Timeline
Jan 7, 2010:
- 11:56 PM Changeset in webkit [52976] by
-
- 2 edits in trunk/WebKitTools
Run the http and websocket tests after all other tests.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Darin Adler.
- Scripts/run-webkit-tests:
- 11:41 PM Changeset in webkit [52975] by
-
- 2 edits in trunk/JavaScriptCore
Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
https://bugs.webkit.org/show_bug.cgi?id=33311
Reviewed by Gavin Barraclough.
Move compileGetDirectOffset function to common part of JSVALUE32
- jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
- 11:08 PM Changeset in webkit [52974] by
-
- 5 edits in trunk
2010-01-07 Mike Belshe <mbelshe@chromium.org>
Reviewed by Darin Adler.
Fix Spdy casing to match style guide.
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::wasFetchedViaSPDY): (WebCore::ResourceResponse::setWasFetchedViaSPDY):
2010-01-07 Mike Belshe <mbelshe@chromium.org>
Reviewed by Darin Adler.
Fix Spdy casing to match style guide.
- public/WebURLResponse.h:
- src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasFetchedViaSPDY): (WebKit::WebURLResponse::setWasFetchedViaSPDY):
- 10:54 PM Changeset in webkit [52973] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-07 Laszlo Gombos <Laszlo Gombos>
Reviewed by Maciej Stachowiak.
Allow call sites to determine if ASSERT_* and LOG_* macros are operational
https://bugs.webkit.org/show_bug.cgi?id=33020
- wtf/Assertions.h: Set ASSERT_MSG_DISABLED, FATAL_DISABLED, ERROR_DISABLED, LOG_DISABLED to 1 if the compiler does not support variadic macros. Refactor for better readibility.
- 10:16 PM Changeset in webkit [52972] by
-
- 14 edits in trunk
2010-01-07 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Added ENABLE_XHTMLMP flag. Disabled by default.
- Configurations/FeatureDefines.xcconfig:
2010-01-07 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Added ENABLE_XHTMLMP flag. Disabled by default.
- features.gypi:
2010-01-07 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Added ENABLE_XHTMLMP flag. Disabled by default.
- Configurations/FeatureDefines.xcconfig:
2010-01-07 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Added ENABLE_XHTMLMP flag. Disabled by default.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- config.h:
2010-01-07 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Added ENABLE_XHTMLMP flag. Disabled by default.
- configure.ac:
- 9:54 PM Changeset in webkit [52971] by
-
- 2 edits in trunk/LayoutTests
2010-01-07 Afonso R. Costa Jr. <afonso.costa@openbossa.org>
Reviewed by Darin Adler.
As the bug https://bugs.webkit.org/show_bug.cgi?id=30034 is fixed,
the zoomOrNot argument is unnecessary.
- fast/dom/elementFromPoint-relative-to-viewport.html:
- 9:47 PM Changeset in webkit [52970] by
-
- 3 edits1 add in trunk/JavaScriptCore
2010-01-07 Laszlo Gombos <Laszlo Gombos>
Reviewed by Gavin Barraclough.
[Symbian] Port ARM traditional JIT Trampolines to RVCT
https://bugs.webkit.org/show_bug.cgi?id=30552
Take the GCC implementation and mechanically convert
it to RVCT syntax.
Use 'bx rX' instead of 'mov pc, rX' when it is available.
Developed in cooperation with Iain Campbell and Gabor Loki.
- JavaScriptCore.pri: Extra step to generate RVCT stubs. The script generation intentionally executed all the time not just for RVCT targets.
- create_rvct_stubs: Added. Perl script to expand precompiler macros for RVCT assembler - the template is defined in JITStubs.cpp.
- jit/JITStubs.cpp: (JSC::ctiTrampoline): (JSC::ctiVMThrowTrampoline): (JSC::ctiOpThrowNotCaught):
- 9:12 PM Changeset in webkit [52969] by
-
- 2 edits in trunk/WebKitTools
2010-01-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix some test-webkitpy expectations
https://bugs.webkit.org/show_bug.cgi?id=33345
I forgot to change these when I added the CheckStyle step.
- Scripts/webkitpy/commands/upload_unittest.py:
- 8:58 PM Changeset in webkit [52968] by
-
- 3 edits in trunk/WebKitTools
2010-01-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
https://bugs.webkit.org/show_bug.cgi?id=33341
Fix this by moving to the root directory before editing ChangeLogs.
There is a related bug with CheckStyle.
- Scripts/webkitpy/steps/checkstyle.py:
- Scripts/webkitpy/steps/editchangelog.py:
- 7:06 PM Changeset in webkit [52967] by
-
- 6 edits in trunk/WebCore
Rolled out http://trac.webkit.org/changeset/52778 due to rolling
out http://trac.webkit.org/changeset/52756
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
- editing/SelectionController.cpp:
(WebCore::SelectionController::layout):
(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::invalidateCaretRect):
(WebCore::SelectionController::paintCaret):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::attach):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attach):
- page/Frame.cpp:
(WebCore::Frame::revealSelection):
- 6:51 PM Changeset in webkit [52966] by
-
- 2 edits in trunk/WebKitTools
2010-01-07 Eric Seidel <eric@webkit.org>
Reviewed by Nikolas Zimmermann.
media/unsupported-tracks.html is failing on Snow Leopard Release bot
https://bugs.webkit.org/show_bug.cgi?id=32339
This is a speculative fix. I do not have a Snow Leopard machine to test on
and I've not seen mention of someone being able to reproduce this locally.
Prevent watchdog timer from firing after a test completes but before
the next one starts, causing the error to appear in the next test.
- DumpRenderTree/mac/DumpRenderTree.mm: (dump): Stop the watchdog before printing #EOF for the test content. We only need to care about the JavaScript of the test running too long or some hang in WebCore. Any other failures will be covered by the calling script's own watchdog timer.
- 6:22 PM Changeset in webkit [52965] by
-
- 2 edits in trunk/WebKitTools
2010-01-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue is stuck spinning due to exception
https://bugs.webkit.org/show_bug.cgi?id=33358
- Scripts/webkitpy/commands/queues.py:
- Don't try to stringify the exception.
- 5:56 PM Changeset in webkit [52964] by
-
- 7 edits2 deletes in trunk
Rollout http://trac.webkit.org/changeset/52756 due to a large performance regression.
WebCore:
- dom/Document.cpp:
(WebCore::Document::updateLayout):
- editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController):
(WebCore::SelectionController::setSelection):
- editing/SelectionController.h:
- page/Frame.cpp:
(WebCore::Frame::setCaretVisible):
(WebCore::Frame::selectionLayoutChanged):
(WebCore::Frame::caretBlinkTimerFired):
(WebCore::Frame::selectionBounds):
- page/FrameView.cpp:
(WebCore::FrameView::needsLayout):
LayoutTests:
- fast/forms/selection-layout-reentry-strange-case-expected.txt: Removed.
- fast/forms/selection-layout-reentry-strange-case.html: Removed.
- 4:57 PM Changeset in webkit [52963] by
-
- 2 edits in trunk/WebKit/mac
More build fix.
- WebKitPrefix.h: Define JS_EXPORTCLASS here, as well (as empty).
- 4:44 PM Changeset in webkit [52962] by
-
- 4 edits in trunk
Fix a crash seen on the buildbots.
Reviewed by Sam Weinig.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Disable specific function tracking here,
instead of in WebCore, to ensure that the disabling happens before a
specific function can be registered.
WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase): Don't disable specific
function tracking here; it's too late, as some specific functions
may already have been tracked in the base class constructor.
- 4:43 PM Changeset in webkit [52961] by
-
- 2 edits in trunk/JavaScriptCore
Mac build fix.
- JavaScriptCore.exp: Export new JSGlobalData static data members.
- 4:36 PM Changeset in webkit [52960] by
-
- 12 edits9 adds in trunk
2010-01-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVGTextElement & friends need to implement svgAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=33284
Implement svgAttributeChanged() for SVGTextElement & SVGTRefElement. As <text> element contain children,
childrenChanged() has to be implemented as well for SVGTextElement.
Simplify SVGTransformable::parseTransformAttribute() code, clearing lists in the beginning
and on error case, after parsing - previously the calling site had to take care of that.
Tests: svg/dynamic-updates/SVGTRefElement-dom-href-attr.html
svg/dynamic-updates/SVGTextElement-dom-transform-attr.html
svg/dynamic-updates/SVGTextElement-svgdom-transform-prop.html
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::parseMappedAttribute):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::svgAttributeChanged):
- svg/SVGTRefElement.h:
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::svgAttributeChanged): (WebCore::SVGTextElement::childrenChanged):
- svg/SVGTextElement.h:
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged):
- svg/SVGTextPositioningElement.h:
- svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute):
- svg/SVGTransformable.h:
- 4:28 PM Changeset in webkit [52959] by
-
- 2 edits in trunk/JavaScriptGlue
Mac build fix.
- config.h: Define JS_EXPORTCLASS for JavaScriptGlue.
- 4:28 PM Changeset in webkit [52958] by
-
- 3 edits1 add in trunk/WebCore
Padding in popup menu gets lost with styled <select> in Windows.
Fixes <rdar://7285538>, and <http://webkit.org/b/33235>.
Reviewed by Adele Peterson.
[Win] Support padding-right on selects when webkit-appearance is off. Added a test
case for narrow selects with -webkit-appearance: none, and padding left and right to
show that both types of padding are honored.
- manual-tests/select-webkit-appearance-off-narrow-select.html: Added.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::calculatePositionAndSize): Use clientPaddingRight instead of a hardcoded constant.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::clientPaddingRight): If webkit-appearance is off, use padding-right instead of
the hardcoded constant.
- 4:24 PM Changeset in webkit [52957] by
-
- 2 edits in trunk/WebKitLibraries
Not reviewed, build fix.
Windows buid fix - disable warning 4251 (class needs to have dll-interface to be used by
clients of another class). WebCore doesn't use all methods of JSString, so
we don't export all classes clients could theoretically access via JSString.
- win/tools/vsprops/common.vsprops:
- 4:15 PM Changeset in webkit [52956] by
-
- 18 edits3 adds in trunk
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=33057
REGRESSION(r49365): typeof(xhr.responseText) != "string" in Windows
<rdar://problem/7296920> REGRESSION: WebKit fails to start PeaceKeeper benchmark
Test: fast/js/webcore-string-comparison.html
In r49365, some code was moved from JSString.cpp to JSString.h, and as a result, WebCore
got a way to directly instantiate JSStrings over DLL borders. Since vftable for JSString was
not exported, objects created from WebCore got a different vptr, and JavaScriptCore
optimizations that relied on vptr of all JSString objects being equal failed.
- config.h: Added a JS_EXPORTCLASS macro for exporting classes. It's currently the same as JS_EXPORTDATA, but it clearly needed a new name.
- runtime/InitializeThreading.cpp: (JSC::initializeThreadingOnce):
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::createNonDefault): (JSC::JSGlobalData::create): (JSC::JSGlobalData::sharedInstance):
- runtime/JSGlobalData.h: Store vptrs just once, no need to repeatedly pick and copy them. This makes it possible to assert vptr correctness in object destructors (which don't have access to JSGlobalData, and even Heap::heap(this) will fail for fake objects created from storeVPtrs()).
- runtime/JSArray.cpp: (JSC::JSArray::~JSArray): Assert that vptr is what we expect it to be. It's important to assert in destructor, because MSVC changes the vptr after constructor is invoked.
- runtime/JSByteArray.cpp: (JSC::JSByteArray::~JSByteArray): Ditto.
- runtime/JSByteArray.h: Ditto.
- runtime/JSFunction.h: Ditto.
- runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction): Ditto.
- runtime/JSCell.h: (JSC::JSCell::setVPtr): Added a method to substitute vptr for another one.
- runtime/JSString.h: Export JSString class together with its vftable, and tell other libraries tp import it. This is needed on platforms that have a separate JavaScriptCore dynamic library - and on Mac, we already did the export via JavaScriptCore.exp. (JSC::JSString::~JSString): Assert tha vptr is what we expect it to be. (JSC::fixupVPtr): Store a previously saved primary vftable pointer (do nothing if building JavaScriptCore itself). (JSC::jsSingleCharacterString): Call fixupVPtr in case this is call across DLL boundary. (JSC::jsSingleCharacterSubstring): Ditto. (JSC::jsNontrivialString): Ditto. (JSC::jsString): Ditto. (JSC::jsSubstring): Ditto. (JSC::jsOwnedString): Ditto.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export the new static JSGlobalData members that are used in WebCore via inline functions.
- 3:51 PM Changeset in webkit [52955] by
-
- 2 edits in trunk/WebCore
Account for scale and current context position (as well as page
position) in the device context world transform passed to
plugins. This is especially important for print surface DPI.
http://bugs.webkit.org/show_bug.cgi?id=32909.
Reviewed by Jon Honeycutt.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintWindowedPluginIntoContext): Revise
world context handling to include scaling and translation
already set for the CTM.
- 3:44 PM Changeset in webkit [52954] by
-
- 2 edits in trunk/WebKitTools
Don't leak a JSStringRef within _accessibilityNotificationCallback.
Reviewed by Jon Honeycutt.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
when it goes out of scope.
- 3:33 PM Changeset in webkit [52953] by
-
- 2 edits in trunk/WebKit/mac
2010-01-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Simon Fraser.
REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't create a selection; drags widget instead ( Translation, Weather, Ski Report )
https://bugs.webkit.org/show_bug.cgi?id=33348
<rdar://problem/7310616>
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): We only want to handle file: URLs for the user stylesheet now, so special-case the DashboardClient's funky user stylesheet URL by mapping it to the equivalent file URL.
- 2:55 PM Changeset in webkit [52952] by
-
- 24 edits in trunk/WebCore
2010-01-07 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Generate V8 bindings header declarations for named and indexed accessors.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- bindings/v8/custom/V8HTMLFormElementCustom.cpp:
- bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
- bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
- bindings/v8/custom/V8NodeListCustom.cpp:
- bindings/v8/custom/V8StorageCustom.cpp:
- bindings/v8/custom/V8StyleSheetListCustom.cpp:
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
- 2:36 PM Changeset in webkit [52951] by
-
- 2 edits in trunk/WebCore
Better build fix: use 'this->structure()', since 'structure' is a
PassRefPtr, and therefore null.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
- 2:27 PM Changeset in webkit [52950] by
-
- 2 edits in trunk/WebCore
Build fix: avoid a name conflict by using the local 'structure' instead
of the member 'structure()'.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
- 2:13 PM Changeset in webkit [52949] by
-
- 7 edits in trunk/WebCore
2010-01-07 Simon Fraser <Simon Fraser>
Build fix.
Add RenderEmbeddedObject.h/cpp to all the build systems.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- 2:07 PM Changeset in webkit [52948] by
-
- 5 edits in trunk
2010-01-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Safari memory usage skyrockets using new Google AdWords interface
https://bugs.webkit.org/show_bug.cgi?id=33343
The memory use was caused by the global object creating too many structures
as it thrashed between different specific functions.
- runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::addAnonymousSlotsTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::despecifyAllFunctions):
- runtime/Structure.h: (JSC::Structure::disableSpecificFunctionTracking): Track a thrash count for specific functions. Disable specific function tracking once the thrash count has been hit.
2010-01-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Safari memory usage skyrockets using new Google AdWords interface
https://bugs.webkit.org/show_bug.cgi?id=33343
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Disabled specific function tracking for the window object, since there's no way to do direct method calls on the window object; they all go through the window shell.
- 1:57 PM Changeset in webkit [52947] by
-
- 46 edits2 copies in trunk
2010-01-07 Simon Fraser <Simon Fraser>
Reviewed by Kevin Decker, Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33338
Create a renderer for <object> and <embed>
Add RenderEmbeddedObject, which derives from RenderPartObject, and is created for <object> and <embed>.
Instances of RenderPartObject are now only allocated for iframes.
Move object/embed-related code from RenderPartObject to RenderEmbeddedObject.
- WebCore.xcodeproj/project.pbxproj: Add RenderEmbeddedObject.h/cpp
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::createRenderer): Create a RenderEmbeddedObject. (WebCore::HTMLEmbedElement::updateWidget): Use toRenderEmbeddedObject()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): Make a RenderEmbeddedObject for the plugin-proxy case. (WebCore::HTMLMediaElement::finishParsingChildren): Use toRenderEmbeddedObject() in the plugin-proxy code.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::createRenderer): Make a RenderEmbeddedObject (WebCore::HTMLObjectElement::updateWidget): Use toRenderEmbeddedObject()
- page/FrameView.h:
- page/FrameView.cpp: (WebCore::FrameView::addWidgetToUpdate): (WebCore::FrameView::removeWidgetToUpdate): (WebCore::FrameView::updateWidgets): Objects in the m_widgetUpdateSet are only ever RenderEmbeddedObjects.
- rendering/RenderEmbeddedObject.cpp: Added.
- rendering/RenderEmbeddedObject.h: Added. Most of the code moved from RenderPartObject.
- rendering/RenderObject.h: (WebCore::RenderObject::isEmbeddedObject): New method.
- rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): Initialize m_hasFallbackContent here, rather than in the derived classes.
- rendering/RenderPart.h: Comments.
- rendering/RenderPartObject.h:
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): Clean up, code moved to base class, and removed object/embed-specific code. (WebCore::RenderPartObject::layout): Removed object/embed-specific code.
- 1:47 PM Changeset in webkit [52946] by
-
- 3 edits in trunk/WebCore
2010-01-07 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33338
Create a renderer for <object> and <embed>
First part of this change: renderPartObject->updateWidget() is a no-op for iframe elements,
so we don't need to call it here, and can thus remove the attach() override entirely.
- html/HTMLIFrameElement.cpp:
- html/HTMLIFrameElement.h:
- 1:36 PM Changeset in webkit [52945] by
-
- 7 edits4 adds in trunk/WebCore
2009-01-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Migrate to canvas-based text viewer / editor that scales.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/JavaScriptHighlighterScheme.js: Added. (WebInspector.JavaScriptHighlighterScheme):
- inspector/front-end/KeyboardShortcut.js:
- inspector/front-end/TextEditor.js: Added. (WebInspector.TextEditor): (WebInspector.TextSelectionModel): (WebInspector.TextCursor):
- inspector/front-end/TextEditorHighlighter.js: Added. (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._lex):
- inspector/front-end/TextEditorModel.js: Added. (WebInspector.TextRange): (WebInspector.TextRange.prototype.clone): (WebInspector.TextEditorModel):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- 1:32 PM Changeset in webkit [52944] by
-
- 5 edits3 adds in trunk
2010-01-07 Christian Sejersen <Christian Sejersen>
Reviewed by Darin Adler.
document.title does not replace or remove space characters
https://bugs.webkit.org/show_bug.cgi?id=27032
- fast/dom/Document/document-title-get-expected.txt: Added.
- fast/dom/Document/document-title-get.html: Added.
- fast/dom/Document/script-tests/document-title-get.js: Added.
2010-01-07 Christian Sejersen <Christian Sejersen>
Reviewed by Darin Adler.
document.title does not replace or remove space characters
https://bugs.webkit.org/show_bug.cgi?id=27032
Test: fast/dom/Document/document-title-get.html
- dom/Document.cpp: (WebCore::Document::Document): Initialization of m_rawTitle (WebCore::canonicalizedTitle): Moved from DocumentLoader.cpp with minor edits (WebCore::Document::updateTitle): Ensures the title is canonicalized (WebCore::Document::setTitle): Uses m_rawTitle instaed of m_title (WebCore::Document::removeTitle): Uses m_rawTitle instead of m_title
- dom/Document.h: Added m_rawTitle that stores the passed in title, m_title now stores the canonicalized title
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setTitle): The title passed in is now canonicalized in Document.cpp
- 12:58 PM Changeset in webkit [52943] by
-
- 3 edits2 adds in trunk
2010-01-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Allow leading/trailing space for CSS nth-*() and lang().
https://bugs.webkit.org/show_bug.cgi?id=17248
For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
See the bug comments for why we don't allow space at other places.
- fast/css/css3-space-in-nth-and-lang.html: Added.
- platform/mac/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
2010-01-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Allow leading/trailing space for CSS nth-*() and lang().
https://bugs.webkit.org/show_bug.cgi?id=17248
For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
See the bug comments for why we don't allow space at other places.
- css/CSSGrammar.y:
- 12:26 PM Changeset in webkit [52942] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=33331
(WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to NetscapePluginHostManager when instantiating plug-ins)
- Plugins/Hosted/NetscapePluginHostManager.h: Modify method signature for instantiatePlugin to include acceleratedCompositingEnabled bool.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): Pass accelerated compositing status to NetscapePluginHostManage
- 12:24 PM Changeset in webkit [52941] by
-
- 3 edits2 adds in trunk
AX: contentEditable DIVs are not AX accessible
https://bugs.webkit.org/show_bug.cgi?id=33325
Reviewed by Beth Dakin.
WebCore:
Test: accessibility/contenteditable-hidden-div.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::canSetValueAttribute):
LayoutTests:
- accessibility/contenteditable-hidden-div-expected.txt: Added.
- accessibility/contenteditable-hidden-div.html: Added.
- 12:20 PM Changeset in webkit [52940] by
-
- 2 edits in trunk/LayoutTests
2010-01-07 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Skip LayoutTests/http/tests/media/video-error-abort.html
- platform/gtk/Skipped:
- 12:18 PM Changeset in webkit [52939] by
-
- 2 edits in trunk/WebKitTools
- 12:08 PM Changeset in webkit [52938] by
-
- 2 edits in trunk/WebCore
2010-01-07 Adam Barth <abarth@webkit.org>
Unreviewed. Resolve merge conflict.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setContextDebugId):
- 12:00 PM Changeset in webkit [52937] by
-
- 12 edits in trunk
2010-01-07 Adam Barth <abarth@webkit.org>
No review, rolling out r52847.
http://trac.webkit.org/changeset/52847
https://bugs.webkit.org/show_bug.cgi?id=33232
Might have caused a perf regression. I'm rolling this out to see if it
heals the perf bot.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::updateDocument):
- bindings/v8/ScriptController.h:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
- bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::~V8Proxy): (WebCore::V8Proxy::handleOutOfMemory): (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::currentContext): (WebCore::V8Proxy::setContextDebugId):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::windowShell):
- bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::adjustedContext):
2010-01-07 Adam Barth <abarth@webkit.org>
No review, rolling out r52847.
http://trac.webkit.org/changeset/52847
https://bugs.webkit.org/show_bug.cgi?id=33232
Might have caused a perf regression.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
- 11:45 AM Changeset in webkit [52936] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in skiplist by this commit.
- platform/mac/Skipped:
- 11:41 AM Changeset in webkit [52935] by
-
- 2 edits in trunk/LayoutTests
2010-01-07 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Add executable bit to video-throttled-load cgi.
- http/tests/media/video-throttled-load.cgi: Added property svn:executable.
- 11:25 AM Changeset in webkit [52934] by
-
- 2 edits in trunk/WebKitTools
Unreviewed. Fix the Mac bots. Why is there no HTTPD PID file?
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
- Scripts/run-webkit-tests:
- 10:48 AM Changeset in webkit [52933] by
-
- 2 edits in trunk/WebCore
Build fix
- WebCore.xcodeproj/project.pbxproj: Made TypesettingFeatures.h private.
- 10:33 AM Changeset in webkit [52932] by
-
- 2 edits in trunk/WebKitTools
Store HTTPD PID in a variable to fix warnings if for some reason the pidfile gets deleted before httpd terminates.
This should fix the occasional warnings for uninitialized values on the Mac bots.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Alexey Proskuryakov.
- Scripts/run-webkit-tests:
- 10:28 AM Changeset in webkit [52931] by
-
- 9 edits1 add in trunk/WebCore
Added Font::typesettingFeatures() and deployed it
Reviewed by Sam Weinig.
No change in funcitonality
- WebCore.xcodeproj/project.pbxproj: Added TypesettingFeatures.h.
- platform/graphics/Font.h:
(WebCore::Font::typesettingFeatures): Added. Determines the typesetting
features from the text redndering mode.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::canUseGlyphCache): Use typesettingFeatures().
- platform/graphics/SimpleFontData.h:
- platform/graphics/TypesettingFeatures.h: Added.
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::disableLigatures): Take TypesettingFeatures instead of
TextRenderingMode.
(WebCore::initializeATSUStyle): Ditto.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
Use typesettingFeatures().
- platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
Ditto.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes): Take
TypesettingFeatures instead of TextRenderingMode.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak): Use TypesettingFeatures().
- 10:08 AM Changeset in webkit [52930] by
-
- 2 edits in trunk/WebCore
2010-01-07 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r52900.
http://trac.webkit.org/changeset/52900
https://bugs.webkit.org/show_bug.cgi?id=30055
Broke over 30 SVG pixel tests.
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- 9:45 AM Changeset in webkit [52929] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] The library version number of the first package release is 4.7.0.
- WebCore.pro:
- 9:36 AM QtWebKitBackportingFixes edited by
- (diff)
- 9:33 AM QtWebKitBackportingFixes edited by
- (diff)
- 9:31 AM QtWebKitBackportingFixes edited by
- (diff)
- 9:29 AM Changeset in webkit [52928] by
-
- 6 edits in trunk
[Qt] Allow the application to override online/offline network status
https://bugs.webkit.org/show_bug.cgi?id=32684
Patch by Yael Aharon <yael.aharon@nokia.com> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.
WebCore:
Added API to NetworkStateNotifier for forcing network status.
- platform/network/NetworkStateNotifier.h:
- platform/network/qt/NetworkStateNotifierPrivate.h:
- platform/network/qt/NetworkStateNotifierQt.cpp:
(WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifierPrivate::onlineStateChanged):
(WebCore::NetworkStateNotifierPrivate::networkAccessPermissionChanged):
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::setNetworkAccessAllowed):
WebKit/qt:
Add a setting so that applications can overide the network status.
Applications that use this setting still need to block network access
through QNAM.
- Api/qwebsettings.cpp:
(qt_networkAccessAllowed):
- 9:26 AM Changeset in webkit [52927] by
-
- 2 edits in trunk/LayoutTests
Unreviewed typo fix.
- platform/gtk/Skipped: missing "l" suffix added to fast/repaint/subtree-layoutstate-transform.html
- 9:14 AM Changeset in webkit [52926] by
-
- 2 edits in trunk/WebCore
prospective bearer management build fix to get the include path correct
- 8:52 AM QtWebKitBackportingFixes edited by
- (diff)
- 8:52 AM QtWebKitBackportingFixes edited by
- (diff)
- 8:38 AM Changeset in webkit [52925] by
-
- 2 edits in trunk/LayoutTests
2010-01-07 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=33323
Skip new test on Tiger for now.
- platform/mac-tiger/Skipped:
- 8:22 AM Changeset in webkit [52924] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Enable JIT in debug mode on win32 after r51141 fixed the crashes.
Reviewed by Simon Hausmann.
- JavaScriptCore.pri:
- 8:02 AM Changeset in webkit [52923] by
-
- 4 edits2 moves in trunk
2010-01-07 Eric Carlson <eric.carlson@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=33272
'abort' event still fired as a progress event
rdar://6710625
Test media/video-error-abort.html doesn't work
Test: http/tests/media/video-error-abort.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::scheduleEvent): Incorporate code from enqueueEvent. (WebCore::HTMLMediaElement::loadInternal): Fix 'abort' event firing logic missed in https://bugs.webkit.org/show_bug.cgi?id=30513. Change order of initialization to match spec wording.
- html/HTMLMediaElement.h: Remove enqueueEvent prototype.
2010-01-07 Eric Carlson <eric.carlson@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=33272
'abort' event still fired as a progress event
rdar://6710625
Test media/video-error-abort.html doesn't work
- http/tests/media/video-error-abort-expected.txt: Copied from LayoutTests/media/video-error-abort-expected.txt.
- http/tests/media/video-error-abort.html: Copied from LayoutTests/media/video-error-abort.html.
Modified to run with slow loading cgi, add test to ensure that 'abort' event is not a
progress event.
- media/video-error-abort-expected.txt: Removed.
- media/video-error-abort.html: Removed.
- 7:48 AM QtWebKitBackportingFixes edited by
- (diff)
- 6:37 AM Changeset in webkit [52922] by
-
- 9 edits in trunk
2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Antti Koivisto.
Wrong state and TouchLists in TouchEvents
https://bugs.webkit.org/show_bug.cgi?id=32878
Touch event tests changed to match the API and semantics of iPhone and
Android. Each new touch point press dispatches a touchstart event with
the pressed touch point(s) in the changedTouches list, and a release
dispatches a touchend event with the released touch point(s) in
changedTouches. Moved points dispatch a touchmove event, with the moved
points in changedTouches. Old behaviour emitted only one touchstart when
the first point was pressed and one touchend when the last point was
released, and any events in between were touchmoves. New presses or
releases could only be detected by comparing the lists touches and
changedTouches.
- fast/events/basic-touch-events-expected.txt:
- fast/events/script-tests/basic-touch-events.js: (singleTouchSequence): (multiTouchSequence):
2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Antti Koivisto.
Wrong state and TouchLists in TouchEvents
https://bugs.webkit.org/show_bug.cgi?id=32878
Touch events changed to match the API and semantics of iPhone and
Android. Each new touch point press dispatches a touchstart event with
the pressed touch point(s) in the changedTouches list, and a release
dispatches a touchend event with the released touch point(s) in
changedTouches. Moved points dispatch a touchmove event, with the moved
points in changedTouches. Old behaviour emitted only one touchstart when
the first point was pressed and one touchend when the last point was
released, and any events in between were touchmoves. New presses or
releases could only be detected by comparing the lists touches and
changedTouches.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
- page/EventHandler.h:
2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Antti Koivisto.
Wrong state and TouchLists in TouchEvents
https://bugs.webkit.org/show_bug.cgi?id=32878
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::touchStart): (EventSender::touchEnd): (EventSender::clearTouchPoints):
- DumpRenderTree/qt/EventSenderQt.h:
- 5:43 AM Changeset in webkit [52921] by
-
- 105 edits3 deletes in trunk
2010-01-07 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Remove COM code generation stuff.
https://bugs.webkit.org/show_bug.cgi?id=32854
Remove the followings:
- CodeGeenratorCOM.pm, COM code generator,
"#if !defined(LANGUAGE_COM) !LANGUAGE_COM" in IDL files, and - UUID attributes in IDL files.
- bindings/scripts/CodeGeneratorCOM.pm: Removed.
- css/CSSCharsetRule.idl:
- css/CSSFontFaceRule.idl:
- css/CSSImportRule.idl:
- css/CSSMediaRule.idl:
- css/CSSPageRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleRule.idl:
- css/CSSStyleSheet.idl:
- css/CSSUnknownRule.idl:
- css/CSSValue.idl:
- css/CSSValueList.idl:
- css/Counter.idl:
- css/MediaList.idl:
- css/RGBColor.idl:
- css/Rect.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- css/WebKitCSSKeyframeRule.idl:
- css/WebKitCSSKeyframesRule.idl:
- css/WebKitCSSTransformValue.idl:
- dom/Attr.idl:
- dom/CDATASection.idl:
- dom/CharacterData.idl:
- dom/Comment.idl:
- dom/DOMImplementation.idl:
- dom/Document.idl:
- dom/DocumentFragment.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- dom/Entity.idl:
- dom/EntityReference.idl:
- dom/Event.idl:
- dom/EventListener.idl:
- dom/EventTarget.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeList.idl:
- dom/Notation.idl:
- dom/ProcessingInstruction.idl:
- dom/Text.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLAppletElement.idl:
- html/HTMLAreaElement.idl:
- html/HTMLBRElement.idl:
- html/HTMLBaseElement.idl:
- html/HTMLBaseFontElement.idl:
- html/HTMLBlockquoteElement.idl:
- html/HTMLBodyElement.idl:
- html/HTMLButtonElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLCollection.idl:
- html/HTMLDListElement.idl:
- html/HTMLDirectoryElement.idl:
- html/HTMLDivElement.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFieldSetElement.idl:
- html/HTMLFontElement.idl:
- html/HTMLFormElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLFrameSetElement.idl:
- html/HTMLHRElement.idl:
- html/HTMLHeadElement.idl:
- html/HTMLHeadingElement.idl:
- html/HTMLHtmlElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLIsIndexElement.idl:
- html/HTMLLIElement.idl:
- html/HTMLLabelElement.idl:
- html/HTMLLegendElement.idl:
- html/HTMLLinkElement.idl:
- html/HTMLMapElement.idl:
- html/HTMLMarqueeElement.idl:
- html/HTMLMenuElement.idl:
- html/HTMLMetaElement.idl:
- html/HTMLModElement.idl:
- html/HTMLOListElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOptGroupElement.idl:
- html/HTMLOptionElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLParagraphElement.idl:
- html/HTMLParamElement.idl:
- html/HTMLPreElement.idl:
- html/HTMLQuoteElement.idl:
- html/HTMLScriptElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLStyleElement.idl:
- html/HTMLTableCaptionElement.idl:
- html/HTMLTableCellElement.idl:
- html/HTMLTableColElement.idl:
- html/HTMLTableElement.idl:
- html/HTMLTableRowElement.idl:
- html/HTMLTableSectionElement.idl:
- html/HTMLTextAreaElement.idl:
- html/HTMLTitleElement.idl:
- html/HTMLUListElement.idl:
2010-01-07 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Remove COM code generation files.
https://bugs.webkit.org/show_bug.cgi?id=32854
- WebKit.vcproj/DerivedSources.make: Removed.
- WebKit.vcproj/build-generated-files.sh: Removed.
- 5:15 AM Changeset in webkit [52920] by
-
- 1 edit in trunk/JavaScriptCore/jit/JIT.cpp
Unreviewed build fix for Qt on Mac OS X
- 4:16 AM Changeset in webkit [52919] by
-
- 3 edits in trunk/WebCore
Android requires ability to increase layout delay
- 4:13 AM Changeset in webkit [52918] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Holger Freyther.
[Mac] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
https://bugs.webkit.org/show_bug.cgi?id=33312
Using of operator += cause compile error on Mac, so it is changed to
"= static_cast<AllocAlignmentInteger*>(old_ptr) + 1".
- wtf/FastMalloc.cpp: (WTF::TCMallocStats::realloc):
- 4:12 AM Changeset in webkit [52917] by
-
- 2 edits in trunk/WebKitTools
Reworked r52853 after r52876 rolled it out.
Chomp the pid variable before passing it to kill and read the contents of
the pidfile in a platform independent manner.
First pach of https://bugs.webkit.org/show_bug.cgi?id=33153.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.
- Scripts/run-webkit-tests:
- 3:50 AM Changeset in webkit [52916] by
-
- 2 edits1 add in trunk/WebKitTools
2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Adam Barth.
Created a module that runs the style package unit tests.
- Scripts/test-webkitpy:
- Scripts/webkitpy/style/unittests.py: Added.
- 3:44 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:40 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:35 AM Changeset in webkit [52915] by
-
- 4 edits in trunk/WebCore
2010-01-07 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Some IDL files lack "," separators for extended attributes.
https://bugs.webkit.org/show_bug.cgi?id=33190
To find such mistakes, IDLParser.pm rejects whitespace characters in
extended attribute names.
- bindings/scripts/IDLParser.pm: parseExtendedAttributes rejects whitespace in a name.
- css/WebKitCSSTransformValue.idl: Add missing ",".
- dom/EventTarget.idl: ditto.
- 3:29 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:26 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:24 AM Changeset in webkit [52914] by
-
- 2 edits in trunk/WebKit/qt
[Qt] need an API to suspend and resume active Javascript DOM objects.
https://bugs.webkit.org/show_bug.cgi?id=31673
Patch by Yongjun Zhang <yongjun.zhang@nokia.com>, Laszlo Gombos <Laszlo Gombos> on 2010-01-07
Reviewed by Simon Hausmann.
Add suspend and resume DOM objects private API to QWebFrame.
- Api/qwebframe.cpp:
(qt_suspendActiveDOMObjects):
(qt_resumeActiveDOMObjects):
- 2:52 AM Changeset in webkit [52913] by
-
- 2 edits in trunk/WebCore
2010-01-07 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
WebKitCSSTransformValue.idl correctly.
https://bugs.webkit.org/show_bug.cgi?id=33193
CodeGeneratorV8.pm doesn't handle inheritance very well and it
tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
which does not exist. Because WebKitCSSTransformValue inherits
CSSValueList and CSSValueList already has HadIndexGetter, we don't
need to do anything for WebKitCSSTransformValue about HasIndexGetter.
- bindings/scripts/CodeGeneratorV8.pm: Reset $hasGetter for WebKitCSSTransformValue.
- 2:22 AM Changeset in webkit [52912] by
-
- 2 edits in trunk/WebKitTools
2010-01-07 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Don't print a redundant message when confirming a diff
https://bugs.webkit.org/show_bug.cgi?id=33315
Instead of saying "ERROR: User declined" we should just exit because
the use knows they just declined!
- Scripts/webkitpy/steps/confirmdiff.py:
- 2:19 AM Changeset in webkit [52911] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Holger Freyther.
[Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
https://bugs.webkit.org/show_bug.cgi?id=33312
Remove pByte (committed in r42344 from #20422), because pByte doesn't
exist and it is unnecessary.
- wtf/FastMalloc.cpp: (WTF::TCMallocStats::realloc):
- 2:12 AM Changeset in webkit [52910] by
-
- 4 edits in trunk/WebKitTools
2010-01-07 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Check style before uploading a patch
https://bugs.webkit.org/show_bug.cgi?id=33314
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/steps/checkstyle.py:
- Scripts/webkitpy/steps/options.py:
- 1:51 AM Changeset in webkit [52909] by
-
- 2 edits in trunk/WebKitTools
2010-01-07 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Add prepare and post to webkit-patch main help
https://bugs.webkit.org/show_bug.cgi?id=33313
- Scripts/webkitpy/commands/upload.py:
- 12:57 AM Changeset in webkit [52908] by
-
- 3 edits in trunk/WebKitTools
2010-01-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
https://bugs.webkit.org/show_bug.cgi?id=33290
Add the Chromium builders to our list of core builders and test that our regexps work.
I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
- Scripts/webkitpy/buildbot.py:
- Scripts/webkitpy/buildbot_unittest.py:
- 12:49 AM Changeset in webkit [52907] by
-
- 13 edits1 move in trunk/WebKitTools
2010-01-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool needs a new name
https://bugs.webkit.org/show_bug.cgi?id=28459
Rename bugzilla-tool to webkit-patch. Also, rename some commands to
make more sense with the new name.
- Scripts/bugzilla-tool: Removed.
- Scripts/webkit-patch: Added.
- Scripts/webkit-tools-completion.sh:
- Scripts/webkitpy/bugzilla_unittest.py:
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/download_unittest.py:
- Scripts/webkitpy/commands/early_warning_system.py:
- Scripts/webkitpy/commands/queries.py:
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/commands/queues_unittest.py:
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/commands/upload_unittest.py:
- Scripts/webkitpy/queueengine.py:
- Scripts/webkitpy/steps/completerollout.py:
- 12:36 AM Changeset in webkit [52906] by
-
- 3 edits6 moves1 add in trunk/WebKitTools
2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Eric Seidel.
Moved style-related modules to webkitpy.style sub-package.
- Scripts/check-webkit-style:
- Updated import statement.
- Scripts/test-webkitpy:
- Updated import statements.
- Scripts/webkitpy/cpp_style.py: Removed.
- Moved to webkitpy/style.
- Scripts/webkitpy/cpp_style_unittest.py: Removed.
- Moved to webkitpy/style.
- Scripts/webkitpy/style.py: Removed.
- Moved to webkitpy/style/checker.py.
- Scripts/webkitpy/style/init.py: Added.
- Added containing webkitpy directory to package search path.
- Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
- Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
- Updated import statement.
- Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
- Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
- Update import statement.
- Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
- Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
- Scripts/webkitpy/style_unittest.py: Removed.
- Moved to webkitpy/style/checker_unittest.py.
- Scripts/webkitpy/text_style.py: Removed.
- Moved to webkitpy/style.
- Scripts/webkitpy/text_style_unittest.py: Removed.
- Moved to webkitpy/style.
- 12:22 AM Changeset in webkit [52905] by
-
- 2 edits in trunk/WebCore
2010-01-07 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Do not return strings whose handles are in near death state (that means
they might be GCed) or just empty.
https://bugs.webkit.org/show_bug.cgi?id=31180
- bindings/v8/V8Binding.cpp: (WebCore::v8ExternalString):
- 12:06 AM Changeset in webkit [52904] by
-
- 18 edits4 adds in trunk
2010-01-06 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG background color on selected text goes wrong when text has
gradient stroke.
https://bugs.webkit.org/show_bug.cgi?id=33069
Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
and paint background and foreground in separate subphase.
- svg/text/selection-background-color.xhtml: Added.
- platform/mac/svg/text/selection-background-color-expected.checksum: Added.
- platform/mac/svg/text/selection-background-color-expected.png: Added.
- platform/mac/svg/text/selection-background-color-expected.txt: Added.
- platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.png:
- platform/mac/svg/batik/text/textDecoration2-expected.checksum:
- platform/mac/svg/batik/text/textDecoration2-expected.png:
- platform/mac/svg/text/text-deco-01-b-expected.checksum:
- platform/mac/svg/text/text-deco-01-b-expected.png:
- platform/mac/svg/text/text-spacing-01-b-expected.checksum:
- platform/mac/svg/text/text-spacing-01-b-expected.png:
- platform/mac/svg/text/text-text-03-b-expected.checksum:
- platform/mac/svg/text/text-text-03-b-expected.png:
- platform/mac/svg/text/text-text-08-b-expected.checksum:
- platform/mac/svg/text/text-text-08-b-expected.png: Re-baselined due to painting algorithm change.
2010-01-06 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG background color on selected text goes wrong when text has
gradient stroke.
https://bugs.webkit.org/show_bug.cgi?id=33069
Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
and paint background and foreground in separate subphase.
Test: svg/text/selection-background-color.xhtml
- rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::SVGTextChunkWalker): Added m_setupBackgroundCallback, m_setupForegroundCallback (WebCore::SVGTextChunkWalker::setupBackground): (WebCore::SVGTextChunkWalker::setupForeground): Added.
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintCharacters): pass SVGTextPaintInfo instead of SVGPaintServer
- rendering/SVGInlineTextBox.h: (WebCore::SVGTextPaintSubphase): (WebCore::SVGTextPaintInfo::SVGTextPaintInfo): Added.
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::walkTextChunks): Invoke setupBackground() and setupForeground() (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupBackgroundCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupForegroundCallback): (WebCore::SVGRootInlineBoxPaintWalker::activePaintServer): Added. (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::SVGRootInlineBox::paint):
Jan 6, 2010:
- 11:07 PM Changeset in webkit [52903] by
-
- 2 edits in trunk/WebKit/qt
2010-01-06 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Return an invalid Qt::ImMicroFocus if queried while the view needs to layout.
- Api/qwebpage.cpp: (QWebPage::inputMethodQuery):
- 10:12 PM Changeset in webkit [52902] by
-
- 7 edits in trunk
2010-01-06 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Remove fast/events/keydown-numpad-key.html from the Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=33250
- platform/qt/Skipped:
2010-01-06 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Make windowsKeyCodeForKeyEvent() return correct key code for
numeric-pad arrow keys.
https://bugs.webkit.org/show_bug.cgi?id=33250
Test: fast/events/keydown-numpad-keys.html
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
2010-01-06 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
[Qt] Support the 3rd argument of EventSender.keyDown that
has been recently added to report keyLocation
(see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
https://bugs.webkit.org/show_bug.cgi?id=33250
Test: fast/events/keydown-numpad-keys.html
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):
- DumpRenderTree/qt/EventSenderQt.h:
- 10:00 PM Changeset in webkit [52901] by
-
- 3 edits in trunk/WebKitTools
2010-01-06 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add long_help for all common commands.
https://bugs.webkit.org/show_bug.cgi?id=33261
For now these long_helps are pretty basic.
These were all written to just explain the steps
that each command runs. This style long_help could
be made easier by using:
https://bugs.webkit.org/show_bug.cgi?id=33257
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/queries.py:
- 9:30 PM Changeset in webkit [52900] by
-
- 2 edits in trunk/WebCore
2009-10-18 Patrick Gansterer <paroga@paroga.com>
Reviewed by Dirk Schulze.
Improve DOM performance in large SVG files.
Check the dirty area before painting a path, which prevents unnecessary
clipping and changes to the GraphicsContext.
https://bugs.webkit.org/show_bug.cgi?id=30055
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- 8:45 PM Changeset in webkit [52899] by
-
- 3 edits in trunk/WebCore
2010-01-06 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Use a static HashMap for HTMLElement::tagPriority().
https://bugs.webkit.org/show_bug.cgi?id=33269
The prior code compares AtomicStringImpl pointers 18 times at
worst. This change avoids it.
No new tests because this is just a refactoring.
- html/HTMLElement.cpp: (WebCore::Empty1IntHashTraits): A HashTraits to return 1 as the empty value. (WebCore::initializeTagPriorityMap): Initialization of a static HashMap. (WebCore::HTMLElement::tagPriority): Use the static HashMap created by initializeTagPriorityMap().
- html/HTMLElement.h: (WebCore::HTMLElement::HTMLElement): Add an assertion about non-null localName().
- 8:06 PM Changeset in webkit [52898] by
-
- 5 edits in trunk
2010-01-06 Mike Belshe <mike@belshe.com>
Add a flag to the ResourceResponse for tracking if a request was
fetched via SPDY. This is plumbed through so that we can inform
a webpage via JavaScript if it was fecthed via the experimental
SPDY protocol.
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::wasFetchedViaSpdy): (WebCore::ResourceResponse::setWasFetchedViaSpdy):
2010-01-06 Mike Belshe <mike@belshe.com>
Add a flag to the ResourceResponse for tracking if a request was
fetched via SPDY. This is plumbed through so that we can inform
a webpage via JavaScript if it was fecthed via the experimental
SPDY protocol.
- public/WebURLResponse.h:
- src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasFetchedViaSpdy): (WebKit::WebURLResponse::setWasFetchedViaSpdy):
- 8:01 PM Changeset in webkit [52897] by
-
- 5 edits in trunk
[Qt] Add page zooming support to Qt DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=32898
Patch by Kim Grönholm <kim.gronholm@nomovok.com>,
Diego Gonzalez <diego.gonzalez@openbossa.org> and
Afonso Costa <afonso.costa@openbossa.org> on 2010-01-06
Reviewed by Kenneth Christiansen.
WebKitTools:
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::zoomPageIn):
(EventSender::zoomPageOut):
- DumpRenderTree/qt/EventSenderQt.h:
LayoutTests:
- platform/qt/Skipped:
- 7:37 PM Changeset in webkit [52896] by
-
- 5 edits in trunk
2010-01-06 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Adam Treat.
[Qt] RenderTheme: Missing support for native sliders
Implement painting of native slider controls in RenderTheme
and unskip a couple of layout tests that are passing after
this change.
- platform/qt/Skipped:
2010-01-06 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Adam Treat.
[Qt] RenderTheme: Missing support for native sliders
Implement painting of native slider controls in RenderTheme
and unskip a couple of layout tests that are passing after
this change.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintSliderTrack): (WebCore::RenderThemeQt::adjustSliderTrackStyle): (WebCore::RenderThemeQt::paintSliderThumb): (WebCore::RenderThemeQt::adjustSliderThumbStyle): (WebCore::RenderThemeQt::supportsFocus): (WebCore::RenderThemeQt::adjustSliderThumbSize):
- platform/qt/RenderThemeQt.h:
- 7:23 PM Changeset in webkit [52895] by
-
- 2 edits in trunk/WebCore
2010-01-06 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Darin Adler.
Adjust incorrect comments after r40534.
- bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext):
- 6:57 PM Changeset in webkit [52894] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix for chromium.
Add "bool V8WorkerContext::WebSocketEnabled()"
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::WebSocketEnabled):
- 6:45 PM Changeset in webkit [52893] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix.
remove wrong assertion
- websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
- 6:33 PM Changeset in webkit [52892] by
-
- 20 edits2 copies9 adds in trunk
2010-01-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin
Add WebSocket feature in Worker
https://bugs.webkit.org/show_bug.cgi?id=32214
- websocket/tests/workers/resources/simple_wsh.py: Copied from LayoutTests/websocket/tests/simple_wsh.py.
- websocket/tests/workers/resources/worker-simple.js: Added.
- websocket/tests/workers/worker-simple-expected.txt: Added.
- websocket/tests/workers/worker-simple.html: Added.
2010-01-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Add WebSocket feature in Worker
https://bugs.webkit.org/show_bug.cgi?id=32214
Introduce ThreadableWebSocketChannel interface and add
WorkerThreadableWebSocketChannel for Worker.
WorkerThreadableWebSocketChannel uses WebSocketChannel in the
main thread, which is managed by Peer and communicated via Bridge.
Test: websocket/tests/workers/worker-simple.html
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebSocketConstructor.h:
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::webSocket):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
- bindings/v8/custom/V8WebSocketCustom.cpp: (WebCore::V8Custom::v8WebSocketConstructorCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
- platform/CrossThreadCopier.cpp: (WebCore::::copy):
- platform/CrossThreadCopier.h: (WebCore::):
- websockets/ThreadableWebSocketChannel.cpp: Added.
- websockets/ThreadableWebSocketChannel.h: Added.
- websockets/ThreadableWebSocketChannelClientWrapper.h: Added.
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect): (WebCore::WebSocket::didReceiveMessage):
- websockets/WebSocket.h:
- websockets/WebSocketChannel.h: (WebCore::WebSocketChannel::refThreadableWebSocketChannel): (WebCore::WebSocketChannel::derefThreadableWebSocketChannel):
- websockets/WebSocketChannelClient.h:
- websockets/WebSocketHandshake.h:
- websockets/WorkerThreadableWebSocketChannel.cpp: Added.
- websockets/WorkerThreadableWebSocketChannel.h: Added.
- workers/WorkerContext.idl:
- 6:20 PM Changeset in webkit [52891] by
-
- 7 edits in trunk
2010-01-06 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Darin Adler.
Modified EventSource event-stream parser to support a single CR as line ending.
Updated test accordingly.
https://bugs.webkit.org/show_bug.cgi?id=33207
- http/tests/eventsource/eventsource-parse-event-stream-expected.txt:
- http/tests/eventsource/eventsource-parse-event-stream.html:
- http/tests/eventsource/resources/event-stream.php:
2010-01-06 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Darin Adler.
Modified EventSource event-stream parser to support a single CR as line ending.
https://bugs.webkit.org/show_bug.cgi?id=33207
- page/EventSource.cpp: (WebCore::EventSource::EventSource): (WebCore::EventSource::parseEventStream):
- page/EventSource.h:
- 6:05 PM Changeset in webkit [52890] by
-
- 5 edits in trunk
2010-01-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getInterfaceMaskFromObject): (getPangoLayoutForAtk): (webkit_accessible_text_get_text):
- accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
2010-01-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text
- tests/testatk.c (test_webkit_atk_get_text_at_offset): (test_webkit_atk_get_text_at_offset_forms): (test_webkit_atk_get_text_at_offset_newlines):
- 6:04 PM QtWebKitBackportingFixes edited by
- (diff)
- 5:41 PM Changeset in webkit [52889] by
-
- 3 edits4 adds in trunk
<rdar://problem/7488126> With text-rendering: optimizelegibility, sometimes lines run too long
https://bugs.webkit.org/show_bug.cgi?id=32794
Reviewed by Sam Weinig.
WebCore:
Test: platform/mac/fast/text/line-breaking-with-kerning.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak): When kerning is enabled, include
the trailing space when measuring a word, then subtract its width. This
accounts for kerning between the last glyph of the word and the following space.
LayoutTests:
- platform/mac/fast/text/line-breaking-with-kerning-expected.checksum: Added.
- platform/mac/fast/text/line-breaking-with-kerning-expected.png: Added.
- platform/mac/fast/text/line-breaking-with-kerning-expected.txt: Added.
- platform/mac/fast/text/line-breaking-with-kerning.html: Added.
- 5:33 PM Changeset in webkit [52888] by
-
- 2 edits in trunk/LayoutTests
2010-01-06 Eric Seidel <eric@webkit.org>
No review.
REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33256
I am unable to reproduce this failure locally, so this fix is only speculative.
Skip the test we believe is causing the log message which bleeds into fast/workers/shared-worker-constructor.html
- platform/mac/Skipped:
- 5:29 PM Changeset in webkit [52887] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Simon Fraser.
Third step of:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView getVariable:value:]): Add case for WKNVSupportsCompositingCoreAnimationPluginsBool.
- 5:14 PM Changeset in webkit [52886] by
-
- 2 edits in trunk/WebKitTools
2010-01-06 Eric Seidel <eric@webkit.org>
No review, just adding Mike Belshe's new bugzilla email at his request.
- Scripts/webkitpy/committers.py:
- 5:01 PM Changeset in webkit [52885] by
-
- 9 edits in trunk
Reviewed by Simon Fraser
Second step of:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism
- Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginLayer]): Added.
- Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginLayer]): Added. Reviewed by Simon Fraser.
Second step of:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism
- Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginLayer]): Added.
- Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginLayer]): Added.
- 4:50 PM Changeset in webkit [52884] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix screwed up ChangeLog about screwing up... Sigh.
- 4:48 PM Changeset in webkit [52883] by
-
- 2 edits in trunk/LayoutTests
2010-01-06 Eric Seidel <eric@webkit.org>
No review.
REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33256
I am unable to reproduce this failure locally, so this fix is only speculative.
Skip the test we believe is causing the log message which bleeds into fast/workers/shared-worker-constructor.html
- platform/mac/Skipped:
- 4:47 PM Changeset in webkit [52882] by
-
- 6 edits in trunk/WebCore
2010-01-06 Adam Barth <abarth@webkit.org>
No review, rolling out r52877.
http://trac.webkit.org/changeset/52877
https://bugs.webkit.org/show_bug.cgi?id=33243
I screwedd up landing this patch and only partially applied the patch I
was trying to land.
- bindings/ScriptControllerBase.cpp:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorld):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::mainWorldWindowShell): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::clearForClose): (WebCore::ScriptController::destroyWindowShell): (WebCore::ScriptController::updateDocument):
- bindings/v8/ScriptController.h: (WebCore::ScriptController::proxy): (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell): (WebCore::ScriptController::evaluateInWorld):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::create): (WebCore::V8DOMWindowShell::V8DOMWindowShell): (WebCore::V8DOMWindowShell::initContextIfNeeded):
- 4:30 PM Changeset in webkit [52881] by
-
- 3 edits in trunk/LayoutTests
2010-01-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Carlson.
media/video-seeking.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33273
Removed setTimeouts from this test. It kind of looks
like they were intentional, but I don't see how they add
anything to this test (other than race conditions).
- media/video-seeking-expected.txt:
- media/video-seeking.html:
- 4:26 PM Changeset in webkit [52880] by
-
- 2 edits in trunk/WebCore
2010-01-06 Eric Seidel <eric@webkit.org>
Unreviewed. Rolling back in a change I should not have rolled out.
The original commit http://trac.webkit.org/changeset/52862
was rolled out again in http://trac.webkit.org/changeset/52871
but I now believe that rollout to be in error.
My sincerest apologies for the churn.
Fix the bug in previous commit: we shouldn't finish
decoding if "sizeOnly" is true.
https://bugs.webkit.org/show_bug.cgi?id=33258
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode):
- 4:24 PM Changeset in webkit [52879] by
-
- 3 edits in trunk/LayoutTests
2010-01-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
fast/css/transition-color-unspecified.html and fast/dom/HTMLObjectElement/object-as-frame.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=33270
These both rely on setTimeouts where they should be using events.
- fast/css/transition-color-unspecified.html:
- fast/dom/HTMLObjectElement/object-as-frame.html:
- 4:21 PM Changeset in webkit [52878] by
-
- 2 edits in trunk/LayoutTests
2010-01-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
platform/chromium/fast/dom/interval.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33274
We're seeing the debug bots take >100000 microseconds to stop
and Interval.
- platform/chromium/fast/dom/interval.html:
- 4:16 PM Changeset in webkit [52877] by
-
- 6 edits in trunk/WebCore
2010-01-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[v8] Let ScriptController have more than one windowShell
https://bugs.webkit.org/show_bug.cgi?id=33243
This patch lets ScriptController have more than one windowShell. We're
currently only using one of them (for the main world), but this patch
lets us use other ones for isolated worlds soon.
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScriptInWorld):
- bindings/js/ScriptController.cpp:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::createWorld): (WebCore::ScriptController::initScript): (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::mainWorldWindowShell): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::clearForClose): (WebCore::ScriptController::destroyWindowShell): (WebCore::ScriptController::updateDocument):
- bindings/v8/ScriptController.h: (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell): (WebCore::ScriptController::globalObject): (WebCore::ScriptController::proxy):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::create): (WebCore::V8DOMWindowShell::V8DOMWindowShell): (WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
- 3:56 PM Changeset in webkit [52876] by
-
- 2 edits in trunk/WebKitTools
2010-01-06 Eric Seidel <eric@webkit.org>
Unreviewed. Rolling out r52869 and r52853 due to bot
and local run-webkit-test failures
REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33256
The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153
- Scripts/run-webkit-tests:
- 3:20 PM Changeset in webkit [52875] by
-
- 5 edits in trunk
Fix the Mac build.
- WebCore.base.exp: Export symbols WebKit would like to use.
- plugins/PluginWidget.h:
(WebCore::PluginWidget::PluginWidget): Redeclare a constructor.
- 3:09 PM Changeset in webkit [52874] by
-
- 2 edits in trunk/WebKit/mac
Attempt to fix non-Snow Leopard Mac build.
- WebCoreSupport/WebFrameLoaderClient.mm:
- 2:25 PM Changeset in webkit [52873] by
-
- 2 edits in trunk/WebKitTools
2010-01-06 Eric Seidel <eric@webkit.org>
Unreviewed "build" fix. Just adding missing include.
bugzilla-tool rollout --complete-rollout should make a nicer bug comment
https://bugs.webkit.org/show_bug.cgi?id=29212
- Scripts/webkitpy/steps/completerollout.py:
- 2:23 PM Changeset in webkit [52872] by
-
- 5 edits2 adds in trunk
Reviewed by Eric Carlson.
First step toward:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism
Small refactoring moving the PluginWidget class from WebKit to WebCore.
- WebCore.xcodeproj/project.pbxproj: Added new source files and a "mac" group; exposes PluginWidget.h as a "Private" role
- platform/Widget.h: Added isPluginWidget(). (WebCore::Widget::isPluginWidget):
- plugins/PluginWidget.h: Added. (WebCore::PluginWidget::isPluginWidget): Added as an interim solution until Mac plug-ins inheirt from PluginView.
- plugins/mac/PluginWidgetMac.mm: Added. (WebCore::PluginWidget::invalidateRect): Added. Extracted from the old WebKit/FrameLoaderClientMac version of PluginWidget
Reviewed by Eric Carlson.
First step toward:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism
Small refactoring moving the PluginWidget class from WebKit to WebCore.
- WebCoreSupport/WebFrameLoaderClient.mm: Use the WebCore version of PluginWidget.
- 2:20 PM Changeset in webkit [52871] by
-
- 2 edits in trunk/WebCore
2010-01-06 Eric Seidel <eric@webkit.org>
No review, rolling out r52862.
http://trac.webkit.org/changeset/52862
https://bugs.webkit.org/show_bug.cgi?id=33258
Caused svg/W3C-SVG-1.1/linking-a-01-b.svg to crash on the
Leopard Release builder.
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode):
- 2:14 PM Changeset in webkit [52870] by
-
- 4 edits in trunk/WebKitTools
2010-01-06 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool rollout --complete-rollout should make a nicer bug comment
https://bugs.webkit.org/show_bug.cgi?id=29212
- Scripts/webkitpy/bugzilla.py:
- Make reopen_bug robust against the bug already being open.
- Scripts/webkitpy/commands/download.py:
- Remove dead code from Rollout.
- Scripts/webkitpy/steps/completerollout.py:
- Improve the rollout comment.
- 2:12 PM Changeset in webkit [52869] by
-
- 2 edits in trunk/WebKitTools
2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Darin Adler.
Set isHttpdOpen to 0 if pidfile does not exist for some reason.
Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.
- Scripts/run-webkit-tests:
- 2:04 PM Changeset in webkit [52868] by
-
- 2 edits in trunk/WebCore
2010-01-06 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Revert the part of my last commit touching Base.xcconfig, was not meant to be commited.
- Configurations/Base.xcconfig:
- 2:02 PM WebKit Team edited by
- (diff)
- 1:37 PM Changeset in webkit [52867] by
-
- 12 edits1 delete in trunk/WebCore
2010-01-05 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Generate header declarations for V8 binding security checks
and delete V8CustomBinding.cpp
- Android.v8bindings.mk: Removed V8CustomBinding.cpp.
- WebCore.gypi: Removed V8CustomBinding.cpp.
- bindings/scripts/CodeGeneratorV8.pm: Generate security check declarations.
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::getTargetFrame): Moved from V8CustomBinding.cpp. (WebCore::reportUnsafeJavaScriptAccess): (WebCore::V8DOMWindowShell::createNewContext): (WebCore::V8DOMWindowShell::setLocation): Moved from V8CustomBinding.cpp.
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::downcastSVGPathSeg): Moved from V8CustomBinding.cpp. (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::getTemplate):
- bindings/v8/custom/V8CustomBinding.cpp: Removed.
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::locationAccessorSetter): (WebCore::V8DOMWindow::namedSecurityCheck): (WebCore::V8DOMWindow::indexedSecurityCheck):
- bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::V8Document::locationAccessorSetter):
- bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::indexedSecurityCheck): (WebCore::V8History::namedSecurityCheck):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::indexedSecurityCheck): (WebCore::V8Location::namedSecurityCheck):
- 1:26 PM Changeset in webkit [52866] by
-
- 42 edits15 adds in trunk
2010-01-06 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Marker code is buggy: referencePoint translation is off
https://bugs.webkit.org/show_bug.cgi?id=33012
Rewrite marker code, as it had many issues:
- Correct refX/refY handling (covered by new marker-referencePoint.svg test)
- Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
- Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
- Fix SVGResource assuming that there is only one resource per resource type per element. Markers can have three different resources of the same type (three markers, start/mid/end markers)
Filed bug 33115 (PathElementAddQuadCurveToPoint not handled for <marker>), which was just a TODO in the code before.
Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
Test: svg/custom/marker-referencePoint.svg
svg/custom/marker-opacity.svg
svg/custom/marker-strokeWidth-changes.svg
- Android.mk: Add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to build.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- page/FrameView.cpp: Notify RenderSVGRoot children about viewport size changes, just like it's handled for <body> in HTML. (WebCore::FrameView::layout): This is important, as marker bounding boxes may depend on the current viewport size through relative coordinates used in <svg>.
- rendering/RenderPath.cpp: (WebCore::RenderPath::markerBoundingBox): Calculates and caches marker boundaries in the layout() phase. (WebCore::RenderPath::repaintRectInLocalCoordinates): Use the cached marker bounding box during paint() time. (WebCore::RenderPath::setPath): Clear marker boundaries upon path changes. (WebCore::RenderPath::paint): Use SVGMarkerLayoutInfo::drawMarkers() instead of the local drawMarkersIfNeeded() function, which is gone now. (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Utilized by markerBoundingBox() to request SVGResourceMarker objects and calculate their boundaries.
- rendering/RenderPath.h: Store SVGMarkerLayoutInfo objects, and rename m_markerBounds to m_cachedLocalMarkerBBox for consistency. (WebCore::RenderPath::path): Inline this accessor.
- rendering/RenderSVGContainer.h: Make paint() public (to be used from SVGResourceMarker), all other methods protected (to be used from RenderSVGViewportContainer).
- rendering/RenderSVGViewportContainer.cpp: Remove useless paint() override, as the comment in the code indicated. (WebCore::RenderSVGViewportContainer::markerBoundaries): Maps the marker contents repaintRectInLocalCoordinates() into the final coordinate system (see code). (WebCore::RenderSVGViewportContainer::markerContentTransformation): Add marker-specific helper method, allowing to make viewportTransform() private again.
- rendering/RenderSVGViewportContainer.h: Marking viewportTransform() private, it's never meant to be used outside this renderer.
- rendering/SVGMarkerData.h: Added. Refactored from existing RenderPath code, preserving original copyrights. (WebCore::SVGMarkerData::): Helper struct for SVGMarkerLayoutInfo. (WebCore::SVGMarkerData::origin): Holds the final computed destination of a marker. (WebCore::SVGMarkerData::marker): Holds a pointer to the associated SVGResourceMarker object, which we're aiming to layout. (WebCore::SVGMarkerData::currentAngle): Calculates the current angle for a certain marker type (start/mid/end) based upon the computed inslope/outslope values. (WebCore::SVGMarkerData::updateTypeAndMarker): Helper method. (WebCore::SVGMarkerData::updateOutslope): Ditto. (WebCore::SVGMarkerData::updateMarkerDataForPathElement): Does the actual inslope/outslope calculation. (WebCore::SVGMarkerData::updateInslope): Helper method.
- rendering/SVGMarkerLayoutInfo.cpp: Added. New approach to build marker layout info, this time correct during layout() time instead of paint() time. (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo): (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo): (WebCore::processStartAndMidMarkers): Static helper method used to visit each path element in order to calculate inslopes/outslopes (-> orientation angles) (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): Build list of MarkerLayout objects, used to query boundaries, and to paint markers during drawMarkers(). (WebCore::SVGMarkerLayoutInfo::drawMarkers): Cheap method walking existing MarkerLayout vector, drawing the individual RenderSVGViewportContainer of the markers. (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker): Helper method.
- rendering/SVGMarkerLayoutInfo.h: Added. (WebCore::MarkerLayout::MarkerLayout): Helper struct storing a pair of SVGResourceMarker* and a TranformationMatrix. (WebCore::SVGMarkerLayoutInfo::markerData): Public helper methods returning references to private member variables, used from processStartAndMidMarkers. (WebCore::SVGMarkerLayoutInfo::midMarker): Ditto. (WebCore::SVGMarkerLayoutInfo::elementIndex): Ditto.
- svg/SVGMarkerElement.cpp: Adopt to name change: setRef() -> setReferencePoint(). setMarker() -> setRenderer() (WebCore::SVGMarkerElement::~SVGMarkerElement): Remove obsolete detach() hack, fixed by SVGUseElement changes. (WebCore::SVGMarkerElement::canvasResource): Add ASSERT(renderer()) to clarify that canvasResource() is only meant to used after renderer creation.
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::~SVGSVGElement): Remove obsolete detach() hack, fixed by SVGUseElement changes.
- svg/SVGUseElement.cpp: Rework buildPendingResource() to remove SVGSVGElement/SVGMarkerElement detach() hacks (called manually from destructors), see below. (WebCore::SVGUseElement::buildPendingResource): Always detach() the shadow tree root element, before destructing it - this caused the regression with this patch before.
- svg/graphics/SVGResource.cpp: Instead of maintaining a global hashmap between SVGStyledElements and an array of possible SVGResources, use a HashSet of SVGResources
and directly scan the already existing list of clients for a certain SVGResource. This wrong approach has been introduced over two years
ago, making the assumption that there's only one resource type per element. Though markers can provide three resources of the same type
per element (all SVGResourceMarker objects, but in different rules: start/mid/end marker). That information is only available while painting.
(WebCore::resourceSet): Add global static HashSet<SVGResource*>.
(WebCore::SVGResource::SVGResource): Add us to the resourceSet.
(WebCore::SVGResource::~SVGResource): Remove us from resourceSet.
(WebCore::SVGResource::removeClient): Traverse all SVGResource clients and remove the passed SVGStyledElement from the client list (invoked by SVGStyledElement destructor).
(WebCore::SVGResource::addClient): Remove the offending part of the old approach, making the wrong assumption regarding resource types.
- svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::markerTransformation): Create TransformationMatrix in the local marker content (RenderSVGViewportContainer) coordinate system, to position a marker. (WebCore::SVGResourceMarker::draw): Simplify marker drawing a lot: used the passing TransformationMatrix (cached in SVGMarkerLayoutInfo) to draw the marker content renderer. (WebCore::SVGResourceMarker::externalRepresentation): Adopt to refX/refY -> referencePoint changes.
- svg/graphics/SVGResourceMarker.h: Store a FloatPoint m_referecePoint instead of two refX/refY float values. (WebCore::SVGResourceMarker::setRenderer): Renamed from setMarker(). (WebCore::SVGResourceMarker::setReferencePoint): Renamed from setRef(). (WebCore::SVGResourceMarker::referencePoint): New accessor replacing refX() / refY().
- 1:10 PM Changeset in webkit [52865] by
-
- 26 edits in trunk
2010-01-06 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG feImage support
https://bugs.webkit.org/show_bug.cgi?id=31905
This implements the SVG Filter effect feImage with support of fragment urls.
It also includes a bug fix for feComposite. feComposite didn't cover values
bigger than 255 correctly on composite oeprator arithmetic.
Tests: There are already many feImage tests in trunk. They just needed updated
pixel test results.
The feComposite bug is covered by svg/W3C-SVG-1.1/filters-composite-02-b.svg
and depends on feImage.
- platform/graphics/filters/FEComposite.cpp: (WebCore::arithmetic):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- rendering/RenderSVGImage.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource): (WebCore::SVGFEImageElement::parseMappedAttribute): (WebCore::SVGFEImageElement::notifyFinished): (WebCore::SVGFEImageElement::build):
- svg/SVGFEImageElement.h:
- svg/SVGFEImageElement.idl:
- svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::transformRect):
- svg/SVGPreserveAspectRatio.h:
- svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::FEImage): (WebCore::FEImage::create): (WebCore::FEImage::apply):
- svg/graphics/filters/SVGFEImage.h:
2010-01-06 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG feImage support
https://bugs.webkit.org/show_bug.cgi?id=31905
The implementation of feImage requires pixel test result updates of the already
available tests.
There is also an update for svg/filters/feComposite.svg, since the patch also
fixed a bug in feComposite.
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/mac/svg/custom/feDisplacementMap-01-expected.checksum:
- platform/mac/svg/custom/feDisplacementMap-01-expected.png:
- platform/mac/svg/filters/feComposite-expected.checksum:
- platform/mac/svg/filters/feComposite-expected.png:
- platform/mac/svg/webarchive/svg-feimage-subresources-expected.checksum:
- platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
2010-01-06 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG feImage support
https://bugs.webkit.org/show_bug.cgi?id=31905
Update SVG status page. We support feDisplacementMap and feImage now.
- projects/svg/status.xml:
- 12:26 PM Changeset in webkit [52864] by
-
- 1 edit1 add in trunk/LayoutTests
Added file James Robinson provided to go with his fix for
https://bugs.webkit.org/show_bug.cgi?id=32295
- platform/mac/fast/repaint/block-no-inflow-children-expected.png: Added.
- 12:24 PM Changeset in webkit [52863] by
-
- 5 edits in trunk/LayoutTests
Some script tests have wrappers that don't match their templates
https://bugs.webkit.org/show_bug.cgi?id=33239
Reviewed by Eric Seidel.
- fast/dom/StyleSheet/get-stylesheet-byname.html: Updated to use
a standard test wrapper instead of a custom one.
- fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js:
Changed test to not depend on a non-standard wrapper.
- fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Updated
results since I changed the test around.
- platform/mac/editing/selection/script-tests/TEMPLATE.html: Fix
incorrect path in template that broke the test when we called
make-script-test-wrappers.
- 12:15 PM Changeset in webkit [52862] by
-
- 2 edits in trunk/WebCore
2010-01-06 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Fix the bug in previous commit: we shouldn't finish
decoding if "sizeOnly" is true.
https://bugs.webkit.org/show_bug.cgi?id=33258
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode):
- 11:59 AM Changeset in webkit [52861] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Should be last part of Windows Build fix.
- 11:58 AM Changeset in webkit [52860] by
-
- 5 edits in trunk/WebCore
2010-01-06 Eric Seidel <eric@webkit.org>
No review, rolling out r52855.
http://trac.webkit.org/changeset/52855
https://bugs.webkit.org/show_bug.cgi?id=33222
Caused 6 layout tests to fail on Mac
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
- loader/ResourceLoader.cpp:
- loader/ResourceLoader.h:
- 11:51 AM Changeset in webkit [52859] by
-
- 2 edits in trunk/JavaScriptCore
QT build fix.
- runtime/Identifier.cpp:
(JSC::createIdentifierTableSpecific):
- 11:45 AM Changeset in webkit [52858] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix part I.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 11:38 AM Changeset in webkit [52857] by
-
- 2 edits in trunk/JavaScriptCore
Build fix
- runtime/Identifier.cpp:
(JSC::createIdentifierTableSpecificCallback):
- 11:38 AM QtWebKitBackportingFixes edited by
- (diff)
- 11:33 AM Changeset in webkit [52856] by
-
- 20 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=33236
Remove m_identifierTable pointer from UString
Reviewed by Sam Weinig.
Currently every string holds a pointer so that during destruction,
if a string has been used as an identifier, it can remove itself
from the table. By instead accessing the identifierTable via a
thread specific tracking the table associated with the current
globaldata, we can save the memory cost of this pointer.
- API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
- change the API shims to track the identifierTable of the current JSGlobalData.
- API/JSContextRef.cpp:
(JSContextGroupCreate):
- update creation of JSGlobalData for API usage to use new create method.
- fix shim instanciation bug in JSGlobalContextCreateInGroup.
- JavaScriptCore.exp:
- runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
- add asserts to check the identifierTable is being tracked correctly.
- runtime/Identifier.cpp:
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::Identifier::remove):
(JSC::Identifier::checkSameIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):
(JSC::createDefaultDataSpecific):
- Use currentIdentifierTable() instead of UStringImpl::m_identifierTable.
- Define methods to access the thread specific identifier tables.
- runtime/Identifier.h:
(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):
- Declare methods to access the thread specific identifier tables.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::createNonDefault):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):
- creation of JSGlobalData objects, other than for API usage, associate themselves with the current thread.
- runtime/JSGlobalData.h:
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::destroy):
- destroy() method should be using isIdentifier().
- runtime/UStringImpl.h:
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
- replace m_identifierTable with a single m_isIdentifier bit.
- wtf/StringHashFunctions.h:
(WTF::stringHash):
- change string hash result from 32-bit to 31-bit, to free a bit in UStringImpl for m_isIdentifier.
JavaScriptGlue:
Add API shims similar to those used in the JSC API to track the current identifierTable.
- JSBase.cpp:
(JSBase::Release):
- JSUtils.cpp:
(JSObjectKJSValue):
(KJSValueToCFTypeInternal):
(unprotectGlobalObject):
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):
- JSUtils.h:
- JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCopyPropertyNames):
(JSValueWrapper::JSObjectCopyProperty):
(JSValueWrapper::JSObjectSetProperty):
(JSValueWrapper::JSObjectCallFunction):
(JSValueWrapper::JSObjectCopyCFValue):
- JavaScriptGlue.cpp:
(JSRunCreate):
(JSRunEvaluate):
(JSRunCheckSyntax):
(JSCollect):
- JavaScriptGlue.xcodeproj/project.pbxproj:
- UserObjectImp.cpp:
(UserObjectImp::callAsFunction):
- 10:25 AM Changeset in webkit [52855] by
-
- 5 edits in trunk/WebCore
2010-01-06 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Let ReourceLoader deliver segmented data
when loading resource from a SharedBuffer object.
https://bugs.webkit.org/show_bug.cgi?id=33222
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveData):
- loader/ResourceLoader.h:
- 3:14 AM Changeset in webkit [52854] by
-
- 2 edits in trunk/WebCore
Unreviewed trivial Qt build fix.
Prefix the phonon includes with phonon/ to avoid conflicts with the S60
audio routing API ( http://wiki.forum.nokia.com/index.php/Audio_Routing_API ).
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- 2:02 AM Changeset in webkit [52853] by
-
- 2 edits in trunk/WebKitTools
2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
and remove the httpd's pidfile directory if httpd terminated.
- Scripts/run-webkit-tests:
- 12:24 AM Changeset in webkit [52852] by
-
- 2 edits in trunk/WebKit/chromium
2010-01-06 Darin Fisher <darin@chromium.org>
Fix release build bustage.
- src/WebKit.cpp: Need to include Logging.h
