⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 8, 2010:

11:49 PM Changeset in webkit [53038] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-08 Adam Barth <​abarth@webkit.org>

Unreviewed. Fix namespace indent for SecurityOrigin.h.

  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::domainWasSetInDOM): (WebCore::SecurityOrigin::protocol): (WebCore::SecurityOrigin::host): (WebCore::SecurityOrigin::domain): (WebCore::SecurityOrigin::port): (WebCore::SecurityOrigin::canLoadLocalResources): (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::isSandboxed): (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage): (WebCore::SecurityOrigin::):
11:40 PM Changeset in webkit [53037] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-01-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dmitry Titov.

bindings/v8/DOMData is missing a virtual destructor
​https://bugs.webkit.org/show_bug.cgi?id=33390

DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes
but it does not have a virtual destructor. While this isn't currently causing
any leaks, since there are no instances of ChildThreadDOMData or
MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC
compiler generates the following compilation error:

"/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual
functions and accessible non-virtual destructor"

We therefore need to add a virtual destructor to DOMData.

  • bindings/v8/DOMData.cpp: (WebCore::DOMData::~DOMData):
  • bindings/v8/DOMData.h:
11:09 PM Changeset in webkit [53036] by dbates@webkit.org
  • 7 edits in trunk

2010-01-08 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33417

Cleans up style errors exposed by the patch for bug #33198.
Moreover, fixes all "Weird number of spaces at line-start. Are you using a 4-space indent?"
errors reported by check-webkit-style.

No functionality was changed. So, no new tests.

  • wtf/Platform.h:

2010-01-08 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33417

Cleans up style errors exposed by the patch for bug #33198.

No functionality was changed. So, no new tests.

  • src/GraphicsContext3D.cpp:

2010-01-08 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33417

Cleans up style errors exposed by the patch for bug #33198.

No functionality was changed. So, no new tests.

  • platform/graphics/SimpleFontData.h:
  • plugins/PluginPackage.cpp:
8:48 PM Changeset in webkit [53035] by Simon Fraser
  • 1 edit
    1 delete in trunk/LayoutTests

2010-01-08 Simon Fraser <Simon Fraser>

No review.

Remove layout test that was committed by mistake.

  • compositing/webgl/webgl-blending.html: Removed.
8:07 PM Changeset in webkit [53034] by Simon Fraser
  • 4 edits
    26 adds in trunk

2010-01-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

WebGL canvas paints background color twice
​https://bugs.webkit.org/show_bug.cgi?id=33361

Clean up some logic around "directly composited" content: some images, video, and WebGL.

We previously set the GraphicsLayer background color to the CSS background color
in some cases where the box has no other decorations. However, the content
layer's bounds do not correspond with the background box in many cases,
and we could end up both painting the background color, and setting it on the layer.

Simplify this logic to never use layer background colors, and thus skip allocating
backing store only when the element has no visible box decorations.

Tests: compositing/images/direct-image-background-color.html

compositing/reflections/simple-composited-reflections.html
compositing/video/video-background-color.html
compositing/webgl/webgl-background-color.html
compositing/webgl/webgl-blending.html

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::is3DCanvas): Utility to determine if a RenderObject is a canvas with WebGL (WebCore::RenderLayerBacking::RenderLayerBacking): Remove m_hasDirectlyCompositedContent. (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): canUseDirectCompositing() is renamed to isDirectlyCompositedImage() and only applies to images now. No longer set layer background color. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Just use hasPaintedContent() as the argument to setDrawsContent(). (WebCore::hasBoxDecorationsOrBackground): Renamed. (WebCore::RenderLayerBacking::hasNonCompositingContent): (WebCore::hasBoxDecorationsOrBackgroundImage): Renamed from hasBoxDecorations(). (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Moved test for hasOverflowControls() into hasNonCompositingContent() and removed the FIXME comment. (WebCore::RenderLayerBacking::containsPaintedContent): New method that decides if the layer (and its non-composited children) has any content that must be painted into backing store. (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Renamed from canUseDirectCompositing() and reduced to only apply to images. (WebCore::RenderLayerBacking::rendererContentChanged): 3D canvas no longer falls under the canUseDirectCompositing() scope.
6:16 PM Changeset in webkit [53033] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

<​http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button

Reviewed by Adam Barth.

This button was broken during a previous Bugzilla upgrade after
changes were made to the names of objects exposed on templates.

  • template/en/custom/attachment/reviewform.html.tmpl: Changed

attachid to attachment.id and ispatch to attachment.ispatch.
Also tweaked the format to use 4 table columns instead of 5.

5:57 PM Changeset in webkit [53032] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Eric Seidel.

Don't store RegExp flags string representation
​https://bugs.webkit.org/show_bug.cgi?id=33321

It's unused; the string representation is reconstructed from flags.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h:
5:46 PM Changeset in webkit [53031] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

5:45 PM Changeset in webkit [53030] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.22

New tag.

5:39 PM Changeset in webkit [53029] by mrowe@apple.com
  • 8 edits in branches/safari-4-branch

Merge r52141.

5:39 PM Changeset in webkit [53028] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

5:25 PM Changeset in webkit [53027] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-08 Steve Block <​steveblock@google.com>

Reviewed by Darin Adler.

Use member initialization syntax instead of assignment for member variables of Document used
for determining minimum layout delay.
​https://bugs.webkit.org/show_bug.cgi?id=33316

No new tests, style change only.

  • dom/Document.cpp: Modified. (WebCore::Document::Document): Modified. Use initializer list for m_startTime, m_overMinimumLayoutThreshold and m_extraLayoutDelay.
5:02 PM Changeset in webkit [53026] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-01-08 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Passing array that is too large to set method of WebGLArrays does not throw an exception
​https://bugs.webkit.org/show_bug.cgi?id=33352

Added needed range checks to JSC and V8 custom bindings. Expanded
preexisting test suite for WebGLArrays and updated its expected
results. Tested in WebKit and Chromium.

  • fast/canvas/webgl/array-set-out-of-bounds-expected.txt: Added.
  • fast/canvas/webgl/array-set-out-of-bounds.html: Added.
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2010-01-08 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Passing array that is too large to set method of WebGLArrays does not throw an exception
​https://bugs.webkit.org/show_bug.cgi?id=33352

Added needed range checks to JSC and V8 custom bindings. Expanded
preexisting test suite for WebGLArrays and updated its expected
results. Tested in WebKit and Chromium.

Test: fast/canvas/webgl/array-set-out-of-bounds.html

  • bindings/js/JSWebGLArrayHelper.h: (WebCore::setWebGLArrayFromArray):
  • bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::setWebGLArrayFromArray):
5:02 PM Changeset in webkit [53025] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Memory use grows grows possibly unbounded in this JavaScript Array test case
​https://bugs.webkit.org/show_bug.cgi?id=31675

This fixes one observed bug in this test case, which is that
arrays don't report extra cost for the sparse value maps.

SunSpider reports a small speedup.

  • runtime/JSArray.cpp: (JSC::JSArray::putSlowCase): Report extra memory cost for the sparse value map.
  • runtime/JSArray.h:
4:46 PM Changeset in webkit [53024] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Eric Seidel <​eric@webkit.org>

Reviewed by Alexey Proskuryakov.

http/tests/xmlhttprequest/logout.html failed on Tiger Bot
​https://bugs.webkit.org/show_bug.cgi?id=31412

  • platform/mac-tiger/Skipped: After talking with Alexey, we're just gonna skip the failing test on Tiger.
4:30 PM Changeset in webkit [53023] by ap@apple.com
  • 3 edits
    6 adds in trunk

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=32962
HTML tags are wrongfully parsed when setting innerHTML of a SCRIPT element

Also fixed the same for STYLE elements.

Tests: fast/dom/css-innerHTML.html

fast/dom/script-innerHTML-x.xhtml
fast/dom/script-innerHTML.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML): Don't parse JS or CSS as HTML, matching Firefox.
4:20 PM Changeset in webkit [53022] by bfulgham@webkit.org
  • 3 edits in trunk/WebKit/win

Build fix, no review.

Protect video control logic inside ENABLE(VIDEO).

  • WebView.cpp:

(WebView::enterFullscreenForNode):
(WebView::exitFullscreen):

  • WebView.h:
4:05 PM Changeset in webkit [53021] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Replacing all RANDOMBLOB calls with ZEROBLOB calls in preparation
for denying RANDOMBLOB calls in HTML5 DB transactions.

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=33396

  • storage/open-database-while-transaction-in-progress.html:
3:59 PM Changeset in webkit [53020] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Included UNCONFIRMED bugs by default in advanced search query

Rubber-stamped by Alexey Proskuryakov.

  • data/params: Prepended 'bug_status=UNCONFIRMED&' to

'defaultquery' parameter.

3:53 PM Changeset in webkit [53019] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=33279
fast/websockets/websocket-event-target.html causes any test after it to fail

  • fast/websockets/script-tests/websocket-event-target.js: The test uses an HTTP server URL to create a WebSocket, so an error may be logged to console when detected (this is timing dependent).
  • platform/mac/Skipped: Removed the test from Skipped list.
3:52 PM Changeset in webkit [53018] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-08 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

run-javascriptcore-tests needs a --quiet flag
​https://bugs.webkit.org/show_bug.cgi?id=33399

Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.

  • Scripts/webkitpy/steps/runtests.py:
3:35 PM Changeset in webkit [53017] by Beth Dakin
  • 9 edits
    8 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
with -webkit-shadow on svg shapes
-and-
<rdar://problem/7389149>

Reviewed by Oliver Hunt.

Inflate the repaintRect for the shadow using its extent.

  • rendering/RenderForeignObject.cpp:

(WebCore::RenderForeignObject::computeRectForRepaint):

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::computeRectForRepaint):

  • rendering/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::computeRectForRepaint):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::computeRectForRepaint):

  • rendering/SVGRenderSupport.cpp:

(WebCore::getSVGShadowExtent):
(WebCore::SVGRenderBase::inflateForShadow):

  • rendering/SVGRenderSupport.h:

LayoutTests: Tests for ​https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
with -webkit-shadow on svg shapes
-and-
<rdar://problem/7389149>

Reviewed by Oliver Hunt.

  • fast/repaint/moving-shadow-on-container.html: Added.
  • fast/repaint/moving-shadow-on-path.html: Added.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum: Added.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.png: Added.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum: Added.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.png: Added.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt: Added.
3:27 PM Changeset in webkit [53016] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

FIX: Make patch status appear on reviewform.html.tmpl

  • template/en/custom/attachment/reviewform.html.tmpl: Check

attachment.ispatch (not just ispatch) when deciding whether
to display patch status. Also update layout a bit.

3:22 PM Changeset in webkit [53015] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2010-01-08
Reviewed by Alexey Proskuryakov.

To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
the time when Apache and WebSocketServer is locked by tests.
Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
we need to run http and websocket tests after all other tests.
If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
we need to preserve the given order.

  • Scripts/run-webkit-tests:
3:22 PM Changeset in webkit [53014] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Update data/params parameters

  • data/params: Updated 'timezone' to turn off DST. Updated

'usebugaliases' and 'usevotes' to turn them off.

3:01 PM Changeset in webkit [53013] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Don't post style-queue pass messages to bugs
​https://bugs.webkit.org/show_bug.cgi?id=33404

These messages aren't needed any more now that we have the status
bubble reporting pass events passively.

  • Scripts/webkitpy/commands/queues.py:
2:51 PM Changeset in webkit [53012] by ap@apple.com
  • 4 edits in trunk/LayoutTests

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32294
http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg

Changed the test to not have any funky characters. Filed bug 33400 to track the underlying
problem with kerning.

  • http/tests/uri/escaped-entity-expected.txt:
  • http/tests/uri/escaped-entity.html:
  • platform/mac/Skipped:
2:45 PM Changeset in webkit [53011] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Optimize the number of CPUs used for building Qt and Gtk
​https://bugs.webkit.org/show_bug.cgi?id=33394

Instead of hardcoding the number 8, we should read the number of CPUs
from the environment.

  • Scripts/webkitpy/executive.py:
  • Scripts/webkitpy/webkitport.py:
  • Scripts/webkitpy/webkitport_unittest.py:
2:31 PM Changeset in webkit [53010] by Dimitri Glazkov
  • 15 edits in trunk/LayoutTests

2010-01-08 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

New baselines to reflect the smaller repaint areas caused by r52839
​https://bugs.webkit.org/show_bug.cgi?id=33271

  • platform/mac/fast/repaint/background-misaligned-expected.checksum:
  • platform/mac/fast/repaint/background-misaligned-expected.png:
  • platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.checksum:
  • platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum:
  • platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
  • platform/mac/fast/repaint/float-new-in-block-expected.checksum:
  • platform/mac/fast/repaint/float-new-in-block-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/mac/fast/repaint/selected-replaced-expected.checksum:
  • platform/mac/fast/repaint/selected-replaced-expected.png:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.checksum:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.png:
2:29 PM Changeset in webkit [53009] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-01-08 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

WebGLArray subclasses do the wrong conversion in indexSetter
​https://bugs.webkit.org/show_bug.cgi?id=33350

  • fast/canvas/webgl/array-setters-expected.txt: Added.
  • fast/canvas/webgl/array-setters.html: Added.
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2010-01-08 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

WebGLArray subclasses do the wrong conversion in indexSetter
​https://bugs.webkit.org/show_bug.cgi?id=33350

Test: fast/canvas/webgl/array-setters.html

  • bindings/js/JSWebGLFloatArrayCustom.cpp: (WebCore::JSWebGLFloatArray::indexSetter):
  • bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: (WebCore::JSWebGLUnsignedIntArray::indexSetter):
2:05 PM Changeset in webkit [53008] by yong.li@torchmobile.com
  • 2 edits in trunk/JavaScriptCore

2010-01-08 Yong Li <​yoli@rim.com>

Reviewed by Darin Adler.

Remove unnecessary #include from FastMalloc.cpp
​https://bugs.webkit.org/show_bug.cgi?id=33393

  • wtf/FastMalloc.cpp:
2:05 PM Changeset in webkit [53007] by eric@webkit.org
  • 4 edits in trunk/BugsSite

2010-01-08 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Show patch status in bugs.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=33368

This patch adds an iframe to the show_bug page and the edit attachment
page that displays whether the attachment passed the various bots.

  • template/en/custom/attachment/edit.html.tmpl:
  • template/en/custom/attachment/list.html.tmpl:
  • template/en/custom/attachment/reviewform.html.tmpl:
1:49 PM Changeset in webkit [53006] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

transitions/cancel-transition.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=33398

There's a race between the check() call and the final
setTimeout. Just remove the final setTimeout and put
its contents in the check call itself.

  • transitions/cancel-transition.html:
1:48 PM Changeset in webkit [53005] by eric@webkit.org
  • 8 edits
    2 moves in trunk

2010-01-08 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Delegation client
​https://bugs.webkit.org/show_bug.cgi?id=32826

Factory related code removed from QtAbstractWebPopup. Popups are now created
by ChromeClientQt.
Popup content information struct added to class QtAbstractWebPopup.
PopupMenuClient is now hidden from higher layers.
QtAbstractWebPopup now receives content information and font as parameters
of method populate.
QtFallbackWebPopup moved to WebKit/qt/WebCoreSupport.

  • WebCore.pro:
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::getItems): (WebCore::PopupMenu::show):
  • platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::popupDidHide): (WebCore::QtAbstractWebPopup::valueChanged):
  • platform/qt/QtAbstractWebPopup.h: (WebCore::QtAbstractWebPopup::Item::):
  • platform/qt/QtFallbackWebPopup.cpp: Removed.
  • platform/qt/QtFallbackWebPopup.h: Removed.

2010-01-08 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Delegation client
​https://bugs.webkit.org/show_bug.cgi?id=32826

Added method createPopup to ChromeClientQt used to create popups.
QtFallbackWebPopup moved from WebCore/platform/qt to
WebKit/qt/WebCoreSupport.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createPopup):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/QtFallbackWebPopup.cpp: Added. (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate): (WebCore::QtFallbackWebPopup::showPopup): (WebCore::QtFallbackWebPopup::hidePopup): (WebCore::QtFallbackWebPopup::activeChanged): (WebCore::QtFallbackWebPopup::setParent):
  • WebCoreSupport/QtFallbackWebPopup.h: Added. (WebCore::QtFallbackWebPopup::hide):
1:31 PM Changeset in webkit [53004] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-08 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Skip invalid blocks in CSS property declarations.
​https://bugs.webkit.org/show_bug.cgi?id=31231
​https://bugs.webkit.org/show_bug.cgi?id=26619

This patch makes the CSS parser skip property declarations containing invalid blocks.

  • fast/css/parsing-error-recovery-expected.txt: Added.
  • fast/css/parsing-error-recovery.html: Added.

2010-01-08 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Skip invalid blocks in CSS property declarations.
​https://bugs.webkit.org/show_bug.cgi?id=31231
​https://bugs.webkit.org/show_bug.cgi?id=26619

This patch makes the CSS parser skip property declarations containing invalid blocks.

Test: fast/css/parsing-error-recovery.html

  • css/CSSGrammar.y:
1:11 PM Changeset in webkit [53003] by cmarrin@apple.com
  • 8 edits in trunk/LayoutTests

Fixed media test failures caused by ​http://trac.webkit.org/changeset/52998.
The media controller on Windows now has a full-screen button, which changes
the layout and therefore the test results. I regenerated them for
Windows.

1:07 PM Changeset in webkit [53002] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

The Windows Release bots were having trouble with the xmlhttprequest tests, so
they were skipped (r50280). They all currently pass on my machine, so unskipping them now.

  • platform/win/Skipped:
12:49 PM Changeset in webkit [53001] by darin@chromium.org
  • 3 edits
    3 adds in trunk/WebKit/chromium

2010-01-08 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Upstream webkit unit tests from the chromium repository
​https://bugs.webkit.org/show_bug.cgi?id=33351

This adds one such test (for KURL) and sets up the test framework.

Switch WebKit to build a static library on all platforms. Add a
webkit_unit_tests executable target that runs the unit tests and also
ensures that we don't have any missing symbols (a function that WebKit
as a shared library used to serve).

Changes chromium_src_dir to ../../WebKit/chromium to match how
WebCore.gyp defines that variable.

  • WebKit.gyp:
  • public/WebKitClient.h: (WebKit::WebKitClient::getPluginList): Remove bogus trailing semi-colon. (WebKit::WebKitClient::decrementStatsCounter): Remove bogus trailing semi-colon. (WebKit::WebKitClient::incrementStatsCounter): Remove bogus trailing semi-colon. (WebKit::WebKitClient::traceEventBegin): Remove bogus trailing semi-colon. (WebKit::WebKitClient::traceEventEnd): Remove bogus trailing semi-colon. (WebKit::WebKitClient::histogramCounts): Remove bogus trailing semi-colon.
  • tests: Added.
  • tests/KURLTest.cpp: Added.
  • tests/WebKitTest.h: Added.
12:31 PM Changeset in webkit [53000] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: CSS content not returned correctly in AX
​https://bugs.webkit.org/show_bug.cgi?id=33308

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/css-content-attribute.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

LayoutTests:

  • platform/mac/accessibility/css-content-attribute-expected.txt: Added.
  • platform/mac/accessibility/css-content-attribute.html: Added.
11:58 AM Changeset in webkit [52999] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-06 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

transitions/shorthand-border-transitions.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=33276

Yet another transitions test that doesn't give consistent
wiggle room. Make all the wiggle rooms account for >=200ms
instead of some that were only giving 100ms wiggle room.

  • transitions/shorthand-border-transitions.html:
11:23 AM Changeset in webkit [52998] by cmarrin@apple.com
  • 17 edits
    2 adds in trunk

Implement full-screen video for Windows
​https://bugs.webkit.org/show_bug.cgi?id=31318

10:55 AM Changeset in webkit [52997] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Unreviewed correction.

Accidentally left unnecessary modification to hdcFromContext
in when landing r52995.

  • WebFrame.cpp:

(hdcFromContext): Back out unneeded modification.

10:54 AM Changeset in webkit [52996] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-08 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Adam Barth.

Fix a regression that removed a call to
FrameLoaderClient::didDestroyScriptContextForFrame.
​https://bugs.webkit.org/show_bug.cgi?id=33347

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::disposeContextHandles):
10:16 AM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
9:30 AM Changeset in webkit [52995] by bfulgham@webkit.org
  • 5 edits in trunk

WebCore: WebKit plugins are not rendered during printing.
​https://bugs.webkit.org/show_bug.cgi?id=33022.

Reviewed by Adam Roben.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintWindowedPluginIntoContext): Tell

cairo printing surface to flush so that blank regions do
not write over the plugin's paint operations.

  • rendering/RenderLayer.cpp: Build fix.

(WebCore::RenderLayer::beginTransparencyLayers): Correct

method signature missing for ColorSpace.

WebKit/win: Use correct cairo surface data type for handling print operations.
​https://bugs.webkit.org/show_bug.cgi?id=33022.

Reviewed by Adam Roben.

  • WebFrame.cpp:

(scaleFactor): Handle 'scale = 0' case.
(WebFrame::spoolPage): Use scaleFactor helper function. Account for

margin size in region passed to header/footer routines.

(WebFrame::spoolPages): Properly clean up Cairo surface.

9:24 AM Changeset in webkit [52994] by Chris Fleizach
  • 7 edits in trunk

REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
​https://bugs.webkit.org/show_bug.cgi?id=33300

Reviewed by Eric Seidel.

WebCore:

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:withContext:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):

LayoutTests:

  • platform/mac/Skipped:
6:27 AM Changeset in webkit [52993] by Csaba Osztrogonác
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed trivail fix. Missing bugzilla link added to ChangeLog.(r52976)

6:22 AM Changeset in webkit [52992] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

r52976 revealed this failure by re-ordering tests.

I do not have a Snow Leopard build to test with, so skipping this
and filed bug ​https://bugs.webkit.org/show_bug.cgi?id=33372

  • platform/mac-snowleopard/Skipped: platform/mac/editing/input/devanagari-ligature.html skipped.
5:26 AM Changeset in webkit [52991] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in this skiplist by this commit.

  • platform/win/Skipped:
5:08 AM Changeset in webkit [52990] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

r52976 revealed this failure by re-ordering tests.
r52980 corrected the expected results file, but Windows still fails,
presumably due to another test still affecting this one.

Reviewed by Eric Seidel.

I do not have a windows build to test with, so skipping this
and filed bug ​https://bugs.webkit.org/show_bug.cgi?id=33374

  • platform/win/Skipped: svg/W3C-SVG-1.1/filters-conv-01-f.svg skipped.
4:59 AM Changeset in webkit [52989] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-08 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Hausmann.

commit-queue should run run-javascriptcore-tests
​https://bugs.webkit.org/show_bug.cgi?id=33376

I also made it run the python and perl unit tests.

  • Scripts/webkitpy/steps/runtests.py:
  • Scripts/webkitpy/webkitport.py:
4:46 AM Changeset in webkit [52988] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Threading problems with some of the tests
​https://bugs.webkit.org/show_bug.cgi?id=30814

We are going to skip all the storage tests until we find the issue
with the threading system in the gtk port.

  • platform/gtk/Skipped:
4:09 AM Changeset in webkit [52987] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Eric Seidel <​eric@webkit.org>

No review, rolling out r52983.
​http://trac.webkit.org/changeset/52983
​https://bugs.webkit.org/show_bug.cgi?id=33321

Broke 59 JavaScriptCore tests. I don't think Kent knew about
run-javascriptcore-tests. Sadly neither does the commit-bot,
yet.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h: (JSC::RegExp::flags):
3:54 AM Changeset in webkit [52986] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-01-08 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

[GTK] loading test should use SoupServer instead of actual sites
​https://bugs.webkit.org/show_bug.cgi?id=33353

Make all the loading tests use SoupServer, instead of fetching
stuff from the Internet.

  • tests/testloading.c: (server_callback): (get_uri_for_path): (test_loading_status): (test_loading_error): (test_loading_cancelled): (load_wentback_status_changed_cb): (load_error_test): (test_loading_goback): (main):
3:50 AM Changeset in webkit [52985] by pfeldman@chromium.org
  • 6 edits
    2 adds
    1 delete in trunk/WebCore

2010-01-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Regex-based syntax highlighting is slow.

​https://bugs.webkit.org/show_bug.cgi?id=33330

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/JavaScriptHighlighterScheme.js: Removed.
  • inspector/front-end/JavaScriptTokenizer.js: Added. (WebInspector.JavaScriptTokenizer): (WebInspector.JavaScriptTokenizer.prototype.set line): (WebInspector.JavaScriptTokenizer.prototype.getCondition): (WebInspector.JavaScriptTokenizer.prototype.setCondition): (WebInspector.JavaScriptTokenizer.prototype._charAt): (WebInspector.JavaScriptTokenizer.prototype.nextToken):
  • inspector/front-end/JavaScriptTokenizer.re2js: Added.
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
3:44 AM Changeset in webkit [52984] by eric@webkit.org
  • 8 edits in trunk

2010-01-08 Eric Seidel <​eric@webkit.org>

No review, rolling out r52981.
​http://trac.webkit.org/changeset/52981
​https://bugs.webkit.org/show_bug.cgi?id=33319

Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

2010-01-08 Eric Seidel <​eric@webkit.org>

No review, rolling out r52981.
​http://trac.webkit.org/changeset/52981
​https://bugs.webkit.org/show_bug.cgi?id=33319

Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/regexp-compile-expected.txt:
  • fast/js/script-tests/regexp-compile.js:
  • fast/regex/non-pattern-characters-expected.txt:
3:32 AM Changeset in webkit [52983] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Darin Adler.

Don't store RegExp flags string representation
​https://bugs.webkit.org/show_bug.cgi?id=33321

It's unused; the string representation is reconstructed from flags.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h:
3:23 AM Changeset in webkit [52982] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Eric Seidel <​eric@webkit.org>

Reviewed by Tor Arne Vestbø.

media/unsupported-tracks.html is failing on Snow Leopard Release bot
​https://bugs.webkit.org/show_bug.cgi?id=32339

  • platform/mac-snowleopard/Skipped: Add this to join a bunch of other skipped media tests which time out.
3:17 AM Changeset in webkit [52981] by eric@webkit.org
  • 8 edits in trunk

2010-01-08 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
​https://bugs.webkit.org/show_bug.cgi?id=33319

"" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.

  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

2010-01-08 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
​https://bugs.webkit.org/show_bug.cgi?id=33319

Add new test cases and adapt existing ones.

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/script-tests/regexp-compile.js:
  • fast/regex/non-pattern-characters-expected.txt:
2:22 AM Changeset in webkit [52980] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-08 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Hausmann.

http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg
​https://bugs.webkit.org/show_bug.cgi?id=32294

  • platform/mac/Skipped: Add http/tests/uri/escaped-entity.html to Skipped list since it affects later tests.
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Check in correct results.
2:12 AM Changeset in webkit [52979] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Fisher.

REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
​https://bugs.webkit.org/show_bug.cgi?id=33300

Skipping platform/mac/accessibility/aria-liveregions-notifications.html
to make the bots green until Chris Fleizach can fix the AX Notification system
to correctly unregister logging callbacks.

  • platform/mac/Skipped:
12:51 AM Changeset in webkit [52978] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

RVCT compiler with "-Otime -O3" optimization tries to optimize out
inline new'ed pointers that are passed as arguments.
Proposed patch assigns new'ed pointer explicitly outside function call.

Patch by Norbert Leser <​norbert.leser@nokia.com> on 2010-01-08
Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=33084

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

12:01 AM Changeset in webkit [52977] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

Remove an unnecessary cacheFlush from ARM_TRADITIONAL JIT
​https://bugs.webkit.org/show_bug.cgi?id=33203

Reviewed by Gavin Barraclough.

  • assembler/ARMAssembler.cpp: Remove obsolete linkBranch function.

(JSC::ARMAssembler::executableCopy): Inline a clean linkBranch code.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::getLdrImmAddress): Use inline function.
(JSC::ARMAssembler::getLdrImmAddressOnPool): Ditto.
(JSC::ARMAssembler::patchPointerInternal): Remove an unnecessary cacheFlush.
(JSC::ARMAssembler::linkJump): Use patchPointerInternal instead of linkBranch.
(JSC::ARMAssembler::linkCall): Ditto.
(JSC::ARMAssembler::relinkCall): Ditto.

Jan 7, 2010:

11:56 PM Changeset in webkit [52976] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Run the http and websocket tests after all other tests.

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Darin Adler.

  • Scripts/run-webkit-tests:
11:41 PM Changeset in webkit [52975] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
​https://bugs.webkit.org/show_bug.cgi?id=33311

Reviewed by Gavin Barraclough.

Move compileGetDirectOffset function to common part of JSVALUE32

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):

11:08 PM Changeset in webkit [52974] by eric@webkit.org
  • 5 edits in trunk

2010-01-07 Mike Belshe <​mbelshe@chromium.org>

Reviewed by Darin Adler.

Fix Spdy casing to match style guide.

​https://bugs.webkit.org/show_bug.cgi?id=33326

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::wasFetchedViaSPDY): (WebCore::ResourceResponse::setWasFetchedViaSPDY):

2010-01-07 Mike Belshe <​mbelshe@chromium.org>

Reviewed by Darin Adler.

Fix Spdy casing to match style guide.

​https://bugs.webkit.org/show_bug.cgi?id=33326

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasFetchedViaSPDY): (WebKit::WebURLResponse::setWasFetchedViaSPDY):
10:54 PM Changeset in webkit [52973] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-07 Laszlo Gombos <Laszlo Gombos>

Reviewed by Maciej Stachowiak.

Allow call sites to determine if ASSERT_* and LOG_* macros are operational
​https://bugs.webkit.org/show_bug.cgi?id=33020

  • wtf/Assertions.h: Set ASSERT_MSG_DISABLED, FATAL_DISABLED, ERROR_DISABLED, LOG_DISABLED to 1 if the compiler does not support variadic macros. Refactor for better readibility.
10:16 PM Changeset in webkit [52972] by dbates@webkit.org
  • 14 edits in trunk

2010-01-07 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • Configurations/FeatureDefines.xcconfig:

2010-01-07 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • features.gypi:

2010-01-07 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • Configurations/FeatureDefines.xcconfig:

2010-01-07 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • config.h:

2010-01-07 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • configure.ac:
9:54 PM Changeset in webkit [52971] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-07 Afonso R. Costa Jr. <​afonso.costa@openbossa.org>

Reviewed by Darin Adler.

As the bug ​https://bugs.webkit.org/show_bug.cgi?id=30034 is fixed,
the zoomOrNot argument is unnecessary.

  • fast/dom/elementFromPoint-relative-to-viewport.html:
9:47 PM Changeset in webkit [52970] by Laszlo Gombos
  • 3 edits
    1 add in trunk/JavaScriptCore

2010-01-07 Laszlo Gombos <Laszlo Gombos>

Reviewed by Gavin Barraclough.

[Symbian] Port ARM traditional JIT Trampolines to RVCT
​https://bugs.webkit.org/show_bug.cgi?id=30552

Take the GCC implementation and mechanically convert
it to RVCT syntax.

Use 'bx rX' instead of 'mov pc, rX' when it is available.

Developed in cooperation with Iain Campbell and Gabor Loki.

  • JavaScriptCore.pri: Extra step to generate RVCT stubs. The script generation intentionally executed all the time not just for RVCT targets.
  • create_rvct_stubs: Added. Perl script to expand precompiler macros for RVCT assembler - the template is defined in JITStubs.cpp.
  • jit/JITStubs.cpp: (JSC::ctiTrampoline): (JSC::ctiVMThrowTrampoline): (JSC::ctiOpThrowNotCaught):
9:12 PM Changeset in webkit [52969] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix some test-webkitpy expectations
​https://bugs.webkit.org/show_bug.cgi?id=33345

I forgot to change these when I added the CheckStyle step.

  • Scripts/webkitpy/commands/upload_unittest.py:
8:58 PM Changeset in webkit [52968] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
​https://bugs.webkit.org/show_bug.cgi?id=33341

Fix this by moving to the root directory before editing ChangeLogs.
There is a related bug with CheckStyle.

  • Scripts/webkitpy/steps/checkstyle.py:
  • Scripts/webkitpy/steps/editchangelog.py:
7:06 PM Changeset in webkit [52967] by Stephanie Lewis
  • 6 edits in trunk/WebCore

Rolled out ​http://trac.webkit.org/changeset/52778 due to rolling
out ​http://trac.webkit.org/changeset/52756

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • editing/SelectionController.cpp:

(WebCore::SelectionController::layout):
(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::invalidateCaretRect):
(WebCore::SelectionController::paintCaret):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::attach):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::attach):

  • page/Frame.cpp:

(WebCore::Frame::revealSelection):

6:51 PM Changeset in webkit [52966] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Eric Seidel <​eric@webkit.org>

Reviewed by Nikolas Zimmermann.

media/unsupported-tracks.html is failing on Snow Leopard Release bot
​https://bugs.webkit.org/show_bug.cgi?id=32339

This is a speculative fix. I do not have a Snow Leopard machine to test on
and I've not seen mention of someone being able to reproduce this locally.

Prevent watchdog timer from firing after a test completes but before
the next one starts, causing the error to appear in the next test.

  • DumpRenderTree/mac/DumpRenderTree.mm: (dump): Stop the watchdog before printing #EOF for the test content. We only need to care about the JavaScript of the test running too long or some hang in WebCore. Any other failures will be covered by the calling script's own watchdog timer.
6:22 PM Changeset in webkit [52965] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue is stuck spinning due to exception
​https://bugs.webkit.org/show_bug.cgi?id=33358

  • Scripts/webkitpy/commands/queues.py:
    • Don't try to stringify the exception.
5:56 PM Changeset in webkit [52964] by Stephanie Lewis
  • 7 edits
    2 deletes in trunk

Rollout ​http://trac.webkit.org/changeset/52756 due to a large performance regression.

WebCore:

  • dom/Document.cpp:

(WebCore::Document::updateLayout):

  • editing/SelectionController.cpp:

(WebCore::SelectionController::SelectionController):
(WebCore::SelectionController::setSelection):

  • editing/SelectionController.h:
  • page/Frame.cpp:

(WebCore::Frame::setCaretVisible):
(WebCore::Frame::selectionLayoutChanged):
(WebCore::Frame::caretBlinkTimerFired):
(WebCore::Frame::selectionBounds):

  • page/FrameView.cpp:

(WebCore::FrameView::needsLayout):

LayoutTests:

  • fast/forms/selection-layout-reentry-strange-case-expected.txt: Removed.
  • fast/forms/selection-layout-reentry-strange-case.html: Removed.
4:57 PM Changeset in webkit [52963] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

More build fix.

  • WebKitPrefix.h: Define JS_EXPORTCLASS here, as well (as empty).
4:44 PM Changeset in webkit [52962] by ggaren@apple.com
  • 4 edits in trunk

Fix a crash seen on the buildbots.

Reviewed by Sam Weinig.

JavaScriptCore:

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init): Disable specific function tracking here,
instead of in WebCore, to ensure that the disabling happens before a
specific function can be registered.

WebCore:

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase): Don't disable specific
function tracking here; it's too late, as some specific functions
may already have been tracked in the base class constructor.

4:43 PM Changeset in webkit [52961] by ap@apple.com
  • 2 edits in trunk/JavaScriptCore

Mac build fix.

4:36 PM Changeset in webkit [52960] by Nikolas Zimmermann
  • 12 edits
    9 adds in trunk

2010-01-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGTextElement & friends need to implement svgAttributeChanged
​https://bugs.webkit.org/show_bug.cgi?id=33284

Implement svgAttributeChanged() for SVGTextElement & SVGTRefElement. As <text> element contain children,
childrenChanged() has to be implemented as well for SVGTextElement.

Simplify SVGTransformable::parseTransformAttribute() code, clearing lists in the beginning
and on error case, after parsing - previously the calling site had to take care of that.

Tests: svg/dynamic-updates/SVGTRefElement-dom-href-attr.html

svg/dynamic-updates/SVGTextElement-dom-transform-attr.html
svg/dynamic-updates/SVGTextElement-svgdom-transform-prop.html

  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::parseMappedAttribute):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::svgAttributeChanged):
  • svg/SVGTRefElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::svgAttributeChanged): (WebCore::SVGTextElement::childrenChanged):
  • svg/SVGTextElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute):
  • svg/SVGTransformable.h:
4:28 PM Changeset in webkit [52959] by ap@apple.com
  • 2 edits in trunk/JavaScriptGlue

Mac build fix.

  • config.h: Define JS_EXPORTCLASS for JavaScriptGlue.
4:28 PM Changeset in webkit [52958] by bweinstein@apple.com
  • 3 edits
    1 add in trunk/WebCore

Padding in popup menu gets lost with styled <select> in Windows.
Fixes <rdar://7285538>, and <​http://webkit.org/b/33235>.

Reviewed by Adele Peterson.

[Win] Support padding-right on selects when webkit-appearance is off. Added a test
case for narrow selects with -webkit-appearance: none, and padding left and right to
show that both types of padding are honored.

  • manual-tests/select-webkit-appearance-off-narrow-select.html: Added.
  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::calculatePositionAndSize): Use clientPaddingRight instead of a hardcoded constant.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::clientPaddingRight): If webkit-appearance is off, use padding-right instead of
the hardcoded constant.

4:24 PM Changeset in webkit [52957] by ap@apple.com
  • 2 edits in trunk/WebKitLibraries

Not reviewed, build fix.

Windows buid fix - disable warning 4251 (class needs to have dll-interface to be used by
clients of another class). WebCore doesn't use all methods of JSString, so
we don't export all classes clients could theoretically access via JSString.

  • win/tools/vsprops/common.vsprops:
4:15 PM Changeset in webkit [52956] by ap@apple.com
  • 18 edits
    3 adds in trunk

Reviewed by Geoffrey Garen.

​https://bugs.webkit.org/show_bug.cgi?id=33057
REGRESSION(r49365): typeof(xhr.responseText) != "string" in Windows

<rdar://problem/7296920> REGRESSION: WebKit fails to start PeaceKeeper benchmark

Test: fast/js/webcore-string-comparison.html

In r49365, some code was moved from JSString.cpp to JSString.h, and as a result, WebCore
got a way to directly instantiate JSStrings over DLL borders. Since vftable for JSString was
not exported, objects created from WebCore got a different vptr, and JavaScriptCore
optimizations that relied on vptr of all JSString objects being equal failed.

  • config.h: Added a JS_EXPORTCLASS macro for exporting classes. It's currently the same as JS_EXPORTDATA, but it clearly needed a new name.
  • runtime/InitializeThreading.cpp: (JSC::initializeThreadingOnce):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::createNonDefault): (JSC::JSGlobalData::create): (JSC::JSGlobalData::sharedInstance):
  • runtime/JSGlobalData.h: Store vptrs just once, no need to repeatedly pick and copy them. This makes it possible to assert vptr correctness in object destructors (which don't have access to JSGlobalData, and even Heap::heap(this) will fail for fake objects created from storeVPtrs()).
  • runtime/JSArray.cpp: (JSC::JSArray::~JSArray): Assert that vptr is what we expect it to be. It's important to assert in destructor, because MSVC changes the vptr after constructor is invoked.
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::~JSByteArray): Ditto.
  • runtime/JSByteArray.h: Ditto.
  • runtime/JSFunction.h: Ditto.
  • runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction): Ditto.
  • runtime/JSCell.h: (JSC::JSCell::setVPtr): Added a method to substitute vptr for another one.
  • runtime/JSString.h: Export JSString class together with its vftable, and tell other libraries tp import it. This is needed on platforms that have a separate JavaScriptCore dynamic library - and on Mac, we already did the export via JavaScriptCore.exp. (JSC::JSString::~JSString): Assert tha vptr is what we expect it to be. (JSC::fixupVPtr): Store a previously saved primary vftable pointer (do nothing if building JavaScriptCore itself). (JSC::jsSingleCharacterString): Call fixupVPtr in case this is call across DLL boundary. (JSC::jsSingleCharacterSubstring): Ditto. (JSC::jsNontrivialString): Ditto. (JSC::jsString): Ditto. (JSC::jsSubstring): Ditto. (JSC::jsOwnedString): Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export the new static JSGlobalData members that are used in WebCore via inline functions.
3:51 PM Changeset in webkit [52955] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Account for scale and current context position (as well as page
position) in the device context world transform passed to
plugins. This is especially important for print surface DPI.
​http://bugs.webkit.org/show_bug.cgi?id=32909.

Reviewed by Jon Honeycutt.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintWindowedPluginIntoContext): Revise

world context handling to include scaling and translation
already set for the CTM.

3:44 PM Changeset in webkit [52954] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Don't leak a JSStringRef within _accessibilityNotificationCallback.

Reviewed by Jon Honeycutt.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
when it goes out of scope.

3:33 PM Changeset in webkit [52953] by mjs@apple.com
  • 2 edits in trunk/WebKit/mac

2010-01-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't create a selection; drags widget instead ( Translation, Weather, Ski Report )
​https://bugs.webkit.org/show_bug.cgi?id=33348
<rdar://problem/7310616>


  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): We only want to handle file: URLs for the user stylesheet now, so special-case the DashboardClient's funky user stylesheet URL by mapping it to the equivalent file URL.
2:55 PM Changeset in webkit [52952] by Nate Chapin
  • 24 edits in trunk/WebCore

2010-01-07 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Generate V8 bindings header declarations for named and indexed accessors.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:
  • bindings/v8/custom/V8StorageCustom.cpp:
  • bindings/v8/custom/V8StyleSheetListCustom.cpp:
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2:36 PM Changeset in webkit [52951] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Better build fix: use 'this->structure()', since 'structure' is a
PassRefPtr, and therefore null.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):

2:27 PM Changeset in webkit [52950] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Build fix: avoid a name conflict by using the local 'structure' instead
of the member 'structure()'.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):

2:13 PM Changeset in webkit [52949] by Simon Fraser
  • 7 edits in trunk/WebCore

2010-01-07 Simon Fraser <Simon Fraser>

Build fix.

Add RenderEmbeddedObject.h/cpp to all the build systems.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
2:07 PM Changeset in webkit [52948] by ggaren@apple.com
  • 5 edits in trunk

2010-01-07 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Safari memory usage skyrockets using new Google AdWords interface
​https://bugs.webkit.org/show_bug.cgi?id=33343

The memory use was caused by the global object creating too many structures
as it thrashed between different specific functions.

  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::addAnonymousSlotsTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::despecifyAllFunctions):
  • runtime/Structure.h: (JSC::Structure::disableSpecificFunctionTracking): Track a thrash count for specific functions. Disable specific function tracking once the thrash count has been hit.

2010-01-07 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Safari memory usage skyrockets using new Google AdWords interface
​https://bugs.webkit.org/show_bug.cgi?id=33343

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Disabled specific function tracking for the window object, since there's no way to do direct method calls on the window object; they all go through the window shell.
1:57 PM Changeset in webkit [52947] by Simon Fraser
  • 46 edits
    2 copies in trunk

2010-01-07 Simon Fraser <Simon Fraser>

Reviewed by Kevin Decker, Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=33338
Create a renderer for <object> and <embed>

Add RenderEmbeddedObject, which derives from RenderPartObject, and is created for <object> and <embed>.
Instances of RenderPartObject are now only allocated for iframes.

Move object/embed-related code from RenderPartObject to RenderEmbeddedObject.

  • WebCore.xcodeproj/project.pbxproj: Add RenderEmbeddedObject.h/cpp
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::createRenderer): Create a RenderEmbeddedObject. (WebCore::HTMLEmbedElement::updateWidget): Use toRenderEmbeddedObject()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): Make a RenderEmbeddedObject for the plugin-proxy case. (WebCore::HTMLMediaElement::finishParsingChildren): Use toRenderEmbeddedObject() in the plugin-proxy code.
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::createRenderer): Make a RenderEmbeddedObject (WebCore::HTMLObjectElement::updateWidget): Use toRenderEmbeddedObject()
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::addWidgetToUpdate): (WebCore::FrameView::removeWidgetToUpdate): (WebCore::FrameView::updateWidgets): Objects in the m_widgetUpdateSet are only ever RenderEmbeddedObjects.
  • rendering/RenderEmbeddedObject.cpp: Added.
  • rendering/RenderEmbeddedObject.h: Added. Most of the code moved from RenderPartObject.
  • rendering/RenderObject.h: (WebCore::RenderObject::isEmbeddedObject): New method.
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): Initialize m_hasFallbackContent here, rather than in the derived classes.
  • rendering/RenderPart.h: Comments.
  • rendering/RenderPartObject.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): Clean up, code moved to base class, and removed object/embed-specific code. (WebCore::RenderPartObject::layout): Removed object/embed-specific code.
1:47 PM Changeset in webkit [52946] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-01-07 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=33338
Create a renderer for <object> and <embed>

First part of this change: renderPartObject->updateWidget() is a no-op for iframe elements,
so we don't need to call it here, and can thus remove the attach() override entirely.

  • html/HTMLIFrameElement.cpp:
  • html/HTMLIFrameElement.h:
1:36 PM Changeset in webkit [52945] by pfeldman@chromium.org
  • 7 edits
    4 adds in trunk/WebCore

2009-01-07 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Migrate to canvas-based text viewer / editor that scales.

​https://bugs.webkit.org/show_bug.cgi?id=33001

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/JavaScriptHighlighterScheme.js: Added. (WebInspector.JavaScriptHighlighterScheme):
  • inspector/front-end/KeyboardShortcut.js:
  • inspector/front-end/TextEditor.js: Added. (WebInspector.TextEditor): (WebInspector.TextSelectionModel): (WebInspector.TextCursor):
  • inspector/front-end/TextEditorHighlighter.js: Added. (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/TextEditorModel.js: Added. (WebInspector.TextRange): (WebInspector.TextRange.prototype.clone): (WebInspector.TextEditorModel):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
1:32 PM Changeset in webkit [52944] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-01-07 Christian Sejersen <Christian Sejersen>

Reviewed by Darin Adler.

document.title does not replace or remove space characters
​https://bugs.webkit.org/show_bug.cgi?id=27032

  • fast/dom/Document/document-title-get-expected.txt: Added.
  • fast/dom/Document/document-title-get.html: Added.
  • fast/dom/Document/script-tests/document-title-get.js: Added.

2010-01-07 Christian Sejersen <Christian Sejersen>

Reviewed by Darin Adler.

document.title does not replace or remove space characters
​https://bugs.webkit.org/show_bug.cgi?id=27032

Test: fast/dom/Document/document-title-get.html

  • dom/Document.cpp: (WebCore::Document::Document): Initialization of m_rawTitle (WebCore::canonicalizedTitle): Moved from DocumentLoader.cpp with minor edits (WebCore::Document::updateTitle): Ensures the title is canonicalized (WebCore::Document::setTitle): Uses m_rawTitle instaed of m_title (WebCore::Document::removeTitle): Uses m_rawTitle instead of m_title
  • dom/Document.h: Added m_rawTitle that stores the passed in title, m_title now stores the canonicalized title
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setTitle): The title passed in is now canonicalized in Document.cpp
12:58 PM Changeset in webkit [52943] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-07 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Allow leading/trailing space for CSS nth-*() and lang().
​https://bugs.webkit.org/show_bug.cgi?id=17248

For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
See the bug comments for why we don't allow space at other places.

  • fast/css/css3-space-in-nth-and-lang.html: Added.
  • platform/mac/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.

2010-01-07 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Allow leading/trailing space for CSS nth-*() and lang().
​https://bugs.webkit.org/show_bug.cgi?id=17248

For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
See the bug comments for why we don't allow space at other places.

  • css/CSSGrammar.y:
12:26 PM Changeset in webkit [52942] by kdecker@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=33331
(WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to NetscapePluginHostManager when instantiating plug-ins)


  • Plugins/Hosted/NetscapePluginHostManager.h: Modify method signature for instantiatePlugin to include acceleratedCompositingEnabled bool.
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin):
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): Pass accelerated compositing status to NetscapePluginHostManage
12:24 PM Changeset in webkit [52941] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: contentEditable DIVs are not AX accessible
​https://bugs.webkit.org/show_bug.cgi?id=33325

Reviewed by Beth Dakin.

WebCore:

Test: accessibility/contenteditable-hidden-div.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::canSetValueAttribute):

LayoutTests:

  • accessibility/contenteditable-hidden-div-expected.txt: Added.
  • accessibility/contenteditable-hidden-div.html: Added.
12:20 PM Changeset in webkit [52940] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, build fix.

Skip LayoutTests/http/tests/media/video-error-abort.html

  • platform/gtk/Skipped:
12:18 PM Changeset in webkit [52939] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Unreviewed. roll-out r52917, r52932 and r52934.

12:08 PM Changeset in webkit [52938] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-07 Adam Barth <​abarth@webkit.org>

Unreviewed. Resolve merge conflict.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setContextDebugId):
12:00 PM Changeset in webkit [52937] by abarth@webkit.org
  • 12 edits in trunk

2010-01-07 Adam Barth <​abarth@webkit.org>

No review, rolling out r52847.
​http://trac.webkit.org/changeset/52847
​https://bugs.webkit.org/show_bug.cgi?id=33232

Might have caused a perf regression. I'm rolling this out to see if it
heals the perf bot.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::updateDocument):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
  • bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::V8IsolatedContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::~V8Proxy): (WebCore::V8Proxy::handleOutOfMemory): (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::currentContext): (WebCore::V8Proxy::setContextDebugId):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::windowShell):
  • bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::adjustedContext):

2010-01-07 Adam Barth <​abarth@webkit.org>

No review, rolling out r52847.
​http://trac.webkit.org/changeset/52847
​https://bugs.webkit.org/show_bug.cgi?id=33232

Might have caused a perf regression.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
11:45 AM Changeset in webkit [52936] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in skiplist by this commit.

  • platform/mac/Skipped:
11:41 AM Changeset in webkit [52935] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, build fix.

Add executable bit to video-throttled-load cgi.

  • http/tests/media/video-throttled-load.cgi: Added property svn:executable.
11:25 AM Changeset in webkit [52934] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Unreviewed. Fix the Mac bots. Why is there no HTTPD PID file?

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2010-01-07

  • Scripts/run-webkit-tests:
10:48 AM Changeset in webkit [52933] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix

  • WebCore.xcodeproj/project.pbxproj: Made TypesettingFeatures.h private.
10:33 AM Changeset in webkit [52932] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Store HTTPD PID in a variable to fix warnings if for some reason the pidfile gets deleted before httpd terminates.
This should fix the occasional warnings for uninitialized values on the Mac bots.

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Alexey Proskuryakov.

  • Scripts/run-webkit-tests:
10:28 AM Changeset in webkit [52931] by mitz@apple.com
  • 9 edits
    1 add in trunk/WebCore

Added Font::typesettingFeatures() and deployed it

Reviewed by Sam Weinig.

No change in funcitonality

  • WebCore.xcodeproj/project.pbxproj: Added TypesettingFeatures.h.
  • platform/graphics/Font.h:

(WebCore::Font::typesettingFeatures): Added. Determines the typesetting

features from the text redndering mode.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::canUseGlyphCache): Use typesettingFeatures().

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/TypesettingFeatures.h: Added.
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::disableLigatures): Take TypesettingFeatures instead of

TextRenderingMode.

(WebCore::initializeATSUStyle): Ditto.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):

Use typesettingFeatures().

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

Ditto.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCFStringAttributes): Take

TypesettingFeatures instead of TextRenderingMode.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak): Use TypesettingFeatures().

10:08 AM Changeset in webkit [52930] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-01-07 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r52900.
​http://trac.webkit.org/changeset/52900
​https://bugs.webkit.org/show_bug.cgi?id=30055

Broke over 30 SVG pixel tests.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
9:45 AM Changeset in webkit [52929] by Simon Hausmann
  • 2 edits in trunk/WebCore

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] The library version number of the first package release is 4.7.0.

  • WebCore.pro:
9:36 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
9:33 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
9:31 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
9:29 AM Changeset in webkit [52928] by Simon Hausmann
  • 6 edits in trunk

[Qt] Allow the application to override online/offline network status
​https://bugs.webkit.org/show_bug.cgi?id=32684

Patch by Yael Aharon <​yael.aharon@nokia.com> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.

WebCore:

Added API to NetworkStateNotifier for forcing network status.

  • platform/network/NetworkStateNotifier.h:
  • platform/network/qt/NetworkStateNotifierPrivate.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:

(WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifierPrivate::onlineStateChanged):
(WebCore::NetworkStateNotifierPrivate::networkAccessPermissionChanged):
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::setNetworkAccessAllowed):

WebKit/qt:

Add a setting so that applications can overide the network status.
Applications that use this setting still need to block network access
through QNAM.

  • Api/qwebsettings.cpp:

(qt_networkAccessAllowed):

9:26 AM Changeset in webkit [52927] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix.

  • platform/gtk/Skipped: missing "l" suffix added to fast/repaint/subtree-layoutstate-transform.html
9:14 AM Changeset in webkit [52926] by Simon Hausmann
  • 2 edits in trunk/WebCore

prospective bearer management build fix to get the include path correct

8:52 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
8:52 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
8:38 AM Changeset in webkit [52925] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, build fix.

​https://bugs.webkit.org/show_bug.cgi?id=33323
Skip new test on Tiger for now.

  • platform/mac-tiger/Skipped:
8:22 AM Changeset in webkit [52924] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

[Qt] Enable JIT in debug mode on win32 after r51141 fixed the crashes.

Reviewed by Simon Hausmann.

8:02 AM Changeset in webkit [52923] by eric.carlson@apple.com
  • 4 edits
    2 moves in trunk

2010-01-07 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=33272
'abort' event still fired as a progress event

rdar://6710625
Test media/video-error-abort.html doesn't work

Test: http/tests/media/video-error-abort.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::scheduleEvent): Incorporate code from enqueueEvent. (WebCore::HTMLMediaElement::loadInternal): Fix 'abort' event firing logic missed in ​https://bugs.webkit.org/show_bug.cgi?id=30513. Change order of initialization to match spec wording.
  • html/HTMLMediaElement.h: Remove enqueueEvent prototype.

2010-01-07 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=33272
'abort' event still fired as a progress event

rdar://6710625
Test media/video-error-abort.html doesn't work

  • http/tests/media/video-error-abort-expected.txt: Copied from LayoutTests/media/video-error-abort-expected.txt.
  • http/tests/media/video-error-abort.html: Copied from LayoutTests/media/video-error-abort.html.

Modified to run with slow loading cgi, add test to ensure that 'abort' event is not a
progress event.

  • media/video-error-abort-expected.txt: Removed.
  • media/video-error-abort.html: Removed.
7:48 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
6:37 AM Changeset in webkit [52922] by eric@webkit.org
  • 9 edits in trunk

2010-01-07 Kim Grönholm <​kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Wrong state and TouchLists in TouchEvents
​https://bugs.webkit.org/show_bug.cgi?id=32878

Touch event tests changed to match the API and semantics of iPhone and
Android. Each new touch point press dispatches a touchstart event with
the pressed touch point(s) in the changedTouches list, and a release
dispatches a touchend event with the released touch point(s) in
changedTouches. Moved points dispatch a touchmove event, with the moved
points in changedTouches. Old behaviour emitted only one touchstart when
the first point was pressed and one touchend when the last point was
released, and any events in between were touchmoves. New presses or
releases could only be detected by comparing the lists touches and
changedTouches.

  • fast/events/basic-touch-events-expected.txt:
  • fast/events/script-tests/basic-touch-events.js: (singleTouchSequence): (multiTouchSequence):

2010-01-07 Kim Grönholm <​kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Wrong state and TouchLists in TouchEvents
​https://bugs.webkit.org/show_bug.cgi?id=32878

Touch events changed to match the API and semantics of iPhone and
Android. Each new touch point press dispatches a touchstart event with
the pressed touch point(s) in the changedTouches list, and a release
dispatches a touchend event with the released touch point(s) in
changedTouches. Moved points dispatch a touchmove event, with the moved
points in changedTouches. Old behaviour emitted only one touchstart when
the first point was pressed and one touchend when the last point was
released, and any events in between were touchmoves. New presses or
releases could only be detected by comparing the lists touches and
changedTouches.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
  • page/EventHandler.h:

2010-01-07 Kim Grönholm <​kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Wrong state and TouchLists in TouchEvents
​https://bugs.webkit.org/show_bug.cgi?id=32878

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::touchStart): (EventSender::touchEnd): (EventSender::clearTouchPoints):
  • DumpRenderTree/qt/EventSenderQt.h:
5:43 AM Changeset in webkit [52921] by tkent@chromium.org
  • 105 edits
    3 deletes in trunk

2010-01-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Remove COM code generation stuff.
​https://bugs.webkit.org/show_bug.cgi?id=32854

Remove the followings:

  • CodeGeenratorCOM.pm, COM code generator,
"#if !defined(LANGUAGE_COM)
!LANGUAGE_COM" in IDL files, and
  • UUID attributes in IDL files.
  • bindings/scripts/CodeGeneratorCOM.pm: Removed.
  • css/CSSCharsetRule.idl:
  • css/CSSFontFaceRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSUnknownRule.idl:
  • css/CSSValue.idl:
  • css/CSSValueList.idl:
  • css/Counter.idl:
  • css/MediaList.idl:
  • css/RGBColor.idl:
  • css/Rect.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSKeyframeRule.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/Attr.idl:
  • dom/CDATASection.idl:
  • dom/CharacterData.idl:
  • dom/Comment.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Entity.idl:
  • dom/EntityReference.idl:
  • dom/Event.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeList.idl:
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
  • dom/Text.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLUListElement.idl:

2010-01-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Remove COM code generation files.
​https://bugs.webkit.org/show_bug.cgi?id=32854

  • WebKit.vcproj/DerivedSources.make: Removed.
  • WebKit.vcproj/build-generated-files.sh: Removed.
5:15 AM Changeset in webkit [52920] by vestbo@webkit.org
  • 1 edit in trunk/JavaScriptCore/jit/JIT.cpp

Unreviewed build fix for Qt on Mac OS X

4:16 AM Changeset in webkit [52919] by steveblock@google.com
  • 3 edits in trunk/WebCore

Android requires ability to increase layout delay

4:13 AM Changeset in webkit [52918] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-07 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Holger Freyther.

[Mac] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
​https://bugs.webkit.org/show_bug.cgi?id=33312

Using of operator += cause compile error on Mac, so it is changed to
"= static_cast<AllocAlignmentInteger*>(old_ptr) + 1".

  • wtf/FastMalloc.cpp: (WTF::TCMallocStats::realloc):
4:12 AM Changeset in webkit [52917] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Reworked r52853 after r52876 rolled it out.
Chomp the pid variable before passing it to kill and read the contents of
the pidfile in a platform independent manner.
First pach of ​https://bugs.webkit.org/show_bug.cgi?id=33153.

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.

  • Scripts/run-webkit-tests:
3:50 AM Changeset in webkit [52916] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-01-07 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Adam Barth.

Created a module that runs the style package unit tests.

​https://bugs.webkit.org/show_bug.cgi?id=32973

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/style/unittests.py: Added.
3:44 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:40 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:35 AM Changeset in webkit [52915] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Some IDL files lack "," separators for extended attributes.
​https://bugs.webkit.org/show_bug.cgi?id=33190

To find such mistakes, IDLParser.pm rejects whitespace characters in
extended attribute names.

  • bindings/scripts/IDLParser.pm: parseExtendedAttributes rejects whitespace in a name.
  • css/WebKitCSSTransformValue.idl: Add missing ",".
  • dom/EventTarget.idl: ditto.
3:29 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:26 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:24 AM Changeset in webkit [52914] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] need an API to suspend and resume active Javascript DOM objects.
​https://bugs.webkit.org/show_bug.cgi?id=31673

Patch by Yongjun Zhang <​yongjun.zhang@nokia.com>, Laszlo Gombos <Laszlo Gombos> on 2010-01-07
Reviewed by Simon Hausmann.

Add suspend and resume DOM objects private API to QWebFrame.

  • Api/qwebframe.cpp:

(qt_suspendActiveDOMObjects):
(qt_resumeActiveDOMObjects):

2:52 AM Changeset in webkit [52913] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Adam Barth.

Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
WebKitCSSTransformValue.idl correctly.
​https://bugs.webkit.org/show_bug.cgi?id=33193

CodeGeneratorV8.pm doesn't handle inheritance very well and it
tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
which does not exist. Because WebKitCSSTransformValue inherits
CSSValueList and CSSValueList already has HadIndexGetter, we don't
need to do anything for WebKitCSSTransformValue about HasIndexGetter.

  • bindings/scripts/CodeGeneratorV8.pm: Reset $hasGetter for WebKitCSSTransformValue.
2:22 AM Changeset in webkit [52912] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Don't print a redundant message when confirming a diff
​https://bugs.webkit.org/show_bug.cgi?id=33315

Instead of saying "ERROR: User declined" we should just exit because
the use knows they just declined!

  • Scripts/webkitpy/steps/confirmdiff.py:
2:19 AM Changeset in webkit [52911] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-07 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Holger Freyther.

[Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
​https://bugs.webkit.org/show_bug.cgi?id=33312

Remove pByte (committed in r42344 from #20422), because pByte doesn't
exist and it is unnecessary.

  • wtf/FastMalloc.cpp: (WTF::TCMallocStats::realloc):
2:12 AM Changeset in webkit [52910] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-07 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Check style before uploading a patch
​https://bugs.webkit.org/show_bug.cgi?id=33314

  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/steps/checkstyle.py:
  • Scripts/webkitpy/steps/options.py:
1:51 AM Changeset in webkit [52909] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add prepare and post to webkit-patch main help
​https://bugs.webkit.org/show_bug.cgi?id=33313

  • Scripts/webkitpy/commands/upload.py:
12:57 AM Changeset in webkit [52908] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
​https://bugs.webkit.org/show_bug.cgi?id=33290

Add the Chromium builders to our list of core builders and test that our regexps work.
I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.

  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/buildbot_unittest.py:
12:49 AM Changeset in webkit [52907] by abarth@webkit.org
  • 13 edits
    1 move in trunk/WebKitTools

2010-01-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool needs a new name
​https://bugs.webkit.org/show_bug.cgi?id=28459

Rename bugzilla-tool to webkit-patch. Also, rename some commands to
make more sense with the new name.

  • Scripts/bugzilla-tool: Removed.
  • Scripts/webkit-patch: Added.
  • Scripts/webkit-tools-completion.sh:
  • Scripts/webkitpy/bugzilla_unittest.py:
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/download_unittest.py:
  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/queueengine.py:
  • Scripts/webkitpy/steps/completerollout.py:
12:36 AM Changeset in webkit [52906] by eric@webkit.org
  • 3 edits
    6 moves
    1 add in trunk/WebKitTools

2010-01-07 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Moved style-related modules to webkitpy.style sub-package.

​https://bugs.webkit.org/show_bug.cgi?id=32971

  • Scripts/check-webkit-style:
    • Updated import statement.
  • Scripts/test-webkitpy:
    • Updated import statements.
  • Scripts/webkitpy/cpp_style.py: Removed.
    • Moved to webkitpy/style.
  • Scripts/webkitpy/cpp_style_unittest.py: Removed.
    • Moved to webkitpy/style.
  • Scripts/webkitpy/style.py: Removed.
    • Moved to webkitpy/style/checker.py.
  • Scripts/webkitpy/style/init.py: Added.
    • Added containing webkitpy directory to package search path.
  • Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
  • Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
    • Updated import statement.
  • Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
  • Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
    • Update import statement.
  • Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
  • Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
  • Scripts/webkitpy/style_unittest.py: Removed.
    • Moved to webkitpy/style/checker_unittest.py.
  • Scripts/webkitpy/text_style.py: Removed.
    • Moved to webkitpy/style.
  • Scripts/webkitpy/text_style_unittest.py: Removed.
    • Moved to webkitpy/style.
12:22 AM Changeset in webkit [52905] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-07 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

Do not return strings whose handles are in near death state (that means
they might be GCed) or just empty.
​https://bugs.webkit.org/show_bug.cgi?id=31180

  • bindings/v8/V8Binding.cpp: (WebCore::v8ExternalString):
12:06 AM Changeset in webkit [52904] by eric@webkit.org
  • 18 edits
    4 adds in trunk

2010-01-06 MORITA Hajime <​morrita@gmail.com>

Reviewed by Nikolas Zimmermann.

SVG background color on selected text goes wrong when text has
gradient stroke.
​https://bugs.webkit.org/show_bug.cgi?id=33069

Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
and paint background and foreground in separate subphase.

  • svg/text/selection-background-color.xhtml: Added.
  • platform/mac/svg/text/selection-background-color-expected.checksum: Added.
  • platform/mac/svg/text/selection-background-color-expected.png: Added.
  • platform/mac/svg/text/selection-background-color-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.png:
  • platform/mac/svg/batik/text/textDecoration2-expected.checksum:
  • platform/mac/svg/batik/text/textDecoration2-expected.png:
  • platform/mac/svg/text/text-deco-01-b-expected.checksum:
  • platform/mac/svg/text/text-deco-01-b-expected.png:
  • platform/mac/svg/text/text-spacing-01-b-expected.checksum:
  • platform/mac/svg/text/text-spacing-01-b-expected.png:
  • platform/mac/svg/text/text-text-03-b-expected.checksum:
  • platform/mac/svg/text/text-text-03-b-expected.png:
  • platform/mac/svg/text/text-text-08-b-expected.checksum:
  • platform/mac/svg/text/text-text-08-b-expected.png: Re-baselined due to painting algorithm change.

2010-01-06 MORITA Hajime <​morrita@gmail.com>

Reviewed by Nikolas Zimmermann.

SVG background color on selected text goes wrong when text has
gradient stroke.
​https://bugs.webkit.org/show_bug.cgi?id=33069

Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
and paint background and foreground in separate subphase.

Test: svg/text/selection-background-color.xhtml

  • rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::SVGTextChunkWalker): Added m_setupBackgroundCallback, m_setupForegroundCallback (WebCore::SVGTextChunkWalker::setupBackground): (WebCore::SVGTextChunkWalker::setupForeground): Added.
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintCharacters): pass SVGTextPaintInfo instead of SVGPaintServer
  • rendering/SVGInlineTextBox.h: (WebCore::SVGTextPaintSubphase): (WebCore::SVGTextPaintInfo::SVGTextPaintInfo): Added.
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::walkTextChunks): Invoke setupBackground() and setupForeground() (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupBackgroundCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupForegroundCallback): (WebCore::SVGRootInlineBoxPaintWalker::activePaintServer): Added. (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::SVGRootInlineBox::paint):
Note: See TracTimeline for information about the timeline view.