⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 11, 2010:

11:25 PM Changeset in webkit [53117] by mjs@apple.com
  • 2 edits in trunk/WebKitSite

Not reviewed; updated for truth (and readability).

Fixed some wrong listings and reorganized this page.

  • security/security-group-members.html:
10:46 PM Changeset in webkit [53116] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-11 Kent Tamura <​tkent@chromium.org>

Unreviewd. Remove a duplicated line in an expectation file.

  • platform/mac-leopard/fast/text/find-kana-expected.txt:
9:53 PM Changeset in webkit [53115] by Darin Adler
  • 3 edits in trunk/LayoutTests

Try to get find-kana tests passing on Qt, Leopard, and Tiger.

  • platform/mac-leopard/fast/text/find-kana-expected.txt: Expect more failures.
  • platform/qt/fast/text/find-kana-expected.txt: Ditto.
5:48 PM Changeset in webkit [53114] by Darin Adler
  • 7 edits in trunk

Fix handling of unusual kana sequences in search
​https://bugs.webkit.org/show_bug.cgi?id=33506

Reviewed by Dan Bernstein.

WebCore:

  • editing/TextIterator.cpp:

(WebCore::composedVoicedSoundMark): Removed unnnecessary case for a
non-kana-letter character. This function only works for kana letters.
(WebCore::SearchBuffer::isBadMatch): Fixed voiced sound mark code to
properly handle cases where one character has a shorter list of
combining voiced sound marks than the other.

LayoutTests:

  • fast/text/find-kana-expected.txt: Updated.
  • fast/text/script-tests/find-kana.js: Added new tests for sequences

that do not have composed equivalents. This is needed to test the code
that compares voice marks. The old test cases didn't cover the combining
character code path because normalizing to NFC combined all the sequences.

  • platform/mac-leopard/fast/text/find-kana-expected.txt: Updated.
  • platform/qt/fast/text/find-kana-expected.txt: Updated.
5:22 PM Changeset in webkit [53113] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Victor Wang <​victorw@chromium.org>

Reviewed by Dimitri Glazkov.

Clear m_acceptedIndexOnAbandon flag when user accepts the selected index.

​https://bugs.webkit.org/show_bug.cgi?id=33499

TEST: manual-tests/chromium/onchange-reload-popup.html
It should be covered by the above test. The current
test shell does not support sending keyboard events to popup
list so use manual test for it.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::acceptIndex):
4:55 PM Changeset in webkit [53112] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after introduction of JS_NO_EXPORT

4:42 PM Changeset in webkit [53111] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Eric Seidel.

[GTK] Debug bots crashing in plugins/iframe-shims.html
​https://bugs.webkit.org/show_bug.cgi?id=33472

Call computeOffsetInContainerNode() instead of
offsetInContainerNode(), since we are not sure this is always
parent-anchored.

plugins/iframe-shims.html no longer ASSERTS

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
4:15 PM Changeset in webkit [53110] by Simon Fraser
  • 17 edits in trunk

2010-01-11 Simon Fraser <Simon Fraser>

Reviewed by Kevin Decker.

​https://bugs.webkit.org/show_bug.cgi?id=33455
Allows plugins to participate in accelerated compositing

For plugins using the CoreAnimation rendering mode, host their CALayers in the
accelerated compositing layer tree.

This requires making normal flow RenderLayers for RenderEmbeddedObjects when they represent
a plugin using this mode.

  • WebCore.base.exp: Export Node::setNeedsStyleRecalc() for use by WebKit.
  • WebCore.xcodeproj/project.pbxproj: Re-order files for sorting.
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::requiresLayer): Make a layer if the plugin is using accelerated compositing mode. (WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing): Asks whether the plugin has a layer, via PluginWidget.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer): RenderEmbeddedObjects should be normal flow layers, and self-painting layers.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Parent the plugin's layer in the GraphicsLayer when updating the layer configuration.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingLayer): (WebCore::RenderLayerCompositor::requiresCompositingForPlugin): RenderEmbeddedObjects that allow accelerated compositing trip accelerated compositing mode for the page.
4:09 PM Changeset in webkit [53109] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Fixed an uninitialized PluginView member (m_mode) which wasn't
set when constructed with a null PluginPackage*

​https://bugs.webkit.org/show_bug.cgi?id=33468

  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
4:02 PM Changeset in webkit [53108] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt

2010-01-11 William Siegrist <​wsiegrist@apple.com>

Sync new Disallow rules from build.webkit.org.

3:58 PM Changeset in webkit [53107] by wsiegrist@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html

2010-01-11 William Siegrist <​wsiegrist@apple.com>

Add Console and CQ Bot Status links to build.webkit.org. Sync CSS changes.

3:41 PM Changeset in webkit [53106] by eric@webkit.org
  • 7 edits in trunk

2010-01-11 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG radialGradient example radial-gradient-with-outstanding-focalPoint.svg fails
​https://bugs.webkit.org/show_bug.cgi?id=32201

  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:

2010-01-11 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG radialGradient example radial-gradient-with-outstanding-focalPoint.svg fails
​https://bugs.webkit.org/show_bug.cgi?id=32201

This patch moves every focalPoint that lies outside the circle defined by the radial
gradients central point and its radius to stay inside this circle, as demanded by the
SVG 1.1 specification.
We use r * 0.99 as maximum radius for the aforementioned circle, when determining where
the focalPoint is lying, to achieve compatibility with Firefox.

  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
3:35 PM Changeset in webkit [53105] by eric@webkit.org
  • 5 edits
    2 deletes in trunk/WebKitTools

2010-01-11 Eric Seidel <​eric@webkit.org>

No review, rolling out r53079.
​http://trac.webkit.org/changeset/53079
​https://bugs.webkit.org/show_bug.cgi?id=33197

Adam doens't think this actually works, and believe it caused
a regression ​https://bugs.webkit.org/show_bug.cgi?id=33488 so
rolling this out.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
  • Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
3:00 PM Changeset in webkit [53104] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=33493
Log redirect details to Network channel

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Log response code and Location header field value. Also, removed a redundant null check.
2:56 PM Changeset in webkit [53103] by Beth Dakin
  • 13 edits
    8 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=33491 REGRESSION:
Many SVG -webkit-shadow tests are currently failing (in the pixel
tests)
-and-
<rdar://problem/7501200>

Reviewed by Oliver Hunt.

The real fix here is to call inflateForShadow() on the repaintRect
in prepareToRenderSVGContent(). But in order to do that, I had to
move inflateForShadow() to a different class since functions in
SVGRenderBase cannot call each other. inflateForShadow() now exists
in SVGRenderStyle which I think makes some sense because a similar
function that returns a box shadow's extent exists on RenderStyle.

Now call inflateForShadow() through the SVGRenderStyle.

  • rendering/RenderForeignObject.cpp:

(WebCore::RenderForeignObject::computeRectForRepaint):

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::computeRectForRepaint):

  • rendering/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::computeRectForRepaint):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::computeRectForRepaint):

No longer implement inflateForShadow() here.

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent): Call new
inflateForShadow() through the SVGRenderStyle

  • rendering/SVGRenderSupport.h:

Implementation of inflateForShadow() now lives here.

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::getSVGShadowExtent):
(WebCore::SVGRenderStyle::inflateForShadow):

  • rendering/style/SVGRenderStyle.h:

LayoutTests: New tests for ​https://bugs.webkit.org/show_bug.cgi?id=33491
REGRESSION: Many SVG -webkit-shadow tests are currently failing (in
the pixel tests)
-and-
<rdar://problem/7501200>

Reviewed by Oliver Hunt.

I would like to note that this change fixes some existing layout
tests as well.

  • platform/mac/svg/css/shadow-with-large-radius-expected.checksum: Added.
  • platform/mac/svg/css/shadow-with-large-radius-expected.png: Added.
  • platform/mac/svg/css/shadow-with-large-radius-expected.txt: Added.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.checksum: Added.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.png: Added.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.txt: Added.
  • platform/mac/svg/css/stars-with-shadow-expected.checksum:
  • platform/mac/svg/css/stars-with-shadow-expected.png:
  • svg/css/shadow-with-large-radius.svg: Added.
  • svg/css/shadow-with-negative-offset.svg: Added.
2:52 PM Changeset in webkit [53102] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-11 Eric Seidel <​eric@webkit.org>

Rubber-stamped by Csaba Osztrogonac.

Web Inspector: External resource relative URLs cannot be navigated to from the Elements panel
​https://bugs.webkit.org/show_bug.cgi?id=33024

  • platform/qt/Skipped: Skip this new test, Qt's DRT doesn't support evaluateInWebInspector()
2:46 PM Changeset in webkit [53101] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=33411

Reviewed by Eric Seidel.

Missing updated test result for gtk.

  • platform/gtk/editing/deleting/5115601-expected.txt:
2:33 PM Changeset in webkit [53100] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-01-11 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Rewrite relative URLs in the ElementsTreeOutline to make them navigable

Targets for "src" and "href" attribute values in the Elements outline tree
are rewritten to full URLs whenever possible.
​https://bugs.webkit.org/show_bug.cgi?id=33024

  • inspector/elements-panel-rewrite-href-expected.txt: Added.
  • inspector/elements-panel-rewrite-href.html: Added.

2010-01-11 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Rewrite relative URLs in the ElementsTreeOutline to make them navigable

Targets for "src" and "href" attribute values in the Elements outline tree
are rewritten to full URLs whenever possible.
​https://bugs.webkit.org/show_bug.cgi?id=33024

Test: inspector/elements-panel-rewrite-href.html

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._rewriteAttrHref): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
  • inspector/front-end/inspector.js:
2:20 PM Changeset in webkit [53099] by oliver@apple.com
  • 2 edits in trunk/SunSpider

2010-01-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

Sunspider parse-only tests don't run
​https://bugs.webkit.org/show_bug.cgi?id=33489

Fix parse-only test list

  • tests/parse-only/LIST:
2:17 PM Changeset in webkit [53098] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

fast/text/international/japanese-kana-letters.html
removed by r53078, so it should be removed from skiplist.

  • platform/qt/Skipped: fast/text/international/japanese-kana-letters.html removed.
1:54 PM Changeset in webkit [53097] by ojan@chromium.org
  • 17 edits in trunk/LayoutTests

2010-01-11 Ojan Vafai <​ojan@chromium.org>

Reviewed by Simon Fraser.

Deflake transitions and animations tests.
​https://bugs.webkit.org/show_bug.cgi?id=30029

The transition-end-event tests all had arbitrary timeouts. Give a consistent
timeout to all of them. Give a generous 1 second of buffer to avoid any possibility
of flakiness. If all the transitionEnd events fire before then, the test still
completes without waiting for the timeout.

  • animations/change-keyframes.html: Increase the wiggle room. It's infrequently flaky now, but it is still a tad bit flaky without this extra wiggle room.
  • transitions/repeated-firing-background-color.html: Remove a gratuitous setTimeout.
  • transitions/transition-end-event-all-properties.html:
  • transitions/transition-end-event-attributes.html:
  • transitions/transition-end-event-container.html:
  • transitions/transition-end-event-helpers.js: (runTransitionTest.startTest): (runTransitionTest):
  • transitions/transition-end-event-left.html:
  • transitions/transition-end-event-multiple-01.html:
  • transitions/transition-end-event-multiple-02.html:
  • transitions/transition-end-event-multiple-03.html:
  • transitions/transition-end-event-multiple-04.html:
  • transitions/transition-end-event-nested.html:
  • transitions/transition-end-event-set-none.html:
  • transitions/transition-end-event-transform.html:
  • transitions/transition-end-event-window.html:
  • transitions/zero-duration-with-non-zero-delay-end.html:
1:46 PM Changeset in webkit [53096] by Darin Adler
  • 1 edit
    2 copies in trunk/LayoutTests

Try to get find-kana and find-russian tests passing on Qt.

  • platform/qt/fast/text/find-kana-expected.txt: Copied from fast/text/find-kana-expected.txt.
  • platform/qt/fast/text/find-russian-expected.txt: Copied from fast/text/find-russian-expected.txt.

Changed to expect failures because text searching does not use
ICU's usearch on this platform, and the non-usearch code is much
less capable.

1:31 PM Status created by alex@milowski.com
1:23 PM WebKit Team edited by jpetsovits@rim.com
Add areas of knowledge to my team member information. (diff)
1:04 PM MathML edited by alex@milowski.com
(diff)
12:35 PM Changeset in webkit [53095] by ap@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=33482
Add a test for Russian text search

  • fast/text/find-russian-expected.txt: Added.
  • fast/text/find-russian.html: Added.
  • fast/text/script-tests/find-russian.js: Added.
12:33 PM Changeset in webkit [53094] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

[Qt] Enable JIT and YARR_JIT if (CPU(X86_64) && OS(LINUX) && GCC_VERSION >= 40100)

Reviewed by Ariya Hidayat.

  • wtf/Platform.h:
12:19 PM Changeset in webkit [53093] by Darin Adler
  • 1 edit
    1 copy in trunk/LayoutTests

Try to get find-kana test passing on Tiger and Leopard.

  • platform/mac-leopard/fast/text/find-kana-expected.txt: Copied from fast/text/find-kana-expected.txt.

Changed to expect failures due to an older version of ICU on those platforms.

12:14 PM Changeset in webkit [53092] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Updated Windows expected results after r53085.

Reviewed by NOBODY.

  • platform/win/editing/selection/mixed-editability-10-expected.txt:
11:55 AM Changeset in webkit [53091] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-01-11 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=33481
Uninitialized data members in ArrayStorage


SunSpider reports no change.

  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): Initialize missing data members in the two cases where we don't use fastZeroedMalloc, so it doesn't happen automatically.
11:53 AM Changeset in webkit [53090] by sfalken@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix ChangeLog

11:45 AM Changeset in webkit [53089] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=33480

Improve debugging reliability for WTF on Windows.
Store WTF static library's PDB file into a better location.

11:42 AM Changeset in webkit [53088] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-01-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Attempt to fix windows builds, by removing the no-longer existant JSSVGPointListCustom.cpp from JSBindingsAllInOne.cpp.

  • bindings/js/JSBindingsAllInOne.cpp:
11:34 AM Changeset in webkit [53087] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.
Remove extraneous entries from def file causing build warning.

11:23 AM Changeset in webkit [53086] by Nikolas Zimmermann
  • 13 edits
    1 move
    7 adds
    1 delete in trunk

2010-01-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Adam Roben & Dirk Schulze.

svg <text> fails to update when setting x/y
​https://bugs.webkit.org/show_bug.cgi?id=22384

Introduce JSSVGPODListCustom, refactoring the existing custom code for SVG POD type lists.
(Currently SVGTransformList/SVGPointList was handled correctly, and SVGLengthList/SVGNumberList not)

Remove the need for custom JSSVG*List.cpp implementations, but instead tweak CodeGeneratorJS.pm,
to call into the new JSSVGPODListCustom methods. Fixes dynamic updates of the SVGTextElement
'rotate' & 'x'/'y' SVG DOM properties.

Tests: svg/custom/text-xy-updates-SVGList.xhtml

svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop.html


  • Android.jscbindings.mk: Remove old files from build, add the new header.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSSVGPODListCustom.h: Copied from bindings/js/JSSVGTransformListCustom.cpp. Refactored code to be sharable between all JSSVG*List classes. (WebCore::JSSVGPODListCustom::finishGetter): (WebCore::JSSVGPODListCustom::finishSetter): (WebCore::JSSVGPODListCustom::finishSetterReadOnlyResult): (WebCore::JSSVGPODListCustom::clear): (WebCore::JSSVGPODListCustom::initialize): (WebCore::JSSVGPODListCustom::getItem): (WebCore::JSSVGPODListCustom::insertItemBefore): (WebCore::JSSVGPODListCustom::replaceItem): (WebCore::JSSVGPODListCustom::removeItem): (WebCore::JSSVGPODListCustom::appendItem):
  • bindings/js/JSSVGPointListCustom.cpp: Removed.
  • bindings/js/JSSVGTransformListCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm: Forward any SVGList call on POD list types to the new JSSVGPODListCustom.
  • svg/SVGNumberList.cpp: Make SVGNumberList a SVGPODList, instead of a SVGList, to make dynamic updates work. (WebCore::SVGNumberList::SVGNumberList):
  • svg/SVGNumberList.h:
  • svg/SVGPointList.idl: Remove JSCCustom markers everywhere.
  • svg/SVGTransformList.idl: Ditto.

2010-01-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Adam Roben & Dirk Schulze.

svg <text> fails to update when setting x/y
​https://bugs.webkit.org/show_bug.cgi?id=22384

Add simple tests covering SVGLengthList & SVGNumberList updates.

  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.checksum: Added.
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.png: Added.
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
  • svg/custom/text-xy-updates-SVGList.xhtml: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-rotate-prop.js: Added. (executeTest):
10:04 AM Changeset in webkit [53085] by enrica@apple.com
  • 10 edits in trunk

Cannot focus on an empty editable span in a non editable div.
​https://bugs.webkit.org/show_bug.cgi?id=33411
<rdar://problem/5982901>

Reviewed by Darin Adler.

WebCore:

We now allow to set the focus inside an empty inline element if it is the only
editable element inside non-editable content.

  • dom/Position.cpp:

(WebCore::Position::isCandidate): Extended to allow positions in inline elements when
at the border between editable and non editable content.
(WebCore::Position::getInlineBoxAndOffset): Modified to be able to calculate the caret
position inside an empty inline.

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs): When merging, we don't always find a break
element, since now an editable inline is a VisiblePosition if it is at editability boundary.

  • editing/VisibleSelection.h: Updated comment on the use of Position member variables

instead of VisiblePosition.

  • page/Frame.cpp:

(WebCore::Frame::selectionLayoutChanged): Changed to avoid multiple calls to upstream and
downstream on the same position.

LayoutTests:

  • editing/deleting/6026335-expected.txt: Updated to reflect the lack of extra break element.
  • editing/selection/mixed-editability-10-expected.txt: Updated to cover the new case.
  • editing/selection/mixed-editability-10.html: Updated to cover the new case.
  • platform/mac/editing/deleting/5115601-expected.txt: Updated to reflect the lack of extra break element.
9:57 AM Changeset in webkit [53084] by kov@webkit.org
  • 5 edits in trunk

Revert 53075 since it caused ASSERTS to be hit.

9:16 AM Changeset in webkit [53083] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-01-06 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Nikolas Zimmermann.

[V8] IsRefPtrType() in CodeGeneratorV8.pm increases maintenance burden.
​https://bugs.webkit.org/show_bug.cgi?id=32994

Refactoring, covered by existings tests.

  • bindings/scripts/CodeGeneratorV8.pm: Reversed testing for ref-counted objects,

since there's a much smaller (and more stable) set of non-ref-counted ones.

9:08 AM Changeset in webkit [53082] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=33472
[GTK] Debug bots crashing in plugins/iframe-shims.html

Skip test that fails on bots, but passes locally, so we can
investigate.

9:05 AM Changeset in webkit [53081] by Nate Chapin
  • 1 edit
    4 adds in trunk/LayoutTests

2010-01-08 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Test that document.referrer is properly preserved through a redirect.

​https://bugs.webkit.org/show_bug.cgi?id=33407

  • http/tests/navigation/redirect-preserves-referrer-expected.txt: Added.
  • http/tests/navigation/redirect-preserves-referrer.html: Added.
  • http/tests/navigation/resources/redirect-to-referrer-check.pl: Added.
  • http/tests/navigation/resources/referrer.html: Added.
9:02 AM Changeset in webkit [53080] by knorton@google.com
  • 7 edits in trunk/WebCore

2010-01-11 Kelly Norton <​knorton@google.com>

Reviewed by Pavel Feldman.

Fixes the fact that timeline panel results are skewed by the use of DOM mutation events.
​https://bugs.webkit.org/show_bug.cgi?id=32846

Instead of using DOM mutation events in InspectorDOMAgent, InspectorController is now called
directly when the DOM is mutated.

  • dom/ContainerNode.cpp: Calls InspectorController directly when child nodes are added/removed. (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: Calls InspectorController directly when attributes are added/removed. (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::didRemoveDOMNode): (WebCore::InspectorController::didModifyDOMAttr):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::didModifyDOMAttr):
  • inspector/InspectorDOMAgent.h:
8:50 AM Changeset in webkit [53079] by abarth@webkit.org
  • 5 edits
    1 copy
    1 add in trunk/WebKitTools

2010-01-10 Adam Barth <​abarth@webkit.org>

Reviewed by David Kilzer.

bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
​https://bugs.webkit.org/show_bug.cgi?id=33197

We should just search for bug numbers in the ChangeLogs instead of in
the whole diff.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
  • Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
8:30 AM Changeset in webkit [53078] by Darin Adler
  • 3 edits
    3 adds
    2 deletes in trunk

REGRESSION: Japanese text search ignores small vs. large and voicing mark differences
​https://bugs.webkit.org/show_bug.cgi?id=30437
rdar://problem/7214058

Reviewed by Alexey Proskuryakov.

WebCore:

Test: fast/text/find-kana.html

  • editing/TextIterator.cpp:

(WebCore::isKanaLetter): Added.
(WebCore::isSmallKanaLetter): Added.
(WebCore::composedVoicedSoundMark): Added.
(WebCore::isCombiningVoicedSoundMark): Added.
(WebCore::containsKanaLetters): Added.
(WebCore::normalizeCharacters): Added.
(WebCore::SearchBuffer::SearchBuffer): Initialize the data members
m_targetRequiresKanaWorkaround and m_normalizedTarget.
(WebCore::SearchBuffer::isBadMatch): Added. Checks for matches that
ICU's default collation considers correct, but we consider incorrect.
(WebCore::SearchBuffer::search): Added code to call isBadMatch and
move to the next match with usearch_next if the result is true.

LayoutTests:

  • fast/text/international/japanese-kana-letters-expected.txt: Removed.
  • fast/text/international/japanese-kana-letters.html: Removed.
  • fast/text/find-kana-expected.txt: Added.
  • fast/text/find-kana.html: Added.
  • fast/text/script-tests/find-kana.js: Added.

This includes all the tests that were in the old test removed above, with three
differences:

1) Moved out of "international" directory because Mitz wants to phase that

directory out.

2) Added more tests to cover more cases involving things like decomposed

characters and different voice marks.

3) Used script-tests, so results list passing tests as well as failing tests.

We could still test even more, but this should at least cover all the lines of
code in the current bug fix patch.

8:15 AM Changeset in webkit [53077] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Add private API for QWebFrame scrolling, to maintain binary compatibility with Qt 4.6.

Reviewed by Holger Freyther.

This is just a temporary addition until we have introduced #ifdefs to allow
safely removing the private API again.

  • Api/qwebframe.cpp:

(qtwebkit_webframe_scrollRecursively):

7:52 AM Changeset in webkit [53076] by ddkilzer@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Created a unit-tested function to parse the header block of
a Git or SVN diff -- for future refactoring of svn-apply and
svn-unapply.

Patch by Chris Jerdonek <​chris.jerdonek@gmail.com> on 2010-01-11
Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=33447

  • Scripts/VCSUtils.pm:
    • Added parseDiffHeader().
    • Removed irrelevant comment from gitdiff2svndiff().
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
    • Added 48 unit tests for parseDiffHeader().
7:51 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
7:15 AM Changeset in webkit [53075] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

[GTK] couple fixes for signal emissions, and property notifications
​https://bugs.webkit.org/show_bug.cgi?id=33428

Fix commitedLoad being called where it should not, causing it to
be called one time too many in some cases. We now match Qt's and
Mac's behavior here.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
  • tests/testloading.c: (load_error_status_changed_cb):
5:16 AM QtWebKitReleases edited by Simon Hausmann
(diff)
4:23 AM Changeset in webkit [53074] by Csaba Osztrogonác
  • 1 edit
    6 adds in trunk/LayoutTests

Rubber-stamped by Holger Hans Peter Freyther.

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2010-01-11
[Qt] Add expected files for the following passing new tests.
Compared to the mac expected files these only differ in svg dumping style and font metrics.

  • platform/qt/fast/repaint/block-no-inflow-children-expected.txt: Added.
  • platform/qt/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
  • platform/qt/svg/custom/marker-referencePoint-expected.txt: Added.
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt: Added.
  • platform/qt/svg/text/selection-background-color-expected.txt: Added.
4:12 AM Changeset in webkit [53073] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix.

  • platform/qt/Skipped:
4:03 AM Changeset in webkit [53072] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-11 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text

  • accessibility/gtk/AccessibilityObjectWrapperAtk.h
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored): (webkit_accessible_text_get_caret_offset):
  • editing/gtk/SelectionControllerGtk.cpp: (SelectionController::notifyAccessibilityForSelectionChange)

Adjust the caret offset and object with focus to reflect the
unignored parent of the static text object which contains the
caret. This is necessary because the static text objects are
no longer being exposed to ATs.

3:48 AM Changeset in webkit [53071] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html fails on buildbot
​https://bugs.webkit.org/show_bug.cgi?id=33465

  • platform/qt/Skipped: fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html skipped.
3:35 AM Changeset in webkit [53070] by Nikolas Zimmermann
  • 45 edits in trunk/LayoutTests

2010-01-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Update SVG test baseline, after the SVG text painting changes, a while ago.
The differences are all below <0.1%, and only show up when running with --tolerance 0.

1:44 AM Changeset in webkit [53069] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2010-01-11 Kim Grönholm <​kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Touchevent coordinates are incorrect after page zoom and page scroll
​https://bugs.webkit.org/show_bug.cgi?id=32899

  • fast/events/touch-coords-in-zoom-and-scroll-expected.txt: Added.
  • fast/events/touch-coords-in-zoom-and-scroll.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:

2010-01-11 Kim Grönholm <​kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Touchevent coordinates are incorrect after page zoom and page scroll
​https://bugs.webkit.org/show_bug.cgi?id=32899

Test: fast/events/touch-coords-in-zoom-and-scroll.html

  • dom/Touch.cpp: (WebCore::contentsX): (WebCore::contentsY):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
1:20 AM Changeset in webkit [53068] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-11 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

Have "Paste and Match Style" fire the dom paste event.
​https://bugs.webkit.org/show_bug.cgi?id=30639

  • editing/execCommand/paste-and-match-style-event.html: Added.

2010-01-11 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

Have "Paste and Match Style" fire the dom paste event.
​https://bugs.webkit.org/show_bug.cgi?id=30639

Test: editing/execCommand/paste-and-match-style-event.html

  • editing/Editor.cpp: (WebCore::Editor::pasteAsPlainText):

Jan 10, 2010:

10:53 PM Changeset in webkit [53067] by oliver@apple.com
  • 2 edits in trunk/WebCore

Rollout renderpath culling as it once again breaks pixel tests.

10:14 PM Changeset in webkit [53066] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-01-10 Adam Barth <​abarth@webkit.org>

Rubber stamped by David Kilzer.

bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
​https://bugs.webkit.org/show_bug.cgi?id=33197

Fix a typo: Commmand -> Command.

  • Scripts/webkitpy/commands/abstractsequencedcommand.py:
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/multicommandtool.py:
10:09 PM Changeset in webkit [53065] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-10 Daniel Bates <​dbates@webkit.org>

Unreviewed, fix typo.


Fixed typo in test LayoutTests/fast/events/frame-programmatic-focus.html.
The word "frame" should be "iframe" in the string "<input> in frame blurred"
based on the context of the test. In particular, the line "<input> in iframe focused"
and the use of an iframe in the test.

  • fast/events/frame-programmatic-focus-expected.txt:
  • fast/events/frame-programmatic-focus.html:
9:36 PM Changeset in webkit [53064] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-10 Daniel Bates <​dbates@webkit.org>

Rubber-stamped by Eric Seidel.

Adding XSSAuditor test http/tests/security/xssAuditor/malformed-HTML.html
to the Qt Skipped file as it times out. We need to look into test further.
See bug #33460 for more details.

  • platform/qt/Skipped:
9:11 PM Changeset in webkit [53063] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Let webkit-patch work with options in $EDITOR
​https://bugs.webkit.org/show_bug.cgi?id=33414

The $EDITOR evironment variable might have command line options like
bbedit -w. This patch lets us run those $EDITORs.

  • Scripts/webkitpy/user.py:
8:55 PM Changeset in webkit [53062] by eric@webkit.org
  • 10 edits in trunk

2010-01-10 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
​https://bugs.webkit.org/show_bug.cgi?id=33319

"" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.

  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):
  • tests/mozilla/ecma_2/RegExp/properties-001.js: (AddRegExpCases):
  • tests/mozilla/js1_2/regexp/toString.js: Update relevant Mozilla tests (Mozilla has had this behavior since November 2003).

2010-01-10 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
​https://bugs.webkit.org/show_bug.cgi?id=33319

Add new test cases and adapt existing ones.

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/regexp-compile-expected.txt:
  • fast/js/script-tests/regexp-compile.js:
  • fast/regex/non-pattern-characters-expected.txt:
8:34 PM Changeset in webkit [53061] by Darin Adler
  • 120 edits in trunk/JavaScriptCore
  • tests/mozilla/ecma/Array/15.4.1.1.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.1.2.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.2.1-1.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.2.2-1.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.2.2-2.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.2.3.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.3.2.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.3.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.4.1.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.4.js: Added property allow-tabs.
  • tests/mozilla/ecma/LexicalConventions/7.7.4.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.13.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.16.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.18.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.2.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.4.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.5.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.7.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.1.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.2.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.3.1-3.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.3.1-4.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.3.js: Added property allow-tabs.
  • tests/mozilla/ecma/TypeConversion/9.5-2.js: Added property allow-tabs.
  • tests/mozilla/ecma/jsref.js: Modified property allow-tabs.
  • tests/mozilla/ecma/shell.js: Modified property allow-tabs.
  • tests/mozilla/ecma_2/LexicalConventions/keywords-001.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/RegExp/exec-001.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/String/match-004.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/String/replace-001.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/String/split-002.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/jsref.js: Modified property allow-tabs.
  • tests/mozilla/ecma_2/shell.js: Added property allow-tabs.
  • tests/mozilla/ecma_3/Date/shell.js: Modified property allow-tabs.
  • tests/mozilla/ecma_3/Exceptions/regress-181654.js: Added property allow-tabs.
  • tests/mozilla/ecma_3/RegExp/regress-209067.js: Added property allow-tabs.
  • tests/mozilla/ecma_3/RegExp/regress-85721.js: Added property allow-tabs.
  • tests/mozilla/importList.html: Added property allow-tabs.
  • tests/mozilla/js1_1/shell.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/general1.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/general2.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/slice.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/splice1.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/splice2.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Objects/toString-001.js: Added property allow-tabs.
  • tests/mozilla/js1_2/String/charCodeAt.js: Added property allow-tabs.
  • tests/mozilla/js1_2/String/concat.js: Modified property allow-tabs.
  • tests/mozilla/js1_2/String/match.js: Added property allow-tabs.
  • tests/mozilla/js1_2/String/slice.js: Added property allow-tabs.
  • tests/mozilla/js1_2/function/Function_object.js: Added property allow-tabs.
  • tests/mozilla/js1_2/function/Number.js: Modified property allow-tabs.
  • tests/mozilla/js1_2/function/String.js: Modified property allow-tabs.
  • tests/mozilla/js1_2/function/nesting.js: Added property allow-tabs.
  • tests/mozilla/js1_2/function/regexparg-1.js: Added property allow-tabs.
  • tests/mozilla/js1_2/function/regexparg-2-n.js: Added property allow-tabs.
  • tests/mozilla/js1_2/jsref.js: Added property allow-tabs.
  • tests/mozilla/js1_2/operator/equality.js: Added property allow-tabs.
  • tests/mozilla/js1_2/operator/strictEquality.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_dollar_number.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_input.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_input_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastIndex.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastMatch.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastMatch_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastParen.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastParen_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_leftContext.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_leftContext_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_multiline.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_multiline_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_object.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_rightContext.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_rightContext_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/alphanumeric.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/asterisk.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/backslash.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/backspace.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/beginLine.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/character_class.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/compile.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/control_characters.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/digit.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/dot.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/endLine.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/everything.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/exec.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/flags.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/global.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/hexadecimal.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/ignoreCase.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/interval.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/octal.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/parentheses.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/plus.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/question_mark.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/simple_form.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/source.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/special_characters.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/string_replace.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/string_search.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/string_split.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/test.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/toString.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/vertical_bar.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/whitespace.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/word_boundary.js: Added property allow-tabs.
  • tests/mozilla/js1_2/shell.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/break.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/continue.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/do_while.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/switch.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/switch2.js: Added property allow-tabs.
  • tests/mozilla/js1_3/shell.js: Added property allow-tabs.
  • tests/mozilla/js1_4/shell.js: Added property allow-tabs.
  • tests/mozilla/js1_5/Regress/regress-111557.js: Added property allow-tabs.
  • tests/mozilla/js1_5/Regress/regress-216320.js: Added property allow-tabs.
  • tests/mozilla/menuhead.html: Added property allow-tabs.
  • tests/mozilla/mklistpage.pl: Added property allow-tabs.
  • tests/mozilla/runtests.pl: Added property allow-tabs.
8:09 PM Changeset in webkit [53060] by eric@webkit.org
  • 9 edits in trunk

2010-01-10 Robert Hogan <​robert@roberthogan.net>

Reviewed by Adam Barth.

[Qt] Add enableXSSAuditor support to QWebSettings and DRT.

​https://bugs.webkit.org/show_bug.cgi?id=33419

  • platform/qt/Skipped:

2010-01-10 Robert Hogan <​robert@roberthogan.net>

Reviewed by Adam Barth.

[Qt] Add enableXSSAuditor support to QWebSettings and DRT.

​https://bugs.webkit.org/show_bug.cgi?id=33419

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-01-10 Robert Hogan <​robert@roberthogan.net>

Reviewed by Adam Barth.

[Qt] Add enableXSSAuditor support to QWebSettings and DRT.

​https://bugs.webkit.org/show_bug.cgi?id=33419

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
7:47 PM Changeset in webkit [53059] by Simon Fraser
  • 5 edits in trunk/WebCore

2010-01-10 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Allows plugins to participate in accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=33455

Part 1: rename setContentsToVideo() on GraphicsLayer to setContentsToMedia()
to make it more general. Rename associated enums and methods similarly.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToMedia):
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToMedia): (WebCore::GraphicsLayerCA::commitLayerChanges): (WebCore::GraphicsLayerCA::updateContentsMediaLayer):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
7:41 PM Changeset in webkit [53058] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

http/tests/messaging/cross-domain-message-event-dispatch.html failed on Gtk Linux 64-Bit Debug Bot
​https://bugs.webkit.org/show_bug.cgi?id=33458

Fix flakey test. If the machine is very slow, then more than 10ms
might have elapsed between registering the timeout and calling
postMessage. We can't be sure which order they will be called in.
Re-ordering the call guarantees the arrival order, even if it reduces
our coverage slightly.

  • http/tests/messaging/cross-domain-message-event-dispatch.html:
6:59 PM Changeset in webkit [53057] by oliver@apple.com
  • 2 edits in trunk/WebCore

Bad DOM performance in large SVG files
​https://bugs.webkit.org/show_bug.cgi?id=30055

Reviewed by Nikolas Zimmerman

Cull RenderPaths before passing on to the underlying graphics system.

4:47 PM Changeset in webkit [53056] by abarth@webkit.org
  • 6 edits
    8 adds in trunk

2010-01-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Add defensive initialization of iframe sandbox flags
​https://bugs.webkit.org/show_bug.cgi?id=32368

Test the mutating the allow-same-origin directive in the sandbox
attribute does not affect the current document (but does affect the
next document).

  • http/tests/security/resources/sandboxed-iframe-origin-add-step1.html: Added.
  • http/tests/security/resources/sandboxed-iframe-origin-add-step2.html: Added.
  • http/tests/security/resources/sandboxed-iframe-origin-remove-step1.html: Added.
  • http/tests/security/resources/sandboxed-iframe-origin-remove-step2.html: Added.
  • http/tests/security/sandboxed-iframe-origin-add-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-origin-add.html: Added.
  • http/tests/security/sandboxed-iframe-origin-remove-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-origin-remove.html: Added.

2010-01-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Add defensive initialization of iframe sandbox flags
​https://bugs.webkit.org/show_bug.cgi?id=32368

We now initialize the SecurityOrigin's sandbox state directly duing
construction. This lets us properly set the isUnique bit.

Tests: http/tests/security/sandboxed-iframe-origin-add.html

http/tests/security/sandboxed-iframe-origin-remove.html

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::setSandboxFlags):
  • page/SecurityOrigin.h:
4:38 PM Changeset in webkit [53055] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-10 Adam Barth <​abarth@webkit.org>

Reviewed by Nikolas Zimmermann.

http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
​https://bugs.webkit.org/show_bug.cgi?id=33349

Previously we were using JavaScript URLs to return to the main event
loop, but that is potentially unreliable because there can be only one
scheduled redirect in flight per frame. Let's try using setTimeout
instead. Notice that there isn't a race condition here because the
event loop will always dispatch the actions in the proper order.

  • http/tests/security/xss-DENIED-window-open-javascript-url.html:
2:53 PM Changeset in webkit [53054] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-10 Adam Barth <​abarth@webkit.org>

Unreviewed cosmetic change. Remove the status bubble for mac-ews
because we don't have hardware for it at the moment.

  • QueueStatusServer/templates/statusbubble.html:
1:30 PM Changeset in webkit [53053] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-01-10 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Inspect Element selects the wrong element.
Drive-by fix that focuses dom tree upon settting focuesDOMNode.

​https://bugs.webkit.org/show_bug.cgi?id=33449

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/treeoutline.js: (TreeElement.prototype.select):
1:04 PM QtWebKitJournal edited by Simon Hausmann
(diff)
11:15 AM Changeset in webkit [53052] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-01-10 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce support for flexible line height in the text editor.

​https://bugs.webkit.org/show_bug.cgi?id=33431

11:06 AM Changeset in webkit [53051] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-01-10 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not repaint line numbers while editing within line.

​https://bugs.webkit.org/show_bug.cgi?id=33427

2:27 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:14 AM Changeset in webkit [53050] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-01-10 Adam Barth <​abarth@webkit.org>

Unreviewed whitespace fixes.

  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateSandboxFlags):
  • loader/FrameLoader.h:
12:10 AM Changeset in webkit [53049] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-01-09 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Unify origin sandbox flag with m_noAccess in SecurityOrigin
​https://bugs.webkit.org/show_bug.cgi?id=32372

It turns out the SandboxOrigin bit is slightly different than the
unique origin concept because the sandbox bit is inherited by iframes.
These concepts are separate in the spec, so I think it's ok to keep
them separate in the implementation as well.

No new tests because there is no behavior change.

  • dom/Document.cpp: (WebCore::Document::cookie): (WebCore::Document::setCookie):
  • loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck):
  • page/SecurityOrigin.cpp: (WebCore::schemesWithUniqueOrigins): (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::taintsCanvas): (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::toString): (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage): (WebCore::SecurityOrigin::canAccessCookies): (WebCore::SecurityOrigin::isUnique):
Note: See TracTimeline for information about the timeline view.