⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 13, 2010:

11:42 PM Changeset in webkit [53242] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-01-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: use hidden text area for clipboard in order to
workaround windows setData bug.

​https://bugs.webkit.org/show_bug.cgi?id=33633

  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._copy):
  • inspector/front-end/inspector.css:
11:35 PM Changeset in webkit [53241] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Mads Ager <​ager@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Slow named property lookup on DOMWindow because of missing fast case
​https://bugs.webkit.org/show_bug.cgi?id=33584

Add fast case checks to V8 named property getter on DOMWindow
objects. If the property is not in the DOM there is no reason to
search the DOM for all occurrences.

Covered by layout tests.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::namedPropertyGetter):
10:45 PM Changeset in webkit [53240] by barraclough@apple.com
  • 6 edits in trunk/WebCore

<rdar://problem/7403736> REGRESSION (r49963,r49965): 8% Dromaeo Core DOM test regression

Reviewed by Oliver Hunt.

Adding isolated worlds support to the JSC bindings introduced a regression due to
additional map lookups. Add a mechanism to quickly detect that a lookup is for the
'normal' world, and add fast paths to a couple of methods to check the normal world
first.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::Document::getWrapperCache):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::forgetDOMObject):

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMWrapperWorld::isNormal):
(WebCore::WebCoreJSClientData::WebCoreJSClientData):

  • bindings/js/ScriptController.cpp:

(WebCore::IsolatedWorld::IsolatedWorld):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::createWrapperCache):

  • dom/Document.h:
10:37 PM Changeset in webkit [53239] by eric@webkit.org
  • 7 edits in trunk

2010-01-13 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Oliver Hunt.

JSON.stringify and JSON.parse needlessly process properties in the prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=33053

  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::walk):

2010-01-13 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Oliver Hunt.

JSON.stringify and JSON.parse needlessly process properties in the prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=33053

Add tests that verify that properties in the prototype chain are ignored.

  • fast/js/JSON-parse-expected.txt:
  • fast/js/JSON-stringify-expected.txt:
  • fast/js/resources/JSON-parse.js:
  • fast/js/resources/JSON-stringify.js:
9:50 PM Changeset in webkit [53238] by eric@webkit.org
  • 25 edits
    1 copy
    6 adds in trunk

2010-01-13 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Need to implement WebGLContextAttributes
​https://bugs.webkit.org/show_bug.cgi?id=31169

Added the WebGLContextAttributes class and custom JavaScript
bindings to accept a native object as the second argument to
getContext("experimental-webgl") per the WebGL specification.
Added GraphicsContext3D::Attributes struct to isolate DOM and
graphics layers. Added getContextAttributes() to
WebGLRenderingContext. Added test case ensuring that context
attributes can be passed down and returned. Tested in Safari and
Chromium. The attributes will be hooked up to the creation of the
OpenGL context in bug 33416.

  • fast/canvas/webgl/context-attributes-expected.txt: Added.
  • fast/canvas/webgl/context-attributes.html: Added.
  • fast/canvas/webgl/resources/webgl-test.js: (create3DContext):

2010-01-13 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Need to implement WebGLContextAttributes
​https://bugs.webkit.org/show_bug.cgi?id=31169

Added the WebGLContextAttributes class and custom JavaScript
bindings to accept a native object as the second argument to
getContext("experimental-webgl") per the WebGL specification.
Added GraphicsContext3D::Attributes struct to isolate DOM and
graphics layers. Added getContextAttributes() to
WebGLRenderingContext. Added test case ensuring that context
attributes can be passed down and returned. Tested in Safari and
Chromium. The attributes will be hooked up to the creation of the
OpenGL context in bug 33416.

Test: fast/canvas/webgl/context-attributes.html

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/IDLParser.pm:
  • bindings/v8/DOMData.cpp:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext):
  • html/HTMLCanvasElement.h:
  • html/HTMLCanvasElement.idl:
  • html/canvas/CanvasContextAttributes.cpp: Added. (WebCore::CanvasContextAttributes::CanvasContextAttributes): (WebCore::CanvasContextAttributes::~CanvasContextAttributes):
  • html/canvas/CanvasContextAttributes.h: Added.
  • html/canvas/WebGLContextAttributes.cpp: Added. (WebCore::WebGLContextAttributes::create): (WebCore::WebGLContextAttributes::WebGLContextAttributes): (WebCore::WebGLContextAttributes::~WebGLContextAttributes): (WebCore::WebGLContextAttributes::alpha): (WebCore::WebGLContextAttributes::setAlpha): (WebCore::WebGLContextAttributes::depth): (WebCore::WebGLContextAttributes::setDepth): (WebCore::WebGLContextAttributes::stencil): (WebCore::WebGLContextAttributes::setStencil): (WebCore::WebGLContextAttributes::antialias): (WebCore::WebGLContextAttributes::setAntialias): (WebCore::WebGLContextAttributes::premultipliedAlpha): (WebCore::WebGLContextAttributes::setPremultipliedAlpha): (WebCore::WebGLContextAttributes::attributes):
  • html/canvas/WebGLContextAttributes.h: Added.
  • html/canvas/WebGLContextAttributes.idl: Added.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::getContextAttributes):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::getContextAttributes):

2010-01-13 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Need to implement WebGLContextAttributes
​https://bugs.webkit.org/show_bug.cgi?id=31169

Added the WebGLContextAttributes class and custom JavaScript
bindings to accept a native object as the second argument to
getContext("experimental-webgl") per the WebGL specification.
Added GraphicsContext3D::Attributes struct to isolate DOM and
graphics layers. Added getContextAttributes() to
WebGLRenderingContext. Added test case ensuring that context
attributes can be passed down and returned. Tested in Safari and
Chromium. The attributes will be hooked up to the creation of the
OpenGL context in bug 33416.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::getContextAttributes):
9:00 PM Changeset in webkit [53237] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-01-13 Simon Fraser <Simon Fraser>

Fix Windows build.

  • platform/graphics/cg/GraphicsContextCG.cpp:
8:54 PM Changeset in webkit [53236] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-01-13 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Transition followed by animation fails to run the animation sometimes
​https://bugs.webkit.org/show_bug.cgi?id=33563

If a transition was closely followed by an animation, it was possible for the cleanup
after the end of the transition to kill the animation.

Fix this by including the keyframes name (or empty string for transitions) in the labels
used to identify CAAnimations on layers.

No test because this was a subtle timing issue that is hard to reproduce in a layout test.

  • platform/graphics/mac/GraphicsLayerCA.h: Some new methods and signature changes.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::animationIdentifier): Pass the keyframes name, since this is included in the identifier string now. (WebCore::moveAllAnimationsForProperty): Pass the keyframes name. (WebCore::GraphicsLayerCA::moveAnimationsForProperty): Try to move both transition- and animation-related CAAnimations, using the list of running animations to get the keyframe names for the latter.

(WebCore::GraphicsLayerCA::ensureStructuralLayer): moveAnimation renamed to moveAnimationsForProperty
and takes the keyframes name.

(WebCore::GraphicsLayerCA::updateLayerAnimations): Pass keyframes name down (or "" for transitions).
(WebCore::GraphicsLayerCA::setAnimationOnLayer): Pass keyframes name down.
(WebCore::GraphicsLayerCA::removeAnimationFromLayer): Pass keyframes name down.
(WebCore::GraphicsLayerCA::pauseAnimationOnLayer): Pass keyframes name down.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Pass keyframes name down.

8:44 PM Changeset in webkit [53235] by Simon Fraser
  • 3 edits
    6 adds in trunk

2010-01-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix shadow drawing to do the correct computations using the base coordinate space
​https://bugs.webkit.org/show_bug.cgi?id=33629

Shadows draw using the CGContext base CTM, so we need to convert the shadow offet
and size from user CTM into into base CTM coordinates, via the matix obtained from wkGetUserToBaseCTM().

Test: compositing/shadows/shadow-drawing.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
8:32 PM Changeset in webkit [53234] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-01-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Update Qt slave result after last SVG commit.

  • platform/qt/svg/css/clippath-with-shadow-expected.txt:
8:09 PM Changeset in webkit [53233] by Nikolas Zimmermann
  • 32 edits in trunk

2010-01-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Oliver Hunt.

SVGClipPathElement shouldn't resolve style manually
​https://bugs.webkit.org/show_bug.cgi?id=33647

Build renderers for SVGClipPathElement, so we can query the style from the renderer
instead of re-resolving style on every clip path resource invalidation.

  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::createRenderer): (WebCore::SVGClipPathElement::canvasResource):
  • svg/SVGClipPathElement.h: (WebCore::SVGClipPathElement::isValid):
7:47 PM Changeset in webkit [53232] by knorton@google.com
  • 5 edits in trunk/WebCore

2010-01-13 Kelly Norton <​knorton@google.com>

Reviewed by Timothy Hatcher.

Web Inspector does not update the DOM tree when attributes change.
​https://bugs.webkit.org/show_bug.cgi?id=20162

  • dom/Element.cpp: Moves callbacks to InspectorController directly into setAttribute and removeAttribute and removes the existing call sites. This makes it possible to see attribute modifications. (WebCore::Element::setAttribute): (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent): (WebCore::Element::removeAttribute):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._setAttributesPayload): Clear existing attributes. (WebInspector.DOMAgent.prototype._didApplyDomChange): Updated call site and fixed style. (WebInspector.DOMAgent.prototype._attributesUpdated): Added.
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._attributesUpdated): Added. (WebInspector.ElementsPanel.prototype.updateModifiedNodes): Updated call site.
  • inspector/front-end/ElementsTreeOutline.js: Renamed _updateTitle to updateTitle. (WebInspector.ElementsTreeElement.prototype.onattach): Updated updateTitle call site. (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto. (WebInspector.ElementsTreeElement.prototype._editingCancelled): Ditto.
7:31 PM Changeset in webkit [53231] by Nikolas Zimmermann
  • 2 edits
    18 deletes in trunk/LayoutTests

2010-01-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Remove six old tiger specific results, that are equal to the SL baseline now. Update one result, showing a marginal difference between Tiger/SL.
This is a follow-up commit for Dirks strokeBoundingBox() fixes -> should turn Tiger slave green again.

  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.checksum: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.checksum: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac-tiger/svg/W3C-SVG-1.1/paths-data-01-t-expected.checksum: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.png: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Removed.
  • platform/mac-tiger/svg/custom/control-points-for-S-and-T-expected.checksum: Removed.
  • platform/mac-tiger/svg/custom/control-points-for-S-and-T-expected.png: Removed.
  • platform/mac-tiger/svg/custom/control-points-for-S-and-T-expected.txt: Removed.
  • platform/mac-tiger/svg/text/text-path-01-b-expected.checksum: Removed.
  • platform/mac-tiger/svg/text/text-path-01-b-expected.png: Removed.
  • platform/mac-tiger/svg/text/text-path-01-b-expected.txt: Removed.
7:30 PM Changeset in webkit [53230] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Darin Adler.

CounterNode::nextInPreOrderAfterChildren(stayWithin) does not stay within.
​https://bugs.webkit.org/show_bug.cgi?id=33625

No new tests because the fix should affect strictly performance.

  • rendering/CounterNode.cpp: (WebCore::CounterNode::nextInPreOrderAfterChildren):
7:05 PM Changeset in webkit [53229] by Nikolas Zimmermann
  • 14 edits
    4 adds in trunk

2010-01-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Oliver Hunt.

Window size changes are not propagated down the render tree
​https://bugs.webkit.org/show_bug.cgi?id=33643

Test: svg/custom/relative-sized-content.xhtml

  • rendering/RenderSVGContainer.cpp: Fix incorrect markParents=true usage, leading to unnecessary relayouts. (WebCore::RenderSVGContainer::layout): Use new layoutChildren() method. (WebCore::RenderSVGContainer::paint): Fix indention.
  • rendering/RenderSVGHiddenContainer.cpp: Fix incorrect markParents=true usage. (WebCore::RenderSVGHiddenContainer::layout): Use new layoutChildren() helper.
  • rendering/RenderSVGRoot.cpp: Refactor existing code to layout children in SVGRenderSupport::layoutChildren. (WebCore::RenderSVGRoot::layout): Make children relayouting depend on width/height changes, if the outermost svg uses relative viewport sizes.
  • rendering/SVGRenderSupport.cpp: Add central place handling child layout, skips relayouting non-relative sized children as benefit. (WebCore::SVGRenderBase::layoutChildren): This methods contains the actual changes.
  • rendering/SVGRenderSupport.h:
  • svg/SVGGElement.h: Remove dead code.
  • svg/SVGSVGElement.h: Make hasRelativeValues() public to remove the need for friendship declarations.
  • svg/SVGStyledElement.h: Change default return value for hasRelativeValues() to false, as it was intended. (WebCore::SVGStyledElement::hasRelativeValues): Make it public, to be usable from SVGRenderSupport.
  • svg/SVGSymbolElement.h: Remove dead code.
  • svg/SVGUseElement.cpp: Implement hasRelativeValues() - it was simply missing here. (WebCore::SVGUseElement::hasRelativeValues):
  • svg/SVGUseElement.h:
6:57 PM Changeset in webkit [53228] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix CloseBugForLandDiff unittest to actually run
​https://bugs.webkit.org/show_bug.cgi?id=33640

  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
6:46 PM Changeset in webkit [53227] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-13 Fumitoshi Ukai <​ukai@chromium.org>

Unreviewed.

Enable websocket/tests/workers/worker-simple.html again.

  • platform/mac/Skipped: rm websocket/tests/workers/worker-simple.html
6:23 PM Changeset in webkit [53226] by ukai@chromium.org
  • 2 edits in trunk/WebCore

2010-01-13 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by David Levin.

Fix websocket/tests/worker/worker-simple.html crash on Leopard Intel Debug (Tests) builder
​https://bugs.webkit.org/show_bug.cgi?id=33581

unref m_workerContext when websocket is disconnected, so that avoid
keeping reference to workerContext longer than worker thread runs.

  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect): (WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion):
5:56 PM Changeset in webkit [53225] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (buildfix).

5:36 PM Changeset in webkit [53224] by ap@apple.com
  • 3 edits
    3 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=33641
Assertion failure in Lexer.cpp if input stream ends while in string escape

Test: fast/js/end-in-string-escape.html

  • parser/Lexer.cpp: (JSC::Lexer::lex): Bail out quickly on end of stream, not giving the assertion a chance to fire.
5:29 PM Changeset in webkit [53223] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (buildfix).

5:28 PM Changeset in webkit [53222] by Simon Fraser
  • 6 edits in trunk

2010-01-13 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

<rdar://problem/7532544>

Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
be used for a shadow drawing fix.

5:20 PM Changeset in webkit [53221] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Rubber stamped by Sam Weinig & Darin Adler.

Three quick fixes to UStringImpl.

  • The destroy() method can be switched back to a normal destructor; since we've switched the way we protect static strings to be using an odd ref-count the destroy() won't abort.
  • The cost() calculation logic was wrong. If you have multiple JSStrings wrapping substrings of a base string, they would each report the full cost of the base string to the heap. Instead we should only be reporting once for the base string.
  • Remove the overloaded new operator calling fastMalloc, replace this with a 'using' to pick up the implementation from the parent class.

(JSC::UStringImpl::~UStringImpl):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::cost):
(JSC::UStringImpl::deref):

5:16 PM Changeset in webkit [53220] by jhoneycutt@apple.com
  • 17 edits
    2 adds in trunk

MSAA: selected, selectable, extended selectable, and multiple
selectable states are not reported

​https://bugs.webkit.org/show_bug.cgi?id=33574
<rdar://problem/7536826>

Reviewed by Darin Adler.

WebCore:

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isMultiSelectable):
Use the correct function name - the function name overriden by
and used in AccessiblityRenderObject.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(setAtkStateSetFromCoreObject):
Update for function rename.
(webkit_accessible_selection_select_all_selection):
Ditto.

WebKit/chromium:

  • public/WebAccessibilityObject.h:

Update for WebCore::AccessibilityObject function rename.

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::isMultiSelectable):
Ditto.

WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::get_accState):
Remove the call to isMultiSelect(). Call the correctly-named
isMultiSelectable(), and if it returns true, set both the "extended
selectable" and "multiple selectable" states. Check whether the object
is selected or selectable, and report those states.

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getIsSelectableCallback):
Return the result of calling isSelectable().
(getIsMultiSelectableCallback):
Return the result of calling isMultiSelectable().
(AccessibilityUIElement::getJSClass):
Add isSelected and isMultiSelectable properties to the JSClass
definition.

  • DumpRenderTree/AccessibilityUIElement.h:

Declare isSelectable() and isMultiSelectable().

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isSelectable):
Stubbed.
(AccessibilityUIElement::isMultiSelectable):
Stubbed.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isSelectable):
Stubbed.
(AccessibilityUIElement::isMultiSelectable):
Stubbed.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(accessibilityState):
Get the object's state, and return it.
(AccessibilityUIElement::isSelected):
Check the object's selected state.
(AccessibilityUIElement::isSelectable):
Check the object's selectable state.
(AccessibilityUIElement::isMultiSelectable):
Check the object's extended/multiple selectable state.

LayoutTests:

  • accessibility/selection-states-expected.txt: Added.
  • accessibility/selection-states.html: Added.
  • platform/gtk/Skipped:

Add new test to skipped list due to stubbed AccessibilityUIElement
functions.

  • platform/mac/Skipped:

Ditto.

5:14 PM Changeset in webkit [53219] by cmarrin@apple.com
  • 4 edits in trunk/WebKitLibraries

2010-01-13 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

<rdar://problem/7532544>


Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
be used for a shadow drawing fix. Once more, with feeling. On Windows.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
5:01 PM Changeset in webkit [53218] by Darin Adler
  • 9 edits in trunk

Move more of the selection and caret painting code from Frame to SelectionController.
​https://bugs.webkit.org/show_bug.cgi?id=33619

Reviewed by Dan Bernstein.

WebCore:

Helpful preparation step for a bug fix I am working on.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::SelectionController): Initialize new data members.
Note that m_caretVisible starts as true for the drag caret controller to match the
old behavior for painting.
(WebCore::SelectionController::setSelection): Changed to call selectionLayoutChanged
in its new name and location.
(WebCore::SelectionController::paintCaret): Added checks that were formerly done
at the Frame level. Tweaked formatting and changed to use early return as well.
(WebCore::SelectionController::focusedOrActiveStateChanged): Updated for call
moved into this class.
(WebCore::SelectionController::updateAppearance): Moved the
Frame::selectionLayoutChanged function here. Had to rename it because the word
"layout" is usedfor other purposes in this function.
(WebCore::SelectionController::setCaretVisible): Moved here from Frame.
(WebCore::SelectionController::clearCaretRectIfNeeded): Ditto.
(WebCore::SelectionController::caretBlinkTimerFired): Ditto.

  • editing/SelectionController.h: Added new functions. Moved conditional function

out of class definition for clarity. Removed unneeded == and != operators.
Removed unneeded use of bit fields.

  • page/Frame.cpp: Moved functions to SelectionController.

(WebCore::Frame::Frame): Removed initialization of moved data members.

  • page/Frame.h: Removed things moved to SelectionController as well as unneeded

forward declaration of Timer class template.

  • page/FrameView.cpp:

(WebCore::FrameView::layout): Updated for new location of function.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintCaret): Ditto.

WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::inputMethodEvent): Seems possibly wrong to be directly invoking this
setCaretVisible here, but I updated it to call it in its new location.

4:55 PM Changeset in webkit [53217] by abarth@webkit.org
  • 3 edits
    1 copy in trunk/WebKitTools

2010-01-13 Adam Barth <​abarth@webkit.org>

Unreviewed. Repeat the below for CloseBugForLandDiff.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/steps/closebugforlanddiff.py:
  • Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
4:49 PM Changeset in webkit [53216] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-13 Adam Barth <​abarth@webkit.org>

Unreviewed. Turn the mac-ews status bubbles back on now that this bot
is running again.

  • QueueStatusServer/templates/statusbubble.html:
4:49 PM Changeset in webkit [53215] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
​https://bugs.webkit.org/show_bug.cgi?id=33634

Deal with the case of no bug patch object in the state.

  • Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
  • Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
4:20 PM Changeset in webkit [53214] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Cleaning up quota-tracking.html. Removing trailing whitespaces and
fixing the errorFunction() to work correctly with both
transaction() and executeSql().

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=33628

  • storage/quota-tracking.html:
4:13 PM Changeset in webkit [53213] by cmarrin@apple.com
  • 3 edits in trunk/WebKitLibraries

2010-01-13 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

<rdar://problem/7532544>


Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
be used for a shadow drawing fix.


  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
4:08 PM Changeset in webkit [53212] by kbr@google.com
  • 2 edits in trunk/WebKitTools

2010-01-13 Kenneth Russell <​kbr@google.com>

Unreviewed; added myself to the committers list.

  • Scripts/webkitpy/committers.py:
4:07 PM Changeset in webkit [53211] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-01-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix shadow drawing to do the correct computations using the base coordinate space
​https://bugs.webkit.org/show_bug.cgi?id=33629

Step 1: do some renames in setPlatformShadow():

size -> offset
width -> xOffset
height -> yOffset

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
4:05 PM CommitterTips edited by adele@apple.com
(diff)
3:51 PM CommitterTips edited by adele@apple.com
(diff)
3:49 PM CommitterTips edited by eric@webkit.org
Update bugzilla-tool to webkit-patch (diff)
3:38 PM Changeset in webkit [53210] by jorlow@chromium.org
  • 8 edits in trunk

2010-01-13 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
​https://bugs.webkit.org/show_bug.cgi?id=33492

  • public/WebKitClient.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::createSessionStorageNamespace):
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):

2010-01-13 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
​https://bugs.webkit.org/show_bug.cgi?id=33492

  • page/Page.cpp: (WebCore::Page::sessionStorage):
  • storage/StorageNamespace.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
  • storage/StorageNamespace.h: (WebCore::StorageNamespace::~StorageNamespace):
3:33 PM Changeset in webkit [53209] by Simon Fraser
  • 5 edits in trunk/WebKitLibraries

2010-01-13 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

<rdar://problem/7532544>

Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
be used for a shadow drawing fix.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
3:31 PM Changeset in webkit [53208] by Darin Adler
  • 4 edits in trunk/WebKitTools

Ignore compiled Python in more of webkitpy.

  • Scripts/webkitpy/commands: Added property svn:ignore.
  • Scripts/webkitpy/steps: Added property svn:ignore.
  • Scripts/webkitpy/style: Added property svn:ignore.
2:42 PM Changeset in webkit [53207] by krit@webkit.org
  • 29 edits
    4 adds in trunk

2010-01-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Beth Dakin.

Repaint bug dragging a star shape with a dash stroke
​https://bugs.webkit.org/show_bug.cgi?id=33406

Calculation of repaint rects for RenderPath objects was wrong. We must take the
union of strokeBoundingBox and objectBoundingBox, since the strokeBoundingBox
must not contain the objectBoundingBox. This is mainly visible on dash-arrays for
strokes.

Test: svg/custom/js-repaint-rect-on-path-with-stroke.svg

  • rendering/RenderPath.cpp: (WebCore::RenderPath::strokeBoundingBox):

2010-01-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Beth Dakin.

Repaint bug dragging a star shape with a dash stroke
​https://bugs.webkit.org/show_bug.cgi?id=33406

Calculation of repaint rects for RenderPath objects was fixed. We take the
union of strokeBoundingBox and objectBoundingBox. Since DRT results depend
on the repaint rect, many results needed an update.
Added a new test, that makes the wrong calculation visible.

  • js-repaint-rect-on-path-with-stroke.svg
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/mac/svg/batik/text/textOnPath-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/verticalText-expected.txt:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/mac/svg/css/composite-shadow-example-expected.txt:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/mac/svg/custom/animate-path-morphing-expected.txt:
  • platform/mac/svg/custom/control-points-for-S-and-T-expected.txt:
  • platform/mac/svg/custom/dasharrayOrigin-expected.txt:
  • platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.checksum: Added.
  • platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
  • platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Added.
  • platform/mac/svg/custom/path-textPath-simulation-expected.txt:
  • platform/mac/svg/text/text-path-01-b-expected.txt:
  • svg/custom/js-repaint-rect-on-path-with-stroke.svg: Added.
2:28 PM Changeset in webkit [53206] by kevino@webkit.org
  • 3 edits in trunk/WebCore

[wx] Build fix. Make the XFORM operator work on wx port.

2:12 PM Changeset in webkit [53205] by pfeldman@chromium.org
  • 8 edits
    1 add in trunk/WebCore

2010-01-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce SourceFrame2 with basic breakpoint / execution line
rendering capabilities.

Contains a drive-by naming fix (lineNumberOffset and lineNumberToOffset were
too close to each other, but were unrelated).

​https://bugs.webkit.org/show_bug.cgi?id=33618

2:10 PM Changeset in webkit [53204] by Nate Chapin
  • 6 edits in trunk/WebCore

2010-01-13 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Generate a function in the V8 bindings to convert v8 objects
to native WebCore objects.

  • bindings/scripts/CodeGeneratorV8.pm: Generate and use toNative().
  • bindings/v8/V8Binding.cpp: Remove manually defined conversion helprs. (WebCore::getElementStringAttr): (WebCore::setElementStringAttr):
  • bindings/v8/V8Binding.h: Remove manually defined conversion helprs.
  • bindings/v8/V8SVGPODTypeWrapper.h: Still need a manually defined coversion helper for SVGPODTypes. (WebCore::V8SVGPODTypeWrapper::toNative):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::V8WebGLRenderingContext::getProgramParameterCallback): (WebCore::V8WebGLRenderingContext::getShaderParameterCallback): (WebCore::V8WebGLRenderingContext::getUniformCallback):
1:59 PM Changeset in webkit [53203] by bweinstein@apple.com
  • 5 edits in trunk

WebCore: REGRESSION (r49268): DHTML drag not allowed unless event.dataTransfer.effectAllowed
is set (differs from HTML5).
Fixes <​https://bugs.webkit.org/show_bug.cgi?id=33607> and <rdar://7507114>.

Reviewed by Adam Roben.

If no effectAllowed is set in the dragStart operation, we should default to
uninitialized instead of none, so the user doesn't have to manually set the
effectAllowed to enable drag and drop.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard):

LayoutTests: REGRESSION (r49268): DHTML drag not allowed unless event.dataTransfer.effectAllowed
is set (differs from HTML5).
Fixes <​https://bugs.webkit.org/show_bug.cgi?id=33607> and <rdar://7507114>.

Reviewed by Adam Roben.

Updated the drag and drop test to test if effectAllowed isn't set, in addition
to its other tests.

  • fast/events/drag-and-drop-expected.txt:
  • fast/events/drag-and-drop.html:
1:35 PM Changeset in webkit [53202] by sfalken@apple.com
  • 8 edits
    3 adds in trunk/WebKit/win

Add additional Geolocation interfaces in WebKit for Windows.

Reviewed by Adam Roben.

  • Interfaces/IWebGeolocationPolicyListener.idl: Added.
  • Interfaces/IWebUIDelegatePrivate.idl: Add decidePolicyForGeolocationRequest to IWebUIDelegatePrivate2.

Append since this version hasn't shipped.

  • Interfaces/WebKit.idl: Add include of IWebGeolocationPolicyListener.idl.
  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::requestGeolocationPermissionForFrame): Call into decidePolicyForGeolocationRequest.

  • WebCoreSupport/WebGeolocationControllerClient.cpp:

(WebGeolocationControllerClient::WebGeolocationControllerClient): Moved *.

  • WebGeolocationPolicyListener.cpp: Added.
  • WebGeolocationPolicyListener.h: Added.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPolicyListener.
  • WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPolicyListener, WebGeolocationPolicyListener.
  • WebView.cpp:

(WebView::setGeolocationProvider): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationProvider): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationDidChangePosition): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationDidFailWithError): Removed extraneous STDMETHODCALLTYPE.

1:27 PM Changeset in webkit [53201] by eric@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

2010-01-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Beth Dakin.

This tests don't pass on Leopard but on Snow Leopard with tolereance of 0.
Created Leopard specific pixel test results since they do not fail.

  • platform/mac-leopard/svg/css: Added.
  • platform/mac-leopard/svg/css/composite-shadow-example-expected.checksum: Added.
  • platform/mac-leopard/svg/css/composite-shadow-example-expected.png: Added.
  • platform/mac-leopard/svg/css/group-with-shadow-expected.checksum: Added.
  • platform/mac-leopard/svg/css/group-with-shadow-expected.png: Added.
1:23 PM Changeset in webkit [53200] by hyatt@apple.com
  • 2 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=32495

Reviewed by Dan Bernstein.

font-size:small with background-color causes text to get clipped. Make sure to only paint within the lineTop/lineBottom of
a line for quirky inline flow boxes that didn't contribute to the overall height of the line.

Added fast/backgrounds/quirks-mode-line-boxes-backgrounds.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

1:11 PM Changeset in webkit [53199] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Beth Dakin.

Add tests to check filter, mask, clip, opacity and marker ordering
​https://bugs.webkit.org/show_bug.cgi?id=14010

This is a follow up. The order of filter and clipping was changes in bug 14010
according to the Spec. Forgot to update this test.

  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.checksum:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
1:09 PM Changeset in webkit [53198] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Refactoring DatabaseAuthorizer to use a CaseFoldingHash function
for the set of whitelisted sqlite functions, and fixing some
indenting issues.

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=33612

  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::allowFunction):

  • storage/DatabaseAuthorizer.h:
12:56 PM Changeset in webkit [53197] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Beth Dakin.

Speed-up SVG Masking
​https://bugs.webkit.org/show_bug.cgi?id=32738

This is a followup. The way how masks are created changed and caused
some results to update. Forgot to update this one.

  • platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
12:46 PM SVG TODO List - Short notes edited by krit@webkit.org
(diff)
12:40 PM Changeset in webkit [53196] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Darin Adler.

RenderObject::nextInPreOrderAfterChildren(RenderObject* stayWithin) does not stay within
​https://bugs.webkit.org/show_bug.cgi?id=33600

No new tests as this fix affects mainly performance.
No test has been found yet that could evidence the bug in the layout
of a page, but the fix to bug 32884 exposes this bug on some pages
such as ​http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/counters-scope-implied-001.htm

  • rendering/RenderObject.cpp: (WebCore::RenderObject::nextInPreOrderAfterChildren):
12:34 PM Changeset in webkit [53195] by kdecker@apple.com
  • 4 edits in trunk/WebKit

​https://bugs.webkit.org/show_bug.cgi?id=33610
<rdar://problem/7288546> Silverlight full screen performance problem seen on Snow Leopard.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView _workaroundSilverlightFullScreenBug:]): Added. Work around Silverlight full screen performance issue by maintaining an accelerated GL pixel format. We can safely remove this at some point in the future when both Microsoft releases a genuine fix for 7288546 and enough Silverlight users update to the new Silverlight. For now, we'll distinguish older broken versions of Silverlight by asking the plug-in if it resolved its full screen badness. (-[WebNetscapePluginView _createPlugin]): Call _workaroundSilverlightFullScreenBug:YES if this is Silverlight. (-[WebNetscapePluginView _destroyPlugin]): Call _workaroundSilverlightFullScreenBug:NO if this is Silverlight.

​https://bugs.webkit.org/show_bug.cgi?id=33610
<rdar://problem/7288546> Silverlight full screen performance problem seen on Snow Leopard.

  • WebKit.xcodeproj/project.pbxproj: Link the project against OpenGL.
11:18 AM Changeset in webkit [53194] by jorlow@chromium.org
  • 8 edits in trunk

WebCore: No reviewer. More or less a build fix. My 53180 broke some
stuff on the Chromium port so I'm reverting.

Patch by Jeremy Orlow <​jorlow@chromium.org> on 2010-01-13

  • page/Page.cpp:

(WebCore::Page::sessionStorage):

  • storage/StorageNamespace.cpp:

(WebCore::StorageNamespace::sessionStorageNamespace):

  • storage/StorageNamespace.h:

(WebCore::StorageNamespace::~StorageNamespace):

WebKit/chromium: No reviewer. More or less a build fix. My 53180 broke some
stuff on the Chromium port so I'm reverting.

Patch by Jeremy Orlow <​jorlow@chromium.org> on 2010-01-13

  • public/WebKitClient.h:
  • public/WebViewClient.h:
  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespace::sessionStorageNamespace):

10:30 AM Changeset in webkit [53193] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Steve Block <​steveblock@google.com>

Update appendClassName in jni_runtime.cpp to use WebCore::StringBuilder, rather than JSC::StringBuilder.
​https://bugs.webkit.org/show_bug.cgi?id=33586

Avoiding the JSC version of StringBuilder allows this file to be used with both JSC and V8 on Android.

No new tests, refactoring only.

  • bridge/jni/jni_runtime.cpp: Modified. (JavaMethod::signature): Modified. Use WebCore::StringBuilder.
10:14 AM Changeset in webkit [53192] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Timothy Hatcher.

Some objects in the global scope are not completed
​https://bugs.webkit.org/show_bug.cgi?id=19119

Use Object.getOwnPropertyNames instead of for-in to provide completions, since
Object.getOwnPropertyNames reports both enumerable and non-enumerable properties.

  • inspector/front-end/InjectedScript.js: (InjectedScript._getPropertyNames): (InjectedScript.getCompletions):
9:03 AM Changeset in webkit [53191] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Ben Murdoch <​benm@google.com>

Reviewed by Simon Hausmann.

[Android] [Qt] The JSC ScriptController does not consider Touch Events user gestures.
​https://bugs.webkit.org/show_bug.cgi?id=33597

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGestureEvent): Add the touch event types (touchstart, touchmove and touchend) to the set of events that are considered user gestures.
8:49 AM Changeset in webkit [53190] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKitTools

[Qt] Fix build problem related to the pushd command

Reviewed by Simon Hausmann.

  • Scripts/webkitdirs.pm:
8:46 AM Changeset in webkit [53189] by Simon Hausmann
  • 2 edits in trunk/WebCore

Rubber-stamped by Tor Arne Vestbø.

[Qt] REGRESSION(53187) Touchevent related tests fail

​https://bugs.webkit.org/show_bug.cgi?id=33602

Pass the ENABLE_TOUCH_EVENTS to the IDL generators.

  • WebCore.pri:
8:31 AM Changeset in webkit [53188] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Timeline panel scrolling speed can be increased.
​https://bugs.webkit.org/show_bug.cgi?id=33579

8:06 AM Changeset in webkit [53187] by Simon Hausmann
  • 9 edits
    4 adds in trunk

[Qt] Split the build process in two different .pro files.
This allows qmake to be run once all source files are available.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2010-01-13
Reviewed by Simon Hausmann.

.:

  • DerivedSources.pro: Added.
  • WebKit.pri:

JavaScriptCore:

  • DerivedSources.pro: Added.
  • JavaScriptCore.pri: Moved source generation to DerivedSources.pro
  • pcre/pcre.pri: Moved source generation to DerivedSources.pro

WebCore:

  • DerivedSources.pro: Added.
  • WebCore.pri: Added. Contains common logic between source generation and compilation.
  • WebCore.pro: Moved source generation to DerivedSources.pro.

WebKitTools:

  • Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
7:55 AM Changeset in webkit [53186] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-01-13 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed tiny typo fix in docstrings.

  • Scripts/webkitpy/style/checker_unittest.py:
7:52 AM Changeset in webkit [53185] by hamaji@chromium.org
  • 5 edits in trunk/WebKitTools

2010-01-13 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Shinichiro Hamaji.

Created a CategoryFilter class to encapsulate the logic of
filter rules.

​https://bugs.webkit.org/show_bug.cgi?id=33454

  • Scripts/webkitpy/style/checker.py:
    • Added CategoryFilter class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added CategoryFilter unit tests.
  • Scripts/webkitpy/style/cpp_style.py:
    • Updated filter methods to use CategoryFilter.
  • Scripts/webkitpy/style/cpp_style_unittest.py:
    • Updated references to filters.
7:24 AM Changeset in webkit [53184] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-01-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Scrolling editor to the 20Kth line is not smooth.

​https://bugs.webkit.org/show_bug.cgi?id=33587

  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype._highlightChanged): (WebInspector.TextEditor.prototype._paintLinesContinuation):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._highlightInChunks): (WebInspector.TextEditorHighlighter.prototype.updateHighlight): (WebInspector.TextEditorHighlighter.prototype._highlightLines): (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype._setLine): (WebInspector.TextEditorModel.prototype.setAttribute): (WebInspector.TextEditorModel.prototype.getAttribute): (WebInspector.TextEditorModel.prototype.removeAttribute):
5:49 AM Changeset in webkit [53183] by Simon Hausmann
  • 3 edits in trunk/WebCore

[Qt] Fix the build on Windows.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2010-01-13
Reviewed by Simon Hausmann.

PluginViewWin.cpp requires the conversion operator from TransformationMatrix to XFORM.

  • WebCore.pro: Build TransformationMatrixWin.cpp.
  • platform/graphics/transforms/TransformationMatrix.h: Enable the conversion operator to XFORM.
2:31 AM QtWebKitTableOfFeatures46 edited by Henry Haverinen
(diff)
2:27 AM QtWebKitTableOfFeatures46 created by Henry Haverinen
2:12 AM QtWebKitFeatures46 edited by Henry Haverinen
(diff)
1:23 AM Changeset in webkit [53182] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-13 Fumitoshi Ukai <​ukai@chromium.org>

Unreviewed.

Add websocket/tests/workers/worker-simple.html, because it starts
crash after r53174

  • platform/mac/Skipped: Add websocket/tests/workers/worker-simple.html
1:18 AM Changeset in webkit [53181] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt/Symbian] Added missing vendor information to qtwebkit.sis

Patch by Miikka Heikkinen <​miikka.heikkinen@digia.com> on 2010-01-13
Reviewed by Simon Hausmann.

This information is necessary to Symbian sign the package.

​http://bugreports.qt.nokia.com/browse/QTBUG-7290

  • WebCore.pro:

Jan 12, 2010:

10:51 PM Changeset in webkit [53180] by jorlow@chromium.org
  • 8 edits in trunk

2010-01-11 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
​https://bugs.webkit.org/show_bug.cgi?id=33492

  • public/WebKitClient.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::getSessionStorageNamespace):
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):

2010-01-11 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
​https://bugs.webkit.org/show_bug.cgi?id=33492

  • page/Page.cpp: (WebCore::Page::sessionStorage):
  • storage/StorageNamespace.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
  • storage/StorageNamespace.h: (WebCore::StorageNamespace::~StorageNamespace):
10:12 PM Changeset in webkit [53179] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. Now I can review :)

  • Scripts/webkitpy/committers.py:
9:23 PM WebKit Team edited by hamaji@chromium.org
(diff)
7:33 PM Changeset in webkit [53178] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

<rdar://problem/7512726> Flash full-screen does not work correctly with Flash 10.1 beta

Reviewed by Darin Adler.

Explicitly track when the plug-in shows and hides a full-screen window to determine
whether a plug-in is currently full-screen, rather than relying on menu bar visibility.
This ensures that we activate the plug-in host process and client application as
appropriate when the plug-in enters or exits full-screen.

  • Plugins/Hosted/NetscapePluginHostProxy.h:

(WebKit::NetscapePluginHostProxy::isFullScreenWindowShowing):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::setMenuBarVisible):
(WebKit::NetscapePluginHostProxy::didEnterFullScreen):
(WebKit::NetscapePluginHostProxy::didExitFullScreen):
(WebKit::NetscapePluginHostProxy::setFullScreenWindowIsShowing):
(WKPCSetMenuBarVisible):
(WKPCSetFullScreenWindowIsShowing):

  • Plugins/Hosted/WebKitPluginClient.defs:
7:29 PM Changeset in webkit [53177] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Adding a list of whitelisted sqlite functions that users are
allowed to use.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33549

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::authorizerFunction):

  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
(WebCore::DatabaseAuthorizer::addWhitelistedFunctions):
(WebCore::DatabaseAuthorizer::allowFunction):

  • storage/DatabaseAuthorizer.h:
6:48 PM Changeset in webkit [53176] by ukai@chromium.org
  • 2 edits
    1 move in trunk/WebCore

2010-01-12 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Simon Hausmann.

[Qt][WebSocket] SocketStreamHandleSoup.cpp is misnamed
​https://bugs.webkit.org/show_bug.cgi?id=33077

  • WebCore.pro:
  • platform/network/qt/SocketStreamHandleQt.cpp: Copied from WebCore/platform/network/qt/SocketStreamHandleSoup.cpp.
  • platform/network/qt/SocketStreamHandleSoup.cpp: Removed.
6:33 PM Changeset in webkit [53175] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/rendering/RenderLayer.cpp

Build Fix.

6:09 PM Changeset in webkit [53174] by ukai@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-01-12 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Darin Adler.

Add a test of WebSockets for shared workers
​https://bugs.webkit.org/show_bug.cgi?id=33285

  • websocket/tests/workers/resources/worker-simple.js:
  • websocket/tests/workers/shared-worker-simple-expected.txt: Added.
  • websocket/tests/workers/shared-worker-simple.html: Added.
6:08 PM Changeset in webkit [53173] by Simon Fraser
  • 4 edits
    4 adds in trunk

2010-01-12 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

position:fixed and transform on same element breaks fixed behavior
​https://bugs.webkit.org/show_bug.cgi?id=31283

Fix interactions of transforms and fixed positioning, namely that fixed position
elements with a transformed ancestor are positioned relative to that ancestor,
and an element with both a transform and fixed position respects that positioning.

Test: transforms/2d/transform-fixed-container.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint): Transforms should not unconditionally stop the propagation of the 'fixed' flag to ancestors, but only if the transformed element is not itself fixed.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::convertToLayerCoords): Fix this method to behave correctly for fixed position layers whose container is not the root, but some other (probably transformed) ancestor. In that case, we can fall into the "position: absolute" code path.
6:04 PM Changeset in webkit [53172] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Replacing RANDOMBLOB with ZEROBLOB, as RANDOMBLOB will soon be
disallowed by the authorizer.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=33396

  • storage/quota-tracking.html:
5:29 PM Changeset in webkit [53171] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

Fix an assert being triggered by how the Chromium port sets the
replacing flag for error pages. This was caused by r53143.

Covered by existing Chromium UI tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
4:58 PM Changeset in webkit [53170] by eric@webkit.org
  • 48 edits
    3 adds in trunk

2010-01-12 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

[ES5] Implement Object.getOwnPropertyNames
​https://bugs.webkit.org/show_bug.cgi?id=32242

Add an extra argument to getPropertyNames() and getOwnPropertyNames()
(and all reimplementations thereof) that indicates whether non-enumerable
properties should be added.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertyNames):
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::getOwnPropertyNames):
  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertyNames):
  • runtime/Arguments.h:
  • runtime/CommonIdentifiers.h:
  • runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertyNames):
  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::getOwnPropertyNames):
  • runtime/JSByteArray.h:
  • runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertyNames):
  • runtime/JSFunction.h:
  • runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::getOwnPropertyNames):
  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp: (JSC::getClassPropertyNames): (JSC::JSObject::getPropertyNames): (JSC::JSObject::getOwnPropertyNames):
  • runtime/JSObject.h:
  • runtime/JSVariableObject.cpp: (JSC::JSVariableObject::getOwnPropertyNames):
  • runtime/JSVariableObject.h:
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyNames):
  • runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::getOwnPropertyNames):
  • runtime/StringObject.cpp: (JSC::StringObject::getOwnPropertyNames):
  • runtime/StringObject.h:
  • runtime/Structure.cpp: Rename getEnumerablePropertyNames() to getPropertyNames(), which takes an extra argument. (JSC::Structure::getPropertyNames):
  • runtime/Structure.h: (JSC::):

2010-01-12 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

[ES5] Implement Object.getOwnPropertyNames
​https://bugs.webkit.org/show_bug.cgi?id=32242

Add new argument to the reimplementation of getOwnPropertyNames().

  • UserObjectImp.cpp: (UserObjectImp::getOwnPropertyNames):
  • UserObjectImp.h:

2010-01-12 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

[ES5] Implement Object.getOwnPropertyNames
​https://bugs.webkit.org/show_bug.cgi?id=32242

Add tests for Object.getOwnPropertyNames(o), both standard usage and cross origin.

  • fast/js/Object-getOwnPropertyNames-expected.txt: Added.
  • fast/js/Object-getOwnPropertyNames.html: Added.
  • fast/js/script-tests/Object-getOwnPropertyNames.js: Added.
  • http/tests/security/cross-frame-access-enumeration-expected.txt:
  • http/tests/security/cross-frame-access-enumeration.html:

2010-01-12 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

[ES5] Implement Object.getOwnPropertyNames
​https://bugs.webkit.org/show_bug.cgi?id=32242

Add new argument to reimplementations of getPropertyNames()
and getOwnPropertyNames(), and update the JS bindings generator.

Test: fast/js/Object-getOwnPropertyNames.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyNames): (WebCore::JSDOMWindow::getOwnPropertyNames):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::getPropertyNames): (WebCore::JSDOMWindowShell::getOwnPropertyNames):
  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getOwnPropertyNames):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getOwnPropertyNames):
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::getPropertyNames): (WebCore::JSQuarantinedObjectWrapper::getOwnPropertyNames):
  • bindings/js/JSQuarantinedObjectWrapper.h:
  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getOwnPropertyNames):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertyNames):
  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getPropertyNames): (JSC::RuntimeObjectImp::getOwnPropertyNames):
  • bridge/runtime_object.h:
4:16 PM Changeset in webkit [53169] by bweinstein@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Add correct expected results after r53168 for GTK and Qt.

  • platform/gtk/fast/block: Added.
  • platform/gtk/fast/block/positioning: Added.
  • platform/gtk/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
  • platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
3:39 PM Changeset in webkit [53168] by bweinstein@apple.com
  • 6 edits
    2 adds in trunk

Safari shows an unneeded horizontal scrollbar on many websites.
Fixes <rdar://6321041> and <​http://webkit.org/b/33555>.

Reviewed by Dave Hyatt.

WebCore:

If a div has no children, and its height or width are 0, we can ignore
it in our calculation of lowest, rightmost, and leftmost positions. This
calculation was causing horizontal scrollbars to be drawn when they weren't needed.

Test: fast/block/positioning/absolute-positioning-no-scrollbar.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lowestPosition): Added check for no children and width or height 0.
(WebCore::RenderBlock::rightmostPosition): Ditto.
(WebCore::RenderBlock::leftmostPosition): Ditto.

LayoutTests:

Added a test that shows no scrollbar in the case where a div has no children
and either a width or height of 0. Also updated results for a few tests which
this patch causes progressions for.

  • fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
  • fast/block/positioning/absolute-positioning-no-scrollbar.html: Added.
  • fast/block/positioning/fixed-positioning-scrollbar-bug.html:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
3:34 PM Changeset in webkit [53167] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Optimize WebInspector.TimelineGrid.prototype.updateDividers()

DOM element property access and modification are slow and should be done as lazily as possible.
​https://bugs.webkit.org/show_bug.cgi?id=33536

  • inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype._setDividerAndBarLeft):
3:10 PM Changeset in webkit [53166] by Beth Dakin
  • 3 edits
    4 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=33550 REGRESSION: -
webkit-svg-shadow with opacity still over-clipped

Reviewed by Sam Weinig.

We need to call inflateForShadow() on the repaintRect before we
clip for opacity or we will over-clip.

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=33550 REGRESSION:
-webkit-svg-shadow with opacity still over-clipped

Reviewed by Sam Weinig.

  • platform/mac/svg/css/shadow-and-opacity-expected.checksum: Added.
  • platform/mac/svg/css/shadow-and-opacity-expected.png: Added.
  • platform/mac/svg/css/shadow-and-opacity-expected.txt: Added.
  • svg/css/shadow-and-opacity.svg: Added.
2:48 PM Changeset in webkit [53165] by sfalken@apple.com
  • 12 edits
    6 adds in trunk

WebCore: Update all-in-one derived sources for Geolocation.

Reviewed by Sam Weinig.

  • DerivedSources.cpp: Add JSCoordinates.cpp, JSGeolocation.cpp, JSGeoposition.cpp, JSPositionError.cpp

WebKit/win: Add Geolocation interfaces in WebKit for Windows.

Reviewed by Adam Roben, Sam Weinig.

  • ForEachCoClass.h: Added WebGeolocationPosition.
  • Interfaces/IWebError.idl:
  • Interfaces/IWebGeolocationPosition.idl: Added.
  • Interfaces/IWebGeolocationProvider.idl: Added.
  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebGeolocationControllerClient.cpp: Added.

(WebGeolocationControllerClient::WebGeolocationControllerClient):
(WebGeolocationControllerClient::startUpdating):
(WebGeolocationControllerClient::stopUpdating):
(WebGeolocationControllerClient::lastPosition):

  • WebCoreSupport/WebGeolocationControllerClient.h: Added.
  • WebGeolocationPosition.cpp: Added IWebGeolocationPosition implementation.
  • WebGeolocationPosition.h: Added IWebGeolocationPosition implementation.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPosition.idl, IWebGeolocationProvider.idl,

relocated JavaScriptCoreAPITypes.idl, WebScrollbarTypes.idl

  • WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPosition.h/.cpp, WebGeolocationControllerClient.h/cpp,
  • WebKitClassFactory.cpp: Add WebGeolocationPosition include.
  • WebView.cpp:

(WebView::initWithFrame): Create WebGeolocationControllerClient if Geolocation is enabled.
(WebView::setGeolocationProvider): Added Geolocation-specific method.
(WebView::geolocationProvider): Added Geolocation-specific method.
(WebView::geolocationDidChangePosition): Added Geolocation-specific method.
(WebView::geolocationDidFailWithError): Added Geolocation-specific method.

  • WebView.h: Added setGeolocationProvider, geolocationProvider, geolocationDidChangePosition, geolocationDidFailWithError.
2:12 PM Changeset in webkit [53164] by Nate Chapin
  • 31 edits in trunk/WebCore

2010-01-12 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Remove static const ints from V8CustomBinding.h

​https://bugs.webkit.org/show_bug.cgi?id=33547

  • bindings/scripts/CodeGeneratorV8.pm: Generate and use custom

internal field indices from lists of custom internal fields.

  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/NPV8Object.h:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: Remove a bunch of now unnecessary

manually calls to setInternalFieldCount().

  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8Index.h:
  • bindings/v8/V8IsolatedContext.cpp:
  • bindings/v8/V8IsolatedContext.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h: Remove the static const ints.
  • bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
2:07 PM Changeset in webkit [53163] by jhoneycutt@apple.com
  • 3 edits
    2 adds in trunk

MSAA: Accessibility role of <select multiple> elements is wrong

​https://bugs.webkit.org/show_bug.cgi?id=33522

Reviewed by Darin Adler.

WebKit/win:

  • AccessibleBase.cpp:

(MSAARole):
Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA
"list" and "list item" roles.

LayoutTests:

  • platform/win/accessibility/multiple-select-element-role-expected.txt: Added.
  • platform/win/accessibility/multiple-select-element-role.html: Added.
1:59 PM Changeset in webkit [53162] by darin@chromium.org
  • 2 edits in trunk/WebCore

2010-01-12 Darin Fisher <​darin@chromium.org>

Fixing chromium build bustage.

  • bindings/v8/custom/V8PopStateEventCustom.cpp: Add V8Proxy.h include.
1:28 PM Changeset in webkit [53161] by darin@chromium.org
  • 7 edits
    1 add in trunk/WebCore

2010-01-12 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

Add V8 bindings for PopStateEvent.
​https://bugs.webkit.org/show_bug.cgi?id=33546


This is covered by existing tests for PopStateEvent.

  • WebCore.gypi:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8PopStateEventCustom.cpp: Added. (WebCore::V8PopStateEvent::initPopStateEventCallback): (WebCore::V8PopStateEvent::stateAccessorGetter):
1:25 PM Changeset in webkit [53160] by knorton@google.com
  • 7 edits in trunk

2010-01-12 Kelly Norton <​knorton@google.com>

Reviewed by Timothy Hatcher.

Adds source length to ParseHTMLRecords in the inspector timeline.
​https://bugs.webkit.org/show_bug.cgi?id=33548

Test: inspector/timeline-parse-html.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willWriteHTML):
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createParseHTMLRecord):
  • inspector/TimelineRecordFactory.h:
1:15 PM Changeset in webkit [53159] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Jungshik Shin <​jshin@chromium.org>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=31597

Make ICU's text breakiterator and string search use Chrome's UI
language instead of 'en-US' or the OS UI language.

As long as the webkit layout tests are run in en-US locale, there'd be
no visible change.

  • platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: (UILanguage): (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
1:05 PM Changeset in webkit [53158] by Beth Dakin
  • 5 edits in trunk/LayoutTests

Updated results for these tests which just have rounding errors.

Reviewed by Nikolas Zimmermann.

  • platform/mac/svg/css/composite-shadow-example-expected.checksum:
  • platform/mac/svg/css/composite-shadow-example-expected.png:
  • platform/mac/svg/css/mask-with-shadow-expected.checksum:
  • platform/mac/svg/css/mask-with-shadow-expected.png:
12:54 PM Changeset in webkit [53157] by Beth Dakin
  • 29 edits in trunk

WebCore: Rubber-stamped by Dave Hyatt.

This patch changes the name of -webkit-shadow to -webkit-svg-shadow
to avoid giving a custom property an overly-general name.
<rdar://problem/7534590>

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShadow):

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

LayoutTests: This patch changes the name of -webkit-shadow to -webkit-svg-shadow
to avoid giving a custom property an overly-general name.
<rdar://problem/7534590>

  • fast/repaint/moving-shadow-on-container.html:
  • fast/repaint/moving-shadow-on-path.html:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/arrow-with-shadow.svg:
  • svg/css/circle-in-mask-with-shadow.svg:
  • svg/css/clippath-with-shadow.svg:
  • svg/css/composite-shadow-example.html:
  • svg/css/composite-shadow-with-opacity.html:
  • svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/group-with-shadow.svg:
  • svg/css/mask-with-shadow.svg:
  • svg/css/path-with-shadow.svg:
  • svg/css/shadow-with-large-radius.svg:
  • svg/css/shadow-with-negative-offset.svg:
  • svg/css/stars-with-shadow.html:
  • svg/filters/shadow-on-filter.svg:
  • svg/filters/shadow-on-rect-with-filter.svg:
12:49 PM Changeset in webkit [53156] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed, build fix.

  • WebCore.vcproj/WebCore.vcproj:
12:44 PM Changeset in webkit [53155] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-01-12 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Add a null check in case of an event handler with invalid syntax.

Should make fast/js/invalid-syntax--for-function.html not crash in
Chromium's test shell.

  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::callListenerFunction): Check the listener object before using it.
12:34 PM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:32 PM Changeset in webkit [53154] by bfulgham@webkit.org
  • 4 edits in trunk/WebKitTools

Extend WinLauncher example with better printing features.

Reviewed by Darin Adler.

  • WinLauncher/PrintWebUIDelegate.cpp:

(PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly

larger margins.

(PrintWebUIDelegate::webViewHeaderHeight): Compute header height based

on text metrics.

(PrintWebUIDelegate::webViewFooterHeight): Compute footer height based

on text metrics.

(PrintWebUIDelegate::drawHeaderInRect): Write useful header, along

with separating line.

(PrintWebUIDelegate::drawFooterInRect):

  • WinLauncher/PrintWebUIDelegate.h: Remove stubs.
  • WinLauncher/WinLauncher.cpp:

(PrintView): Correct loop used to print individual pages.

Previously it started at 0, which is a wild-card to print all
pages at once.

11:59 AM Changeset in webkit [53153] by eric.carlson@apple.com
  • 4 edits in trunk/LayoutTests

2010-01-12 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, build fix.

Add media/video-poster-scale.html to GTK skipped list, it needs platform specific
results (​https://bugs.webkit.org/show_bug.cgi?id=33541). Fix test results on
OSX and Windows.

  • media/video-poster-scale-expected.txt:
  • media/video-poster-scale.html:
  • platform/gtk/Skipped:
11:52 AM Changeset in webkit [53152] by pkasting@chromium.org
  • 6 edits
    1 delete in trunk/WebCore

Remove XBM support from the open-source image decoders.
​https://bugs.webkit.org/show_bug.cgi?id=27823

Reviewed by Dimitri Glazkov.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

  • platform/image-decoders/xbm: Removed.
  • platform/image-decoders/xbm/XBMImageDecoder.cpp: Removed.
  • platform/image-decoders/xbm/XBMImageDecoder.h: Removed.
11:42 AM Changeset in webkit [53151] by ap@apple.com
  • 14 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=33540
Make it possible to build in debug mode with assertions disabled

11:41 AM Changeset in webkit [53150] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

2010-01-12 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, build fix.

Update test and results after r53146.

  • http/tests/security/local-video-poster-from-remote-expected.txt:
  • http/tests/security/local-video-poster-from-remote.html:
11:33 AM Changeset in webkit [53149] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-01-12 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Gustavo Noronha Silva.

[GTK] Failing media/video-seek-past-end-playing.html
​https://bugs.webkit.org/show_bug.cgi?id=33015

  • platform/gtk/Skipped: Skipping the test again, we need to kill its last timer.
10:50 AM Changeset in webkit [53148] by yong.li@torchmobile.com
  • 4 edits in trunk

2009-11-23 Yong Li <​yoli@rim.com>

Reviewed by Adam Treat.

Make GIF decoder support down-sampling
​https://bugs.webkit.org/show_bug.cgi?id=31806

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::upperBoundScaledY): (WebCore::ImageDecoder::lowerBoundScaledY):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::scaledRect): (WebCore::RGBA32Buffer::setScaledRect): (WebCore::ImageDecoder::scaledSize):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::sizeNowAvailable): (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::copyOnePixel): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete):
10:33 AM Changeset in webkit [53147] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Reviewed by Eric Carlson.

[GTK] Failing media/video-seek-past-end-playing.html
​https://bugs.webkit.org/show_bug.cgi?id=33015

Listen on timeupdate event instead of waiting a fixed amount of
time, which is prone to test flackyness.

  • media/audio-mpeg-supported.html:
  • media/video-seek-past-end-playing.html:
  • platform/gtk/Skipped:
10:23 AM Changeset in webkit [53146] by eric.carlson@apple.com
  • 20 edits
    2 adds in trunk

2010-01-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler and Simon Fraser.

rdar://problem/5684062
​https://bugs.webkit.org/show_bug.cgi?id=23094
Flash of white when switching from poster image to video playback


​https://bugs.webkit.org/show_bug.cgi?id=23140
<video> poster should scale like a video frame

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Only call updatePosterImage from one place
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): m_shouldShowPosterImage -> m_shouldDisplayPoster. (WebCore::HTMLVideoElement::createRenderer): Always create a RenderVideo. (WebCore::HTMLVideoElement::attach): Call updatePosterImage before checking to see if we

should display the poster image. renderer() is never a RenderImage, don't need to check.
m_shouldShowPosterImage -> m_shouldDisplayPoster.

(WebCore::HTMLVideoElement::detach): m_shouldShowPosterImage -> m_shouldDisplayPoster.
(WebCore::HTMLVideoElement::parseMappedAttribute): Cache poster attribute when it is set since

it is checked frequently. m_shouldShowPosterImage -> m_shouldDisplayPoster.

(WebCore::HTMLVideoElement::updatePosterImage): Don't bother looking at the network state,

display the poster as long as the attribute is valid and the media engine says it hasn't
rendered a video frame. m_shouldShowPosterImage -> m_shouldDisplayPoster.

(WebCore::HTMLVideoElement::hasAvailableVideoFrame): New, ask the media engine if a video frame

is available to render.

  • html/HTMLVideoElement.h: (WebCore::HTMLVideoElement::poster): (WebCore::HTMLVideoElement::shouldDisplayPoster):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateRenderer): Call setCachedImage for render video too.
  • manual-tests/video-player.html: Remove bit-rot from manual test so it works again.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::hasAvailableVideoFrame): New, ask the media engine if a video frame

is available to render.

  • platform/graphics/MediaPlayer.h: Prototype for hasAvailableVideoFrame.
  • platform/graphics/MediaPlayerPrivate.h: Ditto.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Declare hasAvailableVideoFrame, declare

all bool variables to aid packing.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_videoFrameHasDrawn. Cleanup

floating point initializers to match coding guidelines.

(WebCore::MediaPlayerPrivate::load): Initialize m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivate::hasAvailableVideoFrame): New.
(WebCore::MediaPlayerPrivate::repaint): Set m_videoFrameHasDrawn.

(WebCore::RenderImage::paintReplaced): Split part out into paint method.
(WebCore::RenderImage::paint): New.

  • rendering/RenderImage.h: Declare paint. Make isWidthSpecified and isHeightSpecified protected

instead of private so RenderVideo can use them.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Inherit from RenderImage, not RenderReplaced (WebCore::RenderMedia::destroy): Ditto. (WebCore::RenderMedia::styleDidChange): Ditto. (WebCore::RenderMedia::layout): Ditto. (WebCore::RenderMedia::lowestPosition): Ditto. (WebCore::RenderMedia::rightmostPosition): Ditto. (WebCore::RenderMedia::leftmostPosition): Ditto.
  • rendering/RenderMedia.h: Declare isImage and isRenderImage.
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::intrinsicSizeChanged): New, call RenderVideo::intrinsicSizeChanged

when displaying a poster so it is sized correctly.

(WebCore::RenderVideo::imageChanged): Override so we can cache the image's intrisic size and
use it when we also know the movie's intrinsic size but still need to draw the poster.
(WebCore::RenderVideo::videoBox): Use the poster's intrinsic size when drawing the poster,
use the movie's intrinsic size when drawing frames.
(WebCore::RenderVideo::paintReplaced): Call RenderImage::paint when drawing the poster.
(WebCore::RenderVideo::videoElement): New.
(WebCore::RenderVideo::updatePlayer):

  • rendering/RenderVideo.h: (WebCore::RenderVideo::minimumReplacedHeight): Added.

2010-01-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler and Simon Fraser.

rdar://problem/5684062
​https://bugs.webkit.org/show_bug.cgi?id=23094
Flash of white when switching from poster image to video playback


​https://bugs.webkit.org/show_bug.cgi?id=23140
<video> poster should scale like a video frame

  • media/video-poster-expected.txt: Remove blank line at beginning of test result present as a side effect of the media element using RenderImage to display the poster.
  • media/video-poster-scale.html: New.
  • media/video-poster-scale-expected.txt: New.
10:11 AM Changeset in webkit [53145] by darin@chromium.org
  • 2 edits in trunk/WebKitTools

2010-01-11 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] "build-webkit --chromium" should run "make all" on Linux
​https://bugs.webkit.org/show_bug.cgi?id=33500

  • Scripts/webkitdirs.pm:
10:10 AM Changeset in webkit [53144] by darin@chromium.org
  • 3 edits
    1 add
    1 delete in trunk/WebKit/chromium

2010-01-11 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Re-work webkit_unit_tests so that WebKit is initialized only once
​https://bugs.webkit.org/show_bug.cgi?id=33504

  • WebKit.gyp:
  • tests/KURLTest.cpp: (ComponentCase::TEST):
  • tests/RunAllTests.cpp: Added. (main):
  • tests/WebKitTest.h: Removed.
10:10 AM Changeset in webkit [53143] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-01-12 Tony Chang <​tony@chromium.org>

Reviewed by Maciej Stachowiak.

Add a test for a Chromium crash when loading multipart/x-mixed-replace
data.

​https://bugs.webkit.org/show_bug.cgi?id=31446

  • http/tests/multipart/multipart-wait-before-boundary-expected.txt: Added.
  • http/tests/multipart/multipart-wait-before-boundary.html: Added.
  • http/tests/multipart/resources/multipart-wait-before-boundary.php: Added.

2010-01-12 Tony Chang <​tony@chromium.org>

Reviewed by Maciej Stachowiak.

Fix a crash in Chromium when receiving multipart/x-mixed-replace data.
If we stop a multipart load after ResourceLoader::didReceiveResponse
but before ResourceLoader::didReceiveData, we have a NULL document
loader because it has been moved back to the provisional state. New
loads that happen after this will dereference the NULL document
loader.

Work around this by moving the provisional document loader back as
the document loader when the request is stopped.

​https://bugs.webkit.org/show_bug.cgi?id=31446

Test: http/tests/multipart/multipart-wait-before-boundary.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
9:15 AM Changeset in webkit [53142] by enrica@apple.com
  • 2 edits in trunk/WebCore

WebKit returns incorrect match count when first string match is on an element with user-select-none style
​https://bugs.webkit.org/show_bug.cgi?id=33508
<rdar://problem/7482143>

Reviewed by Darin Adler.

If we use VisiblePosition to calculate the start of the new search range,
we skip all the nodes with user-select-none style, producing an incorrect
match count.

No new tests: there are no API's available to Javascript to verify the
number of matches found.

  • page/Frame.cpp:

(WebCore::Frame::markAllMatchesForText): Changed to use the end of the previous
result range as the start of the new search range.

9:03 AM Changeset in webkit [53141] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Changed ".sidebar" style to allow v-scroll to appear in
"Profiles" panel sidebar.

​https://bugs.webkit.org/show_bug.cgi?id=33470

No new tests -- no code changed.

  • inspector/front-end/inspector.css:
6:37 AM Changeset in webkit [53140] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-12 Petri Latvala <​petri.latvala@nomovok.com>

Reviewed by Antti Koivisto.

fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html failed on buildbot
​https://bugs.webkit.org/show_bug.cgi?id=33465

A touchmove event is not dispatched if none of the touch points actually moved.
Changed the test to use touchstart instead.

  • fast/events/touch/touch-coords-in-zoom-and-scroll.html:
  • platform/qt/Skipped:
5:55 AM Changeset in webkit [53139] by Adam Roben
  • 2 edits in trunk/WebCore

Windows accelerated compositing build fix after r53110

  • plugins/PluginWidget.h:

(WebCore::PluginWidget::platformLayer): Define platformLayer() for
non-Mac platforms that have accelerated compositing turned on. It
would probably be better to make PluginWidget not be used at all on
non-Mac platforms, but this fix is much simpler.

5:48 AM Changeset in webkit [53138] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

[GTK] couple fixes for signal emissions, and property notifications
​https://bugs.webkit.org/show_bug.cgi?id=33428

Fix commitedLoad being called where it should not, causing it to
be called one time too many in some cases. We now match Qt's and
Mac's behavior here.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
  • tests/testloading.c: (load_error_status_changed_cb):
5:05 AM Changeset in webkit [53137] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-12 Eric Seidel <​eric@webkit.org>

Reviewed by Gustavo Noronha Silva.

[GTK] Threading problems with some of the tests
​https://bugs.webkit.org/show_bug.cgi?id=30814

Skip another test which is hitting the SQLiteDatabase::sqliteHandle() threading ASSERT.

  • platform/gtk/Skipped:
4:59 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
4:45 AM Changeset in webkit [53136] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Touch event layout tests should be in their own subdirectory, so that they can be easily skipped
​https://bugs.webkit.org/show_bug.cgi?id=33526

Reviewed by Simon Hausmann.

Tests moved from fast/events to fast/events/touch by r53125,
relative resource paths should be adjuted to the new location.

  • fast/events/touch/basic-touch-events.html: relative paths fixed.
  • fast/events/touch/touch-coords-in-zoom-and-scroll.html: relative paths fixed.
4:41 AM Changeset in webkit [53135] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-01-12 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Support injection of inspector scripts into the inspected context.

​https://bugs.webkit.org/show_bug.cgi?id=33523

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::WeakReferenceCallback): (WebCore::createInjectedScriptHostV8Wrapper): (WebCore::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
4:31 AM Changeset in webkit [53134] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

AssignToCommitter does not need to fetch bugs twice
​https://bugs.webkit.org/show_bug.cgi?id=33530

This is a no-brainer patch now that we've added Bug.reviewed_patches

  • Scripts/webkitpy/commands/upload.py:
4:03 AM Changeset in webkit [53133] by eric@webkit.org
  • 22 edits in trunk/WebKitTools

2010-01-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla.py should have an Attachment object instead of passing around dictionaries
​https://bugs.webkit.org/show_bug.cgi?id=31594

  • Scripts/webkitpy/bugzilla.py:
    • Add a new Attachment class, with accessor methods for all the necessary properties.
    • Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
    • Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
    • Move committer validation logic into its own class.
    • Committer rejection is only used in one place. Make the new Bug reviewed_patches and commit_queued_patches handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle the case where we want to reject patches in bugzilla.
    • Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
    • Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
    • Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
    • Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
  • Scripts/webkitpy/bugzilla_unittest.py:
    • Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
  • Scripts/webkitpy/commands/download.py:
    • Store "bug_id" in state instead of making a fake patch object.
    • Update to use Attachment and Bug objects.
  • Scripts/webkitpy/commands/download_unittest.py:
    • Update expected results now that our testing framework covers more code.
  • Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
  • Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
  • Scripts/webkitpy/commands/queries_unittest.py: ditto.
  • Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
  • Scripts/webkitpy/commands/queuestest.py: ditto.
  • Scripts/webkitpy/commands/upload.py: ditto.
  • Scripts/webkitpy/mock_bugzillatool.py:
    • Now that more logic has moved into Attachment and Bug, we have to actually provide real reviewer emails as well as real reviewer flags.
    • Update mock methods to return Attachment objects.
  • Scripts/webkitpy/scm.py: Update to use Attachment class.
  • Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
  • Scripts/webkitpy/statusserver.py: ditto.
  • Scripts/webkitpy/steps/applypatch.py: ditto.
  • Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
  • Scripts/webkitpy/steps/closebug.py: ditto.
  • Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either statebug_id or statepatch.bug_id()
  • Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
  • Scripts/webkitpy/steps/obsoletepatches.py: ditto.
  • Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
3:48 AM Changeset in webkit [53132] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2010-01-12 Ben Murdoch <​benm@google.com>

Reviewed by Darin Adler.

Form Reset : Press Back Button and Reset , TextareaElemnt is not set to Default Value
​https://bugs.webkit.org/show_bug.cgi?id=31539

Added manual test: manual-tests/textarea-reset-default-value.html.

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::restoreFormControlState): set the value, rather than default value of a text area when restoring its state. This allows resetting a form with a textarea to work correctly after its state has been restored.
  • manual-tests/resources/textarea-form-back-on-submit.html: Added.
  • manual-tests/textarea-reset-default-value.html: Added.
3:28 AM Changeset in webkit [53131] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-12 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

[Qt] WebCore::Path allocates QPainterPath unnecessarily on the heap
​https://bugs.webkit.org/show_bug.cgi?id=33466

WebCore::Path is a pointer to a PlatformPath. In case of Qt that's a
QPainterPath, which itself is a pointer to the elements (QVector).
That creates unecessary allocations in PathQt.cpp.

Replaced the "PlatformPath* m_path;" with a PlatformPathPtr, which
is a plain QPainterPath.

  • platform/graphics/Path.h: (WebCore::Path::platformPath):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::contains): (WebCore::Path::strokeContains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::strokeBoundingRect): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::debugString): (WebCore::Path::apply): (WebCore::Path::transform):
3:21 AM Changeset in webkit [53130] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-12 Adam Barth <​abarth@webkit.org>

Unreviewed typo fix. :(

  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queues.py:
3:21 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:10 AM Changeset in webkit [53129] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Adam Barth <​abarth@webkit.org>

Unreviewed. Add "error" to the right part of the message.

  • Scripts/webkitpy/commands/queues.py:
3:06 AM Changeset in webkit [53128] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-12 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Fraser.

media/video-error-does-not-exist.html failed on Snow Leopard Release Bot
​https://bugs.webkit.org/show_bug.cgi?id=33434

Add another media test to the skipped list.
I expect these are all timing out for the same reason.
We just don't know the reason yet.

  • platform/mac-snowleopard/Skipped:
2:42 AM Changeset in webkit [53127] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2010-01-12 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Adam Barth.

[Qt] XSL stylesheets can load documents from a different origin

​https://bugs.webkit.org/show_bug.cgi?id=33423

Add two expected results for Qt:
QXmlQuery has a different behaviour with regard to loading failures
comparing to libxslt.

  • platform/qt/http/tests/security/xss-DENIED-xsl-document-expected.txt:
  • platform/qt/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt:

2010-01-12 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Adam Barth.

[Qt] XSL stylesheets can load documents from a different origin

​https://bugs.webkit.org/show_bug.cgi?id=33423

  • xml/XSLTProcessorQt.cpp: (WebCore::XSLTUriResolver::XSLTUriResolver): (WebCore::XSLTUriResolver::resolve): (WebCore::XSLTProcessor::transformToString):
2:17 AM Changeset in webkit [53126] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

EWS should show purple when svn-apply fails
​https://bugs.webkit.org/show_bug.cgi?id=33527

  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queues.py:
2:17 AM Changeset in webkit [53125] by Simon Hausmann
  • 5 edits
    4 moves
    1 add in trunk/LayoutTests

Touch event layout tests should be in their own subdirectory, so that they can be easily skipped
​https://bugs.webkit.org/show_bug.cgi?id=33526

Reviewed by Adam Barth.

  • fast/events/touch/basic-touch-events-expected.txt: Renamed from LayoutTests/fast/events/basic-touch-events-expected.txt.
  • fast/events/touch/basic-touch-events.html: Renamed from LayoutTests/fast/events/basic-touch-events.html.
  • fast/events/touch/touch-coords-in-zoom-and-scroll-expected.txt: Renamed from LayoutTests/fast/events/touch-coords-in-zoom-and-scroll-expected.txt.
  • fast/events/touch/touch-coords-in-zoom-and-scroll.html: Renamed from LayoutTests/fast/events/touch-coords-in-zoom-and-scroll.html.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
2:09 AM Changeset in webkit [53124] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Gustavo Noronha Silva.

​https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text

Tweak/correction: Eliminate a needless variable.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
1:50 AM Changeset in webkit [53123] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove copy/paste code from subclasses of AbstractReviewQueue
​https://bugs.webkit.org/show_bug.cgi?id=33525

  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queues.py:
1:42 AM Changeset in webkit [53122] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add Gustavo and Xan as gtk-ews watchers
​https://bugs.webkit.org/show_bug.cgi?id=33519

  • Scripts/webkitpy/commands/early_warning_system.py:
1:41 AM Changeset in webkit [53121] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch shouldn't waste my time for with a component prompt
​https://bugs.webkit.org/show_bug.cgi?id=33521

The component field isn't very useful for bugs created with
webkit-patch because they're likely to be resolved quickly. Instead of
always prompting for a component, we should just default to the "New
Bugs" component. If the bug stays around for more than five minutes,
we can assign it a proper component.

  • Scripts/webkitpy/bugzilla.py:
1:40 AM Changeset in webkit [53120] by abarth@webkit.org
  • 5 edits
    1 add in trunk/WebKitTools

2010-01-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add experimental "land-safely" command to webkit-patch
​https://bugs.webkit.org/show_bug.cgi?id=33518

  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/steps/init.py:
  • Scripts/webkitpy/steps/postdiffforcommit.py: Added.
12:18 AM Changeset in webkit [53119] by yurys@chromium.org
  • 6 edits in trunk/WebCore

2010-01-12 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Geoffrey Garen.

Allow creating injected script for the inspected script state. The InjectedScript is
cached on the inspected ExecState global object and will be garbage collected when the
object is collected. Each InjectedScript object is assigned unique id.

​https://bugs.webkit.org/show_bug.cgi?id=33469

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
  • bindings/js/JSDOMGlobalObject.h: InjectedScript is cached on the global object as a field that is not visible from the inspected code. This InjectedScript should be alive as long as the global object is alive and should be accessible from Web Inspector's native code. (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::createInjectedScript): Creates injected script using the lexical global object of the inspected ScriptState. Reference to the object is stored on the global DOM object. (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::discardInjectedScripts): This method is expected to be called when the the InjectedScript are no longer needed. In particular, this should be called before frame navigation.
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::setInjectedScriptSource): This allows to provide injected script source. The source may be loaded in a platform specific way.
12:16 AM Changeset in webkit [53118] by abarth@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

ecma/Date/15.9.5.12-1.js fails every night at midnight
​https://bugs.webkit.org/show_bug.cgi?id=28041

Change the test to use a concrete time instead of "now".

  • tests/mozilla/ecma/Date/15.9.5.10-1.js:
  • tests/mozilla/ecma/Date/15.9.5.12-1.js:
Note: See TracTimeline for information about the timeline view.