⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 16, 2010:

11:56 PM Changeset in webkit [54875] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to fix the build

11:38 PM Changeset in webkit [54874] by Chris Jerdonek
  • 8 edits in trunk/WebKitTools

Some minor check-webkit-style code clean-ups. This revision
contains no new functionality.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=34932

  • Scripts/check-webkit-style:
    • Replaced the call to webkit_argument_defaults() with a default parameter in the ArgumentParser constructor.
  • Scripts/webkitpy/style/checker.py:
    • Removed the WEBKIT prefix from the default global variables.
    • Prefixed several of the global variables with an underscore to reflect that they are used internally.
    • Renamed _DEFAULT_FILTER_RULES to _BASE_FILTER_RULES.
    • Addressed a FIXME by changing the _PATH_RULES_SPECIFIER configuration from list-tuple pairs to list-list pairs.
    • Renamed style_categories() to _all_categories().
    • Renamed webkit_argument_defaults() to _check_webkit_style_defaults().
    • Renamed the ArgumentDefaults class to DefaultCommandOptionValues.
    • In the ArgumentParser class--
      • Renamed the doc_print attribute to stderr_write.
      • Other minor updates.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the import statements and unit test classes as necessary.
    • Added assertions to test _PATH_RULES_SPECIFIER more fully.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Updated the unit test classes as necessary.
    • Changed StyleErrorHandlerTestBase to store a list of error messages rather than just the last one.
  • Scripts/webkitpy/style/filter.py:
    • Altered FilterConfiguration._path_rules_from_path() to convert the path_rules list to a tuple.
  • Scripts/webkitpy/style/filter_unittest.py:
    • Updated the unit tests to reflect the change from tuples to lists in the _PATH_RULES_SPECIFIER configuration variable.
11:32 PM Changeset in webkit [54873] by eric@webkit.org
  • 32 edits in trunk

2010-02-16 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Add a new setting which gives the option of assigning every ​file:///
to its own unique domain.

​https://bugs.webkit.org/show_bug.cgi?id=34778

Test: Pending in forthcoming separate change due to non-trivial
dependencies.

  • dom/Document.cpp: (WebCore::Document::initSecurityContext): Place ​file:/// URI documents into their own unique domains if the new setting requires it.
  • page/Settings.h:
  • page/Settings.cpp: (WebCore::Settings::setAllowFileAccessFromFileURLs): Simple setter.
  • page/SecurityOrigin.h:
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::makeUnique): Add simple ability to force an origin to be considered unique.
11:12 PM Changeset in webkit [54872] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: drosera/demo.js not syntax highlighted correctly.

​https://bugs.webkit.org/show_bug.cgi?id=35008

  • inspector/front-end/SourceTokenizer.js: (WebInspector.SourceTokenizer.Registry): (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
10:56 PM Changeset in webkit [54871] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: prefer smooth scrolling to instant highlight.

​https://bugs.webkit.org/show_bug.cgi?id=34978

9:57 PM Changeset in webkit [54870] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix a handful of other leaks seen on the buildbot.

Patch by Gavin Barraclough <​barraclough@apple.com> on 2010-02-16
Reviewed by Mark Rowe.

  • runtime/UStringImpl.h:

(JSC::UStringOrRopeImpl::deref): Delegate through to the subclass version of deref to ensure that
the correct cleanup takes place. This function previously featured some code that attempted to
skip deletion of static UStringImpl's. Closer inspection revealed that it was in fact equivalent
to "if (false)", meaning that UStringImpl's which had their final deref performed via this function
were leaked.

9:26 PM Changeset in webkit [54869] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp

Forgot a .get() because this is an OwnPtr

8:55 PM Changeset in webkit [54868] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp

Try using m_qtVideoLayer instead of platformLayer() to fix the build

8:21 PM Changeset in webkit [54867] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp

Build fix when Accelerated Compositing is on

8:06 PM Changeset in webkit [54866] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix a handful of leaks seen on the buildbot.

Reviewed by Gavin Barraclough.

  • runtime/UStringImpl.h:

(JSC::UStringOrRopeImpl::deref): Call URopeImpl::destructNonRecursive rather than delete
to ensure that the rope's fibers are also destroyed.

7:54 PM Changeset in webkit [54865] by eric@webkit.org
  • 3 edits
    6 adds in trunk

2010-02-16 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Nikolas Zimmermann.

SVG not rendered as background-image from data URI
​https://bugs.webkit.org/show_bug.cgi?id=33630

  • platform/mac/svg/css/background-image-svg-expected.checksum: Added.
  • platform/mac/svg/css/background-image-svg-expected.png: Added.
  • platform/qt/svg/css/background-image-svg-expected.checksum: Added.
  • platform/qt/svg/css/background-image-svg-expected.png: Added.
  • svg/css/background-image-svg.html: Added.
  • svg/css/background-image-svg-expected.txt: Added.

2010-02-16 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Nikolas Zimmermann.

SVG not rendered as background-image from data URI
​https://bugs.webkit.org/show_bug.cgi?id=33630

When the background image is an SVG image, and it is smaller than the area
it is supposed to fill, we were using renderSubTreeToImage to draw it.
That call was not going through all the drawing phases, and so the SVG itself
would not be drawn.

Test: svg/css/background-image-svg.html

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
7:37 PM Changeset in webkit [54864] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-16 Bryan Yeung <​bryeung@chromium.org>

Reviewed by Nikolas Zimmermann.

Remove the bounds on stroke width and miter for the skia platform.
​https://bugs.webkit.org/show_bug.cgi?id=34954

Test: svg/custom/stroke-width-large.svg

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
7:27 PM Changeset in webkit [54863] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Correct typo in test name in Skipped list. Should turn SL slave green again.

  • platform/mac-snowleopard/Skipped:
7:25 PM Changeset in webkit [54862] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp

Add a missing semicolon

7:21 PM Changeset in webkit [54861] by eric@webkit.org
  • 5 edits in trunk/WebKit/chromium

2010-02-16 James Hawkins <​jhawkins@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Remove calls to releaseRef when passing PassRefPtrs to base
classes. releaseRef releases the original pointer without decreasing
the reference count, and the base class constructor increases the
reference count, leading to a leak.

​https://bugs.webkit.org/show_bug.cgi?id=35000

  • src/WebDocument.cpp: (WebKit::WebDocument::WebDocument):
  • src/WebElement.cpp: (WebKit::WebElement::WebElement):
  • src/WebFormElement.cpp: (WebKit::WebFormElement::WebFormElement):
  • src/WebInputElement.cpp: (WebKit::WebInputElement::WebInputElement):
7:10 PM Changeset in webkit [54860] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2010-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Attempt to fix win slave. Skip same tests failing on SL, add bug references to skipped list.

  • platform/mac-snowleopard/Skipped:
  • platform/win/Skipped:
7:05 PM Changeset in webkit [54859] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2010-02-16 Bryan Yeung <​bryeung@chromium.org>

Reviewed by Nikolas Zimmermann.

Add a new layout test for large stroke widths in SVG.
This regression tests a bug in the Skia platform where the width was
limited to 512.

​https://bugs.webkit.org/show_bug.cgi?id=34954

  • platform/mac/svg/custom/stroke-width-large-expected.checksum: Added.
  • platform/mac/svg/custom/stroke-width-large-expected.png: Added.
  • platform/mac/svg/custom/stroke-width-large-expected.txt: Added.
  • svg/custom/stroke-width-large.svg: Added.

2010-02-16 Bryan Yeung <​bryeung@chromium.org>

Reviewed by Nikolas Zimmermann.

Remove the bounds on stroke width and miter for the skia platform.
​https://bugs.webkit.org/show_bug.cgi?id=34954

Test: svg/custom/stroke-width-large.svg

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
6:49 PM Changeset in webkit [54858] by eric@webkit.org
  • 3 edits
    8 adds in trunk

2010-02-16 MORITA Hajime <​morrita@gmail.com>

Reviewed by Nikolas Zimmermann.

REGRESSION: SVG text disappaears after double click
​https://bugs.webkit.org/show_bug.cgi?id=34880

  • platform/mac/svg/text/selection-doubleclick-expected.checksum: Added.
  • platform/mac/svg/text/selection-doubleclick-expected.png: Added.
  • platform/mac/svg/text/selection-doubleclick-expected.txt: Added.
  • platform/mac/svg/text/selection-tripleclick-expected.checksum: Added.
  • platform/mac/svg/text/selection-tripleclick-expected.png: Added.
  • platform/mac/svg/text/selection-tripleclick-expected.txt: Added.
  • svg/text/selection-doubleclick.svg: Added.
  • svg/text/selection-tripleclick.svg: Added.

2010-02-16 MORITA Hajime <​morrita@gmail.com>

Reviewed by Nikolas Zimmermann.

REGRESSION: SVG text disappaears after double click
​https://bugs.webkit.org/show_bug.cgi?id=34880

Tests: svg/text/selection-doubleclick.svg

svg/text/selection-tripleclick.svg

  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::mayHaveSelection): Use InlineTextBox::selectionStartEnd() instead of RenderObject::selectionStartEnd() because latter may span multiple comparing startPos and endPos is irrelevant in some cases. former selectionStartEnd() is for single line and comparing startPos and endPos will make sense.
6:29 PM Changeset in webkit [54857] by ariya@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-02-16 Ariya Hidayat <​ariya.hidayat@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Allow scrolling to an anchor programmatically.
​https://bugs.webkit.org/show_bug.cgi?id=29856

  • Api/qwebframe.cpp: (QWebFrame::scrollToAnchor): New API function.
  • Api/qwebframe.h:
  • tests/qwebframe/tst_qwebframe.cpp: New tests for scrollToAnchor().
6:25 PM Changeset in webkit [54856] by jberlin@webkit.org
  • 3 edits in trunk/WebCore

Inspector should display Array lengths in the property lists.
​https://bugs.webkit.org/show_bug.cgi?id=20695

Reviewed by Timothy Hatcher.

  • inspector/front-end/InjectedScript.js:

(injectedScriptConstructor):
For objects of type 'array' (which includes Arrays, NodeLists, and HTMLCollections), make the length of the object available via propertyLength on the proxy object.

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):
For properties that have propertyLength defined, append it to the displayed description.

6:16 PM Changeset in webkit [54855] by eric@webkit.org
  • 3 edits
    5 adds in trunk

2010-02-16 Yusuke Sato <​yusukes@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
​https://bugs.webkit.org/show_bug.cgi?id=34735

  • fast/css/font-face-opentype.html: Added.
  • fast/css/resources/Ahem.otf: Added. Ahem font which has CFF glyphs, converted from Ahem.ttf by FontForge (​http://fontforge.sourceforge.net/).
  • platform/mac/fast/css/font-face-opentype-expected.checksum: Added.
  • platform/mac/fast/css/font-face-opentype-expected.png: Added.
  • platform/mac/fast/css/font-face-opentype-expected.txt: Added.

2010-02-16 Yusuke Sato <​yusukes@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
​https://bugs.webkit.org/show_bug.cgi?id=34735

Use 0xFFFF as invalidGlyph when fontData is a OpenType font with CFF glyphs.

Test: fast/css/font-face-opentype.html

  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs):
6:11 PM Changeset in webkit [54854] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-02-16 Ariya Hidayat <​ariya.hidayat@gmail.com>

Reviewed by Laszlo Gombos.

Fix building with Qt < 4.6.
​https://bugs.webkit.org/show_bug.cgi?id=34885

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
5:51 PM Changeset in webkit [54853] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Change quota-tracking.html to open databases only as they're
needed. Otherwise, open databases end up using more space from
this origin than the test expects.

Reviewed by Simon Fraser.

  • storage/quota-tracking.html:
5:42 PM Changeset in webkit [54852] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2010-02-16 Simon Fraser <Simon Fraser>

Reviewed by Nikolas Zimmermann.

Make this test more robust to slow-loading media.

  • media/video-load-networkState.html:
5:33 PM Changeset in webkit [54851] by Darin Adler
  • 2 edits in trunk/WebCore
  • page/MediaCanStartListener.h: Fixed license.
5:26 PM Changeset in webkit [54850] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Rubber-stamped by Simon Fraser.

Skip svg/zoom/(page|text)/zoom-coords-viewattr-01-b.svg on SnowLeopard.
svg/W3C-SVG-1.1/coords-viewattr* fail on SL and are already Skipped, seems related to entity parsing, not SVG.

  • platform/mac-snowleopard/Skipped:
5:23 PM Changeset in webkit [54849] by Darin Adler
  • 15 edits
    1 add in trunk

2010-02-16 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Generalize delayed plug-in start for background tabs for use for other media
​https://bugs.webkit.org/show_bug.cgi?id=34981

  • WebView.cpp: (WebView::setCanStartPlugins): Change to call setCanStartMedia. In a later patch we can change the of the public function in the IDL file too, but for now this should be enough.

2010-02-16 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Generalize delayed plug-in start for background tabs for use for other media
​https://bugs.webkit.org/show_bug.cgi?id=34981

  • WebView/WebHTMLView.mm: (-[WebHTMLView viewWillMoveToWindow:]): Added comment. (-[WebHTMLView viewDidMoveToWindow]): Ditto.
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Call setCanStartMedia right away so that if this view is not in a window, it will not start any media. (-[WebView viewWillMoveToWindow:]): Call setCanStartMedia(false) when moving to a window of nil. (-[WebView viewDidMoveToWindow]): Call setCanStartMedia(true) when moved to a window that is non-nil.

2010-02-16 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Generalize delayed plug-in start for background tabs for use for other media
​https://bugs.webkit.org/show_bug.cgi?id=34981

Also did some simple cleanup of HTMLMediaElement to get ready to make it
a client of the same mechanism.

  • WebCore.base.exp: Added Page::setCanStartMedia and resorted.
  • WebCore.xcodeproj/project.pbxproj: Added MediaCanStartListener.h.
  • html/HTMLAudioElement.h: Added an implementation of isVideo since that is now a pure virtual function in HTMLMediaElement. Also made tagPriority private.
  • html/HTMLMediaElement.h: Made it clearer that HTMLMediaElement is an abstract base class by making its constructor protected and making the isVideo function a pure virtual function.
  • page/Page.cpp: (WebCore::Page::Page): Updated for name change from m_canStartPlugins to m_canStartMedia. (WebCore::Page::addMediaCanStartListener): Renamed and added an assertion. (WebCore::Page::removeUnstartedMedia): Ditto. (WebCore::Page::setCanStartMedia): Renamed plugin to media and moved the code here from PageWin.cpp. The main change from the one in PageWin.cpp is that this function calls mediaCanStart rather than explicitly calling a combination of start and dispatchDidFailToStartPlugin on a PluginView.
  • page/Page.h: Re-sorted forward class declarations. Renamed the plugin starting functions to media starting names and changed types from PluginView to MediaCanStartListener.
  • page/MediaCanStartListener.h: Added.
  • page/win/PageWin.cpp: Moved setCanStartPlugins to the platform-independent Page.cpp file so it can be used for more than just Windows plug-ins.
  • plugins/PluginView.cpp: Sorted includes. (WebCore::PluginView::startOrAddToUnstartedList): Use addMediaCanStartListener. (WebCore::PluginView::mediaCanStart): Added. Called when the page decides that media can start. Contains the code that used to be in Page::setCanStartPlugins. (WebCore::PluginView::removeFromUnstartedListIfNecessary): Use removeMediaCanStartListener.
  • plugins/PluginView.h: Adopted MediaCanStartListener.
4:50 PM Changeset in webkit [54848] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-02-16 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=34999
Compositing layers inside overflow:scroll divs are not always updated on scrolling

When RenderLayer::scrollToOffset() updates compositing layer positions, it needs
to start updating at its stacking context rather than just its compositing ancestor.
The stacking context is guaranteed to contain all descendants of the overflow
layer, including those that are not direct descendants of the overflow layer in stacking
(and therefore compositing) order.

Test: compositing/overflow/scroll-ancestor-update.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
4:25 PM Changeset in webkit [54847] by barraclough@apple.com
  • 2 edits in trunk/WebKitLibraries

Disable warnings preventing use of anonymous structs/onions -
don't take all my fun toys away, these are useful & awesome!

Reviewed by NOBODY (Build fix).

  • win/tools/vsprops/common.vsprops:
4:09 PM Changeset in webkit [54846] by Nikolas Zimmermann
  • 1 edit
    1 add in trunk/LayoutTests

2010-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Add missing .checksum file in platform/mac/svg/zoom/page. All parts of the original patch for bug 14004 have been landed.

  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added.
4:08 PM Changeset in webkit [54845] by mitz@apple.com
  • 2 edits in trunk/WebCore

Allow FloatRect::center() to return fractional coordinates. It was
mistakenly converting to integers.

Reviewed by Simon Fraser.

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::center):

4:05 PM Changeset in webkit [54844] by Nikolas Zimmermann
  • 1 edit
    74 adds in trunk/LayoutTests

2010-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by David Hyatt.

SVG units don't stay consistently sized on zoom
​https://bugs.webkit.org/show_bug.cgi?id=14004

  • platform/mac/svg/zoom: Added.
  • platform/mac/svg/zoom/page: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/mac/svg/zoom/text: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
  • svg/zoom: Added.
  • svg/zoom/NOTE: Added.
  • svg/zoom/page: Added.
  • svg/zoom/page/absolute-sized-document-no-scrollbars.svg: Added.
  • svg/zoom/page/absolute-sized-document-scrollbars.svg: Added.
  • svg/zoom/page/relative-sized-document-scrollbars.svg: Added.
  • svg/zoom/page/zoom-coords-viewattr-01-b.svg: Added.
  • svg/zoom/page/zoom-foreignObject.svg: Added.
  • svg/zoom/page/zoom-hixie-mixed-008.xml: Added.
  • svg/zoom/page/zoom-hixie-mixed-009.xml: Added.
  • svg/zoom/page/zoom-hixie-rendering-model-004.xhtml: Added.
  • svg/zoom/page/zoom-svg-float-border-padding.xml: Added.
  • svg/zoom/resources: Added.
  • svg/zoom/resources/testPageZoom.js: Added.
  • svg/zoom/resources/testTextZoom.js: Added.
  • svg/zoom/text: Added.
  • svg/zoom/text/absolute-sized-document-no-scrollbars.svg: Added.
  • svg/zoom/text/absolute-sized-document-scrollbars.svg: Added.
  • svg/zoom/text/relative-sized-document-scrollbars.svg: Added.
  • svg/zoom/text/zoom-coords-viewattr-01-b.svg: Added.
  • svg/zoom/text/zoom-foreignObject.svg: Added.
  • svg/zoom/text/zoom-hixie-mixed-008.xml: Added.
  • svg/zoom/text/zoom-hixie-mixed-009.xml: Added.
  • svg/zoom/text/zoom-hixie-rendering-model-004.xhtml: Added.
  • svg/zoom/text/zoom-svg-float-border-padding.xml: Added.
4:01 PM Changeset in webkit [54843] by barraclough@apple.com
  • 16 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=34964
Leaks tool reports false memory leaks due to Rope implementation.

Reviewed by Oliver Hunt.

JavaScriptCore:

A rope is a recursive data structure where each node in the rope holds a set of
pointers, each of which may reference either a string (in UStringImpl form) or
another rope node. A low bit in each pointer is used to distinguish between
rope & string elements, in a fashion similar to the recently-removed
PtrAndFlags class (see ​https://bugs.webkit.org/show_bug.cgi?id=33731 ). Again,
this causes a problem for Leaks – refactor to remove the magic pointer
mangling.

Move Rope out from JSString.h and rename to URopeImpl, to match UStringImpl.
Give UStringImpl and URopeImpl a common parent class, UStringOrRopeImpl.
Repurpose an otherwise invalid permutation to flags (static & should report
memory cost) to identify ropes.

This allows us to change the rope's fibers to interrogate the object rather
than storing a bool within the low bits of the pointer (or in some cases the
use of a common parent class removes the need to determine the type at all -
there is a common interface to ref or get the length of either ropes or strings).

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::keyForCharacterSwitch):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

  • runtime/Identifier.cpp:

(JSC::Identifier::equal):
(JSC::Identifier::addSlowCase):

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):

  • runtime/JSString.h:

(JSC::):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::~JSString):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::JSStringFinalizerStruct::JSStringFinalizerStruct):
(JSC::RopeBuilder::JSStringFinalizerStruct::):

  • runtime/UString.cpp:

(JSC::UString::toStrictUInt32):
(JSC::equal):

  • runtime/UString.h:

(JSC::UString::isEmpty):
(JSC::UString::size):

  • runtime/UStringImpl.cpp:

(JSC::URopeImpl::derefFibersNonRecursive):
(JSC::URopeImpl::destructNonRecursive):

  • runtime/UStringImpl.h:

(JSC::UStringOrRopeImpl::isRope):
(JSC::UStringOrRopeImpl::length):
(JSC::UStringOrRopeImpl::ref):
(JSC::UStringOrRopeImpl::):
(JSC::UStringOrRopeImpl::operator new):
(JSC::UStringOrRopeImpl::UStringOrRopeImpl):
(JSC::UStringImpl::adopt):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):
(JSC::UStringImpl::data):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::):
(JSC::URopeImpl::tryCreateUninitialized):
(JSC::URopeImpl::initializeFiber):
(JSC::URopeImpl::fiberCount):
(JSC::URopeImpl::fibers):
(JSC::URopeImpl::deref):
(JSC::URopeImpl::URopeImpl):
(JSC::URopeImpl::hasOneRef):
(JSC::UStringOrRopeImpl::deref):

WebCore:

Renamed cUStringImpl::size() to UStringImpl::size()UStringImpl::length()
(matches WebCore::StringImpl).

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::length):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::add):
(WebCore::AtomicString::find):

3:55 PM Changeset in webkit [54842] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r54811) fast/canvas/drawImage-with-negative-source-destination.html fails
​https://bugs.webkit.org/show_bug.cgi?id=35005

  • platform/qt/Skipped:
    • fast/canvas/drawImage-with-negative-source-destination.html skipped until fix.
    • inspector/timeline-paint.html skipped because it is flakey.
3:49 PM Changeset in webkit [54841] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7288853> Message about missing plugin does not specify
the type or download link for download

Reviewed by Mark Rowe.

  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::findPlugin):
Only update the mimeType out param if we find a plug-in for the file
extension.

3:41 PM Changeset in webkit [54840] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-02-16 Simon Fraser <Simon Fraser>

Build fix for Tiger.

Add #if USE(ACCELERATED_COMPOSITING) around the call to mediaPlayerRenderingModeChanged().

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setUpVideoRendering):
3:03 PM Changeset in webkit [54839] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

Buildfix for r54826.

Reviewed by Eric Carlson.

HTMLMediaElement class defined by HTMLMediaElement.h in #if ENABLE(VIDEO) block,
it should be in #if ENABLE(VIDEO) block in rendering/RenderLayerBacking.cpp too.

  • rendering/RenderLayerBacking.cpp: Missing #if ENABLE(VIDEO) guard added.

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

3:02 PM Changeset in webkit [54838] by mrowe@apple.com
  • 6 edits
    75 deletes in trunk

Roll out the rest of r54833 as it includes more unrelated changes.

3:00 PM Changeset in webkit [54837] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Let's not check garbage in to common build scripts and hose the world now eh guys?

  • Scripts/webkitdirs.pm:
2:56 PM Changeset in webkit [54836] by jparent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed: Chromium build fix.

​http://trac.webkit.org/changeset/54823 introduced an unused variable. Remove it.

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

2:53 PM Changeset in webkit [54835] by mrowe@apple.com
  • 9 edits in trunk/WebCore

Bug 34974: Leak of ScheduledAction during layout tests
<​https://bugs.webkit.org/show_bug.cgi?id=34974>

Reviewed by Alexey Proskuryakov.

ScheduledAction::create was returning a raw pointer which was threaded down through to an OwnPtr in DOMTimer.
If any of the code paths in between hit an error case and returned early the raw pointer would be leaked. We
can avoid this by passing it as a PassOwnPtr. This will ensure that the ScheduledAction is cleaned up should
an error case be hit.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setTimeout): Store the newly-created ScheduledAction in an OwnPtr and then hand it off
as the function argument.
(WebCore::JSDOMWindow::setInterval): Ditto.

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::setTimeout): Ditto.
(WebCore::JSWorkerContext::setInterval): Ditto.

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create): Return a PassOwnPtr.

  • bindings/js/ScheduledAction.h:
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer): Update argument type.
(WebCore::DOMTimer::install): Ditto.

  • page/DOMTimer.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::setTimeout): Ditto.
(WebCore::DOMWindow::setInterval): Ditto.

  • page/DOMWindow.h:
2:51 PM Changeset in webkit [54834] by Nikolas Zimmermann
  • 9 edits in trunk/WebCore

2010-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by David Hyatt.

SVG units don't stay consistently sized on zoom
​https://bugs.webkit.org/show_bug.cgi?id=14004

Large step towards making WebKit an usable SVG viewer.

Make zooming into SVG documents work as expected, in both standalone and XHTML/SVG compound documents.
SVG applies a global scale to the document, whereas CSS zooms all individual length units (on full-page-zoom).
Scaling has to be avoided for all SVG specific CSS properties (already works) and for some selected CSS
properties shared between CSS & SVG that explicitely need a different treatment in the context of SVG.
To name a few: font-size, letter-spacing, etc. should stay invariant under zoom in SVG document fragments.

Some new rules regarding zooming:

  • "Zoom text only" should never affect SVG documents, neither text nor content should zoom. This option doesn't make much sense for SVG, so it's wise to avoid side-effects and disable it. In compound documents the SVG would stay as-is and only text of surrounding XHTML content would zoom.
  • "Full page zoom" is the only zoom mode affecting SVG. (Panning only works in standalone documents.)

Cover all mentioned cases above by a new set of layout tests.

Tests: svg/zoom/page/absolute-sized-document-no-scrollbars.svg

svg/zoom/page/absolute-sized-document-scrollbars.svg
svg/zoom/page/relative-sized-document-scrollbars.svg
svg/zoom/page/zoom-coords-viewattr-01-b.svg
svg/zoom/page/zoom-foreignObject.svg
svg/zoom/page/zoom-hixie-mixed-008.xml
svg/zoom/page/zoom-hixie-mixed-009.xml
svg/zoom/page/zoom-hixie-rendering-model-004.xhtml
svg/zoom/page/zoom-svg-float-border-padding.xml
svg/zoom/text/absolute-sized-document-no-scrollbars.svg
svg/zoom/text/absolute-sized-document-scrollbars.svg
svg/zoom/text/relative-sized-document-scrollbars.svg
svg/zoom/text/zoom-coords-viewattr-01-b.svg
svg/zoom/text/zoom-foreignObject.svg
svg/zoom/text/zoom-hixie-mixed-008.xml
svg/zoom/text/zoom-hixie-mixed-009.xml
svg/zoom/text/zoom-hixie-rendering-model-004.xhtml
svg/zoom/text/zoom-svg-float-border-padding.xml

  • css/CSSStyleSelector.cpp: Blacklist certain properties not to be zoomed for SVG elements. (WebCore::CSSStyleSelector::styleForDocument): Don't zoom font-sizes. (WebCore::CSSStyleSelector::applyProperty): Ditto (+ letter/word-spacing). (WebCore::CSSStyleSelector::setFontSize): Ditto. (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): Never apply text zoom to SVG.
  • css/CSSStyleSelector.h:
  • css/SVGCSSStyleSelector.cpp: -webkit-shadow + SVG was incorrectly respecting zoom factor. (WebCore::CSSStyleSelector::applySVGProperty):
  • page/Frame.cpp: (WebCore::Frame::shouldApplyTextZoom): Remove SVG special cases. (WebCore::Frame::shouldApplyPageZoom): Ditto. (WebCore::Frame::setZoomFactor): Don't force setZoomsTextOnly() - SVG now uses FPZ as well.
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcReplacedWidth): CSSPropertyWidth is explicitely not scaled by CSSStyleSelector, fix that for outermost <svg> elements. (WebCore::RenderSVGRoot::calcReplacedHeight): Ditto for CSSPropertyHeight. (WebCore::RenderSVGRoot::layout): Simplify & cleanup code, take advantage of new calcWidth/Height functionality, no need to scale anything here. (WebCore::RenderSVGRoot::paint): Use parentOriginToBorderBox() instead of duplicating code. (WebCore::RenderSVGRoot::calcViewport): Simplify code. (WebCore::RenderSVGRoot::localToBorderBoxTransform): Calculate viewBoxToViewTransformation() against unscaled width()/height() values.
  • rendering/RenderSVGRoot.h:
  • svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport): Cleanup & document function.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): Return pageZoomFactor(), not just the zoomFactor() - as we want to ignore text-only zoom. (WebCore::SVGSVGElement::setCurrentScale): Pass isTextOnly=false to setZoomFactor().
2:46 PM Changeset in webkit [54833] by Nikolas Zimmermann
  • 7 edits
    82 adds in trunk

2010-02-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by David Hyatt.

SVG units don't stay consistently sized on zoom
​https://bugs.webkit.org/show_bug.cgi?id=14004

  • platform/mac/svg/zoom: Added.
  • platform/mac/svg/zoom/page: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/mac/svg/zoom/text: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
  • svg/zoom: Added.
  • svg/zoom/NOTE: Added.
  • svg/zoom/page: Added.
  • svg/zoom/page/absolute-sized-document-no-scrollbars.svg: Added.
  • svg/zoom/page/absolute-sized-document-scrollbars.svg: Added.
  • svg/zoom/page/relative-sized-document-scrollbars.svg: Added.
  • svg/zoom/page/zoom-coords-viewattr-01-b.svg: Added.
  • svg/zoom/page/zoom-foreignObject.svg: Added.
  • svg/zoom/page/zoom-hixie-mixed-008.xml: Added.
  • svg/zoom/page/zoom-hixie-mixed-009.xml: Added.
  • svg/zoom/page/zoom-hixie-rendering-model-004.xhtml: Added.
  • svg/zoom/page/zoom-svg-float-border-padding.xml: Added.
  • svg/zoom/resources: Added.
  • svg/zoom/resources/testPageZoom.js: Added.
  • svg/zoom/resources/testTextZoom.js: Added.
  • svg/zoom/text: Added.
  • svg/zoom/text/absolute-sized-document-no-scrollbars.svg: Added.
  • svg/zoom/text/absolute-sized-document-scrollbars.svg: Added.
  • svg/zoom/text/relative-sized-document-scrollbars.svg: Added.
  • svg/zoom/text/zoom-coords-viewattr-01-b.svg: Added.
  • svg/zoom/text/zoom-foreignObject.svg: Added.
  • svg/zoom/text/zoom-hixie-mixed-008.xml: Added.
  • svg/zoom/text/zoom-hixie-mixed-009.xml: Added.
  • svg/zoom/text/zoom-hixie-rendering-model-004.xhtml: Added.
  • svg/zoom/text/zoom-svg-float-border-padding.xml: Added.
2:44 PM Changeset in webkit [54832] by eric.carlson@apple.com
  • 2 edits in trunk/WebKit/mac

2010-02-16 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=34988
WebHTMLView.mm has two -willRemoveSubview: methods

  • WebView/WebHTMLView.mm: (-[WebHTMLView willRemoveSubview:]): Consolidate the two copies of this method.
2:30 PM Changeset in webkit [54831] by jparent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed: Chromium build fix.

​https://bugs.webkit.org/show_bug.cgi?id=34998

Move include of JavaScriptProfile.h behind if (USE_JSC).

  • inspector/InspectorController.cpp:
2:21 PM Changeset in webkit [54830] by eric@webkit.org
  • 3 edits
    2 adds in trunk/WebKitTools

2010-02-16 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

re-factor Skipped list parsing code into multiple functions and unit test it
​https://bugs.webkit.org/show_bug.cgi?id=34986

  • Scripts/test-webkitpy: Add new unit test.
  • Scripts/webkitpy/layout_tests/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
  • Scripts/webkitpy/layout_tests/port/mac.py: Split parsing function into multiple functions for testing.
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py: Added.
2:16 PM Changeset in webkit [54829] by ap@apple.com
  • 9 edits in trunk

Reviewed by Geoffrey Garen and Kevin Decker.

​https://bugs.webkit.org/show_bug.cgi?id=34989
<rdar://problem/7417965> Cursor disappears on scroll bars that are over plugin content

This fixes event dispatch for both Cocoa and Carbon event models (mouseEntered/mouseExited
in the former case, and adjustCursor in the latter).

  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView handleMouseEntered:]): (-[WebHostedNetscapePluginView handleMouseExited:]):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView handleMouseEntered:]): (-[WebBaseNetscapePluginView handleMouseExited:]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): (-[WebNetscapePluginView handleMouseExited:]): AppKit cannot reliably dispatch events for overlapping views. We are now asking WebCore to notify plug-in views of mouse entered/exited as part of DOM event dispatch.
  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Besides mouse moved, dispatch plugin mouse entered/exit events in HTMLPlugInElement default event handler. Other mouse events are passed down by EventHandler.
2:04 PM Changeset in webkit [54828] by Simon Fraser
  • 4 edits
    2 adds in trunk/WebCore

2010-02-16 Simon Fraser <Simon Fraser>

Reviewed by Eric Carlson.

With hardware acceleration turned off, video frames never display if poster
image is specified
​https://bugs.webkit.org/show_bug.cgi?id=34965

HTMLVideoElement's m_shouldDisplayPosterImage was never updated after
the movie supplied its first video frame, so the poster would continue to show.

Fixed by calling updatePosterImage() from mediaPlayerRepaint(), which is called
each time a new frame is available. updatePosterImage() is cheap.

Also made updatePosterImage() virtual on HTMLMediaElement to avoid a number of
ugly casts.

Test: manual-tests/media-elements/video-replaces-poster.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::noneSupported): Call updatePosterImage() without video check. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::setReadyState): Ditto. (WebCore::HTMLMediaElement::mediaPlayerRepaint): Call udpatePosterImage().
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::updatePosterImage): Make this an empty virtual method on the base class.
  • html/HTMLVideoElement.h: Override updatePosterImage().
1:55 PM Changeset in webkit [54827] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-02-16 Simon Fraser <Simon Fraser>

Build fix for platforms without ACCELERATED_COMPOSITING defined.

mediaPlayerRenderingModeChanged() is only available when ACCELERATED_COMPOSITING is defined.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::setUpVideoRendering):
1:46 PM Changeset in webkit [54826] by Simon Fraser
  • 14 edits
    4 adds in trunk

2010-02-16 Simon Fraser <Simon Fraser>

Reviewed by Eric Carlson.

Autoplaying video with poster doesn't reliably show up
​https://bugs.webkit.org/show_bug.cgi?id=34966

A timing issue with compositing updates when replacing the poster image
with the video could cause the video to not display.

Fix by making video layer hook up more similar to WebGL etc, by having the
video kick off a recalcStyle() via a SyntheticStyleChange. This requires
vending a PlaformLayer* from the media player, up through the element.

Test: media/video-replaces-poster.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerRenderingModeChanged): Use setNeedsStyleRecalc() to kick off a compositing update.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::platformLayer): Export the media engine's layer.
  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::platformLayer): Method to vend the media layer. (WebCore::MediaPlayer::platformLayer):
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRenderingModeChanged): New client callback to indicate that the rendering mode changed. The element uses this to kick off a recalcStyle.
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::platformLayer): Method to vend the media layer.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Ditto
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): No longer parent the layer directly via setContentsToMedia(). (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): Ditto. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Tell the client that the rendering mode changed. (WebCore::MediaPlayerPrivate::platformLayer): Method to vend the media layer.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Call setContentsToMedia() here.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: Add platformLayer().
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::platformLayer): Method to vend the media layer. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Call mediaPlayerRenderingModeChanged() (WebCore::MediaPlayerPrivate::createLayerForMovie): Don't parent the layer ourselves any more.
  • rendering/RenderVideo.h: videoGraphicsLayer() is no longer needed.
  • rendering/RenderVideo.cpp: Ditto.
1:06 PM Changeset in webkit [54825] by kov@webkit.org
  • 15 edits in trunk/WebKit/gtk/po

2010-02-16 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Refreshed all localization-related files, so that they are
up-to-date with the code.

  • de.po: Updated.
  • en_GB.po: Updated.
  • es.po: Updated.
  • it.po: Updated.
  • lt.po: Updated.
  • nl.po: Updated.
  • pt_BR.po: Updated.
  • ru.po: Updated.
  • sr.po: Updated.
  • ​sr@latin.po: Updated.
  • sv.po: Updated.
  • vi.po: Updated.
  • webkit.pot: Updated.
  • zh_CN.po: Updated.
1:06 PM Changeset in webkit [54824] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-02-16 Gil Osher <​gilosher@gmail.com>

Reviewed by Gustavo Noronha.

Localization of WebKitGTK+ in Hebrew.

  • he.po: Added.
12:50 PM Changeset in webkit [54823] by pkasting@chromium.org
  • 19 edits in trunk/WebCore

Code cleanup in ImageDecoders; no functional change.
​https://bugs.webkit.org/show_bug.cgi?id=28751

Reviewed by Adam Barth.

  • Make code mostly comply with the style guide (switch indenting, use of "!" vs. "== 0", don't unnecessarily wrap lines, etc.)
  • Eliminate m_allDataReceived in ICO/BMP decoders since it's in the base ImageDecoder class
  • Remove some useless or wrong comments, add others
  • Wrap comments at 80 columns (most already were) for consistency/readability
  • Avoid casts by using correct variable types
  • Consistent naming of decode() function/args
  • Shorter code in some places
  • Make declaration and definition order match
  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::forceLoadEverything):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::setSize):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::RGBA32Buffer::):
(WebCore::ImageDecoder::ImageDecoder):

  • platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::BMPImageDecoder):
(WebCore::BMPImageDecoder::setData):
(WebCore::BMPImageDecoder::isSizeAvailable):
(WebCore::BMPImageDecoder::frameBufferAtIndex):
(WebCore::BMPImageDecoder::decode):
(WebCore::BMPImageDecoder::decodeHelper):
(WebCore::BMPImageDecoder::processFileHeader):

  • platform/image-decoders/bmp/BMPImageDecoder.h:

(WebCore::BMPImageDecoder::readUint32):

  • platform/image-decoders/bmp/BMPImageReader.cpp:

(WebCore::BMPImageReader::BMPImageReader):
(WebCore::BMPImageReader::decodeBMP):
(WebCore::BMPImageReader::readInfoHeaderSize):
(WebCore::BMPImageReader::processInfoHeader):
(WebCore::BMPImageReader::readInfoHeader):
(WebCore::BMPImageReader::isInfoHeaderValid):
(WebCore::BMPImageReader::processBitmasks):
(WebCore::BMPImageReader::processColorTable):
(WebCore::BMPImageReader::processRLEData):
(WebCore::BMPImageReader::processNonRLEData):

  • platform/image-decoders/bmp/BMPImageReader.h:

(WebCore::BMPImageReader::readUint32):
(WebCore::BMPImageReader::pastEndOfImage):
(WebCore::BMPImageReader::readCurrentPixel):
(WebCore::BMPImageReader::getComponent):
(WebCore::BMPImageReader::getAlpha):
(WebCore::BMPImageReader::setI):
(WebCore::BMPImageReader::setRGBA):

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::isSizeAvailable):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::sizeNowAvailable):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):

  • platform/image-decoders/gif/GIFImageDecoder.h:

(WebCore::GIFImageDecoder::):
(WebCore::GIFImageDecoder::filenameExtension):

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::do_lzw):
(GIFImageReader::read):

  • platform/image-decoders/gif/GIFImageReader.h:

(GIFImageReader::~GIFImageReader):

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::ICOImageDecoder):
(WebCore::ICOImageDecoder::~ICOImageDecoder):
(WebCore::ICOImageDecoder::setData):
(WebCore::ICOImageDecoder::isSizeAvailable):
(WebCore::ICOImageDecoder::frameSizeAtIndex):
(WebCore::ICOImageDecoder::frameCount):
(WebCore::ICOImageDecoder::frameBufferAtIndex):
(WebCore::ICOImageDecoder::compareEntries):
(WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex):
(WebCore::ICOImageDecoder::decode):
(WebCore::ICOImageDecoder::decodeDirectory):
(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectoryEntries):
(WebCore::ICOImageDecoder::readDirectoryEntry):

  • platform/image-decoders/ico/ICOImageDecoder.h:

(WebCore::ICOImageDecoder::readUint16):
(WebCore::ICOImageDecoder::readUint32):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::skipBytes):
(WebCore::JPEGImageReader::decode):
(WebCore::error_exit):
(WebCore::fill_input_buffer):
(WebCore::term_source):
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::setSize):
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
(WebCore::JPEGImageDecoder::jpegComplete):
(WebCore::JPEGImageDecoder::decode):

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:

(WebCore::JPEGImageDecoder::filenameExtension):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::decodingFailed):
(WebCore::decodingWarning):
(WebCore::headerAvailable):
(WebCore::rowAvailable):
(WebCore::pngComplete):
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageReader::createInterlaceBuffer):
(WebCore::PNGImageDecoder::setData):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::decode):

  • platform/image-decoders/png/PNGImageDecoder.h:

(WebCore::PNGImageDecoder::filenameExtension):

  • platform/image-decoders/qt/RGBA32BufferQt.cpp:

(WebCore::RGBA32Buffer::setDecodedImage):

6:44 AM Changeset in webkit [54822] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-02-16 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Check if the handle has a SoupMessage before trying to use
it. This will be the case in non-HTTP(S) URLs.

  • webkit/webkitdownload.cpp: (webkit_download_new_with_handle): (webkit_download_start):
5:32 AM Changeset in webkit [54821] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

[Qt] Unreviewed buildfix.

  • WebCore.pro: Missing backslash added.
5:17 AM Changeset in webkit [54820] by mnaganov@chromium.org
  • 6 edits
    4 moves in trunk/WebCore

2010-02-16 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Move JSC-specific wrappers for Profile and ProfileNode to bindings/js.

​https://bugs.webkit.org/show_bug.cgi?id=34848

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JavaScriptProfile.cpp: Added. (WebCore::profileCache): (WebCore::getTitleCallback): (WebCore::getHeadCallback): (WebCore::getUniqueIdCallback): (WebCore::focus): (WebCore::exclude): (WebCore::restoreAll): (WebCore::finalize): (WebCore::ProfileClass): (WebCore::toJS):
  • bindings/js/JavaScriptProfile.h: Added.
  • bindings/js/JavaScriptProfileNode.cpp: Added. (WebCore::profileNodeCache): (WebCore::getFunctionName): (WebCore::getURL): (WebCore::getLineNumber): (WebCore::getTotalTime): (WebCore::getSelfTime): (WebCore::getNumberOfCalls): (WebCore::getChildren): (WebCore::getVisible): (WebCore::getCallUID): (WebCore::finalize): (WebCore::ProfileNodeClass): (WebCore::toJS):
  • bindings/js/JavaScriptProfileNode.h: Added.
  • inspector/JavaScriptProfile.cpp: Removed.
  • inspector/JavaScriptProfile.h: Removed.
  • inspector/JavaScriptProfileNode.cpp: Removed.
  • inspector/JavaScriptProfileNode.h: Removed.
5:11 AM Changeset in webkit [54819] by apavlov@chromium.org
  • 7 edits
    2 adds in trunk

2010-02-16 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Elements Panel: Limit the number of initially loaded element children
​https://bugs.webkit.org/show_bug.cgi?id=34421

Test: inspector/elements-panel-limited-children.html

WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._insertChild):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.createTreeElementFor): (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.get expandedChildrenLimit): (WebInspector.ElementsTreeElement.prototype.set expandedChildrenLimit): (WebInspector.ElementsTreeElement.prototype.get expandedChildCount): (WebInspector.ElementsTreeElement.prototype.showChild): (WebInspector.ElementsTreeElement.prototype.insertChildElement): (WebInspector.ElementsTreeElement.prototype.moveChild): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange): (WebInspector.ElementsTreeElement.prototype.handleLoadAllChildren): ():
  • inspector/front-end/inspector.css:

LayoutTests:

  • inspector/elements-panel-limited-children-expected.txt: Added.
  • inspector/elements-panel-limited-children.html: Added.
4:54 AM Changeset in webkit [54818] by xan@webkit.org
  • 7 edits in trunk

2010-02-16 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump version to 1.1.22 so we can depend on it in applications.

  • configure.ac:

WebKit/gtk:

2010-02-16 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add a new WebKitWebSettings setting, 'auto-resize-window', set to
FALSE by default, that when enabled will apply any resizes or
moves done by a page through various DOM methods (moveTo,
resizeTo, moveBy, resizeBy).

  • WebCoreSupport/ChromeClientGtk.cpp:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):

WebKitTools:

2010-02-16 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Enable 'auto-resize-window' in our DRT.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
3:18 AM Changeset in webkit [54817] by benm@google.com
  • 1 edit
    3 copies
    3 moves in trunk/LayoutTests

Refactor and split up basic-touch-events test
​https://bugs.webkit.org/show_bug.cgi?id=34476

Reviewed by Simon Hausmann.

Split the basic-touch-events test into two separate tests, one for single and another for multi touch. Also refactor the tests to run in an asynchronous manner.

  • fast/events/touch/basic-multi-touch-events.html: Copied from LayoutTests/fast/events/touch/basic-touch-events.html. Tests the same multi touch tests cases from the old basic-touch-events test.
  • fast/events/touch/basic-multi-touch-events-expected.txt: Added.
  • fast/events/touch/script-tests/basic-multi-touch-events.js: Added.
  • fast/events/touch/basic-single-touch-events.html: Copied from LayoutTests/fast/events/touch/basic-touch-events.html. Tests the same single touch tests cases from the old basic-touch-events test.
  • fast/events/touch/script-tests/basic-single-touch-events.js: Added.
  • fast/events/touch/basic-single-touch-events-expected.txt: Added.
  • fast/events/touch/basic-touch-events.html: Removed.
  • fast/events/touch/script-tests/basic-touch-events.js: Removed.
  • fast/events/touch/basic-touch-events-expected.txt: Removed.
3:14 AM Changeset in webkit [54816] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Unreviewed Symbian build fix.

Updated the def file with two new exports used by QtLauncher.

  • symbian/eabi/QtWebKitu.def:
3:10 AM Changeset in webkit [54815] by eric@webkit.org
  • 4 edits in trunk

2010-02-16 Ismail Donmez <​ismail@namtrac.org>

Reviewed by Pavel Feldman.

Fix compilation with inspector disabled.
​https://bugs.webkit.org/show_bug.cgi?id=32724

  • rendering/RenderLayerBacking.cpp: (WebCore::inspectorTimelineAgent):

2010-02-16 Ismail Donmez <​ismail@namtrac.org>

Reviewed by Pavel Feldman.

Fix compilation with inspector disabled.
​https://bugs.webkit.org/show_bug.cgi?id=32724

  • Api/qwebpage.cpp: (qt_drt_webinspector_executeScript): (qt_drt_webinspector_close): (qt_drt_webinspector_show): (qt_drt_setTimelineProfilingEnabled):
2:27 AM Changeset in webkit [54814] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fix include paths for forwarding headers in standalone builds.

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2010-02-16
Reviewed by Simon Hausman.

  • Api/DerivedSources.pro: Use relative paths for package builds and added some

documentation.

2:25 AM Changeset in webkit [54813] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-02-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: turn off line wrapping in source view.

​https://bugs.webkit.org/show_bug.cgi?id=34935

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.markAndRevealRange): (WebInspector.TextViewer.prototype._paintLine):
  • inspector/front-end/textViewer.css:
  • inspector/front-end/utilities.js:
2:08 AM Changeset in webkit [54812] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-02-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: let search iterate over views in Resources
and keep the view in Scripts.

​https://bugs.webkit.org/show_bug.cgi?id=34968

  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.jumpToNextSearchResult): (WebInspector.Panel.prototype.jumpToPreviousSearchResult): (WebInspector.Panel.prototype.showSourceLineForURL): (WebInspector.Panel.prototype.searchIteratesOverViews):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get _resources): (WebInspector.ResourcesPanel.prototype.searchIteratesOverViews):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.showingLastSearchResult):
  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown): (WebInspector.focusSearchField):
1:17 AM Changeset in webkit [54811] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-16 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] canvas clipping is buggy
​https://bugs.webkit.org/show_bug.cgi?id=32405

Apparently the bug was in GraphicsContext::roundToDevicePixels, we
didn't take unto accounts rotation, so the device pixels were rounded
incorrectly. The new formula is a 1:1 copy from GraphicsContextCG so
it should be rather safe

Test: ​http://glimr.rubyforge.org/cake/canvas.html#Polaroids now looks right

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Copy the formula from GraphicsContextCG
12:48 AM Changeset in webkit [54810] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-02-16 Yury Semikhatsky <​yurys@chromium.org>

Not Reviewed, build fix.

  • platform/graphics/FloatRect.h: (WebCore::FloatRect::center): make conversion from float to int explicit so that compiler doesn't complain about that.

Feb 15, 2010:

11:42 PM Changeset in webkit [54809] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-15 Gabor Loki <​loki@webkit.org>

Reviewed by Gavin Barraclough.

Fix the SP at ctiOpThrowNotCaught on Thumb2 (JSVALUE32)
​https://bugs.webkit.org/show_bug.cgi?id=34939

  • jit/JITStubs.cpp:
10:17 PM Changeset in webkit [54808] by Martin Robinson
  • 3 edits in trunk/WebKitTools

2010-02-15 Martin Robinson <Martin Robinson>

Reviewed by Darin Adler.

check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin
​https://bugs.webkit.org/show_bug.cgi?id=34834

  • Scripts/webkitpy/style/processors/cpp.py:
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
8:19 PM Changeset in webkit [54807] by mitz@apple.com
  • 8 edits in trunk

WebCore: <rdar://problem/7645609> [webView selectionRect] API is broken for multicolumn layout

Reviewed by Simon Fraser.

Refine the fix for ​https://bugs.webkit.org/show_bug.cgi?id=34923 by using the center of
a quad’s bounding box, rather than its top left, as the reference point passed to
offsetFromContainer(). This ensures that if a sliver off the top of the selection rect is in
one column, but most of it is on another column, the single rect we return will be for the
second column.

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::center): Added.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::localToContainerQuad): Use the center instead of the top left.

LayoutTests: Add test case for <rdar://problem/7645609> [webView selectionRect] API is broken for multicolumn layout

Reviewed by Simon Fraser.

  • fast/multicol/client-rects-expected.checksum:
  • fast/multicol/client-rects-expected.png:
  • fast/multicol/client-rects-expected.txt:
  • fast/multicol/client-rects.html:
6:36 PM Changeset in webkit [54806] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-15 MORITA Hajime <​morrita@gmail.com>

Reviewed by Nikolas Zimmermann.

SVG text refactor: reduce paint specific callbacks on SVGTextChunkWalker

​https://bugs.webkit.org/show_bug.cgi?id=34831

No new tests, no change of functionality.

  • rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::SVGTextChunkWalker): Removed setupBackground(), setupFill(), setupFillSelection(), setupStroke(), setupStrokeSelection(), setupForeground() and associated member variables.
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::setupBackground): renamed from chunkSetupBackgroundCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupFill): renamed from chunkSetupFillCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupFillSelection): renamed from chunkSetupFillSelectionCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupStroke): renamed from chunkSetupStrokeCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupStrokeSelection): renamed from chunkSetupStrokeSelectionCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupForeground): renamed from chunkSetupForegroundCallback. (WebCore::SVGRootInlineBoxPaintWalker::paintChunk): renamed from chunkPortionCallback. (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): extracted from walkTextChunks. (WebCore::SVGRootInlineBox::paint): follow SVGTextChunkWalker change. (WebCore::SVGRootInlineBox::walkTextChunks): moved paint some specific code to SVGRootInlineBoxPaintWalker::chunkPortionCallback().
5:54 PM Changeset in webkit [54805] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (Build Fix!).

5:32 PM Changeset in webkit [54804] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

Some general Rope related refactoring.

Reviewed by Oliver Hunt.

Rename Rope::m_ropeLength to m_fiberCount, to be more descriptive.
Rename Rope::m_stringLength to simply m_length (since this is the
more conventional name for the length of a string). Move append
behaviour out into a new RopeBuilder class, so that Rope no longer
needs any knowledge of the JSString or UString implementation.

Make Rope no longer be nested within JSString.
(Rope now no-longer need reside within JSString.h, but leaving
the change of moving this out to a different header as a separate
change from these renames).

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • runtime/JSString.cpp:

(JSC::Rope::destructNonRecursive):
(JSC::Rope::~Rope):
(JSC::JSString::resolveRope):
(JSC::JSString::toBoolean):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::Rope::Fiber::Fiber):
(JSC::Rope::Fiber::deref):
(JSC::Rope::Fiber::ref):
(JSC::Rope::Fiber::refAndGetLength):
(JSC::Rope::Fiber::isRope):
(JSC::Rope::Fiber::rope):
(JSC::Rope::Fiber::isString):
(JSC::Rope::Fiber::string):
(JSC::Rope::Fiber::nonFiber):
(JSC::Rope::tryCreateUninitialized):
(JSC::Rope::append):
(JSC::Rope::fiberCount):
(JSC::Rope::length):
(JSC::Rope::fibers):
(JSC::Rope::Rope):
(JSC::Rope::operator new):
(JSC::):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::~JSString):
(JSC::RopeBuilder::length):
(JSC::RopeBuilder::canGetIndex):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::isRope):
(JSC::RopeBuilder::fiberCount):
(JSC::JSString::getStringPropertySlot):

  • runtime/Operations.h:

(JSC::jsString):

4:25 PM Changeset in webkit [54803] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

[Chromium] Fix StorageNamespaceProxy::copy() for test shell
​https://bugs.webkit.org/show_bug.cgi?id=34949

Reviewed by Darin Fisher.

Chromium passes back NULL when you call WebStorageNamespace::proxy()
but TestShell returns a valid object. Both need to work via
the WebStorageNamespace.

  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespaceProxy::copy):

4:19 PM Changeset in webkit [54802] by mitz@apple.com
  • 2 edits in trunk/WebCore

Try to fix the Chromium build.

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::convertToPaintingRect):

3:44 PM Changeset in webkit [54801] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Add missing cast for !YARR (PPC) builds.

Reviewed by NOBODY (Build fix).

  • runtime/RegExp.cpp:

(JSC::RegExp::match):

2:58 PM Changeset in webkit [54800] by bweinstein@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/Skipped

Add newline to end of Windows skipped list

2:57 PM Changeset in webkit [54799] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Dan Bernstein.

Skipped glyph-reordering on Windows since it has failed since it was landed. Left a comment
in <​https://bugs.webkit.org/show_bug.cgi?id=34865> to track the failure.

  • platform/win/Skipped:
2:37 PM Changeset in webkit [54798] by barraclough@apple.com
  • 7 edits
    2 deletes in trunk

​https://bugs.webkit.org/show_bug.cgi?id=33731
Many false leaks in release builds due to PtrAndFlags

Reviewed by Darin Adler.

JavaScriptCore:

StructureTransitionTable was effectively a smart pointer type,
one machine word in size and wholly contained as a member of
of Structure. It either pointed to an actual table, or could
be used to describe a single transtion entry without use of a
table.

This, however, worked by using a PtrAndFlags, which is not
compatible with the leaks tool. Since there is no clear way to
obtain another bit for 'free' here, and since there are bits
available up in Structure, merge this functionality back up into
Structure. Having this in a separate class was quite clean
from an enacapsulation perspective, but this solution doesn't
seem to bad - all table access is now intermediated through the
Structure::structureTransitionTableFoo methods, keeping the
optimization fairly well contained.

This was the last use of PtrAndFlags, so removing the file too.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.h:
  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::hasTransition):

  • runtime/Structure.h:

(JSC::Structure::):
(JSC::Structure::structureTransitionTableContains):
(JSC::Structure::structureTransitionTableGet):
(JSC::Structure::structureTransitionTableHasTransition):
(JSC::Structure::structureTransitionTableRemove):
(JSC::Structure::structureTransitionTableAdd):
(JSC::Structure::structureTransitionTable):
(JSC::Structure::setStructureTransitionTable):
(JSC::Structure::singleTransition):
(JSC::Structure::setSingleTransition):

  • runtime/StructureTransitionTable.h:
  • wtf/PtrAndFlags.h: Removed.

WebCore:

PtrAndFlags has now been removed; remove forwarding header.

  • ForwardingHeaders/wtf/PtrAndFlags.h: Removed.
2:21 PM Changeset in webkit [54797] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Skip more plugin tests on Snow Leopard buildbot, as they need updated closed source components.

  • platform/mac-snowleopard/Skipped: Skip netscape-dom-access.html and netscape-browser-object-identity.html.
1:48 PM Changeset in webkit [54796] by Adam Roben
  • 5 edits in trunk/WebKit/win

Add IWebFramePrivate::visibleContentRect

Fixes <​http://webkit.org/b/34956> Add API to get a WebFrame's visible
content rect

Reviewed by Jon Honeycutt.

  • Interfaces/IWebFramePrivate.idl: Added visibleContentRect.
  • Interfaces/WebKit.idl: Touched to force a build.
  • WebFrame.cpp:

(WebFrame::visibleContentRect):

  • WebFrame.h:

Added. Calls through to FrameView::visibleContentRect.

1:43 PM Changeset in webkit [54795] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Rubber Stamped by Geoff Garen.

Bug 34948 - tryMakeString should fail on error in length calculation

Ooops! - "bool overflow" argument should have been "bool& overflow".

  • runtime/UString.h:

(JSC::sumWithOverflow):
(JSC::tryMakeString):

1:41 PM Changeset in webkit [54794] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Some symbol names have changed, remove, will readd if required.

Reviewed by NOBODY (Build Fix (pt 2!)).

1:37 PM Changeset in webkit [54793] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/multicol/client-rects.html fails in QtLauncher
​https://bugs.webkit.org/show_bug.cgi?id=34959

  • platform/qt/Skipped: fast/multicol/client-rects.html skipped until fix.
1:24 PM Changeset in webkit [54792] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Some symbol names have changed, remove, will readd if required.

Reviewed by NOBODY (Build Fix (pt 1?)).

1:18 PM Changeset in webkit [54791] by ap@apple.com
  • 3 edits in trunk/WebKit/mac

More build fixing (for what is actually a 64-bit failure, as 32-bit apparently includes
headers that aren't included in 64-bit).

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::contains): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Move inline functions to .cpp; also made the class Noncopyable.
1:09 PM Changeset in webkit [54790] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Removed some mistaken code added in ​http://trac.webkit.org/changeset/53860.

Reviewed by Oliver Hunt.

  • API/APIShims.h:

(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim): No need to start/stop the
timeout checker when calling out from the API to the client; we want to
monitor the VM for timeouts, not the client. This mistake was harmless /
undetectable, since it's totally redundant with the APIEntryShim, which
also starts / stops the timeout checker.

1:03 PM Changeset in webkit [54789] by barraclough@apple.com
  • 18 edits in trunk

Bug 34952 - String lengths in UString should be unsigned.
This matches WebCore::StringImpl, and better unifies behaviour throughout JSC.

Reviewed by Geoff Garen.

JavaScriptCore:

  • JavaScriptCore.exp:
  • bytecode/EvalCodeCache.h:
  • runtime/Identifier.cpp:

(JSC::Identifier::equal):

  • runtime/Identifier.h:
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEscape):

  • runtime/JSONObject.cpp:

(JSC::gap):
(JSC::Stringifier::indent):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):

  • runtime/RegExp.cpp:

(JSC::RegExp::match):

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncSplit):
(JSC::trimString):

  • runtime/UString.cpp:

(JSC::UString::UString):
(JSC::UString::from):
(JSC::UString::getCString):
(JSC::UString::ascii):
(JSC::UString::operator[]):
(JSC::UString::toStrictUInt32):
(JSC::UString::find):
(JSC::UString::rfind):
(JSC::UString::substr):
(JSC::operator<):
(JSC::operator>):
(JSC::compare):
(JSC::equal):
(JSC::UString::UTF8String):

  • runtime/UString.h:

(JSC::UString::size):
(JSC::operator==):

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::create):
(JSC::UStringImpl::size):
(JSC::UStringImpl::computeHash):
(JSC::UStringImpl::UStringImpl):

WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::atob):
(WebCore::JSDOMWindow::btoa):

12:59 PM Changeset in webkit [54788] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 34948 - tryMakeString should fail on error in length calculation

Reviewed by Geoff Garen.

The sum of the length of substrings could overflow.

  • runtime/UString.h:

(JSC::sumWithOverflow):
(JSC::tryMakeString):

12:42 PM Changeset in webkit [54787] by ap@apple.com
  • 3 edits in trunk/WebKit/mac

Mac release build fix attempt.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::~LocalObjectMap): Implement destructor in .cpp file, where necessary headers are already included.
12:35 PM Changeset in webkit [54786] by kov@webkit.org
  • 3 edits
    3 adds in trunk

2010-02-15 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crashes when going back to a page that has data: URIs, with page cache enabled
​https://bugs.webkit.org/show_bug.cgi?id=34944

Set the URL in the newly created response, when parsing data:
URIs.

Test: fast/harness/page-cache-crash-on-data-urls.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
12:32 PM Changeset in webkit [54785] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed <rdar://problem/7628524> Crash beneath JSGlobalContextRelease when
typing in Google search field with GuardMalloc/full page heap enabled

Reviewed by Oliver Hunt.

  • API/JSContextRef.cpp: Don't use APIEntryShim, since that requires

a JSGlobalData, which this function destroys. Do use setCurrentIdentifierTable
and JSLock instead, since those are the two features of APIEntryShim we
require.

11:48 AM Changeset in webkit [54784] by mitz@apple.com
  • 15 edits
    4 adds in trunk

<rdar://problem/7647300> Incorrect client rects for blocks the span multiple columns and their descendants
​https://bugs.webkit.org/show_bug.cgi?id=34923

Reviewed by Simon Fraser.

WebCore:

Test: fast/multicol/client-rects.html

In column layout, a different transform applies to different points in
the block and its descendants, depending on their y coordinate within the
block. offsetFromContainer() used to return the offset that applied to
the origin. With this change, it returns the offset that applies to a
given reference point. When mapping a quad from local to absolute
coordinates, the top left of the quad’s bounding box is used as that
reference point.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::layout): Pass the caret’s origin as the
reference point to offsetFromContainer().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForColumns): Adds the offset between the
given point and its image under the column paint-time transform to the
given offset. Used by offsetFromContainer() where it had previously used
adjustRectForColumns(), which takes a rect and operates less efficiently.

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer): Pass the transformed point as
the reference point to offsetFromContainer().
(WebCore::RenderBox::mapAbsoluteToLocalPoint): Pass a point to
offsetFromContainer().
(WebCore::RenderBox::offsetFromContainer): Use adjustForColumns() instead
of adjustRectForColumns(), and use the reference point to get the right
adjustment for the point of interest, instead of the origin, in case this
box spans multiple columns.

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetFromContainer): Ditto. Actually apply the
column offset to the computation, which previously this function didn’t
do.
(WebCore::RenderInline::mapLocalToContainer): Pass the transformed point
as the reference point to offsetFromContainer().
(WebCore::RenderInline::mapAbsoluteToLocalPoint): Pass a point to
offsetFromContainer().

  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::mapLocalToContainer): Apply column adjustment,
based on the reference point, to the transform if needed.
(WebCore::RenderObject::localToContainerQuad): Initialize the
TransformState with the top left corner of the quad’s bounding box. It
is later used as the reference point when deciding on which column to
base the calculations.
(WebCore::RenderObject::offsetFromContainer): Adjust for columns.
(WebCore::RenderObject::offsetFromAncestorContainer): Pass the origin
as the reference point to offsetFromContainer().

  • rendering/RenderObject.h:

(WebCore::RenderObject::adjustForColumns): Added.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::offsetFromContainer): Pass the reference
point through.

  • rendering/RenderTableCell.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRectsForRange): Map (the origin of) each
rect to absolute coordinates individually.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::convertToPaintingRect): Pass a point to
offsetFromContainer().

LayoutTests:

  • fast/multicol/client-rects-expected.checksum: Added.
  • fast/multicol/client-rects-expected.png: Added.
  • fast/multicol/client-rects-expected.txt: Added.
  • fast/multicol/client-rects.html: Added.
11:16 AM Changeset in webkit [54783] by ap@apple.com
  • 13 edits
    3 adds in trunk

Reviewed by Kevin Decker.

<rdar://problem/7130641> Browser objects identity is not preserved by Safari

Test: plugins/netscape-browser-object-identity.html

  • bridge/runtime_root.h: (JSC::Bindings::RootObject::addInvalidationCallback): RootObject can now call out during invalidation, making it possible for other code to know when this happens.
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::InvalidationCallback::~InvalidationCallback): Empty destructor, in cpp file since it's virtual. (JSC::Bindings::RootObject::invalidate): Invoke invalidation callbacks.
  • bridge/NP_jsobject.cpp: (ObjectMap): Keep a JSObject->NPObject map for each RootObject. It somewhat cleaner to keep it outside RootObject, because (1) it is agnostic of what kinds of objects can wrap JSObject, and (2) out of process NPAPI implementation also keeps its corresponding map separately, due to supporting per-instance granularity (as opposed to per-RootObject here). (jsDeallocate): Remove the corresponding map entry. (_NPN_CreateScriptObject): Try to fetch existing object from the map, incrementing refcount.
10:35 AM Changeset in webkit [54782] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-02-15 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Gustavo Noronha Silva.

Removed redefine of LOG_VERBOSE. This should not have commited in
the first place.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
10:04 AM Changeset in webkit [54781] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-02-15 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Laszlo Gombos.

Added additional parameter to create_rvct_stubs
for setting the offset of thunkReturnAddress.
​https://bugs.webkit.org/show_bug.cgi?id=34657

  • create_rvct_stubs:
  • jit/JITStubs.cpp:
9:48 AM Changeset in webkit [54780] by pfeldman@chromium.org
  • 4 edits
    2 adds in trunk

2010-02-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: incorrect syntax highlighting as HTML in a script tag.
We were preserving initial lexer state upon entering other tags while in <script>
but were not doing it for <script tag itself. As a result, nested script
tags were failing to highlight.

​https://bugs.webkit.org/show_bug.cgi?id=34934

  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
9:46 AM Changeset in webkit [54779] by eric@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-02-15 Emilio Pozuelo Monfort <​pochu27@gmail.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Fails to build on GNU/Hurd because of PATH_MAX usage
​https://bugs.webkit.org/show_bug.cgi?id=34920

Use dynamic allocation instead of fixed PATH_MAX size buffers to
fix the build on GNU/Hurd, where PATH_MAX is undefined.

  • tests/testmimehandling.c: (main):
  • tests/testwebview.c: (main):
9:31 AM Changeset in webkit [54778] by beidson@apple.com
  • 4 edits in trunk/WebCore

Add a progress-indicator logging channel to WebCore, and convert the old WebKit Logging
messages over to WebCore-style.

Reviewed by Dan Bernstein.

No new tests. (Logging changes only)

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::progressCompleted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):

  • platform/Logging.cpp:

(WebCore::):
(WebCore::getChannelFromName):

  • platform/Logging.h:
9:10 AM Changeset in webkit [54777] by mnaganov@chromium.org
  • 7 edits
    4 moves in trunk/WebCore

Revert 54776

Move JSC-specific wrappers for Profile and ProfileNode to bindings/js.
​https://bugs.webkit.org/show_bug.cgi?id=34848

8:59 AM Changeset in webkit [54776] by mnaganov@chromium.org
  • 7 edits
    4 moves in trunk/WebCore

2010-02-15 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Move JSC-specific wrappers for Profile and ProfileNode to bindings/js.

​https://bugs.webkit.org/show_bug.cgi?id=34848

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JavaScriptProfile.cpp: Added. (WebCore::profileCache): (WebCore::getTitleCallback): (WebCore::getHeadCallback): (WebCore::getUniqueIdCallback): (WebCore::focus): (WebCore::exclude): (WebCore::restoreAll): (WebCore::finalize): (WebCore::ProfileClass): (WebCore::toJS):
  • bindings/js/JavaScriptProfile.h: Added.
  • bindings/js/JavaScriptProfileNode.cpp: Added. (WebCore::profileNodeCache): (WebCore::getFunctionName): (WebCore::getURL): (WebCore::getLineNumber): (WebCore::getTotalTime): (WebCore::getSelfTime): (WebCore::getNumberOfCalls): (WebCore::getChildren): (WebCore::getVisible): (WebCore::getCallUID): (WebCore::finalize): (WebCore::ProfileNodeClass): (WebCore::toJS):
  • bindings/js/JavaScriptProfileNode.h: Added.
  • inspector/JavaScriptProfile.cpp: Removed.
  • inspector/JavaScriptProfile.h: Removed.
  • inspector/JavaScriptProfileNode.cpp: Removed.
  • inspector/JavaScriptProfileNode.h: Removed.
7:36 AM Changeset in webkit [54775] by eric@webkit.org
  • 5 edits in trunk

2010-02-15 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

[Qt] QtWebkit bridge: enable passing a QWebElement to a signal/slot/property
​https://bugs.webkit.org/show_bug.cgi?id=34901

When a signal/slot/property is of type QWebElement, it can seamlessly
connect with JS objects that hold a WebCore element.

New tests, see WebKit/qt/ChangeLog

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtWebElementRuntime::create): A proxy to QWebElement constructor (JSC::Bindings::QtWebElementRuntime::get): A proxy to QWebElement::element (JSC::Bindings::convertValueToQVariant): handle QWebElement (JSC::Bindings::convertQVariantToValue): handle QWebElement

2010-02-15 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

[Qt] QtWebkit bridge: enable passing a QWebElement to a signal/slot/property
Add Q_DECLARE_METATYPE to QWebElement, add relevant tests to
tst_qwebframe
​https://bugs.webkit.org/show_bug.cgi?id=34901

  • Api/qwebelement.h: declare metatype
  • tests/qwebframe/tst_qwebframe.cpp: (MyQObject::webElementProperty): new test for QWebElement (MyQObject::setWebElementProperty): new test for QWebElement (MyQObject::myOverloadedSlot): new test for QWebElement
5:56 AM Changeset in webkit [54774] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-02-15 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed, Chromium tests fix (force conversion of property names to
strings in Web Inspector's injected script).

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
4:52 AM QtWebKitTableOfFeatures46 edited by Henry Haverinen
(diff)
4:46 AM HackingGtk edited by joel@jms.id.au
(diff)
4:08 AM Changeset in webkit [54773] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-02-15 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Fix QScriptValue::toIntXX methods.

More ECMA Script compliance.

[Qt] QScriptValue::toIntXX returns incorrect values
​https://bugs.webkit.org/show_bug.cgi?id=34847

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toInteger): (QScriptValuePrivate::toInt32): (QScriptValuePrivate::toUInt32): (QScriptValuePrivate::toUInt16):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::toInteger_initData): (tst_QScriptValue::toInteger_makeData): (tst_QScriptValue::toInteger_test): (tst_QScriptValue::toInt32_initData): (tst_QScriptValue::toInt32_makeData): (tst_QScriptValue::toInt32_test): (tst_QScriptValue::toUInt32_initData): (tst_QScriptValue::toUInt32_makeData): (tst_QScriptValue::toUInt32_test): (tst_QScriptValue::toUInt16_initData): (tst_QScriptValue::toUInt16_makeData): (tst_QScriptValue::toUInt16_test):
3:11 AM QtWebKitTableOfFeatures46 edited by Henry Haverinen
(diff)
2:56 AM Changeset in webkit [54772] by eric@webkit.org
  • 10 edits in trunk

2010-02-15 Robert Hogan <​robert@roberthogan.net>

Reviewed by Simon Hausmann.

[Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().

Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.

​https://bugs.webkit.org/show_bug.cgi?id=33096

This allows the following tests to pass:

inspector/console-format-collections.html
inspector/styles-iframe.html
inspector/syntax-highlight-css.html
inspector/syntax-highlight-javascript.html
inspector/timeline-enum-stability.html
inspector/timeline-layout.html
inspector/timeline-mark-timeline.html
inspector/timeline-paint.html
inspector/timeline-parse-html.html
inspector/timeline-recalculate-styles.html
inspector/timeline-script-tag-1.html
inspector/timeline-script-tag-2.html
inspector/timeline-trivial.html
inspector/cookie-resource-match.html
inspector/elements-img-tooltip.html
inspector/elements-panel-selection-on-refresh.html
inspector/inspected-objects-not-overriden.html
inspector/timeline-event-dispatch.html
inspector/timeline-network-resource.html
inspector/elements-panel-rewrite-href.html
inspector/console-dir.html
inspector/console-dirxml.html
inspector/console-format.html
inspector/console-tests.html
inspector/elements-panel-structure.html
inspector/evaluate-in-frontend.html
inspector/console-clear.html

  • platform/qt/Skipped:

2010-02-15 Robert Hogan <​robert@roberthogan.net>, Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Simon Hausmann.

[Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().

Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.

​https://bugs.webkit.org/show_bug.cgi?id=33096

This allows the following tests to pass:

inspector/console-format-collections.html
inspector/styles-iframe.html
inspector/syntax-highlight-css.html
inspector/syntax-highlight-javascript.html
inspector/timeline-enum-stability.html
inspector/timeline-layout.html
inspector/timeline-mark-timeline.html
inspector/timeline-paint.html
inspector/timeline-parse-html.html
inspector/timeline-recalculate-styles.html
inspector/timeline-script-tag-1.html
inspector/timeline-script-tag-2.html
inspector/timeline-trivial.html
inspector/cookie-resource-match.html
inspector/elements-img-tooltip.html
inspector/elements-panel-selection-on-refresh.html
inspector/inspected-objects-not-overriden.html
inspector/timeline-event-dispatch.html
inspector/timeline-network-resource.html
inspector/elements-panel-rewrite-href.html
inspector/console-dir.html
inspector/console-dirxml.html
inspector/console-format.html
inspector/console-tests.html
inspector/elements-panel-structure.html
inspector/evaluate-in-frontend.html
inspector/console-clear.html

  • Api/qwebpage.cpp: (qt_drt_webinspector_executeScript): (qt_drt_webinspector_close): (qt_drt_webinspector_show): (qt_drt_setTimelineProfilingEnabled):
  • WebCoreSupport/InspectorClientQt.cpp: (InspectorClientQt::createPage)

2010-02-15 Robert Hogan <​robert@roberthogan.net>

Reviewed by Simon Hausmann.

[Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().

Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.

​https://bugs.webkit.org/show_bug.cgi?id=33096

This allows the following tests to pass:

inspector/console-format-collections.html
inspector/styles-iframe.html
inspector/syntax-highlight-css.html
inspector/syntax-highlight-javascript.html
inspector/timeline-enum-stability.html
inspector/timeline-layout.html
inspector/timeline-mark-timeline.html
inspector/timeline-paint.html
inspector/timeline-parse-html.html
inspector/timeline-recalculate-styles.html
inspector/timeline-script-tag-1.html
inspector/timeline-script-tag-2.html
inspector/timeline-trivial.html
inspector/cookie-resource-match.html
inspector/elements-img-tooltip.html
inspector/elements-panel-selection-on-refresh.html
inspector/inspected-objects-not-overriden.html
inspector/timeline-event-dispatch.html
inspector/timeline-network-resource.html
inspector/elements-panel-rewrite-href.html
inspector/console-dir.html
inspector/console-dirxml.html
inspector/console-format.html
inspector/console-tests.html
inspector/elements-panel-structure.html
inspector/evaluate-in-frontend.html
inspector/console-clear.html

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::isWebInspectorTest): (WebCore::DumpRenderTree::open):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::display):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::closeWebInspector): (LayoutTestController::showWebInspector): (LayoutTestController::evaluateInWebInspector): (LayoutTestController::setTimelineProfilingEnabled): (LayoutTestController::display):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
2:51 AM Changeset in webkit [54771] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-02-15 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: touch InspectorController in order to kick win bot tests
with new injected script contents.

  • inspector/InspectorController.cpp:
2:44 AM QtWebKitTableOfFeatures46 edited by Henry Haverinen
(diff)
2:34 AM Changeset in webkit [54770] by pfeldman@chromium.org
  • 8 edits in trunk/WebCore

2010-02-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: highlight actual search match in elements panel.

​https://bugs.webkit.org/show_bug.cgi?id=34251

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult): (WebInspector.ElementsPanel.prototype.jumpToNextSearchResult): (WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult): (WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult): (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
  • inspector/front-end/InjectedScript.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.findSearchMatches):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._paintLine):
  • inspector/front-end/textViewer.css:
  • inspector/front-end/utilities.js:
2:22 AM QtWebKitTableOfFeatures46 edited by Henry Haverinen
(diff)
2:20 AM Changeset in webkit [54769] by pfeldman@chromium.org
  • 8 edits in trunk

2010-02-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: XPathResult objects are not expanded in console.

​https://bugs.webkit.org/show_bug.cgi?id=34926

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertiesSection.CompareProperties): (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/Section.js: (WebInspector.Section):
  • inspector/front-end/inspector.css:

Tests:

  • inspector/console-dir-expected.txt:
  • inspector/console-dir.html:
2:20 AM QtWebKitTableOfFeatures46 edited by Henry Haverinen
(diff)
2:14 AM QtWebKitTableOfFeatures46 edited by Henry Haverinen
(diff)
2:07 AM QtWebKitTableOfFeatures46 edited by Henry Haverinen
(diff)
1:51 AM Changeset in webkit [54768] by Philippe Normand
  • 4 edits in trunk/LayoutTests

2010-02-15 Philippe Normand <​pnormand@igalia.com>

media/video-display-aspect-ratio.html fails
​https://bugs.webkit.org/show_bug.cgi?id=34933

Skipped the new test that fails.

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/win/Skipped:
1:28 AM Changeset in webkit [54767] by Antti Koivisto
  • 4 edits in trunk/WebKit/qt

2010-02-12 Antti Koivisto <​koivisto@iki.fi>

Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.


​https://bugs.webkit.org/show_bug.cgi?id=34885
Add a QGraphicsWebView mode that makes it automatically resize itself to the size of the content.

This is useful for cases where the client wants to implement page panning and zooming by manipulating
the graphics item.


Add a option to QGVLauncher to test this mode.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::updateResizesToContentsForPage): (QGraphicsWebViewPrivate::_q_contentsSizeChanged): (QGraphicsWebView::setPage): (QGraphicsWebView::setResizesToContents): (QGraphicsWebView::resizesToContents):
  • Api/qgraphicswebview.h:
  • QGVLauncher/main.cpp: (WebView::WebView): (MainView::MainView): (MainView::setMainWidget): (MainView::resizeEvent): (main):
12:48 AM Changeset in webkit [54766] by Philippe Normand
  • 3 edits
    3 adds in trunk

2010-02-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] wrong video aspect ratio
​https://bugs.webkit.org/show_bug.cgi?id=34790

Fixed natural size calculation regarding pixel aspect ratio and
display aspect ratio.

Test: media/video-display-aspect-ratio.html

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::greatestCommonDivisor): (WebCore::MediaPlayerPrivate::naturalSize):

2010-02-12 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] wrong video aspect ratio
​https://bugs.webkit.org/show_bug.cgi?id=34790

Test checking the size of a 4:3 video with a 16:9 pixel aspect
ratio.

  • media/content/test-par-16-9.mp4: Added.
  • media/video-display-aspect-ratio-expected.txt: Added.
  • media/video-display-aspect-ratio.html: Added.
Note: See TracTimeline for information about the timeline view.