⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 5, 2010:

11:28 PM Changeset in webkit [55613] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-05 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=33247
Backwards cursor movement incorrect when previous block ends with <br>.

If the cursor is trying to move into a node that has a height of 0,
skip over it.

  • editing/execCommand/move-selection-back-line-expected.txt: Added.
  • editing/execCommand/move-selection-back-line.html: Added.

2010-03-05 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=33247
Backwards cursor movement incorrect when previous block ends with <br>.

If the cursor is trying to move into a node that has a height of 0,
skip over it.

Test: editing/execCommand/move-selection-back-line.html

  • editing/visible_units.cpp: (WebCore::previousLinePosition):
11:11 PM Changeset in webkit [55612] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-05 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Eric Seidel.

Enable resource loading callback while loading worker scripts
​https://bugs.webkit.org/show_bug.cgi?id=35744

  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously):
10:45 PM Changeset in webkit [55611] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-03-05 Chris Fleizach <Chris Fleizach>

Reviewed by Eric Seidel.

WAI-ARIA live region doesn't appear when <div> only has a <div> child
​https://bugs.webkit.org/show_bug.cgi?id=35751

  • platform/mac/accessibility/div-containing-div-with-aria-expected.txt: Added.
  • platform/mac/accessibility/div-containing-div-with-aria.html: Added.

2010-03-05 Chris Fleizach <Chris Fleizach>

Reviewed by Eric Seidel.

WAI-ARIA live region doesn't appear when <div> only has a <div> child
​https://bugs.webkit.org/show_bug.cgi?id=35751

Elements should not be ignored if they carry ARIA attributes in them.

Test: platform/mac/accessibility/div-containing-div-with-aria.html

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::supportsARIAAttributes):
  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::supportsARIADropping): (WebCore::AccessibilityObject::supportsARIADragging):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::supportsARIADropping): (WebCore::AccessibilityRenderObject::supportsARIADragging): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  • accessibility/AccessibilityRenderObject.h:
7:48 PM Changeset in webkit [55610] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-05 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Eric Seidel.

Fix Print option on QtLauncher by calling print directly from QWebFrame.

[Qt] QtLauncher Print option is not working on QGraphicsView mode
​https://bugs.webkit.org/show_bug.cgi?id=35769

  • QtLauncher/main.cpp: (LauncherWindow::print):
7:16 PM Changeset in webkit [55609] by dimich@chromium.org
  • 1 edit
    1 add in trunk/WebCore

Add a manual test for crash in DOMWindow::clearTimeout when DOMWindow is not connected to Frame
​https://bugs.webkit.org/show_bug.cgi?id=32353

Reviewed by Oliver Hunt.

  • manual-tests/clearTimeout-crash-bug29832.html: Added.
7:04 PM Changeset in webkit [55608] by dimich@chromium.org
  • 3 edits
    3 adds in trunk

[v8] Remove wrong assert in GC callback.
​https://bugs.webkit.org/show_bug.cgi?id=35757

Reviewed by David Levin.

WebCore:

Test: fast/workers/wrapper-map-gc.html

  • bindings/v8/DOMData.h:

(WebCore::DOMData::handleWeakObject): remove ASSERT(isMainThread()), move another assert up to verify we are on the right thread.

LayoutTests:

  • fast/workers/resources/wrapper-map-gc.js: Added.
  • fast/workers/wrapper-map-gc.html: Added.
  • fast/workers/wrapper-map-gc-expected.txt: Added.
6:52 PM Changeset in webkit [55607] by eric@webkit.org
  • 14 edits
    4 copies
    10 adds in trunk

2010-03-05 Alex Milowski <​alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added tests for row and operator stretching.
Updated over, underover, and subsup due to row/operators in use.

  • mathml/presentation/mo.xhtml: Added.
  • mathml/presentation/row.xhtml: Added.
  • platform/mac/mathml/presentation/mo-expected.checksum: Added.
  • platform/mac/mathml/presentation/mo-expected.png: Added.
  • platform/mac/mathml/presentation/mo-expected.txt: Added.
  • platform/mac/mathml/presentation/over-expected.checksum:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/row-expected.checksum: Added.
  • platform/mac/mathml/presentation/row-expected.png: Added.
  • platform/mac/mathml/presentation/row-expected.txt: Added.
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.checksum:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:

2010-03-05 Alex Milowski <​alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added support for row layout with stretchy operators and
adjusted the over spacing for over and underover accordingly.

Tests: mathml/presentation/mo.xhtml

mathml/presentation/row.xhtml

  • WebCore.xcodeproj/project.pbxproj:
  • mathml/MathMLInlineContainerElement.cpp:
  • mathml/MathMLTextElement.cpp:
  • mathml/RenderMathMLMath.cpp: Added.
  • mathml/RenderMathMLMath.h: Added.
  • mathml/RenderMathMLOperator.cpp: Added.
  • mathml/RenderMathMLOperator.h: Added.
  • mathml/RenderMathMLRow.cpp: Added.
  • mathml/RenderMathMLRow.h: Added.
  • mathml/RenderMathMLUnderOver.cpp:
  • mathml/mathtags.in:
6:34 PM Changeset in webkit [55606] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-05 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

Take out code hack that flips the result of NPP_HandleEvent. This needs to move to
the NPAPI code so that Pepper plugins don't hit it.
​https://bugs.webkit.org/show_bug.cgi?id=35779

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
6:27 PM Changeset in webkit [55605] by dino@apple.com
  • 3 edits
    2 adds in trunk

2010-03-05 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=35772
Animation fill modes should be supported in the shorthand property

Add CSSPropertyWebkitAnimationFillMode to the list of properties
evaluated in the -webkit-animation shorthand.

Test: animations/animation-shorthand.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationShorthand):
5:09 PM Changeset in webkit [55604] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-05 Eric Seidel <​eric@webkit.org>

No review. Skipping recently regressed test to unblock the commit-queue (20 patches waiting).

REGRESSION(55593?): fast/workers/worker-cloneport.html is timing out on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=35819

  • platform/mac-leopard/Skipped:
4:52 PM Changeset in webkit [55603] by Chris Jerdonek
  • 19 edits in trunk/WebKitTools

Changed the logging code for new-run-webkit-tests to use
module-specific loggers rather than the root logger. This is
a standard practice that allows logging specific to a package
to be configured independently of other modules.

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=35194

Added a line of the form "_log = logging.getLogger(<module>)"
to each module below, where <module> is the fully-qualified
name of the module, and updated the log lines to use the new
_log logger.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4:38 PM Changeset in webkit [55602] by dpranke@chromium.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-03-05 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Siedel.

Split the command-line invocation of the Chromium/python LigHTTPd
server implementation out into its own top level script to make it
a more "public" interface and to resolve some awkward layering
issues. This script will be called directly by other test scripts in
the Chromium tree.

At some point this script should be made to work with Apache-based
implementations and on other ports. I have filed
​https://bugs.webkit.org/show_bug.cgi?id=35820 for this.

Also fix a bug in port/factory where options.chromium could be
dereferenced even if it wasn't set, raising an exception.

​https://bugs.webkit.org/show_bug.cgi?id=35812

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/new-run-webkit-httpd: Added
4:21 PM Changeset in webkit [55601] by dino@apple.com
  • 11 edits in trunk

2010-03-05 Dean Jackson <​dino@apple.com>

Reviewed by NOBODY (OOPS!).

​https://bugs.webkit.org/show_bug.cgi?id=35815
Animation Fill Modes fail on Windows

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSStyleSelector.cpp:
  • platform/graphics/mac/GraphicsLayerCA.mm:
    • use new enum value
  • platform/animation/Animation.h:
    • change bitfield type
  • rendering/style/RenderStyleConstants.h:
    • add new enum for fill mode
3:44 PM Changeset in webkit [55600] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-03-05 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (build fix).

Add enw exports to windows

3:29 PM Changeset in webkit [55599] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-03-05 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

JSC should cache int to Identifier conversion as it does for ordinary strings
​https://bugs.webkit.org/show_bug.cgi?id=35814

Make the NumericStrings cache cache unsigned ints in addition to signed.
We keep them separate from the int cache as it both simplifies code, and
also because the unsigned path is exclusive to property access and therefore
seems to have different usage patterns.

The primary trigger for the unsigned to Identifier propertyName conversion
is the construction of array-like objects out of normal objects. Given these
tend to be relative small numbers, and the array-like behaviour lends itself
to sequential values this patch also adds a non-colliding cache for all small
numbers.

  • JavaScriptCore.exp:
  • runtime/Identifier.cpp: (JSC::Identifier::from):
  • runtime/Identifier.h:
  • runtime/NumericStrings.h: (JSC::NumericStrings::add): (JSC::NumericStrings::lookup): (JSC::NumericStrings::lookupSmallString):
3:26 PM Changeset in webkit [55598] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

Unreviewed buildfix after r55593. (To fix Qt --minimal build.)

  • bindings/js/JSDOMWindowCustom.cpp: Missing #if ENABLE(DATABASE) guard added.
2:55 PM Changeset in webkit [55597] by Simon Fraser
  • 3 edits
    5 adds in trunk

2010-03-05 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

ASSERTION FAILED: rootLayer == m_clipRectsRoot at hulu.com
​https://bugs.webkit.org/show_bug.cgi?id=34065
<rdar://problem/7573509>

Fix one instance of this assertion (not necessarily the one seen on hulu.com).

If the layer that clippingRoot() is being called on is itself compositing,
then it acts as the clipping root. Without this, calls to RenderLayer::childrenClipRect()
and RenderLayer::selfClipRect() via FrameView::windowClipRectForLayer(), for plug-ins,
caused the caching of an incorrect clip rects root.

Test: compositing/geometry/object-clip-rects-assertion.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::clippingRoot):
2:53 PM Changeset in webkit [55596] by dino@apple.com
  • 2 edits in trunk/LayoutTests

2010-03-05 Dean Jackson <​dino@apple.com>

No review.

Disabling animations/fill-mode-transform.html on Leopard
due to ​https://bugs.webkit.org/show_bug.cgi?id=35714

  • platform/mac-leopard/Skipped:
2:46 PM Changeset in webkit [55595] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-03-05 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Child clipping compositing layers don't show the blue debug color
​https://bugs.webkit.org/show_bug.cgi?id=35807

Set a layer owner on the GraphicsLayers created for clipping children,
so that they can get to the debug settings that give them the blue color.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateClippingLayers):
2:43 PM Changeset in webkit [55594] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-03-05 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

MobileMe movie page is missing playback controls
​https://bugs.webkit.org/show_bug.cgi?id=35805
<rdar://problem/7653169>

On pages with video or plug-ins, we run overlap tests to determine which layers
need to be composited. There was an ordering dependency bug in
RenderLayerCompositor::computeCompositingRequirements() that caused us to fail
to detect that a layer needed to be composited, resulting in page content
not being visible.

Specifically, layer->setHasCompositingDescendant() can change the answer
to needsToBeComposited(), when a layer has to clip compositing descendants.
So if we change setHasCompositingDescendant(), then we need to re-test
clipsCompositingDescendants() and add the layer to the overlap map if so.

Test: compositing/overflow/overflow-compositing-descendant.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2:17 PM Changeset in webkit [55593] by dumi@chromium.org
  • 23 edits
    9 adds in trunk

WebCore: Adding support for the optional creation callback that could be
passed to openDatabase().

Reviewed by Adam Barth.

Test: storage/open-database-creation-callback.html

​https://bugs.webkit.org/show_bug.cgi?id=34726

  • Android.jscbindings.mk
  • Android.v8bindings.mk
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/js/JSDatabaseCallback.cpp: Added.

(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):

  • bindings/js/JSDatabaseCallback.h: Added.

(WebCore::JSDatabaseCallback::create):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • bindings/v8/custom/V8DatabaseCallback.cpp: Added.

(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):

  • bindings/v8/custom/V8DatabaseCallback.h: Added.

(WebCore::V8DatabaseCallback::create):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/Database.cpp:

(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):

  • storage/Database.h:

(WebCore::Database::isNew):

  • storage/DatabaseCallback.h: Added.

(WebCore::DatabaseCallback::~DatabaseCallback):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):

  • workers/WorkerContext.h:

LayoutTests: Adding a test to test the creation callback passed to
openDatabase() and another one to make sure it is executed in the
correct world.

Reviewed by Adam Barth.

Also, fixing fast/frames/sandboxed-iframe-storage.html: calling
openDatabase() without at least 4 parameters should always fail,
because the database name, version, description and estimated size
are not optional according to the spec.

​https://bugs.webkit.org/show_bug.cgi?id=34726

  • fast/frames/resources/sandboxed-iframe-storage-allowed.html:
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-storage-expected.txt:
  • platform/qt/Skipped:
  • storage/open-database-creation-callback-expected.txt: Added.
  • storage/open-database-creation-callback.html: Added.
  • storage/open-database-creation-callback-isolated-world-expected.txt: Added.
  • storage/open-database-creation-callback-isolated-world.html: Added.
1:04 PM Changeset in webkit [55592] by cmarrin@apple.com
  • 13 edits in trunk

Fixed crash due to infinite recursion when viewing composited video on Windows
​https://bugs.webkit.org/show_bug.cgi?id=35798

10:33 AM Changeset in webkit [55591] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Update getComputedStyle results on Windows.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
10:26 AM Changeset in webkit [55590] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-03-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

[Chromium] Missing commas in WebCore.gypi file make building Geo unpossible.
​https://bugs.webkit.org/show_bug.cgi?id=35797

No new tests, this is a latent compile break.

  • WebCore.gypi:
10:12 AM Changeset in webkit [55589] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

2010-03-05 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, build fix.

Use a movie that will hopefully fail to open less often on a headless
SnowLeopard bot.

  • media/video-preload-expected.txt:
  • media/video-preload.html: Use test.mp4 instead of silence.mpg.
9:39 AM QtWebKitBugs edited by vestbo@webkit.org
(diff)
9:32 AM Changeset in webkit [55588] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-03-05 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, build fix.

media/video-preload.html fails on GTK, skip it.

  • platform/gtk/Skipped:
9:13 AM Changeset in webkit [55587] by eric.carlson@apple.com
  • 7 edits
    2 adds in trunk

2010-03-04 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/7718442> Implement 'preload=none'
​https://bugs.webkit.org/show_bug.cgi?id=35789

Don't load any media data when preload is 'none'.

Test: media/video-preload.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): Don't call player's setPreload method

when autoplay is set.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setPreload): Set m_preload so we have the correct value when

the media engine is created.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_preload. (WebCore::MediaPlayerPrivate::resumeLoad): New, kick off postponed a load. (WebCore::MediaPlayerPrivate::load): Do nothing if preload is 'none' (WebCore::MediaPlayerPrivate::loadInternal): New, complete loading. (WebCore::MediaPlayerPrivate::prepareToPlay): New, resume a postponed load as someone

has called play().

(WebCore::MediaPlayerPrivate::setPreload): New, set m_preload.

2010-03-04 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/7718442> Implement 'preload=none'
​https://bugs.webkit.org/show_bug.cgi?id=35789

Functional test of the 'proload' attribute.

  • media/video-preload-expected.txt: Added.
  • media/video-preload.html: Added.
  • platform/win/Skipped: Skip on Windows for now.
8:53 AM Changeset in webkit [55586] by Nate Chapin
  • 3 edits in trunk/WebCore

2010-03-04 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Give CodeGeneratorV8.pm a much-needed spring cleaning.

​https://bugs.webkit.org/show_bug.cgi?id=35697

  • bindings/scripts/CodeGeneratorV8.pm: Remove unused code, fix style issues, make less hard-coded.
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::addEventListenerCallback): (WebCore::V8DOMWindow::removeEventListenerCallback):
8:16 AM Changeset in webkit [55585] by tonikitoo@webkit.org
  • 5 edits in trunk

[Gtk] Implement setSpatialNavigationEnabled in DRT.
​https://bugs.webkit.org/show_bug.cgi?id=35705

Reviewed by Holger Freyther
Patch by Antonio Gomes <​tonikitoo@webkit.org>

WebKitTools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

LayoutTests:

  • platform/gtk/Skipped:
8:13 AM Changeset in webkit [55584] by pfeldman@chromium.org
  • 26 edits
    3 deletes in trunk

2010-03-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Roll back r55522 since it regreses performance
according to chromium's page cycler.

​https://bugs.webkit.org/show_bug.cgi?id=35568

8:07 AM Changeset in webkit [55583] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/gtk

[Gtk] Add 'enable-spatial-navigation' setting for Spatial Navigation on/off.
​https://bugs.webkit.org/show_bug.cgi?id=35701

Reviewed by Gustavo Noronha.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
(webkit_web_settings_copy):

  • webkit/webkitwebview.cpp:

(DNDContentsRequest::webkit_web_view_update_settings):
(DNDContentsRequest::webkit_web_view_settings_notify):

8:04 AM Changeset in webkit [55582] by tonikitoo@webkit.org
  • 6 edits in trunk/WebKitTools

Add toggle on/off stub methods for Spatial Navigation in win, gtk and mac LayoutTestController class implementations.
​https://bugs.webkit.org/show_bug.cgi?id=35699

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • DumpRenderTree/LayoutTestController.cpp:

(setSpatialNavigationEnabledCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setSpatialNavigationEnabled):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

8:01 AM Changeset in webkit [55581] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] Add toggle on/off mechanism for Spatial Navigation in QtLauncher.

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • QtLauncher/main.cpp:

(LauncherWindow::toggleSpatialNavigation):
(LauncherWindow::setupUI):

7:58 AM Changeset in webkit [55580] by tonikitoo@webkit.org
  • 5 edits in trunk

[Qt] Add setSpatialNavigationEnabled method DRT
​https://bugs.webkit.org/show_bug.cgi?id=33715

Reviewed by Simon Hausmann.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Added setSpatialNavigationEnabled support to Qt DRT.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::WebPage):
(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

Unskipped fast/events/spatial-navigation/

7:49 AM Changeset in webkit [55579] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] QWebSettings attribute for toggle Spatial Navigation on/off
​https://bugs.webkit.org/show_bug.cgi?id=33714 (Qt API part)

Reviewed by Simon Hausmann.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Added 'SpatialNavigationEnabled' attribute to QWebSettings.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

  • Api/qwebsettings.h:
7:48 AM Changeset in webkit [55578] by tonikitoo@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Extend keyboard navigation to allow directional navigation (LayoutTests - part II)
​https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

This patch adds two LayoutTest to ensure the basic table traversal correctness of
Spatial Navigation (SNav) algorithm: focusable elements in a <table> should be accessible.

  • fast/events/spatial-navigation/snav-table-traversal.html: Added. Makes sure all elements in a <table> are accessible via Spatial Navigation.
  • fast/events/spatial-navigation/snav-tiny-table-traversal.html: Added. Tests the similar table traversal scenario as above, but in this case the elements in the <table> are styled with 'font-size: small'. That way this test also validades that overlapping rects of elements too closed from each other are correctly handled.
7:46 AM Changeset in webkit [55577] by tonikitoo@webkit.org
  • 5 edits
    3 adds in trunk/LayoutTests

Extend keyboard navigation to allow directional navigation (LayoutTests - part I)
​https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

This patch adds support for auto testing the Spatial Navigation feature by:

1) Creating the directory where the tests are going to live in, named

fast/events/spatial-navigation/.

2) Skipping this directory by Mac, Qt, Gtk and Win.
3) Adding a JS file drives the test execution by processing, for each test,

a given set of arrow key actions and verify if the right expected Element
got the focus after each event processed. This file is
fast/events/spatial-navigation/resources/spatial-navigation-utils.js

  • LayoutTests/fast/events/spatial-navigation/snav-vertical-superprecedence.html: Added.
7:42 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:31 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:31 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:30 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:28 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:27 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:23 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:23 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:22 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:17 AM QtWebKit edited by Simon Hausmann
(diff)
7:11 AM QtWebKitBugs edited by vestbo@webkit.org
(diff)
6:06 AM QtWebKit edited by Simon Hausmann
(diff)
6:06 AM QtWebKit edited by Simon Hausmann
(diff)
4:58 AM Changeset in webkit [55576] by dino@apple.com
  • 25 edits
    6 adds in trunk

2010-03-05 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser and Chris Marrin.

Bug 26869: Add fill modes for CSS Animations
​https://bugs.webkit.org/show_bug.cgi?id=26869

Tests: animations/fill-mode-removed.html

animations/fill-mode-transform.html
animations/fill-mode.html

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSParser.cpp:
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/CSSValueKeywords.in:
    • parse, assign and retrieve the value of the new -webkit-animation-fill-mode property
  • page/animation/AnimationBase.cpp:
  • page/animation/AnimationBase.h:
    • new state in animation engine for a finished animation that is "filling" forwards in time. This allows the engine to keep the animation around and not revert to the old style.
    • update the timer code to indicate it doesn't need to keep animating if it is filling
    • now that animations can extend beyond their elapsed time, make sure progress works correctly with iteration counts
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate):
    • ensure correct style value is returned at the right time by checking for fill mode

(WebCore::KeyframeAnimation::onAnimationEnd):

  • continue to send the end event, but only remove the animation if it isn't filling forwards
  • platform/animation/Animation.cpp:
  • platform/animation/Animation.h:
    • new fill mode member property
  • platform/animation/AnimationList.cpp:
    • ensure the fill mode is propagated to a list of style valus
  • platform/graphics/mac/GraphicsLayerCA.mm:
    • make hardware layers use Core Animation's fill mode
2:09 AM Changeset in webkit [55575] by pfeldman@chromium.org
  • 8 edits in trunk

2010-03-05 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Do not show link helper in popovers and/or for external resources.

​https://bugs.webkit.org/show_bug.cgi?id=35785

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptOrResourceForURLAndLine):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.hide):
  • inspector/front-end/inspector.js: (WebInspector.documentMouseOver): (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.addMainEventListeners):
1:51 AM Changeset in webkit [55574] by ukai@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-03-05 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket test to transfer null character
​https://bugs.webkit.org/show_bug.cgi?id=35715

  • websocket/tests/null-character-expected.txt: Added.
  • websocket/tests/null-character.html: Added.
  • websocket/tests/script-tests/null-character.js: Added.
1:35 AM Changeset in webkit [55573] by ukai@chromium.org
  • 7 edits
    4 adds in trunk

2010-03-05 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket onmessageerror event handler
​https://bugs.webkit.org/show_bug.cgi?id=35570

  • websocket/tests/error-detect-expected.txt: Added.
  • websocket/tests/error-detect.html: Added.
  • websocket/tests/script-tests/error-detect.js: Added.
  • websocket/tests/unknown-frame-type_wsh.py: Added.

2010-03-05 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket onmessageerror event handler
​https://bugs.webkit.org/show_bug.cgi?id=35570

Test: websocket/tests/error-detect.html

  • websockets/WebSocket.cpp: (WebCore::WebSocketChannel::didConnect): assert scriptExecutionContext. (WebCore::WebSocketChannel::didReceiveMessage): assert scriptExecutionContext. (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didClose): assert scriptExecutionContext.
  • websockets/WebSocket.h:
  • websockets/WebSocket.idl: Add onerror event listener
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData): call didReceiveMessageError if unknown frame tye is detected, or frame length overflowed.
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didReceiveMessageError):

Mar 4, 2010:

10:09 PM Changeset in webkit [55572] by eric@webkit.org
  • 6 edits in trunk

2010-03-04 Garret Kelly <​gdk@chromium.org>

Reviewed by Darin Fisher.

Changing private members from PlatformTouchEvent and PlatformTouchPoint
to be protected, so that Chromium's PlatformTouchEventBuilder and
PlatformTouchPointBuilder can access them. Exercised by the
fast/events/touch tests.
​https://bugs.webkit.org/show_bug.cgi?id=35760

  • platform/PlatformTouchEvent.h: (WebCore::PlatformTouchEvent::~PlatformTouchEvent):
  • platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::~PlatformTouchPoint):

2010-03-04 Garret Kelly <​gdk@chromium.org>

Reviewed by Darin Fisher.

Adding PlatformTouchEventBuilder and PlatformTouchPointBuilder for
converting Chromium WebTouchEvent and WebTouchPoint types to
corresponding WebCore types.
​https://bugs.webkit.org/show_bug.cgi?id=35760

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState): (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder): (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
  • src/WebInputEventConversion.h:
9:52 PM Changeset in webkit [55571] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-04 John Gregg <​johnnyg@google.com>

Reviewed by Darin Fisher.

[chromium] WebDocument:applicationID() crashes on <meta> tag with no http-equiv attribute
​https://bugs.webkit.org/show_bug.cgi?id=35771

  • src/WebDocument.cpp: (WebKit::WebDocument::applicationID): check for presence of http-equiv attribute before lower()ing it.
9:50 PM Changeset in webkit [55570] by ukai@chromium.org
  • 5 edits
    3 adds in trunk

WebSocket crash bug when reloading the page while the WebSocket is busy
​https://bugs.webkit.org/show_bug.cgi?id=35732

Reviewed by Alexey Proskuryakov.

WebCore:

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::disconnect): clear m_context from WebSocketChannel and WebSocketHandshake.
(WebCore::WebSocketChannel::didOpen): check m_context
(WebCore::WebSocketChannel::didClose): clear m_context
(WebCore::WebSocketChannel::didReceiveData): check m_context, and check m_client early before appending to buffer

  • websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clearScriptExecutionContext): Added.

  • websockets/WebSocketHandshake.h:

LayoutTests:

  • websocket/tests/reload-crash-expected.txt: Added.
  • websocket/tests/reload-crash.html: Added.
  • websocket/tests/resoures/reload-crash-iframe.html: Added.
9:35 PM Changeset in webkit [55569] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-03-04 MORITA Hajime <​morrita@google.com>

Reviewed by Alexey Proskuryakov.

Refactoring: XMLHTTPRequest.open() should have all overloaded implementations
​https://bugs.webkit.org/show_bug.cgi?id=35630

  • http/tests/xmlhttprequest/open-async-overload-expected.txt: Added.
  • http/tests/xmlhttprequest/open-async-overload.html: Added.

2010-03-04 MORITA Hajime <​morrita@google.com>

Reviewed by Alexey Proskuryakov.

Refactoring: XMLHTTPRequest.open() should have all overloaded implementations
​https://bugs.webkit.org/show_bug.cgi?id=35630

Test: http/tests/xmlhttprequest/open-async-overload.html

  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::openCallback):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open):
  • xml/XMLHttpRequest.h:
9:18 PM Changeset in webkit [55568] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-04 James Robinson <​jamesr@google.com>

Reviewed by Eric Seidel.

Styles do not have to be synchronously rematched after every event dispatch

​https://bugs.webkit.org/show_bug.cgi?id=32580

  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent):
9:01 PM Changeset in webkit [55567] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-04 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

maemo spelled as mameo in WebCore.pro
​https://bugs.webkit.org/show_bug.cgi?id=35765

Spelling corrected.

  • WebCore.pro:
8:34 PM Changeset in webkit [55566] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-03-04 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=18819
Pressing option+page{down,up} should move the cursor and scroll in
content editable areas. On other platforms, pressing page{down,up}
should move the cursor and scroll in content editable areas.

  • editing/input/option-page-up-down-expected.txt: Added.
  • editing/input/option-page-up-down.html: Added.

2010-03-04 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=18819
Pressing option+page{down,up} should move the cursor and scroll in
content editable areas. On other platforms, pressing page{down,up}
should move the cursor and scroll in content editable areas.

Test: editing/input/option-page-up-down.html

  • editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
7:42 PM Changeset in webkit [55565] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Find the framework relative to TARGET_BUILD_DIR as that has a more obvious value during production builds.

Rubber-stamped by Alice Liu.

  • Scripts/check-for-webkit-framework-include-consistency:
5:33 PM Changeset in webkit [55564] by oliver@apple.com
  • 18 edits
    2 adds in trunk

2010-03-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Allow static property getters to interact with JSCs caching
​https://bugs.webkit.org/show_bug.cgi?id=35716

Add new opcodes for handling cached lookup of static value getters.
More or less the same as with JS getters, all that changes is that
instead of calling through a JSFunction we always know that we have
a C function to call.

For the patching routines in the JIT we now need to pass a few
new parameters to allow us to pass enough information to the stub
function to allow us to call the C function correctly. Logically
this shouldn't actually be necessary as all of these functions ignore
the identifier, but removing the ident parameter would require
somewhat involved changes to the way we implement getOwnPropertySlot,
etc.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):
  • bytecode/Instruction.h: (JSC::Instruction::Instruction): (JSC::Instruction::):
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h: (JSC::):
  • runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot):
  • runtime/Lookup.h: (JSC::getStaticPropertySlot): (JSC::getStaticValueSlot):
  • runtime/PropertySlot.h: (JSC::PropertySlot::): (JSC::PropertySlot::PropertySlot): (JSC::PropertySlot::cachedPropertyType): (JSC::PropertySlot::isCacheable): (JSC::PropertySlot::isCacheableValue): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setCacheableCustom): (JSC::PropertySlot::setGetterSlot): (JSC::PropertySlot::setCacheableGetterSlot): (JSC::PropertySlot::clearOffset): (JSC::PropertySlot::customGetter):

2010-03-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Allow static property getters to interact with JSCs caching
​https://bugs.webkit.org/show_bug.cgi?id=35716

Add tests to ensure nothing horrifying happens to static property
getters if they're in a path where we end up caching lookups.

  • fast/js/pic/cached-named-property-getter-expected.txt: Added.
  • fast/js/pic/cached-named-property-getter.html: Added.

2010-03-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Allow static property getters to interact with JSCs caching
​https://bugs.webkit.org/show_bug.cgi?id=35716

Update the obviously safe getters to allow caching

Test: fast/js/pic/cached-named-property-getter.html

  • bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertySlot):
  • bridge/runtime_method.cpp: (JSC::RuntimeMethod::getOwnPropertySlot):
4:50 PM Changeset in webkit [55563] by tkent@chromium.org
  • 1 edit
    5 adds in trunk/WebKitTools

2010-03-04 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add CppVariant and CppBoundClass
​https://bugs.webkit.org/show_bug.cgi?id=35634

Add CppVariant and CppBoundClass classes, which are going to be
used by DumpRenderTree Chromium port. These files are based on:

  • src/webkit/glue/cpp_variant.{cc,h} and
  • src/webkit/glue/cpp_bound_class.{cc,h} of Chromium rev.40492.
  • DumpRenderTree/chromium/CppBoundClass.cpp: Added.
  • DumpRenderTree/chromium/CppBoundClass.h: Added.
  • DumpRenderTree/chromium/CppVariant.cpp: Added.
  • DumpRenderTree/chromium/CppVariant.h: Added.
4:29 PM Changeset in webkit [55562] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Build fix for older versions of Ruby.

  • Scripts/check-for-webkit-framework-include-consistency:
4:23 PM Changeset in webkit [55561] by mrowe@apple.com
  • 3 edits
    1 add in trunk

Add a script to verify that WebKit framework headers are internally consistent.

Reviewed by Sam Weinig.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Run the script during the build and fail with

an error should the consistency check fail.

WebKitTools:

This script detects the following problematic situations:

  • An exported WebKit header that includes a header from WebCore.
  • An exported WebKit header that includes a header that does not exist in the WebKit framework.
  • A public WebKit header that includes a private WebKit header.
  • Scripts/check-for-webkit-framework-include-consistency: Added.
4:23 PM Changeset in webkit [55560] by mrowe@apple.com
  • 4 edits in trunk

<rdar://problem/7717249> DOMSVG.h includes a non-existent DOMSVGFEMorphologyElement.h

Reviewed by Sam Weinig.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Copy DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h

in to the framework wrapper.

WebKit/mac:

  • MigrateHeaders.make: Migrate DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h.
4:23 PM Changeset in webkit [55559] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Use a framework-style include to pull in WebInspector.h for consistency
with other parts of WebKit.

Reviewed by Sam Weinig.

  • WebInspector/WebInspectorPrivate.h:
3:34 PM Changeset in webkit [55558] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Making sure that the correct path is set before invoking
DumpRenderTree on cygwin.

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=35768

  • Scripts/run-webkit-tests:
3:29 PM Changeset in webkit [55557] by jamesr@google.com
  • 3 edits
    18 adds in trunk

2010-03-04 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Handles setting HTMLSelectElement.length with mutation handlers present
​https://bugs.webkit.org/show_bug.cgi?id=33983

When setting an HTMLSelectElement's length attribute, option elements have to be added or removed to the select
as appropriate. This is a little tricky with mutation events since they might add, remove, or reorder elements
while option elements are being added or deleted.

Tests: fast/forms/select-set-length-optgroup.html

fast/forms/select-set-length-with-mutation-remove.html
fast/forms/select-set-length-with-mutation-reorder.html
fast/forms/select-set-length-with-mutation-reparent.html
fast/forms/select-set-length-with-mutation.html
fast/forms/select-set-length.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setLength):

2010-03-04 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Tests for setting an select's options.length attribute.
​https://bugs.webkit.org/show_bug.cgi?id=33983

  • fast/forms/script-tests/select-set-length-optgroup.js: Added.
  • fast/forms/script-tests/select-set-length-with-mutation-remove.js: Added. (gc): (onRemove):
  • fast/forms/script-tests/select-set-length-with-mutation-reorder.js: Added. (onRemove):
  • fast/forms/script-tests/select-set-length-with-mutation-reparent.js: Added. (onRemove):
  • fast/forms/script-tests/select-set-length-with-mutation.js: Added. (sel):
  • fast/forms/script-tests/select-set-length.js: Added.
  • fast/forms/select-set-length-expected.txt: Added.
  • fast/forms/select-set-length-optgroup-expected.txt: Added.
  • fast/forms/select-set-length-optgroup.html: Added.
  • fast/forms/select-set-length-with-mutation-expected.txt: Added.
  • fast/forms/select-set-length-with-mutation-remove-expected.txt: Added.
  • fast/forms/select-set-length-with-mutation-remove.html: Added.
  • fast/forms/select-set-length-with-mutation-reorder-expected.txt: Added.
  • fast/forms/select-set-length-with-mutation-reorder.html: Added.
  • fast/forms/select-set-length-with-mutation-reparent-expected.txt: Added.
  • fast/forms/select-set-length-with-mutation-reparent.html: Added.
  • fast/forms/select-set-length-with-mutation.html: Added.
  • fast/forms/select-set-length.html: Added.
3:21 PM Changeset in webkit [55556] by Csaba Osztrogonác
  • 3 edits in trunk/WebCore

[Qt] Unreviewed buildfix after r55542 on Windows.

  • WebCore.pro:
    • plugins/win/PluginDatabaseWin.cpp removed.
    • platform/win/WebCoreInstanceHandle.cpp added.
  • platform/win/WebCoreInstanceHandle.cpp: Remove explicit qualification in namespace declaration to make gcc happy.
3:01 PM Changeset in webkit [55555] by Nate Chapin
  • 3 edits
    2 adds in trunk

2010-03-04 Nate Chapin <Nate Chapin>

Reviewed by Kenneth Rohde Christiansen.

Fix the case where we do a same document navigation, scroll,
then repeat the same document navigation. Currently, the second
navigation does nothing.

​https://bugs.webkit.org/show_bug.cgi?id=35547

Test: fast/loader/repeat-same-document-navigation.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): Call scrollToFragment() whether or not the hash changed.
2:44 PM QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
2:31 PM Changeset in webkit [55554] by Simon Fraser
  • 6 edits in trunk

2010-03-04 Simon Fraser <Simon Fraser>

Build fix.

const long long cMaxDistance = numeric_limits<long long>::max() created global
initializers at the call sites, so replace with an inline function.

  • page/FocusController.cpp: (WebCore::updateFocusCandidateIfCloser):
  • page/SpatialNavigation.cpp: (WebCore::distanceInDirection):
  • page/SpatialNavigation.h: (WebCore::maxDistance): (WebCore::FocusCandidate::FocusCandidate):
2:29 PM QtWebKitBugs edited by jocelyn.turcotte@nokia.com
Repeat reporting link. Fill out the crashes part (diff)
2:15 PM Changeset in webkit [55553] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-03-04 Simon Fraser <Simon Fraser>

Build fix: add exceptions to the check-for-global-initializers script
for FocusController and SpatialNavigation, and improve the script
to actually print out the globals found.

  • Scripts/check-for-global-initializers:
1:52 PM Changeset in webkit [55552] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed attempt to fix Windows build.

  • page/SpatialNavigation.cpp:

(WebCore::spatialDistance):

1:40 PM Changeset in webkit [55551] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-04 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Fix dangling reference to "port" instead of "self._port_obj" that
was preventing the http_server from starting on Windows.

  • Scripts/webkitpy/layout_tests/port/http_server.py:
1:35 PM Changeset in webkit [55550] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-03-04 Simon Fraser <Simon Fraser>

Build fix.

Delcare updateFocusCandidateIfCloser static to avoid warning.

  • page/FocusController.cpp: (WebCore::updateFocusCandidateIfCloser):
1:11 PM Changeset in webkit [55549] by darin@chromium.org
  • 7 edits in trunk

2010-03-04 Darin Fisher <​darin@chromium.org>

Reviewed by Dmitry Titov.

[chromium] make history.{push,replace}State enabled at runtime
​https://bugs.webkit.org/show_bug.cgi?id=35753

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setPushStateEnabled): (WebCore::RuntimeEnabledFeatures::pushStateEnabled): (WebCore::RuntimeEnabledFeatures::replaceStateEnabled):
  • page/History.idl:
1:09 PM Changeset in webkit [55548] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed attempt to (again) fix Mac build.

  • page/SpatialNavigation.cpp:

(WebCore::spatialDistance):

1:03 PM Changeset in webkit [55547] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typos

1:02 PM Changeset in webkit [55546] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Based on a pacth from Nick Jong.

Reviewed by Simon Fraser.

Improve selection in multi-column blocks when hitting points above or
below a column rect.

Test: fast/multicol/hit-test-above-or-below.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPointToColumnContents): If the point lies
within the horizontal range for a column, constrain it to the column (if
it is above) or the next column (if it is below).

LayoutTests: Added test for hit-testing points above or below the column rect.

Reviewed by Simon Fraser.

  • fast/multicol/hit-test-above-or-below-expected.txt: Added.
  • fast/multicol/hit-test-above-or-below.html: Added.
12:57 PM Changeset in webkit [55545] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Attempt to fix Mac build.

Reviewed by Simon Frase.

  • page/SpatialNavigation.cpp:
12:20 PM Changeset in webkit [55544] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Add SpatialNavigation header and cpp to Mac XCode project file

Reviewed by Kenneth Christiansen.
Patch by Jesus Palencia <​jesus.palencia@openbossa.org>

  • WebCore.xcodeproj/project.pbxproj:
12:19 PM Changeset in webkit [55543] by tonikitoo@webkit.org
  • 13 edits
    2 adds in trunk/WebCore

Extend keyboard navigation to allow directional navigation
​https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Simon Fraser, Eric Seidel and Darin Adler.
Patch by Antonio Gomes <​tonikitoo@webkit.org>
Based on the initial work of Marco Barisione <​marco.barisione@collabora.co.uk>

This patch implements the core logic of the 'Spatial Navigation' feature [1].
It improves the accessibility support of WebCore by extending the basic keyboard
navigation currently available (based on Tab forward and backward) with the
addition of a two-dimensional directional navigation by using Left, Right, Up and
Down arrow keys to move to the "nearest" element in the corresponding direction.

Highlights:

  • Feature is turned off by default in Settings. Port specific APIs need to be added for toggling it on/off.
  • Only elements viewed in the current viewport can have focus move to it. If the "nearest" is not in viewport dimensions, then a scroll-in-direction action is performed.
  • The layout tests added run on Qt's DRT only for now (skipped for Mac, Win and Gtk).

Known issues (to be covered in follow-up bugs):

  • Add port specific hooks to each DRT to enable/disable Spatial Navigation.
  • Support for spatial navigation through form elements (<input>, <select>, etc) is be added.
  • Make navigation keys customizable. It currently works with arrows keys only (up, down, right and left).
  • Make it support modifiers (Alt, Ctrl and Shift).

[1] ​http://en.wikipedia.org/wiki/Spatial_navigation

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::focusDirectionForKey):
(WebCore::EventHandler::defaultArrowEventHandler):

  • page/EventHandler.h:
  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocus):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::advanceFocusDirectionally):
(WebCore::updateFocusCandidateIfCloser):
(WebCore::FocusController::findFocusableNodeInDirection):
(WebCore::FocusController::deepFindFocusableNodeInDirection):

  • page/FocusController.h:
  • page/FocusDirection.h:

(WebCore::):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setSpatialNavigationEnabled):

  • page/Settings.h:

(WebCore::Settings::isSpatialNavigationEnabled):

  • page/SpatialNavigation.cpp: Added.

(WebCore::distanceInDirection):
(WebCore::renderRectRelativeToRootDocument):
(WebCore::alignmentForRects):
(WebCore::isHorizontalMove):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsPartiallyAligned):
(WebCore::spatialDistance):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::isInRootDocument):
(WebCore::deflateIfOverlapped):

  • page/SpatialNavigation.h: Added.

(WebCore::):
(WebCore::FocusCandidate::FocusCandidate):

12:08 PM Changeset in webkit [55542] by Beth Dakin
  • 10 edits
    2 adds
    1 delete in trunk

WebCore: This fixes the layering violation I committed yesterday by moving
Page::instanceHandle into its own file just in the WebCore
namespace.

Reviewed by Anders Carlsson.

Added WebCoreInstanceHandle.h + .cpp and removed PageWin.cpp

  • WebCore.vcproj/WebCore.vcproj:
  • page/win/PageWin.cpp: Removed.

Remove all instance handle code from Page.

  • page/Page.h:

New files.

  • platform/win/WebCoreInstanceHandle.cpp: Added.
  • platform/win/WebCoreInstanceHandle.h: Added.

(WebCore::setInstanceHandle):
(WebCore::instanceHandle):

Switch to WebCore::instanceHandle() instead of
Page::instanceHandle() and include the new header.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::Pasteboard):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::show):
(WebCore::PopupMenu::registerClass):

  • platform/win/SharedTimerWin.cpp:

(WebCore::initializeOffScreenTimerWindow):

  • plugins/win/PluginViewWin.cpp:

(WebCore::registerPluginView):
(WebCore::PluginView::platformStart):

WebKit/win: WebCore::Page::setInstanceHandle() is now just
WebCore::setInstanceHandle()

Reviewed by Anders Carlsson.

  • WebKitDLL.cpp:

(DllMain):

11:30 AM Changeset in webkit [55541] by eric@webkit.org
  • 6 edits in trunk

2010-03-04 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Simon Hausmann.

Make Qt DumpRenderTree EventSender able to send double click events

LayoutTests:

fast/events/dblclick-addEventListener.html

[Qt] DRT: Send double click event from EventSender
​https://bugs.webkit.org/show_bug.cgi?id=35255

  • platform/qt/Skipped:

2010-03-04 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Simon Hausmann.

Make Qt DumpRenderTree EventSender able to send double click events

LayoutTests:

fast/events/dblclick-addEventListener.html

[Qt] DRT: Send double click event from EventSender
​https://bugs.webkit.org/show_bug.cgi?id=35255

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::EventSender): (EventSender::mouseDown):
  • DumpRenderTree/qt/EventSenderQt.h: (EventSender::resetClickCount):
11:15 AM Changeset in webkit [55540] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

[Gtk] Unreviewed build fix.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

'glib_file_name' renamed to 'gligFileName'.

  • platform/graphics/gtk/ImageGtk.cpp:

(WebCore::Image::loadPlatformResource):

11:12 AM Changeset in webkit [55539] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-04 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] qwebelement.h does not include QtCore headers correctly
​https://bugs.webkit.org/show_bug.cgi?id=35748

The header files of QtCore must be included as QtCore/foo.h.

See also ​http://bugreports.qt.nokia.com/browse/QTBUG-8661

  • Api/qwebelement.h:
11:03 AM Changeset in webkit [55538] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-04 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium tests fix.

  • src/js/Tests.js:
10:56 AM Changeset in webkit [55537] by pfeldman@chromium.org
  • 15 edits in trunk

2010-03-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Remove two last synchronous calls from front-end to InspectorBackend.

​https://bugs.webkit.org/show_bug.cgi?id=35720

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::enableSearchingForNode): (WebCore::InspectorBackend::disableSearchingForNode): (WebCore::InspectorBackend::setPauseOnExceptionsState):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorContorller::setSearchingForNode): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::searchingForNodeWasEnabled): (WebCore::InspectorFrontend::searchingForNodeWasDisabled): (WebCore::InspectorFrontend::updatePauseOnExceptionsState):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.get statusBarItems): (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.searchingForNodeWasEnabled): (WebInspector.ElementsPanel.prototype.searchingForNodeWasDisabled): (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.enableSearchingForNode): (.WebInspector.InspectorBackendStub.prototype.disableSearchingForNode): (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptionsState):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get statusBarItems): (WebInspector.ScriptsPanel.prototype.updatePauseOnExceptionsState): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
  • inspector/front-end/inspector.js: (WebInspector.searchingForNodeWasEnabled): (WebInspector.searchingForNodeWasDisabled): (WebInspector.updatePauseOnExceptionsState): WebKit/chromium:
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
10:48 AM Changeset in webkit [55536] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-03-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Clicking on an error should take me to the error

​https://bugs.webkit.org/show_bug.cgi?id=34860

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype.selectContentTab):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource):
10:46 AM Changeset in webkit [55535] by pfeldman@chromium.org
  • 12 edits in trunk

2010-03-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Remove sync access to resourceTrackingEnabled.

​https://bugs.webkit.org/show_bug.cgi?id=35693

  • inspector/InspectorBackend.cpp:
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources): (WebInspector.AuditsPanel.prototype.show):
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.enableDebugger): (.WebInspector.InspectorBackendStub.prototype.disableDebugger): (.WebInspector.InspectorBackendStub.prototype.enableProfiler): (.WebInspector.InspectorBackendStub.prototype.disableProfiler):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.get resourceTrackingEnabled): (WebInspector.ResourcesPanel.prototype.get visibleView): (WebInspector.ResourcesPanel.prototype.resourceTrackingWasEnabled): (WebInspector.ResourcesPanel.prototype.resourceTrackingWasDisabled): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._enableResourceTracking): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
10:43 AM Changeset in webkit [55534] by jam@chromium.org
  • 1 edit in trunk/LayoutTests/fast/dom/Window/slow-unload-handler-expected.txt

Update test expectations from my recent checkin

10:43 AM Changeset in webkit [55533] by chang.shu@nokia.com
  • 5 edits in trunk/LayoutTests

Committed by Chang Shu: commit manually for bug 35687.

10:17 AM Changeset in webkit [55532] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-04 Antoine Quint <​ml@graougraou.com>

Reviewed by Darin Adler.

DOM insertion mutation events should dispatch after a node is attached to the render tree
​https://bugs.webkit.org/show_bug.cgi?id=35590

  • fast/events/domnodeinsertedintodocument-dispatched-post-rendering-expected.txt: Added.
  • fast/events/domnodeinsertedintodocument-dispatched-post-rendering.html: Added.

2010-03-04 Antoine Quint <​ml@graougraou.com>

Reviewed by Darin Adler.

DOM insertion mutation events should dispatch after a node is attached to the render tree
​https://bugs.webkit.org/show_bug.cgi?id=35590

Test: fast/events/domnodeinsertedintodocument-dispatched-post-rendering.html

Split off the internal-to-WebCore node insertion notification code from the DOM mutation
event dispatching, originally in dispatchChildInsertionEvents(), to a new static function
called notifyChildInserted(). This allows us to dispatch the mutation events at a later
time upon insertion of a child into to the tree, specifically _after_ attachment to the render
tree.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildInsertionEvents):
10:00 AM Changeset in webkit [55531] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-04 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Holger Freyther.

Make paths relocatable on runtime on Windows
​https://bugs.webkit.org/show_bug.cgi?id=32711

  • platform/graphics/gtk/ImageGtk.cpp: (get_webkit_datadir): (WebCore::Image::loadPlatformResource):
9:35 AM Changeset in webkit [55530] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2010-03-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Popup for Timeline panel will work in a tooltip mode

​https://bugs.webkit.org/show_bug.cgi?id=35680

9:25 AM Changeset in webkit [55529] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

REGRESSION (31281): -[WebArchive initWithCoder:] leaks
<rdar://problem/7702420> and ​https://bugs.webkit.org/show_bug.cgi?id=35534

Reviewed by Geoff Garen.

  • WebView/WebArchive.mm:

(-[WebArchive initWithCoder:]): Don't retain objects we don't own.

9:18 AM Changeset in webkit [55528] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2010-03-04 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix.

Build fix after r55464.

No new tests, no new functionality.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
8:14 AM Changeset in webkit [55527] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] storage/open-database-creation-callback-isolated-world.html was removed
from tree by r55488, so it should be removed from Qt Skipped list too.

  • platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html removed.
7:41 AM Changeset in webkit [55526] by eric@webkit.org
  • 1 edit
    7 adds in trunk/WebCore

2010-03-04 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to platform/graphics/efl.
​http://webkit.org/b/35539

  • platform/graphics/efl/FloatRectEfl.cpp: Added.
  • platform/graphics/efl/FontEfl.cpp: Added.
  • platform/graphics/efl/IconEfl.cpp: Added.
  • platform/graphics/efl/ImageEfl.cpp: Added.
  • platform/graphics/efl/IntPointEfl.cpp: Added.
  • platform/graphics/efl/IntRectEfl.cpp: Added.
7:25 AM Changeset in webkit [55525] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-03-04 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to platform/text/efl.
​http://webkit.org/b/35740

  • platform/text/efl/TextBreakIteratorInternalICUEfl.cpp: Added.
7:03 AM Changeset in webkit [55524] by eric@webkit.org
  • 4 edits in trunk

2010-03-04 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=35726
Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID

Removing orphaned #if USE.

  • GNUmakefile.am:

2010-03-04 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=35726
Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID

Removing orphaned #if USE.

  • platform/ThreadGlobalData.h:
6:24 AM Changeset in webkit [55523] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

Trottle sync requests sent to the LocalStorage background thread
​https://bugs.webkit.org/show_bug.cgi?id=34943

Reviewed by Darin Fisher.

Currently, once a second LocalStorage takes all keys/values which have
been changed and sends them to a background thread to sync. The problem
is that this background thread can get overwhelmed and stop being
responsive. This means that if any other page tries to start using
LocalStorage (and thus initiates the initial import) that'll block on
all the previous syncs completing.

To mitigate this, I'm adding code so that we never schedule another
sync task when another is still running. In order to keep the sync
tasks from growing exponentially when they do take longer than the
storage sync interval, I've also added a basic rate limiter. No effort
is made to ensure fairness/ordering of what gets synced nor is there
any way for this rate to be changed because most normal uses of
LocalStorage really shouldn't be hitting these types of limits anyway.

The only behavioral change that's observible in JavaScript is time based
and thus it's not practical to make new tests that aren't racy. The
existing layout tests cover LocalStorage pretty well, though.

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::scheduleFinalSync):
(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::performSync):

  • storage/StorageAreaSync.h:
6:00 AM Changeset in webkit [55522] by pfeldman@chromium.org
  • 27 edits
    2 copies
    1 add in trunk

2010-03-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Added support for worker instrumentation in inspector
(display list of active workers, allow debugging of workers
by injecting fake JS implementation)

​https://bugs.webkit.org/show_bug.cgi?id=35568

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
  • dom/Document.cpp: (WebCore::Document::inspectorController):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::inspectorController):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::injectScript): (WebCore::InjectedScriptHost::nextWorkerId): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::willDestroyWorker):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::willDestroyWorker):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCreateWorker): (WebCore::InspectorFrontend::willDestroyWorker):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorWorkerResource.h: Added. (WebCore::InspectorWorkerResource::create): (WebCore::InspectorWorkerResource::id): (WebCore::InspectorWorkerResource::url): (WebCore::InspectorWorkerResource::isSharedWorker): (WebCore::InspectorWorkerResource::InspectorWorkerResource):
  • inspector/front-end/Checkbox.js: Added. (WebInspector.Checkbox.callbackWrapper): (WebInspector.Checkbox): (WebInspector.Checkbox.prototype.checked):
  • inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._handleException): (InjectedFakeWorker.FakeWorker.prototype._importScripts): (InjectedFakeWorker.FakeWorker.prototype._loadScript): (InjectedFakeWorker.FakeWorker.prototype._expandURLAndCheckOrigin):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/WorkersSidebarPane.js: Added. (WebInspector.WorkersSidebarPane): (WebInspector.WorkersSidebarPane.prototype.addWorker): (WebInspector.WorkersSidebarPane.prototype.removeWorker): (WebInspector.WorkersSidebarPane.prototype.setInstrumentation): (WebInspector.WorkersSidebarPane.prototype.reset): (WebInspector.WorkersSidebarPane.prototype._onTriggerInstrument): (WebInspector.Worker): (WebInspector.didCreateWorker): (WebInspector.willDestroyWorker):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::AbstractWorker): (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::onDestroyWorker): (WebCore::AbstractWorker::contextDestroyed):
  • workers/AbstractWorker.h: (WebCore::AbstractWorker::id):
  • workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
  • workers/Worker.cpp: (WebCore::Worker::Worker):
5:58 AM Changeset in webkit [55521] by hamaji@chromium.org
  • 2 edits in trunk/JavaScriptCore

2010-03-04 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. Remove a non-ASCII character introduced in the following bug.

put_by_id does will incorrectly cache writes where a specific value exists, where at the point of caching the same value is being written.
​https://bugs.webkit.org/show_bug.cgi?id=35537

  • runtime/JSObject.h: (JSC::JSObject::putDirectInternal):
5:39 AM Changeset in webkit [55520] by jocelyn.turcotte@nokia.com
  • 27 edits in trunk

[Qt] Make the OUTPUT_DIR variable in qmake projects independent of build-webkit's logic.

Reviewed by Tor Arne Vestbø.

This also allows shadow builds relying only on qmake to work properly.

.:

  • WebKit.pri:

JavaScriptCore:

  • jsc.pro:
  • qt/api/QtScript.pro:
  • qt/tests/qscriptengine/qscriptengine.pro:
  • qt/tests/qscriptvalue/qscriptvalue.pro:
  • qt/tests/tests.pri:

WebCore:

  • WebCore.pro:

WebKit\qt:

  • tests/benchmarks/loading/loading.pro:
  • tests/benchmarks/painting/painting.pro:
  • tests/hybridPixmap/hybridPixmap.pro:
  • tests/qgraphicswebview/qgraphicswebview.pro:
  • tests/qwebelement/qwebelement.pro:
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebhistory/qwebhistory.pro:
  • tests/qwebhistoryinterface/qwebhistoryinterface.pro:
  • tests/qwebinspector/qwebinspector.pro:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebplugindatabase/qwebplugindatabase.pro:

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/ImageDiff.pro:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • QtLauncher/QtLauncher.pro:
5:17 AM QtWebKitBugs edited by Simon Hausmann
(diff)
4:46 AM Changeset in webkit [55519] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Enable to use built-product-archive on Qt platform.

Patch by Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu> on 2010-03-04
Reviewed by Kenneth Rohde Christiansen.

  • BuildSlaveSupport/built-product-archive:
4:29 AM Changeset in webkit [55518] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Avoid calling QFont::detach too often from FontQt

​https://bugs.webkit.org/show_bug.cgi?id=35569

The letter- and wordspacing is inside the WebCore::Font class,
our QFont is located in the WebCore::FontPlatformData. Everytime
we need to use a QFont inside WebCore::Font we are calling the
font method which gets the QFont from the WebCore::FontPlatformData
and is applying the letter- and wordspacing. Internally this
will attempt to detach the QFont...

Avoid calling setLetterSpacing and setWordSpacing on QFont if
the WebCore::Font has the default applied.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::font):

4:21 AM Changeset in webkit [55517] by apavlov@chromium.org
  • 4 edits in trunk/WebCore

2010-03-04 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Nothing happens on navigation to resource via a link if resource tracking is disabled
​https://bugs.webkit.org/show_bug.cgi?id=35574

3:04 AM Changeset in webkit [55516] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] DRT is failing on new test introduced in r55499
Skipping it until fix.
​https://bugs.webkit.org/show_bug.cgi?id=35729

  • platform/qt/Skipped: fast/events/zoom-dblclick.html skipped
2:45 AM Changeset in webkit [55515] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Fix generation of forwaring headers

Reviewed by Kenneth Rohde Christiansen.

The dependencies were a bit wrong, so we ended up not generating
forwarding headers for qwebkitversion.h and qwebkitglobal.h

The forwardning headers are now the only targets depending on the
real headers. All other targets either depend on the generated
class headers, or the forwarding headers.

  • Api/DerivedSources.pro:
1:41 AM Changeset in webkit [55514] by eric@webkit.org
  • 5 edits in trunk

2010-03-04 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Oliver Hunt.

Update existing test to check that getUniformLocation() returns
null if the uniform requested is not found.
​https://bugs.webkit.org/show_bug.cgi?id=34669

  • fast/canvas/webgl/script-tests/uniform-location.js:
  • fast/canvas/webgl/uniform-location-expected.txt:

2010-03-04 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Oliver Hunt.

getUniformLocation() now returns null if uniform requested
is not found.
​https://bugs.webkit.org/show_bug.cgi?id=34669

Test:LayoutTests/fast/canvas/webgl/uniform-location.html
(added missing test)

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniformLocation):
1:24 AM Changeset in webkit [55513] by eric@webkit.org
  • 4 edits in trunk

2010-03-04 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Adam Barth.

Fix incorrect setup of DateExtension.
​https://bugs.webkit.org/show_bug.cgi?id=35710

  • fast/dom/Window/resources/slow_unload_handler1.html:

2010-03-04 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Adam Barth.

Fix incorrect setup of DateExtension.
​https://bugs.webkit.org/show_bug.cgi?id=35710

  • bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep):
1:13 AM Changeset in webkit [55512] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-04 Darin Fisher <​darin@chromium.org>

Reviewed by Pavel Feldman.

Fix failing DevToolsSanityTest.TestResourceContentLength
​https://bugs.webkit.org/show_bug.cgi?id=35725

​http://trac.webkit.org/changeset/55466 missed one more spot
where contentLength needed to be renamed resourceSize.

  • src/js/Tests.js:
12:57 AM Changeset in webkit [55511] by oliver@apple.com
  • 4 edits
    10 adds in trunk

2010-03-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=35603
SVG incorrectly allows nested <use> elements in a <use> shadow tree

Simplify the handling of invalid or missing use-targets by cloning them
to empty <g> elements rather than just allowing the <use> element to
be copied into the shadow tree, as this violates a number of assumptions
in the shadow tree handling code.

Tests: svg/custom/use-nested-disallowed-target.svg

svg/custom/use-nested-missing-target-added.svg
svg/custom/use-nested-missing-target-removed.svg
svg/custom/use-nested-missing-target.svg
svg/custom/use-nested-notarget.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildPendingResource): (WebCore::SVGUseElement::buildShadowAndInstanceTree): (WebCore::SVGUseElement::expandUseElementsInShadowTree):

2010-03-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=35603
SVG incorrectly allows nested <use> elements in a <use> shadow tree

Add test cases for various combinations of <use> and targets that aren't present.

  • platform/mac/svg/custom/use-empty-reference-expected.txt: Added.
  • svg/custom/use-nested-disallowed-target-expected.txt: Added.
  • svg/custom/use-nested-disallowed-target.svg: Added.
  • svg/custom/use-nested-missing-target-added-expected.txt: Added.
  • svg/custom/use-nested-missing-target-added.svg: Added.
  • svg/custom/use-nested-missing-target-expected.txt: Added.
  • svg/custom/use-nested-missing-target-removed-expected.txt: Added.
  • svg/custom/use-nested-missing-target-removed.svg: Added.
  • svg/custom/use-nested-missing-target.svg: Added.
  • svg/custom/use-nested-notarget-expected.txt: Added.
  • svg/custom/use-nested-notarget.svg: Added.
12:51 AM Changeset in webkit [55510] by eric@webkit.org
  • 2 edits
    7 moves in trunk/WebCore

2010-03-04 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Move Cairo-related font code from platform/graphics/gtk to
platform/graphics/cairo, so other ports may use them.
​http://webkit.org/b/35539

  • GNUmakefile.am:
  • platform/graphics/cairo/FontCacheCairo.cpp: Copied from WebCore/platform/graphics/gtk/FontCacheGtk.cpp.
  • platform/graphics/cairo/FontCustomPlatformData.cpp: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformData.cpp.
  • platform/graphics/cairo/FontCustomPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformData.h.
  • platform/graphics/cairo/FontPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontPlatformData.h.
  • platform/graphics/cairo/FontPlatformDataCairo.cpp: Copied from WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp.
  • platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: Copied from WebCore/platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp.
  • platform/graphics/cairo/SimpleFontDataCairo.cpp: Copied from WebCore/platform/graphics/gtk/SimpleFontDataGtk.cpp.
  • platform/graphics/gtk/FontCacheGtk.cpp: Removed.
  • platform/graphics/gtk/FontCustomPlatformData.cpp: Removed.
  • platform/graphics/gtk/FontCustomPlatformData.h: Removed.
  • platform/graphics/gtk/FontPlatformData.h: Removed.
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: Removed.
  • platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp: Removed.
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: Removed.
12:34 AM Changeset in webkit [55509] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-03-04 Evan Stade <​estade@chromium.org>

Reviewed by David Levin.

​https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs with Skia

This test passes if it doesn't crash.

  • platform/mac/Skipped: Skip the test on Mac, where it crashes.
  • svg/custom/tiling-regular-hexagonal-crash-expected.txt: Added.
  • svg/custom/tiling-regular-hexagonal-crash.svg: Added.

2010-03-04 Evan Stade <​estade@chromium.org>

Reviewed by David Levin.

​https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs

This fixes the crash, but the SVG still doesn't render properly.

Test: svg/custom/tiling-regular-hexagonal-crash.svg

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImageSingleFrameSkia::create): don't return 0 when the copy fails; instead return a blank bitmap. The caller doesn't check for 0 before dereferencing.
12:03 AM Changeset in webkit [55508] by tony@chromium.org
  • 2 edits in trunk/WebCore

2010-03-04 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

Initialize m_isMultipartPayload in other ResourceResponse ctor.
In r55451 (bug 35628) I added an extra bool, but only initialized
it in one constructor.
​https://bugs.webkit.org/show_bug.cgi?id=35719

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
12:01 AM Changeset in webkit [55507] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKit/chromium

2010-03-03 Garret Kelly <​gdk@chromium.org>

Reviewed by Darin Fisher.

Adding touch event type and point type. Tested against the try bots.
​https://bugs.webkit.org/show_bug.cgi?id=35691

  • public/WebInputEvent.h: (WebKit::WebInputEvent::): (WebKit::WebInputEvent::isTouchEventType): (WebKit::WebTouchEvent::WebTouchEvent):
  • public/WebTouchPoint.h: Added. (WebKit::WebTouchPoint::WebTouchPoint): (WebKit::WebTouchPoint::):
Note: See TracTimeline for information about the timeline view.