⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 6, 2010:

9:44 PM Changeset in webkit [55633] by mrowe@apple.com
  • 76 edits in trunk

Remove unnecessary includes of wtf/Platform.h. This is already pulled in by config.h.

Rubber-stamped by Sam Weinig.

JavaScriptCore:

Remove unnecessary includes of wtf/Platform.h. This is already pulled in by config.h.

  • API/APICast.h:
  • API/JSCallbackFunction.cpp:
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp:
  • API/JSValueRef.cpp:
  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h:
  • assembler/AssemblerBuffer.h:
  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/CodeLocation.h:
  • assembler/LinkBuffer.h:
  • assembler/MIPSAssembler.h:
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerARMv7.h:
  • assembler/MacroAssemblerCodeRef.h:
  • assembler/MacroAssemblerMIPS.h:
  • assembler/MacroAssemblerX86.h:
  • assembler/MacroAssemblerX86Common.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/RepatchBuffer.h:
  • assembler/X86Assembler.h:
  • jit/JIT.h:
  • jit/JITCode.h:
  • jit/JITInlineMethods.h:
  • jit/JITStubs.h:
  • os-win32/stdint.h:
  • runtime/JSAPIValueWrapper.h:
  • runtime/JSImmediate.h:
  • wtf/ASCIICType.h:
  • wtf/StdLibExtras.h:
  • wtf/VMTags.h:
  • yarr/RegexCompiler.h:
  • yarr/RegexInterpreter.h:
  • yarr/RegexJIT.h:
  • yarr/RegexParser.h:
  • yarr/RegexPattern.h:

WebCore:

Remove unnecessary includes of wtf/Platform.h. This is already pulled in by config.h.

  • accessibility/AccessibilityObject.h:
  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizerLibxml2.cpp:
  • dom/XMLTokenizerQt.cpp:
  • editing/TextAffinity.h:
  • loader/FrameLoaderClient.h:
  • page/FocusController.cpp:
  • page/FrameTree.cpp:
  • page/Geolocation.h:
  • page/PositionCallback.h:
  • page/PositionErrorCallback.h:
  • platform/Cursor.h:
  • platform/FileSystem.h:
  • platform/FloatConversion.h:
  • platform/KeyboardCodes.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformTouchPoint.h:
  • platform/SuddenTermination.h:
  • platform/Widget.h:
  • platform/graphics/Color.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/openvg/PainterOpenVG.h:
  • platform/graphics/openvg/SurfaceOpenVG.h:
  • platform/network/ResourceHandleClient.h:
  • platform/text/Base64.cpp:
  • rendering/style/SVGRenderStyle.h:
  • xml/XSLTProcessor.cpp:
  • xml/XSLTProcessorLibxslt.cpp:
  • xml/XSLTProcessorQt.cpp:

WebKit/qt:

Remove unnecessary includes of wtf/Platform.h. This is already pulled in by the prefix header.

  • WebCoreSupport/EditCommandQt.cpp:
7:31 PM Changeset in webkit [55632] by weinig@apple.com
  • 7 edits
    3 adds in trunk/WebCore

Move debug only JS wrapper-set tracking code into its own file.
​https://bugs.webkit.org/show_bug.cgi?id=35839

Reviewed by Dan Bernstein.

  • GNUmakefile.am: Added new files.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSDOMBinding.cpp:

(WebCore::cacheDOMObjectWrapper):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument):
Updated for new signature for willCacheWrapper and didUncacheWrapper.

  • bindings/js/JSDOMWrapper.cpp: Added.

(WebCore::DOMObject::~DOMObject):
(WebCore::DOMObject::defineOwnProperty):
Moved from JSDOMBinding.cpp.

  • bindings/js/JSDebugWrapperSet.cpp: Added.

(WebCore::JSDebugWrapperSet::shared):
(WebCore::JSDebugWrapperSet::JSDebugWrapperSet):

  • bindings/js/JSDebugWrapperSet.h: Added.

(WebCore::JSDebugWrapperSet::add):
(WebCore::JSDebugWrapperSet::remove):
(WebCore::JSDebugWrapperSet::contains):
(WebCore::JSDebugWrapperSet::willCacheWrapper):
(WebCore::JSDebugWrapperSet::didUncacheWrapper):
Moved from JSDOMBinding.cpp.

4:38 PM Changeset in webkit [55631] by weinig@apple.com
  • 11 edits
    5 copies in trunk/WebCore

Rubber-stamped by Dan Bernstein.

Move DOMObjectHashTableMap, DOMWrapperWorld and WebCoreJSClientData into
their own files.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/DOMObjectHashTableMap.cpp: Copied from bindings/js/JSDOMBinding.cpp.
  • bindings/js/DOMObjectHashTableMap.h: Copied from bindings/js/JSDOMBinding.h.

(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):

  • bindings/js/DOMWrapperWorld.cpp: Copied from bindings/js/JSDOMBinding.cpp.

(WebCore::forgetWorldOfDOMNodesForDocument):

  • bindings/js/DOMWrapperWorld.h: Copied from bindings/js/JSDOMBinding.h.

(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::rememberDocument):
(WebCore::DOMWrapperWorld::forgetDocument):
(WebCore::DOMWrapperWorld::isNormal):
(WebCore::debuggerWorld):
(WebCore::pluginWorld):
(WebCore::currentWorld):
(WebCore::Document::getWrapperCache):

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/WebCoreJSClientData.h: Copied from bindings/js/JSDOMBinding.h.

(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::~WebCoreJSClientData):
(WebCore::WebCoreJSClientData::normalWorld):
(WebCore::WebCoreJSClientData::getAllWorlds):
(WebCore::WebCoreJSClientData::rememberWorld):
(WebCore::WebCoreJSClientData::forgetWorld):

  • bindings/js/WorkerScriptController.cpp:
3:01 PM Changeset in webkit [55630] by mitz@apple.com
  • 3 edits in trunk/WebCore

Rubber-stamped by Sam Weinig.

Remove an unused method.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): Changed comment.
(WebCore::RenderBlock::floatRect): Removed.

  • rendering/RenderBlock.h: Removed floatRect().
1:45 PM Changeset in webkit [55629] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Chromium: Restore devtools window activate upon node search complete.

​https://bugs.webkit.org/show_bug.cgi?id=35832

  • src/js/DevTools.js:
1:42 PM Changeset in webkit [55628] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-03-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make timeline overview bars transparent to mouse events.

​https://bugs.webkit.org/show_bug.cgi?id=35832

  • inspector/front-end/inspector.css:
10:14 AM Changeset in webkit [55627] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-03-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Jeremy Orlow.

Web Inspector: switching to/from Timeline Panel moves scroller.
(Also added couple of record details items as I was fixing it).

​https://bugs.webkit.org/show_bug.cgi?id=35829

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get defaultFocusedElement): (WebInspector.TimelinePanel.prototype.show): (WebInspector.TimelinePanel.prototype._refreshRecords):
7:30 AM Changeset in webkit [55626] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-06 Darin Fisher <​darin@chromium.org>

Reviewed by David Levin.

[Chromium] Embedder initiated loads should not always stop existing loads
​https://bugs.webkit.org/show_bug.cgi?id=33862

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::reload): (WebKit::WebFrameImpl::loadRequest): (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::loadData):
7:13 AM Changeset in webkit [55625] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-06 Darin Fisher <​darin@chromium.org>

Reviewed by David Levin.

[Chromium] spurious WebViewClient::didStopLoading if changing
location.hash while a subframe is still loading

​https://bugs.webkit.org/show_bug.cgi?id=33884

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage): Call isLoadingInAPISense, which checks subframes.
6:57 AM Changeset in webkit [55624] by eric@webkit.org
  • 1 edit
    1 delete in trunk/WebCore

2010-03-06 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

Removed unnecessary WinCE file.
The same functionality is provided by platform/win/SystemTimeWin.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=35799

  • platform/wince/SystemTimeWince.cpp: Removed.
6:40 AM Changeset in webkit [55623] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-03-06 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk

  • platform/gtk/accessibility/table-hierarchy.html: Added.
  • platform/gtk/accessibility/table-hierarchy-expected.txt: Added.

2010-03-06 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk

This completes the fixing of the Atk table hierarchy which was started
in bug #35418.

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
  • accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::determineAccessibilityRole):
6:23 AM Changeset in webkit [55622] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-03-06 Arno Renevier <​arno@renevier.net>

Reviewed by Eric Seidel.

[Gtk] GEOLOCATION_POLICY_DECISION_CANCELLED unused
​https://bugs.webkit.org/show_bug.cgi?id=35803

  • webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
5:57 AM Changeset in webkit [55621] by eric@webkit.org
  • 2 edits
    1 copy
    2 deletes in trunk/JavaScriptCore

2010-03-06 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Share OwnPtr.
​https://bugs.webkit.org/show_bug.cgi?id=35776

Share OwnPtr implementation with BREW MP and remove OwnPtrBrew.

  • wtf/OwnPtrBrew.cpp: Added. (WTF::deleteOwnedPtr):
  • wtf/OwnPtrCommon.h:
  • wtf/brew/OwnPtrBrew.cpp: Removed.
  • wtf/brew/OwnPtrBrew.h: Removed.
5:20 AM Changeset in webkit [55620] by eric@webkit.org
  • 8 edits
    2 adds in trunk

2010-03-06 Hironori Bono <​hbono@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Typing into Flash with wmode = opaque|transparent and
non-latin language active outputs as if US keyboard layout active

​https://bugs.webkit.org/show_bug.cgi?id=34936

Added a layout test that verifies a plugin can receive keyboard events.
Unfortunately, this test works only on Mac.

  • platform/gtk/Skipped: Skipped the new test because of the lack of eventSender.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: Skipped the new test because NPP_HandleEvent() is not implemented.
  • plugins/keyboard-events-expected.txt: Added.
  • plugins/keyboard-events.html: Added.

2010-03-06 Hironori Bono <​hbono@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Typing into Flash with wmode = opaque|transparent and
non-latin language active outputs as if US keyboard layout active

​https://bugs.webkit.org/show_bug.cgi?id=34936

This change is a WebKit-side change for this issue. It dispatches
Char events to plug-ins so plug-ins can receive non-ASCII characters
as well as ASCII characters.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent):

2010-03-06 Hironori Bono <​hbono@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Typing into Flash with wmode = opaque|transparent and
non-latin language active outputs as if US keyboard layout active

​https://bugs.webkit.org/show_bug.cgi?id=34936

To test keyboard events on the test plugin, this change implements
NPCocoaEventKeyDown and NPCocoaEventKeyUp handlers so the plugin
can write log messages.

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (handleEventCocoa): Implemented the event handlers for NPCocoaKeyDown and NPCocoaEventKeyUp.
5:03 AM Changeset in webkit [55619] by eric@webkit.org
  • 7 edits in trunk

2010-03-06 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

Moved implementations of window.btoa() and window.atob() from
JSDOMWindow to DOMWindow, and make V8DOMWindow use DOMWindow
functions instead of having a separate implementation. As a side effect, the
error message has changed from "Cannot decode base64" to one that
indicates DOM Exception, which is compatible to Firefox.

Refactoring: window.btoa() and window.atob() should be implemented on DOMWindow
​https://bugs.webkit.org/show_bug.cgi?id=35723

  • fast/dom/Window/atob-btoa-expected.txt: Rebaselined expectation due to change of error message.

2010-03-06 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

Moved implementations of window.btoa() and window.atob() from
JSDOMWindow to DOMWindow, and make V8DOMWindow use DOMWindow
functions instead of having a separate implementation. As a side effect, the
error message has changed from "Cannot decode base64" to one that
indicates DOM Exception, which is compatible to Firefox.

Refactoring: window.btoa() and window.atob() should be implemented on DOMWindow
​https://bugs.webkit.org/show_bug.cgi?id=35723

No new test. No new functionality.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa): Moved conversion code to DOMWindow and invoke it. Argument checking remains here.
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::atobCallback): (WebCore::V8DOMWindow::btoaCallback): Remove conversion code and call DOMWindow APIs. Although argument checking remains here.
  • page/DOMWindow.cpp: (WebCore::hasMultibyteCharacters): (WebCore::DOMWindow::btoa): (WebCore::DOMWindow::atob):
  • page/DOMWindow.h: Moved Conversion code from JSDOMWindow, modifing to fit JSC independent.
4:43 AM Changeset in webkit [55618] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebKit/chromium

2010-03-06 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Darin Fisher.

Create WebKit API for WebCore::ImageDecoder
​https://bugs.webkit.org/show_bug.cgi?id=35415

  • WebKit.gyp:
  • public/WebImageDecoder.h: Added.
  • src/WebImageDecoder.cpp: Added.
4:26 AM Changeset in webkit [55617] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-06 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Eric Seidel.

Fix decoration position in search input field.

This patch fixes rendering of input field of "search" type, whose decoration
(loupe icon and close button) was wrongly positioned when the input field was
contained in a block with -webkit-transform property.

Chromium bug: ​http://crbug.com/20439

[Chromium] Decoration of "search" input field is wrongly rendered
​https://bugs.webkit.org/show_bug.cgi?id=30245

No new tests, since this patch fixes an existing test
(fast/forms/search-transformed.html) in Chromium layout tests.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::convertToPaintingRect): Added. This method does almost the same thing as RenderThemeMac::convertToPaintingRect. (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): The position of the icon should not depend on its absolute position. (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): Ditto. (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): Ditto.
  • rendering/RenderThemeChromiumSkia.h: Added new method.
3:50 AM Changeset in webkit [55616] by eric@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-03-06 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Added expected results and removed the test from Skipped.
​https://bugs.webkit.org/show_bug.cgi?id=35806

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvasDrawingIntoSelf-expected.checksum: Added.
  • platform/qt/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
  • platform/qt/fast/canvas/canvasDrawingIntoSelf-expected.txt: Added.
3:31 AM Changeset in webkit [55615] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-06 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

Implemented JIT_OPTIMIZE_NATIVE_CALL for WinCE
​https://bugs.webkit.org/show_bug.cgi?id=33426

  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
3:00 AM Changeset in webkit [55614] by pfeldman@chromium.org
  • 5 edits in trunk

2010-03-06 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: in Timeline panel, click followed with mouse move resets popover.

​https://bugs.webkit.org/show_bug.cgi?id=35827

  • inspector/front-end/Popover.js: (WebInspector.PopoverHelper.prototype._mouseDown): (WebInspector.PopoverHelper.prototype._mouseMove): (WebInspector.PopoverHelper.prototype._handleMouseAction):

Mar 5, 2010:

11:28 PM Changeset in webkit [55613] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-05 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=33247
Backwards cursor movement incorrect when previous block ends with <br>.

If the cursor is trying to move into a node that has a height of 0,
skip over it.

  • editing/execCommand/move-selection-back-line-expected.txt: Added.
  • editing/execCommand/move-selection-back-line.html: Added.

2010-03-05 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=33247
Backwards cursor movement incorrect when previous block ends with <br>.

If the cursor is trying to move into a node that has a height of 0,
skip over it.

Test: editing/execCommand/move-selection-back-line.html

  • editing/visible_units.cpp: (WebCore::previousLinePosition):
11:11 PM Changeset in webkit [55612] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-05 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Eric Seidel.

Enable resource loading callback while loading worker scripts
​https://bugs.webkit.org/show_bug.cgi?id=35744

  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously):
10:45 PM Changeset in webkit [55611] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-03-05 Chris Fleizach <Chris Fleizach>

Reviewed by Eric Seidel.

WAI-ARIA live region doesn't appear when <div> only has a <div> child
​https://bugs.webkit.org/show_bug.cgi?id=35751

  • platform/mac/accessibility/div-containing-div-with-aria-expected.txt: Added.
  • platform/mac/accessibility/div-containing-div-with-aria.html: Added.

2010-03-05 Chris Fleizach <Chris Fleizach>

Reviewed by Eric Seidel.

WAI-ARIA live region doesn't appear when <div> only has a <div> child
​https://bugs.webkit.org/show_bug.cgi?id=35751

Elements should not be ignored if they carry ARIA attributes in them.

Test: platform/mac/accessibility/div-containing-div-with-aria.html

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::supportsARIAAttributes):
  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::supportsARIADropping): (WebCore::AccessibilityObject::supportsARIADragging):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::supportsARIADropping): (WebCore::AccessibilityRenderObject::supportsARIADragging): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  • accessibility/AccessibilityRenderObject.h:
7:48 PM Changeset in webkit [55610] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-05 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Eric Seidel.

Fix Print option on QtLauncher by calling print directly from QWebFrame.

[Qt] QtLauncher Print option is not working on QGraphicsView mode
​https://bugs.webkit.org/show_bug.cgi?id=35769

  • QtLauncher/main.cpp: (LauncherWindow::print):
7:16 PM Changeset in webkit [55609] by dimich@chromium.org
  • 1 edit
    1 add in trunk/WebCore

Add a manual test for crash in DOMWindow::clearTimeout when DOMWindow is not connected to Frame
​https://bugs.webkit.org/show_bug.cgi?id=32353

Reviewed by Oliver Hunt.

  • manual-tests/clearTimeout-crash-bug29832.html: Added.
7:04 PM Changeset in webkit [55608] by dimich@chromium.org
  • 3 edits
    3 adds in trunk

[v8] Remove wrong assert in GC callback.
​https://bugs.webkit.org/show_bug.cgi?id=35757

Reviewed by David Levin.

WebCore:

Test: fast/workers/wrapper-map-gc.html

  • bindings/v8/DOMData.h:

(WebCore::DOMData::handleWeakObject): remove ASSERT(isMainThread()), move another assert up to verify we are on the right thread.

LayoutTests:

  • fast/workers/resources/wrapper-map-gc.js: Added.
  • fast/workers/wrapper-map-gc.html: Added.
  • fast/workers/wrapper-map-gc-expected.txt: Added.
6:52 PM Changeset in webkit [55607] by eric@webkit.org
  • 14 edits
    4 copies
    10 adds in trunk

2010-03-05 Alex Milowski <​alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added tests for row and operator stretching.
Updated over, underover, and subsup due to row/operators in use.

  • mathml/presentation/mo.xhtml: Added.
  • mathml/presentation/row.xhtml: Added.
  • platform/mac/mathml/presentation/mo-expected.checksum: Added.
  • platform/mac/mathml/presentation/mo-expected.png: Added.
  • platform/mac/mathml/presentation/mo-expected.txt: Added.
  • platform/mac/mathml/presentation/over-expected.checksum:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/row-expected.checksum: Added.
  • platform/mac/mathml/presentation/row-expected.png: Added.
  • platform/mac/mathml/presentation/row-expected.txt: Added.
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.checksum:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:

2010-03-05 Alex Milowski <​alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added support for row layout with stretchy operators and
adjusted the over spacing for over and underover accordingly.

Tests: mathml/presentation/mo.xhtml

mathml/presentation/row.xhtml

  • WebCore.xcodeproj/project.pbxproj:
  • mathml/MathMLInlineContainerElement.cpp:
  • mathml/MathMLTextElement.cpp:
  • mathml/RenderMathMLMath.cpp: Added.
  • mathml/RenderMathMLMath.h: Added.
  • mathml/RenderMathMLOperator.cpp: Added.
  • mathml/RenderMathMLOperator.h: Added.
  • mathml/RenderMathMLRow.cpp: Added.
  • mathml/RenderMathMLRow.h: Added.
  • mathml/RenderMathMLUnderOver.cpp:
  • mathml/mathtags.in:
6:34 PM Changeset in webkit [55606] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-05 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

Take out code hack that flips the result of NPP_HandleEvent. This needs to move to
the NPAPI code so that Pepper plugins don't hit it.
​https://bugs.webkit.org/show_bug.cgi?id=35779

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
6:27 PM Changeset in webkit [55605] by dino@apple.com
  • 3 edits
    2 adds in trunk

2010-03-05 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=35772
Animation fill modes should be supported in the shorthand property

Add CSSPropertyWebkitAnimationFillMode to the list of properties
evaluated in the -webkit-animation shorthand.

Test: animations/animation-shorthand.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationShorthand):
5:09 PM Changeset in webkit [55604] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-05 Eric Seidel <​eric@webkit.org>

No review. Skipping recently regressed test to unblock the commit-queue (20 patches waiting).

REGRESSION(55593?): fast/workers/worker-cloneport.html is timing out on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=35819

  • platform/mac-leopard/Skipped:
4:52 PM Changeset in webkit [55603] by Chris Jerdonek
  • 19 edits in trunk/WebKitTools

Changed the logging code for new-run-webkit-tests to use
module-specific loggers rather than the root logger. This is
a standard practice that allows logging specific to a package
to be configured independently of other modules.

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=35194

Added a line of the form "_log = logging.getLogger(<module>)"
to each module below, where <module> is the fully-qualified
name of the module, and updated the log lines to use the new
_log logger.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4:38 PM Changeset in webkit [55602] by dpranke@chromium.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-03-05 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Siedel.

Split the command-line invocation of the Chromium/python LigHTTPd
server implementation out into its own top level script to make it
a more "public" interface and to resolve some awkward layering
issues. This script will be called directly by other test scripts in
the Chromium tree.

At some point this script should be made to work with Apache-based
implementations and on other ports. I have filed
​https://bugs.webkit.org/show_bug.cgi?id=35820 for this.

Also fix a bug in port/factory where options.chromium could be
dereferenced even if it wasn't set, raising an exception.

​https://bugs.webkit.org/show_bug.cgi?id=35812

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/new-run-webkit-httpd: Added
4:21 PM Changeset in webkit [55601] by dino@apple.com
  • 11 edits in trunk

2010-03-05 Dean Jackson <​dino@apple.com>

Reviewed by NOBODY (OOPS!).

​https://bugs.webkit.org/show_bug.cgi?id=35815
Animation Fill Modes fail on Windows

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSStyleSelector.cpp:
  • platform/graphics/mac/GraphicsLayerCA.mm:
    • use new enum value
  • platform/animation/Animation.h:
    • change bitfield type
  • rendering/style/RenderStyleConstants.h:
    • add new enum for fill mode
3:44 PM Changeset in webkit [55600] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-03-05 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (build fix).

Add enw exports to windows

3:29 PM Changeset in webkit [55599] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-03-05 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

JSC should cache int to Identifier conversion as it does for ordinary strings
​https://bugs.webkit.org/show_bug.cgi?id=35814

Make the NumericStrings cache cache unsigned ints in addition to signed.
We keep them separate from the int cache as it both simplifies code, and
also because the unsigned path is exclusive to property access and therefore
seems to have different usage patterns.

The primary trigger for the unsigned to Identifier propertyName conversion
is the construction of array-like objects out of normal objects. Given these
tend to be relative small numbers, and the array-like behaviour lends itself
to sequential values this patch also adds a non-colliding cache for all small
numbers.

  • JavaScriptCore.exp:
  • runtime/Identifier.cpp: (JSC::Identifier::from):
  • runtime/Identifier.h:
  • runtime/NumericStrings.h: (JSC::NumericStrings::add): (JSC::NumericStrings::lookup): (JSC::NumericStrings::lookupSmallString):
3:26 PM Changeset in webkit [55598] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

Unreviewed buildfix after r55593. (To fix Qt --minimal build.)

  • bindings/js/JSDOMWindowCustom.cpp: Missing #if ENABLE(DATABASE) guard added.
2:55 PM Changeset in webkit [55597] by Simon Fraser
  • 3 edits
    5 adds in trunk

2010-03-05 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

ASSERTION FAILED: rootLayer == m_clipRectsRoot at hulu.com
​https://bugs.webkit.org/show_bug.cgi?id=34065
<rdar://problem/7573509>

Fix one instance of this assertion (not necessarily the one seen on hulu.com).

If the layer that clippingRoot() is being called on is itself compositing,
then it acts as the clipping root. Without this, calls to RenderLayer::childrenClipRect()
and RenderLayer::selfClipRect() via FrameView::windowClipRectForLayer(), for plug-ins,
caused the caching of an incorrect clip rects root.

Test: compositing/geometry/object-clip-rects-assertion.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::clippingRoot):
2:53 PM Changeset in webkit [55596] by dino@apple.com
  • 2 edits in trunk/LayoutTests

2010-03-05 Dean Jackson <​dino@apple.com>

No review.

Disabling animations/fill-mode-transform.html on Leopard
due to ​https://bugs.webkit.org/show_bug.cgi?id=35714

  • platform/mac-leopard/Skipped:
2:46 PM Changeset in webkit [55595] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-03-05 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Child clipping compositing layers don't show the blue debug color
​https://bugs.webkit.org/show_bug.cgi?id=35807

Set a layer owner on the GraphicsLayers created for clipping children,
so that they can get to the debug settings that give them the blue color.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateClippingLayers):
2:43 PM Changeset in webkit [55594] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-03-05 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

MobileMe movie page is missing playback controls
​https://bugs.webkit.org/show_bug.cgi?id=35805
<rdar://problem/7653169>

On pages with video or plug-ins, we run overlap tests to determine which layers
need to be composited. There was an ordering dependency bug in
RenderLayerCompositor::computeCompositingRequirements() that caused us to fail
to detect that a layer needed to be composited, resulting in page content
not being visible.

Specifically, layer->setHasCompositingDescendant() can change the answer
to needsToBeComposited(), when a layer has to clip compositing descendants.
So if we change setHasCompositingDescendant(), then we need to re-test
clipsCompositingDescendants() and add the layer to the overlap map if so.

Test: compositing/overflow/overflow-compositing-descendant.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2:17 PM Changeset in webkit [55593] by dumi@chromium.org
  • 23 edits
    9 adds in trunk

WebCore: Adding support for the optional creation callback that could be
passed to openDatabase().

Reviewed by Adam Barth.

Test: storage/open-database-creation-callback.html

​https://bugs.webkit.org/show_bug.cgi?id=34726

  • Android.jscbindings.mk
  • Android.v8bindings.mk
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/js/JSDatabaseCallback.cpp: Added.

(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):

  • bindings/js/JSDatabaseCallback.h: Added.

(WebCore::JSDatabaseCallback::create):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • bindings/v8/custom/V8DatabaseCallback.cpp: Added.

(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):

  • bindings/v8/custom/V8DatabaseCallback.h: Added.

(WebCore::V8DatabaseCallback::create):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/Database.cpp:

(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):

  • storage/Database.h:

(WebCore::Database::isNew):

  • storage/DatabaseCallback.h: Added.

(WebCore::DatabaseCallback::~DatabaseCallback):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):

  • workers/WorkerContext.h:

LayoutTests: Adding a test to test the creation callback passed to
openDatabase() and another one to make sure it is executed in the
correct world.

Reviewed by Adam Barth.

Also, fixing fast/frames/sandboxed-iframe-storage.html: calling
openDatabase() without at least 4 parameters should always fail,
because the database name, version, description and estimated size
are not optional according to the spec.

​https://bugs.webkit.org/show_bug.cgi?id=34726

  • fast/frames/resources/sandboxed-iframe-storage-allowed.html:
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-storage-expected.txt:
  • platform/qt/Skipped:
  • storage/open-database-creation-callback-expected.txt: Added.
  • storage/open-database-creation-callback.html: Added.
  • storage/open-database-creation-callback-isolated-world-expected.txt: Added.
  • storage/open-database-creation-callback-isolated-world.html: Added.
1:04 PM Changeset in webkit [55592] by cmarrin@apple.com
  • 13 edits in trunk

Fixed crash due to infinite recursion when viewing composited video on Windows
​https://bugs.webkit.org/show_bug.cgi?id=35798

10:33 AM Changeset in webkit [55591] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Update getComputedStyle results on Windows.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
10:26 AM Changeset in webkit [55590] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-03-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

[Chromium] Missing commas in WebCore.gypi file make building Geo unpossible.
​https://bugs.webkit.org/show_bug.cgi?id=35797

No new tests, this is a latent compile break.

  • WebCore.gypi:
10:12 AM Changeset in webkit [55589] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

2010-03-05 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, build fix.

Use a movie that will hopefully fail to open less often on a headless
SnowLeopard bot.

  • media/video-preload-expected.txt:
  • media/video-preload.html: Use test.mp4 instead of silence.mpg.
9:39 AM QtWebKitBugs edited by vestbo@webkit.org
(diff)
9:32 AM Changeset in webkit [55588] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-03-05 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, build fix.

media/video-preload.html fails on GTK, skip it.

  • platform/gtk/Skipped:
9:13 AM Changeset in webkit [55587] by eric.carlson@apple.com
  • 7 edits
    2 adds in trunk

2010-03-04 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/7718442> Implement 'preload=none'
​https://bugs.webkit.org/show_bug.cgi?id=35789

Don't load any media data when preload is 'none'.

Test: media/video-preload.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): Don't call player's setPreload method

when autoplay is set.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setPreload): Set m_preload so we have the correct value when

the media engine is created.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_preload. (WebCore::MediaPlayerPrivate::resumeLoad): New, kick off postponed a load. (WebCore::MediaPlayerPrivate::load): Do nothing if preload is 'none' (WebCore::MediaPlayerPrivate::loadInternal): New, complete loading. (WebCore::MediaPlayerPrivate::prepareToPlay): New, resume a postponed load as someone

has called play().

(WebCore::MediaPlayerPrivate::setPreload): New, set m_preload.

2010-03-04 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/7718442> Implement 'preload=none'
​https://bugs.webkit.org/show_bug.cgi?id=35789

Functional test of the 'proload' attribute.

  • media/video-preload-expected.txt: Added.
  • media/video-preload.html: Added.
  • platform/win/Skipped: Skip on Windows for now.
8:53 AM Changeset in webkit [55586] by Nate Chapin
  • 3 edits in trunk/WebCore

2010-03-04 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Give CodeGeneratorV8.pm a much-needed spring cleaning.

​https://bugs.webkit.org/show_bug.cgi?id=35697

  • bindings/scripts/CodeGeneratorV8.pm: Remove unused code, fix style issues, make less hard-coded.
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::addEventListenerCallback): (WebCore::V8DOMWindow::removeEventListenerCallback):
8:16 AM Changeset in webkit [55585] by tonikitoo@webkit.org
  • 5 edits in trunk

[Gtk] Implement setSpatialNavigationEnabled in DRT.
​https://bugs.webkit.org/show_bug.cgi?id=35705

Reviewed by Holger Freyther
Patch by Antonio Gomes <​tonikitoo@webkit.org>

WebKitTools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

LayoutTests:

  • platform/gtk/Skipped:
8:13 AM Changeset in webkit [55584] by pfeldman@chromium.org
  • 26 edits
    3 deletes in trunk

2010-03-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Roll back r55522 since it regreses performance
according to chromium's page cycler.

​https://bugs.webkit.org/show_bug.cgi?id=35568

8:07 AM Changeset in webkit [55583] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/gtk

[Gtk] Add 'enable-spatial-navigation' setting for Spatial Navigation on/off.
​https://bugs.webkit.org/show_bug.cgi?id=35701

Reviewed by Gustavo Noronha.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
(webkit_web_settings_copy):

  • webkit/webkitwebview.cpp:

(DNDContentsRequest::webkit_web_view_update_settings):
(DNDContentsRequest::webkit_web_view_settings_notify):

8:04 AM Changeset in webkit [55582] by tonikitoo@webkit.org
  • 6 edits in trunk/WebKitTools

Add toggle on/off stub methods for Spatial Navigation in win, gtk and mac LayoutTestController class implementations.
​https://bugs.webkit.org/show_bug.cgi?id=35699

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • DumpRenderTree/LayoutTestController.cpp:

(setSpatialNavigationEnabledCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setSpatialNavigationEnabled):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

8:01 AM Changeset in webkit [55581] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] Add toggle on/off mechanism for Spatial Navigation in QtLauncher.

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • QtLauncher/main.cpp:

(LauncherWindow::toggleSpatialNavigation):
(LauncherWindow::setupUI):

7:58 AM Changeset in webkit [55580] by tonikitoo@webkit.org
  • 5 edits in trunk

[Qt] Add setSpatialNavigationEnabled method DRT
​https://bugs.webkit.org/show_bug.cgi?id=33715

Reviewed by Simon Hausmann.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Added setSpatialNavigationEnabled support to Qt DRT.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::WebPage):
(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

Unskipped fast/events/spatial-navigation/

7:49 AM Changeset in webkit [55579] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] QWebSettings attribute for toggle Spatial Navigation on/off
​https://bugs.webkit.org/show_bug.cgi?id=33714 (Qt API part)

Reviewed by Simon Hausmann.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Added 'SpatialNavigationEnabled' attribute to QWebSettings.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

  • Api/qwebsettings.h:
7:48 AM Changeset in webkit [55578] by tonikitoo@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Extend keyboard navigation to allow directional navigation (LayoutTests - part II)
​https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

This patch adds two LayoutTest to ensure the basic table traversal correctness of
Spatial Navigation (SNav) algorithm: focusable elements in a <table> should be accessible.

  • fast/events/spatial-navigation/snav-table-traversal.html: Added. Makes sure all elements in a <table> are accessible via Spatial Navigation.
  • fast/events/spatial-navigation/snav-tiny-table-traversal.html: Added. Tests the similar table traversal scenario as above, but in this case the elements in the <table> are styled with 'font-size: small'. That way this test also validades that overlapping rects of elements too closed from each other are correctly handled.
7:46 AM Changeset in webkit [55577] by tonikitoo@webkit.org
  • 5 edits
    3 adds in trunk/LayoutTests

Extend keyboard navigation to allow directional navigation (LayoutTests - part I)
​https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

This patch adds support for auto testing the Spatial Navigation feature by:

1) Creating the directory where the tests are going to live in, named

fast/events/spatial-navigation/.

2) Skipping this directory by Mac, Qt, Gtk and Win.
3) Adding a JS file drives the test execution by processing, for each test,

a given set of arrow key actions and verify if the right expected Element
got the focus after each event processed. This file is
fast/events/spatial-navigation/resources/spatial-navigation-utils.js

  • LayoutTests/fast/events/spatial-navigation/snav-vertical-superprecedence.html: Added.
7:42 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:31 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:31 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:30 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:28 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:27 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:23 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:23 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:22 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:17 AM QtWebKit edited by Simon Hausmann
(diff)
7:11 AM QtWebKitBugs edited by vestbo@webkit.org
(diff)
6:06 AM QtWebKit edited by Simon Hausmann
(diff)
6:06 AM QtWebKit edited by Simon Hausmann
(diff)
4:58 AM Changeset in webkit [55576] by dino@apple.com
  • 25 edits
    6 adds in trunk

2010-03-05 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser and Chris Marrin.

Bug 26869: Add fill modes for CSS Animations
​https://bugs.webkit.org/show_bug.cgi?id=26869

Tests: animations/fill-mode-removed.html

animations/fill-mode-transform.html
animations/fill-mode.html

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSParser.cpp:
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/CSSValueKeywords.in:
    • parse, assign and retrieve the value of the new -webkit-animation-fill-mode property
  • page/animation/AnimationBase.cpp:
  • page/animation/AnimationBase.h:
    • new state in animation engine for a finished animation that is "filling" forwards in time. This allows the engine to keep the animation around and not revert to the old style.
    • update the timer code to indicate it doesn't need to keep animating if it is filling
    • now that animations can extend beyond their elapsed time, make sure progress works correctly with iteration counts
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate):
    • ensure correct style value is returned at the right time by checking for fill mode

(WebCore::KeyframeAnimation::onAnimationEnd):

  • continue to send the end event, but only remove the animation if it isn't filling forwards
  • platform/animation/Animation.cpp:
  • platform/animation/Animation.h:
    • new fill mode member property
  • platform/animation/AnimationList.cpp:
    • ensure the fill mode is propagated to a list of style valus
  • platform/graphics/mac/GraphicsLayerCA.mm:
    • make hardware layers use Core Animation's fill mode
2:09 AM Changeset in webkit [55575] by pfeldman@chromium.org
  • 8 edits in trunk

2010-03-05 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Do not show link helper in popovers and/or for external resources.

​https://bugs.webkit.org/show_bug.cgi?id=35785

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptOrResourceForURLAndLine):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.hide):
  • inspector/front-end/inspector.js: (WebInspector.documentMouseOver): (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.addMainEventListeners):
1:51 AM Changeset in webkit [55574] by ukai@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-03-05 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket test to transfer null character
​https://bugs.webkit.org/show_bug.cgi?id=35715

  • websocket/tests/null-character-expected.txt: Added.
  • websocket/tests/null-character.html: Added.
  • websocket/tests/script-tests/null-character.js: Added.
1:35 AM Changeset in webkit [55573] by ukai@chromium.org
  • 7 edits
    4 adds in trunk

2010-03-05 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket onmessageerror event handler
​https://bugs.webkit.org/show_bug.cgi?id=35570

  • websocket/tests/error-detect-expected.txt: Added.
  • websocket/tests/error-detect.html: Added.
  • websocket/tests/script-tests/error-detect.js: Added.
  • websocket/tests/unknown-frame-type_wsh.py: Added.

2010-03-05 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket onmessageerror event handler
​https://bugs.webkit.org/show_bug.cgi?id=35570

Test: websocket/tests/error-detect.html

  • websockets/WebSocket.cpp: (WebCore::WebSocketChannel::didConnect): assert scriptExecutionContext. (WebCore::WebSocketChannel::didReceiveMessage): assert scriptExecutionContext. (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didClose): assert scriptExecutionContext.
  • websockets/WebSocket.h:
  • websockets/WebSocket.idl: Add onerror event listener
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData): call didReceiveMessageError if unknown frame tye is detected, or frame length overflowed.
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didReceiveMessageError):
Note: See TracTimeline for information about the timeline view.