Timeline
Apr 2, 2010:
- 11:15 PM Changeset in webkit [57044] by
-
- 2 edits in trunk/LayoutTests
2010-04-02 Adam Barth <abarth@webkit.org>
Unreviewed.
REGRESSION(56394): http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html fails on Tiger
https://bugs.webkit.org/show_bug.cgi?id=36934
Attempt Alexey's solution of using a non-sniffable MIME type.
- http/tests/xmlhttprequest/resources/download-with-delay.php:
- 10:49 PM Changeset in webkit [57043] by
-
- 2 edits in trunk/LayoutTests
2010-04-02 Adam Barth <abarth@webkit.org>
Unreviewed. Disabled fast/workers/worker-terminate.html because it
randomly fails about 25% of the time.
- platform/mac/Skipped:
- 9:48 PM Changeset in webkit [57042] by
-
- 3 edits2 adds in trunk/LayoutTests
2010-04-02 Darin Fisher <darin@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36647
Make replacestate-in-frame.html less insane and hopefully no longer flaky.
- fast/loader/stateobjects/replacestate-in-iframe-expected.txt:
- fast/loader/stateobjects/replacestate-in-iframe.html:
- fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html: Added.
- fast/loader/stateobjects/resources/replacestate-in-iframe-window.html: Added.
- 9:20 PM Changeset in webkit [57041] by
-
- 3 edits9 adds in trunk
2010-04-02 Justin Schuh <jschuh@chromium.org>
Reviewed by Alexey Proskuryakov.
XHR allows arbitrary XSRF across domains
https://bugs.webkit.org/show_bug.cgi?id=36843
Added a one-line change to prevent bypassing the XDC check on
synchronous preflighted requests. Added layout tests to cover
variations of this problem.
- http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html: Added.
- http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html: Added.
- http/tests/xmlhttprequest/access-control-preflight-sync-header-denied-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html: Added.
- http/tests/xmlhttprequest/access-control-preflight-sync-method-denied-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html: Added.
- http/tests/xmlhttprequest/resources/access-control-preflight-denied-xsrf.php: Added.
2010-04-02 Justin Schuh <jschuh@chromium.org>
Reviewed by Alexey Proskuryakov.
XHR allows arbitrary XSRF across domains
https://bugs.webkit.org/show_bug.cgi?id=36843
Added a one-line change to prevent bypassing the XDC check on
synchronous preflighted requests. Added layout tests to cover
variations of this problem.
Tests: http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html
http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html
http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html
http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::preflightFailure):
- 9:09 PM Changeset in webkit [57040] by
-
- 4 edits in trunk/WebKitTools
2010-04-02 Adam Barth <abarth@webkit.org>
Unreviewed.
Have Eric and Adam watch the SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=37054
- Scripts/webkitpy/tool/bot/sheriff.py:
- Scripts/webkitpy/tool/bot/sheriff_unittest.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- 6:05 PM Changeset in webkit [57039] by
-
- 3 edits in trunk/WebCore
2010-04-02 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Very bad scrolling-performance with the Trackpad at http://www.apple.com/ipad/app-store/
https://bugs.webkit.org/show_bug.cgi?id=36978
When we update compositing layers (which can happen on scrolling, when there are fixed position elements
on the page), we can end up redundantly setting images as layer contents if we have to color-correct
the image. This is because we call CGImageCreateCopyWithColorSpace(), which hands back a new image
every time.
Avoid this by storing a reference to the original uncorrected image, which is used to then
avoid work if the image does not change.
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):
- 6:03 PM Changeset in webkit [57038] by
-
- 5 edits in trunk/WebCore
2010-04-02 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Eric Seidel.
Fix for WML enabled build failure.
- wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::disabled):
- wml/WMLOptionElement.h:
- wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::listBoxSelectItem):
- wml/WMLSelectElement.h:
- 5:38 PM Changeset in webkit [57037] by
-
- 2 edits in trunk/WebCore
2010-04-02 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=37011
Position::primaryDirection() should not use its own accessor.
No new tests. This is small clenaup with no behaviour change.
- dom/Position.cpp: (WebCore::Position::primaryDirection):
- 5:16 PM Changeset in webkit [57036] by
-
- 2 edits in trunk/WebCore
2010-04-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by Brady Eidson.
window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5. This is caused by a SecurityOrigin pointer comparison that I should have switched to be a hash comparison in r56293 [bug 34991].
https://bugs.webkit.org/show_bug.cgi?id=36671
No new tests. Requires testing on Safari on Windows.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Convert a pointer comparison to use SecurityOriginHash::hash() instead, and move it to the end of the clause for speed in the easy-out case.
- 5:14 PM Changeset in webkit [57035] by
-
- 4 edits in trunk/WebKitTools
2010-04-02 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
commit-queue should ignore builders when landing rollouts
https://bugs.webkit.org/show_bug.cgi?id=37051
When we moved the "builders are red" check into the master process, we
forgot about rollouts. I thought we had a test covering this case, but
looking at the test, it was a bit too loose. I added a new test and
introduced some new logging technology into MockTool to make the test
tighter.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 5:06 PM Changeset in webkit [57034] by
-
- 6 edits in trunk
2010-04-02 Michael Nordman <Michael Nordman>
Reviewed by Nate Chapin.
Set the close policy used by the DatabaseCloseTask in a constructor argument
instead of hard coding it.
https://bugs.webkit.org/show_bug.cgi?id=37037
No new tests, new new functionality.
- storage/Database.cpp: This callsite passes in DoNotRemoveFromDatabaseContext to retain its current behavior. (WebCore::Database::markAsDeletedAndClose):
- storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::DatabaseCloseTask): (WebCore::DatabaseCloseTask::doPerformTask):
- storage/DatabaseTask.h: (WebCore::DatabaseCloseTask::create):
2010-04-02 Michael Nordman <Michael Nordman>
Reviewed by Nate Chapin.
Set the close policy used by the DatabaseCloseTask at this callsite to
RemoveDatabaseFromContext. This restores its behavior to what it was prior to
r56293.
https://bugs.webkit.org/show_bug.cgi?id=37037
- src/WebDatabase.cpp: (WebKit::WebDatabase::closeDatabaseImmediately):
- 4:52 PM Changeset in webkit [57033] by
-
- 2 edits in trunk/WebCore
2010-04-02 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Remove an ASSERT that sometimes flakes due to time dependent animations
https://bugs.webkit.org/show_bug.cgi?id=37048
The outline repaint rectangle for a layer might change between two calls
if there are animations involved, even if nothing in the DOM has actually
changed between the calls.
No change in behavior, no new tests.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
- 4:45 PM Changeset in webkit [57032] by
-
- 1 edit2 adds in trunk/WebCore
2010-04-02 Evan Stade <estade@chromium.org>
Reviewed by Adam Barth.
[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811
Add two files that failed to get added in my previous patch.
- platform/chromium/DragImageChromiumMac.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
- platform/chromium/DragImageChromiumSkia.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
- 4:30 PM Changeset in webkit [57031] by
-
- 12 edits in trunk
2010-04-02 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Configure multi-language movies: when QuickTime has sufficiently loaded
the movie, call into wkQTMovieSelectPreferredAlternates to select the
movie's alternate tracks according to the user's language preferences.
- WebCore.base.exp:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): If the movie is sufficiently loaded, call wkQTMovieSelectPreferredAlternates to set up the alternate tracks.
- platform/mac/WebCoreSystemInterface.h: Declare WKQTMovieSelectPreferredAlternates.
- platform/mac/WebCoreSystemInterface.mm: Add WKQTMovieSelectPreferredAlternates.
2010-04-02 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Update WebKitSystemInterface
- WebKitSystemInterface.h: add WKQTMovieSelectPreferredAlternates.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
2010-04-02 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
https://bugs.webkit.org/show_bug.cgi?id=36624
Add an INIT macro for the WebKitSystemInterface function wkQTMovieSelectPreferredAlternates.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
- 4:21 PM Changeset in webkit [57030] by
-
- 3 edits in trunk/WebCore
2010-04-02 James Robinson <jamesr@chromium.org>
Reviewed by Darin Adler.
Splits RenderBlock::layoutInline into smaller functions
https://bugs.webkit.org/show_bug.cgi?id=36921
RenderBlock::layoutInlineChildren is 351 lines long and very difficult
to comprehend or edit safely. This patch splits it up into a few
slightly smaller functions. Most of the code is now in the 241 line
layoutRunsAndFloats() which is a slight improvement.
Perf neutral on the page cyclers. This doesn't introduce any function
calls into the hottest layout paths inside layoutRunsAndFloats and
findNextLineBreak.
No change in behavior, no new tests.
- rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutReplacedElements): (WebCore::RenderBlock::createLineBoxesForResolver): (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::layoutInlineChildren):
- 3:57 PM Changeset in webkit [57029] by
-
- 2 edits in trunk/WebKit/qt
2010-04-02 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [Symbian] Rebaseline Symbian def file
https://bugs.webkit.org/show_bug.cgi?id=37038
Switch the ordinal numbers for qtwebkit_webframe_scrollRecursively
and QWebInspector::closeEvent to match QtWebkit 4.6 branch
Fix the signature for qt_drt_setFrameFlatteningEnabled
after r56718.
Add new QtWebKit API symbols introduced not listed in the file yet.
- symbian/eabi/QtWebKitu.def:
- 3:48 PM Changeset in webkit [57028] by
-
- 9 edits1 delete in trunk
2010-04-02 Evan Stade <estade@chromium.org>
Reviewed by Eric Seidel.
[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811
Basic implementation using SkBitmap. Transformations are not supported
yet. No implementation for mac.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/DragImageChromium.cpp:
- platform/chromium/DragImageRef.h:
2010-04-02 Evan Stade <estade@chromium.org>
Reviewed by Eric Seidel.
[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811
Use the DragImageRef that the DragController passes to us.
- public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
- src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
- src/WebViewImpl.h:
- 3:23 PM Changeset in webkit [57027] by
-
- 2 edits in trunk/WebCore
2010-04-02 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] font fallback for generic fonts picks wrong font
https://bugs.webkit.org/show_bug.cgi?id=37033
When a page specifies the generic "monospace" font and the user's
browser-configured monospace font doesn't exist, we previously relied
on getLastResortFallbackFont to eventually pick a monospace font for us.
But that doesn't quite work: WebKit first falls back to the user's
"preferred standard font" before hitting the last resort code path.
So if the above conditions hold but this font exists, we'll end up
never hitting the last resort codepath.
The fix is to allow OS-level font fallback when first attempting to
resolve monospace. The existing code tried to do this, but the logic
was wrong. We would eventually fall back to the correct font anyway
so we didn't notice the logic was wrong.
This code is all handling cases where particular fonts aren't installed,
so I can't think of a way to test it; existing tests should still pass.
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
- 3:13 PM Changeset in webkit [57026] by
-
- 6 edits in trunk/WebKit
2010-04-02 Rafael Weinstein <rafaelw@chromium.org>
Reviewed by Adam Barth.
Clean up unused calls after changes to checkPermission and requestPermission argument lists.
- public/WebNotificationPresenter.h:
- src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission): (WebKit::NotificationPresenterImpl::requestPermission):
2010-04-02 Rafael Weinstein <rafaelw@chromium.org>
Reviewed by Adam Barth.
Clean up unused calls after changes to checkPermission and requestPermission argument lists.
- WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::requestPermission):
- WebCoreSupport/WebDesktopNotificationsDelegate.h:
- 2:53 PM Changeset in webkit [57025] by
-
- 3 edits in trunk/JavaScriptCore
2010-04-02 Ruben Van Boxem <vanboxem.ruben@gmail.com>
Reviewed by Eric Seidel.
Mingw-w64 fixes for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=35607
- runtime/Collector.cpp: use the msvc code for mingw-w64 (but not mingw-w32) (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr): (JSC::currentThreadStackBase): (JSC::currentThreadStackBase):
- wtf/Platform.h: added COMPILER(MINGW64) check to differentiate between mingw.org and mingw-w64 functions
- 2:21 PM Changeset in webkit [57024] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37043
Java regression tests spam stderr about being unable to set status message
With this change, there is still spam about "Attempt to access JavaScript from destroyed
applet, type 9." I haven't investigated if that indicates a problem or not.
- Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]): Removed check for _documentView. We don't seem to care.
- 2:18 PM Changeset in webkit [57023] by
-
- 6 edits2 adds in trunk
2010-04-02 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson and Eric Seidel.
Don't stop the playback event timer when media resource loading has suspended.
https://bugs.webkit.org/show_bug.cgi?id=37003
When a user agent decides to suspend media resource loading and enters the
NETWORK_IDLE state we are supposed to only stop the progress event timer but
keep the playback timer running.
Test: http/tests/media/video-play-suspend.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Only stop the progress event timer.
2010-04-02 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson and Eric Seidel.
Don't stop the playback event timer when media resource loading has suspended.
https://bugs.webkit.org/show_bug.cgi?id=37003
When a user agent decides to suspend media resource loading and enters the
NETWORK_IDLE state we are supposed to only stop the progress event timer but
keep the playback timer running.
Currently Chromium is the only platform that fires the suspend event
hence most platforms skipping this test.
- http/tests/media/video-play-suspend-expected.txt: Added.
- http/tests/media/video-play-suspend.html: Added.
- platform/gtk/Skipped: Doesn't fire a suspend event.
- platform/mac/Skipped: Ditto.
- platform/win/Skipped: Ditto.
- 2:01 PM Changeset in webkit [57022] by
-
- 3 edits in trunk/WebCore
Fix mispelling that broke the build.
- html/canvas/CanvasRenderingContext2D.cpp:
- html/canvas/CanvasRenderingContext2D.h:
Dashbard -> Dashboard.
- 1:40 PM Changeset in webkit [57021] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: updated the .def file.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:31 PM Changeset in webkit [57020] by
-
- 10 edits in trunk
(non-generated) code should only use CanvasRenderingContext::canvas as a CanvasSurface.
https://bugs.webkit.org/show_bug.cgi?id=36906
Reviewed by Darin Adler.
WebCore:
- dom/CanvasSurface.cpp: Added methods for items that depended on
CanvasRenderingContext::canvas() being an HTMLElement(), so that this usage
can be dealt with in one place.
(WebCore::CanvasSurface::securityOrigin): Only used by methods that are
only run in the document context.
(WebCore::CanvasSurface::renderBox): Will likely return 0 in a worker context.
(WebCore::CanvasSurface::computedStyle): Used by setFont. Return value is TBD for
the worker context.
(WebCore::CanvasSurface::styleSelector): Ditto.
- dom/CanvasSurface.h:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext): Passing in information into
the CanvasRenderingContext2D constructor to eliminate some uses of document
inside of the CanvasRenderingContext2D class.
- html/HTMLCanvasElement.h:
(WebCore::HTMLCanvasElement::renderBox): Added to disambiguate between the
two parent class versions of the method.
(WebCore::HTMLCanvasElement::computedStyle): Ditto.
- html/canvas/CanvasRenderingContext2D.cpp: All of these changes are about
removing document usage either by using a bool that is set in the constructor or
by calling one of the new methods added to CanvasSurface.
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode):
(WebCore::CanvasRenderingContext2D::checkOrigin):
(WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/WebGLRenderingContext.cpp: Removed some duplicate includes.
(WebCore::WebGLRenderingContext::markContextChanged): Reduced calls to renderBox
as it may become slightly more expensive in the future.
(WebCore::WebGLRenderingContext::reshape): Ditto.
LayoutTests:
- fast/canvas/script-tests/canvas-gradient-addStop-error.js: Changed the test
to create a new canvas after switching to dashboard compatiblity mode, which is
needed now that the compatibility mode is cached in the canvas.
- 1:15 PM Changeset in webkit [57019] by
-
- 11 edits in trunk/JavaScriptCore
Inlined toThisString and toThisJSString to avoid virtual function call overhead
https://bugs.webkit.org/show_bug.cgi?id=37039
Reviewed by Oliver Hunt.
Maybe a 1% speedup on iBench JS.
- JavaScriptCore.exp: New exports.
- runtime/JSCell.cpp:
- runtime/JSCell.h:
- runtime/JSNumberCell.cpp:
- runtime/JSNumberCell.h:
- runtime/JSString.cpp:
- runtime/JSString.h:
- runtime/JSValue.h:
- runtime/JSZombie.h:
(JSC::JSZombie::toThisObject): Nixed the old virtual-type implementation.
- runtime/JSObject.h:
(JSC::JSValue::toThisString):
(JSC::JSValue::toThisJSString): Added the inlined implementation.
- 1:03 PM Changeset in webkit [57018] by
-
- 14 edits2 adds in trunk
2010-04-02 Zhenyao Mo <zmo@google.com>
Reviewed by Eric Seidel.
Implement and test new framebuffer object attachment behavior.
https://bugs.webkit.org/show_bug.cgi?id=35611
- fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added, test framebuffer object attachment behavior.
- fast/canvas/webgl/framebuffer-object-attachment.html: Added, framebuffer object attachment behavior.
- fast/canvas/webgl/script-tests/gl-object-get-calls.js: DEPTH_COMPONENT is no longer a valid input, use DEPTH_COMPONENT16 instead.
- platform/mac-snowleopard/Skipped: The bot does not support EXT_packed_depth_stencil, skip the framebuffer-object-attachment.html test.
2010-04-02 Zhenyao Mo <zmo@google.com>
Reviewed by Eric Seidel.
Implement and test new framebuffer object attachment behavior.
https://bugs.webkit.org/show_bug.cgi?id=35611
Test: fast/canvas/webgl/framebuffer-object-attachment.html
- html/canvas/WebGLFramebuffer.cpp: Keep track of attached stencil/depth renderbuffers in WebGLFramebuffer. (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::setIsAttached):
- html/canvas/WebGLFramebuffer.h: Ditto. (WebCore::WebGLFramebuffer::isDepthAttached): (WebCore::WebGLFramebuffer::isStencilAttached): (WebCore::WebGLFramebuffer::isDepthStencilAttached):
- html/canvas/WebGLRenderbuffer.cpp: Keep track of internalformat. (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
- html/canvas/WebGLRenderbuffer.h: Ditto. (WebCore::WebGLRenderbuffer::setInternalformat): (WebCore::WebGLRenderbuffer::getInternalformat):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Detect stencil/depth buffer conflicts. (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Handling DEPTH_STENCIL case. (WebCore::WebGLRenderingContext::getRenderbufferParameter): Get correct WebGL internalformat. (WebCore::WebGLRenderingContext::renderbufferStorage): Detect illegal enums.
- html/canvas/WebGLRenderingContext.idl: Add DEPTH_STENCIL enums.
- platform/graphics/GraphicsContext3D.h: Add DEPTH_STENCIL enums. (WebCore::GraphicsContext3D::):
- platform/graphics/mac/GraphicsContext3DMac.cpp: Map to correct DEPTH_STENCIL format. (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
2010-04-02 Zhenyao Mo <zmo@google.com>
Reviewed by Eric Seidel.
Implement and test new framebuffer object attachment behavior.
https://bugs.webkit.org/show_bug.cgi?id=35611
Test: fast/canvas/webgl/framebuffer-object-attachment.html
- src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format. (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv): (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage):
- 12:55 PM Changeset in webkit [57017] by
-
- 2 edits in trunk/WebKit/qt
Stored focused frame and document in a vars, instead of querying for them many times.
Reviewed by Adam Treat.
Patch by Antonio Gomes <tonikitoo@webkit.org>
- Api/qwebpage.cpp:
(QWebPagePrivate::mousePressEvent(QEvent* ev)):
(QWebPagePrivate::mousePressEvent(QGraphicsSceneMouseEvent* ev):
- 12:51 PM Changeset in webkit [57016] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-02 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Geoffrey Garen.
Beef up documentation for ASSERT* and CRASH macros a bit.
- wtf/Assertions.h:
- 12:21 PM Changeset in webkit [57015] by
-
- 3 edits in trunk/LayoutTests
2010-04-02 Zhenyao Mo <zmo@google.com>
Reviewed by Eric Seidel.
fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=36908
- fast/canvas/webgl/index-validation-expected.txt: Gathering more information about the cause of the failure. It's not a fix, and it won't worse change the current test behavior either, i.e., it won't make it better or worse.
- fast/canvas/webgl/script-tests/index-validation.js: Ditto.
- 12:11 PM Changeset in webkit [57014] by
-
- 4 edits1 add in trunk/WebKit/chromium
2010-04-02 Jay Civelli <jcivelli@chromium.org>
Reviewed by Darin Fisher.
The popup type (select or suggestion) is now passed to the
WebClient::createPopupMenu() method. This is required for
Chromium on Linux to make the select popups work correctly.
https://bugs.webkit.org/show_bug.cgi?id=37013
- WebKit.gyp:
- public/WebPopupType.h: Added. (WebKit::):
- public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
- src/ChromeClientImpl.cpp: (WebCore::convertPopupType): (WebKit::ChromeClientImpl::popupOpened):
- 12:09 PM Changeset in webkit [57013] by
-
- 5 edits2 adds in trunk
2010-04-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Form control state shouldn't be restored for hidden inputs.
https://bugs.webkit.org/show_bug.cgi?id=26241
- fast/forms/button-state-restore.html: Updated for the behavior change.
- fast/forms/state-restore-to-non-edited-controls-expected.txt: Added.
- fast/forms/state-restore-to-non-edited-controls.html: Added.
2010-04-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Form control state shouldn't be restored for hidden inputs.
https://bugs.webkit.org/show_bug.cgi?id=26241
To fix this issue, we don't save values if it is not changed from
the default value.
Updating the value IDL attribute of some controls such as
type=hidden also updates the value content attribute, and it's
impossible to distinguish the initial value and the current
value. The values of such controls are not saved. It won't be a
problem because we want to save and restore user-edited values.
Test: fast/forms/state-restore-to-non-edited-controls.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::saveFormControlState): Do not save the value if it is same as the default value.
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::saveFormControlState): ditto.
- 11:31 AM Changeset in webkit [57012] by
-
- 7 edits2 adds in trunk
2010-04-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Forms with autocomplete=off should not consume saved state
https://bugs.webkit.org/show_bug.cgi?id=36762
- fast/forms/state-restore-to-non-autocomplete-form-expected.txt: Added.
- fast/forms/state-restore-to-non-autocomplete-form.html: Added.
2010-04-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Forms with autocomplete=off should not consume saved state
https://bugs.webkit.org/show_bug.cgi?id=36762
Introduce Element::shouldSaveAndRestoreFormControlState() to check
if we should save and restore control state.
Test: fast/forms/state-restore-to-non-autocomplete-form.html
- dom/Document.cpp: (WebCore::Document::formElementsState): Check shouldSaveAndRestoreFormControlState().
- dom/Element.h: (WebCore::Element::shouldSaveAndRestoreFormControlState): Added. It just returns true.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::autoComplete): Added. It return autocomplete state of the form. (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): Added. It returns the result of autoComplete(). (WebCore::HTMLFormControlElementWithState::finishParsingChildren): Do not restore state if shouldSaveAndRestoreFormControlState() is false.
- html/HTMLFormControlElement.h: Declare autoComplete() and overriding methods.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::autoComplete): Reduce code by using autoComplete() of the parent class. (WebCore::HTMLInputElement::saveFormControlState): Remove the autoComplete() check. Document::formElementsState() does equivalent check.
- 11:03 AM Changeset in webkit [57011] by
-
- 4 edits in trunk/WebKitTools
sherrifbot should ensure that the rollout reason doesn't start with - (and fix webkit-patch upload).
https://bugs.webkit.org/show_bug.cgi?id=37030
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/bot/sheriff.py: Ensure that the rollout reason doesn't start with -.
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: A test with a rollout reason which starts with -.
- Scripts/webkitpy/tool/steps/createbug.py: Fix webkit-patch upload.
- 10:41 AM Changeset in webkit [57010] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Fixed check-webkit-style to recognize the short form of the
--verbose option, as stated in --help.
- Scripts/check-webkit-style:
- Tweaked one line.
- 10:40 AM Changeset in webkit [57009] by
-
- 3 edits in trunk/WebCore
2010-04-02 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Avoid doing work in FrameView::scrollPositionChanged() if there are no fixed position elements
https://bugs.webkit.org/show_bug.cgi?id=36994
r55890 added knowledge to FrameView about whether it contains any fixed-position elements. We can
use this to avoid updating widget positions, and compositing layer positions when possible.
- page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged):
- page/FrameView.h: (WebCore::FrameView::hasFixedObjects):
- 10:33 AM Changeset in webkit [57008] by
-
- 2 edits in trunk/WebCore
2010-04-02 Nate Chapin <Nate Chapin>
Rubber-stamped by Dimitri Glazkov.
http://trac.webkit.org/changeset/57004 caused
fast/dom/console-log-stack-overflow.html to fail for Chromium.
Add check for empty wrappers before using them to create a hidden reference.
- bindings/scripts/CodeGeneratorV8.pm:
- 10:24 AM Changeset in webkit [57007] by
-
- 2 edits in trunk/LayoutTests
2010-04-02 Dirk Schulze <krit@webkit.org>
Unreviewed.
[Gtk] LayoutTest feColorMatrix-value with different results over Gtk bots
https://bugs.webkit.org/show_bug.cgi?id=37029
Adding svg/filters/feColorMatrix-values.svg to the Gtk skip list. Opened
the bug report from above.
- platform/gtk/Skipped:
- 10:01 AM Changeset in webkit [57006] by
-
- 1 edit1 add in trunk/LayoutTests
2010-04-02 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Incorrect insertion position after typing 'ำ' (THAI CHARACTER SARA AM = 0E33)
https://bugs.webkit.org/show_bug.cgi?id=36858
Add failing results for Tiger to make the Tiger bot green.
We may wish to actually fix Tiger at some point.
- platform/mac-tiger/fast/text/multiglyph-characters-expected.txt: Added.
- 9:45 AM Changeset in webkit [57005] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix for DumpRenderTree after addition of layerTreeAsText.
- 9:40 AM Changeset in webkit [57004] by
-
- 14 edits4 deletes in trunk/WebCore
2010-04-01 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Generalize (and generate!) the creation of hidden references
between JS wrappers.
- Android.v8bindings.mk:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm: Generate calls to setHiddenReference() in attribute getters.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenReference): Split common logic out of hidden setHiddenWindowReference (WebCore::V8DOMWrapper::setHiddenWindowReference): Now contains logic specific to putting a hidden reference on a global object. (WebCore::globalObjectPrototypeIsDOMWindow): Be more thorough in the COMPILE_ASSERTs. (WebCore::V8DOMWrapper::convertEventTargetToV8Object): Cleanup: Remove a duplicate if statement.
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/WrapperTypeInfo.h:
- bindings/v8/custom/V8BarInfoCustom.cpp: Removed.
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp: (WebCore::toV8):
- bindings/v8/custom/V8DOMSelectionCustom.cpp: Removed.
- bindings/v8/custom/V8HistoryCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::toV8):
- bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
- bindings/v8/custom/V8ScreenCustom.cpp: Removed.
- bindings/v8/custom/V8StyleSheetCustom.cpp: (WebCore::toV8):
- loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::frame): Add frame() accessor.
- 8:43 AM Changeset in webkit [57003] by
-
- 7 edits in trunk/WebCore
2010-04-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: start editing DOM and styles on click-and-pause (part 1).
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onattach): (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._handleClickAndPause): (WebInspector.ElementsTreeElement.prototype._startEditingTarget): (WebInspector.ElementsTreeElement.prototype._startEditingAttribute): (WebInspector.ElementsTreeElement.prototype._startEditingTextNode): (WebInspector.ElementsTreeElement.prototype._startEditingTagName): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick): (WebInspector.StylePropertiesSection.prototype._handleSelectorClick): (WebInspector.StylePropertiesSection.prototype._handleSelectorClickAndPause): (WebInspector.StylePropertiesSection.prototype._handleSelectorDoubleClick): (WebInspector.StylePropertiesSection.prototype._startEditingOnMouseEvent): (WebInspector.StylePropertyTreeElement.prototype.onattach): (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js:
- inspector/front-end/treeoutline.js: (TreeElement.prototype._attach): (TreeElement.treeElementMouseDown): (TreeElement.prototype.selectOnMouseDown):
- 8:07 AM Changeset in webkit [57002] by
-
- 2 edits in trunk/LayoutTests
2010-04-02 Darin Fisher <darin@chromium.org>
Add chromium suppression for http/tests/xhtmlmp since we do not support
this feature.
- platform/chromium/test_expectations.txt:
- 7:54 AM Changeset in webkit [57001] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-02 Laszlo Gombos <Laszlo Gombos>
Unreviewed, minor build fix.
Change the order of the member initialisation list
in constructor to match declaration order
- runtime/Collector.cpp: (JSC::Heap::Heap):
- 6:41 AM WebKit Team edited by
- (diff)
- 6:05 AM Changeset in webkit [57000] by
-
- 2 edits in trunk/WebCore
2010-04-02 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix when building --no-svg.
Build fix after r56941. Add ENABLE(SVG) guard.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
- 5:55 AM Changeset in webkit [56999] by
-
- 14 edits1 copy1 add in trunk
2010-04-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Implement InspectorFrontendHost::showContextMenu for Chromium.
Move inspector frontend context menu code from InspectorFrontendClient to InspectorFrontendHost as it's platform independent.
- WebCore.Inspector.exp:
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
- inspector/InspectorFrontendClientLocal.h:
- inspector/InspectorFrontendHost.cpp: (WebCore::FrontendMenuProvider::create): (WebCore::FrontendMenuProvider::disconnect): (WebCore::FrontendMenuProvider::FrontendMenuProvider): (WebCore::FrontendMenuProvider::~FrontendMenuProvider): (WebCore::FrontendMenuProvider::populateContextMenu): (WebCore::FrontendMenuProvider::contextMenuItemSelected): (WebCore::FrontendMenuProvider::contextMenuCleared): (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::disconnectClient): (WebCore::InspectorFrontendHost::showContextMenu):
- inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::create):
2010-04-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Implement InspectorFrontendClient in Chromium and remove all custom bindings for the host methods from WebDevToolsFrontendImpl.
- WebKit.gyp:
- src/InspectorFrontendClientImpl.cpp: Added. (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl): (WebKit::InspectorFrontendClientImpl::~InspectorFrontendClientImpl): (WebKit::InspectorFrontendClientImpl::windowObjectCleared): (WebKit::InspectorFrontendClientImpl::frontendLoaded): (WebKit::InspectorFrontendClientImpl::moveWindowBy): (WebKit::InspectorFrontendClientImpl::localizedStringsURL): (WebKit::InspectorFrontendClientImpl::hiddenPanels): (WebKit::InspectorFrontendClientImpl::bringToFront): (WebKit::InspectorFrontendClientImpl::closeWindow): (WebKit::InspectorFrontendClientImpl::canAttachWindow): (WebKit::InspectorFrontendClientImpl::attachWindow): (WebKit::InspectorFrontendClientImpl::detachWindow): (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight): (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
- src/InspectorFrontendClientImpl.h: Added.
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
- src/WebDevToolsFrontendImpl.h:
- src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_):
- src/js/DevTools.js: ():
- 5:18 AM Changeset in webkit [56998] by
-
- 2 edits in trunk/LayoutTests
[Qt] http/tests/xmlhttprequest/access-control-response-with-body.html was introduced in r56955,
but it fails: "NETWORK_ERR: XMLHttpRequest Exception 101: A network error occured in synchronous requests."
- platform/qt/Skipped: http/tests/xmlhttprequest/access-control-response-with-body.html skipped.
- 5:17 AM Changeset in webkit [56997] by
-
- 4 edits in trunk/WebCore
2010-04-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Timeline Overview pane should support short records filtering.
https://bugs.webkit.org/show_bug.cgi?id=37020
- English.lproj/localizedStrings.js:
- inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.update.markTimeline): (WebInspector.TimelineOverviewPane.prototype.update):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelinePanel.FormattedRecord.prototype.isLong):
- 4:25 AM Changeset in webkit [56996] by
-
- 1 edit1 add in trunk/LayoutTests
[Qt] Platform specific expected file added for test introduced in r56775,
because it passes. Compared to png file and Mac expected file.
- platform/qt/svg/custom/animation-currentColor-expected.txt: Added.
- 3:10 AM Changeset in webkit [56995] by
-
- 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt
Unreviewed. Update the expectation for fast/dom/HTMLProgressElement/set-progress-properties.html
- 2:31 AM Changeset in webkit [56994] by
-
- 8 edits3 adds in trunk
2010-04-02 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Accept XHTML-MP content type as XHTML content
https://bugs.webkit.org/show_bug.cgi?id=34262
Add a simple test that fails if XHTML-MP mime
type is not accepted.
- http/conf/mime.types: Register XHTML-MP mime type with the test server
- http/tests/xhtmlmp: Added.
- http/tests/xhtmlmp/xhtml-expected.txt: Added.
- http/tests/xhtmlmp/xhtml.xhtmlmp: Added. Testcase with the newly registered file extension.
2010-04-02 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Accept XHTML-MP content type as XHTML content
https://bugs.webkit.org/show_bug.cgi?id=34262
Enable processing XHTML-MP mime type as an XHTML document
even if XHTML-MP support is not enabled.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):
2010-04-02 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Accept XHTML-MP content type as XHTML content
https://bugs.webkit.org/show_bug.cgi?id=34262
Register xhtmlmp file extension as the new type
for XHTML-MP test content.
- Scripts/run-webkit-tests:
- Scripts/webkitpy/layout_tests/layout_package/test_files.py:
- Scripts/webkitpy/layout_tests/port/lighttpd.conf:
- 2:20 AM Changeset in webkit [56993] by
-
- 3 edits in trunk/WebKitTools
2010-04-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
create-rollout doesn't fill out ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=37010
The contract between apply_reverse_diff and PrepareChangeLogForRevert
was unclear. I broke filling out the ChangeLog during rollout earlier
when I changed apply_reverse_diff to revert the ChangeLogs because
PrepareChangeLogForRevert thought that it was supposed to do that.
I've now taught PrepareChangeLogsForRevert the new contract.
It's unclear to me how to test this change because it's essentially an
integration issue that requires the file system. At some point we
should think about a testing strategy for integration. As the system
becomes larger, we're running into more of these issues.
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
- 2:10 AM Changeset in webkit [56992] by
-
- 4 edits in trunk/WebKitTools
2010-04-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add cr-win-ews to QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=37004
- QueueStatusServer/model/queues.py:
- QueueStatusServer/templates/dashboard.html:
- QueueStatusServer/templates/statusbubble.html:
- 2:00 AM Changeset in webkit [56991] by
-
- 7 edits1 add in trunk/WebCore
2010-04-02 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Make XSSAuditor go fast with large POST data
https://bugs.webkit.org/show_bug.cgi?id=36694
There were two things slowing down this bechmark:
1) Searching the large POST data for each inline event handler. To
make this faster, we now use a suffix tree to fast-reject strings
that don't appear as substrings of the POST data.
2) The next largest cost was flattening the form data into a string.
To make this fater, we now use the form data object itself as a key
and only flatten once.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): (WebCore::XSSAuditor::CachingURLCanonicalizer::clear): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h: (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): (WebCore::XSSAuditor::CachingURLCanonicalizer::generation):
- platform/text/SuffixTree.h: Added. (WebCore::UnicodeCodebook::codeWord): (WebCore::UnicodeCodebook::): (WebCore::ASCIICodebook::codeWord): (WebCore::ASCIICodebook::): (WebCore::SuffixTree::SuffixTree): (WebCore::SuffixTree::mightContain): (WebCore::SuffixTree::Node::Node): (WebCore::SuffixTree::Node::~Node): (WebCore::SuffixTree::Node::at): (WebCore::SuffixTree::build):
- 1:33 AM Changeset in webkit [56990] by
-
- 2 edits in trunk/LayoutTests
2010-04-02 Kent Tamura <tkent@chromium.org>
Unreviewed test fix. Follow the behavior change by r56962.
- editing/selection/4960137.html:
- 1:31 AM Changeset in webkit [56989] by
-
- 3 edits in trunk/WebCore
2010-04-02 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Eric Seidel.
Bug 36741 - Duplicate, slightly divergent implementation of Position[Iterator]::isCandidate()
https://bugs.webkit.org/show_bug.cgi?id=36741
Patch: change Position::isCandididate() to call the PositionIterator::isCandidate() version.
Update PositionIterator::isCandidate() to mirror Position::isCandidate().
Rationale: PositionIterator::isCandidate() is called in a tight loop within
next/previousCandidate(). Also, creation of a PositionIterator from a Position
is cheaper than vice-versa.
Tests: ran all tests in 'editing'.
- dom/Position.cpp: (WebCore::Position::isCandidate):
- dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
- 1:31 AM Changeset in webkit [56988] by
-
- 3 edits in trunk/WebKitTools
2010-04-02 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Unit-test networktransaction.py's log messages, and add a base
class to make unit-testing log messages even easier.
The purpose of this patch is also to provide a mini-tutorial on
how to unit-test Python logging.py messages.
- Scripts/webkitpy/common/net/networktransaction_unittest.py:
- Unit-tested the log messages in test_retry().
- Scripts/webkitpy/common/system/logtesting.py:
- Adjusted the LogTesting class by moving the code that clears the array of log messages into a finally block. This prevents redundant AssertionErrors from getting rendered to the screen while running unit tests.
- Added a LoggingTestCase class so the setUp() and tearDown() methods do not need to be implemented in order to test logging. Rather, TestCase classes can simply inherit from this class.
- 1:27 AM Changeset in webkit [56987] by
-
- 3 edits in trunk/WebKitTools
2010-04-02 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Re-wrote check-webkit-style's argument parsing code to use
Python's optparser module and more uniform error-handling logic.
- Scripts/webkitpy/style/optparser.py:
- Removed "option help" from check-webkit-style's usage string since that is provided separately by the OptionParser class.
- Also changed the usage string from a function to a constant string _USAGE.
- Added an _EPILOG string which renders after OptionParser's usage string and option help.
- In the ArgumentParser class:
- Changed the constructor's stderr_write parameter to a mock_stderr since the OptionParser accepts a sys.stderr substitute rather than a sys.stderr.write substitute.
- Changed the constructor to set a _parser data attribute with an OptionParser instance.
- Added a _create_option_parser() method which instantiates the OptionParser.
- Updated _exit_with_help() to interact with the OptionParser's help method.
- Updated the parse() method as necessary. Also changed the raising of ValueErrors to calls to _exit_with_help().
- Scripts/webkitpy/style/optparser_unittest.py:
- Removed the CreateUsageTest class since the create_usage method was replaced by a constant string.
- Added a _MockStdErr class to the ArgumentParserTest class.
- Updated the unit tests as necessary.
- 1:18 AM Changeset in webkit [56986] by
-
- 2 edits in trunk/WebKitTools
2010-04-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The master commit-queue process should take responsibility for checking that the builders are green
https://bugs.webkit.org/show_bug.cgi?id=37009
We had a failure where the child process noticed that the builders were
red. We've always had this race condition, but the new optimistic
design made it easier to trigger.
- Scripts/webkitpy/tool/commands/queues.py:
- 1:18 AM Changeset in webkit [56985] by
-
- 3 edits in trunk/WebKitTools
2010-04-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Tweak rollout changelog to pass ValidateReviewer check
https://bugs.webkit.org/show_bug.cgi?id=37019
We need to use the magic word "unreviewed" to make the commit-queue
happy when landing rollouts.
- Scripts/webkitpy/common/checkout/changelog.py:
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
- 1:16 AM Changeset in webkit [56984] by
-
- 2 edits in trunk/WebKit/qt
2010-04-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Eric Seidel.
[Qt]Fix compile error with QT_NO_SETTINGS
https://bugs.webkit.org/show_bug.cgi?id=36533
If QT_NO_SETTINGS is defined, QSettings is not available.
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): (WebCore::InspectorClientQt::storeSetting):
- 1:13 AM Changeset in webkit [56983] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Unreviewed.
Removed duplicate ChangeLog entry.
- 1:04 AM Changeset in webkit [56982] by
-
- 2 edits in trunk/LayoutTests
2010-04-02 Eric Seidel <eric@webkit.org>
Unreviewed, just updating expected results for passing tests.
suppress image failures for now to get a clean test run w/ pixel tests enabled for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=36620
Remove several tests marked MISSING which no longer seem to be missing.
- platform/mac/test_expectations.txt:
- 1:03 AM Changeset in webkit [56981] by
-
- 4 edits in trunk/WebKitTools
Rubber-stamped by Eric Seidel.
To the Python 2.4 error message, added a link to the wiki page
that contains instructions on how to upgrade.
- Scripts/test-webkitpy:
- Eliminated a use of the ternary operator in configure_logging() to let the version warning display in case of Python 2.4.
- Scripts/webkitpy/python24/versioning.py:
- Added this link to the error text: http://trac.webkit.org/wiki/PythonGuidelines
- Scripts/webkitpy/python24/versioning_unittest.py:
- Updated unit test text.
- 12:39 AM Changeset in webkit [56980] by
-
- 3 edits in trunk/WebKit/qt
2010-04-02 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Maemo5 theme - customized popup for <select multiple> elements
https://bugs.webkit.org/show_bug.cgi?id=36368
Using QtMaemoWebPopup instead of QtFallbackWebPopup for Maemo.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate):
- 12:30 AM Changeset in webkit [56979] by
-
- 3 edits in trunk/LayoutTests
2010-04-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION(56295): http/tests/security/xssAuditor/xss-protection-parsing-01.html times out on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=36933
Change the test design in an attempt to get this passing on Tiger. In
this variation, we use a POST request to work around possible caching
issues in Tiger's CFNetwork.
- http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-01.html:
- 12:25 AM Changeset in webkit [56978] by
-
- 2 edits in trunk/WebCore
Database code falsely returns errors due to errant pointer check
https://bugs.webkit.org/show_bug.cgi?id=37014
Reviewed by Dan Bernstein.
r56943 introduced a check to see if there were any unprocessed
SQL commands after calling sqlite3_prepare16_v2.
Accessing the remaining data via pointer wasn't possible since
the query string is deallocated immediately after the
query runs. The String returned from strippedWhiteSpace
goes out of scope at that point.
Fix is to store the strippedWhiteSpace in a temporary String
so we can access it via character ptr later in the function.
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
- 12:14 AM Changeset in webkit [56977] by
-
- 5 edits in trunk/WebKitTools
2010-04-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Record the IRC nick of folks who request rollouts
https://bugs.webkit.org/show_bug.cgi?id=36999
- Scripts/webkitpy/common/net/irc/ircbot.py:
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/sheriffircbot.py:
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
- 12:04 AM Changeset in webkit [56976] by
-
- 3 edits in trunk/WebKitTools
2010-04-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add cr-win-ews
https://bugs.webkit.org/show_bug.cgi?id=36974
Adds support for an Early Warning System for Chromium on Linux. The
interface to the Chromium port is the same on every platform, so we
don't need to create a new Port object for this queue.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Apr 1, 2010:
- 11:44 PM Changeset in webkit [56975] by
-
- 2 edits in trunk/WebKitTools
2010-04-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Using a failure exit code when failing to load a required import
https://bugs.webkit.org/show_bug.cgi?id=37000
Well spotted by Mark Rowe.
- Scripts/webkitpy/common/system/user.py:
- 11:34 PM Changeset in webkit [56974] by
-
- 3 edits3 adds in trunk
2010-04-01 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
setting document.title doesn't change document.title value
https://bugs.webkit.org/show_bug.cgi?id=36802
- fast/dom/Document/script-tests/title-with-multiple-children.js: Added.
- fast/dom/Document/title-with-multiple-children-expected.txt: Added.
- fast/dom/Document/title-with-multiple-children.html: Added.
2010-04-01 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
setting document.title doesn't change document.title value
https://bugs.webkit.org/show_bug.cgi?id=36802
An entity of "value" argument on HTMLTitleElement::setTitle() could be
Document::m_title and be changed during HTMLTitleElement::setText().
Fix copying the argument to keep the original value.
Test: fast/dom/Document/title-with-multiple-children.html
- html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::setText):
- 11:15 PM Changeset in webkit [56973] by
-
- 3 edits in trunk/WebKitTools
Rewrote the revision (r56942) to disable the 79 character line
length limit Python/PEP8 style check.
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=33639#c39
This rewrite puts the disabling not in the PythonProcessor but
in the calling code's default filter rule configuration. This
allows the user to check line-length style from the command-line
if desired.
- Scripts/webkitpy/style/checker.py:
- Added "-pep8/E501" to the _BASE_FILTER_RULES configuration variable to disable the line-length check.
- Added "-pep8/E501" to the list of recognized style categories to permit the category to be checked from the command line.
- Scripts/webkitpy/style/processors/python.py:
- 11:09 PM Changeset in webkit [56972] by
-
- 4 edits in trunk/WebKit/chromium
2010-04-01 Jay Civelli <jcivelli@google.com>
Reviewed by David Levin.
Adds a method to WebFrame to execute JavaScript and get the value
it evaluates to.
https://bugs.webkit.org/show_bug.cgi?id=36907
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeScriptAndReturnValue):
- src/WebFrameImpl.h:
- 10:35 PM Changeset in webkit [56971] by
-
- 1 edit3 moves1 add in trunk/LayoutTests
2010-04-01 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Move some SVG mac results to the SVG base directory, to give other platforms like Gtk
access to them.
Gtk needs a platform specific result for feColorMatrix-values.
- platform/gtk/svg/filters/feColorMatrix-values-expected.txt: Added.
- platform/mac/svg/custom/animation-currentColor-expected.txt: Removed.
- platform/mac/svg/custom/glyph-transformation-with-hkern-expected.txt: Removed.
- platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt: Removed.
- svg/custom/animation-currentColor-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/animation-currentColor-expected.txt.
- svg/custom/glyph-transformation-with-hkern-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/glyph-transformation-with-hkern-expected.txt.
- svg/custom/gradient-with-1d-boundingbox-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt.
- 10:33 PM Changeset in webkit [56970] by
-
- 3 edits in trunk/WebCore
2010-04-01 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Maemo5 theme - <select multiple> custom rendering
https://bugs.webkit.org/show_bug.cgi?id=36369
Customizing rendering of <select multiple> elements in Maemo5.
- platform/qt/Maemo5Webstyle.cpp: (Maemo5WebStyle::drawMultipleComboButton): (Maemo5WebStyle::drawSimpleComboButton): (Maemo5WebStyle::getButtonImageSize): (Maemo5WebStyle::findComboButton): (Maemo5WebStyle::drawComplexControl):
- platform/qt/Maemo5Webstyle.h:
- 10:24 PM Changeset in webkit [56969] by
-
- 2 edits in trunk/LayoutTests
2010-04-01 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
This is a follow up to commit r56906. The fourth filter example,
feMorphology, shouldn't be displayed. filterRes causes a scaling of the filter
parameters, so that one value of 'radius' is lower than one.
The spec want us to round filter values down and a value of zero
for 'radius' stops the rendering process of feMorphology.
- platform/mac/svg/filters/filterRes-expected.png:
- 10:22 PM Changeset in webkit [56968] by
-
- 24 edits2 adds in trunk
2010-04-01 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dmitry Titov.
Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896
Add EANBEL_FILE_READER and ENABLE_FILE_WRITER flags.
- configure.ac:
2010-04-01 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dmitry Titov.
Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896
Add ENABLE_FILE_READER and ENABLE_FILE_WRITER flags.
- Configurations/FeatureDefines.xcconfig:
2010-04-01 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dmitry Titov.
Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896
Add FileThread for async file operation support for FileReader and
FileWriter. The patch also adds ENABLE_FILE_READER or
ENABLE_FILE_WRITER build flags/defines. Both flags are disabled
by default.
No new tests, will add ones when after adding modules which use the thread.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext): (WebCore::ScriptExecutionContext::fileThread):
- dom/ScriptExecutionContext.h:
- html/FileThread.cpp: Added. (WebCore::FileThread::FileThread): (WebCore::FileThread::~FileThread): (WebCore::FileThread::start): (WebCore::FileThread::stop): (WebCore::FileThread::postTask): (WebCore::SameFilePredicate::SameFilePredicate): (WebCore::SameFilePredicate::operator()): (WebCore::FileThread::removeTask): (WebCore::FileThread::fileThreadStart): (WebCore::FileThread::runLoop):
- html/FileThread.h: Added. (WebCore::FileThread::create): (WebCore::FileThread::Task::Task): (WebCore::FileThread::Task::~Task): (WebCore::FileThread::Task::fileHandle):
- platform/Logging.cpp: (WebCore::): (WebCore::getChannelFromName):
- platform/Logging.h:
2010-04-01 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dmitry Titov.
Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896
Add ENABLE_FILE_READER and ENABLE_FILE_WRITER flags.
- features.gypi:
2010-04-01 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dmitry Titov.
Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896
Add FILE_READER or FILE_WRITER feature defines.
- Configurations/FeatureDefines.xcconfig:
2010-04-01 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dmitry Titov.
Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896
Adds ENABLE_FILE_READER and ENABLE_FILE_WRITER feature flags
for FileReader and FileWriter support.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
2010-04-01 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dmitry Titov.
Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896
Add options to enable FILE_READER and FILE_WRITER support.
- Scripts/build-webkit:
- 10:22 PM Changeset in webkit [56967] by
-
- 2 edits in trunk/LayoutTests
2010-04-01 Eric Seidel <eric@webkit.org>
Unreviewed, just adding flaky tests to test_expectations.
Mark fast/dom/global-constructors.html and
fast/tokenizer/doctype-search-reset.html as flaky when run
under new-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=35006
https://bugs.webkit.org/show_bug.cgi?id=37007
- platform/mac/test_expectations.txt:
- 9:46 PM Changeset in webkit [56966] by
-
- 2 edits in trunk/WebKitTools
2010-04-01 Kent Tamura <tkent@chromium.org>
Unreviewed. Add missing license header.
- DumpRenderTree/chromium/TestShellMac.mm:
- 9:38 PM Changeset in webkit [56965] by
-
- 3 edits2 deletes in trunk
2010-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rollout of http://trac.webkit.org/changeset/56930
https://bugs.webkit.org/show_bug.cgi?id=36977
We suspect that this change broke aria-liveregions-notifications
- platform/mac/accessibility/area-with-aria-label-expected.txt: Removed.
- platform/mac/accessibility/area-with-aria-label.html: Removed.
2010-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rollout of http://trac.webkit.org/changeset/56930
https://bugs.webkit.org/show_bug.cgi?id=36977
- accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::accessibilityDescription):
- 9:31 PM Changeset in webkit [56964] by
-
- 6 edits in trunk/WebKitTools
2010-04-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Improve the error handling in rollout a bit
https://bugs.webkit.org/show_bug.cgi?id=36995
This patch does a few things to make the error handling in rollout a
bit more robust.
- Scripts/webkitpy/common/checkout/api.py:
The old logic here was wrong. We don't want to resolve the
ChangeLogs (that would remove the old ChangeLog entry). Instead,
we want to revert the ChangeLogs so we can fill them with the new
message.
- Scripts/webkitpy/tool/commands/download_unittest.py:
Update test expectations because we're using a different mock object.
- Scripts/webkitpy/tool/commands/download.py:
- Added an update command to make updating from the SheriffBot more robust.
- Now that we have CommitInfo, we can automatically CC the responsible parties on the bug we create.
- Re-ordered the steps in create-rollout. Our original thinking was that we always wanted to create the bug, but that's not really true given how things appear to be playing out. If we fail to apply the reverse diff, we don't want to create the bug.
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Use the new, more robust update command.
- Scripts/webkitpy/tool/steps/createbug.py:
Allow commands to pre-load who they want to be CCed on a new bug.
- 8:37 PM Changeset in webkit [56963] by
-
- 1 edit7 adds in trunk/WebKitTools
2010-04-01 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add TestShell and WebViewHost class, main(), and so on
https://bugs.webkit.org/show_bug.cgi?id=36814
This change introduces:
- WebViewHost class It's an implementation of some delegates required by Chromium WebKit API, and manages painting of a WebView. It's base on src/webkit/tools/test_shell/test_webview_delegate.{cc,h} of Chromium rev.40492.
- TestShell class The TestShell instance holds global states of DumpRenderTree process. Unlike TestShell class of Chromium test_shell, TestShell instance is created just once.
- DumpRenderTree.cpp The program entry.
- DumpRenderTree/chromium/DumpRenderTree.cpp: Added.
- DumpRenderTree/chromium/TestShell.cpp: Added.
- DumpRenderTree/chromium/TestShell.h: Added.
- DumpRenderTree/chromium/TestShellMac.mm: Added.
- DumpRenderTree/chromium/WebViewHost.cpp: Added.
- DumpRenderTree/chromium/WebViewHost.h: Added.
- DumpRenderTree/chromium/config.h: Added.
- 8:14 PM Changeset in webkit [56962] by
-
- 6 edits6 adds in trunk
2010-04-01 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31680
Ownerless nodes leads a crash on DOMSelection APIs
https://bugs.webkit.org/show_bug.cgi?id=36800
- editing/selection/DOMSelection-DocumentType-expected.txt: Added.
- editing/selection/DOMSelection-DocumentType.html: Added.
- editing/selection/DOMSelection-crossing-document-expected.txt: Added.
- editing/selection/DOMSelection-crossing-document.html: Added.
- editing/selection/drag-in-iframe.html: Updated to follow follow behaviour change.
- editing/selection/script-tests/DOMSelection-DocumentType.js: Added.
- editing/selection/script-tests/DOMSelection-crossing-document.js: Added. (makeEditableDocument): (clear):
2010-04-01 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31680
Ownerless nodes leads a crash on DOMSelection APIs
https://bugs.webkit.org/show_bug.cgi?id=36800
Added guards nodes from foreign documents to DOMSelection APIs.
Tests: editing/selection/DOMSelection-DocumentType.html
editing/selection/DOMSelection-crossing-document.html
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
- page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend): (WebCore::DOMSelection::containsNode): (WebCore::DOMSelection::isValidForPosition):
- page/DOMSelection.h:
- 7:54 PM Changeset in webkit [56961] by
-
- 5 edits in trunk
Unreviewed. Roll out r56959 because of some test failures
- 6:45 PM Changeset in webkit [56960] by
-
- 4 edits in trunk/WebKitTools
sheriffbot rollout should verify that the svn revision is a number.
https://bugs.webkit.org/show_bug.cgi?id=37001
Reviewed by Adam Barth.
- Scripts/webkitpy/common/net/bugzilla.py: Allow for the message to be None.
- Scripts/webkitpy/tool/bot/sheriff.py: Did verification that svn revision is a number. Fixed the imports (since the files uses ScriptError and log) and a typo.
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added a test to verify the behavior.
- 6:37 PM Changeset in webkit [56959] by
-
- 5 edits in trunk
2010-04-01 Yuzo Fujishima <yuzo@google.com>
Reviewed by David Hyatt.
Fix bug: CSS3 :not selector with ID simple selector sequence test fails
https://bugs.webkit.org/show_bug.cgi?id=36276
- fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
- fast/css/invalid-not-with-simple-selector-sequence.html: Added.
2010-04-01 Yuzo Fujishima <yuzo@google.com>
Reviewed by David Hyatt.
Fix bug: CSS3 :not selector with ID simple selector sequence test fails
As per http://www.w3.org/TR/css3-selectors/#negation, :not(X) takes a simple selector as an argument.
WebKit was accepting a simple selector *sequence*.
This patch adds WebCore::CSSSelector::isSimple which judges if the selector is simple.
The method is used in CSSGrammar.y to decide whether to accept the selector as the argument of :not().
https://bugs.webkit.org/show_bug.cgi?id=36276
Test: fast/css/invalid-not-with-simple-selector-sequence.html
- css/CSSGrammar.y:
- css/CSSSelector.cpp: (WebCore::CSSSelector::isSimple):
- css/CSSSelector.h:
- 6:25 PM Changeset in webkit [56958] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-01 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by Eric Seidel.
[chromium] FindInPage on multi-frame pages wasn't always updating
tickmarks on scrollbars for the subframes. It was calling invalidateRect
on the View and specifying a rect that's in window coordinates, whereas
the invalidateRect expects frame coordinates.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::invalidateArea):
- 6:14 PM Changeset in webkit [56957] by
-
- 2 edits in trunk/WebKitTools
2010-04-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Print an error message for readline bogosity in MacPorts
https://bugs.webkit.org/show_bug.cgi?id=36979
- Scripts/webkitpy/common/system/user.py:
- 5:44 PM Changeset in webkit [56956] by
-
- 3 edits4 adds in trunk
2010-04-01 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Add test for XSLT NULL crash:
https://bugs.webkit.org/show_bug.cgi?id=36804
- LayoutTests/fast/xsl/xslt-bad-import-uri.html: added
- LayoutTests/fast/xsl/xslt-bad-import-uri-expected.txt: added
- LayoutTests/fast/xsl/resources/xslt-bad-import-uri.xml: added
- LayoutTests/fast/xsl/resources/xslt-bad-import-uri.xsl: added
2010-04-01 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Fix a NULL pointer crash if @import fails to load a stylesheet.
Test: fast/xsl/xslt-bad-import-uri.html
- xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::parseString): Handle an empty string gracefully. An empty string has a NULL buffer, which we pass in to xmlCreateMemoryParserCtxt(). It returns NULL if it is passed a NULL buffer. In the top-level XSL case, the current code does not crash "by luck" because the other APIs used can handle a NULL argument. In the @import case, additional code runs which will deference the NULL.
- 5:26 PM Changeset in webkit [56955] by
-
- 3 edits5 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36854
<rdar://problem/7811668> REGRESSION (r47291): Body from cross origin preflight response
is prepended to the actual response body
Tests: http/tests/xmlhttprequest/access-control-response-with-body-sync.html
http/tests/xmlhttprequest/access-control-response-with-body.html
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData): Don't send data to the client when handling a preflight request.
- 5:13 PM Changeset in webkit [56954] by
-
- 6 edits in trunk
WebCore: Change DatabaseTracker::deleteOrigin() to return true if there are no errors in deleting the origin.
Ditto for DatabaseTracker::deleteDatabase().
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36988
- storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
- storage/DatabaseTracker.h:
WebKit/mac: Change WebDatabaseManager::deleteOrigin() to return true if there are no errors in deleting the origin.
Ditto for WebDatabaseManager::deleteDatabase().
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36988
- Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager deleteOrigin:]):
(-[WebDatabaseManager deleteDatabase:withOrigin:]):
- Storage/WebDatabaseManagerPrivate.h:
- 4:58 PM Changeset in webkit [56953] by
-
- 2 edits in trunk/WebCore
2010-04-01 Simon Fraser <Simon Fraser>
No review.
Remove some casts that I indended to remove before committing r56948.
- rendering/RenderTreeAsText.cpp: (WebCore::writeRenderObject): (WebCore::write):
- 4:54 PM Changeset in webkit [56952] by
-
- 1 edit in trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
Attempt to fix GTK LayoutTestController build
- 4:52 PM Changeset in webkit [56951] by
-
- 3 edits in trunk/WebKitTools
2010-04-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't pass --non-interactive to create-rollout
https://bugs.webkit.org/show_bug.cgi?id=36989
It turns out you can't pass --non-interactive to create-rollout. Also,
improve our error reporting slighly to catch the case where we error
out after creating the rollout bug.
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/sheriff.py:
- 4:49 PM Changeset in webkit [56950] by
-
- 2 edits in trunk/WebKitTools
2010-04-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
webkit-patch can incorrectly think the working directory is modified
https://bugs.webkit.org/show_bug.cgi?id=36985
If a file's modification time is modified, but the contents are not,
then diff-index will think the file has been modified unless you do
some crazy update-index call. Instead, call diff --name-only, which
has the index update builtin.
Tried to write a test, but could not reproduce this in a unittest.
To test manually:
touch file-in-repo
git diff-index HEAD
git diff HEAD --name-only
The diff-index call incorrectly shows file-in-repo as modified.
- Scripts/webkitpy/common/checkout/scm.py:
- 4:42 PM Changeset in webkit [56949] by
-
- 4 edits2 adds in trunk
2010-04-01 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Assertion failure (willBeComposited == needsToBeComposited(layer)) in
RenderLayerCompositor::computeCompositingRequirements() on hulu.com
https://bugs.webkit.org/show_bug.cgi?id=36516
Fix assertions added in r56017. That changed replaced calls to needsToBeComposited()
with use of the local 'willBeComposited' variable, but that fails to take into
account the fact that needsToBeComposited() also tests layer->isSelfPaintingLayer().
Fix by adding a canBeComposited() method that we call before testing
whether the layer should go into compositing mode.
Test: compositing/self-painting-layers2.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): Repace use of isSelfPaintingLayer() with a call to canBeComposited(). (WebCore::RenderLayerCompositor::computeCompositingRequirements): Call canBeComposited() to ensure that we only toggle 'willBeComposited' for layers that can. (WebCore::RenderLayerCompositor::needsToBeComposited): Call canBeComposited(). (WebCore::RenderLayerCompositor::canBeComposited): Test if compositing is enabled, and whether the layer is self-painting.
- rendering/RenderLayerCompositor.h: Add canBeComposited().
- 4:38 PM Changeset in webkit [56948] by
-
- 6 edits in trunk/WebCore
2010-04-01 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36980
Add object addresses to debug showLayerTree() output.
Add the ability to print RenderLayer and RenderObject addresses in the showLayerTree()
output.
- platform/text/TextStream.cpp: (WebCore::TextStream::operator<<):
- platform/text/TextStream.h:
- rendering/RenderLayer.cpp: (showLayerTree):
- rendering/RenderTreeAsText.cpp: (WebCore::writeRenderObject): (WebCore::write):
- rendering/RenderTreeAsText.h:
- 4:34 PM Changeset in webkit [56947] by
-
- 8 edits1 copy1 add in trunk/WebKitTools
2010-04-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add rollout command to sheriffbot
https://bugs.webkit.org/show_bug.cgi?id=36986
This IRC command creates a new bug an attaches a rollout patch. To
actually commit the rollout, a committer needs to mark the patch
commit-queue+ in bugs.webkit.org.
Also, factored out some of the logic from the queue into a separate
object for easier testing.
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/sheriff.py: Added.
- Scripts/webkitpy/tool/bot/sheriff_unittest.py: Added.
- Scripts/webkitpy/tool/bot/sheriffircbot.py:
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- 3:57 PM Changeset in webkit [56946] by
-
- 1 edit in trunk/WebKitTools/Scripts/run-webkit-tests
Backed out change to run-webkit-tests accidentally checked in
- 3:54 PM Changeset in webkit [56945] by
-
- 2 edits in trunk
Skipping compositing/geometry/preserve-3d-switching.html test on Leopard until we can fix https://bugs.webkit.org/show_bug.cgi?id=36984
- 3:53 PM Changeset in webkit [56944] by
-
- 2 edits in trunk
2010-04-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
autoinstalled should be git ignored
https://bugs.webkit.org/show_bug.cgi?id=36970
- .gitignore:
- 3:45 PM Changeset in webkit [56943] by
-
- 3 edits2 adds in trunk
WebCore: Changing SQLiteStatement::prepare() to return an error when it's
given a string that has more than one statement in it. Currently,
everything past the first statement is silently ignored.
Reviewed by Dimitri Glazkov.
Test: storage/executesql-accepts-only-one-statement.html
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
LayoutTests: Testing that executeSql() accepts only one-statement strings.
Reviewed by Dimitri Glazkov.
- storage/executesql-accepts-only-one-statement-expected.txt: Added.
- storage/executesql-accepts-only-one-statement.html: Added.
- 3:39 PM Changeset in webkit [56942] by
-
- 2 edits in trunk/WebKitTools
2010-04-01 Eric Seidel <eric@webkit.org>
Unreviewed, only ignoring chatty style errors.
check-webkit-style: WebKit needs a python style checker
https://bugs.webkit.org/show_bug.cgi?id=33639
Remove the 79 char line limit by ignoring
pep8/E501. Because we have our own report_error
implementation we have to ignore E501 by hand
instead of passing --ignore=E501.
Right now over 1400 lines of our existing python
fail E501 so this rule just generates needless noise.
The rest of WebKit has no wrapping rule so it makes
little sense for our Python to differ here.
- Scripts/webkitpy/style/processors/python.py:
- 3:21 PM Changeset in webkit [56941] by
-
- 10 edits8 adds in trunk
2010-04-01 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Keeps a transient optimistic offset to the root in RenderLayer::updateLayerPositions
https://bugs.webkit.org/show_bug.cgi?id=33520
RenderLayer::updateLayerPositions() makes a recursive walk through all RenderLayers and updates the repaint rectangles on each.
These rectangles have to be calculated in the repaint container's coordinates using RenderObject::mapLocalToContainer to walk
up to the repaint container. This patch keeps track of the offset to the root and uses that offset instead of walking back up to
the root every time.
Tests: fast/layers/nested-layers-1.html
fast/layers/nested-layers-2.html
fast/layers/nested-layers-3.html
fast/layers/nested-layers-4.html
- page/FrameView.cpp: (WebCore::FrameView::layout):
- rendering/RenderBox.cpp: (WebCore::RenderBox::outlineBoundsForRepaint):
- rendering/RenderBox.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
- rendering/RenderLayer.h:
- rendering/RenderObject.h: (WebCore::RenderObject::outlineBoundsForRepaint):
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
- rendering/RenderSVGModelObject.h:
2010-04-01 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Mapping from local to container coord space in updateLayerPositions is quadratic
https://bugs.webkit.org/show_bug.cgi?id=33520
These tests move layers around in various ways to test that the offset caching in
updateLayerPositions() is correct.
- fast/layers/nested-layers-1-expected.txt: Added.
- fast/layers/nested-layers-1.html: Added.
- fast/layers/nested-layers-2-expected.txt: Added.
- fast/layers/nested-layers-2.html: Added.
- fast/layers/nested-layers-3-expected.txt: Added.
- fast/layers/nested-layers-3.html: Added.
- fast/layers/nested-layers-4-expected.txt: Added.
- fast/layers/nested-layers-4.html: Added.
- 3:06 PM Changeset in webkit [56940] by
-
- 5 edits1 add in trunk/WebCore
2010-04-01 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Removed functions Range::operator == and Range::operator != as they
were using C++ code that was not sound and hence may have undefined
behavior.
Test case: manual-tests/crash-on-find-with-no-selection.html
- dom/Range.cpp: (WebCore::areRangesEqual): Added.
- dom/Range.h:
- editing/markup.cpp: (WebCore::createMarkup): Modified to call WebCore::areRangesEqual.
- manual-tests/crash-on-find-with-no-selection.html: Added.
- page/Frame.cpp: (WebCore::Frame::findString): Modified to call WebCore::areRangesEqual.
- 2:57 PM Changeset in webkit [56939] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild of Interfaces
- 2:43 PM Changeset in webkit [56938] by
-
- 3 edits in trunk
Fixed Windows (and hopefully Tiger) build
- 2:15 PM Changeset in webkit [56937] by
-
- 2 edits in trunk/WebKitTools
2010-04-01 Adam Barth <abarth@webkit.org>
Unreviewed. Add cmarrin's IRC nickname.
- Scripts/webkitpy/common/config/committers.py:
- 2:10 PM Changeset in webkit [56936] by
-
- 5 edits in trunk/WebKitTools
2010-04-01 Adam Barth <abarth@webkit.org>
Unreviewed.
EWS spins hot when unable to build
https://bugs.webkit.org/show_bug.cgi?id=36981
The problem is that the queue engine things we have more work to do,
but the bot isn't actually able to do anything. After this change, we
back off the usual amount.
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- 1:59 PM Changeset in webkit [56935] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36976
<rdar://problem/7817498>
REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): The HashTable assertions aren't there to catch potential future attempts to store empty/deleted values before these happen - it's actually wrong to try to look up these values. Added an early return. (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Ditto.
- 1:15 PM Changeset in webkit [56934] by
-
- 18 edits2 adds in trunk
Added layerTreeAsText function to DRT (for Mac)
https://bugs.webkit.org/show_bug.cgi?id=36782
- 1:11 PM Changeset in webkit [56933] by
-
- 3 edits in trunk/WebCore
Synchronous rendering when setting form control values slows down JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36967
Reviewed by Sam Weinig.
This patch basically reverts http://trac.webkit.org/changeset/19006.
Dan asked me to investigate why 19006 is no longer needed. I have two answers:
(1) I was also able to remove the synchronous call to updateFromElement().
That call was the proximate cause of the crash that 19006 fixed.
(2) updateFromElement() no longer calls HTMLElement::setInnerText()
in the way that it used to. (However, it doesn't seem prudent to
rely on this happy coincidence.)
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue): Simplified some logic here. Moved
setNeedsValidityCheck() outside of individual 'if' clauses, since they all
called it.
Removed call to updateStyleIfNeeded(), which does rendering synchronously,
since that was the performance problem. (setNeedsStyleRecalc() ensures
that rendering will happen asynchronously.) Also removed comment about
ordering dangers introduced by updateStyleIfNeeded().
Removed call to updateFromElement(), since it's dangerous and also a minor
performance problem. (setNeedsStyleRecalc() ensures that updateFromElement()
will happen asynchronously, too.)
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setNonDirtyValue): Ditto. Here, I had to
add a call to setNeedsStyleRecalc(), since there wasn't one before.
- 12:59 PM Changeset in webkit [56932] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=36976
<rdar://problem/7817498>
REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Use find() instead of get(), because the latter fails with an assertion when looking up 0 or -1. (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Be prepared for unexpected object IDs coming from plug-in host.
- 12:58 PM Changeset in webkit [56931] by
-
- 4 edits in trunk/WebCore
2010-04-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Sometimes js code can detach page from it's frame and in that case
Dispatch Events will stay in the TimelineAgent's events stack. Only immediate events will
appear at frontend.
https://bugs.webkit.org/show_bug.cgi?id=36890
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
- 12:46 PM Changeset in webkit [56930] by
-
- 3 edits2 adds in trunk
Bug 36977 - aria-label doesn't work on image map area
https://bugs.webkit.org/show_bug.cgi?id=36977
Reviewed by Beth Dakin.
WebCore:
Test: platform/mac/accessibility/area-with-aria-label.html
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::accessibilityDescription):
LayoutTests:
- platform/mac/accessibility/area-with-aria-label-expected.txt: Added.
- platform/mac/accessibility/area-with-aria-label.html: Added.
- 12:36 PM Changeset in webkit [56929] by
-
- 3 edits in trunk/WebKit/qt
2010-04-01 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Add Single and Multiple Selection Popup for Maemo 5.
[Qt] Maemo5 theme - popup dialogs
https://bugs.webkit.org/show_bug.cgi?id=36789
- WebCoreSupport/QtMaemoWebPopup.cpp: (WebCore::Maemo5Popup::populateList): (WebCore::Maemo5Popup::onItemSelected): (WebCore::QtMaemoWebPopup::createSingleSelectionPopup): (WebCore::QtMaemoWebPopup::createMultipleSelectionPopup): (WebCore::Maemo5SingleSelectionPopup::Maemo5SingleSelectionPopup): (WebCore::MultipleItemListDelegate::MultipleItemListDelegate): (WebCore::MultipleItemListDelegate::paint): (WebCore::Maemo5MultipleSelectionPopup::Maemo5MultipleSelectionPopup):
- WebCoreSupport/QtMaemoWebPopup.h:
- 12:23 PM Changeset in webkit [56928] by
-
- 2 edits in trunk/LayoutTests
2010-04-01 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Part of:
REGRESSION(56394):
http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html
fails on Tiger
https://bugs.webkit.org/show_bug.cgi?id=36934
- http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html: Add more explicit failing messages to help find out what is failing.
- 11:54 AM Changeset in webkit [56927] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix after addition of JavaScriptCore/wtf/text directory.
- 11:46 AM Changeset in webkit [56926] by
-
- 2 edits in trunk/LayoutTests
2010-04-01 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
REGRESSION(56489): security/block-test.html fails on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=36932
It appears that r56489 just forgot to update the Tiger results
to include the new parts of the test. Tiger has had custom
results for this test since r54193.
I just pulled these off the bot. I do not have the domain knowledge
to know if these are right or not. They look fine to me.
- platform/mac-tiger/security/block-test-expected.txt:
- 11:37 AM Changeset in webkit [56925] by
-
- 2 edits in trunk/LayoutTests
2010-04-01 Zhenyao Mo <zmo@google.com>
Reviewed by Eric Seidel.
fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=36908
- fast/canvas/webgl/script-tests/index-validation.js: Disable antialias for this test.
- 11:19 AM Changeset in webkit [56924] by
-
- 3 edits2 adds in trunk
2010-04-01 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Assertion failure: !repaintContainer repaintContainer == this RenderText's implementation of clippedOverflowRectForRepaint() uses containingBlock()
to get the renderer to use for computing the repaint rect. However, the renderer returned
by containingBlock() may be an ancestor of the repaintContainer, and containingBlock()
doesn't have the 'repaintContainerSkipped' logic that container() has.
So in this case, check to see whether repaintContainer is actually a descendant of the
containing block, and in that case just repaint the entire repaintContainer.
Test: compositing/repaint/inline-repaint-container.html
- rendering/RenderText.cpp: (WebCore::RenderText::clippedOverflowRectForRepaint):
- 11:05 AM Changeset in webkit [56923] by
-
- 2 edits in trunk
2010-04-01 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt]Add -Wextra warning level to the QtWebKit build
https://bugs.webkit.org/show_bug.cgi?id=36971
- WebKit.pri:
- 10:49 AM WebKit Team edited by
- (diff)
- 10:49 AM Changeset in webkit [56922] by
-
- 3 edits in trunk/WebCore
[Qt] REGRESSION(r56869): Windows build is broken
https://bugs.webkit.org/show_bug.cgi?id=36929
Reviewed by Jian Li.
- WebCore.pro: LIBS += -lOle32 added.
- platform/UUID.cpp: Define ARRAYSIZE macro if it isn't defined before.
- 10:31 AM Changeset in webkit [56921] by
-
- 2 edits in trunk/WebKitTools
Rubber-stamped by David Levin.
Add myself to the reviewers list.
- Scripts/webkitpy/common/config/committers.py:
- 10:17 AM Changeset in webkit [56920] by
-
- 3 edits2 adds in trunk
Bug 36968 - 1 crash in Safari at com.apple.WebCore: WebCore::Element::getAttribute const
https://bugs.webkit.org/show_bug.cgi?id=36968
Reviewed by Beth Dakin.
WebCore:
Test: accessibility/crash-with-noelement-selectbox.html
When a <select> element had no options, the selectedIndex == -1 and that was being
used to index into an empty array.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
LayoutTests:
- accessibility/crash-with-noelement-selectbox-expected.txt: Added.
- accessibility/crash-with-noelement-selectbox.html: Added.
- 10:10 AM Changeset in webkit [56919] by
-
- 2 edits in trunk/WebKitTools
2010-04-01 Adam Barth <abarth@webkit.org>
Unreviewed.
Turns out the Chromium Windows bots don't have pdevenv installed.
- Scripts/webkitdirs.pm:
- 9:54 AM Changeset in webkit [56918] by
-
- 2 edits in trunk/WebKitTools
2010-04-01 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Let Chromium Windows build with Visual Studio Express
https://bugs.webkit.org/show_bug.cgi?id=36919
This is horrible, horrible copy/paste code, but that seems to be the
way of webkitdirs.pm. :(
Someone needs to go through an cleanup this code, but I don't have the
heart to do it in this patch.
- Scripts/webkitdirs.pm:
- 9:45 AM Changeset in webkit [56917] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-01 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by Dimitri Glazkov.
[chromium] FindInPage should clear the focused node when a match has
been found. This is because WebFrameImpl::setFocus will try to refocus
editable elements if it thinks they have focus, causing the page to
scroll.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::find):
- 9:07 AM Changeset in webkit [56916] by
-
- 4 edits1 add in trunk
2010-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
[GTK] webkit_get_default_session() should make sure webkit_init() is called
https://bugs.webkit.org/show_bug.cgi?id=36754
Make sure global functions that do not require a WebKitWebView to
be created call webkit_init() before doing their job. Also add an
API test to check for that.
- tests/testglobals.c: Added. (test_globals_default_session): (main):
- webkit/webkitwebview.cpp: (webkit_get_default_session): (webkit_set_cache_model): (webkit_get_cache_model):
- 8:14 AM Changeset in webkit [56915] by
-
- 4 edits in trunk/WebCore
2010-04-01 MORITA Hajime <morrita@google.com>
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=36948
Refactoring: Position::primaryDirection() should be extracted.
No new tests. No functinal change.
- dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): (WebCore::Position::primaryDirection): Added
- dom/Position.h:
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
- 8:03 AM Changeset in webkit [56914] by
-
- 1 edit1 add in trunk/WebKit
2010-04-01 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Add EFL's pkg-config metadata file file to efl/.
http://webkit.org/b/36766
- efl/ewebkit.pc.in: Added.
- 7:46 AM Changeset in webkit [56913] by
-
- 2 edits in trunk/WebKitTools
2010-04-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Add myself to the committers list.
https://bugs.webkit.org/show_bug.cgi?id=36953
- Scripts/webkitpy/common/config/committers.py:
- 7:12 AM Changeset in webkit [56912] by
-
- 1 edit1 move in trunk/LayoutTests
2010-04-01 yael aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
set-progress-properties.html expected result should not be platform specific
https://bugs.webkit.org/show_bug.cgi?id=36918
- fast/dom/HTMLProgressElement/set-progress-properties-expected.txt: Added.
- platform/qt/fast/dom/HTMLProgressElement/set-progress-properties-expected.txt: Removed.
- 6:48 AM Changeset in webkit [56911] by
-
- 3 edits2 adds in trunk/LayoutTests
2010-04-01 Shu Chang <chang.shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] As Qt does not support dashboard compatibility mode, the red squares on
the second row are expected. Rebaseline and unskip test case.
https://bugs.webkit.org/show_bug.cgi?id=36869
- platform/qt/Skipped:
- platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
- platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
- platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.txt:
- 6:10 AM Changeset in webkit [56910] by
-
- 2 edits in trunk/LayoutTests
2010-04-01 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Mark console-log-before-frame-navigation as pssing on Chromium Win.
- platform/chromium/test_expectations.txt:
- 6:00 AM Changeset in webkit [56909] by
-
- 5 edits in trunk
2010-04-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Audits: fix parsing of injected script-evaluated result for CssInHeadRule
https://bugs.webkit.org/show_bug.cgi?id=36952
- inspector/audits-panel-functional-expected.txt:
- inspector/audits-panel-functional.html:
2010-04-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Audits: fix parsing of injected script-evaluated result for CssInHeadRule
https://bugs.webkit.org/show_bug.cgi?id=36952
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
- 5:02 AM Changeset in webkit [56908] by
-
- 4 edits1 delete in trunk/WebKit/chromium
2010-04-01 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
As a follow up on https://bugs.webkit.org/show_bug.cgi?id=36535, remove:
GeolocationServiceBridgeChromium.h
dettachBridge()
getGeolocationService()
https://bugs.webkit.org/show_bug.cgi?id=36895
- WebKit.gyp:
- public/GeolocationServiceBridgeChromium.h: Removed.
- public/WebGeolocationService.h: (WebKit::WebGeolocationService::detachBridge):
- public/WebViewClient.h: (WebKit::WebViewClient::geolocationService):
- 3:19 AM Changeset in webkit [56907] by
-
- 13 edits in trunk
2010-03-31 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Misc IndexedDatabase cleanup
https://bugs.webkit.org/show_bug.cgi?id=36889
No functional changes.
- bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::onSuccess): (WebCore::V8CustomIDBCallbacks::onError): (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks):
Get rid of 2 largely redundant bools
- storage/IndexedDatabase.h:
- storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
- storage/IndexedDatabaseImpl.h:
- storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
- storage/IndexedDatabaseRequest.h:
Plumb the Frame* and style cleanups.
2010-03-31 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Misc IndexedDatabase cleanup
https://bugs.webkit.org/show_bug.cgi?id=36889
Plumb the Frame* so Chromium knows where the request originated from.
- public/WebIndexedDatabase.h:
- src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
- src/IndexedDatabaseProxy.h:
- src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
- src/WebIndexedDatabaseImpl.h:
- 2:16 AM WebKit Team edited by
- (diff)
- 1:54 AM Changeset in webkit [56906] by
-
- 2 edits in trunk/LayoutTests
2010-04-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Fix filter references in svg/filters/filterRes.svg, to make two filters show up in Opera.
Clearly shows we have a regression with filterRes + feMorphology.
- svg/filters/filterRes.svg:
- 1:30 AM Changeset in webkit [56905] by
-
- 18 edits9 adds in trunk
2010-03-31 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
REGRESSION: document.documentElement.getScreenCTM() returns incorrect matrix.
https://bugs.webkit.org/show_bug.cgi?id=27183
Rewrite getCTM() / getScreenCTM() handling in an iterative way, fixing all known problems/limitations.
The bug mentioned above is actually not a regression, getScreenCTM() only worked before, because we
did not handle non-SVG CSS box parents properly. When support was added to handle those cases, the
getScreenCTM() handling was completly off, causing a lot of trouble in real-life SVG applications (carto.net for instance)
Tests: svg/custom/svgsvgelement-ctm.xhtml (fixed typo, missing unit identifier in CSS 'height' property, leading to incorrect results)
svg/custom/svgsvgelement-ctm2.xhtml
svg/custom/svgsvgelement-ctm3.xhtml
svg/custom/svgsvgelement-ctm4.xhtml
svg/custom/svgsvgelement-ctm5.xhtml
- svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getBBox): (WebCore::SVGLocatable::computeCTM):
- svg/SVGLocatable.h: (WebCore::SVGLocatable::localCoordinateSpaceTransform):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::localCoordinateSpaceTransform): (WebCore::SVGSVGElement::createRenderer):
- svg/SVGSVGElement.h:
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::localCoordinateSpaceTransform):
- svg/SVGStyledElement.h:
- svg/SVGStyledLocatableElement.cpp: (WebCore::SVGStyledLocatableElement::getCTM): (WebCore::SVGStyledLocatableElement::getScreenCTM):
- svg/SVGStyledLocatableElement.h: (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::getCTM): (WebCore::SVGStyledTransformableElement::getScreenCTM):
- svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::localCoordinateSpaceTransform):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::getCTM): (WebCore::SVGTextElement::getScreenCTM):
- svg/SVGTextElement.h: (WebCore::SVGTextElement::localCoordinateSpaceTransform):
- svg/SVGTransformable.cpp: (WebCore::SVGTransformable::SVGTransformable):
- svg/SVGTransformable.h: (WebCore::SVGTransformable::localCoordinateSpaceTransform):
2010-03-31 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
REGRESSION: document.documentElement.getScreenCTM() returns incorrect matrix.
https://bugs.webkit.org/show_bug.cgi?id=27183
Share code between the different svgsvgelement-ctm*.xhtm tests, placed in svg/custom/resources.
Add several new tests covering getCTM()/getScreenCTM() on text, inner and outer svg elements and containers.
- svg/custom/resources/svgsvgelement-ctm.js: Added. (log): (stringForMatrix): (printCTMs):
- svg/custom/svgsvgelement-ctm-expected.txt:
- svg/custom/svgsvgelement-ctm.xhtml:
- svg/custom/svgsvgelement-ctm2-expected.txt: Added.
- svg/custom/svgsvgelement-ctm2.xhtml: Added.
- svg/custom/svgsvgelement-ctm3-expected.txt: Added.
- svg/custom/svgsvgelement-ctm3.xhtml: Added.
- svg/custom/svgsvgelement-ctm4-expected.txt: Added.
- svg/custom/svgsvgelement-ctm4.xhtml: Added.
- svg/custom/svgsvgelement-ctm5-expected.txt: Added.
- svg/custom/svgsvgelement-ctm5.xhtml: Added.
- 1:22 AM Changeset in webkit [56904] by
-
- 1 edit2 adds in trunk/LayoutTests
Not reviewed. Build fix.
Adding test expectations missing in r56873.
- platform/chromium-mac/media/audio-constructor-src-expected.txt: Added.
- platform/chromium-mac/media/video-source-add-src-expected.txt: Added.
- 1:16 AM Changeset in webkit [56903] by
-
- 2 edits in trunk/WebCore
2010-04-01 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Darin Fisher.
[V8] Quick fix for failure in SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=36943
This allows the web worker layout tests to pass again.
- bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::deserializeAndSetProperty):
- 1:02 AM Changeset in webkit [56902] by
-
- 3 edits in trunk/WebKitTools
2010-04-01 Eric Seidel <eric@webkit.org>
Rubber-stamped by Adam Barth.
Add Snow Leopard Release bot to the list of "core builders" (builders which stop the commit-queue when they turn red)
https://bugs.webkit.org/show_bug.cgi?id=33292
Just adding the "Build" builder for now.
We'll add the "Test" builders when the tests
are less flaky.
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- 12:38 AM Changeset in webkit [56901] by
-
- 2 edits in trunk/WebKitTools
2010-04-01 Yury Semikhatsky <yurys@chromium.org>
Reviewed by David Levin.
Add myself to the reviewers list.
- Scripts/webkitpy/common/config/committers.py:
- 12:10 AM WebKit Team edited by
- (diff)
- 12:04 AM Changeset in webkit [56900] by
-
- 2 edits6 moves in trunk/LayoutTests
2010-04-01 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed - more layout test result build fixes:
.) Fix expected layout test filenames for Chromium.
.) Add new layout test to gtk Skipped list.
Original patch review by Darin Adler (no functional change):
Bug 36803 - 'Inline-table' workaround for <ruby> broken with ruby support
https://bugs.webkit.org/show_bug.cgi?id=36803
- platform/chromium-linux/fast/ruby/ruby-inline-table-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/fast/ruby/ruby-inline-table-actual.checksum.
- platform/chromium-linux/fast/ruby/ruby-inline-table-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/ruby/ruby-inline-table-actual.png.
- platform/chromium-linux/fast/ruby/ruby-inline-table-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/ruby/ruby-inline-table-actual.txt.
- platform/chromium-win/fast/ruby/ruby-inline-table-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/ruby/ruby-inline-table-actual.checksum.
- platform/chromium-win/fast/ruby/ruby-inline-table-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/ruby/ruby-inline-table-actual.png.
- platform/chromium-win/fast/ruby/ruby-inline-table-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/ruby/ruby-inline-table-actual.txt.
- platform/gtk/Skipped:
