⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 3, 2010:

11:53 PM Changeset in webkit [57055] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=37068
Change UString to use a 0 rep for null strings instead of a null object.

Reviewed by Oliver Hunt.

No performance impact.

(JSC::InternalFunction::InternalFunction):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):

  • runtime/UString.cpp:

(JSC::initializeUString):

  • runtime/UString.h:

(JSC::UString::UString):
(JSC::UString::data):
(JSC::UString::size):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::cost):

6:53 PM PythonGuidelines edited by Chris Jerdonek
Added another reason for the from/import ordering suggestion. (diff)
6:17 PM Changeset in webkit [57054] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-04-03 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Fix uninitalised members in CallLinkInfo and BytecodeGenerator.

​https://bugs.webkit.org/show_bug.cgi?id=36816

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock):
  • bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo):
1:28 PM PythonGuidelines edited by Chris Jerdonek
Moved the PEP8 remark to the style section. (diff)
1:20 PM PythonGuidelines edited by Chris Jerdonek
Fixed typo. (diff)
1:19 PM PythonGuidelines edited by Chris Jerdonek
Added a style section. (diff)
1:01 PM WikiStart edited by Chris Jerdonek
Retitled link to Python page (diff)
11:59 AM Changeset in webkit [57053] by jwieczorek@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-03 Jakub Wieczorek <​jwieczorek@webkit.org>

Unreviewed.

[Qt] Skip five XMLHttpRequest tests that are timing out.

  • platform/qt/Skipped: Add a comment on why they are failing.
10:40 AM Changeset in webkit [57052] by jwieczorek@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-03 Jakub Wieczorek <​jwieczorek@webkit.org>

Rubber-stamped by Daniel Bates.

Fix the fast/events/popup-allowed-from-gesture-initiated-event.html test
failure on the Qt and GTK+ ports.

Refactor it to not hardcode any metrics (in order to dispatch mouse events)
but instead calculate them from the offset* properties.

  • fast/events/popup-allowed-from-gesture-initiated-event.html:
10:40 AM WikiStart edited by abarth@webkit.org
(diff)
10:38 AM Keeping the Tree Green edited by abarth@webkit.org
(diff)
10:35 AM Keeping the Tree Green edited by abarth@webkit.org
(diff)
10:34 AM Keeping the Tree Green edited by abarth@webkit.org
(diff)
10:34 AM Keeping the Tree Green created by abarth@webkit.org
10:27 AM Changeset in webkit [57051] by eric@webkit.org
  • 11 edits in trunk

2010-04-03 yael aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Enable HTMLProgressElement for Safari on OSX
​https://bugs.webkit.org/show_bug.cgi?id=36961

  • Configurations/FeatureDefines.xcconfig:

2010-04-03 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
​https://bugs.webkit.org/show_bug.cgi?id=36574

Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.

  • fast/canvas/webgl/null-uniform-location-expected.txt: Added.
  • fast/canvas/webgl/null-uniform-location.html: Added.
  • fast/canvas/webgl/script-tests/null-uniform-location.js: Added. (callUniformFunction):
  • fast/canvas/webgl/uniform-location-expected.txt:

2010-04-03 yael aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Enable HTMLProgressElement for Safari on OSX
​https://bugs.webkit.org/show_bug.cgi?id=36961

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeMac::animationDurationForProgressBar): (WebCore::RenderThemeMac::adjustProgressBarStyle): (WebCore::RenderThemeMac::paintProgressBar):

2010-04-03 yael aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Enable HTMLProgressElement for Safari on OSX
​https://bugs.webkit.org/show_bug.cgi?id=36961

  • Configurations/FeatureDefines.xcconfig:
7:34 AM Changeset in webkit [57050] by jwieczorek@webkit.org
  • 2 edits in trunk/WebCore

2010-04-03 Jakub Wieczorek <​jwieczorek@webkit.org>

Unreviewed.

Fix debug build with GCC >= 4.3.

  • platform/graphics/GraphicsLayer.cpp: Include stdio.h explicitly.
12:49 AM Changeset in webkit [57049] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-04-03 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
​https://bugs.webkit.org/show_bug.cgi?id=36574

Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.

  • fast/canvas/webgl/null-uniform-location-expected.txt: Added.
  • fast/canvas/webgl/null-uniform-location.html: Added.
  • fast/canvas/webgl/script-tests/null-uniform-location.js: Added. (callUniformFunction):
  • fast/canvas/webgl/uniform-location-expected.txt:

2010-04-03 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
​https://bugs.webkit.org/show_bug.cgi?id=36574

Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.

Test: fast/canvas/webgl/null-uniform-location.html

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::V8WebGLRenderingContext::getUniformCallback): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv):
12:46 AM Changeset in webkit [57048] by Chris Jerdonek
  • 4 edits in trunk/WebKitTools

The check-webkit-style script now logs an ERROR and exits when
encountering a file path that does not exist. Previously, it failed
silently on such paths.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=36957

  • Scripts/webkitpy/common/system/logtesting.py:
    • Added a FIXME to rename the LoggingTestCase class to LoggingTestCaseBase.
  • Scripts/webkitpy/style/checker.py:
    • In the StyleChecker.check_file() method:
      • Added a mock_os_path_exists parameter.
      • Renamed the process_file parameter to mock_process_file.
      • Added logic to log an error and exist if the given path does not exist.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Refactored the StyleCheckerCheckFileTest class slightly to inherit from LoggingTestCase.
    • Added a test method to unit-test the case of a file that does not exist.
    • Adjusted the other test methods as necessary.
12:34 AM Changeset in webkit [57047] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red)
​https://bugs.webkit.org/show_bug.cgi?id=33289

Add Tiger and SnowLeopard Tests to the core builders. This is a bit of
an experiment now that the bots are green. Hopefully we can keep them
on the list and have the tree stay greener.

  • Scripts/webkitpy/common/net/buildbot.py:
12:12 AM Changeset in webkit [57046] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-03 Darin Fisher <​darin@chromium.org>

Add default implementations of WebNotificationPresenter methods to
repair the downstream Chromium build.

  • public/WebNotificationPresenter.h: (WebKit::WebNotificationPresenter::show): (WebKit::WebNotificationPresenter::cancel): (WebKit::WebNotificationPresenter::objectDestroyed): (WebKit::WebNotificationPresenter::checkPermission): (WebKit::WebNotificationPresenter::requestPermission):
12:05 AM Changeset in webkit [57045] by abarth@webkit.org
  • 13 edits
    8 adds in trunk

2010-04-02 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=37008.

  • fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
  • fast/events/popup-allowed-from-gesture-initiated-event.html: Added.
  • fast/events/popup-blocked-from-fake-button-click-expected.txt: Added.
  • fast/events/popup-blocked-from-fake-button-click.html: Added.
  • fast/events/popup-blocked-from-fake-focus-expected.txt: Added.
  • fast/events/popup-blocked-from-fake-focus.html: Added.

2010-04-02 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

The previous mechanism for testing whether an event was due to a user
gesture only checked the event type, not the source of the event. This
allowed scripts to defeat popup blocking by programatically emitting
certain types of events.

Change the user gesture detection to check for a flag that is only set
when the event in question was generated through the platform and not
through the DOM.

​https://bugs.webkit.org/show_bug.cgi?id=37008

Tests: fast/events/popup-allowed-from-gesture-initiated-event.html

fast/events/popup-blocked-from-fake-button-click.html
fast/events/popup-blocked-from-fake-focus.html

  • Android.mk: Add UserGestureIndicator.{cpp, h}.
  • GNUmakefile.am: Same.
  • WebCore.gypi: Same.
  • WebCore.pro: Same.
  • WebCore.vcproj/WebCore.vcproj: Same.
  • WebCore.xcodeproj/project.pbxproj: Same.
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): Check the value of UserGesureIndicator::processingUserGesture().
  • dom/Document.cpp: (WebCore::Document::createEvent): Remove call to Event::setCreatedByDOM().
  • dom/Event.cpp: (WebCore::Event::Event): Remove initializers for m_createdByDOM. (WebCore::Event::fromUserGesture): Check the value of UserGestureIndicator::processingUserGesture().
  • dom/Event.h: Remove m_createdByDOM.
  • dom/UserGestureIndicator.cpp: Added. (WebCore::UserGestureIndicator::UserGestureIndicator): Save the previous value of s_processingUserGesture before setting it to true. (WebCore::UserGestureIndicator::~UserGestureIndicator): Restore s_processingUserGesture to its previous value.
  • dom/UserGestureIndicator.h: Added. (WebCore::UserGestureIndicator::processingUserGesture): Return the value of s_processingUserGesture.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Instantiate a UserGestureIndicator object on the stack to indicate a user gesture is being processed. (WebCore::EventHandler::handleMouseDoubleClickEvent): Same. (WebCore::EventHandler::handleMouseReleaseEvent): Same. (WebCore::EventHandler::keyEvent): Same. (WebCore::EventHandler::handleTouchEvent): Same.

Apr 2, 2010:

11:15 PM Changeset in webkit [57044] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-02 Adam Barth <​abarth@webkit.org>

Unreviewed.

REGRESSION(56394): http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html fails on Tiger
​https://bugs.webkit.org/show_bug.cgi?id=36934

Attempt Alexey's solution of using a non-sniffable MIME type.

  • http/tests/xmlhttprequest/resources/download-with-delay.php:
10:49 PM Changeset in webkit [57043] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-02 Adam Barth <​abarth@webkit.org>

Unreviewed. Disabled fast/workers/worker-terminate.html because it
randomly fails about 25% of the time.

​https://bugs.webkit.org/show_bug.cgi?id=36646

  • platform/mac/Skipped:
9:48 PM Changeset in webkit [57042] by darin@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

2010-04-02 Darin Fisher <​darin@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=36647
Make replacestate-in-frame.html less insane and hopefully no longer flaky.

  • fast/loader/stateobjects/replacestate-in-iframe-expected.txt:
  • fast/loader/stateobjects/replacestate-in-iframe.html:
  • fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html: Added.
  • fast/loader/stateobjects/resources/replacestate-in-iframe-window.html: Added.
9:20 PM Changeset in webkit [57041] by abarth@webkit.org
  • 3 edits
    9 adds in trunk

2010-04-02 Justin Schuh <​jschuh@chromium.org>

Reviewed by Alexey Proskuryakov.

XHR allows arbitrary XSRF across domains
​https://bugs.webkit.org/show_bug.cgi?id=36843

Added a one-line change to prevent bypassing the XDC check on
synchronous preflighted requests. Added layout tests to cover
variations of this problem.

  • http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-sync-header-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-sync-method-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-preflight-denied-xsrf.php: Added.

2010-04-02 Justin Schuh <​jschuh@chromium.org>

Reviewed by Alexey Proskuryakov.

XHR allows arbitrary XSRF across domains
​https://bugs.webkit.org/show_bug.cgi?id=36843

Added a one-line change to prevent bypassing the XDC check on
synchronous preflighted requests. Added layout tests to cover
variations of this problem.

Tests: http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html

http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html
http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html
http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::preflightFailure):
9:09 PM Changeset in webkit [57040] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Unreviewed.

Have Eric and Adam watch the SheriffBot
​https://bugs.webkit.org/show_bug.cgi?id=37054

  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
6:05 PM Changeset in webkit [57039] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-04-02 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Very bad scrolling-performance with the Trackpad at ​http://www.apple.com/ipad/app-store/
​https://bugs.webkit.org/show_bug.cgi?id=36978

When we update compositing layers (which can happen on scrolling, when there are fixed position elements
on the page), we can end up redundantly setting images as layer contents if we have to color-correct
the image. This is because we call CGImageCreateCopyWithColorSpace(), which hands back a new image
every time.

Avoid this by storing a reference to the original uncorrected image, which is used to then
avoid work if the image does not change.

  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):
6:03 PM Changeset in webkit [57038] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-04-02 Nayan Kumar K <​nayankk@gmail.com>

Reviewed by Eric Seidel.

Fix for WML enabled build failure.

​https://bugs.webkit.org/show_bug.cgi?id=36648

  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::disabled):
  • wml/WMLOptionElement.h:
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::listBoxSelectItem):
  • wml/WMLSelectElement.h:
5:38 PM Changeset in webkit [57037] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-02 MORITA Hajime <​morrita@google.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=37011
Position::primaryDirection() should not use its own accessor.

No new tests. This is small clenaup with no behaviour change.

  • dom/Position.cpp: (WebCore::Position::primaryDirection):
5:16 PM Changeset in webkit [57036] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-02 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Brady Eidson.

window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5. This is caused by a SecurityOrigin pointer comparison that I should have switched to be a hash comparison in r56293 [bug 34991].
​https://bugs.webkit.org/show_bug.cgi?id=36671

No new tests. Requires testing on Safari on Windows.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Convert a pointer comparison to use SecurityOriginHash::hash() instead, and move it to the end of the clause for speed in the easy-out case.
5:14 PM Changeset in webkit [57035] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

commit-queue should ignore builders when landing rollouts
​https://bugs.webkit.org/show_bug.cgi?id=37051

When we moved the "builders are red" check into the master process, we
forgot about rollouts. I thought we had a test covering this case, but
looking at the test, it was a bit too loose. I added a new test and
introduced some new logging technology into MockTool to make the test
tighter.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
5:06 PM Changeset in webkit [57034] by eric@webkit.org
  • 6 edits in trunk

2010-04-02 Michael Nordman <Michael Nordman>

Reviewed by Nate Chapin.

Set the close policy used by the DatabaseCloseTask in a constructor argument
instead of hard coding it.
​https://bugs.webkit.org/show_bug.cgi?id=37037

No new tests, new new functionality.

  • storage/Database.cpp: This callsite passes in DoNotRemoveFromDatabaseContext to retain its current behavior. (WebCore::Database::markAsDeletedAndClose):
  • storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::DatabaseCloseTask): (WebCore::DatabaseCloseTask::doPerformTask):
  • storage/DatabaseTask.h: (WebCore::DatabaseCloseTask::create):

2010-04-02 Michael Nordman <Michael Nordman>

Reviewed by Nate Chapin.

Set the close policy used by the DatabaseCloseTask at this callsite to
RemoveDatabaseFromContext. This restores its behavior to what it was prior to
r56293.
​https://bugs.webkit.org/show_bug.cgi?id=37037

  • src/WebDatabase.cpp: (WebKit::WebDatabase::closeDatabaseImmediately):
4:52 PM Changeset in webkit [57033] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-04-02 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Remove an ASSERT that sometimes flakes due to time dependent animations
​https://bugs.webkit.org/show_bug.cgi?id=37048

The outline repaint rectangle for a layer might change between two calls
if there are animations involved, even if nothing in the DOM has actually
changed between the calls.

No change in behavior, no new tests.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
4:45 PM Changeset in webkit [57032] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-04-02 Evan Stade <​estade@chromium.org>

Reviewed by Adam Barth.

[chromium] need DragImage implementation
​https://bugs.webkit.org/show_bug.cgi?id=35811

Add two files that failed to get added in my previous patch.

  • platform/chromium/DragImageChromiumMac.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageChromiumSkia.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
4:30 PM Changeset in webkit [57031] by eric.carlson@apple.com
  • 12 edits in trunk

2010-04-02 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Configure multi-language movies: when QuickTime has sufficiently loaded
the movie, call into wkQTMovieSelectPreferredAlternates to select the
movie's alternate tracks according to the user's language preferences.

​https://bugs.webkit.org/show_bug.cgi?id=36624

  • WebCore.base.exp:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): If the movie is sufficiently loaded, call wkQTMovieSelectPreferredAlternates to set up the alternate tracks.
  • platform/mac/WebCoreSystemInterface.h: Declare WKQTMovieSelectPreferredAlternates.
  • platform/mac/WebCoreSystemInterface.mm: Add WKQTMovieSelectPreferredAlternates.

2010-04-02 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.


​https://bugs.webkit.org/show_bug.cgi?id=36624

Update WebKitSystemInterface

  • WebKitSystemInterface.h: add WKQTMovieSelectPreferredAlternates.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

2010-04-02 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

​https://bugs.webkit.org/show_bug.cgi?id=36624
Add an INIT macro for the WebKitSystemInterface function wkQTMovieSelectPreferredAlternates.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
4:21 PM Changeset in webkit [57030] by jamesr@google.com
  • 3 edits in trunk/WebCore

2010-04-02 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler.

Splits RenderBlock::layoutInline into smaller functions
​https://bugs.webkit.org/show_bug.cgi?id=36921

RenderBlock::layoutInlineChildren is 351 lines long and very difficult
to comprehend or edit safely. This patch splits it up into a few
slightly smaller functions. Most of the code is now in the 241 line
layoutRunsAndFloats() which is a slight improvement.

Perf neutral on the page cyclers. This doesn't introduce any function
calls into the hottest layout paths inside layoutRunsAndFloats and
findNextLineBreak.

No change in behavior, no new tests.

  • rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutReplacedElements): (WebCore::RenderBlock::createLineBoxesForResolver): (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::layoutInlineChildren):
3:57 PM Changeset in webkit [57029] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Symbian] Rebaseline Symbian def file
​https://bugs.webkit.org/show_bug.cgi?id=37038

Switch the ordinal numbers for qtwebkit_webframe_scrollRecursively
and QWebInspector::closeEvent to match QtWebkit 4.6 branch

Fix the signature for qt_drt_setFrameFlatteningEnabled
after r56718.

Add new QtWebKit API symbols introduced not listed in the file yet.

  • symbian/eabi/QtWebKitu.def:
3:48 PM Changeset in webkit [57028] by eric@webkit.org
  • 9 edits
    1 delete in trunk

2010-04-02 Evan Stade <​estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] need DragImage implementation
​https://bugs.webkit.org/show_bug.cgi?id=35811

Basic implementation using SkBitmap. Transformations are not supported
yet. No implementation for mac.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/DragImageChromium.cpp:
  • platform/chromium/DragImageRef.h:

2010-04-02 Evan Stade <​estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] need DragImage implementation
​https://bugs.webkit.org/show_bug.cgi?id=35811

Use the DragImageRef that the DragController passes to us.

  • public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
  • src/WebViewImpl.h:
3:23 PM Changeset in webkit [57027] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-02 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

[chromium] font fallback for generic fonts picks wrong font
​https://bugs.webkit.org/show_bug.cgi?id=37033

When a page specifies the generic "monospace" font and the user's
browser-configured monospace font doesn't exist, we previously relied
on getLastResortFallbackFont to eventually pick a monospace font for us.

But that doesn't quite work: WebKit first falls back to the user's
"preferred standard font" before hitting the last resort code path.
So if the above conditions hold but this font exists, we'll end up
never hitting the last resort codepath.

The fix is to allow OS-level font fallback when first attempting to
resolve monospace. The existing code tried to do this, but the logic
was wrong. We would eventually fall back to the correct font anyway
so we didn't notice the logic was wrong.

This code is all handling cases where particular fonts aren't installed,
so I can't think of a way to test it; existing tests should still pass.

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
3:13 PM Changeset in webkit [57026] by eric@webkit.org
  • 6 edits in trunk/WebKit

2010-04-02 Rafael Weinstein <​rafaelw@chromium.org>

Reviewed by Adam Barth.

Clean up unused calls after changes to checkPermission and requestPermission argument lists.

  • public/WebNotificationPresenter.h:
  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission): (WebKit::NotificationPresenterImpl::requestPermission):

2010-04-02 Rafael Weinstein <​rafaelw@chromium.org>

Reviewed by Adam Barth.

Clean up unused calls after changes to checkPermission and requestPermission argument lists.

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::requestPermission):
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:
2:53 PM Changeset in webkit [57025] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-04-02 Ruben Van Boxem <​vanboxem.ruben@gmail.com>

Reviewed by Eric Seidel.

Mingw-w64 fixes for JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=35607

  • runtime/Collector.cpp: use the msvc code for mingw-w64 (but not mingw-w32) (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr): (JSC::currentThreadStackBase): (JSC::currentThreadStackBase):
  • wtf/Platform.h: added COMPILER(MINGW64) check to differentiate between mingw.org and mingw-w64 functions
2:21 PM Changeset in webkit [57024] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37043
Java regression tests spam stderr about being unable to set status message

With this change, there is still spam about "Attempt to access JavaScript from destroyed
applet, type 9." I haven't investigated if that indicates a problem or not.

  • Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]): Removed check for _documentView. We don't seem to care.
2:18 PM Changeset in webkit [57023] by scherkus@chromium.org
  • 6 edits
    2 adds in trunk

2010-04-02 Andrew Scherkus <​scherkus@chromium.org>

Reviewed by Eric Carlson and Eric Seidel.

Don't stop the playback event timer when media resource loading has suspended.
​https://bugs.webkit.org/show_bug.cgi?id=37003

When a user agent decides to suspend media resource loading and enters the
NETWORK_IDLE state we are supposed to only stop the progress event timer but
keep the playback timer running.

Test: http/tests/media/video-play-suspend.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Only stop the progress event timer.

2010-04-02 Andrew Scherkus <​scherkus@chromium.org>

Reviewed by Eric Carlson and Eric Seidel.

Don't stop the playback event timer when media resource loading has suspended.
​https://bugs.webkit.org/show_bug.cgi?id=37003

When a user agent decides to suspend media resource loading and enters the
NETWORK_IDLE state we are supposed to only stop the progress event timer but
keep the playback timer running.

Currently Chromium is the only platform that fires the suspend event
hence most platforms skipping this test.

  • http/tests/media/video-play-suspend-expected.txt: Added.
  • http/tests/media/video-play-suspend.html: Added.
  • platform/gtk/Skipped: Doesn't fire a suspend event.
  • platform/mac/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
2:01 PM Changeset in webkit [57022] by Darin Adler
  • 3 edits in trunk/WebCore

Fix mispelling that broke the build.

  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/CanvasRenderingContext2D.h:

Dashbard -> Dashboard.

1:40 PM Changeset in webkit [57021] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix: updated the .def file.

1:31 PM Changeset in webkit [57020] by levin@chromium.org
  • 10 edits in trunk

(non-generated) code should only use CanvasRenderingContext::canvas as a CanvasSurface.
​https://bugs.webkit.org/show_bug.cgi?id=36906

Reviewed by Darin Adler.

WebCore:

  • dom/CanvasSurface.cpp: Added methods for items that depended on

CanvasRenderingContext::canvas() being an HTMLElement(), so that this usage
can be dealt with in one place.
(WebCore::CanvasSurface::securityOrigin): Only used by methods that are
only run in the document context.
(WebCore::CanvasSurface::renderBox): Will likely return 0 in a worker context.
(WebCore::CanvasSurface::computedStyle): Used by setFont. Return value is TBD for
the worker context.
(WebCore::CanvasSurface::styleSelector): Ditto.

  • dom/CanvasSurface.h:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext): Passing in information into
the CanvasRenderingContext2D constructor to eliminate some uses of document
inside of the CanvasRenderingContext2D class.

  • html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::renderBox): Added to disambiguate between the
two parent class versions of the method.
(WebCore::HTMLCanvasElement::computedStyle): Ditto.

  • html/canvas/CanvasRenderingContext2D.cpp: All of these changes are about

removing document usage either by using a bool that is set in the constructor or
by calling one of the new methods added to CanvasSurface.
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode):
(WebCore::CanvasRenderingContext2D::checkOrigin):
(WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/WebGLRenderingContext.cpp: Removed some duplicate includes.

(WebCore::WebGLRenderingContext::markContextChanged): Reduced calls to renderBox

as it may become slightly more expensive in the future.

(WebCore::WebGLRenderingContext::reshape): Ditto.

LayoutTests:

  • fast/canvas/script-tests/canvas-gradient-addStop-error.js: Changed the test

to create a new canvas after switching to dashboard compatiblity mode, which is
needed now that the compatibility mode is cached in the canvas.

1:15 PM Changeset in webkit [57019] by ggaren@apple.com
  • 11 edits in trunk/JavaScriptCore

Inlined toThisString and toThisJSString to avoid virtual function call overhead
​https://bugs.webkit.org/show_bug.cgi?id=37039

Reviewed by Oliver Hunt.

Maybe a 1% speedup on iBench JS.

  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSNumberCell.cpp:
  • runtime/JSNumberCell.h:
  • runtime/JSString.cpp:
  • runtime/JSString.h:
  • runtime/JSValue.h:
  • runtime/JSZombie.h:

(JSC::JSZombie::toThisObject): Nixed the old virtual-type implementation.

  • runtime/JSObject.h:

(JSC::JSValue::toThisString):
(JSC::JSValue::toThisJSString): Added the inlined implementation.

1:03 PM Changeset in webkit [57018] by eric@webkit.org
  • 14 edits
    2 adds in trunk

2010-04-02 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

Implement and test new framebuffer object attachment behavior.
​https://bugs.webkit.org/show_bug.cgi?id=35611

  • fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added, test framebuffer object attachment behavior.
  • fast/canvas/webgl/framebuffer-object-attachment.html: Added, framebuffer object attachment behavior.
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js: DEPTH_COMPONENT is no longer a valid input, use DEPTH_COMPONENT16 instead.
  • platform/mac-snowleopard/Skipped: The bot does not support EXT_packed_depth_stencil, skip the framebuffer-object-attachment.html test.

2010-04-02 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

Implement and test new framebuffer object attachment behavior.
​https://bugs.webkit.org/show_bug.cgi?id=35611

Test: fast/canvas/webgl/framebuffer-object-attachment.html

  • html/canvas/WebGLFramebuffer.cpp: Keep track of attached stencil/depth renderbuffers in WebGLFramebuffer. (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::setIsAttached):
  • html/canvas/WebGLFramebuffer.h: Ditto. (WebCore::WebGLFramebuffer::isDepthAttached): (WebCore::WebGLFramebuffer::isStencilAttached): (WebCore::WebGLFramebuffer::isDepthStencilAttached):
  • html/canvas/WebGLRenderbuffer.cpp: Keep track of internalformat. (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
  • html/canvas/WebGLRenderbuffer.h: Ditto. (WebCore::WebGLRenderbuffer::setInternalformat): (WebCore::WebGLRenderbuffer::getInternalformat):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Detect stencil/depth buffer conflicts. (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Handling DEPTH_STENCIL case. (WebCore::WebGLRenderingContext::getRenderbufferParameter): Get correct WebGL internalformat. (WebCore::WebGLRenderingContext::renderbufferStorage): Detect illegal enums.
  • html/canvas/WebGLRenderingContext.idl: Add DEPTH_STENCIL enums.
  • platform/graphics/GraphicsContext3D.h: Add DEPTH_STENCIL enums. (WebCore::GraphicsContext3D::):
  • platform/graphics/mac/GraphicsContext3DMac.cpp: Map to correct DEPTH_STENCIL format. (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):

2010-04-02 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

Implement and test new framebuffer object attachment behavior.
​https://bugs.webkit.org/show_bug.cgi?id=35611

Test: fast/canvas/webgl/framebuffer-object-attachment.html

  • src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format. (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv): (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage):
12:55 PM Changeset in webkit [57017] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

Stored focused frame and document in a vars, instead of querying for them many times.

Reviewed by Adam Treat.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • Api/qwebpage.cpp:

(QWebPagePrivate::mousePressEvent(QEvent* ev)):
(QWebPagePrivate::mousePressEvent(QGraphicsSceneMouseEvent* ev):

12:51 PM Changeset in webkit [57016] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-02 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Geoffrey Garen.

Beef up documentation for ASSERT* and CRASH macros a bit.

​https://bugs.webkit.org/show_bug.cgi?id=36527

  • wtf/Assertions.h:
12:21 PM Changeset in webkit [57015] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-02 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
​https://bugs.webkit.org/show_bug.cgi?id=36908

  • fast/canvas/webgl/index-validation-expected.txt: Gathering more information about the cause of the failure. It's not a fix, and it won't worse change the current test behavior either, i.e., it won't make it better or worse.
  • fast/canvas/webgl/script-tests/index-validation.js: Ditto.
12:11 PM Changeset in webkit [57014] by eric@webkit.org
  • 4 edits
    1 add in trunk/WebKit/chromium

2010-04-02 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

The popup type (select or suggestion) is now passed to the
WebClient::createPopupMenu() method. This is required for
Chromium on Linux to make the select popups work correctly.
​https://bugs.webkit.org/show_bug.cgi?id=37013

  • WebKit.gyp:
  • public/WebPopupType.h: Added. (WebKit::):
  • public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
  • src/ChromeClientImpl.cpp: (WebCore::convertPopupType): (WebKit::ChromeClientImpl::popupOpened):
12:09 PM Changeset in webkit [57013] by tkent@chromium.org
  • 5 edits
    2 adds in trunk

2010-04-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Form control state shouldn't be restored for hidden inputs.
​https://bugs.webkit.org/show_bug.cgi?id=26241

  • fast/forms/button-state-restore.html: Updated for the behavior change.
  • fast/forms/state-restore-to-non-edited-controls-expected.txt: Added.
  • fast/forms/state-restore-to-non-edited-controls.html: Added.

2010-04-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Form control state shouldn't be restored for hidden inputs.
​https://bugs.webkit.org/show_bug.cgi?id=26241

To fix this issue, we don't save values if it is not changed from
the default value.

Updating the value IDL attribute of some controls such as
type=hidden also updates the value content attribute, and it's
impossible to distinguish the initial value and the current
value. The values of such controls are not saved. It won't be a
problem because we want to save and restore user-edited values.

Test: fast/forms/state-restore-to-non-edited-controls.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::saveFormControlState): Do not save the value if it is same as the default value.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::saveFormControlState): ditto.
11:31 AM Changeset in webkit [57012] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2010-04-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Forms with autocomplete=off should not consume saved state
​https://bugs.webkit.org/show_bug.cgi?id=36762

  • fast/forms/state-restore-to-non-autocomplete-form-expected.txt: Added.
  • fast/forms/state-restore-to-non-autocomplete-form.html: Added.

2010-04-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Forms with autocomplete=off should not consume saved state
​https://bugs.webkit.org/show_bug.cgi?id=36762

Introduce Element::shouldSaveAndRestoreFormControlState() to check
if we should save and restore control state.

Test: fast/forms/state-restore-to-non-autocomplete-form.html

  • dom/Document.cpp: (WebCore::Document::formElementsState): Check shouldSaveAndRestoreFormControlState().
  • dom/Element.h: (WebCore::Element::shouldSaveAndRestoreFormControlState): Added. It just returns true.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::autoComplete): Added. It return autocomplete state of the form. (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): Added. It returns the result of autoComplete(). (WebCore::HTMLFormControlElementWithState::finishParsingChildren): Do not restore state if shouldSaveAndRestoreFormControlState() is false.
  • html/HTMLFormControlElement.h: Declare autoComplete() and overriding methods.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::autoComplete): Reduce code by using autoComplete() of the parent class. (WebCore::HTMLInputElement::saveFormControlState): Remove the autoComplete() check. Document::formElementsState() does equivalent check.
11:03 AM Changeset in webkit [57011] by levin@chromium.org
  • 4 edits in trunk/WebKitTools

sherrifbot should ensure that the rollout reason doesn't start with - (and fix webkit-patch upload).
​https://bugs.webkit.org/show_bug.cgi?id=37030

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/sheriff.py: Ensure that the rollout reason doesn't start with -.
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: A test with a rollout reason which starts with -.
  • Scripts/webkitpy/tool/steps/createbug.py: Fix webkit-patch upload.
10:41 AM Changeset in webkit [57010] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

Unreviewed.

Fixed check-webkit-style to recognize the short form of the
--verbose option, as stated in --help.

  • Scripts/check-webkit-style:
    • Tweaked one line.
10:40 AM Changeset in webkit [57009] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-04-02 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Avoid doing work in FrameView::scrollPositionChanged() if there are no fixed position elements
​https://bugs.webkit.org/show_bug.cgi?id=36994

r55890 added knowledge to FrameView about whether it contains any fixed-position elements. We can
use this to avoid updating widget positions, and compositing layer positions when possible.

  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged):
  • page/FrameView.h: (WebCore::FrameView::hasFixedObjects):
10:33 AM Changeset in webkit [57008] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-04-02 Nate Chapin <Nate Chapin>

Rubber-stamped by Dimitri Glazkov.

​http://trac.webkit.org/changeset/57004 caused
fast/dom/console-log-stack-overflow.html to fail for Chromium.
Add check for empty wrappers before using them to create a hidden reference.

  • bindings/scripts/CodeGeneratorV8.pm:
10:24 AM Changeset in webkit [57007] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-02 Dirk Schulze <​krit@webkit.org>

Unreviewed.

[Gtk] LayoutTest feColorMatrix-value with different results over Gtk bots
​https://bugs.webkit.org/show_bug.cgi?id=37029

Adding svg/filters/feColorMatrix-values.svg to the Gtk skip list. Opened
the bug report from above.

  • platform/gtk/Skipped:
10:01 AM Changeset in webkit [57006] by eric@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-04-02 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

Incorrect insertion position after typing 'ำ' (THAI CHARACTER SARA AM = 0E33)
​https://bugs.webkit.org/show_bug.cgi?id=36858

Add failing results for Tiger to make the Tiger bot green.
We may wish to actually fix Tiger at some point.

  • platform/mac-tiger/fast/text/multiglyph-characters-expected.txt: Added.
9:45 AM Changeset in webkit [57005] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix for DumpRenderTree after addition of layerTreeAsText.

9:40 AM Changeset in webkit [57004] by Nate Chapin
  • 14 edits
    4 deletes in trunk/WebCore

2010-04-01 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Generalize (and generate!) the creation of hidden references
between JS wrappers.


​https://bugs.webkit.org/show_bug.cgi?id=36777

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm: Generate calls to setHiddenReference() in attribute getters.
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenReference): Split common logic out of hidden setHiddenWindowReference (WebCore::V8DOMWrapper::setHiddenWindowReference): Now contains logic specific to putting a hidden reference on a global object. (WebCore::globalObjectPrototypeIsDOMWindow): Be more thorough in the COMPILE_ASSERTs. (WebCore::V8DOMWrapper::convertEventTargetToV8Object): Cleanup: Remove a duplicate if statement.
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/WrapperTypeInfo.h:
  • bindings/v8/custom/V8BarInfoCustom.cpp: Removed.
  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8DOMSelectionCustom.cpp: Removed.
  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
  • bindings/v8/custom/V8ScreenCustom.cpp: Removed.
  • bindings/v8/custom/V8StyleSheetCustom.cpp: (WebCore::toV8):
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::frame): Add frame() accessor.
8:43 AM Changeset in webkit [57003] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2010-04-01 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: start editing DOM and styles on click-and-pause (part 1).

​https://bugs.webkit.org/show_bug.cgi?id=36965

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onattach): (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._handleClickAndPause): (WebInspector.ElementsTreeElement.prototype._startEditingTarget): (WebInspector.ElementsTreeElement.prototype._startEditingAttribute): (WebInspector.ElementsTreeElement.prototype._startEditingTextNode): (WebInspector.ElementsTreeElement.prototype._startEditingTagName): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick): (WebInspector.StylePropertiesSection.prototype._handleSelectorClick): (WebInspector.StylePropertiesSection.prototype._handleSelectorClickAndPause): (WebInspector.StylePropertiesSection.prototype._handleSelectorDoubleClick): (WebInspector.StylePropertiesSection.prototype._startEditingOnMouseEvent): (WebInspector.StylePropertyTreeElement.prototype.onattach): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js:
  • inspector/front-end/treeoutline.js: (TreeElement.prototype._attach): (TreeElement.treeElementMouseDown): (TreeElement.prototype.selectOnMouseDown):
8:07 AM Changeset in webkit [57002] by darin@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-02 Darin Fisher <​darin@chromium.org>

Add chromium suppression for http/tests/xhtmlmp since we do not support
this feature.

  • platform/chromium/test_expectations.txt:
7:54 AM Changeset in webkit [57001] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Unreviewed, minor build fix.

Change the order of the member initialisation list
in constructor to match declaration order

  • runtime/Collector.cpp: (JSC::Heap::Heap):
6:41 AM WebKit Team edited by chang.shu@nokia.com
(diff)
6:05 AM Changeset in webkit [57000] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix when building --no-svg.

Build fix after r56941. Add ENABLE(SVG) guard.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
5:55 AM Changeset in webkit [56999] by yurys@chromium.org
  • 14 edits
    1 copy
    1 add in trunk

2010-04-02 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Implement InspectorFrontendHost::showContextMenu for Chromium.


Move inspector frontend context menu code from InspectorFrontendClient to InspectorFrontendHost as it's platform independent.


​https://bugs.webkit.org/show_bug.cgi?id=36817

  • WebCore.Inspector.exp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::FrontendMenuProvider::create): (WebCore::FrontendMenuProvider::disconnect): (WebCore::FrontendMenuProvider::FrontendMenuProvider): (WebCore::FrontendMenuProvider::~FrontendMenuProvider): (WebCore::FrontendMenuProvider::populateContextMenu): (WebCore::FrontendMenuProvider::contextMenuItemSelected): (WebCore::FrontendMenuProvider::contextMenuCleared): (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::disconnectClient): (WebCore::InspectorFrontendHost::showContextMenu):
  • inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::create):

2010-04-02 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Implement InspectorFrontendClient in Chromium and remove all custom bindings for the host methods from WebDevToolsFrontendImpl.

​https://bugs.webkit.org/show_bug.cgi?id=36817

  • WebKit.gyp:
  • src/InspectorFrontendClientImpl.cpp: Added. (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl): (WebKit::InspectorFrontendClientImpl::~InspectorFrontendClientImpl): (WebKit::InspectorFrontendClientImpl::windowObjectCleared): (WebKit::InspectorFrontendClientImpl::frontendLoaded): (WebKit::InspectorFrontendClientImpl::moveWindowBy): (WebKit::InspectorFrontendClientImpl::localizedStringsURL): (WebKit::InspectorFrontendClientImpl::hiddenPanels): (WebKit::InspectorFrontendClientImpl::bringToFront): (WebKit::InspectorFrontendClientImpl::closeWindow): (WebKit::InspectorFrontendClientImpl::canAttachWindow): (WebKit::InspectorFrontendClientImpl::attachWindow): (WebKit::InspectorFrontendClientImpl::detachWindow): (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight): (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
  • src/InspectorFrontendClientImpl.h: Added.
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
  • src/WebDevToolsFrontendImpl.h:
  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_):
  • src/js/DevTools.js: ():
5:18 AM Changeset in webkit [56998] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/xmlhttprequest/access-control-response-with-body.html was introduced in r56955,
but it fails: "NETWORK_ERR: XMLHttpRequest Exception 101: A network error occured in synchronous requests."

  • platform/qt/Skipped: http/tests/xmlhttprequest/access-control-response-with-body.html skipped.
5:17 AM Changeset in webkit [56997] by loislo@chromium.org
  • 4 edits in trunk/WebCore

2010-04-02 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Timeline Overview pane should support short records filtering.
​https://bugs.webkit.org/show_bug.cgi?id=37020

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.update.markTimeline): (WebInspector.TimelineOverviewPane.prototype.update):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelinePanel.FormattedRecord.prototype.isLong):
4:25 AM Changeset in webkit [56996] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Platform specific expected file added for test introduced in r56775,
because it passes. Compared to png file and Mac expected file.

  • platform/qt/svg/custom/animation-currentColor-expected.txt: Added.
3:10 AM Changeset in webkit [56995] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Update the expectation for fast/dom/HTMLProgressElement/set-progress-properties.html

2:31 AM Changeset in webkit [56994] by eric@webkit.org
  • 8 edits
    3 adds in trunk

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Accept XHTML-MP content type as XHTML content
​https://bugs.webkit.org/show_bug.cgi?id=34262

Add a simple test that fails if XHTML-MP mime
type is not accepted.

  • http/conf/mime.types: Register XHTML-MP mime type with the test server
  • http/tests/xhtmlmp: Added.
  • http/tests/xhtmlmp/xhtml-expected.txt: Added.
  • http/tests/xhtmlmp/xhtml.xhtmlmp: Added. Testcase with the newly registered file extension.

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Accept XHTML-MP content type as XHTML content
​https://bugs.webkit.org/show_bug.cgi?id=34262

Enable processing XHTML-MP mime type as an XHTML document
even if XHTML-MP support is not enabled.

  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Accept XHTML-MP content type as XHTML content
​https://bugs.webkit.org/show_bug.cgi?id=34262

Register xhtmlmp file extension as the new type
for XHTML-MP test content.

  • Scripts/run-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/port/lighttpd.conf:
2:20 AM Changeset in webkit [56993] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

create-rollout doesn't fill out ChangeLog
​https://bugs.webkit.org/show_bug.cgi?id=37010

The contract between apply_reverse_diff and PrepareChangeLogForRevert
was unclear. I broke filling out the ChangeLog during rollout earlier
when I changed apply_reverse_diff to revert the ChangeLogs because
PrepareChangeLogForRevert thought that it was supposed to do that.
I've now taught PrepareChangeLogsForRevert the new contract.

It's unclear to me how to test this change because it's essentially an
integration issue that requires the file system. At some point we
should think about a testing strategy for integration. As the system
becomes larger, we're running into more of these issues.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2:10 AM Changeset in webkit [56992] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add cr-win-ews to QueueStatusServer
​https://bugs.webkit.org/show_bug.cgi?id=37004

  • QueueStatusServer/model/queues.py:
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/statusbubble.html:
2:00 AM Changeset in webkit [56991] by eric@webkit.org
  • 7 edits
    1 add in trunk/WebCore

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

Make XSSAuditor go fast with large POST data
​https://bugs.webkit.org/show_bug.cgi?id=36694

There were two things slowing down this bechmark:

1) Searching the large POST data for each inline event handler. To

make this faster, we now use a suffix tree to fast-reject strings
that don't appear as substrings of the POST data.

2) The next largest cost was flattening the form data into a string.

To make this fater, we now use the form data object itself as a key
and only flatten once.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): (WebCore::XSSAuditor::CachingURLCanonicalizer::clear): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h: (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): (WebCore::XSSAuditor::CachingURLCanonicalizer::generation):
  • platform/text/SuffixTree.h: Added. (WebCore::UnicodeCodebook::codeWord): (WebCore::UnicodeCodebook::): (WebCore::ASCIICodebook::codeWord): (WebCore::ASCIICodebook::): (WebCore::SuffixTree::SuffixTree): (WebCore::SuffixTree::mightContain): (WebCore::SuffixTree::Node::Node): (WebCore::SuffixTree::Node::~Node): (WebCore::SuffixTree::Node::at): (WebCore::SuffixTree::build):
1:33 AM Changeset in webkit [56990] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-02 Kent Tamura <​tkent@chromium.org>

Unreviewed test fix. Follow the behavior change by r56962.

  • editing/selection/4960137.html:
1:31 AM Changeset in webkit [56989] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-02 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Eric Seidel.

Bug 36741 - Duplicate, slightly divergent implementation of Position[Iterator]::isCandidate()
​https://bugs.webkit.org/show_bug.cgi?id=36741

Patch: change Position::isCandididate() to call the PositionIterator::isCandidate() version.
Update PositionIterator::isCandidate() to mirror Position::isCandidate().

Rationale: PositionIterator::isCandidate() is called in a tight loop within
next/previousCandidate(). Also, creation of a PositionIterator from a Position
is cheaper than vice-versa.

Tests: ran all tests in 'editing'.

  • dom/Position.cpp: (WebCore::Position::isCandidate):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
1:31 AM Changeset in webkit [56988] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-04-02 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

Unit-test networktransaction.py's log messages, and add a base
class to make unit-testing log messages even easier.

​https://bugs.webkit.org/show_bug.cgi?id=36958

The purpose of this patch is also to provide a mini-tutorial on
how to unit-test Python logging.py messages.

  • Scripts/webkitpy/common/net/networktransaction_unittest.py:
    • Unit-tested the log messages in test_retry().
  • Scripts/webkitpy/common/system/logtesting.py:
    • Adjusted the LogTesting class by moving the code that clears the array of log messages into a finally block. This prevents redundant AssertionErrors from getting rendered to the screen while running unit tests.
    • Added a LoggingTestCase class so the setUp() and tearDown() methods do not need to be implemented in order to test logging. Rather, TestCase classes can simply inherit from this class.
1:27 AM Changeset in webkit [56987] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-04-02 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Re-wrote check-webkit-style's argument parsing code to use
Python's optparser module and more uniform error-handling logic.

​https://bugs.webkit.org/show_bug.cgi?id=34676

  • Scripts/webkitpy/style/optparser.py:
    • Removed "option help" from check-webkit-style's usage string since that is provided separately by the OptionParser class.
    • Also changed the usage string from a function to a constant string _USAGE.
    • Added an _EPILOG string which renders after OptionParser's usage string and option help.
    • In the ArgumentParser class:
      • Changed the constructor's stderr_write parameter to a mock_stderr since the OptionParser accepts a sys.stderr substitute rather than a sys.stderr.write substitute.
      • Changed the constructor to set a _parser data attribute with an OptionParser instance.
      • Added a _create_option_parser() method which instantiates the OptionParser.
      • Updated _exit_with_help() to interact with the OptionParser's help method.
      • Updated the parse() method as necessary. Also changed the raising of ValueErrors to calls to _exit_with_help().
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Removed the CreateUsageTest class since the create_usage method was replaced by a constant string.
    • Added a _MockStdErr class to the ArgumentParserTest class.
    • Updated the unit tests as necessary.
1:18 AM Changeset in webkit [56986] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

The master commit-queue process should take responsibility for checking that the builders are green
​https://bugs.webkit.org/show_bug.cgi?id=37009

We had a failure where the child process noticed that the builders were
red. We've always had this race condition, but the new optimistic
design made it easier to trigger.

  • Scripts/webkitpy/tool/commands/queues.py:
1:18 AM Changeset in webkit [56985] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Tweak rollout changelog to pass ValidateReviewer check
​https://bugs.webkit.org/show_bug.cgi?id=37019

We need to use the magic word "unreviewed" to make the commit-queue
happy when landing rollouts.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
1:16 AM Changeset in webkit [56984] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-02 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_SETTINGS
​https://bugs.webkit.org/show_bug.cgi?id=36533

If QT_NO_SETTINGS is defined, QSettings is not available.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): (WebCore::InspectorClientQt::storeSetting):
1:13 AM Changeset in webkit [56983] by Chris Jerdonek
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed.

Removed duplicate ChangeLog entry.

1:04 AM Changeset in webkit [56982] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-02 Eric Seidel <​eric@webkit.org>

Unreviewed, just updating expected results for passing tests.

suppress image failures for now to get a clean test run w/ pixel tests enabled for new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=36620

Remove several tests marked MISSING which no longer seem to be missing.

  • platform/mac/test_expectations.txt:
1:03 AM Changeset in webkit [56981] by Chris Jerdonek
  • 4 edits in trunk/WebKitTools

Rubber-stamped by Eric Seidel.

To the Python 2.4 error message, added a link to the wiki page
that contains instructions on how to upgrade.

  • Scripts/test-webkitpy:
    • Eliminated a use of the ternary operator in configure_logging() to let the version warning display in case of Python 2.4.
  • Scripts/webkitpy/python24/versioning_unittest.py:
    • Updated unit test text.
12:39 AM Changeset in webkit [56980] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-04-02 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - customized popup for <select multiple> elements
​https://bugs.webkit.org/show_bug.cgi?id=36368

Using QtMaemoWebPopup instead of QtFallbackWebPopup for Maemo.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate):
12:30 AM Changeset in webkit [56979] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(56295): http/tests/security/xssAuditor/xss-protection-parsing-01.html times out on Tiger Bot
​https://bugs.webkit.org/show_bug.cgi?id=36933

Change the test design in an attempt to get this passing on Tiger. In
this variation, we use a POST request to work around possible caching
issues in Tiger's CFNetwork.

  • http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-01.html:
12:25 AM Changeset in webkit [56978] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Database code falsely returns errors due to errant pointer check
​https://bugs.webkit.org/show_bug.cgi?id=37014

Reviewed by Dan Bernstein.

r56943 introduced a check to see if there were any unprocessed
SQL commands after calling sqlite3_prepare16_v2.

Accessing the remaining data via pointer wasn't possible since
the query string is deallocated immediately after the
query runs. The String returned from strippedWhiteSpace
goes out of scope at that point.

Fix is to store the strippedWhiteSpace in a temporary String
so we can access it via character ptr later in the function.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

12:14 AM Changeset in webkit [56977] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Record the IRC nick of folks who request rollouts
​https://bugs.webkit.org/show_bug.cgi?id=36999

  • Scripts/webkitpy/common/net/irc/ircbot.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
12:04 AM Changeset in webkit [56976] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add cr-win-ews
​https://bugs.webkit.org/show_bug.cgi?id=36974

Adds support for an Early Warning System for Chromium on Linux. The
interface to the Chromium port is the same on every platform, so we
don't need to create a new Port object for this queue.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Note: See TracTimeline for information about the timeline view.