Context Navigation

← Previous Period
Next Period →

Timeline

Apr 10, 2010:

11:57 PM Changeset in webkit [57445] by abarth@webkit.org

4 edits in trunk/WebCore

2010-04-10 Adam Barth <abarth@webkit.org>

Unreviewed. Rename m_forceSandboxFlags to m_forcedSandoxFlags, as
requested by Darin Adler.

loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::updateSandboxFlags):
loader/FrameLoader.h: (WebCore::FrameLoader::setForcedSandboxFlags):
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

11:52 PM Changeset in webkit [57444] by abarth@webkit.org

9 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

kill_process is copy/pasted in five places
https://bugs.webkit.org/show_bug.cgi?id=37405

We shouldn't replicate the kill_process logic in every port. Instead,
we should move the process interaction to Executive.

Dirk mentioned that he wanted this abstraction to make it easier to
mock things out for testing. It turns out this function is only used
in one place where it can't be used as a mock point for testing because
the corresponding create process actually creates a real process. In
the long term, we should indirect both these calls through a non-static
Executive as a mock point. However, we should wait on that until we
actually want to write the test.

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/chromium_linux.py:
Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/websocket_server.py:
Scripts/webkitpy/layout_tests/port/win.py:

11:13 PM Changeset in webkit [57443] by abarth@webkit.org

10 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests shouldn't alter its path to import packages
https://bugs.webkit.org/show_bug.cgi?id=37404

Scripts/new-run-webkit-tests:
Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
Scripts/webkitpy/layout_tests/test_types/image_diff.py:
Scripts/webkitpy/layout_tests/test_types/text_diff.py:
Scripts/webkitpy/thirdparty/simplejson/decoder.py:

11:05 PM Changeset in webkit [57442] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests should store results to a directory under the build tree
https://bugs.webkit.org/show_bug.cgi?id=37380

Scripts/webkitpy/layout_tests/port/webkit.py:

10:57 PM Changeset in webkit [57441] by mrowe@apple.com

8 edits
1 move in trunk

<rdar://problem/7845305> Further adoption of formal protocols for delegates.

Reviewed by Dan Bernstein.

Move EmptyProtocolDefinitions.h down in to WebCore, and add the new protocols. Adopt the protocols in the appropriate places.

WebCore:

WebCore.xcodeproj/project.pbxproj:
platform/mac/EmptyProtocolDefinitions.h: Renamed from WebKit/mac/Misc/EmptyProtocolDefinitions.h.
platform/network/mac/ResourceHandleMac.mm:

WebKit:

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Misc/EmptyProtocolDefinitions.h: Removed.
Misc/WebDownload.mm:
WebKitPrefix.h:

10:46 PM Changeset in webkit [57440] by eric@webkit.org

4 edits
3 adds in trunk/WebKitTools

2010-04-10 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27204

Implement support for changing the executable bit of a file.
The executable bit is among the most changed file properties.
Future support can include other property changes.

Currently, if a patch changes the executable bit of a file
it is not respected by svn-apply or svn-unapply. Since the
commit-queue bot uses these tools as part of its workflow,
such patches cannot be committed by it. That is, such patches
need to be committed by hand. Instead, we should add support
for the executable bit so that such patches can be committed
by the commit-queue bot.

Scripts/VCSUtils.pm: Also change reference to Apple Computer, Inc. in copyright to Apple, Inc.
Scripts/svn-apply:
Scripts/svn-unapply:
Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Added.
Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Added.
Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Added.

10:27 PM Changeset in webkit [57439] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-04-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WinEWS bot fails to svn update because scm.clean_working_directory leaves files around
https://bugs.webkit.org/show_bug.cgi?id=37401

The Git-based bots don't have this trouble because
Git.clean_working_directory fully removes files that were
marked as "add". SVN.clean_working_directory previously just
called "svn revert" which would leave added files in the
working directory untracked. This patch makes
SVN.clean_working_directory function more like
Git.clean_working_directory by removing added files after revert.

Scripts/webkitpy/common/checkout/scm.py:
- Add SCM.absolute_path for easy conversion between repository-relative paths and absolute paths.
- Add SCM.add and SCM.added_files
- Make SVN.clean_working_directory remove any added_files after svn revert.
- The new unit tests found a bug in Git.status_command, change to use git diff --name-status instead.
Scripts/webkitpy/common/checkout/scm_unittest.py:
- Add tests for added code.

10:17 PM Changeset in webkit [57438] by eric@webkit.org

4 edits in trunk/WebCore

2010-04-10 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Defense in depth: make sure an SVG document in the <img> context has
a unique origin.

https://bugs.webkit.org/show_bug.cgi?id=37392

svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Force the temporary rendering context into a unique origin.
loader/FrameLoader.h: (WebCore::FrameLoader::setForceSandboxFlags): Support for setting sandbox flags that will always be applied.
loader/FrameLoader.cpp: (WebCore::FrameLoader::updateSandboxFlags): Always apply any forced flags.

10:10 PM Changeset in webkit [57437] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests can't find ImageDiff on Windows
https://bugs.webkit.org/show_bug.cgi?id=37403

It turns out the build directory on Windows is structured differently
than it is on other platforms. Instead of assuming the normal
structure, we should just ask perl to figure it out for us.

Scripts/webkitpy/layout_tests/port/webkit.py:

10:03 PM Changeset in webkit [57436] by eric@webkit.org

4 edits
6 moves in trunk

2010-04-10 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Moving files associated with the GPU compositor from platform/graphics/skia to platform/graphics/chromium. Class
rename was done in a previous CL, this CL does the file move and rename.
https://bugs.webkit.org/show_bug.cgi?id=37231

No new functionality, no new tests.

WebCore.gypi:
platform/graphics/chromium/GraphicsLayerChromium.cpp: Copied from WebCore/platform/graphics/skia/GraphicsLayerSkia.cpp.
platform/graphics/chromium/GraphicsLayerChromium.h: Copied from WebCore/platform/graphics/skia/GraphicsLayerSkia.h.
platform/graphics/chromium/LayerChromium.cpp: Copied from WebCore/platform/graphics/skia/LayerSkia.cpp.
platform/graphics/chromium/LayerChromium.h: Copied from WebCore/platform/graphics/skia/LayerSkia.h.
platform/graphics/chromium/LayerRendererChromium.cpp: Copied from WebCore/platform/graphics/skia/LayerRendererSkia.cpp.
platform/graphics/chromium/LayerRendererChromium.h: Copied from WebCore/platform/graphics/skia/LayerRendererSkia.h.
platform/graphics/skia/GraphicsLayerSkia.cpp: Removed.
platform/graphics/skia/GraphicsLayerSkia.h: Removed.
platform/graphics/skia/LayerRendererSkia.cpp: Removed.
platform/graphics/skia/LayerRendererSkia.h: Removed.
platform/graphics/skia/LayerSkia.cpp: Removed.
platform/graphics/skia/LayerSkia.h: Removed.

2010-04-10 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Include file change as a result of renaming LayerRenderSkia.h to LayerRenderChromium.h
https://bugs.webkit.org/show_bug.cgi?id=37231

src/WebViewImpl.h:

9:03 PM Changeset in webkit [57435] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Change "Gathering files" status line to "Collecting tests". Gathering
the files sounds silly to me.

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

8:51 PM Changeset in webkit [57434] by abarth@webkit.org

4 edits
1 add in trunk

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix bugs to make new-run-webkit-tests almost run on windows
https://bugs.webkit.org/show_bug.cgi?id=37400

Add an empty test expectations file. I'm not sure whether we'll use
this one or make a common one for each port. However, as written, this
file is requires to run new-run-webkit-tests on Windows.

platform/win/test_expectations.txt: Added.

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix bugs to make new-run-webkit-tests almost run on windows
https://bugs.webkit.org/show_bug.cgi?id=37400

Fix some minor bugs that prevent new-run-webkit-tests from being run on
Windows. I still haven't run it to completion, but I'm getting
further.

Scripts/webkitpy/layout_tests/port/factory.py:
Scripts/webkitpy/layout_tests/port/webkit.py:

6:35 PM Changeset in webkit [57433] by eric@webkit.org

17 edits
2 adds in trunk

2010-04-10 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Refactor Qt DRT support in QtWebKit

https://bugs.webkit.org/show_bug.cgi?id=35844

WebCore.pro: Add DumpRenderTreeSupportQt.cpp

2010-04-10 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Refactor Qt DRT support in QtWebKit

Move all QT DRT support functions to a static class.

https://bugs.webkit.org/show_bug.cgi?id=35844

Api/qwebframe.cpp: Remove static functions.
Api/qwebframe.h: Make DumpRenderTreeSupportQt a friend.
Api/qwebpage.cpp: Remove static functions.
Api/qwebpage.h: Make DumpRenderTreeSupportQt a friend.
Api/qwebsecurityorigin.cpp: Remove static functions.
WebCoreSupport/DumpRenderTreeSupportQt.cpp: Added. (DumpRenderTreeSupportQt::DumpRenderTreeSupportQt): (DumpRenderTreeSupportQt::~DumpRenderTreeSupportQt): (DumpRenderTreeSupportQt::overwritePluginDirectories): (DumpRenderTreeSupportQt::workerThreadCount): (DumpRenderTreeSupportQt::setDumpRenderTreeModeEnabled): (DumpRenderTreeSupportQt::setFrameFlatteningEnabled): (DumpRenderTreeSupportQt::webPageSetGroupName): (DumpRenderTreeSupportQt::webPageGroupName): (DumpRenderTreeSupportQt::webInspectorExecuteScript): (DumpRenderTreeSupportQt::webInspectorClose): (DumpRenderTreeSupportQt::webInspectorShow): (DumpRenderTreeSupportQt::setTimelineProfilingEnabled): (DumpRenderTreeSupportQt::hasDocumentElement): (DumpRenderTreeSupportQt::setJavaScriptProfilingEnabled): (DumpRenderTreeSupportQt::pauseAnimation): (DumpRenderTreeSupportQt::pauseTransitionOfProperty): (DumpRenderTreeSupportQt::pauseSVGAnimation): (DumpRenderTreeSupportQt::numberOfActiveAnimations): (DumpRenderTreeSupportQt::clearFrameName): (DumpRenderTreeSupportQt::javaScriptObjectsCount): (DumpRenderTreeSupportQt::garbageCollectorCollect): (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread): (DumpRenderTreeSupportQt::counterValueForElementById): (DumpRenderTreeSupportQt::pageNumberForElementById): (DumpRenderTreeSupportQt::numberOfPages): (DumpRenderTreeSupportQt::suspendActiveDOMObjects): (DumpRenderTreeSupportQt::resumeActiveDOMObjects): (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld): (DumpRenderTreeSupportQt::whiteListAccessFromOrigin): (DumpRenderTreeSupportQt::resetOriginAccessWhiteLists): (DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme): (DumpRenderTreeSupportQt::setCaretBrowsingEnabled): (DumpRenderTreeSupportQt::setMediaType): (DumpRenderTreeSupportQt::setViewMode):
WebCoreSupport/DumpRenderTreeSupportQt.h: Added.
WebCoreSupport/EditorClientQt.h:
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::multiplePageGroupsAndLocalStorage): (tst_QWebPage::inputMethodsTextFormat): (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):

2010-04-10 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Refactor Qt DRT support in QtWebKit

Update Qt DRT to use new DumpRenderTreeSupportQt static class.

https://bugs.webkit.org/show_bug.cgi?id=35844

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::dumpFramesAsText):
DumpRenderTree/qt/DumpRenderTreeQt.h:
DumpRenderTree/qt/GCControllerQt.cpp: (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
DumpRenderTree/qt/GCControllerQt.h:
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::counterValueForElementById): (LayoutTestController::setViewModeMediaFeature): (LayoutTestController::setMediaType): (LayoutTestController::closeWebInspector): (LayoutTestController::showWebInspector): (LayoutTestController::evaluateInWebInspector): (LayoutTestController::setFrameFlatteningEnabled): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setTimelineProfilingEnabled): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::sampleSVGAnimationForElementAtTime): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::whiteListAccessFromOrigin): (LayoutTestController::setCaretBrowsingEnabled): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): (LayoutTestController::workerThreadCount): (LayoutTestController::pageNumberForElementById): (LayoutTestController::numberOfPages):
DumpRenderTree/qt/LayoutTestControllerQt.h:

6:25 PM Changeset in webkit [57432] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move global queue log to the logs directory so it survives git clean -f
https://bugs.webkit.org/show_bug.cgi?id=37395

Scripts/webkitpy/tool/commands/queues.py:

6:16 PM Changeset in webkit [57431] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-04-10 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Eric Seidel.

Cleanup after chromium breakage. All interface methods are
returned to being abstract.

public/WebNotificationPresenter.h:

6:06 PM Changeset in webkit [57430] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should spam when it encounters errors
https://bugs.webkit.org/show_bug.cgi?id=37329

We need to always update the status server so we don't get stuck in a
spam loop. I tried writing a test for this change, but it kind of
got out of control. We need a better way to do failure injection.

Scripts/webkitpy/tool/commands/sheriffbot.py:

5:51 PM Changeset in webkit [57429] by Joseph Pecoraro

4 edits in trunk/WebCore

2010-04-10 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Missing CONTEXT_MENUS Guards
https://bugs.webkit.org/show_bug.cgi?id=37398

Added missing ENABLE(CONTEXT_MENUS) guards.

bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::disconnectClient):
inspector/InspectorFrontendHost.h:

5:49 PM Changeset in webkit [57428] by abarth@webkit.org

2 edits in trunk/LayoutTests

2010-04-10 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Add slow expectations based on webkit-dev discussion.

platform/mac/test_expectations.txt:

5:44 PM Changeset in webkit [57427] by abarth@webkit.org

4 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Unreviewed attempt to fix the Chromium Mac canary.

Scripts/webkitpy/common/config/ports.py:
Scripts/webkitpy/common/config/ports_unittest.py:
Scripts/webkitpy/common/system/executive.py:

5:28 PM Changeset in webkit [57426] by abarth@webkit.org

4 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Unreviewed.

Add the Apache bits to win.py for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37397

I still have run this yet, but I looked around to figure out what the
various paths appear to be. I'll figure out a way to remove the
copy/paste code in a future patch.

Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/win.py:

4:39 PM Changeset in webkit [57425] by abarth@webkit.org

4 edits
1 add in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out the win port for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37393

I haven't tried running this yet, but we've got to start somewhere.

Scripts/webkitpy/layout_tests/port/factory.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/win.py: Added.

3:44 PM Changeset in webkit [57424] by abarth@webkit.org

6 edits in trunk/WebKitTools

2010-04-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

webkit-patch land should not build and test by default
https://bugs.webkit.org/show_bug.cgi?id=33631

Reverse the sense of --no-build and --no-test to be --build and --test.
Also, decoupled the build and test options so you can test without
building.

(Patch manngled by Adam Barth. All bugs are his fault.)

Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/steps/options.py:
Scripts/webkitpy/tool/steps/runtests.py:

3:18 PM Changeset in webkit [57423] by abarth@webkit.org

4 edits
1 copy in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor WebKitPort out of MacPort to allow for WinPort
https://bugs.webkit.org/show_bug.cgi?id=37388

The split is a bit of a guess. We might have to adjust things once we
actually have a second port to work with.

Scripts/webkitpy/layout_tests/port/apache_http_server.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/webkit.py: Added.
Scripts/webkitpy/layout_tests/port/websocket_server.py:

3:17 PM Changeset in webkit [57422] by abarth@webkit.org

5 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

run_webkit_tests.py shouldn't have platform-specific logic
https://bugs.webkit.org/show_bug.cgi?id=37387

Dirk Pranke pointed out that my last patch was wrong because I
introduced platform-specific logic into run_webkit_tests.py, limiting
the parallelism in Chromium to work around a bug in the main Mac port.

Scripts/webkitpy/common/system/executive.py:
- Fix a typo pointed out by Chris Jerdonek.
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

3:09 PM Changeset in webkit [57421] by mrowe@apple.com

2 edits in trunk/WebKit2

Fix an obviously incorrect part of the Xcode configuration cleanup that resulted in debug builds
asserting shortly after launch.

WebKit2.xcodeproj/project.pbxproj: Fix the setting of DEBUG_DEFINES for the Debug configuration.

2:39 PM Changeset in webkit [57420] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-10 Stephan Aßmus <superstippi@gmx.de>

Reviewed by Eric Seidel.

[Haiku] Fix crash in Gradient::fill()
https://bugs.webkit.org/show_bug.cgi?id=37386

Covered by existing tests.

platform/graphics/haiku/GradientHaiku.cpp: (WebCore::Gradient::fill):
- Make sure the platform gradient is already cached before dereferencing its pointer.

2:30 PM Changeset in webkit [57419] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-10 Stephan Aßmus <superstippi@gmx.de>

Reviewed by Eric Seidel.

[Haiku] Fix build of ImageHaiku.cpp
<https://bugs.webkit.org/show_bug.cgi?id=37384>

No new tests needed.

platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
- include SharedBuffer.h
- changed parameter name to be in line with other ports, the code I landed in an earlier commit was already using this name.

5:28 AM Changeset in webkit [57418] by robert@webkit.org

4 edits in trunk

[Qt] Fix regressions in http/tests/navigation from r57416

2010-04-10 Robert Hogan <robert@webkit.org>

Unreviewed fix to regressions in r57416.

[Qt] Fix regressions in http/tests/navigation from r57416

Unskip tests skipped after regression in r57416.

https://bugs.webkit.org/show_bug.cgi?id=37237

platform/qt/Skipped:

2010-04-10 Robert Hogan <robert@webkit.org>

Unreviewed fix to regressions in r57416.

[Qt] Fix regressions in http/tests/navigation from r57416

Reset willSendRequestReturnsNullOnRedirect after each test to
prevent it leaking to subsequent tests.

Error pointed out by Jakub Wieczorek.

https://bugs.webkit.org/show_bug.cgi?id=37237

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):

3:41 AM Changeset in webkit [57417] by robert@webkit.org

2 edits
4 adds in trunk/LayoutTests

2010-04-10 Robert Hogan <robert@webkit.org>

Unreviewed fix to regressions from r57416.

Add expected results missing from r57416

Skip 2 tests that now fail.

http/tests/navigation/postredirect-reload.html
http/tests/navigation/redirect302-basic.html

These regressions will be worked under:
https://bugs.webkit.org/show_bug.cgi?id=37237

platform/qt/Skipped:
platform/qt/http/tests/misc/window-dot-stop-expected.txt: Added.
platform/qt/http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.

3:12 AM Changeset in webkit [57416] by robert@webkit.org

8 edits in trunk

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.

Unskip http/tests/xmlhttprequest/abort-should-cancel-load.html

http/tests/misc/will-send-request-returns-null-on-redirect.html
fast/loader/user-style-sheet-resource-load-callbacks.html
http/tests/misc/window-dot-stop.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
http/tests/xmlhttprequest/abort-should-cancel-load.html

QNetworkReply::OperationCanceledError has a value of 5 rather than -999, so add platform-specific results accordingly.

Add platform-specific results for the the following, though leave them skipped for now. They've started failing again
since review was granted (see https://bugs.webkit.org/show_bug.cgi?id=37382):

http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

https://bugs.webkit.org/show_bug.cgi?id=37237

platform/qt/Skipped:
platform/qt/http/tests/misc/window-dot-stop-expected.txt: Added.
platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
platform/qt/http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.

Unskip http/tests/xmlhttprequest/abort-should-cancel-load.html

http/tests/misc/will-send-request-returns-null-on-redirect.html
fast/loader/user-style-sheet-resource-load-callbacks.html
http/tests/misc/window-dot-stop.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
http/tests/xmlhttprequest/abort-should-cancel-load.html

QNetworkReply::OperationCanceledError has a value of 5, so update expected results accordingly.

https://bugs.webkit.org/show_bug.cgi?id=37237

WebCoreSupport/FrameLoaderClientQt.cpp: (qt_set_will_send_request_returns_null_on_redirect): (drtDescriptionSuitableForTestResult): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoading): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.

Add support for layoutTestController.setWillSendRequestReturnsNullOnRedirect to Qt DRT.
Prevent dumping resource load callbacks once layout test has dumped.

https://bugs.webkit.org/show_bug.cgi?id=37237

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
DumpRenderTree/qt/LayoutTestControllerQt.h:

2:09 AM Changeset in webkit [57415] by scherkus@chromium.org

2 edits in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, fixing description and expectation for media/video-replaces-poster.html.

platform/chromium/test_expectations.txt:

2:06 AM Changeset in webkit [57414] by scherkus@chromium.org

2 edits in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, marking media/video-replaces-poster.html as flaky.

platform/chromium/test_expectations.txt:

1:35 AM Changeset in webkit [57413] by scherkus@chromium.org

3 edits in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in corrected baselines for media/video-replaces-poster.html
on Chromium Win.

platform/chromium-win/media/video-replaces-poster-expected.checksum:
platform/chromium-win/media/video-replaces-poster-expected.png:

1:18 AM Changeset in webkit [57412] by Csaba Osztrogonác

4 edits in trunk/LayoutTests

Unreviewed, platform specific expected files updated after r57408.

[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503

platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: updated.
platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.

1:11 AM Changeset in webkit [57411] by scherkus@chromium.org

120 edits
41 adds in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, enable the rest of the fast/media tests for Chromium Mac and Linux
by checking in new baselines.

platform/chromium-linux/fast/media/media-descriptor-syntax-01-expected.checksum:
platform/chromium-linux/fast/media/media-descriptor-syntax-01-expected.png:
platform/chromium-linux/fast/media/media-descriptor-syntax-02-expected.checksum:
platform/chromium-linux/fast/media/media-descriptor-syntax-02-expected.png:
platform/chromium-linux/fast/media/media-descriptor-syntax-03-expected.checksum:
platform/chromium-linux/fast/media/media-descriptor-syntax-03-expected.png:
platform/chromium-linux/fast/media/media-descriptor-syntax-04-expected.checksum:
platform/chromium-linux/fast/media/media-descriptor-syntax-04-expected.png:
platform/chromium-linux/fast/media/media-descriptor-syntax-05-expected.checksum:
platform/chromium-linux/fast/media/media-descriptor-syntax-05-expected.png:
platform/chromium-linux/fast/media/media-descriptor-syntax-06-expected.checksum:
platform/chromium-linux/fast/media/media-descriptor-syntax-06-expected.png:
platform/chromium-linux/fast/media/media-type-syntax-01-expected.checksum:
platform/chromium-linux/fast/media/media-type-syntax-01-expected.png:
platform/chromium-linux/fast/media/media-type-syntax-02-expected.checksum:
platform/chromium-linux/fast/media/media-type-syntax-02-expected.png:
platform/chromium-linux/fast/media/mq-animation-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-animation-expected.png: Added.
platform/chromium-linux/fast/media/mq-aspect-ratio-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-aspect-ratio-expected.png: Added.
platform/chromium-linux/fast/media/mq-compound-query-01-expected.checksum:
platform/chromium-linux/fast/media/mq-compound-query-01-expected.png:
platform/chromium-linux/fast/media/mq-compound-query-02-expected.checksum:
platform/chromium-linux/fast/media/mq-compound-query-02-expected.png:
platform/chromium-linux/fast/media/mq-compound-query-03-expected.checksum:
platform/chromium-linux/fast/media/mq-compound-query-03-expected.png:
platform/chromium-linux/fast/media/mq-compound-query-04-expected.checksum:
platform/chromium-linux/fast/media/mq-compound-query-04-expected.png:
platform/chromium-linux/fast/media/mq-compound-query-05-expected.checksum:
platform/chromium-linux/fast/media/mq-compound-query-05-expected.png:
platform/chromium-linux/fast/media/mq-grid-01-expected.checksum:
platform/chromium-linux/fast/media/mq-grid-01-expected.png:
platform/chromium-linux/fast/media/mq-grid-02-expected.checksum:
platform/chromium-linux/fast/media/mq-grid-02-expected.png:
platform/chromium-linux/fast/media/mq-invalid-media-feature-01-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-media-feature-01-expected.png:
platform/chromium-linux/fast/media/mq-invalid-media-feature-02-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-media-feature-02-expected.png:
platform/chromium-linux/fast/media/mq-invalid-media-feature-03-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-media-feature-03-expected.png:
platform/chromium-linux/fast/media/mq-invalid-media-feature-04-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-media-feature-04-expected.png:
platform/chromium-linux/fast/media/mq-invalid-syntax-01-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-syntax-01-expected.png:
platform/chromium-linux/fast/media/mq-invalid-syntax-02-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-syntax-02-expected.png:
platform/chromium-linux/fast/media/mq-invalid-syntax-03-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-syntax-03-expected.png:
platform/chromium-linux/fast/media/mq-invalid-syntax-04-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-syntax-04-expected.png:
platform/chromium-linux/fast/media/mq-invalid-syntax-05-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-syntax-05-expected.png:
platform/chromium-linux/fast/media/mq-js-media-except-01-expected.checksum:
platform/chromium-linux/fast/media/mq-js-media-except-01-expected.png:
platform/chromium-linux/fast/media/mq-js-media-except-02-expected.checksum:
platform/chromium-linux/fast/media/mq-js-media-except-02-expected.png:
platform/chromium-linux/fast/media/mq-js-media-except-03-expected.checksum:
platform/chromium-linux/fast/media/mq-js-media-except-03-expected.png:
platform/chromium-linux/fast/media/mq-js-media-forward-syntax-expected.checksum:
platform/chromium-linux/fast/media/mq-js-media-forward-syntax-expected.png:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-01-expected.checksum:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-01-expected.png:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-02-expected.checksum:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-02-expected.png:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-03-expected.checksum:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-03-expected.png:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-04-expected.checksum:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-04-expected.png:
platform/chromium-linux/fast/media/mq-max-pixel-ratio-expected.checksum:
platform/chromium-linux/fast/media/mq-max-pixel-ratio-expected.png:
platform/chromium-linux/fast/media/mq-min-constraint-expected.checksum:
platform/chromium-linux/fast/media/mq-min-constraint-expected.png:
platform/chromium-linux/fast/media/mq-orientation-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-orientation-expected.png: Added.
platform/chromium-linux/fast/media/mq-pixel-ratio-expected.checksum:
platform/chromium-linux/fast/media/mq-pixel-ratio-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-02-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-02-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-03-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-03-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-04-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-04-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-05-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-05-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-06-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-06-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-07-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-07-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-09-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-09-expected.png:
platform/chromium-linux/fast/media/mq-simple-neg-query-01-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-neg-query-01-expected.png:
platform/chromium-linux/fast/media/mq-simple-neg-query-02-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-neg-query-02-expected.png:
platform/chromium-linux/fast/media/mq-simple-neg-query-03-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-neg-query-03-expected.png:
platform/chromium-linux/fast/media/mq-simple-neg-query-04-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-neg-query-04-expected.png:
platform/chromium-linux/fast/media/mq-simple-neg-query-05-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-neg-query-05-expected.png:
platform/chromium-linux/fast/media/mq-simple-query-01-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-query-01-expected.png:
platform/chromium-linux/fast/media/mq-simple-query-02-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-query-02-expected.png:
platform/chromium-linux/fast/media/mq-simple-query-03-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-query-03-expected.png:
platform/chromium-linux/fast/media/mq-simple-query-04-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-query-04-expected.png:
platform/chromium-linux/fast/media/mq-simple-query-05-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-query-05-expected.png:
platform/chromium-linux/fast/media/mq-transform-01-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-transform-01-expected.png: Added.
platform/chromium-linux/fast/media/mq-transform-02-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-transform-02-expected.png: Added.
platform/chromium-linux/fast/media/mq-transform-03-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-transform-03-expected.png: Added.
platform/chromium-linux/fast/media/mq-transform-04-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-transform-04-expected.png: Added.
platform/chromium-linux/fast/media/mq-transition-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-transition-expected.png: Added.
platform/chromium-linux/fast/media/mq-valueless-expected.checksum:
platform/chromium-linux/fast/media/mq-valueless-expected.png:
platform/chromium-linux/fast/media/mq-width-absolute-01-expected.checksum:
platform/chromium-linux/fast/media/mq-width-absolute-01-expected.png:
platform/chromium-linux/fast/media/mq-width-absolute-02-expected.checksum:
platform/chromium-linux/fast/media/mq-width-absolute-02-expected.png:
platform/chromium-linux/fast/media/mq-width-absolute-03-expected.checksum:
platform/chromium-linux/fast/media/mq-width-absolute-03-expected.png:
platform/chromium-linux/fast/media/mq-width-absolute-04-expected.checksum:
platform/chromium-linux/fast/media/mq-width-absolute-04-expected.png:
platform/chromium-linux/fast/media/viewport-media-query-expected.checksum:
platform/chromium-linux/fast/media/viewport-media-query-expected.png:
platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png: Added.
platform/chromium-mac/fast/media/mq-width-absolute-01-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png: Added.
platform/chromium-mac/fast/media/mq-width-absolute-02-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png: Added.
platform/chromium-mac/fast/media/mq-width-absolute-03-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png: Added.
platform/chromium-mac/fast/media/mq-width-absolute-04-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png: Added.
platform/chromium/test_expectations.txt:

12:47 AM Changeset in webkit [57410] by scherkus@chromium.org

4 edits
8 adds in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in updated baselines and expectations for Chromium media layout tests.

platform/chromium-linux/media/video-replaces-poster-expected.checksum: Added.
platform/chromium-linux/media/video-replaces-poster-expected.png: Added.
platform/chromium-mac/media/controls-drag-timebar-expected.txt: Added.
platform/chromium-mac/media/video-currentTime-set-expected.txt:
platform/chromium-mac/media/video-replaces-poster-expected.checksum: Added.
platform/chromium-mac/media/video-replaces-poster-expected.png: Added.
platform/chromium-win/media/controls-drag-timebar-expected.txt: Added.
platform/chromium-win/media/video-currentTime-set-expected.txt:
platform/chromium-win/media/video-replaces-poster-expected.checksum: Added.
platform/chromium-win/media/video-replaces-poster-expected.png: Added.
platform/chromium/test_expectations.txt:

12:46 AM Changeset in webkit [57409] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] animations/dynamic-stylesheet-loading.html fails with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=37381

platform/qt/Skipped: animations/dynamic-stylesheet-loading.html skipped until fix.

12:35 AM Changeset in webkit [57408] by Laszlo Gombos

13 edits
2 adds in trunk

2010-04-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503

Map WebKit notifications to Qt's SystemTray API and
implement DRT tracing.

This patch does not implement the security part of
WebKit notifications.

Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
Api/qwebpage.h:
Api/qwebpage_p.h:
WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::notificationPresenter):
WebCoreSupport/ChromeClientQt.h:
WebCoreSupport/NotificationPresenterClientQt.cpp: Added. (qt_dump_notification): (NotificationPresenterClientQt::NotificationPresenterClientQt): (NotificationPresenterClientQt::show): (NotificationPresenterClientQt::cancel): (NotificationPresenterClientQt::notificationObjectDestroyed): (NotificationPresenterClientQt::requestPermission): (NotificationPresenterClientQt::checkPermission):
WebCoreSupport/NotificationPresenterClientQt.h: Added.

2010-04-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503

No new tests enabled as notification DRT tests are
disabled at the moment.

WebCore.pri: Add files to the build system and turn on the feature by default.

WebCore.pro: Add files to the build system

bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission): (WebCore::JSNotification::addEventListener): (WebCore::JSNotification::removeEventListener): Fix build regresssion.

2010-04-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503

DRT stubs for notification. Enables to run and pass
3 (currently disabled) tests.

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::grantDesktopNotificationPermission): (LayoutTestController::checkDesktopNotificationPermission):
DumpRenderTree/qt/LayoutTestControllerQt.h:

Apr 9, 2010:

11:35 PM Changeset in webkit [57407] by dumi@chromium.org

2 edits in trunk/WebKitTools

Unreviewed, another change to executive.py to make it run with
python 2.4.

Scripts/webkitpy/common/system/executive.py:

11:20 PM Changeset in webkit [57406] by dumi@chromium.org

2 edits in trunk/WebKitTools

Unreviewed, attempting to make executive.py run with python 2.4
(which is still used on Chromium's Windows canary bot).

Scripts/webkitpy/common/system/executive.py:

10:02 PM Changeset in webkit [57405] by pfeldman@chromium.org

6 edits in trunk

2010-04-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Console with two recursive arrays causes infinite loop trying to display.
https://bugs.webkit.org/show_bug.cgi?id=37133

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._printArray): (WebInspector.ConsoleView.prototype._formatAsArrayEntry):
inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

8:18 PM WebKit2 edited by dbates@webkit.org

Spelling corrections. (diff)

8:09 PM Changeset in webkit [57404] by eric@webkit.org

11 edits in trunk

2010-04-09 Kevin Watters <kevinwatters@gmail.com>

Reviewed by Eric Seidel.

[wx] Basic implementation of SVG support for wx port.

css/CSSFontFaceSource.cpp:
platform/graphics/wx/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size):
platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::FontPlatformData):
platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::setLineDash):
platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
platform/graphics/wx/PathWx.cpp: (WebCore::Path::strokeContains): (WebCore::Path::debugString): (WebCore::Path::operator=): (WebCore::Path::isEmpty):
rendering/RenderSVGResourceMasker.cpp:
wscript:

2010-04-09 Kevin Watters <kevinwatters@gmail.com>

Reviewed by Eric Seidel.

[wx] Basic implementation of SVG support for wx port.

wx/build/settings.py:

7:59 PM Changeset in webkit [57403] by eric@webkit.org

2 edits in trunk/WebKit/mac

2010-04-09 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>

WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]):

7:50 PM Changeset in webkit [57402] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-04-09 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] Linux: respect the scale factor during printing
https://bugs.webkit.org/show_bug.cgi?id=37168

Chromium doesn't support testing .pdfs from printing at the moment, so
this change is not covered by any tests.

src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::spoolPage):

7:34 PM Changeset in webkit [57401] by eric@webkit.org

3 edits in trunk/WebKit/chromium

2010-04-09 Aaron Boodman <aa@chromium.org>

Reviewed by Eric Seidel.

Remove applicationID() from WebDocument as it is Chromium-specific.
https://bugs.webkit.org/show_bug.cgi?id=37350

public/WebDocument.h:
src/WebDocument.cpp:

7:24 PM Changeset in webkit [57400] by abarth@webkit.org

2 edits in trunk/LayoutTests

2010-04-09 Adam Barth <abarth@webkit.org>

Unreviewed.

Test a theory about why this is failing downstream.

http/tests/security/xss-DENIED-mime-type-execute-as-html.html:

7:17 PM Changeset in webkit [57399] by abarth@webkit.org

10 edits in trunk/WebKitTools

2010-04-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't reinvent Executive.cpu_count for every port
https://bugs.webkit.org/show_bug.cgi?id=37377

mac.py and chromium_mac.py had some copy/paste code. This code doesn't
actually have anything to do with WebKit ports. It's really just
something in the multiprocessing package. The lame bit is that package
isn't available in older versions of Python, so we need to implement a
fallback. However, we already have the fallback in common. We don't
need to reinvent it specificly for layout_tests.

Scripts/webkitpy/common/system/executive.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/chromium_linux.py:
Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

7:17 PM Changeset in webkit [57398] by abarth@webkit.org

3 edits in trunk/WebKitTools

2010-04-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests --release fails to build release DRT when global configuration is Debug
https://bugs.webkit.org/show_bug.cgi?id=37376

We need to explicitly pass the --release flag. I bet there are more
instances of this bug.

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/mac.py:

7:16 PM Changeset in webkit [57397] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-04-09 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt]Fix compile error with QT_NO_IM
https://bugs.webkit.org/show_bug.cgi?id=36533

WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup):

7:13 PM Changeset in webkit [57396] by scherkus@chromium.org

59 edits in trunk/LayoutTests

2010-04-09 Sergey Ulanov <sergeyu@chromium.org>

Unreviewed, checking in baselines due to Chromium's new video scaling algorithm.

platform/chromium-linux/media/controls-after-reload-expected.checksum:
platform/chromium-linux/media/controls-after-reload-expected.png:
platform/chromium-linux/media/controls-strict-expected.checksum:
platform/chromium-linux/media/controls-strict-expected.png:
platform/chromium-linux/media/video-aspect-ratio-expected.checksum:
platform/chromium-linux/media/video-aspect-ratio-expected.png:
platform/chromium-linux/media/video-controls-rendering-expected.checksum:
platform/chromium-linux/media/video-controls-rendering-expected.png:
platform/chromium-linux/media/video-display-toggle-expected.checksum:
platform/chromium-linux/media/video-display-toggle-expected.png:
platform/chromium-linux/media/video-layer-crash-expected.checksum:
platform/chromium-linux/media/video-layer-crash-expected.png:
platform/chromium-linux/media/video-no-audio-expected.checksum:
platform/chromium-linux/media/video-no-audio-expected.png:
platform/chromium-linux/media/video-transformed-expected.checksum:
platform/chromium-linux/media/video-transformed-expected.png:
platform/chromium-linux/media/video-volume-slider-expected.checksum:
platform/chromium-linux/media/video-volume-slider-expected.png:
platform/chromium-linux/media/video-zoom-expected.checksum:
platform/chromium-linux/media/video-zoom-expected.png:
platform/chromium-mac/media/controls-after-reload-expected.checksum:
platform/chromium-mac/media/controls-after-reload-expected.png:
platform/chromium-mac/media/controls-strict-expected.checksum:
platform/chromium-mac/media/controls-strict-expected.png:
platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
platform/chromium-mac/media/video-aspect-ratio-expected.png:
platform/chromium-mac/media/video-controls-rendering-expected.checksum:
platform/chromium-mac/media/video-controls-rendering-expected.png:
platform/chromium-mac/media/video-display-toggle-expected.checksum:
platform/chromium-mac/media/video-display-toggle-expected.png:
platform/chromium-mac/media/video-layer-crash-expected.checksum:
platform/chromium-mac/media/video-layer-crash-expected.png:
platform/chromium-mac/media/video-no-audio-expected.checksum:
platform/chromium-mac/media/video-no-audio-expected.png:
platform/chromium-mac/media/video-transformed-expected.checksum:
platform/chromium-mac/media/video-transformed-expected.png:
platform/chromium-mac/media/video-volume-slider-expected.checksum:
platform/chromium-mac/media/video-volume-slider-expected.png:
platform/chromium-mac/media/video-zoom-expected.checksum:
platform/chromium-mac/media/video-zoom-expected.png:
platform/chromium-win/media/controls-after-reload-expected.checksum:
platform/chromium-win/media/controls-after-reload-expected.png:
platform/chromium-win/media/controls-strict-expected.checksum:
platform/chromium-win/media/controls-strict-expected.png:
platform/chromium-win/media/video-aspect-ratio-expected.checksum:
platform/chromium-win/media/video-aspect-ratio-expected.png:
platform/chromium-win/media/video-controls-rendering-expected.checksum:
platform/chromium-win/media/video-controls-rendering-expected.png:
platform/chromium-win/media/video-display-toggle-expected.checksum:
platform/chromium-win/media/video-display-toggle-expected.png:
platform/chromium-win/media/video-layer-crash-expected.checksum:
platform/chromium-win/media/video-layer-crash-expected.png:
platform/chromium-win/media/video-no-audio-expected.checksum:
platform/chromium-win/media/video-no-audio-expected.png:
platform/chromium-win/media/video-transformed-expected.checksum:
platform/chromium-win/media/video-transformed-expected.png:
platform/chromium-win/media/video-volume-slider-expected.checksum:
platform/chromium-win/media/video-volume-slider-expected.png:

7:06 PM Changeset in webkit [57395] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-09 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] DRT compile fix on win/linux
https://bugs.webkit.org/show_bug.cgi?id=37314

Looks like this was missed when upstreaming.

DumpRenderTree/chromium/EventSender.cpp: (applyKeyModifier):

6:56 PM Changeset in webkit [57394] by eric@webkit.org

3 edits in trunk/WebCore

2010-04-09 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

StorageEvent destructor should be in StorageEvent.cpp
https://bugs.webkit.org/show_bug.cgi?id=37356

Because Storage is forward-declared in StorageEvent.h, we need to define
the StorageEvent destructor in the .cpp file so that the RefPtr<Storage>
destructor has a complete type for Storage.

storage/StorageEvent.cpp: (WebCore::StorageEvent::~StorageEvent):
storage/StorageEvent.h:

6:45 PM Changeset in webkit [57393] by eric@webkit.org

1 edit
2 adds in trunk/WebCore

2010-04-09 Young Han Lee <joybro@company100.net>

Reviewed by Eric Seidel.

[WINCE] Add forwarding header for UnicodeWince.h
https://bugs.webkit.org/show_bug.cgi?id=37224

ForwardingHeaders/wtf/unicode/wince/UnicodeWince.h: Added.

6:15 PM Changeset in webkit [57392] by mrowe@apple.com

5 edits in trunk/WebKit2

Bring the WebKit2 Xcode configuration in to sync with recent changes to the WebKit Xcode configuration files.

Reviewed by Sam Weinig.

In particular, this updates the FEATURE_DEFINES to match those used in the other projects, and brings in
the changes to support building WebKit for older Mac OS X versions from the current Mac OS X version.

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

6:09 PM Changeset in webkit [57391] by ggaren@apple.com

7 edits in trunk/WebCore

Tidied up some more DOMWrapperWorld lifetime issues.

Reviewed by Sam "R the K!" Weinig.

bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::~DOMWrapperWorld): Notify the document that
we're going away instead of deleting its data, since deleting other
objects' data is error-prone and, more importantly, rude.

bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::didCreateWrapperCache):
(WebCore::DOMWrapperWorld::didDestroyWrapperCache): A few renames for
clarity.

bindings/js/JSDOMBinding.cpp:
bindings/js/JSDOMBinding.h: Converted forgetAllDOMNodesForDocument

to a Document member function, for the same reason.

dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::createWrapperCache):
(WebCore::Document::destroyWrapperCache):
(WebCore::Document::destroyAllWrapperCaches):

dom/Document.h: Added a destroyWrapperCache function to balance

createWrapperCache, so it's clear who allocates and deletes these wrapper
caches.

6:00 PM Changeset in webkit [57390] by cmarrin@apple.com

4 edits
4 adds in trunk

Reviewed by Simon Fraser.

Fixed bug where animation time was not updated when dynamically loading a style sheet
https://bugs.webkit.org/show_bug.cgi?id=37352

A dynamically loaded style sheet kicks off its own styleRecalc cycle. This was not
bracketed with a beginAnimationUpdate/endAnimationUpdate which wasn't resetting the
animation time. In some time-dependent cases this was causing a negative elapsedTime
to be sent to the keyframe animator. This is an invalid case which destroys the
animation prematurely. I not only added the brackets, but I also added an assert
and protection for when the elapsedTime comes up negative.

Test: animations/dynamic-stylesheet-loading.html

dom/Document.cpp: Added brackets (WebCore::Document::updateStyleSelector):
page/animation/KeyframeAnimation.cpp: Added assert and protection (WebCore::KeyframeAnimation::getKeyframeAnimationInterval):

5:52 PM Changeset in webkit [57389] by mrowe@apple.com

5 edits
1 copy
1 move
1 add in trunk/WebKit2

Clean up the Xcode project configuration.

Reviewed by Sam Weinig.

Common target settings are pulled out in to BaseTarget.xcconfig. The majority of setting overrides are
removed from the Xcode project itself. Info.plist files are updated to match those used in other frameworks.

Configurations/BaseTarget.xcconfig: Copied from WebKit2/Configurations/WebKit2.xcconfig.
Configurations/WebKit2.xcconfig:
Configurations/WebProcess.xcconfig: Copied from WebKit2/Configurations/WebKit2.xcconfig.
Info.plist:
WebKit2.xcodeproj/project.pbxproj:
WebProcess-Info.plist: Removed.
WebProcess/Info.plist: Moved from WebProcess-Info.plist.

5:51 PM Changeset in webkit [57388] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-04-09 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebFrame::popupFocus() fails
https://bugs.webkit.org/show_bug.cgi?id=37320

The QWebPopup class has been moved & renamed, so tst_QWebFrame::popupFocus() should use
the class name "QComboBox", rather than "WebCore::QWebPopup" to find the popup menu.

tests/qwebframe/tst_qwebframe.cpp:

5:41 PM Changeset in webkit [57387] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-09 Jaime Yap <jaimeyap@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Fixes "wrong parent" for GCEvents that come at the end of a
timeline record node.
https://bugs.webkit.org/show_bug.cgi?id=37340

inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):

5:26 PM Changeset in webkit [57386] by abarth@webkit.org

4 edits
3 adds in trunk

2010-04-09 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Prevent HTTP responses served with JSON content type from being rendered as HTML.

Test: http/tests/security/xss-DENIED-mime-type-execute-as-html.html

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isTextMIMEType): Render application/json as text/plain.
platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes): Add a compile assert to prevent addition of new mime types in non-image types.

2010-04-09 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Test non-image and javascript mime types are not rendered as HTML.

http/tests/security/resources/send-mime-types.php: Added.
http/tests/security/xss-DENIED-mime-type-execute-as-html-expected.txt: Added.
http/tests/security/xss-DENIED-mime-type-execute-as-html.html: Added.

4:45 PM Changeset in webkit [57385] by mrowe@apple.com

2 edits in trunk/WebKit2

Build fix.

WebProcess/WebCoreSupport/mac/WebSystemInterface.m:

(InitWebCoreSystemInterface): Update for recent WKSI changes.

4:40 PM Changeset in webkit [57384] by hamaji@chromium.org

3 edits in trunk/WebCore

2010-04-09 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Prevent wrong use of PrintContext
https://bugs.webkit.org/show_bug.cgi?id=37194

No new tests because this doesn't change the behavior.

page/PrintContext.cpp: (WebCore::PrintContext::PrintContext): (WebCore::PrintContext::~PrintContext): (WebCore::PrintContext::begin): (WebCore::PrintContext::end):
page/PrintContext.h:

4:28 PM Changeset in webkit [57383] by abarth@webkit.org

1 edit
1 move in trunk/WebKitTools

2010-04-09 Adam Barth <abarth@webkit.org>

Unreviewed, but approved by Dirk Pranke.

rename test_expectations_test.py to test_expectations_unittest.py so it actually gets run
https://bugs.webkit.org/show_bug.cgi?id=37372

We need to end unit tests with _unittest.py for them to be autodetected
by the test harness. +6 tests.

Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py.

4:28 PM Changeset in webkit [57382] by vitalyr@chromium.org

2 edits in trunk/WebCore

2010-04-09 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Darin Fisher.

[V8] SerializedScriptValue value doesn't follow the spec for DOM objects and files
https://bugs.webkit.org/show_bug.cgi?id=37094

This patch adds support for file-related types.

bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::writeString): (WebCore::Writer::writeWebCoreString): (WebCore::Writer::writeBlob): (WebCore::Writer::writeFile): (WebCore::Writer::writeFileList): (WebCore::Writer::doWriteString): (WebCore::Writer::doWriteWebCoreString): (WebCore::Serializer::writeBlob): (WebCore::Serializer::writeFile): (WebCore::Serializer::writeFileList): (WebCore::Serializer::doSerialize): (WebCore::Reader::read): (WebCore::Reader::readWebCoreString): (WebCore::Reader::readBlob): (WebCore::Reader::readFile): (WebCore::Reader::readFileList): (WebCore::SerializedScriptValue::SerializedScriptValue):

4:19 PM Changeset in webkit [57381] by abarth@webkit.org

6 edits
1 move in trunk/WebKitTools

2010-04-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should talk about DumpRenderTree not test_shell
https://bugs.webkit.org/show_bug.cgi?id=37371

test_shell is some strange Chromium thing.
DumpRenderTree (tm) is the real deal.

Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Added.
Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Removed.
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/server_process.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

4:18 PM Changeset in webkit [57380] by zoltan@webkit.org

2 edits in trunk/WebKitTools

2010-04-09 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix 2 issues (what were introduced in r56524) in svn-create-patch's generateDiff()
https://bugs.webkit.org/show_bug.cgi?id=32582

Add missing return variable. Initialize $patch variable and remove unnecessary condition.

Scripts/svn-create-patch:

4:16 PM Changeset in webkit [57379] by ggaren@apple.com

7 edits in trunk/WebCore

Tidied up some DOMWrapperWorld lifetime issues.

Reviewed by Cameron Zwarich.

bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld): Made DOMWrapperWorld wholly
responsible for managing its presence in WebCoreJSClientData's world set.
This is simpler and more encapsulated than making its clients sometimes
responsible for managing that set and sometimes not.

bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::create): Made isNormal default to false,
removing one of the reasons for the IsolatedWorld class to exist, so I
could remove that class.

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonJSGlobalData): Used the work-around below.

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createWorld): Nixed IsolatedWorld, which is
now superfluous.

bindings/js/WebCoreJSClientData.h:

(WebCore::initNormalWorldClientData): Added a work-around for the fact
that WebCoreJSClientData must be set as globalData->clientData before
the DOMWrapperWorld constructor runs. This removed the other reason
for the IsolatedWorld class to exist, so I could remove that class.

4:12 PM Changeset in webkit [57378] by yaar@chromium.org

1 edit
5 adds in trunk/WebCore

2010-04-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Nate Chapin.

Testing utility for CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=37286

bindings/v8/test: Added.
bindings/v8/test/TestObj.idl: Contains basic IDL definitions for testing purposes.
bindings/v8/test/V8TestObj.cpp: Expected output.
bindings/v8/test/V8TestObj.h: Expected output.
bindings/v8/test/run_tests.py: Tool for generating the above h/cpp files from the idl file.

3:58 PM Changeset in webkit [57377] by Darin Adler

3 edits
2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=37370
Division by 0 in RenderBoxModelObject::calculateFillTileSize

Reviewed by Maciej Stachowiak.

WebCore:

Test: fast/backgrounds/background-fill-zero-area-crash.html

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize): Added checks for
zero before doing division. These come up when the area to fill is zero.

LayoutTests:

fast/backgrounds/background-fill-zero-area-crash-expected.txt: Added.
fast/backgrounds/background-fill-zero-area-crash.html: Added.

3:53 PM Changeset in webkit [57376] by kevino@webkit.org

2 edits in trunk/WebKitTools

[wx] Build fix after addition of LayoutTestController method.

3:50 PM Changeset in webkit [57375] by weinig@apple.com

3 edits in trunk/WebKit2

Fix for https://bugs.webkit.org/show_bug.cgi?id=37351
Cannot build with build-webkit --webkit2

Reviewed by Darin Adler.

Add some headers that it seems others are not getting
already.

Platform/mac/WorkQueueMac.cpp: #inlude <mach/mach_port.h>
Shared/mac/UpdateChunk.cpp: #inlude <mach/vm_map.h>

3:46 PM Changeset in webkit [57374] by weinig@apple.com

1 edit
29 adds in trunk/WebKitTools

Fix for https://bugs.webkit.org/show_bug.cgi?id=37368
Add MiniBrowser.

Reviewed by Anders Carlsson.

MiniBrowser: Added.
MiniBrowser/MiniBrowser.vcproj: Added.
MiniBrowser/MiniBrowser.xcodeproj: Added.
MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added.
MiniBrowser/mac: Added.
MiniBrowser/mac/AppDelegate.h: Added.
MiniBrowser/mac/AppDelegate.m: Added.
MiniBrowser/mac/BrowserWindowController.h: Added.
MiniBrowser/mac/BrowserWindowController.m: Added.
MiniBrowser/mac/English.lproj: Added.
MiniBrowser/mac/English.lproj/BrowserWindow.xib: Added.
MiniBrowser/mac/English.lproj/InfoPlist.strings: Added.
MiniBrowser/mac/English.lproj/MainMenu.xib: Added.
MiniBrowser/mac/MiniBrowser-Info.plist: Added.
MiniBrowser/mac/MiniBrowser_Prefix.pch: Added.
MiniBrowser/mac/main.m: Added.
MiniBrowser/win: Added.
MiniBrowser/win/BrowserView.cpp: Added.
MiniBrowser/win/BrowserView.h: Added.
MiniBrowser/win/BrowserWindow.cpp: Added.
MiniBrowser/win/BrowserWindow.h: Added.
MiniBrowser/win/MiniBrowser.cpp: Added.
MiniBrowser/win/MiniBrowser.h: Added.
MiniBrowser/win/MiniBrowser.rc: Added.
MiniBrowser/win/Resources: Added.
MiniBrowser/win/main.cpp: Added.
MiniBrowser/win/resource.h: Added.
MiniBrowser/win/stdafx.cpp: Added.
MiniBrowser/win/stdafx.h: Added.

3:33 PM Changeset in webkit [57373] by ap@apple.com

16 edits
3 copies
2 adds
2 deletes in trunk

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=24572
XMLHttpRequest.statusText returns always "OK" on Mac

Covered by existing tests, which now pass.

WebCore.base.exp:
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm: Added a WebKitSystemInterface method to fetch status line.

platform/network/HTTPParsers.cpp: (WebCore::extractReasonPhraseFromHTTPStatusLine):
platform/network/HTTPParsers.h:
platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit): Moved code for parsing status line to HTTPHeaders, as it's used for both Mac and CF now.

platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Use the actual reason phrase when available, and "OK" otherwise. Synthesizing a reson when there isn't one is misleading, so we'll stick to our old broken behavior on Tiger, rather than introduce a new broken one.

3:19 PM Changeset in webkit [57372] by dumi@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, rolling back the last two changes. The failing tests
are a Chromium problem, not a WebKit one.

platform/chromium/test_expectations.txt:

3:14 PM Changeset in webkit [57371] by hyatt@apple.com

4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=37361, clean up FillLayer.

Reviewed by Oliver Hunt.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

rendering/style/FillLayer.h:

(WebCore::FillLayer::sizeType):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::backgroundImage):
(WebCore::InheritedFlags::backgroundRepeatX):
(WebCore::InheritedFlags::backgroundRepeatY):
(WebCore::InheritedFlags::backgroundComposite):
(WebCore::InheritedFlags::backgroundAttachment):
(WebCore::InheritedFlags::backgroundClip):
(WebCore::InheritedFlags::backgroundOrigin):
(WebCore::InheritedFlags::backgroundXPosition):
(WebCore::InheritedFlags::backgroundYPosition):
(WebCore::InheritedFlags::backgroundSizeType):
(WebCore::InheritedFlags::backgroundSizeLength):
(WebCore::InheritedFlags::maskImage):
(WebCore::InheritedFlags::maskRepeatX):
(WebCore::InheritedFlags::maskRepeatY):
(WebCore::InheritedFlags::maskComposite):
(WebCore::InheritedFlags::maskAttachment):
(WebCore::InheritedFlags::maskClip):
(WebCore::InheritedFlags::maskOrigin):
(WebCore::InheritedFlags::maskXPosition):
(WebCore::InheritedFlags::maskYPosition):
(WebCore::InheritedFlags::maskSizeType):
(WebCore::InheritedFlags::maskSizeLength):

3:05 PM Changeset in webkit [57370] by mrowe@apple.com

2 edits in tags/Safari-533.4.1/WebKit/win

Merge r57336.

2:59 PM Changeset in webkit [57369] by mrowe@apple.com

4 edits in tags/Safari-533.4.1

Versioning.

2:40 PM Changeset in webkit [57368] by dumi@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, adding a TIMEOUT expectations for worker-simple.html
on Linux.
https://bugs.webkit.org/show_bug.cgi?id=37274

platform/chromium/test_expectations.txt:

2:36 PM Changeset in webkit [57367] by andersca@apple.com

4 edits in trunk/WebKit2

More build fixes.

WebProcess/win/WebProcessMain.h:

Include windows.h here.

win/WebKit2.def:

Add new exports.

win/WebKit2.vcproj:

Add new files.

2:36 PM Changeset in webkit [57366] by mrowe@apple.com

1 copy in tags/Safari-533.4.1

New tag.

2:20 PM Changeset in webkit [57365] by weinig@apple.com

2 edits in trunk/WebCore

Add another missing export to fix the build.

WebCore.base.exp:

2:19 PM Changeset in webkit [57364] by weinig@apple.com

2 edits in trunk/WebKit2

Add new WKString.h and WKURL.h headers to top
level include.

Reviewed by Anders Carlsson.

UIProcess/API/C/WebKit2.h:

2:10 PM Changeset in webkit [57363] by andersca@apple.com

4 edits in trunk/WebKit2

More Windows build fixes.

Shared/NotImplemented.h:
UIProcess/API/C/cf/WKURLCF.cpp:

Fix typo.

(WKURLCreateWithCFURL):

UIProcess/API/C/cf/WKURLCF.h:

Ditto.

win/WebKit2Generated.make:

Copy the new CF headers.

2:06 PM Changeset in webkit [57362] by dumi@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, skipping a test on Linux in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=37359

platform/chromium/test_expectations.txt:

2:01 PM Changeset in webkit [57361] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-04-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch attached my patch to the wrong bug
https://bugs.webkit.org/show_bug.cgi?id=37015

The problem here is that SVN was violating SCM's implicit
contract of always returning paths relative to the repository root.
That can easily be fixed by telling SVN that the CWD is the repository root.

When fixing this I realized there are a large number of places in SCM.py where
we want to consider explicitly passing self.checkout_root as the CWD.
That would allow scm methods to be executed even when the CWD is not inside
the scm tree at all, and would also make sure (in the case of SVN) that paths
returned are relative to the root. Git (almost always) returns paths relative
to the repository root.

Scripts/webkitpy/common/checkout/scm.py:
- Explicitly pass self.checkout_root as cwd in run_status_and_extract_filenames
- Add a ton of FIXMEs about the need to go back and decide which methods require cwd=self.checkout_root and which do not. We'll probably add a helper function to scm (likely SCM._run) which always passes cwd=self.checkout_root to Executive.run_command
Scripts/webkitpy/common/checkout/scm_unittest.py:
- Add a test for this change.
Scripts/webkitpy/tool/commands/upload.py:
- Removed the explicit os.chdir to the repository root, since scm.py methods should be robust against the cwd not being equal to the root.

1:51 PM Changeset in webkit [57360] by weinig@apple.com

3 edits in trunk/WebKit2

Two more #include sorting issues.

Reviewed by Anders Carlsson.

Shared/NotImplemented.h:
WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

1:49 PM Changeset in webkit [57359] by weinig@apple.com

37 edits in trunk/WebKit2

Fix minor style nits found by the style-script.

Reviewed by Anders Carlsson.

Platform/CoreIPC/ArgumentDecoder.h:
Platform/CoreIPC/ArgumentEncoder.cpp:
Platform/CoreIPC/Attachment.cpp:
Platform/CoreIPC/Connection.cpp:
Platform/CoreIPC/Connection.h:
Platform/CoreIPC/mac/ConnectionMac.cpp:
Platform/CoreIPC/win/ConnectionWin.cpp:
Platform/WorkQueue.h:
Platform/mac/WorkQueueMac.cpp:
Platform/win/RunLoopWin.cpp:
Shared/KURLWrapper.h:
Shared/WebCoreTypeArgumentMarshalling.h:
Shared/mac/UpdateChunk.cpp:
UIProcess/API/C/WKPage.cpp:
UIProcess/API/C/WKURL.cpp:
UIProcess/Launcher/win/WebProcessLauncher.cpp:
UIProcess/ResponsivenessTimer.cpp:
UIProcess/WebLoaderClient.cpp:
UIProcess/WebPageProxy.h:
UIProcess/WebPolicyClient.cpp:
UIProcess/WebUIClient.cpp:
UIProcess/win/DrawingAreaProxy.cpp:
UIProcess/win/WebView.cpp:
WebProcess/Launching/win/WebProcessWinMain.cpp:
WebProcess/WebCoreSupport/WebChromeClient.cpp:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
WebProcess/WebCoreSupport/mac/WebSystemInterface.h:
WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp:
WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
WebProcess/WebPage/WebFrame.h:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
WebProcess/WebProcess.h:
WebProcess/win/WebLocalizableStrings.cpp:
WebProcess/win/WebLocalizableStrings.h:
WebProcess/win/WebProcessMain.cpp:

1:44 PM Changeset in webkit [57358] by hyatt@apple.com

5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=37353, clean up cursors used by RenderStyles.

Reviewed by Adam Roben.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):

rendering/style/CursorData.h:

(WebCore::CursorData::CursorData):
(WebCore::CursorData::operator==):
(WebCore::CursorData::image):
(WebCore::CursorData::hotSpot):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::addCursor):

1:40 PM Changeset in webkit [57357] by tonikitoo@webkit.org

2 edits in trunk/WebKit/qt

2010-04-09 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Holger Freyther.

Removing the use of topLevelWidget of QWidget class since it is deprecated/obsolete
since Qt 4.5. window() method is being used instead now.

See http://doc.trolltech.com/4.5/qwidget-obsolete.html#topLevelWidget for more info.

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::windowRect): (WebCore::ChromeClientQt::show): (WebCore::ChromeClientQt::windowResizerRect):

1:35 PM Changeset in webkit [57356] by andersca@apple.com

2 edits in trunk/WebKit2

Fix Windows build.

Shared/NotImplemented.h:

Include stdio.h.

1:21 PM Changeset in webkit [57355] by hyatt@apple.com

11 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=37349, RenderStyle cleanup. Working from the outside in to
bring some style consistency to RenderStyle and its associated classes. This patch cleans up the
border and outline classes.

Reviewed by Adam Roben.

rendering/RenderTable.cpp:

(WebCore::RenderTable::calcBorderLeft):
(WebCore::RenderTable::calcBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):

rendering/RenderTableCell.cpp:

(WebCore::compareBorders):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcOuterBorderTop):
(WebCore::RenderTableSection::calcOuterBorderBottom):
(WebCore::RenderTableSection::calcOuterBorderLeft):
(WebCore::RenderTableSection::calcOuterBorderRight):

rendering/style/BorderData.h:

(WebCore::BorderData::hasBorder):
(WebCore::BorderData::hasBorderRadius):
(WebCore::BorderData::borderLeftWidth):
(WebCore::BorderData::borderRightWidth):
(WebCore::BorderData::borderTopWidth):
(WebCore::BorderData::borderBottomWidth):
(WebCore::BorderData::operator==):
(WebCore::BorderData::left):
(WebCore::BorderData::right):
(WebCore::BorderData::top):
(WebCore::BorderData::bottom):
(WebCore::BorderData::image):
(WebCore::BorderData::topLeft):
(WebCore::BorderData::topRight):
(WebCore::BorderData::bottomLeft):
(WebCore::BorderData::bottomRight):

rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::nonZero):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::color):
(WebCore::BorderValue::width):
(WebCore::BorderValue::style):

rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::width):
(WebCore::CollapsedBorderValue::style):
(WebCore::CollapsedBorderValue::exists):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::isTransparent):
(WebCore::CollapsedBorderValue::precedence):
(WebCore::CollapsedBorderValue::operator==):

rendering/style/OutlineValue.h:

(WebCore::OutlineValue::OutlineValue):
(WebCore::OutlineValue::operator==):
(WebCore::OutlineValue::offset):
(WebCore::OutlineValue::isAuto):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getBorderRadiiForRect):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::borderLeft):
(WebCore::InheritedFlags::borderRight):
(WebCore::InheritedFlags::borderTop):
(WebCore::InheritedFlags::borderBottom):
(WebCore::InheritedFlags::borderImage):
(WebCore::InheritedFlags::borderTopLeftRadius):
(WebCore::InheritedFlags::borderTopRightRadius):
(WebCore::InheritedFlags::borderBottomLeftRadius):
(WebCore::InheritedFlags::borderBottomRightRadius):
(WebCore::InheritedFlags::borderLeftStyle):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderLeftIsTransparent):
(WebCore::InheritedFlags::borderRightStyle):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderRightIsTransparent):
(WebCore::InheritedFlags::borderTopStyle):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderTopIsTransparent):
(WebCore::InheritedFlags::borderBottomStyle):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::borderBottomIsTransparent):
(WebCore::InheritedFlags::outlineWidth):
(WebCore::InheritedFlags::outlineStyleIsAuto):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::outlineOffset):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::resetBorderTop):
(WebCore::InheritedFlags::resetBorderRight):
(WebCore::InheritedFlags::resetBorderBottom):
(WebCore::InheritedFlags::resetBorderLeft):
(WebCore::InheritedFlags::resetBorderImage):
(WebCore::InheritedFlags::resetBorderTopLeftRadius):
(WebCore::InheritedFlags::resetBorderTopRightRadius):
(WebCore::InheritedFlags::resetBorderBottomLeftRadius):
(WebCore::InheritedFlags::resetBorderBottomRightRadius):
(WebCore::InheritedFlags::setBorderImage):
(WebCore::InheritedFlags::setBorderTopLeftRadius):
(WebCore::InheritedFlags::setBorderTopRightRadius):
(WebCore::InheritedFlags::setBorderBottomLeftRadius):
(WebCore::InheritedFlags::setBorderBottomRightRadius):
(WebCore::InheritedFlags::setBorderLeftWidth):
(WebCore::InheritedFlags::setBorderLeftStyle):
(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightWidth):
(WebCore::InheritedFlags::setBorderRightStyle):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopWidth):
(WebCore::InheritedFlags::setBorderTopStyle):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomWidth):
(WebCore::InheritedFlags::setBorderBottomStyle):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineWidth):
(WebCore::InheritedFlags::setOutlineStyle):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setOutlineOffset):
(WebCore::InheritedFlags::setColumnRuleColor):
(WebCore::InheritedFlags::setColumnRuleWidth):

rendering/style/StyleMultiColData.h:

(WebCore::StyleMultiColData::ruleWidth):

1:20 PM Changeset in webkit [57354] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-04-09 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Make CallIdentifier constructor to handle null urls.

https://bugs.webkit.org/show_bug.cgi?id=37341

profiler/CallIdentifier.h: (JSC::CallIdentifier::CallIdentifier):

1:10 PM Changeset in webkit [57353] by weinig@apple.com

1 edit in trunk/WebKit2/ChangeLog

Add some missing URLs to ChangeLogs.

1:08 PM Changeset in webkit [57352] by weinig@apple.com

21 edits
10 adds in trunk/WebKit2

Fix for https://bugs.webkit.org/show_bug.cgi?id=37347
Don't use CF types in the new C API

Reviewed by Anders Carlsson.

Replace all uses of CF types in the C API.

Replace CFStringRef with WKStringRef.
Replace CFURLRef with WKURLRef.

WebKit2.xcodeproj/project.pbxproj: Add new files.

Shared/KURLWrapper.h: Added. RefCounted wrapper around KURL.
UIProcess/API/C/WKAPICast.h: Add new conversions.
UIProcess/API/C/WKBase.h: Add new types.
UIProcess/API/C/WKFrame.cpp:
UIProcess/API/C/WKFrame.h:
UIProcess/API/C/WKPage.cpp:
UIProcess/API/C/WKPage.h:

Replace uses of CF types with WK equivalents.

UIProcess/API/C/WKString.cpp: Added.
UIProcess/API/C/WKString.h: Added.

Represents a WebCore::StringImpl*.

UIProcess/API/C/WKURL.cpp: Added.
UIProcess/API/C/WKURL.h: Added.

Represents a WebKit::KURLWrapper*.

UIProcess/API/C/cf: Added.
UIProcess/API/C/cf/WKStringCF.cpp: Added.
UIProcess/API/C/cf/WKStringCF.h: Added.
UIProcess/API/C/cf/WKURLCF.cpp: Added.
UIProcess/API/C/cf/WKURLCF.h: Added.

CoreFoundation conversion files. Allows converting

WKStringRef <-> CFStringRef
WKURLRef <-> CFURLRef

UIProcess/ScriptReturnValueCallback.cpp:

(WebKit::ScriptReturnValueCallback::performCallbackWithReturnValue):

UIProcess/ScriptReturnValueCallback.h:
UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):

UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):

UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didReceiveTitleForFrame):

UIProcess/WebLoaderClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::processDidExit):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::urlAtProcessExit):

UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):

UIProcess/WebPolicyClient.h:
UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::runJavaScriptAlert):

UIProcess/WebUIClient.h:

Don't use CF types internally at all.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::frameLoaderDestroyed):
Fix typo.

1:01 PM Changeset in webkit [57351] by eric@webkit.org

6 edits in trunk

2010-04-09 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Darin Adler.

Changed expectation for text status for HTTP status of 4xx following
a fix for localized status messages.
https://bugs.webkit.org/show_bug.cgi?id=37274

platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt:
platform/mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt:

2010-04-09 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Darin Adler.

Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText()
to return meaningful values.
https://bugs.webkit.org/show_bug.cgi?id=37274

platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::platformLazyInit):
platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):

12:50 PM Changeset in webkit [57350] by eric@webkit.org

13 edits in trunk

2010-04-09 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Move the IDB::open ExceptionCode paramter to be last
https://bugs.webkit.org/show_bug.cgi?id=37277

Move the ExceptionCode paramter to the last position in
IndexedDatabaseRequest::open and friends. It should definitely
go after the callbacks to keep the parameters that come directly
from javascript together. And having output parameters appear
last is done often in the code base, so it makes sense to push
it past the Frame* param as well.

No functional change.

bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: (WebCore::V8IndexedDatabaseRequest::openCallback):
storage/IndexedDatabase.h:
storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
storage/IndexedDatabaseImpl.h:
storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
storage/IndexedDatabaseRequest.h:

2010-04-09 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Move the IDB::open ExceptionCode paramter to be last
https://bugs.webkit.org/show_bug.cgi?id=37277

Move the ExceptionCode paramter to the last position in
IndexedDatabaseRequest::open and friends. It should definitely
go after the callbacks to keep the parameters that come directly
from javascript together. And having output parameters appear
last is done often in the code base, so it makes sense to push
it past the Frame* param as well.

public/WebIndexedDatabase.h:
src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
src/IndexedDatabaseProxy.h:
src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
src/WebIndexedDatabaseImpl.h:

12:29 PM Changeset in webkit [57349] by dimich@chromium.org

12 edits
2 adds in trunk

WebCore: WorkerGlobalScope.close() should let the currently running script complete execution, then terminate the worker.
https://bugs.webkit.org/show_bug.cgi?id=37053

Reviewed by Darin Adler.

WebCore:

Test: fast/workers/worker-close-more.html

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::):

bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::forbidExecution):

bindings/v8/WorkerScriptController.h:

(WebCore::WorkerScriptController::):
Added option parameter to forbidExecution (both JCS and V8 versions) that specifies whether currently running
script should be immediately terminated or left executed until the end.

bindings/js/WorkerScriptController.h:

(WebCore::WorkerScriptController::workerContextWrapper):
This method now can return 0 instead of context if the further execution of JS is forbidden. Since any JS execution requires
fetching JS global object first, returning 0 here is a good way to prevent re-entry into JS once worker started termination.
V8 version does similar thing already in WorkerScriptController::proxy().

workers/DedicatedWorkerContext.cpp:

(WebCore::DedicatedWorkerContext::postMessage):
Removed check that immediately disables postMessage from WorkerContext after close().

workers/WorkerContext.cpp:

(WebCore::CloseWorkerContextTask::create):
(WebCore::CloseWorkerContextTask::performTask):
(WebCore::CloseWorkerContextTask::isCleanupTask):
(WebCore::WorkerContext::close):
Use new forbidExecution(LetRunningScriptFinish) to avoid termination of script until it executes and exits.
Post a task to actually terminate the worker once the currently executing JS fragment exits.

workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):
Use new forbidExecution(TerminateRunningScript) to immediately terminate the JS.

LayoutTests:

fast/workers/resources/worker-close.js:
fast/workers/worker-close-expected.txt:

Updated tests to expect the script fragment that includes close() to run to completion.

fast/workers/worker-close-more-expected.txt: Added.
fast/workers/worker-close-more.html: Added.
fast/workers/worker-close.html:

Added test to check terminate() after close() and close() in the case of multiple MessagePort messages dispatching.

12:10 PM Changeset in webkit [57348] by eric@webkit.org

2 edits in trunk/WebKit/mac

2010-04-09 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r57343.
http://trac.webkit.org/changeset/57343
https://bugs.webkit.org/show_bug.cgi?id=37311

Broke Tiger compile.

WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]):

11:56 AM Changeset in webkit [57347] by mitz@apple.com

2 edits in trunk/WebKit/mac

<rdar://problem/7846015> REGRESSION (r57332) - Crash in [WebDynamicScrollBarsView(WebInternal) reflectScrolledClipView:] when opening the Downloads window

Reviewed by Darin Adler.

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView initWithCoder:]): Added. Calls super and then initializes _private.

11:03 AM Changeset in webkit [57346] by tkent@chromium.org

6 edits
13 adds in trunk

Implement interactive validation for forms.
https://bugs.webkit.org/show_bug.cgi?id=34930

Reviewed by Darin Adler.

WebCore:

HTMLFormControlElement::checkValidity() supports unhandled invalid control list
HTMLFormElement::validateInteractively() called from prepareSubmit() prevents the submission if neither noValidate nor formNoValidate is specified, and focuses on the first invalid control of which "invalid" event is not canceled.

Tests: fast/forms/checkValidity-cancel.html

fast/forms/interactive-validation-cancel.html
fast/forms/interactive-validation-formnovalidate.html
fast/forms/interactive-validation-novalidate.html
fast/forms/interactive-validation-prevented.html
fast/forms/interactive-validation-remove-node-in-handler.html

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::checkValidity):

If the control is invalid and the "invalid" is not canceled,
push the control to the specified vector.

html/HTMLFormControlElement.h:
html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

The main part of the interactive validation.

(WebCore::HTMLFormElement::prepareSubmit):

Calls validateInteractively().

(WebCore::HTMLFormElement::checkValidity):

Uses collectUnhandledInvalidControls().

(WebCore::HTMLFormElement::collectUnhandledInvalidControls):

html/HTMLFormElement.h:

LayoutTests:

Add tests for "invalid" event and interactive validation.

fast/forms/checkValidity-cancel-expected.txt: Added.
fast/forms/checkValidity-cancel.html: Added.
fast/forms/interactive-validation-cancel-expected.txt: Added.
fast/forms/interactive-validation-cancel.html: Added.
fast/forms/interactive-validation-formnovalidate-expected.txt: Added.
fast/forms/interactive-validation-formnovalidate.html: Added.
fast/forms/interactive-validation-novalidate-expected.txt: Added.
fast/forms/interactive-validation-novalidate.html: Added.
fast/forms/interactive-validation-prevented-expected.txt: Added.
fast/forms/interactive-validation-prevented.html: Added.
fast/forms/interactive-validation-remove-node-in-handler-expected.txt: Added.
fast/forms/interactive-validation-remove-node-in-handler.html: Added.
fast/forms/script-tests/checkValidity-cancel.js: Added.

10:45 AM Changeset in webkit [57345] by kov@webkit.org

2 edits in trunk/LayoutTests

2010-04-09 Gustavo Noronha Silva <Gustavo Noronha Silva>

[GTK+] media/video-src-invalid-remove.html
https://bugs.webkit.org/show_bug.cgi?id=37344

Skip test that is failing constantly but apparently without reason
on the 64 bits release bot.

platform/gtk/Skipped:

10:04 AM Changeset in webkit [57344] by weinig@apple.com

2 edits in trunk/WebCore

Fix the mac WebKit2 build.

WebCore.base.exp:

9:53 AM Changeset in webkit [57343] by eric@webkit.org

2 edits in trunk/WebKit/mac

2010-04-09 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>

WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]):

9:49 AM Changeset in webkit [57342] by abecsi@webkit.org

1 edit
107 adds in trunk/LayoutTests

[Qt] Add expected results for passing new tests. Compared to the Mac png-s and expected files these
platform dependent results only differ from Mac resulst in font metrics and svg implementation.

Rubber-stamped by Simon Hausmann.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu>

platform/qt/editing/deleting/non-smart-delete-expected.checksum: Added.
platform/qt/editing/deleting/non-smart-delete-expected.png: Added.
platform/qt/editing/deleting/non-smart-delete-expected.txt: Added.
platform/qt/fast/css/first-letter-first-line-hover-expected.checksum: Added.
platform/qt/fast/css/first-letter-first-line-hover-expected.png: Added.
platform/qt/fast/css/first-letter-first-line-hover-expected.txt: Added.
platform/qt/fast/forms/basic-selects-expected.checksum: Added.
platform/qt/fast/forms/basic-selects-expected.png: Added.
platform/qt/fast/forms/basic-selects-expected.txt: Added.
platform/qt/fast/repaint/moving-shadow-on-container-expected.checksum: Added.
platform/qt/fast/repaint/moving-shadow-on-container-expected.png: Added.
platform/qt/fast/repaint/moving-shadow-on-container-expected.txt: Added.
platform/qt/fast/repaint/moving-shadow-on-path-expected.checksum: Added.
platform/qt/fast/repaint/moving-shadow-on-path-expected.png: Added.
platform/qt/fast/repaint/moving-shadow-on-path-expected.txt: Added.
platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum: Added.
platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
platform/qt/fast/repaint/stacked-diacritics-expected.checksum: Added.
platform/qt/fast/repaint/stacked-diacritics-expected.png: Added.
platform/qt/fast/repaint/stacked-diacritics-expected.txt: Added.
platform/qt/fast/ruby: Added.
platform/qt/fast/ruby/ruby-inline-table-expected.checksum: Added.
platform/qt/fast/ruby/ruby-inline-table-expected.png: Added.
platform/qt/fast/ruby/ruby-inline-table-expected.txt: Added.
platform/qt/fast/runin/generated2-expected.checksum: Added.
platform/qt/fast/runin/generated2-expected.png: Added.
platform/qt/fast/runin/generated2-expected.txt: Added.
platform/qt/fast/runin/generated3-expected.checksum: Added.
platform/qt/fast/runin/generated3-expected.png: Added.
platform/qt/fast/runin/generated3-expected.txt: Added.
platform/qt/fast/runin/generated4-expected.checksum: Added.
platform/qt/fast/runin/generated4-expected.png: Added.
platform/qt/fast/runin/generated4-expected.txt: Added.
platform/qt/fast/text/international/hebrew-vowels-expected.checksum: Added.
platform/qt/fast/text/international/hebrew-vowels-expected.png: Added.
platform/qt/fast/text/international/hebrew-vowels-expected.txt: Added.
platform/qt/svg/custom/mask-invalidation-expected.checksum: Added.
platform/qt/svg/custom/mask-invalidation-expected.png: Added.
platform/qt/svg/custom/mask-invalidation-expected.txt: Added.
platform/qt/svg/custom/pattern-excessive-malloc-expected.checksum: Added.
platform/qt/svg/custom/pattern-excessive-malloc-expected.png: Added.
platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Added.
platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.checksum: Added.
platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.
platform/qt/svg/custom/pattern-skew-transformed-expected.checksum: Added.
platform/qt/svg/custom/pattern-skew-transformed-expected.png: Added.
platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Added.
platform/qt/svg/custom/stroke-width-large-expected.checksum: Added.
platform/qt/svg/custom/stroke-width-large-expected.png: Added.
platform/qt/svg/custom/stroke-width-large-expected.txt: Added.
platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt: Added.
platform/qt/svg/filters/filter-on-tspan-expected.checksum: Added.
platform/qt/svg/filters/filter-on-tspan-expected.png: Added.
platform/qt/svg/filters/filter-on-tspan-expected.txt: Added.
platform/qt/svg/overflow: Added.
platform/qt/svg/overflow/overflow-on-foreignObject-expected.checksum: Added.
platform/qt/svg/overflow/overflow-on-foreignObject-expected.png: Added.
platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt: Added.
platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.checksum: Added.
platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Added.
platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Added.
platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.checksum: Added.
platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.png: Added.
platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.txt: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.checksum: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.checksum: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.checksum: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.checksum: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.checksum: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.checksum: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.checksum: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.checksum: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.checksum: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Added.
platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
platform/qt/svg/text/selection-doubleclick-expected.checksum: Added.
platform/qt/svg/text/selection-doubleclick-expected.png: Added.
platform/qt/svg/text/selection-doubleclick-expected.txt: Added.
platform/qt/svg/text/selection-styles-expected.checksum: Added.
platform/qt/svg/text/selection-styles-expected.png: Added.
platform/qt/svg/text/selection-styles-expected.txt: Added.
platform/qt/svg/text/selection-tripleclick-expected.checksum: Added.
platform/qt/svg/text/selection-tripleclick-expected.png: Added.
platform/qt/svg/text/selection-tripleclick-expected.txt: Added.

9:38 AM Changeset in webkit [57341] by eric@webkit.org

4 edits in trunk/WebKit/chromium

2010-04-09 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

Complete move of createApplicationCacheHost from WebKitClient to WebFrameClient.
https://bugs.webkit.org/show_bug.cgi?id=37330

public/WebApplicationCacheHost.h:
public/WebKitClient.h:
src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):

9:35 AM Changeset in webkit [57340] by ap@apple.com

4 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=37181
<rdar://problem/7835374> REGRESSION (r54400): Hangs when doing AJAX update with large amount of data

Test: fast/events/gc-freeze-with-attribute-listeners.html

The problem was that we were creating JS wrappers for nodes with attribute event listeners,
and GC is very slow if there are nodes with wrappers in a detached tree whose root does not
have a wrapper.

bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Don't create wrappers for attribute event listeners - if there is a node, JSLazyEventListener::initializeJSFunction() will create one.

bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Added a FIXME about the problem we are stepping around now.

8:56 AM Changeset in webkit [57339] by Adam Roben

4 edits
8 adds in trunk

Make :visited tests added in r57292 not assert on Windows and GTK builds

Fixes <http://webkit.org/b/37333>.

Reviewed by Anders Carlsson.

WebKitTools:

Don't return 0 as a JSValueRef

That is an illegal use of the JSC API.

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):

DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):
Return an "undefined" JSValueRef instead of 0.

LayoutTests:

Add Windows- and GTK-specific results for new :visited tests

These platforms haven't yet implemented the new LayoutTestController
API these tests require. Implementing the API is tracked by
<http://webkit.org/b/37336> and <http://webkit.org/b/37337>.

platform/gtk/fast/history/nested-visited-test-expected.txt: Added.
platform/gtk/fast/history/self-is-visited-expected.txt: Added.
platform/gtk/fast/history/sibling-visited-test-expected.txt: Added.
platform/win/fast/history/nested-visited-test-expected.txt: Added.
platform/win/fast/history/self-is-visited-expected.txt: Added.
platform/win/fast/history/sibling-visited-test-expected.txt: Added.

7:25 AM QtWebKitBackportingFixes edited by joseph.ligman@nokia.com

(diff)

7:01 AM Changeset in webkit [57338] by xan@webkit.org

2 edits in trunk/WebCore

2010-04-09 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

WebGtk GLib-CRITICAL Segmentation fault
https://bugs.webkit.org/show_bug.cgi?id=34937

Do not crash if a plugin does not return anything in
NP_GetMIMEDescription. This can happen, and other ports gracefully
handle the situation.

plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):

6:44 AM Changeset in webkit [57337] by pfeldman@chromium.org

4 edits in trunk/WebCore

2010-04-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Cannot select elements within iframes with the magnifying glass.

https://bugs.webkit.org/show_bug.cgi?id=31732

inspector/InspectorController.cpp: (WebCore::InspectorController::inspect): (WebCore::InspectorController::handleMousePress):
inspector/InspectorController.h:
page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):

6:40 AM Changeset in webkit [57336] by Adam Roben

2 edits in trunk/WebKit/win

Windows Debug/Release build fix after r57244

WebKit.vcproj/WebKit.vcproj: Don't delay-load QuartzCore.dll or

QuartzCoreInterface.dll in any configurations. r57244 made this change
only for Debug_Internal.

6:14 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:13 AM Changeset in webkit [57335] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-04-09 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Crash on WebKit::WebGeolocationServiceBridgeImpl::stopUpdating() during frame disconnection
Should not try to access WebViewClient if the frame has already been disconnected.
https://bugs.webkit.org/show_bug.cgi?id=37318

src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):

6:03 AM Changeset in webkit [57334] by eric@webkit.org

4 edits in trunk/WebCore

2010-04-09 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt]Fix compile error with QT_NO_PROPERTIES
https://bugs.webkit.org/show_bug.cgi?id=36526

Disable dynamic properties when QT_NO_PROPERTIES is defined.

bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fieldNamed):
bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getPropertyNames): (JSC::Bindings::QtField::name): (JSC::Bindings::QtField::valueFromInstance): (JSC::Bindings::QtField::setValueToInstance):
bridge/qt/qt_runtime.h: (JSC::Bindings::QtField::):

5:47 AM QtWebKitJournal edited by Simon Hausmann

(diff)

5:15 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

5:14 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

5:12 AM Changeset in webkit [57333] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Symbian apps crash on exit due to a bad qObject_cast.

Patch by David Leong <david.leong@nokia.com> on 2010-04-09
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=37303

Added check for NULL to avoid the crash.

plugins/symbian/PluginViewSymbian.cpp:

(WebCore::PluginView::platformDestroy):

5:03 AM Changeset in webkit [57332] by mrowe@apple.com

3 edits in trunk/WebKit/mac

<rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]

[ Re-landing of r57329 with the requisite memset added in -initWithFrame: so that the tests keep working. ]

Reviewed by John Sullivan.

In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
size and layout of their subclasses is baked in at compile time. This results in instances
being allocated that are smaller than the new code expects, and may result in the new instance
variables sharing the same memory space as any instance variables that the subclass defines.

We can avoid this problem by having the class contain only a single member that acts as a pointer
to a heap-allocated structure that acts as storage for the real instance variables. This makes
us free to add instance variables in the future without risk of changing the size of the class.
To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
are able to run against older versions of WebKit we pad the class out to its previous size. This
results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
with both versions of the code.

This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
instance variables of its superclass. However, this is a private header and no known subclasses
of WebDynamicScrollBarsView access superclass instance variables in this fashion.

WebView/WebDynamicScrollBarsView.h:
WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView initWithFrame:]):
(-[WebDynamicScrollBarsView dealloc]):
(-[WebDynamicScrollBarsView finalize]):
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
(-[WebDynamicScrollBarsView contentViewFrame]):
(-[WebDynamicScrollBarsView tile]):
(-[WebDynamicScrollBarsView setSuppressLayout:]):
(-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
(-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
(-[WebDynamicScrollBarsView horizontalScrollingMode]):
(-[WebDynamicScrollBarsView verticalScrollingMode]):
(-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
(-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setScrollingModesLocked:]):
(-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
(-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
(-[WebDynamicScrollBarsView scrollWheel:]):

4:55 AM Changeset in webkit [57331] by Simon Hausmann

2 edits in trunk

Unreviewed crash fix.

Revert part of 57320 that would remove NDEBUG in release builds for
DRT, etc.

WebKit.pri:

4:55 AM Changeset in webkit [57330] by mrowe@apple.com

3 edits in trunk/WebKit/mac

Roll out r57329 since the bots are seeing lots of failures that I wasn't seeing locally.

4:51 AM WebKit2 edited by mrowe@apple.com

(diff)

4:47 AM WebKit2 edited by mjs@apple.com

(diff)

4:44 AM Changeset in webkit [57329] by mrowe@apple.com

3 edits in trunk/WebKit/mac

<rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]

Reviewed by John Sullivan.

WebView/WebDynamicScrollBarsView.h:
WebView/WebDynamicScrollBarsView.mm:

4:42 AM WebKit2 edited by mjs@apple.com

(diff)

4:30 AM Changeset in webkit [57328] by Csaba Osztrogonác

4 edits in trunk/WebKitTools

Make DumpRenderTree parallelizable
https://bugs.webkit.org/show_bug.cgi?id=36899

Reviewed by Eric Seidel.

DumpRenderTree/mac/DumpRenderTree.mm:

(libraryPathForDumpRenderTree): Use DUMPRENDERTREE_TEMP if exist.

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree): Use DUMPRENDERTREE_TEMP if exist.

Scripts/run-webkit-tests:
- Create a unique temporary directory and pass its path to DumpRenderTree with DUMPRENDERTREE_TEMP environment variable.

4:26 AM chromium-webkit-stack.png attached to WebKit2 by mjs@apple.com

4:26 AM WebKit2 edited by mjs@apple.com

(diff)

4:14 AM WebKit2 edited by mjs@apple.com

(diff)

4:13 AM WebKit2 edited by mjs@apple.com

(diff)

4:12 AM webkit2-stack.png attached to WebKit2 by mjs@apple.com

webkit2-stack

4:12 AM mac-webkit-stack.png attached to WebKit2 by mjs@apple.com

mac-webkit-stack

3:55 AM Changeset in webkit [57327] by eric@webkit.org

6 edits in trunk/WebKit/qt

2010-04-09 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compile error with QT_NO_ACTION
https://bugs.webkit.org/show_bug.cgi?id=36529

Make sure QT_NO_ACTION is not defined to use QAction

Api/qgraphicswebview.cpp: (QGraphicsWebView::pageAction):
Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPage::updatePositionDependentActions):
Api/qwebpage.h:
Api/qwebview.cpp:
Api/qwebview.h:

3:53 AM Changeset in webkit [57326] by mrowe@apple.com

3 edits
1 add in trunk

<http://webkit.org/b/37326> IDL files are being copied in to the WebCore framework again

Reviewed by Oliver Hunt.

WebCore:

WebCore.xcodeproj/project.pbxproj: Wire up the script. Remove the three inappropriate

files from the Copy Bundle Resources build phase.

WebKitTools:

Add a script to detect the presence of inappropriate files in the frameworks. At present
it only looks for .css, .idl and .in files in the top level of WebCore.framework/Resources,
as these are the only cases we've encountered recently. It can be extended to check the
other frameworks or for other inappropriate files in the future.

Scripts/check-for-inappropriate-files-in-framework: Added.

3:46 AM Changeset in webkit [57325] by eric@webkit.org

3 edits in trunk/WebKit/chromium

2010-04-09 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Expose SecurityOrigin::canRequest in WebSecurityOrigin.
https://bugs.webkit.org/show_bug.cgi?id=37271

public/WebSecurityOrigin.h:
src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::canRequest):

3:37 AM Changeset in webkit [57324] by eric@webkit.org

8 edits in trunk

2010-04-09 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Passing null WebGLObjects should synthesize INVALID_VALUE error
https://bugs.webkit.org/show_bug.cgi?id=37047

fast/canvas/webgl/error-reporting-expected.txt: Change a few errors from INVALID_OPERATION to INVALID_VALUE.
fast/canvas/webgl/getActiveTest-expected.txt: Ditto.
fast/canvas/webgl/null-object-behaviour-expected.txt: Ditto.
fast/canvas/webgl/script-tests/error-reporting.js: Ditto.

2010-04-09 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Passing null WebGLObjects should synthesize INVALID_VALUE error
https://bugs.webkit.org/show_bug.cgi?id=37047

html/canvas/WebGLRenderingContext.cpp: Synthesize INVALID_VALUE error when input object is 0. (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::validateWebGLObject): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::shaderSource):
html/canvas/WebGLRenderingContext.h: Add helper function to validate webgl object input parameters.

3:10 AM Changeset in webkit [57323] by Simon Hausmann

2 edits in trunk/WebKit/qt

[Qt] tests/qgraphicswebview fails
https://bugs.webkit.org/show_bug.cgi?id=37317

Reviewed by Lars Knoll.

Api/qwebpage.cpp:

(QWebPage::userAgentForUrl): Don't crash if the ownerWidget is null.

3:06 AM Changeset in webkit [57322] by eric@webkit.org

6 edits
2 adds in trunk

2010-04-09 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=37174

fast/canvas/webgl/copy-tex-image-and-sub-image-2d-expected.txt: Added.
fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html: Added.
fast/canvas/webgl/resources/utils3d.js: Add ContextAttributes parameter to initWebGL function.

2010-04-09 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=37174

Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html

platform/graphics/mac/GraphicsContext3DMac.cpp: resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D. (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D):

2010-04-09 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=37174

Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html

src/WebGraphicsContext3DDefaultImpl.cpp: Resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D. (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D):

3:00 AM ApplicationsGtk edited by scaroo@gmail.com

(diff)

2:48 AM Changeset in webkit [57321] by eric@webkit.org

3 edits in trunk/WebCore

2010-04-09 Evan Stade <estade@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] <select> dropdowns don't die when an item is selected
https://bugs.webkit.org/show_bug.cgi?id=37243

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::hidePopup): (WebCore::PopupContainer::notifyPopupHidden): (WebCore::PopupListBox::hidePopup): inform container that popup is closing
platform/chromium/PopupMenuChromium.h:

2:03 AM Changeset in webkit [57320] by Simon Hausmann

6 edits in trunk

[Qt] Fix crashes with package builds in release

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-04-09
Reviewed by Simon Hausmann.

WebKit.pri: Don't randomly add NDEBUG to the defines.

JavaScriptCore:

Add NDEBUG to the defines for package build in JavaScriptCore.pri,
so that it's consistently used for JavaScriptCore, WebCore, jsc and all
other tools using wtf, etc. data structures directly. Mixing NDEBUG with
non-NDEBUG builds causes crashes due to differences in data structures when
assertions/checks are enabled.

JavaScriptCore.pri:

WebCore:

WebCore.pro: Don't add NDEBUG to the defines here, add it from JavaScriptCore.pri

1:59 AM Changeset in webkit [57319] by eric@webkit.org

5 edits in trunk

2010-04-09 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Fraser.

Update test as the 'all' value has been removed

fast/media/media-feature-wgt-view-mode.html:

2010-04-09 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Fraser.

Remove "all" value from the view-mode media feature (as agreed on
1-Apr-2010) in the Widgets voice conf.

css/CSSValueKeywords.in:
css/MediaQueryEvaluator.cpp: (WebCore::view_modeMediaFeatureEval):

1:36 AM Changeset in webkit [57318] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2010-04-09 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Implement NO_RETURN for COMPILER(MSVC).
https://bugs.webkit.org/show_bug.cgi?id=33056

Added NO_RETURN_WITH_VALUE for functions with non-void return type.

jsc.cpp:
wtf/AlwaysInline.h:
wtf/FastMalloc.cpp:

1:21 AM WebKit2 edited by mjs@apple.com

(diff)

1:20 AM QtWebKitRelease20 edited by Simon Hausmann

(diff)

1:15 AM Changeset in webkit [57317] by eric@webkit.org

4 edits in trunk/WebCore

2010-04-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57286.
http://trac.webkit.org/changeset/57286
https://bugs.webkit.org/show_bug.cgi?id=37312

"Caused intermittent test failures on all Mac bots."
(Requested by eseidel on #webkit).

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::originQuotaManagerNoLock): (WebCore::DatabaseTracker::originQuotaManager): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::getMaxSizeForDatabase): (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::addOpenDatabase): (WebCore::DatabaseTracker::removeOpenDatabase): (WebCore::DatabaseTracker::usageForOriginNoLock): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): (WebCore::DatabaseTracker::deleteOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile):
storage/DatabaseTracker.h:
storage/SQLTransactionClient.cpp: (WebCore::SQLTransactionClient::didExecuteStatement):

1:06 AM WebKit2 edited by mjs@apple.com

(diff)

12:59 AM Changeset in webkit [57316] by abecsi@webkit.org

7 edits in trunk

[Qt] User agent style sheets are crippled by moc -E in make-css-file-arrays.pl
https://bugs.webkit.org/show_bug.cgi?id=37296

Reviewed by Simon Hausmann.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu>

WebCore:

Do not use moc to preprocess user agent style sheets because it removes at-symbols
and hexadecimal colours from declarations.
Remove unneeded preprocessor usage from make-css-file-arrays.pl since the script
processes default css files using regular expressions therefore preprocessing is redundant.

WebCore.pri: remove --preprocessor usage
css/make-css-file-arrays.pl: remove gcc dependency

LayoutTests:

Update expected files after removal of moc preprocessing of default css sheets.
These test results now only differ in metrics from Mac ones.

platform/qt/editing/execCommand/insert-list-xml-expected.txt:
platform/qt/svg/custom/createImageElement2-expected.txt:
platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:

12:58 AM WebKit2 edited by mjs@apple.com

(diff)

12:35 AM Changeset in webkit [57315] by mrowe@apple.com

5 edits in trunk

Versioning.

12:33 AM Changeset in webkit [57314] by mrowe@apple.com

1 copy in tags/Safari-533.4

New tag.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed