Context Navigation

← Previous Period
Next Period →

Timeline

Apr 11, 2010:

11:53 PM April 2010 Meeting edited by xan@webkit.org

(diff)

11:19 PM April 2010 Meeting edited by levin@chromium.org

(diff)

11:11 PM April 2010 Meeting edited by levin@chromium.org

(diff)

10:47 PM April 2010 Meeting edited by levin@chromium.org

(diff)

10:41 PM April 2010 Meeting edited by mjs@apple.com

(diff)

9:54 PM Changeset in webkit [57469] by abarth@webkit.org

41 edits
2 deletes in trunk

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

Android.mk:
GNUmakefile.am:
WebCore.base.exp:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
dom/Document.cpp: (WebCore::Document::close):
dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
loader/DocumentWriter.cpp: Removed.
loader/DocumentWriter.h: Removed.
loader/FrameLoader.cpp: (WebCore::canReferToParentFrameEncoding): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::replaceDocument): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::responseMIMEType): (WebCore::FrameLoader::setResponseMIMEType): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::end): (WebCore::FrameLoader::endIfNotLoadingMainResource): (WebCore::FrameLoader::encoding): (WebCore::FrameLoader::setEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
loader/FrameLoader.h:
loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

9:34 PM April 2010 Meeting edited by morrita@google.com

(diff)

9:20 PM Changeset in webkit [57468] by abarth@webkit.org

41 edits
2 adds in trunk

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

This patch separates the begin/write/end cycle of decoding network
bytes and putting them into a document from the rest of the loading
machinery. The code and state required to write bytes into a document
doesn't interact very much with the rest of the loading machinery.

No tests because there is no behavior change (hopefully!).

Android.mk:
GNUmakefile.am:
WebCore.base.exp:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
dom/Document.cpp: (WebCore::Document::close):
dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
loader/DocumentWriter.cpp: Added.
loader/DocumentWriter.h: Added.
loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::setURL): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::didEndDocument): (WebCore::FrameLoader::willSetEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
loader/FrameLoader.h: (WebCore::FrameLoader::writer): (WebCore::FrameLoader::isDisplayingInitialEmptyDocument):
loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

9:05 PM April 2010 Meeting edited by ben@webkit.org

(diff)

8:52 PM Changeset in webkit [57467] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-04-11 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Refactored check-webkit-style so that the StyleChecker class
has no dependencies on patch-related concepts.

https://bugs.webkit.org/show_bug.cgi?id=37065

This patch is an intermediate step towards making the StyleChecker
class a generalized file processor that can do arbitary operations
on the files corresponding to a list of paths. This patch
also simplifies the unit-testing of patch-checking code.

Scripts/check-webkit-style:
- Updated to use the new PatchChecker class.

Scripts/webkitpy/style/checker.py:
- Refactored the StyleChecker.check_patch() method into the check() method of a new PatchChecker class.

Scripts/webkitpy/style/checker_unittest.py:
- Refactored the unit tests as necessary, changing the StyleCheckerCheckPatchTest class to a PatchCheckerTest class.

8:50 PM April 2010 Meeting edited by ben@webkit.org

(diff)

8:02 PM April 2010 Meeting edited by dimich@chromium.org

(diff)

7:56 PM April 2010 Meeting edited by morrita@google.com

(diff)

7:54 PM Changeset in webkit [57466] by abarth@webkit.org

6 edits in trunk/WebKitTools

2010-04-11 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix new-run-webkit-tests regressions cased by Eric's option parsing patch
https://bugs.webkit.org/show_bug.cgi?id=37430

We need some basic unit testing of this script, or we're going to keep
breaking it like this. Added missing namespace qualifiers and
propagated renaming of an option.

Scripts/webkitpy/common/config/ports.py:
Scripts/webkitpy/layout_tests/driver_test.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

7:47 PM Changeset in webkit [57465] by tony@chromium.org

2 edits
1 add in trunk/LayoutTests

2010-04-11 Tony Chang <tony@chromium.org>

Not reviewed, layout test fix for QT bots.

Update paste expected results on QT and skip a new d&d test.

platform/qt/Skipped:
platform/qt/editing/pasteboard/onpaste-text-html-expected.txt: Added.

7:21 PM Changeset in webkit [57464] by tony@chromium.org

6 edits
4 adds in trunk

2010-04-11 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] implement getData('text/html') for paste and drop events
https://bugs.webkit.org/show_bug.cgi?id=37193

editing/pasteboard/onpaste-text-html-expected.txt: Added.
editing/pasteboard/onpaste-text-html.html: Added.
fast/events/ondrop-text-html-expected.txt: Added.
fast/events/ondrop-text-html.html: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/win/Skipped:

2010-04-07 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] implement getData('text/html') for paste and drop events
https://bugs.webkit.org/show_bug.cgi?id=37193

Tests: editing/pasteboard/onpaste-text-html.html

fast/events/ondrop-text-html.html

platform/chromium/ClipboardChromium.cpp: (WebCore::): (WebCore::clipboardTypeFromMIMEType): add html type (WebCore::ClipboardChromium::clearData): implement clear text/html (WebCore::ClipboardChromium::getData): implement get text/html (similar to text/plain) (WebCore::ClipboardChromium::setData): implement set text/html

7:16 PM Changeset in webkit [57463] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-04-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Break new-run-webkit-tests options into groups for easier re-use and possible relocation
https://bugs.webkit.org/show_bug.cgi?id=37408

new-run-webkit-tests currently has one huge function for
dealing with all options-parsing.
This patch is a first attempt at trying to split that large
function down into smaller (hopefully more readable?) chunks
dealing with the different areas of options.
For example, it would make sense to move configuration
options off into some module which deals with the vagries of
WebKit's configuration system. It would also make sense to move
Chromium options off onto the Chromium port object (where they are used).
It may make sense to move results.json options over to the results.json code.
This change is a first iteration, and we will certainly need more
refinement to this code over time. Hopefully I didn't make things
harder to read here.

Scripts/webkitpy/layout_tests/driver_test.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

7:07 PM April 2010 Meeting edited by ariya@webkit.org

add myself (diff)

6:58 PM Changeset in webkit [57462] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

create-rollout copy needs to be updated to reflect removal of --no-build
https://bugs.webkit.org/show_bug.cgi?id=37425

Removed --no-build and --no-test from the instructions because these
don't exist anymore.

Scripts/webkitpy/tool/commands/download_unittest.py:
- Updated the expected results to reflect the new copy.
Scripts/webkitpy/tool/steps/postdiffforrevert.py:

6:04 PM Changeset in webkit [57461] by tony@chromium.org

5 edits in trunk

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57460.
http://trac.webkit.org/changeset/57460
https://bugs.webkit.org/show_bug.cgi?id=37424

broke chromium builders (Requested by tony^{work on #webkit).}

DEPS:
gyp_webkit:

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57460.
http://trac.webkit.org/changeset/57460
https://bugs.webkit.org/show_bug.cgi?id=37424

broke chromium builders (Requested by tony^{work on #webkit).}

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

5:49 PM Changeset in webkit [57460] by tony@chromium.org

5 edits in trunk

2010-04-11 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] update chromium DEPS for upstream compile
https://bugs.webkit.org/show_bug.cgi?id=36578

DEPS:
gyp_webkit: Add DumpRenderTree.gyp so we generate xcode projects for DRT.

2010-04-11 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] update chromium DEPS for upstream compile
https://bugs.webkit.org/show_bug.cgi?id=36578

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Small fix to avoid a circular dependency between WebKit.gyp and webkit.gyp.

4:57 PM April 2010 Meeting edited by tkent@chromium.org

(diff)

4:44 PM April 2010 Meeting edited by yutak@chromium.org

(diff)

4:22 PM April 2010 Meeting edited by tkent@chromium.org

Add tkent to attendees list (diff)

4:08 PM April 2010 Meeting edited by maruel@chromium.org

(diff)

4:05 PM April 2010 Meeting edited by abarth@webkit.org

(diff)

3:55 PM April 2010 Meeting edited by maruel@chromium.org

(diff)

3:47 PM April 2010 Meeting edited by eric@webkit.org

(diff)

3:25 PM ApplicationsGtk edited by khorben@defora.org

Added DeforaOS Surfer (diff)

3:23 PM ApplicationsGtk edited by khorben@defora.org

Typos (diff)

3:18 PM April 2010 Meeting edited by jamesr@google.com

(diff)

3:09 PM April 2010 Meeting edited by kbr@google.com

(diff)

2:42 PM April 2010 Meeting edited by staikos@kde.org

(diff)

2:22 PM Changeset in webkit [57459] by mrowe@apple.com

2 edits in tags/Safari-533.4.1/JavaScriptCore

Merge r57457.

2:15 PM April 2010 Meeting edited by mjs@apple.com

(diff)

2:14 PM April 2010 Meeting edited by mjs@apple.com

(diff)

2:14 PM April 2010 Meeting edited by mjs@apple.com

(diff)

2:12 PM Changeset in webkit [57458] by weinig@apple.com

5 edits
1 add in trunk/WebKit2

Fix for https://bugs.webkit.org/show_bug.cgi?id=37417
Move duplicated internal CoreIPC message kinds to a
header.

Reviewed by Darin Adler.

Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):

Platform/CoreIPC/CoreIPCMessageKinds.h: Added.

(CoreIPC::CoreIPCMessage::):
(CoreIPC::):

Platform/CoreIPC/mac/ConnectionMac.cpp:
WebKit2.xcodeproj/project.pbxproj:
win/WebKit2.vcproj:

2:05 PM April 2010 Meeting edited by mjs@apple.com

(diff)

2:04 PM Changeset in webkit [57457] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

<rdar://problem/7851332> Fix the build.

Reviewed by Sam Weinig.

wtf/FastMalloc.cpp:

(WTF::TCMallocStats::): Initialize extra members of malloc_introspection_t to zero.

2:04 PM April 2010 Meeting edited by mjs@apple.com

(diff)

1:55 PM April 2010 Meeting edited by mjs@apple.com

(diff)

1:54 PM April 2010 Meeting edited by mjs@apple.com

(diff)

1:46 PM April 2010 Meeting edited by mjs@apple.com

(diff)

1:43 PM April 2010 Meeting edited by eric@webkit.org

(diff)

1:43 PM April 2010 Meeting edited by eric@webkit.org

(diff)

1:42 PM April 2010 Meeting edited by eric@webkit.org

(diff)

1:41 PM April 2010 Meeting edited by eric@webkit.org

(diff)

1:41 PM April 2010 Meeting edited by eric@webkit.org

(diff)

1:37 PM April 2010 Meeting edited by weinig@apple.com

(diff)

1:35 PM April 2010 Meeting edited by mjs@apple.com

(diff)

1:34 PM Changeset in webkit [57456] by weinig@apple.com

2 edits in trunk/WebKit2

Disable not-implemented warnings by default for now.

Rubber-stamped by Anders Carlsson.

Shared/NotImplemented.h:

1:33 PM April 2010 Meeting edited by weinig@apple.com

(diff)

1:32 PM April 2010 Meeting edited by mjs@apple.com

(diff)

1:31 PM April 2010 Meeting edited by mjs@apple.com

(diff)

1:31 PM April 2010 Meeting edited by mjs@apple.com

(diff)

1:30 PM April 2010 Meeting edited by eric@webkit.org

(diff)

1:30 PM April 2010 Meeting edited by eric@webkit.org

(diff)

1:28 PM April 2010 Meeting edited by mjs@apple.com

(diff)

1:25 PM April 2010 Meeting edited by mjs@apple.com

(diff)

1:24 PM April 2010 Meeting edited by Chris Jerdonek

Typo fix (diff)

1:22 PM April 2010 Meeting edited by mjs@apple.com

(diff)

1:20 PM April 2010 Meeting edited by eric@webkit.org

(diff)

1:19 PM Changeset in webkit [57455] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Seidel.

svn-apply errors out when removing directories in git
https://bugs.webkit.org/show_bug.cgi?id=34871

Scripts/svn-apply: (isDirectoryEmptyForRemoval): early break if the directory doesn't exist (scmRemove): have git ignore unmatched files

1:18 PM Changeset in webkit [57454] by weinig@apple.com

12 edits in trunk/WebKit2

Fix for https://bugs.webkit.org/show_bug.cgi?id=37399
Remove use of STL data structures from CoreIPC code

Reviewed by Anders Carlsson.

Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decodeBytes):
(CoreIPC::ArgumentDecoder::removeAttachment):

Platform/CoreIPC/ArgumentDecoder.h:

Use WTF::Deque instead of std::queue and WTF::Vector
instead of std::vector. Replace use of malloc/free with
fastMalloc/fastFree.

Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::addAttachment):
(CoreIPC::ArgumentEncoder::releaseAttachments):

Platform/CoreIPC/ArgumentEncoder.h:

Use WTF::Vector instead of std::list. Replace use of malloc/free
with fastMalloc/fastFree.

Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::sendOutgoingMessages):
(CoreIPC::Connection::dispatchMessages):

Platform/CoreIPC/Connection.h:
Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createArgumentDecoder):
Use WTF::Vector instead of std::queue.

Platform/RunLoop.cpp:

(RunLoop::performWork):
(RunLoop::scheduleWork):

Platform/RunLoop.h:

Ditto.

Platform/WorkQueue.h:
Platform/win/WorkQueueWin.cpp:

(WorkQueue::scheduleWork):
(WorkQueue::performWork):
Ditto.

1:17 PM April 2010 Meeting edited by eric@webkit.org

(diff)

1:16 PM April 2010 Meeting edited by eric@webkit.org

(diff)

1:15 PM April 2010 Meeting edited by eric@webkit.org

(diff)

12:09 PM Changeset in webkit [57453] by dbates@webkit.org

4 edits
3 deletes in trunk/WebKitTools

2010-04-11 Daniel Bates <dbates@rim.com>

No review, rolling out 57440.
http://trac.webkit.org/changeset/57440
https://bugs.webkit.org/show_bug.cgi?id=27204

Did not handle Git patches that included both file and property
changes to the same file. Rolling this change out while I look
into this.

Scripts/VCSUtils.pm:
Scripts/svn-apply:
Scripts/svn-unapply:
Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Removed.
Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Removed.
Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Removed.

11:51 AM Changeset in webkit [57452] by eric@webkit.org

2 edits in trunk/WebKitSite

2010-04-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Seidel.

Minor Updates and Cleanup to the Contributing Page
https://bugs.webkit.org/show_bug.cgi?id=37415

coding/contributing.html:

11:43 AM Changeset in webkit [57451] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix typo in log path for AbstractQueue
https://bugs.webkit.org/show_bug.cgi?id=37414

Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:

10:34 AM Changeset in webkit [57450] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-04-11 Adam Barth <abarth@webkit.org>

Unreviewed. Add missing import statement.

Scripts/webkitpy/common/system/executive.py:

8:37 AM Changeset in webkit [57449] by eric@webkit.org

7 edits in trunk

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader

Unskip:

http/tests/security/no-referrer.html
fast/loader/onload-willSendRequest-null-for-frame.html
fast/loader/onload-willSendRequest-null-for-script.html

https://bugs.webkit.org/show_bug.cgi?id=37410

platform/qt/Skipped:

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader

https://bugs.webkit.org/show_bug.cgi?id=37410

WebCoreSupport/FrameLoaderClientQt.cpp: (qt_set_will_send_request_returns_null): (qt_set_will_send_request_clear_headers): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader

https://bugs.webkit.org/show_bug.cgi?id=37410

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setWillSendRequestReturnsNull): (LayoutTestController::setWillSendRequestClearHeader):
DumpRenderTree/qt/LayoutTestControllerQt.h:

2:05 AM Changeset in webkit [57448] by Csaba Osztrogonác

2 edits in trunk/WebKitTools

[Qt] Unreviewed buildfix for --debug build after r57433.

Refactor Qt DRT support in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35844

QtLauncher/main.cpp: qt_drt_garbageCollector_collect(); renamed to DumpRenderTreeSupportQt::garbageCollectorCollect();

(launcherMain):

12:46 AM Changeset in webkit [57447] by Joseph Pecoraro

2 edits in trunk/WebKitTools

2010-04-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Mark Rowe.

Make commit-log-editor Rubber-stamp aware. And other minor cleanups.
https://bugs.webkit.org/show_bug.cgi?id=37407

Scripts/commit-log-editor:

12:41 AM Changeset in webkit [57446] by eric@webkit.org

8 edits in trunk/WebKitTools

2010-04-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add PrettyPatch links to new-run-webkit-tests output
https://bugs.webkit.org/show_bug.cgi?id=37406

Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- We're leaking a file handle here, add a FIXME.
Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- Add pretty diff links.
Scripts/webkitpy/layout_tests/port/base.py:
- Add support for generating pretty diffs using PrettyPatch.
Scripts/webkitpy/layout_tests/port/webkit.py:
- We're leaking another file handle here, another FIXME.
Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Update write_output_files signature.
Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Remove unused arguments from write_output_files.
- Add support for dumping pretty diffs to write_output_files.
- Fix a bunch of file descriptor leaks in this file.
Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- Update write_output_files signature.

Apr 10, 2010:

11:57 PM Changeset in webkit [57445] by abarth@webkit.org

4 edits in trunk/WebCore

2010-04-10 Adam Barth <abarth@webkit.org>

Unreviewed. Rename m_forceSandboxFlags to m_forcedSandoxFlags, as
requested by Darin Adler.

loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::updateSandboxFlags):
loader/FrameLoader.h: (WebCore::FrameLoader::setForcedSandboxFlags):
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

11:52 PM Changeset in webkit [57444] by abarth@webkit.org

9 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

kill_process is copy/pasted in five places
https://bugs.webkit.org/show_bug.cgi?id=37405

We shouldn't replicate the kill_process logic in every port. Instead,
we should move the process interaction to Executive.

Dirk mentioned that he wanted this abstraction to make it easier to
mock things out for testing. It turns out this function is only used
in one place where it can't be used as a mock point for testing because
the corresponding create process actually creates a real process. In
the long term, we should indirect both these calls through a non-static
Executive as a mock point. However, we should wait on that until we
actually want to write the test.

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/chromium_linux.py:
Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/websocket_server.py:
Scripts/webkitpy/layout_tests/port/win.py:

11:13 PM Changeset in webkit [57443] by abarth@webkit.org

10 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests shouldn't alter its path to import packages
https://bugs.webkit.org/show_bug.cgi?id=37404

Scripts/new-run-webkit-tests:
Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
Scripts/webkitpy/layout_tests/test_types/image_diff.py:
Scripts/webkitpy/layout_tests/test_types/text_diff.py:
Scripts/webkitpy/thirdparty/simplejson/decoder.py:

11:05 PM Changeset in webkit [57442] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests should store results to a directory under the build tree
https://bugs.webkit.org/show_bug.cgi?id=37380

Scripts/webkitpy/layout_tests/port/webkit.py:

10:57 PM Changeset in webkit [57441] by mrowe@apple.com

8 edits
1 move in trunk

<rdar://problem/7845305> Further adoption of formal protocols for delegates.

Reviewed by Dan Bernstein.

Move EmptyProtocolDefinitions.h down in to WebCore, and add the new protocols. Adopt the protocols in the appropriate places.

WebCore:

WebCore.xcodeproj/project.pbxproj:
platform/mac/EmptyProtocolDefinitions.h: Renamed from WebKit/mac/Misc/EmptyProtocolDefinitions.h.
platform/network/mac/ResourceHandleMac.mm:

WebKit:

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Misc/EmptyProtocolDefinitions.h: Removed.
Misc/WebDownload.mm:
WebKitPrefix.h:

10:46 PM Changeset in webkit [57440] by eric@webkit.org

4 edits
3 adds in trunk/WebKitTools

2010-04-10 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27204

Implement support for changing the executable bit of a file.
The executable bit is among the most changed file properties.
Future support can include other property changes.

Currently, if a patch changes the executable bit of a file
it is not respected by svn-apply or svn-unapply. Since the
commit-queue bot uses these tools as part of its workflow,
such patches cannot be committed by it. That is, such patches
need to be committed by hand. Instead, we should add support
for the executable bit so that such patches can be committed
by the commit-queue bot.

Scripts/VCSUtils.pm: Also change reference to Apple Computer, Inc. in copyright to Apple, Inc.
Scripts/svn-apply:
Scripts/svn-unapply:
Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Added.
Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Added.
Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Added.

10:27 PM Changeset in webkit [57439] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-04-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WinEWS bot fails to svn update because scm.clean_working_directory leaves files around
https://bugs.webkit.org/show_bug.cgi?id=37401

The Git-based bots don't have this trouble because
Git.clean_working_directory fully removes files that were
marked as "add". SVN.clean_working_directory previously just
called "svn revert" which would leave added files in the
working directory untracked. This patch makes
SVN.clean_working_directory function more like
Git.clean_working_directory by removing added files after revert.

Scripts/webkitpy/common/checkout/scm.py:
- Add SCM.absolute_path for easy conversion between repository-relative paths and absolute paths.
- Add SCM.add and SCM.added_files
- Make SVN.clean_working_directory remove any added_files after svn revert.
- The new unit tests found a bug in Git.status_command, change to use git diff --name-status instead.
Scripts/webkitpy/common/checkout/scm_unittest.py:
- Add tests for added code.

10:17 PM Changeset in webkit [57438] by eric@webkit.org

4 edits in trunk/WebCore

2010-04-10 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Defense in depth: make sure an SVG document in the <img> context has
a unique origin.

https://bugs.webkit.org/show_bug.cgi?id=37392

svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Force the temporary rendering context into a unique origin.
loader/FrameLoader.h: (WebCore::FrameLoader::setForceSandboxFlags): Support for setting sandbox flags that will always be applied.
loader/FrameLoader.cpp: (WebCore::FrameLoader::updateSandboxFlags): Always apply any forced flags.

10:10 PM Changeset in webkit [57437] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests can't find ImageDiff on Windows
https://bugs.webkit.org/show_bug.cgi?id=37403

It turns out the build directory on Windows is structured differently
than it is on other platforms. Instead of assuming the normal
structure, we should just ask perl to figure it out for us.

Scripts/webkitpy/layout_tests/port/webkit.py:

10:03 PM Changeset in webkit [57436] by eric@webkit.org

4 edits
6 moves in trunk

2010-04-10 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Moving files associated with the GPU compositor from platform/graphics/skia to platform/graphics/chromium. Class
rename was done in a previous CL, this CL does the file move and rename.
https://bugs.webkit.org/show_bug.cgi?id=37231

No new functionality, no new tests.

WebCore.gypi:
platform/graphics/chromium/GraphicsLayerChromium.cpp: Copied from WebCore/platform/graphics/skia/GraphicsLayerSkia.cpp.
platform/graphics/chromium/GraphicsLayerChromium.h: Copied from WebCore/platform/graphics/skia/GraphicsLayerSkia.h.
platform/graphics/chromium/LayerChromium.cpp: Copied from WebCore/platform/graphics/skia/LayerSkia.cpp.
platform/graphics/chromium/LayerChromium.h: Copied from WebCore/platform/graphics/skia/LayerSkia.h.
platform/graphics/chromium/LayerRendererChromium.cpp: Copied from WebCore/platform/graphics/skia/LayerRendererSkia.cpp.
platform/graphics/chromium/LayerRendererChromium.h: Copied from WebCore/platform/graphics/skia/LayerRendererSkia.h.
platform/graphics/skia/GraphicsLayerSkia.cpp: Removed.
platform/graphics/skia/GraphicsLayerSkia.h: Removed.
platform/graphics/skia/LayerRendererSkia.cpp: Removed.
platform/graphics/skia/LayerRendererSkia.h: Removed.
platform/graphics/skia/LayerSkia.cpp: Removed.
platform/graphics/skia/LayerSkia.h: Removed.

2010-04-10 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Include file change as a result of renaming LayerRenderSkia.h to LayerRenderChromium.h
https://bugs.webkit.org/show_bug.cgi?id=37231

src/WebViewImpl.h:

9:03 PM Changeset in webkit [57435] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Change "Gathering files" status line to "Collecting tests". Gathering
the files sounds silly to me.

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

8:51 PM Changeset in webkit [57434] by abarth@webkit.org

4 edits
1 add in trunk

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix bugs to make new-run-webkit-tests almost run on windows
https://bugs.webkit.org/show_bug.cgi?id=37400

Add an empty test expectations file. I'm not sure whether we'll use
this one or make a common one for each port. However, as written, this
file is requires to run new-run-webkit-tests on Windows.

platform/win/test_expectations.txt: Added.

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix bugs to make new-run-webkit-tests almost run on windows
https://bugs.webkit.org/show_bug.cgi?id=37400

Fix some minor bugs that prevent new-run-webkit-tests from being run on
Windows. I still haven't run it to completion, but I'm getting
further.

Scripts/webkitpy/layout_tests/port/factory.py:
Scripts/webkitpy/layout_tests/port/webkit.py:

6:35 PM Changeset in webkit [57433] by eric@webkit.org

17 edits
2 adds in trunk

2010-04-10 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Refactor Qt DRT support in QtWebKit

https://bugs.webkit.org/show_bug.cgi?id=35844

WebCore.pro: Add DumpRenderTreeSupportQt.cpp

2010-04-10 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Refactor Qt DRT support in QtWebKit

Move all QT DRT support functions to a static class.

https://bugs.webkit.org/show_bug.cgi?id=35844

Api/qwebframe.cpp: Remove static functions.
Api/qwebframe.h: Make DumpRenderTreeSupportQt a friend.
Api/qwebpage.cpp: Remove static functions.
Api/qwebpage.h: Make DumpRenderTreeSupportQt a friend.
Api/qwebsecurityorigin.cpp: Remove static functions.
WebCoreSupport/DumpRenderTreeSupportQt.cpp: Added. (DumpRenderTreeSupportQt::DumpRenderTreeSupportQt): (DumpRenderTreeSupportQt::~DumpRenderTreeSupportQt): (DumpRenderTreeSupportQt::overwritePluginDirectories): (DumpRenderTreeSupportQt::workerThreadCount): (DumpRenderTreeSupportQt::setDumpRenderTreeModeEnabled): (DumpRenderTreeSupportQt::setFrameFlatteningEnabled): (DumpRenderTreeSupportQt::webPageSetGroupName): (DumpRenderTreeSupportQt::webPageGroupName): (DumpRenderTreeSupportQt::webInspectorExecuteScript): (DumpRenderTreeSupportQt::webInspectorClose): (DumpRenderTreeSupportQt::webInspectorShow): (DumpRenderTreeSupportQt::setTimelineProfilingEnabled): (DumpRenderTreeSupportQt::hasDocumentElement): (DumpRenderTreeSupportQt::setJavaScriptProfilingEnabled): (DumpRenderTreeSupportQt::pauseAnimation): (DumpRenderTreeSupportQt::pauseTransitionOfProperty): (DumpRenderTreeSupportQt::pauseSVGAnimation): (DumpRenderTreeSupportQt::numberOfActiveAnimations): (DumpRenderTreeSupportQt::clearFrameName): (DumpRenderTreeSupportQt::javaScriptObjectsCount): (DumpRenderTreeSupportQt::garbageCollectorCollect): (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread): (DumpRenderTreeSupportQt::counterValueForElementById): (DumpRenderTreeSupportQt::pageNumberForElementById): (DumpRenderTreeSupportQt::numberOfPages): (DumpRenderTreeSupportQt::suspendActiveDOMObjects): (DumpRenderTreeSupportQt::resumeActiveDOMObjects): (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld): (DumpRenderTreeSupportQt::whiteListAccessFromOrigin): (DumpRenderTreeSupportQt::resetOriginAccessWhiteLists): (DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme): (DumpRenderTreeSupportQt::setCaretBrowsingEnabled): (DumpRenderTreeSupportQt::setMediaType): (DumpRenderTreeSupportQt::setViewMode):
WebCoreSupport/DumpRenderTreeSupportQt.h: Added.
WebCoreSupport/EditorClientQt.h:
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::multiplePageGroupsAndLocalStorage): (tst_QWebPage::inputMethodsTextFormat): (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):

2010-04-10 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Refactor Qt DRT support in QtWebKit

Update Qt DRT to use new DumpRenderTreeSupportQt static class.

https://bugs.webkit.org/show_bug.cgi?id=35844

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::dumpFramesAsText):
DumpRenderTree/qt/DumpRenderTreeQt.h:
DumpRenderTree/qt/GCControllerQt.cpp: (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
DumpRenderTree/qt/GCControllerQt.h:
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::counterValueForElementById): (LayoutTestController::setViewModeMediaFeature): (LayoutTestController::setMediaType): (LayoutTestController::closeWebInspector): (LayoutTestController::showWebInspector): (LayoutTestController::evaluateInWebInspector): (LayoutTestController::setFrameFlatteningEnabled): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setTimelineProfilingEnabled): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::sampleSVGAnimationForElementAtTime): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::whiteListAccessFromOrigin): (LayoutTestController::setCaretBrowsingEnabled): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): (LayoutTestController::workerThreadCount): (LayoutTestController::pageNumberForElementById): (LayoutTestController::numberOfPages):
DumpRenderTree/qt/LayoutTestControllerQt.h:

6:25 PM Changeset in webkit [57432] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move global queue log to the logs directory so it survives git clean -f
https://bugs.webkit.org/show_bug.cgi?id=37395

Scripts/webkitpy/tool/commands/queues.py:

6:16 PM Changeset in webkit [57431] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-04-10 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Eric Seidel.

Cleanup after chromium breakage. All interface methods are
returned to being abstract.

public/WebNotificationPresenter.h:

6:06 PM Changeset in webkit [57430] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should spam when it encounters errors
https://bugs.webkit.org/show_bug.cgi?id=37329

We need to always update the status server so we don't get stuck in a
spam loop. I tried writing a test for this change, but it kind of
got out of control. We need a better way to do failure injection.

Scripts/webkitpy/tool/commands/sheriffbot.py:

5:51 PM Changeset in webkit [57429] by Joseph Pecoraro

4 edits in trunk/WebCore

2010-04-10 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Missing CONTEXT_MENUS Guards
https://bugs.webkit.org/show_bug.cgi?id=37398

Added missing ENABLE(CONTEXT_MENUS) guards.

bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::disconnectClient):
inspector/InspectorFrontendHost.h:

5:49 PM Changeset in webkit [57428] by abarth@webkit.org

2 edits in trunk/LayoutTests

2010-04-10 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Add slow expectations based on webkit-dev discussion.

platform/mac/test_expectations.txt:

5:44 PM Changeset in webkit [57427] by abarth@webkit.org

4 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Unreviewed attempt to fix the Chromium Mac canary.

Scripts/webkitpy/common/config/ports.py:
Scripts/webkitpy/common/config/ports_unittest.py:
Scripts/webkitpy/common/system/executive.py:

5:28 PM Changeset in webkit [57426] by abarth@webkit.org

4 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Unreviewed.

Add the Apache bits to win.py for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37397

I still have run this yet, but I looked around to figure out what the
various paths appear to be. I'll figure out a way to remove the
copy/paste code in a future patch.

Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/win.py:

4:39 PM Changeset in webkit [57425] by abarth@webkit.org

4 edits
1 add in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out the win port for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37393

I haven't tried running this yet, but we've got to start somewhere.

Scripts/webkitpy/layout_tests/port/factory.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/win.py: Added.

3:44 PM Changeset in webkit [57424] by abarth@webkit.org

6 edits in trunk/WebKitTools

2010-04-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

webkit-patch land should not build and test by default
https://bugs.webkit.org/show_bug.cgi?id=33631

Reverse the sense of --no-build and --no-test to be --build and --test.
Also, decoupled the build and test options so you can test without
building.

(Patch manngled by Adam Barth. All bugs are his fault.)

Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/steps/options.py:
Scripts/webkitpy/tool/steps/runtests.py:

3:18 PM Changeset in webkit [57423] by abarth@webkit.org

4 edits
1 copy in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor WebKitPort out of MacPort to allow for WinPort
https://bugs.webkit.org/show_bug.cgi?id=37388

The split is a bit of a guess. We might have to adjust things once we
actually have a second port to work with.

Scripts/webkitpy/layout_tests/port/apache_http_server.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/webkit.py: Added.
Scripts/webkitpy/layout_tests/port/websocket_server.py:

3:17 PM Changeset in webkit [57422] by abarth@webkit.org

5 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

run_webkit_tests.py shouldn't have platform-specific logic
https://bugs.webkit.org/show_bug.cgi?id=37387

Dirk Pranke pointed out that my last patch was wrong because I
introduced platform-specific logic into run_webkit_tests.py, limiting
the parallelism in Chromium to work around a bug in the main Mac port.

Scripts/webkitpy/common/system/executive.py:
- Fix a typo pointed out by Chris Jerdonek.
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

3:09 PM Changeset in webkit [57421] by mrowe@apple.com

2 edits in trunk/WebKit2

Fix an obviously incorrect part of the Xcode configuration cleanup that resulted in debug builds
asserting shortly after launch.

WebKit2.xcodeproj/project.pbxproj: Fix the setting of DEBUG_DEFINES for the Debug configuration.

2:39 PM Changeset in webkit [57420] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-10 Stephan Aßmus <superstippi@gmx.de>

Reviewed by Eric Seidel.

[Haiku] Fix crash in Gradient::fill()
https://bugs.webkit.org/show_bug.cgi?id=37386

Covered by existing tests.

platform/graphics/haiku/GradientHaiku.cpp: (WebCore::Gradient::fill):
- Make sure the platform gradient is already cached before dereferencing its pointer.

2:30 PM Changeset in webkit [57419] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-10 Stephan Aßmus <superstippi@gmx.de>

Reviewed by Eric Seidel.

[Haiku] Fix build of ImageHaiku.cpp
<https://bugs.webkit.org/show_bug.cgi?id=37384>

No new tests needed.

platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
- include SharedBuffer.h
- changed parameter name to be in line with other ports, the code I landed in an earlier commit was already using this name.

5:28 AM Changeset in webkit [57418] by robert@webkit.org

4 edits in trunk

[Qt] Fix regressions in http/tests/navigation from r57416

2010-04-10 Robert Hogan <robert@webkit.org>

Unreviewed fix to regressions in r57416.

[Qt] Fix regressions in http/tests/navigation from r57416

Unskip tests skipped after regression in r57416.

https://bugs.webkit.org/show_bug.cgi?id=37237

platform/qt/Skipped:

2010-04-10 Robert Hogan <robert@webkit.org>

Unreviewed fix to regressions in r57416.

[Qt] Fix regressions in http/tests/navigation from r57416

Reset willSendRequestReturnsNullOnRedirect after each test to
prevent it leaking to subsequent tests.

Error pointed out by Jakub Wieczorek.

https://bugs.webkit.org/show_bug.cgi?id=37237

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):

3:41 AM Changeset in webkit [57417] by robert@webkit.org

2 edits
4 adds in trunk/LayoutTests

2010-04-10 Robert Hogan <robert@webkit.org>

Unreviewed fix to regressions from r57416.

Add expected results missing from r57416

Skip 2 tests that now fail.

http/tests/navigation/postredirect-reload.html
http/tests/navigation/redirect302-basic.html

These regressions will be worked under:
https://bugs.webkit.org/show_bug.cgi?id=37237

platform/qt/Skipped:
platform/qt/http/tests/misc/window-dot-stop-expected.txt: Added.
platform/qt/http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.

3:12 AM Changeset in webkit [57416] by robert@webkit.org

8 edits in trunk

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.

Unskip http/tests/xmlhttprequest/abort-should-cancel-load.html

http/tests/misc/will-send-request-returns-null-on-redirect.html
fast/loader/user-style-sheet-resource-load-callbacks.html
http/tests/misc/window-dot-stop.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
http/tests/xmlhttprequest/abort-should-cancel-load.html

QNetworkReply::OperationCanceledError has a value of 5 rather than -999, so add platform-specific results accordingly.

Add platform-specific results for the the following, though leave them skipped for now. They've started failing again
since review was granted (see https://bugs.webkit.org/show_bug.cgi?id=37382):

http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

https://bugs.webkit.org/show_bug.cgi?id=37237

platform/qt/Skipped:
platform/qt/http/tests/misc/window-dot-stop-expected.txt: Added.
platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
platform/qt/http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.

Unskip http/tests/xmlhttprequest/abort-should-cancel-load.html

http/tests/misc/will-send-request-returns-null-on-redirect.html
fast/loader/user-style-sheet-resource-load-callbacks.html
http/tests/misc/window-dot-stop.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
http/tests/xmlhttprequest/abort-should-cancel-load.html

QNetworkReply::OperationCanceledError has a value of 5, so update expected results accordingly.

https://bugs.webkit.org/show_bug.cgi?id=37237

WebCoreSupport/FrameLoaderClientQt.cpp: (qt_set_will_send_request_returns_null_on_redirect): (drtDescriptionSuitableForTestResult): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoading): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.

Add support for layoutTestController.setWillSendRequestReturnsNullOnRedirect to Qt DRT.
Prevent dumping resource load callbacks once layout test has dumped.

https://bugs.webkit.org/show_bug.cgi?id=37237

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
DumpRenderTree/qt/LayoutTestControllerQt.h:

2:09 AM Changeset in webkit [57415] by scherkus@chromium.org

2 edits in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, fixing description and expectation for media/video-replaces-poster.html.

platform/chromium/test_expectations.txt:

2:06 AM Changeset in webkit [57414] by scherkus@chromium.org

2 edits in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, marking media/video-replaces-poster.html as flaky.

platform/chromium/test_expectations.txt:

1:35 AM Changeset in webkit [57413] by scherkus@chromium.org

3 edits in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in corrected baselines for media/video-replaces-poster.html
on Chromium Win.

platform/chromium-win/media/video-replaces-poster-expected.checksum:
platform/chromium-win/media/video-replaces-poster-expected.png:

1:18 AM Changeset in webkit [57412] by Csaba Osztrogonác

4 edits in trunk/LayoutTests

Unreviewed, platform specific expected files updated after r57408.

[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503

platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: updated.
platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.

1:11 AM Changeset in webkit [57411] by scherkus@chromium.org

120 edits
41 adds in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, enable the rest of the fast/media tests for Chromium Mac and Linux
by checking in new baselines.

platform/chromium-linux/fast/media/media-descriptor-syntax-01-expected.checksum:
platform/chromium-linux/fast/media/media-descriptor-syntax-01-expected.png:
platform/chromium-linux/fast/media/media-descriptor-syntax-02-expected.checksum:
platform/chromium-linux/fast/media/media-descriptor-syntax-02-expected.png:
platform/chromium-linux/fast/media/media-descriptor-syntax-03-expected.checksum:
platform/chromium-linux/fast/media/media-descriptor-syntax-03-expected.png:
platform/chromium-linux/fast/media/media-descriptor-syntax-04-expected.checksum:
platform/chromium-linux/fast/media/media-descriptor-syntax-04-expected.png:
platform/chromium-linux/fast/media/media-descriptor-syntax-05-expected.checksum:
platform/chromium-linux/fast/media/media-descriptor-syntax-05-expected.png:
platform/chromium-linux/fast/media/media-descriptor-syntax-06-expected.checksum:
platform/chromium-linux/fast/media/media-descriptor-syntax-06-expected.png:
platform/chromium-linux/fast/media/media-type-syntax-01-expected.checksum:
platform/chromium-linux/fast/media/media-type-syntax-01-expected.png:
platform/chromium-linux/fast/media/media-type-syntax-02-expected.checksum:
platform/chromium-linux/fast/media/media-type-syntax-02-expected.png:
platform/chromium-linux/fast/media/mq-animation-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-animation-expected.png: Added.
platform/chromium-linux/fast/media/mq-aspect-ratio-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-aspect-ratio-expected.png: Added.
platform/chromium-linux/fast/media/mq-compound-query-01-expected.checksum:
platform/chromium-linux/fast/media/mq-compound-query-01-expected.png:
platform/chromium-linux/fast/media/mq-compound-query-02-expected.checksum:
platform/chromium-linux/fast/media/mq-compound-query-02-expected.png:
platform/chromium-linux/fast/media/mq-compound-query-03-expected.checksum:
platform/chromium-linux/fast/media/mq-compound-query-03-expected.png:
platform/chromium-linux/fast/media/mq-compound-query-04-expected.checksum:
platform/chromium-linux/fast/media/mq-compound-query-04-expected.png:
platform/chromium-linux/fast/media/mq-compound-query-05-expected.checksum:
platform/chromium-linux/fast/media/mq-compound-query-05-expected.png:
platform/chromium-linux/fast/media/mq-grid-01-expected.checksum:
platform/chromium-linux/fast/media/mq-grid-01-expected.png:
platform/chromium-linux/fast/media/mq-grid-02-expected.checksum:
platform/chromium-linux/fast/media/mq-grid-02-expected.png:
platform/chromium-linux/fast/media/mq-invalid-media-feature-01-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-media-feature-01-expected.png:
platform/chromium-linux/fast/media/mq-invalid-media-feature-02-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-media-feature-02-expected.png:
platform/chromium-linux/fast/media/mq-invalid-media-feature-03-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-media-feature-03-expected.png:
platform/chromium-linux/fast/media/mq-invalid-media-feature-04-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-media-feature-04-expected.png:
platform/chromium-linux/fast/media/mq-invalid-syntax-01-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-syntax-01-expected.png:
platform/chromium-linux/fast/media/mq-invalid-syntax-02-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-syntax-02-expected.png:
platform/chromium-linux/fast/media/mq-invalid-syntax-03-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-syntax-03-expected.png:
platform/chromium-linux/fast/media/mq-invalid-syntax-04-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-syntax-04-expected.png:
platform/chromium-linux/fast/media/mq-invalid-syntax-05-expected.checksum:
platform/chromium-linux/fast/media/mq-invalid-syntax-05-expected.png:
platform/chromium-linux/fast/media/mq-js-media-except-01-expected.checksum:
platform/chromium-linux/fast/media/mq-js-media-except-01-expected.png:
platform/chromium-linux/fast/media/mq-js-media-except-02-expected.checksum:
platform/chromium-linux/fast/media/mq-js-media-except-02-expected.png:
platform/chromium-linux/fast/media/mq-js-media-except-03-expected.checksum:
platform/chromium-linux/fast/media/mq-js-media-except-03-expected.png:
platform/chromium-linux/fast/media/mq-js-media-forward-syntax-expected.checksum:
platform/chromium-linux/fast/media/mq-js-media-forward-syntax-expected.png:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-01-expected.checksum:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-01-expected.png:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-02-expected.checksum:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-02-expected.png:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-03-expected.checksum:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-03-expected.png:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-04-expected.checksum:
platform/chromium-linux/fast/media/mq-js-stylesheet-media-04-expected.png:
platform/chromium-linux/fast/media/mq-max-pixel-ratio-expected.checksum:
platform/chromium-linux/fast/media/mq-max-pixel-ratio-expected.png:
platform/chromium-linux/fast/media/mq-min-constraint-expected.checksum:
platform/chromium-linux/fast/media/mq-min-constraint-expected.png:
platform/chromium-linux/fast/media/mq-orientation-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-orientation-expected.png: Added.
platform/chromium-linux/fast/media/mq-pixel-ratio-expected.checksum:
platform/chromium-linux/fast/media/mq-pixel-ratio-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-02-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-02-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-03-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-03-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-04-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-04-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-05-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-05-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-06-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-06-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-07-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-07-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.png:
platform/chromium-linux/fast/media/mq-relative-constraints-09-expected.checksum:
platform/chromium-linux/fast/media/mq-relative-constraints-09-expected.png:
platform/chromium-linux/fast/media/mq-simple-neg-query-01-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-neg-query-01-expected.png:
platform/chromium-linux/fast/media/mq-simple-neg-query-02-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-neg-query-02-expected.png:
platform/chromium-linux/fast/media/mq-simple-neg-query-03-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-neg-query-03-expected.png:
platform/chromium-linux/fast/media/mq-simple-neg-query-04-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-neg-query-04-expected.png:
platform/chromium-linux/fast/media/mq-simple-neg-query-05-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-neg-query-05-expected.png:
platform/chromium-linux/fast/media/mq-simple-query-01-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-query-01-expected.png:
platform/chromium-linux/fast/media/mq-simple-query-02-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-query-02-expected.png:
platform/chromium-linux/fast/media/mq-simple-query-03-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-query-03-expected.png:
platform/chromium-linux/fast/media/mq-simple-query-04-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-query-04-expected.png:
platform/chromium-linux/fast/media/mq-simple-query-05-expected.checksum:
platform/chromium-linux/fast/media/mq-simple-query-05-expected.png:
platform/chromium-linux/fast/media/mq-transform-01-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-transform-01-expected.png: Added.
platform/chromium-linux/fast/media/mq-transform-02-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-transform-02-expected.png: Added.
platform/chromium-linux/fast/media/mq-transform-03-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-transform-03-expected.png: Added.
platform/chromium-linux/fast/media/mq-transform-04-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-transform-04-expected.png: Added.
platform/chromium-linux/fast/media/mq-transition-expected.checksum: Added.
platform/chromium-linux/fast/media/mq-transition-expected.png: Added.
platform/chromium-linux/fast/media/mq-valueless-expected.checksum:
platform/chromium-linux/fast/media/mq-valueless-expected.png:
platform/chromium-linux/fast/media/mq-width-absolute-01-expected.checksum:
platform/chromium-linux/fast/media/mq-width-absolute-01-expected.png:
platform/chromium-linux/fast/media/mq-width-absolute-02-expected.checksum:
platform/chromium-linux/fast/media/mq-width-absolute-02-expected.png:
platform/chromium-linux/fast/media/mq-width-absolute-03-expected.checksum:
platform/chromium-linux/fast/media/mq-width-absolute-03-expected.png:
platform/chromium-linux/fast/media/mq-width-absolute-04-expected.checksum:
platform/chromium-linux/fast/media/mq-width-absolute-04-expected.png:
platform/chromium-linux/fast/media/viewport-media-query-expected.checksum:
platform/chromium-linux/fast/media/viewport-media-query-expected.png:
platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png: Added.
platform/chromium-mac/fast/media/mq-width-absolute-01-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png: Added.
platform/chromium-mac/fast/media/mq-width-absolute-02-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png: Added.
platform/chromium-mac/fast/media/mq-width-absolute-03-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png: Added.
platform/chromium-mac/fast/media/mq-width-absolute-04-expected.checksum: Added.
platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png: Added.
platform/chromium/test_expectations.txt:

12:47 AM Changeset in webkit [57410] by scherkus@chromium.org

4 edits
8 adds in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in updated baselines and expectations for Chromium media layout tests.

platform/chromium-linux/media/video-replaces-poster-expected.checksum: Added.
platform/chromium-linux/media/video-replaces-poster-expected.png: Added.
platform/chromium-mac/media/controls-drag-timebar-expected.txt: Added.
platform/chromium-mac/media/video-currentTime-set-expected.txt:
platform/chromium-mac/media/video-replaces-poster-expected.checksum: Added.
platform/chromium-mac/media/video-replaces-poster-expected.png: Added.
platform/chromium-win/media/controls-drag-timebar-expected.txt: Added.
platform/chromium-win/media/video-currentTime-set-expected.txt:
platform/chromium-win/media/video-replaces-poster-expected.checksum: Added.
platform/chromium-win/media/video-replaces-poster-expected.png: Added.
platform/chromium/test_expectations.txt:

12:46 AM Changeset in webkit [57409] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] animations/dynamic-stylesheet-loading.html fails with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=37381

platform/qt/Skipped: animations/dynamic-stylesheet-loading.html skipped until fix.

12:35 AM Changeset in webkit [57408] by Laszlo Gombos

13 edits
2 adds in trunk

2010-04-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503

Map WebKit notifications to Qt's SystemTray API and
implement DRT tracing.

This patch does not implement the security part of
WebKit notifications.

Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
Api/qwebpage.h:
Api/qwebpage_p.h:
WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::notificationPresenter):
WebCoreSupport/ChromeClientQt.h:
WebCoreSupport/NotificationPresenterClientQt.cpp: Added. (qt_dump_notification): (NotificationPresenterClientQt::NotificationPresenterClientQt): (NotificationPresenterClientQt::show): (NotificationPresenterClientQt::cancel): (NotificationPresenterClientQt::notificationObjectDestroyed): (NotificationPresenterClientQt::requestPermission): (NotificationPresenterClientQt::checkPermission):
WebCoreSupport/NotificationPresenterClientQt.h: Added.

2010-04-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503

No new tests enabled as notification DRT tests are
disabled at the moment.

WebCore.pri: Add files to the build system and turn on the feature by default.

WebCore.pro: Add files to the build system

bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission): (WebCore::JSNotification::addEventListener): (WebCore::JSNotification::removeEventListener): Fix build regresssion.

2010-04-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503

DRT stubs for notification. Enables to run and pass
3 (currently disabled) tests.

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::grantDesktopNotificationPermission): (LayoutTestController::checkDesktopNotificationPermission):
DumpRenderTree/qt/LayoutTestControllerQt.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed