Context Navigation

← Previous Period
Next Period →

Timeline

Apr 14, 2010:

11:49 PM April 2010 Meeting edited by vestbo@webkit.org

(diff)

9:48 PM Changeset in webkit [57633] by Simon Fraser

3 edits
4 adds in trunk

2010-04-14 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Repaint of fixed, transformed element is broken
https://bugs.webkit.org/show_bug.cgi?id=37637

RenderBox::computeRectForRepaint() failed to set the 'fixed' flag correctly
for elements that had both fixed position and a transform. If the element has
a transform, 'fixed' should only remain true if the element itself is fixed
position.

Also cache style()->position() in a local variable for performance.

Test: fast/repaint/fixed-tranformed.html

rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint):

9:47 PM Changeset in webkit [57632] by Simon Fraser

1 edit in trunk/JavaScriptCore/ChangeLog

Additional refptr/passrefptr workarounds for WINSCW compiler

https://bugs.webkit.org/show_bug.cgi?id=28054

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12

Reviewed by Tor Arne Vestbø.

wtf/PassRefPtr.h:

(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):

wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::::operator):

9:04 PM Changeset in webkit [57631] by eric@webkit.org

8 edits in trunk

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615

specification: http://dev.w3.org/2006/waf/widgets-vmmf/

fast/media/media-feature-wgt-view-mode.html:

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615

test: fast/media/media-feature-wgt-view-mode.html

specification: http://dev.w3.org/2006/waf/widgets-vmmf/

css/MediaQueryEvaluator.cpp: (WebCore::view_modeMediaFeatureEval):
page/ChromeClient.h: (WebCore::ChromeClient::isWindowed): (WebCore::ChromeClient::isMaximized): (WebCore::ChromeClient::isMinimized):

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615

test: fast/media/media-feature-wgt-view-mode.html

specification: http://dev.w3.org/2006/waf/widgets-vmmf/

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::isWindowed): (WebCore::ChromeClientQt::isFullscreen): (WebCore::ChromeClientQt::isMaximized): (WebCore::ChromeClientQt::isMinimized):
WebCoreSupport/ChromeClientQt.h:

8:37 PM Changeset in webkit [57630] by abarth@webkit.org

2 edits in trunk/WebCore

2010-04-14 Adam Barth <abarth@webkit.org>

Unreviewed attempt to fix Qt build.

bindings/js/JSNodeCustom.cpp:

8:34 PM Changeset in webkit [57629] by eric@webkit.org

6 edits in trunk

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
https://bugs.webkit.org/show_bug.cgi?id=37622

Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
(bug 35844). Moving it back.

Api/qwebpage.cpp: (qt_wrt_setViewMode):
WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setMediaType):
WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
https://bugs.webkit.org/show_bug.cgi?id=37622

Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
(bug 35844). Moving it back.

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature):

8:17 PM Changeset in webkit [57628] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-04-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix a memory leak in QScriptValue::inherits.

[Qt] QScriptValue::inherits has a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37617

qt/api/qscriptvalue_p.h: (QScriptValuePrivate::inherits):

8:11 PM Changeset in webkit [57627] by abarth@webkit.org

16 edits in trunk

2010-04-14 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Javascript URL can be set as iframe.src via multiple DOM aliases
https://bugs.webkit.org/show_bug.cgi?id=37031

Moved frame/iframe checks from Attr to Node on inherited members.
Node child manipulation methods now return NOT_SUPPORTED_ERR if used
on a frame/iframe src attribute.
NamedNodeMap set methods now perform frame/iframe src checks.
Moved allowSettingSrcToJavascriptURL static helper function from
JSElementCustom.cpp to exported function in JSDOMBinding.h.

bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
bindings/js/JSDOMBinding.cpp: (WebCore::allowSettingSrcToJavascriptURL):
bindings/js/JSDOMBinding.h:
bindings/js/JSElementCustom.cpp:
bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::setNamedItem): (WebCore::JSNamedNodeMap::setNamedItemNS):
bindings/js/JSNodeCustom.cpp: (WebCore::isAttrFrameSrc): (WebCore::JSNode::setNodeValue): (WebCore::JSNode::setTextContent): (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild):
bindings/v8/custom/V8AttrCustom.cpp:
bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::setNamedItemNSCallback): (WebCore::V8NamedNodeMap::setNamedItemCallback): (WebCore::toV8):
bindings/v8/custom/V8NodeCustom.cpp: (WebCore::isFrameSrc): (WebCore::V8Node::textContentAccessorSetter): (WebCore::V8Node::nodeValueAccessorSetter): (WebCore::V8Node::insertBeforeCallback): (WebCore::V8Node::replaceChildCallback): (WebCore::V8Node::removeChildCallback): (WebCore::V8Node::appendChildCallback):
dom/Attr.idl:
dom/NamedNodeMap.idl:
dom/Node.idl:

2010-04-14 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Fix frame/iframe src setting for JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=37031

http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
http/tests/security/xss-DENIED-iframe-src-alias.html:

8:07 PM Changeset in webkit [57626] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2010-04-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix a few memory leaks in QScriptEngine.

Syntax checking caused memory leak, not all temporary variables were released.

[Qt] Syntax checking in the QtScript cause a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37610

qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::checkSyntax):
qt/api/qscriptsyntaxcheckresult.cpp: (QScriptSyntaxCheckResultPrivate::errorMessage): (QScriptSyntaxCheckResultPrivate::errorLineNumber):

7:58 PM Changeset in webkit [57625] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-04-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix memory leak inside QScriptEnginePrivate::makeJSValue.

QScriptEnginePrivate::makeJSValue should release temporary JSStringRef variable.

[Qt] tst_QScriptValue::toString has a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37598

qt/api/qscriptengine_p.h: (QScriptEnginePrivate::makeJSValue):

6:39 PM Changeset in webkit [57624] by alex

2 edits in trunk/WebCore

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

We have to check if the resource handler is cancelled before
checking the client, other case it could crash.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):

6:06 PM Changeset in webkit [57623] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-04-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Rendering artifacts on Qt plugins when scrolling the page
https://bugs.webkit.org/show_bug.cgi?id=37152

Because we no longer repaint the entire viewport on scroll,
we must trigger a repaint of QtPluginWidgets when their geometry changes.

WebCoreSupport/FrameLoaderClientQt.cpp:

5:59 PM Changeset in webkit [57622] by dpranke@chromium.org

2 edits
1 add in trunk/WebKitTools

2010-04-15 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Add some very minimal unit tests for new-run-webkit-tests. This should
be enough to catch egregious brokenness like syntax errors and import
declaration issues.

https://bugs.webkit.org/show_bug.cgi?id=37432

Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added.

5:46 PM Changeset in webkit [57621] by andersca@apple.com

6 edits in trunk/WebKit2

2010-04-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix horizontal scrollbar repainting
https://bugs.webkit.org/show_bug.cgi?id=37626

Make sure that the update chunk is flipped because that's what WebCore expects.

Shared/mac/UpdateChunk.cpp: (WebKit::UpdateChunk::createImage):
Shared/mac/UpdateChunk.h: Add new createImage member function that creates a CGImageRef from the update chunk.

UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: (WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore): Pass the right rectangle here; CoreGraphics wants it in non-flipped coordinates.

(WebKit::DrawingAreaProxyUpdateChunk::ensureBackingStore):
Create a flipped backing store.

WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk): Flip the update chunk.

5:13 PM Changeset in webkit [57620] by tony@chromium.org

2 edits in trunk/WebKit/chromium

2010-04-12 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] update chromium DEPS for upstream compile
https://bugs.webkit.org/show_bug.cgi?id=36578

DEPS: Pull sub deps from chromium's DEPS file

4:33 PM Changeset in webkit [57619] by mrowe@apple.com

5 edits in trunk

Versioning.

4:31 PM Changeset in webkit [57618] by mrowe@apple.com

1 copy in tags/Safari-533.5

New tag.

4:25 PM Changeset in webkit [57617] by xan@webkit.org

2 edits in trunk/LayoutTests

2010-04-14 Xan Lopez <xlopez@igalia.com>

[GTK] scrollbars/scrollbar-crash-on-refresh.html is flakey on debug bots
https://bugs.webkit.org/show_bug.cgi?id=37623

We are on a mission here, people.

platform/gtk/Skipped:

4:11 PM Changeset in webkit [57616] by eric@webkit.org

5 edits
2 deletes in trunk

2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57609.
http://trac.webkit.org/changeset/57609
https://bugs.webkit.org/show_bug.cgi?id=37614

"Broke multiple builders. Probably needs new test results,
but may be an Inspector bug." (Requested by eseidel on
#webkit).

inspector/console-resource-errors-expected.txt: Removed.
inspector/console-resource-errors.html: Removed.

2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57609.
http://trac.webkit.org/changeset/57609
https://bugs.webkit.org/show_bug.cgi?id=37614

"Broke multiple builders. Probably needs new test results,
but may be an Inspector bug." (Requested by eseidel on
#webkit).

inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):

4:01 PM Changeset in webkit [57615] by Adam Roben

5 edits in trunk/WebKit/win

Expose DOMWrapperWorld::unregisterWorld as WebKit SPI on Windows

Fixes <http://webkit.org/b/37619>.

Reviewed by Steve Falkenburg.

Interfaces/IWebScriptWorld.idl: Added unregisterWorld.

Interfaces/WebKit.idl: Touched to force a build.

WebScriptWorld.cpp:

(WebScriptWorld::unregisterWorld):

WebScriptWorld.h:

Added. Just calls through to DOMWrapperWorld::unregisterWorld.

3:32 PM Changeset in webkit [57614] by alex

2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping fast/workers/shared-worker-frame-lifecycle.html
https://bugs.webkit.org/show_bug.cgi?id=37616

platform/gtk/Skipped:

3:15 PM Changeset in webkit [57613] by sfalken@apple.com

2 edits in trunk/WebCore

2010-04-14 Steve Falkenburg <sfalken@apple.com>

Reviewed by Dan Bernstein.

Don't cache SimpleFontData* in getLastResortFallbackFont. The cached entry may be invalidated.
https://bugs.webkit.org/show_bug.cgi?id=37599

platform/graphics/win/FontCacheWin.cpp: (WebCore::fontDataFromDescriptionAndLogFont): (WebCore::FontCache::getLastResortFallbackFont):

3:06 PM Changeset in webkit [57612] by alex

2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing, I've duplicated the other printing bugs and
left this one.
https://bugs.webkit.org/show_bug.cgi?id=37613

platform/gtk/Skipped:

2:53 PM Changeset in webkit [57611] by bweinstein@apple.com

1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to fix the build

2:51 PM Changeset in webkit [57610] by alex

2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping inspector/timeline-layout.html fails
https://bugs.webkit.org/show_bug.cgi?id=37611

platform/gtk/Skipped:

2:49 PM Changeset in webkit [57609] by eric@webkit.org

5 edits
2 adds in trunk

2010-04-14 Andrey Kosyakov <caseq@chromium.ru>

Reviewed by Timothy Hatcher.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
https://bugs.webkit.org/show_bug.cgi?id=37215

inspector/console-resource-errors-expected.txt: Added.
inspector/console-resource-errors.html: Added.

2010-04-14 Andrey Kosyakov <caseq@chromium.ru>

Reviewed by Timothy Hatcher.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
https://bugs.webkit.org/show_bug.cgi?id=37215

Test: inspector/console-resource-errors.html

inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):

2:38 PM Changeset in webkit [57608] by eric@webkit.org

5 edits in trunk/JavaScriptCore

2010-04-14 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Geoffrey Garen.

Move the YARR JIT fallback detection from RegexJIT.cpp to
RegexCompiler.cpp.

https://bugs.webkit.org/show_bug.cgi?id=37571

yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::atomBackReference): (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateTerm): (JSC::Yarr::RegexGenerator::RegexGenerator): (JSC::Yarr::jitCompileRegex):
yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::operator!):
yarr/RegexPattern.h: (JSC::Yarr::RegexPattern::RegexPattern): (JSC::Yarr::RegexPattern::reset):

2:24 PM Changeset in webkit [57607] by alex

2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing/page-break-always.html
https://bugs.webkit.org/show_bug.cgi?id=37607

platform/gtk/Skipped:

2:10 PM Changeset in webkit [57606] by eric@webkit.org

6 edits
1 delete in trunk

2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57599.
http://trac.webkit.org/changeset/57599
https://bugs.webkit.org/show_bug.cgi?id=37605

"Broke Chromium build" (Requested by dglazkov on #webkit).

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
platform/chromium/PopupMenuChromium.h:

2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57599.
http://trac.webkit.org/changeset/57599
https://bugs.webkit.org/show_bug.cgi?id=37605

"Broke Chromium build" (Requested by dglazkov on #webkit).

WebKit.gyp:
src/WebViewImpl.h:
tests/PopupMenuTest.cpp: Removed.

2:08 PM Changeset in webkit [57605] by weinig@apple.com

3 edits
2 adds in trunk/WebKit2

Add WKRetainPtr helper class as private header
https://bugs.webkit.org/show_bug.cgi?id=37603

Reviewed by Anders Carlsson.

WKRetainPtr is just like RetainPtr, but works for WK types instead of
CF/NS types.

UIProcess/API/cpp: Added.
UIProcess/API/cpp/WKRetainPtr.h: Added.
WebKit2.xcodeproj/project.pbxproj: Add new file.
win/WebKit2.vcproj: Ditto.

1:51 PM Changeset in webkit [57604] by aa@chromium.org

10 edits in trunk

2010-04-14 Aaron Boodman <aa@chromium.org>

Reviewed by David Levin.

Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.

https://bugs.webkit.org/show_bug.cgi?id=36623

Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.

notifications/Notification.cpp: (WebCore::Notification::Notification): Accept resolved KURL instead of relative string.
notifications/Notification.h: (WebCore::Notification::create): Ditto. (WebCore::Notification::iconURL): Return resolved KURL instead of relative string.
notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): Immediately resolve URL instead of passing off relative string. (WebCore::NotificationCenter::createNotification): Ditto.
notifications/NotificationContents.h: (WebCore::NotificationContents::NotificationContents): Accept resolved KURL instead of relative string. (WebCore::NotificationContents::icon): Return resolved URL.

2010-04-14 Aaron Boodman <aa@chromium.org>

Reviewed by David Levin.

Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.

https://bugs.webkit.org/show_bug.cgi?id=36623

Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.

public/WebNotification.h: Remove deprecated icon() method.
src/WebNotification.cpp: Ditto.

2010-04-14 Aaron Boodman <aa@chromium.org>

Reviewed by David Levin.

Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.

https://bugs.webkit.org/show_bug.cgi?id=36623

Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.

WebCoreSupport/NotificationPresenterClientQt.cpp: (NotificationPresenterClientQt::show): Return type of NotificationContents::iconURL() changed.

1:39 PM Changeset in webkit [57603] by andersca@apple.com

3 edits in trunk/WebCore

2010-04-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add ThemeMac::ensuredView and get rid of a workaround in ThemeMac::paintButton.
https://bugs.webkit.org/show_bug.cgi?id=37601

platform/mac/ThemeMac.h:
platform/mac/ThemeMac.mm: (-[WebCoreFlippedView isFlipped]): (WebCore::paintButton): (WebCore::ThemeMac::ensuredView):

1:32 PM Changeset in webkit [57602] by bweinstein@apple.com

2 edits
2 adds in trunk/WebKitTools

Add a way for the buildbot to kill any old processes that are running. This
is useful because the Windows bots can get in states where a process remains
running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red
state, and the processes must be killed manually.

Reviewed by Adam Roben.

BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill

the old processes that might be running.

BuildSlaveSupport/win/kill-old-processes: Added.

1:26 PM Changeset in webkit [57601] by weinig@apple.com

3 edits in trunk/WebKit2

Make the WebProcess a LSUIElement to suppress its icon from the Dock.

Reviewed by Anders Carlsson.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/Info.plist:

1:23 PM Changeset in webkit [57600] by weinig@apple.com

4 edits in trunk/WebKitTools

Tear down WebKit more completely on window closing and application
termination. We still don't block application termination for pending
close, but this is a step in the right direction.

Reviewed by Anders Carlsson.

MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate applicationWillTerminate:]):

MiniBrowser/mac/BrowserWindowController.h:
MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController dealloc]):
(-[BrowserWindowController windowWillClose:]):
(-[BrowserWindowController applicationTerminating]):

1:21 PM Changeset in webkit [57599] by eric@webkit.org

6 edits
1 add in trunk

2010-04-14 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
https://bugs.webkit.org/show_bug.cgi?id=37436

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
platform/chromium/PopupMenuChromium.h:

2010-04-14 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
Also adding unit-tests for the select popup code.
https://bugs.webkit.org/show_bug.cgi?id=37436

WebKit.gyp:
src/WebViewImpl.h: (WebKit::WebViewImpl::selectPopup):
tests/PopupMenuTest.cpp: Added.

1:18 PM Changeset in webkit [57598] by Adam Roben

2 edits in trunk/LayoutTests

Skip xss-DENIED-iframe-src-alias.html on Windows

I thought that skipping this test was causing other http tests to time
out, but Brian Weinstein pointed out that the timing-out tests come
before this one so shouldn't be affected by it.

<http://webkit.org/b/37096> tracks making this test not time out.

Rubber-stamped by Brian Weinstein.

platform/win/Skipped:

1:01 PM Changeset in webkit [57597] by eric@webkit.org

1 edit
3 adds in trunk/LayoutTests

2010-04-14 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

Add tests for ipv6 address canonicalization.
https://bugs.webkit.org/show_bug.cgi?id=37583

fast/url/ipv6-expected.txt: Added.
fast/url/ipv6.html: Added.
fast/url/script-tests/ipv6.js: Added.

12:44 PM PythonGuidelines edited by Chris Jerdonek

Clarified suggested import ordering style guideline. (diff)

12:42 PM Changeset in webkit [57596] by andersca@apple.com

3 edits in trunk/WebKit2

2010-04-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Factor code to paint into an update chunk out into a separate function.
https://bugs.webkit.org/show_bug.cgi?id=37594

WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk): (WebKit::DrawingAreaUpdateChunk::display): (WebKit::DrawingAreaUpdateChunk::setSize):
WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h:

12:24 PM Changeset in webkit [57595] by dumi@chromium.org

2 edits in trunk/WebCore

Remove an incorrect ASSERT in UniscribeHelper::draw().
https://bugs.webkit.org/show_bug.cgi?id=37533

Reviewed by Jian Li.

platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

11:56 AM Changeset in webkit [57594] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: readline shortcuts don't work in Chromium.

inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._onKeyDown): (WebInspector.TextPrompt.prototype._moveCaretToStartOfPrompt):

11:45 AM Changeset in webkit [57593] by alex

2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing/page-break-always-for-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=37592

platform/gtk/Skipped:

11:42 AM Changeset in webkit [57592] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-14 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Console: Shift-Tab does not cycle autocompletions in the reverse order
https://bugs.webkit.org/show_bug.cgi?id=37582

inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): (WebInspector.TextPrompt.prototype._completionsReady): (WebInspector.TextPrompt.prototype._tabKeyPressed):

11:30 AM Changeset in webkit [57591] by eric@webkit.org

8 edits in trunk

2010-04-14 Jeff Schiller <codedread@gmail.com>

Reviewed by Dirk Schulze.

Update path parser test for Bug 37413: https://bugs.webkit.org/show_bug.cgi?id=37413
now that all path segments render up until the first error

platform/mac/svg/custom/path-bad-data-expected.txt: updated path segments that render
svg/custom/path-bad-data.svg: updated test to ensure reference image is the same
svg/dom/fuzz-path-parser-expected.txt: updated path segments that render
svg/dom/path-parser-expected.txt: updated path segments that render
svg/dom/script-tests/path-parser.js: changed expected results for path segments that render ():

2010-04-14 Jeff Schiller <codedread@gmail.com>

Reviewed by Dirk Schulze.

Render SVG Paths up to first error, bug 37413: https://bugs.webkit.org/show_bug.cgi?id=37413

svg/SVGParserUtilities.cpp: (WebCore::SVGPathSegListBuilder::build):

11:18 AM Changeset in webkit [57590] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-14 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Ctrl-L (Clear History) does nothing on Windows
https://bugs.webkit.org/show_bug.cgi?id=37579

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):

10:51 AM Changeset in webkit [57589] by alex

2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing/numberOfPages.html
https://bugs.webkit.org/show_bug.cgi?id=37585

platform/gtk/Skipped:

10:42 AM Changeset in webkit [57588] by eric@webkit.org

1 edit
3 adds in trunk/LayoutTests

2010-04-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Add port URL tests
https://bugs.webkit.org/show_bug.cgi?id=37524

This went pretty well.

fast/url/port-expected.txt: Added.
fast/url/port.html: Added.
fast/url/script-tests/port.js: Added.

10:27 AM Changeset in webkit [57587] by eric@webkit.org

5 edits
1 copy in trunk/WebKitTools

2010-04-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Use pretty patch for confirming webkit-patch diffs
https://bugs.webkit.org/show_bug.cgi?id=37489

Scripts/webkitpy/common/prettypatch.py: Added.
Scripts/webkitpy/tool/commands/download_unittest.py:
Scripts/webkitpy/tool/commands/upload_unittest.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/steps/confirmdiff.py:

10:16 AM Changeset in webkit [57586] by eric@webkit.org

1 edit
3 adds in trunk/LayoutTests

2010-04-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Add LayoutTests for parsing "path" URLs
https://bugs.webkit.org/show_bug.cgi?id=37581

fast/url/path-url-expected.txt: Added.
fast/url/path-url.html: Added.
fast/url/script-tests/path-url.js: Added.

10:06 AM Changeset in webkit [57585] by eric@webkit.org

1 edit
3 adds in trunk/LayoutTests

2010-04-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Add LayoutTests for parsing standard URLs
https://bugs.webkit.org/show_bug.cgi?id=37580

fast/url/script-tests/standard-url.js: Added.
fast/url/standard-url-expected.txt: Added.
fast/url/standard-url.html: Added.

9:39 AM Changeset in webkit [57584] by Adam Roben

2 edits in trunk/LayoutTests

Roll out r57566

It seems to have caused other http tests to hang on Windows.

platform/win/Skipped:

9:26 AM Changeset in webkit [57583] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-04-14 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Maciej Stachowiak.

Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888

When building on (Snow) Leopard but targeting Tiger
(TARGETING_TIGER defined, BUILDING_ON_TIGER not defined),
WebKit would crash on Tiger because the tags passed to mmap
caused those function calls to fail.

Conversely, when building on Tiger but targeting Leopard
(BUILDING_ON_TIGER defined, TARGETING_LEOPARD defined), WebKit
would crash on Leopard because the tags passed to vm_map and
vm_allocate caused those function calls to fail.

Solution: Use TARGETING_TIGER rather than BUILDING_ON_TIGER to
govern the tag definitions. Use the same tags for vm_map and
vm_allocate regardless of target, since they work on
both. Fall back to the mmap tags that work on Tiger (that is,
"no tags") if targeting Tiger, since those tags also work on
Leopard.

wtf/VMTags.h:

9:17 AM WebInspector edited by apavlov@chromium.org

Fix column title, add Chrome/Chromium-specific shortcuts (diff)

9:08 AM Changeset in webkit [57582] by antonm@chromium.org

2 edits in trunk/LayoutTests

2010-04-14 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

Skip some and add test expectations for other layout tests which started to fail
against Chromium after http://trac.webkit.org/changeset/57535/

platform/chromium/test_expectations.txt:

8:48 AM WebInspector edited by apavlov@chromium.org

Add Win/Linux shortcuts (diff)

8:19 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

8:10 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

8:07 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

8:02 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

7:56 AM Changeset in webkit [57581] by Nikolas Zimmermann

2 edits in trunk/LayoutTests

2010-04-14 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skipping another crash on the 64bit Gtk slave.

platform/gtk/Skipped:

7:52 AM Changeset in webkit [57580] by alex

2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping plugins/open-and-close-window-with-plugin.html
https://bugs.webkit.org/show_bug.cgi?id=37572

Skipping media/video-played-ranges-1.html
https://bugs.webkit.org/show_bug.cgi?id=37573

platform/gtk/Skipped:

7:45 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

7:25 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

7:12 AM Changeset in webkit [57579] by antonm@chromium.org

26 edits
147 adds
1 delete in trunk/LayoutTests/platform

Not reviewed.

BUG=http://code.google.com/p/chromium/issues/detail?id=41450

6:49 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

5:12 AM Changeset in webkit [57578] by antonm@chromium.org

2 edits in trunk/WebCore

2010-04-14 Anton Muhin <antonm@chromium.org>

Not review, build fix.

Add <limits.h> include to bring UINT_MAX.

html/canvas/WebGLArray.h:

4:11 AM Changeset in webkit [57577] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57573.
http://trac.webkit.org/changeset/57573
https://bugs.webkit.org/show_bug.cgi?id=37569

Revert r57573 which unskipped http/tests/media/video-
cookie.html on SnowLeopard Intel Release (Tests). Let's get a
core builder back to green again. (Requested by WildFox on
#webkit).

platform/mac/Skipped:

4:00 AM Changeset in webkit [57576] by Nikolas Zimmermann

2 edits in trunk/WebCore

2010-04-14 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Attempt to unbreak build - NodeRenderStyle.h is an _interessting_ concept...

rendering/style/SVGRenderStyle.cpp: Include 'NodeRenderStyle.h'

3:44 AM Changeset in webkit [57575] by Nikolas Zimmermann

14 edits in trunk/WebCore

2010-04-14 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGRenderStyle/SVGRenderStyleDefs needs a cleanup
https://bugs.webkit.org/show_bug.cgi?id=37568

Cleanup SVGRenderStyle / SVGRenderStyleDefs:

use copy constructors in initialization list to initialize members, instead of assignment operators in the body
fix style issues (misplaced references, abbrevations)
merge StyleClipData/StyleMaskData to save memory, rename it StyleResourceData
move filter property in StyleResourceData
rename StyleMarkerData to StyleInheritedResourceData to highlight the difference to StyleResourceData
unify naming schemes for all resources (filter/clipper/masker/markers)
- clipPath() -> clipperResource()
- maskElement() -> maskerResource()
- startMarker() -> markerStartResource()
- midMarker() -> markerMidResource()
- endMarker() -> markerEndResource()
- filter() -> filterResource()

Adapt all callsites to the renames above.
No new tests, as this doesn't affect anything except memory overhead.

css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
rendering/RenderPath.cpp: (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer): (WebCore::deregisterFromResources):
rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeResources):
rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle): (WebCore::SVGRenderStyle::operator==): (WebCore::SVGRenderStyle::inheritedNotEqual): (WebCore::SVGRenderStyle::inheritFrom):
rendering/style/SVGRenderStyle.h:
rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleFillData::StyleFillData): (WebCore::StyleFillData::operator==): (WebCore::StyleStrokeData::StyleStrokeData): (WebCore::StyleStrokeData::operator==): (WebCore::StyleStopData::StyleStopData): (WebCore::StyleStopData::operator==): (WebCore::StyleTextData::StyleTextData): (WebCore::StyleMiscData::StyleMiscData): (WebCore::StyleMiscData::operator==): (WebCore::StyleShadowSVGData::StyleShadowSVGData): (WebCore::StyleShadowSVGData::operator==): (WebCore::StyleResourceData::StyleResourceData): (WebCore::StyleResourceData::operator==): (WebCore::StyleInheritedResourceData::StyleInheritedResourceData): (WebCore::StyleInheritedResourceData::operator==):
rendering/style/SVGRenderStyleDefs.h: (WebCore::StyleFillData::operator!=): (WebCore::StyleStopData::operator!=): (WebCore::StyleMiscData::create): (WebCore::StyleMiscData::copy): (WebCore::StyleMiscData::operator!=): (WebCore::StyleShadowSVGData::create): (WebCore::StyleShadowSVGData::copy): (WebCore::StyleShadowSVGData::operator!=): (WebCore::StyleResourceData::create): (WebCore::StyleResourceData::copy): (WebCore::StyleResourceData::operator!=): (WebCore::StyleInheritedResourceData::create): (WebCore::StyleInheritedResourceData::copy): (WebCore::StyleInheritedResourceData::operator!=):
svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addResource): (WebCore::SVGDocumentExtensions::removeResource):
svg/SVGDocumentExtensions.h:
svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):

3:23 AM Changeset in webkit [57574] by eric@webkit.org

9 edits
2 adds in trunk

2010-04-14 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels must take PACK_ALIGNMENT into account
https://bugs.webkit.org/show_bug.cgi?id=34718

fast/canvas/webgl/read-pixels-expected.txt: Verify pixelStorei and readPixels.
fast/canvas/webgl/read-pixels.html: Ditto.

2010-04-14 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels must take PACK_ALIGNMENT into account
https://bugs.webkit.org/show_bug.cgi?id=34718

Test: fast/canvas/webgl/read-pixels.html

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Init members to support pack_alignment. (WebCore::WebGLRenderingContext::pixelStorei): Save pack/unpack_alignment. (WebCore::WebGLRenderingContext::readPixels): Validate enum and deal with pack_alignment.
html/canvas/WebGLRenderingContext.h: Add members to support pack_alignment.
platform/graphics/GraphicsContext3D.h: Refactor readPixels.
platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.

2010-04-14 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels must take PACK_ALIGNMENT into account
https://bugs.webkit.org/show_bug.cgi?id=34718

src/GraphicsContext3D.cpp: Refactor readPixels.
src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): Temporarily disable pack alignment for glReadPixels. (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.

3:11 AM Changeset in webkit [57573] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-04-14 Nicolas Weber <thakis@chromium.org>

Reviewed by Gustavo Noronha Silva.

Remove passing test from Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=34287

platform/mac/Skipped: video-cookie.html seems to be passing, so remove it from Skipped list.

2:00 AM Changeset in webkit [57572] by eric@webkit.org

6 edits in trunk/WebKitTools

2010-04-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach webkit-patch how to handle revisions missing ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=37519

Make commit_info_for_revision return None when revision
is missing a ChangeLog. Previously we would throw an array index
exception.
Teach callers how to handle None.

Scripts/webkitpy/common/checkout/api.py:
Scripts/webkitpy/common/checkout/api_unittest.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/queries.py:
Scripts/webkitpy/tool/commands/sheriffbot.py:

1:51 AM Changeset in webkit [57571] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-04-14 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Re-write testProfilerTab to match the new implementation.

https://bugs.webkit.org/show_bug.cgi?id=37516

src/js/Tests.js: (.TestSuite.prototype.testProfilerTab.findDisplayedNode): (.TestSuite.prototype.testProfilerTab.findVisibleView): (.TestSuite.prototype.testProfilerTab):

12:34 AM Changeset in webkit [57570] by alex

2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/audio-data-url.html
https://bugs.webkit.org/show_bug.cgi?id=37564

platform/gtk/Skipped:

12:15 AM Changeset in webkit [57569] by alex

2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping plugins/update-widgets-crash.html
https://bugs.webkit.org/show_bug.cgi?id=37562

platform/gtk/Skipped:

12:03 AM Changeset in webkit [57568] by alex

2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/video-seeking.html
https://bugs.webkit.org/show_bug.cgi?id=37551

Skipping media/video-timeupdate-reverse-play.html
https://bugs.webkit.org/show_bug.cgi?id=37552

Skipping media/video-played-reset.html
https://bugs.webkit.org/show_bug.cgi?id=37556

Skipping http/tests/misc/image-blocked-src-change.html
https://bugs.webkit.org/show_bug.cgi?id=37557

Skipping inspector/console-clear.html
https://bugs.webkit.org/show_bug.cgi?id=37558

Skipping inspector/console-format-collections.html
https://bugs.webkit.org/show_bug.cgi?id=37559

Skipping svg/dom/SVGScriptElement/script-set-href.svg
https://bugs.webkit.org/show_bug.cgi?id=37560

platform/gtk/Skipped:

Apr 13, 2010:

11:36 PM Changeset in webkit [57567] by alex

2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping svg/custom/use-instanceRoot-as-event-target.xhtml
https://bugs.webkit.org/show_bug.cgi?id=37544

Skipping plugins/setProperty.html
https://bugs.webkit.org/show_bug.cgi?id=37545

Skipping media/audio-delete-while-slider-thumb-clicked.html
https://bugs.webkit.org/show_bug.cgi?id=37546

Skipping media/video-currentTime-set2.html
https://bugs.webkit.org/show_bug.cgi?id=37547

Skipping media/video-seekable.html
https://bugs.webkit.org/show_bug.cgi?id=37548

Skipping media/video-currentTime-set.html
https://bugs.webkit.org/show_bug.cgi?id=37549

Skipping fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html
https://bugs.webkit.org/show_bug.cgi?id=37550

Skipping media/video-seeking.html
https://bugs.webkit.org/show_bug.cgi?id=37551

Skipping media/video-timeupdate-reverse-play.html
https://bugs.webkit.org/show_bug.cgi?id=37552

platform/gtk/Skipped:

11:22 PM Changeset in webkit [57566] by Adam Roben

2 edits in trunk/LayoutTests

Skip xss-DENIED-iframe-src-alias.html on Windows

<http://webkit.org/b/37096> tracks making this test not time out.

Reviewed by Eric Seidel.

platform/win/Skipped:

11:13 PM Changeset in webkit [57565] by Adam Roben

2 edits in trunk/LayoutTests

Update Windows results for text-control-intrinsic-widths.html

<http://webkit.org/b/37091> tracks deciding whether these results are
better than the previous ones or not.

Reviewed by Eric Seidel.

platform/win/fast/forms/text-control-intrinsic-widths-expected.txt:

11:12 PM Changeset in webkit [57564] by krit@webkit.org

2 edits in trunk/WebCore

2010-04-13 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r57511): many new graphics / svg related leaks
https://bugs.webkit.org/show_bug.cgi?id=37527

The content of a HashMap was not correctly deleted. Fixed this
in the DTor and in invalidateClient of RenderSVGResourceClipper.

rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::invalidateClient):

11:12 PM Changeset in webkit [57563] by Adam Roben

1 edit
1 add in trunk/LayoutTests

Add Windows failing results for mouse-drag-from-frame-to-other-frame.html

<http://webkit.org/b/37494> tracks fixing this test.

Reviewed by Eric Seidel.

platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Added.

11:11 PM Changeset in webkit [57562] by Adam Roben

1 edit
1 add in trunk/LayoutTests

Add Windows failing results for font-face-opentype.html

<http://webkit.org/b/37089> tracks fixing this test.

Reviewed by Eric Seidel.

platform/win/fast/css/font-face-opentype-expected.txt: Added.

11:09 PM Changeset in webkit [57561] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)
https://bugs.webkit.org/show_bug.cgi?id=33297

This is an experiment. The bots have been green for
a while. We'll see if adding them under sheriff-bot protection
will keep them green.

Scripts/webkitpy/common/net/buildbot.py:
Scripts/webkitpy/common/net/buildbot_unittest.py:

10:56 PM Changeset in webkit [57560] by darin@chromium.org

3 edits in trunk/LayoutTests

2010-04-13 Darin Fisher <darin@chromium.org>

Update skipped lists for failing tests:
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

platform/mac-tiger/Skipped:
platform/qt/Skipped:

10:29 PM Changeset in webkit [57559] by eric@webkit.org

12 edits in trunk

2010-04-13 Zhenyao Mo <zmo@google.com>

Reviewed by Oliver Hunt.

Fix a potential integer overflow in WebGL*Array::slice()
https://bugs.webkit.org/show_bug.cgi?id=37466

fast/canvas/webgl/array-unit-tests-expected.txt: Add tests that would cause overflow without this fix, but work fine with this fix.
fast/canvas/webgl/array-unit-tests.html: Ditto.

2010-04-13 Zhenyao Mo <zmo@google.com>

Reviewed by Oliver Hunt.

Fix a potential integer overflow in WebGL*Array::slice()
https://bugs.webkit.org/show_bug.cgi?id=37466

html/canvas/WebGLArray.h: (WebCore::WebGLArray::clampOffsetAndNumElements): Input parameter "offset"'s semantic changed from in bytes from buffer to in elements from array view; calculate offset in bytes from buffer inside the function, avoiding overflow.
html/canvas/WebGLByteArray.cpp: (WebCore::WebGLByteArray::slice): Changed according to new semantic of WebCore::WebGLArray::clampOffsetAndNumElements.
html/canvas/WebGLFloatArray.cpp: (WebCore::WebGLFloatArray::slice): Ditto.
html/canvas/WebGLIntArray.cpp: (WebCore::WebGLIntArray::slice): Ditto.
html/canvas/WebGLShortArray.cpp: (WebCore::WebGLShortArray::slice): Ditto.
html/canvas/WebGLUnsignedByteArray.cpp: (WebCore::WebGLUnsignedByteArray::slice): Ditto.
html/canvas/WebGLUnsignedIntArray.cpp: (WebCore::WebGLUnsignedIntArray::slice): Ditto.
html/canvas/WebGLUnsignedShortArray.cpp: (WebCore::WebGLUnsignedShortArray::slice): Ditto.

9:52 PM Changeset in webkit [57558] by darin@chromium.org

6 edits
4 adds in trunk

2010-04-13 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

If the browsing context's session history contains only one Document,
and that was the about:blank Document created when the browsing context
was created, then the navigation must be done with replacement enabled.

https://bugs.webkit.org/show_bug.cgi?id=37126

Tests: fast/loader/frame-location-change-not-added-to-history.html

fast/loader/frame-src-change-not-added-to-history.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::findFrameForNavigation):
loader/HistoryController.cpp: (WebCore::HistoryController::currentItemShouldBeReplaced):
loader/HistoryController.h:

9:29 PM Changeset in webkit [57557] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <eric@webkit.org>

Unreviewed, just fixing a constant in the Rietveld unit test.

Scripts/webkitpy/common/net/rietveld_unittest.py

9:12 PM Changeset in webkit [57556] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <eric@webkit.org>

Unreviewed, just adding missing Mock to fix python tests.

Scripts/webkitpy/tool/mocktool.py:

5:29 PM Changeset in webkit [57555] by ggaren@apple.com

8 edits in trunk

Separated a DOMWrapperWorld's behavior of keeping wrappers alive from
its own lifetime, so a DOMWrapperWorld's controller can throw away
its wrappers even before its refcount reaches 0.

Reviewed by Oliver Hunt.

WebCore:

WebCore.base.exp:
bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::registerWorld):
(WebCore::DOMWrapperWorld::unregisterWorld):

bindings/js/DOMWrapperWorld.h: Factored out DOMWrapperWorld registration

and unregistration into helper functions, so unregistering could be done manually.

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::destroyWindowShell): Added an ASSERT to match
similar code.

WebKit/mac:

WebView/WebScriptWorld.h:
WebView/WebScriptWorld.mm:

(-[WebScriptWorld unregisterWorld]): Exported this function through WebKit.

5:28 PM Changeset in webkit [57554] by mrowe@apple.com

2 edits in trunk/LayoutTests

Update the test results after r57544.

http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers-expected.txt:

5:25 PM Changeset in webkit [57553] by alex

2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Skipping fast/js/kde/string-1-n.html,
See https://bugs.webkit.org/show_bug.cgi?id=37532

Skipping fast/js/kde/string-2-n.html.
https://bugs.webkit.org/show_bug.cgi?id=37534

Skipping inspector/console-format.html
https://bugs.webkit.org/show_bug.cgi?id=37535

Skipping media/video-reverse-play-duration.html
https://bugs.webkit.org/show_bug.cgi?id=37536

Skipping plugins/round-trip-npobject.html
https://bugs.webkit.org/show_bug.cgi?id=37537

Skipping svg/custom/use-on-clip-path-with-transformation.svg
https://bugs.webkit.org/show_bug.cgi?id=37539

Skipping http/tests/security/xss-DENIED-mime-type-execute-as-html.html
https://bugs.webkit.org/show_bug.cgi?id=37540

platform/gtk/Skipped:

5:23 PM Changeset in webkit [57552] by ojan@chromium.org

11 edits
1 copy
2 adds in trunk/WebKitTools

2010-04-13 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

Add experimental prototype Rietveld integration to webkit-patch upload
https://bugs.webkit.org/show_bug.cgi?id=37418

This patch adds bare-bones integrtion with Rietveld for code reviews.
The behavior is hidden behind the --fancy-review command line flag.
Currently, there's no support for uploading more than one patch per
issue (which is a nice feature of Rietveld). The plan is to play with
this for a bit and see if it's useful.

Modified from Adam's original patch to autoinstall the rietveld upload script.

Scripts/webkitpy/common/config/init.py:
Scripts/webkitpy/common/net/rietveld.py: Added.
Scripts/webkitpy/common/net/rietveld_unitttest.py: Added.
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/commands/upload_unittest.py:
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/steps/init.py:
Scripts/webkitpy/tool/steps/options.py:
Scripts/webkitpy/tool/steps/postcodereview.py: Added.
Scripts/webkitpy/tool/steps/postdiff.py:

5:22 PM Changeset in webkit [57551] by weinig@apple.com

1 edit
1 add in trunk/WebKitTools

Add Makefile to MiniBrowser.

Rubber-stamped by Mark Rowe.

MiniBrowser/Makefile: Added.

4:54 PM Changeset in webkit [57550] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <eric@webkit.org>

Unreviewed, just adding a sanity check.

Add check to make sure commit-queue can never commit too short a message
https://bugs.webkit.org/show_bug.cgi?id=37528

The commit-queue made bogus messages here:
http://trac.webkit.org/changeset/57532
http://trac.webkit.org/changeset/57534

This was a regression caused by adding unicode parsing for
our ChangeLog files. Popen does not seem to play nice with
unicode strings.

I'm also adding an "assert" to make sure short ChangeLogs never happen again.

Scripts/webkitpy/common/system/executive.py:
- Cast input to strings before passing to POpen
Scripts/webkitpy/tool/steps/commit.py:
- Validate that commit messages are not to short.

4:51 PM Changeset in webkit [57549] by weinig@apple.com

4 edits in trunk/WebKit2

Fix reported leaks when quitting MiniBrowser with open pages.

Reviewed by Anders Carlsson.

WebProcess/WebPage/WebPage.h: Make close() public.
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::removeWebPage):
(WebKit::WebProcess::didClose): If the UIProcess disappears, close
the live pages in an effort to not leak.

WebProcess/WebProcess.h:

4:30 PM Changeset in webkit [57548] by weinig@apple.com

5 edits in trunk/WebKit2

Do a JS collection and clear the memory cache to improve leaks output
when exiting. Only do this in debug builds as it is slow.

Reviewed by Anders Carlsson.

UIProcess/API/mac/WKView.h:
UIProcess/WebProcessProxy.cpp:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::shutdown):
(WebKit::WebProcess::didClose):

4:29 PM April 2010 Meeting edited by yuzo@google.com

(diff)

4:22 PM Changeset in webkit [57547] by weinig@apple.com

2 edits in trunk/WebKit2

Post a null event after calling [NSApp stop] to flush the run loop
and finish teardown.

Reviewed by Adele Peterson.

Platform/mac/RunLoopMac.mm:

(RunLoop::stop):

4:20 PM CommitterTips edited by yuzo@google.com

(diff)

4:19 PM Changeset in webkit [57546] by Adam Roben

2 edits in trunk/WebKitTools

Robustify new-run-webkit-tests against paths with spaces in them

Reviewed by Eric Seidel.

Scripts/webkitpy/layout_tests/port/apache_http_server.py:

(LayoutTestApacheHttpd.init): Quote all paths that we pass to
Apache to ensure that paths with spaces in them are interpreted
correctly.

4:04 PM Changeset in webkit [57545] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed fix, update platform specific expected file after r57534.

platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.

3:58 PM Changeset in webkit [57544] by chang.shu@nokia.com

5 edits
2 adds in trunk

2010-04-13 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=34653

Based on W3C spec and Firefox behavior, while invoking XHR Send with parameter
as String, the charset in Content-Type should be forced to set to UTF-8.

Test: http/tests/xmlhttprequest/request-encoding2.html

platform/network/HTTPParsers.cpp: (WebCore::extractCharsetFromMediaType): (WebCore::findCharsetInMediaType):
platform/network/HTTPParsers.h:
xml/XMLHttpRequest.cpp: (WebCore::setCharsetInMediaType): (WebCore::XMLHttpRequest::send):

2010-04-13 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Fisher.

Added test for forcing UTF-8 charset.
https://bugs.webkit.org/show_bug.cgi?id=34653

http/tests/xmlhttprequest/request-encoding2-expected.txt: Added.
http/tests/xmlhttprequest/request-encoding2.html: Added.

3:55 PM Changeset in webkit [57543] by alex

2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Skipping more new tests, we still do not have results. Remove test
that does not exist anymore:
svg/custom/clip-path-display-none-child.svg

platform/gtk/Skipped:

3:50 PM Changeset in webkit [57542] by Csaba Osztrogonác

2 edits in trunk/WebKitTools

Unreviewed buildfix after r57537.

DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added.

3:44 PM Changeset in webkit [57541] by alex

2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Skipping fast/history/multiple-classes-visited.html test,
See https://bugs.webkit.org/show_bug.cgi?id=37526

platform/gtk/Skipped:

3:43 PM Changeset in webkit [57540] by weinig@apple.com

3 edits
1 copy in trunk/WebKitTools

Make building new webkit API and MiniBrowser a little easier.

Reviewed by Maciej Stachowiak.

Scripts/build-webkit: Make building with --webkit2 build the

MiniBrowser as well and tell you how to use it.

Scripts/run-minibrowser: Copied from Scripts/run-safari.
Scripts/webkitdirs.pm: Add runMiniBrowser function.

3:34 PM Changeset in webkit [57539] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Skip new test introduced in r57530, because of
missing layoutTestController.evaluateScriptInIsolatedWorld()

platform/qt/Skipped:
- storage/statement-error-callback-isolated-world.html skipped.
- storage/statement-success-callback-isolated-world.html skipped.
- storage/transaction-callback-isolated-world.html skipped.
- storage/transaction-error-callback-isolated-world.html skipped.

3:31 PM Changeset in webkit [57538] by alex

2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Skipping new tests, we still do not have results.

platform/gtk/Skipped:

3:23 PM Changeset in webkit [57537] by timothy@apple.com

24 edits
2 adds in trunk

SecurityOrigin needs a way to remove individual OriginAccessEntries
https://bugs.webkit.org/show_bug.cgi?id=37449

Reviewed by Dave Hyatt.

WebCore:

Test: http/tests/xmlhttprequest/origin-whitelisting-removal.html

WebCore.base.exp: Added SecurityOrigin::removeOriginAccessWhitelistEntry.
page/OriginAccessEntry.h:

(WebCore::OriginAccessEntry::protocol): Added. Returns m_protocol.
(WebCore::OriginAccessEntry::host): Added. Returns m_host.
(WebCore::OriginAccessEntry::subdomainSettings): Added. Returns m_subdomainSettings.
(WebCore::operator==): Added. Compares OriginAccessEntry.
(WebCore::operator!=): Ditto.

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::addOriginAccessWhitelistEntry): Use the add method to prevent a
second hash lookup.
(WebCore::SecurityOrigin::removeOriginAccessWhitelistEntry): Added. Find a matching
OriginAccessEntry and remove it.

page/SecurityOrigin.h: Added removeOriginAccessWhitelistEntry.

WebKit/mac:

WebView/WebView.mm:

(+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
Call SecurityOrigin::removeOriginAccessWhitelistEntry.

WebView/WebViewPrivate.h: Added _removeOriginAccessWhitelistEntryWithSourceOrigin.

WebKit/win:

Interfaces/IWebViewPrivate.idl:
WebView.cpp:

(WebView::removeOriginAccessWhitelistEntry): Call SecurityOrigin::removeOriginAccessWhitelistEntry.

WebView.h: Added removeOriginAccessWhitelistEntry.

WebKitTools:

DumpRenderTree/LayoutTestController.cpp:

(removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry.
(LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry.

DumpRenderTree/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::removeOriginAccessWhitelistEntry): Added.

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.

DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::removeOriginAccessWhitelistEntry): Added.

DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::whiteListAccessFromOrigin): FIXME to implement.
(LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.

LayoutTests:

http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt: Added.
http/tests/xmlhttprequest/origin-whitelisting-removal.html: Added.
platform/gtk/Skipped: Added origin-whitelisting-removal.html.
platform/qt/Skipped: Ditto.

3:23 PM Changeset in webkit [57536] by timothy@apple.com

1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py

Make Joseph Pecoraro a reviewer.

3:15 PM Changeset in webkit [57535] by timothy@apple.com

40 edits in trunk

Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.

SecurityOrigin needs a way to remove individual OriginAccessEntries
https://bugs.webkit.org/show_bug.cgi?id=37449

Reviewed by Dave Hyatt.

WebCore:

WebCore.base.exp:
page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::addOriginAccessWhitelistEntry):
(WebCore::SecurityOrigin::resetOriginAccessWhitelists):

page/SecurityOrigin.h:

WebKit/chromium:

src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::whiteListAccessFromOrigin):
(WebKit::WebSecurityPolicy::resetOriginAccessWhiteLists):

WebKit/gtk:

webkit/webkitprivate.cpp:

(webkit_white_list_access_from_origin):
(webkit_reset_origin_access_white_lists):

WebKit/mac:

WebView/WebView.mm:

(+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
(+[WebView _resetOriginAccessWhitelists]):

WebView/WebViewPrivate.h:

WebKit/qt:

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::whiteListAccessFromOrigin):
(DumpRenderTreeSupportQt::resetOriginAccessWhiteLists):

WebKit/win:

Interfaces/IWebViewPrivate.idl:
WebView.cpp:

(WebView::addOriginAccessWhitelistEntry):
(WebView::resetOriginAccessWhitelists):

WebView.h:

WebKitTools:

DumpRenderTree/LayoutTestController.cpp:

(addOriginAccessWhitelistEntryCallback):
(LayoutTestController::staticFunctions):

DumpRenderTree/LayoutTestController.h:
DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::addOriginAccessWhitelistEntry):

DumpRenderTree/chromium/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: