⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 3, 2010:

11:52 PM Changeset in webkit [58736] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-05-03 Steven Lai <​steven_lai@asia.apple.com>

Reviewed by Brady Eidson.

Test hashchange() event is fired in asynchronous manner.
​https://bugs.webkit.org/show_bug.cgi?id=36201

  • fast/loader/hashchange-event-async-expected.txt: Added.
  • fast/loader/hashchange-event-async.html: Added.

2010-05-03 Steven Lai <​steven_lai@asia.apple.com>

Reviewed by Brady Eidson.

Reverted hashchange() event back to async.
(This change does not update HashChangeEvent to its new proposed interface)
​https://bugs.webkit.org/show_bug.cgi?id=36201
rdar://problem/7780794
rdar://problem/7761278 (partial fix)

Tests: fast/loader/hashchange-event-async.html

  • dom/Document.cpp: reverted hashchange() event back to async (WebCore::Document::enqueueHashchangeEvent):
11:14 PM Changeset in webkit [58735] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-05-03 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

Fixed a recent REGRESSION that caused svn-apply and -unapply to
skip over changes to the first file in a diff if leading junk was
present (like in an e-mail diff) and if the --force option was used.

​https://bugs.webkit.org/show_bug.cgi?id=38507

  • Scripts/svn-apply:
    • Removed the bit of code at the beginning of the patch() subroutine that checks for the "Index:" line at the beginning of a file diff (since the parsePatch() subroutine already checks this).
  • Scripts/svn-unapply:
    • Removed the bit of code at the beginning of the patch() subroutine that checks for the "Index:" line at the beginning of a file diff (since the parsePatch() subroutine already checks this).
9:44 PM Changeset in webkit [58734] by zecke@webkit.org
  • 3 edits in trunk/WebCore

[Cairo,WX] Stop leaking a FontPlatformData.

Allocate the FontPlatformData on the stack and fix
a memory leak by doing so.

2010-05-03 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber-stamped by Xan Lopez.

[Cairo,WX] Stop leaking a FontPlatformData.
​https://bugs.webkit.org/show_bug.cgi?id=37500

Stephan Aßmus pointed out that the pango font backend
is leaking memory and fixed it. The WX font backend
and the Cairo/Fontconfig backend have the same snippet
of code and are leaking memory as well. This commit is
fixing that.

  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::smallCapsFontData):
  • platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::smallCapsFontData):
9:16 PM Changeset in webkit [58733] by Chris Jerdonek
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed.

Adjusted the ChangeLog entry below for r58732 (bug 35804) to reflect
the fact that the change will not become active until the patch
for bug 38454 lands.

9:00 PM Changeset in webkit [58732] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

2010-05-03 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

The svn-apply and svn-unapply scripts now display an instructive
error message if the --binary flag is left off the "git diff" command
for diffs containing binary file differences.

​https://bugs.webkit.org/show_bug.cgi?id=35804

  • Scripts/VCSUtils.pm:
    • Adjusted parseDiffHeader() to exit with an appropriate error message if it encounters a line of the form "Binary files <path1> and <path2> differ".
7:53 PM Changeset in webkit [58731] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests: r58728 broke the buildbot logic for parsing the
output of the log; specifying --verbose should basically be equivalent
to --print everything, but instead it was equivalent to not specifying
--print and getting the default set. Now, --verbose acts as if
--print everything was implicitly specified as the default (you can
still override it if you specify both; this is a somewhat debatable
call).

​https://bugs.webkit.org/show_bug.cgi?id=38504

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
7:39 PM Changeset in webkit [58730] by Stephanie Lewis
  • 2 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=38368
<rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028
(return memory quicker).
Instead of returning everything but the smallest spans spread out
the spans kept over several size lists.

Reviewed by Geoff Garen.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::scavenge):

7:26 PM Changeset in webkit [58729] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests: Fix minor precedence bug introduced in r58728 where we printed
"-\n" 78 times instead of "-" 78 times followed by a single "\n".

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
6:59 PM Changeset in webkit [58728] by dpranke@chromium.org
  • 6 edits
    2 adds in trunk/WebKitTools

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: refactor a large chunk of the printing/logging
code out of run-webkit-tests py (almost 300 lines out of 1900).

This change also renames --log to --print (to be slightly more
descriptive). I've also added better help messages for printing.

The new code has unit tests!

There is still more code to be moved, but this patch is big enough as
it is. Namely, still to move are the printing of the actual results
and the timing statistics, which should move another 300-400 lines
out of the file.

Notable changes to run_webkit_tests.py beyond code simply moving:

  • MeteredStream is now hidden under the new printing.Printer class. All the references to self._meter now point to self._printer.
  • All logging configuration is done in printing.configure_logging()
  • Instead of using write() lambdas to control what is and isn't printed, we use separate methods on the printer object. This will make it easier to grep which print statements are printed under protection of each flag.
  • The print_results flag I added a few revs back to suppress printing in the unit tests has been replaced with --print nothing.
  • The ResultSummary class now stores the entire TestResult for each test, not just the actual result type.
  • summarize_unexpected_results() got moved from a method on TestRunner to a standalone function. This should move into a separate file along with the ResultSummary class and the TestResult class
  • The --trace option added recently has been replaced by '--print trace-everything' and '--print trace-unexpected'

​https://bugs.webkit.org/show_bug.cgi?id=38018

  • Scripts/new-run-webkit-tests:
    • update to new entry points in run_webkit_tests.py
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
    • fix a minor nit where we were printing an empty string where we didn't need to
  • Scripts/webkitpy/layout_tests/layout_package/printing.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Added
  • Scripts/webkitpy/layout_tests/port/test.py:
    • implement relative_test_filename() and expected_filename() so we can test printing unexpected results in a platform-neutral way
  • Scripts/webkitpy/run_webkit_test.py:
    • move a lot of the printing code into printing.py
    • change the signatures of the exported entry points for easier unit testing
  • Scripts/webkitpy/run_webkit_tests_unittest.py:
    • update w/ changes to run_webkit_tests entry points.
6:55 PM Changeset in webkit [58727] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-05-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Expose HTMLTokenizer yielding parameters
​https://bugs.webkit.org/show_bug.cgi?id=37023

Enables to set TimeDelay and ChunkSize for
HTMLTokenizer.

  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent):
6:37 PM Changeset in webkit [58726] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Fix expectation for fast/forms/searchfield-heights.html - IMAGE+TEXT
on Linux, IMAGE on win and mac.

  • platform/chromium/test_expectations.txt:
6:32 PM Changeset in webkit [58725] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Restore editing/pasteboard/paste-xml.xhtml as failing w/ a TEXT
failure (was failing prior to landing fix for 27751).

Mark editiing/selection/caret-rtl-2.html as failing w/ IMAGE; need
to investigate further.

Mark svg/text/kerning.svg as failing on mac w/ IMAGE as well as Linux.

  • platform/chromium/test_expectations.txt:
6:08 PM Changeset in webkit [58724] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dirk Pranke.

Roll back test expectations change, initially needed to land bug 27751.

  • platform/chromium/test_expectations.txt:
5:45 PM Changeset in webkit [58723] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild

5:42 PM Changeset in webkit [58722] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Roll in Chromium expectations from overrides file.

  • platform/chromium/test_expectations.txt:
5:35 PM Changeset in webkit [58721] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark the SVG test failures as linux-only.
Mark fast/forms/searchfield-heights.html as IMAGE+TEXT, not IMAGE.

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [58720] by andersca@apple.com
  • 3 edits in trunk/WebKit2

2010-05-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon Honeycutt.

[WebKit2] WKView should respond to WM_SHOWWINDOW messages
​https://bugs.webkit.org/show_bug.cgi?id=38496

  • UIProcess/win/WebView.cpp: (WebKit::WebView::wndProc): Add case for WM_SHOWWINDOW.

(WebKit::WebView::onShowWindowEvent):
Update the page visibility accordingly.

  • UIProcess/win/WebView.h:
5:07 PM Changeset in webkit [58719] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

And add one more Linux test (fast/forms/search-placeholder-value-changed.html)
from r58700. Plus, fix sorting of tests from that rev.

  • platform/chromium/test_expectations.txt:
5:03 PM Changeset in webkit [58718] by jamesr@google.com
  • 6 edits in trunk

2010-05-03 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

Clean up a few compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=38073

  • wtf/text/StringImpl.cpp: (WebCore::StringImpl::ascii):

2010-05-03 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

Clean up a few compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=38073

  • html/TextMetrics.h: (WebCore::TextMetrics::width):
  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.h:
5:01 PM Changeset in webkit [58717] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark yet more mac-specific tests as failling from r58700.

  • platform/chromium/test_expectations.txt:
4:48 PM Changeset in webkit [58716] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark more tests as failing from r58700 and change the sandbox test from SLOW to a
flaky PASS TIMEOUT.

  • platform/chromium/test_expectations.txt:
4:43 PM Changeset in webkit [58715] by Darin Adler
  • 3 edits in trunk/WebKit
  • English.lproj/Localizable.strings: Regenerated.
  • StringsNotToBeLocalized.txt: Updated for recent changes.
4:09 PM Changeset in webkit [58714] by andersca@apple.com
  • 10 edits in trunk/WebKit2

2010-05-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of PageClient::isPageVisible and pass visibility directly in setPageIsVisible
​https://bugs.webkit.org/show_bug.cgi?id=38493

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: Remove isPageVisible.


  • UIProcess/API/mac/WKView.mm: (isViewVisible): New function (moved here from PageClientImpl).


(-[WKView _updateVisibility]):
Call didChangeVisibility.


(-[WKView viewDidMoveToWindow]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
Call _updateVisibility.


  • UIProcess/DrawingAreaProxy.h: Rename didChangeVisibility to setPageIsVisible and add an isVisible parameter.


  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: (WebKit::DrawingAreaProxyUpdateChunk::setPageIsVisible): Don't call WebPageProxy::isVisible.
  • UIProcess/DrawingAreaProxyUpdateChunk.h:


  • UIProcess/PageClient.h: Remove isPageVisible.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h: Remove isVisible.
4:07 PM Changeset in webkit [58713] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark more editing/* tests from r58703 as failing. Also, (re-?) add the SVG tests again
as they do fail on some platforms.

  • platform/chromium/test_expectations.txt:
4:03 PM Changeset in webkit [58712] by barraclough@apple.com
  • 16 edits
    1 delete in trunk/JavaScriptCore

Rolling out r58114 - this introduced memory leaks of
AtomicStrings then workers terminated.

Reviewed by NOBODY (reverting previous commit).

(JSC::ThunkHelpers::stringImplDataOffset):

  • runtime/Identifier.cpp:

(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierCStringTranslator::equal):
(JSC::IdentifierCStringTranslator::translate):
(JSC::Identifier::add):
(JSC::IdentifierUCharBufferTranslator::hash):
(JSC::IdentifierUCharBufferTranslator::equal):
(JSC::IdentifierUCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):

  • runtime/Identifier.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:
  • wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):

  • wtf/WTFThreadData.h:

(JSC::IdentifierTable::remove):
(JSC::IdentifierTable::literalTable):
(WTF::WTFThreadData::atomicStringTable):

  • wtf/text/AtomicString.cpp:

(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable):
(WebCore::CStringTranslator::hash):
(WebCore::CStringTranslator::equal):
(WebCore::CStringTranslator::translate):
(WebCore::operator==):
(WebCore::AtomicString::add):
(WebCore::equal):
(WebCore::UCharBufferTranslator::hash):
(WebCore::UCharBufferTranslator::equal):
(WebCore::UCharBufferTranslator::translate):
(WebCore::HashAndCharactersTranslator::hash):
(WebCore::HashAndCharactersTranslator::equal):
(WebCore::HashAndCharactersTranslator::translate):
(WebCore::AtomicString::find):
(WebCore::AtomicString::remove):

  • wtf/text/AtomicStringTable.h: Removed.
  • wtf/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
(WebCore::equal):

  • wtf/text/StringImplBase.h:

(WTF::StringImplBase::StringImplBase):

3:46 PM Changeset in webkit [58711] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittently on Qt bot
Fails caused by layoutTestController.display() in fast/frames/flattening/frameset-flattening-subframe-resize.html
​https://bugs.webkit.org/show_bug.cgi?id=37334

  • platform/qt/Skipped:
    • fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix
    • fast/frames/flattening/frameset-flattening-subframesets.html unskipped, because it works.
3:37 PM Changeset in webkit [58710] by dumi@chromium.org
  • 3 edits
    5 adds in trunk/WebCore

Add the ability to auto-generate callbacks to all code generators.
​https://bugs.webkit.org/show_bug.cgi?id=38414

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp: Added.

(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
(WebCore::JSTestCallback::callbackWithClass1Param):
(WebCore::JSTestCallback::callbackWithClass2Param):

  • bindings/scripts/test/JS/JSTestCallback.h: Added.

(WebCore::JSTestCallback::create):

  • bindings/scripts/test/V8/JSTestCallback.cpp: Added.

(WebCore::V8TestCallback::V8TestCallback):
(WebCore::V8TestCallback::~V8TestCallback):
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):

  • bindings/scripts/test/V8/V8TestCallback.h: Added.

(WebCore::V8TestCallback::create):

  • bindings/scripts/test/TestCallback.idl: Added.
3:37 PM Changeset in webkit [58709] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Kevin Ollivier.

[wx] Implement scheduleDispatchFunctionsOnMainThread for wx port.
​https://bugs.webkit.org/show_bug.cgi?id=38480

3:34 PM Changeset in webkit [58708] by kevino@webkit.org
  • 1 edit in trunk/WebKit/wx/ChangeLog

Fix missing bug URL.

3:31 PM Changeset in webkit [58707] by kevino@webkit.org
  • 23 edits
    1 add in trunk

Reviewed by Kevin Ollivier.

[wx] Build and use Mac's ComplexTextController to support complex text in wx.
​https://bugs.webkit.org/show_bug.cgi?id=38482

3:27 PM Changeset in webkit [58706] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark the editing/* tests from r58703 as temporarily expected to fail
until the other half of the two-sided patch can land.

  • platform/chromium/test_expectations.txt:
3:18 PM Changeset in webkit [58705] by oliver@apple.com
  • 4 edits in trunk

2010-05-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Interpreter crashes due to incorrect refcounting of cached structures.
​https://bugs.webkit.org/show_bug.cgi?id=38491
rdar://problem/7926160

Make sure we ref/deref structures used for cached custom property getters

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):

2010-05-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Interpreter crashes due to incorrect refcounting of cached structures.
​https://bugs.webkit.org/show_bug.cgi?id=38491

Add test for cached structure chains used for custom getters.

  • fast/js/pic/cached-named-property-getter.html:
2:51 PM Changeset in webkit [58704] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Fix duplicate expectation, remove the SVG tests added in r58700.

  • platform/chromium/test_expectations.txt:
2:50 PM Changeset in webkit [58703] by abarth@webkit.org
  • 43 edits
    3 adds in trunk

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Tests that javascript cannot access clipboard.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • editing/execCommand/clipboard-access-expected.txt: Added.
  • editing/execCommand/clipboard-access.html: Added.
  • editing/execCommand/script-tests/clipboard-access.js: Added. (enabled): (whenEnabled):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

Test: editing/execCommand/clipboard-access.html

  • WebCore.base.exp:
  • editing/EditorCommand.cpp: (WebCore::supportedCopyCut): (WebCore::supportedPaste): (WebCore::createCommandMap):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setJavaScriptCanAccessClipboard):
  • page/Settings.h: (WebCore::Settings::javaScriptCanAccessClipboard):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
  • src/WebSettingsImpl.h:

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences javaScriptCanAccessClipboard]): (-[WebPreferences setJavaScriptCanAccessClipboard:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::javaScriptCanAccessClipboard): (WebPreferences::setJavaScriptCanAccessClipboard):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is enabled in test framework.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • DumpRenderTree/LayoutTestController.cpp: (setJavaScriptCanAccessClipboardCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::overridePreference):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
2:43 PM Changeset in webkit [58702] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark a sandbox test as SLOW and change one of the fast/forms tests I
just changed from IMAGE+TEXT->IMAGE back to IMAGE.

  • platform/chromium/test_expectations.txt:
2:34 PM Changeset in webkit [58701] by andersca@apple.com
  • 4 edits in trunk/WebKitTools

2010-05-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Maui MiniBrowser: Add an option to show/hide the web view
​https://bugs.webkit.org/show_bug.cgi?id=38486

  • MiniBrowser/win/BrowserWindow.cpp: (BrowserWindow::createWindow): Set the background brush to something other than null.

(BrowserWindow::onCommand):
Show and hide the web view accordingly.


  • MiniBrowser/win/MiniBrowser.rc:
  • MiniBrowser/win/resource.h: Add new menu item.
2:15 PM Changeset in webkit [58700] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Change expectations for some of the fast/forms tests that just started
failing from IMAGE+TEXT to just IMAGE, and add some failing SVG tests
so that we can get the bots to green up.

  • platform/chromium/test_expectations.txt:
1:45 PM Changeset in webkit [58699] by eric@webkit.org
  • 5 edits in trunk/WebKit/wx

2010-05-03 Kevin Watters <​kevinwatters@gmail.com>

Reviewed by Kevin Ollivier.

Provide access to GrantUniversalAccess to allow enabling of XSS support.

  • WebFrame.cpp: (wxWebFrame::GrantUniversalAccess):
  • WebFrame.h:
  • WebView.cpp: (wxWebView::GetParseMode): (wxWebView::GrantUniversalAccess):
  • WebView.h:
1:36 PM Changeset in webkit [58698] by yaar@chromium.org
  • 6 edits in trunk/LayoutTests

2010-05-03 Yaar Schnitman <​yaar@chromium.org>

Not Reviewed.

Preparing for chromium webkit roll 58626:TBD: Rebaselines
​https://bugs.webkit.org/show_bug.cgi?id=38485

  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [58697] by andersca@apple.com
  • 4 edits in trunk/WebKit2

2010-05-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Implement PageClient::isPageVisible on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=38483

  • UIProcess/PageClient.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::isPageVisible):
  • UIProcess/win/WebView.h:
1:12 PM Changeset in webkit [58696] by ap@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed a typo in ChangeLog.

1:04 PM Changeset in webkit [58695] by ap@apple.com
  • 3 edits
    5 adds in trunk

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=38285
<rdar://problem/7903453> REGRESSION: Javascript command window.open does not work in empty tab

Cannot be tested, because new windows created in DRT always have an opener, and thus inherit
its security origin. Only new windows and tabs created by browser chrome had this problem.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Moved updateSandboxFlags() call to the beginning, so that an initial document would get correct flags.

LayoutTests:

These tests don't verify that this bug is fixed (that cannpt be tested automatically),
but test closely related behavior that hasn't been covered before.

  • http/tests/security/resources/iframe-no-src.html: Added.
  • http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt: Added.
  • http/tests/security/sandbox-inherit-to-initial-document-2.html: Added.
  • http/tests/security/sandbox-inherit-to-initial-document-expected.txt: Added.
  • http/tests/security/sandbox-inherit-to-initial-document.html: Added.
12:51 PM Changeset in webkit [58694] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-03 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Darin Adler.

WebGL compile issue.
Added ExceptionCode.h to JSWebGLArrayBufferConstructor.cpp, for some reason it was missing.
​https://bugs.webkit.org/show_bug.cgi?id=38453

No new tests: compile fix.

  • bindings/js/JSWebGLArrayBufferConstructor.cpp:
12:47 PM Changeset in webkit [58693] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Fix Windows build.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::sendOutgoingMessage):

  • Shared/win/UpdateChunk.cpp:

(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):

  • Shared/win/UpdateChunk.h:

(WebKit::UpdateChunk::rect):

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyUpdateChunk.h:
  • UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp:

(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):

  • WebProcess/WebPage/win/DrawingAreaUpdateChunkWin.cpp:

(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):

  • WebProcess/win/WebProcessMain.cpp:
12:11 PM Changeset in webkit [58692] by yaar@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Yaar Schnitman <​yaar@chromium.org>

Not Reviewed.

Preparing for Chromium WebKit roll 58626:TBD
​https://bugs.webkit.org/show_bug.cgi?id=38479

  • platform/chromium/test_expectations.txt: added missing expectation
11:51 AM Changeset in webkit [58691] by yaar@chromium.org
  • 9 edits
    4 adds in trunk/LayoutTests

2010-05-03 Yaar Schnitman <​yaar@chromium.org>

Not Reviewed.

Added missing chromium baselines for svg text kerning
​https://bugs.webkit.org/show_bug.cgi?id=38476

  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • platform/chromium-win/svg/text/kerning-expected.checksum:
  • platform/chromium-win/svg/text/kerning-expected.png:
  • platform/chromium-win/svg/text/text-hkern-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-hkern-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:49 AM Changeset in webkit [58690] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-03 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r58685.
​http://trac.webkit.org/changeset/58685
​https://bugs.webkit.org/show_bug.cgi?id=38461

Broke a test on Gtk

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates):
11:23 AM Changeset in webkit [58689] by yaar@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Yaar Schnitman <​yaar@chromium.org>

Not Reviewed.

Preparing for chromium webkit roll 58626:TBD
​https://bugs.webkit.org/show_bug.cgi?id=38474

  • platform/chromium/test_expectations.txt: Added temporary expectations.
11:19 AM Changeset in webkit [58688] by andersca@apple.com
  • 10 edits in trunk/WebKit2

2010-04-30 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=38415
Have the WKView notify the DrawingAreaProxy when its visibility changes.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::isPageVisible):
  • UIProcess/API/mac/WKView.mm: (-[WKView viewDidMoveToWindow]): (-[WKView viewDidHide]): (-[WKView viewDidUnhide]):
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: (WebKit::DrawingAreaProxyUpdateChunk::DrawingAreaProxyUpdateChunk): (WebKit::DrawingAreaProxyUpdateChunk::didChangeVisibility):
  • UIProcess/DrawingAreaProxyUpdateChunk.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::isVisible):
  • UIProcess/WebPageProxy.h:
11:16 AM Changeset in webkit [58687] by yael.aharon@nokia.com
  • 7 edits in trunk

Use HTML5 number parsing in HTMLProgressElement
​https://bugs.webkit.org/show_bug.cgi?id=38434

Reviewed by Darin Adler.

WebCore:

Use parseToDoubleForNumberType instead of toDouble.
Throw an exception when the number is NaN or Infinity.

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::value):
(WebCore::HTMLProgressElement::setValue):
(WebCore::HTMLProgressElement::max):
(WebCore::HTMLProgressElement::setMax):

  • html/HTMLProgressElement.h:
  • html/HTMLProgressElement.idl:

LayoutTests:

  • fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js:
  • fast/dom/HTMLProgressElement/set-progress-properties-expected.txt:
11:12 AM Changeset in webkit [58686] by eric@webkit.org
  • 24 edits in trunk

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareSubmit): Call frame loader's dispatchWillSendSubmitEvent
  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchWillSendSubmitEvent): New empty method

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • efl/WebCoreSupport/FrameLoaderClientEfl.h: (WebCore::FrameLoaderClientEfl::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • public/WebFrameClient.h: (WebKit::WebFrameClient::willSendSubmitEvent): New empty method
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillSendSubmitEvent): Delegate to client
  • src/FrameLoaderClientImpl.h:

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientGtk.h: (WebKit::FrameLoaderClient::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientHaiku.h: (WebCore::FrameLoaderClientHaiku::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/WebFrameLoaderClient.h: (WebFrameLoaderClient::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientQt.h: (WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebFrame.h:

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebKitSupport/FrameLoaderClientWx.h: (WebCore::FrameLoaderClientWx::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h: (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
10:58 AM Changeset in webkit [58685] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-05-03 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] forgotten call to durationChanged in updateStates()
​https://bugs.webkit.org/show_bug.cgi?id=38461

Notify MediaPlayer if duration is known after playback started.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates):
10:28 AM Changeset in webkit [58684] by weinig@apple.com
  • 9 edits
    1 add
    4 deletes in trunk/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38471
Add generic callback mechanism

Reviewed by Anders Carlsson.

Added GenericCallback class replacing RenderTreeExternalRepresentationCallback
and ScriptReturnValueCallback.

Also,

  • Standardize C API callbacks to take the context last.
  • Standardize C API callbacks to not have the _f suffix (now the block variants have a _b suffix).
  • Re-write toWK and toRef methods as a set of template functions using the generic API->implementation mapping information.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame):
(callRunJavaScriptBlockAndRelease):
(disposeRunJavaScriptBlock):
(WKPageRunJavaScriptInMainFrame_b):
(WKPageRenderTreeExternalRepresentation):
(WKPageRenderTreeExternalRepresentation_b):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/GenericCallback.h: Added.

(WebKit::GenericCallback::create):
(WebKit::GenericCallback::~GenericCallback):
(WebKit::GenericCallback::performCallbackWithReturnValue):
(WebKit::GenericCallback::invalidate):
(WebKit::GenericCallback::callbackID):
(WebKit::GenericCallback::generateCallbackID):
(WebKit::GenericCallback::GenericCallback):

  • UIProcess/RenderTreeExternalRepresentationCallback.cpp: Removed.
  • UIProcess/RenderTreeExternalRepresentationCallback.h: Removed.
  • UIProcess/ScriptReturnValueCallback.cpp: Removed.
  • UIProcess/ScriptReturnValueCallback.h: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::didGetRenderTreeExternalRepresentation):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
10:25 AM Changeset in webkit [58683] by abarth@webkit.org
  • 1 delete in trunk/URLCore

Remove URLCore top-level directory. The diff wasn't clear where this folder was going and Darin Adler would prefer that we not put this code in a top-level directory.

10:24 AM Changeset in webkit [58682] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-03 Ryuan Choi <​ryuan.choi@gmail.com>

Reviewed by Darin Adler.

fixing build break due to clearWatch() when Geolocation feature is
disabled.

​https://bugs.webkit.org/show_bug.cgi?id=38091

no test because this is a build fix only

  • page/Geolocation.cpp: (WebCore::Geolocation::clearWatch):
10:09 AM Changeset in webkit [58681] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-03 Chris Jerdonek <Chris Jerdonek>

Reviewed by Daniel Bates.

Added a parseGitDiffHeader() subroutine to VCSUtils.pm that
parses any changes to the executable bit in a Git diff.

​https://bugs.webkit.org/show_bug.cgi?id=38425

This revision is more preparation towards adding "executable bit"
support to svn-apply and svn-unapply. No code is going "live" in
this change except for the new unit tests in test-webkitperl.

  • Scripts/VCSUtils.pm:
    • Added isExecutable() to determine whether a file mode has the executable bit set or not.
    • Added parseGitDiffHeader() to parse the header of a Git diff.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Added.
    • Added unit tests for parseGitDiffHeader().
10:00 AM Changeset in webkit [58680] by abarth@webkit.org
  • 2 adds in trunk/URLCore

Add empty folder to house URL parser
​https://bugs.webkit.org/show_bug.cgi?id=38470

Reviewed by Darin Adler.

Add URLCore directory.

9:56 AM Changeset in webkit [58679] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-03 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by Holger Freyther.

[Gtk] Fix leaking the FontPlatformData instance used to create the the
small caps font data.
​https://bugs.webkit.org/show_bug.cgi?id=37500

No new tests needed.

  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::smallCapsFontData):
    • Use a stack allocated FontPlatformData instead of a heap allocated one that is never freed.
9:37 AM Changeset in webkit [58678] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-03 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: support webGL
​https://bugs.webkit.org/show_bug.cgi?id=35388

Added support GraphicsContext3D to GraphicsLayer.
Added paint method to GraphicsContext3D for Qt platform that
uses drawTexture() when QGLWidget is used as viewport of
QGraphicsWebView.
Fine-tuned texture and handling and image to texture conversion to
work also when drawTexture() blitting is used.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::paint): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::): (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsToGraphicsContext3D): (WebCore::GraphicsLayerQt::setGraphicsContext3DNeedsDisplay):
  • platform/graphics/qt/GraphicsLayerQt.h:
9:20 AM Changeset in webkit [58677] by abarth@webkit.org
  • 2 edits in trunk

2010-05-03 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add some more Chromium-specific files to gitignore
​https://bugs.webkit.org/show_bug.cgi?id=38469

These files are generated as part of the update-webkit --chromium
script.

  • .gitignore:
8:59 AM Changeset in webkit [58676] by Csaba Osztrogonác
  • 1 edit
    14 adds in trunk/LayoutTests

Unreviewed. Qt specific expected files added after r58675.

  • platform/qt/editing/pasteboard/4944770-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/5028447-expected.txt: Added.
  • platform/qt/editing/pasteboard/5089327-expected.txt: Added.
  • platform/qt/editing/pasteboard/5601583-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-text-013-expected.txt: Added.
  • platform/qt/editing/pasteboard/select-element-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/testcase-9507-expected.txt: Added.
  • platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
  • platform/qt/editing/pasteboard/unrendered-br-expected.txt: Added.
8:39 AM Changeset in webkit [58675] by robert@webkit.org
  • 105 edits
    4 adds in trunk/LayoutTests

2010-05-03 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed. Qt specific expected files added and updated.

[Qt] Unskip editing/pasteboard tests that fail due to 'x,y' differences
​https://bugs.webkit.org/show_bug.cgi?id=38435

  • platform/qt/editing/pasteboard/3976872-expected.txt:
  • platform/qt/editing/pasteboard/4076267-3-expected.txt:
  • platform/qt/editing/pasteboard/4242293-expected.txt:
  • platform/qt/editing/pasteboard/4631972-expected.txt:
  • platform/qt/editing/pasteboard/4641033-expected.txt:
  • platform/qt/editing/pasteboard/4700297-expected.txt:
  • platform/qt/editing/pasteboard/4806874-expected.txt:
  • platform/qt/editing/pasteboard/4840662-expected.txt:
  • platform/qt/editing/pasteboard/4944770-1-expected.txt:
  • platform/qt/editing/pasteboard/4944770-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/4989774-expected.txt:
  • platform/qt/editing/pasteboard/5006779-expected.txt:
  • platform/qt/editing/pasteboard/5027857-expected.txt:
  • platform/qt/editing/pasteboard/5028447-expected.txt: Added.
  • platform/qt/editing/pasteboard/5032095-expected.txt:
  • platform/qt/editing/pasteboard/5065605-expected.txt:
  • platform/qt/editing/pasteboard/5071074-2-expected.txt:
  • platform/qt/editing/pasteboard/5071074-expected.txt:
  • platform/qt/editing/pasteboard/5075944-2-expected.txt:
  • platform/qt/editing/pasteboard/5075944-3-expected.txt:
  • platform/qt/editing/pasteboard/5075944-expected.txt:
  • platform/qt/editing/pasteboard/5089327-expected.txt: Added.
  • platform/qt/editing/pasteboard/5134759-expected.txt:
  • platform/qt/editing/pasteboard/5156401-1-expected.txt:
  • platform/qt/editing/pasteboard/5245519-expected.txt:
  • platform/qt/editing/pasteboard/5247341-expected.txt:
  • platform/qt/editing/pasteboard/5368833-expected.txt:
  • platform/qt/editing/pasteboard/5478250-expected.txt:
  • platform/qt/editing/pasteboard/5483567-expected.txt:
  • platform/qt/editing/pasteboard/5601583-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/5780697-2-expected.txt:
  • platform/qt/editing/pasteboard/7955-expected.txt:
  • platform/qt/editing/pasteboard/8145-1-expected.txt:
  • platform/qt/editing/pasteboard/8145-2-expected.txt:
  • platform/qt/editing/pasteboard/8145-3-expected.txt:
  • platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
  • platform/qt/editing/pasteboard/cut-text-001-expected.txt:
  • platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/displaced-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/display-block-on-spans-expected.txt:
  • platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
  • platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-1-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-3-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-4-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-3-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-4-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-5-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-list-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-table-expected.txt:
  • platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/merge-start-list-expected.txt:
  • platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-4038267-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-1-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-2-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-3-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-line-endings-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-004-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/qt/editing/pasteboard/paste-list-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-pre-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-pre-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-cells-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-004-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-009-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-010-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-011-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-012-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-013-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-text-014-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-015-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-016-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-017-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-018-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-019-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
  • platform/qt/editing/pasteboard/pasting-object-expected.txt:
  • platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
  • platform/qt/editing/pasteboard/quirks-mode-br-1-expected.txt:
  • platform/qt/editing/pasteboard/select-element-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/styled-element-markup-expected.txt:
  • platform/qt/editing/pasteboard/testcase-9507-expected.txt: Added.
  • platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
  • platform/qt/editing/pasteboard/unrendered-br-expected.txt: Added.

2010-05-03 Robert Hogan <​robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Unskip editing/pasteboard tests that fail due to 'x,y' differences

​https://bugs.webkit.org/show_bug.cgi?id=38435

Unskip a large number of editing/pasteboard tests that fail only due
to rendertree differences in the height/width of rendered text.

Reduce the skipped editing/pasteboard tests to those that fail for
a good reason and add some initial commentary on each.

Unskip:

editing/pasteboard/3976872.html
editing/pasteboard/4076267-3.html
editing/pasteboard/4242293.html
editing/pasteboard/4631972.html
editing/pasteboard/4641033.html
editing/pasteboard/4700297.html
editing/pasteboard/4840662.html
editing/pasteboard/4944770-1.html
editing/pasteboard/4944770-2.html
editing/pasteboard/4989774.html
editing/pasteboard/5006779.html
editing/pasteboard/5027857.html
editing/pasteboard/5028447.html
editing/pasteboard/5032095.html
editing/pasteboard/5065605.html
editing/pasteboard/5071074-2.html
editing/pasteboard/5071074.html
editing/pasteboard/5075944-2.html
editing/pasteboard/5075944-3.html
editing/pasteboard/5075944.html
editing/pasteboard/5089327.html
editing/pasteboard/5134759.html
editing/pasteboard/5156401-1.html
editing/pasteboard/5245519.html
editing/pasteboard/5247341.html
editing/pasteboard/5368833.html
editing/pasteboard/5478250.html
editing/pasteboard/5483567.html
editing/pasteboard/5601583-1.html
editing/pasteboard/5780697-2.html
editing/pasteboard/7955.html
editing/pasteboard/8145-1.html
editing/pasteboard/8145-2.html
editing/pasteboard/8145-3.html
editing/pasteboard/copy-paste-bidi.html
editing/pasteboard/cut-text-001.html
editing/pasteboard/displaced-generic-placeholder.html
editing/pasteboard/displaced-placeholder.html
editing/pasteboard/display-block-on-spans.html
editing/pasteboard/emacs-cntl-y-001.html
editing/pasteboard/innerText-inline-table.html
editing/pasteboard/interchange-newline-1.html
editing/pasteboard/interchange-newline-3.html
editing/pasteboard/interchange-newline-4.html
editing/pasteboard/merge-after-delete-1.html
editing/pasteboard/merge-after-delete-2.html
editing/pasteboard/merge-after-delete.html
editing/pasteboard/merge-end-1.html
editing/pasteboard/merge-end-2.html
editing/pasteboard/merge-end-3.html
editing/pasteboard/merge-end-4.html
editing/pasteboard/merge-end-5.html
editing/pasteboard/merge-end-blockquote.html
editing/pasteboard/merge-end-borders.html
editing/pasteboard/merge-end-list.html
editing/pasteboard/merge-end-table.html
editing/pasteboard/merge-start-blockquote.html
editing/pasteboard/merge-start-list.html
editing/pasteboard/paste-4035648-fix.html
editing/pasteboard/paste-4038267-fix.html
editing/pasteboard/paste-4039777-fix.html
editing/pasteboard/paste-blockquote-1.html
editing/pasteboard/paste-blockquote-2.html
editing/pasteboard/paste-blockquote-3.html
editing/pasteboard/paste-blockquote-after-blockquote.html
editing/pasteboard/paste-blockquote-into-blockquote-2.html
editing/pasteboard/paste-blockquote-into-blockquote-3.html
editing/pasteboard/paste-blockquote-into-blockquote-4.html
editing/pasteboard/paste-blockquote-into-blockquote.html
editing/pasteboard/paste-line-endings-001.html
editing/pasteboard/paste-line-endings-002.html
editing/pasteboard/paste-line-endings-003.html
editing/pasteboard/paste-line-endings-004.html
editing/pasteboard/paste-line-endings-005.html
editing/pasteboard/paste-line-endings-006.html
editing/pasteboard/paste-line-endings-007.html
editing/pasteboard/paste-line-endings-008.html
editing/pasteboard/paste-line-endings-009.html
editing/pasteboard/paste-line-endings-010.html
editing/pasteboard/paste-list-001.html
editing/pasteboard/paste-match-style-001.html
editing/pasteboard/paste-match-style-002.html
editing/pasteboard/paste-pre-001.html
editing/pasteboard/paste-pre-002.html
editing/pasteboard/paste-table-001.html
editing/pasteboard/paste-table-003.html
editing/pasteboard/paste-table-cells.html
editing/pasteboard/paste-text-002.html
editing/pasteboard/paste-text-003.html
editing/pasteboard/paste-text-004.html
editing/pasteboard/paste-text-005.html
editing/pasteboard/paste-text-006.html
editing/pasteboard/paste-text-007.html
editing/pasteboard/paste-text-009.html
editing/pasteboard/paste-text-010.html
editing/pasteboard/paste-text-011.html
editing/pasteboard/paste-text-012.html
editing/pasteboard/paste-text-013.html
editing/pasteboard/paste-text-014.html
editing/pasteboard/paste-text-015.html
editing/pasteboard/paste-text-016.html
editing/pasteboard/paste-text-017.html
editing/pasteboard/paste-text-018.html
editing/pasteboard/paste-text-019.html
editing/pasteboard/paste-text-at-tabspan-002.html
editing/pasteboard/paste-text-at-tabspan-003.html
editing/pasteboard/paste-unrendered-select.html
editing/pasteboard/pasting-object.html
editing/pasteboard/prevent-block-nesting-01.html
editing/pasteboard/quirks-mode-br-1.html
editing/pasteboard/select-element-1.html
editing/pasteboard/styled-element-markup.html
editing/pasteboard/testcase-9507.html
editing/pasteboard/undoable-fragment-removes.html
editing/pasteboard/unrendered-br.html

  • platform/qt/Skipped:
8:18 AM Changeset in webkit [58674] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-05-03 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Csaba Osztrogonac.

media/video-duration-known-after-eos.html failing
​https://bugs.webkit.org/show_bug.cgi?id=38466

  • platform/qt/Skipped: Skipping failing test. A lot of media tests are already skipped on this platform. Tor Arne said he'd look at them, at some point.
7:13 AM Changeset in webkit [58673] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix qtlibraryinfix not to contain space

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2010-05-03
Reviewed by Simon Hausmann.

List catenation with += adds whitespace cutting the infix
from the final target.

  • WebCore.pro:
7:10 AM Changeset in webkit [58672] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix rendering of <button> elements on Mac OS X

Reviewed by Simon Hausmann.

The <button> element has ButtonPart appearance, not PushButton part,
so we have to include ButtonPart when we decide if we should draw the
button as raised on Mac OS X.

7:09 AM Changeset in webkit [58671] by Philippe Normand
  • 3 edits
    2 adds in trunk

2010-04-30 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] endless loop after playback ended
​https://bugs.webkit.org/show_bug.cgi?id=38384

At playback end ensure duration() will return a valid duration if
we managed to calculate it based on current position.

Test: media/video-duration-known-after-eos.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::didEnd):

2010-04-30 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] endless loop after playback ended
​https://bugs.webkit.org/show_bug.cgi?id=38384

  • media/video-duration-known-after-eos-expected.txt: Added.
  • media/video-duration-known-after-eos.html: Added.
5:00 AM Changeset in webkit [58670] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Prune dead code in QWebPage

Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:
4:17 AM Changeset in webkit [58669] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Fix build break on Mac OS X

  • plugins/mac/PluginPackageMac.cpp: Use correct type
  • WebCore.pro: Remove duplicate symbol, we now have a Qt implementation
4:00 AM Changeset in webkit [58668] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-03 Daniel Bates <​dbates@rim.com>

Reviewed by Chris Jerdonek.

​https://bugs.webkit.org/show_bug.cgi?id=38447

Refactor the unit tests in VCSUtils_unittest/parseDiff.pl to use
Test::More::is_deeply like we do in VCSUtils_unittest/parseDiffHeader.pl.

  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2:09 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:57 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:22 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:16 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:15 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
12:59 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
12:12 AM Changeset in webkit [58667] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix library infix usage when compiling inside of Qt

Patch by Thomas Zander <​t.zander@nokia.com> on 2010-05-03
Reviewed by Simon Hausmann.

Don't apply the infix when building inside Qt, as that's done through the
inclusion of qbase.pri.

  • WebCore.pro:

May 2, 2010:

10:40 PM Changeset in webkit [58666] by Chris Jerdonek
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed.

Corrected a file path in the ChangeLog entry for r58663 (bug 38319) below.

9:25 PM Changeset in webkit [58665] by mitz@apple.com
  • 3 edits
    2 adds in trunk

Another case of <rdar://problem/7552959> REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()
​https://bugs.webkit.org/show_bug.cgi?id=38445

Reviewed by Simon Fraser.

WebCore:

Test: editing/selection/mixed-editability-11.html

  • dom/Position.cpp:

(WebCore::downstreamIgnoringEditingBoundaries): Added. Returns the furthest visually equivalent
position downstream, crossing any editability boundaries.
(WebCore::upstreamIgnoringEditingBoundaries): Similarly for upstream.
(WebCore::Position::getInlineBoxAndOffset): Changed the logic for finding an inline box for positions
whose node is a block flow. Instead of traversing the DOM, advance downstream or upstream as far as
possible, crossing any editability boudaries. Infinite recursion is avoided by advancing all the way
and checking that the new position is different from the starting position. Also replaced the specific
test for buttons with the generic and more comprehensive canHaveChildrenForEditing().

LayoutTests:

  • editing/selection/mixed-editability-11-expected.txt: Added.
  • editing/selection/mixed-editability-11.html: Added.
7:21 PM Changeset in webkit [58664] by eric@webkit.org
  • 2 edits in trunk

2010-05-02 Geoff Levand <​geoff.levand@am.sony.com>

Reviewed by Eric Seidel.

[GTK] Fix out of source build failure
​https://bugs.webkit.org/show_bug.cgi?id=38051

Add a preprocessor include path for generated GTK header files.
Fixes build errors like these when building GTK out of source:

webkit.h: error: webkit/webkitversion.h: No such file or directory

  • GNUmakefile.am:
6:49 PM Changeset in webkit [58663] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-02 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=38319

  • Scripts/VCSUtils.pm:
    • In parseDiffHeader()--
      • Added an "scmFormat" hash key to the return value to represent whether the diff is Git or SVN formatted.
      • Adjusted the code so the value of "copiedFromPath" will be undef rather than "does not exist" if the file was not copied.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Added a FIXME to refactor these unit tests to use is_deeply().
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Updated the unit tests to test the "scmFormat" value.
    • Simplified the unit tests by refactoring them to use is_deeply().
3:18 PM Changeset in webkit [58662] by eric@webkit.org
  • 5 edits in trunk

2010-05-02 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with QT_NO_BEARERMANAGEMENT
​https://bugs.webkit.org/show_bug.cgi?id=38324

  • platform/network/NetworkStateNotifier.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:

2010-05-02 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with QT_NO_BEARERMANAGEMENT
​https://bugs.webkit.org/show_bug.cgi?id=38324

  • Api/qwebsettings.cpp:
2:48 PM Changeset in webkit [58661] by Simon Hausmann
  • 3 edits
    1 add in trunk

[Qt] QtWebKit versioning added
​https://bugs.webkit.org/show_bug.cgi?id=37207

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2010-04-29
Reviewed by Simon Hausmann.

QtWebkit releases separated from Qt release cycle.

WebCore:

  • WebCore.pro:

WebKit/qt:

  • qtwebkit_version.pri: Added.
2:42 PM Changeset in webkit [58660] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-02 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Old Style trimWhitespace() should be trim()
​https://bugs.webkit.org/show_bug.cgi?id=38441

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
2:31 PM Changeset in webkit [58659] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-02 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with QT_NO_LINEEDIT
​https://bugs.webkit.org/show_bug.cgi?id=38324

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::~RenderThemeQt): (WebCore::RenderThemeQt::findFrameLineWidth):
1:18 PM Changeset in webkit [58658] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-05-02 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Touch inspector controller to kick windows tests.

  • inspector/InspectorController.cpp:
11:32 AM Changeset in webkit [58657] by pfeldman@chromium.org
  • 3 edits in trunk

2010-05-02 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: IMG nodes are being added to the DOM tree late, sometimes hiding the revealed element.

​https://bugs.webkit.org/show_bug.cgi?id=38432

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode): (WebInspector.ElementsTreeElement.prototype.updateTitle): (WebInspector.ElementsTreeElement.prototype._attributeHTML): ():
10:08 AM WebInspector edited by pfeldman@chromium.org
(diff)
9:30 AM Changeset in webkit [58656] by krit@webkit.org
  • 22 edits
    4 adds in trunk

2010-05-02 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG hkern implementation incomplete
​https://bugs.webkit.org/show_bug.cgi?id=38407

Test: svg/text/text-hkern.svg

The current SVG hkern implementation is incomplete and partly wrong. We pass the ACID3 test
by accident.
The new implementation supports all glyph and unicode combinations that are allowed by the Spec
and fixes various of bugs. The parser moved from SVGFontElement to the general parsing code in
SVGParserUtilities.
Some clean-up makes the code more readable and reuseable for the upcoming vkern implementation.
hkern support for text on path is missing and will be added by a following patch.
Unicode strings of hkern elements are just parsed once and not on every glyph again anymore.

  • rendering/SVGRootInlineBox.cpp: (WebCore::calculateCSSKerning): (WebCore::applySVGKerning): (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
  • svg/SVGFontElement.cpp: (WebCore::stringMatchesUnicodeRange): (WebCore::stringMatchesGlyphName): (WebCore::matches): (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
  • svg/SVGFontElement.h:
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::buildHorizontalKerningPair):
  • svg/SVGHKernElement.h:
  • svg/SVGParserUtilities.cpp: (WebCore::parseGlyphName): (WebCore::parseUnicodeRange): (WebCore::parseKerningUnicodeString):
  • svg/SVGParserUtilities.h:

2010-05-02 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG hkern implementation incomplete
​https://bugs.webkit.org/show_bug.cgi?id=38407

The hkern patch fixes some very old bugs in some tests of the official
SVG Test suite. Added a new test to check correct behavior on different
use cases of textin SVG.

  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/mac/svg/text/kerning-expected.checksum:
  • platform/mac/svg/text/kerning-expected.png:
  • platform/mac/svg/text/text-hkern-expected.checksum: Added.
  • platform/mac/svg/text/text-hkern-expected.png: Added.
  • platform/mac/svg/text/text-hkern-expected.txt: Added.
  • svg/text/text-hkern.svg: Added.

2010-05-02 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG hkern implementation incomplete
​https://bugs.webkit.org/show_bug.cgi?id=38407

We support hkern now. Mention this in the SVG status page.

  • projects/svg/status.xml:
8:27 AM Changeset in webkit [58655] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-02 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: debugger shortcuts are processed twice if source frame has focus.

​https://bugs.webkit.org/show_bug.cgi?id=38431

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
8:03 AM Changeset in webkit [58654] by tkent@chromium.org
  • 1 edit in trunk/WebCore/platform/ThreadGlobalData.cpp

Unreviewed. Build fix on Japanese Windows.
Replace a non-ASCII character in a comment with an ASCII character.

5:47 AM Changeset in webkit [58653] by eric@webkit.org
  • 2 edits in trunk

2010-05-02 Kartikaya Gupta <​kagupta@rim.com>

Reviewed by George Staikos.

When running the IDL file through the preprocessor, wait for the preprocessor subcommand to fully terminate before continuing. Without this, if multiple IDL files are parsed in a tight loop, the code dies after 64 IDL files because it exhausts the available system resources.

​https://bugs.webkit.org/show_bug.cgi?id=37888

No new tests. None needed.

  • bindings/scripts/IDLParser.pm:
5:26 AM Changeset in webkit [58652] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Enable JIT for QtWebKit on Symbian
​https://bugs.webkit.org/show_bug.cgi?id=38339

JIT on Symbian has been stable for quite some time, it
is time to turn it on by default.

  • wtf/Platform.h:
5:05 AM Changeset in webkit [58651] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-02 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Eric Seidel.

[Qt] Build error in GraphicsContext3DQt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=38382

Removed duplicate implementation of isGLES2Compliant from
GraphicsContext3DQt.cpp. Removed deprecated API stuff for
texImage2D/texSubImage2D.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:
4:54 AM Changeset in webkit [58650] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-02 Garret Kelly <​gdk@chromium.org>

Reviewed by David Levin.

Make the Touch RuntimeEnabledFeature disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=38392

  • bindings/generic/RuntimeEnabledFeatures.cpp: Disable the Touch feature by default.
4:29 AM Changeset in webkit [58649] by tkent@chromium.org
  • 1 edit in trunk/WebKit/chromium/src/SharedWorkerRepository.cpp

Unreviewed. Fix a build failure by r58647.

1:55 AM Changeset in webkit [58648] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-05-02 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage::userAgentForUrl is terrible API
​https://bugs.webkit.org/show_bug.cgi?id=33875

Simplify the creation of the user agent string to avoid some
overhead for each loaded url.

The static part of the user agent is cached so it only have
to be made once.
This creation has been made in order to simplify the code.

The two variable: application name and current language are
set dynamically when needed.
The default locale is non longer created if the widget locale
is used.

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::userAgentApplicationName): (tst_QWebPage::userAgentLocaleChange):
1:39 AM Changeset in webkit [58647] by eric@webkit.org
  • 10 edits in trunk

2010-05-02 Michael Nordman <Michael Nordman>

Reviewed by Dmitry Titov.

Define two new ResourceRequestBase TargetTypes for worker and shared worker
main resources. Use the new target types where appropiate. Add logic to marshal
the target type specified by requests initiated on a background worker thread.

​https://bugs.webkit.org/show_bug.cgi?id=38295

No new tests. This doesn't have script visible artifacts.

  • platform/network/ResourceRequestBase.cpp: marshal the values (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData):
  • platform/network/ResourceRequestBase.h: define the types (WebCore::ResourceRequestBase::):
  • workers/DefaultSharedWorkerRepository.cpp: use TargetIsSharedWorker (WebCore::SharedWorkerScriptLoader::load):
  • workers/Worker.cpp: use TargetIsWorker (WebCore::Worker::Worker):
  • workers/WorkerContext.cpp: use TargetIsScript for importScripts (WebCore::WorkerContext::importScripts):
  • workers/WorkerScriptLoader.cpp: add a data member for the target type (WebCore::WorkerScriptLoader::WorkerScriptLoader): (WebCore::WorkerScriptLoader::createResourceRequest):
  • workers/WorkerScriptLoader.h:

2010-05-02 Michael Nordman <Michael Nordman>

Reviewed by Dmitry Titov.

Define two new ResourceRequestBase TargetTypes for worker and shared worker
main resources. Use the new target types where appropiate. Add logic to marshal
the target type specified by requests initiated on a background worker thread.

​https://bugs.webkit.org/show_bug.cgi?id=38295

  • src/SharedWorkerRepository.cpp: use TargetIsSharedWorker (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
1:12 AM Changeset in webkit [58646] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-02 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] Upstream test expectations for:
http/tests/loading/basic-auth-resend-wrong-credentials.html
​https://bugs.webkit.org/show_bug.cgi?id=38387

  • platform/chromium/test_expectations.txt:
1:01 AM Changeset in webkit [58645] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-02 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: animation incorrect when scrolling
​https://bugs.webkit.org/show_bug.cgi?id=38371

This is a regression introduced with the invalidate-on-scroll code path, that uses QGraphicsWebViewPrivate::update()
instead of QGraphicsWebViewPrivate::scroll(). The patch makes sure that the scrolling position is correct on
each content update - this shouldn't have a performance impact - the only overhead is an additional value-test on each update.

Tested by ​http://www.the-art-of-web.com/css/css-animation/

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update):
12:50 AM Changeset in webkit [58644] by eric@webkit.org
  • 8 edits
    1 move in trunk/LayoutTests

2010-05-02 Ben Murdoch <​benm@google.com>

Reviewed by Darin Adler.

fast/events/touch has non-standard script test wrappers
​https://bugs.webkit.org/show_bug.cgi?id=38084

Tidy up the touch event layout tests. Make the script-tests TEMPLATE.html
generate asynchronous style tests using js-test-post-function.js and move
the non-standard synchronous test into the resources directory.

  • fast/events/touch/basic-multi-touch-events.html: Regenerate from TEMPLATE.html
  • fast/events/touch/basic-single-touch-events.html: ditto.
  • fast/events/touch/send-oncancel-event.html: ditto.
  • fast/events/touch/touch-target.html: ditto.
  • fast/events/touch/create-touch-event.html: Link to script in resources rather than

script-tests as this test is not generated from TEMPLATE.html.

  • fast/events/touch/resources/create-touch-event.js: Copied from LayoutTests/fast/events/touch/script-tests/create-touch-event.js.
  • fast/events/touch/script-tests/TEMPLATE.html: Update to generate asynchronous tests.
  • fast/events/touch/script-tests/create-touch-event.js: Removed.
  • fast/events/touch/script-tests/touch-target.js: Refactor to work with new wrapper

generated from TEMPLATE.html.

12:23 AM Changeset in webkit [58643] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-05-02 Rafael Weinstein <​rafaelw@chromium.org>

Reviewed by Darin Fisher.

Include WebWindowFeatures in call to WebViewClient::createView.
​https://bugs.webkit.org/show_bug.cgi?id=38301

  • public/WebViewClient.h: (WebKit::WebViewClient::createView):
  • public/WebWindowFeatures.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow):
12:12 AM Changeset in webkit [58642] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-02 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Adele Peterson.

Webkit doesn't compile with 3D-canvas enabled and video disabled
​https://bugs.webkit.org/show_bug.cgi?id=38297

Added a #ifdef ENABLE(VIDEO) to WebGL code

No new tests: compile fix.

  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::texImage2D): (WebCore::JSWebGLRenderingContext::texSubImage2D):
12:01 AM Changeset in webkit [58641] by eric@webkit.org
  • 4 edits in trunk

2010-05-01 Evan Stade <​estade@chromium.org>

Reviewed by David Levin.

[chromium] Skia needs to fade DragImages
​https://bugs.webkit.org/show_bug.cgi?id=38008

tested by DragImageTest

  • platform/chromium/DragImageChromiumSkia.cpp: (WebCore::dissolveDragImageToFraction):implement (WebCore::createDragImageFromImage):deep copy instead of shallow

2010-05-01 Evan Stade <​estade@chromium.org>

Reviewed by David Levin

[chromium] Skia needs to fade DragImages
​https://bugs.webkit.org/show_bug.cgi?id=38008

  • tests/DragImageTest.cpp: (DragImageTest.CreateDragImage): test that the drag image is a deep copy
Note: See TracTimeline for information about the timeline view.