⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 4, 2010:

11:06 PM Changeset in webkit [58803] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-04 Eric Seidel <​eric@webkit.org>

Reviewed by Shinichiro Hamaji.

PrettyPatch.pretty_diff("") should not hang
​https://bugs.webkit.org/show_bug.cgi?id=38552

Also found a bug in PrettyPatch.pretty_diff where it would
hang when passed "" as input.

I suspect there may be bugs in prettify.rb (or our use there-of)
where it can hang, which would then cause the testing thread to hang.

  • Scripts/webkitpy/common/prettypatch.py:
    • Don't hang when passed ""
  • Scripts/webkitpy/common/prettypatch_unittest.py:
    • Test that we don't hang when passed ""
  • Scripts/webkitpy/layout_tests/port/base.py:
    • Add a FIXME that we should share code with prettypatch.rb
10:09 PM Changeset in webkit [58802] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2010-05-04 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Improve check for drawing into the window that was added in r58623
​https://bugs.webkit.org/show_bug.cgi?id=38562

Rather than assuming that any non-bitmap context is the window's context,
compare the current graphics context with -[NSWindow graphicsContext] to
determine that we're drawing into the window.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
8:24 PM Changeset in webkit [58801] by dumi@chromium.org
  • 24 edits
    5 adds
    18 deletes in trunk/WebCore

Auto-generate all Database callbacks.
​https://bugs.webkit.org/show_bug.cgi?id=38503

Reviewed by Adam Barth.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCustomSQLStatementCallback.cpp: Removed.
  • bindings/js/JSCustomSQLStatementCallback.h: Removed.
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementErrorCallback.h: Removed.
  • bindings/js/JSCustomSQLTransactionCallback.cpp: Removed.
  • bindings/js/JSCustomSQLTransactionCallback.h: Removed.
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: Removed.
  • bindings/js/JSCustomSQLTransactionErrorCallback.h: Removed.
  • bindings/js/JSDatabaseCallback.cpp: Removed.
  • bindings/js/JSDatabaseCallback.h: Removed.
  • bindings/js/JSDatabaseCustom.cpp:

(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomSQLStatementCallback.h: Removed.
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8SQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Removed.
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomSQLTransactionCallback.h: Removed.
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Removed.
  • bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
  • bindings/v8/custom/V8DatabaseCallback.h: Removed.
  • bindings/v8/custom/V8DatabaseCustom.cpp:

(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • storage/DatabaseCallback.h:
  • storage/DatabaseCallback.idl: Added.
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::performCallback):

  • storage/SQLStatementCallback.h:
  • storage/SQLStatementCallback.idl: Added.
  • storage/SQLStatementErrorCallback.idl: Added.
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverTransactionCallback):

  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionCallback.idl: Added.
  • storage/SQLTransactionErrorCallback.h:
  • storage/SQLTransactionErrorCallback.idl: Added.
8:06 PM Changeset in webkit [58800] by cmarrin@apple.com
  • 1 add in trunk/LayoutTests/platform/mac/compositing/iframes/composited-parent-iframe-expected.txt

results for new test checked in with ​http://trac.webkit.org/changeset/58797

7:43 PM Changeset in webkit [58799] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-04 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations fix.

Re-add the two expectations lines that got mistakenly deleted in
r58798.

  • platform/chromium/test_expectations.txt:
7:05 PM Changeset in webkit [58798] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-04 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Made composited iframes work on Windows
​https://bugs.webkit.org/show_bug.cgi?id=32446

I've added one new test (composited-parent-iframe.html) which
shows both the parent iframe and the iframe contents document
with compositing. It also shows correct behavior with clipping,
borders, margins, padding and shadows. It also sets the iframe
size as a percent of the page to show correct resizing behavior.
The existing composited-iframe.html has been changed similarly
but without the page resizing. The existing preserve-3d-switching.html
test needed new results because of changes to the layer dumper.

  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/composited-iframe.html:
  • compositing/iframes/composited-parent-iframe.html: Added.
  • compositing/iframes/resources/composited-subframe.html:
  • platform/win/compositing/iframes/composited-iframe-expected.txt:
  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Added.
6:50 PM Changeset in webkit [58797] by cmarrin@apple.com
  • 9 edits
    2 adds in trunk

Reviewed by Simon Fraser.

Made composited iframes work on Windows
​https://bugs.webkit.org/show_bug.cgi?id=32446


This completes the work in ​http://trac.webkit.org/changeset/57919
to create compositing layers in the parent document when an iframe has
a compositing layer. The parent document has a layer for the iframe
element and builds a layer tree to the page root. The layer tree for the
iframe document is then parented to the iframe element's GraphicsLayer.


The RenderLayerCompositor for the iframe document (which owns the
root of the layer tree) now has a clippingLayer which is the
parent of the layer tree root so it can be clipped to the parent
iframe's bounds, taking into account borders, padding, etc. in
the parent iframe element.


I also got rid of a no longer used function: RenderLayerCompositor::parentInRootLayer

Test: compositing/iframes/composited-parent-iframe.html

  • rendering/RenderLayerBacking.cpp:Make calls to RenderLayerCompositor to set the clipping bounds for iframe content
  • rendering/RenderLayerCompositor.cpp:Hook the iframe content to the parent iframe element
  • rendering/RenderLayerCompositor.h:
6:24 PM Changeset in webkit [58796] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Not reviewed.

Updated test results - the test still passes.

  • http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
6:22 PM Changeset in webkit [58795] by dumi@chromium.org
  • 2 edits in trunk/WebKitSite

Fix the sticky-notes demo.
​https://bugs.webkit.org/show_bug.cgi?id=38550

Reviewed by Darin Adler.

  1. Exceptions thrown by openDatabase() should be treated as

failures.

  1. Do not allow users to create new notes when openDatabase()

failed.

  • demos/sticky-notes/index.html:
6:11 PM Changeset in webkit [58794] by Chris Fleizach
  • 9 edits in trunk/LayoutTests

AX: layout tests need to be updated to reflect what is being tested
​https://bugs.webkit.org/show_bug.cgi?id=38556

Reviewed by Beth Dakin.

Many of the initial AX layout tests just dumped a lot of attributes and did not
have a focused test. This updates some of those tests (more to follow in the future).

  • accessibility/image-map1.html:
  • accessibility/img-aria-button-alt-tag-expected.txt:
  • accessibility/img-aria-button-alt-tag.html:
  • accessibility/input-image-alt-expected.txt:
  • accessibility/input-image-alt.html:
  • accessibility/placeholder-expected.txt:
  • accessibility/placeholder.html:
  • platform/mac/accessibility/image-map1-expected.txt:
6:08 PM Changeset in webkit [58793] by eric@webkit.org
  • 5 edits in trunk/WebKit/chromium

2010-05-04 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

Provide an API for querying whether a WebWidget is using gpu accelerated compositing.
Also changed: isAcceleratedCompositing to: isAcceleratedCompositingActive.
​https://bugs.webkit.org/show_bug.cgi?id=38220

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.h: (WebKit::WebPopupMenuImpl::isAcceleratedCompositingActive):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::isAcceleratedCompositingActive): (WebKit::WebViewImpl::setRootGraphicsLayer): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::updateRootLayerContents):
  • src/WebViewImpl.h:
5:57 PM Changeset in webkit [58792] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=38497
<rdar://problem/7759438> Make sure that http URLs always have a host in SecurityOrigin

This is a hardening fix, and behavior really depends on what an underlying networking layer
does. So, no test.

  • page/SecurityOrigin.cpp: (WebCore::schemeRequiresAuthority): List schemes that need an authority for successful loading. (WebCore::SecurityOrigin::SecurityOrigin): Never let e.g. http origins with empty authorities have the same security origin.
5:49 PM Changeset in webkit [58791] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-04 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark fast/forms/placeholder-pseudo-style.html as an IMAGE diff on
chromium-linux . This was mistaken deleted earlier today. Mark
fast/dom/clone-node-z-index.html as a TEXT diff on chromium-win; I
haven't looked at this yet but I need to roll past this to get the
new-run-webkit-tests change I checked in in r58789 downstream to
the Chromium bots.

  • platform/chromium/test_expectations.txt:
5:30 PM Changeset in webkit [58790] by eric@webkit.org
  • 15 edits in trunk

2010-05-04 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getFramebufferAttachmentParameter should return the original WebGLTexture/WebGLRenderbuffer instead of creating new ones sharing names.
​https://bugs.webkit.org/show_bug.cgi?id=38236

  • fast/canvas/webgl/gl-object-get-calls-expected.txt: Check if getFramebufferAttachmentParameter return a texture/renderbuffer that matches the original one.
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js: Ditto.

2010-05-04 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getFramebufferAttachmentParameter should return the original WebGLTexture/WebGLRenderbuffer instead of creating new ones sharing names.
​https://bugs.webkit.org/show_bug.cgi?id=38236

  • html/canvas/CanvasObject.h: Add type check functions. (WebCore::CanvasObject::isBuffer): (WebCore::CanvasObject::isFramebuffer): (WebCore::CanvasObject::isProgram): (WebCore::CanvasObject::isRenderbuffer): (WebCore::CanvasObject::isShader): (WebCore::CanvasObject::isTexture):
  • html/canvas/WebGLBuffer.h: Add type check functions. (WebCore::WebGLBuffer::isBuffer):
  • html/canvas/WebGLFramebuffer.h: Add type check functions. (WebCore::WebGLFramebuffer::isFramebuffer):
  • html/canvas/WebGLProgram.h: Add type check functions. (WebCore::WebGLProgram::isProgram):
  • html/canvas/WebGLRenderbuffer.cpp: remove constructor using existing name.
  • html/canvas/WebGLRenderbuffer.h: Add type check functions; remove constructor using existing name. (WebCore::WebGLRenderbuffer::isRenderbuffer):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Return original Texture/Renderbuffer instead of creating new ones. (WebCore::WebGLRenderingContext::findTexture): Find a WebGLTexture using a name. (WebCore::WebGLRenderingContext::findRenderbuffer): Find a WebGLRenderbuffer using a name.
  • html/canvas/WebGLRenderingContext.h: Add find* functions.
  • html/canvas/WebGLShader.h: Add type check functions. (WebCore::WebGLShader::isShader):
  • html/canvas/WebGLTexture.cpp: remove constructor using existing name.
  • html/canvas/WebGLTexture.h: Add type check functions; remove constructor using existing name. (WebCore::WebGLTexture::isTexture):
5:16 PM Changeset in webkit [58789] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-05-04 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: turn off threading on the Chromium Mac port until
we can stabilize the port more and figure out why it is hanging so
frequently.

​https://bugs.webkit.org/show_bug.cgi?id=38553

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
    • override default_child_processes() and log a warning
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • fix a typo that caused us to print a method object instead of the value the method object returns in the case where there is only one child process.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
    • Add unit tests for the output of run_webkit_tests - in this case, the handling of --child-processes and --print config
5:16 PM Changeset in webkit [58788] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-04 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] QT_MOBILE_THEME compile time flag
​https://bugs.webkit.org/show_bug.cgi?id=38439

Replacing preprocessor conditional used in RenderThemeQt from Q_WS_MAEMO_5 to
USE(QT_MOBILE_THEME).

  • WebCore.pro:
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::qStyle): (WebCore::RenderThemeQt::extraDefaultStyleSheet): (WebCore::RenderThemeQt::adjustMenuListButtonStyle): (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
  • platform/qt/RenderThemeQt.h:
4:57 PM Changeset in webkit [58787] by adachan@apple.com
  • 2 edits in trunk/WebKit/mac

​https://bugs.webkit.org/show_bug.cgi?id=38555

Reviewed by David Kilzer.

Small code refactoring: move the logic to figure out the path to the
databases directory to another method.

  • Storage/WebDatabaseManager.mm:

(databasesDirectoryPath):
(WebKitInitializeDatabasesIfNecessary):

4:17 PM Changeset in webkit [58786] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-05-04 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dan Bernstein.

SVG fonts trigger GlyphPage::fill with null font
​https://bugs.webkit.org/show_bug.cgi?id=38530

SVG fonts do not use the glyph page cache. This change detects when
attempting to fill a GlyphPage with an SVG font and indicates that
the glyphs were not available.

  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::fill): helper method which handles attempts to fill a GlyphPage with SVG or non-SVG fonts (WebCore::GlyphPageTreeNode::initializePage): use the helper where appropriate
3:59 PM Changeset in webkit [58785] by crogers@google.com
  • 1 edit in branches/audio/WebCore/bindings/v8/V8DOMWrapper.cpp

Fixes to V8DOMWrapper to handle CachedAudio

3:58 PM Changeset in webkit [58784] by crogers@google.com
  • 2 edits in branches/audio/WebCore

Initial changes to gyp files to build audio engine

3:58 PM Changeset in webkit [58783] by crogers@google.com
  • 2 adds in branches/audio/WebCore/audio

Add custom V8 bindings for AudioContext and AudioNode

3:46 PM Changeset in webkit [58782] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed tests skips for qt/gtk.

Add the recently added drag and drop tests to the
skipped lists for both gtk and qt to go along with
the other drag and drop tests that are skipped on
those platforms.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
3:24 PM Changeset in webkit [58781] by andersca@apple.com
  • 5 edits in trunk/WebKit2

2010-05-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

[WebKit2] The web process doesn't need to paint when the web view is hidden.
​https://bugs.webkit.org/show_bug.cgi?id=38549

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: (DrawingAreaMessage::): Add SuspendPainting/ResumePainting messages.


  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: (WebKit::DrawingAreaProxyUpdateChunk::setPageIsVisible): Suspend and resume painting accordingly.


  • WebProcess/WebPage/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk): Initialize m_shouldPaint to true.


(WebKit::DrawingAreaUpdateChunk::display):
Return if m_shouldPaint is false.


(WebKit::DrawingAreaUpdateChunk::scheduleDisplay):
Ditto.


(WebKit::DrawingAreaUpdateChunk::setSize):
Assert that we should paint here.

(WebKit::DrawingAreaUpdateChunk::suspendPainting):
Set m_shouldPaint to false and stop the timer.


(WebKit::DrawingAreaUpdateChunk::resumePainting):
Set m_shouldPaint to true and paint if needed.

(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
handle SuspendPainting/ResumePainting messages.

  • WebProcess/WebPage/DrawingAreaUpdateChunk.h:
3:04 PM Changeset in webkit [58780] by levin@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION(r54368): Text drag-and-drop from input/textarea doesn't work
if the text is like a URL
​https://bugs.webkit.org/show_bug.cgi?id=38374

Patch by Kent Tamura <​tkent@chromium.org> on 2010-05-04
Reviewed by David Levin (and unofficially by Enrica Casucci).

WebCore:

Since r54368, documentFragmentFromDragData() creates an <a> element
with no anchor text for URL-like text dragged from input/textarea
element. If such text is dropped to input/textarea element, the text
is not inserted.
To fix this problem, use the original text or the URL as an anchor
text.

Test: editing/pasteboard/drag-drop-url-text.html

  • page/DragController.cpp:

(WebCore::documentFragmentFromDragData):

LayoutTests:

  • editing/pasteboard/drag-drop-url-text-expected.txt: Added.
  • editing/pasteboard/drag-drop-url-text.html: Added.
3:01 PM Changeset in webkit [58779] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-04 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by Darin Adler.

WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
​https://bugs.webkit.org/show_bug.cgi?id=38535

Don't call asFunction if callee is not a FunctionType to prevent assertion failure
in JSCell::isObject().

  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::functionName): (JSC::DebuggerCallFrame::calculatedFunctionName):
2:50 PM Changeset in webkit [58778] by timothy@apple.com
  • 1 edit in trunk/WebKit/ChangeLog

Remove ChangeLog from bad merge.

2:49 PM Changeset in webkit [58777] by timothy@apple.com
  • 3 edits in trunk/WebKitTools

Fix the find command in extract-localizable-strings so skip
directories are correctly skipped and header files are searched.

​https://bugs.webkit.org/show_bug.cgi?id=38545
rdar://problem/7941295

Reviewed by Darin Adler.

  • Scripts/extract-localizable-strings: Append -o after each -prune

so -and isn't implied. Surround all the -name arguments so they get
an implied -print action. Removed check for "icu". Skip any header that
ends in LocalizableStrings.h, so SafariLocalizableStrings.h is skipped.

  • Scripts/update-webkit-localizable-strings: Add the two icu directories

to the skip list.

2:49 PM Changeset in webkit [58776] by timothy@apple.com
  • 1 edit in trunk/WebKit/ChangeLog

Updated the localizable strings to run without errors.

Rubber-stamped by John Sullivan.

  • English.lproj/Localizable.strings: Updated.
  • StringsNotToBeLocalized.txt: Updated.
2:13 PM Changeset in webkit [58775] by steveblock@google.com
  • 4 edits in trunk/WebCore

JavaInstanceJSC.cpp and JNIUtilityPrivate.cpp need to include jni_jsobject.h for jlong_to_pt() and ptr_to_jlong()
​https://bugs.webkit.org/show_bug.cgi?id=38525

Reviewed by Darin Adler.

No new tests, build fix only.

  • bridge/jni/jni_jsobject.h: Guard Mac-specific code with PLATFORM(MAC)
  • bridge/jni/jsc/JNIUtilityPrivate.cpp: Include jni_jsobject.h
  • bridge/jni/jsc/JavaInstanceJSC.cpp: Include jni_jsobject.h
2:02 PM Changeset in webkit [58774] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-04 Steve Block <​steveblock@google.com>

Reviewed by Darin Adler.

New FileSystemPOSIX functions cause linker errors on Android
​https://bugs.webkit.org/show_bug.cgi?id=38521

No new tests, build fix only.

  • platform/android/FileSystemAndroid.cpp: Remove closeFile, which is provided in FileSystemPOSIX.cpp
  • platform/posix/FileSystemPOSIX.cpp: Guard writeToFile with !PLATFORM(ANDROID)
1:49 PM Changeset in webkit [58773] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove redundant exports to fix Windows build warnings.

1:37 PM Changeset in webkit [58772] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-04 Jesus Sanchez-Palencia <​jesus@webkit.org>

Reviewed by Eric Seidel.

Wrong documentation on 'webkit-patch help land'.
​https://bugs.webkit.org/show_bug.cgi?id=37871

Small fix on the help documentation for webkit-patch
land.

  • Scripts/webkitpy/tool/commands/download.py:
1:16 PM Changeset in webkit [58771] by Beth Dakin
  • 2 edits in trunk/WebKit/mac

Fix for <rdar://problem/7818509> Crash occurs when exiting Safari

Reviewed by Mike Thole.

We can avoid this crash if we call [self _removeFromAllWebViewsSet]
even in the case when we are doing a fastDocumentTeardown. This is
a much safer approach.

  • WebView/WebView.mm:

(-[WebView _close]):

1:13 PM Changeset in webkit [58770] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] http/tests/security/cross-frame-access-name-getter.html timed out
​https://bugs.webkit.org/show_bug.cgi?id=38540

  • platform/qt/Skipped: http/tests/security/cross-frame-access-name-getter.html skipped until bug fixed.
1:02 PM Changeset in webkit [58769] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-04 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Remove a bunch of test failures that are no longer failing (likely fixed in r58762).

  • platform/chromium/test_expectations.txt:
11:49 AM Changeset in webkit [58768] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2010-05-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: restore main and sidebar scroller positions
when switching between panels.

​https://bugs.webkit.org/show_bug.cgi?id=38522

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.elementsToRestoreScrollPositionsFor):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.hide): (WebInspector.Panel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.Panel.prototype._storeScrollPositions): (WebInspector.Panel.prototype._restoreScrollPositions):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.elementsToRestoreScrollPositionsFor):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
11:12 AM Changeset in webkit [58767] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, build fix for Qt skipping new notifications tests.

10:42 AM Changeset in webkit [58766] by eric@webkit.org
  • 5 edits
    4 adds in trunk

2010-05-04 Steven Lai <​steven_lai@asia.apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37900
<rdar://problem/7806164> cloneNode() does not preserve z-index with more than six digits

  • fast/dom/HTMLInputElement/clone-input-checked-expected.txt: Added.
  • fast/dom/HTMLInputElement/clone-input-checked.html: Added.
  • fast/dom/clone-node-z-index-expected.txt: Added.
  • fast/dom/clone-node-z-index.html: Added.

2010-05-04 Steven Lai <​steven_lai@asia.apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37900
<rdar://problem/7806164> cloneNode() does not preserve z-index with more than six digits

Tests: fast/dom/HTMLInputElement/clone-input-checked.html

fast/dom/clone-node-z-index.html

  • dom/Element.cpp: undid the order change of calling copyNonAttributeProperties() before setAttributes() (WebCore::Element::cloneElementWithoutChildren): uncheck the previous radio button in the same radio button group only when the checked radio box is appended to the dom tree
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateCheckedRadioButtons): (WebCore::HTMLInputElement::attach): (WebCore::HTMLInputElement::setChecked):
  • html/HTMLInputElement.h:
10:20 AM Changeset in webkit [58765] by johnnyg@google.com
  • 8 edits
    4 adds in trunk

2010-04-29 John Gregg <​johnnyg@google.com>

Reviewed by Dmitry Titov.

notifications should have dir and replaceId attributes
​https://bugs.webkit.org/show_bug.cgi?id=38336

  • public/WebNotification.h:
  • src/WebNotification.cpp: (WebKit::WebNotification::dir): (WebKit::WebNotification::replaceId):

2010-04-29 John Gregg <​johnnyg@google.com>

Reviewed by Dmitry Titov.

notifications should have dir and replaceId attributes.
Note that tests are only enabled in Chromium, skipped elsewhere
since notifications aren't implemented.
​https://bugs.webkit.org/show_bug.cgi?id=38336

Tests: fast/notifications/notifications-replace.html

fast/notifications/notifications-rtl.html

  • notifications/Notification.h: (WebCore::Notification::dir): (WebCore::Notification::setDir): (WebCore::Notification::replaceId): (WebCore::Notification::setReplaceId):
  • notifications/Notification.idl:

2010-04-29 John Gregg <​johnnyg@google.com>

Reviewed by Dmitry Titov.

notifications should have dir and replaceId attributes
Tests are disabled until the attributes are correctly handled
in Chromium test_shell.
​https://bugs.webkit.org/show_bug.cgi?id=38336

  • fast/notifications/notifications-replace-expected.txt: Added.
  • fast/notifications/notifications-replace.html: Added.
  • fast/notifications/notifications-rtl-expected.txt: Added.
  • fast/notifications/notifications-rtl.html: Added.
  • platform/chromium/test_expectations.txt:
9:31 AM Changeset in webkit [58764] by eric@webkit.org
  • 5 edits in trunk

2010-05-04 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage viewMode property
​https://bugs.webkit.org/show_bug.cgi?id=38119

Rename the property from wrt_viewMode to _q_viewMode.

  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::viewModes):

2010-05-04 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage viewMode property
​https://bugs.webkit.org/show_bug.cgi?id=38119

Rename the property from wrt_viewMode to _q_viewMode.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature):
9:24 AM Changeset in webkit [58763] by alex
  • 2 edits in trunk/WebCore

2010-05-04 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Fixed error defining the float/double minimum in the object
properties, the smallest value of a float/double is
-G_MAXDOUBLE/-G_MAXFLOAT.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorGObject.pm:
8:55 AM Changeset in webkit [58762] by Joseph Pecoraro
  • 7 edits in trunk

2010-05-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dan Bernstein.

REGRESSION: Text clipped in absolutely positioned search inputs
​https://bugs.webkit.org/show_bug.cgi?id=38468

Update the test to include a second search field and show
the clipping of a search input is like a text input.

  • fast/css/input-search-padding.html:
  • platform/mac/fast/css/input-search-padding-expected.checksum:
  • platform/mac/fast/css/input-search-padding-expected.png:
  • platform/mac/fast/css/input-search-padding-expected.txt:

2010-05-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dan Bernstein.

REGRESSION: Text clipped in absolutely positioned search inputs
​https://bugs.webkit.org/show_bug.cgi?id=38468

Previously I incorrectly added x() and y() to the tx and ty positioning.
This clips a search input like a text input, respecting the vertically
centered text.

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): only the Y changes, so change setLocation to setY (WebCore::RenderTextControlSingleLine::controlClipRect):
8:41 AM Changeset in webkit [58761] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-04 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: REGRESSION: Up/Down, PgUp/PgDown keys do not change numeric style properties
​https://bugs.webkit.org/show_bug.cgi?id=38516

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
8:30 AM Changeset in webkit [58760] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2010-05-04 Ben Murdoch <​benm@google.com>

Reviewed by Simon Hausmann.

Crash in handleTouchEvent: using dangling node ptrs in hashmap
​https://bugs.webkit.org/show_bug.cgi?id=38514

  • fast/events/touch/resources/touch-stale-node-crash.js: Added.
  • fast/events/touch/resources/send-touch-up.html: Added.
  • fast/events/touch/touch-stale-node-crash-expected.txt: Added.
  • fast/events/touch/touch-stale-node-crash.html: Added.

2010-05-04 Ben Murdoch <​benm@google.com>

Reviewed by Simon Hausmann.

Crash in handleTouchEvent: using dangling node ptrs in hashmap
​https://bugs.webkit.org/show_bug.cgi?id=38514

When navigating away from a page, if you have your finger still
pressed and then lift it on the new page we see a crash if the
node got deleted as we still have a dangling pointer in the
m_originatingTouchPointTargets hashmap and try to use it as the
receiver to dispatch a touchend event.

Test: fast/events/touch/touch-stale-node-crash.html

  • page/EventHandler.cpp: (WebCore::EventHandler::clear): Clear the hashmap of touch targets.
7:54 AM QtWebKitPackaging edited by Simon Hausmann
(diff)
7:53 AM QtWebKitPackaging edited by Simon Hausmann
(diff)
7:52 AM QtWebKitPackaging edited by Simon Hausmann
(diff)
7:29 AM Changeset in webkit [58759] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-04 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Fix typo in run_webkit_tests.py: s/_print\./_printer./
​https://bugs.webkit.org/show_bug.cgi?id=38515

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:15 AM Changeset in webkit [58758] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-04 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Drawer Misbehaving when Docking / Undocking in Console Panel
​https://bugs.webkit.org/show_bug.cgi?id=38510

  • inspector/front-end/inspector.js: (WebInspector.set attached): resize the drawer after docking/undocking
7:04 AM Changeset in webkit [58757] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-05-04 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

[chromium] Make the select popup not close on right/middle clicks.
​https://bugs.webkit.org/show_bug.cgi?id=38473

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseDown):
7:04 AM Changeset in webkit [58756] by Laszlo Gombos
  • 2 edits in trunk

2010-05-04 Laszlo Gombos <Laszlo Gombos>

Unreviewed, build fix for Symbian.

[Symbian] Symbian builds does not support shadow builds

Revision r54715 broke the Symbian build. For Symbian
the include directory is generated in the root of the source tree.
This patch sets the INCLUDEPATH accordingly for Symbian.

  • WebKit.pri:
6:53 AM Changeset in webkit [58755] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-04 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Holger Freyther.

Fix a memory leak inside the QScriptValue.

QSciptValuePrivate::toString should release all temporary variables.

[Qt] QScriptValue::toString have a memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=38112

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toString):
6:30 AM Changeset in webkit [58754] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Preserve binary compatibility with qtwebkit-2.0 branch

Rubber-stamped by Tor Arne Vestbø.

Moved the WebGL attribute in QWebSettings to the end of the enum,
to ensure that the numeric values of the enum values following it
are the same as in the release branch.

  • Api/qwebsettings.h:
5:34 AM Changeset in webkit [58753] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-04 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Darin Adler.

Does not work on SPARC because of alignment issues
​https://bugs.webkit.org/show_bug.cgi?id=38455

Use AllocAlignmentInteger instead of void* on pageheap_memory to
avoid crashing at runtime in some architectures. Investigated by
Mike Hommey <​mh@glandium.org>, change suggested by Darin Adler.

  • wtf/FastMalloc.cpp:
5:31 AM Changeset in webkit [58752] by Laszlo Gombos
  • 3 edits in trunk/WebCore

2010-05-04 Laszlo Gombos <Laszlo Gombos>

Unreviewed, build fix for Symbian.

[Symbian] Build fix after r58598.

Use C99 integer types for the Symbian plugin
implementation.

No new tests, as there is no new functionality.

  • plugins/symbian/PluginPackageSymbian.cpp: (WebCore::PluginPackage::NPVersion):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::handlePostReadFile):
5:07 AM Changeset in webkit [58751] by Nikolas Zimmermann
  • 11 edits
    3 copies in trunk/WebCore

2010-05-04 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Split SVGCharacterLayoutInfo in smaller pieces
​https://bugs.webkit.org/show_bug.cgi?id=38513

Split SVGCharacterLayoutInfo into SVGCharacterLayoutInfo/SVGCharacterData and SVGTextChunkLayoutInfo.
This is a preparation for more work in the text area.

  • Android.mk: Add SVGCharacterData.(cpp|h) and SVGTextChunkLayoutInfo.h to build.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/SVGCharacterData.cpp: Copied from rendering/SVGCharacterLayoutInfo.cpp.
  • rendering/SVGCharacterData.h: Copied from rendering/SVGCharacterLayoutInfo.h. (WebCore::SVGChar::SVGChar):
  • rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::isInitialLayout): Introduced new helper function to share code between addLayoutInformation/addStackContent. (WebCore::SVGCharacterLayoutInfo::addLayoutInformation): Use new helper function. (WebCore::SVGCharacterLayoutInfo::addStackContent): Ditto
  • rendering/SVGCharacterLayoutInfo.h:
  • rendering/SVGRootInlineBox.h: Include new files.
  • rendering/SVGTextChunkLayoutInfo.h: Copied from rendering/SVGCharacterLayoutInfo.h.
4:49 AM BuildingQtOnOSX edited by vestbo@webkit.org
(diff)
4:48 AM Changeset in webkit [58750] by jeremy@chromium.org
  • 2 edits in trunk/LayoutTests

Revert r58747 - postponing Skia roll, at which time
we'll need to add these expected failures back.

​https://bugs.webkit.org/show_bug.cgi?id=38512

  • platform/chromium/test_expectations.txt:
4:16 AM Changeset in webkit [58749] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-04 Xan Lopez <​xlopez@igalia.com>

Reviewed by Holger Freyther.

[GTK] GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=33590

Use helper functions from CodeGenerator.pm to figure out whether a
type is "fundamental" or not (basically whether it's anything
other than a string or a non-pointer type).

  • bindings/scripts/CodeGeneratorGObject.pm:
3:25 AM Changeset in webkit [58748] by apavlov@chromium.org
  • 10 edits
    2 adds in trunk/WebCore

2010-04-30 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: REGRESSION: Disabled style properties are absent in Styles sidebar after WebInspector is re-opened
​https://bugs.webkit.org/show_bug.cgi?id=38255

Moved stylesheet-related mappings into a separate object stored
in InspectorController rather than InspectorDOMAgent (which gets reset
on every frontend [dis]connect).

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorCSSStore.cpp: Added. (WebCore::InspectorCSSStore::InspectorCSSStore): (WebCore::InspectorCSSStore::~InspectorCSSStore): (WebCore::InspectorCSSStore::reset):
  • inspector/InspectorCSSStore.h: Added.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setFrontend): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::bindStyle): (WebCore::InspectorDOMAgent::bindRule): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::buildObjectForRule):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create): (WebCore::InspectorDOMAgent::cssStore):
2:55 AM Changeset in webkit [58747] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-04 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Pavel Feldman.

Preparing for chromium skia roll incorporating changes up to r561.
Add expected failures so bots don't turn red while rolling.

​https://bugs.webkit.org/show_bug.cgi?id=38512

  • platform/chromium/test_expectations.txt:
2:36 AM Changeset in webkit [58746] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix to make Qt bot happier.

r58712 made fast/workers/worker-gc2.html crash. It seems to be a DRT sideeffect,
skipping worker-event-listener.html solve the problem until we find a real fix.
​https://bugs.webkit.org/show_bug.cgi?id=38502

  • platform/qt/Skipped: fast/workers/worker-event-listener.html skipped.
2:25 AM Changeset in webkit [58745] by mnaganov@chromium.org
  • 4 edits in trunk/WebCore

2010-05-04 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Display "Recording..." item when recording an user-initiated CPU profile.

​https://bugs.webkit.org/show_bug.cgi?id=38043

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.removeProfileHeader): (WebInspector.ProfilesPanel.prototype.showProfile):
  • inspector/front-end/inspector.js: (WebInspector.setRecordingProfile):
2:15 AM Changeset in webkit [58744] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2010-05-04 Tucker Jay <​jay.tucker@nokia.com>

Reviewed by Holger Freyther.

Animated GIF images does not animate 10x as expected by default.
​https://bugs.webkit.org/show_bug.cgi?id=36818

Added test case to existing manual test to test the
fixed functionality.

  • manual-tests/qt/qt-10loop-anim.gif: Added.
  • manual-tests/qt/qt-gif-test.html:
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::repetitionCount):
1:27 AM Changeset in webkit [58743] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-05-04 Dirk Schulze <​krit@webkit.org>

Unreviewed sort of XCodes project file.

  • WebCore.xcodeproj/project.pbxproj:
1:06 AM Changeset in webkit [58742] by Chris Jerdonek
  • 14 edits in trunk/WebKitTools

2010-05-04 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

This revision completes the terminology change from "processor" to
"checker" for the CarriageReturnProcessor, CppProcessor,
PythonProcessor, and TextProcessor classes, etc.

​https://bugs.webkit.org/show_bug.cgi?id=38262

The word "processor" currently has two uses in our code. This
revision renames the lower-level use to "checker" and preserves the
word "processor" for higher-level, more general uses. This
revision also makes whatever other name changes that logically
followed from this change.

  • Scripts/check-webkit-style:
    • Updated references to PatchChecker.
  • Scripts/webkitpy/style/checker.py:
    • Renamed the StyleCheckerConfiguration class to StyleProcessorConfiguration.
    • Renamed the ProcessorDispatcher class to CheckerDispatcher, and made similar changes for the class's method names.
    • Renamed the PatchChecker class to PatchReader.
    • Updated the file as necessary to accommodate the other class renames in this patch.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/checkers/common.py:
    • Renamed the CarriageReturnProcessor class to CarriageReturnChecker, and changed its process() method to check().
  • Scripts/webkitpy/style/checkers/common_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/checkers/cpp.py:
    • Renamed the CppProcessor class to CppChecker, and renamed its process() method to check().
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/checkers/python.py:
    • Renamed the PythonProcessor class to PythonChecker, and renamed its process() method to check().
  • Scripts/webkitpy/style/checkers/python_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/checkers/text.py:
    • Renamed the TextProcessor class to TextChecker, and renamed its process() method to check().
  • Scripts/webkitpy/style/checkers/text_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/error_handlers.py:
    • Updated the code as necessary.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Updated the unit test code as necessary.
1:00 AM Changeset in webkit [58741] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-05-04 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

Adjusted svn-apply and -unapply to accept git diffs generated
using the --no-prefix flag.

​https://bugs.webkit.org/show_bug.cgi?id=32438

  • Scripts/VCSUtils.pm:
    • Loosened the regular expression for the "diff --git" line to match when the --no-prefix flag is used with "git diff".
    • Also refactored the code parsing the first line so that the script exits with an error message if the first line cannot be parsed.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
    • Added a unit test case for the --no-prefix case.
12:57 AM Changeset in webkit [58740] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/JavaScriptCore

2010-05-04 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add first WTFURL file
​https://bugs.webkit.org/show_bug.cgi?id=38470

This class represents a component of a URL, such as the scheme or path.
Essentially, the class is an index into a string buffer.

  • wtf/url: Added.
    • There was some discussion about where to put the URL library. There are a number of reasonable options, but putting the library in the WTF directory seems like a reasonable alternative. This location will make more sense once WTF is moved out of JavaScriptCore and into a top-level directory.
  • wtf/url/src: Added.
    • I've added this extra directory to the usual structure because we eventually want a "public" folder that defines the public interface to this library that clients outside of svn.webkit.org can rely upon, much like the various subfolders of the WebKit directory often define a public API.
  • wtf/url/src/URLComponent.h: Added.
    • I've added this somewhat trivial class to get the ball rolling.

(WTF::URLComponent::URLComponent):
(WTF::URLComponent::isValid):
(WTF::URLComponent::isNonempty):
(WTF::URLComponent::reset):
(WTF::URLComponent::operator==):
(WTF::URLComponent::begin):
(WTF::URLComponent::setBegin):
(WTF::URLComponent::length):
(WTF::URLComponent::setLength):
(WTF::URLComponent::end):

  • wtf/url/wtfurl.gyp: Added.
    • WTFURL will be an independently buildable library, hence the beginnings of a wtfurl.gyp file.
12:55 AM Changeset in webkit [58739] by Chris Jerdonek
  • 3 edits
    1 copy
    1 delete in trunk/WebKitTools

2010-05-04 Chris Jerdonek <Chris Jerdonek>

Reviewed by Daniel Bates.

Changed VCSUtils.pm's parseDiffHeader() to call the new
parseGitDiffHeader() method.

​https://bugs.webkit.org/show_bug.cgi?id=38454

This revision makes more progress towards adding executable-bit
support to svn-apply and svn-unapply. It also makes more progress
towards refactoring the code into a more maintainable form.

  • Scripts/VCSUtils.pm:
    • Removed gitdiff2svndiff().
    • Removed the Git-specific logic from parseDiffHeader() and renamed it parseSvnDiffHeader().
    • Added a new parseDiffHeader() subroutine which calls parseSvnDiffHeader() or parseGitDiffHeader() depending on the format of the first header line.
  • Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Removed.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Removed most of the test cases since these cases are now covered by the unit tests for parseSvnDiffHeader() and parseGitDiffHeader().
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl: Added.
    • Copied the SVN unit tests from parseDiffHeader.pl and updated them as necessary.
12:22 AM Changeset in webkit [58738] by alex
  • 2 edits in trunk/LayoutTests

2010-05-04 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, skip test.

Skipping inspector/timeline-parse-html.html
​https://bugs.webkit.org/show_bug.cgi?id=38509

  • platform/gtk/Skipped:
12:03 AM Changeset in webkit [58737] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-03 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Builders should run the perl and python unit tests on every commit
​https://bugs.webkit.org/show_bug.cgi?id=37976

The unit tests take a few seconds to run, so they should not
have any noticable effect on builder speed.

We're running the tests everywhere but Tiger as Tiger's
Python version is ancient.
I would have rather have detected the python version of the
slave but I couldn't find any API to do that, and I didn't want
to hack version detection into test-webkitpy (at least not yet).

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

May 3, 2010:

11:52 PM Changeset in webkit [58736] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-05-03 Steven Lai <​steven_lai@asia.apple.com>

Reviewed by Brady Eidson.

Test hashchange() event is fired in asynchronous manner.
​https://bugs.webkit.org/show_bug.cgi?id=36201

  • fast/loader/hashchange-event-async-expected.txt: Added.
  • fast/loader/hashchange-event-async.html: Added.

2010-05-03 Steven Lai <​steven_lai@asia.apple.com>

Reviewed by Brady Eidson.

Reverted hashchange() event back to async.
(This change does not update HashChangeEvent to its new proposed interface)
​https://bugs.webkit.org/show_bug.cgi?id=36201
rdar://problem/7780794
rdar://problem/7761278 (partial fix)

Tests: fast/loader/hashchange-event-async.html

  • dom/Document.cpp: reverted hashchange() event back to async (WebCore::Document::enqueueHashchangeEvent):
11:14 PM Changeset in webkit [58735] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-05-03 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

Fixed a recent REGRESSION that caused svn-apply and -unapply to
skip over changes to the first file in a diff if leading junk was
present (like in an e-mail diff) and if the --force option was used.

​https://bugs.webkit.org/show_bug.cgi?id=38507

  • Scripts/svn-apply:
    • Removed the bit of code at the beginning of the patch() subroutine that checks for the "Index:" line at the beginning of a file diff (since the parsePatch() subroutine already checks this).
  • Scripts/svn-unapply:
    • Removed the bit of code at the beginning of the patch() subroutine that checks for the "Index:" line at the beginning of a file diff (since the parsePatch() subroutine already checks this).
9:44 PM Changeset in webkit [58734] by zecke@webkit.org
  • 3 edits in trunk/WebCore

[Cairo,WX] Stop leaking a FontPlatformData.

Allocate the FontPlatformData on the stack and fix
a memory leak by doing so.

2010-05-03 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber-stamped by Xan Lopez.

[Cairo,WX] Stop leaking a FontPlatformData.
​https://bugs.webkit.org/show_bug.cgi?id=37500

Stephan Aßmus pointed out that the pango font backend
is leaking memory and fixed it. The WX font backend
and the Cairo/Fontconfig backend have the same snippet
of code and are leaking memory as well. This commit is
fixing that.

  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::smallCapsFontData):
  • platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::smallCapsFontData):
9:16 PM Changeset in webkit [58733] by Chris Jerdonek
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed.

Adjusted the ChangeLog entry below for r58732 (bug 35804) to reflect
the fact that the change will not become active until the patch
for bug 38454 lands.

9:00 PM Changeset in webkit [58732] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

2010-05-03 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

The svn-apply and svn-unapply scripts now display an instructive
error message if the --binary flag is left off the "git diff" command
for diffs containing binary file differences.

​https://bugs.webkit.org/show_bug.cgi?id=35804

  • Scripts/VCSUtils.pm:
    • Adjusted parseDiffHeader() to exit with an appropriate error message if it encounters a line of the form "Binary files <path1> and <path2> differ".
7:53 PM Changeset in webkit [58731] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests: r58728 broke the buildbot logic for parsing the
output of the log; specifying --verbose should basically be equivalent
to --print everything, but instead it was equivalent to not specifying
--print and getting the default set. Now, --verbose acts as if
--print everything was implicitly specified as the default (you can
still override it if you specify both; this is a somewhat debatable
call).

​https://bugs.webkit.org/show_bug.cgi?id=38504

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
7:39 PM Changeset in webkit [58730] by Stephanie Lewis
  • 2 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=38368
<rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028
(return memory quicker).
Instead of returning everything but the smallest spans spread out
the spans kept over several size lists.

Reviewed by Geoff Garen.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::scavenge):

7:26 PM Changeset in webkit [58729] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests: Fix minor precedence bug introduced in r58728 where we printed
"-\n" 78 times instead of "-" 78 times followed by a single "\n".

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
6:59 PM Changeset in webkit [58728] by dpranke@chromium.org
  • 6 edits
    2 adds in trunk/WebKitTools

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: refactor a large chunk of the printing/logging
code out of run-webkit-tests py (almost 300 lines out of 1900).

This change also renames --log to --print (to be slightly more
descriptive). I've also added better help messages for printing.

The new code has unit tests!

There is still more code to be moved, but this patch is big enough as
it is. Namely, still to move are the printing of the actual results
and the timing statistics, which should move another 300-400 lines
out of the file.

Notable changes to run_webkit_tests.py beyond code simply moving:

  • MeteredStream is now hidden under the new printing.Printer class. All the references to self._meter now point to self._printer.
  • All logging configuration is done in printing.configure_logging()
  • Instead of using write() lambdas to control what is and isn't printed, we use separate methods on the printer object. This will make it easier to grep which print statements are printed under protection of each flag.
  • The print_results flag I added a few revs back to suppress printing in the unit tests has been replaced with --print nothing.
  • The ResultSummary class now stores the entire TestResult for each test, not just the actual result type.
  • summarize_unexpected_results() got moved from a method on TestRunner to a standalone function. This should move into a separate file along with the ResultSummary class and the TestResult class
  • The --trace option added recently has been replaced by '--print trace-everything' and '--print trace-unexpected'

​https://bugs.webkit.org/show_bug.cgi?id=38018

  • Scripts/new-run-webkit-tests:
    • update to new entry points in run_webkit_tests.py
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
    • fix a minor nit where we were printing an empty string where we didn't need to
  • Scripts/webkitpy/layout_tests/layout_package/printing.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Added
  • Scripts/webkitpy/layout_tests/port/test.py:
    • implement relative_test_filename() and expected_filename() so we can test printing unexpected results in a platform-neutral way
  • Scripts/webkitpy/run_webkit_test.py:
    • move a lot of the printing code into printing.py
    • change the signatures of the exported entry points for easier unit testing
  • Scripts/webkitpy/run_webkit_tests_unittest.py:
    • update w/ changes to run_webkit_tests entry points.
6:55 PM Changeset in webkit [58727] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-05-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Expose HTMLTokenizer yielding parameters
​https://bugs.webkit.org/show_bug.cgi?id=37023

Enables to set TimeDelay and ChunkSize for
HTMLTokenizer.

  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent):
6:37 PM Changeset in webkit [58726] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Fix expectation for fast/forms/searchfield-heights.html - IMAGE+TEXT
on Linux, IMAGE on win and mac.

  • platform/chromium/test_expectations.txt:
6:32 PM Changeset in webkit [58725] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Restore editing/pasteboard/paste-xml.xhtml as failing w/ a TEXT
failure (was failing prior to landing fix for 27751).

Mark editiing/selection/caret-rtl-2.html as failing w/ IMAGE; need
to investigate further.

Mark svg/text/kerning.svg as failing on mac w/ IMAGE as well as Linux.

  • platform/chromium/test_expectations.txt:
6:08 PM Changeset in webkit [58724] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dirk Pranke.

Roll back test expectations change, initially needed to land bug 27751.

  • platform/chromium/test_expectations.txt:
5:45 PM Changeset in webkit [58723] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild

5:42 PM Changeset in webkit [58722] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Roll in Chromium expectations from overrides file.

  • platform/chromium/test_expectations.txt:
5:35 PM Changeset in webkit [58721] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark the SVG test failures as linux-only.
Mark fast/forms/searchfield-heights.html as IMAGE+TEXT, not IMAGE.

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [58720] by andersca@apple.com
  • 3 edits in trunk/WebKit2

2010-05-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon Honeycutt.

[WebKit2] WKView should respond to WM_SHOWWINDOW messages
​https://bugs.webkit.org/show_bug.cgi?id=38496

  • UIProcess/win/WebView.cpp: (WebKit::WebView::wndProc): Add case for WM_SHOWWINDOW.

(WebKit::WebView::onShowWindowEvent):
Update the page visibility accordingly.

  • UIProcess/win/WebView.h:
5:07 PM Changeset in webkit [58719] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

And add one more Linux test (fast/forms/search-placeholder-value-changed.html)
from r58700. Plus, fix sorting of tests from that rev.

  • platform/chromium/test_expectations.txt:
5:03 PM Changeset in webkit [58718] by jamesr@google.com
  • 6 edits in trunk

2010-05-03 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

Clean up a few compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=38073

  • wtf/text/StringImpl.cpp: (WebCore::StringImpl::ascii):

2010-05-03 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

Clean up a few compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=38073

  • html/TextMetrics.h: (WebCore::TextMetrics::width):
  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.h:
5:01 PM Changeset in webkit [58717] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark yet more mac-specific tests as failling from r58700.

  • platform/chromium/test_expectations.txt:
4:48 PM Changeset in webkit [58716] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark more tests as failing from r58700 and change the sandbox test from SLOW to a
flaky PASS TIMEOUT.

  • platform/chromium/test_expectations.txt:
4:43 PM Changeset in webkit [58715] by Darin Adler
  • 3 edits in trunk/WebKit
  • English.lproj/Localizable.strings: Regenerated.
  • StringsNotToBeLocalized.txt: Updated for recent changes.
4:09 PM Changeset in webkit [58714] by andersca@apple.com
  • 10 edits in trunk/WebKit2

2010-05-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of PageClient::isPageVisible and pass visibility directly in setPageIsVisible
​https://bugs.webkit.org/show_bug.cgi?id=38493

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: Remove isPageVisible.


  • UIProcess/API/mac/WKView.mm: (isViewVisible): New function (moved here from PageClientImpl).


(-[WKView _updateVisibility]):
Call didChangeVisibility.


(-[WKView viewDidMoveToWindow]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
Call _updateVisibility.


  • UIProcess/DrawingAreaProxy.h: Rename didChangeVisibility to setPageIsVisible and add an isVisible parameter.


  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: (WebKit::DrawingAreaProxyUpdateChunk::setPageIsVisible): Don't call WebPageProxy::isVisible.
  • UIProcess/DrawingAreaProxyUpdateChunk.h:


  • UIProcess/PageClient.h: Remove isPageVisible.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h: Remove isVisible.
4:07 PM Changeset in webkit [58713] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark more editing/* tests from r58703 as failing. Also, (re-?) add the SVG tests again
as they do fail on some platforms.

  • platform/chromium/test_expectations.txt:
4:03 PM Changeset in webkit [58712] by barraclough@apple.com
  • 16 edits
    1 delete in trunk/JavaScriptCore

Rolling out r58114 - this introduced memory leaks of
AtomicStrings then workers terminated.

Reviewed by NOBODY (reverting previous commit).

(JSC::ThunkHelpers::stringImplDataOffset):

  • runtime/Identifier.cpp:

(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierCStringTranslator::equal):
(JSC::IdentifierCStringTranslator::translate):
(JSC::Identifier::add):
(JSC::IdentifierUCharBufferTranslator::hash):
(JSC::IdentifierUCharBufferTranslator::equal):
(JSC::IdentifierUCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):

  • runtime/Identifier.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:
  • wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):

  • wtf/WTFThreadData.h:

(JSC::IdentifierTable::remove):
(JSC::IdentifierTable::literalTable):
(WTF::WTFThreadData::atomicStringTable):

  • wtf/text/AtomicString.cpp:

(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable):
(WebCore::CStringTranslator::hash):
(WebCore::CStringTranslator::equal):
(WebCore::CStringTranslator::translate):
(WebCore::operator==):
(WebCore::AtomicString::add):
(WebCore::equal):
(WebCore::UCharBufferTranslator::hash):
(WebCore::UCharBufferTranslator::equal):
(WebCore::UCharBufferTranslator::translate):
(WebCore::HashAndCharactersTranslator::hash):
(WebCore::HashAndCharactersTranslator::equal):
(WebCore::HashAndCharactersTranslator::translate):
(WebCore::AtomicString::find):
(WebCore::AtomicString::remove):

  • wtf/text/AtomicStringTable.h: Removed.
  • wtf/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
(WebCore::equal):

  • wtf/text/StringImplBase.h:

(WTF::StringImplBase::StringImplBase):

3:46 PM Changeset in webkit [58711] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittently on Qt bot
Fails caused by layoutTestController.display() in fast/frames/flattening/frameset-flattening-subframe-resize.html
​https://bugs.webkit.org/show_bug.cgi?id=37334

  • platform/qt/Skipped:
    • fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix
    • fast/frames/flattening/frameset-flattening-subframesets.html unskipped, because it works.
3:37 PM Changeset in webkit [58710] by dumi@chromium.org
  • 3 edits
    5 adds in trunk/WebCore

Add the ability to auto-generate callbacks to all code generators.
​https://bugs.webkit.org/show_bug.cgi?id=38414

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp: Added.

(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
(WebCore::JSTestCallback::callbackWithClass1Param):
(WebCore::JSTestCallback::callbackWithClass2Param):

  • bindings/scripts/test/JS/JSTestCallback.h: Added.

(WebCore::JSTestCallback::create):

  • bindings/scripts/test/V8/JSTestCallback.cpp: Added.

(WebCore::V8TestCallback::V8TestCallback):
(WebCore::V8TestCallback::~V8TestCallback):
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):

  • bindings/scripts/test/V8/V8TestCallback.h: Added.

(WebCore::V8TestCallback::create):

  • bindings/scripts/test/TestCallback.idl: Added.
3:37 PM Changeset in webkit [58709] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Kevin Ollivier.

[wx] Implement scheduleDispatchFunctionsOnMainThread for wx port.
​https://bugs.webkit.org/show_bug.cgi?id=38480

3:34 PM Changeset in webkit [58708] by kevino@webkit.org
  • 1 edit in trunk/WebKit/wx/ChangeLog

Fix missing bug URL.

3:31 PM Changeset in webkit [58707] by kevino@webkit.org
  • 23 edits
    1 add in trunk

Reviewed by Kevin Ollivier.

[wx] Build and use Mac's ComplexTextController to support complex text in wx.
​https://bugs.webkit.org/show_bug.cgi?id=38482

3:27 PM Changeset in webkit [58706] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark the editing/* tests from r58703 as temporarily expected to fail
until the other half of the two-sided patch can land.

  • platform/chromium/test_expectations.txt:
3:18 PM Changeset in webkit [58705] by oliver@apple.com
  • 4 edits in trunk

2010-05-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Interpreter crashes due to incorrect refcounting of cached structures.
​https://bugs.webkit.org/show_bug.cgi?id=38491
rdar://problem/7926160

Make sure we ref/deref structures used for cached custom property getters

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):

2010-05-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Interpreter crashes due to incorrect refcounting of cached structures.
​https://bugs.webkit.org/show_bug.cgi?id=38491

Add test for cached structure chains used for custom getters.

  • fast/js/pic/cached-named-property-getter.html:
2:51 PM Changeset in webkit [58704] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Fix duplicate expectation, remove the SVG tests added in r58700.

  • platform/chromium/test_expectations.txt:
2:50 PM Changeset in webkit [58703] by abarth@webkit.org
  • 43 edits
    3 adds in trunk

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Tests that javascript cannot access clipboard.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • editing/execCommand/clipboard-access-expected.txt: Added.
  • editing/execCommand/clipboard-access.html: Added.
  • editing/execCommand/script-tests/clipboard-access.js: Added. (enabled): (whenEnabled):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

Test: editing/execCommand/clipboard-access.html

  • WebCore.base.exp:
  • editing/EditorCommand.cpp: (WebCore::supportedCopyCut): (WebCore::supportedPaste): (WebCore::createCommandMap):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setJavaScriptCanAccessClipboard):
  • page/Settings.h: (WebCore::Settings::javaScriptCanAccessClipboard):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
  • src/WebSettingsImpl.h:

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences javaScriptCanAccessClipboard]): (-[WebPreferences setJavaScriptCanAccessClipboard:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::javaScriptCanAccessClipboard): (WebPreferences::setJavaScriptCanAccessClipboard):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is enabled in test framework.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • DumpRenderTree/LayoutTestController.cpp: (setJavaScriptCanAccessClipboardCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::overridePreference):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
2:43 PM Changeset in webkit [58702] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark a sandbox test as SLOW and change one of the fast/forms tests I
just changed from IMAGE+TEXT->IMAGE back to IMAGE.

  • platform/chromium/test_expectations.txt:
2:34 PM Changeset in webkit [58701] by andersca@apple.com
  • 4 edits in trunk/WebKitTools

2010-05-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Maui MiniBrowser: Add an option to show/hide the web view
​https://bugs.webkit.org/show_bug.cgi?id=38486

  • MiniBrowser/win/BrowserWindow.cpp: (BrowserWindow::createWindow): Set the background brush to something other than null.

(BrowserWindow::onCommand):
Show and hide the web view accordingly.


  • MiniBrowser/win/MiniBrowser.rc:
  • MiniBrowser/win/resource.h: Add new menu item.
2:15 PM Changeset in webkit [58700] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Change expectations for some of the fast/forms tests that just started
failing from IMAGE+TEXT to just IMAGE, and add some failing SVG tests
so that we can get the bots to green up.

  • platform/chromium/test_expectations.txt:
1:45 PM Changeset in webkit [58699] by eric@webkit.org
  • 5 edits in trunk/WebKit/wx

2010-05-03 Kevin Watters <​kevinwatters@gmail.com>

Reviewed by Kevin Ollivier.

Provide access to GrantUniversalAccess to allow enabling of XSS support.

  • WebFrame.cpp: (wxWebFrame::GrantUniversalAccess):
  • WebFrame.h:
  • WebView.cpp: (wxWebView::GetParseMode): (wxWebView::GrantUniversalAccess):
  • WebView.h:
1:36 PM Changeset in webkit [58698] by yaar@chromium.org
  • 6 edits in trunk/LayoutTests

2010-05-03 Yaar Schnitman <​yaar@chromium.org>

Not Reviewed.

Preparing for chromium webkit roll 58626:TBD: Rebaselines
​https://bugs.webkit.org/show_bug.cgi?id=38485

  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [58697] by andersca@apple.com
  • 4 edits in trunk/WebKit2

2010-05-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Implement PageClient::isPageVisible on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=38483

  • UIProcess/PageClient.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::isPageVisible):
  • UIProcess/win/WebView.h:
1:12 PM Changeset in webkit [58696] by ap@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed a typo in ChangeLog.

1:04 PM Changeset in webkit [58695] by ap@apple.com
  • 3 edits
    5 adds in trunk

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=38285
<rdar://problem/7903453> REGRESSION: Javascript command window.open does not work in empty tab

Cannot be tested, because new windows created in DRT always have an opener, and thus inherit
its security origin. Only new windows and tabs created by browser chrome had this problem.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Moved updateSandboxFlags() call to the beginning, so that an initial document would get correct flags.

LayoutTests:

These tests don't verify that this bug is fixed (that cannpt be tested automatically),
but test closely related behavior that hasn't been covered before.

  • http/tests/security/resources/iframe-no-src.html: Added.
  • http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt: Added.
  • http/tests/security/sandbox-inherit-to-initial-document-2.html: Added.
  • http/tests/security/sandbox-inherit-to-initial-document-expected.txt: Added.
  • http/tests/security/sandbox-inherit-to-initial-document.html: Added.
12:51 PM Changeset in webkit [58694] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-03 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Darin Adler.

WebGL compile issue.
Added ExceptionCode.h to JSWebGLArrayBufferConstructor.cpp, for some reason it was missing.
​https://bugs.webkit.org/show_bug.cgi?id=38453

No new tests: compile fix.

  • bindings/js/JSWebGLArrayBufferConstructor.cpp:
12:47 PM Changeset in webkit [58693] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Fix Windows build.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::sendOutgoingMessage):

  • Shared/win/UpdateChunk.cpp:

(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):

  • Shared/win/UpdateChunk.h:

(WebKit::UpdateChunk::rect):

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyUpdateChunk.h:
  • UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp:

(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):

  • WebProcess/WebPage/win/DrawingAreaUpdateChunkWin.cpp:

(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):

  • WebProcess/win/WebProcessMain.cpp:
12:11 PM Changeset in webkit [58692] by yaar@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Yaar Schnitman <​yaar@chromium.org>

Not Reviewed.

Preparing for Chromium WebKit roll 58626:TBD
​https://bugs.webkit.org/show_bug.cgi?id=38479

  • platform/chromium/test_expectations.txt: added missing expectation
11:51 AM Changeset in webkit [58691] by yaar@chromium.org
  • 9 edits
    4 adds in trunk/LayoutTests

2010-05-03 Yaar Schnitman <​yaar@chromium.org>

Not Reviewed.

Added missing chromium baselines for svg text kerning
​https://bugs.webkit.org/show_bug.cgi?id=38476

  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • platform/chromium-win/svg/text/kerning-expected.checksum:
  • platform/chromium-win/svg/text/kerning-expected.png:
  • platform/chromium-win/svg/text/text-hkern-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-hkern-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:49 AM Changeset in webkit [58690] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-03 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r58685.
​http://trac.webkit.org/changeset/58685
​https://bugs.webkit.org/show_bug.cgi?id=38461

Broke a test on Gtk

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates):
11:23 AM Changeset in webkit [58689] by yaar@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Yaar Schnitman <​yaar@chromium.org>

Not Reviewed.

Preparing for chromium webkit roll 58626:TBD
​https://bugs.webkit.org/show_bug.cgi?id=38474

  • platform/chromium/test_expectations.txt: Added temporary expectations.
11:19 AM Changeset in webkit [58688] by andersca@apple.com
  • 10 edits in trunk/WebKit2

2010-04-30 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=38415
Have the WKView notify the DrawingAreaProxy when its visibility changes.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::isPageVisible):
  • UIProcess/API/mac/WKView.mm: (-[WKView viewDidMoveToWindow]): (-[WKView viewDidHide]): (-[WKView viewDidUnhide]):
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: (WebKit::DrawingAreaProxyUpdateChunk::DrawingAreaProxyUpdateChunk): (WebKit::DrawingAreaProxyUpdateChunk::didChangeVisibility):
  • UIProcess/DrawingAreaProxyUpdateChunk.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::isVisible):
  • UIProcess/WebPageProxy.h:
11:16 AM Changeset in webkit [58687] by yael.aharon@nokia.com
  • 7 edits in trunk

Use HTML5 number parsing in HTMLProgressElement
​https://bugs.webkit.org/show_bug.cgi?id=38434

Reviewed by Darin Adler.

WebCore:

Use parseToDoubleForNumberType instead of toDouble.
Throw an exception when the number is NaN or Infinity.

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::value):
(WebCore::HTMLProgressElement::setValue):
(WebCore::HTMLProgressElement::max):
(WebCore::HTMLProgressElement::setMax):

  • html/HTMLProgressElement.h:
  • html/HTMLProgressElement.idl:

LayoutTests:

  • fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js:
  • fast/dom/HTMLProgressElement/set-progress-properties-expected.txt:
11:12 AM Changeset in webkit [58686] by eric@webkit.org
  • 24 edits in trunk

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareSubmit): Call frame loader's dispatchWillSendSubmitEvent
  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchWillSendSubmitEvent): New empty method

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • efl/WebCoreSupport/FrameLoaderClientEfl.h: (WebCore::FrameLoaderClientEfl::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • public/WebFrameClient.h: (WebKit::WebFrameClient::willSendSubmitEvent): New empty method
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillSendSubmitEvent): Delegate to client
  • src/FrameLoaderClientImpl.h:

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientGtk.h: (WebKit::FrameLoaderClient::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientHaiku.h: (WebCore::FrameLoaderClientHaiku::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/WebFrameLoaderClient.h: (WebFrameLoaderClient::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientQt.h: (WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebFrame.h:

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebKitSupport/FrameLoaderClientWx.h: (WebCore::FrameLoaderClientWx::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h: (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
10:58 AM Changeset in webkit [58685] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-05-03 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] forgotten call to durationChanged in updateStates()
​https://bugs.webkit.org/show_bug.cgi?id=38461

Notify MediaPlayer if duration is known after playback started.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates):
10:28 AM Changeset in webkit [58684] by weinig@apple.com
  • 9 edits
    1 add
    4 deletes in trunk/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38471
Add generic callback mechanism

Reviewed by Anders Carlsson.

Added GenericCallback class replacing RenderTreeExternalRepresentationCallback
and ScriptReturnValueCallback.

Also,

  • Standardize C API callbacks to take the context last.
  • Standardize C API callbacks to not have the _f suffix (now the block variants have a _b suffix).
  • Re-write toWK and toRef methods as a set of template functions using the generic API->implementation mapping information.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame):
(callRunJavaScriptBlockAndRelease):
(disposeRunJavaScriptBlock):
(WKPageRunJavaScriptInMainFrame_b):
(WKPageRenderTreeExternalRepresentation):
(WKPageRenderTreeExternalRepresentation_b):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/GenericCallback.h: Added.

(WebKit::GenericCallback::create):
(WebKit::GenericCallback::~GenericCallback):
(WebKit::GenericCallback::performCallbackWithReturnValue):
(WebKit::GenericCallback::invalidate):
(WebKit::GenericCallback::callbackID):
(WebKit::GenericCallback::generateCallbackID):
(WebKit::GenericCallback::GenericCallback):

  • UIProcess/RenderTreeExternalRepresentationCallback.cpp: Removed.
  • UIProcess/RenderTreeExternalRepresentationCallback.h: Removed.
  • UIProcess/ScriptReturnValueCallback.cpp: Removed.
  • UIProcess/ScriptReturnValueCallback.h: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::didGetRenderTreeExternalRepresentation):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
10:25 AM Changeset in webkit [58683] by abarth@webkit.org
  • 1 delete in trunk/URLCore

Remove URLCore top-level directory. The diff wasn't clear where this folder was going and Darin Adler would prefer that we not put this code in a top-level directory.

10:24 AM Changeset in webkit [58682] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-03 Ryuan Choi <​ryuan.choi@gmail.com>

Reviewed by Darin Adler.

fixing build break due to clearWatch() when Geolocation feature is
disabled.

​https://bugs.webkit.org/show_bug.cgi?id=38091

no test because this is a build fix only

  • page/Geolocation.cpp: (WebCore::Geolocation::clearWatch):
10:09 AM Changeset in webkit [58681] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-03 Chris Jerdonek <Chris Jerdonek>

Reviewed by Daniel Bates.

Added a parseGitDiffHeader() subroutine to VCSUtils.pm that
parses any changes to the executable bit in a Git diff.

​https://bugs.webkit.org/show_bug.cgi?id=38425

This revision is more preparation towards adding "executable bit"
support to svn-apply and svn-unapply. No code is going "live" in
this change except for the new unit tests in test-webkitperl.

  • Scripts/VCSUtils.pm:
    • Added isExecutable() to determine whether a file mode has the executable bit set or not.
    • Added parseGitDiffHeader() to parse the header of a Git diff.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Added.
    • Added unit tests for parseGitDiffHeader().
10:00 AM Changeset in webkit [58680] by abarth@webkit.org
  • 2 adds in trunk/URLCore

Add empty folder to house URL parser
​https://bugs.webkit.org/show_bug.cgi?id=38470

Reviewed by Darin Adler.

Add URLCore directory.

9:56 AM Changeset in webkit [58679] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-03 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by Holger Freyther.

[Gtk] Fix leaking the FontPlatformData instance used to create the the
small caps font data.
​https://bugs.webkit.org/show_bug.cgi?id=37500

No new tests needed.

  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::smallCapsFontData):
    • Use a stack allocated FontPlatformData instead of a heap allocated one that is never freed.
9:37 AM Changeset in webkit [58678] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-03 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: support webGL
​https://bugs.webkit.org/show_bug.cgi?id=35388

Added support GraphicsContext3D to GraphicsLayer.
Added paint method to GraphicsContext3D for Qt platform that
uses drawTexture() when QGLWidget is used as viewport of
QGraphicsWebView.
Fine-tuned texture and handling and image to texture conversion to
work also when drawTexture() blitting is used.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::paint): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::): (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsToGraphicsContext3D): (WebCore::GraphicsLayerQt::setGraphicsContext3DNeedsDisplay):
  • platform/graphics/qt/GraphicsLayerQt.h:
9:20 AM Changeset in webkit [58677] by abarth@webkit.org
  • 2 edits in trunk

2010-05-03 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add some more Chromium-specific files to gitignore
​https://bugs.webkit.org/show_bug.cgi?id=38469

These files are generated as part of the update-webkit --chromium
script.

  • .gitignore:
8:59 AM Changeset in webkit [58676] by Csaba Osztrogonác
  • 1 edit
    14 adds in trunk/LayoutTests

Unreviewed. Qt specific expected files added after r58675.

  • platform/qt/editing/pasteboard/4944770-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/5028447-expected.txt: Added.
  • platform/qt/editing/pasteboard/5089327-expected.txt: Added.
  • platform/qt/editing/pasteboard/5601583-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-text-013-expected.txt: Added.
  • platform/qt/editing/pasteboard/select-element-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/testcase-9507-expected.txt: Added.
  • platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
  • platform/qt/editing/pasteboard/unrendered-br-expected.txt: Added.
8:39 AM Changeset in webkit [58675] by robert@webkit.org
  • 105 edits
    4 adds in trunk/LayoutTests

2010-05-03 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed. Qt specific expected files added and updated.

[Qt] Unskip editing/pasteboard tests that fail due to 'x,y' differences
​https://bugs.webkit.org/show_bug.cgi?id=38435

  • platform/qt/editing/pasteboard/3976872-expected.txt:
  • platform/qt/editing/pasteboard/4076267-3-expected.txt:
  • platform/qt/editing/pasteboard/4242293-expected.txt:
  • platform/qt/editing/pasteboard/4631972-expected.txt:
  • platform/qt/editing/pasteboard/4641033-expected.txt:
  • platform/qt/editing/pasteboard/4700297-expected.txt:
  • platform/qt/editing/pasteboard/4806874-expected.txt:
  • platform/qt/editing/pasteboard/4840662-expected.txt:
  • platform/qt/editing/pasteboard/4944770-1-expected.txt:
  • platform/qt/editing/pasteboard/4944770-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/4989774-expected.txt:
  • platform/qt/editing/pasteboard/5006779-expected.txt:
  • platform/qt/editing/pasteboard/5027857-expected.txt:
  • platform/qt/editing/pasteboard/5028447-expected.txt: Added.
  • platform/qt/editing/pasteboard/5032095-expected.txt:
  • platform/qt/editing/pasteboard/5065605-expected.txt:
  • platform/qt/editing/pasteboard/5071074-2-expected.txt:
  • platform/qt/editing/pasteboard/5071074-expected.txt:
  • platform/qt/editing/pasteboard/5075944-2-expected.txt:
  • platform/qt/editing/pasteboard/5075944-3-expected.txt:
  • platform/qt/editing/pasteboard/5075944-expected.txt:
  • platform/qt/editing/pasteboard/5089327-expected.txt: Added.
  • platform/qt/editing/pasteboard/5134759-expected.txt:
  • platform/qt/editing/pasteboard/5156401-1-expected.txt:
  • platform/qt/editing/pasteboard/5245519-expected.txt:
  • platform/qt/editing/pasteboard/5247341-expected.txt:
  • platform/qt/editing/pasteboard/5368833-expected.txt:
  • platform/qt/editing/pasteboard/5478250-expected.txt:
  • platform/qt/editing/pasteboard/5483567-expected.txt:
  • platform/qt/editing/pasteboard/5601583-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/5780697-2-expected.txt:
  • platform/qt/editing/pasteboard/7955-expected.txt:
  • platform/qt/editing/pasteboard/8145-1-expected.txt:
  • platform/qt/editing/pasteboard/8145-2-expected.txt:
  • platform/qt/editing/pasteboard/8145-3-expected.txt:
  • platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
  • platform/qt/editing/pasteboard/cut-text-001-expected.txt:
  • platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/displaced-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/display-block-on-spans-expected.txt:
  • platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
  • platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-1-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-3-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-4-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-3-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-4-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-5-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-list-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-table-expected.txt:
  • platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/merge-start-list-expected.txt:
  • platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-4038267-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-1-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-2-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-3-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-line-endings-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-004-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/qt/editing/pasteboard/paste-list-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-pre-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-pre-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-cells-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-004-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-009-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-010-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-011-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-012-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-013-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-text-014-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-015-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-016-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-017-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-018-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-019-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
  • platform/qt/editing/pasteboard/pasting-object-expected.txt:
  • platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
  • platform/qt/editing/pasteboard/quirks-mode-br-1-expected.txt:
  • platform/qt/editing/pasteboard/select-element-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/styled-element-markup-expected.txt:
  • platform/qt/editing/pasteboard/testcase-9507-expected.txt: Added.
  • platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
  • platform/qt/editing/pasteboard/unrendered-br-expected.txt: Added.

2010-05-03 Robert Hogan <​robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Unskip editing/pasteboard tests that fail due to 'x,y' differences

​https://bugs.webkit.org/show_bug.cgi?id=38435

Unskip a large number of editing/pasteboard tests that fail only due
to rendertree differences in the height/width of rendered text.

Reduce the skipped editing/pasteboard tests to those that fail for
a good reason and add some initial commentary on each.

Unskip:

editing/pasteboard/3976872.html
editing/pasteboard/4076267-3.html
editing/pasteboard/4242293.html
editing/pasteboard/4631972.html
editing/pasteboard/4641033.html
editing/pasteboard/4700297.html
editing/pasteboard/4840662.html
editing/pasteboard/4944770-1.html
editing/pasteboard/4944770-2.html
editing/pasteboard/4989774.html
editing/pasteboard/5006779.html
editing/pasteboard/5027857.html
editing/pasteboard/5028447.html
editing/pasteboard/5032095.html
editing/pasteboard/5065605.html
editing/pasteboard/5071074-2.html
editing/pasteboard/5071074.html
editing/pasteboard/5075944-2.html
editing/pasteboard/5075944-3.html
editing/pasteboard/5075944.html
editing/pasteboard/5089327.html
editing/pasteboard/5134759.html
editing/pasteboard/5156401-1.html
editing/pasteboard/5245519.html
editing/pasteboard/5247341.html
editing/pasteboard/5368833.html
editing/pasteboard/5478250.html
editing/pasteboard/5483567.html
editing/pasteboard/5601583-1.html
editing/pasteboard/5780697-2.html
editing/pasteboard/7955.html
editing/pasteboard/8145-1.html
editing/pasteboard/8145-2.html
editing/pasteboard/8145-3.html
editing/pasteboard/copy-paste-bidi.html
editing/pasteboard/cut-text-001.html
editing/pasteboard/displaced-generic-placeholder.html
editing/pasteboard/displaced-placeholder.html
editing/pasteboard/display-block-on-spans.html
editing/pasteboard/emacs-cntl-y-001.html
editing/pasteboard/innerText-inline-table.html
editing/pasteboard/interchange-newline-1.html
editing/pasteboard/interchange-newline-3.html
editing/pasteboard/interchange-newline-4.html
editing/pasteboard/merge-after-delete-1.html
editing/pasteboard/merge-after-delete-2.html
editing/pasteboard/merge-after-delete.html
editing/pasteboard/merge-end-1.html
editing/pasteboard/merge-end-2.html
editing/pasteboard/merge-end-3.html
editing/pasteboard/merge-end-4.html
editing/pasteboard/merge-end-5.html
editing/pasteboard/merge-end-blockquote.html
editing/pasteboard/merge-end-borders.html
editing/pasteboard/merge-end-list.html
editing/pasteboard/merge-end-table.html
editing/pasteboard/merge-start-blockquote.html
editing/pasteboard/merge-start-list.html
editing/pasteboard/paste-4035648-fix.html
editing/pasteboard/paste-4038267-fix.html
editing/pasteboard/paste-4039777-fix.html
editing/pasteboard/paste-blockquote-1.html
editing/pasteboard/paste-blockquote-2.html
editing/pasteboard/paste-blockquote-3.html
editing/pasteboard/paste-blockquote-after-blockquote.html
editing/pasteboard/paste-blockquote-into-blockquote-2.html
editing/pasteboard/paste-blockquote-into-blockquote-3.html
editing/pasteboard/paste-blockquote-into-blockquote-4.html
editing/pasteboard/paste-blockquote-into-blockquote.html
editing/pasteboard/paste-line-endings-001.html
editing/pasteboard/paste-line-endings-002.html
editing/pasteboard/paste-line-endings-003.html
editing/pasteboard/paste-line-endings-004.html
editing/pasteboard/paste-line-endings-005.html
editing/pasteboard/paste-line-endings-006.html
editing/pasteboard/paste-line-endings-007.html
editing/pasteboard/paste-line-endings-008.html
editing/pasteboard/paste-line-endings-009.html
editing/pasteboard/paste-line-endings-010.html
editing/pasteboard/paste-list-001.html
editing/pasteboard/paste-match-style-001.html
editing/pasteboard/paste-match-style-002.html
editing/pasteboard/paste-pre-001.html
editing/pasteboard/paste-pre-002.html
editing/pasteboard/paste-table-001.html
editing/pasteboard/paste-table-003.html
editing/pasteboard/paste-table-cells.html
editing/pasteboard/paste-text-002.html
editing/pasteboard/paste-text-003.html
editing/pasteboard/paste-text-004.html
editing/pasteboard/paste-text-005.html
editing/pasteboard/paste-text-006.html
editing/pasteboard/paste-text-007.html
editing/pasteboard/paste-text-009.html
editing/pasteboard/paste-text-010.html
editing/pasteboard/paste-text-011.html
editing/pasteboard/paste-text-012.html
editing/pasteboard/paste-text-013.html
editing/pasteboard/paste-text-014.html
editing/pasteboard/paste-text-015.html
editing/pasteboard/paste-text-016.html
editing/pasteboard/paste-text-017.html
editing/pasteboard/paste-text-018.html
editing/pasteboard/paste-text-019.html
editing/pasteboard/paste-text-at-tabspan-002.html
editing/pasteboard/paste-text-at-tabspan-003.html
editing/pasteboard/paste-unrendered-select.html
editing/pasteboard/pasting-object.html
editing/pasteboard/prevent-block-nesting-01.html
editing/pasteboard/quirks-mode-br-1.html
editing/pasteboard/select-element-1.html
editing/pasteboard/styled-element-markup.html
editing/pasteboard/testcase-9507.html
editing/pasteboard/undoable-fragment-removes.html
editing/pasteboard/unrendered-br.html

  • platform/qt/Skipped:
8:18 AM Changeset in webkit [58674] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-05-03 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Csaba Osztrogonac.

media/video-duration-known-after-eos.html failing
​https://bugs.webkit.org/show_bug.cgi?id=38466

  • platform/qt/Skipped: Skipping failing test. A lot of media tests are already skipped on this platform. Tor Arne said he'd look at them, at some point.
7:13 AM Changeset in webkit [58673] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix qtlibraryinfix not to contain space

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2010-05-03
Reviewed by Simon Hausmann.

List catenation with += adds whitespace cutting the infix
from the final target.

  • WebCore.pro:
7:10 AM Changeset in webkit [58672] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix rendering of <button> elements on Mac OS X

Reviewed by Simon Hausmann.

The <button> element has ButtonPart appearance, not PushButton part,
so we have to include ButtonPart when we decide if we should draw the
button as raised on Mac OS X.

7:09 AM Changeset in webkit [58671] by Philippe Normand
  • 3 edits
    2 adds in trunk

2010-04-30 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] endless loop after playback ended
​https://bugs.webkit.org/show_bug.cgi?id=38384

At playback end ensure duration() will return a valid duration if
we managed to calculate it based on current position.

Test: media/video-duration-known-after-eos.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::didEnd):

2010-04-30 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] endless loop after playback ended
​https://bugs.webkit.org/show_bug.cgi?id=38384

  • media/video-duration-known-after-eos-expected.txt: Added.
  • media/video-duration-known-after-eos.html: Added.
5:00 AM Changeset in webkit [58670] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Prune dead code in QWebPage

Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:
4:17 AM Changeset in webkit [58669] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Fix build break on Mac OS X

  • plugins/mac/PluginPackageMac.cpp: Use correct type
  • WebCore.pro: Remove duplicate symbol, we now have a Qt implementation
4:00 AM Changeset in webkit [58668] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-03 Daniel Bates <​dbates@rim.com>

Reviewed by Chris Jerdonek.

​https://bugs.webkit.org/show_bug.cgi?id=38447

Refactor the unit tests in VCSUtils_unittest/parseDiff.pl to use
Test::More::is_deeply like we do in VCSUtils_unittest/parseDiffHeader.pl.

  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2:09 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:57 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:22 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:16 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:15 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
12:59 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
12:12 AM Changeset in webkit [58667] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix library infix usage when compiling inside of Qt

Patch by Thomas Zander <​t.zander@nokia.com> on 2010-05-03
Reviewed by Simon Hausmann.

Don't apply the infix when building inside Qt, as that's done through the
inclusion of qbase.pri.

  • WebCore.pro:
Note: See TracTimeline for information about the timeline view.