Timeline
May 10, 2010:
- 11:43 PM Changeset in webkit [59143] by
-
- 2 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Fix asserting GTK build.
r59137 changed the behavior of RenderObject::repaintUsingContainer(). I mistakenly
thought that non-compositing builds would always pass a 0 repaintContainer, but
actually the RenderView is passed in this case. So use this to repaint if
ACCELERATED_COMPOSITING is turned off.
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):
- 11:32 PM Changeset in webkit [59142] by
-
- 2 edits in trunk/LayoutTests
2010-05-10 Simon Fraser <Simon Fraser>
Skip two new flakey tests:
# Tests are flakey: https://bugs.webkit.org/show_bug.cgi?id=38888
compositing/iframes/iframe-resize.html
compositing/iframes/overlapped-iframe.html
- platform/mac/Skipped:
- 11:22 PM Changeset in webkit [59141] by
-
- 3 edits in trunk/LayoutTests
2010-05-10 Simon Fraser <Simon Fraser>
No review; attempt to fix failing tests.
Increase the timeout to give compositing updates a chance to happen.
- compositing/iframes/iframe-resize.html:
- compositing/iframes/overlapped-iframe.html:
- 11:08 PM QtWebKitTriageRoster edited by
- (diff)
- 11:06 PM Changeset in webkit [59140] by
-
- 2 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Fix warning on Windows about unreachable code.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
- 11:05 PM Changeset in webkit [59139] by
-
- 3 edits in trunk/LayoutTests
2010-05-10 Simon Fraser <Simon Fraser>
No review.
Reduce timeouts from 500 to 50ms to make the tests run more quickly.
- compositing/iframes/resources/enter-compositing-subframe.html:
- compositing/iframes/resources/leave-compositing-subframe.html:
- 10:47 PM Changeset in webkit [59138] by
-
- 2 edits in trunk/WebKit/mac
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
When painting an iframe into a compositing layer, the "PaintBehaviorFlattenCompositingLayers"
flag was mistakenly set, because we'd detect that we were drawing into a bitmap. This caused
content to show up in both compositing layers, and the painted background inside the iframe.
Fix by taking the flattening state from the parent frame, if there is one. For the root
frame, we continue to look to see if we're painting into a bitmap.
- WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]):
- 10:47 PM Changeset in webkit [59137] by
-
- 2 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
RenderObject::repaintUsingContainer() incorrectly did a view-based
repaint if the repaint container was the RenderView. Instead, we need
to check to see if the RenderView's layer is composited, and, if so,
whether it's painting into the window or not. This can occur when iframes
are composited.
The bug is timing-sensitive, involving compositing in iframes, and I was not able to
concoct a good testcase.
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):
- 10:44 PM Changeset in webkit [59136] by
-
- 16 edits3 copies4 adds1 delete in trunk
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Changes to allow compositing layers for iframes to switch between being hosted
by the iframe's layer-backed NSView, and parented in the GraphicsLayer tree of the
enclosing document.
Tests: compositing/iframes/connect-compositing-iframe.html
compositing/iframes/connect-compositing-iframe2.html
compositing/iframes/connect-compositing-iframe3.html
- page/FrameView.h:
- page/FrameView.cpp: (WebCore::FrameView::hasCompositedContent): New convenience method. (WebCore::FrameView::setIsOverlapped): If we're composited, poke the owner document in case it
wants to re-evaluate compositing decisions.
(WebCore::FrameView::isOverlapped): Just expose the existing flag.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): If this is an iframe, we need
to ensure that the layers for the iframe content are hooked up.
(WebCore::RenderLayerBacking::updateDrawsContent): When an iframe toggles between different
attachments, the 'drawsContent' behavior of its root layer changes, so needs to be updated.
- rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::updateCompositingLayers): Call destroyRootPlatformLayer()
instead of detachRootPlatformLayer() and manually zeroing out the OwnPtrs.
(WebCore::RenderLayerCompositor::updateBacking): If a RenderIFrame changes compositing mode,
we need to ensure that its content compositor attachment is updated.
(WebCore::RenderLayerCompositor::repaintOnCompositingChange): The existing code had a bug
that caused repaints for RenderViews (which have no parent) to bail. We only want to bail
for non-RenderViews that are not attached.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Factored the iframe-connecting
code into a new method, parentIFrameContentLayers().
(WebCore::RenderLayerCompositor::parentIFrameContentLayers): New method to share the code that hooks
up the iframe's compositing layers to the parent.
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Add logic to propagate
compositing out of iframes on Mac in two situations: 1) when the FrameView is overlapped, and 2)
if the parent document is already composited.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Clean up the logic here to better deal
with dynamic changes of the attachment type.
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Clean up and null out the clipping layer here.
(WebCore::RenderLayerCompositor::attachRootPlatformLayer): Call rootLayerAttachmentChanged().
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Ditto. Also unparent the clipping and platform layers.
(WebCore::RenderLayerCompositor::updateRootLayerAttachment): Call ensureRootPlatformLayer() to re-evaluate
the layer attachment.
(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged): We need to update the drawsContent() status
of the RenderView's layer's backing, because it changes depending on the attachment.
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Do overlap testing if the frameView can do fast repaints (as before),
but also now when the frameView has composited content.
- 10:37 PM Changeset in webkit [59135] by
-
- 1 edit6 adds in trunk/LayoutTests
Adding a test that makes sure openDatabaseSync() deals correctly with invalid inputs.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Brady Eidson.
- fast/workers/storage: Added.
- fast/workers/storage/open-database-sync-inputs-expected.txt: Added.
- fast/workers/storage/open-database-sync-inputs.html: Added.
- fast/workers/storage/resources: Added.
- fast/workers/storage/resources/open-database-sync-inputs.js: Added.
(notAString.toString):
- fast/workers/storage/resources/test-inputs-common.js: Added.
(log):
(finishTest):
(runTest.worker.onmessage):
(runTest):
- 10:34 PM Changeset in webkit [59134] by
-
- 4 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Rename the static shouldPropagateCompositingToIFrameParent() to shouldPropagateCompositingToEnclosingIFrame(),
to pave the way for runtime switches in the propagation behavior. We have to make sure we call it on
the correct RenderLayerCompositor (that belonging to the iframe's content document).
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintingGoesToWindow): Now that we know the root layer attachment, we can simplify this method.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): No need for the setNeedsStyleRecalc() here, because the ensureRootPlatformLayer() or destroyRootPlatformLayer() will have already done it.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Use the root layer attachment to determine
whether to parent the iframe's layers.
(WebCore::RenderLayerCompositor::didMoveOnscreen): Method name change.
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Name change.
(WebCore::RenderLayerCompositor::requiresCompositingForIFrame): We need to consult the iframe contents
document's compositor to ask whether propagation is appropriate.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Name change.
- 10:33 PM Changeset in webkit [59133] by
-
- 3 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Use an enum for the type of root layer attachment on a RenderLayerCompositor, so we can
determine if the attachment is via the ChromeClient, via an enclosing iframe, or unattached.
- rendering/RenderLayerCompositor.h: New RootLayerAttachment enum. (WebCore::RenderLayerCompositor::rootLayerAttachment): getter for the current attachment.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): Init m_rootLayerAttachment. (WebCore::RenderLayerCompositor::~RenderLayerCompositor): Assert that is unattached. (WebCore::RenderLayerCompositor::updateCompositingLayers): Call destroyRootPlatformLayer instead of willMoveOffscreen, when there are no layers left. Also clear out the clipping layer. (WebCore::RenderLayerCompositor::didMoveOnscreen): Call attachRootPlatformLayer. (WebCore::RenderLayerCompositor::willMoveOffscreen): Call ensureRootPlatformLayer with the appropriate attachment. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Only create the m_rootPlatformLayer if we don't have one
already, but be sure to always set the root layer geometry orientation. Also only create the
m_clippingLayer if we need to.
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Call detachRootPlatformLayer().
(WebCore::RenderLayerCompositor::attachRootPlatformLayer): Code moved from didMoveOnscreen, but switching on
attachment.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Code moved from willMoveOffscreen, but switching on
attachment.
- 10:27 PM Changeset in webkit [59132] by
-
- 2 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Clean up the geometry logic when propagating compositing out of iframes.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition): Geometry on m_rootPlatformLayer no longer needs to be special when there's a clipping layer.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Don't set the clipping layer to have
flipped geometry ever, and only set the root layer to have flipped geometry if it is not
being hosted in an iframe. Also no need to set a custom anchor point on the clipping layer.
- 10:22 PM Changeset in webkit [59131] by
-
- 5 edits in trunk/LayoutTests
2010-05-10 Simon Fraser <Simon Fraser>
Fix up test results from last commit, which were generated with a build from before r59129.
- platform/win/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/win/compositing/iframes/iframe-resize-expected.txt:
- platform/win/compositing/iframes/leave-compositing-iframe-expected.txt:
- platform/win/compositing/iframes/overlapped-iframe-expected.txt:
- 10:12 PM Changeset in webkit [59130] by
-
- 1 edit1 copy1 move11 adds1 delete in trunk/LayoutTests
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=38856
Allow compositing layers to be connected across iframe boundaries on Mac
Add several more iframe-compositing-related tests. These tests:
- an iframe dynamically entering compositing mode
- an iframe dynamically leaving compositing mode
- an overlapped iframe
- a compositing iframe being resized
composited-iframe.html had no value and is removed.
- compositing/iframes/composited-iframe-expected.txt: Removed.
- compositing/iframes/composited-iframe.html: Removed.
- compositing/iframes/enter-compositing-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
- compositing/iframes/enter-compositing-iframe.html: Added.
- compositing/iframes/iframe-resize-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
- compositing/iframes/iframe-resize.html: Added.
- compositing/iframes/leave-compositing-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
- compositing/iframes/leave-compositing-iframe.html: Added.
- compositing/iframes/overlapped-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
- compositing/iframes/overlapped-iframe.html: Added.
- compositing/iframes/resources/enter-compositing-subframe.html: Added.
- compositing/iframes/resources/leave-compositing-subframe.html: Added.
- platform/win/compositing/iframes/iframe-resize-expected.txt: Added.
- platform/win/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
- platform/win/compositing/iframes/overlapped-iframe-expected.txt: Added.
- 10:08 PM Changeset in webkit [59129] by
-
- 5 edits in trunk/WebCore
2010-05-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Clean up some methods related to composited iframes. No behavioral changes.
- rendering/RenderLayerBacking.h: Move innerRenderLayerCompositor() to be a static method:
RenderLayerCompositor::iframeContentsCompositor().
- rendering/RenderLayerBacking.cpp: Remove innerRenderLayerCompositor(). (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call iframeContentsCompositor().
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): Call enclosingIFrameElement() (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): iframeContentsCompositor() is now a static method in this class. Also check that the iframe contents are in compositing mode (slightly clearer than relying on rootPlatformLayer() returning null). (WebCore::RenderLayerCompositor::iframeContentsCompositor): Moved from RenderLayerBacking. (WebCore::RenderLayerCompositor::didMoveOnscreen): Use enclosingIFrameElement() method. (WebCore::RenderLayerCompositor::willMoveOffscreen): Ditto. (WebCore::RenderLayerCompositor::enclosingIFrameElement): New method. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Call enclosingIFrameElement().
- rendering/RenderLayerCompositor.h: New method, iframeContentsCompositor().
- 10:06 PM Changeset in webkit [59128] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Final set of baselines and expectations to green up the build.
- platform/chromium-mac/plugins/geturlnotify-during-document-teardown-expected.txt: Added.
- platform/chromium-win/plugins/geturlnotify-during-document-teardown-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 9:49 PM Changeset in webkit [59127] by
-
- 114 edits4 adds in trunk/LayoutTests
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] rebaseline SVG test for windows after recent changes.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
- platform/chromium-win/svg/batik/filters/feTile-expected.png:
- platform/chromium-win/svg/batik/filters/feTile-expected.txt:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.checksum:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
- platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
- platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
- platform/chromium-win/svg/batik/text/textEffect-expected.png: Added.
- platform/chromium-win/svg/batik/text/textEffect-expected.txt:
- platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
- platform/chromium-win/svg/batik/text/textEffect3-expected.png: Added.
- platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
- platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
- platform/chromium-win/svg/batik/text/textProperties-expected.txt:
- platform/chromium-win/svg/custom/empty-mask-expected.txt:
- platform/chromium-win/svg/custom/empty-merge-expected.checksum:
- platform/chromium-win/svg/custom/empty-merge-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
- platform/chromium-win/svg/custom/feDisplacementMap-01-expected.checksum:
- platform/chromium-win/svg/custom/feDisplacementMap-01-expected.png:
- platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.checksum:
- platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/chromium-win/svg/custom/invalid-css-expected.txt:
- platform/chromium-win/svg/custom/mask-invalidation-expected.txt:
- platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
- platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.checksum:
- platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
- platform/chromium-win/svg/custom/text-filter-expected.checksum:
- platform/chromium-win/svg/custom/text-filter-expected.png:
- platform/chromium-win/svg/custom/text-filter-expected.txt:
- platform/chromium-win/svg/custom/visibility-override-filter-expected.checksum:
- platform/chromium-win/svg/custom/visibility-override-filter-expected.png:
- platform/chromium-win/svg/filters/big-sized-filter-2-expected.checksum:
- platform/chromium-win/svg/filters/big-sized-filter-2-expected.png:
- platform/chromium-win/svg/filters/big-sized-filter-expected.checksum:
- platform/chromium-win/svg/filters/big-sized-filter-expected.png:
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum:
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.png:
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
- platform/chromium-win/svg/filters/feComposite-expected.checksum:
- platform/chromium-win/svg/filters/feComposite-expected.png:
- platform/chromium-win/svg/filters/feComposite-expected.txt:
- platform/chromium-win/svg/filters/feGaussianBlur-expected.checksum:
- platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
- platform/chromium-win/svg/filters/feMerge-expected.checksum:
- platform/chromium-win/svg/filters/feMerge-expected.png:
- platform/chromium-win/svg/filters/feOffset-expected.checksum:
- platform/chromium-win/svg/filters/feOffset-expected.png:
- platform/chromium-win/svg/filters/feTile-expected.checksum:
- platform/chromium-win/svg/filters/feTile-expected.png:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.checksum:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.checksum:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
- platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
- platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.checksum:
- platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.png:
- platform/chromium-win/svg/filters/subRegion-one-effect-expected.checksum:
- platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
- platform/chromium-win/svg/filters/subRegion-two-effects-expected.checksum:
- platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
- platform/chromium-win/svg/text/text-vkern-expected.checksum: Added.
- platform/chromium-win/svg/text/text-vkern-expected.png: Added.
- 9:12 PM Changeset in webkit [59126] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fixing the expectations for Chromium.
- platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
- 8:51 PM Changeset in webkit [59125] by
-
- 3 edits in trunk/WebKit/mac
Fix a crash when closing a WebView while the Web Inspector is open.
<rdar://problem/7966830>
Reviewed by Mark Rowe.
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController destroyInspectorView]): Null check Page since it can be null.
- WebView/WebView.mm:
(-[WebView _close]): Null out _private->page before deleting the page, so code called
during destruction don't access a half deleted Page object.
- 8:45 PM Changeset in webkit [59124] by
-
- 6 edits1 add1 delete in trunk
2010-05-10 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Build DRT when running build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=38730
This allows DRT to use the same .o and .lib files when building
on Windows.
- WebKit.gyp: Move DRT.gyp targets into this file.
- gyp_webkit: DRT.gyp is gone
2010-05-10 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Build DRT when running build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=38730
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
- Scripts/build-dumprendertree: This does nothing now.
- 8:40 PM Changeset in webkit [59123] by
-
- 2 edits in trunk/LayoutTests
2010-05-10 Eric Seidel <eric@webkit.org>
Unreviewed, just removing newline from -expected.txt file
REGRESSION(r59100): "Added test is broken on many platforms." (Requested by eseidel on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=38881
Looks like http://trac.webkit.org/changeset/59119
added an extra newline by mistake. Removing.
- plugins/geturlnotify-during-document-teardown-expected.txt:
- 7:54 PM Changeset in webkit [59122] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fixing Qt's expectations.
- platform/qt/http/tests/security/cross-frame-access-call-expected.txt:
- 7:39 PM Changeset in webkit [59121] by
-
- 1 edit in trunk/WebCore/ChangeLog
Remove conflict markers from ChangeLog
- 7:35 PM Changeset in webkit [59120] by
-
- 3 edits in trunk/LayoutTests
REGRESSION(r59100): Added test is broken on many platforms.
https://bugs.webkit.org/show_bug.cgi?id=38881
Reviewed by Eric Seidel.
- platform/mac-snowleopard/Skipped:
Skipped, because we're not logging NPP_Destroy on Snow Leopard.
- platform/qt/Skipped:
Skipped due to lack of support for setCallCloseOnWebViews on
LayoutTestController.
- 7:35 PM Changeset in webkit [59119] by
-
- 4 edits in trunk
REGRESSION(r59100): Added test is broken on many platforms.
https://bugs.webkit.org/show_bug.cgi?id=38881
Reviewed by Eric Seidel.
WebKitTools:
- DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_Destroy):
Use pluginLog, rather than printf, to match other platforms.
LayoutTests:
- plugins/geturlnotify-during-document-teardown-expected.txt:
Update the expected result.
- 7:06 PM Changeset in webkit [59118] by
-
- 7 edits1 move3 adds2 deletes in trunk
WebCore: Cleaning up and fixing the existing JSC DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Brady Eidson.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
- bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabase::transaction):
(WebCore::JSDatabase::readTransaction):
- bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
LayoutTests: Fixing the expectations for openDatabase() in cross-frame-access-call.html.
Related to changes in patches #6 and #7 at https://bugs.webkit.org/show_bug.cgi?id=34994.
Reviewed by Brady Eidson.
- http/tests/security/cross-frame-access-call-expected.txt:
- http/tests/security/cross-frame-access-call.html:
- platform/chromium-linux/http/tests/security/cross-frame-access-call-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/cross-frame-access-call-expected.txt: Removed.
- platform/chromium-win/http/tests/security/cross-frame-access-call-expected.txt: Removed.
- platform/chromium/http: Added.
- platform/chromium/http/tests: Added.
- platform/chromium/http/tests/security: Added.
- platform/chromium/http/tests/security/cross-frame-access-call-expected.txt: Copied from LayoutTests/platform/chromium-win/http/tests/security/cross-frame-access-call-expected.txt.
- 6:52 PM Changeset in webkit [59117] by
-
- 2 edits in trunk/WebKitTools
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Fix a build failure caused by assuming the default platform in
a unit test for new-run-webkit-tests instead of specifying
--platform test.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 6:50 PM Changeset in webkit [59116] by
-
- 9 edits in trunk/WebCore
2010-05-10 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket needs to suspend/resume as Active DOM object.
https://bugs.webkit.org/show_bug.cgi?id=38171
Implement suspend()/resume() in WebSocket and WebSocketChannel.
While WebSocketChannel is suspended, it only adds received data in m_buffer
or record the handle was closed, and report no event to WebSocket.
When resumed, it will process buffer or handle closing.
Since suspend/resume would be called while processing JavaScript event handler (e.g. before/after alert()), WebSocketChannel method that would fire an event need to be reentrant.
So, WebSocketChannel::processBuffer() call WebSocket to fire an event at most once and skips buffer before the calling,
so that next call of processBuffer() would process the next frame.
- websockets/ThreadableWebSocketChannel.h:
- websockets/ThreadableWebSocketChannelClientWrapper.h: (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect): Mark channel is opened, and process pending events if not suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage): Push message back in pending queue, and process pending events if not suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): Mark channel is closed, and process pending events if not suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::suspend): Mark suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::resume): Unmark suspended, and process pending events. (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
- websockets/WebSocket.cpp: (WebCore::WebSocket::canSuspend): (WebCore::WebSocket::suspend): (WebCore::WebSocket::resume): (WebCore::WebSocket::didClose):
- websockets/WebSocket.h:
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::connect): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::close): (WebCore::WebSocketChannel::suspend): (WebCore::WebSocketChannel::resume): When resumed, it will process buffer and handle closing if handle was already closed while suspended. (WebCore::WebSocketChannel::didClose): If suspended, record unhandled bufferedAmount and set m_closed true, so that closing will be processed when resumed. (WebCore::WebSocketChannel::didReceiveData): Add received data in buffer and process buffer while it is not suspended. (WebCore::WebSocketChannel::processBuffer): Process handshake header or one frame message. Return true if there are more data to be processed. Return false otherwise (e.g. incomplete handshake header or incomplete frame).
- websockets/WebSocketChannel.h:
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::suspend): (WebCore::WorkerThreadableWebSocketChannel::resume): (WebCore::WorkerThreadableWebSocketChannel::Peer::suspend): (WebCore::WorkerThreadableWebSocketChannel::Peer::resume): (WebCore::WorkerThreadableWebSocketChannel::mainThreadSuspend): (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend): (WebCore::WorkerThreadableWebSocketChannel::mainThreadResume): (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
- websockets/WorkerThreadableWebSocketChannel.h:
- 6:45 PM Changeset in webkit [59115] by
-
- 2 edits in trunk/LayoutTests
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Fix sort order for expectations after previous change.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- 6:30 PM Changeset in webkit [59114] by
-
- 2 edits in trunk/WebKitTools
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build-fix
new-run-webkit-tests: fix test failure caused by me failing to update
the expected output. Also, run '--platform test' instead of
'platform dryrun' since the former is guaranteed to work and the
latter isn't.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 6:18 PM Changeset in webkit [59113] by
-
- 4 edits in trunk/WebCore
Implement the JSC bindings for the sync DB API.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Brady Eidson.
- bindings/js/JSDatabaseSyncCustom.cpp:
(WebCore::JSDatabaseSync::changeVersion):
(WebCore::createTransaction):
- bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql):
- 6:07 PM Changeset in webkit [59112] by
-
- 2 edits in trunk/LayoutTests
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Unreviewed, test expectation change for Chromium following r59010.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- 5:44 PM Changeset in webkit [59111] by
-
- 4 edits2 adds in trunk
2010-05-10 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=36566
The animation-fill-mode property was missing from
a few places where the animation shorthand is set up.
Test: animations/animation-shorthand-removed.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Make sure animation-fill-mode is included in the animation shorthand
- css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
- 5:10 PM Changeset in webkit [59110] by
-
- 5 edits4 adds in trunk/WebKit/chromium
2010-05-10 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add WebKitScrollbar interface to allow Chromium code to reuse the scrollbar code
https://bugs.webkit.org/show_bug.cgi?id=38854
- public/WebScrollbar.h: Added. (WebKit::WebScrollbar::): (WebKit::WebScrollbar::~WebScrollbar):
- public/WebScrollbarClient.h: Added.
- public/WebThemeEngine.h:
- src/AssertMatchingEnums.cpp:
- src/WebScrollbarImpl.cpp: Added. (WebKit::WebScrollbar::create): (WebKit::WebScrollbar::defaultThickness): (WebKit::WebScrollbarImpl::WebScrollbarImpl): (WebKit::WebScrollbarImpl::~WebScrollbarImpl): (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::value): (WebKit::WebScrollbarImpl::setValue): (WebKit::WebScrollbarImpl::setDocumentSize): (WebKit::WebScrollbarImpl::scroll): (WebKit::WebScrollbarImpl::paint): (WebKit::WebScrollbarImpl::handleInputEvent): (WebKit::WebScrollbarImpl::onMouseDown): (WebKit::WebScrollbarImpl::onMouseUp): (WebKit::WebScrollbarImpl::onMouseMove): (WebKit::WebScrollbarImpl::onMouseLeave): (WebKit::WebScrollbarImpl::onMouseWheel): (WebKit::WebScrollbarImpl::onKeyDown): (WebKit::WebScrollbarImpl::valueChanged): (WebKit::WebScrollbarImpl::invalidateScrollbarRect): (WebKit::WebScrollbarImpl::isActive): (WebKit::WebScrollbarImpl::scrollbarCornerPresent): (WebKit::WebScrollbarImpl::getTickmarks):
- src/WebScrollbarImpl.h: Added.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollViewWithKeyboard): (WebKit::WebViewImpl::mapKeyCodeForScroll):
- src/WebViewImpl.h:
- 5:08 PM Changeset in webkit [59109] by
-
- 5 edits2 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.
Reviewed by Darin Adler.
Test: fast/dom/Element/normalize-crash.html
- dom/Element.cpp:
(WebCore::Element::normalizeAttributes): Copy attributes to a vector
before iterating.
- dom/NamedAttrMap.cpp:
(WebCore::NamedNodeMap::copyAttributesToVector): Added.
- dom/NamedAttrMap.h:
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.
Reviewed by Darin Adler.
- fast/dom/Element/normalize-crash-expected.txt: Added.
- fast/dom/Element/normalize-crash.html: Added.
- 5:01 PM Changeset in webkit [59108] by
-
- 3 edits in trunk/WebKitTools
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
new-run-webkit-tests: looks like the unicode conversion broke
--print-last-failures and --retest-last-failures. Fixing.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 5:00 PM Changeset in webkit [59107] by
-
- 12 edits1 copy2 adds in branches/audio/WebCore
Hook the realtime analyser into the modular routing API
- 5:00 PM Changeset in webkit [59106] by
-
- 6 edits in trunk/WebKitTools
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
Re-attempt to fix 38616 - newline handling in new-run-webkit-tests.
I didn't handle some cases correctly before and the solution was
confusing. The new patch assumes all calls to the printing module
don't have newlines, and will append newlines where necessary, just
like logging does.
- Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
- Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 4:58 PM Changeset in webkit [59105] by
-
- 46 edits59 adds6 deletes in trunk/LayoutTests
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Unreviewed, svg test rebaselines after r59002 for linux.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
- platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
- platform/chromium-linux/svg/batik/filters/feTile-expected.png:
- platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Added.
- platform/chromium-linux/svg/batik/filters/filterRegions-expected.checksum:
- platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-linux/svg/batik/filters/filterRegions-expected.txt: Added.
- platform/chromium-linux/svg/batik/masking/maskRegions-expected.txt: Added.
- platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
- platform/chromium-linux/svg/batik/text/textEffect-expected.png: Added.
- platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
- platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
- platform/chromium-linux/svg/batik/text/textEffect3-expected.png: Added.
- platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
- platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Added.
- platform/chromium-linux/svg/batik/text/textProperties-expected.txt: Added.
- platform/chromium-linux/svg/custom/empty-mask-expected.txt: Added.
- platform/chromium-linux/svg/custom/empty-merge-expected.checksum:
- platform/chromium-linux/svg/custom/empty-merge-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.txt: Added.
- platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.txt: Added.
- platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.txt: Added.
- platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.txt: Added.
- platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.checksum:
- platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.checksum:
- platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.png: Removed.
- platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/chromium-linux/svg/custom/invalid-css-expected.txt: Added.
- platform/chromium-linux/svg/custom/mask-invalidation-expected.txt: Added.
- platform/chromium-linux/svg/custom/non-opaque-filters-expected.txt: Added.
- platform/chromium-linux/svg/custom/text-filter-expected.checksum:
- platform/chromium-linux/svg/custom/text-filter-expected.png: Removed.
- platform/chromium-linux/svg/custom/text-filter-expected.txt: Added.
- platform/chromium-linux/svg/custom/visibility-override-filter-expected.checksum: Added.
- platform/chromium-linux/svg/filters/big-sized-filter-2-expected.checksum: Added.
- platform/chromium-linux/svg/filters/big-sized-filter-2-expected.png: Added.
- platform/chromium-linux/svg/filters/big-sized-filter-expected.checksum: Added.
- platform/chromium-linux/svg/filters/big-sized-filter-expected.png: Added.
- platform/chromium-linux/svg/filters/feColorMatrix-values-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/chromium-linux/svg/filters/feColorMatrix-values-expected.txt: Added.
- platform/chromium-linux/svg/filters/feComposite-expected.checksum:
- platform/chromium-linux/svg/filters/feComposite-expected.png: Removed.
- platform/chromium-linux/svg/filters/feComposite-expected.txt: Added.
- platform/chromium-linux/svg/filters/feGaussianBlur-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feMerge-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feMerge-expected.png: Added.
- platform/chromium-linux/svg/filters/feOffset-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feTile-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feTile-expected.png: Added.
- platform/chromium-linux/svg/filters/filter-on-tspan-expected.checksum:
- platform/chromium-linux/svg/filters/filter-on-tspan-expected.png: Removed.
- platform/chromium-linux/svg/filters/filter-on-tspan-expected.txt: Added.
- platform/chromium-linux/svg/filters/sourceAlpha-expected.txt: Added.
- platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.checksum: Added.
- platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.png: Added.
- platform/chromium-linux/svg/filters/subRegion-one-effect-expected.checksum:
- platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png: Removed.
- platform/chromium-linux/svg/filters/subRegion-two-effects-expected.checksum:
- platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png: Removed.
- platform/chromium-linux/svg/text/text-vkern-expected.checksum: Added.
- platform/chromium-linux/svg/text/text-vkern-expected.png: Added.
- 4:38 PM Changeset in webkit [59104] by
-
- 5 edits in trunk/WebCore
[V8] Fix V8 code generator script to generate the correct code for
converting ScriptString.
https://bugs.webkit.org/show_bug.cgi?id=38873
Reviewed by Adam Barth.
Updated the bindings test result. Note that the result is also updated
to reflect other script generator changes not introduced by this patch.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
- bindings/scripts/test/JS/JSTestCallback.h:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::scriptStringAttrAttrGetter):
- 4:35 PM Changeset in webkit [59103] by
-
- 2 edits in trunk/LayoutTests
Add test to GTK skipped list.
Rubber-stamped by Mark Rowe.
- platform/gtk/Skipped:
- 4:14 PM Changeset in webkit [59102] by
-
- 2 edits in trunk/WebCore
Fix the 32-bit WebKit2 build.
- WebCore.base.exp:
- 4:13 PM WebKit Team edited by
- Move tkent to the reviewers section (diff)
- 4:02 PM Changeset in webkit [59101] by
-
- 2 edits in trunk/WebKitTools
2010-05-10 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Make tkent a reviewer
https://bugs.webkit.org/show_bug.cgi?id=38875
- Scripts/webkitpy/common/config/committers.py:
- 3:56 PM Changeset in webkit [59100] by
-
- 7 edits3 adds in trunk
Crash closing window containing Flash plug-in
https://bugs.webkit.org/show_bug.cgi?id=38797
<rdar://problem/7935266>
Reviewed by Eric Seidel.
WebCore:
Test: plugins/geturlnotify-during-document-teardown.html
- plugins/PluginView.cpp:
(WebCore::PluginView::load):
Null check the DocumentLoader; it's possible for this to be null while
the Document is being torn down and before the plug-in is destroyed.
WebKitTools:
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginAllocate):
Initialize new member to false.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
Added a new member.
- DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_New):
Check whether the element has the "testGetURLOnDestroy" attribute, and
record that.
(NPP_Destroy):
If "testGetURLOnDestroy" is set, perform a load while destroying the
plug-in.
LayoutTests:
- plugins/geturlnotify-during-document-teardown.html: Added.
- plugins/resources/geturlnotify-on-destroy.html: Added.
- 3:48 PM Changeset in webkit [59099] by
-
- 3 edits in trunk/WebKitTools
2010-05-10 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
Executive.kill_* do not work with windows python
https://bugs.webkit.org/show_bug.cgi?id=38872
http://trac.webkit.org/changeset/57444 is where the original
breakage occurred.
http://trac.webkit.org/changeset/58314 is where the regression
started affecting chromium.
I have since learned that sys.platform has no "windows" value.
"win32" is always the value, under 32 or 64 bit windows
The tests for this code are not run anywhere because
test-webkitpy does not yet work on "win32". Mostly due to
depending on unixisms like "cat" and "yes".
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/common/system/executive_unittest.py:
- 3:13 PM Changeset in webkit [59098] by
-
- 7 edits2 adds in trunk
Reviewed by Darin Adler.
Based on a patch by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28697
<rdar://problem/7946578> WebKit crash on WebCore::Node::nodeIndex()
It's not OK to call ContainerNode::willRemoveChild() in a loop, because Range code assumes
that it can adjust start and end position to any node except for the one being removed -
so these notifications cannot be batched.
Test: fast/dom/Range/remove-all-children-crash.html
- dom/ContainerNode.cpp: (WebCore::willRemoveChild): Removed unused ExceptionCode. (WebCore::willRemoveChildren): New function, used in removeChildren() case. (WebCore::ContainerNode::removeChild): ExceptionCode return was always 0, don't bother with it. (WebCore::ContainerNode::removeChildren): Call willRemoveChildrenFromNode. (WebCore::dispatchChildRemovalEvents): Moved some logic out into willRemoveChildrenFromNode and willRemoveChild.
- dom/Document.cpp: (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
- dom/Document.h: (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
- dom/Range.h:
- dom/Range.cpp: (WebCore::boundaryNodeChildrenWillBeRemoved): New function, used in removeChildren() case. (WebCore::Range::nodeChildrenWillBeRemoved): Ditto.
- 2:44 PM Changeset in webkit [59097] by
-
- 6 edits1 add in branches/audio/WebCore
Add custom bindings for attributes which are custom JS objects to avoid compiler warnings/errors
- this is a problem which seems to only occur with the JS (not V8) bindings
- JSAudioMiscCustom.cpp may be temporary until these can be split out into separate files (if necessary)
- 2:34 PM Changeset in webkit [59096] by
-
- 4 edits in trunk/WebCore
Implement the V8 bindings for the sync DB API.
https://bugs.webkit.org.show_bug.cgi?id=34994
Reviewed by Adam Barth.
- bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContextCustom::openDatabaseSyncCallback):
- 1:46 PM Changeset in webkit [59095] by
-
- 4 edits in trunk/WebCore
Clean up and fix the existing V8 DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Adam Barth.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
- bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- 1:03 PM Changeset in webkit [59094] by
-
- 3 edits in trunk/WebCore
[wx] Build fix for wx 2.8 after complex text changes.
- 12:59 PM Changeset in webkit [59093] by
-
- 2 edits in trunk/WebKit/mac
Unbreak the world. (Fix Mac builds).
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 12:53 PM Changeset in webkit [59092] by
-
- 59 edits2 copies4 adds in trunk/LayoutTests
2010-05-07 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add a bunch of windows-specific chromium baselines for the different
versions of windows to update them from a skia change.
- platform/chromium/test_expectations.txt:
- 12:47 PM Changeset in webkit [59091] by
-
- 2 edits1 add in trunk/WebKitTools
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Fix a bug in rebaseline-chromium-webkit-tests where we would crash
instead of logging an error and exiting if it couldn't find either a
debug or a release build of the image diff binary.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Added.
- 12:46 PM Changeset in webkit [59090] by
-
- 3 edits in trunk/WebKitTools
2010-05-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL
https://bugs.webkit.org/show_bug.cgi?id=38861
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/common/system/executive_unittest.py:
- 12:36 PM Changeset in webkit [59089] by
-
- 2 edits in trunk/WebCore
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Try to fix the chromium build after r59085 by
including MathExtras.h before using isnan().
https://bugs.webkit.org/show_bug.cgi?id=38860
- html/canvas/WebGLIntegralTypedArrayBase.h:
- 11:59 AM Changeset in webkit [59088] by
-
- 2 edits in trunk/WebCore
[wx] Build fix for wx trunk after complex text changes.
- 11:14 AM Changeset in webkit [59087] by
-
- 15 edits1 add in trunk
2010-05-10 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Provide mechanism to cache metadata for a resource
https://bugs.webkit.org/show_bug.cgi?id=37874
No new tests because no new functionality.
- WebCore.gypi:
- loader/CachedMetadata.h: Added. (WebCore::CachedMetadata::create): (WebCore::CachedMetadata::deserialize): (WebCore::CachedMetadata::serialize): (WebCore::CachedMetadata::~CachedMetadata): (WebCore::CachedMetadata::dataTypeID): (WebCore::CachedMetadata::data): (WebCore::CachedMetadata::size): (WebCore::CachedMetadata::readUnsigned): (WebCore::CachedMetadata::appendUnsigned): (WebCore::CachedMetadata::CachedMetadata):
- loader/CachedResource.cpp: (WebCore::CachedResource::setSerializedCachedMetadata): (WebCore::CachedResource::setCachedMetadata): (WebCore::CachedResource::cachedMetadata):
- loader/CachedResource.h:
- loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveCachedMetadata):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveCachedMetadata):
- loader/SubresourceLoader.h:
- loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
- loader/loader.cpp: (WebCore::Loader::Host::didReceiveCachedMetadata):
- loader/loader.h:
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveCachedMetadata):
2010-05-10 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Provide mechanism to cache metadata for a resource
https://bugs.webkit.org/show_bug.cgi?id=37874
- src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
- 11:12 AM Changeset in webkit [59086] by
-
- 2 edits in trunk/WebKit/mac
Change the order of the RendererType enum values, so that old versions of WebKitPluginHost will
use accelerated compositing and not layer backed views.
Reviewed by Simon Fraser.
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 10:53 AM Changeset in webkit [59085] by
-
- 18 edits2 adds in trunk/WebCore
2010-05-09 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Refactor WebGLArray types to share more code
https://bugs.webkit.org/show_bug.cgi?id=37712
Refactored WebGLArray types for maximal code sharing. Added
WebGLTypedArrayBase and WebGLIntegralTypedArrayBase template
superclasses. Changed overridden virtuals to have minimal
visibility (private instead of public). Fixed const correctness of
a few methods. There are no changes to the public APIs of the
WebGLArray classes; the JavaScript bindings are unchanged.
No new tests; existing tests cover this functionality. Ran all
WebGL layout tests in Safari and Chromium on Mac OS X.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/WebGLArray.h: (WebCore::WebGLArray::buffer): (WebCore::WebGLArray::baseAddress): (WebCore::WebGLArray::byteOffset):
- html/canvas/WebGLByteArray.cpp: (WebCore::WebGLByteArray::create): (WebCore::WebGLByteArray::WebGLByteArray): (WebCore::WebGLByteArray::slice):
- html/canvas/WebGLByteArray.h: (WebCore::WebGLByteArray::isByteArray):
- html/canvas/WebGLFloatArray.cpp: (WebCore::WebGLFloatArray::create): (WebCore::WebGLFloatArray::WebGLFloatArray): (WebCore::WebGLFloatArray::slice):
- html/canvas/WebGLFloatArray.h: (WebCore::WebGLFloatArray::set): (WebCore::WebGLFloatArray::item): (WebCore::WebGLFloatArray::isFloatArray):
- html/canvas/WebGLIntArray.cpp: (WebCore::WebGLIntArray::create): (WebCore::WebGLIntArray::WebGLIntArray): (WebCore::WebGLIntArray::slice):
- html/canvas/WebGLIntArray.h: (WebCore::WebGLIntArray::isIntArray):
- html/canvas/WebGLIntegralTypedArrayBase.h: Added. (WebCore::WebGLIntegralTypedArrayBase::set): (WebCore::WebGLIntegralTypedArrayBase::item): (WebCore::WebGLIntegralTypedArrayBase::WebGLIntegralTypedArrayBase):
- html/canvas/WebGLShortArray.cpp: (WebCore::WebGLShortArray::create): (WebCore::WebGLShortArray::WebGLShortArray): (WebCore::WebGLShortArray::slice):
- html/canvas/WebGLShortArray.h: (WebCore::WebGLShortArray::isShortArray):
- html/canvas/WebGLTypedArrayBase.h: Added. (WebCore::WebGLTypedArrayBase::data): (WebCore::WebGLTypedArrayBase::set): (WebCore::WebGLTypedArrayBase::length): (WebCore::WebGLTypedArrayBase::WebGLTypedArrayBase): (WebCore::WebGLTypedArrayBase::create): (WebCore::WebGLTypedArrayBase::sliceImpl): (WebCore::WebGLTypedArrayBase::byteLength):
- html/canvas/WebGLUnsignedByteArray.cpp: (WebCore::WebGLUnsignedByteArray::create): (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray): (WebCore::WebGLUnsignedByteArray::slice):
- html/canvas/WebGLUnsignedByteArray.h: (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
- html/canvas/WebGLUnsignedIntArray.cpp: (WebCore::WebGLUnsignedIntArray::create): (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray): (WebCore::WebGLUnsignedIntArray::slice):
- html/canvas/WebGLUnsignedIntArray.h: (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
- html/canvas/WebGLUnsignedShortArray.cpp: (WebCore::WebGLUnsignedShortArray::create): (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray): (WebCore::WebGLUnsignedShortArray::slice):
- html/canvas/WebGLUnsignedShortArray.h: (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
- 10:25 AM Changeset in webkit [59084] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Adding myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 10:12 AM Changeset in webkit [59083] by
-
- 2 edits in trunk/WebCore
Build fix, not reviewed.
Correct post-build copy command for WinCairo port to make sure
cairo headers are available for WebKit.dll build.
- WebCore.vcproj/WebCore.vcproj:
- 9:23 AM Changeset in webkit [59082] by
-
- 7 edits in trunk/LayoutTests
2010-05-10 Dirk Schulze <krit@webkit.org>
Unreviewed.
Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820
New baseline for Qt.
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/qt/svg/css/mask-with-shadow-expected.txt:
- platform/qt/svg/custom/empty-mask-expected.txt:
- platform/qt/svg/custom/mask-invalidation-expected.txt:
- platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/qt/svg/custom/transformedMaskFails-expected.txt:
- 8:59 AM Changeset in webkit [59081] by
-
- 26 edits in trunk
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820
This is a further optimization to get smaller repaintRects on SVG objects
in combination with masker or clipper resources.
Masker takes the unite of all stroke boundaries of it's childs.
Both, clipper and masker, store this union to avoid multiple calls of the childs
and the unite calculations now.
The unite rect can be transformed to any targets objectBoundingBox, if the content
unit of the resource is set to objectBoundingBoxMode.
This speeds up the use of resources with multiple target objects.
No behavior changes, the smaller repaintRects cause updates for DRT results.
- rendering/RenderSVGResource.h:
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::invalidateClients): (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
- rendering/RenderSVGResourceClipper.h:
- rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
- rendering/RenderSVGResourceFilter.h:
- rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
- rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClients): (WebCore::RenderSVGResourceMasker::createMaskImage): (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect): (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
- rendering/RenderSVGResourceMasker.h:
- rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
- rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820
The repaintRect of SVG objects with masks got smaller. This made
updates of some results necessary.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/mac/svg/batik/masking/maskRegions-expected.txt:
- platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/mac/svg/css/mask-with-shadow-expected.txt:
- platform/mac/svg/custom/empty-mask-expected.txt:
- platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
- platform/mac/svg/custom/mask-inside-defs-expected.txt:
- platform/mac/svg/custom/mask-invalidation-expected.txt:
- platform/mac/svg/custom/mask-with-all-units-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/visibility-override-mask-expected.txt:
- svg/custom/transformedMaskFails-expected.txt:
- 8:21 AM Changeset in webkit [59080] by
-
- 3 edits in trunk/WebCore
2010-05-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Cosmetic changes.
1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
2) Standard tooltips for resource links are clashing with Popover.
3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
https://bugs.webkit.org/show_bug.cgi?id=38732
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
- 7:48 AM Changeset in webkit [59079] by
-
- 3 edits in trunk/LayoutTests
2010-05-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Layout test for Session Storage quota should only expect to fit 39 objects.
https://bugs.webkit.org/show_bug.cgi?id=38843
The script should be ready for the exception when inserting the 40th
element, as that is where it will be thrown if a quota is enforced.
This is the same change as in http://trac.webkit.org/changeset/50979.
- storage/domstorage/quota-expected.txt:
- storage/domstorage/script-tests/quota.js: (testNoQuota):
- 7:36 AM Changeset in webkit [59078] by
-
- 2 edits3 deletes in trunk/LayoutTests
2010-05-10 Adam Langley <agl@chromium.org>
Expectations change. Not reviewed.
Delete the current baselines for the WOFF test because they are
incomplete.
Remove the SKIP tag from test_expectations so that the builders
will run the test and then the rebaseline tool can be used to
checkin real baselines.
- platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Removed.
- platform/chromium-win/fast/css/font-face-woff-expected.checksum: Removed.
- platform/chromium-win/fast/css/font-face-woff-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 7:27 AM Changeset in webkit [59077] by
-
- 7 edits in trunk
2010-05-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
https://bugs.webkit.org/show_bug.cgi?id=38750
Put a per-origin quota on session storage since it is using memory in
the browser process, and should not be allowed to grow arbitrarily
large. See also http://trac.webkit.org/changeset/58828.
- public/WebStorageNamespace.h:
- public/WebViewClient.h: (WebKit::WebViewClient::createSessionStorageNamespace):
- src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
2010-05-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
https://bugs.webkit.org/show_bug.cgi?id=38750
Put a per-origin quota on session storage since it is using memory in
the browser process, and should not be allowed to grow arbitrarily
large. See also http://trac.webkit.org/changeset/58828.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createSessionStorageNamespace):
- DumpRenderTree/chromium/WebViewHost.h:
- 7:03 AM Changeset in webkit [59076] by
-
- 7 edits1 delete in trunk
[Qt] Roll-out r59020 and r59021, because the Qt part of these changes
haven't been landed in Qt trunk yet. Should be rolled-in again after the merge.
Rubber-stamped by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=32967
WebCore:
- platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
WebKitTools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
LayoutTests:
- platform/qt/Skipped:
- platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Removed.
- 6:48 AM BuildingQtOnWindows edited by
- add mingw-w64 howto (diff)
- 6:18 AM Changeset in webkit [59075] by
-
- 2 edits in trunk/WebCore
2010-05-10 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Simon Hausmann.
Qt after 4.6.3 has its integrated DNS cache. Therefore some
code is not necessary anymore.
- platform/network/qt/DnsPrefetchHelper.h: (WebCore::DnsPrefetchHelper::lookup): (WebCore::DnsPrefetchHelper::lookedUp):
- 6:07 AM Changeset in webkit [59074] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
[Qt] Disable JIT support for mingw-w64
https://bugs.webkit.org/show_bug.cgi?id=38747
Disale JIT for mingw-w64 as it is reportedly
unstable.
Thanks for Vanboxem Rruben for the investigation.
- wtf/Platform.h:
- 4:53 AM Changeset in webkit [59073] by
-
- 3 edits in trunk/LayoutTests
2010-05-10 Dirk Schulze <krit@webkit.org>
Uneviewed.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
New baseline for Win. Only two tests needed an update.
- platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/win/svg/filters/feColorMatrix-values-expected.txt:
- 4:40 AM Changeset in webkit [59072] by
-
- 3 edits in trunk/WebCore
2010-05-10 Chris Jerdonek <Chris Jerdonek>
Reviewed by Darin Adler.
Asserted that Node::setDocument() is not being used to change
the document of a node.
- dom/Node.cpp: (WebCore::Node::setDocument): Added an ASSERT at the beginning of the function.
- dom/Node.h: Documented that Node::setDocument() should not be used to change the document of a node until after the node has been removed from its prior document.
- 4:37 AM Changeset in webkit [59071] by
-
- 2 edits in trunk/LayoutTests
2010-05-10 Dirk Schulze <krit@webkit.org>
Unreviewed.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
New baseline for Gtk. Just one test needed an update.
- platform/gtk/svg/filters/filter-on-tspan-expected.txt:
- 4:34 AM Changeset in webkit [59070] by
-
- 17 edits in trunk/LayoutTests
2010-05-10 Dirk Schulze <krit@webkit.org>
Unreviewed.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
New baseline for Qt.
- platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/qt/svg/filters/feColorMatrix-values-expected.txt:
- platform/qt/svg/filters/feComposite-expected.txt:
- platform/qt/svg/filters/feGaussianBlur-expected.txt:
- platform/qt/svg/filters/feMerge-expected.txt:
- platform/qt/svg/filters/feOffset-expected.txt:
- platform/qt/svg/filters/feTile-expected.txt:
- platform/qt/svg/filters/filter-clip-expected.txt:
- platform/qt/svg/filters/filter-on-tspan-expected.txt:
- platform/qt/svg/filters/filter-source-position-expected.txt:
- platform/qt/svg/filters/shadow-on-filter-expected.txt:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/qt/svg/filters/sourceAlpha-expected.txt:
- platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/qt/svg/filters/subRegion-one-effect-expected.txt:
- platform/qt/svg/filters/subRegion-two-effects-expected.txt:
- 4:15 AM Changeset in webkit [59069] by
-
- 97 edits in trunk
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
All SVG Filter effects get dumped now. The structure of the DRT output
changed. The last effect is shown first, followed by the previous effects.
No changed behaior, so no new test added.
- platform/graphics/filters/FEBlend.cpp: (WebCore::operator<<): (WebCore::FEBlend::externalRepresentation):
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::operator<<): (WebCore::FEColorMatrix::externalRepresentation):
- platform/graphics/filters/FEColorMatrix.h:
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::operator<<): (WebCore::FEComponentTransfer::externalRepresentation):
- platform/graphics/filters/FEComponentTransfer.h:
- platform/graphics/filters/FEComposite.cpp: (WebCore::operator<<): (WebCore::FEComposite::externalRepresentation):
- platform/graphics/filters/FEComposite.h: (WebCore::): (WebCore::FEComposite::uniteChildEffectSubregions):
- platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::externalRepresentation):
- platform/graphics/filters/FEGaussianBlur.h: (WebCore::FEGaussianBlur::uniteChildEffectSubregions):
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::externalRepresentation):
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::externalRepresentation):
- platform/graphics/filters/SourceAlpha.h:
- platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::externalRepresentation):
- platform/graphics/filters/SourceGraphic.h:
- rendering/RenderTreeAsText.cpp: (WebCore::writeIndent):
- rendering/RenderTreeAsText.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer):
- svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::operator<<): (WebCore::FEConvolveMatrix::externalRepresentation):
- svg/graphics/filters/SVGFEConvolveMatrix.h:
- svg/graphics/filters/SVGFEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::externalRepresentation):
- svg/graphics/filters/SVGFEDiffuseLighting.h:
- svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::operator<<): (WebCore::FEDisplacementMap::externalRepresentation):
- svg/graphics/filters/SVGFEDisplacementMap.h:
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::externalRepresentation):
- svg/graphics/filters/SVGFEFlood.h:
- svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::externalRepresentation):
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::externalRepresentation):
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::operator<<): (WebCore::FEMorphology::externalRepresentation):
- svg/graphics/filters/SVGFEMorphology.h:
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::externalRepresentation):
- svg/graphics/filters/SVGFEOffset.h:
- svg/graphics/filters/SVGFESpecularLighting.cpp: (WebCore::FESpecularLighting::externalRepresentation):
- svg/graphics/filters/SVGFESpecularLighting.h:
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::externalRepresentation):
- svg/graphics/filters/SVGFETile.h:
- svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::operator<<): (WebCore::FETurbulence::externalRepresentation):
- svg/graphics/filters/SVGFETurbulence.h:
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
All SVG Filter effects get dumped now. The structure of the DRT output
changed. The last effect is shown first, followed by the previous effects.
- platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/mac/svg/batik/filters/feTile-expected.txt:
- platform/mac/svg/batik/filters/filterRegions-expected.txt:
- platform/mac/svg/batik/text/textEffect-expected.txt:
- platform/mac/svg/batik/text/textEffect3-expected.txt:
- platform/mac/svg/batik/text/textFeatures-expected.txt:
- platform/mac/svg/batik/text/textProperties-expected.txt:
- platform/mac/svg/custom/empty-merge-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
- platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/mac/svg/custom/invalid-css-expected.txt:
- platform/mac/svg/custom/non-opaque-filters-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/text-filter-expected.txt:
- platform/mac/svg/custom/visibility-override-filter-expected.txt:
- platform/mac/svg/filters/big-sized-filter-2-expected.txt:
- platform/mac/svg/filters/big-sized-filter-expected.txt:
- platform/mac/svg/filters/feColorMatrix-values-expected.txt:
- platform/mac/svg/filters/feComposite-expected.txt:
- platform/mac/svg/filters/feDisplacementMap-expected.txt:
- platform/mac/svg/filters/feGaussianBlur-expected.txt:
- platform/mac/svg/filters/feMerge-expected.txt:
- platform/mac/svg/filters/feOffset-expected.txt:
- platform/mac/svg/filters/feTile-expected.txt:
- platform/mac/svg/filters/filter-clip-expected.txt:
- platform/mac/svg/filters/filter-on-tspan-expected.txt:
- platform/mac/svg/filters/filter-source-position-expected.txt:
- platform/mac/svg/filters/filterRes-expected.txt:
- platform/mac/svg/filters/shadow-on-filter-expected.txt:
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/mac/svg/filters/sourceAlpha-expected.txt:
- platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/mac/svg/filters/subRegion-one-effect-expected.txt:
- platform/mac/svg/filters/subRegion-two-effects-expected.txt:
- 2:53 AM Changeset in webkit [59068] by
-
- 29 edits4 copies2 adds2 deletes in trunk
2010-05-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Change IndexedDB to use events instead of callbacks
https://bugs.webkit.org/show_bug.cgi?id=38594
Switch IndexedDB over to an event based model to match what
Mozilla (and probably MS?) are doing. This also gets rid of
a lot of template mess at the expense of a little extra boiler
plate code (for each type that IDBResult.result could be).
This change also introduces JSC bindings that match the level of
functionality the V8 bindings have.
Still not testable, but that shoudl change shortly.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventCustom.cpp:
- bindings/js/JSIDBRequestCustom.cpp: Added. (WebCore::JSIDBRequest::result):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- bindings/v8/custom/V8CustomIDBCallbacks.h: Removed.
- bindings/v8/custom/V8IDBRequestCustom.cpp: Added. (WebCore::V8IDBRequest::resultAccessorGetter):
- bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: Removed.
- dom/EventTarget.cpp: (WebCore::EventTarget::toIDBRequest):
- dom/EventTarget.h:
- storage/IDBCallbacks.h:
- storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::createObjectStore):
- storage/IDBRequest.cpp: Added. (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::idbDatabaseResult): (WebCore::IDBRequest::serializedScriptValueResult): (WebCore::IDBRequest::onError): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::scriptExecutionContext): (WebCore::IDBRequest::stop): (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::eventTargetData): (WebCore::IDBRequest::ensureEventTargetData): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
- storage/IDBRequest.h: Added. (WebCore::IDBRequest::create): (WebCore::IDBRequest::): (WebCore::IDBRequest::resultType): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::error): (WebCore::IDBRequest::toIDBRequest): (WebCore::IDBRequest::refEventTarget): (WebCore::IDBRequest::derefEventTarget):
- storage/IDBRequest.idl: Added.
- storage/IndexedDatabase.h:
- storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
- storage/IndexedDatabaseImpl.h:
- storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
- storage/IndexedDatabaseRequest.h:
- storage/IndexedDatabaseRequest.idl:
2010-05-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Change IndexedDB to use events instead of callbacks
https://bugs.webkit.org/show_bug.cgi?id=38594
Change the glue here to match the changes I made in WebCore.
- WebKit.gyp:
- public/WebIDBCallbacks.h:
- public/WebIndexedDatabase.h:
- src/IDBCallbacksProxy.cpp: Added. (WebCore::IDBCallbacksProxy::IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::onError): (WebCore::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
- src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
- src/IndexedDatabaseProxy.h:
- src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
- src/WebIndexedDatabaseImpl.h:
- 12:02 AM Changeset in webkit [59067] by
-
- 5 edits in trunk/JavaScriptCore
2010-05-09 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
JavaScriptCore/wtf/MD5.h: checksum should take a reference to output.
https://bugs.webkit.org/show_bug.cgi?id=38723
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/MD5.cpp: (WTF::expectMD5): Fix for checksum change. (WTF::MD5::checksum): Take a reference to output, instead of returning the result by value, to reduce coping for performance.
- wtf/MD5.h:
May 9, 2010:
- 10:07 PM Changeset in webkit [59066] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, test expectation update.
Update Chromium/Linux expectation for fast/forms/input-file-re-render.html.
http://crbug.com/40027
- platform/chromium-linux/fast/forms/input-file-re-render-expected.checksum:
- platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
- platform/chromium/test_expectations.txt:
- 7:17 PM Changeset in webkit [59065] by
-
- 2 edits in trunk/JavaScriptCore
Fix accidental repeat addition of emit_op_new_regexp
- 6:41 PM Changeset in webkit [59064] by
-
- 14 edits2 moves1 add1 delete in trunk
2010-05-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Reserve a large-ish initial capacity for Lexer::m_buffer16.
SunSpider says 0.3% faster.
m_buffer16 is used when parsing complex strings -- for example, strings
with escape sequences in them. These kinds of strings can be really long,
and we want to avoid repeatedly copying as we grow m_buffer16.
The net memory cost is quite low, since it's proporitional to source
code we already have in memory, and we throw away m_buffer16 right when
we're done parsing.
- parser/Lexer.cpp: (JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor, since setCode will be called before we're asked to lex anything. (JSC::Lexer::setCode): Reserve enough space to lex half the source code as a complex string without having to copy. (JSC::Lexer::clear): No need to reserve initial capacity here either, since setCode will be called before we're asked to lex anything.
2010-05-09 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION(r57955): RegExp literals should not actually be cached, so r57955 should be rolled out.
https://bugs.webkit.org/show_bug.cgi?id=38828
Replace incorrect test for caching regexp literals with ones that tests that they are not cached.
- fast/js/regexp-literals-are-constants-expected.txt: Removed.
- fast/js/regexp-literals-are-constants.html: Removed.
- fast/js/regexp-literals-arent-constants-expected.txt: Added.
- fast/js/regexp-literals-arent-constants.html: Added.
- fast/js/script-tests/regexp-literals-are-constants.js: Removed.
- fast/js/script-tests/regexp-literals-arent-constants.js: Added. (test1): (returnRegExpLiteral): (returnConditionalRegExpLiteral):
- 3:09 PM Changeset in webkit [59063] by
-
- 3 edits in trunk/WebCore
2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>
Not reviewed: rollback the commit r59062
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
- 2:38 PM Changeset in webkit [59062] by
-
- 3 edits in trunk/WebCore
2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Cosmetic changes.
1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
2) Standard tooltips for resource links are clashing with Popover.
3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
https://bugs.webkit.org/show_bug.cgi?id=38732
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
- 2:16 PM Changeset in webkit [59061] by
-
- 2 edits in trunk/JavaScriptCore
Reserve a large-ish initial capacity for Lexer::m_buffer16.
Reviewed by Oliver Hunt.
SunSpider says 0.3% faster.
m_buffer16 is used when parsing complex strings -- for example, strings
with escape sequences in them. These kinds of strings can be really long,
and we want to avoid repeatedly copying as we grow m_buffer16.
The net memory cost is quite low, since it's proporitional to source
code we already have in memory, and we throw away m_buffer16 right when
we're done parsing.
- parser/Lexer.cpp:
(JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor,
since setCode will be called before we're asked to lex anything.
(JSC::Lexer::setCode): Reserve enough space to lex half the source code
as a complex string without having to copy.
(JSC::Lexer::clear): No need to reserve initial capacity here either,
since setCode will be called before we're asked to lex anything.
- 2:11 PM Changeset in webkit [59060] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-09 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Remove YARR configuration rules from Qt make system
https://bugs.webkit.org/show_bug.cgi?id=38819
Setting YARR based on JIT seeting is now in Platform.h
for all ports. This patch essentially reverses r49238.
- JavaScriptCore.pri:
- 1:58 PM Changeset in webkit [59059] by
-
- 2 edits in trunk/WebCore
2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: If some record is not in visible area then it's expand element also is not
visible even if it has children in visible area.
https://bugs.webkit.org/show_bug.cgi?id=38643
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._refreshRecords):
- 1:34 PM Changeset in webkit [59058] by
-
- 5 edits in trunk/WebCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=38557
r58526 introduced a ~30% regression on Dromaeo JS lib
Reviewed by Darin Adler.
This fix does two things.
- Don't use QualifiedName as the key to a HashMap, use a RefPtr<QualifiedNameImpl> instead. We should remove the HashTraits for QualifiedName and that will happen in a follow up patch.
- Only mark cached NodeLists on Documents instead of all Nodes. This is okay since the marking of NodeLists is an optimization to keep NodeList wrappers alive and is not mandated by any spec.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::markChildren):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren):
- dom/Node.cpp:
(WebCore::Node::removeCachedTagNodeList):
(WebCore::Node::getElementsByTagNameNS):
- dom/NodeRareData.h:
- 9:37 AM Changeset in webkit [59057] by
-
- 2 edits in trunk/WebKit/qt
2010-05-09 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Crash in QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate when animation were used
https://bugs.webkit.org/show_bug.cgi?id=38574
The fix uses a QWeakPointer for rootGraphicsLayer, protecting from a crash in case the layer is deleted before the QGraphicsWebView.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::setRootGraphicsLayer): (QGraphicsWebViewPrivate::updateCompositingScrollPosition):
- 4:42 AM Changeset in webkit [59056] by
-
- 7 edits in trunk/JavaScriptCore
2010-05-09 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Improve string indexing performance
https://bugs.webkit.org/show_bug.cgi?id=38814
Add an assembly stub to do indexed loads from strings much
more cheaply than the current stub dispatch logic. We can
do this because we are able to make guarantees about the
register contents when entering the stub so the call overhead
is negligible.
- jit/JIT.h:
- jit/JITInlineMethods.h:
- jit/JITOpcodes.cpp:
- jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emitSlow_op_get_by_val):
Moved from JITOpcodes.cpp to keep the slowcase next to
the normal case codegen as we do for everything else.
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emitSlow_op_get_by_val):
- jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitFastArithImmToInt):
- 4:18 AM Changeset in webkit [59055] by
-
- 3 edits in trunk/JavaScriptCore
2010-05-09 Maciej Stachowiak <mjs@apple.com>
Fixed version of: "Optimized o[s] where o is a cell and s is a string"
https://bugs.webkit.org/show_bug.cgi?id=38815
Fixed the previous patch for this from Geoff Garen.
The two problems were a missing exception check and a PropertySlot
initialized improperly, leading to crashes and failures in the case
of getters accessed with bracket syntax.
Previous patch:
Optimized o[s] where o is a cell and s is a string, removing some old
code that wasn't really tuned for the JIT.
SunSpider says 0.8% faster.
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- runtime/JSCell.h:
- 3:24 AM Changeset in webkit [59054] by
-
- 1 edit1 delete in trunk/LayoutTests
2010-05-09 Robert Hogan <robert@webkit.org>
[Qt] Update expected results for unskipped editing/inserting tests
Unreviewed, remove platform-specific results for editing/inserting/6633727.html
- platform/qt/editing/inserting/6633727-expected.txt: Removed.
- 3:15 AM Changeset in webkit [59053] by
-
- 97 edits5 adds in trunk/LayoutTests
[Qt] Update expected results for unskipped editing/inserting tests
Unreviewed, add expected results for unskipped tests. Results are taken
from Qt bot.
- 2:52 AM Changeset in webkit [59052] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unskip editing/inserting tests that fail due to x/y differences
2010-05-03 Robert Hogan <robert@webkit.org>
Reviewed by Eric Seidel.
[Qt] Unskip editing/inserting tests that fail due to x/y differences
Unskip the following tests:
editing/inserting/12882.html
editing/inserting/4840662.html
editing/inserting/4875189-1.html
editing/inserting/4959067.html
editing/inserting/4960120-2.html
editing/inserting/5002441.html
editing/inserting/5058163-2.html
editing/inserting/5156401-2.html
editing/inserting/5418891.html
editing/inserting/5510537.html
editing/inserting/5549929-2.html
editing/inserting/5549929-3.html
editing/inserting/6633727.html
editing/inserting/6703873.html
editing/inserting/editable-inline-element.html
editing/inserting/insert-3654864-fix.html
editing/inserting/insert-3659587-fix.html
editing/inserting/insert-3775316-fix.html
editing/inserting/insert-3778059-fix.html
editing/inserting/insert-3786362-fix.html
editing/inserting/insert-3800346-fix.html
editing/inserting/insert-3851164-fix.html
editing/inserting/insert-3907422-fix.html
editing/inserting/insert-after-delete-001.html
editing/inserting/insert-at-end-01.html
editing/inserting/insert-at-end-02.html
editing/inserting/insert-before-link-1.html
editing/inserting/insert-br-001.html
editing/inserting/insert-br-002.html
editing/inserting/insert-br-003.html
editing/inserting/insert-br-004.html
editing/inserting/insert-br-005.html
editing/inserting/insert-br-006.html
editing/inserting/insert-br-007.html
editing/inserting/insert-br-008.html
editing/inserting/insert-br-009.html
editing/inserting/insert-br-at-tabspan-001.html
editing/inserting/insert-br-at-tabspan-002.html
editing/inserting/insert-br-at-tabspan-003.html
editing/inserting/insert-br-quoted-001.html
editing/inserting/insert-br-quoted-002.html
editing/inserting/insert-br-quoted-003.html
editing/inserting/insert-br-quoted-004.html
editing/inserting/insert-br-quoted-005.html
editing/inserting/insert-br-quoted-006.html
editing/inserting/insert-div-001.html
editing/inserting/insert-div-002.html
editing/inserting/insert-div-003.html
editing/inserting/insert-div-004.html
editing/inserting/insert-div-005.html
editing/inserting/insert-div-006.html
editing/inserting/insert-div-007.html
editing/inserting/insert-div-008.html
editing/inserting/insert-div-009.html
editing/inserting/insert-div-010.html
editing/inserting/insert-div-011.html
editing/inserting/insert-div-012.html
editing/inserting/insert-div-013.html
editing/inserting/insert-div-014.html
editing/inserting/insert-div-015.html
editing/inserting/insert-div-016.html
editing/inserting/insert-div-017.html
editing/inserting/insert-div-018.html
editing/inserting/insert-div-019.html
editing/inserting/insert-div-020.html
editing/inserting/insert-div-021.html
editing/inserting/insert-div-022.html
editing/inserting/insert-div-024.html
editing/inserting/insert-div-025.html
editing/inserting/insert-div-026.html
editing/inserting/insert-div-027.html
editing/inserting/insert-paragraph-01.html
editing/inserting/insert-paragraph-02.html
editing/inserting/insert-paragraph-03.html
editing/inserting/insert-paragraph-04.html
editing/inserting/insert-paragraph-05.html
editing/inserting/insert-space-in-empty-doc.html
editing/inserting/insert-tab-001.html
editing/inserting/insert-tab-002.html
editing/inserting/insert-tab-004.html
editing/inserting/insert-text-at-tabspan-001.html
editing/inserting/insert-text-at-tabspan-002.html
editing/inserting/insert-text-at-tabspan-003.html
editing/inserting/line-break.html
editing/inserting/paragraph-separator-01.html
editing/inserting/paragraph-separator-02.html
editing/inserting/paragraph-separator-in-table-1.html
editing/inserting/paragraph-separator-in-table-2.html
editing/inserting/redo.html
editing/inserting/return-key-with-selection-003.html
editing/inserting/typing-001.html
editing/inserting/typing-002.html
editing/inserting/typing-003.html
editing/inserting/typing-around-br-001.html
editing/inserting/typing-around-image-001.html
editing/inserting/5058163-1.html
editing/inserting/edited-whitespace-1.html
editing/inserting/paragraph-separator-03.html
editing/inserting/return-key-with-selection-001.html
editing/inserting/return-key-with-selection-002.html
editing/inserting/4875189-2.html
- platform/qt/Skipped:
- 2:50 AM Changeset in webkit [59051] by
-
- 2 edits in trunk/WebKitTools
2010-05-09 Daniel Bates <dbates@rim.com>
Reviewed by Chris Jerdonek.
Make the regular expressions for parsing the start of an SVN
and Git header global variables since they are used throughout
VCSUtils.pm.
- Scripts/VCSUtils.pm:
- 2:08 AM Changeset in webkit [59050] by
-
- 3 edits in trunk
2010-05-07 Daniel Bates <dbates@rim.com>
Unreviewed, change log fix.
Add back some entries inadvertently deleted in changeset 59000
<http://trac.webkit.org/changeset/59000> and not restored (as
intended) in changeset 59005 <http://trac.webkit.org/changeset/59005>.
- 1:42 AM Changeset in webkit [59049] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Add back some entries accidentally deleted in r59000 and not restored as intended in r59005.
- 12:21 AM Changeset in webkit [59048] by
-
- 7 edits in trunk/WebKitTools
2010-05-09 Chris Jerdonek <Chris Jerdonek>
Reviewed by Daniel Bates.
Finished moving the header-parsing logic from svn-apply and -unapply
to VCSUtils.pm's parsing methods.
- Scripts/VCSUtils.pm:
- Added to parseGitDiffHeader() the ability to parse and store whether a file is new or deleted.
- Also reordered in parseGitDiffHeader() some of the else statements to a more readable ordering.
- Added to parseSvnDiffHeader() the ability to parse and store whether a file is new.
- Scripts/svn-apply:
- Changed handleGitBinaryChange() to use the new "isNew" and "isDeletion" diffHash key-values.
- Changed patch() to use the new "isNew" diffHash key-value.
- Scripts/svn-unapply:
- Changed patch() to use the new "isNew" and "isDeletion" diffHash key-values.
- Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Added unit tests for new and deleted files.
- Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
- Updated the unit tests as necessary.
- Added a unit test for a deleted file.
- Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
- Updated the unit tests as necessary.
