⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 12, 2010:

11:44 PM Changeset in webkit [59349] by dumi@chromium.org
  • 6 edits
    2 adds in trunk/WebCore

Add the parent class for Database and DatabaseSync.
​https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/AbstractDatabase.cpp: Added.
  • storage/AbstractDatabase.h: Added.
11:39 PM Changeset in webkit [59348] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-12 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Remove transitional functions from WebStorageNamespace and WebViewClient.
​https://bugs.webkit.org/show_bug.cgi?id=38985

These functions are no longer called as of Chromium revision 47020.
This is part of resolving ​http://crbug.com/42740

  • public/WebStorageNamespace.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::createSessionStorageNamespace):
11:27 PM Changeset in webkit [59347] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-12 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: depth-test causes flicker in certain situations

This patch removes the simplistic 2D depth test as it leads to flickering side effects.
​https://bugs.webkit.org/show_bug.cgi?id=38370

Tested by ​http://webkit.org/blog-files/3d-transforms/morphing-cubes.html

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::updateTransform):
11:20 PM Changeset in webkit [59346] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-12 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] disable DRT in chromium again
​https://bugs.webkit.org/show_bug.cgi?id=39049

  • WebKit.gyp:
10:40 PM Changeset in webkit [59345] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59272.
​http://trac.webkit.org/changeset/59272
​https://bugs.webkit.org/show_bug.cgi?id=39047

Original change (59270) was rolled out (Requested by smfr on
#webkit).

  • platform/qt/editing/deleting/5408255-expected.txt:
10:39 PM Changeset in webkit [59344] by Chris Jerdonek
  • 3 edits
    1 add in trunk/WebKitTools

Fixed a bug in svn-apply whereby the reviewer would not get set if
the portion of the patch for the ChangeLog contains "NOBODY (PS!)"
in the leading junk.

Reviewed by Daniel Bates.

​https://bugs.webkit.org/show_bug.cgi?id=38998

  • Scripts/VCSUtils.pm:
    • Added the $changeLogTimeZone variable from svn-apply.
    • Added setChangeLogDateAndReviewer() from svn-apply.
    • Added a localTimeInProjectTimeZone() subroutine.
    • In setChangeLogDateAndReviewer():
      • Added an $epochTime parameter to make the subroutine more testable.
      • Made the "NOBODY (PS!)" regular expression more specific so that it will not apply to text in the leading junk.
      • Updated to call localTimeInProjectTimeZone().
  • Scripts/svn-apply:
    • Removed the $changeLogTimeZone file variable.
    • Added an $epochTime file variable to represent the current time.
    • Removed the setChangeLogDateAndReviewer() subroutine.
    • Updated patch() to use the new setChangeLogDateAndReviewer() syntax.
  • Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl: Added.
    • Added unit tests.
10:38 PM Changeset in webkit [59343] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59276.
​http://trac.webkit.org/changeset/59276
​https://bugs.webkit.org/show_bug.cgi?id=39046

Original change (59270) was rolled out (Requested by smfr on
#webkit).

  • platform/gtk/editing/deleting/delete-select-all-001-expected.txt:
10:28 PM Changeset in webkit [59342] by Simon Fraser
  • 13 edits
    5 deletes in trunk

2010-05-12 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe.

Fix layer dump to avoid spurious platform differences
​https://bugs.webkit.org/show_bug.cgi?id=39045

Only dump the children transform on layers that are not the root layer.
The children transform on the root layer is used on Leopard to implement
geometry flipping, so avoid this supurious difference in test output.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
9:45 PM Changeset in webkit [59341] by Simon Fraser
  • 9 edits
    2 deletes in trunk

2010-05-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59270.
​http://trac.webkit.org/changeset/59270
​https://bugs.webkit.org/show_bug.cgi?id=39044

Caused a crash on some pages - bug 39042 (Requested by smfr on
#webkit).

  • editing/deleting/delete-block-contents-004-expected.txt: Removed.
  • editing/deleting/delete-block-contents-004.html: Removed.
  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
  • platform/mac/fast/events/mouseout-dead-node-expected.txt:

2010-05-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59270.
​http://trac.webkit.org/changeset/59270
​https://bugs.webkit.org/show_bug.cgi?id=39044

Caused a crash on some pages - bug 39042 (Requested by smfr on
#webkit).

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
9:12 PM Changeset in webkit [59340] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

test-webkitpy fails on windows due to lack of readline module
​https://bugs.webkit.org/show_bug.cgi?id=38884

Win32 Python does not have a readline module, so we should
not exit(1) if the import fails.

Also the failure message is mac-specific and doesn't need to be.
Only print the mac-specific install instructions on mac.

  • Scripts/webkitpy/common/system/user.py:
9:01 PM Changeset in webkit [59339] by barraclough@apple.com
  • 22 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=39039
Provide support for separate bytecode/JIT code translations for call/construct usage
This will allow us to produce code generated specifically for use as a constructor, not for general function use.

Reviewed by Oliver Hunt.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::unlinkCallers):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::executablePool):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:
  • jit/JIT.cpp:

(JSC::JIT::unlinkCallOrConstruct):
(JSC::JIT::linkConstruct):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC::JITThunks::ctiVirtualConstructLink):
(JSC::JITThunks::ctiVirtualConstruct):
(JSC::):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • runtime/Arguments.h:

(JSC::JSActivation::copyRegisters):

  • runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCodeForCall):
(JSC::FunctionExecutable::generateJITCodeForConstruct):
(JSC::FunctionExecutable::markAggregate):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):

  • runtime/Executable.h:

(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::isHostFunction):
(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ExecutableBase::generatedJITCodeForConstruct):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::bytecodeForCall):
(JSC::FunctionExecutable::isGeneratedForCall):
(JSC::FunctionExecutable::generatedBytecodeForCall):
(JSC::FunctionExecutable::bytecodeForConstruct):
(JSC::FunctionExecutable::isGeneratedForConstruct):
(JSC::FunctionExecutable::generatedBytecodeForConstruct):
(JSC::FunctionExecutable::symbolTable):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::jitCodeForCall):
(JSC::FunctionExecutable::jitCodeForConstruct):

  • runtime/JSActivation.h:

(JSC::JSActivation::JSActivationData::JSActivationData):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::call):
(JSC::JSFunction::construct):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::numericCompareFunction):

8:27 PM Changeset in webkit [59338] by Simon Fraser
  • 10 edits
    4 adds in trunk

2010-05-12 Simon Fraser <Simon Fraser>

Reviewed by David Hyatt.

Composited plug-ins can cause missed painting
​https://bugs.webkit.org/show_bug.cgi?id=39033
<rdar://problem/7972478>

Fixed missed painting (and assertions in debug builds) related to compositing
propagating out of iframes that contain plug-ins.

When an iframe enters or leaves compositing mode, RenderLayerCompositor uses
setNeedsStyleRecalc(SyntheticStyleChange) to trigger the parent document to re-evaluate
whether the iframe itself should be composited. However, for iframes containing plug-ins,
this can happen at inappropriate times. For example, when a browser tab is brought frontmost,
plug-ins are instantiated for the first time (via -viewDidMoveToWindow), which triggers a
setNeedsStyleRecalc() on the object element. Soon after, the -viewWillDraw machinery
does layout from the top down. During layout of the iframe, the iframe enters compositing mode,
and does a setNeedsStyleRecalc() on the iframe element in its parent document. This leaves the
FrameView as needsLayout(), so the FrameView::paintContents() asserts and bails.

The fix is to avoid doing a setNeedsStyleRecalc() on the root while inside a recalcStyle on
the iframe. We do this by switching the iframe into compositing mode eagerly as soon as we know
the plug-in needs it.

A secondary fix is to ensure that if a document has composited iframes, when that document becomes
composited, we connect compositing layers between the iframes and the parent document.

Tests: compositing/iframes/connect-compositing-iframe-delayed.html

compositing/iframes/iframe-src-change.html

  • WebCore.base.exp: Export FrameView::enterCompositingMode()
  • page/FrameView.h: New method, enterCompositingMode(), that we can call from WebKit plug-in code.
  • page/FrameView.cpp: (WebCore::FrameView::enterCompositingMode):
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): When we switch into compositing mode, we

force a style recaclc on any iframes to get them into compositing layers, so they can hook up
with their content layers if necessary.

(WebCore::RenderLayerCompositor::didMoveOnscreen): Only call attachRootPlatformLayer() if we really need to.
(WebCore::RenderLayerCompositor::willMoveOffscreen): Only call detachRootPlatformLayer() if we really need to.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Whitespace.
(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange): Fetch iframe elements, and send a

synthetic style recalc on them.

8:20 PM Changeset in webkit [59337] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

<rdar://problem/7977960> REGRESSION (r59282): Tiger PPC build broken

8:12 PM Changeset in webkit [59336] by oliver@apple.com
  • 7 edits in trunk

2010-05-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

<rdar://7969718> Incorrect 32-bit codegen for op_jnlesseq
​https://bugs.webkit.org/show_bug.cgi?id=39038

Correct the use of incorrect comparison operators.

  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emitBinaryDoubleOp):

2010-05-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

<rdar://7969718> Incorrect 32-bit codegen for op_jnlesseq
​https://bugs.webkit.org/show_bug.cgi?id=39038

Add more tests for <=, <, >, and >=.

  • fast/js/comparison-operators-greater-expected.txt:
  • fast/js/comparison-operators-less-expected.txt:
  • fast/js/script-tests/comparison-operators-greater.js:
  • fast/js/script-tests/comparison-operators-less.js:
7:37 PM Changeset in webkit [59335] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-12 Joe Ligman <​joseph.ligman@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Nested overflow div does not scroll
​https://bugs.webkit.org/show_bug.cgi?id=38641

Modify qtwebkit_webframe_scrollOverflow, if the current node's render layer
does not scroll it will try and scroll the parent's render layer. Also export
qtwebkit_webframe_scrollOverflow so we can use it independently of
qtwebkit_webframe_scrollRecursively

  • Api/qwebframe.cpp: (qtwebkit_webframe_scrollOverflow): (qtwebkit_webframe_scrollRecursively):
7:25 PM Changeset in webkit [59334] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-05-12 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Eric Seidel.

JavaScriptCore: fix build when some optimizations are disabled
​https://bugs.webkit.org/show_bug.cgi?id=38800

Remove outdated UNUSED_PARAMs when using JIT but with
ENABLE_JIT_OPTIMIZE_CALL and ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
disabled.

  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
6:26 PM Changeset in webkit [59333] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Nate Chapin.

[DRT/Chromium] Add a missing Sans-serif font setting
​https://bugs.webkit.org/show_bug.cgi?id=38981

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Set "Helvetica" for Sans-serif. It is the same as the default setting of test_shell.
5:46 PM Changeset in webkit [59332] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-12 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Disable WebScrollbarImpl's scrollbar if it's not needed
​https://bugs.webkit.org/show_bug.cgi?id=39025

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::setDocumentSize):
5:41 PM Changeset in webkit [59331] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

5:34 PM Changeset in webkit [59330] by andersca@apple.com
  • 3 edits in trunk/WebCore

2010-05-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Simon Fraser.

Shrink the size of FillLayer by moving a member variable.
​https://bugs.webkit.org/show_bug.cgi?id=39035

  • rendering/style/FillLayer.cpp: (WebCore::FillLayer::FillLayer):
  • rendering/style/FillLayer.h:
5:32 PM Changeset in webkit [59329] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59192.

5:32 PM Changeset in webkit [59328] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59190.

5:32 PM WebKit Team edited by morrita@google.com
(diff)
5:32 PM Changeset in webkit [59327] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch/WebKit/win

Merge r59175.

5:32 PM Changeset in webkit [59326] by mrowe@apple.com
  • 11 edits in branches/safari-533-branch

Merge r59173.

5:31 PM Changeset in webkit [59325] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Merge r59155.

5:31 PM Changeset in webkit [59324] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebKit/mac

Merge r59125.

5:31 PM Changeset in webkit [59323] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533-branch

Merge r59109.

5:31 PM Changeset in webkit [59322] by mrowe@apple.com
  • 7 edits
    3 adds in branches/safari-533-branch

Merge r59100.

5:31 PM Changeset in webkit [59321] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533-branch

Merge r59098.

5:31 PM Changeset in webkit [59320] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/JavaScriptCore/jit/JITOpcodes.cpp

Merge r59065.

5:31 PM Changeset in webkit [59319] by mrowe@apple.com
  • 14 edits
    2 moves
    1 add
    1 delete in branches/safari-533-branch

Merge r59064.

5:30 PM Changeset in webkit [59318] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch/WebCore

Merge r59058.

5:30 PM Changeset in webkit [59317] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59009.

5:30 PM Changeset in webkit [59316] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore/platform/graphics/win

Merge r59008.

5:30 PM Changeset in webkit [59315] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h

Merge r59007.

5:30 PM Changeset in webkit [59314] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebCore/platform/graphics/win/QTMovieVisualContext.cpp

Merge r59003.

5:30 PM Changeset in webkit [59313] by mrowe@apple.com
  • 14 edits
    3 copies
    2 moves
    11 adds in branches/safari-533-branch

Merge r59001.

5:30 PM Changeset in webkit [59312] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r58983.

5:30 PM Changeset in webkit [59311] by mrowe@apple.com
  • 4 edits
    1 add in branches/safari-533-branch/WebCore

Merge r58950.

5:29 PM Changeset in webkit [59310] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533-branch

Merge r58936.

5:29 PM Changeset in webkit [59309] by mrowe@apple.com
  • 4 edits
    5 adds in branches/safari-533-branch

Merge r59147.

5:29 PM Changeset in webkit [59308] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch/WebCore

Merge r59116.

5:29 PM Changeset in webkit [59307] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533-branch

Merge r59111.

5:29 PM Changeset in webkit [59306] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKit/mac

Merge r59093.

5:29 PM Changeset in webkit [59305] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKit/mac

Merge r59086.

5:29 PM Changeset in webkit [59304] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch/WebKit/mac

Merge r58982.

5:29 PM Changeset in webkit [59303] by mrowe@apple.com
  • 10 edits in branches/safari-533-branch

Merge r58965.

5:29 PM Changeset in webkit [59302] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533-branch

Merge r58961.

5:28 PM Changeset in webkit [59301] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch

Merge r58960.

5:28 PM Changeset in webkit [59300] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59170.

5:28 PM Changeset in webkit [59299] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch/JavaScriptCore

Merge r59161.

5:28 PM Changeset in webkit [59298] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59061.

5:28 PM Changeset in webkit [59297] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch/JavaScriptCore

Merge r59056.

5:28 PM Changeset in webkit [59296] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/JavaScriptCore

Merge r59055.

5:28 PM Changeset in webkit [59295] by mrowe@apple.com
  • 7 edits
    1 add in branches/safari-533-branch/JavaScriptCore

Merge r59040.

5:28 PM Changeset in webkit [59294] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533-branch

Merge r58993.

5:28 PM Changeset in webkit [59293] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58991.

5:27 PM Changeset in webkit [59292] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58988.

5:27 PM Changeset in webkit [59291] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58987.

5:27 PM Changeset in webkit [59290] by mrowe@apple.com
  • 20 edits in branches/safari-533-branch/JavaScriptCore

Merge r58986.

5:27 PM Changeset in webkit [59289] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58974.

5:27 PM Changeset in webkit [59288] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58970.

5:27 PM Changeset in webkit [59287] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58964.

5:27 PM Changeset in webkit [59286] by mrowe@apple.com
  • 5 edits
    1 add in branches/safari-533-branch/JavaScriptCore

Merge r58935.

5:19 PM Changeset in webkit [59285] by mrowe@apple.com
  • 1 copy in branches/safari-533-branch

New branch.

4:55 PM Changeset in webkit [59284] by ojan@chromium.org
  • 5 edits in trunk/WebKitTools

2010-05-10 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietveld ID
​https://bugs.webkit.org/show_bug.cgi?id=38866

wkrietveld.appspot.com has already been updated to allow you to
pass --issue for the issue creation as well as subsequent uploads.

Also, remove the extra code for trying to read out the issue ID
from the changelog description since we just use the bugzilla ID now.

  • Scripts/webkitpy/common/config/init.py:
  • Scripts/webkitpy/common/net/rietveld.py:
  • Scripts/webkitpy/tool/steps/postcodereview.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
4:43 PM WebKit Team edited by ojan@chromium.org
(diff)
4:34 PM Changeset in webkit [59283] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-12 Ojan Vafai <​ojan@chromium.org>

No review needed.

Marking myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
4:25 PM Changeset in webkit [59282] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

Work around GCC stupidity by either explicitly inlining or by
using ALWAYS_INLINE

Reviewed by Gaving Barraclough.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):

  • runtime/UString.h:

(JSC::UString::~UString):

  • wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::RefPtr::~RefPtr):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::create):
(WebCore::StringImpl::tryCreateUninitialized):

4:21 PM Changeset in webkit [59281] by weinig@apple.com
  • 13 edits in trunk/WebCore

A bunch of nice micro-optimizations for ~1% speedup on PLT.

  • Add fastGetAttribute. The same as getAttribute except can only be called when it is known not to be style attribute or one of the SVG animatable attributes.
  • Inline some functions from Font.
  • Return the same string from deprecatedParseURL if there is nothing to strip.
  • Use a member variable instead of a virtual function to determine whether a ScheduledNavigation is a location change.

Reviewed by Anders Carlsson.

  • WebCore.base.exp:
  • css/CSSHelper.cpp:

(WebCore::deprecatedParseURL):

  • css/CSSStyleSelector.cpp:

(WebCore::linkAttribute):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • dom/Element.cpp:

(WebCore::Element::getAttribute):

  • dom/Element.h:

(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::formControlName):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::value):

  • loader/RedirectScheduler.cpp:

(WebCore::ScheduledNavigation::ScheduledNavigation):
(WebCore::ScheduledNavigation::isLocationChange):
(WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
(WebCore::ScheduledRedirect::ScheduledRedirect):
(WebCore::ScheduledLocationChange::ScheduledLocationChange):
(WebCore::ScheduledRefresh::ScheduledRefresh):
(WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
(WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
(WebCore::RedirectScheduler::locationChangePending):

  • platform/graphics/Font.cpp:
  • platform/graphics/Font.h:

(WebCore::Font::~Font):
(WebCore::Font::primaryFont):
(WebCore::Font::fontDataAt):
(WebCore::Font::fontDataForCharacters):
(WebCore::Font::isFixedPitch):
(WebCore::Font::fontSelector):

  • platform/graphics/FontFallbackList.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageMap):

3:48 PM Changeset in webkit [59280] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-12 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Change expectation from IMAGE to IMAGE+TEXT for Chromium Linux; I'm
not sure if this is flaky or not but it seems to be consistent on the
bot.

  • platform/chromium/test_expectations.txt:
3:36 PM Changeset in webkit [59279] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: add a --print default option so that you can
easily get the default output plus something (e.g., you can say
'--print default,config' instead of '--print misc,one-line-progress,
one-line-summary,unexpected,unexpected-results,updates,config'.

Also, add more unit tests for --verbose, --print everything, etc.

​https://bugs.webkit.org/show_bug.cgi?id=38877

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3:35 PM Changeset in webkit [59278] by dpranke@chromium.org
  • 8 edits
    2 adds in trunk/LayoutTests

2010-05-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Nate Chapin.

Expectations fix and new chromium baselines resulting from the
input type=search change in r58313.

​https://bugs.webkit.org/show_bug.cgi?id=38965

  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.checksum:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.checksum:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/search-zoomed-expected.checksum:
  • platform/mac/fast/forms/search-zoomed-expected.png:
3:33 PM Changeset in webkit [59277] by jianli@chromium.org
  • 15 edits
    3 adds in trunk/LayoutTests

Unreviewed. Chromium: rebaseline layout tests.

  • platform/chromium-linux/editing/deleting/5408255-expected.checksum:
  • platform/chromium-linux/editing/deleting/5408255-expected.png:
  • platform/chromium-linux/fast/css/pseudo-cache-stale-expected.checksum:
  • platform/chromium-linux/fast/css/pseudo-cache-stale-expected.png:
  • platform/chromium-mac/editing/deleting/5408255-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5408255-expected.png: Added.
  • platform/chromium-mac/fast/css/pseudo-cache-stale-expected.checksum: Added.
  • platform/chromium-win/editing/deleting/5408255-expected.checksum:
  • platform/chromium-win/editing/deleting/5408255-expected.png:
  • platform/chromium-win/editing/deleting/5408255-expected.txt:
  • platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
  • platform/chromium-win/editing/selection/4895428-1-expected.txt:
  • platform/chromium-win/editing/selection/4895428-4-expected.txt:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.checksum:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.png:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
  • platform/chromium-win/fast/events/mouseout-dead-node-expected.txt:
3:31 PM Changeset in webkit [59276] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

No review. Updating the baseline for this test after r59270.

  • platform/gtk/editing/deleting/delete-select-all-001-expected.txt:
3:10 PM Changeset in webkit [59275] by Csaba Osztrogonác
  • 3 edits in trunk/WebKitTools

Qt build failures cause SheriffBot false positives
​https://bugs.webkit.org/show_bug.cgi?id=38969

Reviewed by Adam Barth.

Add Qt bots back to the core builders, because bug fixed by r59261.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
3:07 PM Changeset in webkit [59274] by hyatt@apple.com
  • 23 edits
    1 delete in trunk/WebCore

Make InlineBoxes use an IntRect for dimensions, and eliminate the dynamic computation of height() every time.

Reviewed by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj:
  • editing/visible_units.cpp:

(WebCore::previousLinePosition):
(WebCore::nextLinePosition):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):

  • rendering/EllipsisBox.h:

(WebCore::EllipsisBox::EllipsisBox):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::adjustPosition):
(WebCore::InlineBox::canAccommodateEllipsis):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isSVGRootInlineBox):
(WebCore::InlineBox::x):
(WebCore::InlineBox::y):
(WebCore::InlineBox::width):
(WebCore::InlineBox::height):
(WebCore::InlineBox::bottom):
(WebCore::InlineBox::right):
(WebCore::InlineBox::setX):
(WebCore::InlineBox::setY):
(WebCore::InlineBox::setWidth):
(WebCore::InlineBox::setHeight):
(WebCore::InlineBox::location):
(WebCore::InlineBox::size):
(WebCore::InlineBox::setLocation):
(WebCore::InlineBox::setSize):
(WebCore::InlineBox::move):
(WebCore::InlineBox::frameRect):
(WebCore::InlineBox::setFrameRect):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::visibleOverflowRect):
(WebCore::InlineFlowBox::topLayoutOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::leftLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::topVisualOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::leftVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::setSpaceAdd):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPointWithInlineChildren):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeVerticalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::createInlineFlowBox):

  • rendering/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::createTextBox):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::createRootInlineBox):

  • rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::firstRunX):
(WebCore::RenderText::firstRunY):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeTextRun):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::closestLeafChildForXPos):

  • rendering/SVGInlineFlowBox.h:

(WebCore::SVGInlineFlowBox::SVGInlineFlowBox):

  • rendering/SVGInlineTextBox.h:

(WebCore::SVGInlineTextBox::selectionTop):
(WebCore::SVGInlineTextBox::selectionHeight):

  • rendering/SVGRootInlineBox.h:

(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::isSVGRootInlineBox):

  • rendering/TrailingFloatsRootInlineBox.h: Removed.
2:52 PM Changeset in webkit [59273] by dumi@chromium.org
  • 6 edits in trunk

Removing the unnecessary dirfd parameter.
​https://bugs.webkit.org/show_bug.cgi?id=38869

Reviewed by Dimitri Glazkov.

WebCore:

  • platform/chromium/ChromiumBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:

WebKit/chromium:

  • public/WebKitClient.h:

(WebKit::WebKitClient::databaseOpenFile):

  • src/ChromiumBridge.cpp:

(WebCore::ChromiumBridge::databaseOpenFile):

2:47 PM Changeset in webkit [59272] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix after r59270.
Update Qt specific expected result based on IRC discussing with Enrica Casucci.

  • platform/qt/editing/deleting/5408255-expected.txt: updated.
2:34 PM Changeset in webkit [59271] by jparent@chromium.org
  • 2 edits
    1 copy in trunk/BugsSite

Hide the in-rietveld flag in the UI. It is only used only by tooling and shouldn't clutter the UI.
​https://bugs.webkit.org/show_bug.cgi?id=39024

Reviewed by Ojan Vafai.

  • template/en/custom/attachment/list.html.tmpl: Removes this flag entirely from the UI, not needed on this page.
  • template/en/custom/flag/list.html.tmpl: Added. Copied from template/en/default/flag/list.html.tmpl with only changes inside the if WEBKIT_CHANGES section. Hides the flag rather than removing it completely, so tools can still interact with it.
2:24 PM Changeset in webkit [59270] by enrica@apple.com
  • 9 edits
    2 adds in trunk

Adding block elements to a block and removing them changes the height of the element.
​https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.

LayoutTests:

  • editing/deleting/delete-block-contents-004-expected.txt: Added.
  • editing/deleting/delete-block-contents-004.html: Added.

The following tests have new results because of the height change and because we now have one less renderer after the DOM changes.

  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
  • platform/mac/fast/events/mouseout-dead-node-expected.txt
2:21 PM Changeset in webkit [59269] by jianli@chromium.org
  • 14 edits
    15 adds in trunk/LayoutTests

Unreviewed. Chromium: rebaseline layout tests and mark one failed layout test.

  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:18 PM Changeset in webkit [59268] by agl@chromium.org
  • 2 edits
    8 adds in trunk/LayoutTests

2010-05-12 Adam Langley <​agl@chromium.org>

Expectations change. Unreviewed.

Add baselines for fast/css/font-face-woff.html.

  • platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Added.
  • platform/chromium-linux/fast/css/font-face-woff-expected.png: Added.
  • platform/chromium-mac/fast/css/font-face-woff-expected.checksum: Added.
  • platform/chromium-mac/fast/css/font-face-woff-expected.png: Added.
  • platform/chromium-mac/fast/css/font-face-woff-expected.txt: Added.
  • platform/chromium-win/fast/css/font-face-woff-expected.checksum: Added.
  • platform/chromium-win/fast/css/font-face-woff-expected.png: Added.
  • platform/chromium-win/fast/css/font-face-woff-expected.txt: Added.
2:08 PM Changeset in webkit [59267] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Do not check if a database needs to be vacuumed after a read-only transaction.
​https://bugs.webkit.org/show_bug.cgi?id=38972

Reviewed by Dimitri Glazkov.

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::postflightAndCommit):

2:04 PM Changeset in webkit [59266] by Csaba Osztrogonác
  • 2 edits in trunk

[Qt] Link error in debug mode without debug_and_release config
​https://bugs.webkit.org/show_bug.cgi?id=39006

Reviewed by Kenneth Rohde Christiansen.

  • WebKit.pri: Unnecessary build_pass guard removed.
1:57 PM Changeset in webkit [59265] by jparent@chromium.org
  • 4 edits
    1 add in trunk/BugsSite

Adds support for Rietveld reviews. When there is an associated
Rietveld id for a patch, adds a link to do a Rietveld review instead.

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=38143

  • attachment.cgi:

Added support for handling action=rietveldreview.

  • template/en/custom/attachment/list.html.tmpl:

Adds a link to use rietveld review iff the in_rietveld flag is set.

  • template/en/custom/attachment/reviewform.html.tmpl:

Detects if we are in rietveld review mode due to query string paramter,
and customizes the review form slightly:

  • Changes text describing comment field.
  • Comment field does not include quoted patch.
  • Submit button fetches from Rietveld instead of just submitting.
  • template/en/custom/attachment/rietveldreview.html.tmpl: Added.

New template for rietveldreview mode. Hosts the rietveld frame in the
top and the regular comments form in the bottom.
Uses postMessage to communicate with Rietveld frame.

1:56 PM Changeset in webkit [59264] by Csaba Osztrogonác
  • 9 edits in trunk

[Qt] Detect debug mode consistently
​https://bugs.webkit.org/show_bug.cgi?id=38863

Patch by Laszlo Gombos <Laszlo Gombos> on 2010-05-12
Reviewed by Kenneth Rohde Christiansen.

.:

  • WebKit.pri:

JavaScriptCore:

WebCore:

No new tests as there is no new functionality.

  • WebCore.pro:
1:51 PM Changeset in webkit [59263] by jamesr@google.com
  • 2 edits
    1 add in trunk/WebCore

2010-05-12 James Robinson <​jamesr@chromium.org>

Patch by Dan Bernstein.

Reviewed by David Hyatt.

Fix marking the layout root's parent as needing layout
​https://bugs.webkit.org/show_bug.cgi?id=37760

If an element gets marked as needing layout due to the recalcStyle()
call in FrameView::layout(), the m_layoutSchedulingEnabled flag will
be set to false. It's possible at this point that a parent of the
existing FrameView::m_layoutRoot will be marked as needing layout.

This patch updates FrameView::scheduleRelayoutOfSubtree to account
for this case.

Manual test only due to subtle timing issues.

  • manual-tests/layoutroot_detach.xml: Added.
  • page/FrameView.cpp: (WebCore::FrameView::scheduleRelayoutOfSubtree):
1:50 PM Changeset in webkit [59262] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Not reviewed.

[GTK] svg/custom/svg-fonts-with-no-element-reference.html is one pixel different on x86_64
​https://bugs.webkit.org/show_bug.cgi?id=39022

Skipping failing tests for GTK+.

  • platform/gtk/Skipped:
1:32 PM Changeset in webkit [59261] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

[Qt] Slave losts cause build break on bots
​https://bugs.webkit.org/show_bug.cgi?id=38980

Reviewed by Kenneth Rohde Christiansen.

  • Scripts/build-webkit: Remove 0 byte sized files from productDir before build.
1:24 PM Changeset in webkit [59260] by crogers@google.com
  • 4 edits in branches/audio/WebCore/audio

Add noteGrainOn() to AudioBufferSourceNode

  • this is a temporary name to get us going until final names determined
1:24 PM Changeset in webkit [59259] by crogers@google.com
  • 2 edits in branches/audio/WebCore

Add AudioPannerNode to DOMWindow so we can have panner constants

1:24 PM Changeset in webkit [59258] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/EqualPowerPanner.cpp

Fix EqualPowerPanner to always process the correct number of frames

1:24 PM Changeset in webkit [59257] by crogers@google.com
  • 1 edit in branches/audio/.gitignore

Update .gitignore to ignore a gyp-generated file

1:10 PM Changeset in webkit [59256] by eric@webkit.org
  • 8 edits
    2 deletes in trunk

2010-05-12 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59245.
​http://trac.webkit.org/changeset/59245
​https://bugs.webkit.org/show_bug.cgi?id=38874

Broke at least one test on multiple platforms

  • editing/deleting/delete-block-contents-004-expected.txt: Removed.
  • editing/deleting/delete-block-contents-004.html: Removed.
  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:

2010-05-12 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59245.
​http://trac.webkit.org/changeset/59245
​https://bugs.webkit.org/show_bug.cgi?id=38874

Broke at least one test on multiple platforms

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
1:08 PM Changeset in webkit [59255] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Unreviewed trivial fix after r59254.

  • Scripts/old-run-webkit-tests:
1:01 PM Changeset in webkit [59254] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

run-webkit-tests --exit-after-N-failures should not count new tests as failures
​https://bugs.webkit.org/show_bug.cgi?id=31829

Reviewed by Eric Seidel.

  • Scripts/old-run-webkit-tests:
12:48 PM Changeset in webkit [59253] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Not reviewed. Try number 3 to properly add new baselines and remove remaining
merge marker from this file.

  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
12:41 PM Changeset in webkit [59252] by jamesr@google.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix LayoutTest/ChangeLog bad merge

12:36 PM Changeset in webkit [59251] by jamesr@google.com
  • 3 edits in trunk/LayoutTests

2010-04-29 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Test that when a frame with fixed position elements is scrolled via the
keyboard that the correct repaints happen.
​https://bugs.webkit.org/show_bug.cgi?id=38286


  • fast/repaint/fixed-move-after-keyboard-scroll.html: Added.
  • fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
12:19 PM Changeset in webkit [59250] by ap@apple.com
  • 3 edits
    3 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=38752
Strange behaviour after js insertion into a page pointing directly to an object (image, swf, etc)

Test: fast/images/extra-image-in-image-document.html

  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement): Reset setAutoLoadImages after manually feeding an image - there may be more coming.
12:12 PM Changeset in webkit [59249] by Martin Robinson
  • 5 edits
    2 adds in trunk/LayoutTests

2010-05-12 Martin Robinson <Martin Robinson>

Not reviewed. Trying once more to generate baselines for GTK+.

  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/images/svg-background-partial-redraw-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/gtk/svg/custom/repaint-stroke-width-changes-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/repaint-stroke-width-changes-expected.txt.
12:09 PM Changeset in webkit [59248] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

HTMLLabelElement::control() should return HTMLFormControlElement, not HTMLElement
​https://bugs.webkit.org/show_bug.cgi?id=38991

Reviewed by Dan Bernstein.

No new tests since no new functionality was introduced.

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLLabelElement.h:
12:03 PM Changeset in webkit [59247] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=38891

Reviewed by Darin Adler.

First-letter had a number of bugs that were exposed by my attempt to optimize the setting of styles when updating first-letter.
The code that drills down to find the first-letter child stopped if it hit an element that didn't need layout. This means it could
return random incorrect results (and cause the first-letter object to not be found).

In addition when the first-letter was floated/positioned, the text child was not correctly returned, but the container itself was
returned instead.

Finally, the updating code was leaving the box that wrapped the first letter text with a stale style. The old code happened to work because
it made new styles for the text elements instead of using the enclosing box style. The regression was caused by my change to make the
text children simply share style with their parent (thus making the bug that the parent had the wrong style become more prominent).

No new tests, since there's a timing component to reproducing the issue.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

11:30 AM Changeset in webkit [59246] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-05-12 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Disable smooth scrolling on OS X when running tests
​https://bugs.webkit.org/show_bug.cgi?id=38964

Some tests (like fast/repaint/fixed-move-after-keyboard-scroll.html)
depend on smooth scrolling behavior. Since this is off by default
in Leopard and on by default in Snow Leopard, DRT should turn it
off always to ensure a consistent test environment.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
11:29 AM Changeset in webkit [59245] by enrica@apple.com
  • 8 edits
    2 adds in trunk

Adding block elements to a block and removing them changes the height of the element.
​https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.

LayoutTests:

  • editing/deleting/delete-block-contents-004-expected.txt: Added.
  • editing/deleting/delete-block-contents-004.html: Added.

The following tests have new results because of the height change and because we now have one less renderer after the DOM changes.

  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
11:26 AM Changeset in webkit [59244] by Martin Robinson
  • 1 edit
    22 adds in trunk/LayoutTests

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Not reviewed. Added baselines to these tests which are passing interactively.

  • platform/gtk/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
  • platform/gtk/fast/css/input-search-padding-expected.txt: Added.
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt: Added.
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-tranformed-expected.txt: Added.
  • platform/gtk/fast/text/format-control-expected.txt: Added.
  • platform/gtk/fast/text/international/bold-bengali-expected.txt: Added.
  • platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt.
  • platform/gtk/svg/text/text-hkern-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-hkern-expected.txt.
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt.
  • platform/gtk/svg/text/text-vkern-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-vkern-expected.txt.
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt.
  • platform/gtk/transforms/svg-vs-css-expected.txt: Added.
11:24 AM Changeset in webkit [59243] by pfeldman@chromium.org
  • 13 edits
    4 adds in trunk

2010-05-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: disabling style property on container breaks styles inspection for given node.

​https://bugs.webkit.org/show_bug.cgi?id=39005

Tests: inspector/styles-disable-inherited.html

inspector/styles-disable-then-enable.html

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._containsInherited): (WebInspector.StylesSidebarPane.prototype._arrayContainsInheritedProperty):
11:15 AM Changeset in webkit [59242] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

HTML Entity Escape the contents of a textarea node when accessed
via the innerHTML and outerHTML node properties.
​https://bugs.webkit.org/show_bug.cgi?id=38922

Patch by Abhishek Arya <​inferno@chromium.org> on 2010-05-12
Reviewed by Darin Adler.

Test: fast/innerHTML/innerHTML-special-elements.html

  • editing/markup.cpp:

(WebCore::appendStartMarkup):

11:13 AM Changeset in webkit [59241] by Darin Adler
  • 5 edits
    2 adds in trunk

2010-05-12 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Adler.

HTML Entity Escape the contents of a textarea node when accessed via the innerHTML and outerHTML node properties.
​https://bugs.webkit.org/show_bug.cgi?id=38922

Test: fast/encoding/textnode-XSS.html

  • editing/markup.cpp: (WebCore::appendStartMarkup):

2010-05-12 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Adler.

Tests that accessing the innerHTML property of a text node encodes
entities properly. Update existing test to fix the innerHTML result.
​https://bugs.webkit.org/show_bug.cgi?id=38922

  • fast/innerHTML/innerHTML-special-elements-expected.txt: Added.
  • fast/innerHTML/innerHTML-special-elements.html: Added.
  • fast/parser/comment-in-textarea-expected.txt: Update test expectation.
  • fast/parser/script-tests/comment-in-textarea.js: Update test by replacing with html entities of <, > chars in textarea innerHTML result.
10:11 AM Changeset in webkit [59240] by Martin Robinson
  • 6 edits in trunk/WebKit/gtk

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Use GOwnPtr for code that needs it
​https://bugs.webkit.org/show_bug.cgi?id=21594

Convert many uses of raw pointers to GRefPtr and GOwnPtr in WebKitWebView.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::inputMethodsMenuItem):
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState): (WebKit::EditorClient::respondToChangedSelection): (WebKit::EditorClient::handleInputMethodKeydown): (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::~EditorClient):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (destroy_menu_cb): (webkit_web_view_forward_context_menu_event): (webkit_web_view_key_release_event): (webkit_web_view_button_release_event): (webkit_web_view_focus_in_event): (webkit_web_view_focus_out_event): (webkit_web_view_realize): (webkit_web_view_set_scroll_adjustments): (webkit_web_view_dispose): (webkit_web_view_finalize): (webViewGetDPI): (webkit_web_view_screen_changed): (webkit_web_view_query_tooltip): (webkit_web_view_get_im_context): (webkit_web_view_update_settings): (webkit_web_view_init): (webkit_web_view_set_settings): (webkit_web_view_get_settings): (webkit_web_view_get_inspector): (webkit_web_view_set_window_features): (webkit_web_view_get_window_features): (webkit_web_view_get_back_forward_list): (webkit_web_view_zoom_in): (webkit_web_view_zoom_out): (webkit_web_view_get_encoding): (webkit_web_view_get_custom_encoding): (webkit_web_view_add_resource): (webkit_web_view_get_resource): (webkit_web_view_get_main_resource): (webkit_web_view_clear_resources): (webkit_web_view_get_subresources): (webkit_web_view_set_tooltip_text): (webkit_web_view_get_icon_uri):
9:52 AM Changeset in webkit [59239] by Beth Dakin
  • 5 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION:
Crash clicking background NPR tab after few minutes of sitting idle
-and corresponding-
<rdar://problem/7941504>

Reviewed by Darin Adler.

Move m_mediaCanStartListeners HashSet to Document away from Page.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::addMediaCanStartListener):
(WebCore::Document::removeMediaCanStartListener):
(WebCore::Document::takeAnyMediaCanStartListener):

  • dom/Document.h:
  • page/Page.cpp:

(WebCore::Page::takeAnyMediaCanStartListener):

  • page/Page.h:

(WebCore::Page::canStartMedia):

9:44 AM Changeset in webkit [59238] by jorlow@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-05-12 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

[Chromium] Pass the origin parameter for WebIndexedDatabase::open
​https://bugs.webkit.org/show_bug.cgi?id=38983

  • public/WebIndexedDatabase.h:
  • src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
  • src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h:
9:10 AM Changeset in webkit [59237] by loislo@chromium.org
  • 11 edits in trunk

2010-05-11 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Sometimes ResourceRequest records aren't connected to the initiator.
​https://bugs.webkit.org/show_bug.cgi?id=38925

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createScheduleResourceRequestData):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._findParentRecord): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
  • loader/loader.cpp: (WebCore::Loader::load):

2010-05-11 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Sometimes ResourceRequest records aren't connected to the initiator.
​https://bugs.webkit.org/show_bug.cgi?id=38925

  • inspector/timeline-enum-stability-expected.txt:
8:57 AM Changeset in webkit [59236] by tkent@chromium.org
  • 7 edits
    4 adds in trunk

2010-05-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

placeholder text should be stripped from line breaks
​https://bugs.webkit.org/show_bug.cgi?id=36291

Add a test for placeholder values with CR and LF.

  • fast/forms/placeholder-stripped.html: Added.
  • platform/mac/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/mac/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/mac/fast/forms/placeholder-stripped-expected.txt: Added.

2010-05-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

placeholder text should be stripped from line breaks
​https://bugs.webkit.org/show_bug.cgi?id=36291

According to ​http://dev.w3.org/html5/spec/forms.html#attr-input-placeholder ,
we need to remove CR and LF from the placeholder attribute values.
Introduce HTMLTextFormControlElement::strippedPlaceholder(), which
returns stripped value, and replace getAttribute(placeholderAttr) with it.

Test: fast/forms/placeholder-stripped.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::strippedPlaceholder): (WebCore::HTMLTextFormControlElement::isPlaceholderEmpty): (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible): Use strippedPlaceholder().
  • html/HTMLFormControlElement.h:
  • platform/text/CharacterNames.h: Add carriageReturn.
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::updateFromElement): Use strippedPlaceholder().
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::updateFromElement): Use strippedPlaceholder().
8:26 AM Changeset in webkit [59235] by tonikitoo@webkit.org
  • 5 edits in trunk

Allows build-webkit script to receive an install prefix as parameter ​https://bugs.webkit.org/show_bug.cgi?id=26224

Reviewed by Kenneth Christiansen , Simon Hausmann and Gustavo Noronha.
Patch by Rodrigo Belem <​rodrigo.belem@openbossa.org>

WebCore:

This patch adds the ability, in the QtWebkit build system, to change
the installation path.

  • WebCore.pro:

WebKitTools:

Added more parameters to build-webkit script, the --prefix for gkt
and --install-libs, --install-headers for qt. Now it is possible
to change the install prefix for gtk and install path for qt.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
8:05 AM Changeset in webkit [59234] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

[Qt] Remove the unneeded check for QWidgetPageClient @QGraphicsWebView::detachCurrentPage
​https://bugs.webkit.org/show_bug.cgi?id=38989

Reasons:

  • There is no need to check for a QWidgetPageClient-based in QGraphicsWebView.
  • The client has always to be deleted anyways.
  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::detachPage):
8:04 AM Changeset in webkit [59233] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] Implement a detachCurrentPage method for QGraphicsWebView and QWebView
​https://bugs.webkit.org/show_bug.cgi?id=38939

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

unsetPageIfExists method was renamed to detachCurrentPage method and is now responsible
for doing all the unset logic of page and pageClient references previously done by
the Q{Graphics}WebView destructor(s).

It is a code clean up, no behaviour change.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate):
(QGraphicsWebView::~QGraphicsWebView):
(QGraphicsWebViewPrivate::detachCurrentPage):
(QGraphicsWebView::setPage):

  • Api/qwebview.cpp:

(QWebViewPrivate::~QWebViewPrivate):
(QWebView::~QWebView):
(QWebViewPrivate::detachCurrentPage):
(QWebView::setPage):

7:35 AM Changeset in webkit [59232] by jer.noble@apple.com
  • 10 edits in trunk

2010-05-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Bug 38689: #34005 will break fullscreen video playback
​https://bugs.webkit.org/show_bug.cgi?id=38689

Use the new definition of PlatformMedia to check the actual type
returned by MediaPlayer.

  • FullscreenVideoController.cpp: (FullscreenVideoController::movie):

2010-05-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Bug 38689: #34005 will break fullscreen video playback
​https://bugs.webkit.org/show_bug.cgi?id=38689

Use the new definition of PlatformMedia to check the actual type
returned by MediaPlayer.


  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]):

2010-05-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.


Bug 38689: #34005 will break fullscreen video playback
​https://bugs.webkit.org/show_bug.cgi?id=38689


The PlatformMedia struct now contains a type field indicating which type
it contains. The struct now contains a union of all possible return types,
allowing the type of media returned by MediaPlayerPrivate instances to be
determined at runtime.

  • platform/graphics/MediaPlayer.h: (WebCore::PlatformMedia::): (WebCore::):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::platformMedia):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::platformMedia):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::platformMedia):
7:22 AM Changeset in webkit [59231] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Add a comment to explain the web inspector dynamic property url hook
and that it's there on purpose :)

Reviewed by Laszlo Gombos.

​https://bugs.webkit.org/show_bug.cgi?id=35340

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::openInspectorFrontend):

6:52 AM Changeset in webkit [59230] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-12 Young Han Lee <​joybro@company100.net>

Reviewed by Darin Adler.

Add missing ENABLE(SVG) guards.
​https://bugs.webkit.org/show_bug.cgi?id=38892

  • rendering/RenderSVGResourceClipper.cpp:
  • rendering/RenderSVGResourceMarker.cpp:
  • rendering/RenderSVGResourceMasker.cpp:
6:08 AM Changeset in webkit [59229] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-05-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: align sidebar checkboxes on windows.

​https://bugs.webkit.org/show_bug.cgi?id=38986

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/inspector.css: (.sidebar-pane-subtitle): (body.platform-windows .sidebar-pane-subtitle):
6:05 AM Changeset in webkit [59228] by Philippe Normand
  • 2 edits in trunk/WebKitTools

2010-05-12 Philippe Normand <​pnormand@igalia.com>

Unreviewed, added my IRC nickname.

  • Scripts/webkitpy/common/config/committers.py:
6:02 AM Changeset in webkit [59227] by yael.aharon@nokia.com
  • 10 edits
    10 adds in trunk

Support control attribute of HTMLLabelElement
​https://bugs.webkit.org/show_bug.cgi?id=38688

Reviewed by Darin Adler.

WebCore:

Added support for the control attribute of HTMLLabelElement and changed the logic of determining
which control is associated with the label to conform to HTML5 spec.
Added a manual test for testing the logic of selecting the control to get focused, activated or hovered
when the label gets focused, activated or is hovered.

Test: fast/dom/HTMLLabelElement/click-label.html
Test: fast/dom/HTMLLabelElement/focus-label.html
Test: fast/dom/HTMLLabelElement/label-control.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::labelForElement):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isLabelable):

  • html/HTMLFormControlElement.h:
  • html/HTMLLabelElement.cpp:

(WebCore::nodeAsLabelableFormControl):
(WebCore::HTMLLabelElement::control):
(WebCore::HTMLLabelElement::setActive):
(WebCore::HTMLLabelElement::setHovered):
(WebCore::HTMLLabelElement::defaultEventHandler):
(WebCore::HTMLLabelElement::focus):
(WebCore::HTMLLabelElement::accessKeyAction):

  • html/HTMLLabelElement.h:
  • html/HTMLLabelElement.idl:
  • manual-tests/dom/form-control-for-label.html: Added.

WebKit/chromium:

Renamed HTMLLabelElement::correspondingControl to HTMLLabelElement::control

  • src/WebLabelElement.cpp:

(WebKit::WebLabelElement::correspondingControl):

LayoutTests:

  • fast/dom/HTMLLabelElement/click-label-expected.txt: Added.
  • fast/dom/HTMLLabelElement/click-label.html: Added.
  • fast/dom/HTMLLabelElement/focus-label-expected.txt: Added.
  • fast/dom/HTMLLabelElement/focus-label.html: Added.
  • fast/dom/HTMLLabelElement/label-control-expected.txt: Added.
  • fast/dom/HTMLLabelElement/label-control.html: Added.
  • fast/dom/HTMLLabelElement/script-tests: Added.
  • fast/dom/HTMLLabelElement/script-tests/TEMPLATE.html: Added.
  • fast/dom/HTMLLabelElement/script-tests/label-control.js: Added.
5:51 AM Changeset in webkit [59226] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-12 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

Android's writeToFile() is buggy
​https://bugs.webkit.org/show_bug.cgi?id=38908

No new tests, build fix only.

  • platform/android/FileSystemAndroid.cpp: Remove Android's version of writeToFile().
  • platform/posix/FileSystemPOSIX.cpp: Use POSIX version of writeToFile() on Android. (WebCore::writeToFile):
5:21 AM Changeset in webkit [59225] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

Other tests make http/tests/xmlhttprequest/null-auth.php fail
​https://bugs.webkit.org/show_bug.cgi?id=32961

http/tests/xmlhttprequest/basic-auth-default.html introduced in r59185,
and it made http/tests/xmlhttprequest/null-auth.php fail on Qt bot, as
http/tests/xmlhttprequest/failed-auth.html did it before.

  • platform/qt/Skipped: http/tests/xmlhttprequest/basic-auth-default.html skipped until fix.
5:11 AM Changeset in webkit [59224] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-05-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by David Levin.

[GStreamer] incoherent #ifdef in GOwnPtrGStreamer.h
​https://bugs.webkit.org/show_bug.cgi?id=38839

Fixed #ifdef/curly braces coherence.

  • platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: (WTF::GstElement):
5:07 AM Changeset in webkit [59223] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-05-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dirk Schulze.

[GStreamer] un-needed cairo.h include
​https://bugs.webkit.org/show_bug.cgi?id=38837

Cairo not used in the sink anymore. So it's not needed to include
the header.

  • platform/graphics/gstreamer/VideoSinkGStreamer.h:
4:49 AM Changeset in webkit [59222] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-12 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Remove a direct jump in generatePatternCharacterGreedy() and
generatePatternCharacterClassGreedy() functions if quantityCount of the term
is unlimited.
​https://bugs.webkit.org/show_bug.cgi?id=38898

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
3:58 AM Changeset in webkit [59221] by zherczeg@webkit.org
  • 4 edits in trunk/WebCore

Build fix for Windows and Chromium builds.

Reviewed by Nikolas Zimmermann.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • svg/graphics/filters/SVGFELighting.cpp:

(WebCore::FELighting::LightingData::upLeftPixelValue):
(WebCore::FELighting::LightingData::upPixelValue):
(WebCore::FELighting::LightingData::upRightPixelValue):
(WebCore::FELighting::LightingData::leftPixelValue):
(WebCore::FELighting::LightingData::centerPixelValue):
(WebCore::FELighting::LightingData::rightPixelValue):
(WebCore::FELighting::LightingData::downLeftPixelValue):
(WebCore::FELighting::LightingData::downPixelValue):
(WebCore::FELighting::LightingData::downRightPixelValue):
(WebCore::FELighting::setPixel):

3:18 AM Changeset in webkit [59220] by zherczeg@webkit.org
  • 23 edits
    2 adds in trunk

WebCore: Implementing SVG filters: feDiffuseLighting and feSpecularLighting
​https://bugs.webkit.org/show_bug.cgi?id=32197
​https://bugs.webkit.org/show_bug.cgi?id=32199

Reviewed by Nikolas Zimmermann.

The patch implements the SVG filters feDiffuseLighting and
feSpecularLighting including the impementation of their possible
light sources according to the Scalable Vector Graphics (SVG)
1.1 Specification. Only two features are missing: supporting images
with height or width set to 1, and kernelUnitLength other than (1,1).
Since the two lighting filters have a similar body, a common base
class called FELighting is introduced, and contains the code for
both filters. The implementation employs single precision floating
point arithmetic (fixed precision integer arithmetic seemed too difficult).

Indentation is removed of the modified header files in svg/graphics/filters

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatPoint3D.cpp:
  • platform/graphics/FloatPoint3D.h:

(WebCore::FloatPoint3D::FloatPoint3D): constructors changed to inline
(WebCore::operator*): dot product

  • svg/SVGFESpotLightElement.cpp:

(WebCore::SVGFESpotLightElement::lightSource):

  • svg/graphics/filters/SVGDistantLightSource.h:

(WebCore::DistantLightSource::create):
(WebCore::DistantLightSource::azimuth):
(WebCore::DistantLightSource::elevation):
(WebCore::DistantLightSource::DistantLightSource):

  • svg/graphics/filters/SVGFEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::FEDiffuseLighting):
(WebCore::FEDiffuseLighting::create):

  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFELighting.cpp: Added.

(WebCore::FELighting::FELighting):
(WebCore::FELighting::LightingData::upLeftPixelValue):
(WebCore::FELighting::LightingData::upPixelValue):
(WebCore::FELighting::LightingData::upRightPixelValue):
(WebCore::FELighting::LightingData::leftPixelValue):
(WebCore::FELighting::LightingData::centerPixelValue):
(WebCore::FELighting::LightingData::rightPixelValue):
(WebCore::FELighting::LightingData::downLeftPixelValue):
(WebCore::FELighting::LightingData::downPixelValue):
(WebCore::FELighting::LightingData::downRightPixelValue):
(WebCore::FELighting::setPixel):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::apply):

  • svg/graphics/filters/SVGFELighting.h: Added.

(WebCore::FELighting::uniteChildEffectSubregions):
(WebCore::FELighting::):

  • svg/graphics/filters/SVGFESpecularLighting.cpp:

(WebCore::FESpecularLighting::FESpecularLighting):
(WebCore::FESpecularLighting::create):

  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGLightSource.cpp:

(WebCore::PointLightSource::initPaintingData):
(WebCore::PointLightSource::updatePaintingData):
(WebCore::SpotLightSource::initPaintingData):
(WebCore::SpotLightSource::updatePaintingData):
(WebCore::DistantLightSource::initPaintingData):
(WebCore::DistantLightSource::updatePaintingData):

  • svg/graphics/filters/SVGLightSource.h:

(WebCore::):
(WebCore::LightSource::LightSource):
(WebCore::LightSource::~LightSource):
(WebCore::LightSource::type):

  • svg/graphics/filters/SVGPointLightSource.h:

(WebCore::PointLightSource::create):
(WebCore::PointLightSource::position):
(WebCore::PointLightSource::PointLightSource):

  • svg/graphics/filters/SVGSpotLightSource.h:

(WebCore::SpotLightSource::create):
(WebCore::SpotLightSource::position):
(WebCore::SpotLightSource::direction):
(WebCore::SpotLightSource::specularExponent):
(WebCore::SpotLightSource::limitingConeAngle):
(WebCore::SpotLightSource::SpotLightSource):

LayoutTests: Updating the pixel tests for feDiffuseLighting and feSpecularLighting
​https://bugs.webkit.org/show_bug.cgi?id=32197
​https://bugs.webkit.org/show_bug.cgi?id=32199

Reviewed by Nikolas Zimmermann.

No new test were added, since SVG expected values cover
the features of the implementation

  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
2:35 AM Changeset in webkit [59219] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Nikolas Zimmermann.

Add missing AM_V_GEN directives to generation rules so that they
remain silent when requested.

  • GNUmakefile.am:
2:12 AM Changeset in webkit [59218] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-12 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Jeremy Orlow.

[EFL] It does not make sense to use ScrollbarEfl::ScrollbarEfl, so
use ScrollbarEfl (GCC 4.5 seems to be pickier about this). Revision 59030
fixed cases for RenderThemeEfl, but missed this for ScrollbarEfl.
​http://webkit.org/b/38904

No new tests required.

  • platform/efl/ScrollbarEfl.cpp: (scrollbarEflEdjeMessage):
1:51 AM Changeset in webkit [59217] by morrita@google.com
  • 9 edits in trunk

2010-05-12 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Support HTML5 <progress> element on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=37308

Extended ChromiumBridge to handle progress bar painting,
and added delegations to it.

No new tests. Test cases should be shared with existing ones for
progress element. Expectaions will be added after PROGRESS_TAG is
enabled on Chromium tree.

  • platform/chromium/ChromiumBridge.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::animationProgress): (WebCore::RenderProgress::isDeterminate):
  • rendering/RenderProgress.h: (WebCore::RenderProgress::position):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar): (WebCore::RenderThemeChromiumWin::adjustProgressBarStyle): (WebCore::RenderThemeChromiumWin::paintProgressBar):
  • rendering/RenderThemeChromiumWin.h:

2010-05-12 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Support HTML5 <progress> element on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=37308

Extended ChromiumBridge to handle progress bar painting,
and added delegations to it.

No new tests. Test cases should be shared with existing ones for
progress element. Expectaions will be added after PROGRESS_TAG is
enabled on Chromium tree.

  • public/WebThemeEngine.h: (WebKit::WebThemeEngine::paintProgressBar):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::paintProgressBar):
1:43 AM Changeset in webkit [59216] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-12 Marcus Bulach <​bulach@chromium.org>

Reviewed by Steve Block.

Removes Geolocation::setPosition and uses positionChanged() to capture lastPosition().
This brings CLIENT_BASED_GEOLOCATION more inline with the non-client based.
​https://bugs.webkit.org/show_bug.cgi?id=38195

  • page/Geolocation.cpp: (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::positionChangedInternal): (WebCore::Geolocation::positionChanged): (WebCore::Geolocation::geolocationServicePositionChanged):
  • page/Geolocation.h:
  • page/GeolocationController.cpp: (WebCore::GeolocationController::positionChanged): (WebCore::GeolocationController::lastPosition):
  • page/GeolocationController.h:
1:31 AM Changeset in webkit [59215] by eric@webkit.org
  • 5 edits in trunk

2010-05-12 Marcus Bulach <​bulach@chromium.org>

Reviewed by Steve Block.

Attaches the geolocation bridge later on startUpdating().
This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
so we attach the bridge if needed at requestGeolocationPermissionForFrame().
​https://bugs.webkit.org/show_bug.cgi?id=38323
​http://crbug.com/42789

  • platform/chromium/GeolocationServiceChromium.h:

2010-05-12 Marcus Bulach <​bulach@chromium.org>

Reviewed by Steve Block.

Attaches the geolocation bridge later on startUpdating().
This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
so we attach the bridge if needed at requestGeolocationPermissionForFrame().
​https://bugs.webkit.org/show_bug.cgi?id=38323
​http://crbug.com/42789

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition):
1:28 AM Changeset in webkit [59214] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix.

[Qt] Platform specific expected result updated after r59211.

  • platform/qt/fast/css/pseudo-cache-stale-expected.txt: updated.
1:19 AM Changeset in webkit [59213] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-05-12 Robin Qiu <​robin.qiu@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Fix a bug in SVGPathSegList::getPathSegAtLength().
This bug is just a misktake: almost all of the code is OK, but the
parameter is not used at all, therefore, this function always returns
"1".
And make a modification to return the last path segment if the distance
exceeds the actual path length.
​https://bugs.webkit.org/show_bug.cgi?id=37515

  • svg/dom/svgpath-getPathSegAtLength-expected.txt: Added.
  • svg/dom/svgpath-getPathSegAtLength.html: Added.

2010-05-12 Robin Qiu <​robin.qiu@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Fix a bug in SVGPathSegList::getPathSegAtLength().
This bug is just a misktake: almost all of the code is OK, but the
parameter is not used at all, therefore, this function always returns
"1".
And make a modification to return the last path segment if the distance
exceeds the actual path length.
​https://bugs.webkit.org/show_bug.cgi?id=37515

Test: svg/dom/svgpath-getPathSegAtLength.html

  • svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
12:46 AM Changeset in webkit [59212] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-12 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] add DRT back to the chromium build
​https://bugs.webkit.org/show_bug.cgi?id=38978

  • WebKit.gyp:
12:01 AM Changeset in webkit [59211] by hyatt@apple.com
  • 3 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=38976, fast/css/pseudo-cache-stale.html has incorrect results.

Reviewed by Maciej Stachowiak.

Make sure to trigger a relayout of any objects whose first-line styles change dynamically.

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):

May 11, 2010:

10:50 PM Changeset in webkit [59210] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-05-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Shorthand Properties Getting Deleted When Editing
​https://bugs.webkit.org/show_bug.cgi?id=38958

  • inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands): was getting regular values instead of shorthand values
10:10 PM Changeset in webkit [59209] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

2010-05-11 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

Fixed two FIXME's in svn-apply: eliminated the unnecessary %copiedFiles
variable and changed gitKnowsOfFile() to use exitStatus().

​https://bugs.webkit.org/show_bug.cgi?id=38862

  • Scripts/svn-apply:
9:58 PM WebKit Team edited by andreas.kling@nokia.com
(diff)
9:57 PM WebKit Team edited by andreas.kling@nokia.com
(diff)
9:56 PM Changeset in webkit [59208] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-11 Eric Seidel <​eric@webkit.org>

Unreviewed, just fixing python typo.

EWS bots should poll more often than every 5 minutes
​https://bugs.webkit.org/show_bug.cgi?id=38968

Typo in _now(), add a unittest to prove I fixed it.

  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
9:44 PM Changeset in webkit [59207] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Qt build failures cause SheriffBot false positives
​https://bugs.webkit.org/show_bug.cgi?id=38969

The Qt buildbot randomly fails to compile occasionally because its
network connection causes SVn to leave zero-byte files around. These
compile failures confuse SheriffBot into thinking someone's patch
caused a build break.

In this patch, I've temporarily removed Qt from the list of core
builders. Ossy is working on a script to clean up the zero byte files.
Once that goes in, we can add Qt back to the core builders.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
9:36 PM Changeset in webkit [59206] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

sheriffbot is spammy.
​https://bugs.webkit.org/show_bug.cgi?id=38936

Reduce sheriffbot spam by not warning about new blameworthy revisions
that can be explained by previously blamed revisions. This might cause
us to not warn about some real failures, but we're getting too much
spam from slow builders that have large blamelists (and we've already
poked the responsible folks using data from a fast builder).

  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
    • Removed unneeded import
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • The logic change
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
    • Tests of the change
  • Scripts/webkitpy/tool/mocktool.py:
    • Merged two declarations of MockBuilder
9:30 PM Changeset in webkit [59205] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Slight simplification to the calling convention: read RegisterFile::end()
from an absolute address, instead of from a pointer to the RegisterFile
on the stack.

Reviewed by Gavin Barraclough.

SunSpider reports no change.

This should free us to remove the RegisterFile argument from the stack.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

9:20 PM Changeset in webkit [59204] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-05-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

sheriffbot is spammy.
​https://bugs.webkit.org/show_bug.cgi?id=38936

Reduce sheriffbot spam by not warning about new blameworthy revisions
that can be explained by previously blamed revisions. This might cause
us to not warn about some real failures, but we're getting too much
spam from slow builders that have large blamelists (and we've already
poked the responsible folks using data from a fast builder).

  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
    • Removed unneeded import
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • The logic change
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
    • Tests of the change
  • Scripts/webkitpy/tool/mocktool.py:
    • Merged two declarations of MockBuilder
8:53 PM Changeset in webkit [59203] by tony@chromium.org
  • 4 edits in trunk

2010-05-11 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] Remove subframe scrollbar routing (r58937)
​https://bugs.webkit.org/show_bug.cgi?id=38894

  • platform/win/Skipped: This test should pass on windows.

2010-05-11 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] Remove subframe scrollbar routing (r58937)
​https://bugs.webkit.org/show_bug.cgi?id=38894

  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe):
8:53 PM Changeset in webkit [59202] by bweinstein@apple.com
  • 3 edits in trunk/JavaScriptCore

Possible Gtk build fix - use ALWAYS_INLINE on functions that were inlined.

  • wtf/text/AtomicString.h:

(WebCore::AtomicString::add): Use ALWAYS_INLINE.

  • wtf/text/WTFString.h:

(WebCore::String::length): Ditto.
(WebCore::String::isEmpty): Ditto.

8:51 PM Changeset in webkit [59201] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-11 Tony Chang <​tony@chromium.org>

Reviewed by David Levin.

[chromium] detect num processors to pass to make -j on Linux
​https://bugs.webkit.org/show_bug.cgi?id=38833

  • Scripts/webkitdirs.pm:
8:41 PM Changeset in webkit [59200] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-05-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should commit rollouts without running tests
​https://bugs.webkit.org/show_bug.cgi?id=38940

Most of this change is improving our test coverage for the commit-queue.
The only functional change is removing the --test flag when the commit-queue
is running in rollouts mode.

I added test coverage for status updates, and updated the commit-queue status
messages to distinguish rollout vs. normal landing mode in its empty queue
and land patch messages.

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
    • Got rid of a bunch of copy/paste code using _default_expected_stderr
  • Scripts/webkitpy/tool/commands/queues.py:
    • Moved rollout patch filtering out of _validate_patches_in_commit_queue so that we only have to check if the builders are green in one place.
    • Make the "empty queue" message note which queue it is referring to.
    • Don't pass --text to land-attachment when in rollout mode.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
    • Update results now that we're testing status updates.
    • Test _can_build_and_test since I made a typo in that call while writing this change and the unit tests failed to catch it!
  • Scripts/webkitpy/tool/mocktool.py:
    • Log status updates to make them testable in our unit tests.
8:25 PM Changeset in webkit [59199] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-05-11 Simon Fraser <Simon Fraser>

Reviewed by Maciej Stachowiak.

Body not redrawn, and filled with garbage on some composited pages
​https://bugs.webkit.org/show_bug.cgi?id=38951
<rdar://problem/7891548>

When the root layer becomes composited (for example, because a negative z-index
descendant in its stacking context becomes composited), then it has to be made
large enough to fill the viewport, because the page background draws into it.

Test: compositing/geometry/composited-html-size.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds):
7:33 PM Changeset in webkit [59198] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Add a compile time assert that sizeof(String) == sizeof(AtomicString).

Reviewed by Sam Weinig.

  • wtf/text/AtomicString.cpp:
7:28 PM Changeset in webkit [59197] by andersca@apple.com
  • 6 edits in trunk

2010-05-11 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=38961
Move some member variables around to reduce class sizes.


Make AtomicString no longer inherit from FastAllocBase.

Since AtomicString's first (and only) member variable, a RefPtr, also inherits from FastAllocBase this
was causing the size of AtomicString to contain sizeof(void*) bytes of padding.

  • wtf/text/AtomicString.h:

2010-05-11 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=38961
Move some member variables around to reduce class sizes.

If a class inherits (directly or indirectly) from FastAllocBase, we don't want the first member variable
of that class to also inherit (directly or indirectly) from FastAllocBase as this will add padding to the class
and thus increasing its size.

  • css/CSSParserValues.h:
  • css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::RareData::RareData):
  • platform/graphics/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
7:25 PM Changeset in webkit [59196] by bweinstein@apple.com
  • 8 edits in trunk/JavaScriptCore

Patch by Gavin Barraclough.

Reviewed by Maciej Stachowiak.

Rest of REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
​https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Inline string functions that are commonly used in WTFString, CString, and AtomicString.

  • JavaScriptCore.exp: Remove exports of inline functions.
  • wtf/text/AtomicString.cpp:

(WebCore::AtomicString::addSlowCase): Rename add to addSlowCase, and inline the fast path

of add.

  • wtf/text/AtomicString.h:

(WebCore::AtomicString::add): Inline the fast path of add.

  • wtf/text/CString.cpp: Inline implementation of data and length in the header.
  • wtf/text/CString.h:

(WTF::CString::data): Inline implementation of data.
(WTF::CString::length): Inline implementation of length.

  • wtf/text/WTFString.cpp: Remove implementations of functions to be inlined.
  • wtf/text/WTFString.h:

(WebCore::String::String): Inline implementation.
(WebCore::String::length): Ditto.
(WebCore::String::characters): Ditto.
(WebCore::String::operator[]): Ditto.
(WebCore::String::isEmpty): Ditto.

7:20 PM Changeset in webkit [59195] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Adding a function needed by the V8 code generator to turn on/off
the binding for WorkerContext::openDatabaseSync().
​https://bugs.webkit.org/show_bug.cgi?id=38960

Reviewed by Adam Barth.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):

  • bindings/generic/RuntimeEnabledFeatures.h:
7:15 PM Changeset in webkit [59194] by morrita@google.com
  • 3 edits
    5 adds in trunk

2010-05-11 MORITA Hajime <​morrita@google.com>

Reviewed by Dirk Schulze.

CSS SVG font doesn't recognize URL without element reference
​https://bugs.webkit.org/show_bug.cgi?id=37144

  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
  • svg/custom/resources/graffiti-with-empty-first-font.svg: Added.
  • svg/custom/svg-fonts-with-no-element-reference.html: Added.

2010-05-11 MORITA Hajime <​morrita@google.com>

Reviewed by Dirk Schulze.

CSS SVG font doesn't recognize URL without element reference
​https://bugs.webkit.org/show_bug.cgi?id=37144

CachedFont::getSVGFontById() did assume that element reference (ID) is given.
So fixed to handle an empty or missing element reference. In which case,
the first font element is returned if available.

Test: svg/custom/svg-fonts-with-no-element-reference.html

  • loader/CachedFont.cpp: (WebCore::CachedFont::getSVGFontById):
6:53 PM Changeset in webkit [59193] by tkent@chromium.org
  • 14 edits
    2 adds in trunk

2010-05-11 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Apply recent changes of test_shell to DRT
​https://bugs.webkit.org/show_bug.cgi?id=38895

  • DEPS: Update Chromium revision to use the recent webkit_support change.
  • WebKit.gyp: Add JavaScriptCore/wtf to 'include' section.
  • src/WebGraphicsContext3D.cpp: Remove ENABLE(3D_CANVAS) to provide an empty implementation of WebGraphicsContext3D::createDefault().

2010-05-11 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Apply recent changes of test_shell to DRT
​https://bugs.webkit.org/show_bug.cgi?id=38895

Port the changes to test_shell during (r40492, r46810] of Chromium.
Highlights:

  • Introduce NotificationPresenter
  • Fix parameter mismatch of WebViewClient::startDragging()

This change fixes dozens of unexpected behaviors.

  • DumpRenderTree/DumpRenderTree.gypi: Add NotificationPresenter.{cpp,h}
  • DumpRenderTree/chromium/EventSender.cpp: (applyKeyModifier): (EventSender::EventSender): (EventSender::reset): (EventSender::webview): (EventSender::doDragDrop): (EventSender::keyDown): (EventSender::addTouchPoint): (EventSender::clearTouchPoints): (EventSender::releaseTouchPoint): (EventSender::setTouchModifier): (EventSender::updateTouchPoint): (EventSender::cancelTouchPoint): (EventSender::sendCurrentTouchEvent): (EventSender::touchEnd): (EventSender::touchMove): (EventSender::touchStart): (EventSender::touchCancel):
  • DumpRenderTree/chromium/EventSender.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::showWebInspector): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setScrollbarPolicy): (LayoutTestController::setWillSendRequestClearHeader): (LayoutTestController::callShouldCloseOnWebView): (LayoutTestController::grantDesktopNotificationPermission): (LayoutTestController::removeOriginAccessWhitelistEntry): (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/NotificationPresenter.cpp: Added.
  • DumpRenderTree/chromium/NotificationPresenter.h: Added.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::runFileTest): (TestShell::resetTestController):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::eventSender): (TestShell::notificationPresenter): (TestShell::showDevTools):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): (WebViewHost::createPopupMenu): (WebViewHost::startDragging): (WebViewHost::notificationPresenter): (WebViewHost::createApplicationCacheHost): (WebViewHost::willSendRequest): (WebViewHost::updateAddressBar): (WebViewHost::updateURL):
  • DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::addClearHeader): (WebViewHost::clearHeaders):
6:35 PM Changeset in webkit [59192] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

No Review.

Fix the Windows Debug Build: the correct VCProj variable to use when linking against
JavaScriptCore is $(WebKitDLLConfigSuffix), not $(WebKitConfigSuffix), which expands
to an empty string rather than "_debug".

  • WebCore.vcproj/QTMovieWin.vcproj:
6:16 PM Changeset in webkit [59191] by jer.noble@apple.com
  • 2 edits in trunk/WebKit/win

No Review.

Fix build error: The QTMovieWin project is dependent on the JavaScriptCore project.

  • WebKit.vcproj/WebKit.sln:
5:41 PM Changeset in webkit [59190] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

2010-05-11 Jer Noble <​jer.noble@apple.com>

Darin Adler.

19 media tests are crashing on Windows Release
​https://bugs.webkit.org/show_bug.cgi?id=38950
rdar://problem/7971658

Link against JavaScriptCore.lib instead of WTF.lib, so the free and malloc used by
QTMovieWin is always the free and malloc in JavaScriptCore.dll.


  • WebCore.vcproj/QTMovieWin.vcproj:
5:35 PM Changeset in webkit [59189] by Darin Adler
  • 6 edits in trunk/WebCore

Another refactoring patch in preparation for a fix to
​https://bugs.webkit.org/show_bug.cgi?id=38871
REGRESSION: Crash clicking background NPR tab after few minutes of sitting idle

Reviewed by Beth Dakin.

  • dom/Document.cpp:

(WebCore::Document::addMediaCanStartListener): Added.
(WebCore::Document::removeMediaCanStartListener): Added.

  • dom/Document.h: Added add/removeMediaCanStartListener.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Call removeMediaCanStartListener
on the document instead of the page.
(WebCore::HTMLMediaElement::willMoveToNewOwnerDocument): Call
removeMediaCanStartListener on the current document.
(WebCore::HTMLMediaElement::didMoveToNewOwnerDocument): Call
addMediaCanStartListener on the new document.
(WebCore::HTMLMediaElement::loadInternal): Call addMediaCanStartListener
on the document instead of the page.

  • plugins/PluginView.cpp:

(WebCore::PluginView::startOrAddToUnstartedList): Call addMediaCanStartListener
on the document instead of the page.
(WebCore::PluginView::~PluginView): Call removeMediaCanStartListener
on the document instead of the page, and do it in line instead of calling
a function.

  • plugins/PluginView.h: Removed unused removeFromUnstartedListIfNecessary.
5:26 PM Changeset in webkit [59188] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Not reviewed.

​https://bugs.webkit.org/show_bug.cgi?id=38956
[Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails

  • platform/gtk/Skipped: Skipping the new failing test on Gtk.
5:22 PM Changeset in webkit [59187] by bweinstein@apple.com
  • 15 edits
    1 add in trunk

JavaScriptCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg and Jon Honeycutt.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
​https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

When the String classes were moved from WebCore to WTF, it meant that on Windows, all operations
on Strings in WebCore had to cross a DLL boundary (from WebKit.dll to JavaScript.dll).

We fix this by refactoring some of the WTF string code, so the code in AtomicString, StringImpl, and
WTFString can be built by both WebCore and WTF, and we don't need to talk across a DLL to do operations
on Strings.

handled in WebCore.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove the post-build step that was added

here (the post build step is in JavaScriptCoreCommon.vsprops).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Copy the three cpp files that need to be compiled

by WebCore into the WebKitOutputDir directory.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Add the StringStatics file.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Add the three WTF string cpp files to this project.
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Remove the need to link against WTF.lib (since jsc links against JavaScriptCore).
  • JavaScriptCore.xcodeproj/project.pbxproj: Add the StringStatics file.
  • wtf/text/AtomicString.cpp: Moved code to StringStatics.
  • wtf/text/StringImpl.cpp: Ditto.
  • wtf/text/StringStatics.cpp: Added. Move functions in WTF Strings that define static variables to here, so

the rest of the files can be compiled in WebCore.

(WebCore::StringImpl::empty): Moved from StringImpl.cpp to here.
(WebCore::AtomicString::init): Moved from AtomicString.cpp to here.

WebCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg and Jon Honeycutt.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
​https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Add the WTF strings into the WebCore vcproj, from their copied location in $(WebKitOutputDir).

No new tests because no change in behavior.

  • WebCore.vcproj/WebCore.vcproj:
5:04 PM Changeset in webkit [59186] by Beth Dakin
  • 3 edits in trunk/WebCore

Small re-factoring patch in preparation for fixing ​https://
bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION: Crash clicking
background NPR tab after few minutes of sitting idle

Reviewed by Darin Adler.

  • page/Page.cpp:

(WebCore::Page::takeAnyMediaCanStartListener):
(WebCore::Page::setCanStartMedia):

  • page/Page.h:
4:41 PM Changeset in webkit [59185] by ap@apple.com
  • 4 edits
    8 adds in trunk

Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=37989
Safari (still) doesn't always send basic credentials preemptively

Test: http/tests/xmlhttprequest/basic-auth-default.html

After fetching credentials from WebCore storage, put them back right away. This will add
default credentials for the directory, since this may be the first time we learn about its
associated protection space.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):
4:41 PM Changeset in webkit [59184] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Load a blank page on creation to initialize WebCore objects properly.
​https://bugs.webkit.org/show_bug.cgi?id=38932

4:39 PM Changeset in webkit [59183] by kevino@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Create an NSFont on Mac builds that do not have built-in methods to do so.
​https://bugs.webkit.org/show_bug.cgi?id=38931

4:22 PM Changeset in webkit [59182] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-10 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: fix a path-handling bug that was breaking the
dryrun ports on windows, and add a comment about why we don't run
the chromium dryrun tests by default on every port.

​https://bugs.webkit.org/show_bug.cgi?id=38796

  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:12 PM Changeset in webkit [59181] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/38941> build-webkit shouldn't always override ENABLE_FOO Xcode configuration settings

Reviewed by Darin Adler.

  • Scripts/build-webkit: Don't pass the ENABLE setting to xcodebuild if the value matches the default.

This will lead to xcodebuild picking up the settings from FeatureDefines.xcconfig, and will aid in
revealing problems that are due to inconsistent values for settings across projects.

4:11 PM Changeset in webkit [59180] by jianli@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed. Remove unneeded rebaselined result for enter-clicks-buttons.html

  • platform/chromium-win/fast/forms/enter-clicks-buttons-expected.txt: Removed.
4:04 PM Changeset in webkit [59179] by eric@webkit.org
  • 6 edits in trunk

2010-05-11 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Pipe RTL info into WebPopupMenuInfo
​https://bugs.webkit.org/show_bug.cgi?id=38749

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::menuStyle):
  • platform/chromium/PopupMenuChromium.h:

2010-05-11 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Pipe RTL info into WebPopupMenuInfo
​https://bugs.webkit.org/show_bug.cgi?id=38749

  • public/WebPopupMenuInfo.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::getPopupMenuInfo):
3:56 PM Changeset in webkit [59178] by alice.liu@apple.com
  • 4 edits in trunk

Fix build error when enabling debugging block in WebKit win painting code

Rubber-stamped by Gavin Barraclough.

JavaScriptCore:

WebKit/win:

  • WebView.cpp:

(WebView::paintIntoBackingStore):

3:43 PM Changeset in webkit [59177] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Build fix.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
3:39 PM Changeset in webkit [59176] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-11 David Holloway <​dhollowa@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add size method to WebInputElement class, providing same data
as HTMLInputElement::size(). During form AutoFill Chromium needs to
access the input element's size attribute in aid of form matching and
filling heuristics.

​https://bugs.webkit.org/show_bug.cgi?id=38825

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::size):
3:28 PM Changeset in webkit [59175] by alice.liu@apple.com
  • 8 edits in trunk/WebKit/win

​https://bugs.webkit.org/show_bug.cgi?id=38937
W7 window preview paints content at the wrong location

Reviewed by Steve Falkenburg.

  • WebFrame.cpp:

(WebFrame::paintDocumentRectToContext): Revert r58895
(WebFrame::paintDocumentRectToContextAtPoint): Added

  • Interfaces/IWebFramePrivate.idl: Added paintDocumentRectToContextAtPoint
  • Interfaces/IWebViewPrivate.idl: ditto
  • Interfaces/WebKit.idl: touch to rebuild
  • WebFrame.h: ditto
  • WebView.cpp: ditto

(WebView::paintDocumentRectToContextAtPoint): ditto

  • WebView.h: ditto
3:19 PM Changeset in webkit [59174] by mrowe@apple.com
  • 8 edits in trunk

Fix the world.

In r59162 a change was made to WebCore's FeatureDefines.xcconfig that enabled FILE_READER and FILE_WRITER.
The author and reviewer of that patch ignored the carefully-worded warning at the top of that file asking
that changes to the file be kept in sync across JavaScriptCore, WebCore and WebKit, as well as being kept
in sync with build-webkit. This led to WebCore and WebKit having different views of Document's vtable
and results in crashes in Safari shortly after launch when virtual function calls resulted in the wrong
function in WebCore being called.

We fix this by bringing the FeatureDefines.xcconfig files in to sync. Based on the ChangeLog message and
other changes in r59162 it appears that enabling FILE_WRITER was unintentional so that particular change
has been reverted.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:
3:01 PM Changeset in webkit [59173] by Dimitri Glazkov
  • 11 edits in trunk

2010-05-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
​https://bugs.webkit.org/show_bug.cgi?id=38913

Updated the test to include coverage of button elements.

  • fast/forms/enter-clicks-buttons-expected.txt: Updated expectations to account for implicit

submission which now correctly happens from the right element (button).

  • fast/forms/implicit-submission-expected.txt: Updated expectations with new test results.
  • fast/forms/implicit-submission.html: Added tests and code to cover button elements.

2010-05-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
​https://bugs.webkit.org/show_bug.cgi?id=38913

  • Widened the check for a successful submit button to include all HTMLFormControlElements.
  • Clarified implicit submission code by:
    • introducing HTMLFormControlElement::canTriggerImplicitSubmission flag,
    • getting rid of static casting and checking for tag names.
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::canTriggerImplicitSubmission): Added.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitImplicitly): Renamed parameters for clarity, refactored code

to use canTriggerImplicitSubmission.

  • html/HTMLFormElement.h: Renamed parameter for clarity.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Used canTriggerImplicitSubmission()

instead of isTextField() for clarity.

  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::canTriggerImplicitSubmission): Added.
  • html/HTMLIsIndexElement.h: (WebCore::HTMLIsIndexElement::canTriggerImplicitSubmission): Added.
2:35 PM Changeset in webkit [59172] by eric@webkit.org
  • 12 edits
    1 delete in trunk

2010-05-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59171.
​http://trac.webkit.org/changeset/59171
​https://bugs.webkit.org/show_bug.cgi?id=38933

"Broke the world" (Requested by bweinstein on #webkit).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/text/AtomicString.cpp: (WebCore::AtomicString::init):
  • wtf/text/StringImpl.cpp: (WebCore::StringImpl::empty):
  • wtf/text/StringStatics.cpp: Removed.

2010-05-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59171.
​http://trac.webkit.org/changeset/59171
​https://bugs.webkit.org/show_bug.cgi?id=38933

"Broke the world" (Requested by bweinstein on #webkit).

  • WebCore.vcproj/WebCore.vcproj:
1:52 PM Changeset in webkit [59171] by bweinstein@apple.com
  • 12 edits
    1 add in trunk

JavaScriptCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
​https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

When the String classes were moved from WebCore to WTF, it meant that on Windows, all operations
on Strings in WebCore had to cross a DLL boundary (from WebKit.dll to JavaScript.dll).

We fix this by refactoring some of the WTF string code, so the code in AtomicString, StringImpl, and
WTFString can be built by both WebCore and WTF, and we don't need to talk across a DLL to do operations
on Strings.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove string exports, because these are now

handled in WebCore.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove the post-build step that was added

here (the post build step is in JavaScriptCoreCommon.vsprops).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Copy the three cpp files that need to be compiled

by WebCore into the WebKitOutputDir directory.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Add the StringStatics file.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Add the three WTF string cpp files to this project.
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Remove the need to link against WTF.lib (since jsc links against JavaScriptCore).
  • JavaScriptCore.xcodeproj/project.pbxproj: Add the StringStatics file.
  • wtf/text/AtomicString.cpp: Moved code to StringStatics.
  • wtf/text/StringImpl.cpp: Ditto.
  • wtf/text/StringStatics.cpp: Added. Move functions in WTF Strings that define static variables to here, so

the rest of the files can be compiled in WebCore.

(WebCore::StringImpl::empty): Moved from StringImpl.cpp to here.
(WebCore::AtomicString::init): Moved from AtomicString.cpp to here.

WebCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
​https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Add the WTF strings into the WebCore vcproj, from their copied location in $(WebKitOutputDir).

No new tests because no change in behavior.

  • WebCore.vcproj/WebCore.vcproj:
1:38 PM Changeset in webkit [59170] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed test failures seen on SnowLeopard buildbot.

  • runtime/JSString.cpp:

(JSC::JSString::replaceCharacter): Don't use size_t and wtf::notFound.
Instead, use the individual types and notFound values of the string APIs
we're using, since they're not necessarily the same in 64bit.

1:32 PM Changeset in webkit [59169] by Nate Chapin
  • 2 edits in trunk/WebKit/chromium

2010-05-11 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Crash fix in WebPageSerializerImpl::serialize().

​https://bugs.webkit.org/show_bug.cgi?id=38543

The relevant test is a test_shell_test in src.chromium.org, because neither
DRT nor the Chromium webkit unit tests can currently cover the serializer
functionality.

  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::serialize): Check each frame's url before using it,

since they are not guaranteed to be valid (e.g., if the frame was treated as a download).

1:11 PM Changeset in webkit [59168] by ojan@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-10 Ojan Vafai <​ojan@chromium.org>

Reviewed by David Levin.

CheckStyle was eating script errors when there were local-commits and working copy changes
​https://bugs.webkit.org/show_bug.cgi?id=38880

  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Added.
12:58 PM Changeset in webkit [59167] by crogers@google.com
  • 2 edits in branches/audio/WebCore

Create a symlink in the built WebCore.framework/Resources to point to audio spatialization files

  • which exist in WebKit/WebCore/audio/AudioSpatialization
  • This is a temporary hack so that people can build WebKit "build-webkit" in my private "audio" branch and then
  • run the "run-safari" script to test out the new audio features.
12:55 PM Changeset in webkit [59166] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed. Fix compiling erron on snow leopard.

  • html/FileThreadTask.h:

(WebCore::createFileThreadTask):

12:48 PM Changeset in webkit [59165] by tonikitoo@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittently on Qt bot
​https://bugs.webkit.org/show_bug.cgi?id=37334

Rubber-stamped by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Removing unneeded call to LayoutTestController.display(). It was originally intending
to force a layout, but a re-layout will happen regardless because document.body.offsetTop
is called afterwards

  • fast/frames/flattening/frameset-flattening-subframe-resize.html:
  • platform/qt/Skipped:
12:37 PM Changeset in webkit [59164] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip file-reader.html that is not enabled in chromium yet.

  • platform/chromium/test_expectations.txt:
12:20 PM Changeset in webkit [59163] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] emit initialLayoutCompleted signal from FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout
​https://bugs.webkit.org/show_bug.cgi?id=38921

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Emit initialLayoutCompleted signal from FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout
instead of FrameLoaderClientQt::dispatchDidFirstLayout , because the former ensures that a
visual content layed out on the frame.

It matches to QWebFrame::initialLayoutCompleted signal documentation at:

"... This is the first time you will see contents displayed on the frame ..."

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
(WebCore::FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout):

12:04 PM Changeset in webkit [59162] by jianli@chromium.org
  • 28 edits
    1 copy
    10 adds in trunk

Expose FileReader interface.
​https://bugs.webkit.org/show_bug.cgi?id=38609

Reviewed by Dmitry Titov.

WebCore:

Test: fast/files/file-reader.html

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • html/FileError.idl:
  • html/FileReader.idl: Added.
  • page/DOMWindow.idl:

WebKit/chromium:

  • features.gypi: turn on building FileReader for Chromium.

WebKitTools:

  • Scripts/build-webkit: turn on building FileReader for Apple's WebKit.

LayoutTests:

Add a layout test to test basic FileReader operations.
Also update layout tests affected by adding the constructors to DOMWindow.

  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/constructed-objects-prototypes.js:
  • fast/dom/script-tests/prototype-inheritance-2.js:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/files/file-reader-expected.txt: Added.
  • fast/files/file-reader.html: Added.
  • fast/files/resources/UTF16BE-BOM.txt: Added.
  • fast/files/resources/UTF16BE.txt: Added.
  • fast/files/resources/UTF16LE-BOM.txt: Added.
  • fast/files/resources/UTF8-BOM.txt: Added.
  • fast/files/resources/UTF8.txt: Added.
  • fast/files/resources/empty-file: Added.
  • fast/js/script-tests/global-constructors.js:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in gtk platform.
  • platform/qt/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in qt platform.
  • platform/win/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in win platform.
11:42 AM Changeset in webkit [59161] by ggaren@apple.com
  • 7 edits in trunk/JavaScriptCore

Start using ropes in String.prototype.replace.

Reviewed by Oliver Hunt and Darin Adler.

1%-1.5% speedup on SunSpider.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope): Updated for RopeImpl refactoring.

(JSC::JSString::replaceCharacter): Added a replaceCharacter function, which creates
a rope for the resulting replacement.

  • runtime/JSString.h: A few changes here:

(JSC::):
(JSC::RopeBuilder::RopeIterator::RopeIterator):
(JSC::RopeBuilder::RopeIterator::operator++):
(JSC::RopeBuilder::RopeIterator::operator*):
(JSC::RopeBuilder::RopeIterator::operator!=):
(JSC::RopeBuilder::RopeIterator::WorkItem::WorkItem):
(JSC::RopeBuilder::RopeIterator::WorkItem::operator!=):
(JSC::RopeBuilder::RopeIterator::skipRopes): Created a RopeIterator abstraction.
We use this to do a substring find without having to resolve the rope.
(We could use this iterator when resolving ropes, too, but resolving
ropes backwards is usually more efficient.)

(JSC::RopeBuilder::JSString): Added constructors for 2 & 3 UStrings.

(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::size): Updated for RopeImpl refactoring.

  • runtime/Operations.h: Updated for RopeImpl refactoring.

(JSC::jsString): Added jsString functions for 2 & 3 UStrings.

  • runtime/RopeImpl.cpp:

(JSC::RopeImpl::derefFibersNonRecursive):

  • runtime/RopeImpl.h:

(JSC::RopeImpl::initializeFiber):
(JSC::RopeImpl::size):
(JSC::RopeImpl::fibers):
(JSC::RopeImpl::deref):
(JSC::RopeImpl::RopeImpl): A little refactoring to make this patch easier:
Moved statics to the top of the class; put multi-statement functions on
multiple lines; renamed "fiberCount" to "size" to match other collections;
changed the "fibers" accessor to return the fibers buffer, instead of an
item in the buffer, to make iteration easier.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace): Don't resolve a rope unless we need to. Do
use our new replaceCharacter function if possible. Do use a rope to
represent splicing three strings together.

11:35 AM Changeset in webkit [59160] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[chromium] Mark flaky layout tests.

  • platform/chromium/test_expectations.txt:
10:58 AM Changeset in webkit [59159] by jam@chromium.org
  • 1 edit in trunk/WebKit/chromium/src/WebScrollbarImpl.cpp

[chromium] Fix build break on Chromium Mac

10:53 AM Changeset in webkit [59158] by Martin Robinson
  • 3 edits in trunk/WebKit/gtk

2010-05-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Doesn't support gtk-key-themes
​https://bugs.webkit.org/show_bug.cgi?id=28257

Add support for GTK+ key themes.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::backspaceCallback): Added. (WebKit::cutClipboardCallback): Added. (WebKit::copyClipboardCallback): Added. (WebKit::pasteClipboardCallback): Added. (WebKit::selectAllCallback): Added. (WebKit::deleteFromCursorCallback): Added. (WebKit::moveCursorCallback): Added. (WebKit::EditorClient::generateEditorCommands): Added. (WebKit::EditorClient::executePendingEditorCommands): Added. (WebKit::EditorClient::handleKeyboardEvent): Derive editor commands both from internal text widget and a list of fallbacks. (WebKit::EditorClient::EditorClient): Add m_nativeWidget initializer.
  • WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::addPendingEditorCommand): Add m_nativeWidget member.
10:37 AM Changeset in webkit [59157] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-11 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[gtk] critical warning in soup_message_set_first_party() when cancelling a navigation
​https://bugs.webkit.org/show_bug.cgi?id=38653

Check if willSendRequest cancelled the request before setting the
first party for the cookies in the message, otherwise we'll get a
critical warning.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
10:11 AM Changeset in webkit [59156] by jam@chromium.org
  • 1 edit in trunk/WebKit/chromium/WebKit.gyp

Check in gyp changes for r59110

9:47 AM Changeset in webkit [59155] by weinig@apple.com
  • 4 edits in trunk/WebCore

REGRESSION (r59001): 11 media tests are failing on Windows (38847)
rdar://problem/7962997
​https://bugs.webkit.org/show_bug.cgi?id=38847

Patch by Jer Noble <​jer.noble@apple.com> on 2010-05-11
Reviewed by Adele Peterson.

QTMovieWin was too much refactored; the cacheMovieScale() function should have
been left in QTMovie (instead of being moved into QTMovieGWorld). This fixes the
video-size-intrinsic-scale test.

QTMovieTask::updateTaskTimer() was ignoring the maxInterval parameter unless
QTGetTimeUntilNextTask() returned an error, which caused the next timer to be
scheduled for extremely far in the future, breaking some of the layout tests.

QTMovieTask::fireTaskClients() now makes a local copy of the task list before
calling clients, in case one of them removes themselves from the task list and
invalidates our iterating pointer.

  • platform/graphics/win/QTMovie.cpp:

(QTMoviePrivate::task):
(QTMoviePrivate::createMovieController):
(QTMoviePrivate::cacheMovieScale):

  • platform/graphics/win/QTMovieGWorld.cpp:

(QTMovieGWorldPrivate::movieLoadStateChanged):

  • platform/graphics/win/QTMovieTask.cpp:

(QTMovieTask::updateTaskTimer):
(QTMovieTask::fireTaskClients):

9:38 AM Changeset in webkit [59154] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-11 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

Port SharedBuffer to WinCE.
​https://bugs.webkit.org/show_bug.cgi?id=37222

Use only functions which are available on Win32 and WinCE.

  • platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
9:14 AM Changeset in webkit [59153] by tkent@chromium.org
  • 1 edit
    2 adds
    6 deletes in trunk/LayoutTests

Merge some pseudo-valid-*.html tests into one.
​https://bugs.webkit.org/show_bug.cgi?id=38846

Reviewed by Shinichiro Hamaji.

No additional test cases and no removed test cases.

  • fast/css/pseudo-valid-003-expected.txt: Removed.
  • fast/css/pseudo-valid-003.html: Removed.
  • fast/css/pseudo-valid-005-expected.txt: Removed.
  • fast/css/pseudo-valid-005.html: Removed.
  • fast/css/pseudo-valid-006-expected.txt: Removed.
  • fast/css/pseudo-valid-006.html: Removed.
  • fast/css/pseudo-valid-unapplied-expected.txt: Added.
  • fast/css/pseudo-valid-unapplied.html: Added.
8:45 AM Changeset in webkit [59152] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-05-11 Jesus Sanchez-Palencia <​jesus@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Add PageClientQGraphicsWidget specific implementation.
QGraphicsWebViewPrivate doesn't inherit QWebPageClient anymore
and the needed functions were moved to this new PageClient class,
including Tiling and Accelerated Composite specific ones.

[Qt] PageClientQt specific implementation for QGraphicsWidget
​https://bugs.webkit.org/show_bug.cgi?id=37866

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::syncLayers): (QGraphicsWebViewPrivate::_q_scaleChanged): (QGraphicsWebView::event): (QGraphicsWebView::setPage): (QGraphicsWebView::updateGeometry): (QGraphicsWebView::setGeometry): (QGraphicsWebView::setResizesToContents):
  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::scroll): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay): (WebCore::PageClientQGraphicsWidget::syncLayers): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer): (WebCore::PageClientQGraphicsWidget::markForSync): (WebCore::PageClientQGraphicsWidget::updateCompositingScrollPosition): (WebCore::PageClientQGraphicsWidget::updateTiledBackingStoreScale): (WebCore::PageClientQGraphicsWidget::setInputMethodEnabled): (WebCore::PageClientQGraphicsWidget::inputMethodEnabled): (WebCore::PageClientQGraphicsWidget::setInputMethodHint): (WebCore::PageClientQGraphicsWidget::cursor): (WebCore::PageClientQGraphicsWidget::updateCursor): (WebCore::PageClientQGraphicsWidget::palette): (WebCore::PageClientQGraphicsWidget::screenNumber): (WebCore::PageClientQGraphicsWidget::ownerWidget): (WebCore::PageClientQGraphicsWidget::geometryRelativeToOwnerWidget): (WebCore::PageClientQGraphicsWidget::pluginParent): (WebCore::PageClientQGraphicsWidget::style):
  • WebCoreSupport/PageClientQt.h: (WebCore::QGraphicsItemOverlay::page): (WebCore::QGraphicsItemOverlay::boundingRect): (WebCore::QGraphicsItemOverlay::paint): (WebCore::QGraphicsItemOverlay::prepareGraphicsItemGeometryChange): (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::isQWidgetClient): (WebCore::PageClientQGraphicsWidget::allowsAcceleratedCompositing): (WebCore::PageClientQGraphicsWidget::):
8:18 AM QtWebKitTriageRoster edited by Laszlo Gombos
(diff)
8:15 AM Changeset in webkit [59151] by eric@webkit.org
  • 4 edits in trunk

2010-05-11 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/text/find-hidden-text.html
​https://bugs.webkit.org/show_bug.cgi?id=32922

Remove fast/text/find-hidden-text.html from the skipped list of Qt.

  • platform/qt/Skipped:

2010-05-11 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/text/find-hidden-text.html
​https://bugs.webkit.org/show_bug.cgi?id=32922

Use the real page step for populating the QStyleOption otherwhise
the size can be negative, which can break the QStyle used.

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
7:15 AM Changeset in webkit [59150] by pfeldman@chromium.org
  • 10 edits in trunk

2010-05-11 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make styles rendering more user-friendly.

​https://bugs.webkit.org/show_bug.cgi?id=36747

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): (WebInspector.ComputedStyleSidebarPane): (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.collapse): (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
  • inspector/front-end/inspector.css: (#elements-content): (#elements-sidebar): (.styles-sidebar-separator): (.styles-section): (.styles-section .header): (.styles-section .header .title): (.styles-section .header .subtitle): (.styles-section .header .subtitle a): (.styles-section .properties): (.styles-section.no-affect .properties li): (.styles-section.no-affect .properties li.editing): (.styles-section.expanded .properties): (.styles-section .properties li): (.styles-section .properties li.parent): (.styles-section .properties ol): (.styles-section .properties ol.expanded): (.styles-section .properties li.parent::before): (.styles-section .properties li.parent.expanded::before): (.styles-section .properties li .info): (.styles-section:hover .properties .enabled-button): (.styles-section .properties li.disabled .enabled-button): (.styles-section .properties .enabled-button): (.styles-section .properties .overloaded, .styles-section .properties .disabled): (.styles-section.computed-style .properties .disabled): (.styles-section .properties .implicit, .styles-section .properties .inherited): (.styles-section .properties .inherited): (.styles-section.show-inherited .properties .inherited):
6:09 AM Changeset in webkit [59149] by johnnyg@google.com
  • 3 edits
    7 adds in trunk/LayoutTests

2010-05-11 John Gregg <​johnnyg@google.com>

[chromium] Unreviewed, test expectations.

  • platform/chromium-mac/svg/filters/filteredImage-expected.checksum: Added.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/filters/filteredImage-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filteredImage-expected.png: Added.
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png: Added.
  • platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
5:11 AM Changeset in webkit [59148] by Nikolas Zimmermann
  • 13 edits
    10 adds in trunk

2010-05-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Move buildLayoutInformationForTextBox() from SVGRootInlineBox in SVGInlineTextBox where it belongs
​https://bugs.webkit.org/show_bug.cgi?id=38799

Cleanup SVGRootInlineBox/SVGInlineTextBox. Move buildLayoutInformationForTextBox to SVGInlineTextBox.
Move lots of helper methods into new SVGTextLayoutUtilities class. Adapted all callsites.

Fixed bug in kerning handling, hkern was applyable to vertical text as well. Covered by two new tests.

Tests: svg/text/text-hkern-on-vertical-text.svg

svg/text/text-vkern-on-horizontal-text.svg

  • Android.mk: Add SVGTextLayoutUtilities.cpp/h to build.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): Use textRenderer()->characters() instead of textRenderer()->text()->characters() as shortcut. (WebCore::SVGInlineTextBox::svgCharacterHitsPosition): Fix style issue, no else if after a return branch. (WebCore::SVGInlineTextBox::paintSelection): Use !color.alpha() instead of color.alpha() == 0. (WebCore::SVGInlineTextBox::buildLayoutInformation): Moved from SVGRootInlineBox::buildLayoutInformationForTextBox.
  • rendering/SVGInlineTextBox.h: Fix indention. (WebCore::SVGInlineTextBox::selectionTop): Inlined. (WebCore::SVGInlineTextBox::selectionHeight): Inlined.
  • rendering/SVGRenderTreeAsText.cpp: Include SVGTextLayoutUtilities.h
  • rendering/SVGRootInlineBox.cpp: Move almost all static text layout helper functions in SVGTextLayoutUtilities (WebCore::calculateTextLengthCorrectionForTextChunk): Fixed style issue in long if conditions spanning multiple lines. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Use different topLeftPositionOfCharacterRange() taking start/end iterators. (WebCore::SVGRootInlineBox::buildLayoutInformation): Use the moved SVGInlineTextBox::buildLayoutInformation() method. (WebCore::SVGRootInlineBox::buildTextChunks): Fixed small style issue, remove unneeded parenthesis. (WebCore::SVGRootInlineBox::layoutTextChunks): Fix style issue in debugging code.
  • rendering/SVGRootInlineBox.h: Rename 'LastGlyphInfo' to 'SVGLastGlyphInfo' and move to SVGTextLayoutUtilities. (WebCore::SVGRootInlineBox::svgTextChunks): Inlined for speed.
  • rendering/SVGTextLayoutUtilities.cpp: Added. (WebCore::isVerticalWritingMode): (WebCore::dominantBaselineToShift): (WebCore::alignmentBaselineToShift): (WebCore::glyphOrientationToAngle): (WebCore::glyphOrientationIsMultiplyOf180Degrees): (WebCore::applyGlyphAdvanceAndShiftRespectingOrientation): (WebCore::topLeftPositionOfCharacterRange): (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::cummulatedHeightOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox): (WebCore::calculateCSSKerning): (WebCore::applySVGKerning):
  • rendering/SVGTextLayoutUtilities.h: Added. (WebCore::): (WebCore::SVGTextPaintInfo::SVGTextPaintInfo): (WebCore::SVGLastGlyphInfo::SVGLastGlyphInfo):

2010-05-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Move buildLayoutInformationForTextBox() from SVGRootInlineBox in SVGInlineTextBox where it belongs
​https://bugs.webkit.org/show_bug.cgi?id=38799

  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.png: Added.
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.checksum: Added.
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
  • svg/text/text-hkern-on-vertical-text.svg: Added.
  • svg/text/text-vkern-on-horizontal-text.svg: Added.
2:22 AM Changeset in webkit [59147] by zherczeg@webkit.org
  • 4 edits
    5 adds in trunk

WebCore: RenderSVGImage::imageChanged should invalidate the SVG filter cache
​https://bugs.webkit.org/show_bug.cgi?id=38838

Reviewed by Dirk Schulze.

Test: svg/filters/filteredImage.svg

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::imageChanged):

LayoutTests: Test case for SVG filter cache invalidation, after an image resource arrives.
​https://bugs.webkit.org/show_bug.cgi?id=38838

Reviewed by Dirk Schulze.

  • platform/gtk/Skipped:
  • platform/mac/svg/filters/filteredImage-expected.checksum: Added.
  • platform/mac/svg/filters/filteredImage-expected.png: Added.
  • platform/mac/svg/filters/filteredImage-expected.txt: Added.
  • platform/qt/svg/filters/filteredImage-expected.txt: Added.
  • svg/filters/filteredImage.svg: Added.
1:08 AM Changeset in webkit [59146] by Simon Fraser
  • 1 edit
    6 adds in trunk/LayoutTests

2010-05-11 Simon Fraser <Simon Fraser>

Test result fixes for Leopard.

Leopard needs custom results for tests that dump the layer tree, because Leopard
CA does not have geometry flipping, so we do that ourselves by setting a transform.

  • platform/mac-leopard/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
12:24 AM Changeset in webkit [59145] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-10 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] don't build DRT in chromium checkouts due to a circular gyp dependency
​https://bugs.webkit.org/show_bug.cgi?id=38889

  • WebKit.gyp:
12:18 AM Changeset in webkit [59144] by johnnyg@google.com
  • 3 edits in trunk/LayoutTests

2010-05-11 John Gregg <​johnnyg@google.com>

[chromium] Update win-vista version of the baseline recently updated for win-xp.

  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.txt:
Note: See TracTimeline for information about the timeline view.