Context Navigation

Skip new test that fails on Qt. I'm sure skipping is the wrong thing
but no one is around to help me figure out what the right thing to do
is and I don't want to leave the bot red all weekend.

platform/qt/Skipped:

9:46 PM Changeset in webkit [59516] by adele@apple.com

3 edits
2 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=39095
<rdar://problem/7984158> REGRESSION (r53085): Infinite recursion in Position::getInlineBoxAndOffset when changing writing direction to right-to-left

Reviewed by Dave Hyatt.

Test: editing/selection/applystyle-to-inline-inside-block.html

dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): Now that this function correctly goes in and out of editable areas by calling

downstreamIgnoringEditingBoundaries and upstreamIgnoringEditingBoundaries for blocks (added in r58665), we no longer need a special case to
jump out to the parent when we hit an inline (which was added in r53085 when this issue was introduced).

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=39095
<rdar://problem/7984158> REGRESSION (r53085): Infinite recursion in Position::getInlineBoxAndOffset when changing writing direction to right-to-left

Reviewed by Dave Hyatt.

editing/selection/applystyle-to-inline-in-block-expected.txt: Added.
editing/selection/applystyle-to-inline-in-block.html: Added.

8:49 PM Changeset in webkit [59515] by bweinstein@apple.com

2 edits in trunk/WebCore

Hopefully a last fix for the build. Call -mkdir instead of mkdir, so we don't bail if the mkdir call fails. Additionally,
use the %Env% syntax instead of $(Env), which is what we need if we are referring to Windows environment variables instead
of nmake variables.

Reviewed by Mark Rowe.

WebCore.vcproj/WebCore.make:

8:40 PM Changeset in webkit [59514] by Stephanie Lewis

6 edits in trunk

Update order files.

Rubber-stamped by Mark Rowe.

JavaScriptCore:

JavaScriptCore.order:

WebCore:

WebCore.order:

WebKit/mac:

WebKit.order:

8:17 PM Changeset in webkit [59513] by hyatt@apple.com

16 edits
2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=39137

Reviewed by Simon Fraser.

WebCore:

Make RenderLayers position properly inside multicolumn layout.

(1) Create RenderLayers when column properties are specified. This allows descendant layers to easily
know they are inside a multicolumn layout when positioning.

(2) Patch updateLayerPosition to offset the layer into the first column that contains the layer. Splitting
of a layer across columns still does not work, but the layer will now at least appear in the first column in
which it occurs.

(3) Fix pagination bugs caused by the fact that visual overflow doesn't propagate up the line box tree when layers
are involved. Make sure to use lineTop and lineBottom in this case (it's not perfect, but it gets most cases
working properly). With this change elements like <video> will paginate properly and not get split across pages.

(4) Make column repainting and layer positioning work with RTL columns by fixing adjustForColumns to
account for RTL.

(5) Fix RTL pagination by making sure the column pagination rects are the content width of the whole block and not just
the width of one column.

Added fast/multicol/layers-in-multicol.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustForColumns):

rendering/RenderBox.h:

(WebCore::RenderBox::locationOffset):

rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::requiresLayer):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):

rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

rendering/RenderView.h:

(WebCore::RenderView::requiresLayer):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::specifiesColumns):

LayoutTests:

Reset all multicolumn test results now that columns create RenderLayers.

fast/multicol/client-rects-expected.txt:
fast/multicol/layers-in-multicol.html: Added.
fast/multicol/single-line-expected.txt:
platform/mac/fast/multicol/column-rules-expected.txt:
platform/mac/fast/multicol/columns-shorthand-parsing-expected.txt:
platform/mac/fast/multicol/float-avoidance-expected.txt:
platform/mac/fast/multicol/float-multicol-expected.txt:

Add a layout test for various types of RenderLayers inside multicol layouts.

platform/mac/fast/multicol/layers-in-multicol-expected.txt: Added.

7:54 PM Changeset in webkit [59512] by eric@webkit.org

5 edits in trunk

2010-05-14 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Consider implementing addOriginAccessWhitelistEntry method
https://bugs.webkit.org/show_bug.cgi?id=37578

Remove deprecated methods.

public/WebSecurityPolicy.h:
src/WebSecurityPolicy.cpp:

2010-05-14 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Consider implementing addOriginAccessWhitelistEntry method
https://bugs.webkit.org/show_bug.cgi?id=37578

Remove deprecated methods.

DumpRenderTree/chromium/LayoutTestController.cpp
DumpRenderTree/chromium/LayoutTestController.h

6:57 PM Changeset in webkit [59511] by eric@webkit.org

4 edits in trunk/WebCore

2010-05-14 Leon Clarke <leonclarke@google.com>

Reviewed by Steve Block.

Refactor signature of tokenizeRelAttribute and the variables it refers to so that new features don't keep changing the signature, and make m_disabledState into an enum.
https://bugs.webkit.org/show_bug.cgi?id=38900

No new tests. Refactoring only.

html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute): (WebCore::HTMLLinkElement::isAlternate): (WebCore::HTMLLinkElement::isDisabled): (WebCore::HTMLLinkElement::isEnabledViaScript): (WebCore::HTMLLinkElement::isIcon): (WebCore::HTMLLinkElement::):
html/PreloadScanner.cpp: (WebCore::PreloadScanner::processAttribute):

6:43 PM Changeset in webkit [59510] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-14 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer caches directly composited images
https://bugs.webkit.org/show_bug.cgi?id=38444

Directly-composited images and solid fills shouldn't be cached, as that cache
is never used (see GraphicsLayerQtImpl::paint). Cache is only relevant for HTML content,
but we were missing that test.
The fix makes sure we only cache HTML content.

No new tests: this is a minor optimization.

platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):

6:18 PM Changeset in webkit [59509] by mrowe@apple.com

5 edits in tags/Safari-533.9.2

Versioning.

6:08 PM Changeset in webkit [59508] by mrowe@apple.com

2 edits in tags/Safari-533.9.2/WebCore

Merge r59505.

5:56 PM Changeset in webkit [59507] by mrowe@apple.com

1 copy in tags/Safari-533.9.2

New tag.

5:55 PM Changeset in webkit [59506] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebCore

Merge r59505.

5:45 PM Changeset in webkit [59505] by bweinstein@apple.com

2 edits in trunk/WebCore

Build fix. Had the environment variables wrong for source and destination of the copy operation
that was added.

Reviewed by Mark Rowe.

WebCore.vcproj/WebCore.make:

5:29 PM Changeset in webkit [59504] by ap@apple.com

2 edits
4 moves in trunk/LayoutTests

Inspired by Simon Fraser, rubber-stamped by Geoff Garen.

Disabled Sputnik tests that take over 10 seconds in debug builds on my MacBook Pro.

platform/mac-tiger/Skipped: These tests were alrady skipped on Tiger, no need to skip explicitly any more.

fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html: Removed.
fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html-disabled: Copied from fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html.
fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html: Removed.
fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html-disabled: Copied from fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html.
fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html: Removed.
fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html-disabled: Copied from fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html.
fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html: Removed.
fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html-disabled: Copied from fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html.

5:08 PM Changeset in webkit [59503] by eric@webkit.org

9 edits in trunk/JavaScriptCore

2010-05-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Implementation of QtScript API that provide method to convert a value to an object.

[Qt] QtScript is missing toObject API
https://bugs.webkit.org/show_bug.cgi?id=36594

qt/api/qscriptengine.cpp: (QScriptEngine::toObject):
qt/api/qscriptengine.h:
qt/api/qscriptvalue.cpp: (QScriptValue::toObject):
qt/api/qscriptvalue.h:
qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toObject):
qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::toObject): (tst_QScriptEngine::toObjectTwoEngines):
qt/tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::toObjectSimple):
qt/tests/qscriptvalue/tst_qscriptvalue.h:

4:34 PM Changeset in webkit [59502] by abarth@webkit.org

7 edits in trunk/WebCore

2010-05-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove custom bindings for HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=38344

Fix a bug in the TestObj.idl file and update expected results. This
was originally part of a larger change reviewed by Eric, but I'm
landing it separately to help me understand the more interesting bits
of the patch clearly.

bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property):
bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjAttrWithSetterException): (WebCore::setJSTestObjAttrWithSetterException): (WebCore::setJSTestObjAttrWithGetterException):
bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj setAttrWithGetterException:]):
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):

4:12 PM Changeset in webkit [59501] by jparent@chromium.org

2 edits in trunk/BugsSite

Bugzilla: Only show "Rietveld Review" link when in-rietveld is set to +.

Reviewed by Ojan Vafai.

https://bugs.webkit.org/show_bug.cgi?id=39141

template/en/custom/attachment/list.html.tmpl:

3:54 PM Changeset in webkit [59500] by jparent@chromium.org

2 edits in trunk/BugsSite

Bugzilla: Don't send mail if the only change is to the in-rietveld flag.

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=39090

Bugzilla/BugMail.pm:

3:52 PM EFLWebKit edited by leandro@profusion.mobi

(diff)

3:52 PM EFLWebKit edited by leandro@profusion.mobi

(diff)

3:50 PM EFLWebKit edited by leandro@profusion.mobi

(diff)

3:50 PM EFLWebKit edited by leandro@profusion.mobi

(diff)

3:37 PM Changeset in webkit [59499] by kbr@google.com

30 edits
64 moves in trunk

2010-05-14 Kenneth Russell <kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData):

2010-05-14 Kenneth Russell <kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

DerivedSources.make:
GNUmakefile.am:
WebCore.gypi:
WebCore.pri:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSArrayBufferConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLArrayBufferConstructor.cpp. (WebCore::): (WebCore::JSArrayBufferConstructor::JSArrayBufferConstructor): (WebCore::constructCanvasArrayBuffer): (WebCore::JSArrayBufferConstructor::getConstructData):
bindings/js/JSArrayBufferConstructor.h: Copied from WebCore/bindings/js/JSWebGLArrayBufferConstructor.h. (WebCore::construct):
bindings/js/JSArrayBufferViewCustom.cpp: Copied from WebCore/bindings/js/JSWebGLArrayCustom.cpp. (WebCore::toJS): (WebCore::JSArrayBufferView::slice):
bindings/js/JSArrayBufferViewHelper.h: Copied from WebCore/bindings/js/JSWebGLArrayHelper.h.
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray): (WebCore::JSDOMWindow::webGLArrayBuffer): (WebCore::JSDOMWindow::webGLByteArray): (WebCore::JSDOMWindow::webGLUnsignedByteArray): (WebCore::JSDOMWindow::webGLIntArray): (WebCore::JSDOMWindow::webGLUnsignedIntArray): (WebCore::JSDOMWindow::webGLShortArray): (WebCore::JSDOMWindow::webGLUnsignedShortArray): (WebCore::JSDOMWindow::webGLFloatArray):
bindings/js/JSFloatArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLFloatArrayConstructor.cpp. (WebCore::): (WebCore::JSFloatArrayConstructor::JSFloatArrayConstructor): (WebCore::constructCanvasFloatArray): (WebCore::JSFloatArrayConstructor::getConstructData):
bindings/js/JSFloatArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLFloatArrayConstructor.h.
bindings/js/JSFloatArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLFloatArrayCustom.cpp. (WebCore::JSFloatArray::indexSetter): (WebCore::toJS): (WebCore::JSFloatArray::set):
bindings/js/JSInt16ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLShortArrayConstructor.cpp. (WebCore::): (WebCore::JSInt16ArrayConstructor::JSInt16ArrayConstructor): (WebCore::constructCanvasShortArray): (WebCore::JSInt16ArrayConstructor::getConstructData):
bindings/js/JSInt16ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLShortArrayConstructor.h.
bindings/js/JSInt16ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLShortArrayCustom.cpp. (WebCore::JSInt16Array::indexSetter): (WebCore::toJS): (WebCore::JSInt16Array::set):
bindings/js/JSInt32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLIntArrayConstructor.cpp. (WebCore::): (WebCore::JSInt32ArrayConstructor::JSInt32ArrayConstructor): (WebCore::constructCanvasIntArray): (WebCore::JSInt32ArrayConstructor::getConstructData):
bindings/js/JSInt32ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLIntArrayConstructor.h.
bindings/js/JSInt32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLIntArrayCustom.cpp. (WebCore::JSInt32Array::indexSetter): (WebCore::toJS): (WebCore::JSInt32Array::set):
bindings/js/JSInt8ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLByteArrayConstructor.cpp. (WebCore::): (WebCore::JSInt8ArrayConstructor::JSInt8ArrayConstructor): (WebCore::constructCanvasByteArray): (WebCore::JSInt8ArrayConstructor::getConstructData):
bindings/js/JSInt8ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLByteArrayConstructor.h.
bindings/js/JSInt8ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLByteArrayCustom.cpp. (WebCore::JSInt8Array::indexSetter): (WebCore::toJS): (WebCore::JSInt8Array::set):
bindings/js/JSUint16ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp. (WebCore::): (WebCore::JSUint16ArrayConstructor::JSUint16ArrayConstructor): (WebCore::constructCanvasUnsignedShortArray): (WebCore::JSUint16ArrayConstructor::getConstructData):
bindings/js/JSUint16ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayConstructor.h.
bindings/js/JSUint16ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayCustom.cpp. (WebCore::JSUint16Array::indexSetter): (WebCore::toJS): (WebCore::JSUint16Array::set):
bindings/js/JSUint32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp. (WebCore::): (WebCore::JSUint32ArrayConstructor::JSUint32ArrayConstructor): (WebCore::constructCanvasUnsignedIntArray): (WebCore::JSUint32ArrayConstructor::getConstructData):
bindings/js/JSUint32ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayConstructor.h.
bindings/js/JSUint32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayCustom.cpp. (WebCore::JSUint32Array::indexSetter): (WebCore::toJS): (WebCore::JSUint32Array::set):
bindings/js/JSUint8ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp. (WebCore::): (WebCore::JSUint8ArrayConstructor::JSUint8ArrayConstructor): (WebCore::constructCanvasUnsignedByteArray): (WebCore::JSUint8ArrayConstructor::getConstructData):
bindings/js/JSUint8ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayConstructor.h.
bindings/js/JSUint8ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayCustom.cpp. (WebCore::JSUint8Array::indexSetter): (WebCore::toJS): (WebCore::JSUint8Array::set):
bindings/js/JSWebGLArrayBufferConstructor.cpp: Removed.
bindings/js/JSWebGLArrayBufferConstructor.h: Removed.
bindings/js/JSWebGLArrayCustom.cpp: Removed.
bindings/js/JSWebGLArrayHelper.h: Removed.
bindings/js/JSWebGLByteArrayConstructor.cpp: Removed.
bindings/js/JSWebGLByteArrayConstructor.h: Removed.
bindings/js/JSWebGLByteArrayCustom.cpp: Removed.
bindings/js/JSWebGLFloatArrayConstructor.cpp: Removed.
bindings/js/JSWebGLFloatArrayConstructor.h: Removed.
bindings/js/JSWebGLFloatArrayCustom.cpp: Removed.
bindings/js/JSWebGLIntArrayConstructor.cpp: Removed.
bindings/js/JSWebGLIntArrayConstructor.h: Removed.
bindings/js/JSWebGLIntArrayCustom.cpp: Removed.
bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::bufferData): (WebCore::JSWebGLRenderingContext::bufferSubData): (WebCore::JSWebGLRenderingContext::texImage2D): (WebCore::JSWebGLRenderingContext::texSubImage2D): (WebCore::dataFunctionf): (WebCore::dataFunctioni): (WebCore::dataFunctionMatrix):
bindings/js/JSWebGLShortArrayConstructor.cpp: Removed.
bindings/js/JSWebGLShortArrayConstructor.h: Removed.
bindings/js/JSWebGLShortArrayCustom.cpp: Removed.
bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp: Removed.
bindings/js/JSWebGLUnsignedByteArrayConstructor.h: Removed.
bindings/js/JSWebGLUnsignedByteArrayCustom.cpp: Removed.
bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp: Removed.
bindings/js/JSWebGLUnsignedIntArrayConstructor.h: Removed.
bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: Removed.
bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp: Removed.
bindings/js/JSWebGLUnsignedShortArrayConstructor.h: Removed.
bindings/js/JSWebGLUnsignedShortArrayCustom.cpp: Removed.
bindings/v8/V8DOMWrapper.cpp:
bindings/v8/custom/V8ArrayBufferCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLArrayBufferCustom.cpp. (WebCore::V8ArrayBuffer::constructorCallback):
bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLArrayCustom.cpp. (WebCore::toV8): (WebCore::V8ArrayBufferView::sliceCallback):
bindings/v8/custom/V8ArrayBufferViewCustom.h: Copied from WebCore/bindings/v8/custom/V8WebGLArrayCustom.h. (WebCore::constructWebGLArray):
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::WebGLArrayBufferAccessorGetter): (WebCore::V8DOMWindow::WebGLByteArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLUnsignedByteArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLShortArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLUnsignedShortArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLIntArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLUnsignedIntArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLFloatArrayAccessorGetter):
bindings/v8/custom/V8FloatArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLFloatArrayCustom.cpp. (WebCore::V8FloatArray::constructorCallback): (WebCore::V8FloatArray::setCallback): (WebCore::toV8):
bindings/v8/custom/V8Int16ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLShortArrayCustom.cpp. (WebCore::V8Int16Array::constructorCallback): (WebCore::V8Int16Array::setCallback): (WebCore::toV8):
bindings/v8/custom/V8Int32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLIntArrayCustom.cpp. (WebCore::V8Int32Array::constructorCallback): (WebCore::V8Int32Array::setCallback): (WebCore::toV8):
bindings/v8/custom/V8Int8ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLByteArrayCustom.cpp. (WebCore::V8Int8Array::constructorCallback): (WebCore::V8Int8Array::setCallback): (WebCore::toV8):
bindings/v8/custom/V8Uint16ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp. (WebCore::V8Uint16Array::constructorCallback): (WebCore::V8Uint16Array::setCallback): (WebCore::toV8):
bindings/v8/custom/V8Uint32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp. (WebCore::V8Uint32Array::constructorCallback): (WebCore::V8Uint32Array::setCallback): (WebCore::toV8):
bindings/v8/custom/V8Uint8ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp. (WebCore::V8Uint8Array::constructorCallback): (WebCore::V8Uint8Array::setCallback): (WebCore::toV8):
bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: Removed.
bindings/v8/custom/V8WebGLArrayCustom.cpp: Removed.
bindings/v8/custom/V8WebGLArrayCustom.h: Removed.
bindings/v8/custom/V8WebGLByteArrayCustom.cpp: Removed.
bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: Removed.
bindings/v8/custom/V8WebGLIntArrayCustom.cpp: Removed.
bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
bindings/v8/custom/V8WebGLShortArrayCustom.cpp: Removed.
bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: Removed.
bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: Removed.
bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: Removed.
html/canvas/ArrayBuffer.cpp: Copied from WebCore/html/canvas/WebGLArrayBuffer.cpp. (WebCore::ArrayBuffer::create): (WebCore::ArrayBuffer::ArrayBuffer): (WebCore::ArrayBuffer::data): (WebCore::ArrayBuffer::byteLength): (WebCore::ArrayBuffer::~ArrayBuffer): (WebCore::ArrayBuffer::tryAllocate):
html/canvas/ArrayBuffer.h: Copied from WebCore/html/canvas/WebGLArrayBuffer.h.
html/canvas/ArrayBuffer.idl: Copied from WebCore/html/canvas/WebGLArrayBuffer.idl.
html/canvas/ArrayBufferView.cpp: Copied from WebCore/html/canvas/WebGLArray.cpp. (WebCore::ArrayBufferView::ArrayBufferView): (WebCore::ArrayBufferView::~ArrayBufferView): (WebCore::ArrayBufferView::setImpl): (WebCore::ArrayBufferView::calculateOffsetAndLength):
html/canvas/ArrayBufferView.h: Copied from WebCore/html/canvas/WebGLArray.h. (WebCore::ArrayBufferView::buffer): (WebCore::ArrayBufferView::verifySubRange): (WebCore::ArrayBufferView::clampOffsetAndNumElements):
html/canvas/ArrayBufferView.idl: Copied from WebCore/html/canvas/WebGLArray.idl.
html/canvas/FloatArray.cpp: Copied from WebCore/html/canvas/WebGLFloatArray.cpp. (WebCore::FloatArray::create): (WebCore::FloatArray::FloatArray): (WebCore::FloatArray::slice):
html/canvas/FloatArray.h: Copied from WebCore/html/canvas/WebGLFloatArray.h. (WebCore::FloatArray::set): (WebCore::FloatArray::item):
html/canvas/FloatArray.idl: Copied from WebCore/html/canvas/WebGLFloatArray.idl.
html/canvas/Int16Array.cpp: Copied from WebCore/html/canvas/WebGLShortArray.cpp. (WebCore::Int16Array::create): (WebCore::Int16Array::Int16Array): (WebCore::Int16Array::slice):
html/canvas/Int16Array.h: Copied from WebCore/html/canvas/WebGLShortArray.h.
html/canvas/Int16Array.idl: Copied from WebCore/html/canvas/WebGLShortArray.idl.
html/canvas/Int32Array.cpp: Copied from WebCore/html/canvas/WebGLIntArray.cpp. (WebCore::Int32Array::create): (WebCore::Int32Array::Int32Array): (WebCore::Int32Array::slice):
html/canvas/Int32Array.h: Copied from WebCore/html/canvas/WebGLIntArray.h.
html/canvas/Int32Array.idl: Copied from WebCore/html/canvas/WebGLIntArray.idl.
html/canvas/Int8Array.cpp: Copied from WebCore/html/canvas/WebGLByteArray.cpp. (WebCore::Int8Array::create): (WebCore::Int8Array::Int8Array): (WebCore::Int8Array::slice):
html/canvas/Int8Array.h: Copied from WebCore/html/canvas/WebGLByteArray.h.
html/canvas/Int8Array.idl: Copied from WebCore/html/canvas/WebGLByteArray.idl.
html/canvas/IntegralTypedArrayBase.h: Copied from WebCore/html/canvas/WebGLIntegralTypedArrayBase.h. (WebCore::IntegralTypedArrayBase::set): (WebCore::IntegralTypedArrayBase::item): (WebCore::IntegralTypedArrayBase::IntegralTypedArrayBase):
html/canvas/TypedArrayBase.h: Copied from WebCore/html/canvas/WebGLTypedArrayBase.h. (WebCore::TypedArrayBase::set): (WebCore::TypedArrayBase::TypedArrayBase): (WebCore::TypedArrayBase::create):
html/canvas/Uint16Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.cpp. (WebCore::Uint16Array::create): (WebCore::Uint16Array::Uint16Array): (WebCore::Uint16Array::slice):
html/canvas/Uint16Array.h: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.h.
html/canvas/Uint16Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.idl.
html/canvas/Uint32Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.cpp. (WebCore::Uint32Array::create): (WebCore::Uint32Array::Uint32Array): (WebCore::Uint32Array::slice):
html/canvas/Uint32Array.h: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.h.
html/canvas/Uint32Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.idl.
html/canvas/Uint8Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.cpp. (WebCore::Uint8Array::create): (WebCore::Uint8Array::Uint8Array): (WebCore::Uint8Array::slice):
html/canvas/Uint8Array.h: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.h.
html/canvas/Uint8Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.idl.
html/canvas/WebGLArray.cpp: Removed.
html/canvas/WebGLArray.h: Removed.
html/canvas/WebGLArray.idl: Removed.
html/canvas/WebGLArrayBuffer.cpp: Removed.
html/canvas/WebGLArrayBuffer.h: Removed.
html/canvas/WebGLArrayBuffer.idl: Removed.
html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData):
html/canvas/WebGLBuffer.h: (WebCore::WebGLBuffer::elementArrayBuffer):
html/canvas/WebGLByteArray.cpp: Removed.
html/canvas/WebGLByteArray.h: Removed.
html/canvas/WebGLByteArray.idl: Removed.
html/canvas/WebGLFloatArray.cpp: Removed.
html/canvas/WebGLFloatArray.h: Removed.
html/canvas/WebGLFloatArray.idl: Removed.
html/canvas/WebGLGetInfo.cpp: (WebCore::WebGLGetInfo::WebGLGetInfo): (WebCore::WebGLGetInfo::getWebGLFloatArray): (WebCore::WebGLGetInfo::getWebGLIntArray): (WebCore::WebGLGetInfo::getWebGLUnsignedByteArray):
html/canvas/WebGLGetInfo.h:
html/canvas/WebGLIntArray.cpp: Removed.
html/canvas/WebGLIntArray.h: Removed.
html/canvas/WebGLIntArray.idl: Removed.
html/canvas/WebGLIntegralTypedArrayBase.h: Removed.
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::vertexAttrib1fv): (WebCore::WebGLRenderingContext::vertexAttrib2fv): (WebCore::WebGLRenderingContext::vertexAttrib3fv): (WebCore::WebGLRenderingContext::vertexAttrib4fv): (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter): (WebCore::WebGLRenderingContext::getWebGLIntArrayParameter): (WebCore::WebGLRenderingContext::getWebGLUnsignedByteArrayParameter):
html/canvas/WebGLRenderingContext.h:
html/canvas/WebGLRenderingContext.idl:
html/canvas/WebGLShortArray.cpp: Removed.
html/canvas/WebGLShortArray.h: Removed.
html/canvas/WebGLShortArray.idl: Removed.
html/canvas/WebGLTypedArrayBase.h: Removed.
html/canvas/WebGLUnsignedByteArray.cpp: Removed.
html/canvas/WebGLUnsignedByteArray.h: Removed.
html/canvas/WebGLUnsignedByteArray.idl: Removed.
html/canvas/WebGLUnsignedIntArray.cpp: Removed.
html/canvas/WebGLUnsignedIntArray.h: Removed.
html/canvas/WebGLUnsignedIntArray.idl: Removed.
html/canvas/WebGLUnsignedShortArray.cpp: Removed.
html/canvas/WebGLUnsignedShortArray.h: Removed.
html/canvas/WebGLUnsignedShortArray.idl: Removed.
page/DOMWindow.idl:
platform/graphics/GraphicsContext3D.h:
platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData):
platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData):

2010-05-14 Kenneth Russell <kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

fast/dom/script-tests/constructed-objects-prototypes.js: (constructorPropertiesOnWindow):
fast/dom/script-tests/prototype-inheritance-2.js: (constructorNamesForWindow):

2010-05-14 Kenneth Russell <kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

Scripts/do-webcore-rename: Handle the case where some renames are substrings of others. Support renaming files containing custom JS bindings. If isDOMTypeRename is non-zero, expand the regexp which rewrites the file's contents in order to support custom JS bindings.

3:32 PM Changeset in webkit [59498] by sfalken@apple.com

2 edits in trunk/WebCore

<rdar://problem/7985864> Connection properties dictionary should use standard callbacks for keys, values
https://bugs.webkit.org/show_bug.cgi?id=39132

Reviewed by Sam Weinig.

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::createConnectionProperties):

3:27 PM Changeset in webkit [59497] by mrowe@apple.com

1 edit in branches/safari-533-branch/WebKit/win/ChangeLog

Merge r59438.

3:27 PM Changeset in webkit [59496] by mrowe@apple.com

5 edits in branches/safari-533-branch/WebKit/win

Merge r59434.

3:14 PM Changeset in webkit [59495] by eric@webkit.org

3 edits
2 adds in trunk

2010-05-14 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Tests that large colspan in a fixed table layout does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=38261

fast/table/fixed-table-layout-large-colspan-crash-expected.txt: Added.
fast/table/fixed-table-layout-large-colspan-crash.html: Added.

2010-05-14 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Move the m_width(Length) and m_columns(RenderTable::ColumnStruct)
vector out-of-bounds check out of the ASSERT into the main code.
https://bugs.webkit.org/show_bug.cgi?id=38261

Test: fast/table/fixed-table-layout-large-colspan-crash.html

rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):

3:08 PM Changeset in webkit [59494] by mrowe@apple.com

5 edits in tags/Safari-533.9.1

Versioning.

3:04 PM Changeset in webkit [59493] by mrowe@apple.com

2 edits in tags/Safari-533.9.1/WebCore

Merge r59481.

2:54 PM Changeset in webkit [59492] by mrowe@apple.com

1 copy in tags/Safari-533.9.1

New tag.

2:54 PM Changeset in webkit [59491] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebCore

Merge r59481.

2:14 PM Changeset in webkit [59490] by eric@webkit.org

28 edits in trunk

2010-05-14 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r59489.
http://trac.webkit.org/changeset/59489
https://bugs.webkit.org/show_bug.cgi?id=37815

abarth broke the known universe and then some.

http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
http/tests/security/xss-DENIED-iframe-src-alias.html:

2010-05-14 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r59489.
http://trac.webkit.org/changeset/59489
https://bugs.webkit.org/show_bug.cgi?id=37815

abarth broke the known universe and then some.

Android.jscbindings.mk:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
bindings/js/ScheduledAction.h:
bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
bindings/js/ScriptController.h:
bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
bindings/scripts/CodeGeneratorObjC.pm:
bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
bindings/scripts/test/ObjC/DOMTestInterface.mm:
bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
bindings/v8/ScriptController.cpp:
bindings/v8/ScriptController.h:
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

1:52 PM Changeset in webkit [59489] by abarth@webkit.org

28 edits in trunk

2010-05-14 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).

Android.jscbindings.mk:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
bindings/js/ScheduledAction.h:
bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::canAccessFromCurrentOrigin):
bindings/js/ScriptController.h:
bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
bindings/scripts/CodeGeneratorObjC.pm:
bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
bindings/scripts/test/ObjC/DOMTestInterface.mm:
bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::canAccessFromCurrentOrigin):
bindings/v8/ScriptController.h:
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-14 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
http/tests/security/xss-DENIED-iframe-src-alias.html:

1:49 PM Changeset in webkit [59488] by eric@webkit.org

2 edits in trunk/WebKitSite

2010-05-14 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

Update tools.html to mention that Tiger users require a newer Python
https://bugs.webkit.org/show_bug.cgi?id=38822

Also updated the instructions that only Tiger users need
to install a subversion client. Newer OSes already have
subversion included in the install.

building/tools.html:

1:36 PM Changeset in webkit [59487] by dimich@chromium.org

2 edits in trunk/WebCore

Adding resized image caching for Skia.
https://bugs.webkit.org/show_bug.cgi?id=39085

Patch by Sergey Ulanov <sergeyu@chromium.org> on 2010-05-14
Reviewed by Dmitry Titov and Brett Wilson.

Tests: HTML5 video on YouTube.

platform/graphics/skia/ImageSkia.cpp:

(WebCore::Image::drawPattern): Use bitmap->resizedBitmap() to cache resized image when possible.

1:32 PM Changeset in webkit [59486] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=39008
<rdar://problem/7976142> REGRESSION (r58950): Webkit crashes on clicking back button when in Hotmail

Test: fast/parser/tokenizer-close-during-document-write.html

dom/Document.cpp: (WebCore::Document::write): Check that the tokenizer is still around after calling write(). It can become null (as it happens in regression test), and I don't see any guarantee that it would never be replaced with a different one (but I can't make a test for that).

1:31 PM Changeset in webkit [59485] by jianli@chromium.org

2 edits in trunk/WebCore

Fix the code indentation inside a namespace to be consistent with the
style guide.

Rubber-stamped by Dmitry Titov.

workers/GenericWorkerTask.h:

1:24 PM Changeset in webkit [59484] by jianli@chromium.org

2 edits in trunk/WebCore

Remove the ENABLE(WORKERS) guard from GenericWorkerTask.h and rename
all occurrences of GenericWorkerTask* to GenericTask* in this file.
https://bugs.webkit.org/show_bug.cgi?id=39129

Reviewed by Dmitry Titov.

I will have another patch to rename the file and move it to the right
place.

workers/GenericWorkerTask.h:

(WebCore::):
(WebCore::GenericTask1::create):
(WebCore::GenericTask1::GenericTask1):
(WebCore::GenericTask2::create):
(WebCore::GenericTask2::GenericTask2):
(WebCore::GenericTask3::create):
(WebCore::GenericTask3::GenericTask3):
(WebCore::GenericTask4::create):
(WebCore::GenericTask4::GenericTask4):
(WebCore::GenericTask5::create):
(WebCore::GenericTask5::GenericTask5):
(WebCore::GenericTask6::create):
(WebCore::GenericTask6::GenericTask6):
(WebCore::GenericTask7::create):
(WebCore::GenericTask7::GenericTask7):
(WebCore::GenericTask8::create):
(WebCore::GenericTask8::GenericTask8):
(WebCore::createCallbackTask):

1:16 PM Changeset in webkit [59483] by eric@webkit.org

3 edits in trunk/WebCore

2010-05-14 Evan Martin <evan@chromium.org>

Reviewed by David Levin.

[chromium] don't call fontconfig twice in complex text path
https://bugs.webkit.org/show_bug.cgi?id=38701

Previously getFontDataForCharacters would call fontconfig once to
resolve a font name, then pass that name to getCachedFontPlatformData
to load the font. This would be two trips through fontconfig (including
IPCs). With this change, we completely load the font in the first pass.

This patch is actually the same code as in r58341, which was reverted
because of a performance problem; a performance improvement has now
been committed, and with that change in place this change improves
the Chromium intl2 page cycler performance by another 5%.

See also https://bugs.webkit.org/show_bug.cgi?id=37904 .

Test: fast/text/international/bold-bengali.html
(Was checked in as part of the first attempt at this change, continues
to pass after this change.)

platform/chromium/ChromiumBridge.h:
platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):

12:49 PM Changeset in webkit [59482] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-14 Young Han Lee <joybro@company100.net>

Reviewed by Darin Adler.

Don't include RetainPtr.h unless PLATFORM(CF) is set.
The RetainPtr is only used for CF platform in this class.
https://bugs.webkit.org/show_bug.cgi?id=39043

No new tests, there is no new functionality.

platform/network/curl/ResourceHandleManager.cpp:

12:21 PM Changeset in webkit [59481] by bweinstein@apple.com

2 edits in trunk/WebCore

Build fix, we need to copy over the files in $(WebKitOutputDir)/include/JavaScriptCore/private before
WebCore builds. This is because we are building a couple WTF files in WebCore and JavaScriptCore.

Reviewed by Adam Roben.

WebCore.vcproj/WebCore.make:

12:18 PM Changeset in webkit [59480] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-05-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch rollout throws exception if bug is already open
https://bugs.webkit.org/show_bug.cgi?id=38803

This was caused by someone incorrectly wrapping the code. :p
I'm going to have to start demanding unit tests for wrapping changes...

I also fixed the code to be able to reopen bugs which were never confirmed.
Before it regressed, the code would just log in that case. Now it actually
will reopen the bug, but there is a FIXME about how the logic is a bit backwards.

Scripts/webkitpy/common/net/bugzilla.py:
Scripts/webkitpy/common/net/bugzilla_unittest.py:
- Yay testing!

11:59 AM Changeset in webkit [59479] by eric@webkit.org

3 edits in trunk/LayoutTests

2010-05-14 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

Temporarily remove a few test cases that failed on leopard bot.
https://bugs.webkit.org/show_bug.cgi?id=33805

fast/canvas/webgl/texture-npot-expected.txt: Removed failed test cases.
fast/canvas/webgl/texture-npot.html: Ditto.

11:49 AM Changeset in webkit [59478] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-05-14 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Chromium: update test expectations.

platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt:

9:55 AM Changeset in webkit [59477] by hamaji@chromium.org

2 edits in trunk/WebCore

2010-05-14 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed. Attempt to fix chromium's memory bot error.

More :visited link optimizations to reduce memory usage
https://bugs.webkit.org/show_bug.cgi?id=39084

The original change (r59386) adds check for m_element in initElement.
As don't initialize m_element in the constructor of CSSStyleSelector,
valgrind complains.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector):

9:33 AM Changeset in webkit [59476] by jorlow@chromium.org

2 edits
2 deletes in trunk/LayoutTests

2010-05-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Instead of rebaslining prototype-inheritance for Chromium, add indexedDB to its exceptions
https://bugs.webkit.org/show_bug.cgi?id=39122

The test has a way to name properties that shouldn't be tested (used when they're not enabled
by most ports). Use this feature rather than creating custom baselines.

fast/dom/script-tests/prototype-inheritance.js:
platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.

9:03 AM Changeset in webkit [59475] by jorlow@chromium.org

1 edit
2 adds in trunk/LayoutTests

2010-05-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Rebaseline prototype-inheritance
https://bugs.webkit.org/show_bug.cgi?id=39116

IndexedDB is now turned on for Chromium's test shell. I'm not sure
if this is the correct behavior or not (can someone confirm which it is?)
but we should get this test running again so we can catch real regressions.
And, before taking this out from behind a flag, we should be sure to fix it.

platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Added.
platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Added.

8:59 AM QtWebKitBugs edited by Simon Hausmann

(diff)

8:24 AM Changeset in webkit [59474] by Simon Hausmann

5 edits
3 copies
2 deletes in trunk

.: [Qt] Rename QtLauncher to QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=37665

Rubber-stamped by Antti Koivisto.

WebKit.pro:

WebKitTools: [Qt] Rename QtLauncher to QtTestBrowser

Rubber-stamped by Antti Koivisto.

QtTestBrowser: Copied from WebKitTools/QtLauncher.
QtTestBrowser/QtLauncher.pro: Removed.
QtTestBrowser/QtLauncher.qrc: Removed.
QtTestBrowser/QtTestBrowser.pro: Copied from WebKitTools/QtLauncher/QtLauncher.pro.
QtTestBrowser/QtTestBrowser.qrc: Copied from WebKitTools/QtLauncher/QtLauncher.qrc.
Scripts/run-launcher:
Scripts/webkitdirs.pm:

8:12 AM QtWebKitTriageRoster edited by jesus@webkit.org

(diff)

8:11 AM QtWebKitBugs edited by jesus@webkit.org

(diff)

7:47 AM Changeset in webkit [59473] by eric@webkit.org

4 edits in trunk/WebCore

2010-05-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

CSSParser::parseColor() shouldn't alter 'color' unless passed a valid color string.
https://bugs.webkit.org/show_bug.cgi?id=39031

css/CSSParser.cpp: (WebCore::CSSParser::parseColor):
editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::extractTextStyles): Don't depend on old behavior.
html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): Remove dead code.

7:16 AM Changeset in webkit [59472] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-14 Jens Alfke <snej@chromium.org>

Reviewed by John Sullivan.

Don't clear yellow autofill highlight from text fields until the user edits them.
https://bugs.webkit.org/show_bug.cgi?id=39032
No new tests (Couldn't find any autofill tests. The flag doesn't seem to be exposed to JS.)

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::handleFocusEvent): Don't clear the autofilled flag. (WebCore::HTMLInputElement::setValueFromRenderer): Clear the autofilled flag.

5:57 AM Changeset in webkit [59471] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed, unskip passing tests.

[Qt] animations/dynamic-stylesheet-loading.html fails with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=37381

platform/qt/Skipped:
- animations/simultaneous-start-left.html unskipped.
- animations/dynamic-stylesheet-loading.html unskipped.

5:52 AM Changeset in webkit [59470] by eric@webkit.org

6 edits
2 adds in trunk

2010-05-14 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must implement OpenGL ES 2.0 semantics for NPOT textures
https://bugs.webkit.org/show_bug.cgi?id=33805

fast/canvas/webgl/texture-npot-expected.txt: Added.
fast/canvas/webgl/texture-npot.html: Added.

2010-05-14 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must implement OpenGL ES 2.0 semantics for NPOT textures
https://bugs.webkit.org/show_bug.cgi?id=33805

Test: fast/canvas/webgl/texture-npot.html

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Create black 1x1 textures. (WebCore::WebGLRenderingContext::bindTexture): Set texture dimensionality. (WebCore::WebGLRenderingContext::copyTexImage2D): Error check, set texture size. (WebCore::WebGLRenderingContext::drawArrays): Bind to black textures if needed. (WebCore::WebGLRenderingContext::drawElements): Bind to black textures if needed. (WebCore::WebGLRenderingContext::generateMipmap): Error check. (WebCore::WebGLRenderingContext::texImage2DBase): Error check, set texture size. (WebCore::WebGLRenderingContext::texParameterf): Set texture parameter. (WebCore::WebGLRenderingContext::texParameteri): Ditto. (WebCore::WebGLRenderingContext::handleNPOTTextures): Bind to black textures if needed before draw, and bind back to original textures after draw.
html/canvas/WebGLRenderingContext.h: Add black 1x1 textures.
html/canvas/WebGLTexture.cpp: Add support to track NPOT textures. (WebCore::WebGLTexture::createBlackTexture1x1): Create a black 1x1 texture. (WebCore::WebGLTexture::WebGLTexture): Initialize parameters and states. (WebCore::WebGLTexture::setDimensionality): Set dimensionality. (WebCore::WebGLTexture::setParameteri): Set parameter. (WebCore::WebGLTexture::setParameterf): Ditto. (WebCore::WebGLTexture::setSize): Set level 0 texture size. (WebCore::WebGLTexture::isNPOT): Whether the texture is NPOT. (WebCore::WebGLTexture::updateNPOTStates): Calculate NPOT and NeedToUseBlackTexture states.
html/canvas/WebGLTexture.h: Add support to track NPOT textures. (WebCore::WebGLTexture::isNPOT): (WebCore::WebGLTexture::needToUseBlackTexture):

5:39 AM Changeset in webkit [59469] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-05-14 Chao-ying Fu <fu@mips.com>

Reviewed by Oliver Hunt.

String Indexing Failure on JSVALUE32 targets
https://bugs.webkit.org/show_bug.cgi?id=39034

Remove zero-extend/shift-right code on regT1, because we already have
it in emit_op_get_by_val().

jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator):

5:36 AM Changeset in webkit [59468] by pfeldman@chromium.org

17 edits
3 adds in trunk/WebCore

2010-05-14 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add help on keyboard shortcuts (take 2).

https://bugs.webkit.org/show_bug.cgi?id=38667

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._registerShortcuts):
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._registerShortcuts):
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._keyDown):
inspector/front-end/HelpScreen.js: Added.
inspector/front-end/KeyboardShortcut.js:
inspector/front-end/ScriptsPanel.js:

5:32 AM QtWebKitTriageRoster edited by Csaba Osztrogonác

(diff)

5:28 AM Changeset in webkit [59467] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-05-14 Jochen Eisinger <jochen@chromium.org>

Reviewed by Eric Seidel.

Make ImageDiff depend on webkit (again).
https://bugs.webkit.org/show_bug.cgi?id=39000

WebKit.gyp:

5:16 AM Changeset in webkit [59466] by eric@webkit.org

4 edits in trunk/WebKit/chromium

2010-05-14 James Simonsen <simonjam+webkit@google.com>

Reviewed by Darin Fisher.

[chromium] Expose volume through WebMediaPlayerClient
https://bugs.webkit.org/show_bug.cgi?id=38947

public/WebMediaPlayerClient.h:
src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::volume):
src/WebMediaPlayerClientImpl.h:

5:03 AM QtWebKitJournal edited by Simon Hausmann

(diff)

4:55 AM Changeset in webkit [59465] by eric@webkit.org

10 edits in trunk

2010-05-14 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

[chromium] Update chromium port to send/receive cached metadata
https://bugs.webkit.org/show_bug.cgi?id=38665

No new tests because no new functionality.

platform/chromium/ChromiumBridge.h:
platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::responseTime): (WebCore::ResourceResponse::setResponseTime):

2010-05-14 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

[chromium] Update chromium port to send/receive cached metadata
https://bugs.webkit.org/show_bug.cgi?id=38665

public/WebKitClient.h: (WebKit::WebKitClient::cacheMetadata):
public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didReceiveCachedMetadata):
public/WebURLResponse.h:
src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cacheMetadata):
src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveCachedMetadata): (WebCore::ResourceHandle::cacheMetadata):
src/WebURLResponse.cpp: (WebKit::WebURLResponse::responseTime): (WebKit::WebURLResponse::setResponseTime):

4:32 AM Changeset in webkit [59464] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-05-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Stop CCing webkit-bot-watchers
https://bugs.webkit.org/show_bug.cgi?id=39020

webkit-bot-watchers is somewhat of a failed experiment. No one
subscribed to the list (not even me). Removing it from the code
because wms says it bounces email sometimes.

Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

4:24 AM Changeset in webkit [59463] by jocelyn.turcotte@nokia.com

2 edits in trunk/JavaScriptCore

Fix a VS2010 assert in std::copy
https://bugs.webkit.org/show_bug.cgi?id=38630

Reviewed by Alexey Proskuryakov.

The assert complains that the output iterator is null.

wtf/Vector.h:

(WTF::::operator):

4:21 AM Changeset in webkit [59462] by eric@webkit.org

5 edits in trunk/WebCore

2010-05-14 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Chromium-specific fix to prevent zombie infobars.

https://bugs.webkit.org/show_bug.cgi?id=38948

bindings/v8/ScriptController.cpp (WebCore::ScriptController::processingUserGesture): Require a more definite "no" signal.
loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::fire): Use a very strong yes / no signal; no need for "possible" here.
dom/UserGestureIndicator.h:
dom/UserGestureIndicator.cpp: Adapt to tri-state: definitely yes; definitely no; not sure.

3:55 AM Changeset in webkit [59461] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-05-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION: webkit-patch commit-message throws exception
https://bugs.webkit.org/show_bug.cgi?id=38997

Scripts/webkitpy/tool/commands/upload.py:
- Fix to respect and pass the --squash and --git-commit options.
Scripts/webkitpy/tool/commands/upload_unittest.py:
- Fix the unit test to use the central MockCheckout instead of its own custom Mock which didn't require enough parameters.

2:58 AM Changeset in webkit [59460] by Simon Hausmann

3 edits in trunk/WebCore

[Qt] JavaScript unable to invoke methods declared in QML
https://bugs.webkit.org/show_bug.cgi?id=38949

Patch by Aaron Kennedy <tffeeb@gmail.com> on 2010-05-14
Reviewed by Simon Hausmann.

JavaScript code executed by webkit cannot call into QML declared
methods, as it does not check for dynamic meta objects.

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::stringValue): Use QMetaObject::metacall.

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call): Ditto.

2:50 AM Changeset in webkit [59459] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-14 Ben Murdoch <benm@google.com>

Reviewed by Darin Fisher.

Touch events are disabled by default when using V8.
https://bugs.webkit.org/show_bug.cgi?id=38990

Touch events are protected by a compile time guard, so it's safe to
assume that the runtime flag should be enabled by default when this
guard is present.

No new tests, build fix for Android.

bindings/generic/RuntimeEnabledFeatures.cpp: enable touch events by default.

2:29 AM Changeset in webkit [59458] by mrowe@apple.com

10 edits in branches/safari-533-branch

<rdar://problem/7677994> Disable WebGL

JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

WebCore:

Configurations/FeatureDefines.xcconfig:

WebKit/mac:

Configurations/FeatureDefines.xcconfig:

WebKit2:

Configurations/FeatureDefines.xcconfig:

WebKitTools:

Scripts/build-webkit:

2:23 AM Changeset in webkit [59457] by jorlow@chromium.org

1 edit
2 adds in trunk/LayoutTests

2010-05-14 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Rebaseline storage/domstorage/quota.html
https://bugs.webkit.org/show_bug.cgi?id=38996

Chromium enforces quota on session storage and thus expects to "fail"
the first part of this test.

platform/chromium-mac/storage/domstorage/quota-expected.txt: Added.
platform/chromium-win/storage/domstorage/quota-expected.txt: Added.

2:14 AM Changeset in webkit [59456] by Simon Hausmann

15 edits in trunk/WebKit/qt

[Qt] Merge overhaul of the QtWebKit API documentation

Patch by Kent Hansen <kent.hansen@nokia.com>, Jocelyn Turcotte <jocelyn.turcotte@nokia.com>, Tor Arne Vestbø <tor.arne.vestbo@nokia.com>, Henry Haverinen <Henry Haverinen>, Jedrzej Nowacki <jedrzej.nowacki@nokia.com>, Andreas Kling <andreas.kling@nokia.com> on 2010-05-14
Reviewed by Simon Hausmann.

Numerous improvements in wording, qdoc warning fixes and
clarifications, done in a team work effort.

No functional changes.

Api/qwebdatabase.cpp:
Api/qwebelement.cpp:
Api/qwebframe.cpp:
Api/qwebhistoryinterface.cpp:
Api/qwebinspector.cpp:
Api/qwebkitversion.cpp:
Api/qwebpage.cpp:
Api/qwebpluginfactory.cpp:
Api/qwebsecurityorigin.cpp:
Api/qwebsettings.cpp:
Api/qwebsettings.h:
docs/qtwebkit.qdoc:
docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp:

(wrapInFunction):

docs/webkitsnippets/webelement/main.cpp:

(findButtonAndClick):
(autocomplete1):
(autocomplete2):
(main):

2:04 AM Changeset in webkit [59455] by Simon Hausmann

2 edits in trunk/WebKit/qt

Documentation: Fix overview grouping.

Patch by Martin Smith <msmith@trolltech.com> on 2010-05-14
Reviewed by Simon Hausmann.

docs/qtwebkit.qdoc:

1:49 AM Changeset in webkit [59454] by yurys@chromium.org

7 edits
2 adds in trunk/LayoutTests

2010-05-14 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Chromium: update test expectations.

platform/chromium-linux/editing/deleting/5408255-expected.checksum:
platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt: Added.
platform/chromium-mac/editing/deleting/5408255-expected.checksum: Added.
platform/chromium-win/editing/deleting/5408255-expected.checksum:
platform/chromium-win/editing/deleting/5408255-expected.txt:
platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
platform/chromium-win/editing/selection/4895428-1-expected.txt:
platform/chromium-win/editing/selection/4895428-4-expected.txt:

1:44 AM Changeset in webkit [59453] by eric@webkit.org

2 edits in trunk/WebKit

2010-05-14 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by David Levin.

[EF] Include missing header.
http://webkit.org/b/38905

efl/ewk/ewk_main.cpp: Include PageGroup.h

1:43 AM Changeset in webkit [59452] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebKitTools

Merge r59177.

1:32 AM Changeset in webkit [59451] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-05-14 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Laszlo Gombos.

[QT] Update the Symbian version for the user agent
https://bugs.webkit.org/show_bug.cgi?id=38389

Update the user agent for Symbian^{2 to Symbian}4

Api/qwebpage.cpp: (QWebPage::userAgentForUrl):

1:23 AM Changeset in webkit [59450] by mrowe@apple.com

4 edits in branches/safari-533-branch/WebCore

Disable the Audits panel and Workers sidebar in the Web Inspector.

Patch by Timothy Hatcher <timothy@apple.com> on 2010-05-13
<rdar://problem/7947035>

Reviewed by Ada Chan.

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel): Don't make a workers sidebar pane.
(WebInspector.ScriptsPanel.prototype.reset): Null check workers sidebar pane.

inspector/front-end/Settings.js: Set auditsPanelEnabled to false.
inspector/front-end/WorkersSidebarPane.js:

(WebInspector.didCreateWorker): Null check workers sidebar pane.
(WebInspector.didDestroyWorker): Ditto.

1:21 AM Changeset in webkit [59449] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-05-14 Dawit Alemayehu <adawit@kde.org>

Reviewed by Simon Hausmann.

Implemented createJavaAppletWidget to activate Java applet support.

https://bugs.webkit.org/show_bug.cgi?id=33044

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createJavaAppletWidget):

1:09 AM Changeset in webkit [59448] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-14 George Wright <gwright@rim.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=38909

Update JSDataGridColumnListCustom.cpp to call identifierToAtomicString()
on the property name.

bindings/js/JSDataGridColumnListCustom.cpp: (WebCore::JSDataGridColumnList::canGetItemsForName): (WebCore::JSDataGridColumnList::nameGetter):

12:43 AM Changeset in webkit [59447] by eric@webkit.org

3 edits
3 adds in trunk

2010-05-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Add test to check that setting various CanvasRenderingContext2D properties
to invalid values is ignored.

https://bugs.webkit.org/show_bug.cgi?id=38841

fast/canvas/canvas-invalid-values-expected.txt: Added.
fast/canvas/canvas-invalid-values.html: Added.
fast/canvas/script-tests/canvas-invalid-values.js: Added. (trySettingMiterLimit): (trySettingLineWidth): (trySettingShadowBlur): (trySettingShadowOffsetX): (trySettingShadowOffsetY):

2010-05-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Ignore invalid values for various CanvasRenderingContext2D properties
(lineWidth, miterLimit, shadowOffsetX, shadowOffsetY and shadowBlur)

https://bugs.webkit.org/show_bug.cgi?id=38841

Test: fast/canvas/canvas-invalid-values.html

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setLineWidth): (WebCore::CanvasRenderingContext2D::setMiterLimit): (WebCore::CanvasRenderingContext2D::setShadowOffsetX): (WebCore::CanvasRenderingContext2D::setShadowOffsetY): (WebCore::CanvasRenderingContext2D::setShadowBlur):

12:08 AM Changeset in webkit [59446] by tkent@chromium.org

1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed, test expectation update.

deleted-host-in-resource-load-delegate-callback.html sometimes crashes on Windows Release.

May 13, 2010:

11:35 PM Changeset in webkit [59445] by Simon Hausmann

2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with new exports.

symbian/eabi/QtWebKitu.def: Add missing gc symbol for QtLauncher

11:18 PM Changeset in webkit [59444] by Simon Fraser

1 edit
1 add in trunk/LayoutTests

2010-05-13 Simon Fraser <Simon Fraser>

Fixing test failure.

Adding resource that should have been added in r59443.

compositing/iframes/resources/subframe.html: Added.

10:32 PM Changeset in webkit [59443] by Simon Fraser

3 edits
4 adds in trunk

2010-05-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

iframes in compositing layers don't redraw correctly on scrolling
https://bugs.webkit.org/show_bug.cgi?id=39096

When an iframe ends up in a compositing layer (that is painting to its backing store), we need
to turn off blitting on scrolling. RenderView::paintBoxDecorations() already has code to do this
for transformed frames, so do the same thing when the frame is enclosed in a compositing layer.

Test: compositing/iframes/iframe-copy-on-scroll.html

rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):

9:17 PM Changeset in webkit [59442] by tony@chromium.org

2 edits in trunk/WebKit/chromium

2010-05-13 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] enable DRT build in chromium (for the last time)
https://bugs.webkit.org/show_bug.cgi?id=39109

WebKit.gyp:

9:01 PM Changeset in webkit [59441] by tkent@chromium.org

2 edits in trunk

Unreviewed. Move a ChangeLog entry inserted to a wrong file.

8:56 PM Changeset in webkit [59440] by tkent@chromium.org

2 edits in trunk/LayoutTests

2010-05-13 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Kent Tamura.

Update text_expectations.txt for Chromium
fast/forms/input-text-paste-maxlength.html is flaky on Linux Debug
See http://code.google.com/p/chromium/issues/detail?id=44150 for detail.

platform/chromium/test_expectations.txt:

8:49 PM Changeset in webkit [59439] by tkent@chromium.org

2 edits in trunk/LayoutTests

Update test_expectations.txt for Chromium.
fast/forms/implicit-submission.html is flaky on Linux.
See http://crbug.com/43890 for detail.

Patch by Takeshi Yoshino <tyoshino@google.com> on 2010-05-13
Reviewed by Shinichiro Hamaji.

platform/chromium/test_expectations.txt:

7:25 PM Changeset in webkit [59438] by bweinstein@apple.com

1 edit in trunk/WebKit/win/ChangeLog

Update the bug number in the ChangeLog that I just committed.

7:10 PM Changeset in webkit [59437] by mrowe@apple.com

5 edits in branches/safari-533-branch

Versioning.

7:09 PM Changeset in webkit [59436] by Martin Robinson

2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <mrobinson@igalia.com>

No review.

[GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=39101

platform/gtk/Skipped: Skip failing test.

7:09 PM Changeset in webkit [59435] by mrowe@apple.com

1 copy in tags/Safari-533.9

New tag.

7:08 PM Changeset in webkit [59434] by bweinstein@apple.com

5 edits in trunk/WebKit/win

<rdar://problem/7975410>

Reviewed by Tim Hatcher.

Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector.

Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate.
Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild.
WebView.cpp:

(WebView::reportException): Make sure the function was called with a context from a WebView, and call

WebCore::reportException.

WebView.h:

7:08 PM Changeset in webkit [59433] by mrowe@apple.com

5 edits in branches/safari-533-branch

Versioning.

6:52 PM Changeset in webkit [59432] by mrowe@apple.com

5 edits in branches/safari-533-branch

Merge r59418.

6:51 PM Changeset in webkit [59431] by mrowe@apple.com

3 edits in branches/safari-533-branch/WebCore

Merge r59330.

6:51 PM Changeset in webkit [59430] by mrowe@apple.com

4 edits in branches/safari-533-branch/WebCore

Merge r59387.

6:51 PM Changeset in webkit [59429] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebCore

Merge r59417.

6:06 PM Changeset in webkit [59428] by Martin Robinson

2 edits
56 adds in trunk/LayoutTests

2010-05-13 Martin Robinson <mrobinson@igalia.com>

No review. Finish adding css1 baselines for GTK+.

platform/gtk/Skipped: Unskip tests which now have baselines.
platform/gtk/css1/basic/class_as_selector-expected.txt:
platform/gtk/css1/box_properties/width-expected.txt: Added.
platform/gtk/css1/cascade/cascade_order-expected.txt: Added.
platform/gtk/css1/cascade/important-expected.txt: Added.
platform/gtk/css1/classification/display-expected.txt: Added.
platform/gtk/css1/classification/list_style-expected.txt: Added.
platform/gtk/css1/classification/list_style_image-expected.txt: Added.
platform/gtk/css1/classification/list_style_position-expected.txt: Added.
platform/gtk/css1/classification/list_style_type-expected.txt: Added.
platform/gtk/css1/classification/white_space-expected.txt: Added.
platform/gtk/css1/color_and_background/background-expected.txt: Added.
platform/gtk/css1/color_and_background/background_attachment-expected.txt: Added.
platform/gtk/css1/color_and_background/background_color-expected.txt: Added.
platform/gtk/css1/color_and_background/background_image-expected.txt: Added.
platform/gtk/css1/color_and_background/background_position-expected.txt: Added.
platform/gtk/css1/color_and_background/background_repeat-expected.txt: Added.
platform/gtk/css1/color_and_background/color-expected.txt: Added.
platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt: Added.
platform/gtk/css1/font_properties/font-expected.txt: Added.
platform/gtk/css1/font_properties/font_family-expected.txt: Added.
platform/gtk/css1/font_properties/font_size-expected.txt: Added.
platform/gtk/css1/font_properties/font_style-expected.txt: Added.
platform/gtk/css1/font_properties/font_variant-expected.txt: Added.
platform/gtk/css1/font_properties/font_weight-expected.txt: Added.
platform/gtk/css1/formatting_model/canvas-expected.txt: Added.
platform/gtk/css1/formatting_model/floating_elements-expected.txt: Added.
platform/gtk/css1/formatting_model/height_of_lines-expected.txt: Added.
platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt: Added.
platform/gtk/css1/formatting_model/inline_elements-expected.txt: Added.
platform/gtk/css1/formatting_model/replaced_elements-expected.txt: Added.
platform/gtk/css1/formatting_model/vertical_formatting-expected.txt: Added.
platform/gtk/css1/pseudo/anchor-expected.txt: Added.
platform/gtk/css1/pseudo/firstletter-expected.txt: Added.
platform/gtk/css1/pseudo/firstline-expected.txt: Added.
platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt: Added.
platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt: Added.
platform/gtk/css1/text_properties/letter_spacing-expected.txt: Added.
platform/gtk/css1/text_properties/line_height-expected.txt: Added.
platform/gtk/css1/text_properties/text_align-expected.txt: Added.
platform/gtk/css1/text_properties/text_decoration-expected.txt: Added.
platform/gtk/css1/text_properties/text_indent-expected.txt: Added.
platform/gtk/css1/text_properties/text_transform-expected.txt: Added.
platform/gtk/css1/text_properties/vertical_align-expected.txt: Added.
platform/gtk/css1/text_properties/word_spacing-expected.txt: Added.
platform/gtk/css1/units/color_units-expected.txt: Added.
platform/gtk/css1/units/length_units-expected.txt: Added.
platform/gtk/css1/units/percentage_units-expected.txt: Added.
platform/gtk/css1/units/urls-expected.txt: Added.

6:03 PM Changeset in webkit [59427] by mrowe@apple.com

13 edits in branches/safari-533-branch/WebCore

Merge r59281.

6:03 PM Changeset in webkit [59426] by mrowe@apple.com

7 edits
1 copy
1 add in branches/safari-533-branch

Merge r59381.

6:03 PM Changeset in webkit [59425] by mrowe@apple.com

4 edits in branches/safari-533-branch/WebCore

Merge r59372.

6:03 PM Changeset in webkit [59424] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebKit/mac

Merge r59391.

6:03 PM Changeset in webkit [59423] by mrowe@apple.com

3 edits in branches/safari-533-branch/WebCore

Merge r59374.

6:02 PM Changeset in webkit [59422] by mrowe@apple.com

6 edits
2 adds in branches/safari-533-branch

Merge r59384.

6:02 PM Changeset in webkit [59421] by mrowe@apple.com

3 edits
2 adds in branches/safari-533-branch

Merge r59351.

6:02 PM Changeset in webkit [59420] by mrowe@apple.com

2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59337.

5:04 PM Changeset in webkit [59419] by Martin Robinson

2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <mrobinson@igalia.com>

No review. Correcting baseline.

platform/gtk/css1/basic/class_as_selector-expected.txt: Correct baseline.

5:01 PM Changeset in webkit [59418] by timothy@apple.com

5 edits in trunk

WebCore: Expose WebCore::reportException and WebCore::toJSDOMWindow symbols.

Reviewed by Sam Weinig.

WebCore.base.exp: Expose reportException and toJSDOMWindow.

WebKit/mac: Allow reporting exceptions that occur when using JavaScriptCore APIs
to the Web Inspector.

<rdar://problem/7975410>

Reviewed by Sam Weinig.

WebView/WebView.mm:

(+[WebView _reportException:inContext:]): Call WebCore::reportException after checking
that the global object is a DOMWindow.

WebView/WebViewPrivate.h: Added _reportException:inContext:.

4:59 PM Changeset in webkit [59417] by Joseph Pecoraro

2 edits in trunk/WebCore

2010-05-13 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Clearing Breakpoints Too Often
https://bugs.webkit.org/show_bug.cgi?id=39094

Minor resets should preserve both workers and breakpoints.

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):

4:58 PM Changeset in webkit [59416] by Simon Hausmann

2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with new exports.

symbian/eabi/QtWebKitu.def:

4:46 PM Changeset in webkit [59415] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebCore

Merge r59025.

4:46 PM Changeset in webkit [59414] by mrowe@apple.com

3 edits in branches/safari-533-branch/WebCore

Merge r58954.

4:46 PM Changeset in webkit [59413] by mrowe@apple.com

13 edits
4 adds in branches/safari-533-branch

Merge r59243.

4:46 PM Changeset in webkit [59412] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebCore

Merge r59210.

4:46 PM Changeset in webkit [59411] by mrowe@apple.com

10 edits in branches/safari-533-branch

Merge r59232.

4:46 PM Changeset in webkit [59410] by mrowe@apple.com

5 edits in branches/safari-533-branch/WebCore

Merge r59239.

4:46 PM Changeset in webkit [59409] by mrowe@apple.com

6 edits in branches/safari-533-branch/WebCore

Merge r59189.

4:46 PM Changeset in webkit [59408] by mrowe@apple.com

3 edits in branches/safari-533-branch/WebCore

Merge r59186.

4:45 PM Changeset in webkit [59407] by mrowe@apple.com

3 edits
4 adds in branches/safari-533-branch

Merge r59199.

4:45 PM Changeset in webkit [59406] by mrowe@apple.com

2 edits
1 add in branches/safari-533-branch/WebCore

Merge r59263.

4:45 PM Changeset in webkit [59405] by mrowe@apple.com

1 edit in branches/safari-533-branch/WebCore/ChangeLog

Merge r59242.

4:45 PM Changeset in webkit [59404] by mrowe@apple.com

5 edits
2 adds in branches/safari-533-branch

Merge r59241.

4:45 PM Changeset in webkit [59403] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebCore

Merge r59247.

4:45 PM Changeset in webkit [59402] by mrowe@apple.com

3 edits in branches/safari-533-branch/JavaScriptCore

Merge r59202.

4:45 PM Changeset in webkit [59401] by mrowe@apple.com

8 edits in branches/safari-533-branch/JavaScriptCore

Merge r59196.

4:45 PM Changeset in webkit [59400] by mrowe@apple.com

15 edits
1 add in branches/safari-533-branch

Merge r59187.

4:44 PM Changeset in webkit [59399] by mrowe@apple.com

7 edits in branches/safari-533-branch

Merge r59336.

4:41 PM Changeset in webkit [59398] by Martin Robinson

2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <mrobinson@igalia.com>

No review needed.

[GTK] Some test results are one pixel different on x86_64
https://bugs.webkit.org/show_bug.cgi?id=39022

platform/gtk/Skipped: Skipping this test because of single-pixel difference.

4:22 PM Changeset in webkit [59397] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Platform specific expected file updated after r59385.

Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874

platform/qt/editing/deleting/5408255-expected.txt: updated.

4:14 PM Changeset in webkit [59396] by Simon Fraser

14 edits
1 copy
2 adds in trunk

2010-05-13 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Fix scrolling in composited iframes
https://bugs.webkit.org/show_bug.cgi?id=39088
<rdar://problem/7980099>

When propagating compositing out of iframes, we have to update the position of the iframe content
layers on scrolling.

Test: compositing/iframes/scrolling-iframe.html

page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged): Call updateContentLayerScrollPosition() when scrolling.

rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Renamed setRootPlatformLayerClippingBox() to updateContentLayerOffset().

rendering/RenderLayerCompositor.h:
rendering/RenderLayerCompositor.cpp: Rename m_clippingLayer to m_clipLayer to go better with m_scrollLayer. (WebCore::RenderLayerCompositor::updateContentLayerOffset): Renamed from setRootPlatformLayerClippingBox().

Set the size of the clipping layer from the FrameView now, so that scrollbars are not clipped out.
Update the scroll layer position too.

(WebCore::RenderLayerCompositor::updateContentLayerScrollPosition): Set the position of the scroll layer

when the ScrollView is scrolled.

(WebCore::RenderLayerCompositor::rootPlatformLayer): m_clippingLayer rename.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): m_clippingLayer rename. Also create m_scrollLayer at

the same time as the clip layer, and clean it up as necessary.

(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): m_clippingLayer rename, and clean up the m_scrollLayer too.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): m_clippingLayer rename

4:14 PM Changeset in webkit [59395] by Martin Robinson

2 edits
62 adds in trunk/LayoutTests

2010-05-13 Martin Robinson <mrobinson@igalia.com>

No review. Adding baselines for many of the css1 tests. I've checked these manually.

platform/gtk/Skipped: Unskipping tests.
platform/gtk/css1/basic/class_as_selector-expected.txt: Added.
platform/gtk/css1/basic/comments-expected.txt: Added.
platform/gtk/css1/basic/containment-expected.txt: Added.
platform/gtk/css1/basic/contextual_selectors-expected.txt: Added.
platform/gtk/css1/basic/grouping-expected.txt: Added.
platform/gtk/css1/basic/id_as_selector-expected.txt: Added.
platform/gtk/css1/basic/inheritance-expected.txt: Added.
platform/gtk/css1/box_properties/acid_test-expected.txt: Added.
platform/gtk/css1/box_properties/border-expected.txt: Added.
platform/gtk/css1/box_properties/border_bottom-expected.txt: Added.
platform/gtk/css1/box_properties/border_bottom_inline-expected.txt: Added.
platform/gtk/css1/box_properties/border_bottom_width-expected.txt: Added.
platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt: Added.
platform/gtk/css1/box_properties/border_color-expected.txt: Added.
platform/gtk/css1/box_properties/border_color_inline-expected.txt: Added.
platform/gtk/css1/box_properties/border_inline-expected.txt: Added.
platform/gtk/css1/box_properties/border_left-expected.txt: Added.
platform/gtk/css1/box_properties/border_left_inline-expected.txt: Added.
platform/gtk/css1/box_properties/border_left_width-expected.txt: Added.
platform/gtk/css1/box_properties/border_left_width_inline-expected.txt: Added.
platform/gtk/css1/box_properties/border_right-expected.txt: Added.
platform/gtk/css1/box_properties/border_right_inline-expected.txt: Added.
platform/gtk/css1/box_properties/border_right_width-expected.txt: Added.
platform/gtk/css1/box_properties/border_right_width_inline-expected.txt: Added.
platform/gtk/css1/box_properties/border_style-expected.txt: Added.
platform/gtk/css1/box_properties/border_style_inline-expected.txt: Added.
platform/gtk/css1/box_properties/border_top-expected.txt: Added.
platform/gtk/css1/box_properties/border_top_inline-expected.txt: Added.
platform/gtk/css1/box_properties/border_top_width-expected.txt: Added.
platform/gtk/css1/box_properties/border_top_width_inline-expected.txt: Added.
platform/gtk/css1/box_properties/border_width-expected.txt: Added.
platform/gtk/css1/box_properties/border_width_inline-expected.txt: Added.
platform/gtk/css1/box_properties/clear-expected.txt: Added.
platform/gtk/css1/box_properties/clear_float-expected.txt: Added.
platform/gtk/css1/box_properties/float-expected.txt: Added.
platform/gtk/css1/box_properties/float_elements_in_series-expected.txt: Added.
platform/gtk/css1/box_properties/float_margin-expected.txt: Added.
platform/gtk/css1/box_properties/float_on_text_elements-expected.txt: Added.
platform/gtk/css1/box_properties/height-expected.txt: Added.
platform/gtk/css1/box_properties/margin-expected.txt: Added.
platform/gtk/css1/box_properties/margin_bottom-expected.txt: Added.
platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt: Added.
platform/gtk/css1/box_properties/margin_inline-expected.txt: Added.
platform/gtk/css1/box_properties/margin_left-expected.txt: Added.
platform/gtk/css1/box_properties/margin_left_inline-expected.txt: Added.
platform/gtk/css1/box_properties/margin_right-expected.txt: Added.
platform/gtk/css1/box_properties/margin_right_inline-expected.txt: Added.
platform/gtk/css1/box_properties/margin_top-expected.txt: Added.
platform/gtk/css1/box_properties/margin_top_inline-expected.txt: Added.
platform/gtk/css1/box_properties/padding-expected.txt: Added.
platform/gtk/css1/box_properties/padding_bottom-expected.txt: Added.
platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt: Added.
platform/gtk/css1/box_properties/padding_inline-expected.txt: Added.
platform/gtk/css1/box_properties/padding_left-expected.txt: Added.
platform/gtk/css1/box_properties/padding_left_inline-expected.txt: Added.
platform/gtk/css1/box_properties/padding_right-expected.txt: Added.
platform/gtk/css1/box_properties/padding_right_inline-expected.txt: Added.
platform/gtk/css1/box_properties/padding_top-expected.txt: Added.
platform/gtk/css1/box_properties/padding_top_inline-expected.txt: Added.

3:56 PM Changeset in webkit [59394] by weinig@apple.com

2 edits in trunk/WebCore

Follow up to:
Fix for https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>

Reviewed by Anders Carlsson.

Fix failing tests on Leopard.

Initialize m_hasCachedCSSText in CSSPrimitiveValue::init methods.

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cssText): Add extra assertion.

3:45 PM Changeset in webkit [59393] by Martin Robinson

2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <mrobinson@igalia.com>

No review. Rebaselining test after r59385.

platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Rebaseline

3:39 PM Changeset in webkit [59392] by beidson@apple.com

3 edits in trunk/LayoutTests

Adding fast/loader/recursive-before-unload-crash-expected.html to the gtk skipped list
because it needs more logging in its DRT to pass:

platform/gtk/Skipped:

Adding fast/loader/recursive-before-unload-crash-expected.html to the qt skipped list
because it's hanging:

platform/qt/Skipped:

3:39 PM Changeset in webkit [59391] by ap@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=39089
<rdar://problem/7974044> Domain names in Russian '.рф' domain are displayed as punycode

Add a custom check for this domain. Currently, this is the only non-ASCII TLD, we'll
investigate a more extensible solution when there are more, and we know what the
typical restictions are.

Misc/WebNSURLExtras.mm: (allCharactersAllowedByTLDRules): (-[NSString _web_mapHostNameWithRange:encode:makeString:]):

3:33 PM Changeset in webkit [59390] by tkent@chromium.org

3 edits
2 adds in trunk

2010-05-13 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Can't submit a form with <input type=checkbox required>
https://bugs.webkit.org/show_bug.cgi?id=39065

fast/forms/interactive-validation-required-checkbox-expected.txt: Added.
fast/forms/interactive-validation-required-checkbox.html: Added.

2010-05-13 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Can't submit a form with <input type=checkbox required>
https://bugs.webkit.org/show_bug.cgi?id=39065

Test: fast/forms/interactive-validation-required-checkbox.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): Update the validity cache when a checkbox state is changed.

3:12 PM Changeset in webkit [59389] by beidson@apple.com

1 edit
1 copy in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by NOBODY (Layout test fix)

Add Tiger specific results for my new test.

platform/mac-tiger/fast/loader/recursive-before-unload-crash-expected.txt: Copied from fast/loader/recursive-before-unload-crash-expected.txt.

3:07 PM Changeset in webkit [59388] by kbr@google.com

12 edits in trunk

2010-05-13 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all layout tests (including WebGL) in Safari, and WebGL tests in
Chromium.

Test: revised array-unit-tests.html to test both type names.
Revised global prototype and constructor tests to ignore new types.

bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray):
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::ArrayBufferAccessorGetter): (WebCore::V8DOMWindow::Int8ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter): (WebCore::V8DOMWindow::Int16ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter): (WebCore::V8DOMWindow::Int32ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter): (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
page/DOMWindow.idl:

2010-05-13 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all layout tests (including WebGL) in Safari, and WebGL tests in
Chromium.

Test: revised array-unit-tests.html to test both type names.
Revised global prototype and constructor tests to ignore new types.

fast/canvas/webgl/array-unit-tests-expected.txt:
fast/canvas/webgl/array-unit-tests.html:
fast/dom/Window/script-tests/window-property-descriptors.js:
fast/dom/Window/window-properties.html:
fast/dom/script-tests/prototype-inheritance.js:
fast/js/script-tests/global-constructors.js:

2:51 PM Changeset in webkit [59387] by hyatt@apple.com

4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39084

Reviewed by Anders Carlsson.

Improve :visited style resolution to reduce its memory footprint and to make some speed adjustments and
simplifications.

(1) Tie the caching of link state on CSSStyleSelector to the element. Just clear out the element when
style resolution finishes for the unvisited case to avoid caching across external calls. The internal
calls share the cache just fine by doing this.

(2) Delete the RenderStyle if the link is unvisited. This shouldn't take long enough to make us vulnerable
to timing attacks, and it makes sure the overall footprint stays the way it used to be for unvisited links.

(3) Limit the set of properties that can be applied to :visited links to only the colors it supports. This
stops images from being loadable from :visited rules.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::init):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::isValidVisitedLinkProperty):
(WebCore::CSSStyleSelector::applyProperty):

css/CSSStyleSelector.h:
rendering/style/RenderStyle.cpp:

(WebCore::colorIncludingFallback):

2:32 PM Changeset in webkit [59386] by weinig@apple.com

4 edits in trunk/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>

Reviewed by Darin Adler.

Use an external cache to speedup cssText for CSSPrimitiveValue instead of an extra member variable.

css/CSSPrimitiveValue.cpp:

(WebCore::cssTextCache):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::cssText):

css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

1:48 PM Changeset in webkit [59385] by enrica@apple.com

8 edits
2 adds in trunk

Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): resetting m_childrenInline flag to true when layout a block with no children.

LayoutTests:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

editing/deleting/delete-block-contents-004-expected.txt: Added.
editing/deleting/delete-block-contents-004.html: Added.

The following tests results have been updated to reflect the new renderer structure.

editing/deleting/in-visibly-empty-root-expected.txt:
platform/mac/editing/deleting/5408255-expected.txt:
platform/mac/editing/deleting/delete-select-all-001-expected.txt:
platform/mac/editing/selection/4895428-1-expected.txt:
platform/mac/editing/selection/4895428-4-expected.txt:

1:31 PM Changeset in webkit [59384] by beidson@apple.com

6 edits
2 adds in trunk

Repro crash at www.sears.com (infinite recursion in beforeunload handler)
<rdar://problem/7965182> and https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/recursive-before-unload-crash.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldClose): Copied from Frame, with the pageDismissal flag set.

loader/FrameLoader.h:

page/Frame.cpp:

(WebCore::Frame::shouldClose): Forward to the new FrameLoader::shouldClose().

page/Frame.h:

(WebCore::Frame::existingDOMWindow):

LayoutTests:

fast/loader/recursive-before-unload-crash-expected.txt: Added.
fast/loader/recursive-before-unload-crash.html: Added.

1:06 PM Changeset in webkit [59383] by eric@webkit.org

8 edits in trunk

2010-05-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59376.
http://trac.webkit.org/changeset/59376
https://bugs.webkit.org/show_bug.cgi?id=39080

Broke window prototype tests (Requested by jamesr on #webkit).

fast/canvas/webgl/array-unit-tests-expected.txt:
fast/canvas/webgl/array-unit-tests.html:

2010-05-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59376.
http://trac.webkit.org/changeset/59376
https://bugs.webkit.org/show_bug.cgi?id=39080

Broke window prototype tests (Requested by jamesr on #webkit).

bindings/generic/RuntimeEnabledFeatures.h:
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webGLFloatArray):
bindings/v8/custom/V8DOMWindowCustom.cpp:
page/DOMWindow.idl:

12:35 PM Changeset in webkit [59382] by diegohcg@webkit.org

2 edits in trunk/WebKitTools

2010-05-13 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve QtLauncher user agent dialog resize
https://bugs.webkit.org/show_bug.cgi?id=39062

QtLauncher/main.cpp: (LauncherWindow::showUserAgentDialog):

12:24 PM Changeset in webkit [59381] by pfeldman@chromium.org

7 edits
1 copy
1 add in trunk

2010-05-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: A disabled style property cannot be deleted.

https://bugs.webkit.org/show_bug.cgi?id=39057

inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::applyStyleText):

2010-05-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: A disabled style property cannot be deleted.

https://bugs.webkit.org/show_bug.cgi?id=39057

inspector/elements-tests.js: (frontend_getSelectedElementStyles):
inspector/styles-disable-then-delete-expected.txt: Added.
inspector/styles-disable-then-delete.html: Added.
inspector/styles-disable-then-enable.html:

12:15 PM Changeset in webkit [59380] by diegohcg@webkit.org

2 edits in trunk/WebKit/qt

2010-05-11 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebPage::inputMethods failing on Maemo5
https://bugs.webkit.org/show_bug.cgi?id=38685

Check if the SIP (Software Input Panel) is triggered, which usually happens
in the case of a mobile platforms, an user input form receives a mouse click.

tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

12:08 PM Changeset in webkit [59379] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-05-13 Eric Seidel <eric@webkit.org>

Reviewed by Ojan Vafai.

Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
https://bugs.webkit.org/show_bug.cgi?id=39067

Fix yet another typo in my original hack.
I also added another unit test for this fix.

Scripts/webkitpy/common/config/ports.py:
Scripts/webkitpy/common/config/ports_unittest.py:

11:59 AM Changeset in webkit [59378] by tonikitoo@webkit.org

2 edits in trunk/WebKit/qt

[Qt] REGRESSION(r58497) tst_QGraphicsWebView::crashOnViewlessWebPages() is failing
https://bugs.webkit.org/show_bug.cgi?id=38655

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-05-11
Reviewed by Laszlo Gombos.

Fix double free by moving the connect till after the resize.

The bug is causes by the fact that a resize of an empty page causes a
layout, thus deleting the qgraphicswebview before setHtml is called,
which then deletes it again, causing a double free.

tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::crashOnViewlessWebPages):

11:54 AM Changeset in webkit [59377] by tonikitoo@webkit.org

2 edits in trunk/WebKit/qt

Regression(r59152): QGraphicsPageClient is not forwarding scroll and update events to view https://bugs.webkit.org/show_bug.cgi?id=39016

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-05-12
Reviewed by Laszlo Gombos.

Some forward calls got lost during the refatory.

WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::scroll):
(WebCore::PageClientQGraphicsWidget::update):

11:51 AM Changeset in webkit [59376] by kbr@google.com

8 edits in trunk

2010-05-12 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all WebGL layout tests in Safari and Chromium.

Test: revised array-unit-tests.html to test both type names.

bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray):
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::ArrayBufferAccessorGetter): (WebCore::V8DOMWindow::Int8ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter): (WebCore::V8DOMWindow::Int16ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter): (WebCore::V8DOMWindow::Int32ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter): (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
page/DOMWindow.idl:

2010-05-12 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all WebGL layout tests in Safari and Chromium.

Test: revised array-unit-tests.html to test both type names.

fast/canvas/webgl/array-unit-tests-expected.txt:
fast/canvas/webgl/array-unit-tests.html:

11:44 AM BuildingQtOnLinux edited by ikipou@gmail.com

Update the minimal verison of Qt required to compile WebKit (diff)

11:33 AM Changeset in webkit [59375] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-05-13 Eric Seidel <eric@webkit.org>

Reviewed by Ojan Vafai.

Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
https://bugs.webkit.org/show_bug.cgi?id=39067

My previous (unreviewed) hack didn't actually work due to checking "mac" instead of "Mac".
This change fixes my hack, and unit tests it.

Scripts/webkitpy/tool/mocktool.py:
- Make it possible to make run_command log too.
Scripts/webkitpy/tool/steps/runtests.py:
- Fix my hack to actually work.
Scripts/webkitpy/tool/steps/steps_unittest.py:
- Test my hack (and basic RunTests behavior as well).

11:17 AM Changeset in webkit [59374] by beidson@apple.com

3 edits in trunk/WebCore

Part of <rdar://problem/7965182> and https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by John Sullivan.

No new tests. (No change in behavior)

m_unloadEventBeingDispatched was already overloaded to include both unload and pagehide events.
In general, these are "page dismissal" events, and might also include beforeunload, so let's rename
the flag!

loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::pageHidden):

loader/FrameLoader.h:

10:59 AM Changeset in webkit [59373] by tonikitoo@webkit.org

8 edits in trunk

2010-05-13 Antonio Gomes <tonikitoo@webkit.org>, Yi Shen <yi.4.shen@nokia.com>

Reviewed by Kenneth Christiansen.

[Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
https://bugs.webkit.org/show_bug.cgi?id=37759

WebKit/qt:

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::markerTextForListItem): (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
WebCoreSupport/DumpRenderTreeSupportQt.h:

WebKitTools:

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::computedStyleIncludingVisitedInfo):
DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

platform/qt/Skipped:

10:57 AM UsingGitWithWebKit edited by ojan@chromium.org

(diff)

10:55 AM UsingGitWithWebKit edited by ojan@chromium.org

(diff)

10:27 AM Changeset in webkit [59372] by Joseph Pecoraro

4 edits in trunk/WebCore

2010-05-13 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Event Markers should be hidden in Resource's "Size" Graph
https://bugs.webkit.org/show_bug.cgi?id=39074

Added Show / Hide event dividers functionality to the timeline grid,
and included delegation functions in AbstractTimelinePanel.

inspector/front-end/AbstractTimelinePanel.js: delegate to the inner grid (WebInspector.AbstractTimelinePanel.prototype.hideEventDividers): (WebInspector.AbstractTimelinePanel.prototype.showEventDividers):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.populateSidebar): save a reference to the size graph item to know when its selected (WebInspector.ResourcesPanel.prototype._graphSelected): if the size graph is selected hide the dividers, otherwise show them
inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.hideEventDividers): set the container to display: none (WebInspector.TimelineGrid.prototype.showEventDividers): set the container to display: block

10:08 AM Changeset in webkit [59371] by Adam Roben

5 edits in trunk/WebKitTools

Convert status bar text to UTF-8 before logging it on Windows

We were previously logging the text using printf("%S", bstr). This
converts the UTF-16 BSTR to a multibyte string using wctomb, which
uses the codepage for the current locale to perform the conversion.
The conversion was failing, causing printf to bail and truncate the
string. By converting to UTF-8 manually before logging, we avoid this
issue (and also end up with UTF-8 output, which is what the expected
results contain). We may have to do this in other places in DRT,
eventually.

Fixes <http://webkit.org/b/38849> REGRESSION (r59016):
plugins/set-status.html fails on Windows

Reviewed by Alexey Proskuryakov.

DumpRenderTree/win/DumpRenderTree.cpp:

(toUTF8): Moved this here from FrameLoadDelegate. Renamed from
BSTRtoString.

DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of toUTF8.

DumpRenderTree/win/FrameLoadDelegate.cpp: Removed BSTRtoString.

(descriptionSuitableForTestResult): Updated for rename.

DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::setStatusText): Convert the status bar text to UTF-8
before logging it so that Windows won't try (and fail) to convert it
to the current locale's codepage.

10:07 AM Changeset in webkit [59370] by Adam Roben

2 edits in trunk/SunSpider

Fix typo in sunspider-compare-results.js that caused incorrect two-sample t statistics to be computed

Fixes <http://webkit.org/b/38768> SunSpider computes incorrect
two-sample t statistics

Reviewed by Darin Adler.

resources/sunspider-compare-results.js:

(sunspiderCompareResults.resultLine): Fixed the calculation of the t
variable to match the definition of a two-sample t statistic. Looks
like this was just a simple typo.

8:35 AM Changeset in webkit [59369] by Martin Robinson

2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Events tests failing
https://bugs.webkit.org/show_bug.cgi?id=31436

Unskip these two test which are now passing.

platform/gtk/Skipped: Unskip two tests.

8:34 AM Changeset in webkit [59368] by pfeldman@chromium.org

2 edits in trunk/WebKit/chromium

2010-05-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: main inspector toolbar takes noticeable time to expand.

https://bugs.webkit.org/show_bug.cgi?id=39013

src/js/DevTools.js: (devtools.domContentLoaded):

8:21 AM Changeset in webkit [59367] by Martin Robinson

2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Two forms tests failing
https://bugs.webkit.org/show_bug.cgi?id=31435

Unskip passing tests.

platform/gtk/Skipped: Unskip these tests, because they are passing now.

7:56 AM Changeset in webkit [59366] by chang.shu@nokia.com

2 edits in trunk/WebCore

2010-05-13 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Based on the spec and Philip Taylor's test suite, strokeStyle and fillStyle attributes
must initially have the string value #000000.
The link to the spec:
http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.colours.default

https://bugs.webkit.org/show_bug.cgi?id=39068

The complete test suite is in the process of checking in.
https://bugs.webkit.org/show_bug.cgi?id=20553

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State):

7:41 AM Changeset in webkit [59365] by yurys@chromium.org

17 edits
3 deletes in trunk/WebCore

2010-05-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed, rolling out r59360.
http://trac.webkit.org/changeset/59360
https://bugs.webkit.org/show_bug.cgi?id=38667

It broke Chromium Win build

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected):
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._keyDown):
inspector/front-end/HelpScreen.js: Removed.
inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut._makeKeyFromCodeAndModifiers):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
inspector/front-end/ShortcutsHelp.js: Removed.
inspector/front-end/SidebarPane.js: (WebInspector.SidebarPane.prototype._onTitleKeyDown):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.removeSection):
inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleKeyDown):
inspector/front-end/WebKit.qrc:
inspector/front-end/helpScreen.css: Removed.
inspector/front-end/inspector.html:
inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector._searchKeyDown): (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
inspector/front-end/utilities.js:

7:39 AM Changeset in webkit [59364] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-05-13 Eric Seidel <eric@webkit.org>

Unreviewed hack, attempting to get the commit-queue running again.

Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
https://bugs.webkit.org/show_bug.cgi?id=39067

I had this hack locally on the commit-queue, but it's fragile
and broke this morning. It will work much better if committed
to the repository. In either case it's temporary while we
work up a real fix for bug 38912.

Scripts/webkitpy/common/config/ports.py:
- Expose an is_leopard() method.
Scripts/webkitpy/tool/steps/runtests.py:
- Don't run compositing/iframes tests on the commit-queue under leopard.

7:35 AM Changeset in webkit [59363] by antti.j.koivisto@nokia.com

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39063
[Qt] Tiled backing store checker pattern does not paint correctly when scaling factor is not 1

Reviewed by Kenneth Rohde Christiansen.

Use the dirty rect that has been adjusted for scaling instead of the original one.

platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::paint):

7:07 AM Changeset in webkit [59362] by chang.shu@nokia.com

2 edits in trunk/WebCore

2010-05-13 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Based on Philip Taylor's test suite, resetting the canvas
state resets the current path.
https://bugs.webkit.org/show_bug.cgi?id=38934

The complete test suite is in the process of checking in.
https://bugs.webkit.org/show_bug.cgi?id=20553

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset):

6:48 AM Changeset in webkit [59361] by yurys@chromium.org

8 edits
1 delete in trunk/LayoutTests

2010-05-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Chromium build fix. Partially rever r59277 which updated Chromium's expectations
after r59270. r59270 was reverted, so we need to revert Chromium's expectations.

platform/chromium-linux/editing/deleting/5408255-expected.checksum:
platform/chromium-mac/editing/deleting/5408255-expected.checksum: Removed.
platform/chromium-win/editing/deleting/5408255-expected.checksum:
platform/chromium-win/editing/deleting/5408255-expected.txt:
platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
platform/chromium-win/editing/selection/4895428-1-expected.txt:
platform/chromium-win/editing/selection/4895428-4-expected.txt:
platform/chromium-win/fast/events/mouseout-dead-node-expected.txt:

6:42 AM Changeset in webkit [59360] by pfeldman@chromium.org

17 edits
3 adds in trunk/WebCore

2010-05-13 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Added help screen with keyboard shortcuts.
https://bugs.webkit.org/show_bug.cgi?id=38667

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._registerShortcuts):
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._registerShortcuts):
inspector/front-end/HelpScreen.js: Added.
inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut.makeDescriptor): (WebInspector.KeyboardShortcut.shortcutToString): (WebInspector.KeyboardShortcut._modifiersToString):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.ScriptsPanel.prototype._registerShortcuts):
inspector/front-end/ShortcutsHelp.js: Added.
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.removeSection): (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
inspector/front-end/WebKit.qrc:
inspector/front-end/helpScreen.css: Added.

5:12 AM Changeset in webkit [59359] by hamaji@chromium.org

2 edits in trunk

2010-05-13 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Shinichiro Hamaji.

Update test_expectations.txt for Chromium.
fast/forms/implicit-submission.html is flaky on Linux.
See http://crbug.com/43890 for detail.

platform/chromium/test_expectations.txt:

5:05 AM Changeset in webkit [59358] by mjs@apple.com

2 edits in trunk/JavaScriptCore

No review, attempted build fix.

Try to fix Tiger build with some gratuitous initialization of
seemingly uninitialized variables.

wtf/text/StringImpl.h:

(WebCore::StringImpl::tryCreateUninitialized):

2:43 AM Changeset in webkit [59357] by hamaji@chromium.org

3 edits
2 adds in trunk

2010-05-13 Yoshiki Hayashi <yhayashi@google.com>

Reviewed by Darin Adler.

Fix a bug in handleRunInChild where only the first child run-in block
is inserted because removeChildNode clears next sibling.
https://bugs.webkit.org/show_bug.cgi?id=25047

fast/css/run-in-children-expected.txt: Added.
fast/css/run-in-children.html: Added.

2010-05-13 Yoshiki Hayashi <yhayashi@google.com>

Reviewed by Darin Adler.

Fix a bug in handleRunInChild where only the first child run-in block
is inserted because removeChildNode clears next sibling.
https://bugs.webkit.org/show_bug.cgi?id=25047

Test: fast/css/run-in-children.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):

2:37 AM Changeset in webkit [59356] by alex

2 edits in trunk/WebCore

2010-05-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

In case there is no expose event we render the theme in a pixmap
and copy it to the cairo context. This is slow but it is used just
in case we are printing nowadays.

[GTK] Theme does not render when printing
https://bugs.webkit.org/show_bug.cgi?id=38896

platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget):

2:36 AM Changeset in webkit [59355] by mjs@apple.com

5 edits in trunk/JavaScriptCore

2010-05-13 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

Various JavaScript string optimizations
https://bugs.webkit.org/show_bug.cgi?id=39051

Approximately 1% SunSpider speedup.

runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin): Remove branches from the hot code path by moving the first pass outside the loop, and duplicating the hot loop to extract the loop-invariant branch.
runtime/RegExp.cpp: (JSC::RegExp::match): resize ovector to 0 instead of clearing to avoid thrash in case of large matches.
runtime/RegExpConstructor.h: (JSC::RegExpConstructor::performMatch): Mark ALWAYS_INLINE to make the compiler respect our authority.
runtime/StringPrototype.cpp: (JSC::jsSpliceSubstringsWithSeparators): Inline. (JSC::stringProtoFuncSubstring): Rewrite boundary condition checks to reduce the number of floating point comparisons and branches.

1:52 AM Changeset in webkit [59354] by ukai@chromium.org

3 edits in trunk

WebKitTools: Unreviewed fix. Revert previous change.

Even if with-statments are changed in websocket_server.py, it also claims syntax error for with statement in http_server.py.
Until python 2.5 is installed on tiger bot, skips websocket/tests on tiger.

Scripts/webkitpy/layout_tests/port/websocket_server.py: use with statement

LayoutTests: Unreviewed.

Skip websocket/tests on tiger, until Python 2.5 is installed on tiger bot.

platform/mac-tiger/Skipped: Add websocket/tests

1:52 AM Changeset in webkit [59353] by ukai@chromium.org

2 edits in trunk/WebKitTools

WebSocket: pywebsocket 0.5
https://bugs.webkit.org/show_bug.cgi?id=38034

Reviewed by David Levin.

Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.

Scripts/new-run-webkit-websocketserver: Add --output-dir option.
Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
Scripts/run-webkit-websocketserver: Ditto.
Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
Scripts/webkitpy/thirdparty/pywebsocket: Removed.

1:21 AM Changeset in webkit [59352] by ukai@chromium.org

2 edits in trunk/WebKitTools

Unreviewed fix.

On tiger bot, it claims syntax error for with statement.

Scripts/webkitpy/layout_tests/port/websocket_server.py: rewrite with statement with try-finally.

12:32 AM Changeset in webkit [59351] by yuzo@google.com

3 edits
2 adds in trunk

2010-05-12 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Fix Bug 35014 - Modifying UA rules from page JS crashes
https://bugs.webkit.org/show_bug.cgi?id=35014

fast/css/modify-ua-rules-from-javascript-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
fast/css/modify-ua-rules-from-javascript.html: Added.

2010-05-12 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Fix Bug 35014 - Modifying UA rules from page JS crashes
Added a NULL check.
https://bugs.webkit.org/show_bug.cgi?id=35014

Test: fast/css/modify-ua-rules-from-javascript.html

css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

12:28 AM Changeset in webkit [59350] by ukai@chromium.org

6 edits
35 deletes in trunk/WebKitTools

2010-05-13 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

WebSocket: pywebsocket 0.5
https://bugs.webkit.org/show_bug.cgi?id=38034

Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.

Scripts/new-run-webkit-websocketserver: Add --output-dir option.
Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
Scripts/run-webkit-websocketserver: Ditto.
Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
Scripts/webkitpy/thirdparty/pywebsocket: Removed.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed