⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 10, 2010:

11:54 PM Changeset in webkit [63057] by Darin Adler
  • 27 edits
    3 adds in trunk

2010-07-10 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Enhance content attribute reflection for URL attributes, including adding a non-empty option
​https://bugs.webkit.org/show_bug.cgi?id=42040

Test: fast/dom/URL-attribute-reflection.html

Changed syntax from [ReflectURL] to [Reflect,URL] and also added support for
a new option, NonEmpty, which implements the non-empty URL concept from the
HTML5 specification.

  • bindings/scripts/CodeGenerator.pm: Changed code to expect the Reflect and URL extended attributes to come in separately. The URL one simply means "the string of this attribute is a URL", since we don't have a distinct type for URL. Also added a new NonEmpty extended attribute.
  • bindings/scripts/CodeGeneratorJS.pm: Removed now-unneeded code to handle ReflectURL.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated for new added test cases and the fix I made to the reflectedCustomURLAttr test.
  • bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto. Also, for some reason the V8 bindig writes out the keywords into the generated file as comments, so the keyword change had a direct efffect on the output file.
  • bindings/scripts/test/TestObj.idl: Changed the test cases for ReflectURL to use the new syntax. Added test cases for NonEmpty. Fixed the name of reflectedNonEmptyURLAttr, which accidentally was repeating reflectedURLAttr instead; never noticed because we never compile the test output.
  • dom/Element.cpp: (WebCore::Element::getNonEmptyURLAttribute): Added. For use by NonEmpty and also by any code that wants to implement the non-empty URL content attribute semantic.
  • dom/Element.h: Ditto.
  • html/HTMLAnchorElement.idl: Use Reflect,URL instead of ReflectURL.
  • html/HTMLAreaElement.idl: Ditto.
  • html/HTMLFrameElement.idl: Ditto.
  • html/HTMLImageElement.idl: Ditto.
  • html/HTMLInputElement.idl: Ditto.
  • html/HTMLLinkElement.idl: Ditto.
  • html/HTMLMediaElement.idl: Ditto.
  • html/HTMLObjectElement.idl: Ditto.
  • html/HTMLScriptElement.idl: Ditto.
  • html/HTMLVideoElement.idl: Ditto.

2010-07-10 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Enhance content attribute reflection for URL attributes, including adding a non-empty option
​https://bugs.webkit.org/show_bug.cgi?id=42040

The current test results show many failures, and we should follow up with fixes
either to the DOM implementation, or to the test result expectations.

  • fast/dom/URL-attribute-reflection-expected.txt: Added.
  • fast/dom/URL-attribute-reflection.html: Added.
  • fast/dom/script-tests/URL-attribute-reflection.js: Added.
6:14 PM Changeset in webkit [63056] by oliver@apple.com
  • 6 edits in trunk/JavaScriptCore

2010-07-10 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

HAVE_COMPUTED_GOTO is dependent on the interpreter being enabled
​https://bugs.webkit.org/show_bug.cgi?id=42039

Separate the existence of computed goto support in the compiler
from whether or not we are using the interpreter. All the current
HAVE(COMPUTED_GOTO) guards are for the interpreter, but I'd like
the option of using it elsewhere. The interpreter now uses
ENABLE(COMPUTED_GOTO_INTERPRETER)

  • bytecode/Instruction.h: (JSC::Instruction::Instruction):
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter): (JSC::Interpreter::isOpcode): (JSC::Interpreter::privateExecute):
  • interpreter/Interpreter.h: (JSC::Interpreter::getOpcode): (JSC::Interpreter::getOpcodeID):
  • wtf/Platform.h:
5:11 PM Changeset in webkit [63055] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-07-10 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove switches from inner expression loops in the parser
​https://bugs.webkit.org/show_bug.cgi?id=42035

Use bitmasks and flags on the token types to identify unary and
binary operators, rather than switching on the token type to
identify them.

  • parser/JSParser.cpp: (JSC::isUnaryOp): (JSC::JSParser::isBinaryOperator):
  • parser/JSParser.h: (JSC::):
4:11 PM Changeset in webkit [63054] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2010-07-10 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Adler.

Add missing derrived sources to xcode project
​https://bugs.webkit.org/show_bug.cgi?id=42034

This allows --web-timing to work with build-webkit on OSX with JSC.
This should have been done in bug 41442.

No new tests because no new functionality.

  • WebCore.xcodeproj/project.pbxproj:
3:31 PM MathML 3 testsuite results edited by François Sausset
(diff)
3:28 PM Changeset in webkit [63053] by andersca@apple.com
  • 6 edits in trunk

Don't initialize plug-ins until allowed by the page
​https://bugs.webkit.org/show_bug.cgi?id=42033

Reviewed by Sam Weinig.

WebCore:

  • WebCore.exp.in:

Export Document::addMediaCanStartListener and Document::removeMediaCanStartListener.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::paint):
(WebKit::NetscapePlugin::geometryDidChange):
Assert that the plug-in is started.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Initialize m_isWaitingUntilMediaCanStart.

(WebKit::PluginView::~PluginView):
If necessary, remove the plug-in view as a MediaCanStartListener.

(WebKit::PluginView::initializePlugin):
If we're not allowed to initialize the plug-in, add the plug-in view as a MediaCanStartListener.

(WebKit::PluginView::paint):
Check that the plug-in is initialized.

(WebKit::PluginView::viewGeometryDidChange):
Ditto.

(WebKit::PluginView::mediaCanStart):
Initialize the plug-in.

  • WebProcess/Plugins/PluginView.h:
2:47 PM Changeset in webkit [63052] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Have the plug-in view initialize the plug-in
​https://bugs.webkit.org/show_bug.cgi?id=42030

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/DummyPlugin.cpp:

(WebKit::DummyPlugin::initialize):

  • WebProcess/Plugins/DummyPlugin.h:

Plugin::initialize now takes a struct.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::initialize):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Plugin::initialize now takes a struct.

  • WebProcess/Plugins/Plugin.h:

Add Parameters struct.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Add Parameters parameter.

(WebKit::PluginView::~PluginView):
Add m_plugin null check.

(WebKit::PluginView::initializePlugin):
Try to initialize the plug-in and zero out the plug-in if initialization fails.

(WebKit::PluginView::paint):
Add m_plugin null check.

(WebKit::PluginView::setParent):
Initialize the plug-in.

  • WebProcess/Plugins/PluginView.h:

(WebKit::PluginView::create):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Don't initialize the plug-in here.

2:38 PM Changeset in webkit [63051] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore: Patch for ​https://bugs.webkit.org/show_bug.cgi?id=42021
isEqualNode should work for DocumentType nodes

Reviewed by Anders Carlsson.

Test: fast/dom/Node/isEqualNode.html

  • dom/Node.cpp:

(WebCore::Node::isEqualNode): Add DocumentType logic from the DOM3 spec.

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=42021
isEqualNode should work for DocumentType nodes

Reviewed by Anders Carlsson.

  • fast/dom/Node/isEqualNode-expected.txt: Added.
  • fast/dom/Node/isEqualNode.html: Added.
  • fast/dom/Node/script-tests/isEqualNode.js: Added.
2:18 PM Changeset in webkit [63050] by dbates@webkit.org
  • 9 edits
    1 add in trunk/WebCore

2010-07-10 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

Move enum ReasonForCallingCanExecuteScripts to header ScriptControllerBase.h
​https://bugs.webkit.org/show_bug.cgi?id=39339

Moved the enum ReasonForCallingCanExecuteScripts, which was
defined in both the JSC and V8 ScriptController.h file, into
a shared file called ScriptControllerBase.h.

No functionality was changed, so no new tests.

  • GNUmakefile.am: Added file bindings/ScriptControllerBase.h.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcproj/WebCoreCommon.vsprops: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/ScriptControllerBase.h: Added. (WebCore::):
  • bindings/js/ScriptController.h: #include ScriptControllerBase.h
  • bindings/v8/ScriptController.h: Ditto.
1:18 PM MathML 3 testsuite results edited by François Sausset
(diff)
12:39 PM Changeset in webkit [63049] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Call Page::canStartMedia when the WKView is added to/removed from a window
​https://bugs.webkit.org/show_bug.cgi?id=42029

Reviewed by Oliver Hunt.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:

(WebPageMessage::):
Add SetIsInWindow.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:]):
Call setIsInWindow.

(-[WKView _updateVisibility]):
Call setIsInWindow.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Initialize m_isInWindow.

(WebKit::WebPageProxy::setIsInWindow):
Send WebPageMessage::SetIsInWindow.

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setIsInWindow):
Call Page::canStartMedia.

(WebKit::WebPage::didReceiveMessage):
Handle the SetIsInWindow message.

  • WebProcess/WebPage/WebPage.h:
10:57 AM Changeset in webkit [63048] by mitz@apple.com
  • 6 edits
    4 adds in trunk

<rdar://problem/8153214> Continuation outlines in layers do not paint correctly

Reviewed by Anders Carlsson.

WebCore:

Test: fast/inline/continuation-outlines-with-layers-2.html

Continuation outlines are normally painted by the containing block. However, when the
block and the inline are not enclosed by the same self-painting layer, the inline has to
paint its own outlines. This was handled correctly only for the case where the inline had
its own self-painting layer, but now when an ancestor inline had the self-painting layer.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paint): Instead of testing for having a self-painting layer, test
whether any intermediate box between the inline and the containing block has a self-painting
layer.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject): Ditto.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingBoxModelObject): Added this utility method.

  • rendering/RenderObject.h:

LayoutTests:

  • fast/inline/continuation-outlines-with-layers-2.html: Added.
  • platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.checksum: Added.
  • platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.png: Added.
  • platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.txt: Added.
10:33 AM Changeset in webkit [63047] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Reuse initialized NetscapePluginModules, pass parameters to NPP_New
​https://bugs.webkit.org/show_bug.cgi?id=42028

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Let the plug-in module know that a plug-in has been created.

(WebKit::NetscapePlugin::~NetscapePlugin):
Let the plug-in module know that a plug-in has been destroyed.

(WebKit::NetscapePlugin::initialize):
Pass the MIME type and parameters to the plug-in.

  • WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::initializedNetscapePluginModules):
Add list of initialized plug-in modules.

(WebKit::NetscapePluginModule::NetscapePluginModule):
Initialize m_pluginCount to 0.

(WebKit::NetscapePluginModule::~NetscapePluginModule):
Assert that we're not in the list of initialized plug-ins.

(WebKit::NetscapePluginModule::pluginCreated):
Increment the plug-in count.

(WebKit::NetscapePluginModule::pluginDestroyed):
Decrement the plug-in count and call shutdown if it's 0.

(WebKit::NetscapePluginModule::shutdown):
Call NP_Shutdown and remove the plug-in from the list of initialized plug-ins.

(WebKit::NetscapePluginModule::getOrCreate):
Look for an already initialized plug-in module before creating one.

(WebKit::NetscapePluginModule::load):
Set m_isInitialized to true.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginModuleMac.cpp:

(WebKit::NetscapePluginModule::unload):
Leak the CFBundleRef to avoid possible crashes.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Call getOrCreate instead of create.

9:02 AM Changeset in webkit [63046] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-10 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Build fix: syntax and typo issues
​https://bugs.webkit.org/show_bug.cgi?id=41859

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag):
5:02 AM MathML 3 testsuite results edited by François Sausset
(diff)
2:01 AM Changeset in webkit [63045] by eric@webkit.org
  • 5 edits in trunk

2010-07-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs adjustForeignAttributes support
​https://bugs.webkit.org/show_bug.cgi?id=42022

  • html5lib/runner-expected-html5.txt:
    • We now pass 3 more tests.

2010-07-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs adjustForeignAttributes support
​https://bugs.webkit.org/show_bug.cgi?id=42022

To add adjust foreign attributes support I had to add an
AtomicString (prefixed name) to QualifiedName hash. Once I had
done that, I decided it would be best for the other "adjust" functions
to share the same hash logic, so I moved them to using the same
AtomicString -> QualifiedName hash as well.

Tested by html5lib/runner.html

  • dom/Attribute.h: (WebCore::Attribute::parserSetName):
  • html/HTMLTreeBuilder.cpp:
1:14 AM Changeset in webkit [63044] by rwlbuis@webkit.org
  • 16 edits in trunk/WebCore

2010-07-10 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=41978
Remove namespace prefixes from idl files

No new tests, idl syntax fixes.

  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSVariablesRule.idl:
  • svg/SVGAnimatedString.idl:
  • svg/SVGColor.idl:
  • svg/SVGDocument.idl:
  • svg/SVGLangSpace.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGStringList.idl:
  • svg/SVGStylable.idl:
  • svg/SVGStyleElement.idl:
  • svg/SVGTests.idl:
  • svg/SVGZoomEvent.idl:
  • xml/XPathEvaluator.idl:
12:59 AM Changeset in webkit [63043] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, GTK build fix.

  • bindings/gobject/GObjectEventListener.h:
12:24 AM Changeset in webkit [63042] by dumi@chromium.org
  • 16 edits in trunk/WebCore

Remove unnecessary includes in header files in WebCore/dom.
​https://bugs.webkit.org/show_bug.cgi?id=41941

Reviewed by Darin Adler.

  • css/StyleMedia.h:
  • dom/BeforeLoadEvent.h:
  • dom/CustomEvent.h:
  • dom/DOMStringMap.h:
  • dom/DeviceOrientationEvent.h:
  • dom/EventListener.h:
  • dom/MessagePort.h:
  • dom/Node.cpp:
  • dom/NodeFilter.h:
  • dom/NodeRareData.h:
  • dom/RegisteredEventListener.h:
  • dom/SelectorNodeList.cpp:
  • dom/SelectorNodeList.h:
  • dom/StyleElement.h:
  • dom/Traversal.h:

Jul 9, 2010:

10:01 PM Changeset in webkit [63041] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

Windows testers running Windows 7 were hanging during test_kill_process. Changing the
number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
slow down the tests).

Rubber-stamped by Dan Bernstein.

  • Scripts/webkitpy/common/system/executive.py:
9:32 PM Changeset in webkit [63040] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-09 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Take out WebPlugin::supportsFind since we can accomplish the same thing by having a return value on startFind
​https://bugs.webkit.org/show_bug.cgi?id=42011

  • public/WebPlugin.h: (WebKit::WebPlugin::startFind):
9:20 PM Changeset in webkit [63039] by tony@chromium.org
  • 4 edits
    2 adds in trunk

2010-07-09 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting pre
​https://bugs.webkit.org/show_bug.cgi?id=38231

  • editing/execCommand/indent-pre-expected.txt: Added.
  • editing/execCommand/indent-pre.html: Added.

2010-07-09 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting pre
​https://bugs.webkit.org/show_bug.cgi?id=38231

Test: editing/execCommand/indent-pre.html

  • editing/IndentOutdentCommand.cpp: (WebCore::countParagraphs): (WebCore::IndentOutdentCommand::indentRegion): Split text nodes into one node per paragraph

so moveParagraph doesn't get confused.

(WebCore::IndentOutdentCommand::splitTextNodes):

  • editing/IndentOutdentCommand.h:
9:08 PM Changeset in webkit [63038] by arv@chromium.org
  • 10 edits in trunk

2010-07-09 Erik Arvidsson <​arv@chromium.org>

Reviewed by Darin Adler.

Computed style is not implemented for padding-start, padding-end, margin-start, margin-end
​https://bugs.webkit.org/show_bug.cgi?id=41496

  • fast/css/margin-start-end-expected.txt:
  • fast/css/padding-start-end-expected.txt:
  • fast/css/script-tests/margin-start-end.js: Added tests for computed style.
  • fast/css/script-tests/padding-start-end.js: Added tests for computed style.

2010-07-09 Erik Arvidsson <​arv@chromium.org>

Reviewed by Darin Adler.

Computed style is not implemented for padding-start, padding-end, margin-start, margin-end
​https://bugs.webkit.org/show_bug.cgi?id=41496

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSProperty.cpp: (WebCore::CSSProperty::resolveDirectionAwareProperty): This function resolves the property ID for a direction aware property.
  • css/CSSProperty.h:
  • css/CSSStyleSelector.cpp: Use helper function. (WebCore::CSSStyleSelector::applyProperty):
8:47 PM Changeset in webkit [63037] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 tree builder should pass some LayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=41991

Before this patch, we weren't attaching text nodes to the render tree,
which turns out to be important. :)

This patch fixes more than 10,000 LayoutTests.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): (WebCore::HTMLConstructionSite::attachAtSite):
8:36 PM Changeset in webkit [63036] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

[WINCE] Buildfix for TextEncodingRegistry
​https://bugs.webkit.org/show_bug.cgi?id=41992

Renamed TextCodecWince to TextCodecWinCE.

  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
8:20 PM Changeset in webkit [63035] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-09 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Mac build fix
​https://bugs.webkit.org/show_bug.cgi?id=41967

Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
8:13 PM Changeset in webkit [63034] by dbates@webkit.org
  • 7 edits
    1 move in trunk/LayoutTests

2010-07-09 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Clean up: Move dump-list.js utility script from LayoutTests/fast/lists
to LayoutTests/fast/lists/resources
​https://bugs.webkit.org/show_bug.cgi?id=42016

Move fast/lists/dump-list.js to fast/lists/resources since it
is a utility script and not a test case.

  • fast/lists/dump-list.js: Removed. Moved to fast/lists/resources.
  • fast/lists/ol-nested-items-dynamic-insert.html: Modified to look for dump-list.js in new location.
  • fast/lists/ol-nested-items-dynamic-remove.html: Ditto.
  • fast/lists/ol-nested-items.html: Ditto.
  • fast/lists/ol-nested-list-dynamic-insert.html: Ditto.
  • fast/lists/ol-nested-list-dynamic-remove.html: Ditto.
  • fast/lists/ol-nested-list.html: Ditto.
  • fast/lists/resources/dump-list.js: Copied from LayoutTests/fast/lists/dump-list.js.
8:02 PM Changeset in webkit [63033] by diegohcg@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-09 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Antonio Gomes.

[Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
​https://bugs.webkit.org/show_bug.cgi?id=41966

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow):
7:41 PM Changeset in webkit [63032] by commit-queue@webkit.org
  • 29 edits
    3 adds in trunk

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

  • Configurations/FeatureDefines.xcconfig:

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

  • fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch.html: Added.
  • fast/dom/HTMLLinkElement/prefetch.link: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

Test: fast/dom/HTMLLinkElement/prefetch.html

  • Configurations/FeatureDefines.xcconfig:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process):
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
  • loader/Cache.cpp: (WebCore::createResource):
  • loader/CachedResource.cpp: (WebCore::CachedResource::data): (WebCore::CachedResource::didAddClient):
  • loader/CachedResource.h: (WebCore::CachedResource::): (WebCore::CachedResource::error): (WebCore::CachedResource::isPrefetch): (WebCore::CachedResource::schedule):
  • loader/CachedScript.cpp:
  • loader/CachedScript.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestLinkPrefetch): (WebCore::DocLoader::canRequest): (WebCore::DocLoader::incrementRequestCount): (WebCore::DocLoader::decrementRequestCount):
  • loader/DocLoader.h:
  • loader/loader.cpp: (WebCore::cachedResourceTypeToTargetType): (WebCore::Loader::determinePriority): (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): (WebCore::Loader::Host::didReceiveResponse): (WebCore::Loader::Host::cancelPendingRequests):
  • loader/loader.h: (WebCore::Loader::):
  • platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::):

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

  • public/WebURLRequest.h: (WebKit::WebURLRequest::):

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

  • Configurations/FeatureDefines.xcconfig:

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

  • Configurations/FeatureDefines.xcconfig:

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

  • Scripts/build-webkit:
7:30 PM Changeset in webkit [63031] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-07-09 James Robinson <​jamesr@chromium.org>

Unreviewed build fix. Add #include to pick up ExceptionCode values for config (like Qt) where it's not picked up indirectly.

  • html/HTMLCanvasElement.cpp:
6:54 PM Changeset in webkit [63030] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r61710.

6:54 PM Changeset in webkit [63029] by mrowe@apple.com
  • 4 edits in branches/safari-533.17-branch/WebCore

Merge r61341.

6:40 PM Changeset in webkit [63028] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch/WebCore

Merge r62687.

6:39 PM Changeset in webkit [63027] by mrowe@apple.com
  • 9 edits in branches/safari-533.17-branch

Merge r62894.

6:27 PM Changeset in webkit [63026] by mrowe@apple.com
  • 18 edits
    2 adds in branches/safari-533.17-branch

Merge r62875.

6:26 PM Changeset in webkit [63025] by jamesr@google.com
  • 9 edits
    2 deletes in trunk/WebCore

2010-07-09 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler.

Removes CanvasSurface and moves all of its functionality to HTMLCanvasElement.
​https://bugs.webkit.org/show_bug.cgi?id=42005

​http://trac.webkit.org/changeset/55201 introduced a new base class for HTMLCanvasElement called CanvasSurface.
The intention was that this would allow for code sharing with the then-proposed OffscreenCanvas. However,
there is no OffscreenCanvas and there's unlikely to be one soon. Additionally CanvasSurface breaks
encapsulation pretty badly by doing "static_cast<HTMLCanvasElement* const>(this)". Until an abstraction is
really needed we should just use HTMLCanvasElement when we want to talk about a canvas.

This patch moves all of CanvasSurface's functionality back up to HTMLCanvasElement and reorders the header
to be a bit more logical.

Refactor with no behavior change, thus no new tests.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CanvasSurface.cpp: Removed.
  • dom/CanvasSurface.h: Removed.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): (WebCore::HTMLCanvasElement::willDraw): (WebCore::HTMLCanvasElement::setSurfaceSize): (WebCore::HTMLCanvasElement::toDataURL): (WebCore::HTMLCanvasElement::convertLogicalToDevice): (WebCore::HTMLCanvasElement::securityOrigin): (WebCore::HTMLCanvasElement::styleSelector): (WebCore::HTMLCanvasElement::createImageBuffer): (WebCore::HTMLCanvasElement::drawingContext): (WebCore::HTMLCanvasElement::buffer): (WebCore::HTMLCanvasElement::baseTransform):
  • html/HTMLCanvasElement.h: (WebCore::HTMLCanvasElement::setObserver): (WebCore::HTMLCanvasElement::width): (WebCore::HTMLCanvasElement::height): (WebCore::HTMLCanvasElement::size): (WebCore::HTMLCanvasElement::toDataURL): (WebCore::HTMLCanvasElement::setOriginTainted): (WebCore::HTMLCanvasElement::originClean): (WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
6:25 PM Changeset in webkit [63024] by oliver@apple.com
  • 6 edits in trunk/JavaScriptCore

Tidy up lexer token ids
​https://bugs.webkit.org/show_bug.cgi?id=42014

Reviewed by Darin Adler

Stop using character literals to identify single character tokens
and instead use symbolic names for all tokens.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::makeBinaryNode):

  • parser/JSParser.cpp:

(JSC::JSParser::consume):
(JSC::JSParser::match):
(JSC::JSParser::autoSemiColon):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::allowAutomaticSemicolon):
(JSC::JSParser::parseDoWhileStatement):
(JSC::JSParser::parseWhileStatement):
(JSC::JSParser::parseVarDeclarationList):
(JSC::JSParser::parseConstDeclarationList):
(JSC::JSParser::parseForStatement):
(JSC::JSParser::parseReturnStatement):
(JSC::JSParser::parseWithStatement):
(JSC::JSParser::parseSwitchStatement):
(JSC::JSParser::parseSwitchClauses):
(JSC::JSParser::parseSwitchDefaultClause):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseDebuggerStatement):
(JSC::JSParser::parseStatement):
(JSC::JSParser::parseFormalParameters):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseExpressionOrLabelStatement):
(JSC::JSParser::parseIfStatement):
(JSC::JSParser::parseExpression):
(JSC::JSParser::parseAssignmentExpression):
(JSC::JSParser::parseConditionalExpression):
(JSC::isUnaryOp):
(JSC::JSParser::isBinaryOperator):
(JSC::JSParser::parseBinaryExpression):
(JSC::JSParser::parseProperty):
(JSC::JSParser::parseObjectLiteral):
(JSC::JSParser::parseStrictObjectLiteral):
(JSC::JSParser::parseArrayLiteral):
(JSC::JSParser::parsePrimaryExpression):
(JSC::JSParser::parseArguments):
(JSC::JSParser::parseMemberExpression):
(JSC::JSParser::parseUnaryExpression):

  • parser/JSParser.h:

(JSC::):

  • parser/Lexer.cpp:

(JSC::):
(JSC::Lexer::lex):

  • parser/Lexer.h:
6:24 PM Changeset in webkit [63023] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

Bug 42015 - Enable JSValue32_64 on ARMv7

Reviewed by Oliver Hunt.

  • Configurations/JavaScriptCore.xcconfig:
  • jit/JIT.h:
  • jit/JITStubs.cpp:
  • wtf/Platform.h:
6:17 PM Changeset in webkit [63022] by Simon Fraser
  • 15 edits in trunk

2010-07-09 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Calling layoutTestController.layerTreeAsText() should update layout
​https://bugs.webkit.org/show_bug.cgi?id=41818

Need to call updateLayout() before we check for any layers, not after,
since layout will update compositing, and may create layers.

  • page/Frame.cpp: (WebCore::Frame::layerTreeAsText):
6:16 PM Changeset in webkit [63021] by mrowe@apple.com
  • 14 edits in branches/safari-533.17-branch

Merge r62451.

6:14 PM Changeset in webkit [63020] by abarth@webkit.org
  • 11 edits in trunk/WebKitTools

2010-07-09 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

r63004 broke some python tests
​https://bugs.webkit.org/show_bug.cgi?id=42007

AbstractStep now checks options.no_squash and options.squash, so
they needed to have real values. Mock would return an object for those,
which would then act as if the values were True.

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
5:56 PM Changeset in webkit [63019] by mrowe@apple.com
  • 7 edits in branches/safari-533.17-branch/WebKit/win

Merge r62365.

5:54 PM Changeset in webkit [63018] by mrowe@apple.com
  • 10 edits in branches/safari-533.17-branch

Merge r62284.

5:47 PM Changeset in webkit [63017] by kbr@google.com
  • 3 edits
    2 adds in trunk

2010-07-09 Kenneth Russell <​kbr@google.com>

Reviewed by Nate Chapin.

bufferSubData causes crash in WebGLBuffer::associateBufferSubData
​https://bugs.webkit.org/show_bug.cgi?id=42004

Test: fast/canvas/webgl/index-validation-crash-with-buffer-sub-data.html

  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferData):
    • Allocate m_elementArrayBuffer for entry point taking only size. Guard against allocation failures of m_elementArrayBuffer.

(WebCore::WebGLBuffer::associateBufferSubData):

  • Guard against any possibility of crashes due to m_elementArrayBuffer being NULL.

2010-07-09 Kenneth Russell <​kbr@google.com>

Reviewed by Nate Chapin.

bufferSubData causes crash in WebGLBuffer::associateBufferSubData
​https://bugs.webkit.org/show_bug.cgi?id=42004

  • fast/canvas/webgl/index-validation-crash-with-buffer-sub-data-expected.txt: Added.
  • fast/canvas/webgl/index-validation-crash-with-buffer-sub-data.html: Added.
5:34 PM Changeset in webkit [63016] by kbr@google.com
  • 3 edits
    2 adds in trunk

2010-07-09 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Assertion failure in String::utf8() for certain invalid UTF16 inputs
​https://bugs.webkit.org/show_bug.cgi?id=41983

  • wtf/text/WTFString.cpp: (WebCore::String::utf8):
    • Fixed assertion when sourceExhausted is returned from convertUTF16ToUTF8.

2010-07-09 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Assertion failure in String::utf8() for certain invalid UTF16 inputs
​https://bugs.webkit.org/show_bug.cgi?id=41983

  • fast/canvas/webgl/invalid-UTF-16-expected.txt: Added.
  • fast/canvas/webgl/invalid-UTF-16.html: Added.
5:13 PM Changeset in webkit [63015] by mrowe@apple.com
  • 10 edits
    4 adds in branches/safari-533.17-branch

Merge r59338.

5:11 PM Changeset in webkit [63014] by dumi@chromium.org
  • 6 edits in trunk/WebCore

Unreviewed, but pre-approved by Eric Seidel.

Remove unnecessary includes in header files in WebCore/css.
​https://bugs.webkit.org/show_bug.cgi?id=41941

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontFaceSource.h:
  • css/CSSPrimitiveValueMappings.h:
  • css/StyleMedia.h:
4:23 PM Changeset in webkit [63013] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Get rid of manual case maps in HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=42000

No functional change, thus no tests.

  • html/HTMLTreeBuilder.cpp:
4:13 PM Changeset in webkit [63012] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61645.

4:10 PM Changeset in webkit [63011] by tonyg@chromium.org
  • 7 edits in trunk

2010-07-09 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Implement performance.timing.navigationStart
​https://bugs.webkit.org/show_bug.cgi?id=41815

  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-expected.txt:

2010-07-09 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Implement performance.timing.navigationStart
​https://bugs.webkit.org/show_bug.cgi?id=41815

See: ​http://dev.w3.org/2006/webapi/WebTiming/#nt-navigation-start

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader):
  • loader/FrameLoaderTypes.h: (WebCore::FrameLoadTimeline::FrameLoadTimeline):
  • page/Timing.cpp: (WebCore::Timing::navigationStart):
4:05 PM Changeset in webkit [63010] by ajwong@chromium.org
  • 2 edits
    102 adds in trunk/LayoutTests

Unreviewed. Build fix.

[chromium] Add in baseline for ietestcenter tests that pass. Also
rebaseline two other tests.

  • platform/chromium-mac/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/11.4.1-4.a-10-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/11.4.1-4.a-8-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.12.1.1-0-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.12.1.1-0-3-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.12.2-0-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.12.3-0-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-0-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-0-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-0-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-0-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-0-3-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-10-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-11-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-12-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-13-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-14-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-15-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-16-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-17-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-18-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-19-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-20-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-21-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-3-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-4-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-5-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-6-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-7-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-8-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-9-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.14-2-4-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.14-3-4-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.3-4-22-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.3-4-25-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.6-4-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.14-9-a-12-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-3-26-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-3-27-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-12-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-14-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-16-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-4-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-8-9-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-8-a-12-expected.txt: Added.
  • platform/chromium-win/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/11.4.1-4.a-10-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/11.4.1-4.a-8-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.12.1.1-0-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.12.1.1-0-3-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.12.2-0-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.12.3-0-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.10-0-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.10-0-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.10-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.10-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-0-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-0-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-0-3-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-10-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-11-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-12-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-13-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-14-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-15-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-16-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-17-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-18-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-19-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-20-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-21-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-3-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-4-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-5-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-6-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-7-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-8-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-9-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.14-2-4-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.14-3-4-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.3-4-22-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.3-4-25-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.6-4-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.14-9-a-12-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-3-26-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-3-27-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-12-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-14-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-16-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-4-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-8-9-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-8-a-12-expected.txt: Added.
4:05 PM Changeset in webkit [63009] by ajwong@chromium.org
  • 6 edits in trunk/LayoutTests/platform

2010-07-09 Albert J. Wong <​ajwong@chromium.org>

Reviewed by NOBODY (OOPS!).

Need a short description and bug URL (OOPS!)

  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-win/http/tests/plugins/plugin-document-has-focus-expected.txt:
  • platform/chromium-win/plugins/keyboard-events-expected.txt:
  • platform/chromium/test_expectations.txt:
4:02 PM Changeset in webkit [63008] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.17-branch

Merge r61801.

3:55 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
3:54 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
3:54 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
3:53 PM Changeset in webkit [63007] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-533.17-branch/LayoutTests

Merge r61721.

3:53 PM Changeset in webkit [63006] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61707.

3:52 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
3:44 PM Changeset in webkit [63005] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.17-branch

Merge r61424.

3:43 PM Changeset in webkit [63004] by ojan@chromium.org
  • 22 edits
    1 delete in trunk/WebKitTools

2010-07-09 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

--squash should go away and become the default
​https://bugs.webkit.org/show_bug.cgi?id=39624

If there are local commits and working copy changes, then prompt the user
whether to continue. Setting git config webkit-patch.commit_should_always_squash
true bypasses the prompt.

--git-commit=HEAD.. operates on working copy changes only.
--git-commit=committish operates on a range of commits as a single commit.

e.g. --git-commit=HEAD only operates on the HEAD commit.
--git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.

--no-squash and --squash are left in with descriptive error messages if used.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/common/net/rietveld.py:
  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/style/optparser.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
  • Scripts/webkitpy/tool/steps/commit.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
3:29 PM Changeset in webkit [63003] by eric@webkit.org
  • 4 edits in trunk

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix SVG tag name casing for HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=41998

  • html5lib/runner-expected-html5.txt:

2010-07-09 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayerQt must have syncCompositingStateForThisLayerOnly() implemented
​https://bugs.webkit.org/show_bug.cgi?id=41954

Add GraphicsLayerQt::syncCompositingStateForThisLayerOnly, a non-recursive
implementation of GraphicsLayerQt::syncCompositingState and which targets
the current layer only.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::syncCompositingStateForThisLayerOnly):
  • platform/graphics/qt/GraphicsLayerQt.h:
3:26 PM Changeset in webkit [63002] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Versioning.

3:21 PM Changeset in webkit [63001] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-07-09 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayerQt must have syncCompositingStateForThisLayerOnly() implemented
​https://bugs.webkit.org/show_bug.cgi?id=41954

Add GraphicsLayerQt::syncCompositingStateForThisLayerOnly, a non-recursive
implementation of GraphicsLayerQt::syncCompositingState and which targets
the current layer only.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::syncCompositingStateForThisLayerOnly):
  • platform/graphics/qt/GraphicsLayerQt.h:
3:07 PM Changeset in webkit [63000] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Handle setting of drawing and event models
​https://bugs.webkit.org/show_bug.cgi?id=41994

Reviewed by Sam Weinig and Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

Handle NPPVpluginDrawingModel and NPPVpluginEventModel.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_inNPPNew.

(WebKit::NetscapePlugin::~NetscapePlugin):
Assert that we aren't still running.

(WebKit::NetscapePlugin::fromNPP):
New function that returns a NetscapePlugin object given a NPP pointer.

(WebKit::NetscapePlugin::initialize):

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.cpp:

(WebKit::NetscapePlugin::setDrawingModel):
Set the drawing model.

(WebKit::NetscapePlugin::setEventModel):
Set the event model.

(WebKit::initializeEvent):
(WebKit::NetscapePlugin::platformPaint):
Only send the Cocoa event when using the Cocoa event model.

2:58 PM Changeset in webkit [62999] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Add two new Windows test build slaves.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
2:52 PM Changeset in webkit [62998] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 David Kozub <​zub@linux.fjfi.cvut.cz>

Reviewed by Darin Adler.

Fix build by adding missing html/TimeRanges.idl to CMakeLists.txt.

​https://bugs.webkit.org/show_bug.cgi?id=41945

No functional changes, thus no tests.

  • CMakeLists.txt:
2:32 PM Changeset in webkit [62997] by ajwong@chromium.org
  • 2 edits in trunk/WebKitTools

Reviewed by David Levin.

rebaseline_chromium_webkit_tests missing --use_drt option on linux
​https://bugs.webkit.org/show_bug.cgi?id=41985

This adds in the --use_drt option for rebaseline_chromium_webkit_tests
so that it works on linux. This is essentially a "compile-fix" for the
script.

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2:32 PM Changeset in webkit [62996] by weinig@apple.com
  • 18 edits in trunk/WebKit2

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=41971
Add really basic BackForwardList support.

Reviewed by Anders Carlsson.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:

(WebPageMessage::):
Add new message kind.

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

(WebPageProxyMessage::):
Add new message kinds. Remove DidChangeCanGoBack and DidChangeCanGoForward.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGoToBackForwardListItem):

  • UIProcess/API/C/WKPage.h:

Add function to initiate a navigation to a BackForward item. The
BackForward list will be updated to use this as the current item
asynchronously.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::addItem): Added.
(WebKit::WebBackForwardList::goToItem): Added.
(WebKit::WebBackForwardList::itemAtIndex): Added.
(WebKit::WebBackForwardList::backListCount): Changed to return int matching WebCore.
(WebKit::WebBackForwardList::forwardListCount): Ditto.
(WebKit::WebBackForwardList::backListWithLimit): Add cast to int.
(WebKit::WebBackForwardList::forwardListWithLimit): Ditto.
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit): Ditto.
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit): Ditto.

  • UIProcess/WebBackForwardList.h:
  • UIProcess/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::WebBackForwardListItem):

  • UIProcess/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::itemID):
Added itemID.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::canGoForward):
(WebKit::WebPageProxy::canGoBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
(WebKit::WebPageProxy::addItemToBackForwardList):
(WebKit::WebPageProxy::goToItemInBackForwardList):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:
  • Removed m_canGoBack and m_canGoForward booleans and instead use the BackForwardList.
  • Forward goToBackForwardItem to the WebProcess.
  • Respond to messages from the WebBackForwardListProxy in the WebProcess, forwarding to the WebBackForwardList.
  • WebProcess/WebCoreSupport/WebBackForwardControllerClient.cpp:

(WebKit::WebBackForwardControllerClient::createBackForwardList):
Start using a WebBackForwardListProxy instead of a BackForwardListImpl.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidAddBackForwardItem):
(WebKit::WebFrameLoaderClient::dispatchDidRemoveBackForwardItem):
(WebKit::WebFrameLoaderClient::dispatchDidChangeBackForwardIndex):
Remove calls backForwardListDidChange() now that we communicate much more
information than just this state.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::idToHistoryItemMap):
(WebKit::historyItemToIDMap):
(WebKit::generateHistoryItemID):
(WebKit::getIDForHistoryItem):
(WebKit::WebBackForwardListProxy::itemForID):
Add leaking cached maps of HistoryItems to IDs, the life time of these
objects will be improved in a subsequent patch.

(WebKit::WebBackForwardListProxy::WebBackForwardListProxy):
(WebKit::WebBackForwardListProxy::addItem):
(WebKit::WebBackForwardListProxy::goBack):
(WebKit::WebBackForwardListProxy::goForward):
(WebKit::WebBackForwardListProxy::goToItem):
(WebKit::WebBackForwardListProxy::backItem):
(WebKit::WebBackForwardListProxy::currentItem):
(WebKit::WebBackForwardListProxy::forwardItem):
(WebKit::WebBackForwardListProxy::itemAtIndex):
(WebKit::WebBackForwardListProxy::backListWithLimit):
(WebKit::WebBackForwardListProxy::forwardListWithLimit):
(WebKit::WebBackForwardListProxy::capacity):
(WebKit::WebBackForwardListProxy::setCapacity):
(WebKit::WebBackForwardListProxy::enabled):
(WebKit::WebBackForwardListProxy::setEnabled):
(WebKit::WebBackForwardListProxy::backListCount):
(WebKit::WebBackForwardListProxy::forwardListCount):
(WebKit::WebBackForwardListProxy::containsItem):
(WebKit::WebBackForwardListProxy::close):
(WebKit::WebBackForwardListProxy::closed):
(WebKit::WebBackForwardListProxy::removeItem):
(WebKit::WebBackForwardListProxy::entries):
(WebKit::WebBackForwardListProxy::pushStateItem):

  • WebProcess/WebPage/WebBackForwardListProxy.h:

Forward functions to the UIProcess.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::goToBackForwardItem):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:

Respond to GoToBackForwardItem message.

  • mac/WebKit2.exp: Add new API function.
2:24 PM Changeset in webkit [62995] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-07-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Remove a couple of excess writes from the lexer
​https://bugs.webkit.org/show_bug.cgi?id=41981

Remove a couple of fields from JSTokenInfo, and rename the remaining ones
to something more accurate

  • parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::tokenStart): (JSC::JSParser::tokenLine): (JSC::JSParser::tokenEnd):
  • parser/JSParser.h: (JSC::JSTokenInfo::JSTokenInfo):
  • parser/Lexer.cpp: (JSC::Lexer::lex):
2:21 PM Changeset in webkit [62994] by eric@webkit.org
  • 5 edits in trunk

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement SVG attribute case mapping for HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=41949

Update results now that we pass 3 more tests.

  • html5lib/runner-expected-html5.txt:

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement SVG attribute case mapping for HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=41949

Tested by html5lib/runner.html.

  • html/HTMLTreeBuilder.cpp:
2:18 PM MathML 3 testsuite results edited by François Sausset
(diff)
2:18 PM Changeset in webkit [62993] by andersca@apple.com
  • 6 edits
    1 add in trunk/WebKit2

Verify drawing coordinates, add crude painting support
​https://bugs.webkit.org/show_bug.cgi?id=41984

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:

Add NetscapePluginMac.cpp.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize drawing and event models.

(WebKit::NetscapePlugin::initialize):
Call platformPostInitialize.

(WebKit::NetscapePlugin::destroy):
Call NPP_Destroy.

(WebKit::NetscapePlugin::paint):
Call platformPaint.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add member functions.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.cpp: Added.

(WebKit::NetscapePlugin::platformPostInitialize):
Set default event and drawing models and verify that they are compatible.

(WebKit::NetscapePlugin::platformPaint):
Send a paint event (assuming the Cocoa event model currently).

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::paint):
Change the paint rect to be in window coordinates.

(WebKit::PluginView::viewGeometryDidChange):
(WebKit::PluginView::clipRectInWindowCoordinates):

  • WebProcess/Plugins/PluginView.h:
2:04 PM Changeset in webkit [62992] by aestes@apple.com
  • 2 edits in trunk/WebCore

2010-07-09 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

Remove the workaround for a Core Animation bug on platforms where the
bug has been fixed.
​https://bugs.webkit.org/show_bug.cgi?id=41927
<rdar://problem/7920153>

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): Add a compile-time check for platforms that have a Core Animation bug that needs working around.
1:50 PM Changeset in webkit [62991] by thakis@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-09 Nico Weber <​thakis@chromium.org>

Unreviewed. Adding myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
1:49 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
1:47 PM MathML 3 testsuite results edited by François Sausset
(diff)
1:40 PM Changeset in webkit [62990] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Revert "<​http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"

This reverts commit r62692.

  • Scripts/commit-log-editor:
1:38 PM Changeset in webkit [62989] by kinuko@chromium.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-07-08 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
​https://bugs.webkit.org/show_bug.cgi?id=38693

Introduced a new base class JSONResultsGeneratorBase that doesn't
have any dependency on layout_tests packages.
Turned JSONResultsGenerator into a wrapper class of the base class
so that the old code can work with it during the cleanup.

Added json_results_generator_unittest.py.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
1:32 PM Changeset in webkit [62988] by xji@chromium.org
  • 4 edits
    9 adds in trunk/LayoutTests

2010-07-09 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Levin.

Rebaseline bidi-mirror-he-ar.html and bidi-neutral-run.html for Chromium after r62965
​https://bugs.webkit.org/show_bug.cgi?id=41974

  • platform/chromium-linux/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/chromium-linux/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-linux/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:29 PM Changeset in webkit [62987] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/AudioDestinationNode.idl

add AudioDestinationNode.idl

1:29 PM Changeset in webkit [62986] by crogers@google.com
  • 1 edit in branches/audio/WebCore/DerivedSources.make

Make sure derived sources get updated to new naming for AudioDestinationNode

1:29 PM Changeset in webkit [62985] by crogers@google.com
  • 9 edits
    10 moves in branches/audio/WebCore

Change name from AudioOutputNode to AudioDestinationNode

  • this avoids overloading the term 'output' which is also used to refer to a specific output of an AudioNode
  • this makes the naming more symmetric:
  • input <--> output (inputs and outputs to AudioNodes)
  • source <--> destination (source nodes and destination node)
1:25 PM MathML 3 testsuite results edited by François Sausset
(diff)
1:16 PM Changeset in webkit [62984] by tonyg@chromium.org
  • 9 edits
    3 adds in trunk

2010-07-08 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Nate Chapin.

Implement unloadEventEnd, loadEventStart, and loadEventEnd for Web Timing
​https://bugs.webkit.org/show_bug.cgi?id=41332

Expectations are set to FAIL because disabled by default. Passes with --web-timing.

  • fast/dom/script-tests/webtiming.js: Added. (sleepFiftyMilliseconds): (shouldBeGreaterThanOrEqual): (checkTimingBeforeLoad): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-expected.txt: Added.
  • fast/dom/webtiming.html: Added.

2010-07-08 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Nate Chapin.

Implement unloadEventEnd, loadEventStart, and loadEventEnd for Web Timing
​https://bugs.webkit.org/show_bug.cgi?id=41332

Test: fast/dom/webtiming.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::loadWithDocumentLoader):
  • loader/FrameLoader.h: (WebCore::FrameLoader::frameLoadTimeline):
  • loader/FrameLoaderTypes.h: (WebCore::FrameLoadTimeline::FrameLoadTimeline):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
  • page/Timing.cpp: (WebCore::Timing::navigationStart): (WebCore::Timing::unloadEventEnd): (WebCore::Timing::loadEventStart): (WebCore::Timing::loadEventEnd):
  • page/Timing.h:
  • page/Timing.idl:
1:15 PM MathML 3 testsuite results edited by François Sausset
(diff)
1:13 PM Changeset in webkit [62983] by inferno@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-09 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Marking myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
1:11 PM CommitterTips edited by thakis@chromium.org
mention sheriffbot for rollouts (diff)
1:05 PM Changeset in webkit [62982] by aa@chromium.org
  • 3 edits in trunk/LayoutTests

2010-07-09 Aaron Boodman <​aa@chromium.org>

Reviewed by Ojan Vafai.

Fix regression from r62876.
​https://bugs.webkit.org/show_bug.cgi?id=41928

  • platform/mac/Skipped:
  • printing/page-rule-selection.html:
12:53 PM Changeset in webkit [62981] by thakis@chromium.org
  • 5 edits in trunk/LayoutTests

2010-07-09 Nico Weber <​thakis@chromium.org>

Reviewed by Simon Fraser.
​https://bugs.webkit.org/show_bug.cgi?id=41580

Fix layout test to be smaller in y direction. Also add explanatory text.

  • fast/gradients/radial-centered.html: Make divs display:inline-block.
12:45 PM MathML 3 testsuite results edited by François Sausset
(diff)
12:45 PM Changeset in webkit [62980] by Darin Adler
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Updated for recent changes.
12:36 PM Changeset in webkit [62979] by xji@chromium.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

2010-07-09 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Levin.

Rebaseline bidi-mirror-he-ar.html for leopard and snowleopard.
​https://bugs.webkit.org/show_bug.cgi?id=41974

  • platform/mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/mac-snowleopard/platform/mac/fast/text: Removed.
  • platform/mac-snowleopard/platform/mac/fast/text/international: Removed.
  • platform/mac-snowleopard/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
12:04 PM Changeset in webkit [62978] by dumi@chromium.org
  • 5 edits in trunk/WebCore

Unreviewed, but pre-approved by Eric Seidel.

Remove all unnecessary includes from the header files in WebCore/accessibility/.
​https://bugs.webkit.org/show_bug.cgi?id=41941

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityListBox.cpp:
  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityMenuList.h:
  • accessibility/mac/AccessibilityObjectWrapper.h:
12:00 PM Changeset in webkit [62977] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed

[chromium] upstreaming expectations from chromium.

  • platform/chromium/test_expectations.txt:
11:54 AM Changeset in webkit [62976] by crogers@google.com
  • 9 edits in branches/audio/WebCore/audio

Make an AudioContext contain an AudioListener, and remove from AudioPanner

  • all panners will now implicitly use the listener from the context
11:52 AM Changeset in webkit [62975] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, build fix.

[chromium] Update test expecations for failing tests.

  • platform/chromium/test_expectations.txt:
11:52 AM MathML 3 testsuite results edited by François Sausset
(diff)
11:51 AM Changeset in webkit [62974] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Buildfix for EventHandlerWin
​https://bugs.webkit.org/show_bug.cgi?id=41909

Use Clipboard.h instead of ClipboardWin.h on WinCE.

  • page/win/EventHandlerWin.cpp:
11:46 AM MathML 3 testsuite results edited by François Sausset
(diff)
11:43 AM Changeset in webkit [62973] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Pass a clip rect to the plugin and call NPP_SetWindow
​https://bugs.webkit.org/show_bug.cgi?id=41969

Reviewed by Sam Weinig.

  • WebProcess/Plugins/DummyPlugin.cpp:

(WebKit::DummyPlugin::geometryDidChange):

  • WebProcess/Plugins/DummyPlugin.h:

Add clip rect parameter.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_npWindow.

(WebKit::NetscapePlugin::callSetWindow):
Call NPP_SetWindow.

(WebKit::NetscapePlugin::initialize):
Set the window type to NPWindowTypeDrawable for now.

(WebKit::NetscapePlugin::geometryDidChange):
Update the frame and clip rects and call NPP_SetWindow.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add an NPWindow member variable.

  • WebProcess/Plugins/Plugin.h:

Add a clipRect parameter to geometryDidChange.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Add the plug-in element to the constructor.

(WebKit::PluginView::viewGeometryDidChange):
Compute the clip rect and pass it to the plug-in.

  • WebProcess/Plugins/PluginView.h:

(WebKit::PluginView::create):
Pass the plug-in element to the constructor.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Pass the plug-in element to PluginView::create.

11:38 AM MathML 3 testsuite results edited by François Sausset
(diff)
11:36 AM Changeset in webkit [62972] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r62946.
​http://trac.webkit.org/changeset/62946
​https://bugs.webkit.org/show_bug.cgi?id=41965

AppCache inspector support should be enabled in WebKit ToT.
(Requested by pfeldman_ on #webkit).

11:31 AM MathML 3 testsuite results edited by François Sausset
(diff)
11:26 AM Changeset in webkit [62971] by crogers@google.com
  • 1 edit in branches/audio/WebCore/WebCore.xcodeproj/project.pbxproj

Remove some more obsolete files from WebCore.xcodeproj

11:26 AM Changeset in webkit [62970] by crogers@google.com
  • 12 deletes in branches/audio/WebCore/audio

Remove obsolete files: AudioEffect, AudioMixer, AudioSource, BiquadFilter, RealtimeAnalyser.idl, SendPoint.h

11:26 AM Changeset in webkit [62969] by crogers@google.com
  • 18 edits in branches/audio/WebCore

Get rid of use of obsolete files: AudioEffect, AudioMixer, AudioSource, BiquadFilter, SendPoint, RealtimeAnalyser.idl

11:22 AM Changeset in webkit [62968] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

2010-07-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Test for the newly implemented MathML mathcolor & mathbackground attributes
​https://bugs.webkit.org/show_bug.cgi?id=41895

  • mathml/presentation/attributes.xhtml: Added.
  • platform/mac/mathml/presentation/attributes-expected.checksum: Added.
  • platform/mac/mathml/presentation/attributes-expected.png: Added.
  • platform/mac/mathml/presentation/attributes-expected.txt: Added.

2010-07-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Implement MathML mathcolor & mathbackground attributes
​https://bugs.webkit.org/show_bug.cgi?id=41895

Test: mathml/presentation/attributes.xhtml

  • dom/MappedAttributeEntry.h: (WebCore::):
  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement): (WebCore::MathMLElement::mapToEntry): (WebCore::MathMLElement::parseMappedAttribute):
  • mathml/MathMLElement.h:
  • mathml/mathattrs.in:
11:19 AM MathML 3 testsuite results created by François Sausset
11:11 AM Changeset in webkit [62967] by mitz@apple.com
  • 270 edits in trunk/LayoutTests

Set the svn:mime-type property of recently-added PNG files to image/png.

10:53 AM Changeset in webkit [62966] by vitalyr@chromium.org
  • 26 edits in trunk/LayoutTests

2010-07-09 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Updating expectations.

  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/chromium-win/svg/batik/text/textLength-expected.txt:
  • platform/chromium-win/svg/carto.net/button-expected.txt:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.txt:
  • platform/chromium-win/svg/carto.net/combobox-expected.txt:
  • platform/chromium-win/svg/carto.net/slider-expected.txt:
  • platform/chromium-win/svg/carto.net/textbox-expected.txt:
  • platform/chromium-win/svg/carto.net/window-expected.txt:
  • platform/chromium-win/svg/custom/animate-path-morphing-expected.txt:
  • platform/chromium-win/svg/custom/coords-relative-units-transforms-expected.txt:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
  • platform/chromium-win/svg/custom/pattern-rotate-expected.txt:
  • platform/chromium-win/svg/custom/text-rotated-gradient-expected.txt:
  • platform/chromium-win/svg/custom/use-detach-expected.txt:
  • platform/chromium-win/svg/custom/use-font-face-crash-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/chromium-win/svg/custom/use-property-changes-through-svg-dom-expected.txt:
  • platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-transform-expected.txt:
  • platform/chromium-win/svg/hixie/text/003b-expected.txt:
  • platform/chromium-win/svg/text/foreignObject-repaint-expected.txt:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
10:28 AM Changeset in webkit [62965] by xji@chromium.org
  • 5 edits
    8 adds in trunk

2010-07-09 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Levin.

Fix characters with unicode-bidi-mirror property are not correctly
mirrored in Linux.
​https://bugs.webkit.org/show_bug.cgi?id=41305

Since harfbuzz does not do mirroring, chromium should iterate each
character in the string and mirror it if needed before passing the
string to harfbuzz for shaping.

Test: fast/text/international/bidi-mirror-he-ar.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::mirrorCharacters):

2010-07-09 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Levin.

Fix characters with unicode-bidi-mirror property are not correctly
mirrored in Linux.
​https://bugs.webkit.org/show_bug.cgi?id=41305

Since harfbuzz does not do mirroring, chromium should iterate each
character in the string and mirror it if needed before passing the
string to harfbuzz for shaping.

  • fast/text/international/bidi-mirror-he-ar.html: Added.
  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac-snowleopard/platform/mac/fast/text: Added.
  • platform/mac-snowleopard/platform/mac/fast/text/international: Added.
  • platform/mac-snowleopard/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/mac-tiger/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
10:14 AM Changeset in webkit [62964] by andersca@apple.com
  • 9 edits in trunk

Instantiate Netscape plug-ins, pass geometry information to Plugin
​https://bugs.webkit.org/show_bug.cgi?id=41960

Reviewed by Simon Fraser.

WebCore:

  • WebCore.exp.in:

Export ScrollView::contentsToWindow.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

Handle NPNVsupportsCoreGraphicsBool and NPNVsupportsCocoaBool.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Set npp.ndata.

(WebKit::NetscapePlugin::initialize):
Try to instantiate the plug-in by calling NPP_New.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Store the NetscapePluginModule and the NPP struct.

  • WebProcess/Plugins/Netscape/NetscapePluginModule.h:

Add a getter for the NPPluginFuncs vtable.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::frameRectsChanged):
Make sure to call viewGeometryDidChange.

(WebKit::PluginView::setParent):
Ditto.

(WebKit::PluginView::viewGeometryDidChange):
Convert the frame rect to window coordinates and pass it to the plug-in.

  • WebProcess/Plugins/PluginView.h:

Add function declarations.

10:12 AM Changeset in webkit [62963] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Buildfix for FrameWince after r47440
​https://bugs.webkit.org/show_bug.cgi?id=41904

  • page/wince/FrameWince.cpp: Added property svn:eol-style. (WebCore::computePageRectsForFrame): (WebCore::imageFromSelection):
10:06 AM Changeset in webkit [62962] by vitalyr@chromium.org
  • 2 edits in trunk/WebCore

2010-07-09 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Pavel Feldman.

[v8] Call JS gc in a fresh context to avoid retaining the current one.
​https://bugs.webkit.org/show_bug.cgi?id=41963
​http://crbug.com/46571

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::collectGarbage):
9:48 AM MathML edited by François Sausset
(diff)
9:43 AM Changeset in webkit [62961] by kbr@google.com
  • 6 edits in trunk

2010-07-09 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Crash with uniform array test
​https://bugs.webkit.org/show_bug.cgi?id=36028

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
    • Fixed type tests and casting of incoming arrays.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform):
    • Fixed crash when null WebGLUniform is passed to getUniform.

2010-07-09 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Crash with uniform array test
​https://bugs.webkit.org/show_bug.cgi?id=36028

  • fast/canvas/webgl/gl-uniform-arrays-expected.txt:
    • Updated test expectations.
  • fast/canvas/webgl/gl-uniform-arrays.html:
    • Separated calling wrong uniform*fv entry point from calling with non-array.
9:24 AM Changeset in webkit [62960] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: text editing not spoken by VO on web view contenteditable textbox
​https://bugs.webkit.org/show_bug.cgi?id=41912

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/selection-value-changes-for-aria-textbox.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::renderObjectIsObservable):

LayoutTests:

  • platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt: Added.
  • platform/mac/accessibility/selection-value-changes-for-aria-textbox.html: Added.
9:14 AM Changeset in webkit [62959] by diegohcg@webkit.org
  • 3 edits in trunk/WebKit2

2010-07-08 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WebKit2] Make QWKPage call _q_webActionTriggered as a private slot
​https://bugs.webkit.org/show_bug.cgi?id=41880

  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/qwkpage.h:
9:05 AM Changeset in webkit [62958] by vitalyr@chromium.org
  • 256 edits
    23 adds
    11 deletes in trunk/LayoutTests

2010-07-09 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Updating expectations.

  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.txt:
  • platform/chromium-linux/svg/batik/text/textOnPath-expected.txt:
  • platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/stroke-width-large-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/001-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/002-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/007-expected.txt:
  • platform/chromium-linux/svg/hixie/text/003a-expected.txt:
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/chromium-linux/svg/text/selection-doubleclick-expected.txt:
  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt: Added.
  • platform/chromium-mac/plugins/clicking-missing-plugin-fires-delegate-expected.txt: Added.
  • platform/chromium-mac/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-evenodd-expected.txt: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/chromium-mac/svg/custom/createelement-expected.txt:
  • platform/chromium-mac/svg/custom/junk-data-expected.txt:
  • platform/chromium-mac/svg/custom/missing-xlink-expected.txt:
  • platform/chromium-mac/svg/custom/repaint-moving-svg-and-div-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/repaint-moving-svg-and-div-expected.png: Added.
  • platform/chromium-mac/userscripts/user-script-top-frame-only-expected.txt: Added.
  • platform/chromium-mac/userscripts/user-style-top-frame-only-expected.txt: Added.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt: Added.
  • platform/chromium-win/plugins/clicking-missing-plugin-fires-delegate-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor2-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor3-expected.txt:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
  • platform/chromium-win/svg/batik/text/textDecoration2-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath2-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath3-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/chromium-win/svg/batik/text/textPCDATA-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
  • platform/chromium-win/svg/batik/text/textStyles-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalText-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium-win/svg/carto.net/scrollbar-expected.txt:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-evenodd-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-text-and-stroke-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-text-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/chromium-win/svg/css/group-with-shadow-expected.txt:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.txt:
  • platform/chromium-win/svg/custom/SVGMatrix-interface-expected.txt:
  • platform/chromium-win/svg/custom/SVGPoint-matrixTransform-expected.txt:
  • platform/chromium-win/svg/custom/alignment-baseline-modes-expected.txt:
  • platform/chromium-win/svg/custom/altglyph-expected.txt:
  • platform/chromium-win/svg/custom/circle-move-invalidation-expected.txt:
  • platform/chromium-win/svg/custom/clip-path-referencing-use-expected.txt:
  • platform/chromium-win/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
  • platform/chromium-win/svg/custom/container-opacity-clip-viewBox-expected.txt:
  • platform/chromium-win/svg/custom/createImageElement2-expected.txt:
  • platform/chromium-win/svg/custom/createelement-expected.txt:
  • platform/chromium-win/svg/custom/dominant-baseline-modes-expected.txt:
  • platform/chromium-win/svg/custom/empty-clip-path-expected.txt:
  • platform/chromium-win/svg/custom/empty-mask-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/chromium-win/svg/custom/fill-fallback-expected.txt:
  • platform/chromium-win/svg/custom/focus-ring-expected.txt:
  • platform/chromium-win/svg/custom/font-face-cascade-order-expected.txt:
  • platform/chromium-win/svg/custom/font-face-simple-expected.txt:
  • platform/chromium-win/svg/custom/foreignObject-crash-on-hover-expected.txt:
  • platform/chromium-win/svg/custom/getTransformToElement-expected.txt:
  • platform/chromium-win/svg/custom/gradient-cycle-detection-expected.txt:
  • platform/chromium-win/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/chromium-win/svg/custom/hit-test-unclosed-subpaths-expected.txt:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.txt:
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/chromium-win/svg/custom/invalid-css-expected.txt:
  • platform/chromium-win/svg/custom/invalid-fill-expected.txt:
  • platform/chromium-win/svg/custom/invalid-fill-hex-expected.txt:
  • platform/chromium-win/svg/custom/invalid-lengthlist-expected.txt:
  • platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-clipPath-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.txt:
  • platform/chromium-win/svg/custom/junk-data-expected.txt:
  • platform/chromium-win/svg/custom/marker-default-width-height-expected.txt:
  • platform/chromium-win/svg/custom/marker-overflow-clip-expected.txt:
  • platform/chromium-win/svg/custom/mask-invalidation-expected.txt:
  • platform/chromium-win/svg/custom/missing-xlink-expected.txt:
  • platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
  • platform/chromium-win/svg/custom/path-bad-data-expected.txt:
  • platform/chromium-win/svg/custom/path-textPath-simulation-expected.txt:
  • platform/chromium-win/svg/custom/pattern-cycle-detection-expected.txt:
  • platform/chromium-win/svg/custom/pattern-deep-referencing-expected.txt:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.txt:
  • platform/chromium-win/svg/custom/pointer-events-image-expected.txt:
  • platform/chromium-win/svg/custom/pointer-events-path-expected.txt:
  • platform/chromium-win/svg/custom/pointer-events-text-expected.txt:
  • platform/chromium-win/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/chromium-win/svg/custom/repaint-moving-svg-and-div-expected.checksum: Added.
  • platform/chromium-win/svg/custom/repaint-moving-svg-and-div-expected.png: Added.
  • platform/chromium-win/svg/custom/second-inline-text-expected.txt:
  • platform/chromium-win/svg/custom/shape-rendering-expected.txt:
  • platform/chromium-win/svg/custom/shapes-supporting-markers-expected.txt:
  • platform/chromium-win/svg/custom/stroke-fallback-expected.txt:
  • platform/chromium-win/svg/custom/stroke-width-large-expected.txt:
  • platform/chromium-win/svg/custom/stroked-pattern-expected.txt:
  • platform/chromium-win/svg/custom/style-attribute-font-size-expected.txt:
  • platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/chromium-win/svg/custom/svg-float-border-padding-expected.txt:
  • platform/chromium-win/svg/custom/text-clip-expected.txt:
  • platform/chromium-win/svg/custom/text-ctm-expected.txt:
  • platform/chromium-win/svg/custom/text-decoration-visibility-expected.txt:
  • platform/chromium-win/svg/custom/text-filter-expected.txt:
  • platform/chromium-win/svg/custom/text-hit-test-expected.txt:
  • platform/chromium-win/svg/custom/text-image-opacity-expected.txt:
  • platform/chromium-win/svg/custom/text-letter-spacing-expected.txt:
  • platform/chromium-win/svg/custom/text-linking-expected.txt:
  • platform/chromium-win/svg/custom/text-repaint-including-stroke-expected.txt:
  • platform/chromium-win/svg/custom/text-whitespace-handling-expected.txt:
  • platform/chromium-win/svg/custom/text-x-dx-lists-expected.txt:
  • platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.txt:
  • platform/chromium-win/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/chromium-win/svg/custom/text-xy-updates-expected.txt:
  • platform/chromium-win/svg/custom/tref-update-expected.txt:
  • platform/chromium-win/svg/custom/use-clipped-hit-expected.txt:
  • platform/chromium-win/svg/custom/use-dynamic-append-expected.txt:
  • platform/chromium-win/svg/custom/use-elementInstance-event-target-expected.txt:
  • platform/chromium-win/svg/custom/use-elementInstance-methods-expected.txt:
  • platform/chromium-win/svg/custom/use-event-handler-on-referenced-element-expected.txt:
  • platform/chromium-win/svg/custom/use-event-handler-on-use-element-expected.txt:
  • platform/chromium-win/svg/custom/use-events-crash-expected.txt:
  • platform/chromium-win/svg/custom/use-instanceRoot-modifications-expected.txt:
  • platform/chromium-win/svg/custom/use-modify-container-in-target-expected.txt:
  • platform/chromium-win/svg/custom/use-modify-target-container-expected.txt:
  • platform/chromium-win/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/chromium-win/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-on-g-containing-use-expected.txt:
  • platform/chromium-win/svg/custom/use-on-g-expected.txt:
  • platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/chromium-win/svg/custom/use-on-rect-expected.txt:
  • platform/chromium-win/svg/custom/use-on-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-win/svg/custom/use-on-text-expected.txt:
  • platform/chromium-win/svg/custom/use-on-use-expected.txt:
  • platform/chromium-win/svg/custom/use-property-changes-through-dom-expected.txt:
  • platform/chromium-win/svg/custom/use-recursion-1-expected.txt:
  • platform/chromium-win/svg/custom/use-recursion-2-expected.txt:
  • platform/chromium-win/svg/custom/use-recursion-3-expected.txt:
  • platform/chromium-win/svg/custom/use-recursion-4-expected.txt:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/chromium-win/svg/custom/viewbox-syntax-expected.txt:
  • platform/chromium-win/svg/custom/viewport-em-expected.txt:
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
  • platform/chromium-win/svg/filters/feComposite-expected.txt:
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
  • platform/chromium-win/svg/filters/filter-width-update-expected.txt:
  • platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
  • platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/chromium-win/svg/hixie/data-types/002-expected.txt:
  • platform/chromium-win/svg/hixie/dynamic/002-expected.txt:
  • platform/chromium-win/svg/hixie/error/002-expected.txt:
  • platform/chromium-win/svg/hixie/error/010-expected.txt:
  • platform/chromium-win/svg/hixie/error/011-expected.txt:
  • platform/chromium-win/svg/hixie/error/012-expected.txt:
  • platform/chromium-win/svg/hixie/error/013-expected.txt:
  • platform/chromium-win/svg/hixie/error/017-expected.txt:
  • platform/chromium-win/svg/hixie/links/002-expected.txt:
  • platform/chromium-win/svg/hixie/links/003-broken-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/003-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/004-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/005-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/011-expected.txt:
  • platform/chromium-win/svg/hixie/perf/001-expected.txt:
  • platform/chromium-win/svg/hixie/perf/002-expected.txt:
  • platform/chromium-win/svg/hixie/perf/007-expected.txt:
  • platform/chromium-win/svg/hixie/shapes/path/001-expected.txt:
  • platform/chromium-win/svg/hixie/text/002-expected.txt:
  • platform/chromium-win/svg/hixie/text/003a-expected.txt:
  • platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
  • platform/chromium-win/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/chromium-win/svg/text/kerning-expected.txt:
  • platform/chromium-win/svg/text/multichar-glyph-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-1-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-2-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-3-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-4-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/chromium-win/svg/text/selection-background-color-expected.txt:
  • platform/chromium-win/svg/text/selection-doubleclick-expected.txt:
  • platform/chromium-win/svg/text/selection-styles-expected.txt:
  • platform/chromium-win/svg/text/selection-tripleclick-expected.txt:
  • platform/chromium-win/svg/text/text-gradient-positioning-expected.txt:
  • platform/chromium-win/svg/text/text-repaint-rects-expected.txt:
  • platform/chromium-win/svg/text/textPathBoundsBug-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
  • platform/chromium-win/transforms/svg-vs-css-expected.txt:
  • platform/chromium-win/userscripts/user-script-top-frame-only-expected.txt: Added.
  • platform/chromium-win/userscripts/user-style-top-frame-only-expected.txt: Added.
8:55 AM Changeset in webkit [62957] by commit-queue@webkit.org
  • 11 edits
    3 adds in trunk

2010-07-09 Michael Nordman <Michael Nordman>

Reviewed by Dumitru Daniliuc.

Add a layout test to verify the expected number of progress events are raised by the appcache,
and that those events have properly set 'lengthComputable', 'loaded', and 'total' attributes.
Also update a couple of other tests that depend on counting the number of progress events to
determine success or failure to now expect the additional final progress event that is being
raised.
​https://bugs.webkit.org/show_bug.cgi?id=37602

  • http/tests/appcache/foreign-iframe-main-expected.txt:
  • http/tests/appcache/progress-counter-expected.txt: Added.
  • http/tests/appcache/progress-counter.html: Added.
  • http/tests/appcache/resources/different-https-origin-resource.html:
  • http/tests/appcache/resources/progress-counter.manifest: Added.

2010-07-09 Michael Nordman <Michael Nordman>

Reviewed by Dumitru Daniliuc.

Use class ProgressEvent when raising appcache related progress events and
set the 'total', 'loaded', and 'lengthComputable' attributes.
Also raise the final progress event with the 'total' and 'loaded' attribute
values are equal to one another to keep pace with the spec for this feature.
​https://bugs.webkit.org/show_bug.cgi?id=37602

Test: http/tests/appcache/progress-counter.html

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::CallCacheListenerTask::create): (WebCore::CallCacheListenerTask::performTask): (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask):
  • loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::postListenerTask):
  • loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): (WebCore::ApplicationCacheHost::stopDeferringEvents): (WebCore::ApplicationCacheHost::dispatchDOMEvent):
  • loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::DeferredEvent::DeferredEvent):

2010-07-09 Michael Nordman <Michael Nordman>

Reviewed by Dumitru Daniliuc.

Use class ProgressEvent when raising appcache related progress events and
set the 'total', 'loaded', and 'lengthComputable' attributes.
Also raise the final progress event with the 'total' and 'loaded' attribute
values are equal to one another to keep pace with the spec for this feature.
​https://bugs.webkit.org/show_bug.cgi?id=37602

  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): (WebCore::ApplicationCacheHost::stopDeferringEvents): (WebCore::ApplicationCacheHost::dispatchDOMEvent):
  • src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::notifyEventListener): (WebCore::ApplicationCacheHostInternal::notifyProgressEventListener):
8:39 AM Changeset in webkit [62956] by commit-queue@webkit.org
  • 1 edit
    5 adds in trunk/WebKitTools

2010-07-09 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

Implement MiniBrowser for Qt.
​https://bugs.webkit.org/show_bug.cgi?id=40233

  • MiniBrowser/qt/BrowserWindow.cpp: Added. (createNewPage): (BrowserView::BrowserView): (BrowserView::resizeEvent): (BrowserView::load): (BrowserView::view): (BrowserWindow::BrowserWindow): (BrowserWindow::load): (BrowserWindow::changeLocation): (BrowserWindow::~BrowserWindow):
  • MiniBrowser/qt/BrowserWindow.h: Added. (BrowserView::~BrowserView):
  • MiniBrowser/qt/MiniBrowser.pro: Added.
  • MiniBrowser/qt/main.cpp: Added. (main):
8:26 AM Changeset in webkit [62955] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Sebastian Dröge <​sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha Silva.

Bug 41340 - [GStreamer] Subtle race condition during seeks
​https://bugs.webkit.org/show_bug.cgi?id=41340

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcStop): (webKitWebSrcNeedDataMainCb): (webKitWebSrcNeedDataCb): (webKitWebSrcEnoughDataMainCb): (webKitWebSrcEnoughDataCb): (webKitWebSrcSeekDataCb): (StreamingClient::didFinishLoading): Fix two subtle race conditions that can happen during seeks:
  • The timeout callback could be called before the callback ID is assigned to the instance private data. This causes the ID to be set after the callback has finished and breaks all future processing.
  • The source must not go EOS while a seek is pending because this confuses appsrc due to the different threads involved here.
8:06 AM Changeset in webkit [62954] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Removed hard-coded enabled default of video support

Reviewed by Tor Arne Vestbø.

Properly detect video/audio instead of defaulting to true.Properly detect video/audio instead of defaulting to true.Properly detect video/audio instead of defaulting to true.Properly detect video/audio instead of defaulting to true.

  • WebCore.pri:
7:59 AM Changeset in webkit [62953] by Simon Hausmann
  • 3 edits in trunk/WebCore

[Qt] Prospective build fix.

Reviewed by Tor Arne Vestbø.

Moved the media element detection from WebCore.pro into WebCore.pri, where
all the features are detected. This is also used by build-webkit to determine
the defaults, which may be the reason for the build breakage.

  • WebCore.pri:
  • WebCore.pro:
7:53 AM Changeset in webkit [62952] by benm@google.com
  • 3 edits
    2 adds in trunk

[Arm] Missing NaN check in XPath substring function
​https://bugs.webkit.org/show_bug.cgi?id=41862

Reviewed by Steve Block.

WebCore:

Test: fast/xpath/substring-nan-position.html

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunSubstring::evaluate): Add an isnan()

to the value returned from evaluating the position
argument and early out and return the empty string.

LayoutTests:

This layout test checks for the case described in the bug
and some related edge cases that do currently already pass
but only through a fluke.

  • fast/xpath/substring-nan-position-expected.txt: Added.
  • fast/xpath/substring-nan-position.html: Added.
7:47 AM Changeset in webkit [62951] by Simon Hausmann
  • 4 edits in trunk/WebCore

[Qt] Re-enable support for QtMultimediaKit as backend for the media elements

Reviewed by Tor Arne Vestbø.

Experimental support is re-enabled if QtMobility is available and the Qt
version is 4.7 or above.

  • WebCore.pro:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivate::supportsType): Adapt to latest QtMultimediaKit API changes.
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::totalBytes):

7:28 AM Changeset in webkit [62950] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-07-09 David Holloway <​dhollowa@chromium.org>

Reviewed by Dimitri Glazkov.

Roll Chromium DEPS forward to r51736.
​https://bugs.webkit.org/show_bug.cgi?id=41867

  • DEPS:
7:17 AM Changeset in webkit [62949] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-07-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not show default tooltip when detailed network info is available.

​https://bugs.webkit.org/show_bug.cgi?id=41957

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._getPopoverAnchor): (WebInspector.ResourcesPanel.prototype._showPopover): (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels):
7:11 AM Changeset in webkit [62948] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

2010-07-09 François Sausset <François Sausset>

Reviewed by Beth Dakin.

Add test to be sure that only <mi> elements use italic fonts by default.
Update test with fractions to take into account the correct behaviour of mtext (regular instead of italic).
​https://bugs.webkit.org/show_bug.cgi?id=41626

  • mathml/presentation/tokenElements.xhtml: Added.
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/tokenElements-expected.checksum: Added.
  • platform/mac/mathml/presentation/tokenElements-expected.png: Added.
  • platform/mac/mathml/presentation/tokenElements-expected.txt: Added.

2010-07-09 François Sausset <François Sausset>

Reviewed by Beth Dakin.

Correct the default font variant of mtext (regular instead of italic).
​https://bugs.webkit.org/show_bug.cgi?id=41626

Add test to be sure that only <mi> elements use italic fonts by default.
Update test with fractions to take into account the correct behaviour of mtext (regular instead of italic).

  • css/mathml.css: (mi):
6:58 AM Changeset in webkit [62947] by tonyg@chromium.org
  • 5 edits
    7 adds in trunk

2010-07-09 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Implement performance.navigation.type
​https://bugs.webkit.org/show_bug.cgi?id=41564

Expectations set to FAIL because disabled by default. Tests pass with --web-timing.

  • fast/dom/navigation-type-back-forward-expected.txt: Added.
  • fast/dom/navigation-type-back-forward.html: Added.
  • fast/dom/navigation-type-navigate-expected.txt: Added.
  • fast/dom/navigation-type-navigate.html: Added.
  • fast/dom/navigation-type-reload-expected.txt: Added.
  • fast/dom/navigation-type-reload.html: Added.
  • fast/dom/resources/navigation-type-matches-querystring.html: Added.

2010-07-09 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Implement performance.navigation.type
​https://bugs.webkit.org/show_bug.cgi?id=41564

Tests: fast/dom/navigation-type-back-forward.html

fast/dom/navigation-type-navigate.html
fast/dom/navigation-type-reload.html

  • page/Navigation.cpp: (WebCore::Navigation::type):
  • page/Navigation.h: (WebCore::Navigation::):
  • page/Navigation.idl:
6:45 AM Changeset in webkit [62946] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: hide AppCache until implemented.

​https://bugs.webkit.org/show_bug.cgi?id=41858

6:29 AM Changeset in webkit [62945] by commit-queue@webkit.org
  • 7 edits in trunk

2010-07-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Set the good default behaviour for the columalign attribute on MathML mtable element
​https://bugs.webkit.org/show_bug.cgi?id=41631

Test updated.

  • mathml/presentation/tables.xhtml:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:

2010-07-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Set the good default behaviour for the columalign attribute on MathML mtable element
​https://bugs.webkit.org/show_bug.cgi?id=41631

Test update: mathml/tables.xhtml

  • css/mathml.css: (math):
5:42 AM Changeset in webkit [62944] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

2010-07-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r62937.
​http://trac.webkit.org/changeset/62937
​https://bugs.webkit.org/show_bug.cgi?id=41955

Crashes SnowLeopard leaks and Windows debug bot in fast/xsl
/xslt-relative-path.xml, with assertion in
XSLTProcessorLibxslt.cpp:264 (Requested by WildFox on
#webkit).

  • xml/XSLTProcessor.h: (WebCore::XSLTProcessor::XSLTProcessor):
  • xml/XSLTProcessorLibxslt.cpp: (WebCore::docLoaderFunc): (WebCore::setXSLTLoadCallBack): (WebCore::xsltStylesheetPointer): (WebCore::XSLTProcessor::transformToString):
5:08 AM Changeset in webkit [62943] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Add mac-tiger specific results. That should mark the end of the journey.

  • platform/mac-tiger/svg/hixie/text/003-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003a-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
5:05 AM Changeset in webkit [62942] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-09 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium build fix.

  • public/WebGLES2Context.h:
5:02 AM Changeset in webkit [62941] by antti.j.koivisto@nokia.com
  • 2 edits in trunk/WebKit2

Build fix.

  • cmake/OptionsEfl.cmake:
4:51 AM Changeset in webkit [62940] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/WebKitTools

Introduce the Qt autotest launcher.

Patch by Jedrzej Nowacki <​jedrzej.nowacki@nokia.com> on 2010-07-09
Reviewed by Simon Hausmann.

Qt autotests should be executed more frequently, ideally by the Qt
build bot. This is the first step to provide the tests more accessible.

[Qt] It should be easier to run all Qt's autotests.
​https://bugs.webkit.org/show_bug.cgi?id=31625

  • Scripts/run-qtwebkit-tests: Added.
4:47 AM Changeset in webkit [62939] by yael.aharon@nokia.com
  • 11 edits in trunk

2010-07-09 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

NotificationPresenter needs a cancelRequestPermission API
​https://bugs.webkit.org/show_bug.cgi?id=41783

Updated NotificationPresenter API, to use ScriptExecutionContext instead of origin.
Added new API NotificationPresenter::cancelRequestsForPermision
The new API will be implemented and a test will be added in a followup patch.

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission): (WebCore::NotificationCenter::requestPermission): (WebCore::NotificationCenter::disconnectFrame):
  • notifications/NotificationCenter.h:
  • notifications/NotificationPresenter.h:

2010-07-09 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

NotificationPresenter needs a cancelRequestPermission API
​https://bugs.webkit.org/show_bug.cgi?id=41783

Updated the NotificationPresenter API.

  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission): (WebKit::NotificationPresenterImpl::requestPermission):
  • src/NotificationPresenterImpl.h: (WebKit::NotificationPresenterImpl::cancelRequestsForPermission):

2010-07-09 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

NotificationPresenter needs a cancelRequestPermission API
​https://bugs.webkit.org/show_bug.cgi?id=41783

Updated NotificationPresenter API to use ScriptExecutionContext instead of origin
and added a new NotificationPresenter::cancelRequestsForPermission API.
The new API will be implemented in a followup patch.

  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::requestPermission): (WebCore::NotificationPresenterClientQt::checkPermission): (WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
  • WebCoreSupport/NotificationPresenterClientQt.h:
4:34 AM Changeset in webkit [62938] by Nikolas Zimmermann
  • 21 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Hopefully last round of gtk specific results.

  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/gtk/svg/text/selection-background-color-expected.txt:
  • platform/gtk/svg/text/selection-doubleclick-expected.txt:
  • platform/gtk/svg/text/selection-styles-expected.txt:
  • platform/gtk/svg/text/selection-tripleclick-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/svg/zoom/text/relative-sized-document-scrollbars-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/transforms/svg-vs-css-expected.txt:
4:33 AM Changeset in webkit [62937] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-07-09 Andreas Wictor <​andreas.wictor@xcerion.com>

Reviewed by Alexey Proskuryakov.

Remove global variables from XSLTProcessorLibxslt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=41348

Remove the globalProcessor and globalDocLoader global variables
by using the _private field that exists on most libxml structs.

No new tests, existing tests covers this.

  • xml/XSLTProcessor.h: (WebCore::XSLTProcessor::sourceNode): (WebCore::XSLTProcessor::XSLTProcessor):
  • xml/XSLTProcessorLibxslt.cpp: (WebCore::registeredXSLTProcessors): (WebCore::registeredXSLStyleSheets): (WebCore::docLoaderFunc): (WebCore::clearSavedStyleSheetPointers): (WebCore::xsltStylesheetPointer): (WebCore::XSLTProcessor::transformToString):
4:20 AM Changeset in webkit [62936] by Nikolas Zimmermann
  • 11 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Next round of gtk specific results.

  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-4-expected.txt:
4:19 AM Changeset in webkit [62935] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Adam Barth <​abarth@webkit.org>

Unreviewed build fix.

We recently taught the HTMLTokenizer to recognize self-closing tags,
<​http://trac.webkit.org/changeset/62926>, but that confused the
LegacyHTMLTreeBuilder. It turns out that it's much happier if we never
say a tag is self-closing.

  • html/HTMLTreeBuilder.cpp: (WebCore::convertToOldStyle):
4:08 AM Changeset in webkit [62934] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Last round of qt specific results.

  • platform/qt/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/qt/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/qt/fast/repaint/svg-layout-root-style-attr-update-expected.txt:
3:57 AM Changeset in webkit [62933] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Next round of win specific results.

  • platform/win/svg/custom/broken-internal-references-expected.txt:
  • platform/win/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/win/svg/filters/feColorMatrix-values-expected.txt:
3:54 AM Changeset in webkit [62932] by Csaba Osztrogonác
  • 84 edits in trunk/LayoutTests

[Qt] Update platform specific expected results after r62922.

Reviewed by Nikolas Zimmermann.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

  • platform/qt/svg/custom/js-update-image-and-display-expected.txt:
  • platform/qt/svg/custom/js-update-image-and-display2-expected.txt:
  • platform/qt/svg/custom/js-update-image-and-display3-expected.txt:
  • platform/qt/svg/custom/marker-opacity-expected.txt:
  • platform/qt/svg/custom/marker-referencePoint-expected.txt:
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
  • platform/qt/svg/custom/mask-invalidation-expected.txt:
  • platform/qt/svg/custom/mask-on-multiple-objects-expected.txt:
  • platform/qt/svg/custom/mask-with-default-value-expected.txt:
  • platform/qt/svg/custom/non-scaling-stroke-expected.txt:
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/qt/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
  • platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/qt/svg/custom/repaint-stroke-width-changes-expected.txt:
  • platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/qt/svg/custom/stroke-width-large-expected.txt:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/qt/svg/custom/text-zoom-expected.txt:
  • platform/qt/svg/custom/transformedMaskFails-expected.txt:
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feLighting-crash-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/filter-clip-expected.txt:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/filters/filter-source-position-expected.txt:
  • platform/qt/svg/filters/filteredImage-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
  • platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt:
  • platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt:
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt:
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.txt:
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/qt/svg/text/select-x-list-1-expected.txt:
  • platform/qt/svg/text/select-x-list-2-expected.txt:
  • platform/qt/svg/text/select-x-list-3-expected.txt:
  • platform/qt/svg/text/select-x-list-4-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/qt/svg/text/selection-background-color-expected.txt:
  • platform/qt/svg/text/selection-doubleclick-expected.txt:
  • platform/qt/svg/text/selection-styles-expected.txt:
  • platform/qt/svg/text/selection-tripleclick-expected.txt:
  • platform/qt/svg/text/text-hkern-expected.txt:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/qt/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.txt:
  • platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
3:51 AM Changeset in webkit [62931] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

svg/custom/use-instanceRoot-event-bubbling.xhtml test crashes
​https://bugs.webkit.org/show_bug.cgi?id=41931

Be careful to not mutate (marking it for recreation) the shadow tree, while building it.
The recent change that cloneNode() properly synchronizes the style/SVG attributes caused this problem.

Fixes crash seen on the buildbots in svg/custom/use-instanceRoot-event-bubbling.xhtml.

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::recalcStyle): (WebCore::SVGUseElement::buildShadowAndInstanceTree): (WebCore::SVGUseElement::invalidateShadowTree):
  • svg/SVGUseElement.h: (WebCore::SVGUseElement::setUpdatesBlocked):
3:47 AM Changeset in webkit [62930] by Nikolas Zimmermann
  • 13 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Next round of gtk specific results.

  • platform/gtk/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/gtk/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
3:40 AM Changeset in webkit [62929] by Nikolas Zimmermann
  • 9 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Next round of gtk specific results.

  • platform/gtk/svg/custom/text-zoom-expected.txt:
  • platform/gtk/svg/filters/feDisplacementMap-expected.txt:
  • platform/gtk/svg/filters/feLighting-crash-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt:
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
3:24 AM Changeset in webkit [62928] by abarth@webkit.org
  • 4 edits in trunk

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Skip leading newlines in <textarea>
​https://bugs.webkit.org/show_bug.cgi?id=41947

We would have caught this earlier with the ASSERT.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Skip leading newlines in <textarea>
​https://bugs.webkit.org/show_bug.cgi?id=41947

  • html5lib/runner-expected-html5.txt:
3:18 AM Changeset in webkit [62927] by pfeldman@chromium.org
  • 22 edits
    2 adds in trunk

2010-07-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Provide detailed network info in the resources panel.

​https://bugs.webkit.org/show_bug.cgi?id=40227

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::updateResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::buildObjectForTiming):
  • inspector/InspectorResource.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):

2010-07-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Provide detailed network info in the resources panel.

​https://bugs.webkit.org/show_bug.cgi?id=40227

  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebURLLoadTiming.h: Added. (WebKit::WebURLLoadTiming::~WebURLLoadTiming): (WebKit::WebURLLoadTiming::WebURLLoadTiming): (WebKit::WebURLLoadTiming::operator=): (WebKit::WebURLLoadTiming::isNull):
  • public/WebURLRequest.h:
  • public/WebURLResponse.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::willSendRequest):
  • src/WebDevToolsAgentImpl.h:
  • src/WebURLLoadTiming.cpp: Added. (WebKit::WebURLLoadTiming::initialize): (WebKit::WebURLLoadTiming::reset): (WebKit::WebURLLoadTiming::assign): (WebKit::WebURLLoadTiming::setDomainLookupTimes): (WebKit::WebURLLoadTiming::setConnectStartTime): (WebKit::WebURLLoadTiming::setRequestTimes): (WebKit::WebURLLoadTiming::setHeadersAvailableTime): (WebKit::WebURLLoadTiming::WebURLLoadTiming): (WebKit::WebURLLoadTiming::operator=): (WebKit::WebURLLoadTiming::operator PassRefPtr<ResourceLoadTiming>):
  • src/WebURLRequest.cpp: (WebKit::WebURLRequest::reportLoadTiming): (WebKit::WebURLRequest::setReportLoadTiming):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::setConnectionID): (WebKit::WebURLResponse::setLoadTiming):
3:10 AM Changeset in webkit [62926] by eric@webkit.org
  • 11 edits in trunk

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement self closing start tag state in the tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=41946

  • html5lib/runner-expected-html5.txt:
    • Yay progressions!

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement self closing start tag state in the tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=41946

Amazingly we got this far w/o needing self closing.
The LegacyHTMLTreeBuilder clearly uses the self-closing
state, but the fact that we never exposed it seems to
not have caused any test failures. Sad.

The new HTMLTreeBuilder only needs the self closing state
for foreign content mode (and a few parse error cases).

  • html/HTMLToken.h: (WebCore::HTMLToken::setSelfClosing):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
  • html/HTMLTreeBuilder.cpp: (WebCore::):
3:02 AM Changeset in webkit [62925] by Nikolas Zimmermann
  • 39 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Update gtk/qt specific results, and 4 mac results I missed.

  • fast/repaint/svg-layout-root-style-attr-update-expected.txt:
  • platform/gtk/svg/css/shadow-and-opacity-expected.txt:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/custom/clip-path-id-changes-expected.txt:
  • platform/gtk/svg/custom/empty-mask-expected.txt:
  • platform/gtk/svg/custom/fill-opacity-hsl-expected.txt:
  • platform/gtk/svg/custom/fill-opacity-rgba-expected.txt:
  • platform/gtk/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt:
  • platform/gtk/svg/custom/marker-opacity-expected.txt:
  • platform/gtk/svg/custom/marker-referencePoint-expected.txt:
  • platform/gtk/svg/custom/mask-invalidation-expected.txt:
  • platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt:
  • platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/repaint-stroke-width-changes-expected.txt:
  • platform/gtk/svg/custom/stroke-width-large-expected.txt:
  • platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/mac/transforms/svg-vs-css-expected.txt:
  • platform/qt/svg/batik/text/textDecoration-expected.txt:
  • platform/qt/svg/css/arrow-with-shadow-expected.txt:
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/qt/svg/css/clippath-with-shadow-expected.txt:
  • platform/qt/svg/css/mask-with-shadow-expected.txt:
  • platform/qt/svg/css/path-with-shadow-expected.txt:
  • platform/qt/svg/css/shadow-and-opacity-expected.txt:
  • platform/qt/svg/css/shadow-with-large-radius-expected.txt:
  • platform/qt/svg/css/shadow-with-negative-offset-expected.txt:
  • platform/qt/svg/css/stars-with-shadow-expected.txt:
  • platform/qt/svg/custom/animation-currentColor-expected.txt:
  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/custom/clip-path-id-changes-expected.txt:
  • platform/qt/svg/custom/createImageElement-expected.txt:
  • platform/qt/svg/custom/createImageElement2-expected.txt:
  • platform/qt/svg/custom/empty-mask-expected.txt:
  • platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt:
2:57 AM Changeset in webkit [62924] by abarth@webkit.org
  • 5 edits in trunk

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Coalesce text nodes when foster parenting
​https://bugs.webkit.org/show_bug.cgi?id=41921

Yay test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Coalesce text nodes when foster parenting
​https://bugs.webkit.org/show_bug.cgi?id=41921

Introduces the notion of an AttachmentSite to the overall
HTMLConstructionSite. Maybe we should rename HTMLConstructionSite to
HTMLConstructionArea since we construct things all over the tree? :)

There's something wrong in the internal layering in this class, but I
can't quite see what it is. I added a FIXME for the some of the
symptoms.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): (WebCore::HTMLConstructionSite::attachAtSite): (WebCore::HTMLConstructionSite::insertTextNode): (WebCore::HTMLConstructionSite::findFosterSite): (WebCore::HTMLConstructionSite::fosterParent):
  • html/HTMLConstructionSite.h:
2:40 AM Changeset in webkit [62923] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue should merge to TOT when checkout needs update
​https://bugs.webkit.org/show_bug.cgi?id=41944

There are a bunch of different designs that are possible here. This
one merges to top of tree by cleaning out the working copy and
re-applying the patch. Once you decide to merge that way, you need to
decide who's going to retry. In this patch, we retry in the child
process instead of plumbing the failure reason to the master process.

This patch is difficult to test end-to-end, but hopefully it will work.
:)

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py:
  • Scripts/webkitpy/tool/multicommandtool.py:
  • Scripts/webkitpy/tool/multicommandtool_unittest.py:
2:30 AM Changeset in webkit [62922] by Nikolas Zimmermann
  • 477 edits
    4 adds in trunk

2010-07-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

RenderSVGRoot does not include border/padding in the repaint rect.
clippedOverflowRectForRepaint() was missing. Affects all DRT results,
as <svg> now gets properly sized.

Test: svg/custom/repaint-moving-svg-and-div.xhtml

  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates): (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
  • rendering/RenderSVGRoot.h:

2010-07-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Update most textual results as <svg> now receives a proper size and location.
NOTE: This requires updating more platform specific results, after landing with the help of the buildbots.

  • platform/mac-leopard/svg/custom/junk-data-expected.txt: .... (stripped long list)
2:19 AM Changeset in webkit [62921] by Simon Hausmann
  • 6 edits in trunk/JavaScriptCore/qt

Implementation of the QScriptValue::propertyFlags function.

Patch by Jedrzej Nowacki <​jedrzej.nowacki@nokia.com> on 2010-07-09
Reviewed by Simon Hausmann.

The function returns the flags of a property with the given name,
using a given mode to resolve the property. This is a simple
implementation that is sufficient to test the QScriptValueIterator.

[Qt] QScriptValue API should have a property flag accessor.
​https://bugs.webkit.org/show_bug.cgi?id=41769

  • api/qscriptvalue.cpp:

(QScriptValue::propertyFlags):

  • api/qscriptvalue.h:
  • api/qscriptvalue_p.h:

(QScriptValuePrivate::propertyFlags):

  • tests/qscriptvalue/tst_qscriptvalue.cpp:

(tst_QScriptValue::propertyFlag_data):
(tst_QScriptValue::propertyFlag):

  • tests/qscriptvalue/tst_qscriptvalue.h:
2:18 AM Changeset in webkit [62920] by ajwong@chromium.org
  • 3 edits in trunk/WebCore

Add RuntimeEnabledFeatures::timeRangesEnabled() required by r62880

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=41935

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::timeRangesEnabled):

Add in timeRangesEnabled() implementation.

  • bindings/generic/RuntimeEnabledFeatures.h:

Add in timeRangesEnabled() declaration.

2:01 AM Changeset in webkit [62919] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add setInsertionMode setter in preparation for "in foreign content" mode
​https://bugs.webkit.org/show_bug.cgi?id=41942

"in foreign content" mode needs to be able to use a fake
insertion mode for processing. We need to be able to save the
original insertion mode, set a fake one, and then restore the original
if it wasn't changed. To detect changes, we need all callsites to
use a setInsertionMode accessor instead of m_insertionMode =

No functional changes, thus no tests.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup): (WebCore::HTMLTreeBuilder::processStartTagForInTable): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): (WebCore::HTMLTreeBuilder::setInsertionModeAndEnd): (WebCore::HTMLTreeBuilder::processEndTagForInTableBody): (WebCore::HTMLTreeBuilder::processEndTagForInCell): (WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption): (WebCore::HTMLTreeBuilder::processTrEndTagForInRow): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processDefaultForInTableTextMode): (WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag): (WebCore::HTMLTreeBuilder::processGenericRawTextStartTag): (WebCore::HTMLTreeBuilder::processScriptStartTag):
1:53 AM Changeset in webkit [62918] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, build fix.

plugins/return-negative-one-from-write.html times out after r62739.
Marking as skip.

  • platform/chromium/test_expectations.txt:
1:35 AM Changeset in webkit [62917] by dumi@chromium.org
  • 1 edit
    1 add in trunk/WebKitTools

Add a script to check for unnecessary includes in header files.
​https://bugs.webkit.org/show_bug.cgi?id=41894

Reviewed by Darin Adler.

  • Scripts/check-header-includes: Added.
1:26 AM Changeset in webkit [62916] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add insertForeignElement in preparation for adding "in foreign content" support
​https://bugs.webkit.org/show_bug.cgi?id=41940

No functional changes, thus no tests.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertForeignElement): (WebCore::HTMLConstructionSite::createElement): (WebCore::HTMLConstructionSite::createHTMLElement):
  • html/HTMLConstructionSite.h:
1:13 AM Changeset in webkit [62915] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add --html5-treebuilder option to run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=41922

We're down to one or two regressions in the HTML5lib test suite. It's
getting to be time to look at fixing LayoutTests.

  • Scripts/old-run-webkit-tests:
1:11 AM Changeset in webkit [62914] by abarth@webkit.org
  • 5 edits in trunk

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implementing pending table characters
​https://bugs.webkit.org/show_bug.cgi?id=41916

This turned out to not be as scary as I thought it would be.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processDoctypeToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::processDefaultForInTableTextMode):
  • html/HTMLTreeBuilder.h:

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implementing pending table characters
​https://bugs.webkit.org/show_bug.cgi?id=41916

This doesn't quite fix all the tests, but it fixes a bunch of them.

  • html5lib/runner-expected-html5.txt:
1:09 AM Changeset in webkit [62913] by kent.hansen@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-07-09 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Skip test that never terminates on maemo5

Due to ​https://bugs.webkit.org/show_bug.cgi?id=38538
the tst_QWebPage::infiniteLoopJS() autotest never terminates.
Skip the test so that the test case may run to completion.

Patch by Dominik Holland <​dominik.holland@nokia.com>

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::infiniteLoopJS):
1:08 AM Changeset in webkit [62912] by abarth@webkit.org
  • 9 edits in trunk

2010-07-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Handle whitespace correctly
​https://bugs.webkit.org/show_bug.cgi?id=41907

This patch introduces an extra memcpy in the character token pipeline.
I'll remove the memcpy in a future patch.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode):
  • html/HTMLConstructionSite.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCharacter):
  • html/HTMLTreeBuilder.h:

2010-07-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Handle whitespace correctly
​https://bugs.webkit.org/show_bug.cgi?id=41907

Update expectations to show massive progression.

  • html5lib/resources/doctype01.dat:
    • When I created this test, I set the expectations incorrectly. The new expectations now match the spec and Minefield.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
1:02 AM Changeset in webkit [62911] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move more mode handling into functions for later re-use
​https://bugs.webkit.org/show_bug.cgi?id=41939

No functional changes, thus no tests.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInTableBody): (WebCore::HTMLTreeBuilder::processEndTagForInRow): (WebCore::HTMLTreeBuilder::processEndTagForInCell): (WebCore::HTMLTreeBuilder::processEndTag):
  • html/HTMLTreeBuilder.h:
12:56 AM QtWebKitWeeklyBuilds edited by Simon Hausmann
(diff)
12:51 AM Changeset in webkit [62910] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Unreviewed trivial Symbian build fix.

[Qt] Fix the Symbian build when compiling without S60

Use Q_OS_SYMBIAN instead of Q_WS_S60 for the user agent
determination.

  • Api/qwebpage.cpp:

(QWebPage::userAgentForUrl):

12:48 AM Changeset in webkit [62909] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add new popUntilPopped functions to clean up code
​https://bugs.webkit.org/show_bug.cgi?id=41936

Pretty self explanatory. Much awesome code reduction.

No functional changes, thus no tests.

  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::popUntilPopped):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption): (WebCore::HTMLTreeBuilder::processTableEndTagForInTable): (WebCore::HTMLTreeBuilder::processEndTag):
12:44 AM Changeset in webkit [62908] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fixed Qt symbian/linux-armcc mkspec when configured with -qtlibinfix.

Patch by Kristian Amlie <​kristian.amlie@nokia.com> on 2010-07-09
Reviewed by Simon Hausmann.

  • declarative/declarative.pro: Use QT_LIBINFIX.
12:35 AM Changeset in webkit [62907] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Unreviewed. Just renaming (discussed with Adam Barth).

Rename createElement* to createHTMLElement* to better reflect
behavior. This is in preparation for adding foreign content support.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::createHTMLElementAndAttachToCurrent): (WebCore::HTMLConstructionSite::insertHTMLHtmlElement): (WebCore::HTMLConstructionSite::insertHTMLHeadElement): (WebCore::HTMLConstructionSite::insertHTMLBodyElement): (WebCore::HTMLConstructionSite::insertHTMLElement): (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement): (WebCore::HTMLConstructionSite::createHTMLElement):
  • html/HTMLConstructionSite.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
12:30 AM Changeset in webkit [62906] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Unreviewed. Just renaming (discussed with Adam Barth).

Rename insertElement to insertHTMLElement and
insertSelfClosingElement to insertSelfClosingHTMLElement
to better reflect what they actually do. This is in preparation
for adding foreign content support.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertHTMLElement): (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement): (WebCore::HTMLConstructionSite::insertFormattingElement): (WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements): (WebCore::HTMLConstructionSite::fosterParent):
  • html/HTMLConstructionSite.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTagForInTable): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): (WebCore::HTMLTreeBuilder::processStartTagForInHead): (WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag): (WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
12:27 AM Changeset in webkit [62905] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed fix.

[Qt] Add platform specific expected file after r62889.
This test say it passes if doesn't crash. It passes, but
Qt has an extra newline character in its expected file.

  • platform/qt/editing/inserting/return-key-in-hidden-field-expected.txt: Added.
12:22 AM Changeset in webkit [62904] by rwlbuis@webkit.org
  • 5 edits
    2 adds in trunk

2010-07-08 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Eric Seidel.

Implement SVGSVGElement.getElementById
​https://bugs.webkit.org/show_bug.cgi?id=41655

Implement getElementById for SVGSVGElement by trying to
reuse Document.getElementById. If that fails to find an
SVG element in the document fragent do a subtree search.

Test: svg/custom/svg-getelementid.xhtml

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getElementById):
  • svg/SVGSVGElement.h:
  • svg/SVGSVGElement.idl:
12:11 AM Changeset in webkit [62903] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-07-09 Anders Bakken <​agbakken@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Remove superfluous function calls
​https://bugs.webkit.org/show_bug.cgi?id=40353

QWebFrame::setUrl() calls ensureAbsoluteUrl() twice. It's better to
store a local variable and reuse this one.

QWebFrame::load(QUrl) calls QWebFrame::load(QNetworkRequest) which in
turn will get the QUrl from the request and make sure it's absolute by
calling ensureAbsoluteUrl() on it.

  • Api/qwebframe.cpp: (QWebFrame::setUrl): (QWebFrame::load):
Note: See TracTimeline for information about the timeline view.