⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 5, 2010:

11:50 PM Changeset in webkit [64820] by ap@apple.com
  • 5 edits in trunk

Fix http/tests/webarchive/test-css-url-encoding-shift-jis.html

For some reason, I didn't see the failure locally, but bots complain.

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Register "shift-jis" (with dash instead of underscore). At least Firefox supports it.
10:57 PM Changeset in webkit [64819] by benm@google.com
  • 3 edits
    2 adds in trunk

2010-08-05 Ben Murdoch <​benm@google.com>

Reviewed by Simon Fraser.

Form button input elements lacking text in some cases after switching from visibility:collapse to visibility:visible
​https://bugs.webkit.org/show_bug.cgi?id=38050

  • fast/css/visibility-collapse-form-buttons-expected.txt: Added.
  • fast/css/visibility-collapse-form-buttons.html: Added.

2010-08-05 Ben Murdoch <​benm@google.com>

Reviewed by Simon Fraser.

Form button input elements lacking text in some cases after switching from
visibility:collapse to visibility:visible
​https://bugs.webkit.org/show_bug.cgi?id=38050

A relayout is required after toggling visibility from collapse to another value.

Test: fast/css/visibility-collapse-form-buttons.html

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): If we're toggling from visibility:collapse to another

visibility value (or vice versa) then we need to trigger a relayout.

10:50 PM Changeset in webkit [64818] by loki@webkit.org
  • 4 edits in trunk/JavaScriptCore

The ARM JIT does not support JSValue32_64 with RVCT
​https://bugs.webkit.org/show_bug.cgi?id=43411

Reviewed by Gavin Barraclough.

JSValue32_64 is enabled for RVCT by default.

  • create_jit_stubs:
  • jit/JITStubs.cpp:

(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):

  • wtf/Platform.h:
10:36 PM Changeset in webkit [64817] by ap@apple.com
  • 9 edits
    3 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=43554
Way too many encoding aliases are treated as valid

<rdar://problem/7863399> Garbage characters displayed in some yesky.com pages.

<rdar://problem/7859068> Garbage characters displayed for most text at ceping.zhaopin.com

Test: http/tests/misc/bad-charset-alias.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForCSSCharset): Fix encoding name length computation. Previously, a trailing quote was ignored by TextEncodingRegistry.


  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Added dashes to alias names that didn't have them. Added aliases prompted by regression tests.
  • platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::registerEncodingNames): Don't register 8859-1, other browsers do not support this encoding name.
  • platform/text/TextEncoding.cpp: (WebCore::Latin1Encoding): "Latin-1" is not a real encoding name, it's not known to Firefox or IE.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::TextEncodingNameHash::equal): Changed to no longer ignore non-alphanumeric characters. There is a good chance that we'll be missing support for some necessary alias names, but other browsers don't ignore any characters when matching names. (WebCore::TextEncodingNameHash::hash): Ditto. (WebCore::checkExistingName): Re-formatted a line. (WebCore::isUndesiredAlias): Added a filter to reject "8859_1" and any names containing commas. (WebCore::addToTextEncodingNameMap): Used it. (WebCore::atomicCanonicalTextEncodingName): Changed to no longer ignore non-alphanumeric characters.
10:08 PM Changeset in webkit [64816] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Temporary files should not be created in the current directory
​https://bugs.webkit.org/show_bug.cgi?id=43562

Don't create temporary files in the current directory, use QDir::tempPath()
instead, as suggested by the QTemporaryFile documentation.

  • platform/qt/FileSystemQt.cpp: (WebCore::openTemporaryFile):
9:50 PM Changeset in webkit [64815] by commit-queue@webkit.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

2010-08-05 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by Nikolas Zimmermann.

SVG - numeric overflow for very large elements
​https://bugs.webkit.org/show_bug.cgi?id=25645

Rebaselining results for gtk/win platforms.
Skip pattern-excessive-malloc.svg on GTK for now.

  • platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
  • platform/gtk/Skipped: Modified.
  • platform/win/svg/custom/massive-coordinates-expected.txt: Added.
9:11 PM Changeset in webkit [64814] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Make STIX font the default one to render MathML
​https://bugs.webkit.org/show_bug.cgi?id=41961

  • css/mathml.css: (math):
8:47 PM Changeset in webkit [64813] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Eric Seidel.

Apply a stylistic fix to the patch 62640.
​https://bug-41175-attachments.webkit.org/attachment.cgi?id=62640
​https://bugs.webkit.org/show_bug.cgi?id=41175

  • WebCore/platform/graphics/skia/ImageBufferSkia.cpp: (getImageData):
7:57 PM WebKit Team edited by Girish Ramakrishnan
(diff)
7:51 PM Changeset in webkit [64812] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

Make SearchPopupMenuWin more portable
​https://bugs.webkit.org/show_bug.cgi?id=43527

Add #if PLATFORM(CF) around CoreFoundation code.

  • platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenuWin::enabled): (WebCore::SearchPopupMenuWin::saveRecentSearches): (WebCore::SearchPopupMenuWin::loadRecentSearches):
7:17 PM Changeset in webkit [64811] by jberlin@webkit.org
  • 2 edits in trunk/WebKit/win

2010-08-05 Jessie Berlin <​jberlin@apple.com>

Reviewed by Jon Honeycutt.

Bug 43593 - WebView::backingStore should check if m_backingStoreBitmap is NULL.
​https://bugs.webkit.org/show_bug.cgi?id=43593

  • WebView.cpp: (WebView::backingStore): If m_backingStoreBitmap is NULL, return E_FAIL.
6:54 PM Changeset in webkit [64810] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/WebCore

2010-08-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63653.
​http://trac.webkit.org/changeset/63653
​https://bugs.webkit.org/show_bug.cgi?id=43592

regressed multiple background-images (Requested by smfr on
#webkit).

  • manual-tests/css3-background-layer-count.html: Removed.
  • rendering/style/FillLayer.cpp: (WebCore::FillLayer::fillUnsetProperties): (WebCore::FillLayer::cullEmptyLayers):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::adjustBackgroundLayers): (WebCore::InheritedFlags::adjustMaskLayers):
6:38 PM Changeset in webkit [64809] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix some leaks seen on the buildbot.

Reviewed by Jon Honeycutt.

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::paintToCanvas): Adopt the newly-created CoreGraphics objects rather than sharing ownership
and over-incrementing their reference count. Also cleaned up the bizarre wrapping used for function arguments while I was
touching this code.

6:23 PM Changeset in webkit [64808] by rniwa@webkit.org
  • 4 edits
    3 adds
    29 deletes in trunk/LayoutTests

2010-08-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

dumpAsMarkup conversion: deleting/delete-4038408-fix.html, deleting/delete-br-011.html, and execCommand/format-block-from-range-selection.html
​https://bugs.webkit.org/show_bug.cgi?id=43580

Converted deleting/delete-4038408-fix.html, deleting/delete-br-011.html, and execCommand/format-block-from-range-selection.html
to a dumpAsMarkup test because all the tests were testing the correctness of the resultant DOM tree.
In addition, removed editing delegates from execCommand/format-block-from-range-selection.html because it's not relevant to the test.

  • editing/deleting/delete-4038408-fix-expected.txt: Added.
  • editing/deleting/delete-4038408-fix.html: Converted.
  • editing/deleting/delete-br-011-expected.txt: Added.
  • editing/deleting/delete-br-011.html: Converted.
  • editing/execCommand/format-block-from-range-selection-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection.html: Converted.
  • platform/chromium-linux/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-4038408-fix-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-br-011-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-br-011-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/delete-4038408-fix-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-4038408-fix-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/delete-br-011-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/delete-br-011-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-br-011-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
  • platform/mac-leopard/editing/deleting/delete-4038408-fix-expected.png: Removed.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.png: Removed.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-br-011-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-br-011-expected.png: Removed.
  • platform/mac/editing/deleting/delete-br-011-expected.txt: Removed.
  • platform/mac/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
  • platform/mac/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
  • platform/mac/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-4038408-fix-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-br-011-expected.txt: Removed.
  • platform/qt/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
6:09 PM Changeset in webkit [64807] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-08-05 James Robinson <​jamesr@chromium.org>

Rubber stamped by Eric Seidel.

[SVG] SVGPathSeg.cpp needs an #if ENABLE(SVG) guard
​https://bugs.webkit.org/show_bug.cgi?id=43599

Matches the rest of the .cpp files in this directory.

  • svg/SVGPathSeg.cpp:
5:56 PM Changeset in webkit [64806] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Adam Barth <​abarth@webkit.org>

Update Qt result showing that we strip nulls in this case.

  • platform/qt/fast/text/stripNullFromText-expected.txt:
5:46 PM Changeset in webkit [64805] by arv@chromium.org
  • 4 edits
    2 adds in trunk

2010-08-05 Erik Arvidsson <​arv@chromium.org>

Reviewed by Kent Tamura.

Calling setCustomValidity should trigger a layout
​https://bugs.webkit.org/show_bug.cgi?id=43582

  • fast/forms/setCustomValidity-expected.txt: Added.
  • fast/forms/setCustomValidity.html: Added.

2010-08-05 Erik Arvidsson <​arv@chromium.org>

Reviewed by Kent Tamura.

Calling setCustomValidity should trigger a layout
​https://bugs.webkit.org/show_bug.cgi?id=43582

Test: fast/forms/setCustomValidity.html

  • html/ValidityState.cpp: (WebCore::ValidityState::setCustomErrorMessage): Call setNeedsValidityCheck to tell the system that the validity might have changed.
  • html/ValidityState.h:
5:41 PM Changeset in webkit [64804] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-05 Chao-ying Fu <​fu@mips.com>

Reviewed by Darin Adler.

Define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER for MIPS
​https://bugs.webkit.org/show_bug.cgi?id=43514

MIPS needs to define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER, so that
RenderArena::allocate() can return 8-byte aligned memory to avoid
exceptions on sdc1/ldc1.

  • wtf/Platform.h:
5:31 PM Changeset in webkit [64803] by weinig@apple.com
  • 12 edits in trunk

Add ability to get a JSValueRef for a node handle and a world
​https://bugs.webkit.org/show_bug.cgi?id=43591

Reviewed by Anders Carlsson.

WebCore:

  • WebCore.exp.in: Add exports.

WebKit2:

  • Add API to get a JSValueRef for a world, node and frame (the frame is currently necessary to pick the right globalObject for the node wrapper).
  • Add API to a JSGlobalContextRef for a world and a frame.
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetJavaScriptContextForWorld):
(WKBundleFrameGetJavaScriptWrapperForNodeForWorld):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::coreNode):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:

(WebKit::InjectedBundleScriptWorld::coreWorld):

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::jsContext):
(WebKit::WebFrame::jsContextForWorld):
(WebKit::WebFrame::jsWrapperForWorld):

  • WebProcess/WebPage/WebFrame.h:
5:24 PM Changeset in webkit [64802] by Joseph Pecoraro
  • 2 edits in trunk/WebKit/mac

2010-08-05 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Remove Invalid Asserts for Application Cache Quotas
​https://bugs.webkit.org/show_bug.cgi?id=43585

Removed Invalid ASSERTs that would always happen for quotas
that were not noQuota().

  • WebView/WebPreferences.mm: (-[WebPreferences applicationCacheTotalQuota]): (-[WebPreferences applicationCacheDefaultOriginQuota]):
5:20 PM Changeset in webkit [64801] by barraclough@apple.com
  • 286 edits in trunk

Bug 43594 - Add string forwards to Forward.h
This allows us to remove forward declarations for these classes from
WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).

Rubber stamped by Sam Weinig

JavaScriptCore:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityTable.h:
  • bindings/cpp/WebDOMCString.h:
  • bindings/cpp/WebDOMString.h:
  • bindings/gobject/ConvertToUTF8String.h:
  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSMessagePortCustom.h:
  • bindings/js/JavaScriptCallFrame.h:
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptProfile.h:
  • bindings/js/ScriptSourceProvider.h:
  • bindings/js/ScriptString.h:
  • bindings/js/WorkerScriptController.h:
  • bindings/objc/DOMImplementationFront.h:
  • bindings/v8/ScheduledAction.h:
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8CustomXPathNSResolver.h:
  • bridge/c/c_utility.h:
  • css/CSSFontSelector.h:
  • css/CSSHelper.h:
  • css/CSSOMUtils.h:
  • css/CSSPrimitiveValue.h:
  • css/MediaList.h:
  • css/StyleBase.h:
  • css/StyleSheetList.h:
  • css/WebKitCSSKeyframesRule.h:
  • dom/CheckedRadioButtons.h:
  • dom/DOMImplementation.h:
  • dom/DocumentMarker.h:
  • dom/DynamicNodeList.h:
  • dom/EventTarget.h:
  • dom/MessagePort.h:
  • dom/MessagePortChannel.h:
  • dom/NameNodeList.h:
  • dom/Node.h:
  • dom/NodeList.h:
  • dom/OptionGroupElement.h:
  • dom/ScriptExecutionContext.h:
  • dom/SelectElement.h:
  • dom/ViewportArguments.h:
  • dom/make_names.pl:
  • editing/HTMLInterchange.h:
  • editing/htmlediting.h:
  • editing/markup.h:
  • html/CollectionCache.h:
  • html/DOMFormData.h:
  • html/DataGridColumnList.h:
  • html/DateComponents.h:
  • html/FileStream.h:
  • html/FileStreamProxy.h:
  • html/FormDataList.h:

(WebCore::FormDataList::appendData):

  • html/HTMLCollection.h:
  • html/HTMLElementStack.h:
  • html/HTMLFormattingElementList.h:
  • html/HTMLParserQuirks.h:
  • html/HTMLQuoteElement.h:
  • html/HTMLScriptRunnerHost.h:
  • html/StepRange.h:
  • html/canvas/CanvasGradient.h:
  • html/canvas/CanvasNumberArray.h:
  • html/canvas/CanvasPattern.h:
  • inspector/InjectedScript.h:
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorClient.h:
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorValues.h:
  • inspector/ScriptDebugListener.h:
  • loader/CachedResourceClient.h:
  • loader/CrossOriginAccessControl.h:
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/RedirectScheduler.h:
  • loader/SubframeLoader.h:
  • loader/appcache/DOMApplicationCache.h:
  • loader/archive/ArchiveFactory.h:
  • loader/icon/IconDatabaseClient.h:
  • notifications/NotificationPresenter.h:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Console.h:
  • page/ContextMenuClient.h:
  • page/DOMSelection.h:
  • page/EditorClient.h:
  • page/EventHandler.h:
  • page/FrameView.h:
  • page/GeolocationPositionCache.h:
  • page/History.h:
  • page/Location.h:
  • page/Navigator.h:
  • page/NavigatorBase.h:
  • page/PluginHalterClient.h:
  • page/PrintContext.h:
  • page/SpeechInput.h:
  • page/SpeechInputListener.h:
  • page/animation/AnimationController.h:
  • platform/CookieJar.h:
  • platform/CrossThreadCopier.h:
  • platform/DragImage.h:
  • platform/FileSystem.h:
  • platform/Language.h:
  • platform/Length.h:
  • platform/LinkHash.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.h:
  • platform/Logging.h:
  • platform/Pasteboard.h:
  • platform/PopupMenuClient.h:
  • platform/SearchPopupMenu.h:
  • platform/Widget.h:
  • platform/cf/BinaryPropertyList.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ClipboardUtilitiesChromium.h:
  • platform/cocoa/KeyEventCocoa.h:
  • platform/graphics/Color.h:
  • platform/graphics/FontCache.h:
  • platform/graphics/FontData.h:
  • platform/graphics/FontSelector.h:
  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/Icon.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/Path.h:
  • platform/graphics/StringTruncator.h:
  • platform/graphics/cairo/FontCustomPlatformData.h:
  • platform/graphics/cairo/FontPlatformData.h:
  • platform/graphics/cg/FontPlatformData.h:
  • platform/graphics/cg/ImageSourceCG.h:
  • platform/graphics/chromium/FontCustomPlatformData.h:
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:
  • platform/graphics/chromium/FontPlatformDataLinux.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/haiku/FontCustomPlatformData.h:
  • platform/graphics/mac/FontCustomPlatformData.h:
  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/qt/FontCustomPlatformData.h:
  • platform/graphics/qt/FontPlatformData.h:
  • platform/graphics/win/FontCustomPlatformData.h:
  • platform/graphics/win/FontCustomPlatformDataCairo.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/wince/FontPlatformData.h:
  • platform/graphics/wince/MediaPlayerPrivateWince.h:
  • platform/graphics/wince/MediaPlayerProxy.h:
  • platform/graphics/wx/FontCustomPlatformData.h:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/mac/PasteboardHelper.h:
  • platform/network/DNS.h:
  • platform/network/FormData.h:
  • platform/network/FormDataBuilder.h:
  • platform/network/HTTPParsers.h:
  • platform/text/Hyphenation.h:
  • platform/text/LineEnding.h:
  • platform/text/TextCodec.h:
  • platform/text/TextEncoding.h:
  • platform/text/TextStream.h:
  • platform/win/BString.h:
  • platform/win/ClipboardUtilitiesWin.h:
  • platform/win/WCDataObject.h:
  • platform/win/WebCoreTextRenderer.h:
  • plugins/DOMMimeType.h:
  • plugins/DOMMimeTypeArray.h:
  • plugins/DOMPlugin.h:
  • plugins/DOMPluginArray.h:
  • rendering/CounterNode.h:
  • rendering/HitTestResult.h:
  • rendering/RenderObjectChildList.h:
  • rendering/RenderText.h:
  • rendering/RenderTreeAsText.h:
  • rendering/TextControlInnerElements.h:
  • rendering/style/ContentData.h:
  • rendering/style/RenderStyle.h:
  • storage/DatabaseAuthorizer.h:
  • storage/DatabaseTrackerClient.h:
  • storage/SQLTransaction.h:
  • storage/SQLTransactionSync.h:
  • storage/Storage.h:
  • storage/chromium/DatabaseObserver.h:
  • svg/SVGAnimatedTemplate.h:
  • svg/SVGDocumentExtensions.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGHKernElement.h:
  • svg/SVGNumberList.h:
  • svg/SVGPointList.h:
  • svg/SVGPreserveAspectRatio.h:
  • svg/SVGStylable.h:
  • svg/SVGTests.h:
  • svg/SVGTransformList.h:
  • svg/SVGTransformable.h:
  • svg/SVGVKernElement.h:
  • websockets/ThreadableWebSocketChannel.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.h:
  • websockets/WebSocketHandshakeResponse.h:
  • wml/WMLErrorHandling.h:
  • wml/WMLPageState.h:
  • wml/WMLVariables.h:
  • workers/DefaultSharedWorkerRepository.h:
  • workers/SharedWorkerRepository.h:
  • workers/Worker.h:
  • workers/WorkerContextProxy.h:
  • workers/WorkerLoaderProxy.h:
  • workers/WorkerLocation.h:
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:
  • workers/WorkerThread.h:
  • xml/DOMParser.h:
  • xml/XMLHttpRequestUpload.h:
  • xml/XPathEvaluator.h:
  • xml/XPathExpression.h:
  • xml/XPathNSResolver.h:
  • xml/XPathResult.h:
  • xml/XPathUtil.h:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/chromium:

  • public/WebCString.h:
  • public/WebString.h:
  • src/DOMUtilitiesPrivate.h:
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.h:
  • src/WebDevToolsAgentImpl.h:
  • src/WebDevToolsFrontendImpl.h:
  • src/WebPageSerializerImpl.h:

WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.h:

WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.h:

WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.h:
  • WebCoreSupport/InspectorClientHaiku.h:

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/WebBaseNetscapePluginView.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebIconDatabaseClient.h:
  • WebCoreSupport/WebPluginHalterClient.h:
  • WebView/WebViewInternal.h:

WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/InspectorClientQt.h:

WebKit/win:

  • COMVariantSetter.h:
  • MarshallingHelpers.h:
  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebPluginHalterClient.h:
  • WebHistory.h:

WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.h:
  • WebKitSupport/InspectorClientWx.h:

WebKit2:

  • UIProcess/PageClient.h:
  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebUIClient.h:
  • UIProcess/win/WebView.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/Plugins/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h:
5:13 PM Changeset in webkit [64800] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed leak seen on buildbot.

Reviewed by Mark Rowe.

  • runtime/GCActivityCallbackCF.cpp:

(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::operator()): Make out timer a RetainPtr,
since anything less would be uncivilized.

5:12 PM Changeset in webkit [64799] by abarth@webkit.org
  • 9 edits
    4 adds in trunk

2010-08-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

U+0000 is turned to U+FFFD (replacement character)
​https://bugs.webkit.org/show_bug.cgi?id=42112

Update test results to show null stripping. These changes are mostly
going back to the old results we had before we added the FFFD
replacement.

  • fast/dom/stripNullFromTextNodes-expected.txt:
  • fast/tokenizer/null-in-text-expected.txt: Added.
  • fast/tokenizer/null-in-text.html: Added.
  • fast/tokenizer/null-xss-expected.txt: Added.
  • fast/tokenizer/null-xss.html: Added.
    • The main risk with stripping null characters is that they'll be used in XSS attacks. This test shows that we don't strip null characters from tag names.
  • platform/mac/fast/text/stripNullFromText-expected.txt:
  • svg/dom/fuzz-path-parser-expected.txt:
  • svg/dom/rgb-color-parser-expected.txt:

2010-08-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

U+0000 is turned to U+FFFD (replacement character)
​https://bugs.webkit.org/show_bug.cgi?id=42112

This patch introduces an intentional parsing difference from the HTML5
parsing specificiation. The spec requires us to convert NULL
characters to U+FFFD, but doing so causes compatibility issues with a
number of sites, including US Bank.

In this patch, we strip the null characters instead in certain cases.
Firefox has made a corresponding change. After gathering compatability
data, we hope to convince the HTML WG to adopt this change.

Tests: fast/tokenizer/null-in-text.html

fast/tokenizer/null-xss.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::reset):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::setSkipLeadingNewLineForListing): (WebCore::HTMLTokenizer::forceNullCharacterReplacement): (WebCore::HTMLTokenizer::setForceNullCharacterReplacement): (WebCore::HTMLTokenizer::shouldSkipNullCharacters): (WebCore::HTMLTokenizer::InputStreamPreprocessor::InputStreamPreprocessor): (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::passTokenToLegacyParser): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processStartTagForInBody):
5:08 PM Changeset in webkit [64798] by aestes@apple.com
  • 11 edits in trunk

JavaScriptCore: Rename iOS-related OS and PLATFORM macros.
​https://bugs.webkit.org/show_bug.cgi?id=43493

Reviewed by David Kilzer.

Rename WTF_OS_IPHONE_OS to WTF_OS_IOS, WTF_PLATFORM_IPHONE to
WTF_PLATFORM_IOS, and WTF_PLATFORM_IPHONE_SIMULATOR to
WTF_PLATFORM_IOS_SIMULATOR.

  • jit/ExecutableAllocator.h:
  • jit/JITStubs.cpp:
  • profiler/ProfilerServer.mm:

(-[ProfilerServer init]):

  • wtf/FastMalloc.cpp:

(WTF::TCMallocStats::):

  • wtf/Platform.h:
  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault):

WebCore: Rename iOS-related OS and PLATFORM macros.
​https://bugs.webkit.org/show_bug.cgi?id=43493

Reviewed by David Kilzer.

Rename WTF_OS_IPHONE_OS to WTF_OS_IOS, WTF_PLATFORM_IPHONE to
WTF_PLATFORM_IOS, and WTF_PLATFORM_IPHONE_SIMULATOR to
WTF_PLATFORM_IOS_SIMULATOR.

  • platform/cocoa/KeyEventCocoa.mm:
  • platform/iphone/KeyEventIPhone.mm:
  • platform/network/Credential.h:
5:00 PM Changeset in webkit [64797] by andersca@apple.com
  • 13 edits in trunk

Use the visited link provider for visited links
​https://bugs.webkit.org/show_bug.cgi?id=43583

Reviewed by Sam Weinig.

WebCore:

Export Page::visitedStateChanged and Page::allvisitedStateChanged.

  • WebCore.exp.in:

WebKit2:

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):
Remove AddVisitedLink.

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:

(WebProcessProxyMessage::):
Remove PopulateVisitedLinks and add AddVisitedLink.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::sharedProcessContext):
Initialize the main run loop before creating the context.

(WebKit::WebContext::sharedThreadContext):
Ditto.

(WebKit::WebContext::create):
Ditto.

(WebKit::WebContext::WebContext):
Initialize the visited link provider.

(WebKit::WebContext::processDidFinishLaunching):
Ask the visited link provider to populate visited links.

(WebKit::WebContext::addVisitedLink):
Ask the visited link provider to add the visited link.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addVisitedLink):
Call WebContext::addVisitedLink.

(WebKit::WebProcessProxy::didReceiveMessage):
Handle AddVisitedLink.

(WebKit::WebProcessProxy::didFinishLaunching):
Call WebContext::processdidFinishLaunching.

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::populateVisitedLinks):
Don't send the WebProcessProxyMessage::PopulateVisitedLinks message.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::isLinkVisited):
Call WebProcess::isLinkVisited.

(WebKit::WebPlatformStrategies::addVisitedLink):
Call WebProcess::addVisitedLink.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setVisitedLinkTable):
Create a shared memory object and tell the visited link table about it.

(WebKit::WebProcess::visitedLinkStateChanged):
Go through the link hashes and call Page::visitedStateChanged.

(WebKit::WebProcess::allVisitedLinkStateChanged):
Call Page::allVisitedStateChanged.

(WebKit::WebProcess::isLinkVisited):
Call VisitedLinkTable::isLinkVisited.

(WebKit::WebProcess::addVisitedLink):
Inform the UI process about the added link.

(WebKit::WebProcess::didReceiveMessage):
Handle new messages.

4:52 PM Changeset in webkit [64796] by abarth@webkit.org
  • 7 edits in trunk/LayoutTests

2010-08-05 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

js-test-pre.js's escapeHTML should escape null characters so we can see them
​https://bugs.webkit.org/show_bug.cgi?id=43579

  • fast/canvas/canvas-getContext-invalid-expected.txt:
  • fast/js/null-char-in-string-expected.txt:
  • fast/js/resources/js-test-pre.js: (escapeHTML):
  • fast/js/switch-behaviour-expected.txt:
  • storage/domstorage/complex-values-expected.txt:
  • websocket/tests/bad-sub-protocol-control-chars-expected.txt:
4:22 PM Changeset in webkit [64795] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.
Add missing include path.

  • win/WebKit2Common.vsprops:
4:11 PM Changeset in webkit [64794] by brettw@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-05 Brett Wilson <​brettw@chromium.org>

Reviewed by Nate Chapin.

Make the webkit unit tests depend on test_support_base
​https://bugs.webkit.org/show_bug.cgi?id=43584

  • WebKit.gyp:
3:55 PM CommitterTips edited by ojan@chromium.org
(diff)
3:55 PM Changeset in webkit [64793] by eric@webkit.org
  • 22 edits
    1 add in trunk/WebCore

2010-08-05 Eric Seidel <​eric@webkit.org>

Reviewed by Nikolas Zimmermann.

Touching SVGNames should only rebuild hundreds of files, not thousands
​https://bugs.webkit.org/show_bug.cgi?id=43308

Remove SVGNames.h include from several core SVG header files
which do not need to include it.

One of them, SVGPathSeg.h, required creation of an SVGPathSeg.cpp.
A bunch of SVGPathSeg* could remove PlatformString.h includes if
we moved their toString() methods into the .cpp files.

I re-indented on header to stop check-webkit-style from complaining.
I removed a couple mode lines I saw, since my understanding from
previous webkit-dev threads is that we plan to remove those all.

No functional change, thus no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAngle.h:
  • svg/SVGPathSeg.cpp: Added. (WebCore::SVGPathSeg::~SVGPathSeg): (WebCore::SVGPathSeg::pathSegType): (WebCore::SVGPathSeg::pathSegTypeAsLetter): (WebCore::SVGPathSeg::toString): (WebCore::SVGPathSeg::associatedAttributeName): (WebCore::SVGPathSegSingleCoord::toString):
  • svg/SVGPathSeg.h: (WebCore::SVGPathSegSingleCoord::SVGPathSegSingleCoord):
  • svg/SVGPathSegArc.cpp: (WebCore::SVGPathSegArc::toString):
  • svg/SVGPathSegArc.h: (WebCore::SVGPathSegArc::SVGPathSegArc):
  • svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::create): (WebCore::SVGPathSegClosePath::pathSegType): (WebCore::SVGPathSegClosePath::pathSegTypeAsLetter): (WebCore::SVGPathSegClosePath::toString):
  • svg/SVGPathSegCurvetoCubic.h:
  • svg/SVGPathSegCurvetoCubicSmooth.h:
  • svg/SVGPathSegCurvetoQuadratic.h:
  • svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • svg/SVGPathSegLineto.h:
  • svg/SVGPathSegLinetoHorizontal.h:
  • svg/SVGPathSegLinetoVertical.h:
  • svg/SVGPathSegMoveto.h:
  • svg/SVGTransform.h:
3:38 PM Changeset in webkit [64792] by beidson@apple.com
  • 2 edits in trunk/WebKit2

Export WKError.h

Rubberstamped by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:
3:29 PM Changeset in webkit [64791] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.
Correct vcproj nesting.

  • win/WebKit2.vcproj:
3:22 PM Changeset in webkit [64790] by commit-queue@webkit.org
  • 11 edits in trunk/JavaScriptCore

2010-08-05 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=43464

Currently, the global object is being embedded in the JavaScriptCore
bytecode, however since the global object is the same for all opcodes
in a code block, we can have the global object just be a member of the
associated code block.

Additionally, I added an assert inside of emitOpcode that verifies
that the last generated opcode was of the correct length.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject): (JSC::GlobalCodeBlock::GlobalCodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock): (JSC::FunctionCodeBlock::FunctionCodeBlock):
  • bytecode/Opcode.h: (JSC::opcodeLength):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitOpcode):

Added an assert to check that the last generated opcode is the
correct length.

(JSC::BytecodeGenerator::rewindBinaryOp):

Changed the last opcode to op_end since the length will no longer
be correct.

(JSC::BytecodeGenerator::rewindUnaryOp):

Changed the last opcode to op_end since the length will no longer
be correct.

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitGetScopedVar):
(JSC::BytecodeGenerator::emitPutScopedVar):
(JSC::BytecodeGenerator::emitResolveWithBase):

  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::privateExecute):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_resolve_global_dynamic): (JSC::JIT::emitSlow_op_resolve_global_dynamic):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global):
  • jit/JITStubs.cpp: (JSC::cti_op_resolve_global):
  • runtime/Executable.cpp: (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal): (JSC::FunctionExecutable::reparseExceptionInfo):
2:49 PM Changeset in webkit [64789] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Dirk Schulze <​krit@webkit.org>

Unreviewed sort of XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
2:32 PM Changeset in webkit [64788] by weinig@apple.com
  • 8 edits
    4 adds in trunk/WebKit2

Add script world API for injected bundles
​https://bugs.webkit.org/show_bug.cgi?id=43577

Reviewed by Gavin Barraclough.

  • Shared/APIObject.h:

(WebKit::APIObject::):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit::):

  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp: Added.

(WKBundleScriptWorldGetTypeID):
(WKBundleScriptWorldCreateWorld):
(WKBundleScriptWorldNormalWorld):
(WKBundleScriptWorldRetain):
(WKBundleScriptWorldRelease):

  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h: Added.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp: Added.

(WebKit::allWorlds):
(WebKit::InjectedBundleScriptWorld::create):
(WebKit::InjectedBundleScriptWorld::getOrCreate):
(WebKit::InjectedBundleScriptWorld::normalWorld):
(WebKit::InjectedBundleScriptWorld::InjectedBundleScriptWorld):
(WebKit::InjectedBundleScriptWorld::~InjectedBundleScriptWorld):

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h: Added.

(WebKit::InjectedBundleScriptWorld::type):

  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
2:28 PM Changeset in webkit [64787] by eric@webkit.org
  • 5 edits
    1 copy
    1 add in trunk/WebKitTools

2010-05-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

QueueStatusServer needs better queue-status pages
​https://bugs.webkit.org/show_bug.cgi?id=39562

The primary goal of this patch is to display queue
positions somewhere on the site so that it's easier
for commit-queue users to know when their pach will
be landed. I also tried to improve the root page
to be more useful than the previous wall of status text.

  • QueueStatusServer/handlers/recentstatus.py:
  • QueueStatusServer/main.py:
  • QueueStatusServer/model/queues.py:
  • QueueStatusServer/templates/recentstatus.html:
2:24 PM Changeset in webkit [64786] by victorw@chromium.org
  • 5 edits in trunk/WebKitTools

2010-08-05 Victor Wang <​victorw@chromium.org>

Reviewed by Ojan Vafai.

Add option to generate/upload incremental json results to test result server.
Also refactor the json results generator unittest code to test
incremental and aggregated json results.

​https://bugs.webkit.org/show_bug.cgi?id=43519

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:10 PM Changeset in webkit [64785] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Adam Barth <​abarth@webkit.org>

Actually make HTMLEntityNames.json valid JSON.

  • html/HTMLEntityNames.json:
2:10 PM Changeset in webkit [64784] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix for chromium.
​https://bugs.webkit.org/show_bug.cgi?id=43574

  • platform/chromium/test_expectations.txt:
1:59 PM Changeset in webkit [64783] by Beth Dakin
  • 2 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=43516 REGRESSION:
Huge number of memory leaks after enabling MathML
-and corresponding-
<rdar://problem/8274123>

Reviewed by Kenneth Rohde Christiansen.

Destroy the old children in
RenderMathMLOperator::updateFromElement() instead of just removing
them since just removing them will cause them to leak.

  • mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

1:57 PM Changeset in webkit [64782] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

Bug 43185 - Switch RegisterFile over to use PageAllocation

Reviewed by Sam Weinig.

Remove platform-specific memory allocation code.

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::~RegisterFile):
(JSC::RegisterFile::releaseExcessCapacity):

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):
(JSC::RegisterFile::checkAllocatedOkay):

  • wtf/PageAllocation.cpp:

(WTF::PageAllocation::lastError):

  • wtf/PageAllocation.h:

(WTF::PageAllocation::allocate):
(WTF::PageAllocation::allocateAt):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::pageSize):
(WTF::PageAllocation::isPageAligned):
(WTF::PageAllocation::isPowerOfTwo):

  • wtf/PageReservation.h:

(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::reserve):
(WTF::PageReservation::reserveAt):

1:40 PM Changeset in webkit [64781] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-08-05 Martin Robinson <​mrobinson@igalia.com>

[GTK] Some sputnik tests fail
​https://bugs.webkit.org/show_bug.cgi?id=43568

  • platform/gtk/Skipped: Skip some more failing Sputnik tests.
1:32 PM Changeset in webkit [64780] by tony@chromium.org
  • 6 edits
    3 adds in trunk

2010-08-05 Tony Chang <​tony@chromium.org>

Reviewed by David Hyatt.

Fix a crash when a hidden iframe with a custom scrollbar finishes loading an image.
​https://bugs.webkit.org/show_bug.cgi?id=42724

  • scrollbars/hidden-iframe-scrollbar-crash2.html: Added.
  • scrollbars/resources/hidden-iframe-scrollbar-crash2.html: Added.

2010-08-05 Tony Chang <​tony@chromium.org>

Reviewed by David Hyatt.

Fix a crash when a hidden iframe with a custom scrollbar finishes loading an image.
​https://bugs.webkit.org/show_bug.cgi?id=42724

Test: scrollbars/hidden-iframe-scrollbar-crash2.html

  • page/FrameView.cpp: (WebCore::FrameView::createScrollbar):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::createCustomScrollbar): Pass in Frame (WebCore::RenderScrollbar::RenderScrollbar): Pass in Frame (WebCore::RenderScrollbar::owningRenderer): Use the frame to get the RenderBox (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): null check (WebCore::RenderScrollbarPart::computeScrollbarHeight): null check
1:27 PM Changeset in webkit [64779] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix for Chromium.

WebInspector: inspector/debugger-breakpoints-not-activated-on-reload.html
was regressed. I'll fix it tomorrow.
​https://bugs.webkit.org/show_bug.cgi?id=43574

  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [64778] by weinig@apple.com
  • 8 edits
    5 adds in trunk/WebKit2

Reviewed Anders Carlsson.

Add DOM Node wrapper class for injected bundle
​https://bugs.webkit.org/show_bug.cgi?id=43524

  • This class should not expose any DOM APIs, but just be a handle that can be used to get a JS wrapper for the node in a specific world.
  • Shared/APIObject.h:

(WebKit::APIObject::):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit::):

  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNode.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: Added.

(WKBundleNodeHandleGetTypeID):
(WKBundleNodeHandleRetain):
(WKBundleNodeHandleRelease):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h: Added.
  • WebProcess/InjectedBundle/DOM: Added.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Added.

(WebKit::domHandleCache):
(WebKit::getDOMHandle):
(WebKit::setDOMHandle):
(WebKit::removeDOMHandle):
(WebKit::InjectedBundleNodeHandle::getOrCreate):
(WebKit::InjectedBundleNodeHandle::create):
(WebKit::InjectedBundleNodeHandle::InjectedBundleNodeHandle):
(WebKit::InjectedBundleNodeHandle::~InjectedBundleNodeHandle):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Added.

(WebKit::InjectedBundleNodeHandle::type):

  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
1:01 PM Changeset in webkit [64777] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-08-05 Yong Li <​yoli@rim.com>

Reviewed by Adam Treat.

Fix the problem that down-sampling code doesn't work
for some GIF's. GIF reader can call setSize() multiple times.
We should clear the scaling maps before adding new entries.
Also add a fast path to check if the size has changed since last time.

​https://bugs.webkit.org/show_bug.cgi?id=43501

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::prepareScaleDataIfNecessary):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::setSize):
12:58 PM Changeset in webkit [64776] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • Platform/mac/SharedMemoryMac.cpp:
12:54 PM Changeset in webkit [64775] by andersca@apple.com
  • 5 edits
    1 copy
    1 add in trunk/WebKit2

Add VisitedLinkProvider class
​https://bugs.webkit.org/show_bug.cgi?id=43570

Reviewed by Sam Weinig.

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):
Add SetVisitedLinkTable, VisitedLinkStateChanged and AllVisitedLinkStateChanged.

  • UIProcess/VisitedLinkProvider.cpp: Added.

(WebKit::VisitedLinkProvider::VisitedLinkProvider):
Initialize table.

(WebKit::VisitedLinkProvider::populateVisitedLinksIfNeeded):
Ask the context to populate visited links.

(WebKit::VisitedLinkProvider::addVisitedLink):
Add the link hash to the set of pending visited links and start the timer.

(WebKit::nextPowerOf2):
Add helper function.

(WebKit::tableSizeForKeyCount):
Given a key count, returns a table size. The table size is always a power of two, and
is chosen so that the table is always at least half empty.

(WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):
First, check if we need to resize the hash table and allocate new shared memory for it if that is the case.
Then, go through the pending link hash vector and insert all the elements in the table. Finally, notify the web
process about visited links whose state have changed.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):
Add case statements.

  • win/WebKit2.vcproj:
  • WebKit2.xcodeproj/project.pbxproj:

Add VisitedLinkProvider.cpp and VisitedLinkProvider.h.

12:44 PM Changeset in webkit [64774] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-08-05 Martin Robinson <​mrobinson@igalia.com>

[GTK] Some sputnik tests fail
​https://bugs.webkit.org/show_bug.cgi?id=43568

  • platform/gtk/Skipped: Adding some more sputnik failures from the debug bot.
12:33 PM Changeset in webkit [64773] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-08-05 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=43401 where array
content aren't properly initialized as part of unshift.

  • runtime/JSArray.cpp: (JSC::JSArray::unshiftCount):

2010-08-05 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

New regression tests added as part of unshift fix for bug described
inhttps://bugs.webkit.org/show_bug.cgi?id=43401.

  • fast/js/script-tests/unshift-multi.js: Added.
  • fast/js/unshift-multi-expected.txt: Added.
  • fast/js/unshift-multi.html: Added.
12:24 PM Changeset in webkit [64772] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/JavaScriptAudioNode.cpp

fixes for buffer size in JavaScriptAudioNode

  • keep buffer size within reasonable min/max range
  • fix initialization error
12:24 PM Changeset in webkit [64771] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/AudioContext.cpp

Fix AudioContext initialization to avoid unpredictable pauses

12:17 PM Changeset in webkit [64770] by loislo@chromium.org
  • 18 edits in trunk/WebCore

2010-08-05 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: In the current implementation of inspector agents we're calling
did methods manually. That is error prone and is bad from protocol point of view.
It would be better to call did methods automatically from the corresponding methods
of InspectorBackendDispatcher and report the results. As far as our protocol is
statefull this trick will keep it in the consistent state.
​https://bugs.webkit.org/show_bug.cgi?id=43489

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfilerLogLines): (WebCore::InspectorBackend::setInjectedScriptSource): (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::clearConsoleMessages): (WebCore::InspectorBackend::releaseWrapperObjectGroup): (WebCore::InspectorBackend::getDatabaseTableNames):
  • inspector/InspectorBackend.h:
  • inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::inspectorStyleSheet):
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::removeDOMStorageItem): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::editScriptSource): (WebCore::InspectorController::getScriptSource): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::getResourceContent):
  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorClient):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::changeTagName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::setTextNodeValue): (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getStyleSheet): (WebCore::InspectorDOMAgent::getRuleRanges): (WebCore::InspectorDOMAgent::getInlineStyle): (WebCore::InspectorDOMAgent::getComputedStyle): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::buildObjectForRule): (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorValues.cpp: (WebCore::InspectorValue::asNumber): (WebCore::InspectorBasicValue::asNumber):
  • inspector/InspectorValues.h:
  • inspector/front-end/Callback.js: (WebInspector.Callback.prototype.processCallback): (WebInspector.Callback.prototype.removeCallbackEntry):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):
  • inspector/front-end/inspector.js: (WebInspector.reportProtocolError):
12:11 PM Changeset in webkit [64769] by Martin Robinson
  • 2 edits
    6 adds in trunk/LayoutTests

2010-08-05 Martin Robinson <​mrobinson@igalia.com>

[GTK] Some sputnik tests fail
​https://bugs.webkit.org/show_bug.cgi?id=43568

Unskip the majority of the Sputnik tests. Most of them are passing
and a few just needed GTK+ baselines showing that they pass.

  • platform/gtk/Skipped: Skip remaining failures.
  • platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Copied from LayoutTests/platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
  • platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Copied from LayoutTests/platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
  • platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Copied from LayoutTests/platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
11:58 AM Changeset in webkit [64768] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

Add VisitedLinkTable class
​https://bugs.webkit.org/show_bug.cgi?id=43566

Reviewed by Sam Weinig.

  • Shared/VisitedLinkTable.cpp: Added.

(WebKit::VisitedLinkTable::VisitedLinkTable):
(WebKit::VisitedLinkTable::~VisitedLinkTable):
Add out of line constructors so we won't have to include SharedMemory.h in the
VisitedLinkTable.h header.

(WebKit::isPowerOf2):
Add helper function.

(WebKit::VisitedLinkTable::setSharedMemory):
Set the new shared memory and update the table size and hash.

(WebKit::doubleHash):
Add helper function from the WTF HashTable.

(WebKit::VisitedLinkTable::addLinkHash):
Add a link hash to the table.

(WebKit::VisitedLinkTable::isLinkVisited):
See if there is an entry for the given link hash.

  • Shared/VisitedLinkTable.h: Added.

(WebKit::VisitedLinkTable::sharedMemory):

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add VisitedLinkTable.cpp and VisitedLinkTable.h

11:33 AM Changeset in webkit [64767] by kbr@google.com
  • 28 edits in trunk

2010-08-04 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Style cleanups in WebGL
​https://bugs.webkit.org/show_bug.cgi?id=38761

Cleaned up all style violations in WebGL-related files reported by
check-webkit-style. No logic or other changes. Built WebKit and
Chromium and ran WebGL layout tests.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
  • src/WebGraphicsContext3DDefaultImpl.cpp:
  • src/WebGraphicsContext3DDefaultImpl.h:

2010-08-04 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Style cleanups in WebGL
​https://bugs.webkit.org/show_bug.cgi?id=38761

Cleaned up all style violations in WebGL-related files reported by
check-webkit-style. No logic or other changes. Built WebKit and
Chromium and ran WebGL layout tests.

  • html/canvas/ArrayBuffer.cpp: (WebCore::ArrayBuffer::ArrayBuffer): (WebCore::ArrayBuffer::data): (WebCore::ArrayBuffer::byteLength): (WebCore::ArrayBuffer::~ArrayBuffer): (WebCore::ArrayBuffer::tryAllocate):
  • html/canvas/ArrayBufferView.cpp: (WebCore::ArrayBufferView::setImpl):
  • html/canvas/ArrayBufferView.h:
  • html/canvas/TypedArrayBase.h:
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::deleteObjectImpl): (WebCore::WebGLBuffer::associateBufferData):
  • html/canvas/WebGLBuffer.h: (WebCore::WebGLBuffer::~WebGLBuffer): (WebCore::WebGLBuffer::elementArrayBuffer): (WebCore::WebGLBuffer::getTarget): (WebCore::WebGLBuffer::isBuffer):
  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::deleteObjectImpl):
  • html/canvas/WebGLFramebuffer.h: (WebCore::WebGLFramebuffer::~WebGLFramebuffer): (WebCore::WebGLFramebuffer::isDepthAttached): (WebCore::WebGLFramebuffer::isStencilAttached): (WebCore::WebGLFramebuffer::isDepthStencilAttached): (WebCore::WebGLFramebuffer::isFramebuffer):
  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLObject.cpp: (WebCore::WebGLObject::deleteObject):
  • html/canvas/WebGLObject.h: (WebCore::WebGLObject::object): (WebCore::WebGLObject::detachContext): (WebCore::WebGLObject::context): (WebCore::WebGLObject::isBuffer): (WebCore::WebGLObject::isFramebuffer): (WebCore::WebGLObject::isProgram): (WebCore::WebGLObject::isRenderbuffer): (WebCore::WebGLObject::isShader): (WebCore::WebGLObject::isTexture):
  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::deleteObjectImpl):
  • html/canvas/WebGLProgram.h: (WebCore::WebGLProgram::~WebGLProgram): (WebCore::WebGLProgram::isLinkFailureFlagSet): (WebCore::WebGLProgram::setLinkFailureFlag): (WebCore::WebGLProgram::isProgram):
  • html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::deleteObjectImpl):
  • html/canvas/WebGLRenderbuffer.h: (WebCore::WebGLRenderbuffer::~WebGLRenderbuffer): (WebCore::WebGLRenderbuffer::setInternalFormat): (WebCore::WebGLRenderbuffer::getInternalFormat): (WebCore::WebGLRenderbuffer::isInitialized): (WebCore::WebGLRenderbuffer::setInitialized): (WebCore::WebGLRenderbuffer::isRenderbuffer):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::beginPaint): (WebCore::WebGLRenderingContext::blendEquation): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getBufferParameter): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::vertexAttribPointer):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::is3d): (WebCore::WebGLRenderingContext::isAccelerated): (WebCore::WebGLRenderingContext::graphicsContext3D): (WebCore::WebGLRenderingContext::cleanupAfterGraphicsCall): (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState): (WebCore::WebGLRenderingContext::VertexAttribState::initValue):
  • html/canvas/WebGLShader.cpp: (WebCore::WebGLShader::deleteObjectImpl):
  • html/canvas/WebGLShader.h: (WebCore::WebGLShader::~WebGLShader): (WebCore::WebGLShader::getType): (WebCore::WebGLShader::isShader):
  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::deleteObjectImpl):
  • html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::~WebGLTexture): (WebCore::WebGLTexture::isCubeMapRWrapModeInitialized): (WebCore::WebGLTexture::setCubeMapRWrapModeInitialized): (WebCore::WebGLTexture::isTexture): (WebCore::WebGLTexture::LevelInfo::LevelInfo): (WebCore::WebGLTexture::LevelInfo::setInfo):
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): (WebCore::GraphicsContext3D::Attributes::Attributes): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::platformLayer):
11:19 AM Changeset in webkit [64766] by jianli@chromium.org
  • 19 edits in trunk/LayoutTests

Update test results caused by r64763.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/script-tests/constructed-objects-prototypes.js:

(constructorPropertiesOnWindow):

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/Skipped:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
11:12 AM WebKitGTK edited by Martin Robinson
Small language cleanup (diff)
11:03 AM Changeset in webkit [64765] by andersca@apple.com
  • 3 edits
    3 adds in trunk/WebKit2

Add shared memory abstraction
​https://bugs.webkit.org/show_bug.cgi?id=43535
<rdar://problem/8275295>

Reviewed by Adam Roben.

  • Platform/SharedMemory.h: Added.

(WebKit::SharedMemory::):
(WebKit::SharedMemory::size):
Return the size, in bytes, of the shared memory object.

(WebKit::SharedMemory::data):
Return a pointer to the shared memory object.

  • Platform/mac/SharedMemoryMac.cpp: Added.

(WebKit::SharedMemory::Handle):
A shared memory handle, which can be passed in a CoreIPC Connection.

(WebKit::SharedMemory::create):
Allocate the shared memory.

(WebKit::SharedMemory::~SharedMemory):
Deallocate the shared memory.

(WebKit::SharedMemory::createHandle):
Create a mach port and pass it to the handle.

(WebKit::SharedMemory::systemPageSize):
Return the system page size, in bytes.

  • Platform/win/SharedMemoryWin.cpp: Added.

Add stubbed out version.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add files.

10:50 AM Changeset in webkit [64764] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-08-05 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Make the viewport meta tag parser support the Android
target-densitydpi extension.
​http://webkit.org/b/43492

​http://developer.android.com/reference/android/webkit/WebView.html
Section 'Building web pages to support different screen densities'

  • dom/ViewportArguments.cpp: (WebCore::setViewportFeature): (WebCore::viewportErrorMessageTemplate):
  • dom/ViewportArguments.h: (WebCore::): (WebCore::ViewportArguments::ViewportArguments): (WebCore::ViewportArguments::hasCustomArgument):
10:42 AM Changeset in webkit [64763] by jianli@chromium.org
  • 49 edits in trunk

Unify blob related feature defines to ENABLE(BLOB).
​https://bugs.webkit.org/show_bug.cgi?id=43081

Reviewed by David Levin.

.:

  • cmakeconfig.h.cmake:
  • configure.ac:

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:
  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • dom/ExceptionCode.h:

(WebCore::):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • html/Blob.cpp:
  • html/Blob.h:
  • html/Blob.idl:
  • html/FileError.h:
  • html/FileError.idl:
  • html/FileReader.cpp:
  • html/FileReader.h:
  • html/FileReader.idl:
  • html/FileStream.cpp:

(WebCore::FileStream::openForRead):

  • html/FileStream.h:
  • html/FileStreamClient.h:
  • html/FileStreamProxy.cpp:
  • html/FileStreamProxy.h:
  • html/FileThread.cpp:
  • html/FileThread.h:
  • page/DOMWindow.idl:
  • platform/BlobItem.cpp:

(WebCore::getFileSnapshotModificationTime):
(WebCore::DataBlobItem::slice):
(WebCore::FileBlobItem::slice):

  • platform/BlobItem.h:
  • platform/network/FormData.cpp:

(WebCore::FormData::deepCopy):
(WebCore::FormData::appendFile):
(WebCore::FormData::appendItem):
(WebCore::FormData::appendKeyValuePairItems):

  • platform/network/FormData.h:

(WebCore::operator==):

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::closeCurrentStream):
(WebCore::advanceCurrentStream):
(WebCore::formCreate):
(WebCore::formRead):
(WebCore::setHTTPBody):

WebKit/chromium:

  • features.gypi:
  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFileRange):

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

WebKitTools:

  • Scripts/build-webkit:
10:25 AM Changeset in webkit [64762] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
10:14 AM Changeset in webkit [64761] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-05 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Remove GHashTable left-overs. GHashTable is ref-counted, and is
correctly supported by GRefPtr.

  • wtf/gobject/GOwnPtr.h:
10:06 AM Changeset in webkit [64760] by kov@webkit.org
  • 2 edits in trunk

2010-08-05 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Move files that are generated by the configure script to
DISTCLEANFILES, where they should be. This fixes building after a
make clean.

  • GNUmakefile.am:
10:06 AM Changeset in webkit [64759] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-05 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed.

Typo fix that makes distcheck happy.

  • GNUmakefile.am:
9:57 AM Changeset in webkit [64758] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

When trying to wrap a Node we know is an Element fallback to a
simple Element wrapper in the worst case, not to Node.

  • bindings/gobject/WebKitDOMBinding.cpp: (WebKit::createWrapper):
9:52 AM Changeset in webkit [64757] by jorlow@chromium.org
  • 17 edits
    13 adds in trunk/LayoutTests

2010-08-05 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Updated test expectations for speech input in the chromium port
​https://bugs.webkit.org/show_bug.cgi?id=43563

  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.checksum:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
9:30 AM Changeset in webkit [64756] by thakis@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-05 Nico Weber <​thakis@chromium.org>

Reviewed by Jeremy Orlow.

Remove useless const on return-by-value (fixes a clang warning)
​https://bugs.webkit.org/show_bug.cgi?id=43491

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformKeyboardEventType):
9:23 AM Debugging With Visual Studio edited by Adam Roben
(diff)
9:10 AM Debugging With Visual Studio edited by Adam Roben
(diff)
9:07 AM Debugging With Visual Studio edited by Adam Roben
(diff)
9:00 AM Debugging With Visual Studio created by Adam Roben
8:58 AM Changeset in webkit [64755] by abecsi@webkit.org
  • 2 edits in trunk/WebKit2

2010-08-05 Balazs Kelemen <​kb@inf.u-szeged.hu>

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Remove redundant include paths from WebKit2.pro.

  • WebKit2.pro:
8:55 AM Changeset in webkit [64754] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Jeremy Orlow <​jorlow@chromium.org>

Don't skip speech tests.

  • platform/chromium/test_expectations.txt:
8:43 AM WikiStart edited by Adam Roben
(diff)
8:33 AM Changeset in webkit [64753] by commit-queue@webkit.org
  • 8 edits in trunk

2010-08-05 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Add test for basic values of the MathML mathvariant attribute
​https://bugs.webkit.org/show_bug.cgi?id=43481

  • mathml/presentation/attributes.xhtml:
  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:

2010-08-05 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Implement basic values of MathML mathvariant attribute
​https://bugs.webkit.org/show_bug.cgi?id=43481

Test: mathml/presentation/attributes.xhtml

  • css/mathml.css: (math[mathvariant="normal"], mstyle[mathvariant="normal"], mo[mathvariant="normal"], mn[mathvariant="normal"], mi[mathvariant="normal"], mtext[mathvariant="normal"], mspace[mathvariant="normal"], ms[mathvariant="normal"]): (math[mathvariant="bold"], mstyle[mathvariant="bold"], mo[mathvariant="bold"], mn[mathvariant="bold"], mi[mathvariant="bold"], mtext[mathvariant="bold"], mspace[mathvariant="bold"], ms[mathvariant="bold"]): (math[mathvariant="italic"], mstyle[mathvariant="italic"], mo[mathvariant="italic"], mn[mathvariant="italic"], mi[mathvariant="italic"], mtext[mathvariant="italic"], mspace[mathvariant="italic"], ms[mathvariant="italic"]): (math[mathvariant="bold-italic"], mstyle[mathvariant="bold-italic"], mo[mathvariant="bold-italic"], mn[mathvariant="bold-italic"], mi[mathvariant="bold-italic"], mtext[mathvariant="bold-italic"], mspace[mathvariant="bold-italic"], ms[mathvariant="bold-italic"]):
  • mathml/mathattrs.in:
8:29 AM Changeset in webkit [64752] by xan@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-08-05 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Use correct path for Inspector data files in GTK+3.x builds
​https://bugs.webkit.org/show_bug.cgi?id=43445

Use the right data path for inspector files when building with
GTK+ 3.x.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend):
8:16 AM Changeset in webkit [64751] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
7:48 AM Changeset in webkit [64750] by Nikolas Zimmermann
  • 1 edit
    2 adds in trunk/LayoutTests

2010-08-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add missing pixel test results for svg/in-html test.

  • platform/mac/svg/in-html/circle-expected.checksum: Added.
  • platform/mac/svg/in-html/circle-expected.png: Added.
7:40 AM Changeset in webkit [64749] by jorlow@chromium.org
  • 17 edits
    7 adds in trunk

2010-08-05 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Add speech input controller mock in WebKit and a layout test.
​https://bugs.webkit.org/show_bug.cgi?id=43477

  • fast/speech/input-text-speechbutton-expected.txt: Added.
  • fast/speech/input-text-speechbutton.html: Added.
  • fast/speech/script-tests/input-text-speechbutton.js: Added. (onChange): (run):

2010-08-05 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Add speech input controller mock in WebKit and a layout test.
​https://bugs.webkit.org/show_bug.cgi?id=43477

  • WebKit.gyp:
  • public/WebSpeechInputControllerMock.h: Added WebKit speech input controller mock interface.
  • src/WebSpeechInputControllerMockImpl.cpp: Added implementation of the above mock. (WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl): (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecording): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecognition): (WebKit::WebSpeechInputControllerMockImpl::setRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition): (WebKit::WebSpeechInputControllerMockImpl::cancelRecognition): (WebKit::WebSpeechInputControllerMockImpl::stopRecording): (WebKit::WebSpeechInputControllerMock::create):

2010-08-05 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Add speech input controller mock in WebKit and a layout test.
​https://bugs.webkit.org/show_bug.cgi?id=43477

Added LayoutTestController::setMockSpeechInputResultCallback method.

  • DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback): Wrapper invoking the member function. (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setMockSpeechInputResult): Sets the mock result. (LayoutTestController::speechInputController): Creates the mock controller.
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::speechInputController): Creates the mock controller.
  • DumpRenderTree/chromium/WebViewHost.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult): dummy method.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult): dummy method.
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult): dummy method.
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method. (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method. (LayoutTestController::setMockSpeechInputResult):
7:39 AM Changeset in webkit [64748] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Skip new debugger test on Qt.

  • platform/qt/Skipped:
7:32 AM Changeset in webkit [64747] by yurys@chromium.org
  • 3 edits
    2 adds in trunk

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspected page crashes when there is a cyclic reference in Object prototype
​https://bugs.webkit.org/show_bug.cgi?id=43558

Test: inspector/debugger-cyclic-ref.html

  • bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue):

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspected page crashes when there is a cyclic reference in Object prototype
​https://bugs.webkit.org/show_bug.cgi?id=43558

  • inspector/debugger-cyclic-ref-expected.txt: Added.
  • inspector/debugger-cyclic-ref.html: Added.
7:28 AM Changeset in webkit [64746] by jorlow@chromium.org
  • 10 edits
    3 moves
    14 adds
    4 deletes in trunk

2010-08-05 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Fix rendering of speech button and enable layout tests
​https://bugs.webkit.org/show_bug.cgi?id=43425

Added layout and pixel test expecations for speech button on chromium-linux and chromium-mac.
Also enabled the relevant layout tests on these platforms.
Non chromium ports don't have the feature flag enabled and the code does not get compiled in yet,
so there are no test expectations for those ports.

  • fast/speech/input-appearance-numberandspeech-expected.txt: Removed.
  • fast/speech/input-appearance-numberandspeech.html:
  • fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
  • fast/speech/input-appearance-searchandspeech.html:
  • fast/speech/input-appearance-speechbutton-expected.txt: Removed.
  • fast/speech/input-appearance-speechbutton.html:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/input-appearance-numberandspeech-expected.checksum: Removed.
  • platform/mac/fast/forms/input-appearance-numberandspeech-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-speechbutton-expected.checksum: Removed.
  • platform/mac/fast/forms/input-appearance-speechbutton-expected.png: Removed.

2010-08-05 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Fix rendering of speech button and enable layout tests
​https://bugs.webkit.org/show_bug.cgi?id=43425

Rewrote the speech button rendering code to match how the spin buttons (for input type=number)
are implemented as the previous implementation did not work well on many platforms.

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::createSpeechButtonStyle): (WebCore::RenderTextControlSingleLine::clientPaddingRight):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::create):
  • rendering/TextControlInnerElements.h:
7:23 AM Changeset in webkit [64745] by commit-queue@webkit.org
  • 7 edits in trunk

2010-08-05 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Re-enabling inspector/extension* tests following a fix in InspectorController.
​https://bugs.webkit.org/show_bug.cgi?id=43344

  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-08-05 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Separated WebInspector extension API injection logic from other scripts that inspector injects.
Enabled injection of the API scripts even if inspector is disabled for inspector front-end page.
​https://bugs.webkit.org/show_bug.cgi?id=43344

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::setInspectorExtensionAPI):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
7:16 AM QtScript edited by kent.hansen@nokia.com
(diff)
7:02 AM Changeset in webkit [64744] by Adam Roben
  • 11 edits in trunk

Get WebKitTestRunner loading TestNetscapePlugin on Windows

Fixes <​http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
load TestNetscapePlugin

Reviewed by Jon Honeycutt.

WebKit2:

Teach WebKit2 how to load the TestNetscapePlugin

  • Platform/Module.cpp:

(WebKit::Module::Module): Initialize m_module on Windows.

  • Platform/Module.h: Added m_module on Windows.
  • Platform/win/ModuleWin.cpp:

(WebKit::Module::load): Implemented using ::LoadLibraryExW.
(WebKit::Module::unload): Implemented using ::FreeLibrary.
(WebKit::Module::platformFunctionPointer): Implemented using
::GetProcAddress.

  • Platform/win/RunLoopWin.cpp:

(RunLoop::TimerBase::timerFired): Kill the native timer before calling
the fired callback. This makes all our timers non-repeating, but
that's all we need currently.
(RunLoop::TimerBase::start): Added an assertion to help us figure out
when we need to implement repeating timers. Also fixed a typo.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::pluginsDirectories): Added a FIXME.

(WebKit::PathWalker::PathWalker):
(WebKit::PathWalker::~PathWalker):
(WebKit::PathWalker::isValid):
(WebKit::PathWalker::data):
(WebKit::PathWalker::step):
Added. This class wraps the ::FindFirstFile/::FindNextFile APIs.

(WebKit::PluginInfoStore::pluginPathsInDirectory): Implemented by
porting logic from
WebCore::PluginDatabase::getPluginPathsInDirectories.
(WebKit::getVersionInfo): Copied from PluginDatabaseWin.cpp.
(WebKit::PluginInfoStore::getPluginInfo): Implemented by porting logic
from WebCore::PluginPackage::fetchInfo.
(WebKit::PluginInfoStore::shouldUsePlugin): Changed to always return
true for now. Added a FIXME about implementing this for real.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Removed PLATFORM(MAC) guards around plugin code.

  • win/WebKit2.vcproj: Let VS sort the file.

WebKitTools:

Fix the path to TestNetscapePlugin's directory on Windows

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::initializeTestPluginDirectory):
TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
next to WebKitTestRunner.exe. Previously we were passing the directory
that contains WebKitTestRunner.exe. Also fixed some leaks.

6:41 AM Changeset in webkit [64743] by commit-queue@webkit.org
  • 6 edits in trunk/WebKitTools

2010-08-05 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Shinichiro Hamaji.

check-webkit-style returns non-zero when patch is entirely minus lines.
​https://bugs.webkit.org/show_bug.cgi?id=38169

  • Scripts/check-webkit-style: Check whether a patch contains modified files that are entirely minus lines.
  • Scripts/webkitpy/style/filereader.py: Add a variable that holds number of files that contain only deleted lines.
  • Scripts/webkitpy/style/patchreader.py: Count up modified files that contain only deleted lines.
6:30 AM Changeset in webkit [64742] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: [REGRESSION] Frame navigation is not handled in devtools.

​https://bugs.webkit.org/show_bug.cgi?id=43556

  • src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::frontendLoaded): (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled):
6:27 AM Changeset in webkit [64741] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. More chromium test rebaselines.

  • platform/chromium/test_expectations.txt:
6:19 AM Changeset in webkit [64740] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-08-05 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=43469
<noscript> is working wrong in some cases when xhtmlmp is enabled.

  • fast/xhtmlmp/noscript-basic-expected.txt: Added.
  • fast/xhtmlmp/noscript-basic.xhtml: Added.

2010-08-05 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

<noscript> is working the other way around in some cases with xhtmlmp enabled
​https://bugs.webkit.org/show_bug.cgi?id=43469

Test: fast/xhtmlmp/noscript-basic.xhtml

  • dom/Document.cpp: (WebCore::Document::Document):
6:05 AM QtWebKitWeeklyBuilds edited by Simon Hausmann
(diff)
5:58 AM Changeset in webkit [64739] by antti.j.koivisto@nokia.com
  • 3 edits in trunk/WebKit2

Use toCopiedRef for making WK objects
​https://bugs.webkit.org/show_bug.cgi?id=43552

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/cpp/qt/WKStringQt.cpp:

(WKStringCreateWithQString):

  • UIProcess/API/cpp/qt/WKURLQt.cpp:

(WKURLCreateWithQUrl):

5:50 AM Changeset in webkit [64738] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Fix Win compilation.

  • bindings/js/JSBindingsAllInOne.cpp:
5:44 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:40 AM Changeset in webkit [64737] by Simon Hausmann
  • 6 edits in trunk

[Qt] Clean up the input method handling
​https://bugs.webkit.org/show_bug.cgi?id=43545

Reviewed by Tor Arne Vestbø.

WebCore:

Changed input method hint interface to be more efficient by setting
all hints in one shot, like in QWidget.

  • platform/qt/QWebPageClient.h:

WebKit/qt:

Replace the way of individually setting input method hints by
many calls to QWidget::setInputMethodHints with one single call.

This is more efficient by requiring less updates in the input
method hint.

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::setInputMethodHints):
(WebCore::PageClientQGraphicsWidget::setInputMethodHints):

  • WebCoreSupport/PageClientQt.h:
5:37 AM Changeset in webkit [64736] by pfeldman@chromium.org
  • 2 edits
    10 adds
    1 delete in trunk/LayoutTests

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. More chromium test rebaselines.

  • platform/chromium-linux/svg/in-html/circle-expected.checksum: Added.
  • platform/chromium-linux/svg/in-html/circle-expected.png: Added.
  • platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-mac/svg/in-html/circle-expected.checksum: Added.
  • platform/chromium-mac/svg/in-html/circle-expected.png: Added.
  • platform/chromium-win/svg/in-html/circle-expected.checksum: Added.
  • platform/chromium-win/svg/in-html/circle-expected.png: Added.
  • platform/chromium-win/svg/in-html/circle-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:36 AM Changeset in webkit [64735] by yurys@chromium.org
  • 17 edits
    4 deletes in trunk/WebCore

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove mutator methods from ScriptObject and remove ScriptArray.
We shouldn't modify JS objects from InspectorController, InspectorValues
should be used instead.
​https://bugs.webkit.org/show_bug.cgi?id=43546

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptArray.cpp: Removed.
  • bindings/js/ScriptArray.h: Removed.
  • bindings/js/ScriptCallStack.h:
  • bindings/js/ScriptObject.cpp:
  • bindings/js/ScriptObject.h:
  • bindings/v8/ScriptArray.cpp: Removed.
  • bindings/v8/ScriptArray.h: Removed.
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptObject.cpp:
  • bindings/v8/ScriptObject.h:
4:54 AM Changeset in webkit [64734] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-08-05 Ned Holbrook <​nholbrook@apple.com>

Reviewed by Darin Adler.

~5% complex layout performance improvement.
​https://bugs.webkit.org/show_bug.cgi?id=43436

  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Use Vector rather than CFMutableData. (WebCore::ComplexTextController::ComplexTextRun::createTextRunFromFontDataCoreText): Ditto. (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Avoid typesetter allocation unless using typesetter options.
4:34 AM Changeset in webkit [64733] by johnnyg@google.com
  • 2 edits in trunk/WebKit/chromium

2010-08-05 John Gregg <​johnnyg@google.com>

Reviewed by Darin Fisher.

[chromium] WebFileChooserParams should have default constructor
​https://bugs.webkit.org/show_bug.cgi?id=43435

  • public/WebFileChooserParams.h: (WebKit::WebFileChooserParams::WebFileChooserParams):
4:24 AM MathML 3 testsuite results edited by François Sausset
(diff)
4:19 AM Changeset in webkit [64732] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-08-05 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

targetReferenceFromResource() in SVGResources.cpp is missing an ENABLE(FILTERS) guard
​https://bugs.webkit.org/show_bug.cgi?id=43550

Also updates an existing ENABLE(FILTERS) guard to avoid a compiler
warning 'case FilterResourceType not handled in switch' when FILTERS
is not enabled.

No new tests, build fix only.

  • rendering/SVGResources.cpp: (WebCore::targetReferenceFromResource): (WebCore::SVGResources::resourceDestroyed):
4:15 AM Changeset in webkit [64731] by commit-queue@webkit.org
  • 5 edits in trunk

2010-08-05 Victoria Kirst <​vrk@google.com>

Reviewed by David Levin.

Added logic to use glMapTexSubImage2D to write video layer to GPU
texture. Also fixes CPU usage problem from previous patch.
​https://bugs.webkit.org/show_bug.cgi?id=43101

No change in user-visible functionality (since it isn't turned on),
so no new tests.

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateTextureContents): (WebCore::VideoLayerChromium::createTextureRect): (WebCore::VideoLayerChromium::updateTextureRect): (WebCore::VideoLayerChromium::updateCompleted):
  • platform/graphics/chromium/VideoLayerChromium.h:

2010-08-05 Victoria Kirst <​vrk@google.com>

Reviewed by David Levin.

Added a repaint request so that VideoLayerChromium does not have
a flickering problem when playing video.
​https://bugs.webkit.org/show_bug.cgi?id=43101

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::repaint):
3:55 AM Changeset in webkit [64730] by pfeldman@chromium.org
  • 26 edits
    3 adds in trunk/LayoutTests

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium expectations update.

3:00 AM Changeset in webkit [64729] by pfeldman@chromium.org
  • 14 edits in trunk

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

DevTools: get rid of delayed command dispatching on front-end side.

​https://bugs.webkit.org/show_bug.cgi?id=43479

  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendFrontendLoaded):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::frontendLoaded):
  • src/WebDevToolsAgentImpl.h:
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend): (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
  • src/WebDevToolsFrontendImpl.h:
  • src/js/DevTools.js: (WebInspector.doLoadedDone):
  • src/js/Tests.js: (.uiTests.runTest):

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

DevTools: get rid of delayed command dispatching on front-end side.

​https://bugs.webkit.org/show_bug.cgi?id=43479

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::detach): (DRTDevToolsAgent::frontendLoaded):
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::~DRTDevToolsClient): (DRTDevToolsClient::sendFrontendLoaded):
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
2:56 AM Changeset in webkit [64728] by pfeldman@chromium.org
  • 141 edits
    39 adds in trunk/LayoutTests

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rebaselined a bunch of chromium layout tests after the parser switch.

​https://bugs.webkit.org/show_bug.cgi?id=43547

2:25 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
2:25 AM Changeset in webkit [64727] by Simon Hausmann
  • 1 edit in trunk/WebKit/qt/tests/qwebview/tst_qwebview.cpp

Remove stray debug output

2:25 AM Changeset in webkit [64726] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Simon Hausmann.

Allow custom memory allocation control for ClipperData struct
​https://bugs.webkit.org/show_bug.cgi?id=43337

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

class name - instantiated at: WebCore/'location'
RenderLayerBacking - rendering/RenderSVGResourceClipper.cpp:165

  • rendering/RenderSVGResourceClipper.h:
2:19 AM Changeset in webkit [64725] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

[Qt] Input mode states are not reset after entering a password field
​https://bugs.webkit.org/show_bug.cgi?id=43530

Patch by David Leong <​david.leong@nokia.com> on 2010-08-05
Reviewed by Simon Hausmann.

Input mode hints are not reset if clicking on password <input> elements then
clicking on <textarea> elements

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

  • tests/qwebview/resources/input_types.html:
  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::focusInputTypes):

2:06 AM Changeset in webkit [64724] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Simon Hausmann.

Allow custom memory allocation control for DoctypeData class
​https://bugs.webkit.org/show_bug.cgi?id=43343

Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'
DoctypeData - html/HTMLToken.h:113

  • html/HTMLToken.h:
1:45 AM Changeset in webkit [64723] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 François Sausset <François Sausset>

Reviewed by Darin Adler.

Small style adjustments for MathML merror element.
​https://bugs.webkit.org/show_bug.cgi?id=43432

  • css/mathml.css: (merror):
1:31 AM Changeset in webkit [64722] by yurys@chromium.org
  • 12 edits in trunk/WebCore

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: forbid InspectorController to create script objects directly in the frontend
​https://bugs.webkit.org/show_bug.cgi?id=43541

Cookie and AppCache data are now serialized into InspectorValues instead of
ScriptObjects. These were last usages of InspectorFrontend::newScript{Object,Array}
so we can remove them now and use only InspectorValues to pass data to the inspector
frontend.

  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache): (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::buildArrayForCookies): (WebCore::InspectorController::buildObjectForCookie):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::setRecordingProfile):
  • inspector/InspectorFrontend.h:
12:55 AM Changeset in webkit [64721] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] Extra check needed at AccessibilityObject::visiblePositionRangeForRange
​https://bugs.webkit.org/show_bug.cgi?id=43418

Ensure the renderer is a RenderText before calling toRenderText()

Also, simplified code a bit to avoid so many nested if's in that
part of the code, while keeping the same logic.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::visiblePositionRangeForRange):
12:36 AM Changeset in webkit [64720] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Define htonl, htons, ntohl and ntohs
​https://bugs.webkit.org/show_bug.cgi?id=43397

In BREWMP, AEEStdLib.h provides macros for byte order conversion: HTONL, HTONS, NTOHL and NTOHS.
Use these macros to define htonl, htons, ntohl and ntohs used by WOFFFileFormat.cpp.

  • platform/graphics/WOFFFileFormat.cpp:
12:11 AM Changeset in webkit [64719] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Adam Barth <​abarth@webkit.org>

residual-style-hang times out on Gtk
​https://bugs.webkit.org/show_bug.cgi?id=43540

Skip fast/parser/residual-style-hang.html on Gtk. Hopefully someone
with access to a Gtk machine can help us understand why this is
hanging. There's (a little) more information in the bug page.

  • platform/gtk/Skipped:
12:11 AM Changeset in webkit [64718] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-04 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Shinichiro Hamaji.

Fixes check-webkit-style false positive on "new uint32_t."
​https://bugs.webkit.org/show_bug.cgi?id=43077

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
12:01 AM Changeset in webkit [64717] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-08-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a test for SVG-in-HTML
​https://bugs.webkit.org/show_bug.cgi?id=43539

Just a basic test that we can render SVG in HTML.

  • platform/mac/svg/in-html/circle-expected.txt: Added.
  • svg/in-html/circle.html: Added.

Aug 4, 2010:

11:44 PM Changeset in webkit [64716] by zherczeg@webkit.org
  • 10 edits
    80 adds in trunk

SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
​https://bugs.webkit.org/show_bug.cgi?id=42244

Reviewed by Nikolas Zimmermann.

WebCore:

Implementing svgAttributeChanged for SVGFESpotLightElement object.
Furthermore, invalidateFilter has been moved to SVGFilterElement, and
it is a static function now.

Tests: svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr.html

svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop.html

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::svgAttributeChanged):
(WebCore::SVGFELightElement::childrenChanged):

  • svg/SVGFELightElement.h:
  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::svgAttributeChanged):

  • svg/SVGFESpecularLightingElement.cpp:
  • svg/SVGFilterElement.h:

(WebCore::SVGFilterElement::invalidateFilter):

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):

  • svg/SVGFilterPrimitiveStandardAttributes.h:

LayoutTests:

  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop.html: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-limitingConeAngle-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-pointsAtX-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-pointsAtY-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-pointsAtZ-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-specularExponent-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-x-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-z-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-limitingConeAngle-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-pointsAtX-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-pointsAtY-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-pointsAtZ-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-specularExponent-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-x-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-y-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-z-prop.js: Added.

(executeTest):

11:38 PM Changeset in webkit [64715] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-04 Adam Barth <​abarth@webkit.org>

Enable HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=42804

Update expected results for Leopard.

  • platform/mac-leopard/fast/forms/file-input-disabled-expected.txt:
11:15 PM Changeset in webkit [64714] by abarth@webkit.org
  • 7 edits in trunk/LayoutTests

2010-08-04 Adam Barth <​abarth@webkit.org>

Enable HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=42804

Update expected results for Qt. These results look correct vis-a-vis
the Mac changes.

  • platform/qt/fast/block/float/4145535Crash-expected.txt:
  • platform/qt/fast/dom/isindex-001-expected.txt:
  • platform/qt/fast/forms/isindex-placeholder-expected.txt:
  • platform/qt/fast/forms/text-style-color-expected.txt:
  • platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
11:00 PM Changeset in webkit [64713] by yurys@chromium.org
  • 7 edits in trunk/WebCore

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: serialize DOM storage items to InspectorValues
​https://bugs.webkit.org/show_bug.cgi?id=43486

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::selectDOMStorage): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::removeDOMStorageItem):
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
  • inspector/InspectorDOMStorageResource.h:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
10:57 PM Changeset in webkit [64712] by abarth@webkit.org
  • 90 edits in trunk

2010-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Enable HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=42804

Lots of crazy changes. As far as we can tell, these
are all progressions/match minefield. For a more in-depth,
per-test breakdown see the spreadsheet:
​http://spreadsheets.google.com/ccc?key=0AlC4tS7Ao1fIdEo0SFdLaVpiclBHMVNQcHlTenV5TEE

  • dom/html/level2/html/HTMLIsIndexElement01-expected.txt: Expected, <isindex> now gets converted into a <form><input> tree.
  • dom/html/level2/html/HTMLIsIndexElement02-expected.txt:
  • dom/html/level2/html/HTMLIsIndexElement03-expected.txt:
  • editing/execCommand/indent-div-inside-list-expected.txt:
  • fast/dom/HTMLLabelElement/label-control-expected.txt:
  • fast/dom/attribute-case-sensitivity-expected.txt:
  • fast/dom/no-elements-expected.txt:
  • fast/events/tabindex-focus-blur-all-expected.txt:
  • fast/forms/datalist-nonoption-child-expected.txt:
  • fast/lists/ol-nested-items-expected.txt:
  • fast/parser/remove-current-node-parent-expected.txt:
  • fast/parser/residual-style-dom-expected.txt:
  • fast/parser/residual-style-hang-expected.txt:
  • html5lib/runner-expected.txt: massive progression
  • html5lib/webkit-resumer-expected.txt: massive progression.
  • http/tests/misc/isindex-formdata-expected.txt:
  • http/tests/misc/isindex-with-no-form-base-href-expected.txt:
  • http/tests/xmlhttprequest/close-window-expected.txt:
  • platform/mac/editing/selection/designmode-no-caret-expected.txt:
  • platform/mac/fast/block/float/4145535Crash-expected.txt:
  • platform/mac/fast/block/float/float-in-float-painting-expected.txt:
  • platform/mac/fast/dom/isindex-001-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/events/focusingUnloadedFrame-expected.txt:
  • platform/mac/fast/forms/file-input-disabled-expected.txt:
  • platform/mac/fast/forms/form-added-to-table-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/form-in-malformed-markup-expected.txt:
  • platform/mac/fast/forms/formmove3-expected.txt:
  • platform/mac/fast/forms/isindex-placeholder-expected.txt:
  • platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/mac/fast/forms/text-style-color-expected.txt:
  • platform/mac/fast/invalid/004-expected.txt:
  • platform/mac/fast/invalid/005-expected.txt:
  • platform/mac/fast/invalid/007-expected.txt:
  • platform/mac/fast/invalid/012-expected.txt:
  • platform/mac/fast/invalid/017-expected.txt:
  • platform/mac/fast/invalid/018-expected.txt:
  • platform/mac/fast/invalid/019-expected.txt:
  • platform/mac/fast/invalid/missing-address-end-tag-expected.txt:
  • platform/mac/fast/invalid/missing-font-end-tag-expected.txt:
  • platform/mac/fast/invalid/residual-style-expected.txt:
  • platform/mac/fast/invalid/table-inside-stray-table-content-expected.txt:
  • platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
  • platform/mac/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
  • platform/mac/fast/parser/remove-block-in-residual-style-expected.txt:
  • platform/mac/fast/parser/title-error-test-expected.txt:
  • platform/mac/fast/table/fixed-table-non-cell-in-row-expected.txt:
  • platform/mac/fast/table/giantCellspacing-expected.txt:
  • platform/mac/fast/table/inline-form-assert-expected.txt:
  • platform/mac/fast/table/insert-cell-before-form-expected.txt:
  • platform/mac/fast/table/insert-row-before-form-expected.txt:
  • platform/mac/fast/text/large-text-composed-char-expected.txt:
  • platform/mac/fonts/cursive-expected.txt:
  • platform/mac/fonts/fantasy-expected.txt:
  • platform/mac/fonts/monospace-expected.txt:
  • platform/mac/fonts/sans-serif-expected.txt:
  • platform/mac/fonts/serif-expected.txt:
  • platform/mac/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug137388-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug137388-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2267-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2516-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2757-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug278385-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug32447-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug34538-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug48028-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug48028-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug53690-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96343-expected.txt:
  • platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
  • webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
  • webarchive/test-frameset-expected.webarchive:

2010-08-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Enable HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=42804

Months of work into a single line code change.
Geez. Should have thought of this sooner.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
10:51 PM Changeset in webkit [64711] by tkent@chromium.org
  • 3 edits
    3 adds in trunk

Spin-button behavior improvement for out-of-range values
​https://bugs.webkit.org/show_bug.cgi?id=43463

Reviewed by Darin Adler.

WebCore:

If the current value is smaller than the minimum value, the up
button should change the value to the minimum value. If the
current value is larger than the maximum value, the down button
should change the value to the maximum value.

Test: fast/forms/input-number-outofrange.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::stepUpFromRenderer):

LayoutTests:

  • fast/forms/input-number-outofrange-expected.txt: Added.
  • fast/forms/input-number-outofrange.html: Added.
  • fast/forms/script-tests/input-number-outofrange.js: Added.
10:20 PM Changeset in webkit [64710] by tkent@chromium.org
  • 4 edits in trunk/WebKitTools

2010-08-04 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Remove base/linked_ptr.h dependency
​https://bugs.webkit.org/show_bug.cgi?id=43472

Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
We need to use RefPtr<> because m_pendingEntry points an object in
m_entries or not in m_entries.

  • DumpRenderTree/chromium/TestNavigationController.cpp: (TestNavigationEntry::create): Added. (TestNavigationController::activeEntry): (TestNavigationController::didNavigateToEntry): (TestNavigationController::discardPendingEntry): (TestNavigationController::insertEntry): (TestNavigationController::navigateToPendingEntry):
  • DumpRenderTree/chromium/TestNavigationController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::loadURLForFrame): Use TestNavigationEntry::create(). (WebViewHost::updateURL): Use RefPtr<>. (WebViewHost::updateSessionHistory): Remove unnecessary static_cast<>.
10:19 PM Changeset in webkit [64709] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-04 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a problem that "archived test results" step doesn't work on Chromium buildbots
​https://bugs.webkit.org/show_bug.cgi?id=43333

  • BuildSlaveSupport/test-result-archive:
    • Make layoutTestResultsDir local and pass it to archiveTestResults()
    • Adjust layoutTestResultsDir for Chromium
10:17 PM Changeset in webkit [64708] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-04 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

NRWT: websocket_server startup detection failure
​https://bugs.webkit.org/show_bug.cgi?id=43466

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Increase timeout value: 5 second -> 10 second
9:55 PM Changeset in webkit [64707] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-04 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Add flaky tests on DRT/Chromium/Mac
9:52 PM Changeset in webkit [64706] by ggaren@apple.com
  • 4 edits
    3 adds in trunk

JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=43461
Invalid NaN parsing

Reviewed by Oliver Hunt and Beth Dakin.

  • wtf/dtoa.cpp: Turn off the dtoa feature that allows you to specify a

non-standard NaN representation, since our NaN encoding assumes that all
true NaNs have the standard bit pattern.

  • API/JSValueRef.cpp:

(JSValueMakeNumber): Don't allow an API client to accidentally specify
a non-standard NaN either.

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=43461
Crash parsing certain values for NaN

Reviewed by Oliver Hunt and Beth Dakin.

  • fast/js/parse-nan.html: Added.
  • fast/js/script-tests/parse-nan.js: Added.
8:27 PM Changeset in webkit [64705] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

2010-08-04 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Daniel Bates.

Remove superfluous non-negative checks in HitTestResult:padding{Width|Height}
​https://bugs.webkit.org/show_bug.cgi?id=43534

As pointed out by Steve Block in ​https://bugs.webkit.org/show_bug.cgi?id=40197#c54 ,
the non-negative checks present in both paddingWidth and paddingHeight methods of
HitTestResults class are superflous, after we changed the rect based hit testing logic
of invalid padding from IntSize(-1, -1) to IntSize(0, 0). Patch addresses this issue.

No new tests needed.

  • rendering/HitTestResult.h: (WebCore::HitTestResult::paddingWidth): (WebCore::HitTestResult::paddingHeight):
7:22 PM Changeset in webkit [64704] by abarth@webkit.org
  • 6 edits
    25 deletes in trunk

2010-08-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64674.
​http://trac.webkit.org/changeset/64674
​https://bugs.webkit.org/show_bug.cgi?id=43532

Doesn't work with HTML5 tree builder (Requested by tonyg-cr on
#webkit).

  • fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-double-defer-write.html: Removed.
  • fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-double-write.html: Removed.
  • fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-inline-script.html: Removed.
  • fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-onbeforeload.html: Removed.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Removed.
  • fast/dom/HTMLScriptElement/resources/defer.js: Removed.
  • fast/dom/HTMLScriptElement/resources/external.js: Removed.
  • fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Removed.
  • http/tests/misc/resources/defer-script.js: Removed.
  • http/tests/misc/resources/external-script.js: Removed.
  • http/tests/misc/resources/script-debug-body-background.js: Removed.
  • http/tests/misc/resources/script-write-slow-stylesheet.js: Removed.
  • http/tests/misc/resources/slow-defer-script.cgi: Removed.
  • http/tests/misc/resources/slow-stylesheet.cgi: Removed.
  • http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Removed.
  • http/tests/misc/script-defer-after-slow-stylesheet.html: Removed.
  • http/tests/misc/script-defer-expected.txt: Removed.
  • http/tests/misc/script-defer-write-slow-stylesheet-expected.txt: Removed.
  • http/tests/misc/script-defer-write-slow-stylesheet.html: Removed.
  • http/tests/misc/script-defer.html: Removed.

2010-08-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64674.
​http://trac.webkit.org/changeset/64674
​https://bugs.webkit.org/show_bug.cgi?id=43532

Doesn't work with HTML5 tree builder (Requested by tonyg-cr on
#webkit).

  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed):
  • html/HTMLDocumentParser.h:
  • html/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestScript): (WebCore::HTMLScriptRunner::runScript):
  • html/HTMLScriptRunner.h:
6:19 PM Changeset in webkit [64703] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix part II.

  • wtf/PageReservation.h:

(WTF::PageReservation::systemReserve):

6:10 PM Changeset in webkit [64702] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

fast/parser/residual-style-hang.html hangs
​https://bugs.webkit.org/show_bug.cgi?id=42950

Add a dump-as-markup test that shows what DOM we actually create in
this case.

Note: these results are for the existing parser.

  • fast/parser/residual-style-dom-expected.txt: Added.
  • fast/parser/residual-style-dom.html: Added.

2010-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

fast/parser/residual-style-hang.html hangs
​https://bugs.webkit.org/show_bug.cgi?id=42950

We need to cap the iteration of the adoption agency algorithm to
prevent this hang. The legacy tree builder does this as well.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
6:02 PM Changeset in webkit [64701] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix for chromium test expectations.

  • platform/chromium/test_expectations.txt: Removed incorrectly formatted line.
5:53 PM Changeset in webkit [64700] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • wtf/PageReservation.h:

(WTF::PageReservation::systemReserve):

5:36 PM Changeset in webkit [64699] by abarth@webkit.org
  • 4 edits in trunk

2010-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Pick up spec change w.r.t. figcaption and summary
​https://bugs.webkit.org/show_bug.cgi?id=43075

  • html5lib/runner-expected-html5.txt:

2010-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Pick up spec change w.r.t. figcaption and summary
​https://bugs.webkit.org/show_bug.cgi?id=43075

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInBody):
5:34 PM Changeset in webkit [64698] by abarth@webkit.org
  • 4 edits in trunk

2010-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Pick up spec change w.r.t. replacement character and <frameset>
​https://bugs.webkit.org/show_bug.cgi?id=43073

  • html5lib/runner-expected-html5.txt:

2010-08-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Pick up spec change w.r.t. replacement character and <frameset>
​https://bugs.webkit.org/show_bug.cgi?id=43073

Apparently this fixes parsing for some home router configuration pages.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCharacterBuffer):
5:31 PM Changeset in webkit [64697] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed change to Chromium test expectations to mark hyphenate-locale.html as failing.

  • platform/chromium/test_expectations.txt: mark hyphenate-locate.html as failing.
5:21 PM Changeset in webkit [64696] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Build fix - add new header to !Mac projects.

5:18 PM Changeset in webkit [64695] by barraclough@apple.com
  • 13 edits
    1 copy
    2 adds in trunk

JavaScriptCore: Bug 43515 - Fix small design issues with PageAllocation, split out PageReservation.

Reviewed by Sam Weinig.

The PageAllocation class has a number of issues:

  • Changes in bug #43269 accidentally switched SYMBIAN over to use malloc/free to allocate blocks of memory for the GC heap, instead of allocating RChunks. Revert this change in behaviour.
  • In order for PageAllocation to work correctly on WinCE we should be decommitting memory before deallocating. In order to simplify understanding the expected state at deallocate, split behaviour out into PageAllocation and PageReservation classes. Require that all memory be decommitted before calling deallocate on a PageReservation, add asserts to enforce this.
  • add many missing asserts.
  • inline more functions.
  • remove ability to create sub-PageAllocations from an existing PageAllocations object - this presented an interface that would allow sub regions to be deallocated, which would not have provided expected behaviour.
  • remove writable/executable arguments to commit, this value can be cached at the point the memory is reserved.
  • remove writable/executable arguments to allocateAligned, protection other than RW is not supported.
  • add missing checks for overflow & failed allocation to mmap path through allocateAligned.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::intializePageSize):

  • jit/ExecutableAllocator.h:

(JSC::ExecutablePool::Allocation::Allocation):
(JSC::ExecutablePool::Allocation::base):
(JSC::ExecutablePool::Allocation::size):
(JSC::ExecutablePool::Allocation::operator!):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::coalesceFreeSpace):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::allocInternal):

  • runtime/AlignedMemoryAllocator.h:

(JSC::::allocate):
(JSC::::AlignedMemoryAllocator):

  • runtime/Collector.cpp:

(JSC::Heap::allocateBlock):

  • runtime/Collector.h:
  • wtf/PageAllocation.cpp:
  • wtf/PageAllocation.h:

(WTF::PageAllocation::operator!):
(WTF::PageAllocation::allocate):
(WTF::PageAllocation::allocateAt):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::deallocate):
(WTF::PageAllocation::pageSize):
(WTF::PageAllocation::systemAllocate):
(WTF::PageAllocation::systemAllocateAt):
(WTF::PageAllocation::systemAllocateAligned):
(WTF::PageAllocation::systemDeallocate):
(WTF::PageAllocation::systemPageSize):

  • wtf/PageReservation.h: Copied from JavaScriptCore/wtf/PageAllocation.h.

(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::reserve):
(WTF::PageReservation::reserveAt):
(WTF::PageReservation::deallocate):
(WTF::PageReservation::systemCommit):
(WTF::PageReservation::systemDecommit):
(WTF::PageReservation::systemReserve):
(WTF::PageReservation::systemReserveAt):

  • wtf/Platform.h:

JavaScriptGlue: Bug 43515 - Fix small design issues with PageAllocation, split out PageReservation.
(add forwarding headers)

Reviewed by Sam Weinig.

  • ForwardingHeaders/wtf/Bitmap.h: Added.
  • ForwardingHeaders/wtf/PageReservation.h: Added.

WebCore: Bug 43515 - Fix small design issues with PageAllocation, split out PageReservation.
(add forwarding headers)

Reviewed by Sam Weinig.

  • ForwardingHeaders/wtf/Bitmap.h: Added.
  • ForwardingHeaders/wtf/PageReservation.h: Added.
5:13 PM Changeset in webkit [64694] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-04 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

[Qt] [QtTestBrowser] Remove unneeded QAction class members
​https://bugs.webkit.org/show_bug.cgi?id=43518

LauncherWindow class has two totally unneeded class members: m_flopAnimated and
m_flipYAnimated. Also, in initializeView method there are some dead code block
trying to connect them at the wrong time, when they have not been instanciated.

This patch:

  • removes the two cited class members in favor of local variables in createChrome method;
  • removes the dead code block.
  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::initializeView): (LauncherWindow::createChrome):
  • QtTestBrowser/launcherwindow.h:
5:12 PM Changeset in webkit [64693] by crogers@google.com
  • 20 edits
    3 copies in branches/audio/WebCore

Implement more carefully thought out JavaScriptAudioNode for direct JavaScript audio processing

  • works with a simple test case (amplitude modulation effect), but not heavily tested
  • can be routed together with other AudioNode objects for hybrid processing
  • the API still needs a little more work, but it's coming along
  • still may need V8 bindings work for Chrome
5:12 PM Changeset in webkit [64692] by crogers@google.com
  • 3 edits
    3 moves in branches/audio/WebCore

Change name of JavascriptAudioSourceNode to JavaScriptAudioNode

5:12 PM Changeset in webkit [64691] by tonikitoo@webkit.org
  • 1 edit in trunk/WebKitTools/QtTestBrowser/launcherwindow.cpp

2010-08-04 Antonio Gomes <​tonikitoo@webkit.org>

Unreviewed missing bit of r64673

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
5:12 PM Changeset in webkit [64690] by crogers@google.com
  • 20 edits in branches/audio/WebCore/audio

General random cleanup in audio branch

5:12 PM Changeset in webkit [64689] by crogers@google.com
  • 10 edits in branches/audio/WebCore/audio

Add create() methods for all the AudioNode objects

5:06 PM Changeset in webkit [64688] by beidson@apple.com
  • 11 edits
    3 adds in trunk/WebKit2

2010-08-04 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig.

Change callback APIs to include an Error object in one callback, instead of having a second callback for failure.
​https://bugs.webkit.org/show_bug.cgi?id=43522

This includes adding a WKErrorRef object which - for now - either exists or doesn't.
In the future, it may contain useful information about the error.


  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:


  • Shared/APIObject.h: (WebKit::APIObject::):
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:


  • Shared/WebError.h: Added. (WebKit::WebError::create): (WebKit::WebError::WebError): (WebKit::WebError::type):


  • UIProcess/API/C/WKError.cpp: Added. (WKErrorGetTypeID):
  • UIProcess/API/C/WKError.h: Added.


  • UIProcess/API/C/WKPage.cpp: (WKPageRunJavaScriptInMainFrame): (callRunJavaScriptBlockAndRelease): (WKPageRunJavaScriptInMainFrame_b): (WKPageRenderTreeExternalRepresentation): (callRenderTreeExternalRepresentationBlockAndDispose): (WKPageRenderTreeExternalRepresentation_b):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPagePrivate.h:


  • UIProcess/GenericCallback.h: (WebKit::GenericCallback::create): (WebKit::GenericCallback::performCallbackWithReturnValue): (WebKit::GenericCallback::invalidate): (WebKit::GenericCallback::GenericCallback):
4:50 PM Changeset in webkit [64687] by victorw@chromium.org
  • 8 edits
    3 adds in trunk/WebKitTools

2010-08-04 Victor Wang <​victorw@chromium.org>

Reviewed by Ojan Vafai.

-. Add result.json incremental merging functionality to test results app engine.
-. blobstore is not suitable for AE data merging and there is no API to

programatically edit existing blob or write a new one yet, so replace blobstore
with datastore. If file is oversize (>1000*1000 bytes), store file data in
multiple datastore entries.

-. Fix styles.

Test: jsonresults_unittest to test merging logics.

​https://bugs.webkit.org/show_bug.cgi?id=38599

  • TestResultServer/handlers/dashboardhandler.py:
  • TestResultServer/handlers/menu.py:
  • TestResultServer/handlers/testfilehandler.py:
  • TestResultServer/main.py:
  • TestResultServer/model/dashboardfile.py:
  • TestResultServer/model/datastorefile.py: Added.
  • TestResultServer/model/jsonresults.py: Added.
  • TestResultServer/model/jsonresults_unittest.py: Added.
  • TestResultServer/model/testfile.py:
  • TestResultServer/templates/uploadform.html:
4:13 PM Changeset in webkit [64686] by zmo@google.com
  • 2 edits in trunk/WebCore

2010-08-04 Zhenyao Mo <​zmo@google.com>

Reviewed by Adam Barth.

getAttachedShaders takes wrong parameter type in WebGLRenderingContext.idl
​https://bugs.webkit.org/show_bug.cgi?id=43517

  • html/canvas/WebGLRenderingContext.idl: Fix the wrong parameter type in getAttachedShaders().
3:48 PM Changeset in webkit [64685] by kbr@google.com
  • 23 edits
    2 moves in trunk/WebCore

2010-08-04 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Rename CanvasObject to WebGLObject
​https://bugs.webkit.org/show_bug.cgi?id=31564

Renamed CanvasObject to WebGLObject using do-webcore-rename script.
Because it seems the new convention is to not check in the changes
made to this script, only checking in its effects. No new tests;
built and ran WebGL in Safari and Chromium to test.

  • Android.mk:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasObject.cpp: Removed.
  • html/canvas/CanvasObject.h: Removed.
  • html/canvas/CanvasRenderingContext.h:
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::WebGLBuffer):
  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::setAttachment): (WebCore::WebGLFramebuffer::onAttachedObjectChange): (WebCore::WebGLFramebuffer::isUninitialized): (WebCore::WebGLFramebuffer::setInitialized):
  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLObject.cpp: Copied from WebCore/html/canvas/CanvasObject.cpp. (WebCore::WebGLObject::WebGLObject): (WebCore::WebGLObject::~WebGLObject): (WebCore::WebGLObject::setObject): (WebCore::WebGLObject::deleteObject):
  • html/canvas/WebGLObject.h: Copied from WebCore/html/canvas/CanvasObject.h.
  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::WebGLProgram):
  • html/canvas/WebGLProgram.h:
  • html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
  • html/canvas/WebGLRenderbuffer.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::objectOrZero): (WebCore::WebGLRenderingContext::validateWebGLObject): (WebCore::WebGLRenderingContext::removeObject): (WebCore::WebGLRenderingContext::addObject): (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects): (WebCore::WebGLRenderingContext::findTexture): (WebCore::WebGLRenderingContext::findRenderbuffer): (WebCore::WebGLRenderingContext::findBuffer): (WebCore::WebGLRenderingContext::findShader):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLShader.cpp: (WebCore::WebGLShader::WebGLShader):
  • html/canvas/WebGLShader.h:
  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::WebGLTexture):
  • html/canvas/WebGLTexture.h:
  • html/canvas/WebGLUniformLocation.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
3:21 PM Changeset in webkit [64684] by commit-queue@webkit.org
  • 15 edits in trunk

2010-08-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64655.
​http://trac.webkit.org/changeset/64655
​https://bugs.webkit.org/show_bug.cgi?id=43496

JavaScriptCore references patch seems to have caused
regressions in QT and GTK builds (Requested by nlawrence on
#webkit).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • runtime/Collector.cpp: (JSC::Heap::markConservatively):
  • runtime/JSCell.h: (JSC::JSValue::asCell): (JSC::MarkStack::append):
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object):
  • runtime/JSObject.h: (JSC::JSObject::prototype):
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
  • runtime/JSValue.h: (JSC::JSValue::): (JSC::JSValue::JSValue): (JSC::JSValue::asCell):
  • runtime/MarkStack.h:
  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeErrorConstructor.h:
  • runtime/Structure.h: (JSC::Structure::storedPrototype):

2010-08-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64655.
​http://trac.webkit.org/changeset/64655
​https://bugs.webkit.org/show_bug.cgi?id=43496

JavaScriptCore references patch seems to have caused
regressions in QT and GTK builds (Requested by nlawrence on
#webkit).

  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):
2:38 PM Changeset in webkit [64683] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • platform/text/mac/HyphenationMac.mm:

(WebCore::lastHyphenLocation):

2:34 PM Changeset in webkit [64682] by mitz@apple.com
  • 2 edits in trunk/WebCore

Release build fix.

  • platform/text/mac/HyphenationMac.mm:

(WebCore::lastHyphenLocation):

2:32 PM Changeset in webkit [64681] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Don't leak FontDescription objects inside MathML.

Reviewed by Sam Weinig.

  • mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement): Don't unnecessarily allocate the FontDescription on the heap.
(WebCore::RenderMathMLOperator::createStackableStyle): Ditto.

2:28 PM Changeset in webkit [64680] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-08-04 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Add ANGLE dependency for Chromium WebCore build
​https://bugs.webkit.org/show_bug.cgi?id=43508

No new tests. Built modified version of patch from bug 42405 in
Chromium to test.

  • WebCore.gyp/WebCore.gyp:
2:26 PM Changeset in webkit [64679] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-08-04 Pierre Rossi <​pierre.rossi@nokia.com>

Reviewed by Antonio Gomes.

[Qt] QWebFrame::setContent() does not respect charset provided in the mimeType
​https://bugs.webkit.org/show_bug.cgi?id=43125

  • Api/qwebframe.cpp: (QWebFrame::setContent):
  • tests/qwebframe/tst_qwebframe.cpp:
2:24 PM Changeset in webkit [64678] by adachan@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix

  • win/WebKit2Generated.make:
2:22 PM Changeset in webkit [64677] by mitz@apple.com
  • 22 edits
    5 adds in trunk

WebCore: Allow the language for hyphenation to be specified
​https://bugs.webkit.org/show_bug.cgi?id=43467

Test: fast/text/hyphenate-locale.html

Added a -webkit-hyphenate-locale property whose value can be either auto or a locale identifier
string. The initial value is auto and the property is inherited. When the value is a locale
identifier, hyphenation should follow the rules for the specified locale.

  • WebCore.xcodeproj/project.pbxproj: Added AtomicStringKeyedMRUCache.h.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Handle -webkit-hyphenate-locale.
Updated for the renaming of RenderStyle::hyphenateCharacter() to hyphenationString().

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-locale.

  • css/CSSPropertyNames.in: Added -webkit-hyphenate-locale.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Apply the -webkit-hyphenate-locale property to the
RenderStyle. Updated for the renaming of RenderStyle::hyphenateCharacter() to hyphenationString().

  • platform/text/AtomicStringKeyedMRUCache.h: Added.

(WebCore::AtomicStringKeyedMRUCache::get):

  • platform/text/Hyphenation.cpp:

(WebCore::canHyphenate): Added an implementation that returns false.
(WebCore::lastHyphenLocation): Now asserts that it is not called, because it is an error to call
this function if canHyphenate() returned false.

  • platform/text/Hyphenation.h:

Added canHyphenate(). Returns true if hyphenation is possible for the given locale identifier.

  • platform/text/android/HyphenationAndroid.cpp:

(WebCore::canHyphenate): Added an implementation that returns true and a FIXME.
(WebCore::lastHyphenLocation): Added unused localeIdentifier parameter.

  • platform/text/cf/HyphenationCF.cpp:

(WebCore::AtomicStringKeyedMRUCache<RetainPtr<CFLocaleRef> >::createValueForNullKey): Returns
the CFLocaleRef for the current search locale.
(WebCore::AtomicStringKeyedMRUCache<RetainPtr<CFLocaleRef> >::createValueForKey): Returns a
CFLocaleRef for the locale identifier.
(WebCore::canHyphenate): Added. Returns true.
(WebCore::lastHyphenLocation): Added localeIdentifier parameter, used to pass a CFLocaleRef to
the hyphenation function.

  • platform/text/mac/HyphenationMac.mm:

(WebCore::AtomicStringKeyedMRUCache<bool>::createValueForNullKey): Returns whether the current
search locale is english.
(WebCore::AtomicStringKeyedMRUCache<bool>::createValueForKey): Returns whether the locale identifier
string identifies locale with the English language.
(WebCore::canHyphenate): Added. Returns true if the locale language is English.
(WebCore::lastHyphenLocation): Added localeIdentifier parameter and an assertion that its language
is English.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Added a locale identifier parameter, which is passed down to
lastHyphenLocation(). Added 1 to the value passed for the beforeIndex parameter to lastHyphenLocation(),
because the latter only returns values smaller than that index. The Mac implementation could
return a value equal to beforeIndex, but that is fixed in the WebKitSystemInterface part of this patch.
(WebCore::RenderBlock::findNextLineBreak): Only set canHyphenate to true if hyphenation is possible
for the specified hyphenation locale. Pass the hyphenation locale to tryHyphenating().

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Compare hyphenation locales.
(WebCore::RenderStyle::hyphenString): Updated for the renaming of hyphenateCharacter() to
hyphenationString().

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hyphenationString): Renamed hyphenateCharacter() to this.
(WebCore::InheritedFlags::hyphenationLocale): Added this accessor.
(WebCore::InheritedFlags::setHyphenationString): Renamed setHyphenateCharacter() to this.
(WebCore::InheritedFlags::setHyphenationLocale): Added this accessor.
(WebCore::InheritedFlags::initialHyphenationString): Renamed initialHyphenateCharacter() to this.
(WebCore::InheritedFlags::initialHyphenateLocale): Added. Returns the null atom, which represents a
value of auto.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Copy the hyphenation locale. Updated for
rename.
(WebCore::StyleRareInheritedData::operator==): Compare the hyphenation locales. Updated for rename.

  • rendering/style/StyleRareInheritedData.h:

WebKitLibraries: WebKitSystemInterface part of: Allow the language for hyphenation to be specified
​https://bugs.webkit.org/show_bug.cgi?id=43467

Reviewed by Darin Adler.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

LayoutTests: Allow the language for hyphenation to be specified
​https://bugs.webkit.org/show_bug.cgi?id=43467

Reviewed by Simon Fraser.

  • fast/text/hyphenate-locale.html: Added.
  • platform/mac/fast/text/hyphenate-locale-expected.checksum: Added.
  • platform/mac/fast/text/hyphenate-locale-expected.png: Added.
  • platform/mac/fast/text/hyphenate-locale-expected.txt: Added.
2:02 PM Changeset in webkit [64676] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-08-04 Dimitri Glazkov <Dimitri Glazkov>

Updating Windows DRT expectations after DRT's successful run.

  • platform/chromium/drt_expectations.txt: Added failure expectations.
2:00 PM Changeset in webkit [64675] by sullivan@apple.com
  • 2 edits in trunk/WebKit2

Build fix, rubber-stamped by Brady Eidson.

  • WebKit2.xcodeproj/project.pbxproj:

Made WKData.h a public header.

1:39 PM Changeset in webkit [64674] by tonyg@chromium.org
  • 6 edits
    25 adds in trunk

2010-08-04 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

LayoutTests for <script defer> as specified by HTML5
​https://bugs.webkit.org/show_bug.cgi?id=40934

  • fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-double-defer-write.html: Added. Tests for tricky ordering and reentrancy by doing a double write of defered scripts.
  • fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Copied from LayoutTests/fast/tokenizer/write-before-load-expected.txt.
  • fast/dom/HTMLScriptElement/defer-double-write.html: Added. Tests for tricky ordering and reentrancy by doing a double write of inline scripts.
  • fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-inline-script.html: Added. Tests that the defer attribute is ignored on inline script blocks.
  • fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-onbeforeload.html: Added. Tests that onbeforeload fires immediately when a deferred script is encounted. Also tests that it can be cancelled.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Added. Tests that invalid URLs are ignored and subsequent scripts are still executed.
  • fast/dom/HTMLScriptElement/resources/defer.js: Added.
  • fast/dom/HTMLScriptElement/resources/external.js: Added.
  • fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Added.
  • http/tests/misc/resources/defer-script.js: Added.
  • http/tests/misc/resources/external-script.js: Added.
  • http/tests/misc/resources/script-debug-body-background.js: Added.
  • http/tests/misc/resources/script-write-slow-stylesheet.js: Added.
  • http/tests/misc/resources/slow-defer-script.cgi: Added.
  • http/tests/misc/resources/slow-stylesheet.cgi: Added.
  • http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Added.
  • http/tests/misc/script-defer-after-slow-stylesheet.html: Added. Tests stylesheet blocking behavior.
  • http/tests/misc/script-defer-expected.txt: Added.
  • http/tests/misc/script-defer-write-slow-stylesheet-expected.txt: Added.
  • http/tests/misc/script-defer-write-slow-stylesheet.html: Added. Tests stylesheet blocking behavior with a slow stylesheet.
  • http/tests/misc/script-defer.html: Added. Tests basic functionality and ordering.

2010-08-04 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Support <script defer> as specified by HTML5
​https://bugs.webkit.org/show_bug.cgi?id=40934

See: ​http://dev.w3.org/html5/spec/Overview.html#the-end

Tests: fast/dom/HTMLScriptElement/defer-double-defer-write.html

fast/dom/HTMLScriptElement/defer-double-write.html
fast/dom/HTMLScriptElement/defer-inline-script.html
fast/dom/HTMLScriptElement/defer-onbeforeload.html
fast/dom/HTMLScriptElement/defer-script-invalid-url.html
http/tests/misc/script-defer-after-slow-stylesheet.html
http/tests/misc/script-defer-write-slow-stylesheet.html
http/tests/misc/script-defer.html

  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::executeScriptsWaitingForParsingAndEnd):
  • html/HTMLDocumentParser.h:
  • html/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing): (WebCore::HTMLScriptRunner::requestScript): (WebCore::HTMLScriptRunner::requestParsingBlockingScript): (WebCore::HTMLScriptRunner::requestDeferredScript): (WebCore::HTMLScriptRunner::runScript):
  • html/HTMLScriptRunner.h: (WebCore::HTMLScriptRunner::PendingScript::PendingScript): (WebCore::HTMLScriptRunner::PendingScript::operator=):
1:31 PM Changeset in webkit [64673] by tonikitoo@webkit.org
  • 4 edits in trunk/WebKitTools

2010-08-04 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Simon Hausmann and Kenneth Christiansen.

[Qt] [QtTestBrowser] Clean up static and global menu state controls
​https://bugs.webkit.org/show_bug.cgi?id=43448

After LauncherWindow class was refactored out of from main.cpp, all global variables that
were hanging in main.cpp became temporarily public static class members of newly added
LauncherWindow class. This design was not properly handling the initial purpose of the
global variables: newly created launcher windows should inherit the settings of the originating
one.

In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
comprises all data needed to handling the goal described above.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object

holding all user settings configured in the menus and command line.
It also receices an optional QGraphicsScene points in case we are doing
a "Clone Window".

(LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its

value.

(LauncherWindow::initializeView): Ditto.
(LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
(LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly

apply the preferences is provided by m_userData.

(LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
(LauncherWindow::toggleResizesToContents): Ditto.
(LauncherWindow::toggleWebGL): Ditto.
(LauncherWindow::toggleFrameFlattening): Ditto.
(LauncherWindow::toggleQGLWidgetViewport): Ditto.
(LauncherWindow::changeViewportUpdateMode): Ditto.
(LauncherWindow::showFPS): Ditto.
(LauncherWindow::newWindow): Changed to pass the userData.
(LauncherWindow::cloneWindow): Ditto.

  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (requiresGraphicsView): (LauncherApplication::handleUserOptions): (main):
1:26 PM Changeset in webkit [64672] by kevino@webkit.org
  • 7 edits in trunk

[wx] Build fix for gcc not importing all symbols from convenience libraries.
Works on 10.6 only for Mac until the build system is reworked.

1:18 PM Changeset in webkit [64671] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-04 Markus Goetz <​Markus.Goetz@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Change wording in QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=43241

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
1:17 PM Changeset in webkit [64670] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix. Enclose PlatformStrategy methods in USE(PLATFORM_STRATEGIES).

12:57 PM Changeset in webkit [64669] by Adam Roben
  • 2 edits in trunk/WebKit2

Windows build fix

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_SetValue): Removed unreachable code.

12:56 PM Changeset in webkit [64668] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

2010-08-04 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Regression test: overflow: auto; on a math element was a cause of crash.
​https://bugs.webkit.org/show_bug.cgi?id=42894

  • mathml/presentation/style.xhtml: Added.
  • platform/mac/mathml/presentation/style-expected.checksum: Added.
  • platform/mac/mathml/presentation/style-expected.png: Added.
  • platform/mac/mathml/presentation/style-expected.txt: Added.

2010-08-04 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Remove unnecessary calls to setStyle() in MathML code that made RenderLayer crash.
​https://bugs.webkit.org/show_bug.cgi?id=42894

Test: mathml/presentation/style.xhtml

  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/MathMLMathElement.cpp: (WebCore::MathMLMathElement::createRenderer):
  • mathml/MathMLTextElement.cpp: (WebCore::MathMLTextElement::createRenderer):
12:49 PM Changeset in webkit [64667] by Adam Roben
  • 2 edits in trunk/WebKit2

Windows build fix

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_SetValue): Added some case statements that are compiled
on Windows to avoid a warning about having default but not cases.

12:36 PM Changeset in webkit [64666] by Adam Roben
  • 2 edits in trunk/WebKit2

Windows build fix

  • win/WebKit2.vcproj: Added NetscapeBrowserFuncs.
12:31 PM Changeset in webkit [64665] by kbr@google.com
  • 9 edits in trunk/ANGLE

2010-08-04 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Update ANGLE to r352
​https://bugs.webkit.org/show_bug.cgi?id=43500

Updated ANGLE to r352 (July 26, 2010). Built WebKit to test.

  • include/GLSLANG/ShaderLang.h:
  • src/compiler/Initialize.cpp: (BuiltInFunctionsCommon): (BuiltInFunctionsVertex): (BuiltInFunctionsFragment): (StandardUniforms): (DefaultPrecisionVertex): (DefaultPrecisionFragment): (BuiltInConstants): (TBuiltIns::initialize): (IdentifyBuiltIns):
  • src/compiler/Initialize.h: (TBuiltIns::getBuiltInStrings):
  • src/compiler/OutputGLSL.cpp: (TOutputGLSL::visitSelection):
  • src/compiler/ShHandle.h: (TCompiler::getLanguage): (TCompiler::getSpec): (TCompiler::getSymbolTable): (TCompiler::getInfoSink):
  • src/compiler/ShaderLang.cpp: (InitializeSymbolTable): (GenerateBuiltInSymbolTable): (ShInitialize): (ShConstructCompiler): (ShFinalize): (ShCompile):
  • src/compiler/SymbolTable.h: (TSymbolTable::atBuiltInLevel): (TSymbolTable::atGlobalLevel): (TSymbolTable::push): (TSymbolTable::getGlobalLevel): (TSymbolTable::currentLevel):
  • src/libGLESv2/Shader.cpp: (gl::Shader::Shader): (gl::Shader::compileToHLSL):
12:29 PM Changeset in webkit [64664] by Adam Roben
  • 2 edits
    1 delete in trunk/WebKit2

Windows build fix

The functions in NetscapePluginModuleWin.cpp have been moved to
NetscapePluginModule.cpp.

  • WebProcess/Plugins/Netscape/win/NetscapePluginModuleWin.cpp: Removed.
  • win/WebKit2.vcproj: Removed NetscapePluginModuleWin.
12:09 PM Changeset in webkit [64663] by Adam Roben
  • 5 edits
    3 copies
    1 move
    1 add in trunk/WebKit2

Move bundle-loading code from NetscapePluginModule to a new Module class

This allows more NetscapePluginModule code to be cross-platform.

Fixes <​http://webkit.org/b/43497> NetscapePluginModule::try/unload
should be cross-platform

Reviewed by Anders Carlsson.

  • Platform/Module.cpp: Added.

(WebKit::Module::Module): Store our path.
(WebKit::Module::~Module): Unload our native module.

  • Platform/Module.h: Added.

(WebKit::Module::leakBundle): Does what it says.
(WebKit::Module::functionPointer): Returns a pointer to the named
function, with the right type.

  • Platform/mac/ModuleMac.mm: Added.

(WebKit::Module::load): Code was moved here from
NetscapePluginModule::tryLoad.
(WebKit::Module::unload): Just clears our bundle.
(WebKit::Module::platformFunctionPointer): Code was moved here from
NetscapePluginModuleMac.cpp.

  • Platform/qt/ModuleQt.cpp: Added.

(WebKit::Module::load):
(WebKit::Module::unload):
(WebKit::Module::platformFunctionPointer):

  • Platform/win/ModuleWin.cpp: Added.

(WebKit::Module::load):
(WebKit::Module::unload):
(WebKit::Module::platformFunctionPointer):
Just stubbed out these functions.

  • WebKit2.xcodeproj/project.pbxproj: Added Module.
  • WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):
(WebKit::NetscapePluginModule::unload):
Moved here from NetscapePluginModuleMac.cpp. Now uses the
cross-platform m_module member.

  • WebProcess/Plugins/Netscape/NetscapePluginModule.h: Replaced

m_bundle with m_module.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginModuleMac.cpp: Removed.
  • win/WebKit2.vcproj: Added Module.
11:55 AM Changeset in webkit [64662] by beidson@apple.com
  • 10 edits
    3 adds in trunk/WebKit2

2010-08-04 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig.

Lay the groundwork for saving/restoring page session state to WK2
​https://bugs.webkit.org/show_bug.cgi?id=43495

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • Shared/APIObject.h: (WebKit::APIObject::):
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:


Arbitrary byte buffer:

  • Shared/WebData.h: Added. (WebKit::WebData::create): (WebKit::WebData::bytes): (WebKit::WebData::size): (WebKit::WebData::WebData): (WebKit::WebData::type):


API facing object to act as a byte buffer:

  • UIProcess/API/C/WKData.cpp: Added. (WKDataGetTypeID): (WKDataCreate): (WKDataGetBytes): (WKDataGetSize): (WKDataRetain): (WKDataRelease):
  • UIProcess/API/C/WKData.h: Added.

API for saving/restoring state:

  • UIProcess/API/C/WKPage.cpp: (WKPageCopySessionState): (WKPageRestoreFromSessionState):
  • UIProcess/API/C/WKPage.h:

These will be filled in later:

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::sessionState): (WebKit::WebPageProxy::restoreFromSessionState):
  • UIProcess/WebPageProxy.h:
11:44 AM Changeset in webkit [64661] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Set correct default minimumFontSize.

Reviewed by Anders Carlsson.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):

11:39 AM Changeset in webkit [64660] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-08-03 Kenneth Russell <​kbr@google.com>

Reviewed by Nate Chapin.

Move WebGL-specific code out of GraphicsContext3D so that G3D can be used as a generic accelerated drawing API
​https://bugs.webkit.org/show_bug.cgi?id=43221

Added a helper function to extract the contents of WebGL objects
to reduce duplicated code and fix a couple of potential crashes
introduced in the previous refactoring.

No new tests; ran existing WebGL tests.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::attachShader): (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::bindFramebuffer): (WebCore::WebGLRenderingContext::bindRenderbuffer): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getAttachedShaders): (WebCore::WebGLRenderingContext::getAttribLocation): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::useProgram): (WebCore::WebGLRenderingContext::validateProgram): (WebCore::WebGLRenderingContext::handleNPOTTextures): (WebCore::WebGLRenderingContext::restoreStatesAfterVertexAttrib0Simulation):
11:29 AM Changeset in webkit [64659] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

2010-08-04 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Jeremy Orlow.

[Gtk] Make sure DRT return the right AXTitle for controls
​https://bugs.webkit.org/show_bug.cgi?id=39997

Added expected results file to the GTK port and removed the new
test from the Skipped file.

  • platform/gtk/Skipped:
  • platform/gtk/accessibility/aria-checkbox-text-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-checkbox-text-expected.txt.

2010-08-04 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Jeremy Orlow.

[Gtk] Make sure DRT return the right AXTitle for controls
​https://bugs.webkit.org/show_bug.cgi?id=39997

Fallback to the text under the given element as its name in case
it's a control element and has no associated label for it.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name):
11:14 AM Changeset in webkit [64658] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Enable JSVALUE64 for CPU(PPC64).
Basic browsing seems to work.

Rubber stamped by Sam Weinig.

  • wtf/Platform.h:
11:08 AM Changeset in webkit [64657] by commit-queue@webkit.org
  • 2 edits in trunk

2010-08-04 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Variable max heap size between target/emulator
​https://bugs.webkit.org/show_bug.cgi?id=41480

  • WebKit.pri: Symbian-only code block for EPOCHEAPSIZE configuration
10:48 AM Changeset in webkit [64656] by kbr@google.com
  • 9 edits in trunk

2010-08-02 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Port Chromium's accelerated compositing to Mac OS X
​https://bugs.webkit.org/show_bug.cgi?id=43398

  • public/WebGLES2Context.h:
    • Added resizeOnscreenContent, needed on Mac OS X to report window size changes.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize):
    • Send resize notification to the WebGLES2Context.

(WebKit::WebViewImpl::updateRootLayerContents):

  • Ported to Core Graphics.

(WebKit::WebViewImpl::gles2Context):

  • Added initial size notification upon context creation.

2010-08-02 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Port Chromium's accelerated compositing to Mac OS X
​https://bugs.webkit.org/show_bug.cgi?id=43398

No new tests. Tested manually with CSS 3D and WebGL tests.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::clearBorderColor): (WebCore::clearLayerBackgroundColor):
    • Fixed compilation problems with gcc.
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateTextureContents):
    • Added Core Graphics port.
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium):
    • Fixed compilation problems with gcc related to initialization order of members.

(WebCore::LayerChromium::updateTextureContents):
(WebCore::LayerChromium::updateTextureRect):

  • Ported to Core Graphics, adjusting for lower-left coordinate system origin.
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium):
    • Fixed compilation problems with gcc related to initialization order of members.

(WebCore::LayerRendererChromium::setRootLayerCanvasSize):

  • Ported to Core Graphics.

(WebCore::LayerRendererChromium::drawLayers):

  • Added more debug-only error calls during drawing phase. Adjusted scrolling and incremental updating code for Core Graphics' lower-left coordinate system origin.

(WebCore::LayerRendererChromium::initializeSharedGLObjects):

  • Removed color channel swizzling in Core Graphics port. Fixed preexisting bug in initialization check of m_rootLayerTextureId.
  • platform/graphics/chromium/LayerRendererChromium.h:
    • Added needed data members for Core Graphics port.
10:18 AM Changeset in webkit [64655] by commit-queue@webkit.org
  • 15 edits in trunk

2010-08-04 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Darin Adler.

Refactoring MarkStack::append to take a reference. This is in
preparation for movable objects when we will need to update pointers.
​http://bugs.webkit.org/show_bug.cgi?id=41177

Unless otherwise noted, all changes are to either return by reference
or pass a reference to MarkStack::append.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • runtime/Collector.cpp: (JSC::Heap::markConservatively):

Added a temporary variable to prevent marking from changing an
unknown value on the stack

  • runtime/JSCell.h: (JSC::JSValue::asCell): (JSC::MarkStack::append): (JSC::MarkStack::appendInternal):
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object):
  • runtime/JSObject.h: (JSC::JSObject::prototype):
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
  • runtime/JSValue.h: (JSC::JSValue::JSValue): (JSC::JSValue::asCell):
  • runtime/MarkStack.h:
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::createStructure):

Changed the structure flags to include a custom markChildren.

(JSC::NativeErrorConstructor::markChildren):

Update the prototype of the stored structure.

  • runtime/NativeErrorConstructor.h:

Added structure flags.

  • runtime/Structure.h: (JSC::Structure::storedPrototype):

2010-08-04 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Darin Adler.

Removed unneeded marking. We need to remove this marking in order to have
MarkStack::append take references for updating movable objects.

​https://bugs.webkit.org/show_bug.cgi?id=41177

  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):
10:12 AM Changeset in webkit [64654] by aa@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-04 Aaron Boodman <​aa@chromium.org>

Reviewed by Eric Seidel.

prepare-ChangeLog fails mysteriously if curl doesn't support ssl
​https://bugs.webkit.org/show_bug.cgi?id=43460

  • Scripts/prepare-ChangeLog:
8:26 AM Changeset in webkit [64653] by yurys@chromium.org
  • 12 edits in trunk/WebCore

2010-08-04 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use InspectorValue to push dispatch results from the injected script
​https://bugs.webkit.org/show_bug.cgi?id=43483

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::reportDidDispatchOnInjectedScript):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::reportDidDispatchOnInjectedScriptCallback):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::dispatch):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript): (WebCore::InjectedScriptHost::remoteFrontend):
  • inspector/InjectedScriptHost.h:
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didContinue):
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
8:10 AM Changeset in webkit [64652] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-04 Abhishek Arya <​inferno@chromium.org>

Unreviewed. QT expectation fix.

  • platform/qt/fast/notifications/notifications-document-close-crash-expected.txt:
7:45 AM Changeset in webkit [64651] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-08-04 Abhishek Arya <​inferno@chromium.org>

Unreviewed. Put missing equivalent js bindings check.

Forgot putting js bindings check in ​http://trac.webkit.org/changeset/64647. This fixes the qt crash.

  • bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission):

2010-08-04 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Add qt specific layout test results for my commit ​http://trac.webkit.org/changeset/64647.
Fix timeout in my layout test since it was generating too many events in qt.

  • fast/notifications/notifications-document-close-crash.html:
  • platform/qt/fast/notifications: Added.
  • platform/qt/fast/notifications/notifications-document-close-crash-expected.txt: Added.
7:43 AM Changeset in webkit [64650] by yurys@chromium.org
  • 10 edits in trunk/WebCore

2010-08-04 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: serialize database resources to InspectorValues
​https://bugs.webkit.org/show_bug.cgi?id=43482

  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getDatabaseTableNames):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::selectDatabase): (WebCore::InspectorController::didOpenDatabase):
  • inspector/InspectorController.h:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::create): (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • storage/Database.cpp: (WebCore::Database::openDatabase):
7:19 AM Changeset in webkit [64649] by commit-queue@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-08-03 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Oliver Hunt.

Tightened up some get_by_id_chain* code generation
​https://bugs.webkit.org/show_bug.cgi?id=40935

This is in the style of
​https://bugs.webkit.org/show_bug.cgi?id=30539, and changed code to
call accessor functions when it was not necessary to directly access
the private variables.

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
6:56 AM Changeset in webkit [64648] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-04 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium expectations update.

  • platform/chromium/test_expectations.txt:
6:25 AM Changeset in webkit [64647] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-08-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Alexey Proskuryakov.

Null the script execution context when disconnecting frame in notifications.
Make sure that script execution context is valid in notification requestPermission.
​https://bugs.webkit.org/show_bug.cgi?id=43295

Tests: fast/notifications/notifications-document-close-crash.html

  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::requestPermissionCallback):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::disconnectFrame):

2010-08-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Alexey Proskuryakov.

Tests that requesting notification permission on a closed document does
not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=43295

  • fast/notifications/notifications-document-close-crash-expected.txt: Added.
  • fast/notifications/notifications-document-close-crash.html: Added.
6:13 AM Changeset in webkit [64646] by pfeldman@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-08-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

DevTools: get rid of delayed command dispatching on front-end side.

​https://bugs.webkit.org/show_bug.cgi?id=43479

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::frontendLoaded):
  • src/WebDevToolsAgentImpl.h:
6:00 AM Changeset in webkit [64645] by Adam Roben
  • 10 edits
    2 adds
    2 deletes in trunk

Turn on PLATFORM_STRATEGIES on Windows

Fixes <​http://webkit.org/b/43431>.

Reviewed by Anders Carlsson.

JavaScriptCore:

  • wtf/Platform.h:

WebCore:

  • WebCore.vcproj/WebCore.vcproj: Added LocalizedStrings.cpp,

PlatformStrategies.h, LocalizationStrategy.h, PluginStrategy.h, and
VisitedLinkStrategy.h. Removed PluginDataWin.cpp

  • platform/LocalizedStrings.cpp: Wrapped Mac-only functions in

PLATFORM(MAC) guards.

(WebCore::uploadFileText):
(WebCore::allFilesText):
Added these Windows-only functions.

  • plugins/win/PluginDataWin.cpp: Removed.

WebKit/win:

  • WebCoreLocalizedStrings.cpp: Removed.
  • WebCoreSupport/WebPlatformStrategies.cpp: Added. Based on the Mac

equivalent.
(WebPlatformStrategies::initialize): Creates the singleton instance.
(WebPlatformStrategies::WebPlatformStrategies): Registers the
singleton instance as the PlatformStrategies instance for WebCore.

(WebPlatformStrategies::createPluginStrategy):
(WebPlatformStrategies::createLocalizationStrategy):
(WebPlatformStrategies::createVisitedLinkStrategy):
Return ourselves as the strategy.

(WebPlatformStrategies::refreshPlugins):
(WebPlatformStrategies::getPluginInfo):
Moved code here from WebCore's PluginDataWin.cpp file.

(WebPlatformStrategies::searchableIndexIntroduction):
(WebPlatformStrategies::submitButtonDefaultLabel):
(WebPlatformStrategies::inputElementAltText):
(WebPlatformStrategies::resetButtonDefaultLabel):
(WebPlatformStrategies::fileButtonChooseFileLabel):
(WebPlatformStrategies::fileButtonNoFileSelectedLabel):
(WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow):
(WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk):
(WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard):
(WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow):
(WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk):
(WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard):
(WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow):
(WebPlatformStrategies::contextMenuItemTagCopy):
(WebPlatformStrategies::contextMenuItemTagGoBack):
(WebPlatformStrategies::contextMenuItemTagGoForward):
(WebPlatformStrategies::contextMenuItemTagStop):
(WebPlatformStrategies::contextMenuItemTagReload):
(WebPlatformStrategies::contextMenuItemTagCut):
(WebPlatformStrategies::contextMenuItemTagPaste):
(WebPlatformStrategies::contextMenuItemTagNoGuessesFound):
(WebPlatformStrategies::contextMenuItemTagIgnoreSpelling):
(WebPlatformStrategies::contextMenuItemTagLearnSpelling):
(WebPlatformStrategies::contextMenuItemTagSearchWeb):
(WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
(WebPlatformStrategies::contextMenuItemTagOpenLink):
(WebPlatformStrategies::contextMenuItemTagIgnoreGrammar):
(WebPlatformStrategies::contextMenuItemTagSpellingMenu):
(WebPlatformStrategies::contextMenuItemTagCheckSpelling):
(WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping):
(WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling):
(WebPlatformStrategies::contextMenuItemTagFontMenu):
(WebPlatformStrategies::contextMenuItemTagBold):
(WebPlatformStrategies::contextMenuItemTagItalic):
(WebPlatformStrategies::contextMenuItemTagUnderline):
(WebPlatformStrategies::contextMenuItemTagOutline):
(WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu):
(WebPlatformStrategies::contextMenuItemTagTextDirectionMenu):
(WebPlatformStrategies::contextMenuItemTagDefaultDirection):
(WebPlatformStrategies::contextMenuItemTagLeftToRight):
(WebPlatformStrategies::contextMenuItemTagRightToLeft):
(WebPlatformStrategies::contextMenuItemTagShowSpellingPanel):
(WebPlatformStrategies::contextMenuItemTagInspectElement):
(WebPlatformStrategies::searchMenuNoRecentSearchesText):
(WebPlatformStrategies::searchMenuRecentSearchesText):
(WebPlatformStrategies::searchMenuClearRecentSearchesText):
(WebPlatformStrategies::AXWebAreaText):
(WebPlatformStrategies::AXLinkText):
(WebPlatformStrategies::AXListMarkerText):
(WebPlatformStrategies::AXImageMapText):
(WebPlatformStrategies::AXHeadingText):
(WebPlatformStrategies::AXDefinitionListTermText):
(WebPlatformStrategies::AXDefinitionListDefinitionText):
(WebPlatformStrategies::AXButtonActionVerb):
(WebPlatformStrategies::AXRadioButtonActionVerb):
(WebPlatformStrategies::AXTextFieldActionVerb):
(WebPlatformStrategies::AXCheckedCheckBoxActionVerb):
(WebPlatformStrategies::AXUncheckedCheckBoxActionVerb):
(WebPlatformStrategies::AXLinkActionVerb):
(WebPlatformStrategies::AXMenuListActionVerb):
(WebPlatformStrategies::AXMenuListPopupActionVerb):
(WebPlatformStrategies::unknownFileSizeText):
(WebPlatformStrategies::uploadFileText):
(WebPlatformStrategies::allFilesText):
(WebPlatformStrategies::missingPluginText):
(WebPlatformStrategies::crashedPluginText):
(WebPlatformStrategies::imageTitle):
(WebPlatformStrategies::multipleFileUploadText):
(WebPlatformStrategies::mediaElementLoadingStateText):
(WebPlatformStrategies::mediaElementLiveBroadcastStateText):
(WebPlatformStrategies::localizedMediaControlElementString):
(WebPlatformStrategies::localizedMediaControlElementHelpText):
(WebPlatformStrategies::localizedMediaTimeDescription):
(WebPlatformStrategies::validationMessageValueMissingText):
(WebPlatformStrategies::validationMessageTypeMismatchText):
(WebPlatformStrategies::validationMessagePatternMismatchText):
(WebPlatformStrategies::validationMessageTooLongText):
(WebPlatformStrategies::validationMessageRangeUnderflowText):
(WebPlatformStrategies::validationMessageRangeOverflowText):
(WebPlatformStrategies::validationMessageStepMismatchText):
Moved code here from WebCoreLocalizedStrings.cpp (and slightly cleaned
it up).

(WebPlatformStrategies::isLinkVisited):
(WebPlatformStrategies::addVisitedLink):
Copied code from WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm.

  • WebCoreSupport/WebPlatformStrategies.h: Added.
  • WebKit.vcproj/WebKit.vcproj: Removed WebCoreLocalizedStrings, added

WebPlatformStrategies.

  • WebView.cpp:

(WebView::initWithFrame): Initialize WebPlatformStrategies.

WebKit2:

  • win/WebKit2.vcproj: Added WebPlatformStrategies. Also let VS reorder

this file as it saw fit.

5:41 AM Changeset in webkit [64644] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-04 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
5:38 AM Changeset in webkit [64643] by morrita@google.com
  • 3 edits
    2 adds in trunk

2010-08-03 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[DRT] Assertion failed when drag and move a draggable element.
​https://bugs.webkit.org/show_bug.cgi?id=41695

  • fast/events/dragging-mouse-moves-expected.txt: Added.
  • fast/events/dragging-mouse-moves.html: Added.

2010-08-03 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[DRT] Assertion failed when drag and move a draggable element.
​https://bugs.webkit.org/show_bug.cgi?id=41695

mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
But Cocoa doesn't call mouseDragged() until dragging is done.
Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
on UIDelegate failed when mouseDragged() is called during dragging.
This change eliminated the mouseDragged() call when dragging begins,
which is implicated by draggingInfo instance.

  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController mouseMoveToX:Y:]):

Test: fast/events/dragging-mouse-moves.html

5:36 AM QtWebKit edited by Henry Haverinen
(diff)
5:22 AM Changeset in webkit [64642] by yurys@chromium.org
  • 17 edits
    1 add in trunk/WebCore

2010-08-04 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: serialize CPU profiles to InspectorValues instead of
using JS wrappers.
​https://bugs.webkit.org/show_bug.cgi?id=43475

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptProfile.h:
  • bindings/js/ScriptProfiler.cpp: (WebCore::ScriptProfiler::stop):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/v8/ScriptProfile.cpp: (WebCore::buildInspectorObjectFor): (WebCore::ScriptProfile::buildInspectorObjectForHead):
  • bindings/v8/ScriptProfile.h:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
4:42 AM Changeset in webkit [64641] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-08-04 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Use a QImage for the stroke applier scratch context

This avoids leaking a server-side resource on some graphics systems.

  • platform/graphics/qt/PathQt.cpp: (WebCore::scratchContext):
4:39 AM Changeset in webkit [64640] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed build fix.

Add new Geolocation delayed permission tests to Qt skipped list
​https://bugs.webkit.org/show_bug.cgi?id=43478

  • platform/qt/Skipped:
4:13 AM Changeset in webkit [64639] by steveblock@google.com
  • 12 edits
    6 adds in trunk

Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
​https://bugs.webkit.org/show_bug.cgi?id=40002

Reviewed by Alexey Proskuryakov.

WebKitTools:

The code in LayoutTestController::setGeolocationPermission() was moved to
setGeolocationPermissionCommon() to allow each port to provide its own
implementation of setGeolocationPermission().

For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
new permission, so it can call back to WebCore if permission requests are in
progress and are waiting for a response. A minor fix to the Mac
MockGeolocationProvider was also required to make sure that the mock provider
calls back to WebCore when it is first started.

For other ports, LayoutTestController::setGeolocationPermission() is not
implemented.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::setGeolocationPermissionCommon):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setGeolocationPermission):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setGeolocationPermission):

  • DumpRenderTree/mac/MockGeolocationProvider.mm:

(-[MockGeolocationProvider registerWebView:]):

  • DumpRenderTree/mac/UIDelegate.h:
  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
(-[UIDelegate setGeolocationPermission:]):
(-[UIDelegate dealloc]):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setGeolocationPermission):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setGeolocationPermission):

LayoutTests:

  • fast/dom/Geolocation/delayed-permission-allowed-expected.txt: Added.
  • fast/dom/Geolocation/delayed-permission-allowed.html: Added.
  • fast/dom/Geolocation/delayed-permission-denied-expected.txt: Added.
  • fast/dom/Geolocation/delayed-permission-denied.html: Added.
  • fast/dom/Geolocation/script-tests/delayed-permission-allowed.js: Added.
  • fast/dom/Geolocation/script-tests/delayed-permission-denied.js: Added.
  • platform/gtk/Skipped: Added new tests to GTK skipped lists
2:30 AM Changeset in webkit [64638] by benm@google.com
  • 2 edits in trunk/WebCore

HTML5 parser may cause onload not to fire
​https://bugs.webkit.org/show_bug.cgi?id=43423

Reviewed by Darin Adler.

If a complex page causes the HTML parser to yield,
then when parsing continues again and eventually
finishes, we are missing a call to endIfDelayed(). This
results in onload never being called.

Not for lack of trying, but it seems almost
impossible to write a reliable test for this bug,
due to the highly timing-dependent nature of the
bug. The link above contains further discussion and
attempts at writing a test.

  • html/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
Add a call to endIfDelayed() after pumping the tokenizer
post the parser yielding to ensure that the parsing step
is completed properly and the onload event fires.

1:57 AM Changeset in webkit [64637] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-08-04 Dirk Schulze <​krit@webkit.org>

Unreviewed sort of XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
1:16 AM Changeset in webkit [64636] by mrowe@apple.com
  • 2 edits in trunk

Build fix.

Fix the contents of the forwarding headers too.

1:06 AM Changeset in webkit [64635] by mrowe@apple.com
  • 2 moves in trunk

Build fix.

It's really useful if the forwarding headers match the name of the file that they're forwarding to.
Amazingly enough, if the name doesn't match then the file cannot be found! Who'd have thunk it?!

12:32 AM Changeset in webkit [64634] by Darin Adler
  • 2 edits
    1 add in trunk/WebCore

2010-08-03 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

System color changes are not applied properly
​https://bugs.webkit.org/show_bug.cgi?id=43468

  • manual-tests/system-color-change.html: Added.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::platformColorsDidChange): Added a call to Page::setNeedsReapplyStyles, so all frames of all pages will recompute in case they use system colors. It's rare for these colors to change, so OK to do a little extra style computation.
12:30 AM Changeset in webkit [64633] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-08-04 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Revert changed license in SVGFEOffsetElement.h, thanks Gabor for noticing.

  • svg/SVGFEOffsetElement.h:
12:12 AM Changeset in webkit [64632] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

Enable JSValue32_64 for GCC on ARM by default
​https://bugs.webkit.org/show_bug.cgi?id=43410

Reviewed by Geoffrey Garen.

  • wtf/Platform.h:
Note: See TracTimeline for information about the timeline view.