⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 13, 2010:

11:44 PM Changeset in webkit [65359] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-13 Eric Seidel <​eric@webkit.org>

Unreviewed. Build fix only.

Add support for MathML entities
​https://bugs.webkit.org/show_bug.cgi?id=43949

  • Scripts/create-html-entity-table:
    • Hack sys.path to avoid executing 2.5 dependent python on systems (like chromium-win and Tiger) which do not have 2.5 python.
11:26 PM Changeset in webkit [65358] by abarth@webkit.org
  • 7 edits in trunk

2010-08-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename some concepts in HTML entity search to be more self-documenting
​https://bugs.webkit.org/show_bug.cgi?id=44004

Start and end are now first and last, which lets us use some better
names for the statics in HTMLEntityTable.

  • html/HTMLEntityParser.cpp: (WebCore::consumeHTMLEntity):
  • html/HTMLEntitySearch.cpp: (WebCore::HTMLEntitySearch::HTMLEntitySearch): (WebCore::HTMLEntitySearch::findFirst): (WebCore::HTMLEntitySearch::findLast): (WebCore::HTMLEntitySearch::advance):
  • html/HTMLEntitySearch.h: (WebCore::HTMLEntitySearch::isEntityPrefix): (WebCore::HTMLEntitySearch::mostRecentMatch): (WebCore::HTMLEntitySearch::fail):
  • html/HTMLEntityTable.h:

2010-08-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename some concepts in HTML entity search to be more self-documenting
​https://bugs.webkit.org/show_bug.cgi?id=44004

Reflect name change in generator script.

  • Scripts/create-html-entity-table:
11:03 PM Changeset in webkit [65357] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

2010-08-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make it easier to run LayoutTests in Firefox
​https://bugs.webkit.org/show_bug.cgi?id=44002

Firefox doesn't seem to have innerText. Instead, let's just use the
normal DOM operations.

  • fast/parser/resources/p-in-scope.js:
  • fast/table/incomplete-table-in-fragment-2.html:
  • fast/table/incomplete-table-in-fragment-hang.html:
10:09 PM Changeset in webkit [65356] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

[wx] Build fix, add CString to the list of forwards.

10:05 PM Changeset in webkit [65355] by abarth@webkit.org
  • 8 edits in trunk/LayoutTests

2010-08-13 Adam Barth <​abarth@webkit.org>

Update test expectations to account for the HTML5 entity parser. There
are two main differences:

1) The value of lang and rang have changed.
2) We now parse FOO&ltBAR as FOO<BAR.

  • fast/parser/entities-in-html-expected.txt:
  • fast/parser/entities-in-xhtml-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
    • This test expectation is wrong. It's on my list to redesign how the XSS auditor works now that we have better parsing tools. Rather than skip the test on all platforms, I'm updating the expectation.
  • platform/mac/fast/text/word-space-expected.txt:
  • platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
9:57 PM Changeset in webkit [65354] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-13 Adam Barth <​abarth@webkit.org>

Fix ASSERT in XML entity parsing. You can't advance the entity search
if you've already discovered that your string is not an entity.

  • html/HTMLEntityParser.cpp: (WebCore::decodeNamedEntity):
8:32 PM Changeset in webkit [65353] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-13 Eric Seidel <​eric@webkit.org>

Unreviewed. Attempt at fixing Chromium build.

Add support for MathML entities
​https://bugs.webkit.org/show_bug.cgi?id=43949

  • WebCore.gyp/WebCore.gyp:
    • I have no clue if this is right or not.
8:28 PM Changeset in webkit [65352] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-13 Eric Seidel <​eric@webkit.org>

Unreviewed. Attempted build fix for Windows.

Add support for MathML entities
​https://bugs.webkit.org/show_bug.cgi?id=43949

  • DerivedSources.cpp:
    • Add HTMLEntityTable.cpp
8:18 PM Changeset in webkit [65351] by eric@webkit.org
  • 16 edits
    4 adds
    1 delete in trunk

2010-08-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add support for MathML entities
​https://bugs.webkit.org/show_bug.cgi?id=43949

Test progression for proper entity support.

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:

2010-08-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add support for MathML entities
​https://bugs.webkit.org/show_bug.cgi?id=43949

Implementing the HTML5 entity parsing algorithm require refactoring how
we search for entity names. Instead of using a perfect hash, we now
use a sorted list. As we advance through the input, we walk down a
binary search of the table looking for an entity.

Using this data structure lets us keep track of whether the current
string is a prefix of an existing entity, which we need for the
algorithm. In a future patch, I plan to add some indices to the
table, which should let us narrow down the range of interesting entries
more quickly.

The one nasty piece of the algorithm is if we walk too far down the
input and we need to back up to a previous match. In this patch, we
accomplish this by rewinding the input and consuming a known number of
characters to resync the source.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLEntityParser.cpp: (WebCore::consumeHTMLEntity):
  • html/HTMLEntitySearch.cpp: Added. (WebCore::): (WebCore::HTMLEntitySearch::HTMLEntitySearch): (WebCore::HTMLEntitySearch::compare): (WebCore::HTMLEntitySearch::findStart): (WebCore::HTMLEntitySearch::findEnd): (WebCore::HTMLEntitySearch::advance):
  • html/HTMLEntitySearch.h: Added. (WebCore::HTMLEntitySearch::isEntityPrefix): (WebCore::HTMLEntitySearch::currentValue): (WebCore::HTMLEntitySearch::lastMatch): (WebCore::HTMLEntitySearch::): (WebCore::HTMLEntitySearch::fail):
  • html/HTMLEntityTable.h: Added. (WebCore::HTMLEntityTableEntry::lastCharacter):

2010-08-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add support for MathML entities
​https://bugs.webkit.org/show_bug.cgi?id=43949

A script for generating the C++ state data structure describing all the
entities from a JSON description.

  • Scripts/create-html-entity-table: Added.
8:09 PM Changeset in webkit [65350] by tonyg@chromium.org
  • 3 edits in trunk/WebCore

2010-08-13 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Refactor HTMLScriptRunner to allow deferred scripts to share code
​https://bugs.webkit.org/show_bug.cgi?id=43736

No new tests because no functional change

  • html/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript): Make const to enforce the idea that it doesn't change m_parsingBlockingScript. (WebCore::HTMLScriptRunner::executeParsingBlockingScript): Rename to make it clear this deals with the parsing blocking script and refactor to use executePendingScriptAndDispatchEvent. (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Factored out of executePendingScript, this can be used for executing any external script. (WebCore::HTMLScriptRunner::executeScript): This can be used for executing any inline or external script. ASSERTs moved to the two calling points. (WebCore::HTMLScriptRunner::executeParsingBlockingScripts): Moved method. (WebCore::HTMLScriptRunner::requestParsingBlockingScript): Factored out requestPendingScript. (WebCore::HTMLScriptRunner::requestPendingScript): Factored out from reqeustParsingBlockingScript. (WebCore::HTMLScriptRunner::runScript):
  • html/HTMLScriptRunner.h:
7:23 PM Changeset in webkit [65349] by barraclough@apple.com
  • 3 edits in trunk/WebCore

Windows build fix.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/win/SharedBufferWin.cpp:
7:16 PM Changeset in webkit [65348] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2010-08-13 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Form state restore tests fail on GTK build with r65340
​https://bugs.webkit.org/show_bug.cgi?id=43998

Move form submits (and rest of test) to run during onload, to make sure
that the submit generates a history entry.

  • fast/forms/state-restore-to-non-autocomplete-form.html:
  • fast/forms/state-restore-to-non-edited-controls.html:
6:53 PM Changeset in webkit [65347] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix

6:37 PM Changeset in webkit [65346] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix

6:34 PM Changeset in webkit [65345] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix

6:28 PM Changeset in webkit [65344] by barraclough@apple.com
  • 30 edits in trunk

Switch String::/UString::ascii() to return a CString.

Rubber stamped by Sam Weinig.

JavaScriptCore:

(JSC::CodeBlock::dump):

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::dump):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::dumpCaller):

  • jsc.cpp:

(runWithScripts):
(runInteractive):

  • runtime/Identifier.h:

(JSC::Identifier::ascii):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::print):

  • runtime/UString.cpp:

(JSC::UString::ascii):
(JSC::UString::latin1):

  • runtime/UString.h:
  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::asciiOLD):

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.cpp:

(WTF::String::ascii):
(WTF::String::latin1):

  • wtf/text/WTFString.h:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/c/c_class.cpp:

(JSC::Bindings::CClass::methodsNamed):
(JSC::Bindings::CClass::fieldNamed):

  • bridge/jni/jsc/JNIBridgeJSC.cpp:

(JavaField::valueFromInstance):
(JavaField::setValueToInstance):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::methodsNamed):
(JSC::Bindings::ObjcClass::fieldNamed):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):

  • loader/icon/IconRecord.cpp:
  • platform/sql/SQLiteDatabase.cpp:
  • platform/sql/SQLiteStatement.cpp:
  • storage/SQLStatement.cpp:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

5:34 PM Changeset in webkit [65343] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-08-13 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
check for exceptions on all threads, not just the first thread.

This change also changes the logging behavior for wedged threads
to only dump the stacks of threads that are actually wedged.

Refactor the thread classes in the dump_render_tree_thread module
to make the contract between TestRunner and TestShellThread clearer.

Added a bunch of unit tests.
​https://bugs.webkit.org/show_bug.cgi?id=38561

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:59 PM Changeset in webkit [65342] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • WebKit2.xcodeproj/project.pbxproj: Make WKDictionary.h public.
4:44 PM Changeset in webkit [65341] by weinig@apple.com
  • 9 edits in trunk/WebKit2

Pass values map to willSubmitForm in WebKit2 API
Part of <rdar://problem/8255932>
​https://bugs.webkit.org/show_bug.cgi?id=43995

Reviewed by Brady Eidson.

  • Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::):
Add overload for std::pair.

  • Shared/ImmutableDictionary.h:

(WebKit::ImmutableDictionary::adopt):
Fix function signature by removing size parameter.

  • UIProcess/API/C/WKPage.h:

Add dictionary parameter to callback.

  • UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):
Create an ImmutableDictionary from the vector of string pairs.

  • UIProcess/WebFormClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::willSubmitForm):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
Plumb through the values vector.

4:35 PM Changeset in webkit [65340] by commit-queue@webkit.org
  • 65 edits
    1 copy
    9 adds
    4 deletes in trunk

2010-08-13 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Session history should skip over JS redirects
​https://bugs.webkit.org/show_bug.cgi?id=42861

Lock the back/forward list for location changes and form submits that
happen before the onload event fires that are not the result of user
gestures.

http/tests/history tests now pass, their expectations were updated
accordingly. Other tests needed a setTimeout wrapper around location
changes and form submits during onload, otherwise they would not
generate history entries as expected anymore.

  • fast/css/target-fragment-match.html:
  • fast/dom/location-hash.html:
  • fast/dom/Geolocation/resources/cached-page-1.html:
  • fast/dom/Window/timer-resume-on-navigation-back.html:
  • fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt:
  • fast/events/pageshow-pagehide-on-back-cached-with-frames.html:
  • fast/forms/button-state-restore.html:
  • fast/forms/state-restore-to-non-autocomplete-form.html:
  • fast/forms/state-restore-to-non-edited-controls.html:
  • fast/frames/resources/cached-page-1.html:
  • fast/frames/resources/cached-page-2.html:
  • fast/harness/resources/cached-page-1.html:
  • fast/harness/resources/cached-page-with-data-urls.html:
  • fast/history/gesture-before-onload-expected.txt: Added.
  • fast/history/gesture-before-onload.html: Added.
  • fast/history/history-length.html:
  • fast/history/resources/gesture-before-onload-target.html: Added.
  • fast/history/saves-state-after-fragment-nav.html:
  • fast/loader/input-element-page-cache-crash.html:
  • fast/loader/stateobjects/document-destroyed-navigate-back.html:
  • fast/loader/stateobjects/pushstate-clears-forward-history.html:
  • fast/loader/subframe-navigate-during-main-frame-load.html:
  • http/tests/history/back-to-post.php:
  • http/tests/history/redirect-js-document-location-before-load-expected.txt:
  • http/tests/history/redirect-js-form-submit-before-load-expected.txt:
  • http/tests/history/redirect-js-location-assign-before-load-expected.txt:
  • http/tests/history/redirect-js-location-before-load-expected.txt:
  • http/tests/history/redirect-js-location-href-before-load-expected.txt:
  • http/tests/loading/307-after-303-after-post-expected.txt:
  • http/tests/loading/redirect-methods-expected.txt:
  • http/tests/navigation/resources/back-send-referrer-helper.php:
  • http/tests/navigation/resources/document-location.js: (start):
  • http/tests/navigation/resources/submit-to-fragment.pl:
  • security/autocomplete-cleared-on-back.html:
  • storage/hash-change-with-xhr.js: (updateDatabase): (invokeBack): (runTest): (runTestsInner):

2010-08-13 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Session history should skip over JS redirects
​https://bugs.webkit.org/show_bug.cgi?id=42861

Lock the back/forward list for location changes and form submits that
happen before the onload event fires that are not the result of user
gestures.

Made form submission (at the ScheduledFormSubmission level) more similar
to ScheduledURLNavigation by having it call clientRedirected too, fixing
a long-standing FIXME.

Test: fast/history/gesture-before-onload-location-href.html,
fast/history/gesture-before-onload-form-submit.html and updated
expectations for http/tests/history tests that used to fail.

  • loader/FormSubmission.cpp: (WebCore::FormSubmission::requestURL): (WebCore::FormSubmission::populateFrameLoadRequest):
  • loader/FormSubmission.h:
  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::ScheduledFormSubmission::didStartTimer): (WebCore::ScheduledFormSubmission::didStopTimer): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission):
  • loader/RedirectScheduler.h:
2:33 PM Changeset in webkit [65339] by weinig@apple.com
  • 8 edits
    4 adds in trunk/WebKit2

Add dictionary API type
​https://bugs.webkit.org/show_bug.cgi?id=43990

Reviewed by Brady Eidson.

Add an immutable dictionary type (WKStringRef -> WKTypeRef).

  • Shared/APIObject.h:

(WebKit::APIObject::):
Add new APIType.

  • Shared/ImmutableDictionary.cpp: Added.

(WebKit::ImmutableDictionary::ImmutableDictionary):
(WebKit::ImmutableDictionary::~ImmutableDictionary):

  • Shared/ImmutableDictionary.h: Added.

(WebKit::ImmutableDictionary::create):
(WebKit::ImmutableDictionary::adopt):
(WebKit::ImmutableDictionary::get):
(WebKit::ImmutableDictionary::size):
(WebKit::ImmutableDictionary::):
(WebKit::ImmutableDictionary::type):
Add basic implementation

  • UIProcess/API/C/WKAPICast.h:

(WebKit::):
Add new mappings.

  • UIProcess/API/C/WKBase.h:

Add new opaque type.

  • UIProcess/API/C/WKDictionary.cpp: Added.

(WKDictionaryGetTypeID):
(WKDictionaryGetItemForKey):
(WKDictionaryGetSize):
(WKDictionaryRetain):
(WKDictionaryRelease):

  • UIProcess/API/C/WKDictionary.h: Added.

Add API wrappings.

  • UIProcess/API/C/WebKit2.h:

Add missing public headers.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

2:03 PM Changeset in webkit [65338] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add two more unsupported tests to the WebKit2 skipped list.

Rubber-stamped by Beth Dakin and Ban Bernstein.

  • platform/mac-wk2/Skipped:
1:11 PM Changeset in webkit [65337] by weinig@apple.com
  • 18 edits
    2 copies
    6 adds in trunk/WebKit2

Add form submission listener to WebKit2
Part of <rdar://problem/8255932>
​https://bugs.webkit.org/show_bug.cgi?id=43947

Reviewed by Jon Honeycutt.

  • Shared/APIObject.h:

Add TypeFormSubmissionListener APIType.

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

Add WillSubmitForm message kind.

  • UIProcess/API/C/WKAPICast.h:

Add new mappings for WKFormSubmissionListenerRef -> WebFormSubmissionListener

  • UIProcess/API/C/WKBase.h:

Add OpaqueWKFormSubmissionListener and rename the other opaque types to match.

  • UIProcess/API/C/WKFormSubmissionListener.cpp: Added.

(WKFormSubmissionListenerGetTypeID):
(WKFormSubmissionListenerContinue):
(WKFormSubmissionListenerRetain):
(WKFormSubmissionListenerRelease):

  • UIProcess/API/C/WKFormSubmissionListener.h: Added.

Add C wrapper for WebFormSubmissionListener.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageFormClient):

  • UIProcess/API/C/WKPage.h:

Add WKPageFormClient with willSubmitForm callback. Additional callbacks will be added as
needed.

  • UIProcess/API/C/WebKit2.h:

Add include for WKFormSubmissionListener.h

  • UIProcess/WebFormClient.cpp: Added.

(WebKit::WebFormClient::WebFormClient):
(WebKit::WebFormClient::initialize):
(WebKit::WebFormClient::willSubmitForm):

  • UIProcess/WebFormClient.h: Added.

Add client for form related delagations.

  • UIProcess/WebFormSubmissionListenerProxy.cpp: Added.

(WebKit::WebFormSubmissionListenerProxy::WebFormSubmissionListenerProxy):
(WebKit::WebFormSubmissionListenerProxy::continueSubmission):

  • UIProcess/WebFormSubmissionListenerProxy.h: Added.

(WebKit::WebFormSubmissionListenerProxy::create):
(WebKit::WebFormSubmissionListenerProxy::type):

  • UIProcess/WebFrameListenerProxy.cpp: Copied from UIProcess/WebFramePolicyListenerProxy.cpp.

Add new type of listener for form submissions. It inherits from the new base class
for listeners, WebFrameListenerProxy.

(WebKit::WebFrameListenerProxy::WebFrameListenerProxy):
(WebKit::WebFrameListenerProxy::~WebFrameListenerProxy):
(WebKit::WebFrameListenerProxy::invalidate):
(WebKit::WebFrameListenerProxy::receivedPolicyDecision):

  • UIProcess/WebFrameListenerProxy.h: Copied from UIProcess/WebFramePolicyListenerProxy.h.

Move logic that would have to be shared between WebFramePolicyListenerProxy and
WebFormSubmissionListenerProxy into shared base class.

  • UIProcess/WebFramePolicyListenerProxy.cpp:

(WebKit::WebFramePolicyListenerProxy::WebFramePolicyListenerProxy):

  • UIProcess/WebFramePolicyListenerProxy.h:

(WebKit::WebFramePolicyListenerProxy::create):
(WebKit::WebFramePolicyListenerProxy::type):
Move to inheriting from WebFrameListenerProxy.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::disconnect):
(WebKit::WebFrameProxy::receivedPolicyDecision):
(WebKit::WebFrameProxy::setUpPolicyListenerProxy):
(WebKit::WebFrameProxy::setUpFormSubmissionListenerProxy):

  • UIProcess/WebFrameProxy.h:

Change listener functions to act on WebFrameListenerProxys and add setUpFormSubmissionListenerProxy.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeFormClient):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::willSubmitForm):

  • UIProcess/WebPageProxy.h:

Plumb through willSubmitForm call as we do with the other listeners.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
Ditto.

  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • win/WebKit2.vcproj: Add new files.
  • win/WebKit2Generated.make: Ditto.
12:09 PM Changeset in webkit [65336] by leandro@webkit.org
  • 2 edits in trunk/WebCore

2010-08-13 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed build fix.
These changes were supposed to be landed on r65319, but due to some
svn-apply/commit-queue bug it wasn't fully applied. A bug was filed
by Patrick Gansterer (author of the changes in this commit):
​https://bugs.webkit.org/show_bug.cgi?id=43981

  • CMakeLists.txt: Update calls to GENERATE_GPERF and GENERATE_GRAMMAR macros.
11:49 AM Changeset in webkit [65335] by Chris Fleizach
  • 6 edits
    2 adds in trunk

AX: isNativeCheckbox does not work as advertised
​https://bugs.webkit.org/show_bug.cgi?id=43872

Re-adding this patch after it was erroneously rolled out.

WebCore:

Test: platform/mac/accessibility/native-vs-nonnative-checkboxes.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isInputImage):
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):

  • dom/InputElement.h:
  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::isCheckbox):

LayoutTests:

  • platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Added.
  • platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Added.
11:05 AM Changeset in webkit [65334] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65331.
​http://trac.webkit.org/changeset/65331
​https://bugs.webkit.org/show_bug.cgi?id=43980

This patch breaks some shadow tests on Qt Linux release
(Requested by ariya on #webkit).

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow):
10:39 AM Changeset in webkit [65333] by kinuko@chromium.org
  • 6 edits in trunk/WebCore

2010-08-13 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Update run-bindings-tests expectations
​https://bugs.webkit.org/show_bug.cgi?id=43944

The results have become out of sync after changeset 64552 and 65269.

Test: WebKitTools/Scripts/run-bindings-tests

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type):
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws): (webkit_dom_test_obj_serialized_value): (webkit_dom_test_obj_idb_key): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad): (webkit_dom_test_obj_with_script_state_obj): (webkit_dom_test_obj_with_script_state_obj_exception): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_xml_obj_attr): (webkit_dom_test_obj_set_xml_obj_attr): (webkit_dom_test_obj_get_reflected_string_attr): (webkit_dom_test_obj_set_reflected_string_attr): (webkit_dom_test_obj_get_reflected_url_attr): (webkit_dom_test_obj_set_reflected_url_attr): (webkit_dom_test_obj_get_reflected_non_empty_url_attr): (webkit_dom_test_obj_set_reflected_non_empty_url_attr): (webkit_dom_test_obj_get_reflected_custom_url_attr): (webkit_dom_test_obj_set_reflected_custom_url_attr): (webkit_dom_test_obj_get_reflected_custom_non_empty_url_attr): (webkit_dom_test_obj_set_reflected_custom_non_empty_url_attr): (webkit_dom_test_obj_get_string_attr_with_getter_exception): (webkit_dom_test_obj_set_string_attr_with_getter_exception): (webkit_dom_test_obj_get_string_attr_with_setter_exception): (webkit_dom_test_obj_set_string_attr_with_setter_exception): (webkit_dom_test_obj_get_script_string_attr): (webkit_dom_test_obj_get_hash): (webkit_dom_test_obj_class_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
10:35 AM Changeset in webkit [65332] by leandro@webkit.org
  • 3 edits in trunk

2010-08-13 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed build fix.

  • cmake/FindGthread.cmake: Fix warnings about obsolete PKGCONFIG macro.
  • cmake/WebKitGenerators.cmake: FLEX_EXECUTABLE was defined already by the root CMakeLists.txt file, so remove relevant lines that depends on FIND_PACKAGE_HANDLE_STANDARD_ARGS macro, which isn't available anymore.
10:24 AM Changeset in webkit [65331] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2010-08-13 Ariya Hidayat <​ariya@sencha.com>

Reviewed by Simon Hausmann.

[Qt] Canvas and CSS: blur option in shadow not working
​https://bugs.webkit.org/show_bug.cgi?id=34479

Patch 1: Refactor shadow states handling.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::): Added shadow states as member variables. (WebCore::GraphicsContextPlatformPrivate::hasShadow): Convenient function to check whether there is shadow or not. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::drawRect): Use shadow states instead of calling getShadow. (WebCore::GraphicsContext::drawLine): ditto. (WebCore::GraphicsContext::strokeArc): ditto. (WebCore::GraphicsContext::drawConvexPolygon): ditto. (WebCore::GraphicsContext::fillPath): ditto. (WebCore::GraphicsContext::strokePath): ditto. (WebCore::GraphicsContext::fillRect): Removes the use of helper function drawBorderlessRectShadow as the code already becomes a lot simpler. (WebCore::GraphicsContext::fillRoundedRect): Removes the use of helper function drawFilledShadowPath as the code already becomes a lot simpler. (WebCore::GraphicsContext::setPlatformShadow): Store shadow states and find out the shadow type (complexity) for future use. (WebCore::GraphicsContext::clearPlatformShadow): Reset shadow states.
10:12 AM Changeset in webkit [65330] by zmo@google.com
  • 9 edits in trunk

2010-08-11 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Regression in linking of programs
​https://bugs.webkit.org/show_bug.cgi?id=43820

Shaders and programs shouldn't be deleted until their attachments are removed, therefore, we need to track the attach/detach/useProgram.

  • html/canvas/WebGLObject.cpp: Track the object attachment count and whether it should really be deleted. (WebCore::WebGLObject::WebGLObject): (WebCore::WebGLObject::setObject): (WebCore::WebGLObject::deleteObject):
  • html/canvas/WebGLObject.h: Track the object attachment count and whether it should really be deleted. (WebCore::WebGLObject::onAttached): (WebCore::WebGLObject::onDetached): (WebCore::WebGLObject::getAttachmentCount):
  • html/canvas/WebGLProgram.cpp: Track the attached shaders. (WebCore::WebGLProgram::WebGLProgram): (WebCore::WebGLProgram::deleteObjectImpl): (WebCore::WebGLProgram::getAttachedShader): (WebCore::WebGLProgram::attachShader): (WebCore::WebGLProgram::detachShader):
  • html/canvas/WebGLProgram.h: Track the attached shaders.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::attachShader): Track the attachment of a shader to a program. (WebCore::WebGLRenderingContext::deleteProgram): Detach shaders. (WebCore::WebGLRenderingContext::detachShader): Track the attachment of a shader to a program. (WebCore::WebGLRenderingContext::validateWebGLObject): Also check if object == 0. (WebCore::WebGLRenderingContext::linkProgram): Using the cached attached shaders instead of query from driver. (WebCore::WebGLRenderingContext::useProgram): Track the attachment of a program to the current rendering pipeline.

2010-08-11 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Regression in linking of programs
​https://bugs.webkit.org/show_bug.cgi?id=43820

  • fast/canvas/webgl/program-test-expected.txt: Fix the tests so a second shader of the same type attaching to a program will generate error; also, add tests for deleteShader/deleteProgram behavior.
  • fast/canvas/webgl/program-test.html: Ditto.
10:02 AM Changeset in webkit [65329] by steveblock@google.com
  • 4 edits
    5 adds in trunk

2010-08-13 Steve Block <​steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Geolocation activity started after frame has been disconnected can cause crash
​https://bugs.webkit.org/show_bug.cgi?id=39879

New requests started after the Frame has been disconnected are ignored. We do
not invoke the error callback as this would allow buggy or malicious pages to
hose the CPU. Such a page could hold a reference to a Geolocation object from
a since closed Page and register new requests from the error callback to
create an infinite loop.

Tests: fast/dom/Geolocation/disconnected-frame-already.html

  • page/Geolocation.cpp:

2010-08-13 Steve Block <​steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Geolocation activity started after frame has been disconnected can cause crash
​https://bugs.webkit.org/show_bug.cgi?id=39879

Added new tests to GTK skipped list.

  • fast/dom/Geolocation/disconnected-frame-already.html: Added.
  • fast/dom/Geolocation/disconnected-frame-already-expected.txt: Added.
  • fast/dom/Geolocation/script-tests/disconnected-frame-already.js: Added.
  • fast/dom/Geolocation/resources/disconnected-frame-already-inner1.html: Added.
  • fast/dom/Geolocation/resources/disconnected-frame-already-inner2.html: Added.
  • platform/gtk/Skipped:
9:51 AM Changeset in webkit [65328] by alex
  • 2 edits in trunk

2010-08-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

We have to add the ACLOCAL_FLAGS in the env to the autogen.sh
ACLOCAL_FLAGS variable in order to honor the value already
defined, jhbuild uses it to pass parameters.

  • autogen.sh:
9:49 AM Changeset in webkit [65327] by commit-queue@webkit.org
  • 16 edits in trunk

2010-08-13 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Support for multiple speech enabled elements in same page.
​https://bugs.webkit.org/show_bug.cgi?id=43922

  • page/SpeechInput.cpp: Generates request ids as necessary when each speech enabled input element gets created/destroyed and multiplexes the listener callbacks to the appropriate input element based on the request id. (WebCore::SpeechInput::SpeechInput): (WebCore::SpeechInput::~SpeechInput): (WebCore::SpeechInput::registerListener): (WebCore::SpeechInput::unregisterListener): (WebCore::SpeechInput::didCompleteRecording): (WebCore::SpeechInput::didCompleteRecognition): (WebCore::SpeechInput::setRecognitionResult): (WebCore::SpeechInput::startRecognition): (WebCore::SpeechInput::stopRecording): (WebCore::SpeechInput::cancelRecognition):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h: Now requires a one time set for the WebCore::SpeechInputListener and takes in a 'requestId' for all calls.
  • page/SpeechInputListener.h: Now returns the above mentioned requestId in all the listener callbacks for identifying which input element the event goes to.
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::SpeechInputClientMock): (WebCore::SpeechInputClientMock::setListener): (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::stopRecording): (WebCore::SpeechInputClientMock::cancelRecognition): (WebCore::SpeechInputClientMock::timerFired):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::~InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::speechInput): (WebCore::InputFieldSpeechButtonElement::didCompleteRecording): (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition): (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
  • rendering/TextControlInnerElements.h:

2010-08-13 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Support for multiple speech enabled elements in same page.
​https://bugs.webkit.org/show_bug.cgi?id=43922

  • public/WebSpeechInputController.h: Bubbles up the requestId given by webcore to the embedder. (WebKit::WebSpeechInputController::startRecognition): (WebKit::WebSpeechInputController::cancelRecognition): (WebKit::WebSpeechInputController::stopRecording):
  • public/WebSpeechInputListener.h: Passes down the requestId given by embedder to webcore. (WebKit::WebSpeechInputListener::didCompleteRecording): (WebKit::WebSpeechInputListener::setRecognitionResult): (WebKit::WebSpeechInputListener::didCompleteRecognition):
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::setListener): (WebKit::SpeechInputClientImpl::startRecognition): (WebKit::SpeechInputClientImpl::stopRecording): (WebKit::SpeechInputClientImpl::cancelRecognition): (WebKit::SpeechInputClientImpl::didCompleteRecording): (WebKit::SpeechInputClientImpl::didCompleteRecognition): (WebKit::SpeechInputClientImpl::setRecognitionResult):
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl): (WebKit::WebSpeechInputControllerMockImpl::~WebSpeechInputControllerMockImpl): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecording): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecognition): (WebKit::WebSpeechInputControllerMockImpl::setRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition): (WebKit::WebSpeechInputControllerMockImpl::cancelRecognition): (WebKit::WebSpeechInputControllerMockImpl::stopRecording):
  • src/WebSpeechInputControllerMockImpl.h:
9:27 AM Changeset in webkit [65326] by ariya@webkit.org
  • 3 edits in trunk/LayoutTests

2010-08-13 Ariya Hidayat <​ariya@sencha.com>

Rubber-stamped by Simon Hausmann.

[Qt] Outdated pixel test reference for basic-shadows.html
​https://bugs.webkit.org/show_bug.cgi?id=43952

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
9:22 AM Changeset in webkit [65325] by steveblock@google.com
  • 2 edits
    5 adds in trunk/LayoutTests

2010-08-13 Steve Block <​steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Need a LayoutTest to check that pages using Geolocation are not put in the page cache
​https://bugs.webkit.org/show_bug.cgi?id=43957

  • fast/dom/Geolocation/no-page-cache-expected.txt: Added.
  • fast/dom/Geolocation/no-page-cache.html: Added.
  • fast/dom/Geolocation/resources/cached-page-1.html: Added.
  • fast/dom/Geolocation/resources/cached-page-2.html: Added.
  • fast/dom/Geolocation/script-tests/no-page-cache.js: Added. (reportPageOneOnload):
  • platform/gtk/Skipped: Added new test to GTK skipped list
8:52 AM Changeset in webkit [65324] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-08-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by David Kilzer.

HTMLMediaElement::prepareForLoad should cancel current plug-in proxy media player
​https://bugs.webkit.org/show_bug.cgi?id=43923

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad): Tell mediaPlayer to cancel the current load if it already exists.
6:58 AM Changeset in webkit [65323] by senorblanco@chromium.org
  • 4 edits in trunk/WebCore

2010-08-12 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

[CHROMIUM] Use the BGRA format for canvas 2D accel upload and readbacks.
​https://bugs.webkit.org/show_bug.cgi?id=43804

Use the BGRA format from GraphicsContext3D, if supported. Also keep a
texture around for uploads, rather than re-creating it each time.

Covered by many layout tests (once we're running them).

  • platform/graphics/chromium/GLES2Texture.cpp: (WebCore::convertFormat): Move convertFormat() ahead of texture creation, so we can check for BGRA support. (WebCore::GLES2Texture::create): Use convertFormat() to determine the correct format and types to use; use the returned format also for internalFormat, since GLES2 insists they match.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setGraphicsContext3D): Clear the upload texture when a new context is set. (WebCore::PlatformContextSkia::uploadSoftwareToHardware): Use m_uploadTexture instead of creating a new one each time. (WebCore::PlatformContextSkia::readbackHardwareToSoftware): When the context supports it, use the BGRA format for readbacks instead of swizzling.
  • platform/graphics/skia/PlatformContextSkia.h: Add m_uploadTexture for consecutive uploads.
6:52 AM MathML Status edited by alex@milowski.com
(diff)
6:48 AM Changeset in webkit [65322] by Simon Hausmann
  • 2 edits in trunk

[Qt] Introduce Maemo6 for mobile features
​https://bugs.webkit.org/show_bug.cgi?id=43969

Reviewed by Ariya Hidayat.

  • WebKit.pri: Use maemo6 where we also use maemo5.
6:48 AM Changeset in webkit [65321] by Simon Hausmann
  • 4 edits in trunk

[Qt] Clean up mobile feature useage
​https://bugs.webkit.org/show_bug.cgi?id=43968

Reviewed by Ariya Hidayat.

.:

  • WebKit.pri: Set feature defaults here for some Nokia specific mobile platforms

WebCore:

  • WebCore.pro: Replaced use of Nokia specific platform scopes with concrete

feature names.

6:22 AM MathML Status edited by alex@milowski.com
(diff)
6:22 AM Changeset in webkit [65320] by pfeldman@chromium.org
  • 20 edits in trunk/WebCore

2010-08-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename InspectorValue::push and set to
push{Value|Object|Array} and set{...}.
​https://bugs.webkit.org/show_bug.cgi?id=43966

  • bindings/js/ScriptProfile.cpp: (WebCore::buildInspectorObjectFor):
  • bindings/js/ScriptValue.cpp: (WebCore::jsToInspectorValue):
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::stackTrace):
  • bindings/v8/ScriptProfile.cpp: (WebCore::buildInspectorObjectFor):
  • bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache): (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::buildArrayForCookies): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getRuleRanges): (WebCore::InspectorDOMAgent::buildObjectForAttributeStyles): (WebCore::InspectorDOMAgent::buildArrayForCSSRules): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::buildArrayForDisabledStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::saveBreakpoints):
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
  • inspector/InspectorStorageAgent.cpp: (WebCore::): (WebCore::InspectorStorageAgent::executeSQL):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::didScheduleResourceRequest): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
  • inspector/InspectorValues.cpp: (WebCore::): (WebCore::InspectorValue::asValue): (WebCore::InspectorValue::asObject): (WebCore::InspectorValue::asArray): (WebCore::InspectorObject::asObject): (WebCore::InspectorArray::asArray):
  • inspector/InspectorValues.h: (WebCore::InspectorObject::setBool): (WebCore::InspectorObject::setNumber): (WebCore::InspectorObject::setString): (WebCore::InspectorObject::setValue): (WebCore::InspectorObject::setObject): (WebCore::InspectorObject::setArray): (WebCore::InspectorArray::pushValue): (WebCore::InspectorArray::pushObject): (WebCore::InspectorArray::pushArray):
  • inspector/ScriptBreakpoint.cpp: (WebCore::ScriptBreakpoint::inspectorObjectFromSourceBreakpoints):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
6:18 AM MathML Status edited by alex@milowski.com
(diff)
6:16 AM Changeset in webkit [65319] by commit-queue@webkit.org
  • 3 edits in trunk

2010-08-13 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Nikolas Zimmermann.

[CMake] Cleanup generator code.
​https://bugs.webkit.org/show_bug.cgi?id=39164

  • cmake/WebKitGenerators.cmake:
  • cmake/WebKitMacros.cmake:
6:03 AM QtWebKitContrib edited by Ademar Reis
(diff)
6:02 AM Changeset in webkit [65318] by Nate Chapin
  • 2 edits
    1 add in trunk/LayoutTests

2010-08-13 Nate Chapin <Nate Chapin>

Unreviewed, Chromium test_expectations.txt updates + a rebaseline

  • platform/chromium-linux/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:54 AM Changeset in webkit [65317] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

2010-08-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65204.
​http://trac.webkit.org/changeset/65204
​https://bugs.webkit.org/show_bug.cgi?id=43965

Caused a lot of test crashes in Chromium (Requested by yutak
on #webkit).

  • platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Removed.
  • platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Removed.

2010-08-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65204.
​http://trac.webkit.org/changeset/65204
​https://bugs.webkit.org/show_bug.cgi?id=43965

Caused a lot of test crashes in Chromium (Requested by yutak
on #webkit).

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isInputImage): (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
  • dom/InputElement.h:
  • html/HTMLInputElement.h:
5:29 AM Changeset in webkit [65316] by antonm@chromium.org
  • 8 edits in trunk/WebCore

2010-08-13 Anton Muhin <​antonm@chromium.org>

Reviewed by Nate Chapin.

Reapplying ​http://trac.webkit.org/changeset/65284 after fixed include.

[v8] Create callbacks for named access of elements from document object on fly.
​https://bugs.webkit.org/show_bug.cgi?id=43725

That should speed up access to methods on document as there is no need to
consult with interceptor before invoking the method.

This reapplies ​http://trac.webkit.org/changeset/60670 reverted with
​http://trac.webkit.org/changeset/63845. The main difference is in treatment
of removed named elements: we don't remove an accessor any more, but leave it.
Therefore any accessor should be able to treat the case when there is no
expando property.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::removeItemFromMap):
5:11 AM Changeset in webkit [65315] by yurys@chromium.org
  • 7 edits in trunk/LayoutTests

2010-08-13 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: DRT sometimes crashes on debugger tests
​https://bugs.webkit.org/show_bug.cgi?id=43964
notifyDone() should be called only when debugger already resumed all active DOM objects,
otherwise we might accidentally call setTimeout in the inspected page and create
a new active DOM object while their set should remain unchanged when script execution
is paused.

  • inspector/debugger-cyclic-ref.html:
  • inspector/debugger-eval-while-paused.html:
  • inspector/debugger-no-nested-pause.html:
  • inspector/debugger-pause-in-eval-script.html:
  • inspector/debugger-pause-on-debugger-statement.html:
  • inspector/debugger-proto-property.html:
5:08 AM Changeset in webkit [65314] by pfeldman@chromium.org
  • 9 edits in trunk/WebCore

2010-08-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove openInInspectorWindow and evaluateAndStringify from InjectedScript.
​https://bugs.webkit.org/show_bug.cgi?id=43854

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::openInInspectedWindow):
  • inspector/InspectorController.h:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage.callback): (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/InspectorBackendStub.js: (WebInspector.InspectorBackendStub):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
5:01 AM Changeset in webkit [65313] by ukai@chromium.org
  • 3 edits in trunk/WebCore

2010-08-13 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

flaky websocket/tests/frame-length-overflow.html
​https://bugs.webkit.org/show_bug.cgi?id=43902

Add m_shouldDiscardReceivedData flag to indicate it will no longer
receive data from network.

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::didReceiveData): (WebCore::WebSocketChannel::didFail): (WebCore::WebSocketChannel::processBuffer):
  • when frame length overflows, we couldn't process data any more. clear buffer and mark m_shouldDiscardReceivedData true to make sure it doesn't process the same buffer again.
  • websockets/WebSocketChannel.h:
4:50 AM WinCE edited by paroga@paroga.com
(diff)
4:12 AM QtWebKitWeeklyBuilds edited by Simon Hausmann
(diff)
4:12 AM MathML edited by alex@milowski.com
(diff)
4:09 AM MathML Status edited by alex@milowski.com
(diff)
3:42 AM MathML Status edited by alex@milowski.com
(diff)
3:28 AM MathML Status edited by alex@milowski.com
(diff)
3:26 AM MathML Status edited by alex@milowski.com
(diff)
3:21 AM MathML Status edited by alex@milowski.com
(diff)
3:15 AM Changeset in webkit [65312] by krit@webkit.org
  • 16 edits
    2 adds in trunk/WebCore

2010-08-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Use SVGPathByteStream to animate SVGPath
​https://bugs.webkit.org/show_bug.cgi?id=43929

Use SVGPathByteStream to perform animations of Paths. SVGPathBlender blends
the starting point to the end point according to the current progress value.
Cleanup SVGPathSegList, by removing the unnecessary legacy blending code.

No new tests because no functional changes.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGAnimateElement.h:
  • svg/SVGPathBlender.cpp: Added. (WebCore::SVGPathBlender::SVGPathBlender): (WebCore::SVGPathBlender::~SVGPathBlender): (WebCore::SVGPathBlender::blendAnimatedFloat): (WebCore::SVGPathBlender::blendAnimatedFloatPoint): (WebCore::SVGPathBlender::blendMoveToSegment): (WebCore::SVGPathBlender::blendLineToSegment): (WebCore::SVGPathBlender::blendLineToHorizontalSegment): (WebCore::SVGPathBlender::blendLineToVerticalSegment): (WebCore::SVGPathBlender::blendCurveToCubicSegment): (WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment): (WebCore::SVGPathBlender::blendCurveToQuadraticSegment): (WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment): (WebCore::SVGPathBlender::blendArcToSegment): (WebCore::SVGPathBlender::blendAnimatedPath): (WebCore::SVGPathBlender::cleanup):
  • svg/SVGPathBlender.h: Added.
  • svg/SVGPathParserFactory.cpp: (WebCore::globalSVGPathBlender): (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
  • svg/SVGPathSegList.h: (WebCore::SVGPathSegList::create):
  • svg/SVGPointList.cpp: (WebCore::adjustAnimatedValue):
3:14 AM Changeset in webkit [65311] by loki@webkit.org
  • 12 edits in trunk/JavaScriptCore

Avoid increasing required alignment of target type warning on ARM
​https://bugs.webkit.org/show_bug.cgi?id=38045

Reviewed by Gavin Barraclough.

The reinterpret_cast<Type1*>([pointer to Type2]) expressions - where
sizeof(Type1) > sizeof(Type2) - cause the following warning on ARM:
increases required alignment of target type warnings.
Casting the type of [pointer to Type2] object to void* bypasses the
warning.

(JSC::ARMAssembler::executableCopy):

(JSC::AssemblerBuffer::putShortUnchecked):
(JSC::AssemblerBuffer::putIntUnchecked):
(JSC::AssemblerBuffer::putInt64Unchecked):

(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):

(jsRegExpCompile):

(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):

(WTF::PageHeapAllocator::New):
(WTF::TCMalloc_Central_FreeList::Populate):

  • wtf/MD5.cpp:

(WTF::reverseBytes):
(WTF::MD5::addBytes):
(WTF::MD5::checksum):

(isPointerTypeAlignmentOkay):
(reinterpret_cast_ptr):

(WTF::VectorBuffer::inlineBuffer):

(WTF::String::String):

3:14 AM MathML edited by alex@milowski.com
(diff)
3:03 AM Changeset in webkit [65310] by Nikolas Zimmermann
  • 25 edits
    4 adds in trunk

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Window size changes + resources on absolute sized content leads to pixelation
​https://bugs.webkit.org/show_bug.cgi?id=43921

Avoid pixelation when using resources on absolute sized objects. Be sure to invalidate the used resources if window size changes.
Otherwhise masks etc. will be scaled up and pixelate. As nice side-effect, this fixes run-webkit-tests --singly svg/W3C-SVG-1.1, which
used to produce wrong results for the gradient tests, as the window size change from 800x600 for 480x360 (svg/W3C-SVG-1.1 specific DRT quirk)
didn't invalidate the resources.

Renamed invalidateClient -> removeClientFromCache and invalidateClients -> removeAllClientsFromCache.
Add a boolean "markForInvalidation" parameter, that controls wheter the clients should be marked for repaint/boundaries invalidation/layout
or wheter we only want to notify the parents that the resource changed, to avoid doing unncessary work in SVGRenderSupport::layoutChildren.

Test: svg/custom/absolute-sized-content-with-resources.xhtml

  • rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::styleDidChange): Don't do anything for StyleDifferenceEqual.
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):
  • rendering/RenderSVGResource.cpp: (WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::removeAllClientsFromCache): (WebCore::RenderSVGResourceClipper::removeClientFromCache):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::layout): (WebCore::RenderSVGResourceContainer::idChanged): (WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation): (WebCore::RenderSVGResourceContainer::markClientForInvalidation):
  • rendering/RenderSVGResourceContainer.h: (WebCore::RenderSVGResourceContainer::):
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::removeAllClientsFromCache): (WebCore::RenderSVGResourceFilter::removeClientFromCache): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::removeAllClientsFromCache): (WebCore::RenderSVGResourceGradient::removeClientFromCache): (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/RenderSVGResourceGradient.h:
  • rendering/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::layout): (WebCore::RenderSVGResourceMarker::removeAllClientsFromCache): (WebCore::RenderSVGResourceMarker::removeClientFromCache):
  • rendering/RenderSVGResourceMarker.h:
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::removeAllClientsFromCache): (WebCore::RenderSVGResourceMasker::removeClientFromCache):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::removeAllClientsFromCache): (WebCore::RenderSVGResourcePattern::removeClientFromCache): (WebCore::RenderSVGResourcePattern::applyResource):
  • rendering/RenderSVGResourcePattern.h:
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::removeAllClientsFromCache): (WebCore::RenderSVGResourceSolidColor::removeClientFromCache):
  • rendering/SVGRenderSupport.cpp: (WebCore::invalidateResourcesOfChildren): Add new helper funtion recursively invalidating resources of a sub render tree. (WebCore::SVGRenderSupport::layoutChildren): Keep track of all objects that didn't need layout, as we still have to invalidate their resources, if window size changes.
  • rendering/SVGResources.cpp: (WebCore::SVGResources::removeClientFromCache): (WebCore::SVGResources::resourceDestroyed):
  • rendering/SVGResources.h:
  • rendering/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::clientLayoutChanged):

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Window size changes + resources on absolute sized content leads to pixelation
​https://bugs.webkit.org/show_bug.cgi?id=43921

  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.checksum: Added.
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
  • svg/custom/absolute-sized-content-with-resources.xhtml: Added.
2:55 AM Changeset in webkit [65309] by pfeldman@chromium.org
  • 2 edits
    5 moves
    3 adds in trunk/LayoutTests

2010-08-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: brush up test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=43959

  • platform/chromium/inspector/console-dir-expected.txt: Added.
  • platform/chromium/inspector/console-format-expected.txt: Added.
  • platform/chromium/inspector/timeline-event-dispatch-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-event-dispatch-expected.txt.
  • platform/chromium/inspector/timeline-mark-timeline-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-mark-timeline-expected.txt.
  • platform/chromium/inspector/timeline-network-resource-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-network-resource-expected.txt.
  • platform/chromium/inspector/timeline-paint-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-paint-expected.txt.
  • platform/chromium/inspector/timeline-parse-html-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-parse-html-expected.txt.
  • platform/chromium/test_expectations.txt:
1:54 AM Changeset in webkit [65308] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk/WebKitTools

2010-08-13 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Shinichiro Hamaji.

Add test_expectations.txt syntax checker to check-webkit-style.
​https://bugs.webkit.org/show_bug.cgi?id=43899

Just utilizing layout_tests/layout_package/test_expectations.py for checking
the syntax of test_expectations.txt.
This change also moves tab checking class from style/checkers/text.py to
style/checkers/common.py for sharing code.

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checkers/common.py:
  • Scripts/webkitpy/style/checkers/common_unittest.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py: Added.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
  • Scripts/webkitpy/style/checkers/text.py:
  • Scripts/webkitpy/style_references.py:
1:42 AM Changeset in webkit [65307] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-08-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: [CRASH] Autocomplete on arrays causes crashes.
​https://bugs.webkit.org/show_bug.cgi?id=43955

  • bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue):
1:38 AM Changeset in webkit [65306] by commit-queue@webkit.org
  • 2 edits in trunk

2010-08-13 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Nikolas Zimmermann.

[CMake] Add missing FIND_PACKAGE(Gperf)
​https://bugs.webkit.org/show_bug.cgi?id=43937

  • CMakeLists.txt:
12:35 AM Changeset in webkit [65305] by barraclough@apple.com
  • 41 edits in trunk

Unify UString::UTF8String() & String::utf8() methods,
remove UString::cost() & make atArrayIndex a free function.

Reviewed by Sam Weinig

JavaScriptCore:

(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpName):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):

  • jsc.cpp:

(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):

  • pcre/pcre_exec.cpp:

(Histogram::~Histogram):

  • profiler/CallIdentifier.h:

(JSC::CallIdentifier::c_str):

  • profiler/Profile.cpp:

(JSC::Profile::debugPrintDataSampleStyle):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):

  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):

  • runtime/DateConversion.cpp:

(JSC::parseDate):

  • runtime/Identifier.h:

(JSC::Identifier::toStrictUInt32):

  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):

  • runtime/JSArray.h:

(JSC::toArrayIndex):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::parseInt):
(JSC::globalFuncJSCPrint):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):

  • runtime/UString.cpp:

(JSC::UString::toDouble):
(JSC::putUTF8Triple):
(JSC::UString::utf8):

  • runtime/UString.h:

(JSC::UString::~UString):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):

  • wtf/text/WTFString.cpp:

(WTF::String::utf8):

  • wtf/text/WTFString.h:

(WTF::String::~String):
(WTF::String::swap):
(WTF::String::isNull):
(WTF::String::isEmpty):
(WTF::String::impl):
(WTF::String::length):
(WTF::String::String):
(WTF::String::isHashTableDeletedValue):

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):

  • bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/jni/JNIBridge.cpp:

(JavaParameter::JavaParameter):
(JavaMethod::JavaMethod):
(JavaMethod::signature):
(JavaMethod::methodID):

  • bridge/jni/JNIBridge.h:

(JSC::Bindings::JavaString::utf8):
(JSC::Bindings::JavaParameter::type):
(JSC::Bindings::JavaMethod::returnType):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
(JavaJSObject::convertJObjectToValue):

  • bridge/jni/jsc/JNIBridgeJSC.cpp:

(JavaField::JavaField):
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):

  • bridge/jni/jsc/JNIBridgeJSC.h:

(JSC::Bindings::JavaField::type):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::utf8):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::put):

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate):

WebKit/wx:

  • WebFrame.cpp:

(wxWebFrame::RunScript):

WebKit2:

  • WebProcess/Plugins/JSNPObject.cpp:

(WebKit::npIdentifierFromIdentifier):

  • WebProcess/Plugins/NPJSObject.cpp:

(WebKit::NPJSObject::enumerate):

  • WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

Aug 12, 2010:

11:58 PM Changeset in webkit [65304] by yurys@chromium.org
  • 10 edits in trunk

2010-08-12 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: allow interrupting long running JS to execute inspector command
​https://bugs.webkit.org/show_bug.cgi?id=43900

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::): (WebCore::ScriptDebugServer::pause): (WebCore::ScriptDebugServer::interruptAndRun): (WebCore::ScriptDebugServer::runPendingTasks): (WebCore::ScriptDebugServer::handleV8DebugEvent):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::Task::~Task):

2010-08-12 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: allow interrupting long running JS to execute inspector command
​https://bugs.webkit.org/show_bug.cgi?id=43900

  • public/WebDevToolsAgent.h: (WebKit::WebDevToolsAgent::MessageDescriptor::~MessageDescriptor):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::interruptAndDispatch): (WebKit::WebDevToolsAgent::shouldInterruptForMessage): (WebKit::WebDevToolsAgent::processPendingMessages):
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
  • src/WebDevToolsFrontendImpl.h:
  • src/js/DevTools.js:
11:49 PM Changeset in webkit [65303] by zherczeg@webkit.org
  • 3 edits in trunk/JavaScriptCore

Refactoring the fpu code generator for the ARM port
​https://bugs.webkit.org/show_bug.cgi?id=43842

Reviewed by Gavin Barraclough.

Support up to 32 double precision registers, and the
recent VFP instruction formats. This patch is mainly
a style change which keeps the current functionality.

  • assembler/ARMAssembler.h:

(JSC::ARMRegisters::):
(JSC::ARMAssembler::):
(JSC::ARMAssembler::emitInst):
(JSC::ARMAssembler::emitDoublePrecisionInst):
(JSC::ARMAssembler::emitSinglePrecisionInst):
(JSC::ARMAssembler::vadd_f64_r):
(JSC::ARMAssembler::vdiv_f64_r):
(JSC::ARMAssembler::vsub_f64_r):
(JSC::ARMAssembler::vmul_f64_r):
(JSC::ARMAssembler::vcmp_f64_r):
(JSC::ARMAssembler::vsqrt_f64_r):
(JSC::ARMAssembler::vmov_vfp_r):
(JSC::ARMAssembler::vmov_arm_r):
(JSC::ARMAssembler::vcvt_f64_s32_r):
(JSC::ARMAssembler::vcvt_s32_f64_r):
(JSC::ARMAssembler::vmrs_apsr):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::sqrtDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):

11:42 PM Changeset in webkit [65302] by Csaba Osztrogonác
  • 41 edits in trunk

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65295.
​http://trac.webkit.org/changeset/65295
​https://bugs.webkit.org/show_bug.cgi?id=43950

It broke 4 sputnik tests (Requested by Ossy on #webkit).

  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::constantName): (JSC::idName): (JSC::CodeBlock::registerName): (JSC::regexpName): (JSC::printGlobalResolveInfo): (JSC::printStructureStubInfo): (JSC::CodeBlock::printStructure): (JSC::CodeBlock::printStructures):
  • jsc.cpp: (functionPrint): (functionDebug): (runInteractive): (fillBufferWithContentsOfFile):
  • pcre/pcre_exec.cpp: (Histogram::~Histogram):
  • profiler/CallIdentifier.h: (JSC::CallIdentifier::c_str):
  • profiler/Profile.cpp: (JSC::Profile::debugPrintDataSampleStyle):
  • profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::willExecute): (JSC::ProfileGenerator::didExecute):
  • profiler/ProfileNode.cpp: (JSC::ProfileNode::debugPrintData): (JSC::ProfileNode::debugPrintDataSampleStyle):
  • runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put): (JSC::Arguments::deleteProperty):
  • runtime/DateConversion.cpp: (JSC::parseDate):
  • runtime/Identifier.h: (JSC::Identifier::Identifier): (JSC::Identifier::toArrayIndex):
  • runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::deleteProperty):
  • runtime/JSArray.h:
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::parseInt): (JSC::globalFuncJSCPrint):
  • runtime/JSString.h: (JSC::RopeBuilder::JSString):
  • runtime/UString.cpp: (JSC::UString::toDouble): (JSC::UString::UTF8String):
  • runtime/UString.h: (JSC::UString::isNull): (JSC::UString::isEmpty): (JSC::UString::impl): (JSC::UString::cost): (JSC::UString::~UString): (JSC::UString::toArrayIndex):
  • wtf/text/WTFString.cpp: (WTF::String::utf8):
  • wtf/text/WTFString.h: (WTF::String::String): (WTF::String::isHashTableDeletedValue): (WTF::String::length): (WTF::String::operator[]): (WTF::String::isNull): (WTF::String::isEmpty): (WTF::String::impl):

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65295.
​http://trac.webkit.org/changeset/65295
​https://bugs.webkit.org/show_bug.cgi?id=43950

It broke 4 sputnik tests (Requested by Ossy on #webkit).

  • WebFrame.cpp: (wxWebFrame::RunScript):

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65295.
​http://trac.webkit.org/changeset/65295
​https://bugs.webkit.org/show_bug.cgi?id=43950

It broke 4 sputnik tests (Requested by Ossy on #webkit).

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate):

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65295.
​http://trac.webkit.org/changeset/65295
​https://bugs.webkit.org/show_bug.cgi?id=43950

It broke 4 sputnik tests (Requested by Ossy on #webkit).

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot): (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
  • bridge/NP_jsobject.cpp: (_NPN_Enumerate):
  • bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant):
  • bridge/jni/JNIBridge.cpp: (JavaParameter::JavaParameter): (JavaMethod::JavaMethod): (JavaMethod::signature): (JavaMethod::methodID):
  • bridge/jni/JNIBridge.h: (JSC::Bindings::JavaString::UTF8String): (JSC::Bindings::JavaParameter::type): (JSC::Bindings::JavaMethod::returnType):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember): (JavaJSObject::convertJObjectToValue):
  • bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::JavaField): (JavaField::valueFromInstance): (JavaField::setValueToInstance):
  • bridge/jni/jsc/JNIBridgeJSC.h: (JSC::Bindings::JavaField::type):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/jsc/JavaStringJSC.h: (JSC::Bindings::JavaStringImpl::UTF8String):
  • bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertySlot): (JSC::RuntimeArray::getOwnPropertyDescriptor): (JSC::RuntimeArray::put):

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65295.
​http://trac.webkit.org/changeset/65295
​https://bugs.webkit.org/show_bug.cgi?id=43950

It broke 4 sputnik tests (Requested by Ossy on #webkit).

  • WebProcess/Plugins/JSNPObject.cpp: (WebKit::npIdentifierFromIdentifier):
  • WebProcess/Plugins/NPJSObject.cpp: (WebKit::NPJSObject::enumerate):
  • WebProcess/Plugins/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
11:35 PM Changeset in webkit [65301] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Fixed typo in inspector js.
Follow up to r65300.

  • inspector/front-end/inspector.js: (WebInspector.log.isLogAvailable):
11:31 PM Changeset in webkit [65300] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Make getPrototypes return objects, not names.
​https://bugs.webkit.org/show_bug.cgi?id=43934

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
  • inspector/front-end/inspector.js: (WebInspector.log):
10:43 PM Changeset in webkit [65299] by jamesr@google.com
  • 8 edits in trunk/WebCore

2010-08-12 James Robinson <​jamesr@chromium.org>

Unreviewed, rolling out r65284 and r65288. Broke chromium compile.
​https://bugs.webkit.org/show_bug.cgi?id=43725
​http://trac.webkit.org/changeset/65284
​http://trac.webkit.org/changeset/65288

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyDeleter): (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::indexedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::removeItemFromMap):
9:33 PM Changeset in webkit [65298] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add more files to the WebKit2 skipped list.

Reviewed by Gavin Barraclough.

  • platform/mac-wk2/Skipped:
9:27 PM Changeset in webkit [65297] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-08-12 James Robinson <​jamesr@chromium.org>

Unreviewed. Mark play-state.html and isindex-with-no-form.html as flaky because they are.

  • platform/chromium/test_expectations.txt:
9:09 PM Changeset in webkit [65296] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

8:58 PM Changeset in webkit [65295] by barraclough@apple.com
  • 41 edits in trunk

Unify UString::UTF8String() & String::utf8() methods,
remove UString::cost() & make atArrayIndex a free function.

Reviewed by Sam Weinig

JavaScriptCore:

(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpName):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):

  • jsc.cpp:

(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):

  • pcre/pcre_exec.cpp:

(Histogram::~Histogram):

  • profiler/CallIdentifier.h:

(JSC::CallIdentifier::c_str):

  • profiler/Profile.cpp:

(JSC::Profile::debugPrintDataSampleStyle):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):

  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):

  • runtime/DateConversion.cpp:

(JSC::parseDate):

  • runtime/Identifier.h:

(JSC::Identifier::toStrictUInt32):

  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):

  • runtime/JSArray.h:

(JSC::toArrayIndex):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::parseInt):
(JSC::globalFuncJSCPrint):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):

  • runtime/UString.cpp:

(JSC::UString::toDouble):
(JSC::putUTF8Triple):
(JSC::UString::utf8):

  • runtime/UString.h:

(JSC::UString::~UString):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):

  • wtf/text/WTFString.cpp:

(WTF::String::utf8):

  • wtf/text/WTFString.h:

(WTF::String::~String):
(WTF::String::swap):
(WTF::String::isNull):
(WTF::String::isEmpty):
(WTF::String::impl):
(WTF::String::length):
(WTF::String::String):
(WTF::String::isHashTableDeletedValue):

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):

  • bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/jni/JNIBridge.cpp:

(JavaParameter::JavaParameter):
(JavaMethod::JavaMethod):
(JavaMethod::signature):
(JavaMethod::methodID):

  • bridge/jni/JNIBridge.h:

(JSC::Bindings::JavaString::utf8):
(JSC::Bindings::JavaParameter::type):
(JSC::Bindings::JavaMethod::returnType):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
(JavaJSObject::convertJObjectToValue):

  • bridge/jni/jsc/JNIBridgeJSC.cpp:

(JavaField::JavaField):
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):

  • bridge/jni/jsc/JNIBridgeJSC.h:

(JSC::Bindings::JavaField::type):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::utf8):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::put):

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate):

WebKit/wx:

  • WebFrame.cpp:

(wxWebFrame::RunScript):

WebKit2:

  • WebProcess/Plugins/JSNPObject.cpp:

(WebKit::npIdentifierFromIdentifier):

  • WebProcess/Plugins/NPJSObject.cpp:

(WebKit::NPJSObject::enumerate):

  • WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

8:47 PM Changeset in webkit [65294] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKitTools

WebKitTestRunner does not correctly resize WebView for W3C SVG tests
​https://bugs.webkit.org/show_bug.cgi?id=43945

Reviewed by Sam Weinig.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::sizeWebViewForCurrentTest):
Allow for a Windows-style path.

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::resizeTo):
Call SetWindowPos to resize the view window.

8:46 PM Changeset in webkit [65293] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit2

WebKit2 needs to initialize SafariTheme
​https://bugs.webkit.org/show_bug.cgi?id=43901

Reviewed by Sam Weinig.

  • WebProcess/win/WebProcessMainWin.cpp:

(WebKit::initializeSafariTheme):
Copied from old WebKit.
(WebKit::WebProcessMain):
If we're using SafariTheme, initialize it.

8:21 PM Changeset in webkit [65292] by mjs@apple.com
  • 4 edits in trunk/WebKit2

2010-08-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

WebKit2 crashes when WebFrame outlives WebPage
​https://bugs.webkit.org/show_bug.cgi?id=43939

  • WebProcess/WebCoreSupport/WebChromeClient.h: (WebKit::WebChromeClient::page): Add this method, to allow WebFrame to retrieve its WebPage following WebCore pointers.
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::WebFrame): Do not initialize m_page (it's gone). (WebKit::WebFrame::page): Don't use the data member, get it from WebCore. (WebKit::WebFrame::invalidate): Use method to get page() and null check. (WebKit::WebFrame::isMainFrame): ditto
  • WebProcess/WebPage/WebFrame.h:
8:11 PM Changeset in webkit [65291] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-12 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed, fixing the previous commit.

Added PASS CRASH expectation for editing/pasteboard/smart-paste-004.html.

  • platform/chromium/test_expectations.txt:
8:05 PM Changeset in webkit [65290] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-12 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed.

Added PASS CRASH expectation for editing/pasteboard/smart-paste-003.html and
editing/pasteboard/smart-paste-004.html reported by japhet.

  • platform/chromium/test_expectations.txt:
7:29 PM Changeset in webkit [65289] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Eeerk! - revert accidentally committed changes in UString!

(JSC::UString::UString):

  • runtime/UString.h:
7:29 PM Changeset in webkit [65288] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Speculative build fix for chromium bindings (someone added the old include style!).

  • bindings/v8/V8DOMWindowShell.h:
6:44 PM Changeset in webkit [65287] by morrita@google.com
  • 4 edits in trunk/WebCore

2010-08-12 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] TextEvent class has to many flags
​https://bugs.webkit.org/show_bug.cgi?id=43893

Turned TextEvent::m_isLineBreak, TextEvent::m_isBacktab, TextEvent::m_isPaste
into single TextEvent::m_inputType enumeration.

No functional change. No new tests.

  • dom/TextEvent.cpp: (WebCore::TextEvent::selectInputType): (WebCore::TextEvent::create): (WebCore::TextEvent::createForPlainTextPaste): (WebCore::TextEvent::createForFragmentPaste): (WebCore::TextEvent::TextEvent):
  • dom/TextEvent.h: (WebCore::TextEvent::): (WebCore::TextEvent::isLineBreak): (WebCore::TextEvent::isBackTab): (WebCore::TextEvent::isPaste):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent):
6:05 PM Changeset in webkit [65286] by barraclough@apple.com
  • 9 edits in trunk/JavaScriptCore

Change UString constructors to match those in WTF::String.
This changes behaviour of UString((char*)0) to create null
strings, akin to UString() rather than UString::empty().
(This matches String). Remove unused constructors from
UString, and add null-terminated UTF-16 constructor, to
match String. Move String's constructor into the .cpp to
match UString.

Reviewed by Sam Weinig

(JSC::DebuggerCallFrame::calculatedFunctionName):

  • runtime/RegExpKey.h:

(JSC::RegExpKey::RegExpKey):

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::createSingleCharacterString):

  • runtime/UString.cpp:

(JSC::UString::UString):

  • runtime/UString.h:

(JSC::UString::UString):
(JSC::UString::swap):
(JSC::UString::adopt):
(JSC::UString::operator[]):

  • wtf/text/WTFString.h:

(WTF::String::String):
(WTF::String::adopt):
(WTF::String::operator[]):

5:12 PM Changeset in webkit [65285] by kbr@google.com
  • 5 edits
    4 deletes in trunk/WebCore

2010-08-12 Kenneth Russell <​kbr@google.com>

Reviewed by David Levin.

Delete obsolete CanvasNumberArray
​https://bugs.webkit.org/show_bug.cgi?id=38619

Deleted unreferenced code. Built WebKit and Chromium to test.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.jscbindings.mk:
  • Android.mk:
  • bindings/js/JSCanvasNumberArrayCustom.cpp: Removed.
  • html/canvas/CanvasNumberArray.cpp: Removed.
  • html/canvas/CanvasNumberArray.h: Removed.
  • html/canvas/CanvasNumberArray.idl: Removed.
4:57 PM Changeset in webkit [65284] by antonm@chromium.org
  • 8 edits in trunk/WebCore

2010-08-12 Anton Muhin <​antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Create callbacks for named access of elements from document object on fly.
​https://bugs.webkit.org/show_bug.cgi?id=43725

That should speed up access to methods on document as there is no need to
consult with interceptor before invoking the method.

This reapplies ​http://trac.webkit.org/changeset/60670 reverted with
​http://trac.webkit.org/changeset/63845. The main difference is in treatment
of removed named elements: we don't remove an accessor any more, but leave it.
Therefore any accessor should be able to treat the case when there is no
expando property.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::removeItemFromMap):
4:30 PM Changeset in webkit [65283] by tony@chromium.org
  • 1 edit
    27 adds in trunk/LayoutTests

2010-08-12 Tony Chang <​tony@chromium.org>

Unreviewed, landing google-chrome linux 64 test results.

  • platform/google-chrome-linux64/fast/borders/borderRadiusGroove01-expected.checksum: Added.
  • platform/google-chrome-linux64/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/google-chrome-linux64/fast/borders/borderRadiusGroove02-expected.checksum: Added.
  • platform/google-chrome-linux64/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/google-chrome-linux64/fast/borders/borderRadiusRidge01-expected.checksum: Added.
  • platform/google-chrome-linux64/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum: Added.
  • platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
  • platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
  • platform/google-chrome-linux64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum: Added.
  • platform/google-chrome-linux64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
  • platform/google-chrome-linux64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
  • platform/google-chrome-linux64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/google-chrome-linux64/svg/hixie/perf/001-expected.txt: Added.
  • platform/google-chrome-linux64/svg/hixie/perf/002-expected.txt: Added.
  • platform/google-chrome-linux64/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
  • platform/google-chrome-linux64/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
4:26 PM Changeset in webkit [65282] by Dimitri Glazkov
  • 2 edits in trunk

2010-08-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

Add more Chromium-related dependency directories to .gitignore.
​https://bugs.webkit.org/show_bug.cgi?id=43940

  • .gitignore: Added all existing that are created by update-webkit --chromium.
4:23 PM Changeset in webkit [65281] by Dimitri Glazkov
  • 4 edits in trunk/WebCore

2010-08-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Ensure that parser doesn't attach children that have been removed by JavaScript event handlers.
​https://bugs.webkit.org/show_bug.cgi?id=43813

This patch re-fixes bug 40742 in a way that keeps allowing HTMLLinkElement
to lazy-attach.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): Added parent check.
  • html/HTMLLinkElement.cpp: Basically undoes changes introduced by r61424.
  • html/HTMLLinkElement.h: Ditto.
4:18 PM Changeset in webkit [65280] by jschuh@chromium.org
  • 4 edits in trunk

2010-08-12 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dumitru Daniliuc.

Clear PluginData's page pointer on page refresh
​https://bugs.webkit.org/show_bug.cgi?id=43888

Test: plugins/access-after-page-destroyed.html

  • page/Page.cpp: (WebCore::Page::refreshPlugins):

2010-08-12 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dumitru Daniliuc.

Clear PluginData's page pointer on page refresh
​https://bugs.webkit.org/show_bug.cgi?id=43888

  • plugins/access-after-page-destroyed.html:
4:14 PM Changeset in webkit [65279] by zmo@google.com
  • 5 edits in trunk

2010-08-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getParameter(STENCIL_VALUE_MASK) (and others) returns the wrong value
​https://bugs.webkit.org/show_bug.cgi?id=31842

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUnsignedLongParameter): Casting from int to unsigned long correctly.

2010-08-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getParameter(STENCIL_VALUE_MASK) (and others) returns the wrong value
​https://bugs.webkit.org/show_bug.cgi?id=31842

  • fast/canvas/webgl/gl-get-calls-expected.txt: Bring back the commented out STENCIL tests.
  • fast/canvas/webgl/gl-get-calls.html: Ditto.
4:11 PM MathML 3 testsuite results edited by François Sausset
(diff)
4:06 PM Changeset in webkit [65278] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: mimic FireBug's array detection.
​https://bugs.webkit.org/show_bug.cgi?id=30974

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
3:59 PM Changeset in webkit [65277] by zmo@google.com
  • 5 edits in trunk

2010-08-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

regression in generateMipmap
​https://bugs.webkit.org/show_bug.cgi?id=43873

  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::generateMipmapLevelInfo): should set m_needToUseBlackTexture to false if generateMipmapLevelInfo runs through successfully.

2010-08-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

regression in generateMipmap
​https://bugs.webkit.org/show_bug.cgi?id=43873

  • fast/canvas/webgl/texture-npot-expected.txt: Add more test cases on NPOT/POT texture behaviors.
  • fast/canvas/webgl/texture-npot.html: Ditto.
3:57 PM Changeset in webkit [65276] by ariya@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2010-08-12 Ariya Hidayat <​ariya@sencha.com>

Reviewed by David Hyatt.

[Qt] Split TransparencyLayer into its own header file.
​https://bugs.webkit.org/show_bug.cgi?id=43935

  • WebCore.pro: Include TransparencyLayer.h.
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/TransparencyLayer.h: Added. (WebCore::TransparencyLayer::TransparencyLayer): (WebCore::TransparencyLayer::operator=):
3:53 PM Changeset in webkit [65275] by commit-queue@webkit.org
  • 24 edits in trunk

2010-08-12 François Sausset <François Sausset>

Reviewed by Beth Dakin.

Update the tests to take into account padding changes for the mrow element.
​https://bugs.webkit.org/show_bug.cgi?id=43908

  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.checksum:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.checksum:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.checksum:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:

2010-08-12 François Sausset <François Sausset>

Reviewed by Beth Dakin.

Horizontal padding should be 0 on mrow elements.
​https://bugs.webkit.org/show_bug.cgi?id=43908

Updated tests in /mathml

  • css/mathml.css: (mrow, mfenced): (mfenced):
3:42 PM Changeset in webkit [65274] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

Build break fix.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues): Removed usage
of a variable that doesn't exist in the class.

3:40 PM Changeset in webkit [65273] by aa@chromium.org
  • 9 edits in trunk

2010-08-12 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Make the cascade level of "user" styles configurable
​https://bugs.webkit.org/show_bug.cgi?id=43457

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector):
  • dom/Document.cpp: (WebCore::Document::pageGroupUserSheets):
  • page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld):
  • page/PageGroup.h:
  • page/UserStyleSheet.h: (WebCore::UserStyleSheet::): (WebCore::UserStyleSheet::UserStyleSheet): (WebCore::UserStyleSheet::level):

2010-08-12 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Make the cascade level of "user" styles configurable
​https://bugs.webkit.org/show_bug.cgi?id=43457

  • src/WebViewImpl.cpp: (WebKit::WebView::addUserStyleSheet):
3:32 PM Changeset in webkit [65272] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Fix qt build break.

  • html/ThreadableBlobRegistry.cpp:

(WebCore::postTaskToMainThread):

3:16 PM Changeset in webkit [65271] by jianli@chromium.org
  • 13 edits
    2 adds in trunk/WebCore

Add ThreadableBlobRegistry to support calling BlobRegistry methods in
main thread.
​https://bugs.webkit.org/show_bug.cgi?id=43874

Reviewed by David Levin.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::addBlob):
(WebCore::ScriptExecutionContext::removeBlob):
(WebCore::ScriptExecutionContext::createPublicBlobURL):
(WebCore::ScriptExecutionContext::revokePublicBlobURL):

  • dom/ScriptExecutionContext.h:
  • html/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::~Blob):
(WebCore::Blob::contextDestroyed):

  • html/Blob.h:
  • html/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::unregisterBlobURL):
(WebCore::BlobRegistryImpl::getBlobDataFromURL):

  • html/ThreadableBlobRegistry.cpp: Added.
  • html/ThreadableBlobRegistry.h: Added.
3:03 PM Changeset in webkit [65270] by jhoneycutt@apple.com
  • 14 edits
    2 copies
    1 add in trunk

WebKitTestRunner needs to run tests without using native controls
​https://bugs.webkit.org/show_bug.cgi?id=43772

Reviewed by Sam Weinig.

WebKit2:

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):
Add a new message.

  • UIProcess/API/C/win/WKContextPrivateWin.h: Added.

Declare WKContextSetShouldPaintNativeControls().

  • UIProcess/API/C/win/WKContextWin.cpp: Added.

(WKContextSetShouldPaintNativeControls):
Call the WebContext's setShouldPaintNativeControls().

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
Initialize m_shouldPaintNativeControls.
(WebKit::WebContext::ensureWebProcess):
If we created a web process, call platformSetUpWebProcess().

  • UIProcess/WebContext.h:

Declare new functions and a member to store whether we should paint
native controls.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformSetUpWebProcess):
Stubbed.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::setShouldPaintNativeControls):
Set m_shouldPaintNativeControls. If we have a valid web process, send a
SetShouldPaintNativeControls message.
(WebKit::WebContext::platformSetUpWebProcess):
Send a SetShouldPaintNativeControls message.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):
If this is a SetShouldPaintNativeControls message, decode the argument,
and call Settings::setShouldPaintNativeControls().

  • win/WebKit2.vcproj:

Add WKContextPrivateWin.h and WKContextWin.cpp to project.

  • win/WebKit2Generated.make:

Copy WKContextPrivateWin.h.

WebKitTools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
Call platformInitializeContext().

  • WebKitTestRunner/TestController.h:

Declare platformInitializeContext().

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformInitializeContext):
Stubbed.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformInitializeContext):
Call WKContextSetShouldPaintNativeControls() to disable native control
drawing.

2:55 PM Changeset in webkit [65269] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-12 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Darin Adler.

generate-bindings.pl should generate warning free code
​https://bugs.webkit.org/show_bug.cgi?id=43353

bindings/scripts/CodeGeneratorJS.pm: Suggested parentheses added around && within
2:49 PM Changeset in webkit [65268] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore
  • runtime/UString.h: Removed unneccessary #include.

Reviewed by NOBODY (build fix).

2:28 PM Changeset in webkit [65267] by weinig@apple.com
  • 14 edits
    2 deletes in trunk/WebKitTools

WebKitTestRunner should be more aggressive about ensuring consistent state between tests
​https://bugs.webkit.org/show_bug.cgi?id=43653

Reviewed by Alexey Proskuryakov.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::isTestRunning):
(WTR::InjectedBundle::):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::stopLoading):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
Don't do any work if we are not currently running a test.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/StringFunctions.h:

(WTR::toCF):
Add conversion function for WKURLRef -> CFURLRef

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::runTest):
(WTR::TestController::didFinishLoadForFrame):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

  • WebKitTestRunner/TestInvocation.h:

Move resetting code to TestController.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::runUntil):

  • WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::runUntil):

  • WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:

Move runUntil to TestController.

2:20 PM Changeset in webkit [65266] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Revert changes to ALWAYS_INLINEness of a couple of functions in UString.
This appears to have degraded performance.

Reviewed by Sam Weinig

  • runtime/UString.cpp:

(JSC::UString::ascii):

  • runtime/UString.h:

(JSC::UString::length):
(JSC::UString::isEmpty):
(JSC::UString::~UString):

2:06 PM Changeset in webkit [65265] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-08-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

merge MarkupAccumulator and MarkupAccumulatorWrapper
​https://bugs.webkit.org/show_bug.cgi?id=43834

Removed MarkupAccumulator and added serializeNodesWithNamespaces to use MarkupAccumulatorWrapper
in both versions of createMarkup. Accumulation of nodes done manually in serializeNodes is
now done by MarkupAccumulatorWrapper as done in the original MarkupAccumulator.

No new tests added since this is a cleanup.

  • editing/markup.cpp: (WebCore::MarkupAccumulatorWrapper::MarkupAccumulatorWrapper): Takes vector of nodes and set it to m_nodes. (WebCore::MarkupAccumulatorWrapper::insertOpenTag): Adds node to m_nodes. (WebCore::MarkupAccumulatorWrapper::wrapWithNode): Adds node to m_nodes. (WebCore::serializeNodes): Adding node to nodes is moved into MarkupAccumulatorWrapper. (WebCore::createMarkup): Instantiates MarkupAccumulatorWrapper. (WebCore::serializeNodesWithNamespaces): Renamed from MarkupAccumulator::appendMarkup.
1:28 PM Changeset in webkit [65264] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

2010-08-12 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Antonio Gomes.

[Qt] Fix warnings: unknown conversion type character 'l' in format
​https://bugs.webkit.org/show_bug.cgi?id=43359

Qt port doesn't call any printf in String::format(...), consequently
using attribute((format(printf,m,n))) is incorrect and causes
false positive warnings on Windows if you build with MinGW.

Qt port calls QString::vsprintf(...) , which is platform
independent, and handles %lli, %llu and %llx on all platforms.
(​http://trac.webkit.org/changeset/35712)

  • wtf/text/WTFString.h:
1:05 PM Changeset in webkit [65263] by hclam@chromium.org
  • 17 edits in trunk/LayoutTests

Rebaselining the test results for media controls on Mac to fix
a regression.

Submitted for Victoria Kirst (​vrk@google.com).

Reviewed by David Levin.

  • platform/chromium-mac/media/audio-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium/test_expectations.txt:
12:43 PM BuildingQtOnLinux edited by Ademar Reis
install dependencies on fedora (diff)
12:16 PM Changeset in webkit [65262] by demarchi@webkit.org
  • 53 edits
    4 adds
    2 deletes in trunk/WebKit/efl

2010-08-11 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Adding new theme for widgets.
​https://bugs.webkit.org/show_bug.cgi?id=43860

Original theme was there for a long time. This is a new
fresh one.

  • DefaultTheme/default.edc:
  • DefaultTheme/widget/button/button.edc:
  • DefaultTheme/widget/button/img_button_focus.png:
  • DefaultTheme/widget/button/img_button_hover.png:
  • DefaultTheme/widget/button/img_button_normal.png:
  • DefaultTheme/widget/button/img_button_press.png:
  • DefaultTheme/widget/check/check.edc:
  • DefaultTheme/widget/check/img_check_off.png:
  • DefaultTheme/widget/check/img_check_off_focus.png:
  • DefaultTheme/widget/check/img_check_off_hover.png:
  • DefaultTheme/widget/check/img_check_on.png:
  • DefaultTheme/widget/check/img_check_on_focus.png:
  • DefaultTheme/widget/check/img_check_on_hover.png:
  • DefaultTheme/widget/combo/combo.edc:
  • DefaultTheme/widget/combo/combo_focus.png:
  • DefaultTheme/widget/combo/combo_focus_button.png:
  • DefaultTheme/widget/combo/combo_hover.png:
  • DefaultTheme/widget/combo/combo_hover_button.png:
  • DefaultTheme/widget/combo/combo_normal.png:
  • DefaultTheme/widget/combo/combo_normal_button.png:
  • DefaultTheme/widget/combo/combo_press.png:
  • DefaultTheme/widget/combo/combo_press_button.png:
  • DefaultTheme/widget/combo/icon.png:
  • DefaultTheme/widget/entry/img_focused.png:
  • DefaultTheme/widget/entry/img_hovered.png:
  • DefaultTheme/widget/entry/img_normal.png:
  • DefaultTheme/widget/file/file_focus.png:
  • DefaultTheme/widget/file/file_hover.png:
  • DefaultTheme/widget/file/file_normal.png:
  • DefaultTheme/widget/file/file_press.png:
  • DefaultTheme/widget/radio/img_radio_off.png:
  • DefaultTheme/widget/radio/img_radio_off_focus.png:
  • DefaultTheme/widget/radio/img_radio_off_hover.png:
  • DefaultTheme/widget/radio/img_radio_on.png:
  • DefaultTheme/widget/radio/img_radio_on_focus.png:
  • DefaultTheme/widget/radio/img_radio_on_hover.png:
  • DefaultTheme/widget/radio/radio.edc:
  • DefaultTheme/widget/scrollbar/scrollbar.edc:
  • DefaultTheme/widget/scrollbar/scrollbar_h.png:
  • DefaultTheme/widget/scrollbar/scrollbar_hilight.png: Removed.
  • DefaultTheme/widget/scrollbar/scrollbar_knob_h.png:
  • DefaultTheme/widget/scrollbar/scrollbar_knob_v.png:
  • DefaultTheme/widget/scrollbar/scrollbar_v.png:
  • DefaultTheme/widget/search/cancel/cancel_normal_button2.png:
  • DefaultTheme/widget/search/decoration/decoration_normal_button.png:
  • DefaultTheme/widget/search/field/field_focused.png:
  • DefaultTheme/widget/search/field/field_hovered.png:
  • DefaultTheme/widget/search/field/field_normal.png:
  • DefaultTheme/widget/slider/slider.edc:
  • DefaultTheme/widget/slider/slider_fill_h.png: Added.
  • DefaultTheme/widget/slider/slider_fill_v.png: Added.
  • DefaultTheme/widget/slider/slider_h.png:
  • DefaultTheme/widget/slider/slider_hilight.png: Removed.
  • DefaultTheme/widget/slider/slider_knob_h.png:
  • DefaultTheme/widget/slider/slider_knob_press_h.png: Added.
  • DefaultTheme/widget/slider/slider_knob_press_v.png: Added.
  • DefaultTheme/widget/slider/slider_knob_v.png:
  • DefaultTheme/widget/slider/slider_v.png:
12:13 PM Changeset in webkit [65261] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-08-12 Dirk Schulze <​krit@webkit.org>

Unreviewed sort of XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
11:22 AM Changeset in webkit [65260] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-12 Gabor Loki <​loki@webkit.org>

Reviewed by Geoffrey Garen.

Fix the array subscript is above array bounds warning in ByteArray on ARM.
​https://bugs.webkit.org/show_bug.cgi?id=43358

The warning is very similar to this one: ​http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37861

  • wtf/ByteArray.cpp: (WTF::ByteArray::create):
11:04 AM Changeset in webkit [65259] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-08-12 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations tweak.

Remove a duplicate linux debug expectation.

  • platform/chromium/test_expectations.txt:
10:51 AM Changeset in webkit [65258] by benm@google.com
  • 2 edits in trunk/WebCore

2010-08-12 Ben Murdoch <​benm@google.com>

Reviewed by Pavel Feldman.

InspectorController.h missing InspectorObject forward declaration
​https://bugs.webkit.org/show_bug.cgi?id=43913

Build fix so no new tests.

  • inspector/InspectorController.h: Adds the necessary forward declaration.
10:47 AM Changeset in webkit [65257] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk

Add file I forgot to add in r65255.

10:39 AM Changeset in webkit [65256] by demarchi@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-12 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
10:33 AM Changeset in webkit [65255] by kov@webkit.org
  • 10 edits in trunk

2010-08-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Use GSettings to save/restore Web Inspector settings
​https://bugs.webkit.org/show_bug.cgi?id=43512

  • GNUmakefile.am: GSettings rules.
  • configure.ac: GSettings infrastructure, and check if we should use it by looking for an appropriate version of GIO.

JavaScriptCore

2010-08-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Use GSettings to save/restore Web Inspector settings
​https://bugs.webkit.org/show_bug.cgi?id=43512

  • wtf/gobject/GRefPtr.cpp: Added support for GVariant, used by our GSettings support. (WTF::refGPtr): (WTF::derefGPtr):
  • wtf/gobject/GRefPtr.h:

WebKit/gtk

2010-08-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Use GSettings to save/restore Web Inspector settings
​https://bugs.webkit.org/show_bug.cgi?id=43512

Use GSettings to save/restore settings used by the Web Inspector.
A few helper functions were added to have settings that use
boolean values be actual booleans, and also to conform with the
GSettings naming requirements for keys.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::toGSettingName): (WebKit::truthStringFromVariant): (WebKit::variantFromTruthString): (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting):
  • org.webkit.gtk.gschema.xml: Added.
  • webkit/webkitprivate.cpp: (inspectorGSettings): (webkit_init):
  • webkit/webkitprivate.h:
10:32 AM Changeset in webkit [65254] by commit-queue@webkit.org
  • 2 edits
    1 copy
    1 delete in trunk/WebKitTools

2010-08-12 Hayato Ito <​hayato@chromium.org>

Reviewed by Tony Chang.

Merge pretty printers for gdb.
​https://bugs.webkit.org/show_bug.cgi?id=43850

We need to update webcore.py because basic string classes have moved to WTF from WebCore.
It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
webcore.py is left for backward compatibility.

  • gdb/webcore.py:
  • gdb/webkit.py: Added.
  • gdb/wtf.py: Removed.
10:16 AM Changeset in webkit [65253] by commit-queue@webkit.org
  • 4 edits in trunk

2010-08-12 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Making CMake keep track of theme dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=43862

Removing unused macro GENERATE_EDJ.

  • cmake/WebKitEfl.cmake:

2010-08-12 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Making CMake keep track of theme dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=43862

Adding theme source files and images as dependencies of the theme.

  • CMakeListsEfl.txt:
10:11 AM QtWebKitTriageRoster edited by Csaba Osztrogonác
(diff)
10:10 AM MathML Goals edited by alex@milowski.com
(diff)
10:10 AM MathML Goals edited by alex@milowski.com
(diff)
10:03 AM Changeset in webkit [65252] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-08-12 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations tweak.

Comment out svg/hittest/svg-rect-hit.html, as the test
was not landed with the relevant patch.

  • platform/chromium/test_expectations.txt:
10:02 AM MathML edited by alex@milowski.com
(diff)
10:00 AM MathML Status edited by alex@milowski.com
(diff)
9:59 AM Changeset in webkit [65251] by johnnyg@google.com
  • 3 edits in trunk/WebKit/chromium

2010-08-12 John Gregg <​johnnyg@google.com>

Reviewed by Kent Tamura.

[chromium] Add Notification::detachPresenter to the WebKit API.
​https://bugs.webkit.org/show_bug.cgi?id=43659

  • public/WebNotification.h:
  • src/WebNotification.cpp: (WebKit::WebNotification::detachPresenter):
9:38 AM MathML edited by alex@milowski.com
(diff)
9:35 AM MathML edited by alex@milowski.com
(diff)
9:33 AM Changeset in webkit [65250] by tony@chromium.org
  • 4 edits
    2 adds in trunk/WebKitTools

2010-08-11 Tony Chang <​tony@chromium.org>

Reviewed by David Levin.

[chromium] add google-chrome layout test result directories
​https://bugs.webkit.org/show_bug.cgi?id=43889

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
9:32 AM MathML Status created by alex@milowski.com
9:20 AM MathML edited by alex@milowski.com
(diff)
9:19 AM MathML edited by alex@milowski.com
(diff)
8:58 AM Changeset in webkit [65249] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-12 Hui Huang <​hui.2.huang@nokia.com>

Reviewed by Eric Seidel.

m_windowRect is not updated because parent of PluginView is not
set when updatePluginWidget is called. plugin gets wrong window
size on setwindow.
​https://bugs.webkit.org/show_bug.cgi?id=43635

  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setParent):
8:37 AM Changeset in webkit [65248] by pfeldman@chromium.org
  • 27 edits
    1 add
    1 delete in trunk

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed, re-apply r65241 and 65243.

Web Inspector: brush up object proxies, introduce remote object model.
​https://bugs.webkit.org/show_bug.cgi?id=43847

8:26 AM Changeset in webkit [65247] by senorblanco@chromium.org
  • 8 edits in trunk

2010-08-11 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Add support for BGRA pixel format to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=43858

Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. The DefaultImpl returns false, since it does not yet
implement the TexImage2D internalFormat quirks.

  • public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::supportsBGRA):
  • src/GraphicsContext3D.cpp:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
  • src/WebGraphicsContext3DDefaultImpl.h:

2010-08-11 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Add support for BGRA pixel format to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=43858

Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. Since they differ on semantics (GL ES 2.0 requires
TexImage2D()'s format and internalFormat to match, while desktop GL
will not accept BGRA as an internalFormat), the stub implementation
returns false until these quirks have been implemented and tested on
each port.

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsBGRA): Add implementation for non-chromium platforms which returns false.
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): Add query function (supportsBGRA()) and the BGRA_EXT token.
8:11 AM Changeset in webkit [65246] by commit-queue@webkit.org
  • 3 edits in trunk

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65225.
​http://trac.webkit.org/changeset/65225
​https://bugs.webkit.org/show_bug.cgi?id=43918

Broke EFL port build (Requested by acidx on #webkit).

  • cmake/WebKitGenerators.cmake:
  • cmake/WebKitMacros.cmake:
8:04 AM Changeset in webkit [65245] by pfeldman@chromium.org
  • 26 edits
    1 add
    1 delete in trunk

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out r65241 and 65243 for breaking inspector tests.

7:38 AM MathML 3 testsuite results edited by François Sausset
(diff)
7:20 AM MathML 3 testsuite results edited by François Sausset
(diff)
7:11 AM MathML 3 testsuite results edited by François Sausset
(diff)
7:01 AM MathML 3 testsuite results edited by François Sausset
(diff)
6:40 AM Changeset in webkit [65244] by Nate Chapin
  • 2 edits
    3 adds in trunk/LayoutTests

2010-08-12 Nate Chapin <Nate Chapin>

Update chromium's test_expectations.txt and provide new baselines for
​http://trac.webkit.org/changeset/65229.

(Text-only baseline for win/linux because there are real regressions in the
image results. See ​https://bugs.webkit.org/show_bug.cgi?id=43912)

  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:38 AM Changeset in webkit [65243] by pfeldman@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Adding the file missing in r65241.

6:37 AM Changeset in webkit [65242] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

The scratch register should be saved in YARR with ARM JIT
​https://bugs.webkit.org/show_bug.cgi?id=43910

Reviewed by Simon Hausmann.

Reported by Jocelyn Turcotte.

  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generateEnter):
(JSC::Yarr::RegexGenerator::generateReturn):

6:31 AM Changeset in webkit [65241] by pfeldman@chromium.org
  • 26 edits
    1 delete in trunk

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up object proxies, introduce remote object model.
​https://bugs.webkit.org/show_bug.cgi?id=43847

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed): (WebInspector.ConsoleView.prototype._format): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._formatAsArrayEntry): (WebInspector.ConsoleMessage.prototype._format): (WebInspector.ConsoleCommandResult):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
  • inspector/front-end/ObjectProxy.js: Removed.
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
  • inspector/front-end/RemoteObject.js: Added. (WebInspector.RemoteObjectId): (WebInspector.RemoteObject): (WebInspector.RemoteObject.fromPrimitiveValue): (WebInspector.RemoteObject.fromErrorMessage): (WebInspector.RemoteObject.fromNode): (WebInspector.RemoteObject.fromPayload): (WebInspector.RemoteObject.type): (WebInspector.RemoteObject.prototype.get objectId): (WebInspector.RemoteObject.prototype.get type): (WebInspector.RemoteObject.prototype.get description): (WebInspector.RemoteObject.prototype.get hasChildren): (WebInspector.RemoteObject.prototype.isError): (WebInspector.RemoteObject.prototype.getPropertyValueDescriptions): (WebInspector.RemoteObject.prototype.getOwnProperties): (WebInspector.RemoteObject.prototype.getProperties.remoteObjectBinder): (WebInspector.RemoteObjectProperty):
  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.evaluateCallback): (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype.update):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.log.logMessage): (WebInspector.log):
  • inspector/front-end/utilities.js:

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up object proxies, introduce remote object model.
​https://bugs.webkit.org/show_bug.cgi?id=43847

  • inspector/console-dir-expected.txt:
  • inspector/console-dir-global.html:
  • inspector/console-dir.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-expected.txt:
6:30 AM MathML 3 testsuite results edited by François Sausset
(diff)
6:27 AM Changeset in webkit [65240] by benm@google.com
  • 2 edits in trunk/WebCore

2010-08-12 Ben Murdoch <​benm@google.com>

Reviewed by Steve Block.

V8 code generator does not add V8BindingMacros.h include in all places it is needed
​https://bugs.webkit.org/show_bug.cgi?id=43907

Adds the V8BindingMacros.h header before using the STRING_TO_V8PARAMETER_EXCEPTION_BLOCK
macro.

Build fix so no new tests.

  • bindings/scripts/CodeGeneratorV8.pm: include the header at the right time.
6:23 AM MathML 3 testsuite results edited by François Sausset
(diff)
6:09 AM Changeset in webkit [65239] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2010-08-12 Philippe Normand <​pnormand@igalia.com>

Unreviewed.

Media test baseline forgotten in r65224.

  • platform/gtk/media/audio-no-installed-engines-expected.txt: Added.
6:04 AM MathML 3 testsuite results edited by François Sausset
(diff)
5:47 AM MathML 3 testsuite results edited by François Sausset
(diff)
5:37 AM MathML 3 testsuite results edited by François Sausset
(diff)
5:36 AM Changeset in webkit [65238] by hamaji@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65181.
​http://trac.webkit.org/changeset/65181
​https://bugs.webkit.org/show_bug.cgi?id=43909

It broke 35 layout tests fail on chromium-win (Requested by
hamaji on #webkit).

  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
5:31 AM MathML 3 testsuite results edited by François Sausset
(diff)
5:04 AM Changeset in webkit [65237] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-12 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's test_expectations.txt

  • platform/chromium/test_expectations.txt: Two failing video related tests.
5:00 AM Changeset in webkit [65236] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] animations/suspend-resume-animation.html fails
​https://bugs.webkit.org/show_bug.cgi?id=43905

  • platform/qt/Skipped: animations/suspend-resume-animation.html skipped until fix.
4:52 AM Changeset in webkit [65235] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-12 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's test_expectations.txt

  • platform/chromium/test_expectations.txt: animations/play-state is flaky on Mac
4:44 AM MathML 3 testsuite results edited by François Sausset
(diff)
4:37 AM MathML 3 testsuite results edited by François Sausset
(diff)
4:10 AM Changeset in webkit [65234] by jorlow@chromium.org
  • 19 edits
    2 deletes in trunk

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Revert for now
​https://bugs.webkit.org/show_bug.cgi?id=43794

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/GroupSettings.cpp: Removed.
  • page/GroupSettings.h: Removed.
  • page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): (WebCore::PageGroup::localStorage):
  • page/PageGroup.h:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setLocalStorageQuota): (WebCore::Settings::setLocalStorageDatabasePath):
  • page/Settings.h: (WebCore::Settings::localStorageQuota): (WebCore::Settings::localStorageDatabasePath):

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Revert for now
​https://bugs.webkit.org/show_bug.cgi?id=43794

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _preferencesChangedNotification:]):

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Revert for now
​https://bugs.webkit.org/show_bug.cgi?id=43794

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Revert for now
​https://bugs.webkit.org/show_bug.cgi?id=43794

  • WebView.cpp: (WebView::initWithFrame):
3:37 AM Changeset in webkit [65233] by Nikolas Zimmermann
  • 1 edit
    1 delete in trunk/LayoutTests

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Delete a test that slipped in by accident.

  • svg/zoom/page/zoom-mask.svg: Removed.
3:30 AM Changeset in webkit [65232] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Follow up to Jeremys fix, just remove the context parameter, it's not needed anymore.

  • rendering/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
  • rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::createImageBuffer):
  • rendering/SVGImageBufferTools.h:
3:27 AM Changeset in webkit [65231] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Build fix.

  • rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::createImageBuffer):
3:21 AM Changeset in webkit [65230] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/win

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Build fix. Matches solutions in qt and mac ports for
​https://bugs.webkit.org/show_bug.cgi?id=43794

  • WebView.cpp: (WebView::initWithFrame):
3:11 AM Changeset in webkit [65229] by Nikolas Zimmermann
  • 18 edits
    7 adds in trunk

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG masking performance very slow
​https://bugs.webkit.org/show_bug.cgi?id=43622

Create ImageBuffers only as large as the final rendered size on screen. Only gradient on text on CG handled this correctly so far.
Refactored the code into a new SVGImageBufferTools class, and use the code from RenderSVGResourceMasker -> makes the IE9 demo SVG dice usable.
Clippers, Patterns and Filters remain to be converted.

Test: svg/zoom/page/zoom-mask-with-percentages.svg

  • Android.mk: Add SVGImageBufferTools.* to build.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/RenderSVGAllInOne.cpp: Ditto.
  • rendering/RenderSVGResourceGradient.cpp: Refactored CG gradient specific "create image buffer in absolute coordinates" code into SVGImageBufferTools class. (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/RenderSVGResourceMasker.cpp: Use new SVGImageBufferTools class, to avoid pixelation when zooming and to create image buffers as big as the final rendered size on screen, not more. (WebCore::RenderSVGResourceMasker::invalidateClients): (WebCore::RenderSVGResourceMasker::applyResource): (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect): (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/SVGImageBufferTools.cpp: Added. (WebCore::SVGImageBufferTools::absoluteTransformFromContext): (WebCore::SVGImageBufferTools::createImageBuffer): (WebCore::SVGImageBufferTools::clipToImageBuffer):
  • rendering/SVGImageBufferTools.h: Added. (WebCore::SVGImageBufferTools::SVGImageBufferTools): (WebCore::SVGImageBufferTools::~SVGImageBufferTools):

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG masking performance very slow
​https://bugs.webkit.org/show_bug.cgi?id=43622

Update mask results, now that mask image buffers are as big as the finaled rendered size on screen.
Add new test covering zooming into masks, to show that it doesn't pixelate anymore.

  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
  • svg/zoom/page/zoom-mask-with-percentages.svg: Added.
3:03 AM Changeset in webkit [65228] by jorlow@chromium.org
  • 17 edits
    2 adds in trunk

2010-08-10 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Adam Barth.

Some settings are linked to the PageGroup not the Page. Create a new class for those.
​https://bugs.webkit.org/show_bug.cgi?id=43794

Since persistient storage is shared between pages, there's no way to modify
some settings related to it on a per page basis. As such, it's not technically
correct for these settings to be on the Page's settings. Create a new class
called GroupSettings, move the 2 group-wide local storage settings there, and
add a new setting for IndexedDB's path (which is prompting this change).

No behavior has changed, so no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): (WebCore::PageGroup::localStorage):
  • page/PageGroup.h: (WebCore::PageGroup::groupSettings):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setSessionStorageQuota):
  • page/Settings.h:

2010-08-10 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Adam Barth.

Some settings are linked to the PageGroup not the Page. Create a new class for those.
​https://bugs.webkit.org/show_bug.cgi?id=43794

Change WebView to use the new GroupSettings class rather than Settings for the
settings that moved. This is sub-optimal since the settings aren't really
per-view, but we can't really change the API at this point.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _preferencesChangedNotification:]):

2010-08-11 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Adam Barth.

Some settings are linked to the PageGroup not the Page. Create a new class for those.
​https://bugs.webkit.org/show_bug.cgi?id=43794

Change WebSettings to use the new GroupSettings class rather than Settings for the
settings that moved. This is sub-optimal since the settings aren't really
per-view, but I don't see how we can change the API at this point.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
2:43 AM Changeset in webkit [65227] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Decode images directly to QPixmap
​https://bugs.webkit.org/show_bug.cgi?id=40797

Patch by Benjamin Poulain <​benjamin.poulain@nokia.com> on 2010-08-12
Reviewed by Simon Hausmann.

Use the new API of Qt 4.7 to decode data from the image
reader directly to QPixmap.

This allow us to use JDCT_IFAST when decoding jpeg images
to pixmap, and to decode animated GIF images, while still
using in-place conversion of color space.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):

2:41 AM Changeset in webkit [65226] by bulach@chromium.org
  • 12 edits in trunk

2010-07-14 Marcus Bulach <​bulach@chromium.org>

Reviewed by Darin Adler.

Removes DontCheckEnums from some IDLs and fixes the corresponding enums.
​https://bugs.webkit.org/show_bug.cgi?id=42278

This is a follow-up to ​https://bugs.webkit.org/show_bug.cgi?id=42250: it fixes some IDL/.h and enables generating compile-time checks for enums.

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js: (createEventHelper): splits event creation so that we can test without init. (testInitEvent): adds test for OverflowEvent creation.

2010-07-14 Marcus Bulach <​bulach@chromium.org>

Reviewed by Darin Adler.

Removes DontCheckEnums from some IDLs and fixes the corresponding enums.
​https://bugs.webkit.org/show_bug.cgi?id=42278

This is a follow-up to ​https://bugs.webkit.org/show_bug.cgi?id=42250: it fixes some IDL/.h and enables generating compile-time checks for enums.

Tests: idls should generate valid code.

  • dom/Node.h: (WebCore::Node::):
  • dom/Node.idl:
  • dom/OverflowEvent.h: (WebCore::OverflowEvent::):
  • dom/OverflowEvent.idl:
  • html/FileReader.cpp: (WebCore::FileReader::readyState):
  • html/FileReader.h: (WebCore::FileReader::):
  • html/FileReader.idl:
1:50 AM Changeset in webkit [65225] by commit-queue@webkit.org
  • 3 edits in trunk

2010-08-12 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Nikolas Zimmermann.

[CMake] Cleanup generator code.
​https://bugs.webkit.org/show_bug.cgi?id=39164

  • cmake/WebKitGenerators.cmake:
  • cmake/WebKitMacros.cmake:
1:24 AM Changeset in webkit [65224] by Philippe Normand
  • 2 edits
    8 adds in trunk/LayoutTests

2010-08-12 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] new media tests baselines needed
​https://bugs.webkit.org/show_bug.cgi?id=42444

Visually check those tests, they seemed fine to me so I added
their baselines.

  • platform/gtk/Skipped:
  • platform/gtk/media/audio-controls-rendering-expected.txt: Added.
  • platform/gtk/media/video-display-toggle-expected.txt: Added.
  • platform/gtk/media/video-empty-source-expected.txt: Added.
  • platform/gtk/media/video-layer-crash-expected.txt: Added.
  • platform/gtk/media/video-no-audio-expected.txt: Added.
  • platform/gtk/media/video-transformed-expected.txt: Added.
  • platform/gtk/media/video-zoom-controls-expected.txt: Added.
  • platform/gtk/media/video-zoom-expected.txt: Added.
1:06 AM Changeset in webkit [65223] by alex
  • 2 edits in trunk/WebCore

2010-08-12 Alejandro G. Castro <​alex@igalia.com>

Reviewed by David Levin.

The #if clause enabling a feature should avoid the all includes of
the feature
​https://bugs.webkit.org/show_bug.cgi?id=43866

Modified the position of the guard to avoid including all the
headers if the feature controlling the guard is not enabled.

  • dom/make_names.pl:
12:18 AM Changeset in webkit [65222] by commit-queue@webkit.org
  • 8 edits in trunk

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65221.
​http://trac.webkit.org/changeset/65221
​https://bugs.webkit.org/show_bug.cgi?id=43896

Broke snow leopard build. (Requested by dave_levin on
#webkit).

  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::):

2010-08-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r65221.
​http://trac.webkit.org/changeset/65221
​https://bugs.webkit.org/show_bug.cgi?id=43896

Broke snow leopard build. (Requested by dave_levin on
#webkit).

  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3D.cpp:
  • src/WebGraphicsContext3DDefaultImpl.cpp:
  • src/WebGraphicsContext3DDefaultImpl.h:
12:00 AM Changeset in webkit [65221] by senorblanco@chromium.org
  • 8 edits in trunk

2010-08-11 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Add support for BGRA pixel format to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=43858

Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. Since they differ on semantics (GL ES 2.0 requires
TexImage2D()'s format and internalFormat to match, while desktop GL
will not accept BGRA as an internalFormat), the stub implementation
returns false until these quirks have been implemented and tested on
each port.

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsBGRA): Add implementation for non-chromium platforms which returns false.
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): Add query function (supportsBGRA()) and the BGRA_EXT token.

2010-08-11 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Add support for BGRA pixel format to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=43858

Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. The DefaultImpl returns false, since it does not yet
implement the TexImage2D internalFormat quirks.

  • public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::supportsBGRA):
  • src/GraphicsContext3D.cpp:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
  • src/WebGraphicsContext3DDefaultImpl.h:
Note: See TracTimeline for information about the timeline view.