Timeline
Sep 25, 2010:
- 10:56 PM Changeset in webkit [68340] by
-
- 3 edits2 adds in trunk
2010-09-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Nikolas Zimmermann.
Fix the macro to bail out after setting the SVG style to 'initial'. Check that color is
SVGColor before calling colorFromSVGColorCSSValue which makes sure we don't set invalid
color. Also, doing the static cast in the caller and keeping the function
colorFromSVGColorCSSValue clean to accept only take SVGColor objects.
Test: svg/css/invalid-color-crash.svg
- css/SVGCSSStyleSelector.cpp: (WebCore::colorFromSVGColorCSSValue): (WebCore::CSSStyleSelector::applySVGProperty):
2010-09-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Nikolas Zimmermann.
Tests that we dont crash when setting color to initial for SVG.
https://bugs.webkit.org/show_bug.cgi?id=46471
- svg/css/invalid-color-crash-expected.txt: Added.
- svg/css/invalid-color-crash.svg: Added.
- 3:57 PM Changeset in webkit [68339] by
-
- 4 edits in trunk/JavaScriptCore
Relearning the lesson that last minute changes are bad.
- 2:42 PM Changeset in webkit [68338] by
-
- 11 edits in trunk/JavaScriptCore
2010-09-25 Oliver Hunt <oliver@apple.com>
Reviewed by Cameron Zwarich.
Avoid constructing arguments object when accessing length and index properties
https://bugs.webkit.org/show_bug.cgi?id=46572
Add opcodes to read argument length and properties, and then implement them.
Much like other lazy opcodes these opcodes take a fast path when the arguments
object has not been instantiated, and fall back on generic access mechanisms
if they are acting on an instantiated object.
3% win on v8-earleyboyer, no change elsewhere.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitGetArgumentsLength): (JSC::BytecodeGenerator::emitGetArgumentByVal):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp: (JSC::BracketAccessorNode::emitBytecode): (JSC::DotAccessorNode::emitBytecode):
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_arguments_length): (JSC::JIT::emitSlow_op_get_arguments_length): (JSC::JIT::emit_op_get_argument_by_val): (JSC::JIT::emitSlow_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_arguments_length): (JSC::JIT::emitSlow_op_get_arguments_length): (JSC::JIT::emit_op_get_argument_by_val): (JSC::JIT::emitSlow_op_get_argument_by_val):
- 1:42 PM Changeset in webkit [68337] by
-
- 3 edits in trunk/WebCore
2010-09-25 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
FormatBlockCommand's modifyRange and doApply should be merged
https://bugs.webkit.org/show_bug.cgi?id=46504
Isolated the code in doApply to insert and remove lists for single paragraph into doApplyForSingleParagraph.
Merged the code in modifyRange into doApply and cleaned up.
No new tests are added since this is a cleanup.
- editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Merged with modifyRange; calls doApplyForSingleParagraph. (WebCore::FormatBlockCommand::doApplyForSingleParagraph): Added.
- editing/FormatBlockCommand.h:
- 11:09 AM Changeset in webkit [68336] by
-
- 2 edits in trunk/LayoutTests
2010-09-25 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium drt_expectations.txt update.
Speech input appearance tests have image diffs on Linux too.
- platform/chromium/drt_expectations.txt:
- 10:34 AM Changeset in webkit [68335] by
-
- 3 edits2 adds in trunk
<rdar://problem/8478160> Null deref in InlineBox::height()
https://bugs.webkit.org/show_bug.cgi?id=45344
Reviewed by John Sullivan.
WebCore:
Test: fast/css/first-line-parent-style-different.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::firstLineStyleSlowCase): Set the pseudo style bit on the RenderStyle
which is going to supply the first-line style rather than on this object’s RenderStyle. The
styles may differ.
LayoutTests:
- fast/css/first-line-parent-style-different-expected.txt: Added.
- fast/css/first-line-parent-style-different.html: Added.
- 10:30 AM Changeset in webkit [68334] by
-
- 2 edits in trunk/WebCore
<rdar://problem/8478182> Make canHyphenate() return false for unsupported locales
Reviewed by John Sullivan.
No change in functionality, hence no new test.
- platform/text/cf/HyphenationCF.cpp:
(WebCore::::createValueForKey): Return 0 if hyphenation is not available for the locale.
(WebCore::cfLocaleCache): Moved the definition of the cache from lastHyphenLocation() to
this new getter to allow canHyphenate() to share it.
(WebCore::canHyphenate): Now returns true only if hyphenation is available.
(WebCore::lastHyphenLocation): Added an assertion.
- 10:01 AM Changeset in webkit [68333] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-25 Nicolas Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Fix clang warning/error.
https://bugs.webkit.org/show_bug.cgi?id=46552
- src/WorkerFileSystemCallbacksBridge.h:
- 9:17 AM Changeset in webkit [68332] by
-
- 2 edits in trunk/LayoutTests
2010-09-25 Andreas Kling <andreas.kling@nokia.com>
Unreviewed, Qt rebaseline after r68331 which fixed dash offset rendering.
- platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt:
- 8:44 AM Changeset in webkit [68331] by
-
- 2 edits in trunk/WebCore
2010-09-25 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext::setLineDash() should scale dashOffset to penWidth
https://bugs.webkit.org/show_bug.cgi?id=46548
Fixes incorrect rendering of <http://www.carto.net/svg/samples/animated_bustrack.shtml>
This is covered by existing layout tests which need to be rebaselined.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setLineDash):
- 2:07 AM Changeset in webkit [68330] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-25 Patrick Gansterer <Patrick Gansterer>
Unreviewed.
Fix typo in StringHasher class
https://bugs.webkit.org/show_bug.cgi?id=45970
- wtf/StringHashFunctions.h: (WTF::StringHasher::createHash):
- 12:36 AM Changeset in webkit [68329] by
-
- 2 edits in trunk/WebKitTools
2010-09-25 Nicolas Weber <thakis@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=46555
Fix typo in prepare-ChangeLog's help output.
- Scripts/prepare-ChangeLog:
Sep 24, 2010:
- 11:53 PM Changeset in webkit [68328] by
-
- 3 edits in trunk/LayoutTests
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test_expectations.txt and drt_expectations.txt update.
fast/canvas/webgl/null-object-behaviour.html and
fast/canvas/webgl/uniform-location.html were unskipped with r68187,
however, they still fail with the DRT (only on the bot, presumably due
to a Leopard-only issue), just like a lot of other WebGL tests.
fast/viewport/viewport-128.html is yet another viewport test that only
the Qt port supports.
animations/opacity-transform-animation.html hasn't passed since it was
committed with r68323.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 10:52 PM Changeset in webkit [68327] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Unnecessary blob dependency in WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=46488
r66322 shouldn't have added a blob dependency by hand to targets in
WebKit.gyp, instead blob should be a dependency of webkit_support.
http://crrev.com/59406 did that, so we can now remove these deps.
- WebKit.gyp:
- 8:45 PM WebKit Team edited by
- (diff)
- 8:42 PM WebKit Team edited by
- (diff)
- 8:29 PM Changeset in webkit [68326] by
-
- 2 edits in trunk/WebCore
Fix accidental increase in the size of InlineBox by using a bit
field to indicate that a bool should only take up 1 bit.
Rubber-stamped by Dan Bernstein.
- rendering/InlineBox.h:
- 8:26 PM Changeset in webkit [68325] by
-
- 2 edits in trunk/WebKit2
Fix release build.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- 8:05 PM Changeset in webkit [68324] by
-
- 2 edits in trunk/WebKit2
One more build fix.
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::setEditCommandState):
- 7:52 PM Changeset in webkit [68323] by
-
- 4 edits4 adds in trunk
2010-09-24 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Accelerated transitions do not suspend/resume properly.
https://bugs.webkit.org/show_bug.cgi?id=43792
(1) Fix regression from r68233, where if an animation affected two
properties, only one would animate. The testcase tests this.
(2) Fix a flash at the end of an animation or transition that has been
paused and resumed. The flash occurred because we used CAAnimation's
timeOffset when resuming to push the start of the animation into
the past. However, timeOffset does not play nicely with fill modes,
causing a single frame of animation with the element in its unanimated state.
Fixed this by offsetting the beginTime into the past, rather than setting
timeOffset. Normally we submit animations with beginTime == 0, and rely
on CA assigning a beginTime when the animation is committed. This beginTime
is then passed to AnimationController to sync hardware and software animations.
However, since the code now assigns beginTimes in the past (on resume),
we now have to denote whether we've done this, and send an appropriate
timestamp back to AnimationController.
(3) Finally, the patch removes PropertyAnimationPair and just uses LayerPropertyAnimation
instead. This is just cleanup.
Test: animations/opacity-transform-animation.html
- platform/graphics/mac/GraphicsLayerCA.h: Remove PropertyAnimationPair, and change AnimationsMap to store a vector of LayerPropertyAnimation. New method, animationDidStart(), is called from the -animationDidStart: callback.
- platform/graphics/mac/GraphicsLayerCA.mm: (-[WebAnimationDelegate animationDidStart:]): Just call m_graphicsLayer->animationDidStart() now. (WebCore::animationIdentifier): We need to pass in the property, to fix (1) (WebCore::GraphicsLayerCA::moveOrCopyAnimationsForProperty): Copy the WebKitAnimationBeginTimeSet value, if present. (WebCore::GraphicsLayerCA::animationDidStart): Call notifyAnimationStarted() on the client, after testing if we set a non-zero beginTime on this particular animation. (WebCore::GraphicsLayerCA::updateLayerAnimations): Change to use LayerPropertyAnimation. (WebCore::GraphicsLayerCA::setCAAnimationOnLayer): Set value for WebKitAnimationBeginTimeSetKey if we have a non-zero timeOffset. Make animationID an NSString, to avoid several conversions. (WebCore::GraphicsLayerCA::removeCAAnimationFromLayer): Make animationID an NSString, to avoid several conversions. (WebCore::copyAnimationProperties): Copy WebKitAnimationBeginTimeSetKey if present. (WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer): Make animationID an NSString, to avoid several conversions.
- 7:32 PM Changeset in webkit [68322] by
-
- 23 edits4 adds in trunk
Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
<rdar://problem/8359279>
https://bugs.webkit.org/show_bug.cgi?id=46546
Reviewed by Darin Adler.
WebKit2:
- Adds new WKBundleHitTestResultRef object to represent a content under a cursor.
- Adds new Bundle and UI level mouseDidMoveOverElement UIClient callbacks, with pass through userData to communicate context up to the UIProcess
- Shared/APIObject.h:
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::mouseDidMoveOverElement):
- UIProcess/WebPageProxy.h:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::mouseDidMoveOverElement):
- UIProcess/WebUIClient.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleBase.h:
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp: Added.
(WKBundleHitTestResultGetTypeID):
(WKBundleHitTestResultGetNodeHandle):
(WKBundleHitTestResultGetFrame):
(WKBundleHitTestResultCopyAbsoluteLinkURL):
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h: Added.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp: Added.
(WebKit::InjectedBundleHitTestResult::create):
(WebKit::InjectedBundleHitTestResult::nodeHandle):
(WebKit::InjectedBundleHitTestResult::webFrame):
(WebKit::InjectedBundleHitTestResult::absoluteLinkURL):
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h: Added.
(WebKit::InjectedBundleHitTestResult::coreHitTestResult):
(WebKit::InjectedBundleHitTestResult::InjectedBundleHitTestResult):
(WebKit::InjectedBundleHitTestResult::type):
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::mouseDidMoveOverElement):
- win/WebKit2.vcproj:
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(mouseDidMoveOverElement):
(-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp:
(mouseDidMoveOverElement):
(BrowserView::create):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
- WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
- 6:57 PM Changeset in webkit [68321] by
-
- 2 edits in trunk/WebCore
2010-09-24 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
SVG: Avoid calling pow() in genericParseNumber() unless necessary
https://bugs.webkit.org/show_bug.cgi?id=46537
0.4% speedup on <http://themaninblue.com/experiment/AnimationBenchmark/svg/>
- svg/SVGParserUtilities.cpp: (WebCore::genericParseNumber): Only call pow() when we have an exponent.
- 6:50 PM Changeset in webkit [68320] by
-
- 4 edits in trunk/WebKit2
Build fix.
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/win/WebView.cpp:
(WebKit::WebView::setEditCommandState):
- UIProcess/win/WebView.h:
- 6:39 PM Changeset in webkit [68319] by
-
- 2 edits in trunk/WebKit/wx
2010-09-24 Kwang Yul Seo <skyul@company100.net>
Reviewed by Andreas Kling.
[wx] ChromeClientWx::scaleFactor must return 1.0
https://bugs.webkit.org/show_bug.cgi?id=46542
The default value of ChromeClientWx::scaleFactor must be 1.0.
Otherwise, canvas element won't be painted.
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::scaleFactor):
- 6:36 PM Changeset in webkit [68318] by
-
- 14 edits in trunk/WebKit2
Maui: Pasteboard support (42317)
<rdar://problem/7660537>
https://bugs.webkit.org/show_bug.cgi?id=42317
Reviewed by Darin Adler.
This is the final piece of the pasteboard support for WebKit2.
The menu validation has been hooked up for Mac. The validation is
performed asynchronously and the menu entries updated while the menu
is visible. I've created a generic mechanism to call editing commands
that will make it easy to add new commands we will support in the future.
The commands supported now are copy, cut, paste, pasteAsPlainText, delete
and selectAll.
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added DidValidateMenuItem.
- UIProcess/API/mac/PageClientImpl.h: Added setEditCommandState.
- UIProcess/API/mac/PageClientImpl.mm: Added setEditCommandState implementation.
(WebKit::PageClientImpl::setEditCommandState): Added.
- UIProcess/API/mac/WKView.mm:
(WebCore::MenuItemInfo::MenuItemInfo):
(-[WKView initWithFrame:pageNamespaceRef:]):
(createSelectorExceptionMap): Added.
(commandNameForSelector): Added.
(-[WKView validateUserInterfaceItem:]): Added implementation.
(-[WKView _setUserInterfaceItemState:enabled:state:]): Added.
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::validateMenuItem):
(WebKit::WebPageProxy::executeEditCommand):
(WebKit::WebPageProxy::didReceiveMessage): Now processing also
DidValidateMenuItem.
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::executeEditingCommand): Fixed.
(WebKit::WebPage::isEditingCommandEnabled): Fixed.
(WebKit::WebPage::validateMenuItem): Added.
(WebKit::WebPage::executeEditCommand): Added.
- WebProcess/WebPage/WebPage.h: Removed cut, copy, paste, selectAll.
Added validateMenuItem and executeEditCommand.
- WebProcess/WebPage/WebPage.messages.in: Added new messages.
- UIProcess/API/qt/qwkpage.cpp:
(WebKit::QWKPage::setEditCommandState): Added.
- UIProcess/API/qt/qwkpage_p.h: Added
- 6:36 PM Changeset in webkit [68317] by
-
- 4 edits in trunk/WebKitTools
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Allow rebaselines for webkit-patch rebaseline to be chosen
https://bugs.webkit.org/show_bug.cgi?id=46407
Instead of always rebaselining all failing tests, allow a subset to be
chosen.
- Scripts/webkitpy/common/system/user.py:
- Scripts/webkitpy/tool/commands/rebaseline.py:
- 5:47 PM Changeset in webkit [68316] by
-
- 2 edits in trunk/WebKit2
Build fix.
- WebKit2.xcodeproj/project.pbxproj:
- 5:40 PM Changeset in webkit [68315] by
-
- 32 edits2 copies in branches/audio/WebCore
audio branch: changes in preparation for landing in trunk
- split BiquadProcessor files into BiquadProcessor and BiquadDSPKernel
- HRTFDatabase, HRTFDatabaseLoader, and HRTFPanner cleanup
- AudioPannerNode cleanup
- AudioBasicProcessorNode cleanup
- other misc. cleanup
- 4:36 PM Changeset in webkit [68314] by
-
- 3 edits in trunk/LayoutTests
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test_expectations.txt and drt_expectations.txt update.
Userscript test now pass with both the Chromium DRT and test_shell
(as of http://crrev.com/60526).
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 4:33 PM Changeset in webkit [68313] by
-
- 4 edits in trunk
2010-09-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] opening local files on win32
https://bugs.webkit.org/show_bug.cgi?id=31066
This is tested by changes to the testmimehandling API test.
- platform/network/soup/ResourceHandleSoup.cpp: Properly convert the GContentType of a file into a mime type. This is important for non-Unix platforms.
2010-09-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] opening local files on win32
https://bugs.webkit.org/show_bug.cgi?id=31066
Add tests that check the mime type returned by local files loaded via file URLs.
- tests/testmimehandling.c: (testRemoteMimeType): Added. (testLocalMimeType): Added. (main): Run tests by using g_test_add_data_func with either testRemoteMimeType or testLocalMimeType.
- 4:22 PM Changeset in webkit [68312] by
-
- 10 edits in trunk
2010-09-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
[chromium] Implement TextInputController::firstRectForCharacterRange
https://bugs.webkit.org/show_bug.cgi?id=38100
The following test now passes on chromium DumpRenderTree:
platform/mac/editing/input/caret-primary-bidi.html
platform/mac/editing/input/firstrectforcharacterrange-plain.html
platform/mac/editing/input/range-for-empty-document.html
editing/inserting/caret-position.html
- platform/chromium/test_expectations.txt:
2010-09-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
[chromium] Implement TextInputController::firstRectForCharacterRange
https://bugs.webkit.org/show_bug.cgi?id=38100
Implemented TextInputController::firstRectForCharacterRange for chromium platform.
Because the function needs to return an array of integers, added makeIntArray to WebBindings.
makeIntArray does not take Vector because WebBindings.h is included in plugin glue code
where it cannot find wtf/Vector.h.
No new tests are added since we need to implement the same feature in chromium side
in order to enable any tests that uses this function.
- public/WebBindings.h:
- public/WebFrame.h:
- src/WebBindings.cpp: (WebKit::makeIntArrayImpl): Added. (WebKit::WebBindings::makeIntArray): Added.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange): Added.
- src/WebFrameImpl.h:
2010-09-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
[chromium] Implement TextInputController::firstRectForCharacterRange
https://bugs.webkit.org/show_bug.cgi?id=38100
Implemented TextInputController::firstRectForCharacterRange for chromium platform.
No new tests are added since we need to implement the same feature in chromium side
in order to enable any tests that uses this function.
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::firstRectForCharacterRange): Added.
- 4:18 PM Changeset in webkit [68311] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] add individual entries for repaint failures on mac
https://bugs.webkit.org/show_bug.cgi?id=46517
- platform/chromium/test_expectations.txt:
- 4:17 PM Changeset in webkit [68310] by
-
- 2 edits in trunk/WebCore
2010-09-24 Pawel Hajdan <phajdan.jr@chromium.org>
Reviewed by Dumitru Daniliuc.
Move the implementation of chromium_vfs to webkit for POSIX.
This allows us to link Chrome with system-provided SQLite on Linux.
See also http://code.google.com/p/chromium/issues/detail?id=22208.
https://bugs.webkit.org/show_bug.cgi?id=45416
No new tests.
- platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (sqliteErrorFromPosixError): (releaseLockInfo): (releaseOpenInfo): (findLockInfo): (chromiumCheckReservedLock): (rangeLock): (chromiumLock): (closePendingFds): (chromiumUnlock): (chromiumCloseNoLock): (chromiumClose): (chromiumCheckReservedLockNoop): (chromiumLockNoop): (chromiumUnlockNoop): (seekAndRead): (chromiumRead): (seekAndWrite): (chromiumWrite): (syncWrapper): (chromiumSync): (chromiumTruncate): (chromiumFileSize): (chromiumFileControl): (chromiumSectorSize): (chromiumDeviceCharacteristics): (fillInChromiumFile): (findReusableFd): (chromiumOpen): (chromiumDelete): (chromiumAccess): (chromiumFullPathname): (chromiumDlOpen): (chromiumDlError): (chromiumDlSym): (chromiumDlClose): (chromiumRandomness): (chromiumSleep): (chromiumCurrentTime): (chromiumGetLastError): (WebCore::SQLiteFileSystem::registerSQLiteVFS):
- 4:12 PM Changeset in webkit [68309] by
-
- 12 edits1 add in trunk/WebKit2
Fill in more of PluginProcess
https://bugs.webkit.org/show_bug.cgi?id=46534
Reviewed by Adam Roben.
- DerivedSources.make:
Add PluginProcessProxy.
- Platform/CoreIPC/MessageID.h:
Add a MessageClassPluginProcessProxy message class.
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::PluginProcess):
Initialize the shutdown timer.
(WebKit::PluginProcess::initializeConnection):
Rename this to initializeConnection to avoid conflicts in the CoreIPC message handler.
(WebKit::PluginProcess::removeWebProcessConnection):
Remove the given web process connection from our vector.
(WebKit::PluginProcess::initialize):
Create the plug-in module.
(WebKit::PluginProcess::createWebProcessConnection):
Create a connection handle and send it to the UI process.
(WebKit::PluginProcess::shutdownTimerFired):
Quit.
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
Call initializeConnection.
- Scripts/webkit2/messages.py:
Add CoreIPC::MachPort as a special case.
- Scripts/webkit2/messages_unittest.py:
Add test case.
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
Add empty function.
- UIProcess/Plugins/PluginProcessProxy.messages.in: Added.
- WebKit2.xcodeproj/project.pbxproj:
Add PluginProcessProxy.messages.in.
- WebKit2Prefix.h:
Add an ENABLE_PLUGIN_PROCESS #define which is 0 for now.
- 4:09 PM Changeset in webkit [68308] by
-
- 3 edits in trunk/WebKitTools
2010-09-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue reports land failures as "PASS"
https://bugs.webkit.org/show_bug.cgi?id=46530
We were ignoring the return value of land instead of passing it back to
CommitQueue. Of course, this was the one case I forgot to test!
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- 3:57 PM Changeset in webkit [68307] by
-
- 3 edits3 adds in trunk
2010-09-24 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Dirk Schulze.
SVG: Make SVGLength's stringToLengthType() stricter and faster
https://bugs.webkit.org/show_bug.cgi?id=46066
Add test coverage for handling of invalid SVGLength units.
- svg/custom/invalid-length-units-expected.txt: Added.
- svg/custom/invalid-length-units.html: Added.
- svg/custom/script-tests/invalid-length-units.js: Added. (trySettingLength):
2010-09-24 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Dirk Schulze.
SVG: Make SVGLength's stringToLengthType() stricter and faster
https://bugs.webkit.org/show_bug.cgi?id=46066
Only accept unit names immediately following the numeric value.
This behavior matches Gecko.
Also, using String::endsWith("foo") caused a temporary WTF::String to be created.
Avoid this by comparing characters directly.
10.5% speedup on <http://data.xeoh.net/svg.benchmark/>
Test: svg/custom/invalid-length-units.html
- svg/SVGLength.cpp: (WebCore::stringToLengthType): (WebCore::SVGLength::setValueAsString):
- 3:48 PM Changeset in webkit [68306] by
-
- 3 edits2 deletes in trunk/LayoutTests
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Layout test html5lib/runner.html failing on Chromium
https://bugs.webkit.org/show_bug.cgi?id=42845
Rebaseline html5lib tests (diffs from upstream are still only due to V8
differences).
- platform/chromium-mac/html5lib/runner-expected.txt: Removed.
- platform/chromium-win/html5lib/runner-expected.txt: Removed.
- platform/chromium/html5lib/runner-expected.txt:
- platform/chromium/test_expectations.txt:
- 3:47 PM Changeset in webkit [68305] by
-
- 1 edit2 copies in branches/chromium/517
Merge 67716
Review URL: http://codereview.chromium.org/3405033
- 3:31 PM Changeset in webkit [68304] by
-
- 5 edits in trunk
Versioning.
- 3:28 PM Changeset in webkit [68303] by
-
- 1 copy in tags/Safari-534.9
New tag.
- 3:26 PM Changeset in webkit [68302] by
-
- 1 edit in branches/chromium/517/WebCore/rendering/RenderObject.cpp
Merge 68278
Review URL: http://codereview.chromium.org/3497007
- 3:25 PM Changeset in webkit [68301] by
-
- 1 edit2 copies in branches/chromium/517
Merge 68158
Review URL: http://codereview.chromium.org/3404021
- 3:13 PM Changeset in webkit [68300] by
-
- 1 edit4 copies in branches/chromium/517
Merge 68062
Review URL: http://codereview.chromium.org/3471012
- 3:12 PM Changeset in webkit [68299] by
-
- 9 edits in trunk/WebKit2
Give windowed Netscape plugins their own window
The plugin window is a child of the WebView's window. The WebView's
window is in the UI process, and the plugin's window is in the web
process (though someday it will be in the plugin process), but Windows
mostly handles this just fine. Right now we move the plugin's window
in the web process, but we need to do it at paint time in the UI
process instead so that the plugin windows will stay in sync with the
web page's contents. There are also a whole bunch of plugin quirks
that WebKit1 supports that we don't support yet, but that's a task for
another day.
Fixes <http://webkit.org/b/44428> Get basic in-process windowed
plugins working in WebKit2 on Windows
Reviewed by Anders Carlsson.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::destroy):
(WebKit::NetscapePlugin::geometryDidChange):
Call the new platform-specific functions.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Added
platformDestroy/platformGeometryDidChange, and an m_window member on
Windows to hold our window.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformGeometryDidChange):
- WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformGeometryDidChange):
Stubbed these out.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::registerPluginView): Added. The code came from
WebCore's PluginViewWin.cpp, though I changed it to add one to
COLOR_WINDOW, since that's what MSDN says we should do.
(WebKit::NetscapePlugin::platformPostInitialize): If we're windowed,
create a window for the plugin and make it a child of the WebView's
window. If we're not windowed, just set m_window to 0.
(WebKit::NetscapePlugin::platformDestroy): Destroy our window if we
have one and it hasn't been destroyed already.
(WebKit::NetscapePlugin::platformGeometryDidChange): Update our
window's size and position.
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::nativeParentWindow):
- WebProcess/Plugins/PluginView.h:
Added nativeParentWindow on Windows to return the WebView's window.
- 3:12 PM Changeset in webkit [68298] by
-
- 9 edits in trunk/WebKit2
Pass the WebView's HWND over to the web process
The HWND is packaged up in the WebPageCreationParameters and stored in
the WebPage. It will eventually be used by windowed plugins.
Fixes <http://webkit.org/b/46512> WebPage needs access to its
corresponding HWND from the UI process
Reviewed by Anders Carlsson.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Encode and decode the HWND as a uint64_t.
- Shared/WebPageCreationParameters.h: Added a nativeWindow member to
store the HWND.
- UIProcess/PageClient.h: Added a nativeWindow function on Windows.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters): Store the HWND from the
page client in the struct to be sent to the web process.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Moved the call to initializeWebPage after
we've created our window so that our window will be ready when
WebPageProxy asks for it to send it to the web process.
(WebKit::WebView::nativeWindow): Added. Just returns our window.
- UIProcess/win/WebView.h: Added nativeWindow.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Store the HWND in the new m_nativeWindow
member.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::nativeWindow): Added this simple getter.
- 3:11 PM Changeset in webkit [68297] by
-
- 3 edits in trunk/WebKit2
Add WebPageProxy::creationParameters
Fixes <http://webkit.org/b/46510> WebPageProxy has a bunch of
duplicated WebPageCreationParameters code
Reviewed by Anders Carlsson.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
Use creationParameters.
(WebKit::WebPageProxy::creationParameters):
- UIProcess/WebPageProxy.h:
Added creationParameters.
- 3:11 PM Changeset in webkit [68296] by
-
- 4 edits in trunk/WebKit2
Make WebPage::create take a WebPageCreationParameter struct
It only makes sense, after all.
Fixes <http://webkit.org/b/46502>.
Reviewed by Anders Carlsson.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::create):
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
Changed to take a WebPageCreationParameters struct.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage): Changed to pass a
WebPageCreationParameters struct.
- 3:09 PM Changeset in webkit [68295] by
-
- 1 edit2 copies in branches/chromium/517
Merge 67967
Review URL: http://codereview.chromium.org/3389031
- 3:04 PM Changeset in webkit [68294] by
-
- 3 edits in trunk/WebKitTools
2010-09-24 Kenichi Ishibashi <bashi@google.com>
Reviewed by Eric Seidel.
new-run-webkit-tests prints out nothing when build-dumprendertree fails
https://bugs.webkit.org/show_bug.cgi?id=37563
Print error message when build-dumprendertree fails.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 3:04 PM Changeset in webkit [68293] by
-
- 1 edit in branches/chromium/517/WebCore/html/HTMLFrameOwnerElement.cpp
Merge 67659
Review URL: http://codereview.chromium.org/3427022
- 2:54 PM Changeset in webkit [68292] by
-
- 12 edits2 adds in trunk
2010-09-24 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Keep viewport information in Document
https://bugs.webkit.org/show_bug.cgi?id=46385
The viewport meta data (layout viewport, scale) needs to be set again when bringing
back a page from the page cache. As the viewport metadata is only retrieved while parsing
the document, we need to store it in the Document class.
- fast/viewport/viewport-128-expected.txt: Copied from LayoutTests/fast/viewport/viewport-19-expected.txt.
- fast/viewport/viewport-128.html: Added.
2010-09-24 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Keep viewport information in Document
https://bugs.webkit.org/show_bug.cgi?id=46385
The viewport meta data (layout viewport, scale) needs to be set again when bringing
back a page from the page cache. As the viewport metadata is only retrieved while parsing
the document, we need to store it in the Document class.
Test: fast/viewport/viewport-128.html
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp: (WebCore::Document::processViewport): (WebCore::Document::setInPageCache):
- dom/Document.h: (WebCore::Document::viewportArguments):
2010-09-24 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Keep viewport information in Document
https://bugs.webkit.org/show_bug.cgi?id=46385
The viewport meta data (layout viewport, scale) needs to be set again when bringing
back a page from the page cache. As the viewport metadata is only retrieved while parsing
the document, we need to store it in the Document class.
- Api/qwebframe.cpp: (QWebFramePrivate::viewportArguments):
- Api/qwebframe_p.h:
- Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::didReceiveViewportArguments):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
- 2:47 PM Changeset in webkit [68291] by
-
- 5 edits in trunk/WebKit2
Expose all WebKit2 C API preferences via the Qt API.
Reviewed by Andreas Kling.
Also rename a wrongly named C method (was using Web instead of WK).
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCopyStandardFontFamily):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/API/qt/qwkpreferences.cpp:
(QWKPreferences::setFontFamily):
(QWKPreferences::fontFamily):
(QWKPreferences::testAttribute):
(QWKPreferences::setAttribute):
- UIProcess/API/qt/qwkpreferences.h:
- 2:47 PM BuildBot edited by
- (diff)
- 2:07 PM Changeset in webkit [68290] by
-
- 12 edits in branches/chromium/517
Merge 68061 - 2010-09-22 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
Trying to reland a version of r67749:
Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registerExtension):
- bindings/v8/V8Proxy.h:
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::allowScriptExtension):
- loader/FrameLoaderClient.h:
2010-09-22 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
Trying to reland a version of r67749:
Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721
- public/WebFrameClient.h: (WebKit::WebFrameClient::allowScriptExtension):
- public/WebScriptController.h:
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowScriptExtension):
- src/FrameLoaderClientImpl.h:
- src/WebScriptController.cpp: (WebKit::WebScriptController::registerExtension):
TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/3453022
- 2:06 PM Changeset in webkit [68289] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-24 Patrick Gansterer <paroga@paroga.com>
Reviewed by Gavin Barraclough.
Add WTF::StringHasher
https://bugs.webkit.org/show_bug.cgi?id=45970
StringHasher is a class for calculation stringHash out of character string.
This class will unify the different usages of the same algorithm.
- wtf/StringHashFunctions.h: (WTF::StringHasher::StringHasher): (WTF::StringHasher::addCharacters): (WTF::StringHasher::addCharacter): (WTF::StringHasher::hash): (WTF::StringHasher::createHash): (WTF::StringHasher::defaultCoverter): (WTF::StringHasher::addCharactersToHash): (WTF::stringHash):
- 1:54 PM Changeset in webkit [68288] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-24 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Variable declarations inside a catch scope don't get propogated to the parent scope
https://bugs.webkit.org/show_bug.cgi?id=46501
Add logic to make variable declaration look for a scope for the
new variable. This allows us to create a scope (eg. for catch)
and then seal it, so that additional variable declarations
contained are propogated to the correct target. Strangely this
comes out as a performance win, but I think it's mostly cache
effects.
- parser/JSParser.cpp: (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::preventNewDecls): (JSC::JSParser::Scope::allowsNewDecls): (JSC::JSParser::declareVariable): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionDeclaration):
- 1:47 PM Changeset in webkit [68287] by
-
- 2 edits in trunk/WebKit2
messages_unittest.py should compare the generated results against expected results
https://bugs.webkit.org/show_bug.cgi?id=46490
Reviewed by Adam Roben.
- Scripts/webkit2/messages_unittest.py:
- 1:22 PM Changeset in webkit [68286] by
-
- 8 edits in trunk/LayoutTests
2010-09-24 Stephen White <senorblanco@chromium.org>
Unreviewed; new test baselines and test_expectations update.
[CHROMIUM] Rebaseline some fast/speech test results for chromium-mac. Also mark svg/clip-path/clip-path-text-and-stroke.svg as crashing intermittently.
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium/test_expectations.txt:
- 1:11 PM Changeset in webkit [68285] by
-
- 1 edit1 add in trunk/JavaScriptCore
2010-09-24 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Csaba Osztrogonác.
Add a Windows compatible inttypes.h header to fix WinCE build.
https://bugs.webkit.org/show_bug.cgi?id=46463
- os-win32/inttypes.h: Added.
- 12:43 PM Changeset in webkit [68284] by
-
- 6 edits1 copy in trunk/WebKit2
Make it possible to get the page preferences for Qt WebKit2 port.
Reviewed by Antonio Gomes.
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::QWKPagePrivate):
(QWKPage::preferences):
- UIProcess/API/qt/qwkpage.h:
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/API/qt/qwkpreferences.cpp:
(QWKPreferencesPrivate::createPreferences):
(QWKPreferencesPrivate::createSharedPreferences):
(QWKPreferences::sharedPreferences):
(QWKPreferences::QWKPreferences):
- UIProcess/API/qt/qwkpreferences.h:
- 12:32 PM Changeset in webkit [68283] by
-
- 6 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46496, rename containingBlockWidthForContent to
containingBlockLogicalWidthForContent.
Reviewed by Sam Weinig.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::localCaretRect):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeReplacedWidthUsing):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::containingBlockLogicalWidthForContent):
- rendering/RenderBoxModelObject.h:
- 12:14 PM Changeset in webkit [68282] by
-
- 9 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46489, rename the lineWidth and left/RightOffset methods
to reflect that they will be logical.
Reviewed by Sam Weinig.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::leftSelectionOffset):
(WebCore::RenderBlock::rightSelectionOffset):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::getClearDelta):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::fitBelowFloats):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::checkLinesForTextOverflow):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockWidthForContent):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyLineClamp):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTop):
- 12:06 PM Changeset in webkit [68281] by
-
- 11 edits in trunk/JavaScriptCore
REGRESSION(r68223): It broke 2-3 tests on bots (Requested by Ossy on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=46448
Reviewed by Gavin Barraclough
Roll this back in, with additional logic to prevent us from delaying construction
of functions named "arguments"
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitInitLazyRegister):
(JSC::BytecodeGenerator::registerFor):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::constRegisterFor):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitLazyNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionInternal):
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_init_lazy_reg):
(JSC::JIT::emit_op_new_func):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_init_lazy_reg):
- parser/Nodes.h:
(JSC::ScopeNode::needsActivationForMoreThanVariables):
- 11:55 AM Changeset in webkit [68280] by
-
- 2 edits in trunk/WebKit/mac
automaticSpellingCorrectionEnabled isn't updated.
https://bugs.webkit.org/show_bug.cgi?id=46486
<rdar://problem/8475212>
Patch by Jia Pu <jpu@apple.com> on 2010-09-24
Reviewed by Dan Bernstein.
- WebView/WebView.mm:
(+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"
instead of "automaticTextReplacementEnabled".
- 11:38 AM Changeset in webkit [68279] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-24 Tony Chang <tony@chromium.org>
Unreviewed, fix chromium compile after r68276 which renamed
Render*::minPrefWidth to minPreferredLogicalWidth.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::contentsPreferredWidth):
- 11:21 AM Changeset in webkit [68278] by
-
- 2 edits in trunk/WebCore
2010-09-24 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Comply with spec by generalizing container on which transforms can be applied.
https://bugs.webkit.org/show_bug.cgi?id=46485
Already covered by existing tests.
- rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
- 11:08 AM Changeset in webkit [68277] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 Tony Chang <tony@chromium.org>
Unreviewed, updating test_expectations.txt.
Removing tests that are now passing in test_shell.
- platform/chromium/test_expectations.txt:
- 11:07 AM Changeset in webkit [68276] by
-
- 58 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46482, rename the various prefWidth functions to use
preferredLogicalWidth.
Reviewed by Simon Fraser.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveWidth):
- rendering/AutoTableLayout.h:
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
- rendering/FixedTableLayout.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::RenderBlock::layoutInlineChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::RenderBox):
(WebCore::RenderBox::minPreferredLogicalWidth):
(WebCore::RenderBox::maxPreferredLogicalWidth):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
- rendering/RenderBox.h:
(WebCore::RenderBox::computePreferredLogicalWidths):
- rendering/RenderCounter.cpp:
(WebCore::RenderCounter::computePreferredLogicalWidths):
- rendering/RenderCounter.h:
- rendering/RenderDataGrid.cpp:
(WebCore::RenderDataGrid::computePreferredLogicalWidths):
- rendering/RenderDataGrid.h:
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::computePreferredLogicalWidths):
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
- rendering/RenderFileUploadControl.h:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
(WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderFlexibleBox::allowedChildFlex):
- rendering/RenderFlexibleBox.h:
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::canvasSizeChanged):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computePreferredLogicalWidths):
- rendering/RenderListBox.h:
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerLocation):
(WebCore::RenderListItem::computePreferredLogicalWidths):
- rendering/RenderListItem.h:
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMargins):
- rendering/RenderListMarker.h:
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::computePreferredLogicalWidths):
- rendering/RenderMenuList.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::setPreferredLogicalWidthsDirty):
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):
- rendering/RenderObject.h:
(WebCore::RenderObject::preferredLogicalWidthsDirty):
(WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
(WebCore::RenderObject::minPreferredLogicalWidth):
(WebCore::RenderObject::maxPreferredLogicalWidth):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computePreferredLogicalWidths):
- rendering/RenderReplaced.h:
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::computePreferredLogicalWidths):
- rendering/RenderReplica.h:
- rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computePreferredLogicalWidths):
- rendering/RenderSVGRoot.h:
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::computePreferredLogicalWidths):
- rendering/RenderScrollbarPart.h:
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::computePreferredLogicalWidths):
- rendering/RenderSlider.h:
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::computePreferredLogicalWidths):
- rendering/RenderTable.h:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computePreferredLogicalWidths):
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::computePreferredLogicalWidths):
- rendering/RenderTableCol.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::minPreferredLogicalWidth):
(WebCore::RenderText::maxPreferredLogicalWidth):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::width):
- rendering/RenderText.h:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computePreferredLogicalWidths):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::computePreferredLogicalWidths):
(WebCore::RenderView::layout):
- rendering/RenderView.h:
- rendering/TableLayout.h:
- 11:03 AM Changeset in webkit [68275] by
-
- 7 edits2 adds in trunk
DOMWindow::revokeBlobURL erroneously uses ParsedURLString.
https://bugs.webkit.org/show_bug.cgi?id=46434
Reviewed by Alexey Proskuryakov.
WebCore:
Test: fast/files/revoke-blob-url.html
- page/DOMWindow.cpp:
(WebCore::DOMWindow::revokeBlobURL):
LayoutTests:
Add a test. Also update Skipped files for those not-supported platforms.
- fast/files/revoke-blob-url-expected.txt: Added.
- fast/files/revoke-blob-url.html: Added.
- platform/gtk/Skipped:
- platform/mac-wk2/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 11:00 AM Changeset in webkit [68274] by
-
- 8 edits in trunk/WebKit2
Add WebKit2 C API for setting/getting frame flattening and plugin settings.
http://webkit.org/b/46477
Reviewed by Sam Weinig.
NOTE: The plugin setting was partly done but there was no C API.
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetFrameFlatteningEnabled):
(WKPreferencesGetFrameFlatteningEnabled):
(WKPreferencesSetPluginsEnabled):
(WKPreferencesGetPluginsEnabled):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setFrameFlatteningEnabled):
(WebKit::WebPreferences::frameFlatteningEnabled):
(WebKit::WebPreferences::setPluginsEnabled):
(WebKit::WebPreferences::pluginsEnabled):
- UIProcess/WebPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::preferencesDidChange):
- 10:51 AM Changeset in webkit [68273] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 Zhenyao Mo <zmo@google.com>
Unreviewed.
Remove outdated WebGL linux entries from chromium/drt_expectations.txt.
- platform/chromium/drt_expectations.txt:
- 10:24 AM Changeset in webkit [68272] by
-
- 8 edits2 adds in trunk/WebKit2
Add WebPageCreationParameters
This struct is used in any messages that end up creating a WebPage.
Using a struct instead of individual parameters will make it easier to
add platform-specific data, such as an HWND on Windows.
Fixes <http://webkit.org/b/46470> Pass parameters for creating a
WebPage in a single struct
Reviewed by Anders Carlsson.
- Shared/WebPageCreationParameters.cpp: Added.
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Simple encode/decode functions.
- Shared/WebPageCreationParameters.h: Added.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::didReceiveMessage):
- WebProcess/WebProcess.h:
Changed to use WebPageCreationParameters instead of passing the
values individually.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Added WebPageCreationParameters.
- 10:23 AM Changeset in webkit [68271] by
-
- 7 edits1 delete in trunk/WebKit2
Stop pretending that we know how to encode a DrawingArea and just encode the DrawingAreaInfo directly
DrawingAreaBase and friends were trying to hide the fact that they
were just encoding/decoding a DrawingAreaInfo behind the scenes, but
everyone knew what was going on and it was getting embarassing.
Fixes <http://webkit.org/b/46469> Code to encode/decode a
DrawingAreaInfo is confusing
Reviewed by Anders Carlsson.
- Shared/DrawingAreaBase.cpp: Removed.
- Shared/DrawingAreaBase.h: Removed encode/decode.
- UIProcess/ChunkedUpdateDrawingAreaProxy.h: Removed encode override.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
Changed to encode the DrawingAreaInfo directly.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Removed DrawingAreaBase.cpp.
- 10:23 AM Changeset in webkit [68270] by
-
- 6 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=46474
Reviewed by Sam Weinig.
Patch computeWidthUsing to be block-flow-aware. Rename the WidthType enum to LogicalWidthType. Make computeLogicalWidthUsing
query the style for logical width properties instead of width properties.
fast/css/logical-property-resolution.html now fails and gives bad results. This is expected. It will become correct
again as more layout code gets patched.
WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
(WebCore::RenderBox::sizesToIntrinsicWidth):
- rendering/RenderBox.h:
LayoutTests:
- fast/css/logical-property-resolution-expected.txt:
- fast/css/logical-property-resolution.html:
- 10:23 AM Changeset in webkit [68269] by
-
- 9 edits in trunk/WebKit2
Expose a whole DrawingAreaInfo instead of its constituent parts from DrawingAreaBase
This is just a step toward cleaning up how drawing areas are
encoded/ecoded.
Fixes <http://webkit.org/b/46468> DrawingAreaInfo should be used in
more places
Reviewed by Anders Carlsson.
- Shared/DrawingAreaBase.cpp:
(WebKit::DrawingAreaBase::encode): Changed to use info().
- Shared/DrawingAreaBase.h:
(WebKit::DrawingAreaBase::info): Added. Replaces type() and id().
(WebKit::DrawingAreaBase::DrawingAreaBase): Changed to store a
DrawingAreaInfo instead of storing its constituent parts.
- UIProcess/API/mac/WKView.mm:
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
- UIProcess/LayerBackedDrawingAreaProxy.cpp:
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
- WebProcess/WebPage/LayerBackedDrawingArea.cpp:
- WebProcess/WebPage/WebPage.cpp:
Updated to use info().
- 10:22 AM Changeset in webkit [68268] by
-
- 3 edits in trunk/WebKitTools
2010-09-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
NRWT doesn't respect config set with set-webkit-configuration
https://bugs.webkit.org/show_bug.cgi?id=46278
Use Port.default_configuration() instead of hardcoding Release in
ChromiumPort configuration initialization, so that we still inherit the
configuration set by set-webkit-configuration.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- 10:20 AM Changeset in webkit [68267] by
-
- 2 edits2 adds in trunk/WebKit2
Add WebProcessConnection class
https://bugs.webkit.org/show_bug.cgi?id=46478
Reviewed by Sam Weinig.
- PluginProcess/WebProcessConnection.cpp: Added.
- PluginProcess/WebProcessConnection.h: Added.
Add stubbed out WebProcessConnection class.
- WebKit2.xcodeproj/project.pbxproj:
Add files.
- 10:17 AM Changeset in webkit [68266] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46380
REGRESSION: Crash when downloading a file
Downloading cannot be tested in DRT.
- Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Don't copy null strings.
- 10:03 AM Changeset in webkit [68265] by
-
- 2 edits5 deletes in trunk/LayoutTests
2010-09-24 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Remove a bad baseline and clean up a comment
https://bugs.webkit.org/show_bug.cgi?id=46446
- platform/chromium-linux/svg/filters/filterRes-expected.checksum: Removed.
- platform/chromium-linux/svg/filters/filterRes-expected.png: Removed.
- platform/chromium-win/svg/filters/filterRes-expected.checksum: Removed.
- platform/chromium-win/svg/filters/filterRes-expected.png: Removed.
- platform/chromium-win/svg/filters/filterRes-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 10:03 AM Changeset in webkit [68264] by
-
- 4 edits2 copies in trunk/WebKit2
Add PluginProcess class
https://bugs.webkit.org/show_bug.cgi?id=46476
Reviewed by Sam Weinig.
- PluginProcess/PluginProcess.cpp: Added.
- PluginProcess/PluginProcess.h: Added.
Add stubbed out PluginProcess class.
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
Initialize the plug-in process.
- WebKit2.xcodeproj/project.pbxproj:
Add files.
- WebProcess/Plugins/PluginProcessConnection.h:
Add a comment about which connection this is.
- 9:51 AM Changeset in webkit [68263] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 Nate Chapin <Nate Chapin>
Unreviewed, chromium expectations update.
http/tests/navigation/ping-* are passing now
that they have had their LayoutTestController patch.
- platform/chromium/test_expectations.txt:
- 9:37 AM Changeset in webkit [68262] by
-
- 2 edits in trunk/WebKit2
Fix windows build.
- Shared/win/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
- 9:17 AM Changeset in webkit [68261] by
-
- 2 edits in trunk/WebCore
2010-09-24 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Clicking "Select All" in audits panel has no effect when the checkbox is unchecked
Only add category event listeners to real categories, not to "Select All"
https://bugs.webkit.org/show_bug.cgi?id=46467
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createCategoryElement):
- 9:10 AM Changeset in webkit [68260] by
-
- 5 edits3 adds in trunk/WebKit2
Add Windows implementation of PlatformCertificateInfo
Part of < rdar://problem/8350189>
https://bugs.webkit.org/show_bug.cgi?id=46450
Reviewed by Adam Roben.
- Shared/win/PlatformCertificateInfo.cpp: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::~PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::organizationNameForCertificate):
- Shared/win/PlatformCertificateInfo.h:
(WebKit::PlatformCertificateInfo::certificateContext):
- UIProcess/API/C/win/WKCertificateInfoWin.cpp: Added.
(WKCertificateInfoGetCertificateContext):
- UIProcess/API/C/win/WKCertificateInfoWin.h: Added.
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
- 9:10 AM Changeset in webkit [68259] by
-
- 2 edits in trunk/WebKitTools
2010-09-24 Chang Shu <chang.shu@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Fix the code to check file existence.
https://bugs.webkit.org/show_bug.cgi?id=46465
- QtTestBrowser/main.cpp: (main):
- 9:01 AM Changeset in webkit [68258] by
-
- 6 edits in trunk/WebKit2
Add WebKit2 C API for setting the font families.
https://bugs.webkit.org/show_bug.cgi?id=46408
Reviewed by Sam Weinig.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetStandardFontFamily):
(WebPreferencesCopyStandardFontFamily):
(WKPreferencesSetFixedFontFamily):
(WKPreferencesCopyFixedFontFamily):
(WKPreferencesSetSerifFontFamily):
(WKPreferencesCopySerifFontFamily):
(WKPreferencesSetSansSerifFontFamily):
(WKPreferencesCopySansSerifFontFamily):
(WKPreferencesSetCursiveFontFamily):
(WKPreferencesCopyCursiveFontFamily):
(WKPreferencesSetFantasyFontFamily):
(WKPreferencesCopyFantasyFontFamily):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setStandardFontFamily):
(WebKit::WebPreferences::standardFontFamily):
(WebKit::WebPreferences::setFixedFontFamily):
(WebKit::WebPreferences::fixedFontFamily):
(WebKit::WebPreferences::setSerifFontFamily):
(WebKit::WebPreferences::serifFontFamily):
(WebKit::WebPreferences::setSansSerifFontFamily):
(WebKit::WebPreferences::sansSerifFontFamily):
(WebKit::WebPreferences::setCursiveFontFamily):
(WebKit::WebPreferences::cursiveFontFamily):
(WebKit::WebPreferences::setFantasyFontFamily):
(WebKit::WebPreferences::fantasyFontFamily):
- UIProcess/WebPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::preferencesDidChange):
- 8:58 AM Changeset in webkit [68257] by
-
- 3 edits in trunk/WebCore
2010-09-24 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Remove unnecessary casts in DeviceOrientation V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=46466
Remove unnecessary casts of v8::Value::NumberValue() to double from
the custom v8 bindings code for DeviceOrientation/Motion.
No new tests: just cleanup, no new functionality.
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):
- bindings/v8/custom/V8DeviceOrientationEventCustom.cpp: (WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):
- 8:45 AM Changeset in webkit [68256] by
-
- 6 edits in trunk/WebCore
2010-09-24 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move searchingForNode flag in InspectorController under control of InspectorCookies.
Four functions from Inspector IDL go away.
Searching for node feature of Inspector keeps alive even after navigation.
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::updateInspectorStateCookie): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::setSearchingForNode): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.updateFocusedNode): (WebInspector.ElementsPanel.prototype._setSearchingForNode): (WebInspector.ElementsPanel.prototype.setSearchingForNode): (WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
- inspector/front-end/inspector.js: (WebInspector._updateFocusedNode):
- 8:42 AM Changeset in webkit [68255] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 Satish Sampath <satish@chromium.org>
Unreviewed, updating the baseline for a speech input layout test.
- fast/speech/input-text-speechbutton-expected.txt:
- 8:23 AM Changeset in webkit [68254] by
-
- 2 edits in trunk/WebCore
2010-09-24 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBTransactionCoordinator incorrectly assumes that aborted transactions must have been started or running.
https://bugs.webkit.org/show_bug.cgi?id=46459
No new tests, storage/indexeddb/transaction-basics.html covers this.
Also fixes http://code.google.com/p/chromium/issues/detail?id=56732
- storage/IDBTransactionCoordinator.cpp: (WebCore::IDBTransactionCoordinator::didFinishTransaction):
- 8:08 AM Changeset in webkit [68253] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 Satish Sampath <satish@chromium.org>
Reviewed by NOBODY (OOPS!).
Remove chromium test expectation entries for 3 tests which pass now.
https://bugs.webkit.org/show_bug.cgi?id=46457
These tests were marked as fail when the related images were being updated so removing the
entries now that the new images have landed.
- platform/chromium/test_expectations.txt:
- 7:38 AM Changeset in webkit [68252] by
-
- 13 edits in trunk
2010-09-24 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344
- fast/dom/DeviceMotion/script-tests/create-event.js:
- fast/dom/DeviceMotion/create-event-expected.txt: Look for the new attributes.
- fast/dom/DeviceMotion/script-tests/optional-event-properties.js:
- fast/dom/DeviceMotion/optional-event-properties-expected.txt: Test the new attributes.
- fast/dom/script-tests/prototype-inheritance.js: DeviceMotionEvent is not implemented on all platforms, so it should be skipped in this test. This is necessary for platforms that enable the feature to pass the layout tests.
2010-09-24 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344
The spec has changed: the DeviceMotionEvent attributes accelerationX,
accelerationY, etc. have been baked into an 'acceleration' attribute
which returns an object with x, y, and z values. Likewise for the
rotation rate. The 'accelerationIncludingGravity' attribute is new.
- WebCore.exp.in: The DeviceMotionData::create member function has changed. Also export create functions for DeviceMotionData::Acceleration and RotationRate.
- bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::acceleration): (WebCore::JSDeviceMotionEvent::accelerationIncludingGravity): (WebCore::JSDeviceMotionEvent::rotationRate): (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent): Manually create and return objects with the right attributes for acceleration, accelerationIncludingGravity, and rotationRate. When creating the DeviceMotionData object in initDeviceMotionEvent, accept any input objects that have the right attributes.
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::accelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter): (WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback): V8 counterpart to the JSC code above.
- dom/DeviceMotionData.cpp: (WebCore::DeviceMotionData::Acceleration::create): (WebCore::DeviceMotionData::Acceleration::Acceleration): (WebCore::DeviceMotionData::RotationRate::create): (WebCore::DeviceMotionData::RotationRate::RotationRate): (WebCore::DeviceMotionData::create): (WebCore::DeviceMotionData::DeviceMotionData):
- dom/DeviceMotionData.h: (WebCore::DeviceMotionData::Acceleration::canProvideX): (WebCore::DeviceMotionData::Acceleration::canProvideY): (WebCore::DeviceMotionData::Acceleration::canProvideZ): (WebCore::DeviceMotionData::Acceleration::x): (WebCore::DeviceMotionData::Acceleration::y): (WebCore::DeviceMotionData::Acceleration::z): (WebCore::DeviceMotionData::RotationRate::canProvideAlpha): (WebCore::DeviceMotionData::RotationRate::canProvideBeta): (WebCore::DeviceMotionData::RotationRate::canProvideGamma): (WebCore::DeviceMotionData::RotationRate::alpha): (WebCore::DeviceMotionData::RotationRate::beta): (WebCore::DeviceMotionData::RotationRate::gamma): (WebCore::DeviceMotionData::acceleration): (WebCore::DeviceMotionData::accelerationIncludingGravity): (WebCore::DeviceMotionData::rotationRate): Add member classes Acceleration and RotationRate to DeviceMotionData.
- dom/DeviceMotionEvent.idl: Update according to the spec. Acceleration and RotationRate need not be backed by native classes.
- 7:26 AM Changeset in webkit [68251] by
-
- 4 edits in trunk
[Qt] Fix the Wince build.
Patch by Romain Pokrzywka <romain@kdab.com> on 2010-09-24
Reviewed by Simon Hausmann.
.:
- WebKit.pri: Apply msvc flags to wince, too.
WebCore:
- WebCore.pro: Apply msvc flags to wince, too.
- 7:24 AM Changeset in webkit [68250] by
-
- 2 edits in trunk/WebCore
[Qt] Enable building Qt/Webkit with debug symbols
Patch by Anders Bakken <agbakken@gmail.com> on 2010-09-24
Reviewed by Simon Hausmann.
With this patch one can configure with -webkit-debug to build Webkit
with debug symbols without having to manually edit WebCore.pro.
- WebCore.pro:
- 6:46 AM Changeset in webkit [68249] by
-
- 2 edits in trunk/BugsSite
Support Unicode-strings in committers-autocomplete script
Reviewed by Csaba Osztrogonác.
- committers-autocomplete.js:
- 5:44 AM Changeset in webkit [68248] by
-
- 2 edits in trunk/WebCore
2010-09-24 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Web Sockets are insecure with QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=44769
Throw an error when the server certificate is not valid.
DRT currently does not support secure websocket connection,
so no new tests. This was tested with the server at
http://code.google.com/p/pywebsocket instead.
- platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::socketSslErrors):
- 5:08 AM Changeset in webkit [68247] by
-
- 2 edits in trunk/WebKit/mac
2010-09-24 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: CRASH at node highlight on MAC Safari.
1) run-safari --debug
2) open inspector
3) open elements panel
4) hover mouse over elements panel items multiple times
5) CRASH
Looks like it is a race condition. WebNodeHighlightView doesn't check
the pointer to WebNodeHighligh object and it can be nil.
- WebInspector/WebNodeHighlightView.mm: (-[WebNodeHighlightView drawRect:]):
- 4:31 AM Changeset in webkit [68246] by
-
- 20 edits in trunk/LayoutTests
2010-09-24 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Update speech button image baselines for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=46457
- platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum:
- platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum:
- platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium/test_expectations.txt: Disables above tests, they will get enabled again after the chromium patch is submitted.
- 3:16 AM Changeset in webkit [68245] by
-
- 1 edit14 adds in trunk/LayoutTests
2010-09-24 Andrey Kosyakov <caseq@chromium.org>
Unreviewed test expectations update after new tests in 68233.
- platform/chromium-linux/animations/suspend-transform-animation-expected.png: Added.
- platform/chromium-linux/transitions/suspend-transform-transition-expected.png: Added.
- platform/chromium-mac/animations/suspend-transform-animation-expected.checksum: Added.
- platform/chromium-mac/animations/suspend-transform-animation-expected.png: Added.
- platform/chromium-mac/transitions/suspend-transform-transition-expected.checksum: Added.
- platform/chromium-mac/transitions/suspend-transform-transition-expected.png: Added.
- platform/chromium-win-xp/animations/suspend-transform-animation-expected.png: Added.
- platform/chromium-win-xp/transitions/suspend-transform-transition-expected.png: Added.
- platform/chromium-win/animations/suspend-transform-animation-expected.checksum: Added.
- platform/chromium-win/animations/suspend-transform-animation-expected.png: Added.
- platform/chromium-win/transitions/suspend-transform-transition-expected.checksum: Added.
- platform/chromium-win/transitions/suspend-transform-transition-expected.png: Added.
- 2:13 AM Changeset in webkit [68244] by
-
- 2 edits in trunk/LayoutTests
2010-09-24 James Kozianski <koz@chromium.org>
Reviewed by Ojan Vafai.
[chromium] Updated test expectations to match the bots using new auto-update script.
https://bugs.webkit.org/show_bug.cgi?id=46452
Updated expectations to match the bots using the new auto-update script.
- platform/chromium/test_expectations.txt:
- 1:44 AM Changeset in webkit [68243] by
-
- 4 edits in trunk/WebCore
2010-09-24 Jia Pu <jpu@apple.com>
Reviewed by Shinichiro Hamaji.
Need to remove autocorrection underlines in current line when newline is entered.
https://bugs.webkit.org/show_bug.cgi?id=45709
<rdar://problem/8335576>
This change affects only Mac OSX build.
- dom/DocumentMarker.h: Added "CorrectionIndicator" to indicate the words on which we need to draw autocorrection underline. We cannot use existing "Replacement" for this purpose, since it is not meant to be removed once it is added. But we need to remove all autocorrection underlines when a line break or paragraph separator is inserted, which is the behavior in NSTextView. Hence we need a separate marker value for drawing autocorrection underline.
- editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Add "CorrectionIndicator" when autocorrection takes place. (WebCore::Editor::changeSelectionAfterCommand): Remove "CorrectionIndicator" markers if the command results in inserting paragraph separator.
- rendering/InlineTextBox.cpp: (WebCore::textCheckingLineStyleForMarkerType): Use "CorrectionIndicator" marker instead of "Replacement" to draw autocorrection underline. (WebCore::InlineTextBox::paintDocumentMarkers): Ditto.
- 1:15 AM Changeset in webkit [68242] by
-
- 8 edits in trunk
2010-09-24 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Remove unnecessary parameter from AsyncFileWriterClient::didTruncate
https://bugs.webkit.org/show_bug.cgi?id=46390
- fileapi/AsyncFileWriterClient.h:
Added state to FileWriter to replace the parameter.
- fileapi/FileWriter.h:
- fileapi/FileWriter.cpp: (WebCore::FileWriter::truncate): (WebCore::FileWriter::didTruncate):
2010-09-24 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Remove unnecessary parameter from AsyncFileWriterClient::didTruncate
https://bugs.webkit.org/show_bug.cgi?id=46390
- public/WebFileWriterClient.h:
- src/AsyncFileWriterChromium.cpp:
- src/AsyncFileWriterChromium.h:
- 1:02 AM Changeset in webkit [68241] by
-
- 13 edits in trunk
2010-09-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r68236.
http://trac.webkit.org/changeset/68236
https://bugs.webkit.org/show_bug.cgi?id=46449
compile fix didn't work (Requested by dino_ on #webkit).
- fast/dom/DeviceMotion/create-event-expected.txt:
- fast/dom/DeviceMotion/optional-event-properties-expected.txt:
- fast/dom/DeviceMotion/script-tests/create-event.js:
- fast/dom/DeviceMotion/script-tests/optional-event-properties.js:
- fast/dom/script-tests/prototype-inheritance.js:
2010-09-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r68236.
http://trac.webkit.org/changeset/68236
https://bugs.webkit.org/show_bug.cgi?id=46449
compile fix didn't work (Requested by dino_ on #webkit).
- WebCore.exp.in:
- bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::xAcceleration): (WebCore::JSDeviceMotionEvent::yAcceleration): (WebCore::JSDeviceMotionEvent::zAcceleration): (WebCore::JSDeviceMotionEvent::xRotationRate): (WebCore::JSDeviceMotionEvent::yRotationRate): (WebCore::JSDeviceMotionEvent::zRotationRate): (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::xAccelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::yAccelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::zAccelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::xRotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::yRotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::zRotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):
- dom/DeviceMotionData.cpp: (WebCore::DeviceMotionData::create): (WebCore::DeviceMotionData::DeviceMotionData):
- dom/DeviceMotionData.h: (WebCore::DeviceMotionData::xAcceleration): (WebCore::DeviceMotionData::yAcceleration): (WebCore::DeviceMotionData::zAcceleration): (WebCore::DeviceMotionData::xRotationRate): (WebCore::DeviceMotionData::yRotationRate): (WebCore::DeviceMotionData::zRotationRate): (WebCore::DeviceMotionData::canProvideXAcceleration): (WebCore::DeviceMotionData::canProvideYAcceleration): (WebCore::DeviceMotionData::canProvideZAcceleration): (WebCore::DeviceMotionData::canProvideXRotationRate): (WebCore::DeviceMotionData::canProvideYRotationRate): (WebCore::DeviceMotionData::canProvideZRotationRate):
- dom/DeviceMotionEvent.idl:
- 12:51 AM Changeset in webkit [68240] by
-
- 35 edits1 copy in trunk
2010-09-24 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send webkit accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
- platform/chromium/accessibility/post-notification-ActiveDescendantChanged-expected.txt:
- platform/chromium/accessibility/post-notification-CheckedStateChanged-expected.txt:
- platform/chromium/accessibility/post-notification-ChildrenChanged-expected.txt:
- platform/chromium/accessibility/post-notification-FocusedUIElementChanged-expected.txt:
- platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html:
- platform/chromium/accessibility/post-notification-LayoutComplete-expected.txt:
- platform/chromium/accessibility/post-notification-LayoutComplete.html:
- platform/chromium/accessibility/post-notification-LiveRegionChanged-expected.txt:
- platform/chromium/accessibility/post-notification-LoadComplete-expected.txt:
- platform/chromium/accessibility/post-notification-LoadComplete.html:
- platform/chromium/accessibility/post-notification-MenuListValueChanged-expected.txt:
- platform/chromium/accessibility/post-notification-RowCollapsed-expected.txt:
- platform/chromium/accessibility/post-notification-RowCountChanged-expected.txt:
- platform/chromium/accessibility/post-notification-RowExpanded-expected.txt:
- platform/chromium/accessibility/post-notification-ScrolledToAnchor-expected.txt:
- platform/chromium/accessibility/post-notification-ScrolledToAnchor.html:
- platform/chromium/accessibility/post-notification-SelectedChildrenChanged-expected.txt:
- platform/chromium/accessibility/post-notification-SelectedTextChanged-expected.txt:
- platform/chromium/accessibility/post-notification-SelectedTextChanged.html:
- platform/chromium/accessibility/post-notification-ValueChanged-expected.txt:
- platform/chromium/accessibility/post-notification.js: (test):
2010-09-24 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send webkit accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
- WebCore.gypi:
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::handleScrolledToAnchor):
- dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::setFocusedNode):
- editing/SelectionController.h:
- page/ChromeClient.h: (WebCore::ChromeClient::postAccessibilityNotification):
- page/FrameView.cpp: (WebCore::FrameView::layout):
2010-09-24 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send webkit accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
- public/WebAccessibilityCache.h:
- public/WebViewClient.h:
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focusedNodeChanged): (WebKit::ChromeClientImpl::getPopupMenuInfo):
- src/ChromeClientImpl.h:
- src/WebAccessibilityCache.cpp: (WebKit::WebAccessibilityCache::accessibilityEnabled):
- 12:26 AM Changeset in webkit [68239] by
-
- 24 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46454, rename a bunch of the width and height calculation methods.
Reviewed by Maciej Stachowiak.
calcReplacedWidth -> computeReplacedWidth
calcHorizontalMargins -> computeInlineDirectionMargins
calcVerticalMargins -> computeBlockDirectionMargins
calcWidthUsing -> computeLogicalWidthUsing
calcHeightUsing -> computeLogicalHeightUsing
calcReplacedHeight/HeightUsing -> computeReplacedHeight/HeightUsing
calcAbsoluteHorizontalValues -> computePositionedLogicalWidthUsing
calcAbsoluteVerticalValues -> computePositionedLogicalHeightUsing
calcAbsoluteHorizontal -> computePositionedLogicalWIdth
calcAbsoluteVertical -> computePositionedLogicalHeight
calcAbsoluteHorizontalReplaced -> computePositionedLogicalWidthReplaced
calcAbsoluteVerticalReplaced -> computePositionedLogicalHeightReplaced
calcBorderBoxWidth/Height -> computeBorderBoxLogicalWidth/LogicalHeight
calcContentBoxWidth/Height -> computeContentBoxLogicalWidth/LogicalHeight
shouldCalculateSizeAsReplaced -> shouldComputeSizeAsReplaced
calcPercentageHeight -> computePercentageLogicalHeight
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::calcPrefWidths):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeBorderBoxLogicalWidth):
(WebCore::RenderBox::computeBorderBoxLogicalHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedWidth):
(WebCore::RenderBox::computeReplacedWidthUsing):
(WebCore::RenderBox::computeReplacedHeight):
(WebCore::RenderBox::computeReplacedHeightUsing):
(WebCore::RenderBox::availableHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
- rendering/RenderBox.h:
(WebCore::RenderBox::shouldComputeSizeAsReplaced):
- rendering/RenderDataGrid.cpp:
(WebCore::RenderDataGrid::calcPrefWidths):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::calcPrefWidths):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::calcPrefWidths):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::computeReplacedWidth):
(WebCore::RenderImage::computeReplacedHeight):
(WebCore::RenderImage::calcAspectRatioWidth):
(WebCore::RenderImage::calcAspectRatioHeight):
- rendering/RenderImage.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::calcPrefWidths):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::calcPrefWidths):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::container):
- rendering/RenderObject.h:
(WebCore::RenderObject::computeBlockDirectionMargins):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedWidth):
(WebCore::RenderReplaced::computeReplacedHeight):
(WebCore::RenderReplaced::calcAspectRatioWidth):
(WebCore::RenderReplaced::calcAspectRatioHeight):
(WebCore::RenderReplaced::calcPrefWidths):
- rendering/RenderReplaced.h:
- rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::calcPrefWidths):
(WebCore::RenderSVGRoot::computeReplacedWidth):
(WebCore::RenderSVGRoot::computeReplacedHeight):
- rendering/RenderSVGRoot.h:
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::calcPrefWidths):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::calcPrefWidths):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::computeReplacedWidth):
(WebCore::RenderVideo::computeReplacedHeight):
- rendering/RenderVideo.h:
