Timeline
Oct 19, 2010:
- 11:45 PM Changeset in webkit [70130] by
-
- 2 edits in trunk/WebKitLibraries
Windows build fix
- win/include/WebKitSystemInterface/WebKitSystemInterface.h: Check in
this file that I meant to check in in r70129.
- 11:36 PM Changeset in webkit [70129] by
-
- 10 edits in trunk
Remove uses of CACFContextRef and CARender* from WebCore
These types are now wrapped in a WKCACFContext type exported by
WebKitSystemInterface.
Fixes <http://webkit.org/b/43244>.
Reviewed by Sam Weinig.
WebCore:
- platform/graphics/win/WKCACFContextFlusher.cpp:
(WebCore::WKCACFContextFlusher::addContext):
(WebCore::WKCACFContextFlusher::removeContext):
(WebCore::WKCACFContextFlusher::flushAllContexts):
- platform/graphics/win/WKCACFContextFlusher.h:
Changed to use WKCACFContext. We don't retain/release the context when
putting it into/taking it out of the set. WKCACFContext is not a
ref-counted type, so we can't retain/release it, but the
retain/release was also unnecessary as WKCACFLayerRenderer calls
removeContext before the context is destroyed.
- platform/graphics/win/WKCACFLayer.cpp:
(WebCore::WKCACFLayer::becomeRootLayerForContext):
- platform/graphics/win/WKCACFLayer.h:
Changed to use WKCACFContext.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::didFlushContext):
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::layerTreeDidChange):
(WebCore::WKCACFLayerRenderer::createRenderer):
(WebCore::WKCACFLayerRenderer::destroyRenderer):
(WebCore::WKCACFLayerRenderer::render): Also replaced uses of
CGSRegion with WebKitSystemInterface functions/types.
(WebCore::WKCACFLayerRenderer::resetDevice):
- platform/graphics/win/WKCACFLayerRenderer.h:
Replaced our CACFContextRef, CARenderContext, and CARenderOGLContext
with a single WKCACFContext, which wraps all three. We hold a bare
pointer to it and destroy it in our destructor.
WebKitLibraries:
Add WKCACFContext and related functions
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 11:33 PM Changeset in webkit [70128] by
-
- 2 edits in trunk/WebKitTools
Teach update-webkit-support-libs about the new versioning of WebKitSupportLibrary
Fixes <http://webkit.org/b/47915> update-webkit-support-libs should
check version numbers instead of modification times
Reviewed by Sam Weinig.
- Scripts/update-webkit-support-libs: Fetch the expected version
number from developer.apple.com, then compare with the version number
of the extracted library and of the zipped library to see if anything
needs to be done. Removed code that tracked the modified timestamp of
the library, as it is no longer needed.
- 9:59 PM Changeset in webkit [70127] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-10-19 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test rebaseline.
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.checksum: Added.
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png: Added.
- 9:43 PM Changeset in webkit [70126] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-19 Kwang Yul Seo <skyul@company100.net>
Reviewed by David Kilzer.
[BREWMP] Turn off JIT for simulator build
https://bugs.webkit.org/show_bug.cgi?id=47937
We don't need to test x86 JIT.
- wtf/Platform.h:
- 8:34 PM Changeset in webkit [70125] by
-
- 2 edits in trunk/LayoutTests
2010-10-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70124.
http://trac.webkit.org/changeset/70124
https://bugs.webkit.org/show_bug.cgi?id=47965
test expectation conflict (Requested by yuzo on #webkit).
- platform/chromium/test_expectations.txt:
- 8:24 PM Changeset in webkit [70124] by
-
- 2 edits in trunk/LayoutTests
2010-10-19 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
The following tests are failing for WIN and LINUX.
editing/spelling/spelling-contenteditable.html
editing/spelling/spelling-textarea.html
- platform/chromium/test_expectations.txt:
- 8:19 PM Changeset in webkit [70123] by
-
- 2 edits in trunk/LayoutTests
2010-10-19 James Robinson <jamesr@chromium.org>
Update chromium expectations.
- platform/chromium/test_expectations.txt:
- 8:07 PM Changeset in webkit [70122] by
-
- 2 edits7 adds in trunk/LayoutTests
2010-10-19 James Robinson <jamesr@chromium.org>
Update chromium expectations and add baselines for new test.
- platform/chromium-linux/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
- platform/chromium-linux/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
- platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
- platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
- platform/chromium-win/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
- platform/chromium-win/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
- platform/chromium-win/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 7:53 PM Changeset in webkit [70121] by
-
- 2 edits in trunk/WebKitSite
2010-10-19 Jenn Braithwaite <jennb@chromium.org>
Reviewed by David Levin.
Add DirectX SDK to Installing Developer Tools web page
https://bugs.webkit.org/show_bug.cgi?id=47911
- building/tools.html:
- 7:18 PM Changeset in webkit [70120] by
-
- 2 edits in trunk
2010-10-19 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed, adding missed additionalArguments.
[CMAKE] additional arguments was missed in GENERATE_DOM_NAMES
https://bugs.webkit.org/show_bug.cgi?id=47694
Pass additionalArguments for make_names.pl to choose enabled features.
- cmake/WebKitMacros.cmake:
- 6:55 PM Changeset in webkit [70119] by
-
- 2 edits169 adds in trunk/LayoutTests
2010-10-19 Kenneth Russell <kbr@google.com>
Unreviewed, test expectations update.
Added initial test expectations for the chromium-gpu configuration,
generated on Windows. Pixel results have been added under chromium-gpu-win.
The hope is that at least the text results might be shareable between the
Windows and Linux platforms; for the time being, they are being placed
under chromium-gpu, though they may be moved in the near future.
platform/chromium-gpu/test_expectations.txt still has all of the tests
marked "PASS FAIL". Only once we have a certain set of the tests passing on
all three platforms (Windows, Mac, Linux) will we remove the FAIL from that
line. The current effort has focused on the "compositing" directory.
- platform/chromium-gpu-win/compositing: Added.
- platform/chromium-gpu-win/compositing/animation: Added.
- platform/chromium-gpu-win/compositing/animation/state-at-end-event-transform-layer-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
- platform/chromium-gpu-win/compositing/compositing-visible-descendant-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/compositing-visible-descendant-expected.png: Added.
- platform/chromium-gpu-win/compositing/direct-image-compositing-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png: Added.
- platform/chromium-gpu-win/compositing/generated-content-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/generated-content-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry: Added.
- platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/outline-change-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/outline-change-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/partial-layout-update-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/partial-layout-update-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/root-layer-update-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/root-layer-update-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/iframes: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png: Added.
- platform/chromium-gpu-win/compositing/iframes/iframe-content-flipping-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/iframes/iframe-content-flipping-expected.png: Added.
- platform/chromium-gpu-win/compositing/iframes/iframe-copy-on-scroll-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
- platform/chromium-gpu-win/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
- platform/chromium-gpu-win/compositing/images: Added.
- platform/chromium-gpu-win/compositing/images/direct-image-background-color-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/images/direct-image-background-color-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow: Added.
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/overflow-positioning-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/overflow-positioning-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/overflow-scroll-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/overflow-scroll-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/parent-overflow-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/parent-overflow-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/zero-size-overflow-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/zero-size-overflow-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections: Added.
- platform/chromium-gpu-win/compositing/reflections/backface-hidden-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/backface-hidden-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint: Added.
- platform/chromium-gpu-win/compositing/repaint/become-overlay-composited-layer-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/layer-repaint-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/layer-repaint-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/layer-repaint-rects-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/layer-repaint-rects-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute2-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute2-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.png: Added.
- platform/chromium-gpu-win/compositing/sibling-positioning-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/sibling-positioning-expected.png: Added.
- platform/chromium-gpu-win/compositing/transitions: Added.
- platform/chromium-gpu-win/compositing/transitions/singular-scale-transition-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/transitions/singular-scale-transition-expected.png: Added.
- platform/chromium-gpu/compositing/animation: Added.
- platform/chromium-gpu/compositing/animation/animated-composited-inside-hidden-expected.txt: Added.
- platform/chromium-gpu/compositing/animation/animation-compositing-expected.txt: Added.
- platform/chromium-gpu/compositing/animation/computed-style-during-delay-expected.txt: Added.
- platform/chromium-gpu/compositing/animation/state-at-end-event-transform-layer-expected.txt: Added.
- platform/chromium-gpu/compositing/composited-negative-zindex-child-expected.txt: Added.
- platform/chromium-gpu/compositing/compositing-visible-descendant-expected.txt: Added.
- platform/chromium-gpu/compositing/direct-image-compositing-expected.txt: Added.
- platform/chromium-gpu/compositing/generated-content-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry: Added.
- platform/chromium-gpu/compositing/geometry/clip-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/clipping-foreground-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/empty-embed-rects-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/fixed-in-composited-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/fixed-position-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/huge-layer-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/outline-change-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/partial-layout-update-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/preserve-3d-switching-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/root-layer-update-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes: Added.
- platform/chromium-gpu/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/composited-parent-iframe-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-content-flipping-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-resize-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-size-to-zero-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-src-change-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/layout-on-compositing-change-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/overlapped-iframe-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/remove-iframe-crash-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/scrolling-iframe-expected.txt: Added.
- platform/chromium-gpu/compositing/images: Added.
- platform/chromium-gpu/compositing/images/clip-on-directly-composited-image-expected.txt: Added.
- platform/chromium-gpu/compositing/images/content-image-expected.txt: Added.
- platform/chromium-gpu/compositing/images/direct-image-background-color-expected.txt: Added.
- platform/chromium-gpu/compositing/layer-creation: Added.
- platform/chromium-gpu/compositing/layer-creation/scroll-partial-update-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow: Added.
- platform/chromium-gpu/compositing/overflow/clip-descendents-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/get-transform-from-non-box-container-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/overflow-positioning-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/overflow-scroll-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/parent-overflow-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/resize-painting-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/scrollbar-painting-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/zero-size-overflow-expected.txt: Added.
- platform/chromium-gpu/compositing/plugins: Added.
- platform/chromium-gpu/compositing/plugins/1x1-composited-plugin-expected.txt: Added.
- platform/chromium-gpu/compositing/plugins/large-to-small-composited-plugin-expected.txt: Added.
- platform/chromium-gpu/compositing/plugins/small-to-large-composited-plugin-expected.txt: Added.
- platform/chromium-gpu/compositing/reflections: Added.
- platform/chromium-gpu/compositing/reflections/backface-hidden-reflection-expected.txt: Added.
- platform/chromium-gpu/compositing/reflections/reflection-in-composited-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint: Added.
- platform/chromium-gpu/compositing/repaint/become-overlay-composited-layer-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/content-into-overflow-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/inline-repaint-container-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/layer-repaint-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/layer-repaint-rects-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/opacity-between-absolute-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/opacity-between-absolute2-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/overflow-into-content-expected.txt: Added.
- platform/chromium-gpu/compositing/sibling-positioning-expected.txt: Added.
- platform/chromium-gpu/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
- platform/chromium-gpu/compositing/tiling/huge-layer-resize-expected.txt: Added.
- platform/chromium-gpu/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
- platform/chromium-gpu/compositing/transitions: Added.
- platform/chromium-gpu/compositing/transitions/opacity-on-inline-expected.txt: Added.
- platform/chromium-gpu/compositing/transitions/singular-scale-transition-expected.txt: Added.
- platform/chromium-gpu/test_expectations.txt:
- 6:44 PM Changeset in webkit [70118] by
-
- 3 edits5 adds in trunk
2010-10-19 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Dan Bernstein.
Pixel cracks when using background image sprite on transformed element at certain scales.
https://bugs.webkit.org/show_bug.cgi?id=47868
- fast/images/pixel-crack-image-background-webkit-transform-scale.html: Added.
- fast/images/resources/pixel-crack-image-background-webkit-transform-scale.png: Added.
- platform/mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
- platform/mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
- platform/mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.txt: Added.
2010-10-19 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Dan Bernstein.
Pixel cracks when using background image sprite on transformed element at certain scales.
https://bugs.webkit.org/show_bug.cgi?id=47868
The pixel bleeding happens when the current context has scale and interpolation is kCGInterpolationHigh
or kCGInterpolationDefault. If the source rect size is smaller than the intrinsic image size, some
pixels outside of the clip rect will also be used to interpolate the color value for clip edges, which
results in unwanted thin lines around the painted area. We need to use sub-image patch to get rid of
the artifacts in this case.
Test: fast/images/pixel-crack-image-background-webkit-transform-scale.html
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
- 6:26 PM Changeset in webkit [70117] by
-
- 7 edits1 add in trunk/WebKitTools
2010-10-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach feeder-queue how to feed the EWS bots
https://bugs.webkit.org/show_bug.cgi?id=47943
queues.webkit.org already knew how to accept EWS submissions
via /submit-to-ews. This teaches the feeder queue how to post
to that page with any new r? patches it sees.
- QueueStatusServer/model/activeworkitems_unitest.py: Added.
- More unit testing is always a good thing.
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/statusserver.py:
- Scripts/webkitpy/tool/bot/feeders.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 6:25 PM Changeset in webkit [70116] by
-
- 2 edits in trunk/LayoutTests
2010-10-19 James Robinson <jamesr@chromium.org>
Remove test expectations entries for tests that consistently pass.
- platform/chromium/test_expectations.txt:
- 6:10 PM Changeset in webkit [70115] by
-
- 2 edits in trunk/LayoutTests
2010-10-19 Tony Chang <tony@chromium.org>
Unreviewed, plugins/plugin-javascript-access.html is
passing again on Chromium mac after a chromium side fix to TestShell.
- platform/chromium/test_expectations.txt:
- 6:08 PM Changeset in webkit [70114] by
-
- 3 edits in trunk/WebCore
2010-10-19 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
sqlite: remove unused member variable
https://bugs.webkit.org/show_bug.cgi?id=47957
There's no need to save the error code into a member variable
because nobody ever looks at it.
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open):
- platform/sql/SQLiteDatabase.h:
- 5:20 PM Changeset in webkit [70113] by
-
- 2 edits in trunk/WebCore
2010-10-19 Jia Pu <jpu@apple.com>
Reviewed by James Robinson.
Moving cursor back to autocorrected word in the same line shouldn't remove the underline
https://bugs.webkit.org/show_bug.cgi?id=47629
<rdar://problem/8546758>
Patch <http://trac.webkit.org/changeset/70071> breaks some Chromium Mac hehavior. This patch
fixes that.
- editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Add "!PLATFORM(MAC)" to make sure nothing changes on non-Mac platforms.
- 5:06 PM Changeset in webkit [70112] by
-
- 18 edits in branches/chromium/552
Merge 70102 - Rename createBlobURL to createObjectURL and revokeBlobURL to
revokeObjectURL per the latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=47934
Reviewed by Darin Fisher.
BUG=59875
TEST=none
- 4:55 PM Changeset in webkit [70111] by
-
- 24 edits in trunk/JavaScriptCore
2010-10-19 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Remove support for JSVALUE32 from JSC
https://bugs.webkit.org/show_bug.cgi?id=47948
Remove all the code for supporting JSVALUE32 from JSC.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_lshift): (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emit_op_urshift): (JSC::JIT::emitSlow_op_urshift): (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emitSlow_op_jlesseq): (JSC::JIT::emit_op_bitand): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
- jit/JITCall.cpp:
- jit/JITInlineMethods.h: (JSC::JIT::emitGetFromCallFrameHeaderPtr): (JSC::JIT::emitGetFromCallFrameHeader32):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_next_pname):
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val):
- jit/JITStubs.h:
- jit/JSInterfaceJIT.h:
- jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::tagReturnAsInt32):
- jit/ThunkGenerators.cpp: (JSC::sqrtThunkGenerator): (JSC::powThunkGenerator):
- runtime/Collector.cpp: (JSC::isPossibleCell): (JSC::typeName):
- runtime/JSCell.h:
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- runtime/JSGlobalObject.h: (JSC::Structure::prototypeForLookup):
- runtime/JSImmediate.h: (JSC::reinterpretIntptrToDouble): (JSC::JSImmediate::isIntegerNumber): (JSC::JSImmediate::isDouble): (JSC::JSImmediate::areBothImmediateIntegerNumbers): (JSC::JSImmediate::makeDouble): (JSC::JSImmediate::doubleValue): (JSC::JSImmediate::toBoolean): (JSC::JSImmediate::fromNumberOutsideIntegerRange): (JSC::JSImmediate::from): (JSC::JSImmediate::toDouble): (JSC::JSFastMath::rightShiftImmediateNumbers):
- runtime/JSNumberCell.cpp:
- runtime/JSNumberCell.h:
- runtime/JSObject.h: (JSC::JSObject::JSObject):
- runtime/JSValue.h:
- runtime/NumberObject.h:
- wtf/Platform.h:
- 4:41 PM Changeset in webkit [70110] by
-
- 2 edits in trunk/LayoutTests
2010-10-19 Tony Chang <tony@chromium.org>
Unreviewed, updating drt expectations for plugin tests on mac.
- platform/chromium/drt_expectations.txt:
- 4:40 PM Changeset in webkit [70109] by
-
- 3 edits in trunk/WebKit2
Fix MiniBrowser crashes during startup and shutdown
https://bugs.webkit.org/show_bug.cgi?id=47954
Reviewed by Sam Weinig.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::sharedProcessContext):
Initialize the main thread.
(WebKit::WebContext::create):
Ditto.
(WebKit::WebContext::WebContext):
Add the language observer here so we know that it will always be set up.
(WebKit::WebContext::ensureWebProcess):
Remove code.
- UIProcess/WebContext.h:
- 4:27 PM Changeset in webkit [70108] by
-
- 5 edits in trunk
Versioning.
- 4:25 PM Changeset in webkit [70107] by
-
- 4 edits in branches/chromium/552/WebCore
Merge 69804 - 2010-10-14 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Cache link status at linkProgram and use it in useProgram instead of querying GPU
https://bugs.webkit.org/show_bug.cgi?id=47685
- html/canvas/WebGLProgram.cpp: Always cache link status at linkStatus and use it upon query. (WebCore::WebGLProgram::WebGLProgram):
- html/canvas/WebGLProgram.h: Ditto. (WebCore::WebGLProgram::getLinkStatus): (WebCore::WebGLProgram::setLinkStatus):
- html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::useProgram):
TBR=zmo@google.com
- 4:23 PM Changeset in webkit [70106] by
-
- 1 copy in tags/Safari-534.10
New tag.
- 4:17 PM Changeset in webkit [70105] by
-
- 2 edits in trunk/LayoutTests
2010-10-19 James Robinson <jamesr@chromium.org>
Update chromium test expectations
- platform/chromium/test_expectations.txt:
- 4:15 PM Changeset in webkit [70104] by
-
- 2 edits in trunk/WebCore
Build fix (EFL, maybe more).
- CMakeLists.txt: Added platform/Language.cpp here, too.
- 4:02 PM Changeset in webkit [70103] by
-
- 3 edits in trunk/WebKitTools
2010-10-19 Eric Seidel <eric@webkit.org>
Unreviewed, just fixing test-webkitpy. I'm really on a roll today.
commit-queue gets stuck when release-patch returns 404
https://bugs.webkit.org/show_bug.cgi?id=47935
Fix test-webkitpy and unittest NetworkTransaction.
- Scripts/webkitpy/common/net/networktransaction.py:
- Scripts/webkitpy/common/net/networktransaction_unittest.py:
- 4:02 PM Changeset in webkit [70102] by
-
- 21 edits in trunk
Rename createBlobURL to createObjectURL and revokeBlobURL to
revokeObjectURL per the latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=47934
Reviewed by Darin Fisher.
WebCore:
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._contextMenu):
- inspector/front-end/utilities.js:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::createObjectURL):
(WebCore::DOMWindow::revokeObjectURL):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::createObjectURL):
(WebCore::WorkerContext::revokeObjectURL):
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
LayoutTests:
Update all the related test and result files to account for the
renaming changes.
- fast/dom/Window/script-tests/window-property-descriptors.js:
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-properties.html:
- fast/dom/script-tests/prototype-inheritance.js:
- fast/files/apply-blob-url-to-img.html:
- fast/files/apply-blob-url-to-xhr.html:
- fast/files/create-blob-url-crash-expected.txt:
- fast/files/create-blob-url-crash.html:
- fast/files/revoke-blob-url-expected.txt:
- fast/files/revoke-blob-url.html:
- fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
- 3:59 PM Changeset in webkit [70101] by
-
- 6 edits1 copy in branches/chromium/552
Merge 69747 - 2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
https://bugs.webkit.org/show_bug.cgi?id=47016
- compositing/tiling/huge-layer-img.html: Added.
- platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
- platform/mac-wk2/Skipped:
- platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.
2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
https://bugs.webkit.org/show_bug.cgi?id=47016
Test: compositing/tiling
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerContentRect):
- 3:55 PM Changeset in webkit [70100] by
-
- 8 edits1 delete in branches/chromium/552
Reverting 70099 as checkin messed up Changelog files..
Revert 70099 - Merge 69747 - 2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
https://bugs.webkit.org/show_bug.cgi?id=47016
- compositing/tiling/huge-layer-img.html: Added.
- platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
- platform/mac-wk2/Skipped:
- platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.
2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
https://bugs.webkit.org/show_bug.cgi?id=47016
Test: compositing/tiling
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerContentRect):
- 3:49 PM Changeset in webkit [70099] by
-
- 8 edits1 copy in branches/chromium/552
Merge 69747 - 2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
https://bugs.webkit.org/show_bug.cgi?id=47016
- compositing/tiling/huge-layer-img.html: Added.
- platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
- platform/mac-wk2/Skipped:
- platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.
2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
https://bugs.webkit.org/show_bug.cgi?id=47016
Test: compositing/tiling
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerContentRect):
- 3:48 PM Changeset in webkit [70098] by
-
- 6 edits in trunk/WebKit2
Coalesce plug-in drawing
https://bugs.webkit.org/show_bug.cgi?id=47939
Reviewed by Sam Weinig.
Coalesce plug-in drawing in the same manner as we do it in the chunked update drawing area.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_waitingForDidUpdate to false.
(WebKit::PluginControllerProxy::startPaintTimer):
Move code from invalidate out to here. Don't start the paint timer if m_waitingForDidUpdate is true.
(WebKit::PluginControllerProxy::invalidate):
Call startPaintTimer.
(WebKit::PluginControllerProxy::didUpdate):
Set m_waitingForDidUpdate to false and start the paint timer.
- PluginProcess/PluginControllerProxy.messages.in:
Add DidUpdate message.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::PluginProxy):
Initialize m_waitingForPaintInResponseToUpdate to false.
(WebKit::PluginProxy::paint):
If m_waitingForPaintInResponseToUpdate is true, send a DidUpdate message.
(WebKit::PluginProxy::update):
Set m_waitingForPaintInResponseToUpdate to true.
- 3:45 PM Changeset in webkit [70097] by
-
- 13 edits in trunk/WebKit2
Add alternateHTMLString and unreachableURL API to WebKit2
<rdar://problem/8557864>
https://bugs.webkit.org/show_bug.cgi?id=47938
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyUnreachableURL):
- UIProcess/API/C/WKFrame.h:
Add accessor for the unreachableURL if one is set. It will only be
set during a loadAlternateHTMLString and will be unset on the next normal
didStartProvisionalLoadForFrame call.
- UIProcess/API/C/WKPage.cpp:
(WKPageLoadHTMLString): Remove whitespace.
(WKPageLoadAlternateHTMLString):
- UIProcess/API/C/WKPage.h:
Add function to load a string as "alternate", meant for use as error pages.
- UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::setUnreachableURL):
(WebKit::WebFrameProxy::unreachableURL):
Add setter/getter for the unreachableURL.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadAlternateHTMLString):
Plumb through the call to loadAlternateHTMLString to the WebProcess
and set the main frame's unreachableURL. This does nothing if no pages
have ever been loaded in this page.
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
If this is not a provisional load of substitute data for an unreachableURL
(e.g. someone who called WKPageLoadAlternateHTMLString), reset the
frame's unreachableURL.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
Update function signatures.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
Pass whether or not this is a load of SubstituteData for an unreachableURL
to the UIProcess.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadData):
(WebKit::WebPage::loadAlternateHTMLString):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Plumb through the loading of the alternate HTML string.
- 3:29 PM Changeset in webkit [70096] by
-
- 2 edits in trunk/WebKitTools
2010-10-19 Eric Seidel <eric@webkit.org>
Unreviewed.
commit-queue gets stuck when release-patch returns 404
https://bugs.webkit.org/show_bug.cgi?id=47935
Turns out ClientForm gets upset if passed an int() instead of a string type.
Yay for untestable code.
- Scripts/webkitpy/common/net/statusserver.py:
- 3:28 PM Changeset in webkit [70095] by
-
- 25 edits5 moves1 add in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=47933
<rdar://problem/8494337> navigator.language doesn't work in WebKit2
- 3:16 PM Changeset in webkit [70094] by
-
- 4 edits in trunk/WebCore
2010-10-19 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Add "in select" insertion mode to parser.
This was added to the spec in:
http://html5.org/tools/web-apps-tracker?from=5520&to=5522
And as a result of:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=10314
No new tests. Open to ideas.
- html/parser/HTMLElementStack.cpp: Added "in select" mode. (WebCore::HTMLNames::isSelectScopeMarker): Ditto. (WebCore::HTMLElementStack::inSelectScope): Ditto.
- html/parser/HTMLElementStack.h: Ditto.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): Use "in select" instead of "in table." (WebCore::HTMLTreeBuilder::processEndTag): Ditto.
- 3:10 PM Changeset in webkit [70093] by
-
- 6 edits2 adds in trunk
2010-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Fix multiple index support in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=47919
Modify an existing test to verify behavior and add another test for
something I thought might have been related (but wasn't, but it still
seems like a good test).
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/queued-commands-expected.txt: Added.
- storage/indexeddb/queued-commands.html: Added.
2010-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Fix multiple index support in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=47919
Fix 2 bugs that caused the IndexData of all but the last index to be
properly updated:
- The objectStoreDataId is NOT unique if there are multiple indexes. So remove the constraint.
- Do not delete all existing entries with that objectStoreDataId before adding an entry for each index. Only do it once at the beginning.
Test: storage/indexeddb/queued-commands.html
+ index-basics.html modified
- storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::deleteIndexData): (WebCore::putIndexData): (WebCore::IDBObjectStoreBackendImpl::putInternal):
- 3:06 PM Changeset in webkit [70092] by
-
- 5 edits in trunk/WebKitTools
2010-10-19 Eric Seidel <eric@webkit.org>
Unreviewed. Will get Adam's commentary after his meeting
for now this gets the commit-cluster back running.
commit-queue gets stuck when release-patch returns 404
https://bugs.webkit.org/show_bug.cgi?id=47935
I taught NetworkTransaction the basics of 404 handling.
We'll want to go back and teach it how to handle urllib2 404's too
and then deploy it to the places that want it.
- QueueStatusServer/handlers/releasepatch.py:
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/networktransaction.py:
- Scripts/webkitpy/common/net/statusserver.py:
- 2:58 PM Changeset in webkit [70091] by
-
- 4 edits in trunk/WebKit/efl
2010-10-19 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Eric Seidel.
[EFL] Add setting api for disabling auto resize window
https://bugs.webkit.org/show_bug.cgi?id=47787
- WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::setWindowRect): Return when auto_resize_window was disabled.
- ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_enable_auto_resize_window_get): Added. (ewk_view_setting_enable_auto_resize_window_set): Added.
- ewk/ewk_view.h:
- 2:42 PM Changeset in webkit [70090] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-19 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Geoffrey Garen.
BytecodeGenerator::m_lastOpcodePosition must be initialized in all constructors
https://bugs.webkit.org/show_bug.cgi?id=47920
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Add missing member initialization.
- 2:38 PM Changeset in webkit [70089] by
-
- 2 edits in trunk/WebCore
2010-10-19 Martin Robinson <mrobinson@igalia.com>
Fix the GTK+ build after r70072. The logic looks incorrect, but
this fix tries to preserves it, even so.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (baselinePositionForAccessibilityRenderObject): (getAttributeSetForAccessibilityObject):
- 2:19 PM Changeset in webkit [70088] by
-
- 13 edits1 copy1 add in trunk/WebKitTools
2010-10-19 Eric Seidel <eric@webkit.org>
Unreviewed. Fixing typos in my previous commit.
Make patch release explicit and not a magic part of "retry" status
https://bugs.webkit.org/show_bug.cgi?id=47909
All of these typos again due to our inability to unit
test much of this code. I added one unit test where
possible. activeworkitems_unittest.py will be in a separate patch.
- QueueStatusServer/handlers/releasepatch.py:
- QueueStatusServer/main.py:
- QueueStatusServer/model/activeworkitems.py:
- QueueStatusServer/model/workitems.py:
- QueueStatusServer/model/workitems_unittest.py:
- QueueStatusServer/templates/releasepatch.html:
- Scripts/webkitpy/common/net/statusserver.py:
- 2:18 PM Changeset in webkit [70087] by
-
- 3 edits in trunk/LayoutTests
2010-10-19 James Robinson <jamesr@chromium.org>
Update chromium expectations.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 2:14 PM Changeset in webkit [70086] by
-
- 4 edits in trunk/LayoutTests
2010-10-19 Antonio Gomes <agomes@rim.com>
Unreviewed complementary fix to r70058 (Part III).
Skipping fast/dom/nodesFromRect-links-and-text.html instead of fast/dom/nodesFromRect-links-and-text-expected.html.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 2:11 PM Changeset in webkit [70085] by
-
- 3 edits in trunk/WebKit2
Stop waiting for sync replies if the connection is closed
https://bugs.webkit.org/show_bug.cgi?id=47930
Reviewed by Adam Roben.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::Connection):
Initialize m_shouldWaitForSyncReplies to true.
(CoreIPC::Connection::sendSyncMessage):
Don't attempt to send a message if m_shouldWaitForSyncReplies is false.
(CoreIPC::Connection::waitForSyncReply):
Return if m_shouldWaitForSyncReplies was set to false.
(CoreIPC::Connection::connectionDidClose):
Set m_shouldWaitForSyncReplies to true and signal the semaphore.
- Platform/CoreIPC/Connection.h:
- 2:11 PM Changeset in webkit [70084] by
-
- 5 edits in trunk
Windows: Implement 'preload=none'
https://bugs.webkit.org/show_bug.cgi?id=47317
<rdar://problem/7718442>
Reviewed by Eric Carlson.
WebCore:
Implement the 'preload=none' identically to the mac implementation. Add three new
ivars: m_preload, m_delayLoad and m_movieURL; and override the MediaPlayerPrivate
functions: prepareToPlay() and setPreload().
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
Initialize new ivars m_delayLoad and m_preload.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::resumeLoad): Added; new.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load): Split contents between
load and loadInternal.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::loadInternal): Added; new.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::prepareToPlay): Added; overrides MediaPlayerPrivate.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPreload): Added; overrides MediaPlayerPrivate.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
LayoutTests:
Do not skip the media/video-preload.html test on windows any longer.
- platform/win/Skipped:
- 2:03 PM Changeset in webkit [70083] by
-
- 2 edits in trunk/WebCore
Upstream support of KeyCodes for iOS
https://bugs.webkit.org/show_bug.cgi?id=47857
Reviewed by Alexey Proskuryakov.
- platform/cocoa/KeyEventCocoa.mm:
(WebCore::windowsKeyCodeForCharCode): Added special handling of keyCodes for iOS.
- 1:59 PM Changeset in webkit [70082] by
-
- 2 edits in trunk/LayoutTests
2010-10-19 Zhenyao Mo <zmo@google.com>
Unreviewed, remove a passing webgl test from test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 1:54 PM Changeset in webkit [70081] by
-
- 5 edits1 add in trunk
2010-10-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Use webkit's TestNetscapePlugIn in DRT mac
https://bugs.webkit.org/show_bug.cgi?id=47850
- platform/chromium/drt_expectations.txt: Update passing/failing test
list. More new passing tests than new failing tests.
2010-10-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Use webkit's TestNetscapePlugIn in DRT mac
https://bugs.webkit.org/show_bug.cgi?id=47850
- WebKit.gyp: Copy WebKitTestPlugIn into plugins and add
GCC_SYMBOLS_PRIVATE_EXTERN: NO to export the symbols.
2010-10-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Use webkit's TestNetscapePlugIn in DRT mac
https://bugs.webkit.org/show_bug.cgi?id=47850
- DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked
because we're going to name our plugin WebKitTestNetscapePlugIn
temporarily until the chromium forked plugin goes away.
- 1:47 PM Changeset in webkit [70080] by
-
- 4 edits in trunk/LayoutTests
2010-10-19 Antonio Gomes <agomes@rim.com>
Unreviewed complementary fix to r70058 (Part II).
Skipping the test on Gtk, Qt and Windows, because they do not implement LayoutTestController::nodesFromRect.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 1:44 PM Changeset in webkit [70079] by
-
- 3 edits in trunk/WebKitTools
2010-10-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
cr-mac bubble has caused status bubbles to wrap
https://bugs.webkit.org/show_bug.cgi?id=47928
We now have too many EWSes to fit in the bugs.webkit.org
status-bubble iframe when more than a couple EWS builds are pending.
To fix this I've reduced the space taken up by queue position,
and also moved cr-mac to the end of the list (since it's going to be
triple-digits for a while).
- QueueStatusServer/model/queues.py:
- QueueStatusServer/templates/statusbubble.html:
- 1:39 PM Changeset in webkit [70078] by
-
- 1 edit1 move in trunk/LayoutTests
2010-10-19 Antonio Gomes <agomes@rim.com>
Unreviewed complementary fix to r70058.
- fast/dom/nodesFromRect-links-and-text-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-links-and-text-expected.html.
- 1:34 PM Changeset in webkit [70077] by
-
- 2 edits in trunk/WebCore
2010-10-19 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
iOS: ASSERT in Cache::adjustSize running layout tests
https://bugs.webkit.org/show_bug.cgi?id=47873
Inside Cache::pruneDeadResources we loop over the LRU lists and make resources purgeable
with Cache::makeResourcePurgeable(). This wasn't taking into account whether the resource
was already purgeable or not, and the makeResourcePurgeable call was always calling
adjustSize(). Now we make sure makeResourcePurgable only adjusts the size of the Cache's
dead sizes when it first marks the resource purgeable. Likewise, if a resource is marked
as purgeable and then evicted, we should not adjust the size again.
The balancing call is when we have a resource that has been marked as purgeable and we
successfully mark it as no longer purgeable in Cache::resourceForURL.
No test added because this requires testing purgeable memory.
- loader/Cache.cpp: (WebCore::Cache::makeResourcePurgeable): (WebCore::Cache::evict):
- 12:43 PM Changeset in webkit [70076] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-19 Kwang Yul Seo <skyul@company100.net>
Reviewed by David Kilzer.
RVCT fails to compile DateMath.cpp due to overloaded function pow
https://bugs.webkit.org/show_bug.cgi?id=47844
Choose std::pow(double, double) among multiple overloaded pow functions
to fix build for RVCT.
- wtf/DateMath.cpp: (WTF::parseES5DateFromNullTerminatedCharacters):
- 12:38 PM Changeset in webkit [70075] by
-
- 4 edits in trunk/WebCore
2010-10-19 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Disable mipmapping for ImageLayer's to prevent memory use and
performance regression.
https://bugs.webkit.org/show_bug.cgi?id=47913
This patch is a straight revert of the patch committed with issue 46493
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::updateTextureRect):
- platform/graphics/chromium/ContentLayerChromium.h: (WebCore::ContentLayerChromium::SharedValues::initialized):
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
- 12:23 PM Changeset in webkit [70074] by
-
- 3 edits in trunk/JavaScriptCore
2010-10-19 Patrick Gansterer <Patrick Gansterer>
Reviewed by David Kilzer.
Use UChar instead of wchar_t in UnicodeWinCE
https://bugs.webkit.org/show_bug.cgi?id=47904
Make UnicodeWinCE more portable, so we can use it for other ports too.
- wtf/unicode/wince/UnicodeWinCE.cpp: (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSpace): (WTF::Unicode::isLetter): (WTF::Unicode::isUpper): (WTF::Unicode::isLower): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::isAlphanumeric): (WTF::Unicode::toTitleCase): (WTF::Unicode::mirroredChar): (WTF::Unicode::digitValue):
- wtf/unicode/wince/UnicodeWinCE.h: (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isHighSurrogate): (WTF::Unicode::isLowSurrogate): (WTF::Unicode::umemcasecmp): (WTF::Unicode::surrogateToUcs4):
- 12:16 PM Changeset in webkit [70073] by
-
- 4 edits in trunk/WebCore
2010-10-18 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
gl-teximage.html fails on chromium webkit mac bot
https://bugs.webkit.org/show_bug.cgi?id=47034
- platform/graphics/GraphicsContext3D.cpp: Deal with endians in 16 bit image data. (WebCore::convertColor16LittleTo8): (WebCore::convertColor16BigTo8): (WebCore::doPacking):
- platform/graphics/GraphicsContext3D.h: Ditto.
- platform/graphics/cg/GraphicsContext3DCG.cpp: Ditto. (WebCore::GraphicsContext3D::getImageData):
- 11:38 AM Changeset in webkit [70072] by
-
- 54 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=47841
Reviewed by Dan Bernstein.
Rework baselinePosition and lineHeight to be writing-mode-aware. There's a lot of refactoring here to clean up
the method parameters to be more readable and to simplify the subclassing of the various methods in order to
keep the horizontal/vertical querying to a minimum.
- WebCore.xcodeproj/project.pbxproj:
- mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::baselinePosition):
- mathml/RenderMathMLFraction.h:
- mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::baselinePosition):
- mathml/RenderMathMLOperator.h:
- mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::baselinePosition):
- mathml/RenderMathMLRow.h:
- mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::baselinePosition):
- mathml/RenderMathMLSubSup.h:
- mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout):
(WebCore::RenderMathMLUnderOver::baselinePosition):
- mathml/RenderMathMLUnderOver.h:
- rendering/InlineBox.h:
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
- rendering/InlineTextBox.h:
- rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight):
- rendering/RenderBR.h:
(WebCore::toRenderBR):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):
(WebCore::RenderBlock::localCaretRect):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::lineHeight):
(WebCore::RenderBox::baselinePosition):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::verticalPosition):
- rendering/RenderBoxModelObject.h:
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::lineHeight):
(WebCore::RenderInline::baselinePosition):
- rendering/RenderInline.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::baselinePosition):
- rendering/RenderListBox.h:
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::lineHeight):
(WebCore::RenderListMarker::baselinePosition):
- rendering/RenderListMarker.h:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderReplaced.cpp:
- rendering/RenderReplaced.h:
- rendering/RenderSVGRoot.cpp:
- rendering/RenderSVGRoot.h:
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::baselinePosition):
- rendering/RenderSlider.h:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::baselinePosition):
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.h:
(WebCore::RenderTableCol::isTableCol):
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.h:
- rendering/RenderText.cpp:
- rendering/RenderText.h:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight):
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::baselinePosition):
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::lineHeight):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::calculateBoundaries):
- 11:30 AM Changeset in webkit [70071] by
-
- 9 edits24 adds in trunk
2010-10-19 Jia Pu <jpu@apple.com>
Reviewed by Adele Peterson.
Moving cursor back to autocorrected word in the same line shouldn't remove the underline
https://bugs.webkit.org/show_bug.cgi?id=47629
<rdar://problem/8546758>
- platform/mac-leopard/Skipped: New tests don't apply to this Mac OSX version.
- platform/mac-snowleopard/Skipped: Ditto.
- platform/mac-tiger/Skipped: Ditto.
- platform/mac-wk2/Skipped: Ditto.
- platform/mac/editing/spelling/autocorrection-delete-expected.checksum:
- platform/mac/editing/spelling/autocorrection-delete-expected.png:
- platform/mac/editing/spelling/click-autocorrected-word-expected.checksum: Added.
- platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
- platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
- platform/mac/editing/spelling/click-autocorrected-word.html: Added.
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum: Added.
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
- platform/mac/editing/spelling/delete-into-autocorrected-word.html: Added.
- platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt: Added.
- platform/mac/editing/spelling/delete-into-misspelled-word.html: Added.
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.checksum: Added.
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html: Added.
- platform/mac/editing/spelling/move-cursor-around-misspelled-word-expected.txt: Added.
- platform/mac/editing/spelling/move-cursor-around-misspelled-word.html: Added.
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.checksum: Added.
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html: Added.
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.checksum: Added.
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html: Added.
2010-10-19 Jia Pu <jpu@apple.com>
Reviewed by Adele Peterson.
Moving cursor back to autocorrected word in the same line shouldn't remove the underline
https://bugs.webkit.org/show_bug.cgi?id=47629
<rdar://problem/8546758>
Tests: platform/mac/editing/spelling/click-autocorrected-word.html
platform/mac/editing/spelling/delete-into-autocorrected-word.html
platform/mac/editing/spelling/delete-into-misspelled-word.html
platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
- editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Don't remove misspelling or autocorrection underlines when cursor is moved onto a word.
- 11:02 AM Changeset in webkit [70070] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-19 Tony Chang <tony@chromium.org>
Unreviewed. Rolling chromium DEPS to 63057 to pick up mac plugin
loading in DRT.
- DEPS: bump chromium DEPS to 63057.
- 10:58 AM Changeset in webkit [70069] by
-
- 3 edits1 move in trunk/WebKit
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=47864
Convert WebNSUserDefaultsExtras.m to .mm
Also, fixed some issues in the process:
- removed locking, which was only necessary when this code was in Foundation;
- fixed notification center observer to actually work (previously, it picked up changes when application preferences changed, not when system language did);
- removed unused NSString category;
- updated style.
- Misc/WebNSUserDefaultsExtras.m: Removed.
- Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m. (createHTTPStyleLanguageCode): (+[NSUserDefaults _webkit_defaultsDidChange]): (addLanguageChangeObserver): (+[NSUserDefaults _webkit_preferredLanguageCode]):
- 10:56 AM Changeset in webkit [70068] by
-
- 3 edits in trunk/WebKitTools
2010-10-19 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
https://bugs.webkit.org/show_bug.cgi?id=47874
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- 10:47 AM Changeset in webkit [70067] by
-
- 2 edits in trunk/WebKit2
Windows build fix
- WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
(WebKit::interruptForPolicyChangeError): Add a missing comma.
- 10:15 AM Changeset in webkit [70066] by
-
- 9 edits1 add in trunk/WebKit2
Part 2 of:
Need to include WKErrorRef in the WKPageDidFail... functions
<rdar://problem/8564110>
https://bugs.webkit.org/show_bug.cgi?id=47871
Reviewed by Anders Carlsson.
- Shared/API/c/WKError.cpp:
(WKErrorCopyWKErrorDomain):
- Shared/API/c/WKError.h:
- Shared/WebError.cpp: Added.
(WebKit::WebError::webKitErrorDomain):
- Shared/WebError.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
(+[NSError _webKitErrorWithCode:failingURL:]):
(registerErrors):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
- WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
(WebKit::cancelledError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptForPolicyChangeError):
- win/WebKit2.vcproj:
- 10:10 AM Changeset in webkit [70065] by
-
- 2 edits in trunk/WebCore
2010-10-19 Eric Carlson <eric.carlson@apple.com>
Not reviewed. Build fix.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectNextSourceChild): Initialize variable to avoid Windows "potentially uninitialized local variable" warning.
- 9:43 AM Changeset in webkit [70064] by
-
- 33 edits in trunk
2010-10-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] DumpRenderTree shouldn't put '.' in include path
https://bugs.webkit.org/show_bug.cgi?id=47877
- WebKit.gyp: Replace '.' with <(chromium_src_dir) and add public
2010-10-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] DumpRenderTree shouldn't put '.' in include path
https://bugs.webkit.org/show_bug.cgi?id=47877
Fix include paths.
- DumpRenderTree/chromium/AccessibilityController.cpp:
- DumpRenderTree/chromium/AccessibilityUIElement.cpp:
- DumpRenderTree/chromium/AccessibilityUIElement.h:
- DumpRenderTree/chromium/CppBoundClass.cpp:
- DumpRenderTree/chromium/CppVariant.cpp:
- DumpRenderTree/chromium/CppVariant.h:
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
- DumpRenderTree/chromium/DRTDevToolsClient.cpp:
- DumpRenderTree/chromium/DRTDevToolsClient.h:
- DumpRenderTree/chromium/EventSender.cpp:
- DumpRenderTree/chromium/EventSender.h:
- DumpRenderTree/chromium/LayoutTestController.cpp:
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/MockSpellCheck.cpp:
- DumpRenderTree/chromium/NotificationPresenter.cpp:
- DumpRenderTree/chromium/NotificationPresenter.h:
- DumpRenderTree/chromium/PlainTextController.cpp:
- DumpRenderTree/chromium/Task.cpp:
- DumpRenderTree/chromium/TestNavigationController.h:
- DumpRenderTree/chromium/TestShell.cpp:
- DumpRenderTree/chromium/TestWebWorker.h:
- DumpRenderTree/chromium/TextInputController.cpp:
- DumpRenderTree/chromium/WebPreferences.cpp:
- DumpRenderTree/chromium/WebPreferences.h:
- DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
- DumpRenderTree/chromium/WebThemeEngineDRT.h:
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
- 9:43 AM Changeset in webkit [70063] by
-
- 7 edits4 adds in trunk
2010-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46763
CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal
Fix crashes caused by moving and deleting <source> element(s) of active media element.
Tests: media/video-source-moved.html
media/video-source-removed.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Add logging. Initialize selectNextSourceChild. (WebCore::HTMLMediaElement::~HTMLMediaElement): Ditto. (WebCore::HTMLMediaElement::insertedIntoDocument): Ditto. (WebCore::HTMLMediaElement::removedFromDocument): Ditto. (WebCore::HTMLMediaElement::scheduleLoad): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Deal with m_currentSourceNode being null when the media engine signals a failure by skipping the error message and continuing as usual. (WebCore::HTMLMediaElement::setVolume): Fix logging typo. (WebCore::HTMLMediaElement::havePotentialSourceChild): Save and restore m_nextChildNodeToConsider around call to selectNextSourceChild because they are both significant. (WebCore::HTMLMediaElement::selectNextSourceChild): Use m_nextChildNodeToConsider to pick the first node to consider. Bail immediately if it signals that we have already processed every <source> node. Stach the node following the current source element in m_nextChildNodeToConsider so we can resume the search even if m_currentSourceNode is removed while it is being processed. (WebCore::HTMLMediaElement::sourceWasAdded): New, move logic from HTMLSourceElement::insertedIntoTree here and correct it to deal with a <source> node being inserted immediately after the current <source> node and a new <source> node being inserted at the end of the list after all candidates have failed. (WebCore::HTMLMediaElement::sourceWillBeRemoved): New, deal with current source node and next potential node being removed.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::sourceChildEndOfListValue): New, define sentinal value used to indicate that all nodes have been processed.
- html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::HTMLSourceElement): Add logging. (WebCore::HTMLSourceElement::insertedIntoTree): Call mediaElement->sourceWasAdded instead of having logic here. (WebCore::HTMLSourceElement::willRemove): New, call mediaElement->sourceWillBeRemoved (WebCore::HTMLSourceElement::scheduleErrorEvent): Add logging. (WebCore::HTMLSourceElement::cancelPendingErrorEvent): Add logging.
- html/HTMLSourceElement.h:
2010-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46763
CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal
Test moving and deleting <source> element(s) of active <video>.
- media/media-file.js: (mimeTypeForExtension): New, added to make it possible to set 'type' attribute on <source>.
- media/video-source-moved-expected.txt: Added.
- media/video-source-moved.html: Added.
- media/video-source-removed-expected.txt: Added.
- media/video-source-removed.html: Added.
- 8:56 AM Changeset in webkit [70062] by
-
- 23 edits in trunk
WebKit2: Need to include WKErrorRef in the WKPageDidFail... functions
<rdar://problem/8564110>
https://bugs.webkit.org/show_bug.cgi?id=47871
Reviewed by Dan Bernstein.
Give WebError a WebCore::ResourceError backing and start passing it over the wire
for failure cases. Also, fill out the WKError API to include domain, errorCode,
failingURL and localizedDescription.
- Shared/API/c/WKError.cpp:
(WKErrorCopyDomain):
(WKErrorGetErrorCode):
(WKErrorCopyFailingURL):
(WKErrorCopyLocalizedDescription):
- Shared/API/c/WKError.h:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
- Shared/WebCoreArgumentCoders.h:
- Shared/WebError.h:
(WebKit::WebError::create):
(WebKit::WebError::domain):
(WebKit::WebError::errorCode):
(WebKit::WebError::failingURL):
(WebKit::WebError::localizedDescription):
(WebKit::WebError::platformError):
(WebKit::WebError::WebError):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/ClientImpl.cpp:
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
- UIProcess/API/qt/ClientImpl.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
WebKitTools: Need to include WKErrorRef in the WKPageDidFail... functions
https://bugs.webkit.org/show_bug.cgi?id=47871
Reviewed by Dan Bernstein.
Update tools for new parameter in failure callbacks.
- MiniBrowser/mac/BrowserWindowController.m:
(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
(-[BrowserWindowController updateProvisionalURLForFrame:]):
- TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- 8:31 AM Changeset in webkit [70061] by
-
- 2 edits in trunk/WebKit2
2010-10-19 Christian Sejersen <Christian Sejersen>
Reviewed by Kenneth Rohde Christiansen.
Scratchbox has an old version of python as the default one, so
force it to use version 2.6.
https://bugs.webkit.org/show_bug.cgi?id=47895
- DerivedSources.pro:
- 8:28 AM Changeset in webkit [70060] by
-
- 9 edits in trunk
2010-10-19 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Antti Koivisto.
[Qt] WebKit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47897
Qt WebKit2 MacOS build fix.
- bridge/npapi.h:
2010-10-19 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Antti Koivisto.
[Qt] WebKit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47897
Qt WebKit2 MacOS build fix.
- UIProcess/WebPageProxy.cpp:
- WebKit2.pri:
- WebKit2.pro:
2010-10-19 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Antti Koivisto.
[Qt] WebKit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47897
Qt WebKit2 MacOS build fix.
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/qt/TestControllerQt.cpp:
- 8:21 AM Changeset in webkit [70059] by
-
- 7 edits in trunk/WebKitTools
2010-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch stats the filesystem too many times
https://bugs.webkit.org/show_bug.cgi?id=47883
This patch attempts to cache the list of changed files more agressively
and to use that list to compute the diff instead of stating the file
system again.
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Scripts/webkitpy/tool/steps/editchangelog.py:
- Scripts/webkitpy/tool/steps/preparechangelog.py:
- 8:12 AM Changeset in webkit [70058] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-10-18 Antonio Gomes <agomes@rim.com>
Reviewed by Kenneth Rohde Christiansen.
Add a test to nodesFromRect involving links and text nodes
https://bugs.webkit.org/show_bug.cgi?id=47795
Similarly to bug 47766 (Enrich /fast/dom/nodesFromRect-basic.html test,
this patch continues to improve the test coverage for Document::nodesFromRect.
This time tests involving links and text nodes are being added this time. Basically
it performs various rect hit tests involving the positions of the elements.
- fast/dom/nodesFromRect-links-and-text-expected.html: Added.
- fast/dom/nodesFromRect-links-and-text.html: Added.
- 7:51 AM Changeset in webkit [70057] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly
Reviewed by Darin Adler.
- Scripts/sort-Xcode-project-file:
- Don't print an error message about missing arguments when
-hhelp is used. - Allow Xcode project files to be specified as Project.xcodeproj instead of Project.xcodeproj/project.pbxproj.
- 7:37 AM Changeset in webkit [70056] by
-
- 2 edits in trunk/WebCore
2010-10-19 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] Soup cache code still has some warnings
https://bugs.webkit.org/show_bug.cgi?id=47733
Fixed some compilation warnings happening with gcc 4.4.5 on
64-bits architecture.
- platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_entry_set_freshness): (close_ready_cb):
- 7:21 AM Changeset in webkit [70055] by
-
- 1 edit in branches/chromium/552/WebCore/inspector/front-end/ScriptsPanel.js
Merge 70054 - 2010-10-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: crash while trying to step over a function using inspector
https://bugs.webkit.org/show_bug.cgi?id=47902
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset): reset scripts panel to resumed state on navigation.
TBR=yurys@chromium.org
BUG=59622
- 7:12 AM Changeset in webkit [70054] by
-
- 2 edits in trunk/WebCore
2010-10-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: crash while trying to step over a function using inspector
https://bugs.webkit.org/show_bug.cgi?id=47902
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset): reset scripts panel to resumed state on navigation.
- 6:44 AM Changeset in webkit [70053] by
-
- 2 edits in trunk/LayoutTests
2010-10-19 Andreas Kling <kling@webkit.org>
Unreviewed, skip fast/canvas/canvas-getImageData-negative-source.html on Mac.
https://bugs.webkit.org/show_bug.cgi?id=47901
- platform/mac/Skipped:
- 5:52 AM Changeset in webkit [70052] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update the Qt test expectations after r70047.
Missing support for document.createTouch and document.createTouchList
https://bugs.webkit.org/show_bug.cgi?id=47676
- platform/qt/fast/dom/Window/window-properties-expected.txt:
Add the new APIs to the expected results.
- 5:47 AM Changeset in webkit [70051] by
-
- 2 edits in trunk/WebCore
2010-10-19 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed attempt to remove warning in EFL build.
Fix #if to #ifdef.
No new features, so no tests added.
- platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyFallbackCursor):
- 5:46 AM Changeset in webkit [70050] by
-
- 3 edits3 adds in trunk
2010-10-19 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] getImageData returns wrong data for non-0,0 source offset
https://bugs.webkit.org/show_bug.cgi?id=47898
Test: fast/canvas/canvas-getImageData-negative-source.html
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): Add missing *4's to get correct pixel offset.
2010-10-19 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] getImageData returns wrong data for non-0,0 source offset
https://bugs.webkit.org/show_bug.cgi?id=47898
- fast/canvas/canvas-getImageData-negative-source-expected.txt: Added.
- fast/canvas/canvas-getImageData-negative-source.html: Added.
- fast/canvas/script-tests/canvas-getImageData-negative-source.js: Added.
- 5:44 AM Changeset in webkit [70049] by
-
- 2 edits in trunk/WebCore
2010-10-19 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Correct initial state of ImageBuffer QPen
https://bugs.webkit.org/show_bug.cgi?id=47804
Have the QPen on ImageBuffers start in Qt::SvgMiterJoin mode.
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBufferData::ImageBufferData):
- 5:15 AM Changeset in webkit [70048] by
-
- 5 edits in trunk/WebCore
2010-10-19 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
GStreamer PlatformVideoWindow needs an API to prepare the widget before applying the overlay
https://bugs.webkit.org/show_bug.cgi?id=46790
Simple API addition to PlatformVideoWindow to allow
implementations to optionally prepare their own PlatformWidget
before applying the GStreamer XOverlay to it. This will likely be
needed on Mac OSX only.
- platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay):
- platform/graphics/gstreamer/PlatformVideoWindow.h:
- platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: (PlatformVideoWindow::prepareForOverlay):
- platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp: (PlatformVideoWindow::prepareForOverlay):
- 4:50 AM Changeset in webkit [70047] by
-
- 12 edits8 adds in trunk
2010-10-19 Ben Murdoch <benm@google.com>
Reviewed by Steve Block.
Missing support for document.createTouch and document.createTouchList
https://bugs.webkit.org/show_bug.cgi?id=47676
Add tests to verify the presence of the APIs and that they work correctly.
- fast/events/touch/document-create-touch-expected.txt: Added.
- fast/events/touch/document-create-touch-list-expected.txt: Added.
- fast/events/touch/document-create-touch-list.html: Added.
- fast/events/touch/document-create-touch.html: Added.
- fast/events/touch/script-tests/document-create-touch-list.js: Added.
- fast/events/touch/script-tests/document-create-touch.js: Added.
2010-10-19 Ben Murdoch <benm@google.com>
Reviewed by Steve Block.
Missing support for document.createTouch and document.createTouchList
https://bugs.webkit.org/show_bug.cgi?id=47676
These APIs are used by many sites to detect support for touch events.
Implement the APIs according to the documentation at:
http://developer.apple.com/library/safari/#documentation/UserExperience/Reference/DocumentAdditionsReference/DocumentAdditions/DocumentAdditions.html
Tests: fast/events/touch/document-create-touch-list.html
fast/events/touch/document-create-touch.html
- bindings/js/JSBindingsAllInOne.cpp: Add new files to list.
- bindings/js/JSTouchCustom.cpp: Added. (WebCore::toJSNewlyCreated):
- bindings/js/JSTouchListCustom.cpp: Added. (WebCore::toJSNewlyCreated):
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.cpp: (WebCore::Document::createTouch): (WebCore::Document::createTouchList):
- dom/Document.h:
- dom/Document.idl: Add createTouch and createTouchList functions.
- Android.jscbindings.mk: Update makefiles.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- 3:38 AM Changeset in webkit [70046] by
-
- 11 edits in trunk/WebCore
2010-10-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: migrate from legacy Object.properties to Object.keys, remove dead code.
https://bugs.webkit.org/show_bug.cgi?id=47890
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._reportCompletions):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onGetResources):
- inspector/front-end/HAREntry.js: (WebInspector.HARLog.prototype.build):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/utilities.js:
- 3:35 AM Changeset in webkit [70045] by
-
- 4 edits in trunk/WebCore
2010-10-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not access ResourcePanel from resources directly.
https://bugs.webkit.org/show_bug.cgi?id=47892
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set documentURL): (WebInspector.Resource.prototype.set startTime): (WebInspector.Resource.prototype.set responseReceivedTime): (WebInspector.Resource.prototype.set endTime): (WebInspector.Resource.prototype.set resourceSize): (WebInspector.Resource.prototype.set expectedContentLength): (WebInspector.Resource.prototype.set category): (WebInspector.Resource.prototype.set cached): (WebInspector.Resource.prototype.set mimeType): (WebInspector.Resource.prototype.get requestHeaders): (WebInspector.Resource.prototype.set requestHeaders): (WebInspector.Resource.prototype.get responseHeaders): (WebInspector.Resource.prototype.set responseHeaders):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.addResource): (WebInspector.ResourcesPanel.prototype.refreshResource): (WebInspector.ResourcesPanel.prototype._recreateViewForResourceIfNeeded): (WebInspector.ResourcesPanel.prototype._resourceViewIsConsistentWithCategory): (WebInspector.ResourceGraph): (WebInspector.ResourceGraph.prototype.refresh):
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 3:34 AM Changeset in webkit [70044] by
-
- 3 edits in trunk/WebKitTools
[Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode.
https://bugs.webkit.org/show_bug.cgi?id=47809
Reviewed by Andreas Kling.
Connecting a call to load from the loadFinished signal can cause
re-entrance crashes in WebCore. This patch uses a timer to do so,
also giving some time to subsequent frames to finish loading.
- QtTestBrowser/urlloader.cpp:
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::checkIfFinished):
(UrlLoader::frameLoadStarted):
(UrlLoader::frameLoadFinished):
- QtTestBrowser/urlloader.h:
- 3:21 AM Changeset in webkit [70043] by
-
- 2 edits in trunk/WebCore
2010-10-19 Yuta Kitamura <yutak@chromium.org>
Reviewed by Pavel Feldman.
Make sure WebSocket resource has the url field when it is created.
Web Inspector: Uncaught TypeError when connection to WebSocket server is refused
https://bugs.webkit.org/show_bug.cgi?id=47891
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::createWebSocket):
- 2:38 AM Changeset in webkit [70042] by
-
- 9 edits in branches/chromium/552
DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829
BUG=59579
Reviewed by Darin Adler.
LayoutTests:
Add tests for out of range behavior here since IndexedDB is the only user
of DOMStringList.
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
WebCore:
When item() returns a null string, it needs to be passed to JS as
null. The indexed getter will then magically do the right thing.
So all that's left is having DOMStringList::item() return null when
the index is out of bounds.
- dom/DOMStringList.cpp:
(WebCore::DOMStringList::item):
- dom/DOMStringList.h:
- dom/DOMStringList.idl:
Merge 69983 - 2010-10-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829
Add tests for out of range behavior here since IndexedDB is the only user
of DOMStringList.
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
2010-10-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829
When item() returns a null string, it needs to be passed to JS as
null. The indexed getter will then magically do the right thing.
So all that's left is having DOMStringList::item() return null when
the index is out of bounds.
- dom/DOMStringList.cpp: (WebCore::DOMStringList::item):
- dom/DOMStringList.h:
- dom/DOMStringList.idl:
- 2:05 AM Changeset in webkit [70041] by
-
- 3 edits in trunk/JavaScriptCore
2010-10-19 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
Fix style of UnicodeWinCE
https://bugs.webkit.org/show_bug.cgi?id=47818
- wtf/unicode/wince/UnicodeWinCE.cpp: (WTF::Unicode::toLower): (WTF::Unicode::toUpper):
- wtf/unicode/wince/UnicodeWinCE.h:
- 1:57 AM Changeset in webkit [70040] by
-
- 4 edits2 adds in trunk
2010-10-19 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Make CSS style selector non-recursive.
https://bugs.webkit.org/show_bug.cgi?id=43783
This change is one of the required changes to fix the following master bug:
https://bugs.webkit.org/show_bug.cgi?id=42806
To avoid recursion, we prepare a call stack and maintain a list of
function call state by ourselves and try matching iteratively.
- fast/css/long-css-selector-matches-expected.txt: Added.
- fast/css/long-css-selector-matches.html: Added.
2010-10-19 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Make CSS style selector non-recursive.
https://bugs.webkit.org/show_bug.cgi?id=43783
This change is one of the required changes to fix the following master bug:
https://bugs.webkit.org/show_bug.cgi?id=42806
To avoid recursion, we prepare a call stack and maintain a list of
function call state by ourselves and try matching iteratively.
Test: fast/css/long-css-selector-matches.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::checkSelector):
- css/CSSStyleSelector.h:
- 1:48 AM Changeset in webkit [70039] by
-
- 5 edits in trunk
2010-10-19 Sergio Villar Senín <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] http/history tests are failing
https://bugs.webkit.org/show_bug.cgi?id=36173
Removed skipped tests from http/history
- platform/gtk/Skipped:
2010-10-19 Sergio Villar Senín <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] http/history tests are failing
https://bugs.webkit.org/show_bug.cgi?id=36173
Clear the history each time a test is run. Return the actual
history item count when calling
LayoutTestController::webHistoryItemCount
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::webHistoryItemCount):
- 1:30 AM Changeset in webkit [70038] by
-
- 6 edits in trunk
2010-10-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70034.
http://trac.webkit.org/changeset/70034
https://bugs.webkit.org/show_bug.cgi?id=47889
"Gustavo's bot is lame" (Requested by xan_ on #webkit).
- configure.ac:
2010-10-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70034.
http://trac.webkit.org/changeset/70034
https://bugs.webkit.org/show_bug.cgi?id=47889
"Gustavo's bot is lame" (Requested by xan_ on #webkit).
- platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar): (WebCore::setCookies):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL): (WebCore::restartedCallback): (WebCore::startHttp):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
- 1:23 AM Changeset in webkit [70037] by
-
- 1 edit in branches/chromium/552/WebCore/inspector/front-end/inspector.css
Merge 69954 - 2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: tab headers on resource panel are 1px off on Mac.
https://bugs.webkit.org/show_bug.cgi?id=47798
- inspector/front-end/inspector.css: (.tabbed-pane-header li):
TBR=pfeldman@chromium.org
BUG=59748
- 1:17 AM Changeset in webkit [70036] by
-
- 3 edits in trunk/WebKit/gtk
2010-10-19 Joone Hur <joone@kldp.org>
Reviewed by Martin Robinson.
[GTK] Needs fixing mistyped comments in the API documentation
https://bugs.webkit.org/show_bug.cgi?id=47656
Fixed mistyped comments in the API documenentation.
- webkit/webkitwebsettings.cpp: Fixed a mistyped comment in the the section block.
- webkit/webkitwebwindowfeatures.cpp: Fixed a mistyped comment in the section block.
- 12:58 AM Changeset in webkit [70035] by
-
- 2 edits in trunk
2010-10-19 Prof. MAAD <himself@prof-maad.org>
Reviewed by Xan Lopez.
[GTK] Correct erroneous documentation for webkit_web_navigation_action_get_button()
https://bugs.webkit.org/show_bug.cgi?id=46723
- WebKit/gtk/webkit/webkitwebnavigationaction.cpp:
- 12:50 AM Changeset in webkit [70034] by
-
- 6 edits in trunk
2010-10-19 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Bump minimum requirement for libsoup to 2.30
https://bugs.webkit.org/show_bug.cgi?id=46176
Bump minimum libsoup to required version to 2.30.0.
- configure.ac:
WebCore:
2010-10-19 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Bump minimum requirement for libsoup to 2.30
https://bugs.webkit.org/show_bug.cgi?id=46176
Bump minimum required libsoup version to 2.30.
- platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar): (WebCore::setCookies):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL): (WebCore::restartedCallback): (WebCore::startHttp):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
- 12:15 AM Changeset in webkit [70033] by
-
- 2 edits in trunk/WebCore
2010-10-19 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Fix distcheck, take 2.
- GNUmakefile.am: also move the generated CSS hash files to the build dir.
Oct 18, 2010:
- 11:54 PM Changeset in webkit [70032] by
-
- 2 edits in trunk/LayoutTests
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed.
Re-enabled editing/execCommand/remove-formatting.html and editing/execCommand/remove-formatting-2.html on Qt platforms.
- platform/qt/Skipped:
- 11:34 PM Changeset in webkit [70031] by
-
- 3 edits2 adds22 deletes in trunk/LayoutTests
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
dump-as-markup conversion: editing/execCommand/remove-formatting.html and remove-formatting-2.html
https://bugs.webkit.org/show_bug.cgi?id=47792
Converted editing/execCommand/remove-formatting.html and remove-formatting-2.html to dump-as-markup tests.
- editing/execCommand/remove-formatting-2-expected.txt: Added.
- editing/execCommand/remove-formatting-2.html:
- editing/execCommand/remove-formatting-expected.txt: Added.
- editing/execCommand/remove-formatting.html:
- platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/remove-formatting-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-2-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-expected.txt: Removed.
- platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/mac-leopard/editing/execCommand/remove-formatting-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
- platform/mac/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-2-expected.txt: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.checksum: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.txt: Removed.
- platform/qt/editing/execCommand/remove-formatting-2-expected.txt: Removed.
- platform/qt/editing/execCommand/remove-formatting-expected.txt: Removed.
- 10:37 PM Changeset in webkit [70030] by
-
- 3 edits in trunk/WebKit/qt
2010-10-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Export QWebPage::ViewportAttributes class.
https://bugs.webkit.org/show_bug.cgi?id=47845
- Api/qwebpage.h:
- symbian/eabi/QtWebKitu.def:
- 10:36 PM Changeset in webkit [70029] by
-
- 2 edits in trunk/WebKitTools
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add Chromium Mac EWS to the list of queues at queues.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=47878
- QueueStatusServer/model/queues.py:
- 10:35 PM Changeset in webkit [70028] by
-
- 6 edits in trunk/WebKitTools
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queues.webkit.org/next_patch is always 404
https://bugs.webkit.org/show_bug.cgi?id=47881
With the addition of the Queue class, I changed most of the
code to lookup WorkItems using get_or_insert with a key_name
instead of WorkItems.all().filter(queue_name=).
Because the new get_or_insert code uses an explicit key_name
(which is obviously different from the previously autogenerated
ones), there were new WorkItem records created for each queue.
However, some parts of the code still use WorkItems.all().filter,
thus some parts were getting the new record and some parts the old record.
The same basic bug was occurring with ActiveWorkItems, because I
changed the key_name for that class as well.
To fix this I've moved more of the code over to using Queue.*work_items.
I've also enabled the datastore_admin (new in GAE 1.3.8) so that
we can go delete the old WorkItems records.
I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).
- QueueStatusServer/app.yaml:
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/handlers/updatestatus.py:
- QueueStatusServer/handlers/updateworkitems.py:
- 10:33 PM Changeset in webkit [70027] by
-
- 3 edits2 adds in trunk
2010-10-18 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Should not save state of a detached form control.
https://bugs.webkit.org/show_bug.cgi?id=47811
- fast/forms/state-save-of-detached-control-expected.txt: Added.
- fast/forms/state-save-of-detached-control.html: Added.
2010-10-18 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Should not save state of a detached form control.
https://bugs.webkit.org/show_bug.cgi?id=47811
Test: fast/forms/state-save-of-detached-control.html
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): If the node is detached, don't save the state.
- 9:55 PM Changeset in webkit [70026] by
-
- 9 edits in trunk
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Bump version numbers for 1.3.5 release.
- configure.ac:
WebCore:
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- GNUmakefile.am: add missing files.
WebKit/gtk:
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- NEWS: update for 1.3.5 release.
- docs/webkitgtk-sections.txt: add new APIs.
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- GNUmakefile.am: add missing file.
- 9:48 PM Changeset in webkit [70025] by
-
- 8 edits2 copies in trunk/WebKitTools
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Correct a bunch of typos in QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=47880
These are all due to our complete lack of unit testing in QueueStatusServer.
I added a couple unit tests to cover a few of these fixes, but most of these
are still only caught by actually running the application.
- QueueStatusServer/handlers/nextpatch.py:
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/handlers/statusbubble_unittest.py: Added.
- QueueStatusServer/handlers/updateworkitems.py:
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queuepropertymixin.py:
- QueueStatusServer/model/queuepropertymixin_unittest.py:
- QueueStatusServer/model/workitems.py:
- QueueStatusServer/model/workitems_unittest.py: Added.
- 9:25 PM Changeset in webkit [70024] by
-
- 2 edits in trunk/WebKitTools
2010-10-18 Adam Barth <abarth@webkit.org>
Disable this test because it's failing on the bots and the authors
aren't around to fix it.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 9:11 PM Changeset in webkit [70023] by
-
- 6 edits in trunk/WebKitTools
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CC authors of flaky tests when the commit-queue hits a flaky test
https://bugs.webkit.org/show_bug.cgi?id=47872
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/net/layouttestresults.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 9:05 PM Changeset in webkit [70022] by
-
- 3 edits in trunk/WebKitTools
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to run a chromium-mac-ews builder
https://bugs.webkit.org/show_bug.cgi?id=47876
Since we can't run Mac OS X in a VM, we need to only run committer patches.
There was a multiple inheritance problem which was holding this patch back,
but I decided to just ignore the problem and go with a functional hack for now.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- 8:22 PM Changeset in webkit [70021] by
-
- 2 edits in trunk/WebKitTools
2010-10-18 Kenneth Russell <kbr@google.com>
Reviewed by Tony Chang.
Regression in run_webkit_tests_unittest from r70017
https://bugs.webkit.org/show_bug.cgi?id=47875
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 7:44 PM Changeset in webkit [70020] by
-
- 6 edits in trunk/WebKitTools
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement webkit-patch suggest-reviewers
https://bugs.webkit.org/show_bug.cgi?id=47866
- Scripts/webkitpy/common/checkout/api.py:
- The main logic. We look at the last five changes to each modified (non-ChangeLog) file and collect up the reviewers of those changes as well as the authors of those changes who are reviewers.
- Scripts/webkitpy/common/checkout/api_unittest.py:
- Test the logic with some fun mocks.
- Scripts/webkitpy/common/checkout/scm.py:
- Fix a bug when you have local git commits.
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Test that the bug is fixed.
- Scripts/webkitpy/tool/commands/queries.py:
- Add the query.
- 7:37 PM Changeset in webkit [70019] by
-
- 9 edits1 copy1 add in trunk/WebKitTools
2010-10-18 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
new-run-webkit-tests produces corrupt PNG baselines on Windows
https://bugs.webkit.org/show_bug.cgi?id=47867
- Scripts/webkitpy/layout_tests/port/base.py:
- 7:33 PM Changeset in webkit [70018] by
-
- 5 edits in trunk
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
REGRESSION: Feedly extension crashes Webkit
https://bugs.webkit.org/show_bug.cgi?id=45811
Make test cover large number of properties/string pairs, at two offsets to get the
new allocation to occur at different locations.
- fast/dom/Window/window-postmessage-clone-expected.txt:
- fast/dom/Window/window-postmessage-clone.html:
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
REGRESSION: Feedly extension crashes Webkit
https://bugs.webkit.org/show_bug.cgi?id=45811
The basic problem was the deserializer was holding a pointer into
the constant pool, but if you were sufficiently unlucky then the
constant pool would be moved while still relying on the pointer,
which leads to badness.
I looked at just making all the sites this could happen extract the
right string/jsstring before any possible allocations, but it seemed
too fragile so i've gone for a forwarding object as the solution.
- bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::CachedStringRef::CachedStringRef): (WebCore::CloneDeserializer::CachedStringRef::operator->): (WebCore::CloneDeserializer::readStringData): (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal): (WebCore::CloneDeserializer::deserialize):
- 7:32 PM Changeset in webkit [70017] by
-
- 2 edits in trunk/WebKitTools
2010-10-18 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
new-run-webkit-tests produces corrupt PNG baselines on Windows
https://bugs.webkit.org/show_bug.cgi?id=47867
- Scripts/webkitpy/layout_tests/port/base.py:
- 7:13 PM Changeset in webkit [70016] by
-
- 8 edits2 copies in trunk/WebKitTools
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Deploy Queue class in more places throughout QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=47855
I also caught two typos from the previous change. Unfortunately
I don't yet know how to unittest request handlers yet.
- QueueStatusServer/handlers/dashboard.py:
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/handlers/updateworkitems.py:
- QueueStatusServer/model/activeworkitems.py:
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queuepropertymixin.py: Added.
- QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
- QueueStatusServer/model/queuestatus.py:
- QueueStatusServer/model/workitems.py:
- 6:59 PM Changeset in webkit [70015] by
-
- 1 edit2 adds in trunk/WebCore
2010-10-18 Chris Rogers <crogers@google.com>
Reviewed by Chris Fleizach.
Add AudioResampler files
https://bugs.webkit.org/show_bug.cgi?id=47623
No new tests since audio API is not yet implemented.
- platform/audio/AudioResampler.cpp: Added. (WebCore::AudioResampler::AudioResampler): (WebCore::AudioResampler::configureChannels): (WebCore::AudioResampler::process): (WebCore::AudioResampler::setRate): (WebCore::AudioResampler::reset):
- platform/audio/AudioResampler.h: Added. (WebCore::AudioResampler::~AudioResampler): (WebCore::AudioResampler::rate):
- 6:38 PM Changeset in webkit [70014] by
-
- 3 edits in trunk/WebKitTools
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
scm.py should be able tell us what revisions made changes to a given file
https://bugs.webkit.org/show_bug.cgi?id=47863
Look again, your SCM.py can now log files.
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- 6:02 PM Changeset in webkit [70013] by
-
- 16 edits1 add in trunk/WebKitTools
2010-10-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
new-run-webkit-tests: clean up the options-parsing code in the port
classes.
This change modifies the Port interface to have a get_option() and
set_option_default() method for accessing the options argument
passed to the constructor. If the constructor is not passed an
options argument, we default to a MockOptions() argument from
mocktool, which has the same semantics we want.
Note that there is a disadvantage to port.get_option('foo') over
port._options.foo, which is that you lose some of the checking
for whether 'foo' is set (typos result in the default value, not
an exception being raised. This is desired in this case, since the
Port class is not allowed to assume that options does have any
particular values set, and so this change ensures that all of
the subclasses are following the same, intended, logic.
Arguably this is the wrong semantics to have, and the Port
classes should be able to assume a default set of
attributes/arguments, but that change will need to wait for a
different CL where we can modify new-run-webkit-tests to pull a
list of arguments from the port factory routines.
Also, add unit tests for webkitpy.tool.mocktool.MockOptions .
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/dryrun.py:
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
- Scripts/webkitpy/tool/mocktool_unittest.py: Added.
- 5:40 PM Changeset in webkit [70012] by
-
- 9 edits in trunk/WebKitTools
2010-10-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Re-submit a revised version of r69638 - enabling new-run-webkit-tests
under cygwin. The initial version had a bug in base:uri_to_test_name
that was causing tests to fail. This version corrects that bug, but
also makes the code safer by calling cygpath more reliably, and
leaving a long-running cygpath process open.
This patch also corrects a couple of minor bugs in http_lock_unittest,
chromium_unittest, and dedpulicate_tests_unittest that showed up
while testing this.
- Scripts/webkitpy/common/system/path.py:
- Scripts/webkitpy/common/system/path_unittest.py:
- Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 5:06 PM Changeset in webkit [70011] by
-
- 2 edits1 add in trunk/LayoutTests
2010-10-18 James Robinson <jamesr@chromium.org>
Update chromium test expectations
- platform/chromium-linux/svg/custom/text-linking-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/svg/custom/text-linking-expected.txt.
- platform/chromium/test_expectations.txt:
- 4:53 PM Changeset in webkit [70010] by
-
- 6 edits in trunk/WebCore
2010-10-18 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Prevent the creation of very large textures for layers by switching
to "large layer" mode when a texture is larger than some fixed reasonable size
(set to 2000 pixels for now).
https://bugs.webkit.org/show_bug.cgi?id=47751
The code also changes the large layer logic to use the current scissor rect used
by the compositor instead of the visible rect to determine how to clip large layers.
This will provide additional texture savings. In addition, the various layer rects
have been converted to use integers instead of floats to preserve uniformity in the code.
Tests: Existing large layer layout tests including huge-layer and huge-layer-img
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect):
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::getDrawRect):
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::drawLayersRecursive): (WebCore::LayerRendererChromium::scissorToRect):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::currentScissorRect):
- 4:38 PM Changeset in webkit [70009] by
-
- 2 edits2 moves1 delete in trunk/LayoutTests
2010-10-18 James Robinson <jamesr@chromium.org>
Move chromium xp specific baselines to right place.
- platform/chromium-win-xp/svg/custom/text-linking-expected.checksum:
- platform/chromium-win-xp/svg/custom/text-linking-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/custom/text-linking-expected.png.
- platform/chromium-win-xp/svg/custom/text-linking-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/custom/text-linking-expected.txt.
- platform/chromium-win/svg/custom/text-linking-expected.checksum: Removed.
- 4:28 PM Changeset in webkit [70008] by
-
- 5 edits in trunk
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: Functions created with the function constructor don't implement strict mode semantics
https://bugs.webkit.org/show_bug.cgi?id=47860
When creating the FunctionExecutable for a new function the function constructor
was always passing false for whether or not a function was strict, rather than
using the information from the freshly parsed function itself.
- runtime/Executable.cpp: (JSC::FunctionExecutable::fromGlobalCode):
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: Functions created with the function constructor don't implement strict mode semantics
https://bugs.webkit.org/show_bug.cgi?id=47860
Test that the function constructor produces correct strict mode functions.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
- 4:21 PM Changeset in webkit [70007] by
-
- 2 edits in trunk/WebKit2
Initialize the API client.
Reviewed by Sam Weinig.
- Shared/APIClient.h:
(WebKit::APIClient::APIClient):
- 4:08 PM Changeset in webkit [70006] by
-
- 11 edits1 add in trunk/WebKitTools
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add Queue class and add minimal unittesting of QueueStatusServer code
https://bugs.webkit.org/show_bug.cgi?id=47847
- QueueStatusServer/handlers/dashboard.py:
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/handlers/updateworkitems.py:
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queues.py:
- QueueStatusServer/model/queues_unittest.py: Added.
- QueueStatusServer/model/svnrevision.py:
- Scripts/test-webkitpy:
- Scripts/webkitpy/test/main.py:
- 3:44 PM Changeset in webkit [70005] by
-
- 2 edits in trunk/LayoutTests
2010-10-18 James Robinson <jamesr@chromium.org>
Mark flaky SVG tests as flaky in chromium test expectations.
- platform/chromium/test_expectations.txt:
- 3:40 PM Changeset in webkit [70004] by
-
- 5 edits in trunk/WebKit2
WebKit2 should handle dismissing the Find overlay on mouse-down
https://bugs.webkit.org/show_bug.cgi?id=47854
Reviewed by John Sullivan.
- WebProcess/WebPage/FindPageOverlay.cpp:
(WebKit::FindPageOverlay::mouseEvent):
Dismiss the find UI on MouseDown.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEvent):
If there's a page overlay, let it have a go at the event.
- 3:29 PM Changeset in webkit [70003] by
-
- 2 edits in trunk/WebCore
2010-10-18 Jia Pu <jpu@apple.com>
Reviewed by Stephanie Lewis.
Correct the description of manual test: autocorrection-cancelled-by-typing-1.html
https://bugs.webkit.org/show_bug.cgi?id=47722
<rdar://problem/8556206>
- manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Update description to match the test content.
- 3:19 PM Changeset in webkit [70002] by
-
- 2 edits in trunk/LayoutTests
2010-10-18 Mihai Parparita <mihaip@chromium.org>
Group Chromium DRT media test failures and add media/video-src.html,
which became flaky around r68970.
- platform/chromium/drt_expectations.txt:
- 3:14 PM Changeset in webkit [70001] by
-
- 5 edits in trunk/WebKit2
Fix clang build.
- UIProcess/API/mac/FindIndicatorWindow.mm:
(-[WebFindIndicatorWindowAnimation _initWithFindIndicatorWindow:WebKit::animationProgressCallback:WebKit::FindIndicatorWindow::animationDidEndCallback:WebKit::FindIndicatorWindow::]):
(WebKit::FindIndicatorWindow::setFindIndicator):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPopupMenuProxy.h:
- WebProcess/WebCoreSupport/WebPopupMenu.h:
- 3:13 PM Changeset in webkit [70000] by
-
- 1 edit in trunk/ChangeLog
70,000!
- 3:11 PM Changeset in webkit [69999] by
-
- 2 edits in trunk/WebKit2
Fix Qt build.
- WebKit2.pro:
- 3:10 PM WebKit2 edited by
- (diff)
- 3:02 PM Changeset in webkit [69998] by
-
- 2 edits in trunk/WebCore
2010-10-18 Martin Robinson <mrobinson@igalia.com>
Build fix for newer versions of GTK+ 2.0. Instead of using GDK_DISPLAY()
use GDK_DRAWABLE_XDISPLAY(gdk_display_get_default()). GDK_DISPLAY() was
recently deprecated and the latter method has been available since GTK+
2.2.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::initXEvent): (WebCore::PluginView::platformGetValue): (WebCore::getVisualAndColormap): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
- 2:55 PM Changeset in webkit [69997] by
-
- 3 edits in trunk/WebKit2
Don't try to change accelerated compositing mode if the web page is closed
https://bugs.webkit.org/show_bug.cgi?id=47852
Reviewed by Simon Fraser.
changeAcceleratedCompositingMode ends up sending a sync message to the UI process which is unnecessary if
the UI process is being torn down.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::changeAcceleratedCompositingMode):
(WebKit::WebPage::close):
- WebProcess/WebPage/WebPage.h:
- 2:53 PM Changeset in webkit [69996] by
-
- 6 edits in trunk
2010-10-18 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Update context attribute conformance test from updated Khronos source.
https://bugs.webkit.org/show_bug.cgi?id=47697
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
- platform/chromium/test_expectations.txt:
2010-10-18 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Turn off antialiasing when using Mesa during testing.
https://bugs.webkit.org/show_bug.cgi?id=47697
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
- 2:44 PM Changeset in webkit [69995] by
-
- 1 edit in branches/chromium/552/WebKit/chromium/src/WebFontImpl.cpp
Merge 69719 - 2010-10-13 Brett Wilson <brettw@chromium.org>
Reviewed by Darin Fisher.
Save and restore the GraphicsContext around setting the clip rect for
drawing text.
https://bugs.webkit.org/show_bug.cgi?id=47634
- src/WebFontImpl.cpp: (WebKit::WebFontImpl::drawText):
- 2:42 PM Changeset in webkit [69994] by
-
- 5 edits in trunk/WebCore
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
elementCannotHaveEndTag should be a member function of MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=47846
Moved elementCannotHaveEndTag into MarkupAccumulator.
No new tests are added since this is a cleanup.
- editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::elementCannotHaveEndTag): Added.
- editing/MarkupAccumulator.h: Added MarkupAccumulator::elementCannotHaveEndTag.
- editing/markup.cpp: Removed elementCannotHaveEndTag.
- editing/markup.h: Removed elementCannotHaveEndTag.
- 2:41 PM Changeset in webkit [69993] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-18 James Robinson <jamesr@chromium.org>
Update the chromium DEPS from 62399 to 62813 to pick up skia fixes
- DEPS:
- 2:28 PM Changeset in webkit [69992] by
-
- 4 edits in trunk/WebKit2
<rdar://problem/8036034>
WebKit2's WebProcess dies immediately on Mac due to DYLD_FRAMEWORK_PATH problem
Reviewed by Sam Weinig.
Pass the path to the WebKit2 framework along to the web process and don't rely on DYLD_FRAMEWORK_PATH being set.
- Shared/mac/CommandLineMac.cpp:
(WebKit::CommandLine::parse):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
- mac/MainMac.cpp:
(main):
- 2:24 PM Changeset in webkit [69991] by
-
- 9 edits3 adds in trunk/WebKit2
Need a WebKit2 equivalent of the WebKit1 WebUserContentURLPattern.
https://bugs.webkit.org/show_bug.cgi?id=47783
Reviewed by Sam Weinig.
- Shared/API/c/WKBase.h:
- Shared/API/c/WKSharedAPICast.h:
- Shared/API/c/WKUserContentURLPattern.cpp: Added.
(WKUserContentURLPatternGetTypeID):
(WKUserContentURLPatternCreate):
(WKUserContentURLPatternMatchesURL):
- Shared/API/c/WKUserContentURLPattern.h: Added.
- Shared/APIObject.h:
- Shared/UserMessageCoders.h:
Use the original pattern string to encode and decode a UserContentURLPattern.
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebUserContentURLPattern.h: Added.
(WebKit::WebUserContentURLPattern::create):
(WebKit::WebUserContentURLPattern::matchesURL):
Use WebCore::UserContentURLPattern::matches.
(WebKit::WebUserContentURLPattern::patternString):
Expose the pattern string used to create the UserContentURLPattern for the purpose of
encoding and decoding.
(WebKit::WebUserContentURLPattern::WebUserContentURLPattern):
(WebKit::WebUserContentURLPattern::type):
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add WKUserContentURLPattern.h/.cpp and WebUserContentURLPattern.h
- win/WebKit2Generated.make:
Copy over WKUsercontentURLPattern into the output directory.
- 2:15 PM Changeset in webkit [69990] by
-
- 4 edits2 adds in trunk
2010-10-18 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Set the right referent sourceURL for the script with force user gesture.
https://bugs.webkit.org/show_bug.cgi?id=37138
Because empty sourceURL indicates running script with force user gesture,
make WebKit use document.url() as referent sourceURL (Since it uses blank
URL instead empty if the input URL is empty) if WebKit isn't running the
script from a hyper-link.
Test: fast/events/popup-blocked-from-window-open.html
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorld):
2010-10-18 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Set the right referent sourceURL for the script with force user gesture.
https://bugs.webkit.org/show_bug.cgi?id=37138
- fast/events/popup-blocked-from-window-open-expected.txt: Added.
- fast/events/popup-blocked-from-window-open.html: Added.
- 2:12 PM Changeset in webkit [69989] by
-
- 15 edits6 adds in trunk/LayoutTests
2010-10-18 James Robinson <jamesr@chromium.org>
Update chromium expectations and baselines.
- platform/chromium/test_expectations.txt:
- 12:59 PM Changeset in webkit [69988] by
-
- 2 edits in trunk/WebCore
- dom/Node.h: Fix ancient typo in just-modified comment.
- 12:52 PM Changeset in webkit [69987] by
-
- 10 edits in trunk/WebCore
2010-10-18 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov.
Remove some functions from class Node and make a few others non-virtual
https://bugs.webkit.org/show_bug.cgi?id=47735
Refactoring. No new tests.
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Added a FIXME about the use of the virtual ownerDocument function.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Removed the unused return value.
- dom/ContainerNode.h: Made insertBefore, replaceChild, removeChild, and appendChild non-virtual for clarity and performance. Made removeChildren non-virtual and removed its return value. Moved the inline Node functions that call through to ContainerNode into this file since the old way involved an extra level of inline function but otherwise had no advantages.
- dom/Element.h: Moved isMathMLElement here because there is no call site that needs to call it on a Node*. We can always move it back if we need to, but it's better to have less in the Node class.
- dom/Node.cpp: (WebCore::Node::insertBefore): Added an isContainerNode check so this can be non-virtual. There are very few callers who call this function on Node. If we want to optimize them further we can make the isContainerNode check inline in the future. (WebCore::Node::replaceChild): Ditto. (WebCore::Node::removeChild): Ditto. (WebCore::Node::appendChild): Ditto. (WebCore::Node::remove): Removed unneeded ref/unref because ContainerNode::removeChild already does this. (WebCore::Node::createRendererIfNeeded): Removed #if around call to childShouldCreateRenderer since it's needed even without SVG and XHTMLMP.
- dom/Node.h: Moved definitions of inline functions that depend on ContainerNode to the ContainerNode.h header. They already required inclusion of that header, so there is no functional change. Made insertBefore, replaceChild, removeChild, and appendChild non-virtual. There are very few callers of these functions on this class. Moved isMathMLElement to Element. Added a FIXME about the name of eventAncestors. Fixed comment formatting. Eliminated unused isEditableBlock function. Moved the body of the enclosingInlineElement function to the editing file that was the only call site. Removed the previousEditable and nextEditable functions, incorporating their bodies into the one place they were called. Took the childShouldCreateRenderer function out of #if since it's now used by the implementation of the <noscript> element.
- dom/Position.cpp: (WebCore::nextRenderedEditable): Rewrote the function to use nextLeafNode instead of nextEditable. (WebCore::previousRenderedEditable): Rewrote the function to use previousLeafNode instead of previousEditable.
- editing/ReplaceSelectionCommand.cpp: (WebCore::enclosingInline): Moved function here from the Node class. Also fixed an incorrect cast this function did, which assumed the function result was always an element, which the function does not guarantee. (WebCore::ReplaceSelectionCommand::doApply): Call the function above.
- history/HistoryItem.cpp: Added include of MathExtras.h.
- 12:48 PM Changeset in webkit [69986] by
-
- 2 edits in trunk/WebKitTools
Fix build.
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventCarbon):
- 12:46 PM Changeset in webkit [69985] by
-
- 2 edits in trunk/WebKit2
Fix build.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformSetFocus):
- 12:33 PM Changeset in webkit [69984] by
-
- 3 edits3 adds in trunk
2010-10-18 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Darin Adler.
Missing support for document.createEvent("OrientationEvent")
https://bugs.webkit.org/show_bug.cgi?id=32492
Add support for document.createEvent("OrientationEvent") to help unit testing of
onOrientationChange event.
- fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt: Added.
- fast/dom/DeviceOrientation/create-event-onorientationchange.html: Added.
- fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js: Added.
2010-10-18 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Darin Adler.
Missing support for document.createEvent("OrientationEvent")
https://bugs.webkit.org/show_bug.cgi?id=32492
Add support for document.createEvent("OrientationEvent") to help unit testing of
onOrientationChange event.
Test: fast/dom/DeviceOrientation/create-event-onorientationchange.html
- dom/Document.cpp: (WebCore::Document::createEvent):
- 12:15 PM Changeset in webkit [69983] by
-
- 9 edits in trunk
2010-10-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829
Add tests for out of range behavior here since IndexedDB is the only user
of DOMStringList.
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
2010-10-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829
When item() returns a null string, it needs to be passed to JS as
null. The indexed getter will then magically do the right thing.
So all that's left is having DOMStringList::item() return null when
the index is out of bounds.
- dom/DOMStringList.cpp: (WebCore::DOMStringList::item):
- dom/DOMStringList.h:
- dom/DOMStringList.idl:
- 12:14 PM Changeset in webkit [69982] by
-
- 4 edits3 adds33 deletes in trunk/LayoutTests
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
dump-as-markup conversion: editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html
https://bugs.webkit.org/show_bug.cgi?id=47784
Converted editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html to dump-as-markup tests.
- editing/execCommand/4920742-1-expected.txt: Added.
- editing/execCommand/4920742-1.html:
- editing/execCommand/5049671-expected.txt: Added.
- editing/execCommand/5049671.html:
- editing/execCommand/5573879-expected.txt: Added.
- editing/execCommand/5573879.html:
- platform/chromium-linux/editing/execCommand/4920742-1-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/4920742-1-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/5049671-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/5049671-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/5573879-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/5573879-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4920742-1-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/4920742-1-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4920742-1-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/5049671-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/5049671-expected.png: Removed.
- platform/chromium-win/editing/execCommand/5049671-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/5573879-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/5573879-expected.png: Removed.
- platform/chromium-win/editing/execCommand/5573879-expected.txt: Removed.
- platform/gtk/editing/execCommand/4920742-1-expected.txt: Removed.
- platform/gtk/editing/execCommand/5049671-expected.txt: Removed.
- platform/gtk/editing/execCommand/5573879-expected.txt: Removed.
- platform/mac-leopard/editing/execCommand/4920742-1-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/4920742-1-expected.png: Removed.
- platform/mac-leopard/editing/execCommand/5049671-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/5049671-expected.png: Removed.
- platform/mac/editing/execCommand/4920742-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/4920742-1-expected.png: Removed.
- platform/mac/editing/execCommand/4920742-1-expected.txt: Removed.
- platform/mac/editing/execCommand/5049671-expected.checksum: Removed.
- platform/mac/editing/execCommand/5049671-expected.png: Removed.
- platform/mac/editing/execCommand/5049671-expected.txt: Removed.
- platform/mac/editing/execCommand/5573879-expected.checksum: Removed.
- platform/mac/editing/execCommand/5573879-expected.png: Removed.
- platform/mac/editing/execCommand/5573879-expected.txt: Removed.
- platform/qt/editing/execCommand/4920742-1-expected.txt: Removed.
- platform/qt/editing/execCommand/5049671-expected.txt: Removed.
- 12:13 PM Changeset in webkit [69981] by
-
- 3 edits in trunk/WebCore
[Qt] Implement Accelerated Composition for NPAPI Plugins.
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=35524
- plugins/PluginView.h:
(WebCore::PluginView::platformLayer):
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::paint):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::invalidateRegion):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformLayer):
- 11:54 AM Changeset in webkit [69980] by
-
- 4 edits3 adds34 deletes in trunk/LayoutTests
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
dump-as-markup conversion: editing/execCommand/4786404-1.html, 4786404-2.html, 4920488.html
https://bugs.webkit.org/show_bug.cgi?id=47782
Converted editing/execCommand/4786404-1.html, 4786404-2.html, 4920488.html to dump-as-markup tests.
- editing/execCommand/4786404-1-expected.txt: Added.
- editing/execCommand/4786404-1.html:
- editing/execCommand/4786404-2-expected.txt: Added.
- editing/execCommand/4786404-2.html:
- editing/execCommand/4920488-expected.txt: Added.
- editing/execCommand/4920488.html:
- platform/chromium-linux/editing/execCommand/4786404-1-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/4786404-1-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/4786404-2-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/4786404-2-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/4920488-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/4920488-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4786404-1-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/4786404-1-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4786404-1-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/4786404-2-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/4786404-2-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4786404-2-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/4920488-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/4920488-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4920488-expected.txt: Removed.
- platform/gtk/editing/execCommand/4786404-1-expected.txt: Removed.
- platform/gtk/editing/execCommand/4786404-2-expected.txt: Removed.
- platform/gtk/editing/execCommand/4920488-expected.txt: Removed.
- platform/mac-leopard/editing/execCommand/4786404-2-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/4786404-2-expected.png: Removed.
- platform/mac-leopard/editing/execCommand/4920488-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/4920488-expected.png: Removed.
- platform/mac/editing/execCommand/4786404-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/4786404-1-expected.png: Removed.
- platform/mac/editing/execCommand/4786404-1-expected.txt: Removed.
- platform/mac/editing/execCommand/4786404-2-expected.checksum: Removed.
- platform/mac/editing/execCommand/4786404-2-expected.png: Removed.
- platform/mac/editing/execCommand/4786404-2-expected.txt: Removed.
- platform/mac/editing/execCommand/4920488-expected.checksum: Removed.
- platform/mac/editing/execCommand/4920488-expected.png: Removed.
- platform/mac/editing/execCommand/4920488-expected.txt: Removed.
- platform/qt/editing/execCommand/4786404-1-expected.txt: Removed.
- platform/qt/editing/execCommand/4786404-2-expected.txt: Removed.
- platform/qt/editing/execCommand/4920488-expected.txt: Removed.
- 11:54 AM Changeset in webkit [69979] by
-
- 7 edits in trunk
2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Eric Seidel.
Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.
- bridge/npapi.h:
- plugins/mac/PluginViewMac.mm: (WebCore::PluginView::setFocus): (WebCore::PluginView::handleMouseEvent):
2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Eric Seidel.
Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.
- Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::mouseEntered): (WebNetscapePluginEventHandlerCarbon::mouseExited): (WebNetscapePluginEventHandlerCarbon::mouseMoved): (WebNetscapePluginEventHandlerCarbon::focusChanged):
2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Eric Seidel.
Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventCarbon):
- 11:46 AM Changeset in webkit [69978] by
-
- 13 edits in trunk/WebKit2
Add matchCountDidChange callback
https://bugs.webkit.org/show_bug.cgi?id=47840
Reviewed by Darin Adler.
- UIProcess/API/C/WKPage.h:
Add matchCountDidChange WKPageFindClient callback.
- UIProcess/WebFindClient.cpp:
(WebKit::WebFindClient::matchCountDidChange):
Call the WKPageFindClient callback.
- UIProcess/WebPageProxy.messages.in:
Add MatchCountDidChange message.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):
Move code here from WebPage.
(WebKit::FindController::findString):
Send the MatchCountDidChange message.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::countStringMatches):
Move this code over to FindController.
- 11:32 AM Changeset in webkit [69977] by
-
- 5 edits in trunk
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Strict mode: |this| should be undefined if it is not explicitly provided
https://bugs.webkit.org/show_bug.cgi?id=47833
To make strict mode behave correctly we want to pass undefined instead of null
as the default this value. This has no impact on behaviour outside of strict
mode as both values are replaced with the global object if necessary.
- bytecompiler/NodesCodegen.cpp: (JSC::FunctionCallValueNode::emitBytecode): (JSC::FunctionCallResolveNode::emitBytecode): (JSC::CallFunctionCallDotNode::emitBytecode): (JSC::ApplyFunctionCallDotNode::emitBytecode):
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Strict mode: |this| should be undefined if it is not explicitly provided
https://bugs.webkit.org/show_bug.cgi?id=47833
Add tests to ensure that |this| is undefined rather than null when it has
not been explicitly provided.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
- 11:17 AM Changeset in webkit [69976] by
-
- 2 edits in trunk/WebCore
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: comment out resource manager instantiation on front-end side.
https://bugs.webkit.org/show_bug.cgi?id=47823
- inspector/front-end/inspector.js:
- 11:08 AM Changeset in webkit [69975] by
-
- 2 edits in trunk/LayoutTests
2010-10-18 Robert Hogan <robert@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
Unskip:
http/tests/navigation/no-referrer-reset.html
http/tests/navigation/no-referrer-target-blank.html
These tests now pass.
- platform/qt/Skipped:
- 11:04 AM Changeset in webkit [69974] by
-
- 8 edits in trunk
2010-10-18 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
The description parameter of IDBFactory::open() should be mandatory.
https://bugs.webkit.org/show_bug.cgi?id=47835
- storage/indexeddb/basics-expected.txt:
- storage/indexeddb/basics.html:
2010-10-18 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
The description parameter of IDBFactory::open() should be mandatory.
https://bugs.webkit.org/show_bug.cgi?id=47835
Makes the description parameter mandatory, as per the IndexedDatabase specification.
Modified existing tests to cover this change.
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::extractMetaData): (WebCore::setMetaData): (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
- storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
- storage/IDBFactory.h:
- storage/IDBFactory.idl:
- 11:02 AM Changeset in webkit [69973] by
-
- 4 edits in trunk/WebKit2
Use nullptr instead of 0.
Reviewed by Darin Adler.
- UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::closeWindow):
- UIProcess/API/mac/WKView.mm:
(-[WKView renewGState]):
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::removePluginProxy):
- 10:41 AM Changeset in webkit [69972] by
-
- 2 edits in trunk/WebCore
2010-10-18 Xiaomei Ji <xji@chromium.org>
Reviewed by David Levin.
Code cleanup: Move most function members in TextRunWorker from inlined.
https://bugs.webkit.org/show_bug.cgi?id=47732
No functionality change, so no tests added.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::setWordSpacingAdjustment): (WebCore::TextRunWalker::setLetterSpacingAdjustment): (WebCore::TextRunWalker::setXOffsetToZero): (WebCore::TextRunWalker::rtl): (WebCore::TextRunWalker::glyphs): (WebCore::TextRunWalker::length): (WebCore::TextRunWalker::xPositions): (WebCore::TextRunWalker::advances): (WebCore::TextRunWalker::width): (WebCore::TextRunWalker::logClusters): (WebCore::TextRunWalker::numCodePoints): (WebCore::TextRunWalker::fontPlatformDataForScriptRun): (WebCore::TextRunWalker::isCodepointSpace): (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::isWordBreak): (WebCore::TextRunWalker::setPadding): (WebCore::TextRunWalker::reset): (WebCore::TextRunWalker::setBackwardsIteration): (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::widthOfFullRun): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setupFontForScriptRun): (WebCore::TextRunWalker::allocHarfbuzzFont): (WebCore::TextRunWalker::deleteGlyphArrays): (WebCore::TextRunWalker::createGlyphArrays): (WebCore::TextRunWalker::resetGlyphArrays): (WebCore::TextRunWalker::shapeGlyphs): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::TextRunWalker::mirrorCharacters):
- 10:27 AM Changeset in webkit [69971] by
-
- 3 edits in trunk/WebCore
2010-10-18 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] AC rendering bugs
There were a few missing connections in Qt AC between GraphicsLayer and plugins, like changing the plugin's geometry to the layer's
contentsRect, and making sure media layers handle ParentChange events and setContentsNeedsDisplay. Now media layers behave correctly.
No new tests. This is in preparation for fixing AC+plugins, which already has tests that don't work yet with Qt.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsNeedsDisplay):
- platform/graphics/qt/GraphicsLayerQt.h:
- 10:23 AM Changeset in webkit [69970] by
-
- 10 edits1 add in trunk/JavaScriptCore
2010-10-18 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Make a nullptr that works with OwnPtr and RefPtr
https://bugs.webkit.org/show_bug.cgi?id=47756
- JavaScriptCore.xcodeproj/project.pbxproj: Added NullPtr.h.
- wtf/NullPtr.h: Added.
- wtf/OwnArrayPtr.h: Add an overload of = taking nullptr.
- wtf/OwnPtr.h: Ditto.
- wtf/PassOwnArrayPtr.h: Ditto.
- wtf/PassOwnPtr.h: Ditto.
- wtf/PassRefPtr.h: Ditto.
- wtf/RefPtr.h: Ditto.
- wtf/RetainPtr.h: Ditto.
- 10:21 AM Changeset in webkit [69969] by
-
- 4 edits in trunk/WebKit
2010-10-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: disable private browsing for inspector
https://bugs.webkit.org/show_bug.cgi?id=47827
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]):
2010-10-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: disable private browsing for inspector
https://bugs.webkit.org/show_bug.cgi?id=47827
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::openInspectorFrontend):
- 10:08 AM Changeset in webkit [69968] by
-
- 15 edits1 add in trunk
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorClient.cpp: Added. (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
- inspector/InspectorClient.h: (WebCore::InspectorClient::InspectorClient):
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224
- WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::sendMessageToFrontend):
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::sendMessageToFrontend):
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::sendMessageToFrontend):
- 10:07 AM Changeset in webkit [69967] by
-
- 2 edits in trunk/LayoutTests
2010-10-18 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skip test failing in the bots, bug opened to check the
problem: https://bugs.webkit.org/show_bug.cgi?id=47832
- platform/gtk/Skipped:
- 9:48 AM Changeset in webkit [69966] by
-
- 3 edits in trunk/WebKit/qt
2010-10-18 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] AC rendering bugs
This fixes a regression that was introduced by making scrolling in accelerated compositing automatic,
which made our explicit function to scroll the compositing layers superfluous, making the scrolling behavior
when graphics layers are present incorrect. The fix simply removes those redundant functions.
- WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::scroll): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
- WebCoreSupport/PageClientQt.h:
- 9:47 AM Changeset in webkit [69965] by
-
- 5 edits in trunk
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: JIT doesn't check for |this| being an immediate before dereferencing
https://bugs.webkit.org/show_bug.cgi?id=47826
There's no guarantee that |this| will be a cell in a strict mode function, so
don't claim that it is.
- bytecode/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: JIT doesn't check for |this| being an immediate before dereferencing
https://bugs.webkit.org/show_bug.cgi?id=47826
Add tests for accessing properties on |this| when |this| is not an object
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js: (testThisDotAccess): (testThisBracketAccess):
- 9:35 AM Changeset in webkit [69964] by
-
- 3 edits1 delete in trunk/WebCore
2010-10-18 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBKeyTree.h is no longer used.
https://bugs.webkit.org/show_bug.cgi?id=47824
No new tests, just removing unused files.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- storage/IDBKeyTree.h: Removed.
- 9:30 AM Changeset in webkit [69963] by
-
- 5 edits in trunk
2010-10-18 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Oliver Hunt.
if (0) throw "x" ; else { } throws parse error after r69906
https://bugs.webkit.org/show_bug.cgi?id=47807
r69906 introduced a bug: the semicolon is not parsed after a throw
expression anymore. Thus, the semicolon terminates the "if" parsing
in the example above, and the else token results a parse error.
- parser/JSParser.cpp: (JSC::JSParser::parseThrowStatement):
2010-10-18 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Oliver Hunt.
if (0) throw "x" ; else { } throws parse error after r69906
https://bugs.webkit.org/show_bug.cgi?id=47807
Adding a new test case to break-ASI.js
- fast/js/break-ASI-expected.txt:
- fast/js/script-tests/break-ASI.js:
- 9:16 AM Changeset in webkit [69962] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix the build with MSVC.
Reviewed by nobody, build fix.
Splitting the condition in two to prevent qmake parentheses issues.
- Api/DerivedSources.pro:
- 8:41 AM Changeset in webkit [69961] by
-
- 2 edits in trunk/WebKit/qt
2010-10-18 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Antonio Gomes.
[QT] Unable to load pages on QtTestBrowser after canceling a page load.
https://bugs.webkit.org/show_bug.cgi?id=43827
- Api/qwebpage.cpp: (QWebPage::triggerAction):
- 8:39 AM Changeset in webkit [69960] by
-
- 2 edits in trunk/WebCore
2010-10-18 Andreas Kling <kling@webkit.org>
Unreviewed buildfix for Qt + V8.
Add missing <wtf/text/CString.h> include.
- inspector/InspectorInstrumentation.cpp:
- 8:24 AM Changeset in webkit [69959] by
-
- 2 edits in trunk/WebCore
2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: toJSON serialization for Numbers should be fixed.
DecimalNumber is used instead of printf.
- inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
- 6:29 AM Changeset in webkit [69958] by
-
- 1 edit107 adds in trunk/LayoutTests
[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.
- platform/qt/editing/input: Added.
- platform/qt/editing/input/emacs-ctrl-o-expected.checksum: Added.
- platform/qt/editing/input/emacs-ctrl-o-expected.png: Added.
- platform/qt/editing/input/emacs-ctrl-o-expected.txt: Added.
- platform/qt/fast/blockflow: Added.
- platform/qt/fast/blockflow/block-level-images-expected.checksum: Added.
- platform/qt/fast/blockflow/block-level-images-expected.png: Added.
- platform/qt/fast/blockflow/block-level-images-expected.txt: Added.
- platform/qt/fast/blockflow/fieldsets-expected.checksum: Added.
- platform/qt/fast/blockflow/fieldsets-expected.png: Added.
- platform/qt/fast/blockflow/fieldsets-expected.txt: Added.
- platform/qt/fast/blockflow/floats-in-block-layout-expected.checksum: Added.
- platform/qt/fast/blockflow/floats-in-block-layout-expected.png: Added.
- platform/qt/fast/blockflow/floats-in-block-layout-expected.txt: Added.
- platform/qt/fast/blockflow/inline-direction-positioning-expected.checksum: Added.
- platform/qt/fast/blockflow/inline-direction-positioning-expected.png: Added.
- platform/qt/fast/blockflow/inline-direction-positioning-expected.txt: Added.
- platform/qt/fast/blockflow/margin-collapse-expected.checksum: Added.
- platform/qt/fast/blockflow/margin-collapse-expected.png: Added.
- platform/qt/fast/blockflow/margin-collapse-expected.txt: Added.
- platform/qt/fast/blockflow/root-lr-basic-expected.checksum: Added.
- platform/qt/fast/blockflow/root-lr-basic-expected.png: Added.
- platform/qt/fast/blockflow/root-lr-basic-expected.txt: Added.
- platform/qt/fast/blockflow/self-collapsing-block-expected.checksum: Added.
- platform/qt/fast/blockflow/self-collapsing-block-expected.png: Added.
- platform/qt/fast/blockflow/self-collapsing-block-expected.txt: Added.
- platform/qt/fast/css/first-letter-punctuation-expected.checksum: Added.
- platform/qt/fast/css/first-letter-punctuation-expected.png: Added.
- platform/qt/fast/css/first-letter-punctuation-expected.txt: Added.
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
- platform/qt/fast/css/rtl-to-viewport-expected.checksum: Added.
- platform/qt/fast/css/rtl-to-viewport-expected.png: Added.
- platform/qt/fast/css/rtl-to-viewport-expected.txt: Added.
- platform/qt/fast/forms/input-button-sizes-expected.checksum: Added.
- platform/qt/fast/forms/input-button-sizes-expected.png: Added.
- platform/qt/fast/forms/input-button-sizes-expected.txt: Added.
- platform/qt/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
- platform/qt/fast/forms/input-placeholder-focus-twice-expected.png: Added.
- platform/qt/fast/forms/input-placeholder-focus-twice-expected.txt: Added.
- platform/qt/fast/images/gif-large-checkerboard-expected.checksum: Added.
- platform/qt/fast/images/gif-large-checkerboard-expected.png: Added.
- platform/qt/fast/images/gif-large-checkerboard-expected.txt: Added.
- platform/qt/fast/multicol/border-padding-pagination-expected.checksum: Added.
- platform/qt/fast/multicol/border-padding-pagination-expected.png: Added.
- platform/qt/fast/multicol/border-padding-pagination-expected.txt: Added.
- platform/qt/fast/multicol/column-break-with-balancing-expected.checksum: Added.
- platform/qt/fast/multicol/column-break-with-balancing-expected.png: Added.
- platform/qt/fast/multicol/column-break-with-balancing-expected.txt: Added.
- platform/qt/fast/multicol/float-paginate-complex-expected.checksum: Added.
- platform/qt/fast/multicol/float-paginate-complex-expected.png: Added.
- platform/qt/fast/multicol/float-paginate-complex-expected.txt: Added.
- platform/qt/fast/multicol/margin-collapse-expected.checksum: Added.
- platform/qt/fast/multicol/margin-collapse-expected.png: Added.
- platform/qt/fast/multicol/margin-collapse-expected.txt: Added.
- platform/qt/fast/multicol/shadow-breaking-expected.checksum: Added.
- platform/qt/fast/multicol/shadow-breaking-expected.png: Added.
- platform/qt/fast/multicol/shadow-breaking-expected.txt: Added.
- platform/qt/fast/multicol/table-margin-collapse-expected.checksum: Added.
- platform/qt/fast/multicol/table-margin-collapse-expected.png: Added.
- platform/qt/fast/multicol/table-margin-collapse-expected.txt: Added.
- platform/qt/fast/multicol/table-vertical-align-expected.checksum: Added.
- platform/qt/fast/multicol/table-vertical-align-expected.png: Added.
- platform/qt/fast/multicol/table-vertical-align-expected.txt: Added.
- platform/qt/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
- platform/qt/fast/multicol/unsplittable-inline-block-expected.png: Added.
- platform/qt/fast/multicol/unsplittable-inline-block-expected.txt: Added.
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
- platform/qt/scrollbars: Added.
- platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
- platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
- platform/qt/svg/custom/fill-opacity-hsl-expected.checksum: Added.
- platform/qt/svg/custom/fill-opacity-hsl-expected.png: Added.
- platform/qt/svg/custom/fill-opacity-hsl-expected.txt: Added.
- platform/qt/svg/custom/fill-opacity-rgba-expected.checksum: Added.
- platform/qt/svg/custom/fill-opacity-rgba-expected.png: Added.
- platform/qt/svg/custom/fill-opacity-rgba-expected.txt: Added.
- platform/qt/svg/custom/recursive-filter-expected.checksum: Added.
- platform/qt/svg/custom/recursive-filter-expected.png: Added.
- platform/qt/svg/custom/recursive-filter-expected.txt: Added.
- platform/qt/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
- platform/qt/svg/custom/repaint-on-constant-size-change-expected.png: Added.
- platform/qt/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
- platform/qt/svg/custom/text-rotation-expected.checksum: Added.
- platform/qt/svg/custom/text-rotation-expected.png: Added.
- platform/qt/svg/custom/text-rotation-expected.txt: Added.
- platform/qt/svg/custom/text-x-dy-lists-expected.checksum: Added.
- platform/qt/svg/custom/text-x-dy-lists-expected.png: Added.
- platform/qt/svg/custom/text-x-dy-lists-expected.txt: Added.
- platform/qt/svg/in-html/by-reference-expected.txt: Added.
- 6:20 AM Changeset in webkit [69957] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-18 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Andreas Kling.
Remove some unnecessary lines of code from Parser.cpp
https://bugs.webkit.org/show_bug.cgi?id=47816
- parser/Parser.cpp:
- 5:46 AM Changeset in webkit [69956] by
-
- 2 edits in trunk/WebCore
2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION] Inspector window visible during run-webkit-tests.
The initial state of an inspector setting should stay untouched
if the profile has no value for it.
- inspector/InspectorState.cpp: (WebCore::InspectorState::loadFromSettings):
- 5:43 AM Styling Form Controls edited by
- (diff)
- 5:42 AM Styling Form Controls edited by
- (diff)
- 5:41 AM Styling Form Controls edited by
- (diff)
- 5:32 AM Styling Form Controls created by
- 5:29 AM Changeset in webkit [69955] by
-
- 2 edits in trunk/WebKitTools
2010-10-18 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
check-webkit-style should treat the GObject binding directory like other GTK directories.
https://bugs.webkit.org/show_bug.cgi?id=47796
- Scripts/webkitpy/style/checker.py: Added the GObject binding directory with the other gtk directories (and fixed typo).
- 5:24 AM WikiStart edited by
- (diff)
- 5:13 AM Changeset in webkit [69954] by
-
- 2 edits in trunk/WebCore
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: tab headers on resource panel are 1px off on Mac.
https://bugs.webkit.org/show_bug.cgi?id=47798
- inspector/front-end/inspector.css: (.tabbed-pane-header li):
- 4:57 AM Changeset in webkit [69953] by
-
- 4 edits in trunk/WebKitTools
2010-10-18 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
check-webkit-style needs to ignore underscores in opcode names and vm_throw
https://bugs.webkit.org/show_bug.cgi?id=47789
- Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
- Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.
- 4:46 AM Changeset in webkit [69952] by
-
- 20 edits in trunk
2010-10-18 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=47659
Changed the reciever of hasSpellingMarkers from
textInputController to layoutTestController.
- editing/spelling/design-mode-spellcheck-off.html:
- editing/spelling/script-tests/spelling-backspace-between-lines.js: (testWithDelete): (testWithForwardDelete):
- editing/spelling/spelling-backspace-between-lines-expected.txt:
- editing/spelling/spelling-contenteditable.html:
- editing/spelling/spelling-textarea.html:
2010-10-18 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=47659
Moved hasSpellingMarkers() from TextInputController to
LayoutTestController. Currently the implementation is available
only for Mac and for Chromium.
- DumpRenderTree/LayoutTestController.cpp: (hasSpellingMarkerCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): (TextInputController::makeAttributedString):
- DumpRenderTree/chromium/TextInputController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/mac/TextInputController.m: (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::hasSpellingMarker):
- 4:42 AM Changeset in webkit [69951] by
-
- 3 edits in trunk/WebKitTools
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
commit-queue's flaky test notice is very Pythony
https://bugs.webkit.org/show_bug.cgi?id=47790
This patch make the list of tests delimted by \n instead of just
converting the array to a string.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 3:42 AM Changeset in webkit [69950] by
-
- 2 edits in trunk/LayoutTests
2010-10-18 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skip another mathml flaky test, check bug:
https://bugs.webkit.org/show_bug.cgi?id=47727
- platform/gtk/Skipped:
- 3:39 AM Changeset in webkit [69949] by
-
- 2 edits in trunk/WebCore
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Build fix.
- inspector/InspectorResourceAgent.cpp: (WebCore::cachedResourceTypeString):
- 3:14 AM Changeset in webkit [69948] by
-
- 27 edits1 add in trunk
2010-10-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
fill network panel with data.
https://bugs.webkit.org/show_bug.cgi?id=47779
InspectorResourceAgent instance / JS part are introduced in this patch. Agent's lifetime is equal
to the front-end's. This new resource agent does not have state, instead it covers two functions:
1) forwards loader client messages to the front-end 2) is capable of building a tree of cached resources.
(1) feeds network panel with data, (2) shows the resource tree in the new ResourcesPanel concept.
This bug is for extracting this new InspectorResourceAgent class and its javascript counterpart.
Once resources panel is refactored for the new concept, InspectorResource, InspectorController's
resource-related routines, inspector.js's code dealing with resources, they all will be gone.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse): (WebCore::cachedResourceType): (WebCore::InspectorResource::type): (WebCore::InspectorResource::sourceString): (WebCore::InspectorResource::sourceBytes): (WebCore::InspectorResource::endTiming):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::resourceContentBase64): (WebCore::InspectorResourceAgent::resourceData): (WebCore::InspectorResourceAgent::cachedResource): (WebCore::buildObjectForHeaders): (WebCore::buildObjectForTiming): (WebCore::buildObjectForResourceRequest): (WebCore::buildObjectForResourceResponse): (WebCore::buildObjectForMainResource): (WebCore::cachedResourceTypeString): (WebCore::buildObjectForCachedResource): (WebCore::buildObjectForFrameResources): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::identifierForInitialRequest): (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::markResourceAsCached): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::didFailLoading): (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): (WebCore::InspectorResourceAgent::setOverrideContent): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::createReadableStringFromBinary): (WebCore::InspectorResourceAgent::didCreateWebSocket): (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorResourceAgent::didCloseWebSocket): (WebCore::InspectorResourceAgent::cachedResources): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
- inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetResourceContent):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get responseReceivedTime): (WebInspector.Resource.prototype.set endTime):
- inspector/front-end/Settings.js:
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: (.tabbed-pane-header li):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse):
2010-10-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
fill network panel with data.
https://bugs.webkit.org/show_bug.cgi?id=47779
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didReceiveResponse):
- 2:18 AM Changeset in webkit [69947] by
-
- 11 edits in trunk
2010-10-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: brush up URL parsing on the front-end.
https://bugs.webkit.org/show_bug.cgi?id=47772
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.getDomainToResourcesMap): (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun): (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun): (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies): (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
- inspector/front-end/DOMAgent.js: (WebInspector.Cookies.cookieMatchesResourceURL):
- inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.set url): (WebInspector.Resource.prototype.get displayName):
- inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory.prototype.addResource):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.updateResource): (WebInspector.linkifyStringAsFragment): (WebInspector.resourceURLForRelatedNode): (WebInspector.completeURL):
- inspector/front-end/utilities.js: (String.prototype.asParsedURL):
- 1:15 AM Changeset in webkit [69946] by
-
- 3 edits in trunk/WebCore
2010-10-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Support custom open() verbs/methods in XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=40476
Fall back to QNetworkAccessManager::CustomOperation for any HTTP verb
that's not specifically supported by QNetworkAccessManager.
This prevents the infinite loop that otherwise occurs after sending
an UnknownOperation request.
This change is covered by existing (skipped) tests that will be
unskipped once the Qt bots are running Qt 4.7.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::httpMethod): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- platform/network/qt/QNetworkReplyHandler.h:
- 12:53 AM Changeset in webkit [69945] by
-
- 5 edits in trunk/LayoutTests
2010-10-18 Adam Barth <abarth@webkit.org>
Add more Skipped list entries because WebP requires an external decoder
library.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 12:39 AM Changeset in webkit [69944] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Csaba Osztrogonác.
Build broken with JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=47801
This is a regression caused by r69940.
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolveBase):
- 12:25 AM Changeset in webkit [69943] by
-
- 2 edits in trunk/JavaScriptCore
Change FastAllocBase implementation into a macro
https://bugs.webkit.org/show_bug.cgi?id=42998
Reviewed by Darin Adler.
It was investigated in bug #33896 that inheriting classes from FastAllocBase
can result in objects getting larger which leads to memory regressions.
Using a macro instead of inheriting classes from FastAllocBase would solve the issue.
- wtf/FastAllocBase.h: Add a WTF_MAKE_FAST_ALLOCATED macro
