⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 8, 2010:

11:48 PM Changeset in webkit [71610] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-11-08 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Convert to and from DOMTimeStamp with converter functions
​https://bugs.webkit.org/show_bug.cgi?id=49066

  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::triggeringEventTime):
11:07 PM Changeset in webkit [71609] by rniwa@webkit.org
  • 67 edits
    1 add in trunk/LayoutTests

2010-11-08 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium rebaselines for r71465.

  • platform/chromium-linux/editing/pasteboard/4806874-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4806874-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/input-field-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-linux/editing/selection/4397952-expected.checksum:
  • platform/chromium-linux/editing/selection/4397952-expected.png:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.checksum:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.png:
  • platform/chromium-linux/editing/selection/click-start-of-line-expected.checksum:
  • platform/chromium-linux/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.checksum:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
  • platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
  • platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-linux/fast/text/delete-hard-break-character-expected.checksum:
  • platform/chromium-linux/fast/text/delete-hard-break-character-expected.png:
  • platform/chromium-win/editing/pasteboard/4806874-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4806874-expected.png:
  • platform/chromium-win/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-win/editing/selection/4397952-expected.checksum:
  • platform/chromium-win/editing/selection/4397952-expected.png:
  • platform/chromium-win/editing/selection/after-line-break-expected.txt: Added.
  • platform/chromium-win/editing/selection/caret-before-select-expected.checksum:
  • platform/chromium-win/editing/selection/caret-before-select-expected.png:
  • platform/chromium-win/editing/selection/click-start-of-line-expected.checksum:
  • platform/chromium-win/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-win/editing/selection/select-element-paragraph-boundary-expected.checksum:
  • platform/chromium-win/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/chromium-win/fast/text/delete-hard-break-character-expected.checksum:
  • platform/chromium-win/fast/text/delete-hard-break-character-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/editing/pasteboard/4806874-expected.checksum:
  • platform/mac/editing/pasteboard/4806874-expected.png:
  • platform/mac/editing/pasteboard/4944770-1-expected.checksum:
  • platform/mac/editing/pasteboard/4944770-1-expected.png:
  • platform/mac/editing/pasteboard/input-field-1-expected.checksum:
  • platform/mac/editing/pasteboard/input-field-1-expected.png:
  • platform/mac/editing/selection/4397952-expected.checksum:
  • platform/mac/editing/selection/4397952-expected.png:
  • platform/mac/editing/selection/caret-before-select-expected.checksum:
  • platform/mac/editing/selection/caret-before-select-expected.png:
  • platform/mac/editing/selection/extend-by-word-002-expected.checksum:
  • platform/mac/editing/selection/extend-by-word-002-expected.png:
  • platform/mac/editing/selection/select-element-paragraph-boundary-expected.checksum:
  • platform/mac/editing/selection/select-element-paragraph-boundary-expected.png:
11:02 PM Changeset in webkit [71608] by commit-queue@webkit.org
  • 10 edits in trunk

2010-11-08 James Simonsen <​simonjam@chromium.org>

Reviewed by Dimitri Glazkov.

[Web Timing] Split domContentLoaded into start/end
​https://bugs.webkit.org/show_bug.cgi?id=48920

  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingOnDOMContentLoaded): Added. (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-document-open-expected.txt:
  • fast/dom/webtiming-expected.txt:

2010-11-08 James Simonsen <​simonjam@chromium.org>

Reviewed by Dimitri Glazkov.

[Web Timing] Split domContentLoaded into start/end
​https://bugs.webkit.org/show_bug.cgi?id=48920

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
  • dom/DocumentTiming.h: (WebCore::DocumentTiming::DocumentTiming):
  • page/Timing.cpp: (WebCore::Timing::domContentLoadedStart): (WebCore::Timing::domContentLoadedEnd):
  • page/Timing.h:
  • page/Timing.idl:
10:19 PM Changeset in webkit [71607] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-11-08 Adam Barth <​abarth@webkit.org>

Update help text to match behavior change.

  • code-review.js:
10:15 PM Changeset in webkit [71606] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-11-08 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Call ApplicationCacheHost::maybeLoadResource() in
ResourceLoader::start() instead of ResourceLoader::load().
maybeLoadResource() might mutate the ResourceRequest, and
in its current location any modifications are lost.

​https://bugs.webkit.org/show_bug.cgi?id=49221

Fixes a couple of http/tests/appcache tests
failing on chromium.

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::start):
9:23 PM Changeset in webkit [71605] by chang.shu@nokia.com
  • 4 edits in trunk

2010-11-08 Chang Shu <​chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Unskip test that is passing now.
​https://bugs.webkit.org/show_bug.cgi?id=49150

  • platform/gtk/Skipped:

2010-11-08 Chang Shu <​chang.shu@nokia.com>

Reviewed by Antonio Gomes.

[GTK] Use Space to toggle arrow key handling for selection change or
spatial navigation. Put the logic in common code to pass both Qt and
GTK. Mac won't work because arrow keys trigger the popup.
​https://bugs.webkit.org/show_bug.cgi?id=49150

Existing test: fast/events/spatial-navigation/snav-single-select.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
9:05 PM Changeset in webkit [71604] by commit-queue@webkit.org
  • 7 edits in trunk

2010-11-08 Nicolas Dufresne <​nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Link with target name set does not work
​https://bugs.webkit.org/show_bug.cgi?id=48865

When a new page is created with a name (target=myFrame), the new
mainFrame could not be found because they where not stored in the
same PageGroup. As PageGroup are not exposed externally so the
simpliest solution is to use a global page group name. This also fixes
issue with visited link coloration across pages. After this change the
private function webkit_web_view_set_group_name() was no longer used
so it was removed completly.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_init):

2010-11-08 Nicolas Dufresne <​nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Link with target name set does not work
​https://bugs.webkit.org/show_bug.cgi?id=48865

When a new page is created with a name (target=myFrame), the new
mainFrame could not be found because they where not stored in the
same PageGroup. As PageGroup are not exposed externally so the
simpliest solution is to use a global page group name. This also fixes
issue with visited link coloration across pages. After this change the
private function webkit_web_view_set_group_name() was no longer used
so it was removed completly.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView):
8:47 PM Changeset in webkit [71603] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-08 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Pavel Feldman.

_bindResourceURL in ResourceManager.js may not add resource to map
​https://bugs.webkit.org/show_bug.cgi?id=49088

No new tests. pfeldman working on better test harness and tests.

  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype._bindResourceURL):
8:14 PM Changeset in webkit [71602] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk

2010-11-08 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Convert to and from DOMTimeStamp with converter functions.
This is a refactoring only, covered by existing layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=49066

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMTimeStamp.h: Added. (WebCore::convertSecondsToDOMTimeStamp): (WebCore::convertDOMTimeStampToSeconds):
  • dom/Event.cpp: (WebCore::Event::Event):
  • dom/Event.h:
  • page/Geolocation.cpp: (WebCore::Geolocation::haveSuitableCachedPosition):
  • platform/android/GeolocationServiceAndroid.cpp: (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):

2010-11-08 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Convert to and from DOMTimeStamp with converter functions
​https://bugs.webkit.org/show_bug.cgi?id=49066

  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::triggeringEventTime):
8:14 PM Changeset in webkit [71601] by rniwa@webkit.org
  • 238 edits in trunk/LayoutTests

2010-11-08 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed. Rebaselines for r71589.

  • platform/chromium-linux/editing/deleting/5156801-2-expected.checksum:
  • platform/chromium-linux/editing/deleting/5156801-2-expected.png:
  • platform/chromium-linux/editing/deleting/delete-3608445-fix-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-linux/editing/deleting/delete-br-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-linux/editing/deleting/delete-br-004-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-linux/editing/deleting/delete-br-005-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-linux/editing/deleting/delete-line-003-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-line-003-expected.png:
  • platform/chromium-linux/editing/deleting/delete-tab-004-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-linux/editing/execCommand/5482023-expected.checksum:
  • platform/chromium-linux/editing/execCommand/5482023-expected.png:
  • platform/chromium-linux/editing/inserting/4960120-2-expected.checksum:
  • platform/chromium-linux/editing/inserting/4960120-2-expected.png:
  • platform/chromium-linux/editing/inserting/5549929-2-expected.checksum:
  • platform/chromium-linux/editing/inserting/5549929-2-expected.png:
  • platform/chromium-linux/editing/inserting/5549929-3-expected.checksum:
  • platform/chromium-linux/editing/inserting/5549929-3-expected.png:
  • platform/chromium-linux/editing/inserting/editable-inline-element-expected.checksum:
  • platform/chromium-linux/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-linux/editing/inserting/insert-3654864-fix-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-3654864-fix-expected.png:
  • platform/chromium-linux/editing/inserting/insert-3775316-fix-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.png:
  • platform/chromium-linux/editing/inserting/insert-3800346-fix-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-004-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-005-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-006-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-007-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-008-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-009-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-at-tabspan-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-at-tabspan-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-at-tabspan-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-linux/editing/inserting/insert-tab-004-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-linux/editing/inserting/line-break-expected.checksum:
  • platform/chromium-linux/editing/inserting/line-break-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-in-table-1-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-linux/editing/inserting/typing-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/typing-003-expected.png:
  • platform/chromium-linux/editing/inserting/typing-around-br-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/4989774-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4989774-expected.png:
  • platform/chromium-linux/editing/pasteboard/5028447-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/5028447-expected.png:
  • platform/chromium-linux/editing/pasteboard/5601583-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-line-endings-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-line-endings-006-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-table-003-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-table-003-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-010-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-010-expected.png:
  • platform/chromium-linux/editing/selection/5007143-2-expected.checksum:
  • platform/chromium-linux/editing/selection/5007143-2-expected.png:
  • platform/chromium-linux/editing/selection/5007143-expected.checksum:
  • platform/chromium-linux/editing/selection/5007143-expected.png:
  • platform/chromium-linux/editing/selection/5234383-2-expected.checksum:
  • platform/chromium-linux/editing/selection/5234383-2-expected.png:
  • platform/chromium-linux/editing/selection/editable-html-element-expected.checksum:
  • platform/chromium-linux/editing/selection/editable-html-element-expected.png:
  • platform/chromium-linux/editing/selection/move-3875618-fix-expected.checksum:
  • platform/chromium-linux/editing/selection/move-3875618-fix-expected.png:
  • platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-character-002-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-linux/editing/selection/move-by-character-003-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-linux/editing/selection/selection-3748164-fix-expected.checksum:
  • platform/chromium-linux/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-linux/editing/unsupported-content/table-delete-001-expected.checksum:
  • platform/chromium-linux/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-linux/editing/unsupported-content/table-delete-003-expected.checksum:
  • platform/chromium-linux/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-win/editing/deleting/5156801-2-expected.checksum:
  • platform/chromium-win/editing/deleting/5156801-2-expected.png:
  • platform/chromium-win/editing/deleting/delete-3608445-fix-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-win/editing/deleting/delete-br-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-win/editing/deleting/delete-br-004-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-win/editing/deleting/delete-br-005-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-win/editing/deleting/delete-line-003-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-line-003-expected.png:
  • platform/chromium-win/editing/deleting/delete-tab-004-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-win/editing/execCommand/5482023-expected.checksum:
  • platform/chromium-win/editing/execCommand/5482023-expected.png:
  • platform/chromium-win/editing/inserting/4960120-2-expected.checksum:
  • platform/chromium-win/editing/inserting/4960120-2-expected.png:
  • platform/chromium-win/editing/inserting/5549929-2-expected.checksum:
  • platform/chromium-win/editing/inserting/5549929-2-expected.png:
  • platform/chromium-win/editing/inserting/5549929-3-expected.checksum:
  • platform/chromium-win/editing/inserting/5549929-3-expected.png:
  • platform/chromium-win/editing/inserting/editable-inline-element-expected.checksum:
  • platform/chromium-win/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-win/editing/inserting/insert-3654864-fix-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-3654864-fix-expected.png:
  • platform/chromium-win/editing/inserting/insert-3775316-fix-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-win/editing/inserting/insert-3786362-fix-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-3786362-fix-expected.png:
  • platform/chromium-win/editing/inserting/insert-3800346-fix-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-001-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-002-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-003-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-004-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-005-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-006-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-008-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-009-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-001-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-win/editing/inserting/insert-tab-004-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-win/editing/inserting/line-break-expected.checksum:
  • platform/chromium-win/editing/inserting/line-break-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-in-table-1-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-win/editing/inserting/typing-003-expected.checksum:
  • platform/chromium-win/editing/inserting/typing-003-expected.png:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.checksum:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-win/editing/pasteboard/4989774-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4989774-expected.png:
  • platform/chromium-win/editing/pasteboard/5028447-expected.checksum:
  • platform/chromium-win/editing/pasteboard/5028447-expected.png:
  • platform/chromium-win/editing/pasteboard/5601583-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-2-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-2-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-table-003-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-table-003-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-010-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-010-expected.png:
  • platform/chromium-win/editing/selection/5007143-2-expected.checksum:
  • platform/chromium-win/editing/selection/5007143-2-expected.png:
  • platform/chromium-win/editing/selection/5007143-expected.checksum:
  • platform/chromium-win/editing/selection/5007143-expected.png:
  • platform/chromium-win/editing/selection/5234383-2-expected.checksum:
  • platform/chromium-win/editing/selection/5234383-2-expected.png:
  • platform/chromium-win/editing/selection/editable-html-element-expected.checksum:
  • platform/chromium-win/editing/selection/editable-html-element-expected.png:
  • platform/chromium-win/editing/selection/extend-selection-expected.txt:
  • platform/chromium-win/editing/selection/move-3875618-fix-expected.checksum:
  • platform/chromium-win/editing/selection/move-3875618-fix-expected.png:
  • platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-character-002-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-win/editing/selection/move-by-character-003-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-win/editing/selection/selection-3748164-fix-expected.checksum:
  • platform/chromium-win/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-win/editing/unsupported-content/table-delete-001-expected.checksum:
  • platform/chromium-win/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-win/editing/unsupported-content/table-delete-003-expected.checksum:
  • platform/chromium-win/editing/unsupported-content/table-delete-003-expected.png:
7:41 PM Changeset in webkit [71600] by kenneth@webkit.org
  • 11 edits in trunk/WebKit2

2010-11-08 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Send page scroll requests to the PageClient when scroll delegation is turned on
​https://bugs.webkit.org/show_bug.cgi?id=49171

Implement the IPC and API required for making scroll delegation work
with WebKit2. This is only used when you have tiling enabled.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::pageDidRequestScroll):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::pageDidRequestScroll):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::delegatedScrollRequested):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::pageDidRequestScroll):
  • WebProcess/WebPage/WebPage.h:
7:24 PM Changeset in webkit [71599] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

<rdar://problem/8531943> Enable partial symbolication for sandbox violations in WebProcess.

Patch by Ivan Krstić <​ike@apple.com> on 2010-11-08
Reviewed by Mark Rowe.

  • WebProcess/com.apple.WebProcess.sb:
7:19 PM Changeset in webkit [71598] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-11-08 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed build fix for Chromium Mac for r71590.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::provideStringAndAttributes):
7:04 PM Changeset in webkit [71597] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-08 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Kent Tamura.

WebViewHost::reset() uses placement new.
​https://bugs.webkit.org/show_bug.cgi?id=49069

WebViewHost is using placement destruction / new to simulate a fresh
WebViewHost object at the same address. This is because the WebView remains
open across tests and maintains a pointer to the WebViewHost.
This change resets member variables explictly instead of the placement new dance.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::WebViewHost): (WebViewHost::reset):
6:48 PM Changeset in webkit [71596] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit2

2010-11-08 Juha Savolainen <​juha.savolainen@weego.fi>

Reviewed by Andreas Kling.

[Qt] Added new methods to QWKHistory and made QWKHistoryItemPrivate to shared object.
​https://bugs.webkit.org/show_bug.cgi?id=49063

Added more functionality to the QWKHistory and changed QWKHistoryItemPrivate to shared object.
This is needed because we cannot delete the QWKHistoryItemPrivate pointer in destructor of QWKHistoryItem,
there may have other history instances which share same private implementation.

  • UIProcess/API/qt/qwkhistory.cpp: (QWKHistoryItemPrivate::~QWKHistoryItemPrivate): (QWKHistoryItem::QWKHistoryItem): (QWKHistoryItem::QWKHistoryItem::operator=): (QWKHistory::currentItem): Added (QWKHistory::backItem): Added (QWKHistory::forwardItem): Added (QWKHistory::itemAt): Added (QWKHistory::backItems): Added (QWKHistory::forwardItems): Added
  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkhistory_p.h:
6:45 PM Changeset in webkit [71595] by rniwa@webkit.org
  • 6 edits
    2 adds
    21 deletes in trunk/LayoutTests

2010-11-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

dump-as-markup conversion: editing/inserting/5607069-2.html and 5607069-3.html
​https://bugs.webkit.org/show_bug.cgi?id=49223

Converted editing/inserting/5607069-2.html and editing/inserting/5607069-3.html
to dump-as-markup tests. Re-enabled them on Qt, Gtk, and Chromium platforms.

  • editing/inserting/5607069-2-expected.txt: Added.
  • editing/inserting/5607069-2.html:
  • editing/inserting/5607069-3-expected.txt: Added.
  • editing/inserting/5607069-3.html:
  • platform/chromium-linux/editing/inserting/5607069-2-expected.checksum: Removed.
  • platform/chromium-linux/editing/inserting/5607069-2-expected.png: Removed.
  • platform/chromium-linux/editing/inserting/5607069-2-expected.txt: Removed.
  • platform/chromium-linux/editing/inserting/5607069-3-expected.checksum: Removed.
  • platform/chromium-linux/editing/inserting/5607069-3-expected.png: Removed.
  • platform/chromium-win/editing/inserting/5607069-2-expected.checksum: Removed.
  • platform/chromium-win/editing/inserting/5607069-2-expected.png: Removed.
  • platform/chromium-win/editing/inserting/5607069-2-expected.txt: Removed.
  • platform/chromium-win/editing/inserting/5607069-3-expected.checksum: Removed.
  • platform/chromium-win/editing/inserting/5607069-3-expected.png: Removed.
  • platform/chromium-win/editing/inserting/5607069-3-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/editing/inserting/5607069-2-expected.checksum: Removed.
  • platform/mac-leopard/editing/inserting/5607069-2-expected.png: Removed.
  • platform/mac-leopard/editing/inserting/5607069-3-expected.checksum: Removed.
  • platform/mac-leopard/editing/inserting/5607069-3-expected.png: Removed.
  • platform/mac/editing/inserting/5607069-2-expected.checksum: Removed.
  • platform/mac/editing/inserting/5607069-2-expected.png: Removed.
  • platform/mac/editing/inserting/5607069-2-expected.txt: Removed.
  • platform/mac/editing/inserting/5607069-3-expected.checksum: Removed.
  • platform/mac/editing/inserting/5607069-3-expected.png: Removed.
  • platform/mac/editing/inserting/5607069-3-expected.txt: Removed.
  • platform/qt/Skipped:
6:32 PM Changeset in webkit [71594] by antonm@chromium.org
  • 6 edits in trunk

2010-11-08 Anton Muhin <​antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Get rid of automatically generated named property getter for classes with namedItem method
​https://bugs.webkit.org/show_bug.cgi?id=48770

  • platform/chromium-mac/fast/dom/HTMLSelectElement/named-options-expected.txt:
  • platform/chromium-win/fast/dom/HTMLSelectElement/named-options-expected.txt:

2010-11-08 Anton Muhin <​antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Get rid of automatically generated named property getter for classes with namedItem method
​https://bugs.webkit.org/show_bug.cgi?id=48770

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
6:15 PM Changeset in webkit [71593] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-11-08 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] build error in WebKit/qt/Api/qwebpage.cpp in Qt 4.7.0
​https://bugs.webkit.org/show_bug.cgi?id=47427

Add a missing guard in order to be able to compile when
ENABLE(TOUCH_EVENTS) is not defined.

  • Api/qwebpage.cpp: (QWebPagePrivate::touchEvent):
6:08 PM Changeset in webkit [71592] by dumi@chromium.org
  • 10 edits
    46 adds in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-linux/editing/selection/home-end-expected.txt: Added.
  • platform/chromium-linux/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/chromium-linux/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-win/editing/selection/home-end-expected.txt:
  • platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
  • platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
  • platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
  • platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
  • platform/chromium-win/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-explicit-embedding-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-override-expected.txt:
  • platform/chromium/test_expectations.txt:
5:54 PM Changeset in webkit [71591] by andersca@apple.com
  • 16 edits
    3 copies
    1 add in trunk/WebKit2

Add WKDownloadClient API
​https://bugs.webkit.org/show_bug.cgi?id=49227

Reviewed by Dan Bernstein.

  • Shared/API/c/WKBase.h:

Add WKDownloadRef.

  • UIProcess/API/C/WKAPICast.h:

Add WKDownloadRef <-> DownloadProxy mapping.

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetDownloadClient):
Initialize the download client.

  • UIProcess/API/C/WKContext.h:

Add new WKContextDownloadClient API.

  • UIProcess/API/C/WKDownload.cpp: Added.
  • UIProcess/API/C/WKDownload.h:

Add WKDownload files.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didStart):
(WebKit::DownloadProxy::didCreateDestination):
(WebKit::DownloadProxy::didFinish):
Call down to the the WebDownloadClient.

  • UIProcess/Downloads/DownloadProxy.messages.in:

Rename DidBegin to DidStart.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeDownloadClient):
Initialize the download client.

  • UIProcess/WebContext.h:

(WebKit::WebContext::downloadClient):
Add getter.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::didStart):
(WebKit::WebDownloadClient::didCreateDestination):
(WebKit::WebDownloadClient::didFinish):
Call the relevant WKContextDownloadClient functions.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::didStart):

  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate downloadDidBegin:]):
Rename Download::didBegin to Download::didStart.

  • win/WebKit2.vcproj:

Add new files.

5:53 PM Changeset in webkit [71590] by commit-queue@webkit.org
  • 7 edits in trunk

2010-11-08 Ned Holbrook <​nholbrook@apple.com>

Reviewed by Adam Barth.

Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
​https://bugs.webkit.org/show_bug.cgi?id=48886

  • WebCore.exp.in:
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::provideStringAndAttributes): (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

2010-11-08 Ned Holbrook <​nholbrook@apple.com>

Reviewed by Adam Barth.

Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
​https://bugs.webkit.org/show_bug.cgi?id=48886

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
5:41 PM Changeset in webkit [71589] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=49228

Reviewed by Simon Fraser.

REGRESSION: caret too short when a positive line height is specified. Now that lineTop no longer
accidentally incorporates the top leading, we need to use selectionTop/Bottom for the caret rect.

  • rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):

5:13 PM Changeset in webkit [71588] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-08 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Rebaesline for GTK after r71566
​https://bugs.webkit.org/show_bug.cgi?id=25321

  • platform/gtk/editing/selection/extend-selection-expected.txt:
5:05 PM Changeset in webkit [71587] by commit-queue@webkit.org
  • 6 edits in trunk

2010-11-08 Pierre-Antoine LaFayette <​pierre.lafayette@gmail.com>

Reviewed by Darin Fisher.

[chromium] Adding hasUserGesture flag to the ResourceRequest
​https://bugs.webkit.org/show_bug.cgi?id=37057

This flag is to be used on the browser side to indicate when a
download has been user initiated.

No new tests. This change will be tested through a browser UI test.

  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::hasUserGesture): (WebCore::ResourceRequest::setHasUserGesture):

2010-11-08 Pierre-Antoine LaFayette <​pierre.lafayette@gmail.com>

Reviewed by Darin Fisher.

[chromium] Adding hasUserGesture flag to the ResourceRequest
​https://bugs.webkit.org/show_bug.cgi?id=37057

This flag is to be used on the browser side to indicate when a
download has been user initiated.

  • public/WebURLRequest.h:
  • src/WebURLRequest.cpp: (WebKit::WebURLRequest::hasUserGesture): (WebKit::WebURLRequest::setHasUserGesture):
4:48 PM Changeset in webkit [71586] by crogers@google.com
  • 5 edits in trunk/WebCore

2010-11-08 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Remove obsolete PASSTHROUGH and MATRIXMIX panner mode
​https://bugs.webkit.org/show_bug.cgi?id=49087

No new tests since audio API is not yet implemented.

  • platform/audio/Panner.cpp: (WebCore::Panner::create):
  • platform/audio/Panner.h:
  • webaudio/AudioPannerNode.h:
  • webaudio/AudioPannerNode.idl:
4:42 PM Changeset in webkit [71585] by beidson@apple.com
  • 19 edits
    2 moves in trunk/WebKit2

Part of ​https://bugs.webkit.org/show_bug.cgi?id=49222
Rename "WebContextMenuItem" to "WebContextMenuItemData"

Reviewed by Anders Carlsson.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • Shared/WebContextMenuItem.cpp: Removed.
  • Shared/WebContextMenuItem.h: Removed.
  • Shared/WebContextMenuItemData.cpp: Copied from Shared/WebContextMenuItem.cpp.

(WebKit::WebContextMenuItemData::WebContextMenuItemData):
(WebKit::WebContextMenuItemData::encode):
(WebKit::WebContextMenuItemData::decode):
(WebKit::kitItems):

  • Shared/WebContextMenuItemData.h: Copied from Shared/WebContextMenuItem.h.

(WebKit::WebContextMenuItemData::submenu):

  • UIProcess/WebContextMenuProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::contextMenuItemSelected):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebContextMenuProxyMac.h:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(-[WebMenuTarget forwardContextMenuAction:]):
(WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::showContextMenu):

  • UIProcess/qt/WebContextMenuProxyQt.h:
  • UIProcess/win/WebContextMenuProxyWin.cpp:

(WebKit::WebContextMenuProxyWin::showContextMenu):

  • UIProcess/win/WebContextMenuProxyWin.h:
  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::itemSelected):

  • WebProcess/WebPage/WebContextMenu.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didSelectItemFromActiveContextMenu):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
4:23 PM Changeset in webkit [71584] by Patrick Gansterer
  • 2 edits
    1 delete in trunk/WebCore

2010-11-08 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Merge EditorWinCE.cpp into EditorWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=49095

  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard):
  • platform/wince/EditorWinCE.cpp: Removed.
4:08 PM Changeset in webkit [71583] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Find in Page: scrolling the page with the scrollbar while overlay is up dismisses the overlay
​https://bugs.webkit.org/show_bug.cgi?id=49219
<rdar://problem/8569550>

Reviewed by John Sullivan and Dan Bernstein.

  • WebProcess/WebPage/FindPageOverlay.cpp:

(WebKit::FindPageOverlay::bounds):
Return the bounds of the find page overlay, excluding any scrollbars.

(WebKit::FindPageOverlay::drawRect):
Call bounds.

(WebKit::FindPageOverlay::mouseEvent):
Only dismiss the find UI if the mouse down event happens inside the overlay bounds.

3:59 PM Changeset in webkit [71582] by hyatt@apple.com
  • 6 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=49217

Reviewed by Simon Fraser.

Fix coordinate space mismatch in RenderReplaced and make sure RenderText retains its old behavior of
preferring later lines when there is overlap.

WebCore:

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint):

  • rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint):

LayoutTests:

  • fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/replace-element.html:
3:52 PM Changeset in webkit [71581] by andersca@apple.com
  • 16 edits
    1 add in trunk/WebKit2

Add the ability to send messages to DownloadProxy objects
​https://bugs.webkit.org/show_bug.cgi?id=49213

Reviewed by Adam Roben.

  • DerivedSources.make:
  • DerivedSources.pro:

Add Download.messages.in.

  • Platform/CoreIPC/MessageID.h:

Add MessageClassDownloadProxy message class.

  • Platform/CoreIPC/MessageSender.h:

Include Connection.h directly since it's required.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didBegin):
(WebKit::DownloadProxy::didCreateDestination):
(WebKit::DownloadProxy::didFinish):
Add stubs.

  • UIProcess/Downloads/DownloadProxy.messages.in: Added.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didReceiveMessage):
Handle DownloadProxy messages.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):
Hand DownloadProxy messages off to the context.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::didBegin):
(WebKit::Download::didReceiveData):
(WebKit::Download::didCreateDestination):
(WebKit::Download::didFinish):
Send messages.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:didCreateDestination:]):
Call Download::didCreateDestination.

  • win/WebKit2.vcproj:

Add new files.

3:36 PM Changeset in webkit [71580] by dpranke@chromium.org
  • 9 edits
    5 adds in trunk/WebKitTools

2010-11-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py.
It turns out that NRWT can't use the code in scm.find_checkout_root()
because the Chromium bots don't do full checkouts of the WebKit
tree; they only check out subdirectories like WebKitTools/Scripts.
Until we can figure out a better approach for this, I've
restored the base_dir-detecting code from NRWT, which works in
any directory tree, scm or no.

This also restores the files modified in r71475 and r71474.

​https://bugs.webkit.org/show_bug.cgi?id=49151

  • WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
  • WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
3:07 PM Changeset in webkit [71579] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/RenderObject.h

Fix build bustage.

2:52 PM Changeset in webkit [71578] by steveblock@google.com
  • 4 edits in trunk/WebCore

2010-11-08 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

Building for Android generates several compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=49175

Fixes these warnings, most of which are trivial.

No new tests, fixes compile warnings only.

  • WebCorePrefix.h:
  • bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue):
  • platform/android/FileSystemAndroid.cpp: (WebCore::listDirectory):
2:52 PM Changeset in webkit [71577] by noam.rosenthal@nokia.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed bot fix.

Removed a test that was added without results. Will add again later.

  • compositing/layer-creation/many-layers.html: Removed.
2:48 PM Changeset in webkit [71576] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/8119781> Crash zooming into Word document at office.live.com
​https://bugs.webkit.org/show_bug.cgi?id=49203

Reviewed by Darin Adler.

WebCore:

Test: fast/css/zoom-change-triggering-layout.html

RenderBox::styleDidChange() was calling scrollLeft() and scrollTop(), whose RenderTextControlSingleLine
overrides can trigger layout.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange): Use the layer directly for updating the scroll offsets when
the zoom factor changes.

LayoutTests:

  • fast/css/zoom-change-triggering-layout-expected.txt: Added.
  • fast/css/zoom-change-triggering-layout.html: Added.
2:43 PM Changeset in webkit [71575] by Csaba Osztrogonác
  • 1 edit
    2 moves in trunk/LayoutTests

Unreviewed rolling out r71567.

r71567 was incorrect, because fast/js/navigator-mimeTypes-length.html contains relative paths to js files.

  • fast/js/navigator-mimeTypes-length-expected.txt: Copied from LayoutTests/plugins/navigator-mimeTypes-length-expected.txt.
  • fast/js/navigator-mimeTypes-length.html: Copied from LayoutTests/plugins/navigator-mimeTypes-length.html.
  • plugins/navigator-mimeTypes-length-expected.txt: Removed.
  • plugins/navigator-mimeTypes-length.html: Removed.
2:39 PM Changeset in webkit [71574] by andersca@apple.com
  • 9 edits
    2 copies
    1 add in trunk/WebKit2

Add DownloadProxy object
​https://bugs.webkit.org/show_bug.cgi?id=49211

Reviewed by Adam Roben.

DownloadProxy will be the implementation of the forthcoming WKDownloadRef object.

  • Shared/APIObject.h:

Add TypeDownload.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::generateDownloadID):
Generate a unique download ID.

(WebKit::DownloadProxy::invalidate):
Null out the web context.

  • UIProcess/Downloads/DownloadProxy.h:

(WebKit::WebContext::processDidClose):
Invalidate all downloads.

(WebKit::WebContext::createDownloadProxy):
Create a WebDownload object.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
Call createDownloadProxy instead.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

  • win/WebKit2Common.vsprops:

Add new include path.

2:28 PM Changeset in webkit [71573] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-08 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations update.

Add a test missing results to chromium-gpu test expectations.

  • platform/chromium-gpu/test_expectations.txt:
2:21 PM Changeset in webkit [71572] by hyatt@apple.com
  • 4 edits
    12 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=48587

Reviewed by Simon Fraser.

Make Ruby work with vertical text. Ruby already nearly does work. The only big issue I found was with
flipped lines writing modes. Make sure to mutate the writing-mode of the RenderRubyRun to ensure that
the ruby text is on the correct side of the ruby base.

Added fast/blockflow tests of the various writing modes.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::staticCreateRubyRun):

LayoutTests:

  • fast/blockflow/japanese-ruby-horizontal-bt.html: Added.
  • fast/blockflow/japanese-ruby-vertical-lr.html: Added.
  • fast/blockflow/japanese-ruby-vertical-rl.html: Added.
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
2:19 PM Changeset in webkit [71571] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-11-08 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch failure-reason explodes if a build is missing
​https://bugs.webkit.org/show_bug.cgi?id=49195

This is likely a recent regression. Adding a unit test for this case.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
2:18 PM Changeset in webkit [71570] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-11-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Restore normal meaning of double-click on patch review page?
​https://bugs.webkit.org/show_bug.cgi?id=47641

After this patch, you need to click on the line numbers to add a
comment.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
2:10 PM Changeset in webkit [71569] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

Unreviewed build correction after @70369/@70846.

Please use PLATFORM(CG) to define CG-specific code, not
PLATFORM(CF).

  • platform/image-decoders/ImageDecoder.cpp:
  • platform/image-decoders/ImageDecoder.h:
1:52 PM Changeset in webkit [71568] by jamesr@google.com
  • 3 edits
    2 adds in trunk

2010-11-08 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Input element with inner spin button set to display:none causes crash
​https://bugs.webkit.org/show_bug.cgi?id=49121

Adds a test for dispatching mouse events at an <input type="number"> with
the inner spin button set to display:none does not crash.

  • fast/forms/input-number-spinbutton-crash-expected.txt: Added.
  • fast/forms/input-number-spinbutton-crash.html: Added.

2010-11-08 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Input element with inner spin button set to display:none causes crash
​https://bugs.webkit.org/show_bug.cgi?id=49121

Null check the inner spin button's renderer before dereferencing it.

Test: fast/forms/input-number-spinbutton-crash.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::forwardEvent):
1:41 PM Changeset in webkit [71567] by tony@chromium.org
  • 1 edit
    2 moves in trunk/LayoutTests

2010-11-08 Tony Chang <​tony@chromium.org>

Unreviewed. Moving a plugin test into the plugins directory.

  • plugins/navigator-mimeTypes-length-expected.txt: Renamed from LayoutTests/fast/js/navigator-mimeTypes-length-expected.txt.
  • plugins/navigator-mimeTypes-length.html: Renamed from LayoutTests/fast/js/navigator-mimeTypes-length.html.
1:35 PM Changeset in webkit [71566] by xji@chromium.org
  • 13 edits
    4 adds in trunk

2010-11-08 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Fix Unicode explicit bidi control characters are removed in editing operations,
such as insert/copy/cut/paste.
​https://bugs.webkit.org/show_bug.cgi?id=25321

Unicode explicit bidi control characters were excluded in BidiRun and
consequently from InlineTextBoxes due to their effect on rendering complex
text with ATSUI.
The fix is including those characters in BidiRun and remove them from
ComplexTextRun with ATSUI.

Test: editing/inserting/insert-paste-bidi-control.html

fast/text/atsui-bidi-control.html

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
  • platform/text/BidiResolver.h: (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::createBidiRunsForLine):

2010-11-08 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Fix Unicode explicit bidi control characters are removed in editing operations,
such as insert/copy/cut/paste.
​https://bugs.webkit.org/show_bug.cgi?id=25321

Unicode explicit bidi control characters were excluded in BidiRun and
consequently from InlineTextBoxes due to their effect on rendering complex
text with ATSUI.
The fix is including those characters in BidiRun and remove them from
ComplexTextRun with ATSUI.

  • editing/inserting/insert-paste-bidi-control-expected.txt: Added.
  • editing/inserting/insert-paste-bidi-control.html: Added.
  • editing/selection/extend-selection-expected.txt:
  • editing/selection/home-end-expected.txt:
  • fast/text/atsui-bidi-control-expected.txt: Added.
  • fast/text/atsui-bidi-control.html: Added.
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
  • platform/mac/fast/text/international/bidi-explicit-embedding-expected.txt:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/fast/text/international/bidi-override-expected.txt:
1:21 PM Changeset in webkit [71565] by ap@apple.com
  • 3 edits in trunk/WebKit2

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=49201
Crash when closing a page

Handle null frame by passing a 0 frame id (normal ones start from 1).

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::focusedFrameChanged):
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::focusedFrameChanged):
1:20 PM Changeset in webkit [71564] by Nate Chapin
  • 2 edits in trunk/WebKit/mac

2010-11-08 Nate Chapin <Nate Chapin>

Unreviewed, build fix.

Clumsy typo in r71562.

  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::start):
1:12 PM Changeset in webkit [71563] by hyatt@apple.com
  • 11 edits
    12 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=49126

Reviewed by Dan Bernstein.

RenderBlock::positionForPoint is not writing-mode aware. Patch the function to examine lines in the correct
writing-mode direction. Patched and renamed a number of helpers used by positionForPoint.

Fixed a bug with RenderReplaced's positionForPoint. There was a coordinate space mismatch between what the
function expected (local coordinates) and what was passed in (containing block coords), which meant the function didn't even work.

Fixed a bug with the propagation of selection state on RenderReplaced to its containing block. The bit double propagated
because both the base class function and the derived class function did the propagation, and the setter function did not
do the right thing if this happened.

Patched the localSelectionRect method on RenderReplaced so that selection draws in the right place in all writing modes.

Added new tests of positionForPoint and replaced elements in fast/blockflow.

WebCore:

  • editing/visible_units.cpp:

(WebCore::previousLinePosition):
(WebCore::nextLinePosition):

  • platform/graphics/IntPoint.h:

(WebCore::IntPoint::transpose):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::paint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::positionForPoint):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint):
(WebCore::RenderReplaced::localSelectionRect):
(WebCore::RenderReplaced::setSelectionState):

  • rendering/RenderReplaced.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition):

  • rendering/RootInlineBox.h:

LayoutTests:

  • fast/blockflow/horizontal-bt-replaced-selection.html: Added.
  • fast/blockflow/vertical-lr-replaced-selection.html: Added.
  • fast/blockflow/vertical-rl-replaced-selection.html: Added.
  • platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
  • platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
  • platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
  • platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
  • platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
  • platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
  • platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
  • platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
  • platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
1:01 PM Changeset in webkit [71562] by Nate Chapin
  • 28 edits
    2 adds in trunk

2010-11-08 Nate Chapin <Nate Chapin>

Reviewed by Alexey Proskuryakov.

Move connection-per-host counting and request prioritization out
of Loader and down to the ResourceLoader level.

​https://bugs.webkit.org/show_bug.cgi?id=27165

Refactor only, so no new tests.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::suspendPostAttachCallbacks): (WebCore::ContainerNode::resumePostAttachCallbacks):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::loadNow):
  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::create):
  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoadScheduler.cpp: Added. (WebCore::ResourceLoadScheduler::hostForURL): (WebCore::resourceLoadScheduler): Returns the single ResourceLoadScheduler instance (WebCore::ResourceLoadScheduler::ResourceLoadScheduler): (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): (WebCore::ResourceLoadScheduler::schedulePluginStreamLoad): (WebCore::ResourceLoadScheduler::addMainResourceLoad): (WebCore::ResourceLoadScheduler::scheduleLoad): (WebCore::ResourceLoadScheduler::remove): (WebCore::ResourceLoadScheduler::crossOriginRedirectReceived): (WebCore::ResourceLoadScheduler::servePendingRequests): (WebCore::ResourceLoadScheduler::suspendPendingRequests): (WebCore::ResourceLoadScheduler::resumePendingRequests): (WebCore::ResourceLoadScheduler::scheduleServePendingRequests): (WebCore::ResourceLoadScheduler::requestTimerFired): (WebCore::ResourceLoadScheduler::assertLoaderBeingCounted): (WebCore::ResourceLoadScheduler::HostInformation::assertLoaderBeingCounted): (WebCore::ResourceLoadScheduler::HostInformation::HostInformation): (WebCore::ResourceLoadScheduler::HostInformation::~HostInformation): (WebCore::ResourceLoadScheduler::HostInformation::schedule): (WebCore::ResourceLoadScheduler::HostInformation::addLoadInProgress): (WebCore::ResourceLoadScheduler::HostInformation::remove): (WebCore::ResourceLoadScheduler::HostInformation::hasRequests):
  • loader/ResourceLoadScheduler.h: Added. (WebCore::ResourceLoadScheduler::HostInformation::name): (WebCore::ResourceLoadScheduler::HostInformation::limitRequests): (WebCore::ResourceLoadScheduler::HostInformation::requestsPending):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources): Remove this from ResourceLoadScheduler's counting. (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::start): Create the ResourceHandle, called by ResourceLoadScheduler. (WebCore::ResourceLoader::willSendRequest): Ensure ResourceLoadScheduler counts redirects

correctly.

  • loader/ResourceLoader.h: (WebCore::ResourceLoader::url):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading):
  • loader/loader.cpp: Move scheduling to ResourceLoadScheduler, remove Host subclass

and make Loader the SubresourceLoaderClient instead.

(WebCore::determinePriority):
(WebCore::Loader::load): Schedule the creation of the ResourceHandle, rather than

doing it immediately.

(WebCore::Loader::cancelRequests):
(WebCore::Loader::didFinishLoading):
(WebCore::Loader::didFail):
(WebCore::Loader::didReceiveResponse):
(WebCore::Loader::didReceiveData):
(WebCore::Loader::didReceiveCachedMetadata):

  • loader/loader.h:
  • page/EventSource.cpp: (WebCore::EventSource::connect): (WebCore::EventSource::endRequest):
  • plugins/PluginStream.cpp: (WebCore::PluginStream::start):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::didFail): (WebCore::XMLHttpRequest::didFinishLoading):
  • xml/XMLHttpRequest.h:
1:00 PM Changeset in webkit [71561] by leandro@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-11-08 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Change the usage of eina_iterator_next due to latest EFL changes.
​https://bugs.webkit.org/show_bug.cgi?id=49082

A change on how the iterator for a tiler is used in EFL needs to be
reflected in WebKit-EFL. The iterator now receives a pointer to an
Eina_Rectangle and makes it point to its internal structure. The old
usage was to receive a reference to a pre-allocated Eina_Rectangle.

  • ewk/ewk_view_single.c: (_ewk_view_single_smart_repaints_process):
12:41 PM Changeset in webkit [71560] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Ignore the system scrollbar setting.

Reviewed by Darin Adler.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues): Set the scrollbar default.

12:32 PM Changeset in webkit [71559] by andersca@apple.com
  • 9 edits in trunk

NPClass::construct and NPClass::invokeDefault never called with out-of-process plug-ins in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=49198

Reviewed by Adam Roben.

WebKit2:

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::invokeDefault):
Call NPClass::invokeDefault.

(WebKit::NPObjectMessageReceiver::construct):
Call NPClass::construct

  • Shared/Plugins/NPObjectMessageReceiver.messages.in:

Add InvokeDefault and Construct messages.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::invokeDefault):
Send the InvokeDefault message.

(WebKit::NPObjectProxy::construct):
Send the Construct message.

(WebKit::NPObjectProxy::NP_InvokeDefault):
Call NPObjectProxy::invokeDefault.

(WebKit::NPObjectProxy::NP_Construct):
Call NPObjectProxy::construct.

LayoutTests:

Remove now passing tests.

  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
12:29 PM Changeset in webkit [71558] by tony@chromium.org
  • 4 edits
    1 copy
    1 move
    2 deletes in trunk/LayoutTests

2010-11-08 Tony Chang <​tony@chromium.org>

Unreviewed, updating plugin expectations.

  • platform/chromium-mac/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
  • platform/chromium-win/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
  • platform/mac-snowleopard/Skipped: Only failing on SL.
  • platform/mac/Skipped:
  • platform/qt/plugins/nested-plugin-objects-expected.txt: Removed.
  • plugins/nested-plugin-objects-expected.txt: Made the main version

have a console error line of 0 since it seems to be a chromium
specific difference.

12:28 PM Changeset in webkit [71557] by jberlin@webkit.org
  • 2 edits in trunk/WebKitSite

We should add a build step to comment out or remove the lines unsetting TEMP and TMP in the
.bashrc file.
​https://bugs.webkit.org/show_bug.cgi?id=49189

Reviewed by Adam Roben.

  • building/tools.html:

Add a line recommending bash shell users to comment out or remove those lines, with an
explanation as to why.

12:15 PM Changeset in webkit [71556] by rniwa@webkit.org
  • 13 edits in trunk/WebCore

2010-11-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Remove the remaining editing-style functions from ApplyStyleCommand
​https://bugs.webkit.org/show_bug.cgi?id=49155

Replaced removeNonEditingProperties, editingStyleAtPosition, prepareEditingStyleToApplyAt,
and removeStylesAddedByNode in ApplyStyleCommand.cpp by removeNonEditingProperties, EditingStyle::create,
prepareToApplyAt, and removeStyleAddedByNode in EditingStyle.cpp.

Also removed unnecessary header includes from various cpp files.

No tests are added since this is a cleanup.

  • editing/ApplyStyleCommand.cpp: Removed removeNonEditingProperties, editingStyleAtPosition, prepareEditingStyleToApplyAt, and removeStylesAddedByNode.
  • editing/ApplyStyleCommand.h: Ditto.
  • editing/DeleteSelectionCommand.cpp: Removed removeEnclosingAnchorStyle. (WebCore::DeleteSelectionCommand::saveTypingStyleState): Calls removeStylesAddedByNode instead.
  • editing/EditingStyle.cpp: (WebCore::copyEditingProperties): Moved and renamed ApplyStyleCommand::removeNonEditingProperties. (WebCore::editingStyleFromComputedStyle): Calls copyEditingProperties. Changed the argument to PassRefPtr as supposed to a raw pointer for convenience. (WebCore::EditingStyle::init): Calls editingStyleFromComputedStyle. (WebCore::EditingStyle::removeStyleAddedByNode): Added. (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added. (WebCore::EditingStyle::removeNonEditingProperties): Added. (WebCore::editingStyleIncludingTypingStyle): Calls copyEditingProperties.
  • editing/EditingStyle.h: Added prototypes.
  • editing/Editor.cpp: (WebCore::Editor::selectionComputedStyle): Uses EditingStyle.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Ditto. (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto.
  • editing/InsertParagraphSeparatorCommand.h:
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::handleStyleSpansBeforeInsertion): Ditto. (WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto. (WebCore::ReplaceSelectionCommand::doApply): Ditto. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
  • editing/ReplaceSelectionCommand.h:
  • editing/markup.cpp: Removed removeEnclosingMailBlockquoteStyle and removeDefaultStyles. (WebCore::createMarkup): Uses EditingStyle.
12:02 PM Changeset in webkit [71555] by dumi@chromium.org
  • 1 edit
    60 adds
    2 deletes in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
  • platform/chromium-mac/svg/custom/polyline-points-crash-expected.txt: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
  • platform/chromium-win/svg/custom/polyline-points-crash-expected.txt: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
11:58 AM Changeset in webkit [71554] by andersca@apple.com
  • 4 edits in trunk

Plug-in views should not assume that plugins are RenderEmbeddedObjects
​https://bugs.webkit.org/show_bug.cgi?id=49196
<rdar://problem/8638467>

Reviewed by Dan Bernstein.

WebKit/mac:

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView pluginHostDied]):

WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginProcessCrashed):

11:47 AM Changeset in webkit [71553] by Simon Fraser
  • 9 edits
    5 adds in trunk

2010-11-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Media objects in nested iframes showing above everything else in TinyMCE
​https://bugs.webkit.org/show_bug.cgi?id=44877

Tests: compositing/iframes/become-composited-nested-iframes.html

compositing/iframes/overlapped-nested-iframes.html

The overlap testing logic that connects compositing across iframe boundaries
needed to be educated about nestd iframes, for platforms (i.e. Mac) where iframes
are allowed to be independently composited.

Also fix a bug that could cause iframes (and possibly other elements) that share
style to fail to become composited.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Disable style sharing for elements that force synethetic style updates in order to gain RenderLayers, so they can become composited. This is tested by become-composited-nested-iframes.html, though it is very timing-dependent.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::hasCompositedContentIncludingDescendants): New method that is a "deep" version of hasCompositedContent() on platforms where that is necessary to ask.

(WebCore::FrameView::hasCompositingAncestor): New method.
(WebCore::FrameView::setIsOverlapped): If we can have independently composited iframes,
we need to force all descendant iframes to update so that compositing gets hooked up across
nested iframes.

(WebCore::FrameView::isOverlappedIncludingAncestors): New method, only called on platforms
where allowsIndependentlyCompositedIFrames() is true.

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::allowsIndependentlyCompositedIFrames): Utility method that returns true if an iframe can be a compositing root.

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Make use of
allowsIndependentlyCompositedIFrames().

(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange): We need to notify all
descendant frames, not just children.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Add assert to ensure that we don't do style sharing for elements that play tricks with synthetic style changes.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Run overlap testing if a frame has any composited descendants.
11:29 AM Changeset in webkit [71552] by tony@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-11-08 Tony Chang <​tony@chromium.org>

Unreviewed, adding qt results for new test (only console line number
is different). Test failing for unknown reasons on mac-- will fix
offline.

  • platform/mac/Skipped:
  • platform/qt/plugins/nested-plugin-objects-expected.txt: Added.
11:26 AM Changeset in webkit [71551] by andersca@apple.com
  • 7 edits in trunk

NPN_Evaluate doesn't work with out-of-process plugins in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=49193

Reviewed by Adam Roben.

WebKit2:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::evaluate):
Send an Evaluate message.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::evaluate):
Call Evaluate on the plug-in proxy.

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:

Add Evaluate message.

LayoutTests:

Remove now passing tests.

  • platform/mac-wk2/Skipped:
11:22 AM Changeset in webkit [71550] by caseq@chromium.org
  • 6 edits in trunk/WebCore

Unreviewed. Rolling back r71506 & r71507, broke inspector/debugger-pause-on-* tests.

11:18 AM Changeset in webkit [71549] by leandro@webkit.org
  • 2 edits in trunk/WebKit

2010-11-08 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed. Build fix after r71496.

  • CMakeLists.txt: Add WebCore/loader/cache directory to WebKit's include directories list.
11:15 AM Changeset in webkit [71548] by ap@apple.com
  • 2 edits in trunk/WebKit/win

Windows build fix.

  • WebCoreSupport/WebChromeClient.h: Added namespace prefix.
11:12 AM Changeset in webkit [71547] by Adam Roben
  • 3 edits in trunk/WebKitTools

Make webkitpy.common.system.executive_unittest pass when running under Win32 Python

Fixes <​http://webkit.org/b/49033>.

Reviewed by Dave Levin and Eric Seidel.

  • Scripts/webkitpy/common/system/executive.py:

(Executive._run_command_with_teed_output): Pass the arguments through
encode_argument_if_needed rather than using Cygwin-specific code here.
(Executive.run_and_throw_if_fail): Use child_process_encoding to decode
the output.
(Executive.run_command): Use encode_argument_if_needed to encode the
arguments and child_process_encoding to decode the output.
(Executive._child_process_encoding): Returns the encoding that should be
used when communicating with child processes. On Windows we use mbcs,
which maps to the current code page. On all other platforms we use
UTF-8.
(Executive._should_encode_child_process_arguments): Returns True if
arguments to child processes need to be encoded. This is currently
only needed on Cygwin and Win32 Python 2.x.
(Executive._encode_argument_if_needed): Encode the argument using
child_process_encoding if we need to encode arguments to child
processes on this platform.

  • Scripts/webkitpy/common/system/executive_unittest.py:

(never_ending_command): Added. Returns arguments to run a command that
will not quit until we kill it. On Windows we use wmic, on other
platforms we use yes.
(ExecutiveTest.test_run_command_with_unicode): Changed to expect the
mbcs encoding to be used and for output from the child processes to
have been roundtripped through encode/decode on Win32 Python. When
UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
it's possible that some characters will not be able to be converted
and will be replaced by question marks; the round-tripping allows us
to expect this result.

(ExecutiveTest.test_kill_process):
(ExecutiveTest.test_kill_all):
Use never_ending_command instead of invoking "yes" directly. Expect an
exit code of 1 when using Win32 Python, as that's what seems to happen.

11:05 AM Changeset in webkit [71546] by andersca@apple.com
  • 8 edits in trunk

Correctly convert NPObjectProxy to NPVariantData
​https://bugs.webkit.org/show_bug.cgi?id=49190

Reviewed by John Sullivan.

WebKit2:

  • Shared/Plugins/NPObjectMessageReceiver.h:

(WebKit::NPObjectMessageReceiver::npObject):
Add NPObject getter.

  • Shared/Plugins/NPObjectProxy.h:

(WebKit::NPObjectProxy::npObjectID):
Add NPObjectID getter.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
Handle the case where the NPObject is an NPObjectProxy.

(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
Handle NPVariantData::LocalNPObjectID.

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::makeRemoteNPObjectID):

  • Shared/Plugins/NPVariantData.h:

New function for creating an NPVariantData that contains a remote NPObject ID.

LayoutTests:

Remove now passing test.

  • platform/mac-wk2/Skipped:
11:04 AM Changeset in webkit [71545] by Adam Roben
  • 5 edits
    2 deletes in trunk

Roll out r71532

It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
.bashrc unsets %TEMP%, which broke copy-tools.cmd.

JavaScriptCore:

WebKitTools:

  • Scripts/webkitdirs.pm:
11:00 AM Changeset in webkit [71544] by Darin Adler
  • 3 edits in trunk
  • fast/images/image-map-multiple-xhtml.xhtml: Fixed this test to check that

map name lookup is case sensitive.

Rubber stamped by Alexey Proskuryakov.

10:50 AM Changeset in webkit [71543] by Darin Adler
  • 5 edits
    4 adds in trunk

2010-11-08 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Incorrect image map used when multiple maps have the same name
​https://bugs.webkit.org/show_bug.cgi?id=49086

Test: fast/images/image-map-multiple.html

Factored out the code used to look up elements by id and reused it
to look up maps by name. It handles multiple elements efficiently.

  • dom/Document.cpp: (WebCore::Document::DocumentOrderedMap::clear): Added. (WebCore::Document::DocumentOrderedMap::add): Added. Has code that was formerly in addElementById. (WebCore::Document::DocumentOrderedMap::remove): Added. Has code that was formerly in removeElementById. (WebCore::Document::DocumentOrderedMap::get): Added. Has code that was formerly in getElementById. (WebCore::keyMatchesId): Added. (WebCore::Document::getElementById): Use DocumentOrderedMap::get. (WebCore::Document::addElementById): Use DocumentOrderedMap::add. (WebCore::Document::removeElementById): Use DocumentOrderedMap::remove. (WebCore::Document::addImageMap): Use DocumentOrderedMap::add. (WebCore::Document::removeImageMap): Use DocumentOrderedMap::remove. (WebCore::keyMatchesMapName): Added. (WebCore::keyMatchesLowercasedMapName): Added. (WebCore::Document::getImageMap): Use DocumentOrderedMap::get.
  • dom/Document.h: Added DocumentOrderedMap class, used inside the Document class. Changed m_imageMapsByName to be a DocumentOrderedMap. Changed m_elementsById to be a DocumentOrderedMap. Eliminated m_duplicateIds, since DocumentOrderedMap now has that internally.

2010-11-08 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Incorrect image map used when multiple maps have the same name
​https://bugs.webkit.org/show_bug.cgi?id=49086

  • fast/images/image-map-multiple-expected.txt: Added.
  • fast/images/image-map-multiple-xhtml-expected.txt: Added.
  • fast/images/image-map-multiple-xhtml.xhtml: Added.
  • fast/images/image-map-multiple.html: Added.
  • fast/images/zoomed-img-size-expected.txt: Removed property svn:executable.
10:36 AM Changeset in webkit [71542] by apavlov@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-08 Alexander Pavlov <​apavlov@chromium.org>

Unreviewed, build fix from commit r71530.

  • fast/css/background-norepeat-crash-expected.txt:
  • fast/css/background-norepeat-crash.html:
10:23 AM Changeset in webkit [71541] by ap@apple.com
  • 42 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=48685
Notify UI process about focused frame

10:19 AM Changeset in webkit [71540] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix.

  • MigrateHeaders.make:
10:16 AM Changeset in webkit [71539] by andersca@apple.com
  • 4 edits in trunk

Remove use of HIGetScaleFactor
​https://bugs.webkit.org/show_bug.cgi?id=49186
<rdar://problem/8618410>

Reviewed by Adam Roben.

Scale factors can vary on a display-by-display basis and it doesn't make sense
to compute scale factor event coordinates like this.

WebCore:

  • plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::globalMousePosForPlugin):

WebKit/mac:

  • Plugins/WebNetscapePluginEventHandlerCarbon.mm:

(getCarbonEvent):

10:04 AM Changeset in webkit [71538] by noam.rosenthal@nokia.com
  • 14 edits
    4 adds in trunk

[Texmap] [Qt] Texture mapper initial implementation
​https://bugs.webkit.org/show_bug.cgi?id=47070

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Make the necessary changes in TextureMapperNode in preparation of making it possible to paint it
from a different thread.
The main problematic part was the cache, which made it so that textures can become invalid and have to
be rerendered from content during paint. This is solved here by creating a pack/unpack function for
textures, which lets a texture archive its data away from video memory, or do whatever the platform
thinks is right for freeing memory without needing to re-render again from content (which cannot be
made thread safe).

After this change, TextureMapperNode moved to its own file, and has 2 entry points: paint and syncCompositingState.
The idea is that syncCompositingState has to be called in the UI thread, paint can be called from a different
thread, and they should block each other.

The new test tests the cache code-path, to show that the pack/unpack technique works for cases where it
kicks in.

Test: compositing/layer-creation/many-layers.html

  • WebCore.pro:
  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::drawTexture):

  • platform/graphics/opengl/TextureMapperGL.h:

(WebCore::TextureMapperGL::create):

  • platform/graphics/qt/TextureMapperQt.cpp:

(WebCore::BitmapTextureQt::pack):
(WebCore::BitmapTextureQt::unpack):
(WebCore::TextureMapper::create):
(WebCore::BitmapTextureQt::BitmapTextureQt):

  • platform/graphics/qt/TextureMapperQt.h: Added.

WebKit/qt:

Reorganized the textureMapper to be a member of QWebFramePrivate, to help with making
TextureMapper thread-safe.

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderCompositedLayers):

  • Api/qwebframe_p.h:
  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PlatformLayerProxyQt::setTextureMapper):
(WebCore::PlatformLayerProxyQt::textureMapper):
(WebCore::PlatformLayerProxyQWidget::PlatformLayerProxyQWidget):
(WebCore::PlatformLayerProxyQGraphicsObject::PlatformLayerProxyQGraphicsObject):

LayoutTests:

Added a test that includes several composited layers, containing pixel data that's larger
than 24MB, which is the default value for TextureMapper's cache. This tests the video memory
ceiling functionality of TextureMapper, as purging that cache would kick in whe running this test.

  • compositing/layer-creation/many-layers.html: Added.
9:56 AM Changeset in webkit [71537] by tony@chromium.org
  • 4 edits
    2 moves in trunk

2010-11-08 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

run platform/chromium/plugins/nested-plugin-objects.html on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=49094

  • plugins/nested-plugin-objects-expected.txt: Renamed from LayoutTests/platform/chromium/plugins/nested-plugin-objects-expected.txt.
  • plugins/nested-plugin-objects.html: Renamed from LayoutTests/platform/chromium/plugins/nested-plugin-objects.html.

2010-11-08 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

run platform/chromium/plugins/nested-plugin-objects.html on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=49094

This tests that objects created by plugins are proplery cleaned up.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (testPassTestObject): (pluginInvoke):
  • DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: (testAllocate): (testDeallocate): (testGetProperty): (testConstruct):
9:48 AM Changeset in webkit [71536] by Simon Fraser
  • 8 edits in trunk

2010-11-08 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Allow applets to participate in accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=49117
<rdar://problem/8625819>

Add RenderApplet to the list of renderers that can optionally get RenderLayers,
and be composited for some reason.

Not currently testable.

  • rendering/RenderApplet.h: Outdented the class declaration.
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::requiresLayer): Return true if the underlying widget has a platform layer. (WebCore::RenderApplet::allowsAcceleratedCompositing): Check the widget to see if it has a platform layer.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): Reformat, and add isApplet(). (WebCore::RenderLayer::isSelfPaintingLayer): Reformat, and add isApplet().
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Use 'renderer' local variable for efficiency. Now check for embedded objects and applets.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingForPlugin): Check for embedded objects and applets.
9:30 AM Changeset in webkit [71535] by Martin Robinson
  • 2 edits in trunk/JavaScriptCore

2010-11-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

=webkitgtk-1.2.5: parallel build fails with libtool: link: cannot find the library libwebkit-1.0.la' or unhandled argument libwebkit-1.0.la'

​https://bugs.webkit.org/show_bug.cgi?id=49128

r59042 introduced a C++-style comment in Platform.h, which is often
included in C source files. Change it to a C-style comment.

  • wtf/Platform.h: Fix the C++-style comment.
9:24 AM Changeset in webkit [71534] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-11-08 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

  • GNUmakefile.am: add missing files to fix distcheck.
9:17 AM Changeset in webkit [71533] by inferno@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-11-08 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Only call WebInspector_syncDispatch if it's actually a function.
​https://bugs.webkit.org/show_bug.cgi?id=49180

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
  • src/WebDevToolsFrontendImpl.h:
9:14 AM Changeset in webkit [71532] by Adam Roben
  • 5 edits
    2 adds in trunk

Show a message and cause the build to immediately fail when any .vsprops files are copied

When $WebKitLibrariesDir is set to a non-standard location, the
.vsprops files have to be copied from WebKitLibraries/win to
$WebKitLibrariesDir. When this happens, Visual Studio doesn't pick up
changes to the .vsprops files until the next time it opens the solution
file. Before this patch, the build would soldier on with the old
.vsprops files, leading to strange build failures. Now we detect that
the .vsprops files have been updated, display a message to the user
telling them what to do, and make the build fail immediately.

Fixes <​http://webkit.org/b/49181> Windows build fail mysteriously when
.vsprops files are updated

Reviewed by Steve Falkenburg.

JavaScriptCore:

Moved code to copy the tools directory to the new copy-tools.cmd
script. Moved that after the command that writes the buildfailed file
so the build will be considered a failure if copy-tools.cmd fails.
Changed to write the project name into buildfailed like all our other
projects do, so those other projects will know that the failure was due
to this project.

Added new scripts.

the tools directory to $WebKitLibrariesDir. If any files were copied,
we display a message to the user and exit with error code 1 to cause
the build to fail. In non-interactive builds, we just print the message
to the build log. In interactive builds, we show the message in an
alert.

Windows Scripting Host to display a message in an alert.

WebKitTools:

Mark Windows builds triggered from Perl as being non-interactive

This affects whether some of our scripts will show alerts vs. printing
to the build log.

  • Scripts/webkitdirs.pm:

(buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.

9:02 AM Changeset in webkit [71531] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add a sometimes-failing test to the Windows Skipped file

  • platform/win/Skipped: Added

animations/stop-animation-on-suspend.html.

8:54 AM Changeset in webkit [71530] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

2010-11-08 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by David Hyatt.

getPropertyValue("background") causes crash
​https://bugs.webkit.org/show_bug.cgi?id=49055

  • fast/css/background-norepeat-crash-expected.txt: Added.
  • fast/css/background-norepeat-crash.html: Added.

2010-11-08 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by David Hyatt.

getPropertyValue("background") causes crash
​https://bugs.webkit.org/show_bug.cgi?id=49055

Test: fast/css/background-norepeat-crash.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
8:48 AM Changeset in webkit [71529] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-11-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] Error page templates are not filled properly
​https://bugs.webkit.org/show_bug.cgi?id=49148

Replace a call to makeString with String::format. This was mistakenly
changed to makeString in an earlier commit.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
8:42 AM Changeset in webkit [71528] by Martin Robinson
  • 4 edits in trunk/WebCore

2010-11-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Wrapped DOM bindings GObjects do not disconnect event listeners when they die
​https://bugs.webkit.org/show_bug.cgi?id=49136

When GObjects are finalized and freed, disconnect their event listeners, so that
WebCore does not try to fire signals on dead GObjects. We do this by holding a weak
reference to the GObject in the signal listener. When the weak reference notification
callback is executed, we disconnect the event listener.

No new tests; this fix is proved by prevention of crashes in soon to be
landed editing delegate signals, which are covered by the layout tests.

  • bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::GObjectEventListener): Updated the constructor. (WebCore::GObjectEventListener::~GObjectEventListener): Disconnect the weak reference if the GObject is still alive. (WebCore::GObjectEventListener::gobjectDestroyed): When the GObject is destroyed, disconnect the appropriate event listener. (WebCore::GObjectEventListener::handleEvent): Changes to reflect use of CString instead of WebCore string.
  • bindings/gobject/GObjectEventListener.h: (WebCore::GObjectEventListener::addEventListener): Changed create to addEventListener, so that the connection and disconnection is an internal contract to the class. (WebCore::GObjectEventListener::gobjectDestroyedCallback): Added.
  • bindings/scripts/CodeGeneratorGObject.pm: Modified the code generate to use GObjectEventListener::addEventListener and no longer call addEventListener on its own.
8:27 AM Changeset in webkit [71527] by Csaba Osztrogonác
  • 3 edits in trunk/WebKitTools

Make http locking default in NRWT.
​https://bugs.webkit.org/show_bug.cgi?id=48053

Patch by Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu> on 2010-11-08
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
8:26 AM Changeset in webkit [71526] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-11-08 Martin Robinson <​mrobinson@igalia.com>

Skip failing tests and rebaseline another test after r71512.

  • platform/gtk/Skipped: Update the skipped list.
  • platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt:
8:25 AM Changeset in webkit [71525] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

2010-11-08 Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[NRWT] If the http lock fails we shouldn't do any locking
​https://bugs.webkit.org/show_bug.cgi?id=49164

If something goes wrong with the locking, the test should keep going.

  • Scripts/webkitpy/layout_tests/port/http_lock.py:
7:50 AM Changeset in webkit [71524] by xan@webkit.org
  • 4 edits in trunk

2010-11-08 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Update version numbers for release.

  • configure.ac:

WebKit/gtk:

2010-11-08 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

  • NEWS: update for release.
7:40 AM Changeset in webkit [71523] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Skip plugins tests on Qt WebKit2 since we do
not have plugin support yet.

Rubber-stamped by Csaba Osztrogonac.

  • platform/qt-wk2/Skipped:
7:30 AM Changeset in webkit [71522] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-08 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations update.

Update chromium-gpu test_expectations after canvas/philip update, and
other fixes.

  • platform/chromium-gpu/test_expectations.txt:
7:19 AM Changeset in webkit [71521] by Adam Roben
  • 2 edits in trunk/WebCore

Windows Release build fix after r71514

The build was failing due to an alignment error. Strangely, depending
on the order of SVGStaticPropertyTearOff's members, the build will
either fail in Release (as it does before this change), or Debug (as it
did before r71514), but not both.

  • svg/properties/SVGStaticPropertyTearOff.h:

(WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff): Copied
the #pragma pack trick from JSSVGPODTypeWrapper.h, which has similar
issues.

7:09 AM Changeset in webkit [71520] by Csaba Osztrogonác
  • 8 edits in trunk/LayoutTests

Unreviewed. Update expectations.

[Qt] DRT sideeffect revealed by r71518
​https://bugs.webkit.org/show_bug.cgi?id=49174

The previous expected results were wrong, because they were modified by this sideeffect.
New results were generated by: WebKitTools/Scripts/run-webkit-tests --reset-results --singly TEST_NAME

  • platform/qt/http/tests/navigation/error404-basic-expected.txt:
  • platform/qt/http/tests/navigation/error404-goback-expected.txt:
  • platform/qt/http/tests/navigation/error404-subframeload-expected.txt:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/qt/http/tests/navigation/postredirect-basic-expected.txt:
  • platform/qt/http/tests/navigation/postredirect-frames-expected.txt:
  • platform/qt/http/tests/navigation/postredirect-goback1-expected.txt:
6:48 AM Changeset in webkit [71519] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected file after r71512.

  • platform/qt/svg/custom/use-property-synchronization-crash-expected.txt: updated.
6:31 AM Changeset in webkit [71518] by Csaba Osztrogonác
  • 120 edits
    1 copy
    264 adds in trunk/LayoutTests

[Qt] Unreviewed. Update/add expectations for passing editing/deleting/* tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/Skipped:
  • platform/qt/editing/deleting/4845371-expected.checksum: Added.
  • platform/qt/editing/deleting/4845371-expected.png: Added.
  • platform/qt/editing/deleting/4845371-expected.txt:
  • platform/qt/editing/deleting/4922367-expected.checksum: Added.
  • platform/qt/editing/deleting/4922367-expected.png: Added.
  • platform/qt/editing/deleting/4922367-expected.txt:
  • platform/qt/editing/deleting/5026848-1-expected.checksum: Added.
  • platform/qt/editing/deleting/5026848-1-expected.png: Added.
  • platform/qt/editing/deleting/5026848-1-expected.txt:
  • platform/qt/editing/deleting/5026848-2-expected.checksum: Added.
  • platform/qt/editing/deleting/5026848-2-expected.png: Added.
  • platform/qt/editing/deleting/5026848-2-expected.txt:
  • platform/qt/editing/deleting/5026848-3-expected.checksum: Added.
  • platform/qt/editing/deleting/5026848-3-expected.png: Added.
  • platform/qt/editing/deleting/5026848-3-expected.txt:
  • platform/qt/editing/deleting/5032066-expected.checksum: Added.
  • platform/qt/editing/deleting/5032066-expected.png: Added.
  • platform/qt/editing/deleting/5032066-expected.txt:
  • platform/qt/editing/deleting/5091898-expected.checksum: Added.
  • platform/qt/editing/deleting/5091898-expected.png: Added.
  • platform/qt/editing/deleting/5091898-expected.txt:
  • platform/qt/editing/deleting/5099303-expected.checksum: Added.
  • platform/qt/editing/deleting/5099303-expected.png: Added.
  • platform/qt/editing/deleting/5099303-expected.txt:
  • platform/qt/editing/deleting/5115601-expected.checksum: Added.
  • platform/qt/editing/deleting/5115601-expected.png: Added.
  • platform/qt/editing/deleting/5115601-expected.txt:
  • platform/qt/editing/deleting/5126166-expected.checksum: Added.
  • platform/qt/editing/deleting/5126166-expected.png: Added.
  • platform/qt/editing/deleting/5126166-expected.txt:
  • platform/qt/editing/deleting/5144139-2-expected.checksum: Added.
  • platform/qt/editing/deleting/5144139-2-expected.png: Added.
  • platform/qt/editing/deleting/5144139-2-expected.txt:
  • platform/qt/editing/deleting/5156801-2-expected.checksum: Added.
  • platform/qt/editing/deleting/5156801-2-expected.png: Added.
  • platform/qt/editing/deleting/5156801-2-expected.txt:
  • platform/qt/editing/deleting/5168598-expected.checksum: Added.
  • platform/qt/editing/deleting/5168598-expected.png: Added.
  • platform/qt/editing/deleting/5168598-expected.txt:
  • platform/qt/editing/deleting/5206311-1-expected.checksum: Added.
  • platform/qt/editing/deleting/5206311-1-expected.png: Added.
  • platform/qt/editing/deleting/5206311-1-expected.txt:
  • platform/qt/editing/deleting/5206311-2-expected.checksum: Added.
  • platform/qt/editing/deleting/5206311-2-expected.png: Added.
  • platform/qt/editing/deleting/5206311-2-expected.txt:
  • platform/qt/editing/deleting/5272440-expected.checksum: Added.
  • platform/qt/editing/deleting/5272440-expected.png: Added.
  • platform/qt/editing/deleting/5272440-expected.txt:
  • platform/qt/editing/deleting/5369009-expected.checksum: Added.
  • platform/qt/editing/deleting/5369009-expected.png: Added.
  • platform/qt/editing/deleting/5369009-expected.txt:
  • platform/qt/editing/deleting/5390681-2-expected.checksum: Added.
  • platform/qt/editing/deleting/5390681-2-expected.png: Added.
  • platform/qt/editing/deleting/5390681-2-expected.txt:
  • platform/qt/editing/deleting/5390681-expected.checksum: Added.
  • platform/qt/editing/deleting/5390681-expected.png: Added.
  • platform/qt/editing/deleting/5433862-2-expected.checksum: Added.
  • platform/qt/editing/deleting/5433862-2-expected.png: Added.
  • platform/qt/editing/deleting/5433862-2-expected.txt: Added.
  • platform/qt/editing/deleting/5483370-expected.checksum: Added.
  • platform/qt/editing/deleting/5483370-expected.png: Added.
  • platform/qt/editing/deleting/5483370-expected.txt: Added.
  • platform/qt/editing/deleting/delete-3608445-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-3608445-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3775172-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-3775172-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-3775172-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3857753-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-3857753-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-3857753-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3865854-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-3865854-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-3865854-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3928305-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-3928305-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-3928305-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3959464-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-3959464-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-3959464-fix-expected.txt:
  • platform/qt/editing/deleting/delete-4038408-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-4038408-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
  • platform/qt/editing/deleting/delete-at-start-or-end-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-start-or-end-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
  • platform/qt/editing/deleting/delete-block-contents-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-contents-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-contents-001-expected.txt:
  • platform/qt/editing/deleting/delete-block-contents-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-contents-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-contents-002-expected.txt:
  • platform/qt/editing/deleting/delete-block-contents-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-contents-003-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-002-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-003-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-004-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-004-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-004-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-005-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-005-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-006-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-006-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-007-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-007-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-008-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-008-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-009-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-009-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-009-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-010-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-010-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-011-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-011-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-011-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-012-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-012-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-013-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-013-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-014-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-014-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-015-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-015-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-016-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-016-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-017-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-017-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-019-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-019-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-020-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-020-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-023-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-023-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-023-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-024-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-024-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-024-expected.txt:
  • platform/qt/editing/deleting/delete-br-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-001-expected.txt:
  • platform/qt/editing/deleting/delete-br-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-002-expected.txt:
  • platform/qt/editing/deleting/delete-br-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-003-expected.txt:
  • platform/qt/editing/deleting/delete-br-004-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-004-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-004-expected.txt:
  • platform/qt/editing/deleting/delete-br-005-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-005-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-005-expected.txt:
  • platform/qt/editing/deleting/delete-br-006-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-006-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-006-expected.txt:
  • platform/qt/editing/deleting/delete-br-008-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-008-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-008-expected.txt:
  • platform/qt/editing/deleting/delete-br-009-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-009-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-009-expected.txt:
  • platform/qt/editing/deleting/delete-br-010-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-010-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-010-expected.txt:
  • platform/qt/editing/deleting/delete-br-011-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-011-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-012-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-012-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-013-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-013-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-013-expected.txt: Added.
  • platform/qt/editing/deleting/delete-br-in-last-table-cell-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-in-last-table-cell-expected.png: Added.
  • platform/qt/editing/deleting/delete-by-word-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-by-word-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-by-word-001-expected.txt:
  • platform/qt/editing/deleting/delete-by-word-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-by-word-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-by-word-002-expected.txt:
  • platform/qt/editing/deleting/delete-character-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-character-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-character-001-expected.txt:
  • platform/qt/editing/deleting/delete-first-list-item-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-first-list-item-expected.png: Added.
  • platform/qt/editing/deleting/delete-first-list-item-expected.txt:
  • platform/qt/editing/deleting/delete-hr-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-hr-expected.png: Added.
  • platform/qt/editing/deleting/delete-hr-expected.txt:
  • platform/qt/editing/deleting/delete-image-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-image-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-image-001-expected.txt:
  • platform/qt/editing/deleting/delete-image-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-image-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-image-002-expected.txt:
  • platform/qt/editing/deleting/delete-image-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-image-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-image-003-expected.txt:
  • platform/qt/editing/deleting/delete-image-004-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-image-004-expected.png: Added.
  • platform/qt/editing/deleting/delete-image-004-expected.txt:
  • platform/qt/editing/deleting/delete-line-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-001-expected.txt:
  • platform/qt/editing/deleting/delete-line-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-002-expected.txt:
  • platform/qt/editing/deleting/delete-line-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-003-expected.txt:
  • platform/qt/editing/deleting/delete-line-004-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-004-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-004-expected.txt:
  • platform/qt/editing/deleting/delete-line-005-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-005-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-005-expected.txt:
  • platform/qt/editing/deleting/delete-line-006-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-006-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-006-expected.txt:
  • platform/qt/editing/deleting/delete-line-007-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-007-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-007-expected.txt:
  • platform/qt/editing/deleting/delete-line-008-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-008-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-008-expected.txt:
  • platform/qt/editing/deleting/delete-line-009-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-009-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-009-expected.txt:
  • platform/qt/editing/deleting/delete-line-010-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-010-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-010-expected.txt:
  • platform/qt/editing/deleting/delete-line-011-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-011-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-011-expected.txt:
  • platform/qt/editing/deleting/delete-line-012-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-012-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-012-expected.txt:
  • platform/qt/editing/deleting/delete-line-013-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-013-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-013-expected.txt:
  • platform/qt/editing/deleting/delete-line-014-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-014-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-014-expected.txt:
  • platform/qt/editing/deleting/delete-line-015-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-015-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-015-expected.txt:
  • platform/qt/editing/deleting/delete-line-016-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-016-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-016-expected.txt:
  • platform/qt/editing/deleting/delete-line-017-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-017-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-017-expected.txt:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-select-all-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-select-all-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-select-all-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-select-all-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-select-all-002-expected.txt:
  • platform/qt/editing/deleting/delete-select-all-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-select-all-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-select-all-003-expected.txt:
  • platform/qt/editing/deleting/delete-selection-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-selection-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-selection-001-expected.txt:
  • platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.png: Added.
  • platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from LayoutTests/platform/qt/editing/deleting/delete-line-009-expected.txt.
  • platform/qt/editing/deleting/delete-to-select-table-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/qt/editing/deleting/delete-to-select-table-expected.txt:
  • platform/qt/editing/deleting/delete-trailing-ws-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-trailing-ws-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-trailing-ws-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/qt/editing/deleting/list-item-1-expected.checksum: Added.
  • platform/qt/editing/deleting/list-item-1-expected.png: Added.
  • platform/qt/editing/deleting/list-item-1-expected.txt:
  • platform/qt/editing/deleting/merge-different-styles-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-different-styles-expected.png: Added.
  • platform/qt/editing/deleting/merge-different-styles-expected.txt:
  • platform/qt/editing/deleting/merge-endOfParagraph-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-endOfParagraph-expected.png: Added.
  • platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
  • platform/qt/editing/deleting/merge-into-empty-block-1-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-into-empty-block-1-expected.png: Added.
  • platform/qt/editing/deleting/merge-into-empty-block-1-expected.txt:
  • platform/qt/editing/deleting/merge-into-empty-block-2-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-into-empty-block-2-expected.png: Added.
  • platform/qt/editing/deleting/merge-into-empty-block-2-expected.txt:
  • platform/qt/editing/deleting/merge-no-br-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-no-br-expected.png: Added.
  • platform/qt/editing/deleting/merge-no-br-expected.txt:
  • platform/qt/editing/deleting/merge-unrendered-space-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-unrendered-space-expected.png: Added.
  • platform/qt/editing/deleting/merge-unrendered-space-expected.txt:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.png: Added.
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/qt/editing/deleting/move-nodes-001-expected.checksum: Added.
  • platform/qt/editing/deleting/move-nodes-001-expected.png: Added.
  • platform/qt/editing/deleting/move-nodes-001-expected.txt:
  • platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.checksum: Added.
  • platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.png: Added.
  • platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.txt:
  • platform/qt/editing/deleting/pruning-after-merge-2-expected.checksum: Added.
  • platform/qt/editing/deleting/pruning-after-merge-2-expected.png: Added.
  • platform/qt/editing/deleting/pruning-after-merge-2-expected.txt:
  • platform/qt/editing/deleting/smart-delete-001-expected.checksum: Added.
  • platform/qt/editing/deleting/smart-delete-001-expected.png: Added.
  • platform/qt/editing/deleting/smart-delete-001-expected.txt:
  • platform/qt/editing/deleting/table-cells-expected.checksum: Added.
  • platform/qt/editing/deleting/table-cells-expected.png: Added.
  • platform/qt/editing/deleting/table-cells-expected.txt:
  • platform/qt/editing/deleting/type-delete-after-quote-expected.checksum: Added.
  • platform/qt/editing/deleting/type-delete-after-quote-expected.png: Added.
  • platform/qt/editing/deleting/type-delete-after-quote-expected.txt: Added.
  • platform/qt/editing/deleting/whitespace-pre-1-expected.checksum: Added.
  • platform/qt/editing/deleting/whitespace-pre-1-expected.png: Added.
  • platform/qt/editing/deleting/whitespace-pre-1-expected.txt:
6:20 AM Changeset in webkit [71517] by Adam Roben
  • 4 edits
    6 adds in trunk/LayoutTests

Update Windows results after r71465

  • platform/win/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/win/fast/blockflow/border-vertical-lr-expected.png:
  • platform/win/fast/blockflow/border-vertical-lr-expected.txt:
  • platform/win/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
  • platform/win/fast/blockflow/japanese-lr-selection-expected.png: Added.
  • platform/win/fast/blockflow/japanese-lr-selection-expected.txt: Added.
  • platform/win/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
  • platform/win/fast/blockflow/japanese-rl-selection-expected.png: Added.
  • platform/win/fast/blockflow/japanese-rl-selection-expected.txt: Added.
6:18 AM Changeset in webkit [71516] by Adam Roben
  • 2 edits in trunk/WebKitTools

Switch back to using kCGImageAlphaPremultipliedFirst when generating pixel dumps on Windows

I changed this behavior in r71418 thinking that it was required for
getting plugins to show up in pixel dumps. But it doesn't seem to be
necessary, and was making it impossible to compare new Windows pixel
dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
compare an image with alpha to an image without alpha).

Fixes <​http://webkit.org/b/49172> REGRESION (r71418): Can't compare
new Windows pixel results to existing Windows or Mac results

Reviewed by Antti Koivisto.

  • DumpRenderTree/win/PixelDumpSupportWin.cpp:

(createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
with kCGImageAlphaPremultipliedFirst.

6:05 AM Changeset in webkit [71515] by yurys@chromium.org
  • 30 edits
    4 copies
    6 moves
    2 deletes in trunk/WebCore

2010-11-08 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: decouple ScriptArguments from ScriptCallStack
​https://bugs.webkit.org/show_bug.cgi?id=48058

ScriptCallFrame and ScriptCallStack are now the same for both JSC and V8.
The factory functions that allow to create ScriptCallStack from VM-specific
objects are defined in ScriptCallStackFactory.cpp.

ScriptArguments class is used for passing arguments from JS code to the native
part.

No new tests. This refactoring is covered with existing Console tests.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profile): (WebCore::JSConsole::profileEnd):
  • bindings/js/ScriptCallStackFactory.cpp: Renamed from WebCore/bindings/js/ScriptCallStack.cpp. (WebCore::createScriptCallStack): (WebCore::createScriptArguments): (WebCore::ScriptCallStack::stackTrace):
  • bindings/js/ScriptCallStackFactory.h: Copied from WebCore/bindings/js/ScriptCallFrame.cpp.
  • bindings/js/ScriptState.cpp: (WebCore::ScriptStateProtectedPtr::~ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get):
  • bindings/js/ScriptState.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::customArgsAndExceptionCallback):
  • bindings/v8/ScriptCallFrame.h: Removed.
  • bindings/v8/ScriptCallStack.h: Removed.
  • bindings/v8/ScriptCallStackFactory.cpp: Renamed from WebCore/bindings/v8/ScriptCallStack.cpp. (WebCore::toScriptCallFrame): (WebCore::toScriptCallFramesVector): (WebCore::createScriptCallStack): (WebCore::createScriptArguments): (WebCore::ScriptCallStack::stackTrace):
  • bindings/v8/ScriptCallStackFactory.h: Copied from WebCore/bindings/js/ScriptCallFrame.cpp.
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
  • bindings/v8/ScriptState.h: (WebCore::ScriptStateProtectedPtr::get):
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler): (WebCore::V8ConsoleMessage::dispatchNow):
  • bindings/v8/V8ConsoleMessage.h:
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::traceCallback): (WebCore::V8Console::assertCallback): (WebCore::V8Console::profileCallback): (WebCore::V8Console::profileEndCallback):
  • dom/NodeFilter.h:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup):
  • inspector/InspectorController.h:
  • inspector/ScriptArguments.cpp: Copied from WebCore/bindings/v8/ScriptCallFrame.cpp. (WebCore::ScriptArguments::ScriptArguments): (WebCore::ScriptArguments::~ScriptArguments): (WebCore::ScriptArguments::argumentAt): (WebCore::ScriptArguments::globalState): (WebCore::ScriptArguments::getFirstArgumentAsString): (WebCore::ScriptArguments::isEqual):
  • inspector/ScriptArguments.h: Copied from WebCore/bindings/js/ScriptCallFrame.h. (WebCore::ScriptArguments::argumentCount):
  • inspector/ScriptCallFrame.cpp: Renamed from WebCore/bindings/v8/ScriptCallFrame.cpp. (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::~ScriptCallFrame): (WebCore::ScriptCallFrame::isEqual): (WebCore::ScriptCallFrame::buildInspectorObject):
  • inspector/ScriptCallFrame.h: Renamed from WebCore/bindings/js/ScriptCallFrame.h. (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber):
  • inspector/ScriptCallStack.cpp: Renamed from WebCore/bindings/js/ScriptCallFrame.cpp. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::isEqual): (WebCore::ScriptCallStack::buildInspectorObject):
  • inspector/ScriptCallStack.h: Renamed from WebCore/bindings/js/ScriptCallStack.h.
  • page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::debug): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::dirxml): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::count): (WebCore::Console::markTimeline): (WebCore::Console::profile): (WebCore::Console::profileEnd): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed): (WebCore::Console::shouldCaptureFullStackTrace): (WebCore::Console::warn):
  • page/Console.h: (WebCore::Console::profiles):
  • page/Console.idl:
6:00 AM Changeset in webkit [71514] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Build fix.


Attempt to fix windows builds after r71512. Swap order of members to avoid warning C4121.

  • svg/properties/SVGStaticPropertyTearOff.h: (WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff):
5:49 AM Changeset in webkit [71513] by mnaganov@chromium.org
  • 2 edits in trunk/WebCore

2010-11-08 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed. Fix Qt build after r71511.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie):
5:43 AM Changeset in webkit [71512] by Nikolas Zimmermann
  • 40 edits
    4 adds
    3 deletes in trunk

2010-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPoint/SVGPointList to the new SVGPropertyTearOff concept
​https://bugs.webkit.org/show_bug.cgi?id=49067

Remove SVGAnimatedPoints interface, not reachable through bindings anyway, it was just another MI interface, that
now has been integrated into SVGPolylineElement/SVGPolygonElement, simplfying the generation and avoiding virtual
calls in SVGPolylineElement/SVGPolygonElement.

Remove the need to use manual XML <-> SVG DOM synchronization. The points/animatedPoints methods now create
SVGListPropertyTearOffs, thus using the same synchronization/expose-to-bindings concept like all other
animated properties.

Convert SVGPoint/SVGPointList to use the new SVGPropertyTearOff concept, adapted all code, as SVGPointList
is now a plain Vector<FloatPoint>. Enable StrictTypeChecking for SVGPoint.

Test: svg/dom/SVGPoint.html

  • Android.derived.v8bindings.mk: Remove SVGAnimatedPoints (and IDL generation).
  • Android.mk: Ditto.
  • CMakeLists.txt: Ditto.
  • DerivedSources.make: Ditto.
  • GNUmakefile.am: Ditto. Add SVGStaticPropertyTearOff.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.order: Remove SVGAnimatedPoints symbols.
  • WebCore.pro: Remove SVGAnimatedPoints (and IDL generation). Add SVGStaticPropertyTearOff.h to build.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/objc/DOMSVG.h: Remove DOMSVGAnimatedPoints include.
  • bindings/scripts/CodeGenerator.pm: Adapt code converting SVGPoint/SVGPointList to use the new SVGPropertyTearOff concepts.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • rendering/SVGRenderTreeAsText.cpp: Adapt for SVGPolyElement API change, use pointList() instead of points() (which is only used for bindings now). (WebCore::operator<<):
  • svg/SVGAllInOne.cpp: Remove SVGAnimatedPoints.cpp.
  • svg/SVGAnimateElement.cpp: Adapt for SVGPointList API change, it's not refcounted anymore. (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGAnimateElement.h: Ditto.
  • svg/SVGAnimatedPoints.cpp: Removed.
  • svg/SVGAnimatedPoints.h: Removed.
  • svg/SVGAnimatedPoints.idl: Removed.
  • svg/SVGParserUtilities.cpp: Adapt for SVGPointList API change, it's not refcounted anymore. (WebCore::pointsListFromSVGData):
  • svg/SVGParserUtilities.h: Ditto.
  • svg/SVGPoint.idl: Remove PODType marker, and add StrictTypeChecking for x/y attributes.
  • svg/SVGPointList.cpp: SVGPointList is now a plain Vector<FloatPoint>, rewrite. (WebCore::SVGPointList::valueAsString): (WebCore::SVGPointList::createAnimated):
  • svg/SVGPointList.h: Ditto. (WebCore::SVGPointList::SVGPointList):
  • svg/SVGPolyElement.cpp: Remove manual SVG <-> XML DOM synchronization. Now handles through the SVGAnimatedPropertyTearOff concept. (WebCore::SVGPolyElement::parseMappedAttribute): (WebCore::SVGPolyElement::svgAttributeChanged): (WebCore::SVGPolyElement::synchronizeProperty): (WebCore::SVGPolyElement::synchronizePoints): (WebCore::SVGPolyElement::points): (WebCore::SVGPolyElement::animatedPoints):
  • svg/SVGPolyElement.h: Reindented. (WebCore::SVGPolyElement::pointList): (WebCore::SVGPolyElement::isValid): (WebCore::SVGPolyElement::supportsMarkers):
  • svg/SVGPolygonElement.cpp: Adapt for SVGPointList API change. (WebCore::SVGPolygonElement::toPathData):
  • svg/SVGPolygonElement.idl: Remove SVGAnimatedPoints inheritance.
  • svg/SVGPolylineElement.cpp: Adapt for SVGPointList API change. (WebCore::SVGPolylineElement::toPathData):
  • svg/SVGPolylineElement.idl: Remove SVGAnimatedPoints inheritance.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentTranslate): Use updateCurrentTranslate(). (WebCore::SVGSVGElement::updateCurrentTranslate): Added, only used by the bindings, after changing a value of SVGStaticPropertyTearOff object.
  • svg/SVGSVGElement.h: (WebCore::SVGSVGElement::currentTranslate): Return reference to m_translation.
  • svg/properties/SVGPropertyTearOff.h: Made constructors protected, as SVGStaticPropertyTearOff inherits from it. (WebCore::SVGPropertyTearOff::commitChange):
  • svg/properties/SVGPropertyTraits.h: Add SVGPointList handing.
  • svg/properties/SVGStaticPropertyTearOff.h: Added. Used for SVGProperty types returned by attributes, that are not associated with a SVGAnimatedProperty. (SVGSVGElement::currentTranslate). (WebCore::SVGStaticPropertyTearOff::create): (WebCore::SVGStaticPropertyTearOff::commitChange): (WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff):

2010-11-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPoint/SVGPointList to the new SVGPropertyTearOff concept
​https://bugs.webkit.org/show_bug.cgi?id=49067

  • platform/mac/svg/custom/use-property-synchronization-crash-expected.txt: Cloned <polyline> now reports parsing problems as well.
  • svg/custom/polyline-points-crash-expected.txt: Update expectation.
  • svg/custom/polyline-points-crash.html: appendItem(null) now throws, catch exception.
  • svg/dom/points-parser.html: Fix failure reporting, use correct variable name.
5:38 AM Changeset in webkit [71511] by mnaganov@chromium.org
  • 10 edits in trunk/WebCore

2010-11-08 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Adam Barth.

Web Inspector [Chromium]: Make CPU profiling to survive navigation.

​https://bugs.webkit.org/show_bug.cgi?id=48843

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::reuseFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
  • inspector/InspectorController.h: (WebCore::InspectorController::startProfiling): (WebCore::InspectorController::stopProfiling):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling): (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.hasTemporaryProfile): (WebInspector.ProfilesPanel.prototype.hasProfile):
  • inspector/front-end/inspector.js: (WebInspector.setRecordingProfile):
3:58 AM Changeset in webkit [71510] by Csaba Osztrogonác
  • 6 edits in trunk

2010-11-08 Csaba Osztrogonac <Csaba Osztrogonác>

Unreviewed, rolling out r71466.
​http://trac.webkit.org/changeset/71466
​https://bugs.webkit.org/show_bug.cgi?id=48865

It broke layout tests on GTK bots.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_init): (webkit_web_view_set_group_name):

2010-11-08 Csaba Osztrogonac <Csaba Osztrogonác>

Unreviewed, rolling out r71466.
​http://trac.webkit.org/changeset/71466
​https://bugs.webkit.org/show_bug.cgi?id=48865

It broke layout tests on GTK bots.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView):
2:50 AM Changeset in webkit [71509] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Enable running of Qt API tests on BuildBot
​https://bugs.webkit.org/show_bug.cgi?id=49004

Patch by Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu> on 2010-11-08
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
2:43 AM Changeset in webkit [71508] by reni@webkit.org
  • 6 edits
    50 adds in trunk

WebCore: SVGFEConvolveMatrixElement doesn't support dynamic invalidation
​https://bugs.webkit.org/show_bug.cgi?id=47660

Patch by Renata Hodovan <​reni@webkit.org> on 2010-11-08
Reviewed by Nikolas Zimmermann.

Wrap orderX and orderY into the common order property according to the w3 standard and remove them from svnattrs.in.
The patch implements the orderXIdentifier and orderYIdentifier getter functions to reach
properly the orderX and orderY components of order property from SVG DOM.

Tests: svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop.html

svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html

  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::orderXIdentifier):
(WebCore::SVGFEConvolveMatrixElement::orderYIdentifier):

  • svg/SVGFEConvolveMatrixElement.h:
  • svg/svgattrs.in:

LayoutTests: SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
​https://bugs.webkit.org/show_bug.cgi?id=47660

Patch by Renata Hodovan <​reni@webkit.org> on 2010-11-08
Reviewed by Nikolas Zimmermann.

This patch contains the SVG DOM dynamic update tests of feConvolveMatrix and it
fixes the DOM test of order attribute because the product of order components should be equal the
size of the kernelMatrix.

  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js:

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-bias-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-divisor-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-in-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop.js: Added.

(SVGNumberListToString):
(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-order-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-targetX-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-targetY-prop.js: Added.

(executeTest):

2:28 AM Changeset in webkit [71507] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-11-08 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: follow up to inspector commit.
​https://bugs.webkit.org/show_bug.cgi?id=49130

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/inspector.css: (.event-bar):
2:12 AM Changeset in webkit [71506] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-11-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add more event listener breakpoint types, add support for regular breakpoint hit state, beautify hit rendering.
​https://bugs.webkit.org/show_bug.cgi?id=49130

  • English.lproj/localizedStrings.js:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.debuggerPaused): (WebInspector.Breakpoint.jsBreakpointId): (WebInspector.Breakpoint.prototype.get id):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/inspector.css: (#elements-sidebar): (.pane > .body): (#scripts-sidebar): (li.breakpoint-hit .breakpoint-hit-marker):
1:36 AM Changeset in webkit [71505] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

Since r71493:r71496, http/tests/misc/prefetch-purpose.html start failing on Mac

  • platform/chromium/test_expectations.txt:
1:12 AM Changeset in webkit [71504] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION (r71465): editing/selection/after-line-break.html fails
​https://bugs.webkit.org/show_bug.cgi?id=49127

  • platform/qt/Skipped: editing/selection/after-line-break.html skipped until fix.
12:59 AM Changeset in webkit [71503] by abarth@webkit.org
  • 8 edits in trunk/WebCore

2010-11-08 Adam Barth <​abarth@webkit.org>

Reviewed by Antti Koivisto.

Rename CachedResourceLoader::m_doc to CachedResourceLoader::m_document
​https://bugs.webkit.org/show_bug.cgi?id=49163

The usual convention is to use "document", not "doc" to refer to the
document.

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::cachedImage):
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::shouldAllowExternalLoad):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::CachedResourceLoader): (WebCore::CachedResourceLoader::frame): (WebCore::CachedResourceLoader::requestImage): (WebCore::CachedResourceLoader::canRequest): (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::printAccessDeniedMessage): (WebCore::CachedResourceLoader::preload): (WebCore::CachedResourceLoader::checkForPendingPreloads): (WebCore::CachedResourceLoader::requestPreload):
  • loader/cache/CachedResourceLoader.h: (WebCore::CachedResourceLoader::document):
  • loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::requestResource):
  • loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail):
  • xml/XSLTProcessorLibxslt.cpp: (WebCore::docLoaderFunc):
12:42 AM Changeset in webkit [71502] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-11-08 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
​https://bugs.webkit.org/show_bug.cgi?id=49160

Bugzilla doesn't automatically remove r? when a bug gets closed.
This script takes care of that for webkit.org.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/tool/commands/upload.py:

Nov 7, 2010:

11:59 PM Changeset in webkit [71501] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-11-07 Adam Barth <​abarth@webkit.org>

Unreviewed. Remove some unneeded includes.

  • loader/FrameLoader.cpp:
  • loader/PlaceholderDocument.cpp:
10:54 PM Changeset in webkit [71500] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium/test_expectations.txt:
10:46 PM Changeset in webkit [71499] by abarth@webkit.org
  • 53 edits
    2 moves in trunk

2010-11-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
​https://bugs.webkit.org/show_bug.cgi?id=49159

  • public/WebCache.h:
  • src/WebCache.cpp: (WebKit::ToResourceTypeStat): (WebKit::WebCache::setCapacities): (WebKit::WebCache::clear): (WebKit::WebCache::getUsageStats): (WebKit::WebCache::getResourceTypeStats):

2010-11-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
​https://bugs.webkit.org/show_bug.cgi?id=49159

  • Api/qwebpage.cpp:
  • Api/qwebsettings.cpp:

2010-11-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
​https://bugs.webkit.org/show_bug.cgi?id=49159

  • webkit/webkitwebview.cpp:

2010-11-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
​https://bugs.webkit.org/show_bug.cgi?id=49159

  • WebCache.cpp: (WebCache::statistics):
  • WebFrame.cpp:
  • WebView.cpp:

2010-11-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
​https://bugs.webkit.org/show_bug.cgi?id=49159

  • WebView.cpp: (wxWebView::SetCachePolicy):
  • WebView.h:

2010-11-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
​https://bugs.webkit.org/show_bug.cgi?id=49159

  • Misc/WebCache.mm: (+[WebCache statistics]):
  • WebCoreSupport/WebDeviceOrientationClient.mm: (WebDeviceOrientationClient::setController):
  • WebView/WebView.mm:

2010-11-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
​https://bugs.webkit.org/show_bug.cgi?id=49159

So sayeth the diagram.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSImageValue.cpp:
  • dom/ContainerNode.cpp:
  • history/PageCache.cpp:
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorResourceAgent.cpp:
  • loader/FrameLoader.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/cache/Cache.cpp: Removed.
  • loader/cache/Cache.h: Removed.
  • loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::allClientsRemoved):
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::destroyDecodedData):
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedScript.cpp: (WebCore::CachedScript::destroyDecodedData):
  • loader/cache/MemoryCache.cpp: Copied from WebCore/loader/cache/Cache.cpp. (WebCore::cache): (WebCore::MemoryCache::MemoryCache): (WebCore::MemoryCache::requestResource): (WebCore::MemoryCache::requestUserCSSStyleSheet): (WebCore::MemoryCache::revalidateResource): (WebCore::MemoryCache::revalidationSucceeded): (WebCore::MemoryCache::revalidationFailed): (WebCore::MemoryCache::resourceForURL): (WebCore::MemoryCache::deadCapacity): (WebCore::MemoryCache::liveCapacity): (WebCore::MemoryCache::pruneLiveResources): (WebCore::MemoryCache::pruneDeadResources): (WebCore::MemoryCache::setCapacities): (WebCore::MemoryCache::makeResourcePurgeable): (WebCore::MemoryCache::evict): (WebCore::MemoryCache::addCachedResourceLoader): (WebCore::MemoryCache::removeCachedResourceLoader): (WebCore::MemoryCache::lruListFor): (WebCore::MemoryCache::removeFromLRUList): (WebCore::MemoryCache::insertInLRUList): (WebCore::MemoryCache::resourceAccessed): (WebCore::MemoryCache::removeFromLiveDecodedResourcesList): (WebCore::MemoryCache::insertInLiveDecodedResourcesList): (WebCore::MemoryCache::addToLiveResourcesSize): (WebCore::MemoryCache::removeFromLiveResourcesSize): (WebCore::MemoryCache::adjustSize): (WebCore::MemoryCache::TypeStatistic::addResource): (WebCore::MemoryCache::getStatistics): (WebCore::MemoryCache::setDisabled): (WebCore::MemoryCache::dumpStats): (WebCore::MemoryCache::dumpLRULists):
  • loader/cache/MemoryCache.h: Copied from WebCore/loader/cache/Cache.h. (WebCore::MemoryCache::shouldMakeResourcePurgeableOnEviction):
  • loader/loader.cpp:
  • page/EventSource.cpp:
  • page/Settings.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest):

2010-11-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
​https://bugs.webkit.org/show_bug.cgi?id=49159

  • WebProcess/WebProcess.cpp:
  • WebProcess/mac/WebProcessMac.mm:
  • WebProcess/win/WebProcessWin.cpp:
9:57 PM Changeset in webkit [71498] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

Add failures for crbug 62298, 62299, 62301

  • platform/chromium/test_expectations.txt:
9:47 PM Changeset in webkit [71497] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-11-07 Eric Seidel <​eric@webkit.org>

Unreviewed. Attempt to fix the windows build.

Move the rest of the cache-related files into loader/cache
​https://bugs.webkit.org/show_bug.cgi?id=49156

  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
9:30 PM Changeset in webkit [71496] by eric@webkit.org
  • 9 edits
    20 moves in trunk

2010-11-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move the rest of the cache-related files into loader/cache
​https://bugs.webkit.org/show_bug.cgi?id=49156

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachePolicy.h: Removed.
  • loader/CachedCSSStyleSheet.cpp: Removed.
  • loader/CachedCSSStyleSheet.h: Removed.
  • loader/CachedFont.cpp: Removed.
  • loader/CachedFont.h: Removed.
  • loader/CachedImage.cpp: Removed.
  • loader/CachedImage.h: Removed.
  • loader/CachedResource.cpp: Removed.
  • loader/CachedResource.h: Removed.
  • loader/CachedResourceClient.h: Removed.
  • loader/CachedResourceClientWalker.cpp: Removed.
  • loader/CachedResourceClientWalker.h: Removed.
  • loader/CachedResourceHandle.cpp: Removed.
  • loader/CachedResourceHandle.h: Removed.
  • loader/CachedResourceLoader.cpp: Removed.
  • loader/CachedResourceLoader.h: Removed.
  • loader/CachedScript.cpp: Removed.
  • loader/CachedScript.h: Removed.
  • loader/CachedXSLStyleSheet.cpp: Removed.
  • loader/CachedXSLStyleSheet.h: Removed.
  • loader/cache/CachePolicy.h: Copied from WebCore/loader/CachePolicy.h.
  • loader/cache/CachedCSSStyleSheet.cpp: Copied from WebCore/loader/CachedCSSStyleSheet.cpp.
  • loader/cache/CachedCSSStyleSheet.h: Copied from WebCore/loader/CachedCSSStyleSheet.h.
  • loader/cache/CachedFont.cpp: Copied from WebCore/loader/CachedFont.cpp.
  • loader/cache/CachedFont.h: Copied from WebCore/loader/CachedFont.h.
  • loader/cache/CachedImage.cpp: Copied from WebCore/loader/CachedImage.cpp.
  • loader/cache/CachedImage.h: Copied from WebCore/loader/CachedImage.h.
  • loader/cache/CachedResource.cpp: Copied from WebCore/loader/CachedResource.cpp.
  • loader/cache/CachedResource.h: Copied from WebCore/loader/CachedResource.h.
  • loader/cache/CachedResourceClient.h: Copied from WebCore/loader/CachedResourceClient.h.
  • loader/cache/CachedResourceClientWalker.cpp: Copied from WebCore/loader/CachedResourceClientWalker.cpp.
  • loader/cache/CachedResourceClientWalker.h: Copied from WebCore/loader/CachedResourceClientWalker.h.
  • loader/cache/CachedResourceHandle.cpp: Copied from WebCore/loader/CachedResourceHandle.cpp.
  • loader/cache/CachedResourceHandle.h: Copied from WebCore/loader/CachedResourceHandle.h.
  • loader/cache/CachedResourceLoader.cpp: Copied from WebCore/loader/CachedResourceLoader.cpp.
  • loader/cache/CachedResourceLoader.h: Copied from WebCore/loader/CachedResourceLoader.h.
  • loader/cache/CachedScript.cpp: Copied from WebCore/loader/CachedScript.cpp.
  • loader/cache/CachedScript.h: Copied from WebCore/loader/CachedScript.h.
  • loader/cache/CachedXSLStyleSheet.cpp: Copied from WebCore/loader/CachedXSLStyleSheet.cpp.
  • loader/cache/CachedXSLStyleSheet.h: Copied from WebCore/loader/CachedXSLStyleSheet.h.
9:03 PM Changeset in webkit [71495] by morrita@google.com
  • 2 edits
    1 delete in trunk/LayoutTests

2010-11-07 MORITA Hajime <​morrita@google.com>

Unreviewed test expectation rebaseline.

  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed. (It's now same as platform/win)
  • platform/chromium/test_expectations.txt:
8:44 PM Changeset in webkit [71494] by abarth@webkit.org
  • 5 edits in trunk

2010-11-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename X-Purpose to Purpose
​https://bugs.webkit.org/show_bug.cgi?id=47802

As requested by IETF HTTP WG. This patch is part of a larger movement
in the HTTP community to move away from X- headers. Various senior
folks at the IETF believe they're a failed experiment:

​http://tools.ietf.org/html/draft-saintandre-xdash-considered-harmful

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):

2010-11-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename X-Purpose to Purpose
​https://bugs.webkit.org/show_bug.cgi?id=47802

Update expected results.

  • http/tests/misc/prefetch-purpose-expected.txt:
  • http/tests/misc/resources/prefetch-purpose.php:
8:32 PM Changeset in webkit [71493] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-11-07 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

Assert that a non-null PassRefPtr<Document> has a non-null frame in Frame::setDocument()
​https://bugs.webkit.org/show_bug.cgi?id=49152

Add an ASSERT to ensure that a non-null Document has a non-null Frame
in Frame::setDocument().

Currently, whenever Frame::setDocument() is called with a non-null
Document the Document has a non-null Frame. We should assert this
invariant.

  • page/Frame.cpp: (WebCore::Frame::setDocument):
8:09 PM Changeset in webkit [71492] by eric@webkit.org
  • 9 edits
    2 moves
    1 add in trunk/WebCore

2010-11-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move Cache.* into loader/cache in as a start to cleaning up loader/
​https://bugs.webkit.org/show_bug.cgi?id=49153

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/Cache.cpp: Renamed from WebCore/loader/Cache.cpp. (WebCore::cache): (WebCore::Cache::Cache): (WebCore::createResource): (WebCore::Cache::requestResource): (WebCore::Cache::requestUserCSSStyleSheet): (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationSucceeded): (WebCore::Cache::revalidationFailed): (WebCore::Cache::resourceForURL): (WebCore::Cache::deadCapacity): (WebCore::Cache::liveCapacity): (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::setCapacities): (WebCore::Cache::makeResourcePurgeable): (WebCore::Cache::evict): (WebCore::Cache::addCachedResourceLoader): (WebCore::Cache::removeCachedResourceLoader): (WebCore::fastLog2): (WebCore::Cache::lruListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): (WebCore::Cache::resourceAccessed): (WebCore::Cache::removeFromLiveDecodedResourcesList): (WebCore::Cache::insertInLiveDecodedResourcesList): (WebCore::Cache::addToLiveResourcesSize): (WebCore::Cache::removeFromLiveResourcesSize): (WebCore::Cache::adjustSize): (WebCore::Cache::TypeStatistic::addResource): (WebCore::Cache::getStatistics): (WebCore::Cache::setDisabled): (WebCore::Cache::dumpStats): (WebCore::Cache::dumpLRULists):
  • loader/cache/Cache.h: Renamed from WebCore/loader/Cache.h. (WebCore::Cache::LRUList::LRUList): (WebCore::Cache::TypeStatistic::TypeStatistic): (WebCore::Cache::loader): (WebCore::Cache::disabled): (WebCore::Cache::setPruneEnabled): (WebCore::Cache::prune): (WebCore::Cache::setDeadDecodedDataDeletionInterval): (WebCore::Cache::deadDecodedDataDeletionInterval): (WebCore::Cache::remove): (WebCore::Cache::shouldMakeResourcePurgeableOnEviction):
7:54 PM Changeset in webkit [71491] by ukai@chromium.org
  • 9 edits in trunk/WebKitTools

2010-11-07 Fumitoshi Ukai <​ukai@chromium.org>

Unreviewed, rolling out r71474.
​http://trac.webkit.org/changeset/71474
​https://bugs.webkit.org/show_bug.cgi?id=48280

breaks chromium webkit tests
​https://bugs.webkit.org/show_bug.cgi?id=49151

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
7:52 PM Changeset in webkit [71490] by ukai@chromium.org
  • 1 edit
    5 deletes in trunk/WebKitTools

2010-11-07 Fumitoshi Ukai <​ukai@chromium.org>

Unreviewed, rolling out r71475.
​http://trac.webkit.org/changeset/71475

breaks chromium webkit tests
​https://bugs.webkit.org/show_bug.cgi?id=49151

  • Scripts/webkitpy/common/newstringio.py: Removed.
  • Scripts/webkitpy/common/newstringio_unittest.py: Removed.
  • Scripts/webkitpy/common/system/executive_mock.py: Removed.
  • Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
  • Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
7:08 PM Changeset in webkit [71489] by andreas.kling@nokia.com
  • 2 edits in trunk/JavaScriptCore

2010-11-07 Sam Magnuson <​smagnuson@netflix.com>

Reviewed by Andreas Kling.

[Qt] make install does not cause JavaScriptCore to be built
​https://bugs.webkit.org/show_bug.cgi?id=49114

6:54 PM Changeset in webkit [71488] by andreas.kling@nokia.com
  • 5 edits in trunk

2010-11-05 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] box-shadow does not blur (is solid) when using border-radius
​https://bugs.webkit.org/show_bug.cgi?id=46327

Implement blurred box-shadow when styling with border-radius.
This change is related to ​https://bugs.webkit.org/show_bug.cgi?id=44488

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRoundedRect):

2010-11-05 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] box-shadow does not blur (is solid) when using border-radius
​https://bugs.webkit.org/show_bug.cgi?id=46327

Implement blurred box-shadow when styling with border-radius.
This change is related to ​https://bugs.webkit.org/show_bug.cgi?id=44488

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
6:31 PM Changeset in webkit [71487] by mdelaney@apple.com
  • 3 edits
    12 adds in trunk/LayoutTests

2010-11-07 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Andreas Kling.

Unskipping recently merged new philip canvas tests from SnowLeopard
​https://bugs.webkit.org/show_bug.cgi?id=49147

  • platform/mac-leopard/Skipped: Moving skipped test list down to leopard.
  • platform/mac-snowleopard/canvas/philip/tests/*: All new tests' expectations.
  • platform/mac/Skipped: Unskipping tests from overall mac.
5:49 PM Changeset in webkit [71486] by andreas.kling@nokia.com
  • 3 edits in trunk/LayoutTests

2010-11-07 Helder Correia <​helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Update the baseline for blur shadow test
​https://bugs.webkit.org/show_bug.cgi?id=48223

Update basic-shadows test expected result with correct line segments.

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
5:14 PM Changeset in webkit [71485] by andreas.kling@nokia.com
  • 3 edits in trunk/LayoutTests

2010-11-07 Andreas Kling <​kling@webkit.org>

Unreviewed, skipping new canvas tests that are failing on Gtk+ and Qt.

Skip the following tests:

  • canvas/philip/tests/security.pattern.canvas.timing.html
  • canvas/philip/tests/security.pattern.create.html
  • canvas/philip/tests/security.pattern.cross.html
  • canvas/philip/tests/security.pattern.image.fillStyle.html
  • canvas/philip/tests/security.pattern.image.strokeStyle.html
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
3:38 PM Changeset in webkit [71484] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2010-11-07 John Reck <​jreck@google.com>

Reviewed by Steve Block.

Implements navigator.language for Android
​https://bugs.webkit.org/show_bug.cgi?id=49099

Android was previously hardcoding the value for WebCore::platformDefaultLanguage().
This patch removes the hardcoding and calls into the PlatformBridge to get the
correct language based off of the user's settings.

No new tests needed, this is already covered

  • Android.mk:
  • platform/android/LanguageAndroid.cpp: Added. (WebCore::platformDefaultLanguage):
  • platform/android/PlatformBridge.h:
  • platform/android/TemporaryLinkStubs.cpp:
7:25 AM Changeset in webkit [71483] by robert@webkit.org
  • 3 edits
    2 adds in trunk

2010-11-07 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[qt] screenDepthPerComponent returns the wrong value

Return best estimate of the number of bits per color
rather than screen depth.

Add a layout test to sanity check screenDepthPerComponent.

​https://bugs.webkit.org/show_bug.cgi?id=20289

  • fast/css/media-rule-screenDepthPerComponent-expected.txt: Added.
  • fast/css/media-rule-screenDepthPerComponent.html: Added.

2010-11-07 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[qt] screenDepthPerComponent returns the wrong value

Return best estimate of the number of bits per color
rather than screen depth.

Add a layout test to sanity check screenDepthPerComponent.

​https://bugs.webkit.org/show_bug.cgi?id=20289

Test: fast/css/media-rule-screenDepthPerComponent.html

  • platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepthPerComponent):
7:02 AM Changeset in webkit [71482] by andreas.kling@nokia.com
  • 52 edits in trunk/LayoutTests

2010-11-07 Andreas Kling <​kling@webkit.org>

Unreviewed, rebaselining failures on Leopard and Snow Leopard after r71481.

  • canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
  • canvas/philip/tests/security.pattern.canvas.timing-expected.txt:
  • canvas/philip/tests/security.pattern.create-expected.txt:
  • canvas/philip/tests/security.pattern.cross-expected.txt:
  • canvas/philip/tests/security.pattern.image.fillStyle-expected.txt:
  • canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.null-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create1.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create2.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.get.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.line.cap.closed-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.line.join.parallel-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.line.miter.lineedge-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.missingargs-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.path.rect.winding-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.broken-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.incomplete-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.blur-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.x-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.y-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.basic-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.basic-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.complex-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.system-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.measure.width.space-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt:
5:49 AM Changeset in webkit [71481] by andreas.kling@nokia.com
  • 1568 edits
    53 adds in trunk/LayoutTests

2010-10-18 Andreas Kling <​kling@webkit.org>

Reviewed by James Robinson.

Update our clone of Philip Taylor's canvas test suite
​https://bugs.webkit.org/show_bug.cgi?id=47707

Source: ​http://dvcs.w3.org/hg/html/file/df23d00a3395/tests/submission/PhilipTaylor

  • canvas/philip/README: Added, contains link to upstream revision.
  • canvas/philip/: Synced with upstream.
  • platform/gtk/Skipped: Skipped new failing tests.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
1:42 AM Changeset in webkit [71480] by jcivelli@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-07 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Kent Tamura.

Fixing a crasher with the select popup on Mac that happens when a
page removes the select node when the select changes.
​https://bugs.webkit.org/show_bug.cgi?id=49108

  • src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::didAcceptIndex): (WebKit::ExternalPopupMenu::didCancel):
1:24 AM Changeset in webkit [71479] by chang.shu@nokia.com
  • 9 edits in trunk

2010-11-07 Chang Shu <​chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Add a helper function to avoid duplicated code.
​https://bugs.webkit.org/show_bug.cgi?id=49085

  • dom/SelectElement.cpp:
  • editing/SelectionController.cpp: (WebCore::SelectionController::modify):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable):
  • page/EventHandler.cpp: (WebCore::EventHandler::defaultArrowEventHandler):
  • page/SpatialNavigation.cpp: (WebCore::isSpatialNavigationEnabled):
  • page/SpatialNavigation.h:

2010-11-07 Chang Shu <​chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Add a helper function to avoid duplicated code.
​https://bugs.webkit.org/show_bug.cgi?id=49085

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
Note: See TracTimeline for information about the timeline view.