⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 2, 2010:

11:44 PM Changeset in webkit [73245] by aa@chromium.org
  • 2 edits in trunk/WebCore

2010-12-02 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Reduce the number of cases where we end up with a stale value for
minimumPreferredLogicalWidth(). This isn't a complete fix, but fixes a
large number of cases.

RenderObject::minimumPreferredLogicalWidth() sometimes reports wrong value.
​https://bugs.webkit.org/show_bug.cgi?id=50119

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange):
11:25 PM Changeset in webkit [73244] by commit-queue@webkit.org
  • 8 edits in trunk/WebCore

2010-12-02 Gregg Tavares <​gman@google.com>

Reviewed by David Levin.

Need to initialize destination variables before calling GL
​https://bugs.webkit.org/show_bug.cgi?id=50048

No new tests because no change in functionality.

  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::initializeRenderbuffers):
  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::cacheActiveAttribLocations):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getAttachedShaders): (WebCore::WebGLRenderingContext::getBufferParameter): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::getBooleanParameter): (WebCore::WebGLRenderingContext::getFloatParameter): (WebCore::WebGLRenderingContext::getLongParameter): (WebCore::WebGLRenderingContext::getUnsignedLongParameter):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::loadShader): (WebCore::LayerChromium::createShaderProgram):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initializeSharedObjects):
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::reset):
  • platform/graphics/gpu/Shader.cpp: (WebCore::Shader::loadProgram):
11:21 PM Changeset in webkit [73243] by abarth@webkit.org
  • 2 edits
    3 copies in branches/chromium/597

Merge 73112 - 2010-12-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Gray-scale JPEG images with a color profile are stretched horizonally
​https://bugs.webkit.org/show_bug.cgi?id=49950

Turns out gray-scale JPEGs with color profiles have the same issue as
PNGs. As with PNGs, we suppress now suppress the color profile for
gray-scale JPEGs. Most importantly, this patch adds a test.

Test: fast/images/gray-scale-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):

2010-12-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Gray-scale JPEG images with a color profile are stretched horizonally
​https://bugs.webkit.org/show_bug.cgi?id=49950

Test that we properly render gray-scale JPEGs with embedded color
profiles.

  • fast/images/gray-scale-jpeg-with-color-profile.html: Added.
  • fast/images/resources/flowchart.jpg: Added.
  • platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Added.

TBR=​abarth@webkit.org
Review URL: ​http://codereview.chromium.org/5635002

11:05 PM Changeset in webkit [73242] by commit-queue@webkit.org
  • 2 edits in trunk

2010-12-02 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Eric Seidel.

[EFL] Fails to build with non-system cairo
​https://bugs.webkit.org/show_bug.cgi?id=50395

Do not add 'cairo' as a suffix for the paths provided by
pkgconfig. The paths provided by pkgconfig already include it.

  • cmake/FindCairo.cmake:
10:49 PM Changeset in webkit [73241] by Laszlo Gombos
  • 6 edits in trunk

2010-12-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Andreas Kling.

[Qt] Enable Web Timing for Qt
​https://bugs.webkit.org/show_bug.cgi?id=42433

  • fast/dom/webtiming-document-open-expected.txt: Add an extra line to the expected results.
  • platform/qt/Skipped: Enable Web Timing tests.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Add webkitPerformance property.

2010-12-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Andreas Kling.

[Qt] Enable Web Timing for Qt
​https://bugs.webkit.org/show_bug.cgi?id=42433

  • features.pri: Enable Web Timing for trunk (but not yet for production)
10:15 PM Changeset in webkit [73240] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-12-02 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Update the EWSTools scripts to use modern-style git repos
​https://bugs.webkit.org/show_bug.cgi?id=50402

  • EWSTools/create-webkit-git:
  • EWSTools/start-commit-queue.sh:
  • EWSTools/start-queue.sh:
9:34 PM Changeset in webkit [73239] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Yuta Kitamura <​yutak@chromium.org>

Unreviewed.

Revert Chromium test expectations updates at r73234 and r73232.
Tests added in these changes are no longer failing.

  • platform/chromium/test_expectations.txt:
9:21 PM Changeset in webkit [73238] by aestes@apple.com
  • 9 edits in trunk/WebCore

Update bindings test results with new GObject results.

Rubber-stamped by Mark Rowe.

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(WebKit::kit):
(webkit_dom_test_obj_obj_method):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_method_that_requires_all_args):
(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_with_script_state_obj):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_get_read_only_test_obj_attr):
(webkit_dom_test_obj_get_test_obj_attr):
(webkit_dom_test_obj_get_xml_obj_attr):

  • bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
8:59 PM Changeset in webkit [73237] by Simon Fraser
  • 15 edits
    1 move
    1 add
    5 deletes in trunk

2010-12-02 Simon Fraser <Simon Fraser>

Revert r73217 and r73227 because of continued bustage.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::nativeLayer):
  • platform/graphics/ca/PlatformCAAnimation.h: Removed.
  • platform/graphics/ca/PlatformCALayer.h: Removed.
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm: Removed.
  • platform/graphics/ca/mac/PlatformCALayerMac.mm: Removed.
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::nativeLayer):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/mac/GraphicsLayerMac.h: Renamed from WebCore/platform/graphics/ca/GraphicsLayerCA.h. (WebCore::GraphicsLayerMac::hasContentsLayer): (WebCore::GraphicsLayerMac::primaryLayer): (WebCore::GraphicsLayerMac::isReplicatedRootClone): (WebCore::GraphicsLayerMac::primaryLayerClones): (WebCore::GraphicsLayerMac::animationIsRunning): (WebCore::GraphicsLayerMac::contentsLayer): (WebCore::GraphicsLayerMac::ReplicaState::ReplicaState): (WebCore::GraphicsLayerMac::ReplicaState::push): (WebCore::GraphicsLayerMac::ReplicaState::setBranchType): (WebCore::GraphicsLayerMac::ReplicaState::pop): (WebCore::GraphicsLayerMac::ReplicaState::depth): (WebCore::GraphicsLayerMac::ReplicaState::replicaDepth): (WebCore::GraphicsLayerMac::hasCloneLayers): (WebCore::GraphicsLayerMac::LayerPropertyAnimation::LayerPropertyAnimation): (WebCore::GraphicsLayerMac::AnimationProcessingAction::AnimationProcessingAction):
  • platform/graphics/mac/GraphicsLayerMac.mm: Renamed from WebCore/platform/graphics/ca/GraphicsLayerCA.cpp. (WebCore::currentTimeToMediaTime): (WebCore::mediaTimeToCurrentTime): (-[WebAnimationDelegate animationDidStart:]): (-[WebAnimationDelegate WebCore::]): (-[WebAnimationDelegate setLayer:WebCore::]): (WebCore::copyTransform): (WebCore::getTransformFunctionValue): (WebCore::getValueFunctionNameForTransformOperation): (WebCore::propertyIdToString): (WebCore::animationIdentifier): (WebCore::getCAMediaTimingFunction): (WebCore::setLayerBorderColor): (WebCore::clearBorderColor): (WebCore::setLayerBackgroundColor): (WebCore::clearLayerBackgroundColor): (WebCore::safeSetSublayers): (WebCore::caValueFunctionSupported): (WebCore::forceSoftwareAnimation): (WebCore::nullActionsDictionary): (WebCore::animationHasStepsTimingFunction): (WebCore::GraphicsLayer::create): (WebCore::GraphicsLayerMac::GraphicsLayerMac): (WebCore::GraphicsLayerMac::~GraphicsLayerMac): (WebCore::GraphicsLayerMac::setName): (WebCore::GraphicsLayerMac::nativeLayer): (WebCore::GraphicsLayerMac::setChildren): (WebCore::GraphicsLayerMac::addChild): (WebCore::GraphicsLayerMac::addChildAtIndex): (WebCore::GraphicsLayerMac::addChildBelow): (WebCore::GraphicsLayerMac::addChildAbove): (WebCore::GraphicsLayerMac::replaceChild): (WebCore::GraphicsLayerMac::removeFromParent): (WebCore::GraphicsLayerMac::setMaskLayer): (WebCore::GraphicsLayerMac::setReplicatedLayer): (WebCore::GraphicsLayerMac::setReplicatedByLayer): (WebCore::GraphicsLayerMac::setPosition): (WebCore::GraphicsLayerMac::setAnchorPoint): (WebCore::GraphicsLayerMac::setSize): (WebCore::GraphicsLayerMac::setTransform): (WebCore::GraphicsLayerMac::setChildrenTransform): (WebCore::GraphicsLayerMac::moveOrCopyLayerAnimation): (WebCore::GraphicsLayerMac::moveOrCopyAnimationsForProperty): (WebCore::GraphicsLayerMac::setPreserves3D): (WebCore::GraphicsLayerMac::setMasksToBounds): (WebCore::GraphicsLayerMac::setDrawsContent): (WebCore::GraphicsLayerMac::setBackgroundColor): (WebCore::GraphicsLayerMac::clearBackgroundColor): (WebCore::GraphicsLayerMac::setContentsOpaque): (WebCore::GraphicsLayerMac::setBackfaceVisibility): (WebCore::GraphicsLayerMac::setOpacity): (WebCore::GraphicsLayerMac::setNeedsDisplay): (WebCore::GraphicsLayerMac::setNeedsDisplayInRect): (WebCore::GraphicsLayerMac::setContentsNeedsDisplay): (WebCore::GraphicsLayerMac::setContentsRect): (WebCore::GraphicsLayerMac::addAnimation): (WebCore::GraphicsLayerMac::pauseAnimation): (WebCore::GraphicsLayerMac::removeAnimation): (WebCore::GraphicsLayerMac::animationDidStart): (WebCore::GraphicsLayerMac::setContentsToImage): (WebCore::GraphicsLayerMac::setContentsToMedia): (WebCore::GraphicsLayerMac::didDisplay): (WebCore::GraphicsLayerMac::syncCompositingState): (WebCore::GraphicsLayerMac::syncCompositingStateForThisLayerOnly): (WebCore::GraphicsLayerMac::recursiveCommitChanges): (WebCore::GraphicsLayerMac::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerMac::commitLayerChangesAfterSublayers): (WebCore::GraphicsLayerMac::updateLayerNames): (WebCore::GraphicsLayerMac::updateSublayerList): (WebCore::GraphicsLayerMac::updateLayerPosition): (WebCore::GraphicsLayerMac::updateLayerSize): (WebCore::GraphicsLayerMac::updateAnchorPoint): (WebCore::GraphicsLayerMac::updateTransform): (WebCore::GraphicsLayerMac::updateChildrenTransform): (WebCore::GraphicsLayerMac::updateMasksToBounds): (WebCore::GraphicsLayerMac::updateContentsOpaque): (WebCore::GraphicsLayerMac::updateBackfaceVisibility): (WebCore::GraphicsLayerMac::updateStructuralLayer): (WebCore::GraphicsLayerMac::ensureStructuralLayer): (WebCore::GraphicsLayerMac::structuralLayerPurpose): (WebCore::GraphicsLayerMac::updateLayerDrawsContent): (WebCore::GraphicsLayerMac::updateLayerBackgroundColor): (WebCore::GraphicsLayerMac::updateContentsImage): (WebCore::GraphicsLayerMac::updateContentsMediaLayer): (WebCore::GraphicsLayerMac::updateContentsCanvasLayer): (WebCore::GraphicsLayerMac::updateContentsRect): (WebCore::GraphicsLayerMac::updateMaskLayer): (WebCore::GraphicsLayerMac::updateReplicatedLayers): (WebCore::GraphicsLayerMac::ReplicaState::cloneID): (WebCore::GraphicsLayerMac::replicatedLayerRoot): (WebCore::GraphicsLayerMac::updateLayerAnimations): (WebCore::GraphicsLayerMac::setCAAnimationOnLayer): (WebCore::bug7311367Workaround): (WebCore::GraphicsLayerMac::removeCAAnimationFromLayer): (WebCore::copyAnimationProperties): (WebCore::GraphicsLayerMac::pauseCAAnimationOnLayer): (WebCore::GraphicsLayerMac::setContentsToCanvas): (WebCore::GraphicsLayerMac::repaintLayerDirtyRects): (WebCore::GraphicsLayerMac::updateContentsNeedsDisplay): (WebCore::GraphicsLayerMac::createAnimationFromKeyframes): (WebCore::GraphicsLayerMac::createTransformAnimationsFromKeyframes): (WebCore::GraphicsLayerMac::createBasicAnimation): (WebCore::GraphicsLayerMac::createKeyframeAnimation): (WebCore::GraphicsLayerMac::setupAnimation): (WebCore::GraphicsLayerMac::timingFunctionForAnimationValue): (WebCore::GraphicsLayerMac::setAnimationEndpoints): (WebCore::GraphicsLayerMac::setAnimationKeyframes): (WebCore::GraphicsLayerMac::setTransformAnimationEndpoints): (WebCore::GraphicsLayerMac::setTransformAnimationKeyframes): (WebCore::GraphicsLayerMac::suspendAnimations): (WebCore::GraphicsLayerMac::resumeAnimations): (WebCore::GraphicsLayerMac::hostLayerForSublayers): (WebCore::GraphicsLayerMac::layerForSuperlayer): (WebCore::GraphicsLayerMac::animatedLayer): (WebCore::GraphicsLayerMac::animatedLayerClones): (WebCore::GraphicsLayerMac::platformLayer): (WebCore::GraphicsLayerMac::setDebugBackgroundColor): (WebCore::GraphicsLayerMac::setDebugBorder): (WebCore::GraphicsLayerMac::constrainedSize): (WebCore::GraphicsLayerMac::requiresTiledLayer): (WebCore::GraphicsLayerMac::swapFromOrToTiledLayer): (WebCore::GraphicsLayerMac::defaultContentsOrientation): (WebCore::GraphicsLayerMac::updateContentsTransform): (WebCore::GraphicsLayerMac::setupContentsLayer): (WebCore::GraphicsLayerMac::findOrMakeClone): (WebCore::GraphicsLayerMac::ensureCloneLayers): (WebCore::GraphicsLayerMac::removeCloneLayers): (WebCore::GraphicsLayerMac::positionForCloneRootLayer): (WebCore::GraphicsLayerMac::propagateLayerChangeToReplicas): (WebCore::GraphicsLayerMac::fetchCloneLayers): (WebCore::GraphicsLayerMac::cloneLayer): (WebCore::GraphicsLayerMac::setOpacityInternal): (WebCore::GraphicsLayerMac::updateOpacityOnLayer): (WebCore::GraphicsLayerMac::noteSublayersChanged): (WebCore::GraphicsLayerMac::noteLayerPropertyChanged):
  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm: (-[WebLayer initWithLayer:]): (-[WebLayer setNeedsDisplay]): (-[WebLayer setNeedsDisplayInRect:]): (-[WebLayer display]): (-[WebLayer drawInContext:]): (-[WebLayer setLayerOwner:]): (-[WebLayer layerOwner]):
  • platform/graphics/mac/WebTiledLayer.h:
  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer initWithLayer:]): (-[WebTiledLayer setNeedsDisplay]): (-[WebTiledLayer setNeedsDisplayInRect:]): (-[WebTiledLayer display]): (-[WebTiledLayer drawInContext:]): (-[WebTiledLayer setLayerOwner:]): (-[WebTiledLayer layerOwner]):
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::nativeLayer):
  • platform/graphics/qt/GraphicsLayerQt.h:
  • platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::nativeLayer):
  • platform/graphics/win/GraphicsLayerCACF.h:
8:49 PM Changeset in webkit [73236] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-12-02 Simon Fraser <Simon Fraser>

Fix Chromium Linux plugin tests by not logging
unconditionally from the event handling code.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventX11):
8:46 PM Changeset in webkit [73235] by Simon Fraser
  • 1 edit
    2 moves in trunk/LayoutTests

2010-12-02 Simon Fraser <Simon Fraser>

Move to platform/mac, since the paint call is only made for plugins using QuickDraw or
CoreGraphics.

  • platform/mac/plugins/testplugin-onnew-onpaint-expected.txt: Renamed from LayoutTests/plugins/testplugin-onnew-onpaint-expected.txt.
  • platform/mac/plugins/testplugin-onnew-onpaint.html: Renamed from LayoutTests/plugins/testplugin-onnew-onpaint.html.
8:39 PM Changeset in webkit [73234] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Yuta Kitamura <​yutak@chromium.org>

Unreviewed.

Remove duplicate entries from Chromium test expectations.

  • platform/chromium/test_expectations.txt:
8:35 PM Changeset in webkit [73233] by jianli@chromium.org
  • 3 edits in trunk/WebCore

[chromium] Remove dead code from PNG encoder
​https://bugs.webkit.org/show_bug.cgi?id=50377

Patch by Noel Gordon <​noel.gordon@gmail.com> on 2010-12-02
Reviewed by David Levin.

Also webkit style the PNG encoder files.

No change in behaviour, so no new tests.

  • platform/image-encoders/skia/PNGImageEncoder.cpp:

(WebCore::encodeImpl):
(WebCore::PNGImageEncoder::encode):

  • platform/image-encoders/skia/PNGImageEncoder.h:
8:06 PM Changeset in webkit [73232] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Yuta Kitamura <​yutak@chromium.org>

Unreviewed.

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
7:41 PM Changeset in webkit [73231] by dpranke@chromium.org
  • 5 edits in trunk/WebKitTools

2010-12-02 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt multiprocessing - move logic back into run_webkit_tests

This change moves a bunch of logic that I had put into
message_broker back into run_webkit_tests, in a slightly
different format. WorkerMessageBroker needed to become less aware of
the logic the TestRunner class uses, and more generic.
Eventually the MessageBroker will only do generic messaging and
thread/process-pooling, and (almost) all of the
run-webkit-tests-specific logic will be moved to
run_webkit_tests.py and dump_render_tree_thread.py.

The biggest changes are that the Broker can now start a single
worker, but the responsibility for starting all of them is pushed
back to the TestRunner (Manager), and the logic for checking if
the threads are done or wedged is moved back to TestRunner. We
also remove WorkerMessageBroker.cleanup (not needed) and
cancel_workers (they have to be cancelled individually).

The message_broker is now encapsulated inside
TestRunner._run_tests(); it only needs to exist while actually
running the tests.

Also, delete a bunch of tests in message_broker_unittest that no
longer make much sense.

This patch depends on bug 50372.

​https://bugs.webkit.org/show_bug.cgi?id=50374

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
7:41 PM Changeset in webkit [73230] by yutak@chromium.org
  • 2 edits in trunk/WebCore

2010-12-02 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

An attempt to fix Chromium's clang build.

Implement (non-EventListener) marquee IDL attributes from HTML5.
​https://bugs.webkit.org/show_bug.cgi?id=49786

  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::initialMarqueeSpeed):
6:30 PM Changeset in webkit [73229] by mnaganov@chromium.org
  • 3 edits in trunk/WebCore

2010-12-02 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix heap snapshots loading. Loading is now
conducted by the Profiles panel which prevents accidental
simultaneous attempts to load the same profile several times in
parallel.

​https://bugs.webkit.org/show_bug.cgi?id=50427

  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._loadProfile): (WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot):
6:29 PM Changeset in webkit [73228] by hayato@chromium.org
  • 6 edits in trunk/WebKitTools

2010-12-02 Hayato Ito <​hayato@chromium.org>

Reviewed by Eric Seidel.

Refactor test_types's compare_output() method so that it takes a
TestInput object.

compare_output() will need additional information included in a TestInput
object to support reftests. This change is a pre-requirement of that.

​https://bugs.webkit.org/show_bug.cgi?id=50362

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
6:24 PM Changeset in webkit [73227] by cmarrin@apple.com
  • 5 edits in trunk/WebCore

2010-12-02 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Fix Leopard build broken by ​http://trac.webkit.org/changeset/73217

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::getTransformFunctionValue): (WebCore::GraphicsLayerCA::updateContentsTransform):
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm: (PlatformCAAnimation::valueFunction): (PlatformCAAnimation::setValueFunction):
  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::PlatformCALayer): (PlatformCALayer::anchorPoint): (PlatformCALayer::setAnchorPoint): (PlatformCALayer::contentsTransform): (PlatformCALayer::setContentsTransform): (PlatformCALayer::isGeometryFlipped): (PlatformCALayer::setGeometryFlipped): (PlatformCALayer::setMinificationFilter): (PlatformCALayer::setMagnificationFilter):
5:42 PM Changeset in webkit [73226] by Simon Fraser
  • 5 edits
    2 adds in trunk

2010-12-02 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Add the ability to run script on 'new' and 'paint' in the test plugin
​https://bugs.webkit.org/show_bug.cgi?id=50425

Add "onnew" and "onpaintevent" attributes to the test plugin,
so that tests can run JS at these times.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (NPP_Destroy): (handleEventCarbon): (handleEventCocoa): (NPP_HandleEvent):
5:30 PM Changeset in webkit [73225] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix Windows build.

  • runtime/GCActivityCallback.cpp:

(JSC::DefaultGCActivityCallback::synchronize): Added a non-CF implementation.

5:26 PM Changeset in webkit [73224] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update bug numbers in chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:16 PM Changeset in webkit [73223] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

Fixed <rdar://problem/8310571> CrashTracer: 60 crashes in Photo Booth at
com.apple.JavaScriptCore: JSC::Heap::markRoots + 746

Reviewed by Gavin Barraclough.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock): Call our new
synchronize() function.

  • runtime/Collector.cpp:

(JSC::Heap::activityCallback):

  • runtime/Collector.h: Added an activityCallback() accessor, for the

call above.

  • runtime/GCActivityCallback.h:

(JSC::GCActivityCallback::synchronize):

  • runtime/GCActivityCallbackCF.cpp:

(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::operator()):
(JSC::DefaultGCActivityCallback::synchronize): Track the run loop we're
scheduled in. If we begin/resume execution within a new run loop, reschedule
on it. This prevents a crash when using a lockless context group on
multiple threads -- the crash would happen if the GC timer scheduled on
thread A, then you continued execution on thread B, then the thread A
timer fired.

5:13 PM Changeset in webkit [73222] by dpranke@chromium.org
  • 7 edits in trunk/WebKitTools

2010-12-02 Sam Weinig <​sam@webkit.org>

Fix Qt build.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::PlatformWebView):
4:38 PM Changeset in webkit [73221] by Laszlo Gombos
  • 7 edits in trunk/WebKit2

2010-12-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Fix compilation with !ENABLE(OFFLINE_WEB_APPLICATIONS) and
!ENABLE(TILED_BACKING_STORE) for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=50071

Add appropriate guards. No functional change if guards are set.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::setActualVisibleContentsRect):
  • UIProcess/TiledDrawingAreaProxy.cpp:
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
  • UIProcess/qt/TiledDrawingAreaTileQt.cpp:
  • UIProcess/qt/WebContextQt.cpp: (WebKit::WebContext::applicationCacheDirectory):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
4:38 PM Changeset in webkit [73220] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix Qt build.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

4:36 PM Changeset in webkit [73219] by mitz@apple.com
  • 15 edits
    2 adds in trunk

WebCore: CSS support for the text-emphasis properties
​https://bugs.webkit.org/show_bug.cgi?id=48539

Reviewed by Dave Hyatt.

Test: fast/css/parsing-text-emphasis.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added text-emphasis-color,
text-emphasis-position and text-emphasis-style. Left the text-emphasis shorthand unsupported.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Parse the properties.
(WebCore::CSSParser::parseTextEmphasisStyle): Added.

  • css/CSSParser.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added TextEmphasisPosition, TextEmphasisFill
and TextEmphasisMark mappings.
(WebCore::CSSPrimitiveValue::operator TextEmphasisPosition): Added.
(WebCore::CSSPrimitiveValue::operator TextEmphasisFill): Added.
(WebCore::CSSPrimitiveValue::operator TextEmphasisMark): Added.

  • css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap): Added the text-emphasis shorthand.

  • css/CSSPropertyNames.in: Added -webkit-text-emphasis, -webkit-text-emphasis-color,

-webkit-text-emphasis-position, and -webkit-text-emphasis-style.

  • css/CSSStyleSelector.cpp:

(WebCore::isValidVisitedLinkProperty): Added text-emphasis-color.
(WebCore::CSSStyleSelector::applyProperty): Handle the properties.

  • css/CSSValueKeywords.in: Added 'over' and 'under' for text-emphasis-position. Added 'dot',

'double-circle', 'triangle', 'sesame', 'filled' and 'open' for text-emphasis-style.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::colorIncludingFallback): Handle text-emphasis-color.
(WebCore::RenderStyle::textEmphasisMark): Added. Maps the fake 'auto' value to 'dot' or
'sesame' based on writing direction.

  • rendering/style/RenderStyle.h: Added accessors.

(WebCore::InheritedFlags::textEmphasisFill):
(WebCore::InheritedFlags::textEmphasisCustomMark):
(WebCore::InheritedFlags::textEmphasisPosition):
(WebCore::InheritedFlags::setTextEmphasisColor):
(WebCore::InheritedFlags::setTextEmphasisFill):
(WebCore::InheritedFlags::setTextEmphasisMark):
(WebCore::InheritedFlags::setTextEmphasisCustomMark):
(WebCore::InheritedFlags::setTextEmphasisPosition):
(WebCore::InheritedFlags::initialTextEmphasisColor):
(WebCore::InheritedFlags::initialTextEmphasisFill):
(WebCore::InheritedFlags::initialTextEmphasisMark):
(WebCore::InheritedFlags::initialTextEmphasisCustomMark):
(WebCore::InheritedFlags::initialTextEmphasisPosition):
(WebCore::InheritedFlags::textEmphasisColor):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests: Test parsing of the text-emphasis CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=48539

Reviewed by Dave Hyatt.

  • fast/css/parsing-text-emphasis-expected.txt: Added.
  • fast/css/parsing-text-emphasis.html: Added.
4:35 PM Changeset in webkit [73218] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] merge toDataURL-supportedTypes in chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:34 PM Changeset in webkit [73217] by cmarrin@apple.com
  • 15 edits
    8 adds
    2 deletes in trunk

2010-12-02 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
​https://bugs.webkit.org/show_bug.cgi?id=49388

Replaced GraphicsLayerMac with GraphicsLayerCA. GraphicsLayerCA is essentially
identical to GraphicsLayerMac, but replaces all the CoreAnimation specific calls
with calls to PlatformCALayer and PlatformCAAnimation. This makes GraphicsLayerCA
platform neutral as long as implementations of those two classes are available.
Added implementations in PlatformCALayerMac and PlatformCAAnimationMac. Also got
rid of GraphicsLayer::nativeLayer() and replaced it with GraphicsLayer::platformLayer()
to avoid confusion since both names were used to refer to the same thing.

This patch is only for Mac. Windows implementation has not changed.

4:33 PM Changeset in webkit [73216] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix Qt.

  • UIProcess/API/qt/qwkpreferences.cpp:

(QWKPreferencesPrivate::createPreferences):

4:30 PM Changeset in webkit [73215] by weinig@apple.com
  • 26 edits in trunk

WebKit2 Preferences should be held off the PageGroup, not the Context
​https://bugs.webkit.org/show_bug.cgi?id=50414

Reviewed by Anders Carlsson.

WebKit2:

  • In addition, this now makes the preference held off the PageGroup have the identifier of the PageGroup and autosave to disk (only on the mac for now).
  • Adds ability to create an arbitrary preference that can be autosaved via a new WKPreferencesCreateWithIdentifier function.
  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContext.h:

Remove preference related code.

  • UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupSetPreferences):
(WKPageGroupGetPreferences):

  • UIProcess/API/C/WKPageGroup.h:

Add getter/setter for preferences.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreateWithIdentifier):

  • UIProcess/API/C/WKPreferences.h:

Add WKPreferencesCreateWithIdentifier and remove WKPreferencesCreateCopy which is
unused.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):

  • UIProcess/WebContext.h:

Remove preference related code.

  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::addPage):
(WebKit::WebPageGroup::removePage):
(WebKit::WebPageGroup::setPreferences):
(WebKit::WebPageGroup::preferences):
(WebKit::WebPageGroup::preferencesDidChange):

  • UIProcess/WebPageGroup.h:

Add preference and page tracking.

  • UIProcess/WebPageNamespace.cpp:
  • UIProcess/WebPageNamespace.h:

Remove preference change notification code.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
Add/remove self from page group set.

(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::creationParameters):
Get preferences from the pageGroup.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::WebPreferences):
(WebKit::WebPreferences::addPageGroup):
(WebKit::WebPreferences::removePageGroup):
(WebKit::WebPreferences::update):

  • UIProcess/WebPreferences.h:

(WebKit::WebPreferences::create):
Change to track page groups instead of contexts.

  • UIProcess/mac/WebPreferencesMac.mm:

(WebKit::makeKey): Add ".WebKit2" prefix for keys.

WebKitTools:

Update for API changes.

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView):

4:30 PM Changeset in webkit [73214] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool

Reviewed by Beth Dakin.

  • Misc/WebNSFileManagerExtras.m:

(setMetaData): Create an autorelease pool for the duration of the thread body.

4:09 PM Changeset in webkit [73213] by jianli@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 73208 - Integer calculation issues in DataView constructor
​https://bugs.webkit.org/show_bug.cgi?id=50354

Reviewed by Kenneth Russell.

WebCore:

Test: fast/canvas/webgl/data-view-crash.html

  • html/canvas/DataView.cpp:

(WebCore::DataView::create):

LayoutTests:

  • fast/canvas/webgl/data-view-crash-expected.txt: Added.
  • fast/canvas/webgl/data-view-crash.html: Added.

BUG=64974
TEST=Layout test
TBR=​jianli@chromium.org
Review URL: ​http://codereview.chromium.org/5556003

4:04 PM Changeset in webkit [73212] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:55 PM Changeset in webkit [73211] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-02 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

This change is a bunch of cleanup / refactoring of the file
below. It moves a bunch of free functions to methods on the
TestShellThread class, and restructures other methods to be
closer to the structure we'll need for the multiprocessing
rewrite.

It also makes the logic of --run-singly a *lot* easier to follow
by nestling all of the separate-thread logic into a single
routine.

There should be no semantic changes in this patch, just cleanup.

​https://bugs.webkit.org/show_bug.cgi?id=50367

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3:49 PM Changeset in webkit [73210] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-12-02 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Update ResourceLoaderSet Enumeration
​https://bugs.webkit.org/show_bug.cgi?id=50405

Use size_t when working with Vectors and when comparing between size_t types.

  • loader/DocumentLoader.cpp: (WebCore::cancelAll): (WebCore::setAllDefersLoading):
3:44 PM Changeset in webkit [73209] by jamesr@google.com
  • 6 edits in branches/chromium/597

Merge 73137 - 2010-12-02 Vincent Scheib <​scheib@chromium.org>

Reviewed by Darin Fisher.

[chromium] histograms api updated in WebKitClient and added to ChromiumBridge
​https://bugs.webkit.org/show_bug.cgi?id=50285

Test by loading "about:histograms" after navigating to accelerated pages.

  • platform/chromium/ChromiumBridge.h: api update.

2010-12-02 Vincent Scheib <​scheib@chromium.org>

Reviewed by Darin Fisher.

[chromium] histograms api updated in WebKitClient/ChromiumBridge and histogram "GPU.setIsAcceleratedCompositingActive" added.
​https://bugs.webkit.org/show_bug.cgi?id=50285

Test by loading "about:histograms" after navigating to accelerated pages.

  • public/WebKitClient.h: (WebKit::WebKitClient::histogramCustomCounts): api update. (WebKit::WebKitClient::histogramEnumeration): api update.
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::histogramCustomCounts): api update. (WebCore::ChromiumBridge::histogramEnumeration): api update.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): "GPU.setIsAcceleratedCompositingActive" added.

TBR=​scheib@chromium.org

Review URL: ​http://codereview.chromium.org/5622002

3:39 PM Changeset in webkit [73208] by jianli@chromium.org
  • 3 edits
    2 adds in trunk

Integer calculation issues in DataView constructor
​https://bugs.webkit.org/show_bug.cgi?id=50354

Reviewed by Kenneth Russell.

WebCore:

Test: fast/canvas/webgl/data-view-crash.html

  • html/canvas/DataView.cpp:

(WebCore::DataView::create):

LayoutTests:

  • fast/canvas/webgl/data-view-crash-expected.txt: Added.
  • fast/canvas/webgl/data-view-crash.html: Added.
3:20 PM Changeset in webkit [73207] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-02 Tony Chang <​tony@chromium.org>

Unreviewed, rolling out r73164.
​http://trac.webkit.org/changeset/73164
​https://bugs.webkit.org/show_bug.cgi?id=50359

broke debugger tests on win

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3:04 PM Changeset in webkit [73206] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • wtf/ASCIICType.h: Fix wrong type from last check-in.
3:01 PM Changeset in webkit [73205] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Try to fix certain builds (Qt Windows).

  • wtf/ASCIICType.h: Added an overload for unsigned because in obsolete

versions of ICU, UChar32 can be a typedef for unsigned. Adding this
overload should make us compatible with these old ICUs.

2:53 PM Changeset in webkit [73204] by mihaip@chromium.org
  • 7 edits in trunk/WebKitTools

2010-11-30 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: add updating of baselines
​https://bugs.webkit.org/show_bug.cgi?id=50305

Implements updating of baselines, where we copy -actual.* files over
the current -expected.* files. To do this, we need a
_get_actual_result_files method to get test results files and a
_rebaseline_test method to actually do the file copy and SCM operation.
_rebaseline_test logs output into a buffer, this is useful for both
showing result in the UI and for unit tests.

To make passing around of the various test environment properties
(results directory, filesystem, SCM, etc) easier, add a TestConfig
class for them.

Moving of existing baselines is not implemented yet, this patch is big
enough as it is.

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
2:49 PM Changeset in webkit [73203] by xji@chromium.org
  • 2 edits
    1 move
    1 delete in trunk/LayoutTests

2010-12-02 Xiaomei Ji <​xji@chromium.org>

Unreviewed.

2nd try on rebaseline vertical-scrollbar-in-rtl.

  • platform/chromium-mac/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
  • platform/chromium-win/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
  • platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/vertical-scrollbar-in-rtl-expected.txt.
  • platform/chromium/test_expectations.txt:
2:46 PM Changeset in webkit [73202] by jamesr@google.com
  • 2 edits in branches/chromium/597/WebKit/chromium

Merge 73079 - 2010-12-01 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by James Robinson.

[chromium] renderer does not realize hardware compositing is disabled and crashes
​https://bugs.webkit.org/show_bug.cgi?id=50264

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setRootGraphicsLayer): repaint always (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): null check (WebKit::WebViewImpl::reallocateRenderer):

TBR=​kbr@google.com
BUG=64650

Review URL: ​http://codereview.chromium.org/5592002

2:45 PM Changeset in webkit [73201] by Patrick Gansterer
  • 11 edits in trunk

2010-12-02 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Add AtomicString::fromUTF8
​https://bugs.webkit.org/show_bug.cgi?id=45594

Unicode::calculateStringHashFromUTF8 creates a StringHash out of UTF8 input data and
calculates the required length for the UTF16 conversation in one step.
This is then used in a specialized translator for the string table of AtomicString.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/text/AtomicString.cpp: (WTF::CStringTranslator::equal): (WTF::HashAndUTF8CharactersTranslator::hash): (WTF::HashAndUTF8CharactersTranslator::equal): (WTF::HashAndUTF8CharactersTranslator::translate): (WTF::AtomicString::add): (WTF::AtomicString::addSlowCase): (WTF::AtomicString::find): (WTF::AtomicString::fromUTF8):
  • wtf/text/AtomicString.h:
  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.h:
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::readUTF8Sequence): (WTF::Unicode::convertUTF8ToUTF16): (WTF::Unicode::calculateStringHashFromUTF8): (WTF::Unicode::equalUTF16WithUTF8):
  • wtf/unicode/UTF8.h:

2010-12-02 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Add AtomicString::fromUTF8
​https://bugs.webkit.org/show_bug.cgi?id=45594

Use AtomicString::fromUTF8 directly in the libxml2 parser.

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::toAtomicString):
2:33 PM Changeset in webkit [73200] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations for failed canvas toDataURL test.

  • platform/chromium/test_expectations.txt:
2:09 PM Changeset in webkit [73199] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] add vertical-scrollbar-in-rtl back to test expectations for mac.
The test does not putput consistent y-scroll position with HOME keydown.

  • platform/chromium/test_expectations.txt:
2:07 PM Changeset in webkit [73198] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Added a little hardening to OSAllocator.

Reviewed by Sam Weinig.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::release):

  • wtf/OSAllocatorWin.cpp:

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
(WTF::OSAllocator::release): CRASH() if the OS's virtual memory system
reports an error.

1:56 PM Changeset in webkit [73197] by aestes@apple.com
  • 2 edits in trunk/WebCore

Fix the Qt Linux Release minimal build.

  • html/HTMLMarqueeElement.cpp: Include ExceptionCode.h
1:55 PM Changeset in webkit [73196] by xan@webkit.org
  • 2 edits in trunk

2010-12-02 Xan Lopez <​xlopez@igalia.com>

Third attempt to fix the build.

  • autotools/symbols.filter: be more liberal in one more symbol.
1:49 PM Changeset in webkit [73195] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Flash videos on YouTube flicker
​https://bugs.webkit.org/show_bug.cgi?id=50409
<rdar://problem/8668757>

Reviewed by Sam Weinig.

When painting from a backing store, we need to add the source location
to the destination point.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::update):

1:47 PM Changeset in webkit [73194] by bfulgham@webkit.org
  • 3 edits in trunk/WebKitTools

Unreviewed build fix after vcproj updates.

  • DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure

that WIN_CAIRO is defined for this build.

  • DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file

to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
(these were previously 'Debug_Cairo' and 'Release_Cairo'

1:35 PM Changeset in webkit [73193] by crogers@google.com
  • 5 edits in trunk/WebKit/chromium

2010-12-02 Chris Rogers <​crogers@google.com>

Reviewed by Darin Fisher.

Fine-tune chromium WebKit API for loading audio resources
​https://bugs.webkit.org/show_bug.cgi?id=50406

  • public/WebAudioBus.h: (WebKit::WebAudioBus::~WebAudioBus):
  • public/WebKitClient.h: (WebKit::WebKitClient::loadAudioResource):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::decodeAudioFileData):
  • src/WebAudioBus.cpp: (WebKit::WebAudioBus::reset):
1:23 PM Changeset in webkit [73192] by victorw@chromium.org
  • 20 edits in trunk/LayoutTests

2010-12-02 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations for failed svg tests.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium/test_expectations.txt:
1:22 PM Changeset in webkit [73191] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-12-02 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Update ResourceLoaderSet Enumeration
​https://bugs.webkit.org/show_bug.cgi?id=50405

  • loader/DocumentLoader.cpp: (WebCore::cancelAll): instead of copying the HashSet, use copyToVector. (WebCore::setAllDefersLoading): instead of copying the HashSet, use copyToVector.
1:18 PM Changeset in webkit [73190] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-12-02 Darin Fisher <​darin@chromium.org>

Fix the Windows multi-dll build. Do not export functions that are
implemented inline!

  • public/WebFormControlElement.h: (WebKit::WebFormControlElement::assign):
1:14 PM Changeset in webkit [73189] by aestes@apple.com
  • 6 edits
    2 adds in trunk

Implement (non-EventListener) marquee IDL attributes from HTML5.
​https://bugs.webkit.org/show_bug.cgi?id=49786

Reviewed by Darin Adler.

WebCore:

Test: fast/html/marquee-element.html

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::scrollAmount): If the content attribute
can be converted to a signed integer and is >= 0, return it.
Otherwise, return the default scrollAmount value.
(WebCore::HTMLMarqueeElement::setScrollAmount): Update the content
attribute if it is >= 0. Otherwise, raise INDEX_SIZE_ERR.
(WebCore::HTMLMarqueeElement::scrollDelay): Same as scrollAmount.
(WebCore::HTMLMarqueeElement::setScrollDelay): Same as setScrollAmount.
(WebCore::HTMLMarqueeElement::loop): If the content attribute can be
converted to a signed integer and is greater than 0 or equal to -1,
return it. Otherwise, return the default loop value.
(WebCore::HTMLMarqueeElement::setLoop): Update the content attribute if
it is greater than 0 or equal to -1. Otherwise, raise INDEX_SIZE_ERR.

  • html/HTMLMarqueeElement.h:
  • html/HTMLMarqueeElement.idl: Update the IDL to match what is in HTML5.
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::initialMarqueeSpeed):

LayoutTests:

  • fast/html/marquee-element-expected.txt: Added.
  • fast/html/marquee-element.html: Added.
1:10 PM Changeset in webkit [73188] by xan@webkit.org
  • 2 edits in trunk

2010-12-02 Xan Lopez <​xlopez@igalia.com>

Another attempt to fix the GTK+ build.

  • autotools/symbols.filter: try to be more liberal with the mangled names of some symbols.
12:55 PM Changeset in webkit [73187] by weinig@apple.com
  • 8 edits in trunk

WebKit2 needs API to turn on popup blocking
​https://bugs.webkit.org/show_bug.cgi?id=50407

Reviewed by Anders Carlsson.

WebKit2:

Pipe-through a preference for javascript being able to open
windows without user gesture.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetJavaScriptCanOpenWindowsAutomatically):
(WKPreferencesGetJavaScriptCanOpenWindowsAutomatically):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

WebKitTools:

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

12:49 PM Changeset in webkit [73186] by xji@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-12-02 Xiaomei Ji <​xji@chromium.org>

Unreviewed.

Rebaseline vertical-scrollbar-in-rtl after r73063.
Enable truncation-rtl after r73087.
​https://bugs.webkit.org/show_bug.cgi?id=50352

  • platform/chromium-mac/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
  • platform/chromium-win/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:43 PM Changeset in webkit [73185] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations.

  • platform/chromium/test_expectations.txt:
12:41 PM Changeset in webkit [73184] by Patrick Gansterer
  • 5 edits in trunk/WebCore

2010-12-02 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[OpenVG] Remove "current path" of GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=50294

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::clipPath):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::PainterOpenVG): (WebCore::PainterOpenVG::~PainterOpenVG): (WebCore::PainterOpenVG::drawPath):
  • platform/graphics/openvg/PainterOpenVG.h:
12:36 PM Changeset in webkit [73183] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-12-02 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Remove "current path" of GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=50284

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
12:27 PM Changeset in webkit [73182] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations.
These svg tests need to rebaseline on win and linux.

  • platform/chromium/test_expectations.txt:
12:17 PM Changeset in webkit [73181] by jnd@chromium.org
  • 5 edits
    5 adds in trunk

2010-12-02 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

Set the right gesture status for URL redirections.
​https://bugs.webkit.org/show_bug.cgi?id=47817

  • fast/frames/location-redirect-user-gesture-expected.txt: Added.
  • fast/frames/location-redirect-user-gesture.html: Added.
  • fast/frames/meta-refresh-user-gesture-expected.txt: Added.
  • fast/frames/meta-refresh-user-gesture.html: Added.
  • fast/frames/resources/meta-refresh-target.html: Added.
  • platform/gtk/Skipped:
  • platform/win/Skipped:

2010-12-02 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

Set the right gesture status for URL redirections.
​https://bugs.webkit.org/show_bug.cgi?id=47817

Tests: fast/frames/location-redirect-user-gesture.html

fast/frames/meta-refresh-user-gesture.html

  • loader/NavigationScheduler.cpp: (WebCore::ScheduledNavigation::clearUserGesture): (WebCore::ScheduledRedirect::ScheduledRedirect):
12:16 PM Changeset in webkit [73180] by xan@webkit.org
  • 2 edits in trunk

2010-12-02 Xan Lopez <​xlopez@igalia.com>

Try to fix GTK+ build.

  • autotools/symbols.filter: add missing ';'.
12:09 PM Changeset in webkit [73179] by Csaba Osztrogonác
  • 5 edits in trunk/JavaScriptCore

2010-12-02 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Geoffrey Garen.

[Qt] Make platform managing of OSAllocator better than r73106
​https://bugs.webkit.org/show_bug.cgi?id=50385

  • wtf/OSAllocatorPosix.cpp: Remove platform specific guard.
  • wtf/OSAllocatorSymbian.cpp: Remove platform specific guard.
  • wtf/OSAllocatorWin.cpp: Remove platform specific guard.
  • wtf/wtf.pri: Add the correct platform specific source file instead of all of them.
12:07 PM Changeset in webkit [73178] by inferno@chromium.org
  • 2 edits
    35 copies in branches/chromium/552

Merge 72802

BUG=62358

11:57 AM Changeset in webkit [73177] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-12-02 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Use GetTickCount() for srand()
​https://bugs.webkit.org/show_bug.cgi?id=50338

time() is not a native function on WinCE, so use GetTickCount() instead.

  • wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
11:56 AM Changeset in webkit [73176] by dimich@chromium.org
  • 2 edits in branches/chromium/597/WebCore

Merge 72863 - Crash when iframe transfers from one page to another and has child frames.
​https://bugs.webkit.org/show_bug.cgi?id=50200

Reviewed by David Levin.

  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument):
avoid overriding 'didTransfer' which has the result of previous check.

TBR=​dimich@chromium.org
Review URL: ​http://codereview.chromium.org/5564003

11:53 AM Changeset in webkit [73175] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Eric Seidel <​eric@webkit.org>

Unreviewed.

animations/stop-animation-on-suspend.html sometimes fails on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=49182

  • platform/mac/Skipped:
11:48 AM Changeset in webkit [73174] by crogers@google.com
  • 4 edits in trunk/WebCore

2010-12-02 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

AudioContext needs createBuffer() method from ArrayBuffer
​https://bugs.webkit.org/show_bug.cgi?id=50343

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp: (WebCore::AudioContext::createBuffer):
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
11:42 AM Changeset in webkit [73173] by commit-queue@webkit.org
  • 6 edits
    2 adds
    1 delete in trunk

2010-12-02 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by David Levin.

[chromium] Add canvas.toDataURL("image/jpeg", quality) support
​https://bugs.webkit.org/show_bug.cgi?id=49365

Chromium window/linux layout try results now match the default test result, so
remove this platform-specific test exception file.

  • platform/chromium-win/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Removed.

2010-12-02 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by David Levin.

[chromium] Add canvas.toDataURL("image/jpeg", quality) support
​https://bugs.webkit.org/show_bug.cgi?id=49365

Adds a libjpeg-based image encoder for Skia bitmaps. Default encoding quality
is 92 to match Mozilla, also Safari, though the actual value used by Safari is
undocumented, and it appears to pre-blur images prior to compression.

The preMultipliedBGRAtoRGB() routine restores the un-premultiplied RGB colors
where there is non-zero alpha. Again, this matches Firefox and Safari, but no
browser conforms to the HTML5 canvas standard here, I believe, considering the
result of canvas/philip/tests/toDataURL.jpeg.alpha.html; that test ignores the
alpha channel when extracting an "image/jpeg".toDataURL(). The correct answer
needs more investigation, bug ​http://webkit.org/b/40147.

Canvas toDataURL is covered by existing tests canvas/philip/tests/toDataURL.*,
and fast/canvas/*toDataURL* tests.

  • WebCore.gypi:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::toDataURLCallback): don't set encoding quality here, just pass the toDataURL parameters through to the canvas layer.
  • platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): implement the supported mimeTypes for encoding in-place.
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::toDataURL): add jpeg encoding and quality support.
  • platform/image-encoders/skia/JPEGImageEncoder.cpp: Added. (WebCore::prepareOutput): (WebCore::writeOutput): (WebCore::finishOutput): (WebCore::handleError): (WebCore::preMultipliedBGRAtoRGB): FIXME: bug 40147. (WebCore::JPEGImageEncoder::encode):
  • platform/image-encoders/skia/JPEGImageEncoder.h: Added.
11:32 AM Changeset in webkit [73172] by inferno@chromium.org
  • 1 edit in branches/chromium/552/WebCore/css/StyleSheet.cpp

Merge 71769

BUG=62496

11:30 AM Changeset in webkit [73171] by commit-queue@webkit.org
  • 11 edits in trunk

2010-12-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73152.
​http://trac.webkit.org/changeset/73152
​https://bugs.webkit.org/show_bug.cgi?id=50401

the patch has broken chromium win layout tests (Requested by
loislo on #webkit).

  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2010-12-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73152.
​http://trac.webkit.org/changeset/73152
​https://bugs.webkit.org/show_bug.cgi?id=50401

the patch has broken chromium win layout tests (Requested by
loislo on #webkit).

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/front-end/Callback.js:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
  • inspector/front-end/inspector.js: (WebInspector.loaded.WebInspector.socket.onmessage): (WebInspector.dispatch): (WebInspector_syncDispatch): (WebInspector.reportProtocolError):
11:30 AM Changeset in webkit [73170] by inferno@chromium.org
  • 15 edits
    8 copies
    4 deletes in branches/chromium/552

Merge 71767

BUG=62496

11:23 AM Changeset in webkit [73169] by commit-queue@webkit.org
  • 4 edits
    25 adds in trunk

2010-12-02 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by James Robinson.

Scaled Resized images are blurred when sent to Skia
​https://bugs.webkit.org/show_bug.cgi?id=42370

  • platform/chromium-linux/svg/custom/image-rescale-clip-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/image-rescale-clip-expected.png: Added.
  • platform/chromium-linux/svg/custom/image-rescale-clip-expected.txt: Added.
  • platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/image-rescale-expected.png: Added.
  • platform/chromium-linux/svg/custom/image-rescale-expected.txt: Added.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/svg/custom/image-rescale-expected.checksum: Added.
  • platform/mac-leopard/svg/custom/image-rescale-expected.png: Added.
  • platform/mac-leopard/svg/custom/image-rescale-expected.txt: Added.
  • platform/mac/svg/custom/image-rescale-clip-expected.checksum: Added.
  • platform/mac/svg/custom/image-rescale-clip-expected.png: Added.
  • platform/mac/svg/custom/image-rescale-clip-expected.txt: Added.
  • platform/mac/svg/custom/image-rescale-expected.checksum: Added.
  • platform/mac/svg/custom/image-rescale-expected.png: Added.
  • platform/mac/svg/custom/image-rescale-expected.txt: Added.
  • platform/mac/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/mac/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/mac/svg/custom/image-rescale-scroll-expected.txt: Added.
  • svg/custom/image-rescale-clip.html: Added.
  • svg/custom/image-rescale-scroll.html: Added.
  • svg/custom/image-rescale.svg: Added.
  • svg/custom/resources/image-rescale.jpg: Added.

2010-12-02 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by James Robinson.

Scaled Resized images are blurred when sent to Skia
​https://bugs.webkit.org/show_bug.cgi?id=42370

This patch modifies ImageSkia.cpp to fix the calculation of resampled
bitmap sizes so as to include the transform matrix of the canvas.
Includes new tests to catch a scrolling regression and a clipping regression.

Tests: svg/custom/image-rescale-clip.html

svg/custom/image-rescale-scroll.html
svg/custom/image-rescale.svg

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::computeResamplingMode): (WebCore::drawResampledBitmap):
11:21 AM Changeset in webkit [73168] by arv@chromium.org
  • 3 edits
    3 adds in trunk

2010-12-02 Erik Arvidsson <​arv@chromium.org>

Reviewed by Darin Adler.

Missing DOM property for incremental input attribute
​https://bugs.webkit.org/show_bug.cgi?id=50335

  • fast/forms/incremental-dom-property-expected.txt: Added.
  • fast/forms/incremental-dom-property.html: Added.
  • fast/forms/script-tests/incremental-dom-property.js: Added.

2010-12-02 Erik Arvidsson <​arv@chromium.org>

Reviewed by Darin Adler.

Missing DOM property for incremental input attribute
​https://bugs.webkit.org/show_bug.cgi?id=50335

Test: fast/forms/incremental-dom-property.html

  • html/HTMLInputElement.idl: Added attribute
11:17 AM Changeset in webkit [73167] by Martin Robinson
  • 2 edits in trunk

2010-12-02 Martin Robinson <​mrobinson@igalia.com>

Attempt to fix the GTK+ build. Add missing symbol the
list of unfiltered symbols for the linker.

  • autotools/symbols.filter: Add symbol used in DumpRenderTree.
11:13 AM Changeset in webkit [73166] by inferno@chromium.org
  • 2 edits
    4 copies in branches/chromium/597

Merge 72924

BUG=52587
Review URL: ​http://codereview.chromium.org/5601001

11:07 AM Changeset in webkit [73165] by inferno@chromium.org
  • 2 edits
    4 copies in branches/chromium/552

Merge 72924

BUG=52587

11:00 AM Changeset in webkit [73164] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-01 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] force NRWT to use DRT
​https://bugs.webkit.org/show_bug.cgi?id=50359

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
10:59 AM Changeset in webkit [73163] by commit-queue@webkit.org
  • 19 edits in trunk

2010-12-02 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Move requestGeolocationPermissionForFrame to GeolocationClient
​https://bugs.webkit.org/show_bug.cgi?id=50061

This change facilitates client-based geolocation implementation by
bringing together permission control into the geolocation client
interface.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::requestPermission):
  • page/GeolocationClient.h:
  • page/GeolocationController.cpp: (WebCore::GeolocationController::requestPermission): (WebCore::GeolocationController::cancelPermissionRequest):
  • page/GeolocationController.h:
  • platform/mock/GeolocationClientMock.cpp: (WebCore::GeolocationClientMock::GeolocationClientMock): (WebCore::GeolocationClientMock::setPermission): (WebCore::GeolocationClientMock::requestPermission): (WebCore::GeolocationClientMock::cancelPermissionRequest): (WebCore::GeolocationClientMock::asyncUpdatePermission): (WebCore::GeolocationClientMock::permissionTimerFired): (WebCore::GeolocationClientMock::reset): (WebCore::GeolocationClientMock::stopUpdating): (WebCore::GeolocationClientMock::asyncUpdateController): (WebCore::GeolocationClientMock::controllerTimerFired):
  • platform/mock/GeolocationClientMock.h:

2010-12-02 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Move requestGeolocationPermissionForFrame to GeolocationClient
​https://bugs.webkit.org/show_bug.cgi?id=50061

This change facilitates client-based geolocation implementation by
bringing together permission control into the geolocation client
interface.

Move method ChromeClient::requestGeolocationPermissionForFrame to
GeolocationClient::requestPermission, and supporting class
WebGeolocationPolicyListener. The moved code is unchanged except
that requestPermission now takes only one argument (Geolocation*)
and the Frame parameter is retrieved from the Geolocation object.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:
  • WebCoreSupport/WebGeolocationClient.h: (WebGeolocationClient::cancelPermissionRequest):
  • WebCoreSupport/WebGeolocationClient.mm: (WebGeolocationClient::requestPermission): (-[WebGeolocationPolicyListener initWithGeolocation:]): (-[WebGeolocationPolicyListener allow]): (-[WebGeolocationPolicyListener deny]):

2010-12-02 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Move requestGeolocationPermissionForFrame to GeolocationClient
​https://bugs.webkit.org/show_bug.cgi?id=50061

This change facilitates client-based geolocation implementation by
bringing together permission control into the geolocation client
interface.

Move method ChromeClient::requestGeolocationPermissionForFrame to
GeolocationClient::requestPermission. The moved code is unchanged
except that requestPermission now takes only one argument (Geolocation*),
the Frame parameter is retrieved from the Geolocation object and we need to
call m_webView.get() as it is a COMPtr in GeolocationClient.

  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebGeolocationClient.cpp: (WebGeolocationClient::requestPermission):
  • WebCoreSupport/WebGeolocationClient.h: (WebGeolocationClient::cancelPermissionRequest):
10:56 AM Changeset in webkit [73162] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/552

Merge 72969

BUG=64424

10:53 AM Changeset in webkit [73161] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/597

Merge 72969

BUG=64424
Review URL: ​http://codereview.chromium.org/5543004

10:48 AM Changeset in webkit [73160] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 72685

BUG=63866

10:41 AM Changeset in webkit [73159] by andersca@apple.com
  • 6 edits in trunk

Plug-ins should be able to update the mouse cursor
​https://bugs.webkit.org/show_bug.cgi?id=50399

Reviewed by Sam Weinig.

WebKit2:

Call WKEnableSettingCursorWhenInBackground.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):

WebKitLibraries:

Add WKEnableSettingCursorWhenInBackground.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
10:35 AM Changeset in webkit [73158] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 72927

BUG=64559
Review URL: ​http://codereview.chromium.org/5526003

10:33 AM Changeset in webkit [73157] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 72927

BUG=64559

10:33 AM Changeset in webkit [73156] by tony@chromium.org
  • 4 edits in trunk

2010-12-02 Tony Chang <​tony@chromium.org>

Unreviewed, update DRT crash on mac.

  • platform/chromium/test_expectations.txt:

2010-12-02 Tony Chang <​tony@chromium.org>

Unreviewed, roll chromium deps to r67980.

  • DEPS:
10:30 AM Changeset in webkit [73155] by inferno@chromium.org
  • 1 edit
    3 copies in branches/chromium/552

Merge 72625

BUG=62987

10:30 AM Changeset in webkit [73154] by weinig@apple.com
  • 12 edits
    3 adds in trunk/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=50368
Overhaul WebKit2 preferences code

Reviewed by Anders Carlsson.

  • Reduces the number of places you have to touch to add a new preference (From 9 down to 4, but with a bit of elbow grease, we should get that

down to 2 or 3).

  • Add hooks so that platforms can initialize the preferences based on an identifier. This is currently only used on the Mac to initialize a preference store from NSUserDefaults and autosave the changes to disk. It is not yet enabled due to no way to set the identifier from client code.
  • Shared/WebPageCreationParameters.cpp:

Add necessary #include of WebCoreArgumentCoders.h which is now needed
due to cleanup in WebPreferencesStore.h.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
(WebKit::defaultValueForKey):
(WebKit::setValueForKey):
(WebKit::valueForKey):
(WebKit::WebPreferencesStore::setStringValueForKey):
(WebKit::WebPreferencesStore::getStringValueForKey):
(WebKit::WebPreferencesStore::setBoolValueForKey):
(WebKit::WebPreferencesStore::getBoolValueForKey):
(WebKit::WebPreferencesStore::setUInt32ValueForKey):
(WebKit::WebPreferencesStore::getUInt32ValueForKey):

  • Shared/WebPreferencesStore.h:

Complete overhaul of this class to store the preferences as
a set of HashMaps and use macros to define the keys and default
values.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesGetFontSmoothingLevel):
Add cast to keep conversion function working.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::WebPreferences): Add identifier constructor.
(WebKit::WebPreferences::updateStringValueForKey):
(WebKit::WebPreferences::updateBoolValueForKey):
(WebKit::WebPreferences::updateUInt32ValueForKey):
Add type based updaters. These currently give hooks to the platform and
call the generic update, but in the future, we can use this to optimize
updating preferences to not send the entire store for each change.

  • UIProcess/WebPreferences.h:

Generate the getters and setters via macro instantiation.

  • UIProcess/cf/WebPreferencesCF.cpp: Added.

(WebKit::WebPreferences::platformInitializeStore):
(WebKit::WebPreferences::platformUpdateStringValueForKey):
(WebKit::WebPreferences::platformUpdateBoolValueForKey):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
Stubbed out.

  • UIProcess/mac/WebPreferencesMac.mm: Added.

(WebKit::makeKey):
(WebKit::setStringValueIfInUserDefaults):
(WebKit::setBoolValueIfInUserDefaults):
(WebKit::setUInt32ValueIfInUserDefaults):
(WebKit::WebPreferences::platformInitializeStore):
(WebKit::WebPreferences::platformUpdateStringValueForKey):
(WebKit::WebPreferences::platformUpdateBoolValueForKey):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
Use the platform hooks to initialize and update the store from
NSUserDefaults.

  • UIProcess/qt/WebPreferencesQt.cpp: Added.

(WebKit::WebPreferences::platformInitializeStore):
(WebKit::WebPreferences::platformUpdateStringValueForKey):
(WebKit::WebPreferences::platformUpdateBoolValueForKey):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
Stubbed out.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformPreferencesDidChange):
Update to pull the value using the new type based getters.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

10:25 AM Changeset in webkit [73153] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 72639

BUG=63924

10:22 AM Changeset in webkit [73152] by loislo@chromium.org
  • 11 edits in trunk

2010-12-01 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector protocol cleanup task.

The patch has just small renames and adjustments for the protocol things.
'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned for the each backend to frontend messages.
At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.

​https://bugs.webkit.org/show_bug.cgi?id=50337

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/front-end/inspector.js: (WebInspector_syncDispatch):

2010-12-01 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector protocol cleanup task.

The patch has just small renames and adjustments for the protocol things.
'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned for the each backend to frontend messages.
At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.

​https://bugs.webkit.org/show_bug.cgi?id=50337

  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
  • inspector/report-protocol-errors-expected.txt:
10:17 AM Changeset in webkit [73151] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 72748

BUG=63454

10:14 AM Changeset in webkit [73150] by Martin Robinson
  • 7 edits in trunk

2010-12-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DumpRenderTree has two copies of JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=49877

Prevent the need to compile JSC into DumpRenderTree twice, by adjusting
the symbol visibility rules for libwebkit. Make all JSC symbols visible,
while hiding WebCore/WebKit symbols.

  • GNUmakefile.am: Move the symbol visibility flags to the WebKit build.
  • autotools/symbols.filter: Update the symbol filter list with the real mangled names of the symbols and include other symbols that DRT needs.

2010-12-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DumpRenderTree has two copies of JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=49877

Keep WebKit/WebCore symbols hidden.

  • GNUmakefile.am: Move the symbol visibility rules here, because now JSC symbols are visible, but WebCore/WebKit symbols are hidden.

2010-12-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DumpRenderTree has two copies of JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=49877

  • GNUmakefile.am: Remove the second copy of JavaScriptCore from the LDADD list for DumpRenderTree.
10:07 AM Changeset in webkit [73149] by Joseph Pecoraro
  • 2 edits in trunk/WebKit/mac

2010-12-02 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Carlson.

Style Fixes in WebPluginController
​https://bugs.webkit.org/show_bug.cgi?id=50397

  • Plugins/WebPluginController.mm: (-[WebPluginController startAllPlugins]): (-[WebPluginController stopAllPlugins]):
9:55 AM Changeset in webkit [73148] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Mac build fix.

  • WebProcess/WebKitMain.cpp:

(enableDataExecutionPrevention):

9:46 AM Changeset in webkit [73147] by vangelis@chromium.org
  • 6 edits in branches/chromium/597

Part 2 of merges for Chromium bug #64589
Merge 73055 - 2010-11-30 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

Get the value of the accelerated compositing triggers from the Settings
class. This allows setting the triggers via command line flags.
​https://bugs.webkit.org/show_bug.cgi?id=50301

  • public/WebSettings.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowedCompositingTriggers):
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAcceleratedCompositingFor3DTransformsEnabled): (WebKit::WebSettingsImpl::setAcceleratedCompositingForVideoEnabled): (WebKit::WebSettingsImpl::setAcceleratedCompositingForPluginsEnabled): (WebKit::WebSettingsImpl::setAcceleratedCompositingForCanvasEnabled): (WebKit::WebSettingsImpl::setAcceleratedCompositingForAnimationEnabled):
  • src/WebSettingsImpl.h:

2010-11-30 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

Adds accelerated compositing trigger flags to Settings to allow
ports to set them via command line flags, etc.
​https://bugs.webkit.org/show_bug.cgi?id=50301

  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAcceleratedCompositingFor3DTransformsEnabled): (WebCore::Settings::setAcceleratedCompositingForVideoEnabled): (WebCore::Settings::setAcceleratedCompositingForPluginsEnabled): (WebCore::Settings::setAcceleratedCompositingForCanvasEnabled): (WebCore::Settings::setAcceleratedCompositingForAnimationEnabled):
  • page/Settings.h: (WebCore::Settings::acceleratedCompositingFor3DTransformsEnabled): (WebCore::Settings::acceleratedCompositingForVideoEnabled): (WebCore::Settings::acceleratedCompositingForPluginsEnabled): (WebCore::Settings::acceleratedCompositingForCanvasEnabled): (WebCore::Settings::acceleratedCompositingForAnimationEnabled):

TBR=​vangelis@chromium.org
Review URL: ​http://codereview.chromium.org/5534003

9:45 AM Changeset in webkit [73146] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Tony Chang <​tony@chromium.org>

Unreviewed, add back fast/overflow/hit-test-overflow-controls.html
to chromium test_expectations.txt. It's failing on the main
waterfall. Thanks to victorw for notifying me.

  • platform/chromium/test_expectations.txt:
9:42 AM Changeset in webkit [73145] by caseq@chromium.org
  • 5 edits in trunk

2010-12-01 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Re-implementing HAR export functionality that used to be in Resources
tab in Network tab.
​https://bugs.webkit.org/show_bug.cgi?id=45663

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._toggleViewingResourceMode): (WebInspector.NetworkPanel.prototype._contextMenu): (WebInspector.NetworkPanel.prototype._exportAll): (WebInspector.NetworkPanel.prototype._exportResource): (WebInspector.NetworkDataGridNode.prototype.refreshResource):
  • inspector/front-end/networkPanel.css: (.data-grid table.data tr.revealed.network-item): (.data-grid.filter-other table.data tr.revealed.network-category-other):

2010-12-01 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Enable resource export to HAR for Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=45663

  • src/js/DevTools.js: Preferences.resourceExportEnabled = true
9:42 AM Changeset in webkit [73144] by vangelis@chromium.org
  • 11 edits in branches/chromium/597

Part 1 of merges for Chromium bug #64589

Merge 72954 - 2010-11-29 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Simon Fraser.

Provide more fine grained control to ports over when to turn on accelerated
compositing.
​https://bugs.webkit.org/show_bug.cgi?id=49998

As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
has now been replaced by allowedCompositingTriggers which returns a bitfield of
all the features which can trigger the compositor.

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowedCompositingTriggers):
  • src/ChromeClientImpl.h:

2010-11-29 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Simon Fraser.

Provide more fine grained control to ports over when to turn on accelerated
compositing.
​https://bugs.webkit.org/show_bug.cgi?id=49998

As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
has now been replaced by allowedCompositingTriggers which returns a bitfield of
all the features which can trigger the compositor.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::allowedCompositingTriggers):
  • WebCoreSupport/ChromeClientQt.h:

2010-11-30 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Simon Fraser.

Provide more fine grained control to ports over when to turn on
accelerated compositing.
​https://bugs.webkit.org/show_bug.cgi?id=49998

The RenderLayerCompositor now checks with the chrome client whether
3d transforms, video, plugins, canvas and animation require
switching over to the composited path. Layers that overlap composited
content will still turn into composited layers regardless of the
setting.

  • css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
  • page/ChromeClient.h: (WebCore::ChromeClient::allowedCompositingTriggers):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::canRender3DTransforms): (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::currentTransform):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateLayerTransform):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags): (WebCore::RenderLayerCompositor::canRender3DTransforms): (WebCore::RenderLayerCompositor::requiresCompositingLayer): (WebCore::RenderLayerCompositor::requiresCompositingForTransform): (WebCore::RenderLayerCompositor::requiresCompositingForVideo): (WebCore::RenderLayerCompositor::requiresCompositingForCanvas): (WebCore::RenderLayerCompositor::requiresCompositingForPlugin): (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
  • rendering/RenderLayerCompositor.h:

TBR=​vangelis@chromium.org
Review URL: ​http://codereview.chromium.org/5523003

9:39 AM Changeset in webkit [73143] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Slightly speculative fix for:

Reviewed by Adam Roben.

<rdar://problem/8712674>
<​https://bugs.webkit.org/show_bug.cgi?id=50393>
setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]

  • Panels/WebAuthenticationPanel.m:

(-[WebAuthenticationPanel setUpForChallenge:]):
If the realm is nil, use @"" instead.

9:34 AM Changeset in webkit [73142] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk/WebKit2

2010-11-30 Amruth Raj <​amruthraj@motorola.com> and Ravi Kasibhatla <​ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] Implement RunLoop, WorkQueue, Connection classes for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=48507

  • Platform/CoreIPC/Connection.h: UNIX_X11 specific changes for GTK port. (CoreIPC::Connection::messageProcessingCompleted):
  • Platform/CoreIPC/gtk: Added.
  • Platform/CoreIPC/gtk/ConnectionGtk.cpp: Added. Connection class implementation for GTK port (UNIX_X11 specific). (CoreIPC::readBytesFromSocket): (CoreIPC::writeBytesToSocket): (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::platformInvalidate): (CoreIPC::Connection::processCompletedMessage): (CoreIPC::Connection::readEventHandler): (CoreIPC::Connection::open): (CoreIPC::Connection::platformCanSendOutgoingMessages): (CoreIPC::Connection::sendOutgoingMessage):
  • Platform/PlatformProcessIdentifier.h: UNIX_X11 specific changes for GTK port.
  • Platform/RunLoop.h: GTK port specific changes.
  • Platform/WorkQueue.h: GTK port specific changes.
  • Platform/gtk/RunLoopGtk.cpp: Added. Runs an event loop using GMainLoop and handles the incoming messages. (RunLoop::RunLoop): (RunLoop::~RunLoop): (RunLoop::run): (RunLoop::mainLoop): (RunLoop::stop): (RunLoop::queueWork): (RunLoop::wakeUp): (RunLoop::TimerBase::TimerBase): (RunLoop::TimerBase::~TimerBase): (RunLoop::TimerBase::resetTimerSource): (RunLoop::TimerBase::oneShotTimerFired): (RunLoop::TimerBase::repeatingTimerFired): (RunLoop::TimerBase::start): (RunLoop::TimerBase::stop): (RunLoop::TimerBase::isActive):
  • Platform/gtk/WorkQueueGtk.cpp: Added. Creates a thread and polls on a given fd using GIOChannel. Dispatches the obtained messages to RunLoop's GMainLoop. (WorkQueue::EventSource::EventSource): (WorkQueue::EventSource::dispatchSource): (WorkQueue::EventSource::performWorkOnce): (WorkQueue::EventSource::performWork): (WorkQueue::EventSource::deleteEventSource): (WorkQueue::platformInitialize): (WorkQueue::platformInvalidate): (WorkQueue::startWorkQueueThread): (WorkQueue::workQueueThreadBody): (WorkQueue::registerEventSourceHandler): (WorkQueue::unregisterEventSourceHandler): (WorkQueue::scheduleWork):
9:33 AM Changeset in webkit [73141] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-02 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing tests.

  • platform/gtk/Skipped:
9:24 AM Changeset in webkit [73140] by sfalken@apple.com
  • 3 edits in trunk/WebKit2

2010-12-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Move enableExecutionPrevention to WebKitMain
​https://bugs.webkit.org/show_bug.cgi?id=50392

  • WebProcess/WebKitMain.cpp: (enableDataExecutionPrevention): (WebKitMain):
  • WebProcess/win/WebProcessMainWin.cpp: (WebKit::WebProcessMain):
9:11 AM Changeset in webkit [73139] by commit-queue@webkit.org
  • 5 edits in trunk

2010-12-02 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

Reject named colors, accept only #rrggbb in <input type=color />
​https://bugs.webkit.org/show_bug.cgi?id=50308

  • fast/forms/ValidityState-typeMismatch-color-expected.txt:
  • fast/forms/script-tests/ValidityState-typeMismatch-color.js: Changed to reject English color names.

2010-12-02 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

Reject named colors, accept only #rrggbb in <input type=color />
​https://bugs.webkit.org/show_bug.cgi?id=50308

  • html/ColorInputType.cpp: Modified to accept only simple colors like #xxxxxx. (WebCore::isValidColorString):
9:10 AM Changeset in webkit [73138] by sfalken@apple.com
  • 3 edits in trunk/WebKit2

2010-12-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Enable DEP at runtime to allow for compatibility with older versions of ATL
​https://bugs.webkit.org/show_bug.cgi?id=50378

  • WebProcess/win/WebProcessMainWin.cpp: (WebKit::enableDataExecutionPrevention): (WebKit::WebProcessMain):
  • win/WebKit2WebProcessCommon.vsprops:
8:51 AM XBL2UseCases edited by Dimitri Glazkov
(diff)
8:33 AM Changeset in webkit [73137] by commit-queue@webkit.org
  • 6 edits in trunk

2010-12-02 Vincent Scheib <​scheib@chromium.org>

Reviewed by Darin Fisher.

[chromium] histograms api updated in WebKitClient and added to ChromiumBridge
​https://bugs.webkit.org/show_bug.cgi?id=50285

Test by loading "about:histograms" after navigating to accelerated pages.

  • platform/chromium/ChromiumBridge.h: api update.

2010-12-02 Vincent Scheib <​scheib@chromium.org>

Reviewed by Darin Fisher.

[chromium] histograms api updated in WebKitClient/ChromiumBridge and histogram "GPU.setIsAcceleratedCompositingActive" added.
​https://bugs.webkit.org/show_bug.cgi?id=50285

Test by loading "about:histograms" after navigating to accelerated pages.

  • public/WebKitClient.h: (WebKit::WebKitClient::histogramCustomCounts): api update. (WebKit::WebKitClient::histogramEnumeration): api update.
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::histogramCustomCounts): api update. (WebCore::ChromiumBridge::histogramEnumeration): api update.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): "GPU.setIsAcceleratedCompositingActive" added.
8:23 AM Changeset in webkit [73136] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-02 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing test.

  • platform/gtk/Skipped: Skip media/video-volume.html
8:14 AM Changeset in webkit [73135] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-02 Philippe Normand <​pnormand@igalia.com>

Unreviewed, unskip passing media tests on GTK.

  • platform/gtk/Skipped: Unskip fullscreen video tests, now passing.
8:13 AM Changeset in webkit [73134] by Csaba Osztrogonác
  • 1 edit
    2 copies in trunk/LayoutTests

Unreviewed. Add Qt specific expected files after r73063.

Make scrolling work properly with writing modes
​https://bugs.webkit.org/show_bug.cgi?id=46645

  • platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Copied from LayoutTests/fast/dom/horizontal-scrollbar-in-rtl-expected.txt.
  • platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Copied from LayoutTests/fast/dom/vertical-scrollbar-in-rtl-expected.txt.
8:12 AM Changeset in webkit [73133] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2010-12-02 Andras Becsi <​abecsi@webkit.org>

Unreviewed build fix.

[Qt][V8] Fix linking of generated sources.

No new tests needed.

  • WebCore.pro: add missing V8ImageDataCustom.cpp.
7:55 AM Changeset in webkit [73132] by Adam Roben
  • 2 edits in trunk/LayoutTests

Remove a test that we were only skipping to see if it would fix other tests

It didn't.

  • platform/mac-wk2/Skipped:
7:51 AM Changeset in webkit [73131] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add some new tests to the mac-wk2 Skipped file

All of the tests depend on EventSender.keyDown.

  • platform/mac-wk2/Skipped:
7:19 AM Changeset in webkit [73130] by Nikolas Zimmermann
  • 74 edits in trunk/WebCore

2010-12-02 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Adam Roben.

Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedString/SVGAnimatedEnumeration
​https://bugs.webkit.org/show_bug.cgi?id=50383

Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_(STRING|ENUMERATION) / DEFINE_ANIMATED_(STRING|ENUMERATION).
The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.

No functional changes, thus no new tests.

  • svg/SVGAElement.cpp:
  • svg/SVGAElement.h: (WebCore::SVGAElement::isValid): (WebCore::SVGAElement::target):
  • svg/SVGAltGlyphElement.cpp:
  • svg/SVGAltGlyphElement.h:
  • svg/SVGAnimatedEnumeration.h:
  • svg/SVGAnimatedString.h:
  • svg/SVGClipPathElement.cpp:
  • svg/SVGClipPathElement.h:
  • svg/SVGComponentTransferFunctionElement.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGCursorElement.cpp:
  • svg/SVGCursorElement.h:
  • svg/SVGFEBlendElement.cpp:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp:
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp:
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEGaussianBlurElement.cpp:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp:
  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.cpp:
  • svg/SVGFEMergeNodeElement.cpp:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp:
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGForeignObjectElement.cpp:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGradientElement.cpp:
  • svg/SVGGradientElement.h:
  • svg/SVGImageElement.cpp:
  • svg/SVGImageElement.h:
  • svg/SVGMPathElement.cpp:
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp:
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp:
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp:
  • svg/SVGPatternElement.h:
  • svg/SVGScriptElement.cpp:
  • svg/SVGScriptElement.h:
  • svg/SVGStyledElement.cpp:
  • svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasRelativeLengths): (WebCore::SVGStyledElement::supportsMarkers): (WebCore::SVGStyledElement::style): (WebCore::SVGStyledElement::updateRelativeLengthsInformation): (WebCore::SVGStyledElement::selfHasRelativeLengths): (WebCore::SVGStyledElement::isStyled):
  • svg/SVGTRefElement.cpp:
  • svg/SVGTRefElement.h:
  • svg/SVGTextContentElement.cpp:
  • svg/SVGTextContentElement.h:
  • svg/SVGTextPathElement.cpp:
  • svg/SVGTextPathElement.h:
  • svg/SVGUseElement.cpp:
  • svg/SVGUseElement.h:
6:28 AM Changeset in webkit [73129] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-12-02 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WX] Remove "current path" of GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=50286

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
6:11 AM Changeset in webkit [73128] by Martin Robinson
  • 230 edits
    2 adds in trunk

2010-11-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Text input controls do not react properly to CSS styling
​https://bugs.webkit.org/show_bug.cgi?id=40855

Update tests which have changed after fixes to text field layout.

  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/encoding-test-expected.txt:
  • platform/gtk/fast/forms/fieldset-align-expected.txt:
  • platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/input-align-expected.txt:
  • platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
  • platform/gtk/fast/forms/input-appearance-width-expected.txt:
  • platform/gtk/fast/forms/input-baseline-expected.txt:
  • platform/gtk/fast/forms/input-disabled-color-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
  • platform/gtk/fast/forms/input-paste-undo-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/gtk/fast/forms/input-readonly-empty-expected.txt:
  • platform/gtk/fast/forms/input-spaces-expected.txt:
  • platform/gtk/fast/forms/input-table-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
  • platform/gtk/fast/forms/input-type-change2-expected.txt:
  • platform/gtk/fast/forms/input-type-text-min-width-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/input-width-expected.txt:
  • platform/gtk/fast/forms/isindex-placeholder-expected.txt:
  • platform/gtk/fast/forms/minWidthPercent-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/gtk/fast/forms/text-style-color-expected.txt:
  • platform/gtk/fast/forms/textAreaLineHeight-expected.txt:
  • platform/gtk/fast/forms/textarea-align-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/textarea-scroll-height-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/gtk/fast/forms/textarea-width-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:

2010-10-26 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Text input controls do not react properly to CSS styling
​https://bugs.webkit.org/show_bug.cgi?id=40855

Improve text input control rendering. Instead of using the GTK+ border
attributes of the control modify the padding, they modify the border.
Make this same choice for search inputs and text area inputs.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::setTextInputBorders): Added this helper which sets text input control borders based on GTK+ theme settings. (WebCore::RenderThemeGtk::adjustTextFieldStyle): Use the setTextInputBorders helper. (WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto. (WebCore::RenderThemeGtk::adjustSearchFieldStyle): Ditto.
  • platform/gtk/RenderThemeGtk.h:
6:00 AM Changeset in webkit [73127] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Updating test expectations.

  • platform/chromium/test_expectations.txt:
5:58 AM Changeset in webkit [73126] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-12-02 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] Reintroduce compiler optimizations for JSC
​https://bugs.webkit.org/show_bug.cgi?id=50270

Add compiler optimization (symbian ARM target) which was lost after split from WebCore.
Tested via Sunspider and V8 - both of which show significant performance improvement.

5:39 AM Changeset in webkit [73125] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-12-02 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsContext::strokeRect() taints the context's lineWidth
​https://bugs.webkit.org/show_bug.cgi?id=50269

  • fast/canvas/canvas-lineWidth-intact-after-strokeRect-expected.txt: Added.
  • fast/canvas/canvas-lineWidth-intact-after-strokeRect.html: Added.
  • fast/canvas/script-tests/canvas-lineWidth-intact-after-strokeRect.js: Added.

2010-12-02 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsContext::strokeRect() taints the context's lineWidth
​https://bugs.webkit.org/show_bug.cgi?id=50269

Test: fast/canvas/canvas-lineWidth-intact-after-strokeRect.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::strokeRect): Restore the context's original stroke thickness after painting.
5:36 AM Changeset in webkit [73124] by abecsi@webkit.org
  • 7 edits in trunk/JavaScriptCore

2010-12-02 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Move regex parsing and fallback handling to runtime/RegExp.cpp
​https://bugs.webkit.org/show_bug.cgi?id=50015

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create): (JSC::RegExp::compile): (JSC::RegExp::match): (JSC::RegExp::printTraceData):
  • runtime/RegExp.h: (JSC::RegExp::pattern):
  • yarr/RegexInterpreter.cpp:
  • yarr/RegexInterpreter.h:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile): (JSC::Yarr::jitCompileRegex):
  • yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::RegexCodeBlock): (JSC::Yarr::RegexCodeBlock::setFallBack): (JSC::Yarr::RegexCodeBlock::isFallBack): (JSC::Yarr::executeRegex):
4:38 AM Changeset in webkit [73123] by reni@webkit.org
  • 2 edits in trunk/WebCore

[Qt] GraphicsContext::clip(path) should clip using winding fill
​https://bugs.webkit.org/show_bug.cgi?id=49912

Patch by Renata Hodovan <​reni@webkit.org> on 2010-12-02
Reviewed by Andreas Kling.

GraphicsContext::clip(path) now uses winding fill and this function is called by
GraphicsContext::canvasClip(path).

No new test is needed.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):

4:33 AM Changeset in webkit [73122] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-02 Alexander Pavlov <​apavlov@chromium.org>

Unreviewed, build fix.

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
3:25 AM Changeset in webkit [73121] by apavlov@chromium.org
  • 19 edits
    2 deletes in trunk

2010-12-01 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove obsolete CSS backend API from InspectorDOMAgent
​https://bugs.webkit.org/show_bug.cgi?id=50318

WebCore:

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.idl:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorCSSStore.cpp: Removed.
  • inspector/InspectorCSSStore.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::unbind):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):

LayoutTests:

  • inspector/styles-iframe.html:
  • inspector/styles-source-lines.html:
  • inspector/styles-source-offsets-expected.txt:
  • inspector/styles-source-offsets.html:
2:50 AM Changeset in webkit [73120] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

Unreviewed trivial buildfix after r73117.

  • page/FrameView.cpp:

(WebCore::FrameView::calculateScrollbarModesForLayout):

2:40 AM Changeset in webkit [73119] by commit-queue@webkit.org
  • 6 edits
    1 copy in trunk/WebCore

2010-12-02 Yuqiang Xian <​yuqiang.xian@intel.com>

Reviewed by Pavel Feldman.

[V8] Speed up data property access for ImageData.
​https://bugs.webkit.org/show_bug.cgi?id=49999

We create a normal V8 object which has a PixelArray as the backing storage,
and set the "data" property of the ImageData object to it.
This way "data" becomes a pure JS property and we don't need to call through
the C++ bindings for ImageData "data" access.
This eliminates big overhead in switching between JavaScript and native
contexts and performing object bindings.

No new tests. Relying on existing Canvas tests.

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8ImageDataCustom.cpp: Added. (WebCore::toV8):
  • html/ImageData.idl:
  • html/canvas/CanvasPixelArray.idl:
2:23 AM Changeset in webkit [73118] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-12-02 Kent Tamura <​tkent@chromium.org>

Unreviewed. Run sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
2:12 AM Changeset in webkit [73117] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-02 Mike Lawther <​mikelawther@chromium.org>

Reviewed by David Hyatt.

Clean up of iframe scrollbar mode code
​https://bugs.webkit.org/show_bug.cgi?id=47797

Pull setChildNeedsLayout/setNeedsLayout calls out of scrollbar mode
calculation method and put back into main layout function.
Early exit from the scrollbar calc when scrollbars are turned off.

  • page/FrameView.cpp: (WebCore::FrameView::calculateScrollbarModesForLayout): (WebCore::FrameView::layout):
1:54 AM Changeset in webkit [73116] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-02 Hironori Bono <​hbono@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Fix possible crashes in FontFallbackFont::determinePitch().
​https://bugs.webkit.org/show_bug.cgi?id=25770

When all of "Arial", "Courier New", and "Times New Roman" fonts are corrupted,
FontCache::getLastResortFallbackFont() returns 0 and it causes this crash. To
avoid this crash, this change falls back to system fonts (Windows ensures they
are sane) as Win Safari does. Unfortunately, I don't have any ideas how I can
write a layout test for this issue because this crash happens on a PC some of
its system fonts are corrupted.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontDataFromDescriptionAndLogFont): (WebCore::FontCache::getLastResortFallbackFont):
1:39 AM Changeset in webkit [73115] by sergio@webkit.org
  • 2 edits in trunk/WebKitTools

2010-12-02 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed: Added myself to list of Committers.

  • Scripts/webkitpy/common/config/committers.py:
1:15 AM Changeset in webkit [73114] by Dimitri Glazkov
  • 4 edits in trunk/WebCore

2010-12-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Provide means to store shadow DOM nodes on Element
​https://bugs.webkit.org/show_bug.cgi?id=48697

Adds shadow DOM awareness to the standard Node attach/detach,
document and tree insertion and removal cycle.

No new tests, because the code is not yet used.

  • dom/Element.cpp: (WebCore::Element::insertedIntoDocument): Added logic to cascade down to shadow DOM, if present. (WebCore::Element::removedFromDocument): Ditto. (WebCore::Element::insertedIntoTree): Ditto. (WebCore::Element::removedFromTree): Ditto. (WebCore::Element::attach): Ditto. (WebCore::Element::detach): Ditto. (WebCore::Element::recalcStyle): (WebCore::Element::shadowRoot): Added. (WebCore::Element::setShadowRoot): Added. (WebCore::Element::clearShadowRoot): Added.
  • dom/Element.h: Added decls.
  • dom/ElementRareData.h: Added a member to hold a RefPtr to the shadow DOM root for the element.
12:18 AM Changeset in webkit [73113] by dbates@webkit.org
  • 6 edits in trunk

2010-12-02 Daniel Bates <​dbates@rim.com>

Add autotools generated files to svn:ignore so that these
files do not show up in an svn stat.

  • .: Modified property svn:ignore.
  • autotools: Added property svn:ignore.

2010-12-02 Daniel Bates <​dbates@rim.com>

Ignore WebKit/gtk/docs/GNUmakefile.in and WebKit/gtk/po/*.pot so that
these files do not appear in an svn stat. This change makes SVN
consistent with the current Git ignore behavior for these files.

  • docs: Added property svn:ignore.
  • po: Added property svn:ignore.
12:05 AM Changeset in webkit [73112] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

2010-12-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Gray-scale JPEG images with a color profile are stretched horizonally
​https://bugs.webkit.org/show_bug.cgi?id=49950

Turns out gray-scale JPEGs with color profiles have the same issue as
PNGs. As with PNGs, we suppress now suppress the color profile for
gray-scale JPEGs. Most importantly, this patch adds a test.

Test: fast/images/gray-scale-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):

2010-12-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Gray-scale JPEG images with a color profile are stretched horizonally
​https://bugs.webkit.org/show_bug.cgi?id=49950

Test that we properly render gray-scale JPEGs with embedded color
profiles.

  • fast/images/gray-scale-jpeg-with-color-profile.html: Added.
  • fast/images/resources/flowchart.jpg: Added.
  • platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Added.

Dec 1, 2010:

11:01 PM Changeset in webkit [73111] by dbates@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-12-01 Daniel Bates <​dbates@rim.com>

Remove file LayoutTests/platform/gtk/Skipped.rej which was
inadvertently committed in changeset 72675 <​http://trac.webkit.org/changeset/72675>.

  • platform/gtk/Skipped.rej: Removed.
10:15 PM Changeset in webkit [73110] by jianli@chromium.org
  • 6 edits
    3 copies in branches/chromium/597

Merge 72866 - Add send(ArrayBuffer) to XMLHttpRequest per XMLHttpRequest Level 2 spec
​https://bugs.webkit.org/show_bug.cgi?id=50199

Reviewed by David Levin.

WebCore:

Test: http/tests/xmlhttprequest/send-array-buffer.html

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

  • xml/XMLHttpRequest.h:

LayoutTests:

  • http/tests/xmlhttprequest/resources/post-echo-as-ascii.cgi: Added.
  • http/tests/xmlhttprequest/send-array-buffer-expected.txt: Added.
  • http/tests/xmlhttprequest/send-array-buffer.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

BUG=65046
TEST=Layout test
TBR=​jianli@chromium.org
Review URL: ​http://codereview.chromium.org/5569001

8:38 PM Changeset in webkit [73109] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the GTK build.

  • GNUmakefile.am: Use a full path to OSAllocator*.cpp.
8:28 PM Changeset in webkit [73108] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the EFL Linux build.

  • CMakeListsEfl.txt: Added OSAllocator to the project.
8:27 PM Changeset in webkit [73107] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Eric Seidel <​eric@webkit.org>

Unreviewed.

compositing/iframes/overlapped-nested-iframes.html is ridiculously flaky
​https://bugs.webkit.org/show_bug.cgi?id=50255

Skipping it to stop the madness.

  • platform/mac-snowleopard/Skipped:
8:04 PM Changeset in webkit [73106] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

Try to fix the Qt build: Include all OS files for Qt's sake, and then
use #ifdefs in the files to exclude things based on OS.

This is a pretty bad way to manage platforms -- hopefully we can
fix the Qt build system and move away from this in the future.

  • wtf/OSAllocatorPosix.cpp:
  • wtf/OSAllocatorSymbian.cpp:
  • wtf/OSAllocatorWin.cpp:
  • wtf/wtf.pri:
7:50 PM Changeset in webkit [73105] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the Chromium build.

  • JavaScriptCore.gypi: This is a Windows build file, so use OSAllocatorWin.cpp.
7:39 PM Changeset in webkit [73104] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the GTK build.

  • GNUmakefile.am: Added OSAllocator to another project.
7:31 PM Changeset in webkit [73103] by victorw@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

2010-12-01 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium image test expectations.

  • platform/chromium-mac/platform/mac/editing: Added.
  • platform/chromium-mac/platform/mac/editing/spelling: Added.
  • platform/chromium-mac/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Added.
  • platform/chromium-mac/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Added.
  • platform/chromium-win/platform/mac/editing/spelling: Added.
  • platform/chromium-win/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Added.
  • platform/chromium-win/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Added.
7:23 PM Changeset in webkit [73102] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the GTK Linux build.

7:18 PM Changeset in webkit [73101] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the Qt Linux build.

  • wtf/OSAllocatorPosix.cpp: Use the right errno.h.
7:04 PM Changeset in webkit [73100] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Removing out of date expectation.

  • platform/chromium/test_expectations.txt:
7:01 PM Changeset in webkit [73099] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix Windows build: export some more symbols.

6:56 PM Changeset in webkit [73098] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix 64-bit build.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::windowAndViewFramesChanged):

6:52 PM Changeset in webkit [73097] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the Qt Linux build.

  • wtf/wtf.pri: Use the POSIX OSAllocator for Qt Linux.
6:42 PM Changeset in webkit [73096] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: commit doesn't have a return value.

  • wtf/OSAllocatorWin.cpp:

(WTF::OSAllocator::commit):

6:36 PM Changeset in webkit [73095] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix: Export some symbols.

6:34 PM Changeset in webkit [73094] by ggaren@apple.com
  • 2 edits
    2 adds in trunk

Build fix: Added a forwarding header.

JavaScriptGlue:

  • ForwardingHeaders/wtf/OSAllocator.h: Added.

WebCore:

  • ForwardingHeaders/wtf/OSAllocator.h: Added.
6:27 PM Changeset in webkit [73093] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Moving test expecation upstream.

  • platform/chromium/test_expectations.txt:
6:22 PM Changeset in webkit [73092] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix.

  • JavaScriptCore.xcodeproj/project.pbxproj: Export OSAllocator.h as private

so other projects can see it.

  • wtf/OSAllocatorPosix.cpp: #include UnusedParam.h for UNUSED_PARAM.
6:13 PM Changeset in webkit [73091] by ggaren@apple.com
  • 9 edits
    4 adds
    1 delete in trunk/JavaScriptCore

Baby step toward a cross-platform virtual memory abstraction: created
an all-static OSAllocator class and changed MarkStack to use it.

Reviewed by Sam Weinig.

  • JavaScriptCore.xcodeproj/project.pbxproj: Added OSAllocatorPosix.cpp.
  • runtime/MarkStack.h:

(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack): Use OSAllocator instead of rolling our
own platform-specific code.

  • runtime/MarkStackNone.cpp: Removed. Nothing used this.
  • runtime/MarkStackPosix.cpp:
  • runtime/MarkStackSymbian.cpp:
  • runtime/MarkStackWin.cpp: Removed custom platform-specific code, since

we use the OSAllocator abstraction now.

  • wtf/OSAllocator.h: Added.
  • wtf/OSAllocatorPosix.cpp: Added.

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
(WTF::OSAllocator::release):

  • wtf/OSAllocatorSymbian.cpp: Added.

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
(WTF::OSAllocator::release):

  • wtf/OSAllocatorWin.cpp: Added.

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
(WTF::OSAllocator::release): The new OSAllocator abstraction.

  • wtf/wtf.pri: Added OSAllocatorSymbian.cpp.
5:55 PM Changeset in webkit [73090] by andersca@apple.com
  • 17 edits in trunk/WebKit2

Give the fake Carbon window the right bounds
​https://bugs.webkit.org/show_bug.cgi?id=50361

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::windowAndViewFramesChanged):

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowAndViewFrames]):
Pass both the window frame and view frame along.

(-[WKView renewGState]):
Call _updateWindowAndViewFrames.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::windowAndViewFramesChanged):
Pass both the window frame and view frame along.

  • UIProcess/WebPageProxy.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformPostInitialize):
We don't want a title bar in our fake window.

(WebKit::computeFakeWindowBoundsRect):
Compute the fake window bounds.

(WebKit::NetscapePlugin::windowAndViewFramesChanged):
Update the fake window bounds.

  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::windowAndViewFramesChanged):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::windowAndViewFramesChanged):
(WebKit::PluginView::initializePlugin):

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowAndViewFramesChanged):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::windowFrameInScreenCoordinates):
(WebKit::WebPage::viewFrameInWindowCoordinates):

  • WebProcess/WebPage/WebPage.messages.in:

Pass both the window frame and view frame along.

5:50 PM Changeset in webkit [73089] by thakis@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-12-01 Nico Weber <​thakis@chromium.org>

More baselines after ​http://trac.webkit.org/changeset/72689
​https://bugs.webkit.org/show_bug.cgi?id=50040

The rebaseline script didn't find these, because they're only wrong
in platform/mac-leopard. I use Snow Leopard, so the script didn't look
there. The bots on the other hand use Leopard, so they complain. I
manually copied the expectations from platfrom/mac to
platform/chromium-mac. Explanation by jamesr.

  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum: Added.
5:19 PM Changeset in webkit [73088] by Darin Adler
  • 45 edits
    4 adds in trunk

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::getGuessesForWord):
  • src/EditorClientImpl.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::getGuessesForWord):
  • WebCoreSupport/EditorClientQt.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::getGuessesForWord):
  • WebCoreSupport/EditorClientGtk.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::getGuessesForWord):
  • WebCoreSupport/WebEditorClient.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::getGuessesForWord):
  • WebKitSupport/EditorClientWx.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

This patch is for supporting multiple correction suggestion panel on Mac OS X.
The behavior and implementation is similar to that of reversion candiate panel.

  • WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
  • WebCoreSupport/WebEditorClient.mm: Adopted new signatures defined in base class. Added code to handle new multiple suggestion canidate panel type. (WebEditorClient::showCorrectionPanel): (WebEditorClient::getGuessesForWord):

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::getGuessesForWord):
  • WebCoreSupport/EditorClientHaiku.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::getGuessesForWord):
  • WebCoreSupport/EditorClientWinCE.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::getGuessesForWord):
  • WebCoreSupport/EditorClientEfl.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Test: platform/mac/editing/spelling/delete-autocorrected-word-1.html
Manual test: WebCore/manual-tests/autocorrection/dismiss-multiple-guesses.html

WebCore/manual-tests/autocorrection/select-from-multiple-guesses.html

This patch is for supporting multiple correction suggestion panel on Mac OS X.
The behavior and implementation is similar to that of reversion candiate panel.

  • WebCore.exp.in: Added and removed symbols.
  • editing/CorrectionPanelInfo.h: Added new correction panel type, PanelTypeSpellingSuggestions.
  • editing/Editor.cpp: (WebCore::markerTypesForAutocorrection): Convenient function for getting marker types to be added to autocorrected word. (WebCore::boundingBoxForRange): Convenient function for calculating the bounding box of a range. (WebCore::markerTypesForReplacement): Convenient function for getting marker types to be added to word that has been replaced by various correction panel. (WebCore::Editor::respondToChangedSelection): Added code to trigger timer for multiple suggestion panel. (WebCore::Editor::guessesForMisspelledSelection): Adopted new signature of EditorClient::getGuessesForWord(). (WebCore::Editor::markMisspellingsAfterTypingToWord): Adopted new signature of applyCorrectionPanelInfo(). (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto. (WebCore::Editor::correctionPanelTimerFired): Added code to handle new multiple suggestion panel. (WebCore::Editor::handleCorrectionPanelResult): Replaced handleRejectedCorrection(), since with new AppKit correction panel API, not only rejection, but also confirmation can be handled in callback. (WebCore::Editor::stopCorrectionPanelTimer): Moved the code that clears correction panel info from dismissCorrectionPanel() to this function to fix a bug that would occur when deleting autocorrected word. (WebCore::Editor::dismissCorrectionPanel): Ditto. (WebCore::Editor::applyCorrectionPanelInfo): Added code to handle new multiple suggestion panel.
  • editing/Editor.h: Replaced handleRejectedCorrection() with handleCorrectionPanelResult(). Changed the signature of applyCorrectionPanelInfo() to hanlde new correction panel type.
  • editing/TextCheckingHelper.cpp: (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Adopted new EditorClient::getGuessesForWord().
  • editing/TextCheckingHelper.h: Made paragraphRange() public.
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature defined in base class. (WebCore::EmptyEditorClient::getGuessesForWord): Ditto.
  • manual-tests/autocorrection/dismiss-multiple-guesses.html: Added.
  • manual-tests/autocorrection/select-from-multiple-guesses.html: Added.
  • page/EditorClient.h: Changed showCorrectionPanel() to allow passing multiple correction candidates. Changed getGuessesForWord() to allow passing in contextual text for better correction suggestions (for those spellcheckers that utilizes such contextual information).

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt: Added.
  • platform/mac/editing/spelling/delete-autocorrected-word-1.html: Added.

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signatures defined in base class.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::getGuessesForWord):
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::showCorrectionPanel):
4:56 PM Changeset in webkit [73087] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=50360

Reviewed by James Robinson.

Make sure to include the origin adjustment code that I added on Mac to keep truncation-rtl.html passing.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

4:23 PM Changeset in webkit [73086] by bweinstein@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Land Windows specific results for /vertical-scrollbar-in-rtl.html
after r73063.

  • platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
4:21 PM Changeset in webkit [73085] by rniwa@webkit.org
  • 4 edits
    4 copies in branches/chromium/597

Merge 73052 - 2010-12-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.

chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (cf0d0f28bc56f2591cc74f71b46036ea)
​https://bugs.webkit.org/show_bug.cgi?id=47808

The crash was caused by moveParagraphWithClones' not copying the entire paragraph
when called by doApplyForSingleParagraph, which was induced by a bug in
cloneParagraphUnderNewElement which ended the cloning process early when the start node
and the end node didn't share the same parent node. Fixed the bug in cloneParagraphUnderNewElement
by calling traverseNextSibling(outerNode) instead of nextSibling().

Also added an early exit to InsertListCommand::doApply when lastSelectionRange is null.

Tests: editing/execCommand/switch-multiple-list-items-crash.html

editing/execCommand/switch-multiple-list-items.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):

2010-12-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.

chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (cf0d0f28bc56f2591cc74f71b46036ea)
​https://bugs.webkit.org/show_bug.cgi?id=47808

Added tests to ensure WebKit can switch the type of multiple list items without a crash.

  • editing/execCommand/switch-multiple-list-items-crash-expected.txt: Added.
  • editing/execCommand/switch-multiple-list-items-crash.html: Added.
  • editing/execCommand/switch-multiple-list-items-expected.txt: Added.
  • editing/execCommand/switch-multiple-list-items.html: Added.

TBR=​rniwa@webkit.org
BUG=59557
Review URL: ​http://codereview.chromium.org/5536001

4:14 PM Changeset in webkit [73084] by Simon Fraser
  • 2 edits in trunk/WebKit2

2010-12-01 Simon Fraser <Simon Fraser>

Reviewed by John Sullivan.

Hit testing broken on sibling views of the WKView
<rdar://problem/8718397>

Make sure that hitView is not null when comparing with the
_layerHostingView.

  • UIProcess/API/mac/WKView.mm: (-[WKView hitTest:]):
4:06 PM Changeset in webkit [73083] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Implement the remaining PluginController/Plugin member functions
​https://bugs.webkit.org/show_bug.cgi?id=50356

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::cancelStreamLoad):
(WebKit::PluginControllerProxy::cancelManualStreamLoad):
(WebKit::PluginControllerProxy::setStatusbarText):
(WebKit::PluginControllerProxy::pluginProcessCrashed):
(WebKit::PluginControllerProxy::frameDidFinishLoading):
(WebKit::PluginControllerProxy::frameDidFail):
(WebKit::PluginControllerProxy::manualStreamDidReceiveResponse):
(WebKit::PluginControllerProxy::manualStreamDidReceiveData):
(WebKit::PluginControllerProxy::manualStreamDidFinishLoading):
(WebKit::PluginControllerProxy::manualStreamDidFail):

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::frameDidFinishLoading):
(WebKit::PluginProxy::frameDidFail):
(WebKit::PluginProxy::manualStreamDidReceiveResponse):
(WebKit::PluginProxy::manualStreamDidReceiveData):
(WebKit::PluginProxy::manualStreamDidFinishLoading):
(WebKit::PluginProxy::manualStreamDidFail):
(WebKit::PluginProxy::windowFrameChanged):
(WebKit::PluginProxy::cancelStreamLoad):
(WebKit::PluginProxy::cancelManualStreamLoad):
(WebKit::PluginProxy::setStatusbarText):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:
4:03 PM Changeset in webkit [73082] by mihaip@chromium.org
  • 4 edits in trunk/WebKitTools

2010-12-01 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

build-webkit --chromium always updates DEPS and re-generates project files
​https://bugs.webkit.org/show_bug.cgi?id=50340

Make build-webkit --chromium invoke update-webkit-chromium only when
--update-chromium is passed in, so that we don't add 20 seconds to all
builds.

Making all invocations update was added with r61883, with the goal of
making EWS bots always update. The bots will switch to using this flag
(as will all other webkit-patch build steps) so nothing should change
for them.

  • Scripts/webkitdirs.pm:
  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
4:02 PM Changeset in webkit [73081] by hyatt@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46645

Reviewed by Dan Bernstein.

Generalize overflow section scrollOriginX code to be a point and to work in both horizontal
and vertical modes.

Not testable yet, since the rightmost/leftmost/topmost/lowestPosition functions are returning
horrendously wrong values in the vertical text case for overflow:auto objects.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateOverflowStatus):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::scrolledContentOffset):
(WebCore::RenderLayer::scrollXOffset):
(WebCore::RenderLayer::scrollYOffset):
(WebCore::RenderLayer::scrollToXOffset):
(WebCore::RenderLayer::scrollToYOffset):

3:59 PM Changeset in webkit [73080] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-12-01 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add a --dry-run / -n flag
​https://bugs.webkit.org/show_bug.cgi?id=50045

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3:58 PM Changeset in webkit [73079] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-12-01 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by James Robinson.

[chromium] renderer does not realize hardware compositing is disabled and crashes
​https://bugs.webkit.org/show_bug.cgi?id=50264

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setRootGraphicsLayer): repaint always (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): null check (WebKit::WebViewImpl::reallocateRenderer):
3:55 PM Changeset in webkit [73078] by sfalken@apple.com
  • 28 edits in trunk

WinCairo build should not use link-time code generation (LTCG)
​https://bugs.webkit.org/show_bug.cgi?id=50353

Reviewed by Adam Roben.

JavaScriptCore:

WebCore:

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.vcproj:

WebKit/win:

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

WebKit2:

  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:

WebKitTools:

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • FindSafari/FindSafari.vcproj:
  • MiniBrowser/MiniBrowser.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WinLauncher/WinLauncher.vcproj:
  • record-memory-win/record-memory-win.vcproj:
3:32 PM Changeset in webkit [73077] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:23 PM Changeset in webkit [73076] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-12-01 Martin Robinson <​mrobinson@igalia.com>

Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
adding the file to the sources list was not enough to force the rebuild.

  • DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Remove an empty line at the end of this file to force a rebuild.
3:14 PM WebKitGtkLayoutTests edited by Martin Robinson
Combined all required packages into one list. Removed … (diff)
3:09 PM Changeset in webkit [73075] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Don't let harmless errorlevels from the "set" utility leak into project-specific build scripts

When using set to unset an environment variable that didn't previously
exist, set raises the errorlevel to 1. This was leaking into
project-specific scripts, causing them to think the build has failed.
We now clear the errorlevel after we finish setting environment
variables.

Fixes <​http://webkit.org/b/50350> Windows builds mysteriously fail in
some configurations

Reviewed by Steve Falkenburg.

  • win/tools/vsprops/common.vsprops: Call "cmd /c" after setting

environment variables to get rid of any errorlevel that "set" set.

3:08 PM Changeset in webkit [73074] by Adam Roben
  • 2 edits in trunk

Teach git to ignore files installed by WebKitSupportLibrary and WebKitAuxiliaryLibrary

Fixes <​http://webkit.org/b/50348> Git complains about lots of
untracked files in WebKitLibraries/win

Reviewed by Steve Falkenburg.

  • .gitignore: Added files from these libraries.
3:04 PM Changeset in webkit [73073] by Simon Fraser
  • 4 edits in trunk/WebKit2

2010-12-01 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Size changes on layer-backed drawing areas don't always end up with the correct value
​https://bugs.webkit.org/show_bug.cgi?id=50351
<rdar://problem/8692966>

When the UI process does not receive didSetSize messages promptly,
LayerBackedDrawingAreaProxy::setSize() bails early based on the
m_isWaitingForDidSetFrameNotification flag.

In this situation, the final size may be incorrect. didSetSize()
needs to compare the size that the web process has to the expected size,
and send a final setSize if they differ.

  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::didSetSize): (WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage):
  • UIProcess/LayerBackedDrawingAreaProxy.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::setSize):
3:01 PM WebKitGtkLayoutTests edited by dbates@webkit.org
Added dependency on otf-stix (diff)
2:44 PM Changeset in webkit [73072] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Tony Chang <​tony@chromium.org>

Unreviewed, one more try to get chromium drt bots green.

  • platform/chromium/test_expectations.txt:
2:27 PM Changeset in webkit [73071] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix <rdar://problem/8717674>.

Reviewed by Sam Weinig..

  • WebProcess/com.apple.WebProcess.sb:

Allow the UI process to issue file-write extensions.

2:24 PM Changeset in webkit [73070] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix windows build.

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

2:16 PM Changeset in webkit [73069] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-12-01 Martin Robinson <​mrobinson@igalia.com>

Add missing file to the TestNetscapePlugin sources list after r73057.

  • GNUmakefile.am: Add missing file.
2:15 PM Changeset in webkit [73068] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Another windows build fix.

  • UIProcess/API/C/win/WKView.cpp:

(WKViewCreate):

2:08 PM Changeset in webkit [73067] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Attempt to fix Windows build.

  • UIProcess/API/C/win/WKViewPrivate.cpp:
  • UIProcess/API/C/win/WKViewPrivate.h:
2:00 PM Changeset in webkit [73066] by weinig@apple.com
  • 65 edits
    10 adds in trunk

Add PageGrouping to WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=50332

Reviewed by Anders Carlsson.

WebKit2:

  • Adds WKPageGroupRef and WKBundlePageGroupRef API objects (backed by WebPageGroup and WebPageGroupProxy respectively).
  • Moves visibleToInjectedBundle from page to PageGroup.
  • Make userScript/userStyleSheet functions take a page group parameter.
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • Shared/WebPageGroupData.cpp: Added.

(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):

  • Shared/WebPageGroupData.h: Added.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetPageGroup):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPageGroup.cpp: Added.

(WKPageGroupGetTypeID):
(WKPageGroupCreateWithIdentifier):
(WKPageGroupCopyIdentifier):

  • UIProcess/API/C/WKPageGroup.h: Added.
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/API/C/win/WKView.cpp:

(WKViewCreate):

  • UIProcess/API/C/win/WKView.h:
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:pageGroupRef:]):
(-[WKView initWithFrame:pageNamespaceRef:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::QWKPagePrivate):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::inspectorPageGroup):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebPageGroup.cpp: Added.

(WebKit::generatePageGroupID):
(WebKit::webPageGroupMap):
(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::get):
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):

  • UIProcess/WebPageGroup.h: Added.

(WebKit::WebPageGroup::identifier):
(WebKit::WebPageGroup::pageGroupID):
(WebKit::WebPageGroup::data):
(WebKit::WebPageGroup::type):

  • UIProcess/WebPageNamespace.cpp:

(WebKit::WebPageNamespace::createWebPage):

  • UIProcess/WebPageNamespace.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageGroup):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):

  • UIProcess/win/WebView.h:

(WebKit::WebView::create):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleAddUserScript):
(WKBundleAddUserStyleSheet):
(WKBundleRemoveUserScript):
(WKBundleRemoveUserStyleSheet):
(WKBundleRemoveUserScripts):
(WKBundleRemoveUserStyleSheets):
(WKBundleRemoveAllUserContent):
(WKBundleOverrideXSSAuditorEnabledForTestRunner):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetPageGroup):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageGroup.cpp: Added.

(WKBundlePageGroupGetTypeID):
(WKBundlePageGroupCopyIdentifier):

  • WebProcess/InjectedBundle/API/c/WKBundlePageGroup.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner):
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):
(WebKit::InjectedBundle::didInitializePageGroup):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/InjectedBundleClient.cpp:

(WebKit::InjectedBundleClient::didInitializePageGroup):

  • WebProcess/InjectedBundle/InjectedBundleClient.h:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::create):
(WebKit::WebPage::WebPage):
(WebKit::WebPage::close):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::pageGroup):

  • WebProcess/WebPage/WebPageGroupProxy.cpp: Added.

(WebKit::WebPageGroupProxy::create):
(WebKit::WebPageGroupProxy::~WebPageGroupProxy):

  • WebProcess/WebPage/WebPageGroupProxy.h: Added.

(WebKit::WebPageGroupProxy::identifier):
(WebKit::WebPageGroupProxy::pageGroupID):
(WebKit::WebPageGroupProxy::isVisibleToInjectedBundle):
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
(WebKit::WebPageGroupProxy::type):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPageGroup):

  • WebProcess/WebProcess.h:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

WebKitTools:

  • Update testing harnesses to deal with new PageGroup API.
  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(WKBundleInitialize):

  • TestWebKitAPI/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::initialize):
(TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
(TestWebKitAPI::InjectedBundleController::initializeTestNamed):

  • TestWebKitAPI/InjectedBundleController.h:
  • TestWebKitAPI/InjectedBundleTest.h:

(TestWebKitAPI::InjectedBundleTest::initialize):
(TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):

  • TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextForInjectedBundleTest):

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:

(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):

  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::PlatformWebView):

  • TestWebKitAPI/win/PlatformWebViewWin.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didInitializePageGroup):
(WTR::InjectedBundle::initialize):
(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::pageGroup):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::addUserScript):
(WTR::LayoutTestController::addUserStyleSheet):
(WTR::LayoutTestController::setXSSAuditorEnabled):

  • WebKitTestRunner/TestController.cpp:
  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView):

1:53 PM Changeset in webkit [73065] by barraclough@apple.com
  • 7 edits in trunk

JavaScriptCore: 010-12-01 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCF.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/testapi/testapi.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Added property svn:eol-style.

LayoutTests: Bug 50298 - /()()()()()()()()()(?:(\10a|b)(X|Y))+/.exec("bXXaYYaY") ASSERTs

Reviewed by Sam Weinig.

  • fast/regex/script-tests/pcre-test-1.js:

Enable regex643, this now works.

1:49 PM Changeset in webkit [73064] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Ojan Vafai <​ojan@chromium.org>

[chromium] Green tree.
-​http://trac.webkit.org/changeset/73057 caused plugins/get-user-agent-with-null-npp-from-npp-new.html
-Clean up a couple mistakes from ​http://trac.webkit.org/changeset/73059
-add a bug ID for fast/regex/pcre-test-1.html

  • platform/chromium/test_expectations.txt:
1:31 PM Changeset in webkit [73063] by hyatt@apple.com
  • 13 edits
    8 adds
    2 deletes in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46645

Reviewed by Darin Adler.

Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
recently added for horizontal RTL documents and applies it to writing modes as well. Now the
scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.

This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
makes them behave the same as the cross-platform code (allowing for cross-platform results to be
landed).

WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::adjustViewSize):

  • page/mac/WebCoreFrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::maximumScrollPosition):
(WebCore::ScrollView::minimumScrollPosition):
(WebCore::ScrollView::valueChanged):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:

(WebCore::ScrollView::scrollOrigin):

  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetScrollPosition):
(WebCore::ScrollView::platformSetScrollOrigin):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxDecorations):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):
(WebCore::RenderView::docTop):
(WebCore::RenderView::docHeight):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docWidth):

  • rendering/RenderView.h:

WebKit/mac:

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
(-[WebDynamicScrollBarsView scrollOrigin]):

  • WebView/WebFrameView.mm:

(-[WebFrameView _scrollToBeginningOfDocument]):
(-[WebFrameView _scrollToEndOfDocument]):

LayoutTests:

  • fast/dom/vertical-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt: Added.
  • fast/dom/vertical-scrollbar-in-rtl-doesnt-fire-onscroll.html: Added.
  • fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
  • fast/dom/vertical-scrollbar-in-rtl.html: Added.
  • fast/dom/vertical-scrollbar-when-dir-change-expected.txt: Added.
  • fast/dom/vertical-scrollbar-when-dir-change.html: Added.
  • platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
  • platform/mac/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Removed.
1:21 PM Changeset in webkit [73062] by steveblock@google.com
  • 5 edits
    1 add in trunk/WebCore

2010-11-30 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Upstream recent changes to WebCore/platform/network/android
​https://bugs.webkit.org/show_bug.cgi?id=50224

Android implementation changes only, no new tests.

  • platform/network/NetworkingContext.h:
  • platform/network/android/CookieJarAndroid.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled):
  • platform/network/android/ProxyServerAndroid.cpp: Added. (WebCore::proxyServersForURL):
  • platform/network/android/ResourceHandleAndroid.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::loadResourceSynchronously):
  • platform/network/android/ResourceRequestAndroid.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
1:10 PM Changeset in webkit [73061] by victorw@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-12-01 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations.

  • platform/chromium/fast/xmlhttprequest: Added.
  • platform/chromium/fast/xmlhttprequest/xmlhttprequest-responsetype-abort-expected.txt: Added.
  • platform/chromium/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt: Added.
  • platform/chromium/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Added.
1:01 PM Changeset in webkit [73060] by sfalken@apple.com
  • 107 edits in trunk

.: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • .gitattributes:

ANGLE: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • src/libEGL/libEGL.vcproj: Added property svn:eol-style.
  • src/libGLESv2/libGLESv2.vcproj: Added property svn:eol-style.

JavaScriptCore: 010-12-01 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCF.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/testapi/testapi.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Added property svn:eol-style.

WebCore: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • WebCore.vcproj/QTMovieWin.vcproj: Modified property svn:eol-style.
  • WebCore.vcproj/QTMovieWinCommon.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCore.sln: Modified property svn:eol-style.
  • WebCore.vcproj/WebCore.submit.sln: Modified property svn:eol-style.
  • WebCore.vcproj/WebCore.vcproj: Modified property svn:eol-style.
  • WebCore.vcproj/WebCoreCFNetwork.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreCG.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreCURL.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreCairo.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreCommon.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreGenerated.vcproj: Modified property svn:eol-style.
  • WebCore.vcproj/WebCoreGeneratedCairo.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreGeneratedCommon.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreMediaQT.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCorePthreads.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreQuartzCore.vsprops: Added property svn:eol-style.

WebKit/win: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • WebKit.vcproj/Interfaces.vcproj: Modified property svn:eol-style.
  • WebKit.vcproj/InterfacesCommon.vsprops: Added property svn:eol-style.
  • WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
  • WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.
  • WebKit.vcproj/WebKit.vcproj: Modified property svn:eol-style.
  • WebKit.vcproj/WebKitGUID.vcproj: Modified property svn:eol-style.
  • WebKit.vcproj/WebKitGUIDCommon.vsprops: Added property svn:eol-style.
  • WebKit.vcproj/WebKitLibCommon.vsprops: Added property svn:eol-style.

WebKit2: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • win/WebKit2.submit.sln: Added property svn:eol-style.
  • win/WebKit2.vcproj: Added property svn:eol-style.
  • win/WebKit2Apple.vsprops: Added property svn:eol-style.
  • win/WebKit2CFLite.vsprops: Added property svn:eol-style.
  • win/WebKit2Common.vsprops: Added property svn:eol-style.
  • win/WebKit2DirectX.vsprops: Added property svn:eol-style.
  • win/WebKit2Generated.vcproj: Added property svn:eol-style.
  • win/WebKit2GeneratedCommon.vsprops: Added property svn:eol-style.
  • win/WebKit2WebProcess.vcproj: Added property svn:eol-style.
  • win/WebKit2WebProcessCommon.vsprops: Added property svn:eol-style.

WebKitLibraries: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • win/tools/vsprops/WinCairo.vsprops: Added property svn:eol-style.
  • win/tools/vsprops/cURL.vsprops: Added property svn:eol-style.
  • win/tools/vsprops/debug_wincairo.vsprops: Added property svn:eol-style.

WebKitTools: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
  • CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
  • DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
  • DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
  • DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
  • DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
  • DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
  • DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
  • DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
  • FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
  • FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
  • MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
  • MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
  • MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
  • MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
  • MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
  • TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
  • TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
  • TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
  • TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
  • WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
  • WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
  • WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
  • WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
  • WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
  • WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
  • WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
  • WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
  • WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
  • record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
  • record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
12:47 PM Changeset in webkit [73059] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2010-12-01 Tony Chang <​tony@chromium.org>

Unreviewed, merging drt_expectations into test_expectations in
anticipation of the switch.

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
12:46 PM Changeset in webkit [73058] by Simon Fraser
  • 5 edits in trunk/WebKit2

2010-12-01 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Crash when closing WebKit2 window with accelerated composting content
​https://bugs.webkit.org/show_bug.cgi?id=50307
<rdar://problem/8640126>

When the web page is closing, notify the drawing area, so that
the layer-backed drawing area can kill the runloop obsever,
then clear it. Clearing it is not sufficient, since the drawing
area is ref-counted.

  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::onPageClose):
  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformClear): (WebKit::LayerBackedDrawingArea::onPageClose):
12:12 PM Changeset in webkit [73057] by andersca@apple.com
  • 13 edits
    3 adds in trunk

Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
​https://bugs.webkit.org/show_bug.cgi?id=50336

Reviewed by Darin Adler.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_UserAgent):
Call the static NetscapePlugin::userAgent function instead.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent):
If the passed in NPP is null, get the NetscapePlugin currently executing NPP_New.

(WebKit::NetscapePlugin::initialize):
Keep track of the plug-in currently executing NPP_New.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

WebKitTools:

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Add new test.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPP_New):
Add default implementation/

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.

(GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
(GetUserAgentWithNullNPPFromNPPNew::NPP_New):
Get the user agent.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_New):
Call PluginTest::NPP_New.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

Add new files.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:

(webkit_test_plugin_new_instance):
Call PluginTest::NPP_New.

LayoutTests:

Add tests.

  • plugins/get-user-agent-with-null-npp-from-npp-new-expected.txt: Added.
  • plugins/get-user-agent-with-null-npp-from-npp-new.html: Added.
12:04 PM Changeset in webkit [73056] by barraclough@apple.com
  • 6 edits in trunk

Bug 50297 - \s in YARR should match BOMs.

Rubber stamped by Sam Weinig.

JavaScriptCore:

  • create_regex_tables:

LayoutTests:

This exposes a Sputnik bug, tracked by:
​http://code.google.com/p/sputniktests/issues/detail?id=34
Checking in expected failing results.

  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.12_CharacterClassEscape/S15.10.2.12_A1_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.12_CharacterClassEscape/S15.10.2.12_A2_T1-expected.txt:
  • fast/regex/script-tests/pcre-test-1.js:
12:04 PM Changeset in webkit [73055] by vangelis@chromium.org
  • 8 edits in trunk

2010-11-30 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

Get the value of the accelerated compositing triggers from the Settings
class. This allows setting the triggers via command line flags.
​https://bugs.webkit.org/show_bug.cgi?id=50301

  • public/WebSettings.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowedCompositingTriggers):
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAcceleratedCompositingFor3DTransformsEnabled): (WebKit::WebSettingsImpl::setAcceleratedCompositingForVideoEnabled): (WebKit::WebSettingsImpl::setAcceleratedCompositingForPluginsEnabled): (WebKit::WebSettingsImpl::setAcceleratedCompositingForCanvasEnabled): (WebKit::WebSettingsImpl::setAcceleratedCompositingForAnimationEnabled):
  • src/WebSettingsImpl.h:

2010-11-30 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

Adds accelerated compositing trigger flags to Settings to allow
ports to set them via command line flags, etc.
​https://bugs.webkit.org/show_bug.cgi?id=50301

  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAcceleratedCompositingFor3DTransformsEnabled): (WebCore::Settings::setAcceleratedCompositingForVideoEnabled): (WebCore::Settings::setAcceleratedCompositingForPluginsEnabled): (WebCore::Settings::setAcceleratedCompositingForCanvasEnabled): (WebCore::Settings::setAcceleratedCompositingForAnimationEnabled):
  • page/Settings.h: (WebCore::Settings::acceleratedCompositingFor3DTransformsEnabled): (WebCore::Settings::acceleratedCompositingForVideoEnabled): (WebCore::Settings::acceleratedCompositingForPluginsEnabled): (WebCore::Settings::acceleratedCompositingForCanvasEnabled): (WebCore::Settings::acceleratedCompositingForAnimationEnabled):
11:55 AM Changeset in webkit [73054] by mitz@apple.com
  • 1 edit
    1 copy
    1 add in trunk/LayoutTests

Re-added Leopard-specific results for editing/text-iterator/findString.html. In the Leopard version
of ICU, the full stop character is a word separator, so an at-word-starts search for "org" in
"webkit.org" matches.

  • platform/mac-leopard/editing/text-iterator: Added.
  • platform/mac-leopard/editing/text-iterator/findString-expected.txt: Copied from LayoutTests/editing/text-iterator/findString-expected.txt.
11:54 AM Changeset in webkit [73053] by Darin Adler
  • 2 edits in trunk/WebCore

Fixed warning seen on buildbot.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::SharedValues::SharedValues): Added #if.

11:50 AM Changeset in webkit [73052] by rniwa@webkit.org
  • 4 edits
    4 adds in trunk

2010-12-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.

chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (cf0d0f28bc56f2591cc74f71b46036ea)
​https://bugs.webkit.org/show_bug.cgi?id=47808

The crash was caused by moveParagraphWithClones' not copying the entire paragraph
when called by doApplyForSingleParagraph, which was induced by a bug in
cloneParagraphUnderNewElement which ended the cloning process early when the start node
and the end node didn't share the same parent node. Fixed the bug in cloneParagraphUnderNewElement
by calling traverseNextSibling(outerNode) instead of nextSibling().

Also added an early exit to InsertListCommand::doApply when lastSelectionRange is null.

Tests: editing/execCommand/switch-multiple-list-items-crash.html

editing/execCommand/switch-multiple-list-items.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):

2010-12-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.

chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (cf0d0f28bc56f2591cc74f71b46036ea)
​https://bugs.webkit.org/show_bug.cgi?id=47808

Added tests to ensure WebKit can switch the type of multiple list items without a crash.

  • editing/execCommand/switch-multiple-list-items-crash-expected.txt: Added.
  • editing/execCommand/switch-multiple-list-items-crash.html: Added.
  • editing/execCommand/switch-multiple-list-items-expected.txt: Added.
  • editing/execCommand/switch-multiple-list-items.html: Added.
11:46 AM Changeset in webkit [73051] by kevino@webkit.org
  • 6 edits in trunk

[wx] Build fixes after recent trunk changes.

11:41 AM Changeset in webkit [73050] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, upstreaming test suppression.

  • platform/chromium/test_expectations.txt:
11:39 AM Changeset in webkit [73049] by rniwa@webkit.org
  • 4 edits
    4 deletes in trunk

2010-12-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73047.
​http://trac.webkit.org/changeset/73047
​https://bugs.webkit.org/show_bug.cgi?id=50339

missing bug number (Requested by rniwa on #webkit).

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):

2010-12-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73047.
​http://trac.webkit.org/changeset/73047
​https://bugs.webkit.org/show_bug.cgi?id=50339

missing bug number (Requested by rniwa on #webkit).

  • editing/execCommand/switch-multiple-list-items-crash-expected.txt: Removed.
  • editing/execCommand/switch-multiple-list-items-crash.html: Removed.
  • editing/execCommand/switch-multiple-list-items-expected.txt: Removed.
  • editing/execCommand/switch-multiple-list-items.html: Removed.
11:34 AM Changeset in webkit [73048] by bweinstein@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

Add failing Windows expected results for tests that involve the xhr.arrayBuffer = 'arraybuffer',
which works on Mac, but not on Windows.

Getting arrayBuffer working on Windows is being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=50334.

  • platform/win/fast/xmlhttprequest: Added.
  • platform/win/fast/xmlhttprequest/xmlhttprequest-responsetype-abort-expected.txt: Added.
  • platform/win/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt: Added.
  • platform/win/http/tests/xmlhttprequest: Added.
  • platform/win/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Added.
11:28 AM Changeset in webkit [73047] by rniwa@webkit.org
  • 4 edits
    4 adds in trunk

2010-12-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.

The crash was caused by moveParagraphWithClones' not copying the entire paragraph
when called by doApplyForSingleParagraph, which was induced by a bug in
cloneParagraphUnderNewElement which ended the cloning process early when the start node
and the end node didn't share the same parent node. Fixed the bug in cloneParagraphUnderNewElement
by calling traverseNextSibling(outerNode) instead of nextSibling().

Also added an early exit to InsertListCommand::doApply when lastSelectionRange is null.

Tests: editing/execCommand/switch-multiple-list-items-crash.html

editing/execCommand/switch-multiple-list-items.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):

2010-12-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.

Added tests to ensure WebKit can switch the type of multiple list items without a crash.

  • editing/execCommand/switch-multiple-list-items-crash-expected.txt: Added.
  • editing/execCommand/switch-multiple-list-items-crash.html: Added.
  • editing/execCommand/switch-multiple-list-items-expected.txt: Added.
  • editing/execCommand/switch-multiple-list-items.html: Added.
11:13 AM Changeset in webkit [73046] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-12-01 Grace Kloba <​klobag@chromium.org>

Reviewed by Kenneth Russell.

[chromium] ContentLayerChromium shader should honor the platform Sk_x_SHIFT value instead of assuming BGRA color
​https://bugs.webkit.org/show_bug.cgi?id=50189

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues):Use SK_B32_SHIFT to decide whether to use RGBA or BGRA shader for Skia port.
11:08 AM Changeset in webkit [73045] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

One last Windows build fix.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):

10:59 AM Changeset in webkit [73044] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::pageDidEnterAcceleratedCompositing):
(WebKit::WebView::pageDidLeaveAcceleratedCompositing):
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):

10:51 AM Changeset in webkit [73043] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip another HTMLProgressElement test on Windows, because it's not turned on for Windows yet. Adding
progress element support on Windows is being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=49769.

  • platform/win/Skipped:
10:43 AM Changeset in webkit [73042] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • UIProcess/win/WebView.h:
10:41 AM XBL2UseCases edited by Dimitri Glazkov
(diff)
10:40 AM Changeset in webkit [73041] by vitalyr@chromium.org
  • 12 edits in trunk/LayoutTests

2010-12-01 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Updating test expectations and rebaselining.

  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.txt:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.txt:
  • platform/chromium/test_expectations.txt:
10:37 AM Changeset in webkit [73040] by yurys@chromium.org
  • 2 edits in branches/chromium/597/WebCore/inspector/front-end

Merge 73021 - 2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not make helpScreen.css lazily loaded.
​https://bugs.webkit.org/show_bug.cgi?id=50304

  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen): (WebInspector.HelpScreen.prototype._onBlur):
  • inspector/front-end/inspector.html:

BUG=64913
TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/5487001

10:36 AM Changeset in webkit [73039] by mitz@apple.com
  • 6 edits in trunk/WebKitTools

WebKitTestRunner needs layoutTestController.findString
​https://bugs.webkit.org/show_bug.cgi?id=50238

Reviewed by Darin Adler.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
10:34 AM Changeset in webkit [73038] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-12-01 Tony Chang <​tony@chromium.org>

Unreviewed, rolling chromium deps to r67811.

  • DEPS:
10:28 AM Changeset in webkit [73037] by yurys@chromium.org
  • 1 edit in branches/chromium/597/WebCore/css/CSSImportRule.cpp

Merge 72988 - 2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Dave Hyatt.

Web Inspector: [CRASH] on "Revert to this revision" of style with import.
​https://bugs.webkit.org/show_bug.cgi?id=50256

Rolled back one line from ​http://trac.webkit.org/changeset/36904 as agreed with
David.

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):

BUG=64916
TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/5482001

10:23 AM Changeset in webkit [73036] by andersca@apple.com
  • 24 edits in trunk/WebKit2

Get rid of DrawingAreaBase
​https://bugs.webkit.org/show_bug.cgi?id=50329

Reviewed by Andreas Kling.

  • Scripts/webkit2/messages.py:
  • Shared/DrawingAreaInfo.h:

(WebKit::DrawingAreaInfo::DrawingAreaInfo):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
(-[WKView _pageDidEnterAcceleratedCompositing]):
(-[WKView _pageDidLeaveAcceleratedCompositing]):

  • UIProcess/API/qt/qgraphicswkview.cpp:

(QGraphicsWKView::takeSnapshot):
(QGraphicsWKViewPrivate::commitScale):

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
(WebKit::ChunkedUpdateDrawingAreaProxy::setSize):
(WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
(WebKit::ChunkedUpdateDrawingAreaProxy::update):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::nextIdentifier):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::info):

  • UIProcess/LayerBackedDrawingAreaProxy.cpp:

(WebKit::LayerBackedDrawingAreaProxy::LayerBackedDrawingAreaProxy):
(WebKit::LayerBackedDrawingAreaProxy::setSize):
(WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible):
(WebKit::LayerBackedDrawingAreaProxy::update):

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeAcceleratedCompositing):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):
(WebKit::DrawingArea::DrawingArea):

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::info):

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
(WebKit::LayerBackedDrawingArea::didReceiveMessage):

  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::TiledDrawingArea):

  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::changeAcceleratedCompositingMode):

10:19 AM Changeset in webkit [73035] by yurys@chromium.org
  • 10 edits in branches/chromium/597/WebCore

Merge 72938 - 2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement "Revert to this revision" in resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=50107

  • inspector/Inspector.idl:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::setStyleSheetText2):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::reparseStyleSheet):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get contentTimestamp): (WebInspector.Resource.prototype.setInitialContent): (WebInspector.Resource.prototype.isLocallyModified): (WebInspector.Resource.prototype.setContent.else.finished): (WebInspector.Resource.prototype.setContent): (WebInspector.Resource.prototype.revertToThis.callback): (WebInspector.Resource.prototype.revertToThis): (WebInspector.Resource.prototype.get baseRevision): (WebInspector.Resource.prototype._innerRequestContent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showResourceView): (WebInspector.FrameResourceTreeElement.prototype._contentChanged): (WebInspector.ResourceRevisionTreeElement): (WebInspector.ResourceRevisionTreeElement.prototype.onattach): (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart): (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._editLine): (WebInspector.SourceView.prototype._editLineComplete): (WebInspector.SourceView.prototype._revertEditLine):

BUG=64915
TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/5446003

10:15 AM Changeset in webkit [73034] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Cleaning up test expectations.

  • platform/chromium/test_expectations.txt:
9:58 AM Changeset in webkit [73033] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Tony Chang <​tony@chromium.org>

Unreviewed, update drt expectations.

  • platform/chromium/drt_expectations.txt:
9:49 AM Changeset in webkit [73032] by thakis@chromium.org
  • 2 edits in trunk/WebCore

2010-12-01 Nico Weber <​thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Fix clang warnings caused by -Wlogical-op-parentheses
​https://bugs.webkit.org/show_bug.cgi?id=50324

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
9:46 AM Changeset in webkit [73031] by yurys@chromium.org
  • 1 edit in branches/chromium/597/WebCore/inspector/front-end/InjectedScript.js

Merge 72903 - 2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make copy(node) work in console.
​https://bugs.webkit.org/show_bug.cgi?id=50180

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/5469002

9:25 AM Changeset in webkit [73030] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-12-01 Martin Robinson <​mrobinson@igalia.com>

Build fix for GTK+.

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::typeAheadFind): Uncomment mistakenly commented line.
9:18 AM Changeset in webkit [73029] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Updating test expectations.

  • platform/chromium/test_expectations.txt:
9:07 AM Changeset in webkit [73028] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Try using svn:eol-style native on a vcproj file.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
9:04 AM Changeset in webkit [73027] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unrreviewed.

[Qt] Add focus ring outline color support
​https://bugs.webkit.org/show_bug.cgi?id=50325

Focus ring outline color is unsupported now.
Add failing tests to the Skipped list until fix.

  • platform/qt/Skipped:
    • fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html added
    • fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html added
    • fast/images/imagemap-focus-ring-outline-color.html added
8:49 AM Changeset in webkit [73026] by Patrick Gansterer
  • 1 edit
    2 adds in trunk/WebKitTools

2010-12-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Add WinCELauncher
​https://bugs.webkit.org/show_bug.cgi?id=50217

  • WinCELauncher/main.cpp: Added.
8:46 AM Changeset in webkit [73025] by Martin Robinson
  • 4 edits
    2 adds in trunk

2010-12-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Open menulists should support typeahead find
​https://bugs.webkit.org/show_bug.cgi?id=27443

Added a GTK+-specific layout test to track typeahead find state.

  • platform/gtk/fast/forms/menulist-typeahead-find-expected.txt: Added.
  • platform/gtk/fast/forms/menulist-typeahead-find.html: Added.

2010-12-01 Apelete Seketeli <​apelete@seketeli.org> and Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Open menulists should support typeahead find
​https://bugs.webkit.org/show_bug.cgi?id=27443

Added typeahead find support for open GTK+ menulists.

Test: platform/gtk/fast/forms/menulist-typeahead-find.html

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::PopupMenuGtk): Initialize new members. (WebCore::PopupMenuGtk::show): Track currently selected menu item via a signal handler. (WebCore::PopupMenuGtk::typeAheadFind): Added. (WebCore::PopupMenuGtk::menuUnmapped): Reset typeahead find state when menu is unmapped. (WebCore::PopupMenuGtk::resetTypeAheadFindState): Added. (WebCore::PopupMenuGtk::selectItemCallback): Added. (WebCore::PopupMenuGtk::keyPressEventCallback): Added.
  • platform/gtk/PopupMenuGtk.h: Added new members to track typeahead find state.
8:36 AM Changeset in webkit [73024] by Nikolas Zimmermann
  • 28 edits in trunk/WebCore

2010-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Xan Lopez.

Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedNumber
​https://bugs.webkit.org/show_bug.cgi?id=50323

Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_NUMBER / DEFINE_ANIMATED_NUMBER.
The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.

No functional changes, thus no new tests.

  • svg/SVGAnimatedNumber.h:
  • svg/SVGComponentTransferFunctionElement.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGFECompositeElement.cpp:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp:
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEGaussianBlurElement.cpp:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFELightElement.cpp:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMorphologyElement.cpp:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGPathElement.cpp:
  • svg/SVGPathElement.h:
  • svg/SVGStopElement.cpp:
  • svg/SVGStopElement.h: (WebCore::SVGStopElement::isGradientStop):
8:15 AM Changeset in webkit [73023] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-12-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Sliders are not transformed after r50188
​https://bugs.webkit.org/show_bug.cgi?id=50317

Need to call updateLayerTransform during slider layout, as sliders
may be transformed.

No new tests. This patch should make fast/forms/slider-transformed.html
pass on the GTK+ bots.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Call updateLayerTransform here.
8:13 AM Changeset in webkit [73022] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-12-01 Martin Robinson <​mrobinson@igalia.com>

Skip failing tests for text height on GTK
​https://bugs.webkit.org/show_bug.cgi?id=50314

  • platform/gtk/Skipped: Skip failing tests.
7:52 AM Changeset in webkit [73021] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not make helpScreen.css lazily loaded.
​https://bugs.webkit.org/show_bug.cgi?id=50304

  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen): (WebInspector.HelpScreen.prototype._onBlur):
  • inspector/front-end/inspector.html:
7:41 AM Changeset in webkit [73020] by Nikolas Zimmermann
  • 23 edits in trunk/WebCore

2010-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Xan Lopez.

Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLengthList/SVGNumberList/SVGTransformList
​https://bugs.webkit.org/show_bug.cgi?id=50322

Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_(LENGTH|NUMBER|TRANSFORM)_LIST / DEFINE_ANIMATED_(LENGTH|NUMBER|TRANSFORM).
The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.

No functional changes, thus no new tests.

  • svg/SVGAnimatedLengthList.h:
  • svg/SVGAnimatedNumberList.h:
  • svg/SVGAnimatedTransformList.h:
  • svg/SVGComponentTransferFunctionElement.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGFEColorMatrixElement.cpp:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGGradientElement.cpp:
  • svg/SVGGradientElement.h: (WebCore::SVGGradientElement::needsPendingResourceHandling):
  • svg/SVGPatternElement.cpp:
  • svg/SVGPatternElement.h:
  • svg/SVGPolygonElement.cpp:
  • svg/SVGPolylineElement.cpp:
  • svg/SVGStyledTransformableElement.cpp:
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement):
  • svg/SVGTextElement.h: (WebCore::SVGTextElement::localCoordinateSpaceTransform):
  • svg/SVGTextPositioningElement.cpp:
  • svg/SVGTextPositioningElement.h:
  • svg/properties/SVGAnimatedPropertyMacros.h:
7:32 AM Changeset in webkit [73019] by chang.shu@nokia.com
  • 1 edit
    3 moves
    2 adds in trunk/LayoutTests

2010-12-01 Chang Shu <​chang.shu@nokia.com>

Reviewed by Laszlo Gombos.

Move orientation event test case to a better place.
​https://bugs.webkit.org/show_bug.cgi?id=32492

  • fast/dom/DeviceOrientation/create-event-orientationchange-expected.txt: Removed.
  • fast/dom/DeviceOrientation/create-event-orientationchange.html: Removed.
  • fast/dom/DeviceOrientation/script-tests/create-event-orientationchange.js: Removed.
  • fast/dom/Orientation: Added.
  • fast/dom/Orientation/create-event-orientationchange-expected.txt: Copied from LayoutTests/fast/dom/DeviceOrientation/create-event-orientationchange-expected.txt.
  • fast/dom/Orientation/create-event-orientationchange.html: Copied from LayoutTests/fast/dom/DeviceOrientation/create-event-orientationchange.html.
  • fast/dom/Orientation/script-tests: Added.
  • fast/dom/Orientation/script-tests/create-event-orientationchange.js: Copied from LayoutTests/fast/dom/DeviceOrientation/script-tests/create-event-orientationchange.js.
6:14 AM Changeset in webkit [73018] by apavlov@chromium.org
  • 4 edits in trunk

2010-12-01 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: name-only property appears in style declaration but not in the Styles pane
​https://bugs.webkit.org/show_bug.cgi?id=49663

Check that at least one property has been parsed from the user input.

WebCore:

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::setPropertyText):

LayoutTests:

  • inspector/styles-new-API.html:
5:29 AM Changeset in webkit [73017] by caseq@chromium.org
  • 5 edits in trunk

2010-12-01 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: disable cookies tab in network resource view by default, enable for chromium
​https://bugs.webkit.org/show_bug.cgi?id=50249

  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView): (WebInspector.NetworkItemView.prototype.resize):
  • inspector/front-end/Settings.js:

2010-12-01 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: disable cookies tab in network resource view by default, enable for chromium
​https://bugs.webkit.org/show_bug.cgi?id=50249

  • src/js/DevTools.js:
4:17 AM Changeset in webkit [73016] by Nikolas Zimmermann
  • 40 edits in trunk/WebCore

2010-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Xan Lopez.

Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLength
​https://bugs.webkit.org/show_bug.cgi?id=50316

Introduce DECLARE_ANIMATED_LENGTH / DEFINE_ANIMATED_LENGTH, splitting up the original DECLARE_ANIMATED_PROPERTY_NEW macro
in a part that goes in the .cpp file and another that remains in the header. This avoids having to include SVGNames.h
in all SVG*Element files.

No functional changes, thus no new tests.

  • svg/SVGAnimatedLength.h:
  • svg/SVGCircleElement.cpp:
  • svg/SVGCircleElement.h: (WebCore::SVGCircleElement::isValid):
  • svg/SVGCursorElement.cpp:
  • svg/SVGCursorElement.h: (WebCore::SVGCursorElement::isValid):
  • svg/SVGEllipseElement.cpp:
  • svg/SVGEllipseElement.h: (WebCore::SVGEllipseElement::isValid):
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
  • svg/SVGForeignObjectElement.h: (WebCore::SVGForeignObjectElement::isValid):
  • svg/SVGImageElement.cpp:
  • svg/SVGImageElement.h: (WebCore::SVGImageElement::isValid):
  • svg/SVGLineElement.cpp:
  • svg/SVGLineElement.h: (WebCore::SVGLineElement::isValid): (WebCore::SVGLineElement::supportsMarkers):
  • svg/SVGLinearGradientElement.cpp:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp:
  • svg/SVGMaskElement.h: (WebCore::SVGMaskElement::isValid): (WebCore::SVGMaskElement::needsPendingResourceHandling):
  • svg/SVGPatternElement.cpp:
  • svg/SVGPatternElement.h: (WebCore::SVGPatternElement::isValid): (WebCore::SVGPatternElement::needsPendingResourceHandling):
  • svg/SVGRadialGradientElement.cpp:
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp:
  • svg/SVGRectElement.h: (WebCore::SVGRectElement::isValid):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
  • svg/SVGSVGElement.h: (WebCore::SVGSVGElement::isValid): (WebCore::SVGSVGElement::setContainerSize): (WebCore::SVGSVGElement::containerSize): (WebCore::SVGSVGElement::hasSetContainerSize): (WebCore::SVGSVGElement::currentTranslate): (WebCore::SVGSVGElement::timeContainer): (WebCore::SVGSVGElement::isSVG): (WebCore::SVGSVGElement::rendererIsNeeded):
  • svg/SVGTextContentElement.cpp:
  • svg/SVGTextContentElement.h: (WebCore::SVGTextContentElement::isValid): (WebCore::SVGTextContentElement::isTextContent):
  • svg/SVGTextPathElement.cpp:
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.h:
  • svg/SVGUseElement.cpp:
  • svg/SVGUseElement.h: (WebCore::SVGUseElement::isValid): (WebCore::SVGUseElement::setUpdatesBlocked): (WebCore::SVGUseElement::isPendingResource):
  • svg/properties/SVGAnimatedPropertyMacros.h:
4:03 AM Changeset in webkit [73015] by commit-queue@webkit.org
  • 5 edits in trunk

2010-12-01 Anton D'Auria <​adauria@apple.com>

Reviewed by Kevin Decker.

Private browsing denies read access to local and session storage,
so updating expected test results.

​https://bugs.webkit.org/show_bug.cgi?id=49329

  • storage/domstorage/localstorage/private-browsing-affects-storage-expected.txt:
  • storage/domstorage/sessionstorage/private-browsing-affects-storage-expected.txt:

2010-12-01 Anton D'Auria <​adauria@apple.com>

Reviewed by Kevin Decker.

Deny access to local and session storage in private browsing mode.
​https://bugs.webkit.org/show_bug.cgi?id=49329

  • storage/Storage.cpp: (WebCore::Storage::length): (WebCore::Storage::key): (WebCore::Storage::getItem): (WebCore::Storage::contains):
3:41 AM Changeset in webkit [73014] by Philippe Normand
  • 4 edits in trunk/WebCore

2010-12-01 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

Volume control not correctly initialized
​https://bugs.webkit.org/show_bug.cgi?id=36299

Replaced the mute/volume Timers with g_timeouts which are (for
now, at least) more reliable than Timers for one-shot-fire-now
actions.

Test: media/video-volume.html

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::~MediaPlayer): Reset the raw pointers to 0 when destructing the player.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateVolumeChangeTimeoutCallback): (WebCore::mediaPlayerPrivateMuteChangeTimeoutCallback): (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVolumeChange): (WebCore::MediaPlayerPrivateGStreamer::volumeChanged): (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfMute): (WebCore::MediaPlayerPrivateGStreamer::muteChanged): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Set playbin2 volume/mute base on MediaPlayer related values.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
3:32 AM Changeset in webkit [73013] by hayato@chromium.org
  • 5 edits in trunk/LayoutTests

2010-12-01 Hayato Ito <​hayato@chromium.org>

Unreviewed trivial fix.

Removed fast/regex/{test1,test4}.html because they were removed from tree by r72990

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
2:47 AM Changeset in webkit [73012] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-12-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Cleanup main CMakeLists.txt after r72664, r72672 and r72667
​https://bugs.webkit.org/show_bug.cgi?id=50232

  • CMakeLists.txt: Removed obsolete dependencies.
12:57 AM Changeset in webkit [73011] by Nikolas Zimmermann
  • 25 edits
    1 add in trunk/WebCore

2010-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Cleanup SVGPropertyTraits
​https://bugs.webkit.org/show_bug.cgi?id=50229

Move all template specializations for non-POD types (eg. SVGLength, SVGLengthList, etc.) from SVGPropertyTraits
into the right SVG* classes, to avoid having to include a dozen SVG*.h files in SVGPropertyTraits.h, which is
included by all DOM/JS/V8 binding files and SVGElement.h.

No new functionality, thus no new tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • svg/SVGAngle.h:
  • svg/SVGLength.h:
  • svg/SVGLengthList.h:
  • svg/SVGMarkerElement.h:
  • svg/SVGNumberList.h:
  • svg/SVGPatternElement.h:
  • svg/SVGPointList.h:
  • svg/SVGPreserveAspectRatio.h:
  • svg/SVGRect.h: Added.
  • svg/SVGSVGElement.h:
  • svg/SVGStringList.h:
  • svg/SVGSymbolElement.h:
  • svg/SVGTransformList.h:
  • svg/SVGViewElement.h:
  • svg/SVGViewSpec.h:
  • svg/properties/SVGListProperty.h:
  • svg/properties/SVGPropertyTraits.h:
  • svg/properties/SVGTransformListPropertyTearOff.h:
12:13 AM Changeset in webkit [73010] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

  • platform/qt/Skipped:
    • editing/selection/5109817.html: removed, because it was removed from tree by r73009
    • fast/regex/test1.html: removed, because it was removed from tree by r72990
    • fast/regex/test4.html: removed, because it was removed from tree by r72990
Note: See TracTimeline for information about the timeline view.