⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 7, 2010:

10:45 PM Changeset in webkit [73491] by antonm@chromium.org
  • 3 edits in trunk/WebCore

2010-12-07 Anton Muhin <​antonm@chromium.org>

Reviewed by Nate Chapin.

Port ​http://trac.webkit.org/changeset/72819/ to v8-backed ports.
​https://bugs.webkit.org/show_bug.cgi?id=50246

  • bindings/v8/V8DOMMap.h: (WebCore::AbstractWeakReferenceMap::Visitor::startMap): (WebCore::AbstractWeakReferenceMap::Visitor::endMap): (WebCore::WeakReferenceMap::visit):
  • bindings/v8/V8GCController.cpp: (WebCore::GrouperItem::GrouperItem): (WebCore::GrouperItem::groupId): (WebCore::makeV8ObjectGroups): (WebCore::NodeGrouperVisitor::NodeGrouperVisitor): (WebCore::NodeGrouperVisitor::visitDOMWrapper): (WebCore::NodeGrouperVisitor::applyGrouping): (WebCore::DOMObjectGrouperVisitor::ObjectGrouperVisitor): (WebCore::DOMObjectGrouperVisitor::startMap): (WebCore::DOMObjectGrouperVisitor::endMap): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper): (WebCore::V8GCController::gcPrologue):
8:49 PM Changeset in webkit [73490] by dbates@webkit.org
  • 5 edits
    20 adds in trunk

2010-12-07 Daniel Bates <​dbates@rim.com>

Reviewed by Martin Robinson.

Implement focus ring support for image maps
​https://bugs.webkit.org/show_bug.cgi?id=50371

Implement GraphicsContext::drawFocusRing(const Path&, ...) so as to support
drawing a focus ring for image maps.

Tests: fast/images/imagemap-circle-focus-ring.html

fast/images/imagemap-polygon-focus-ring.html

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::adjustFocusRingColor): Added. (WebCore::adjustFocusRingLineWidth): Added. (WebCore::focusRingStrokeStyle): Added. (WebCore::GraphicsContext::drawFocusRing): Moved code for determining focus ring- color, line width and stroke style into functions adjustFocusRingColor(), adjustFocusRingLineWidth(), and focusRingStrokeStyle(), respectively. Implemented GraphicsContext::drawFocusRing(const Path&, ...).

2010-12-07 Daniel Bates <​dbates@rim.com>

Reviewed by Martin Robinson.

Implement focus ring support for image maps
​https://bugs.webkit.org/show_bug.cgi?id=50371

Tests to ensure that we support drawing a focus ring for an image map.
In particular, that the GTK port can draw a focus ring for an image map.

  • fast/images/imagemap-circle-focus-ring.html: Added.
  • fast/images/imagemap-polygon-focus-ring.html: Added.
  • platform/gtk/fast/images/imagemap-circle-focus-ring-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/gtk/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-expected.checksum: Rebase result since we now support drawing a focus ring for imagemaps.
  • platform/gtk/fast/images/imagemap-focus-ring-expected.png: Ditto.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/mac/fast/images/imagemap-circle-focus-ring-expected.checksum: Added.
  • platform/mac/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/mac/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/mac/fast/images/imagemap-polygon-focus-ring-expected.checksum: Added.
  • platform/mac/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/mac/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
8:33 PM Changeset in webkit [73489] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-07 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitSoupCache fails to load resources when cache contents are externally removed
​https://bugs.webkit.org/show_bug.cgi?id=50577

Try to download cached resources again if they are no longer
accesible by the cache.

  • platform/network/soup/cache/soup-request-http.c: (send_async_cb): (webkit_soup_request_http_send_async):
8:21 PM Changeset in webkit [73488] by morrita@google.com
  • 21 edits
    2 adds in trunk

2010-12-05 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

  • Added a test case
  • Updated expectations to follow the change on the shadow structure.

RenderIndicator subclasses should not change the render tree during layout.
​https://bugs.webkit.org/show_bug.cgi?id=50026

  • fast/dom/HTMLMeterElement/meter-element-crash-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-element-crash.html: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

2010-12-06 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

RenderIndicator subclasses should not change the render tree during layout.
​https://bugs.webkit.org/show_bug.cgi?id=50026

The old code created shadow elements during a layout computation,
that makes the layout state inconsisntent and cause an assertion failure.
This change created shadow elements before the layout to avoid
state inconsistencies.

Instead of creating shadows on demand, RenderMeter and
RenderProgress now create all necessary shadows before layouts,
and change its visibilities during the layout: Changing
visibilities doesn't trigger relayout and keep the state
consistent.

RenderMeter uses new HidablePartElement for shadow elements,
which can toggle visibiliby between hidden and original value.

Test: fast/dom/HTMLMeterElement/meter-element-crash.html

  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::attach): Calling updateFromElement()
  • html/HTMLMeterElement.h:
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::attach): Calling updateFromElement()
  • html/HTMLProgressElement.h:
  • rendering/RenderIndicator.cpp:
  • rendering/RenderIndicator.h:
  • rendering/RenderMeter.cpp: (WebCore::MeterPartElement::MeterPartElement): Added to hold a restorable visibility. (WebCore::MeterPartElement::createForPart): (WebCore::MeterPartElement::hide): (WebCore::MeterPartElement::restoreVisibility): (WebCore::MeterPartElement::updateStyleForPart): (WebCore::MeterPartElement::saveVisibility): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::createPart): Extracted (WebCore::RenderMeter::updateFromElement): Had a shadow generation. (WebCore::RenderMeter::layoutParts): Removed shadow generation code. (WebCore::RenderMeter::shouldHaveParts): (WebCore::RenderMeter::valuePartRect): Adopted orientation. (WebCore::RenderMeter::orientation): Morphed from isHorizontal() (WebCore::RenderMeter::valuePseudoId): Adoptedn orientation (WebCore::RenderMeter::barPseudoId): Adopted orientation.
  • rendering/RenderMeter.h: (WebCore::RenderMeter::shadowAttached):
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::updateFromElement): Had a shadow generation. (WebCore::RenderProgress::layoutParts):
  • rendering/RenderProgress.h:
  • rendering/ShadowElement.cpp: (WebCore::ShadowBlockElement::createForPart): Extracted initAsPart(). (WebCore::ShadowBlockElement::initAsPart): Extracted from createForPart().
  • rendering/ShadowElement.h:
6:44 PM Changeset in webkit [73487] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2010-12-07 Simon Fraser <Simon Fraser>

Relax the matching tolerance to reduce flakiness.

  • transitions/border-radius-transition.html:
6:32 PM Changeset in webkit [73486] by mihaip@chromium.org
  • 6 edits
    10 adds
    2 deletes in trunk

2010-11-29 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

returning to a POST result within a frame does a GET instead of a POST
​https://bugs.webkit.org/show_bug.cgi?id=10199

Re-enable postredirect-frames-goback1.html and post-frames-goback1.html
now that the big that made them be checked in disabled was fixed.

The tests were also re-written to not be pixel tests, since that just
adds extra per-platform baseline pain.

Add fast/history/history-back-initial-vs-final-url.html since there did
not appear to be any tests for whether we used the initial or final URL
of a frame's history item (and this patch changes it from the former to
the latter).

  • fast/history/history-back-initial-vs-final-url-expected.txt: Added.
  • fast/history/history-back-initial-vs-final-url.html: Added.
  • fast/history/resources/frame-final-url.html: Added.
  • fast/history/resources/frame-initial-url.html: Added.
  • http/tests/navigation/post-frames-goback1-expected.txt: Added.
  • http/tests/navigation/post-frames-goback1.html: Added.
  • http/tests/navigation/post-frames-goback1.html-disabled: Removed.
  • http/tests/navigation/post-frames.html:
  • http/tests/navigation/postredirect-frames-goback1-expected.txt: Added.
  • http/tests/navigation/postredirect-frames-goback1.html: Added.
  • http/tests/navigation/postredirect-frames-goback1.html-disabled: Removed.
  • http/tests/navigation/resources/form-target.pl:
  • http/tests/navigation/resources/redirect-to-go-back.pl: Added.
  • http/tests/navigation/resources/top-go-back.html: Added.

2010-11-29 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

returning to a POST result within a frame does a GET instead of a POST
​https://bugs.webkit.org/show_bug.cgi?id=10199

FrameLoader::loadURLIntoChildFrame had a check for whether a frame
had a HistoryItem, and if so used that item's URL. However, that did
not handle the case where the HistoryItem had FormData and thus was the
result of a POST request. FrameLoader::navigateToDifferentDocument (now
renamed to loadDifferentDocumentItem) does all that, so just switch to
using it instead.

Besides the bug fix, the only difference in behavior is that we use the
HistoryItem's URL instead of original URL when restoring it in a child
frame. This seems desirable too (for consistency with other browsers, and
so that we can avoid form double-submits for forms that that do
POST-then-redirect), and is tested by
fast/history/history-back-initial-vs-final-url.html.

Tests: fast/history/history-back-initial-vs-final-url.html

http/tests/navigation/post-frames-goback1.html
http/tests/navigation/postredirect-frames-goback1.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): Switch to using

loadDifferentDocumentItem. Also cleaned up ordering slightly (if
on the archive path, there's no need to do any of the other checks).

(WebCore::FrameLoader::loadDifferentDocumentItem): Renamed from

navigateToDifferentDocument so that calling it from loadItem and
loadURLIntoChildFrame flows more easily.

(WebCore::FrameLoader::loadSameDocumentItem): Similarly, renamed from

navigateWithinDocument.

(WebCore::FrameLoader::loadItem): Update callsites to the above methods.

  • loader/FrameLoader.h:
6:27 PM Changeset in webkit [73485] by mrowe@apple.com
  • 9 edits
    1 delete in trunk

Roll out r73477 and r73483 since they broke the Mac SnowLeopard build.

5:37 PM Changeset in webkit [73484] by mitz@apple.com
  • 3 edits
    8 adds in trunk

WebCore: Made tables repaint correctly in all writing modes
Part of: Make tables work with vertical text
​https://bugs.webkit.org/show_bug.cgi?id=46417

Reviewed by Darin Adler.

Tests: fast/repaint/table-writing-modes-h.html

fast/repaint/table-writing-modes-v.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintObject): Compute the ranges of rows and
columns to repaint based on the logical extent of the repaint rect.

LayoutTests: Test that tables repaint correctly in all writing modes
Part of: Make tables work with vertical text
​https://bugs.webkit.org/show_bug.cgi?id=46417

Reviewed by Darin Adler.

  • fast/repaint/table-writing-modes-h-expected.checksum: Added.
  • fast/repaint/table-writing-modes-h-expected.png: Added.
  • fast/repaint/table-writing-modes-h-expected.txt: Added.
  • fast/repaint/table-writing-modes-h.html: Added.
  • fast/repaint/table-writing-modes-v-expected.checksum: Added.
  • fast/repaint/table-writing-modes-v-expected.png: Added.
  • fast/repaint/table-writing-modes-v-expected.txt: Added.
  • fast/repaint/table-writing-modes-v.html: Added.
5:17 PM Changeset in webkit [73483] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2010-12-07 Chris Marrin <​cmarrin@apple.com>

Unreviewed.

Fix build problem from ​http://trac.webkit.org/changeset/73477

  • platform/graphics/transforms/TransformationMatrix.h:
5:03 PM Changeset in webkit [73482] by jamesr@google.com
  • 2 edits in branches/chromium/597/WebCore

Merge 73479 - 2010-12-07 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by James Robinson.

[chromium] compositor lost context recovery fix
​https://bugs.webkit.org/show_bug.cgi?id=50614

To test, load a page that triggers the compositor, kill the GPU
process and hover over a link to redraw and thus restart the GPU
process. Without this patch it will assert in
ContentLayerChromium::updateTextureRect; with this patch it will not.

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setNeedsDisplay):

TBR=​amarinichev@chromium.org
BUG=65194

Review URL: ​http://codereview.chromium.org/5639006

5:02 PM Changeset in webkit [73481] by jschuh@chromium.org
  • 7 edits
    2 copies in branches/chromium/552

2010-12-07 Justin Schuh <​jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
​https://bugs.webkit.org/show_bug.cgi?id=50549

Test: svg/css/cursor-replace.svg

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): (WebCore::SVGCursorElement::removeClient): (WebCore::SVGCursorElement::removeReferencedElement):
  • svg/SVGCursorElement.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::setCursorElement): (WebCore::SVGElement::cursorElementRemoved): (WebCore::SVGElement::setCursorImageValue): (WebCore::SVGElement::cursorImageElementRemoved):
  • svg/SVGElement.h:

2010-12-07 Justin Schuh <​jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
​https://bugs.webkit.org/show_bug.cgi?id=50549

  • svg/css/cursor-replace-expected.txt: Added.
  • svg/css/cursor-replace.svg: Added.

BUG=64959
TBR=​jschuh@chromium.org

4:58 PM Changeset in webkit [73480] by jamesr@google.com
  • 3 edits in branches/chromium/597/WebCore

Merge 73424 - 2010-12-06 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Throw webglcontextlost and webglcontextrestored events when a WebGL context is lost and restored.
​https://bugs.webkit.org/show_bug.cgi?id=50364

No new tests since there is currently no way to force a context lost event.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired): (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::isContextLost): (WebCore::WebGLRenderingContext::loseContext): (WebCore::WebGLRenderingContext::restoreContext):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::WebGLRenderingContextRestoreTimer):

TBR=​amarinichev@chromium.org
BUG=57176

Review URL: ​http://codereview.chromium.org/5511013

4:53 PM Changeset in webkit [73479] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-12-07 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by James Robinson.

[chromium] compositor lost context recovery fix
​https://bugs.webkit.org/show_bug.cgi?id=50614

To test, load a page that triggers the compositor, kill the GPU
process and hover over a link to redraw and thus restart the GPU
process. Without this patch it will assert in
ContentLayerChromium::updateTextureRect; with this patch it will not.

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setNeedsDisplay):
4:41 PM Changeset in webkit [73478] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <​tony@chromium.org>

Unreviewed, mark a test as flaky on chromium drt linux.

  • platform/chromium/test_expectations.txt:
4:31 PM Changeset in webkit [73477] by cmarrin@apple.com
  • 9 edits
    1 add in trunk

2010-12-07 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
​https://bugs.webkit.org/show_bug.cgi?id=49388

Added copy constructors and casting operators to go between
TransformationMatrix and CATransform3D. Also added a copy
constructor to go from CGAffineTransform to TransformationMatrix.
Used these new methods to clean up platform CA code. This will
make it easier to port to Windows.

I also fixed a couple of build issues found when trying out a
Windows build.

4:31 PM Changeset in webkit [73476] by tony@chromium.org
  • 5 edits
    2 adds in trunk/LayoutTests

2010-12-07 Tony Chang <​tony@chromium.org>

Unreviewed, adding chromium pixel results for
fast/forms/caret-rtl.html after ​http://trac.webkit.org/changeset/73459

  • platform/chromium-linux/fast/forms/caret-rtl-expected.checksum:
  • platform/chromium-linux/fast/forms/caret-rtl-expected.png:
  • platform/chromium-mac/fast/forms/caret-rtl-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/caret-rtl-expected.png: Added.
  • platform/chromium-win/fast/forms/caret-rtl-expected.checksum:
  • platform/chromium-win/fast/forms/caret-rtl-expected.png:
4:26 PM Changeset in webkit [73475] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix the last clang++ build error.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::animationForKey):
Cast the returned animation to the correct type.

3:55 PM Changeset in webkit [73474] by andersca@apple.com
  • 4 edits in trunk/WebCore

Fix some clang++ build errors.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Remove unused variable.

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

Fix constness of pointers.

3:54 PM Changeset in webkit [73473] by jschuh@chromium.org
  • 5 edits
    2 copies in branches/chromium/597

Merge 73432 - 2010-12-07 Justin Schuh <​jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
​https://bugs.webkit.org/show_bug.cgi?id=50549

Test: svg/css/cursor-replace.svg

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): (WebCore::SVGCursorElement::removeClient): (WebCore::SVGCursorElement::removeReferencedElement):
  • svg/SVGCursorElement.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::setCursorElement): (WebCore::SVGElement::cursorElementRemoved): (WebCore::SVGElement::setCursorImageValue): (WebCore::SVGElement::cursorImageElementRemoved):
  • svg/SVGElement.h:

2010-12-07 Justin Schuh <​jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
​https://bugs.webkit.org/show_bug.cgi?id=50549

  • svg/css/cursor-replace-expected.txt: Added.
  • svg/css/cursor-replace.svg: Added.

BUG=64959
TBR=​jschuh@chromium.org
Review URL: ​http://codereview.chromium.org/5545007

3:37 PM Changeset in webkit [73472] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-12-07 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Fix the Color -> CGColorRef conversions for the debug colors
used for compositing layers.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::setBackgroundColor): (PlatformCALayer::setBorderColor):
3:31 PM Changeset in webkit [73471] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <​tony@chromium.org>

Unreviewed, remove more passing tests (mac) from test_expecatations.txt
after DRT switch. Also remove a test that is passing because of
crankshaft.

  • platform/chromium/test_expectations.txt:
3:13 PM Changeset in webkit [73470] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <​tony@chromium.org>

Unreviewed, remove more passing tests (win) from test_expectations.txt
after DRT switch.

  • platform/chromium/test_expectations.txt:
2:47 PM Changeset in webkit [73469] by bweinstein@apple.com
  • 5 edits in trunk

Part of Layering Violation in ContextMenu
​https://bugs.webkit.org/show_bug.cgi?id=50586

Reviewed by John Sullivan.

WebCore:

ContextMenuMac.mm had a WebCoreMenuTarget class, which was responsible for wrapping
a ContextMenuItem, and calling through to the ContextMenuController to validate it
and call a function when it was selected.

It was a layering violation to have this class here, because ContextMenu can't know
about ContextMenuController.

This patch moves the class that wraps the ContextMenuItems to WebKit/mac/WebHTMLView.mm,
and sets up the menu targets there.

No change in behavior, no new tests.

  • WebCore.exp.in: Added function that needs to be exported.
  • platform/mac/ContextMenuMac.mm:

(WebCore::ContextMenu::ContextMenu): Don't set the sharedMenuTarget anymore.
(WebCore::ContextMenu::appendItem): Don't call setMenuItemTarget (this is done in WebKit now).
(WebCore::ContextMenu::insertItem): Ditto.

WebKit/mac:

Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
was a layering violation. Also, make sure we set the menu item targets for all menu
items before showing them, because the ContextMenu constructor doesn't do that anymore.

  • WebView/WebHTMLView.mm:

(+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
(-[WebMenuTarget WebCore::]): Ditto.
(-[WebMenuTarget setMenuController:WebCore::]): Ditto.
(-[WebMenuTarget forwardContextMenuAction:]): Ditto.
(-[WebMenuTarget validateMenuItem:]): Ditto.

(setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
(setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including

submenus), and calls setMenuItemTarget on them.

(-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding

them to the menu.

2:45 PM Changeset in webkit [73468] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <​tony@chromium.org>

Unreviewed, remove passing tests (linux) from test_expectations
after DRT switch.

  • platform/chromium/test_expectations.txt:
2:31 PM Changeset in webkit [73467] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix follow up build fix.

  • pcre/pcre_ucp_searchfuncs.cpp:

(jsc_pcre_ucp_othercase):

2:22 PM Changeset in webkit [73466] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <​tony@chromium.org>

Unreviewed, update chromium test_expectations for DRT based
on Linux bot cycles and debug try bot.

  • platform/chromium/test_expectations.txt:
2:21 PM Changeset in webkit [73465] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix clang++ build
​https://bugs.webkit.org/show_bug.cgi?id=50645

Reviewed by Darin Adler.

Explicitly cast offset to int.

  • pcre/pcre_ucp_searchfuncs.cpp:

(jsc_pcre_ucp_othercase):

2:07 PM Changeset in webkit [73464] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-06 Antonio Gomes <​agomes@rim.com>

Reviewed by Martin Robinson.

Clean up fast/events/multiline-link-arrow-navigation.html
​https://bugs.webkit.org/show_bug.cgi?id=50616

fast/events/multiline-link-arrow-navigation.html is setting both
WebKitEnableCaretBrowsing and -webkit-user-modify CSS property. Since
both work similarly for the purposes of this test, and the former is
not support by Mac and Windows DRTs, lets stick with using the later
only.

  • fast/events/multiline-link-arrow-navigation.html:
2:05 PM Changeset in webkit [73463] by andersca@apple.com
  • 2 edits in trunk/WebKit2

fast/loader/empty-embed-src-attribute.html asserts in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=50643

Reviewed by Sam Weinig.

Just always ignore attempts to load requests with empty URLs.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

2:03 PM Changeset in webkit [73462] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-12-07 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

-webkit-transition Fails on Multiple text-shadow Shadows
​https://bugs.webkit.org/show_bug.cgi?id=42281

When transitioning multiple shadows, the blend function for
ShadowData dropped all but the first and last shadow because
of a failure to append to the end of the list. Fixed.

Test: transitions/multiple-text-shadow-transition.html

  • page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::blend):
2:03 PM Changeset in webkit [73461] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-12-07 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

CSS animation doesn't work for border-radius
​https://bugs.webkit.org/show_bug.cgi?id=48340

Include CSSPropertyBorderRadius in the list of shorthand
properties, so that the individual border-radius properties
get animated.

Test: transitions/border-radius-transition.html

  • page/animation/AnimationBase.cpp: (WebCore::addShorthandProperties):
2:02 PM Changeset in webkit [73460] by Simon Fraser
  • 4 edits in trunk/LayoutTests

2010-12-07 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Make use of pause API more explicit before landing fix for borer-radius animation.
​https://bugs.webkit.org/show_bug.cgi?id=48340

  • transitions/transition-test-helpers.js: Add some constants that we can use to make the tests more readable. Handle an extra value in the expected values arrays, to tell us if we should expect a property to be animated, and therefore whether we should try to pause it.
  • transitions/color-transition-all.html:
  • transitions/zero-duration-in-list.html: Adjust to make use of the above changes.
2:01 PM Changeset in webkit [73459] by mjs@apple.com
  • 4 edits
    2 adds in trunk

2010-12-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Kent Tamura.

Implement HTML5 hidden attribute
​https://bugs.webkit.org/show_bug.cgi?id=40511

  • fast/forms/caret-rtl.html: Fixed a non-closed comment which added an "hidden" attribute.
  • fast/html/hidden-attr-expected.txt: Added.
  • fast/html/hidden-attr.html: Added. Test static and dynamic cases of hidden attribute.

2010-12-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Kent Tamura.

Implement HTML5 hidden attribute
​https://bugs.webkit.org/show_bug.cgi?id=40511

Test: fast/html/hidden-attr.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped attribute. (WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to display: none.
1:45 PM Changeset in webkit [73458] by kbr@google.com
  • 15 edits
    1 add in trunk

2010-12-07 Kenneth Russell <​kbr@google.com>

Reviewed by David Levin.

Fix compilation of core web audio files on Windows
​https://bugs.webkit.org/show_bug.cgi?id=50603

Added log2 definition to MathExtras.h on Windows platform.

  • wtf/MathExtras.h: (log2):

2010-12-07 Kenneth Russell <​kbr@google.com>

Reviewed by David Levin.

Fix compilation of core web audio files on Windows
​https://bugs.webkit.org/show_bug.cgi?id=50603

Changed a few constructs using C99 features of math.h to use
wtf/MathExtras.h instead. Changed inline definitions of a couple of
const static doubles in classes to out-of-line. Built Chrome with
web audio enabled on Windows and Mac OS X to test these changes.

No new tests since audio API is not yet implemented.

  • WebCore.gypi:
  • platform/audio/AudioResampler.cpp:
  • platform/audio/Biquad.cpp: (WebCore::Biquad::setLowpassParams): (WebCore::Biquad::setHighpassParams): (WebCore::Biquad::setLowShelfParams):
  • platform/audio/Cone.cpp: (WebCore::ConeEffect::gain):
  • platform/audio/EqualPowerPanner.cpp: (WebCore::EqualPowerPanner::pan):
  • platform/audio/FFTFrame.cpp: (WebCore::FFTFrame::interpolateFrequencyComponents): (WebCore::FFTFrame::extractAverageGroupDelay): (WebCore::FFTFrame::addConstantGroupDelay):
  • platform/audio/HRTFKernel.cpp:
  • platform/audio/HRTFPanner.cpp:
  • webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::readFromBufferWithGrainEnvelope):
  • webaudio/AudioPannerNode.cpp: (WebCore::AudioPannerNode::getAzimuthElevation):
  • webaudio/AudioParam.cpp: Added. (AudioParam::setValue): (AudioParam::smooth):
  • webaudio/AudioParam.h:
  • webaudio/RealtimeAnalyser.cpp:
1:39 PM Changeset in webkit [73457] by Philippe Normand
  • 3 edits in trunk/WebCore

2010-11-25 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] faster elements linking
​https://bugs.webkit.org/show_bug.cgi?id=50067

Perform less checks during GStreamer elements linking if building
against GStreamer >= 0.10.30.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::enterFullscreen):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
1:05 PM Changeset in webkit [73456] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-07 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] force NRWT to use DRT
​https://bugs.webkit.org/show_bug.cgi?id=50359

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1:00 PM Changeset in webkit [73455] by kov@webkit.org
  • 5 edits in trunk/WebKit/gtk

2010-12-07 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] clears the subresources prematurely
​https://bugs.webkit.org/show_bug.cgi?id=50634

Make adding the main resource explicit, and only clear
subresources when the new load is committed, avoid clearing them
prematurely.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::FrameLoaderClient::provisionalLoadStarted): (WebKit::FrameLoaderClient::prepareForDataSourceReplacement): (WebKit::postCommitFrameViewSetup):
  • tests/testwebdatasource.c: (notify_load_status_lifetime_cb): (test_webkit_web_data_source_lifetime): (main):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_add_main_resource): (webkit_web_view_add_resource): (webkit_web_view_clear_resources):
12:47 PM Changeset in webkit [73454] by Philippe Normand
  • 18 edits
    3 adds in trunk

2010-12-07 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] ::buffered() should return multiple ranges in some cases
​https://bugs.webkit.org/show_bug.cgi?id=45101

Improved the ::buffered() method thanks to the new buffering query
support that landed in GStreamer 0.10.31. The method now
queries the media buffered-ranges on the pipeline and queue2
handles it if it's buffering the media to disk.

The webkitwebsrc element also gained BYTES duration query
support. This is needed in the rare cases where uridecodebin
configures its queue before the HTTP server returns the media
Content-Length.

Test: http/tests/media/video-buffered.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::buffered):
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webkit_web_src_init): (webKitWebSrcQuery): Make webkitwebsrc handle the duration queries if it's aware of the media content-length.
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaSliderTrack): Fix position of the second and next buffered ranges.

LayoutTests:

Reviewed by Gustavo Noronha Silva.

[GStreamer] ::buffered() should return multiple ranges in some cases
​https://bugs.webkit.org/show_bug.cgi?id=45101

New test for video.buffered attribute. The test is skipped for
ports not returning multiple timeranges for video.buffered.

  • http/tests/media/video-buffered-expected.txt: Added.
  • http/tests/media/video-buffered.html: Added.
  • http/tests/resources/counting-captioned.mov: Added.
  • http/tests/media/video-throttled-load.cgi: added Range requests/responses support.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt-win/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win/Skipped:
11:56 AM Changeset in webkit [73453] by Simon Fraser
  • 2 edits in trunk/WebKit

2010-12-07 Simon Fraser <Simon Fraser>

Update Xcode project for newer Xcode.

  • WebKit.xcodeproj/project.pbxproj:
11:04 AM Changeset in webkit [73452] by yael.aharon@nokia.com
  • 5 edits
    8 adds in trunk

Spatial navigation not Working for Map and Area Tags
​https://bugs.webkit.org/show_bug.cgi?id=47142

Reviewed by Antonio Gomes.

WebCore:

Give area elements special treatment in spatial navigation algorithm by getting the
rect of the area from the associated image. Since area elements are likely to overlap
if they are not rects, or if authors are not careful, we flatten the rect of area elements.

Tests: fast/spatial-navigation/snav-imagemap-area-not-focusable.html

fast/spatial-navigation/snav-imagemap-area-without-image.html
fast/spatial-navigation/snav-imagemap-overlapped-areas.html
fast/spatial-navigation/snav-imagemap-simple.html

  • page/FocusController.cpp:

(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):

  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::virtualRectForDirection):
(WebCore::virtualRectForAreaElementAndDirection):

  • page/SpatialNavigation.h:

(WebCore::FocusCandidate::FocusCandidate):

LayoutTests:

  • fast/spatial-navigation/snav-imagemap-area-not-focusable-expected.txt: Added.
  • fast/spatial-navigation/snav-imagemap-area-not-focusable.html: Added.
  • fast/spatial-navigation/snav-imagemap-area-without-image-expected.txt: Added.
  • fast/spatial-navigation/snav-imagemap-area-without-image.html: Added.
  • fast/spatial-navigation/snav-imagemap-overlapped-areas-expected.txt: Added.
  • fast/spatial-navigation/snav-imagemap-overlapped-areas.html: Added.
  • fast/spatial-navigation/snav-imagemap-simple-expected.txt: Added.
  • fast/spatial-navigation/snav-imagemap-simple.html: Added.
10:04 AM Changeset in webkit [73451] by jberlin@webkit.org
  • 2 edits
    1 add in trunk/WebKit2

Build fix. Unreviewed.

  • WebKit2.pro:

Added WebDatabaseManagerQt.cpp.

  • WebProcess/WebCoreSupport/qt/WebDatabaseManagerQt.cpp: Added.

(WebKit::WebDatabaseManager::databaseDirectory):
Added a FIXME to implement and return an empty string.

9:52 AM Changeset in webkit [73450] by Darin Adler
  • 4 edits in trunk

WebCore: Try to fix V8 build.

  • bindings/generic/BindingDOMWindow.h:

(WebCore::BindingDOMWindow::createWindow): Pass security origin.

WebKit2: Get a bit closer to making Qt WebKit2 compile again.

  • WebKit2.pro: Add the WebDatabaseManager source files.

Still missing: The Qt version of the databaseDirectory function.

9:27 AM Changeset in webkit [73449] by jberlin@webkit.org
  • 4 edits
    4 adds in trunk/WebKit2

WebKit2: Need to set the location of the Databases directory when the WebProcess is initialized
​https://bugs.webkit.org/show_bug.cgi?id=50604

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp: Added.

(WebKit::WebDatabaseManager::shared):
(WebKit::WebDatabaseManager::WebDatabaseManager):
Initialize the DatabaseTracker with the Database directory.

  • WebProcess/WebCoreSupport/WebDatabaseManager.h: Added.
  • WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm: Added.

(WebKit::WebDatabaseManager::databaseDirectory):
Copied from WebKitInitializeDatabasesIfNecessary in WebKit/mac/Storage/WebDatabaseManager.mm.

  • WebProcess/WebCoreSupport/win/WebDatabaseManagerWin.cpp: Added.

(WebKit::WebDatabaseManager::databaseDirectory):
Copied from WebKitInitializeWebDatabasesIfNecessary in WebKit/win/WebDatabaseManager.cpp.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
Make sure that the Databases directory has been set by calling WebDatabaseManager::shared().

  • WebKit2.xcodeproj/project.pbxproj:

Add WebDatabaseManager.cpp/.h/Mac.cpp

  • win/WebKit2.vcproj:

Add WebDatabaseManager.cpp/.h/Win.cpp

9:14 AM Changeset in webkit [73448] by jberlin@webkit.org
  • 2 edits in trunk/WebKit/win

Build fix. Unreviewed.

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):
FrameLoader::urlSelected does not take a SecurityOrigin as a parameter.

8:40 AM Changeset in webkit [73447] by Darin Adler
  • 2 edits in trunk/WebCore

Another build fix.

  • loader/CrossOriginAccessControl.cpp: Added a missing include.
8:33 AM Changeset in webkit [73446] by Darin Adler
  • 4 edits in trunk/WebCore

Try to fix build.

  • plugins/PluginView.cpp:

(WebCore::PluginView::start): Pass security origin.
(WebCore::PluginView::getURLNotify): Ditto.
(WebCore::PluginView::getURL): Ditto.
(WebCore::PluginView::handlePost): Ditto.

8:30 AM Changeset in webkit [73445] by Darin Adler
  • 2 edits in trunk/WebKit/qt

Try to fix build.

  • Api/qwebpage.cpp:

(frameLoadRequest): Added missing parentheses.

8:23 AM Changeset in webkit [73444] by Darin Adler
  • 29 edits in trunk

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
​https://bugs.webkit.org/show_bug.cgi?id=48603

  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::selectCacheWithManifest): Pass security origin.
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchCreatePage): Ditto. (WebKit::FrameLoaderClientImpl::createFrame): Ditto.
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest): Ditto.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
​https://bugs.webkit.org/show_bug.cgi?id=48603

  • Api/qwebpage.cpp: (frameLoadRequest): Pass security origin.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
​https://bugs.webkit.org/show_bug.cgi?id=48603

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Pass security origin.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
​https://bugs.webkit.org/show_bug.cgi?id=48603

  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
​https://bugs.webkit.org/show_bug.cgi?id=48603

  • bindings/generic/BindingDOMWindow.h: (WebCore::BindingDOMWindow::createWindow): Pass security origin. (WebCore::BindingDOMWindow::open): Ditto.
  • bindings/generic/BindingFrame.h: (WebCore::BindingFrame::navigateIfAllowed): Ditto.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Pass security origin. (WebCore::createWindow): Ditto. (WebCore::JSDOMWindow::open): Ditto.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation): Pass security origin.
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Pass security origin.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::openInInspectedWindow): Pass security origin.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): Added a security origin argument, passed through to urlSelected. (WebCore::FrameLoader::urlSelected): Replaced the resource request and frame name arguments with a frame load request arguments in one overload, and changed the other overload to pass in the current frame's document for the security origin. (WebCore::FrameLoader::loadFrameRequest): Moved the canDisplay check before the referrer computation because it no longer needs to look at the referrer. Replaced the call to canDisplay that used the target frame's security origin and the call to deprecatedCanDisplay with a single call to canDisplay that uses the requester security origin.
  • loader/FrameLoader.h: Updated for argument changes above.
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): Added a security origin. (WebCore::ScheduledURLNavigation::fire): Pass the security origin in to FrameLoader::changeLocation. (WebCore::ScheduledURLNavigation::securityOrigin): Added. (WebCore::ScheduledRedirect::ScheduledRedirect): Added a security origin argument. (WebCore::ScheduledLocationChange::ScheduledLocationChange): Ditto. (WebCore::ScheduledRefresh::ScheduledRefresh): Ditto. (WebCore::ScheduledRefresh::fire): Pass the security origin in to FrameLoader::changeLocation. (WebCore::ScheduledFormSubmission::fire): Include the security origin when constructing form submission. (WebCore::NavigationScheduler::scheduleRedirect): Include the security origin when creating the scheduled navigation object. (WebCore::NavigationScheduler::scheduleLocationChange): Ditto. (WebCore::NavigationScheduler::scheduleRefresh): Ditto.
  • loader/NavigationScheduler.h: Added the security origin argument to scheduleLocationChange.
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadOrRedirectSubframe): Pass in the security origin when calling scheduleLocationChange.
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): Ditto.
  • page/ContextMenuController.cpp: (WebCore::openNewWindow): Pass in the security origin. (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
  • page/FrameLoadRequest.h: Added a security origin called the requester to all FrameLoadRequest objects.
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest): Added the security origin.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
​https://bugs.webkit.org/show_bug.cgi?id=48603

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::loadURL): Pass security origin.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchCreatePage): Ditto.
8:13 AM Changeset in webkit [73443] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-12-07 Chyangwoo Ryu <​cwryu@debian.org>

Reviewed by Gustavo Noronha.

Korean message translation
​https://bugs.webkit.org/show_bug.cgi?id=42465

  • kr.po: Added.
7:54 AM Changeset in webkit [73442] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-12-07 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] testwebdatasource - unreachable test is broken
​https://bugs.webkit.org/show_bug.cgi?id=50629

Fix, and disable testwebdatasource's unreachable test (it is not
passing now that it actually tests what it should). This also
fixes the wait timer to actually work as expected.

  • tests/testwebdatasource.c: (notify_load_status_unreachable_cb): (notify_load_status_cb): (test_webkit_web_data_source):
7:20 AM Changeset in webkit [73441] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-12-07 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: avoid initializing Context on when creating attaching listener to ScriptDebugServer
​https://bugs.webkit.org/show_bug.cgi?id=50627

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::addListener): don't try to collect already parsed scripts if context has not been initialized yet.
6:24 AM Changeset in webkit [73440] by yurys@chromium.org
  • 4 edits in trunk/LayoutTests

2010-12-07 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: switch http/tests/inspector/console-resource-errors.html to inspector-tests2
​https://bugs.webkit.org/show_bug.cgi?id=50551

We need to be sure that front-end has already opened by the time the messages are
recorded in console because the data we collect for errors may differ depending
on whether the front-end is open.

  • http/tests/inspector/console-resource-errors-expected.txt:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/console-tests2.js: (initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithClasses):
5:58 AM Changeset in webkit [73439] by Csaba Osztrogonác
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for tests introduced in r73385 and r73398.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/qt/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/qt/fast/html/marquee-scrollamount-expected.txt: Added.
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt: Added.
5:29 AM Changeset in webkit [73438] by Csaba Osztrogonác
  • 6 edits
    2 deletes in trunk

Unreviewed. Rolling out r73421, because it made transitions/color-transition-all.html flakey.

WebCore:

  • page/animation/AnimationBase.cpp:

(WebCore::addShorthandProperties):

LayoutTests:

  • transitions/border-radius-transition-expected.txt: Removed.
  • transitions/border-radius-transition.html: Removed.
  • transitions/color-transition-all.html:
  • transitions/transition-test-helpers.js:

(expected):

  • transitions/zero-duration-in-list.html:
5:19 AM Changeset in webkit [73437] by pfeldman@chromium.org
  • 1 edit in branches/chromium/597/WebCore/inspector/InspectorStyleSheet.cpp

Merge 72811 - 2010-11-29 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: crash upon inspecting user style sheet.
​https://bugs.webkit.org/show_bug.cgi?id=50109

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):

BUG=64483
TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/5575009

4:40 AM Changeset in webkit [73436] by Martin Robinson
  • 37 edits in trunk

2010-12-07 Martin Robinson <​mrobinson@igalia.com>

Unreviewed, rolling out r73392.
​http://trac.webkit.org/changeset/73392
​https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::close): (WebCore::Document::lastModified): (WebCore::Document::finishedParsing): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
  • dom/Document.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::commitData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setFrame):
  • loader/DocumentLoader.h:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
  • loader/DocumentWriter.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h: (WebCore::FrameLoader::writer):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestPreload):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

2010-12-07 Martin Robinson <​mrobinson@igalia.com>

Unreviewed, rolling out r73392.
​http://trac.webkit.org/changeset/73392
​https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::loadJavaScriptURL):
  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
  • src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-12-07 Martin Robinson <​mrobinson@igalia.com>

Unreviewed, rolling out r73392.
​http://trac.webkit.org/changeset/73392
​https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-12-07 Martin Robinson <​mrobinson@igalia.com>

Unreviewed, rolling out r73392.
​http://trac.webkit.org/changeset/73392
​https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]):

2010-12-07 Martin Robinson <​mrobinson@igalia.com>

Unreviewed, rolling out r73392.
​http://trac.webkit.org/changeset/73392
​https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • Api/qwebframe.cpp: (QWebFrame::setUrl):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading):

2010-12-07 Martin Robinson <​mrobinson@igalia.com>

Unreviewed, rolling out r73392.
​http://trac.webkit.org/changeset/73392
​https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::finishedLoading):

2010-12-07 Martin Robinson <​mrobinson@igalia.com>

Unreviewed, rolling out r73392.
​http://trac.webkit.org/changeset/73392
​https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::finishedLoading):
4:11 AM Changeset in webkit [73435] by Martin Robinson
  • 53 edits in trunk/LayoutTests

2010-12-07 Martin Robinson <​mrobinson@igalia.com>

Rebaseline GTK+ results after r73385.

  • platform/gtk/css1/box_properties/margin-expected.txt:
  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/classification/white_space-expected.txt:
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt:
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/gtk/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/gtk/fast/blockflow/block-level-images-expected.txt:
  • platform/gtk/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/gtk/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/gtk/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt:
  • platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
  • platform/gtk/fast/css/negative-leading-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/file-input-direction-expected.txt:
  • platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-grid-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/gtk/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/images/gif-large-checkerboard-expected.txt:
  • platform/gtk/fast/lists/001-vertical-expected.txt:
  • platform/gtk/fast/lists/003-vertical-expected.txt:
  • platform/gtk/fast/multicol/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
  • platform/gtk/fast/multicol/float-paginate-expected.txt:
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
  • platform/gtk/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
  • platform/gtk/fast/table/height-percent-test-vertical-expected.txt:
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/gtk/svg/custom/text-zoom-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/gtk/transforms/svg-vs-css-expected.txt:
3:11 AM Changeset in webkit [73434] by Patrick Gansterer
  • 4 edits
    1 delete in trunk

2010-12-07 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Remove WebKitGenerators
​https://bugs.webkit.org/show_bug.cgi?id=50445

  • CMakeLists.txt:
  • cmake/WebKitGenerators.cmake: Removed.

2010-12-07 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Remove WebKitGenerators
​https://bugs.webkit.org/show_bug.cgi?id=50445

Move remaining logic into main CMakeLists.txt.

  • CMakeLists.txt:
3:11 AM Changeset in webkit [73433] by Antti Koivisto
  • 4 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=50412
​http://www.wunderground.com/US/CA/Hayward.html causes big memory spike during page loading

Reviewed by Gavin Barraclough.

Creating a substring caused the original string be flattened if it was in the rope form. This could use
significant amount of memory by reducing buffer sharing between strings.

Add a rope specific substring function that constructs the substring by reusing the rope fibers
instead of flattening the rope.

No change observed in SunSpider.

  • runtime/JSString.cpp:

(JSC::JSString::substringFromRope):

  • runtime/JSString.h:

(JSC::jsSubstring):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):

2:44 AM Changeset in webkit [73432] by jschuh@chromium.org
  • 7 edits
    2 adds in trunk

2010-12-07 Justin Schuh <​jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
​https://bugs.webkit.org/show_bug.cgi?id=50549

Test: svg/css/cursor-replace.svg

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): (WebCore::SVGCursorElement::removeClient): (WebCore::SVGCursorElement::removeReferencedElement):
  • svg/SVGCursorElement.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::setCursorElement): (WebCore::SVGElement::cursorElementRemoved): (WebCore::SVGElement::setCursorImageValue): (WebCore::SVGElement::cursorImageElementRemoved):
  • svg/SVGElement.h:

2010-12-07 Justin Schuh <​jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
​https://bugs.webkit.org/show_bug.cgi?id=50549

  • svg/css/cursor-replace-expected.txt: Added.
  • svg/css/cursor-replace.svg: Added.
2:15 AM Changeset in webkit [73431] by yutak@chromium.org
  • 2 edits
    13 adds in trunk/LayoutTests

2010-12-07 Yuta Kitamura <​yutak@chromium.org>

Unreviewed.

Add Chromium-specific expected results for two tests.

  • platform/chromium-linux/css2.1/t040105-import-10-b-expected.checksum: Added.
  • platform/chromium-linux/css2.1/t040105-import-10-b-expected.png: Added.
  • platform/chromium-linux/media/controls-without-preload-expected.checksum: Added.
  • platform/chromium-linux/media/controls-without-preload-expected.png: Added.
  • platform/chromium-mac/media/controls-without-preload-expected.checksum: Added.
  • platform/chromium-mac/media/controls-without-preload-expected.png: Added.
  • platform/chromium-mac/media/controls-without-preload-expected.txt: Added.
  • platform/chromium-win/css2.1/t040105-import-10-b-expected.checksum: Added.
  • platform/chromium-win/css2.1/t040105-import-10-b-expected.png: Added.
  • platform/chromium-win/css2.1/t040105-import-10-b-expected.txt: Added.
  • platform/chromium-win/media/controls-without-preload-expected.checksum: Added.
  • platform/chromium-win/media/controls-without-preload-expected.png: Added.
  • platform/chromium-win/media/controls-without-preload-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:40 AM Changeset in webkit [73430] by tkent@chromium.org
  • 41 edits
    2 copies
    3 adds in trunk

2010-12-07 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
​https://bugs.webkit.org/show_bug.cgi?id=48821

Introduces FormAssociatedElement class which would be a super class
of form assocated elements. Some of member functions and variables of
HTMLFormControlElement are migrated into this class.
Following the HTML5 spec, HTMLFormControlElement class and
HTMLObjectElement class are subclasses of it for now.

Test: fast/forms/form-collection-elements-order.html

  • Android.mk: Added FormAssociatedElement.cpp
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Added FormAssociatedElement.{cpp,h}
  • WebCore.exp.in: Added the symbol for toHTMLElement(FormAssociatedElement*)
  • WebCore.gypi: Added FormAssociatedElement.{cpp,h}
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/CheckedRadioButtons.h: Fixed class forward declaration order.
  • dom/Document.cpp: (WebCore::Document::registerFormElementWithFormAttribute): Modified to use FormAssociatedElement instead of HTMLFormControlElement (WebCore::Document::unregisterFormElementWithFormAttribute): Ditto. (WebCore::Document::resetFormElementsOwner):
  • dom/Document.h: Ditto.
  • html/DOMFormData.cpp: Ditto. (WebCore::DOMFormData::DOMFormData):
  • html/FormAssociatedElement.cpp: Copied and renamed from WebCore/html/HTMLFormControlElement.cpp. (WebCore::FormAssociatedElement::FormAssociatedElement): (WebCore::FormAssociatedElement::~FormAssociatedElement): (WebCore::FormAssociatedElement::validity): (WebCore::FormAssociatedElement::insertedIntoTree): (WebCore::FormAssociatedElement::removedFromTree): (WebCore::FormAssociatedElement::removeFromForm): (WebCore::FormAssociatedElement::resetFormOwner): (WebCore::FormAssociatedElement::formAttributeChanged): (WebCore::toHTMLElement):
  • html/FormAssociatedElement.h: Ditto. (WebCore::FormAssociatedElement::ref): (WebCore::FormAssociatedElement::deref): (WebCore::FormAssociatedElement::formDestroyed): (WebCore::FormAssociatedElement::setForm):
  • html/HTMLElement.h: Changed the access level of findFormAncestor().
  • html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::item): Modified to use FormAssociatedElement instead of HTMLFormControlElement. (WebCore::HTMLFormCollection::getNamedFormItem): Ditto. (WebCore::HTMLFormCollection::updateNameCache): Ditto.
  • html/HTMLFormControlElement.cpp: Modified regarding with the change of class hierarchy. (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::~HTMLFormControlElement): (WebCore::HTMLFormControlElement::insertedIntoTree): (WebCore::HTMLFormControlElement::removedFromTree): (WebCore::HTMLFormControlElement::supportsFocus): (WebCore::HTMLFormControlElement::checkValidity): (WebCore::HTMLFormControlElement::virtualForm): (WebCore::HTMLFormControlElement::isDefaultButtonForForm): (WebCore::HTMLFormControlElement::attributeChanged):
  • html/HTMLFormControlElement.h: Ditto. (WebCore::HTMLFormControlElement::form): (WebCore::HTMLFormControlElement::disabled): (WebCore::HTMLFormControlElement::type): (WebCore::HTMLFormControlElement::refFormAssociatedElement): (WebCore::HTMLFormControlElement::derefFormAssociatedElement):
  • html/HTMLFormElement.cpp: Modified to use FormAssociatedElement instead of HTMLFormControlElement. (WebCore::HTMLFormElement::submitImplicitly): (WebCore::HTMLFormElement::validateInteractively): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::reset): (WebCore::HTMLFormElement::formElementIndexWithFormAttribute): (WebCore::HTMLFormElement::formElementIndex): (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement): (WebCore::HTMLFormElement::defaultButton): (WebCore::HTMLFormElement::checkValidity): (WebCore::HTMLFormElement::collectUnhandledInvalidControls): (WebCore::HTMLFormElement::documentDidBecomeActive):
  • html/HTMLFormElement.h: Ditto. (WebCore::HTMLFormElement::associatedElements):
  • html/HTMLInputElement.cpp: Ditto. (WebCore::HTMLInputElement::updateCheckedRadioButtons):
  • html/HTMLObjectElement.cpp: Modified regarding with the change of class hierarchy. (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::create): (WebCore::HTMLObjectElement::attributeChanged): (WebCore::HTMLObjectElement::insertedIntoTree): (WebCore::HTMLObjectElement::removedFromTree): (WebCore::HTMLObjectElement::appendFormData): (WebCore::HTMLObjectElement::formControlName):
  • html/HTMLObjectElement.h: Ditto. (WebCore::HTMLObjectElement::form): (WebCore::HTMLObjectElement::isFormControlElement): (WebCore::HTMLObjectElement::isEnumeratable): (WebCore::HTMLObjectElement::refFormAssociatedElement): (WebCore::HTMLObjectElement::derefFormAssociatedElement):
  • html/HTMLTagNames.in: Added constructorNeedsFormElement to object tag.
  • html/ValidationMessage.cpp: Modified to use FormAssociatedElement instead of HTMLFormControlElement. (WebCore::ValidationMessage::ValidationMessage): (WebCore::ValidationMessage::create):
  • html/ValidationMessage.h: Ditto.
  • html/ValidityState.cpp: Ditto. (WebCore::ValidityState::validationMessage): (WebCore::ValidityState::setCustomErrorMessage): (WebCore::ValidityState::valueMissing): (WebCore::ValidityState::typeMismatch): (WebCore::ValidityState::patternMismatch): (WebCore::ValidityState::tooLong): (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow): (WebCore::ValidityState::stepMismatch):
  • html/ValidityState.h: Ditto. (WebCore::ValidityState::create): (WebCore::ValidityState::ValidityState):
  • loader/FormSubmission.cpp: Ditto. (WebCore::FormSubmission::create):

2010-12-07 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
​https://bugs.webkit.org/show_bug.cgi?id=48821

Modified to use FormAssociatedElement instead of HTMLFormControlElement.

  • src/WebFormElement.cpp: (WebKit::WebFormElement::getFormControlElements): Modified to use FormAssociatedElement instead of HTMLFormControlElement.
  • src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Ditto.
  • src/WebSearchableFormData.cpp: (WebCore::GetButtonToActivate): Ditto. (WebCore::HasSuitableTextElement): Ditto.

2010-12-07 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
​https://bugs.webkit.org/show_bug.cgi?id=48821

Modified to use FormAssociatedElement instead of HTMLFormControlElement.

  • WebFrame.cpp: (WebFrame::elementWithName): Modified to use FormAssociatedElement instead of HTMLFormControlElement. (WebFrame::controlsInForm): Ditto.

2010-12-07 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
​https://bugs.webkit.org/show_bug.cgi?id=48821

Modified to use FormAssociatedElement instead of HTMLFormControlElement.

  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use FormAssociatedElement instead of HTMLFormControlElement. (-[WebHTMLRepresentation controlsInForm:]): Ditto.

2010-12-07 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
​https://bugs.webkit.org/show_bug.cgi?id=48821

Adds a test to ensure the order of form.elements attribute.
Updates two tests to check whether object elements are handled
correctly in form.elements attribute.

  • fast/forms/form-attribute-expected.txt: Updated.
  • fast/forms/form-collection-elements-order-expected.txt: Added.
  • fast/forms/form-collection-elements-order.html: Added.
  • fast/forms/script-tests/form-attribute.js: Updated.
  • fast/forms/script-tests/form-collection-elements-order.js: Added. (checkOrder):
  • fast/forms/script-tests/form-collection-elements.js: Updated.

Dec 6, 2010:

11:31 PM Changeset in webkit [73429] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-06 Yuta Kitamura <​yutak@chromium.org>

Unreviewed.

Update Chromium test expectations for svg/custom/text-linking.svg.

11:09 PM Changeset in webkit [73428] by pfeldman@chromium.org
  • 1 edit in branches/chromium/597/WebCore/css/CSSImportRule.cpp

Merge 73427 - 2010-12-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out r72988 for breaking iframes.

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):

BUG=65376
TBR=​jamesr@chromium.org
Review URL: ​http://codereview.chromium.org/5521007

11:01 PM Changeset in webkit [73427] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-12-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out r72988 for breaking iframes.

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
10:02 PM Changeset in webkit [73426] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-06 Yuta Kitamura <​yutak@chromium.org>

Unreviewed.

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
9:05 PM Changeset in webkit [73425] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-06 Hironori Bono <​hbono@chromium.org>

Reviewed by David Levin.

[Chromium] Refactor FontCacheChromiumWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=50611

This change just moved the helper functions for the WebCore::FontCache class to the beginning of ths file.

No new tests are added since this is a refactoring.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontDataFromDescriptionAndLogFont): Moved to the beginning of the file. (WebCore::toGDIFontWeight): Moved to the beginning of the file. (WebCore::FillLogFont): Moved to the beginning of the file. (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData): Moved to the beginning of the file. (WebCore::traitsInFamilyEnumProc): Moved to the beginning of the file. (WebCore::FontCache::platformInit): Moved after the static functions.
8:24 PM Changeset in webkit [73424] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-12-06 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Throw webglcontextlost and webglcontextrestored events when a WebGL context is lost and restored.
​https://bugs.webkit.org/show_bug.cgi?id=50364

No new tests since there is currently no way to force a context lost event.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired): (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::isContextLost): (WebCore::WebGLRenderingContext::loseContext): (WebCore::WebGLRenderingContext::restoreContext):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::WebGLRenderingContextRestoreTimer):
7:42 PM Changeset in webkit [73423] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=50593

Reviewed by Simon Fraser.

Fix background canvas painting for documents with left/top overflow. The math from the original RTL patch was incorrect.

Just use the RenderView's document dimensions always.

WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxDecorations):

LayoutTests:

  • fast/blockflow/Kusa-Makura-background-canvas.html: Added.
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
6:01 PM Changeset in webkit [73422] by Simon Fraser
  • 3 edits in trunk/WebKit2

2010-12-06 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Fix two WebKit2 prefs issues.

  • Shared/WebPreferencesStore.h: Include font-family preferences in the FOR_EACH_WEBKIT_STRING_PREFERENCE macro, actually propagating font family prefs to WebCore settings.
  • UIProcess/WebPageGroup.cpp: (WebKit::WebPageGroup::WebPageGroup): (WebKit::WebPageGroup::~WebPageGroup): Add and remove the WebPageGroup from the preference object it creates. This allows preference changes to actually be propagated to the web process.
6:01 PM Changeset in webkit [73421] by Simon Fraser
  • 6 edits
    2 adds in trunk

2010-12-06 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

CSS animation doesn't work for border-radius
​https://bugs.webkit.org/show_bug.cgi?id=48340

Include CSSPropertyBorderRadius in the list of shorthand
properties, so that the individual border-radius properties
get animated.

Test: transitions/border-radius-transition.html

  • page/animation/AnimationBase.cpp: (WebCore::addShorthandProperties):
5:24 PM Changeset in webkit [73420] by victorw@chromium.org
  • 3 edits in trunk/LayoutTests

2010-12-06 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations.

  • platform/chromium-mac-leopard/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/box-shadow-h-expected.png:
5:14 PM Changeset in webkit [73419] by andersca@apple.com
  • 7 edits in trunk/WebKit2

The plug-in process crashes if it can't load the plug-in module
​https://bugs.webkit.org/show_bug.cgi?id=50601
<rdar://problem/8692654>

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::initialize):
Handle m_plugin being 0.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::netscapePluginModule):
Create the plug-in module if it doesn't exist.

(WebKit::PluginProcess::initialize):
Store the plug-in path.

  • PluginProcess/PluginProcess.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::create):
Return null if the plug-in module doesn't exist.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Simplify code.

5:12 PM Changeset in webkit [73418] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-06 Emil Eklund <​eae@chromium.org>

Reviewed by Dimitri Glazkov.

Fix for classList perf test, failing due to typo.
​https://bugs.webkit.org/show_bug.cgi?id=50578

  • perf/class-list-remove.html: Changed to use the right value.
5:01 PM Changeset in webkit [73417] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-12-06 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Gavin Barraclough.

Simplified some ASLR-related code in PageAllocation/Reservation
​https://bugs.webkit.org/show_bug.cgi?id=50599


Removed reserveAt, allocateAt, and friends, since they all existed to
serve one feature: ASLR for executable memory on x86_64 on Mac. Moved
ASLR code down into systemAllocate -- now, any time you allocate
executable memory on a supporting platform, the memory's location is
randomized.

  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator): No need for the caller to randomize anything.
  • wtf/PageAllocation.h: (WTF::PageAllocation::systemAllocate): Removed some *At() functions, and beefed up executable allocation with randomization.
  • wtf/PageReservation.h: (WTF::PageReservation::systemReserve): Removed some *At() functions.
5:00 PM Changeset in webkit [73416] by rniwa@webkit.org
  • 21 edits in trunk/WebCore

2010-12-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

ApplyStyleCommand should take EditingStyle instead of CSSStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=49938

Modified ApplyStyleCommand::ApplyStyleCommand and ApplyStyleCommand::create to take EditingStyle*
instead of CSSStyleDeclaration*. Also replaced much of code in Editor::computeAndSetTypingStyle
by calls to EditingStyle's member functions and extracted EditingStyle::overrideWith and
EditingStyle::extractAndRemoveBlockProperties.

No new tests are added since this is a refactoring.

  • WebCore.exp.in: Added SelectionController::copyTypingStyle and EditingStyle::~EditingStyle.
  • css/CSSMutableStyleDeclaration.cpp: Made CSSMutableStyleDeclaration* in the argument list const. (WebCore::CSSMutableStyleDeclaration::merge):
  • css/CSSMutableStyleDeclaration.h:
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): Takes EditingStyle* instead of CSSStyleDeclaration*. (WebCore::ApplyStyleCommand::doApply): Uses EditingStyle.
  • editing/ApplyStyleCommand.h: m_style is now a ref-pointer to EditingStyle instead of CSSMutableStyleDeclaration. (WebCore::ApplyStyleCommand::create): Takes EditingStyle* instead of CSSStyleDeclaration*.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyle): Ditto. (WebCore::CompositeEditCommand::moveParagraphs): Calls applyStyle. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto.
  • editing/EditCommand.cpp:
  • editing/EditCommand.h:
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::~EditingStyle): Added. (WebCore::EditingStyle::overrideWithStyle): Extracted from Editor::calculateTypingStyleAfterDelete. (WebCore::EditingStyle::copy): Added. (WebCore::EditingStyle::extractAndRemoveBlockProperties): Extracted from Editor::calculateTypingStyleAfterDelete.
  • editing/EditingStyle.h:
  • editing/Editor.cpp: (WebCore::Editor::applyStyle): Calls ApplyStyleCommand::create. (WebCore::Editor::applyParagraphStyle): Ditto. (WebCore::Editor::computeAndSetTypingStyle): Ditto.
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Calls applyStyle.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Ditto.
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): Calls ApplyStyleCommand::create.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Calls applyStyle.
  • editing/SelectionController.cpp: (WebCore::SelectionController::copyTypingStyle): Moved from SelectionController.h
  • editing/SelectionController.h:
4:58 PM Changeset in webkit [73415] by commit-queue@webkit.org
  • 9 edits
    6 deletes in trunk/LayoutTests

2010-12-06 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Eric Seidel.

Fix testcase: textPath cannot be inside another textPath
​https://bugs.webkit.org/show_bug.cgi?id=50211

  • platform/mac/svg/custom/text-linking-expected.checksum: Updated.
  • platform/mac/svg/custom/text-linking-expected.png: Updated.
  • platform/mac/svg/custom/text-linking-expected.txt: Updated.
  • platform/chromium-linux/svg/custom/text-linking-expected.checksum: Updated.
  • platform/chromium-linux/svg/custom/text-linking-expected.png: Updated.
  • platform/chromium-linux/svg/custom/text-linking-expected.txt: Updated.
  • platform/chromium-win-vista/svg/custom/text-linking-expected.checksum: Deleted.
  • platform/chromium-win-vista/svg/custom/text-linking-expected.png: Deleted.
  • platform/chromium-win-vista/svg/custom/text-linking-expected.txt: Deleted.
  • platform/chromium-win-xp/svg/custom/text-linking-expected.checksum: Deleted.
  • platform/chromium-win-xp/svg/custom/text-linking-expected.png: Deleted.
  • platform/chromium-win-xp/svg/custom/text-linking-expected.txt: Deleted.
  • svg/custom/text-linking.svg: Removed test for <textPath> inside <textPath>.
4:57 PM Changeset in webkit [73414] by andersca@apple.com
  • 5 edits in trunk/WebKit2

WebProcess crash in NPRemoteObjectMap::invalidate when closing tab
​https://bugs.webkit.org/show_bug.cgi?id=50597
<rdar://problem/8655584>

Reviewed by Sam Weinig.

When invalidating the NPRemoteObjectMap, we don't want NPObjectMessageReceiver to
release all objects NPObjects blindly because NPJSObjects have already been deallocated by the plug-in view.

This is not an ideal solution; an ideal solution would involve NPJSObjects notifying any NPObjectMessageReceiver objects
that the NPJSObject is being destroyed. The NPObjectMessageReceiver could then simply null out the NPObject pointer.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):

  • Shared/Plugins/NPObjectMessageReceiver.h:
  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::NPRemoteObjectMap):
(WebKit::NPRemoteObjectMap::invalidate):

  • Shared/Plugins/NPRemoteObjectMap.h:

(WebKit::NPRemoteObjectMap::isInvalidating):

4:49 PM Changeset in webkit [73413] by jhoneycutt@apple.com
  • 5 edits in trunk/LayoutTests

Update Windows results after r73385.

Unreviewed.

  • platform/win/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum:
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
4:33 PM Changeset in webkit [73412] by weinig@apple.com
  • 26 edits
    2 adds in trunk

Generalize didChangeLocationWithinPageForFrame for all same document navigations
​https://bugs.webkit.org/show_bug.cgi?id=50584

Reviewed by Anders Carlsson.

WebKit2:

  • Rename didChangeLocationWithinPageForFrame callbacks to didSameDocumentNavigationForFrame
  • Add WKSameDocumentNavigationType to didChangeLocationWithinPageForFrame.
  • Call didSameDocumentNavigationForFrame for HTML session state changes.
  • Shared/API/c/WKPageLoadTypes.h: Added.
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
Moved WKFrameNavigationType here from WKPage.h and add WKSameDocumentNavigationType.

  • Shared/SameDocumentNavigationType.h: Added.
  • UIProcess/API/C/WKAPICast.h:

Moved WKFrameNavigationType conversion from here.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):
Update comment.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didSameDocumentNavigation):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didSameDocumentNavigationForFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didSameDocumentNavigationForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

Pipe new name through.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage):
Call didChangeLocationWithinPageForFrame for session state changes.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(didSameDocumentNavigationForFrame):
(-[BrowserWindowController awakeFromNib]):
(-[BrowserWindowController didSameDocumentNavigationForFrame:]):

  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:

(TestWebKitAPI::didSameDocumentNavigationForFrame):
(TestWebKitAPI::TEST):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

4:31 PM Changeset in webkit [73411] by rniwa@webkit.org
  • 10 edits
    2 adds in trunk

2010-12-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Executing FormatBlock on multiple paragraphs inside pre does not remove the outer pre
​https://bugs.webkit.org/show_bug.cgi?id=47300

The bug was caused by FormatBlockCommand::formatRange's not removing refNode when the refNode
contains more than one paragraphs even when the refNode is fully selected.

Fixed the bug by modifying FormatBlockCommand::formatRange to correctly remove the node in
such a situation.

Also fixed a bug in ApplyBlockElementCommand::formatSelection that the end of selection
is not properly updated when the end of selection resides in the node split by
rangeForParagraphSplittingTextNodesIfNeeded or endOfNextParagrahSplittingTextNodesIfNeeded.

Test: editing/execCommand/format-block-multiple-paragraphs-in-pre.html

  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::formatSelection): Calls formatRange with m_endOfLastParagraph. (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): Updates m_endOfLastParagraph when the position points to the node split by this function. (WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded): Ditto.
  • editing/ApplyBlockElementCommand.h: Added m_endOfLastParagraph as a member variable.
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): See above.
  • editing/FormatBlockCommand.h:
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::formatRange): Ignores the end of selection.
  • editing/IndentOutdentCommand.h:

2010-12-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Executing FormatBlock on multiple paragraphs inside pre does not remove the outer pre
​https://bugs.webkit.org/show_bug.cgi?id=47300

Added a test to ensure execCommand('FormatBlock') correctly removes pre when formatting paragraphs within.
Also rebaselined several tests because WebKit no longer erroneously format the paragraphs immediately
after the selection.

  • editing/execCommand/format-block-multiple-paragraphs-in-pre-expected.txt: Added.
  • editing/execCommand/format-block-multiple-paragraphs-in-pre.html: Added.
  • editing/execCommand/format-block-multiple-paragraphs-expected.txt: No longer erroneously format the last paragraph in a pre by a blockquote when formatting all but the last paragraph in the pre.
  • editing/execCommand/indent-pre-expected.txt: No longer erroneously format the last paragraph in the pre-list by a blockquote.
4:18 PM Changeset in webkit [73410] by jberlin@webkit.org
  • 5 edits in trunk/WebKit2

WebKit2: Expose the preference to enable or disable HTML5 Databases.
​https://bugs.webkit.org/show_bug.cgi?id=50411

Reviewed by Dan Bernstein.

  • Shared/WebPreferencesStore.h:

Make the preference to enable HTML5 Databases default ot true.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDatabasesEnabled):
(WKPreferencesGetDatabasesEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Set AbstractDatabase::isAvailable (mimicking how the preference is set in WebKit1).

4:07 PM Changeset in webkit [73409] by kinuko@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-06 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Make TestResultsServer return 404 for non-existing results files.
​https://bugs.webkit.org/show_bug.cgi?id=50581

  • TestResultServer/handlers/testfilehandler.py:
3:52 PM Changeset in webkit [73408] by victorw@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2010-12-06 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations for fast/html/marquee-scrollamount.html

  • platform/chromium-linux/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/chromium-linux/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/chromium-mac/fast/html: Added.
  • platform/chromium-mac/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/chromium-mac/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/chromium-win/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/chromium-win/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/chromium-win/fast/html/marquee-scrollamount-expected.txt: Added.
3:24 PM Changeset in webkit [73407] by Csaba Osztrogonác
  • 125 edits
    7 copies
    57 adds in trunk/LayoutTests

Unreviewed.

Update Qt specific expected results after r73385.

  • platform/qt/css1/box_properties/margin-expected.checksum: Added.
  • platform/qt/css1/box_properties/margin-expected.png: Added.
  • platform/qt/css1/box_properties/margin-expected.txt:
  • platform/qt/css1/box_properties/margin_right-expected.checksum: Added.
  • platform/qt/css1/box_properties/margin_right-expected.png: Added.
  • platform/qt/css1/box_properties/margin_right-expected.txt:
  • platform/qt/css1/formatting_model/inline_elements-expected.checksum: Added.
  • platform/qt/css1/formatting_model/inline_elements-expected.png: Added.
  • platform/qt/css1/formatting_model/inline_elements-expected.txt:
  • platform/qt/css2.1/t1202-counter-08-b-expected.checksum: Added.
  • platform/qt/css2.1/t1202-counter-08-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-08-b-expected.checksum: Added.
  • platform/qt/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-08-b-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.checksum:
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.checksum:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.checksum:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.checksum:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/qt/fast/backgrounds/size/backgroundSize15-expected.checksum: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize15-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/qt/fast/block/float/008-expected.checksum: Added.
  • platform/qt/fast/block/float/008-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png.
  • platform/qt/fast/block/float/008-expected.txt:
  • platform/qt/fast/block/float/019-expected.checksum: Added.
  • platform/qt/fast/block/float/019-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png.
  • platform/qt/fast/block/float/019-expected.txt:
  • platform/qt/fast/block/float/033-expected.checksum: Added.
  • platform/qt/fast/block/float/033-expected.png: Added.
  • platform/qt/fast/block/float/033-expected.txt:
  • platform/qt/fast/block/float/035-expected.checksum:
  • platform/qt/fast/block/float/035-expected.png:
  • platform/qt/fast/block/float/035-expected.txt:
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.checksum: Added.
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.checksum: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.checksum: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/qt/fast/block/positioning/049-expected.checksum: Added.
  • platform/qt/fast/block/positioning/049-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png.
  • platform/qt/fast/block/positioning/049-expected.txt:
  • platform/qt/fast/blockflow/block-level-images-expected.checksum:
  • platform/qt/fast/blockflow/block-level-images-expected.png:
  • platform/qt/fast/blockflow/block-level-images-expected.txt:
  • platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
  • platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
  • platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.checksum:
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.png:
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
  • platform/qt/fast/box-shadow/basic-shadows-expected.txt:
  • platform/qt/fast/css/negative-leading-expected.png:
  • platform/qt/fast/css/negative-leading-expected.txt:
  • platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.checksum: Added.
  • platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
  • platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/qt/fast/flexbox/flex-hang-expected.checksum: Added.
  • platform/qt/fast/flexbox/flex-hang-expected.png: Copied from LayoutTests/platform/qt/fast/table/height-percent-test-vertical-expected.png.
  • platform/qt/fast/flexbox/flex-hang-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.checksum: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.checksum: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.checksum: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.checksum: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.checksum: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.checksum: Added.
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.checksum: Added.
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.png: Added.
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/qt/fast/images/gif-large-checkerboard-expected.checksum:
  • platform/qt/fast/images/gif-large-checkerboard-expected.png:
  • platform/qt/fast/images/gif-large-checkerboard-expected.txt:
  • platform/qt/fast/lists/001-vertical-expected.checksum:
  • platform/qt/fast/lists/001-vertical-expected.png:
  • platform/qt/fast/lists/001-vertical-expected.txt:
  • platform/qt/fast/lists/003-vertical-expected.checksum:
  • platform/qt/fast/lists/003-vertical-expected.png:
  • platform/qt/fast/lists/003-vertical-expected.txt:
  • platform/qt/fast/multicol/column-count-with-rules-expected.checksum:
  • platform/qt/fast/multicol/column-count-with-rules-expected.png:
  • platform/qt/fast/multicol/column-count-with-rules-expected.txt:
  • platform/qt/fast/multicol/float-paginate-complex-expected.checksum:
  • platform/qt/fast/multicol/float-paginate-complex-expected.png:
  • platform/qt/fast/multicol/float-paginate-complex-expected.txt:
  • platform/qt/fast/multicol/float-paginate-expected.checksum:
  • platform/qt/fast/multicol/float-paginate-expected.png:
  • platform/qt/fast/multicol/float-paginate-expected.txt:
  • platform/qt/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/qt/fast/multicol/layers-in-multicol-expected.png:
  • platform/qt/fast/multicol/layers-in-multicol-expected.txt:
  • platform/qt/fast/multicol/nested-columns-expected.checksum:
  • platform/qt/fast/multicol/nested-columns-expected.png:
  • platform/qt/fast/multicol/nested-columns-expected.txt:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.checksum:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.png:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.checksum: Added.
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.png: Added.
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.checksum:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.checksum:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/qt/fast/multicol/table-vertical-align-expected.checksum:
  • platform/qt/fast/multicol/table-vertical-align-expected.png:
  • platform/qt/fast/multicol/table-vertical-align-expected.txt:
  • platform/qt/fast/repaint/content-into-overflow-expected.checksum: Added.
  • platform/qt/fast/repaint/content-into-overflow-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png.
  • platform/qt/fast/repaint/content-into-overflow-expected.txt:
  • platform/qt/fast/repaint/overflow-into-content-expected.checksum: Added.
  • platform/qt/fast/repaint/overflow-into-content-expected.png: Copied from LayoutTests/platform/qt/fast/block/float/035-expected.png.
  • platform/qt/fast/repaint/overflow-into-content-expected.txt:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.checksum:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
  • platform/qt/fast/table/height-percent-test-vertical-expected.checksum:
  • platform/qt/fast/table/height-percent-test-vertical-expected.png:
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt:
  • platform/qt/fast/table/wide-colspan-expected.checksum: Added.
  • platform/qt/fast/table/wide-colspan-expected.png: Added.
  • platform/qt/fast/table/wide-colspan-expected.txt:
  • platform/qt/fast/table/wide-column-expected.checksum: Added.
  • platform/qt/fast/table/wide-column-expected.png: Copied from LayoutTests/platform/qt/fast/table/height-percent-test-vertical-expected.png.
  • platform/qt/fast/table/wide-column-expected.txt:
  • platform/qt/fast/text/text-letter-spacing-expected.checksum: Added.
  • platform/qt/fast/text/text-letter-spacing-expected.png: Added.
  • platform/qt/fast/text/text-letter-spacing-expected.txt:
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum:
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.checksum: Added.
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.png: Added.
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.checksum:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.checksum:
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.png:
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.checksum: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.checksum:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29314-expected.checksum: Added.
  • platform/qt/tables/mozilla/bugs/bug29314-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug29314-expected.txt:
3:16 PM Changeset in webkit [73406] by zmo@google.com
  • 10 edits in trunk/WebCore

2010-12-03 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Postpone gl delete* calls until shaders/programs are no longer attached
​https://bugs.webkit.org/show_bug.cgi?id=50501

  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::deleteObjectImpl): Simply delete GL resource.
  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::deleteObjectImpl): Ditto.
  • html/canvas/WebGLObject.cpp: (WebCore::WebGLObject::deleteObject): Tracking whether deleteObjectImpl should be called or not.
  • html/canvas/WebGLObject.h: (WebCore::WebGLObject::detachContext): Set attachmentCount to 0 to ensure OpenGL resource deletion. (WebCore::WebGLObject::onDetached): No need to track attachmentCount here as we track it in deleteObject. (WebCore::WebGLObject::isDeleted): Make this public.
  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::deleteObjectImpl): Simply delete GL resource.
  • html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::deleteObjectImpl): Ditto.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getProgramParameter): intercept DELETE_STATUS. (WebCore::WebGLRenderingContext::getShaderParameter): Ditto.
  • html/canvas/WebGLShader.cpp: (WebCore::WebGLShader::deleteObjectImpl): Simply delete GL resource.
  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::deleteObjectImpl): Simply delete GL resource.
3:14 PM Changeset in webkit [73405] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

reserveAndCommit doesn't commit on MADVISE_FREE_REUSE systems
​https://bugs.webkit.org/show_bug.cgi?id=50588

Reviewed by Maciej Stachowiak.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit): Tightened up some comments. Changed
reserveAndCommit to actually commit on MADVISE_FREE_REUSE systems.

3:12 PM RebaselineServer edited by mihaip@chromium.org
(diff)
3:12 PM Changeset in webkit [73404] by rniwa@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2010-12-06 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Leopard rebaseline for r73385. The actual results now match that of Snow Leopard.

  • platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.txt Removed.
  • platform/mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.checksum: Removed.
  • platform/mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.png: Removed.
  • platform/mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.txt: Removed.
3:08 PM Changeset in webkit [73403] by victorw@chromium.org
  • 13 edits
    4 adds in trunk/LayoutTests

2010-12-06 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium mac test baselines affected by ​http://trac.webkit.org/changeset/73385

  • platform/chromium-mac/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.txt: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.png: Added.
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum:
  • platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
3:04 PM RebaselineServer edited by mihaip@chromium.org
(diff)
3:03 PM section-8.png attached to RebaselineServer by mihaip@chromium.org
3:02 PM RebaselineServer edited by mihaip@chromium.org
Rebaseline server: rest of UI walkthrough (diff)
2:54 PM Changeset in webkit [73402] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/http/tests/misc/acid3-expected.txt

Land updated results for acid3.

2:49 PM section-4.png attached to RebaselineServer by mihaip@chromium.org
2:48 PM RebaselineServer edited by mihaip@chromium.org
Rebaseline server: more UI walkthrough (diff)
2:41 PM overview.png attached to RebaselineServer by mihaip@chromium.org
2:40 PM RebaselineServer edited by mihaip@chromium.org
Rebaseline server: begin UI walkthrough (diff)
2:34 PM section-1.png attached to RebaselineServer by mihaip@chromium.org
2:32 PM Changeset in webkit [73401] by victorw@chromium.org
  • 294 edits
    10 adds
    9 deletes in trunk/LayoutTests

2010-12-06 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium layout test baselines affected by ​http://trac.webkit.org/changeset/73385

  • platform/chromium-linux/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-linux/css2.1/t1202-counters-09-b-expected.txt:
  • platform/chromium-linux/fast/block/positioning/047-expected.txt:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-linux/fast/lists/001-expected.checksum: Added.
  • platform/chromium-linux/fast/lists/001-expected.png: Added.
  • platform/chromium-linux/fast/lists/001-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/003-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/float-multicol-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/float-paginate-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/paginate-block-replaced-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/chromium-linux/fast/overflow/image-selection-highlight-expected.checksum:
  • platform/chromium-linux/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-linux/fast/overflow/infiniteRecursionGuard-expected.checksum:
  • platform/chromium-linux/fast/overflow/infiniteRecursionGuard-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-float-stacking-expected.txt: Added.
  • platform/chromium-linux/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
  • platform/chromium-linux/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/chromium-linux/fast/overflow/overflow-with-local-background-attachment-expected.checksum:
  • platform/chromium-linux/fast/overflow/overflow-with-local-background-attachment-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.checksum:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-linux/fast/repaint/text-selection-rect-in-overflow-2-expected.checksum:
  • platform/chromium-linux/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/chromium-linux/fast/repaint/text-selection-rect-in-overflow-expected.checksum:
  • platform/chromium-linux/fast/repaint/text-selection-rect-in-overflow-expected.png:
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.checksum:
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.txt:
  • platform/chromium-linux/fast/text/letter-spacing-negative-opacity-expected.txt:
  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum:
  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-win/css1/box_properties/margin-expected.txt:
  • platform/chromium-win/css1/box_properties/margin_right-expected.txt:
  • platform/chromium-win/css1/classification/white_space-expected.txt:
  • platform/chromium-win/css1/color_and_background/background_attachment-expected.txt:
  • platform/chromium-win/css1/color_and_background/background_repeat-expected.txt:
  • platform/chromium-win/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt:
  • platform/chromium-win/css2.1/t0803-c5505-mrgn-02-c-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-00-d-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/chromium-win/css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-win/css2.1/t1202-counters-08-b-expected.txt:
  • platform/chromium-win/css2.1/t1202-counters-09-b-expected.txt:
  • platform/chromium-win/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/chromium-win/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/chromium-win/editing/selection/focus_editable_html-expected.txt:
  • platform/chromium-win/editing/selection/select-all-001-expected.txt:
  • platform/chromium-win/editing/selection/select-all-002-expected.txt:
  • platform/chromium-win/editing/selection/select-all-003-expected.txt:
  • platform/chromium-win/editing/selection/select-all-004-expected.txt:
  • platform/chromium-win/editing/selection/unrendered-001-expected.txt:
  • platform/chromium-win/editing/selection/unrendered-002-expected.txt:
  • platform/chromium-win/editing/selection/unrendered-003-expected.txt:
  • platform/chromium-win/editing/selection/unrendered-004-expected.txt:
  • platform/chromium-win/editing/selection/unrendered-005-expected.txt:
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/chromium-win/fast/block/basic/010-expected.txt:
  • platform/chromium-win/fast/block/float/013-expected.txt:
  • platform/chromium-win/fast/block/float/021-expected.txt:
  • platform/chromium-win/fast/block/float/029-expected.txt:
  • platform/chromium-win/fast/block/float/031-expected.txt:
  • platform/chromium-win/fast/block/float/avoidance-percent-width-strict-expected.txt:
  • platform/chromium-win/fast/block/float/clamped-right-float-expected.txt:
  • platform/chromium-win/fast/block/float/float-in-float-painting-expected.txt:
  • platform/chromium-win/fast/block/float/nested-clearance-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/004-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/062-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/063-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/104-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/chromium-win/fast/block/positioning/002-expected.txt:
  • platform/chromium-win/fast/block/positioning/047-expected.txt:
  • platform/chromium-win/fast/block/positioning/051-expected.txt:
  • platform/chromium-win/fast/block/positioning/061-expected.txt:
  • platform/chromium-win/fast/block/positioning/auto-height-with-top-and-bottom-expected.txt:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/chromium-win/fast/body-propagation/background-color/002-expected.txt:
  • platform/chromium-win/fast/body-propagation/background-color/002-xhtml-expected.txt:
  • platform/chromium-win/fast/body-propagation/background-image/002-expected.txt:
  • platform/chromium-win/fast/body-propagation/background-image/002-xhtml-expected.txt:
  • platform/chromium-win/fast/body-propagation/overflow/001-expected.txt:
  • platform/chromium-win/fast/body-propagation/overflow/001-xhtml-expected.txt:
  • platform/chromium-win/fast/body-propagation/overflow/005-declarative-expected.txt:
  • platform/chromium-win/fast/body-propagation/overflow/005-expected.txt:
  • platform/chromium-win/fast/body-propagation/overflow/005-xhtml-expected.txt:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.txt:
  • platform/chromium-win/fast/box-sizing/box-sizing-expected.txt:
  • platform/chromium-win/fast/clip/008-expected.txt:
  • platform/chromium-win/fast/clip/009-expected.txt:
  • platform/chromium-win/fast/clip/010-expected.txt:
  • platform/chromium-win/fast/clip/011-expected.txt:
  • platform/chromium-win/fast/clip/012-expected.txt:
  • platform/chromium-win/fast/compact/001-expected.txt:
  • platform/chromium-win/fast/css/MarqueeLayoutTest-expected.txt:
  • platform/chromium-win/fast/css/negative-leading-expected.txt:
  • platform/chromium-win/fast/css/percentage-non-integer-expected.txt:
  • platform/chromium-win/fast/css/word-space-extra-expected.txt:
  • platform/chromium-win/fast/dom/clone-node-dynamic-style-expected.txt:
  • platform/chromium-win/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/chromium-win/fast/events/focusingUnloadedFrame-expected.txt:
  • platform/chromium-win/fast/flexbox/009-expected.txt:
  • platform/chromium-win/fast/flexbox/016-expected.txt:
  • platform/chromium-win/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/chromium-win/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-win/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/chromium-win/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/chromium-win/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/chromium-win/fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/chromium-win/fast/inline-block/tricky-baseline-expected.txt:
  • platform/chromium-win/fast/inline/long-wrapped-line-expected.txt:
  • platform/chromium-win/fast/layers/layer-visibility-expected.txt:
  • platform/chromium-win/fast/layers/layer-visibility-sublayer-expected.txt:
  • platform/chromium-win/fast/layers/overflow-scroll-auto-switch-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/fast/lists/001-expected.txt:
  • platform/chromium-win/fast/lists/001-vertical-expected.txt:
  • platform/chromium-win/fast/lists/003-expected.txt:
  • platform/chromium-win/fast/lists/003-vertical-expected.txt:
  • platform/chromium-win/fast/lists/li-br-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-02-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-03-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-04-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-05-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-06-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-07-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-08-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-09-expected.txt:
  • platform/chromium-win/fast/media/mq-width-absolute-01-expected.txt:
  • platform/chromium-win/fast/media/mq-width-absolute-02-expected.txt:
  • platform/chromium-win/fast/media/mq-width-absolute-03-expected.txt:
  • platform/chromium-win/fast/media/mq-width-absolute-04-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.txt:
  • platform/chromium-win/fast/multicol/float-paginate-expected.txt:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/nested-columns-expected.txt:
  • platform/chromium-win/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/chromium-win/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-win/fast/overflow/002-expected.txt:
  • platform/chromium-win/fast/overflow/006-expected.txt:
  • platform/chromium-win/fast/overflow/dynamic-hidden-expected.txt:
  • platform/chromium-win/fast/overflow/float-in-relpositioned-expected.txt:
  • platform/chromium-win/fast/overflow/image-selection-highlight-expected.checksum:
  • platform/chromium-win/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-win/fast/overflow/image-selection-highlight-expected.txt:
  • platform/chromium-win/fast/overflow/infiniteRecursionGuard-expected.checksum:
  • platform/chromium-win/fast/overflow/infiniteRecursionGuard-expected.png:
  • platform/chromium-win/fast/overflow/infiniteRecursionGuard-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-auto-table-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.txt: Added.
  • platform/chromium-win/fast/overflow/overflow-stacking-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-with-local-background-attachment-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-x-y-expected.txt:
  • platform/chromium-win/fast/overflow/scrollRevealButton-expected.txt:
  • platform/chromium-win/fast/reflections/reflection-direction-expected.txt:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.txt:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.checksum:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.txt:
  • platform/chromium-win/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt:
  • platform/chromium-win/fast/repaint/float-overflow-expected.txt:
  • platform/chromium-win/fast/repaint/float-overflow-right-expected.txt:
  • platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.txt:
  • platform/chromium-win/fast/repaint/overflow-scroll-delete-expected.checksum:
  • platform/chromium-win/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/chromium-win/fast/repaint/overflow-scroll-delete-expected.txt:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-2-expected.checksum:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-expected.checksum:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-expected.png:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-expected.txt:
  • platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
  • platform/chromium-win/fast/replaced/004-expected.txt:
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.checksum:
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.txt:
  • platform/chromium-win/fast/table/034-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium-win/fast/table/frame-and-rules-expected.txt:
  • platform/chromium-win/fast/table/overflowHidden-expected.txt:
  • platform/chromium-win/fast/text/international/thai-line-breaks-expected.txt:
  • platform/chromium-win/fast/text/large-text-composed-char-expected.txt:
  • platform/chromium-win/fast/text/letter-spacing-negative-opacity-expected.txt:
  • platform/chromium-win/fast/text/text-letter-spacing-expected.txt:
  • platform/chromium-win/fast/text/whitespace/012-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/scrollbars/basic-scrollbar-expected.txt:
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum:
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/chromium-win/scrollbars/disabled-scrollbar-expected.txt:
  • platform/chromium-win/scrollbars/scrollbar-buttons-expected.txt:
  • platform/chromium-win/scrollbars/scrollbar-orientation-expected.txt:
  • platform/chromium-win/svg/custom/altglyph-expected.txt:
  • platform/chromium-win/svg/custom/getscreenctm-in-mixed-content-expected.txt:
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/chromium-win/svg/custom/invisible-text-after-scrolling-expected.txt:
  • platform/chromium-win/svg/custom/path-bad-data-expected.txt:
  • platform/chromium-win/svg/custom/scroll-hit-test-expected.txt: Added.
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium-win/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/chromium-win/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/chromium-win/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/chromium-win/svg/text/kerning-expected.txt:
  • platform/chromium-win/svg/text/multichar-glyph-expected.txt:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug23151-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug43039-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug45055-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug5797-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug72359-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug83786-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug92143-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-win/tables/mozilla/core/nested1-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_index-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_left-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_td_nowrap-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_th_nowrap-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug67915-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
  • platform/chromium-win/transforms/svg-vs-css-expected.txt:
2:10 PM RebaselineServer edited by mihaip@chromium.org
Rebaseline server: more code descriptions (diff)
2:02 PM Changeset in webkit [73400] by xji@chromium.org
  • 15 edits
    12 copies in branches/chromium/597

Merge 72852 - 2010-11-29 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by David Hyatt.

Right-to-left pages should be scrollable to reveal left overflow.
​https://bugs.webkit.org/show_bug.cgi?id=23556

Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
pages with a left overflow.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView inProgramaticScroll]): (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]): (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]): (-[WebDynamicScrollBarsView setScrollOriginX:]): (-[WebDynamicScrollBarsView scrollOriginX]):
  • WebView/WebFrameView.mm: (-[WebFrameView _scrollToBeginningOfDocument]): (-[WebFrameView _scrollToEndOfDocument]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]):

2010-11-29 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Right-to-left pages should be scrollable to reveal left overflow.
​https://bugs.webkit.org/show_bug.cgi?id=23556

For RTL page, save left layout overflow and include it into the document
size during layout. Use the left layout overflow when scroll and paint
the page. Behavior on LTR page should be untouched since left layout
overflow is set as 0 for LTR page.

Tests: fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html

fast/dom/horizontal-scrollbar-in-rtl.html
fast/dom/horizontal-scrollbar-when-dir-change.html
fast/dom/left-overflow-in-ltr.html
fast/dom/right-overflow-in-rtl.html

  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): Save negative of left layout overflow as scroll X origin. And includes left layout overflow into document size.
  • page/mac/WebCoreFrameView.h: Add methods for setting and getting scroll X origin.
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::maximumScrollPosition): Minus scroll X origin from maximum horizontal scroll position. (WebCore::ScrollView::minimumScrollPosition): (WebCore::ScrollView::adjustScrollPositionWithinRange): (WebCore::ScrollView::valueChanged): (WebCore::ScrollView::setScrollPosition): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformSetContentsSize): (WebCore::ScrollView::platformSetScrollPosition): (WebCore::ScrollView::platformSetScrollOriginX):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::paintRootBoxDecorations): Include left layout overflow into canvas size.
  • rendering/RenderView.cpp: (WebCore::RenderView::layout): Save left layout overflow. (WebCore::RenderView::docLeft): (WebCore::RenderView::docWidth): Include left layout overflow into doc width for RTL page.
  • rendering/RenderView.h:

2010-11-29 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Right-to-left pages should be scrollable to reveal left overflow.
​https://bugs.webkit.org/show_bug.cgi?id=23556

For RTL page, save left layout overflow and include it into the document
size during layout. Use the left layout overflow when scroll and paint
the page. Behavior on LTR page should be untouched since left layout
overflow is set as 0 for LTR page.

  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt: Added.
  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html: Added.
  • fast/dom/horizontal-scrollbar-in-rtl.html: Added.
  • fast/dom/horizontal-scrollbar-when-dir-change.html: Added.
  • fast/dom/left-overflow-in-ltr.html: Added.
  • fast/dom/right-overflow-in-rtl.html: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/mac/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/dom/left-overflow-in-ltr-expected.txt: Added.
  • platform/mac/fast/dom/right-overflow-in-rtl-expected.txt: Added.
  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt: Added.
  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html: Added.
  • fast/dom/horizontal-scrollbar-in-rtl.html: Added.
  • fast/dom/horizontal-scrollbar-when-dir-change.html: Added.
  • fast/dom/left-overflow-in-ltr.html: Added.
  • fast/dom/right-overflow-in-rtl.html: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/mac/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/dom/left-overflow-in-ltr-expected.txt: Added.
  • platform/mac/fast/dom/right-overflow-in-rtl-expected.txt: Added.

TBR=​xji@chromium.org

2:01 PM Changeset in webkit [73399] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-12-06 Ryosuke Niwa <​rniwa@webkit.org>

Yet unreviewed another Leopard build fix for r73380.

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm: (PlatformCAAnimation::setKeyTimes):
  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::platformCALayer):
1:58 PM RebaselineServer created by mihaip@chromium.org
Initial rebaseline server wiki page.
1:57 PM Changeset in webkit [73398] by aestes@apple.com
  • 3 edits
    4 adds in trunk

2010-12-06 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

Marquee elements do not stop animating when scrollAmount is set to 0.
​https://bugs.webkit.org/show_bug.cgi?id=50434

Test: fast/html/marquee-scrollamount.html

  • rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::timerFired): Allow increment to be 0.

2010-12-06 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

Marquee elements do not stop animating when scrollAmount is set to 0.
​https://bugs.webkit.org/show_bug.cgi?id=50434

  • fast/html/marquee-scrollamount.html: Added.
  • platform/mac/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/mac/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/mac/fast/html/marquee-scrollamount-expected.txt: Added.
1:52 PM Changeset in webkit [73397] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-12-06 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Leopard buildfix for r73380.

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm: (PlatformCAAnimation::setTimingFunctions):
  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::PlatformCALayer):
1:37 PM Changeset in webkit [73396] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-12-06 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] use ResourceHandle::setDefersLoading in WebKitWebSourceGStreamer
​https://bugs.webkit.org/show_bug.cgi?id=44157

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcNeedDataMainCb): (webKitWebSrcEnoughDataMainCb): Replaced platform-specific code with cross-platform ResourceHandle::setDefersLoading calls.
1:30 PM WikiStart edited by mihaip@chromium.org
(diff)
1:27 PM Changeset in webkit [73395] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-12-06 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Leopard build fix for r73388.

  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::maxValueForRange): (WebCore::AccessibilitySlider::minValueForRange):
1:25 PM WikiStart edited by mihaip@chromium.org
Group layout test-related wiki pages. (diff)
1:19 PM Changeset in webkit [73394] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-12-06 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed build fix for Leopard after r73379.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setAllowsFontSmoothing):
1:15 PM Changeset in webkit [73393] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent): Wrap Carbon-specific code in #ifndef NP_NO_CARBON.

1:11 PM Changeset in webkit [73392] by Nate Chapin
  • 37 edits in trunk

2010-12-06 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Make DocumentWriter a member of DocumentLoader
instead of FrameLoader.
​https://bugs.webkit.org/show_bug.cgi?id=50489

Refactor, no new tests.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::close): (WebCore::Document::lastModified): (WebCore::Document::finishedParsing): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
  • dom/Document.h: (WebCore::Document::setDocumentLoader): (WebCore::Document::loader):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::commitData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setFrame):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::writer):
  • loader/DocumentWriter.h: (WebCore::DocumentWriter::setFrame):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h: (WebCore::FrameLoader::notifier):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestPreload):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
12:58 PM Changeset in webkit [73391] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Add a shim for GetCurrentEventButtonState
​https://bugs.webkit.org/show_bug.cgi?id=50583

Reviewed by Adam Roben.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::getCurrentEventButtonState):
Get the event button state from the plug-in.

(WebKit::PluginProcess::initializeShim):
Add new shim callback.

  • PluginProcess/mac/PluginProcessShim.cpp:

(WebKit::shimGetCurrentEventButtonState):
Add shim.

  • PluginProcess/mac/PluginProcessShim.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::buttonState):
Return the button state.

(WebKit::NetscapePlugin::platformHandleMouseEvent):
Update the button state. Also, make sure to actually pass the modifiers to NPP_HandleEvent.

12:58 PM Changeset in webkit [73390] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • WebCore.xcodeproj/project.pbxproj: Don't force WebCore to build against the 10.5 SDK.

That's just plain wrong.

12:39 PM Changeset in webkit [73389] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-06 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] fix an assert hit in DRT
​https://bugs.webkit.org/show_bug.cgi?id=50575

This class uses WTF's RefPtr, but expects chrome's base::RefPtr
semantics.

Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
(third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
WTF::RefCountedBase::ref()).

  • DumpRenderTree/chromium/TestWebWorker.h: (TestWebWorker::TestWebWorker):
12:37 PM Changeset in webkit [73388] by Chris Fleizach
  • 9 edits
    2 adds in trunk

HTML5 Slider does not work correctly with VoiceOver
​https://bugs.webkit.org/show_bug.cgi?id=50505

Reviewed by Darin Adler.

Address a few problems with the Mac implementation for the accessibility slider.

1) The value indicator is not hit testable.
2) The value indicator does not return an AXValue.
3) In the slider, the min/max values are not correct when min/max attributes are not present.
4) When you change the value with the keyboard, it doesn't send out the right notification.
5) Sliders were returning AXValue and AXTopLevelUIElement attributes twice in their list of attributes.

Test: platform/mac/accessibility/html-slider-indicator.html

WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::getAttribute):

Use fastGetAttribute on Element, instead of getAttribute.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isInputSlider):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::doAccessibilityHitTest):
(WebCore::AccessibilitySlider::maxValueForRange):
(WebCore::AccessibilitySlider::minValueForRange):

  • accessibility/AccessibilitySlider.h:

(WebCore::AccessibilitySlider::isInputSlider):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::applyStep):

LayoutTests:

  • platform/mac/accessibility/html-slider-indicator-expected.txt: Added.
  • platform/mac/accessibility/html-slider-indicator.html: Added.
12:34 PM Changeset in webkit [73387] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Add a shim for IsWindowActive
​https://bugs.webkit.org/show_bug.cgi?id=50582

Reviewed by Adam Roben.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::isWindowActive):
Get the NetscapePlugin from the WindowRef and check if the plug-in's window is active.

(WebKit::PluginProcess::initializeShim):

  • PluginProcess/mac/PluginProcessShim.cpp

(WebKit::shimIsWindowActive):
Call isWindowActive. If it returns true, return the result value. Otherwise, call the real
IsWindowActive function.

  • PluginProcess/mac/PluginProcessShim.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_isWindowactive.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(WebKit::NetscapePlugin::isWindowActive):
Return whether the window is active.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::windowMap):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::netscapePluginFromWindow):
Add a mapping between windows and the corresponding NetscapePlugin objects.

(WebKit::NetscapePlugin::windowFocusChanged):
Update the window focus member variable.

12:32 PM Changeset in webkit [73386] by aa@chromium.org
  • 2 edits in branches/chromium/597/WebCore

Merge 73245 - 2010-12-02 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Reduce the number of cases where we end up with a stale value for
minimumPreferredLogicalWidth(). This isn't a complete fix, but fixes a
large number of cases.

RenderObject::minimumPreferredLogicalWidth() sometimes reports wrong value.
​https://bugs.webkit.org/show_bug.cgi?id=50119

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange):

TBR=​aa@chromium.org
Review URL: ​http://codereview.chromium.org/5661001

12:03 PM Changeset in webkit [73385] by hyatt@apple.com
  • 303 edits
    4 adds in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=49220 <<rdar://problem/8644849>, REGRESSION: transforms now
O(n3) from pathological behavior in lowestPosition, rightmostPosition, leftmostPosition and topmostPosition.

Reviewed by Simon Fraser.

This patch throws out the lowest/rightmost/leftmost/topmostPosition functions and re-architects layout overflow
in the engine to cache all the information required to properly handle scrolling.

In the old code, there were two types of overflow: layout overflow and visual overflow. The former could
affect scrolling and the latter could not. The distinction was largely meaningless, since layout overflow
wasn't actually used to determine scroll width or scroll height. It didn't propagate across self-painting layer
boundaries either. In the old code, the term visible overflow meant the union of the layout overflow and
visual overflow rects.

In the new code, the two types of overflow remain, but the distinction between the two is now clear. Visual overflow
is used purely for painting and hit testing checks and layout overflow is used specifically for scrolling. It has
been expanded to propagate across self-painting layers, to factor in relative positioning and transforms, and to
work with writing modes.

In order to minimize layout test changes, layers no longer incorporate right/bottom overflow into their width/height members.
Doing so uncovered two bugs where left/top overflow was ignored (proof that even having layer dimensions is harmful).
A render tree dump hack has been put into the code to keep this overflow dumping for the RenderView's layer, since otherwise
a huge number of tests would change.

Added fast/overflow/overflow-rtl-vertical.html to test vertical writing-mode overflow. Existing tests cover the rest.

WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::forceLayoutForPagination):
Changed to use RenderView's docTop/Left/Width/Height accessors, which simply grab the overflow and properly flip it
to account for writing modes.

  • platform/graphics/IntRect.h:

(WebCore::IntRect::shiftLeftEdgeTo):
(WebCore::IntRect::shiftRightEdgeTo):
(WebCore::IntRect::shiftTopEdgeTo):
(WebCore::IntRect::shiftBottomEdgeTo):
New helper functions for sliding the edge of a rectangle without moving any of the other three edges.

  • rendering/InlineBox.h:

(WebCore::InlineBox::frameRect):
frameRect is a helper for obtaining the x, y, width, height of an InlineBox as an IntRect.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
All of the overflow setting in the inline direction has been removed from this function. All line overflow is computed
at once now in a single function: computeOverflow.

(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::addReplacedChildOverflow):
Helper for propagating overflow from specific types of children that occur on a line into the InlineFlowBox's overflow.

(WebCore::InlineFlowBox::computeOverflow):
The new function that computes both horizontal and vertical overflow for a line box.

(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):
(WebCore::InlineFlowBox::setOverflowFromLogicalRects):
New functions that set the overflow computed by computeOverflow. These replace setBlockDirectionOverflowPositions
and setInlineDirectionOverflowPositions. They essentially do the same thing, but they operate on rectangles.

(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
Changed to use visual overflow instead of visible overflow. (Visible overflow as a union of layout and visual
overflow is no longer necessary, since visual overflow is now equivalent to the old visible overflow concept.)

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::logicalLayoutOverflowRect):
(WebCore::InlineFlowBox::logicalVisualOverflowRect):
Helpers for obtaining logical overflow rectangles, since lines compute their overflow in logical terms before
converting to block coordinates at the end.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::addOverflowFromPositionedObjects):
Blocks now have a computeOverflow function called at the end of layout that adds in all the types of overflow. The addOverflowFromChildren
method is virtual so that RenderListItem and RenderTable can subclass it. RenderListItem has to position its list marker and
propagate marker overflow up, and RenderTable adds in overflow from its sections.

(WebCore::RenderBlock::layoutOnlyPositionedObjects):
(WebCore::RenderBlock::layoutPositionedObjects):
When only positioned objects lay out, overflow must still be recomputed. The refactoring of overflow computation into a single
callable method: computeOverflow, makes it possible for this to be done easily.

(WebCore::RenderBlock::paint):
visible -> visual.

(WebCore::RenderBlock::addOverhangingFloats):
The propagation of float overflow has changed substantially. The basic rules are:

(1) The float must be in our floating objects list to contribute to overflow.
(2) The float must be a descendant to contribute to overflow.
(3) The block must have the outermost list that contains the float, or it has a self-painting layer and

so the float needs to be included in its overflow.

(WebCore::RenderBlock::nodeAtPoint):
visible -> visual.

(WebCore::RenderBlock::layoutColumns):
Remove column overflow computation from layoutColumns and move it to computeOverflow.

(WebCore::RenderBlock::adjustLinePositionForPagination):
visible -> visual.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::scrollbarsChanged):
Added a new virtual method used by table cells when scrollbars in an overflow:auto/scroll table cell come and go.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
visible -> visual.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
Patched to use layoutOverflow functions instead of the old rightmost/leftmostPosition functions.

(WebCore::RenderBox::paintRootBoxDecorations):
Use docLeft and docTop here, so that writing modes are handled.

(WebCore::RenderBox::clippedOverflowRectForRepaint):
visible -> visual.

(WebCore::RenderBox::addOverflowFromChild):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::logicalVisualOverflowRectForPropagation):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::logicalLayoutOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

  • rendering/RenderBox.h:

The new overflow system for boxes. Layout overflow now crosses self-painting layer boundaries and adjusts child boxes
for transforms, relative positioning and writing mode differences.

(WebCore::RenderBox::layoutOverflowRect):
(WebCore::RenderBox::topLayoutOverflow):
(WebCore::RenderBox::bottomLayoutOverflow):
(WebCore::RenderBox::leftLayoutOverflow):
(WebCore::RenderBox::rightLayoutOverflow):
Changed the default rectangle for layout overflow to be the client box to match the scrollable areas of overflow regions.

(WebCore::RenderBox::clientLogicalBottom):
New helper for obtaining the logical bottom of the client box.

(WebCore::RenderBox::clientBoxRect):
New helper for obtaining the clientLeft/Top/Width/Height box.

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::relativePositionLogicalOffset):
Helper for obtaining the relative position offset transposed for vertical writing modes. Used by line overflow.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
Changed flexible boxes to just call the base class computeOverflow method.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
visible -> visual.

  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):
Changed layers to no longer incorporate right/bottom overflow into width/height. This is the reason many layout
tests change. (Not doing this makes the layout test changes far worse, since overflow propagates across self-painting
layers now.)

(WebCore::RenderLayer::overflowTop):
(WebCore::RenderLayer::overflowBottom):
(WebCore::RenderLayer::overflowLeft):
(WebCore::RenderLayer::overflowRight):
overflowTop/Bottom/Left/Right return overflow that accounts for writing modes, i.e., purely physical overflow that can be used
to set up the scroll area.

(WebCore::RenderLayer::computeScrollDimensions):
Drastically simplified this method now that overflowTop/Bottom/Left/Right just do the right thing regarding unreachable overflow.

(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Make sure to explicitly set the vertical scrollbar's position just as we did with horizontal scrollbars, so that clamping to the
bottom works.

(WebCore::performOverlapTests):
(WebCore::RenderLayer::paintLayer):
Fix a bug in performOverlapTests. It incorrectly used the layer's bounds, and so it didn't account for left/top overflow out
of the layer (see why I hate layers even having dimensions?). Changed it to use the bounding box of the layer instead.

(WebCore::RenderLayer::hitTest):
Fix a bug in hit testing. It incorrectly used the root layer's bounds as the limit of the hit test, and so it didn't account
for left/top overflow in a ScrollView (hate hate hate layers having dimensions). I changed it to use the hit test rect instead,
so that the damage rect never stops the point from being tested (unless the hit test request says not to ignore clipping).

(WebCore::RenderLayer::localBoundingBox):
visible -> visual.

  • rendering/RenderLayer.h:

Added the new overflowTop/Left/Right/Bottom accessors.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
visible -> visual.

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::addOverflowFromChildren):
(WebCore::RenderListItem::positionListMarker):

  • rendering/RenderListItem.h:

RenderListItem now positions the list marker when computing its overflow, since the marker propagates overflow back up to the list item.

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):
visible -> visual.

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):
Changed to use overflow functions instead of rightmost/lowestPosition.

  • rendering/RenderMedia.cpp:
  • rendering/RenderMedia.h:

Removed the lowest/topmost/rightmost/leftmostPosition functions, since control overflow is handled properly already.

  • rendering/RenderOverflow.h:

(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::setLayoutOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
Add new setters for layout and visual overflow as rects.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
visible -> visual.

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layout):
Call computeOverflow to recompute our overflow information after we adjust the ruby.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):
(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::paint):

  • rendering/RenderTable.h:

Move section overflow propagation into addOverflowFromChildren, and change RenderTable to just call computeOverflow.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
visible -> visual.

(WebCore::RenderTableCell::scrollbarsChanged):
Adding unreachable overflow support (something that in the old code only existed for positioned objects in the root view) exposed
a bug in table layout. If scrollbars are added during the layout that occurs after intrinsic padding was incorporated into the
cell, then the cell won't lay out properly the second time (after the scrollbars have been added). We have to adjust the intrinsic
padding accounting for the presence of the new scrollbar so the second layout will get the right dimensions.

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::hasVisualOverflow):
visible -> visual.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderTableSection.h:

visible -> visual. Removed the leftmost/rightmost/topmost/bottommostPosition functions.

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):
Added a hack to render tree dumping to include right/bottom overflow for the root layer only. This keeps a zillion layout tests
from failing.

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):
(WebCore::RenderView::docTop):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docRight):

  • rendering/RenderView.h:

(WebCore::RenderView::docHeight):
(WebCore::RenderView::docWidth):
RenderView now uses docLeft/Top/Height/Width functions, which are just overflow queries that account for writing modes. These methods
are now the preferred way to query for the physical dimensions of a document.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::addHighlightOverflow):
Changed to call setOverflowFromLogicalRects instead of the block/inline position functions.

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
Remove the computation of block direction overflow, since it now all happens at once after the line is built.

(WebCore::RootInlineBox::paddedLayoutOverflowRect):

  • rendering/RootInlineBox.h:

Added a new helper function for incorporating the end padding into a line. This end padding also includes the single pixel for a caret
in LTR if needed.

LayoutTests:

  • compositing/checkerboard-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • fast/backgrounds/size/contain-and-cover-expected.txt:
  • fast/flexbox/009.html:
  • fast/overflow/overflow-rtl-vertical.html: Added.
  • fast/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
  • fast/spatial-navigation/snav-clipped-overflowed-content.html:
  • platform/mac/compositing/direct-image-compositing-expected.txt:
  • platform/mac/compositing/geometry/fixed-position-expected.txt:
  • platform/mac/compositing/geometry/video-opacity-overlay-expected.txt:
  • platform/mac/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
  • platform/mac/compositing/overflow/scroll-ancestor-update-expected.txt:
  • platform/mac/compositing/reflections/load-video-in-reflection-expected.txt:
  • platform/mac/compositing/repaint/content-into-overflow-expected.txt:
  • platform/mac/compositing/repaint/overflow-into-content-expected.txt:
  • platform/mac/css1/box_properties/margin-expected.txt:
  • platform/mac/css1/box_properties/margin_right-expected.txt:
  • platform/mac/css1/classification/white_space-expected.txt:
  • platform/mac/css1/color_and_background/background_attachment-expected.txt:
  • platform/mac/css1/color_and_background/background_repeat-expected.txt:
  • platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt:
  • platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.txt:
  • platform/mac/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-00-d-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/mac/css2.1/t1202-counters-08-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-09-b-expected.txt:
  • platform/mac/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/mac/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/mac/editing/selection/25228-expected.txt:
  • platform/mac/editing/selection/focus_editable_html-expected.txt:
  • platform/mac/editing/selection/select-all-001-expected.txt:
  • platform/mac/editing/selection/select-all-002-expected.txt:
  • platform/mac/editing/selection/select-all-003-expected.txt:
  • platform/mac/editing/selection/select-all-004-expected.txt:
  • platform/mac/editing/selection/unrendered-001-expected.txt:
  • platform/mac/editing/selection/unrendered-002-expected.txt:
  • platform/mac/editing/selection/unrendered-003-expected.txt:
  • platform/mac/editing/selection/unrendered-004-expected.txt:
  • platform/mac/editing/selection/unrendered-005-expected.txt:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/mac/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/mac/fast/block/basic/010-expected.txt:
  • platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
  • platform/mac/fast/block/float/008-expected.txt:
  • platform/mac/fast/block/float/013-expected.txt:
  • platform/mac/fast/block/float/019-expected.txt:
  • platform/mac/fast/block/float/021-expected.txt:
  • platform/mac/fast/block/float/029-expected.txt:
  • platform/mac/fast/block/float/031-expected.txt:
  • platform/mac/fast/block/float/033-expected.txt:
  • platform/mac/fast/block/float/035-expected.txt:
  • platform/mac/fast/block/float/avoidance-percent-width-strict-expected.txt:
  • platform/mac/fast/block/float/clamped-right-float-expected.txt:
  • platform/mac/fast/block/float/float-in-float-painting-expected.txt:
  • platform/mac/fast/block/float/nested-clearance-expected.txt:
  • platform/mac/fast/block/float/relative-painted-twice-expected.txt:
  • platform/mac/fast/block/margin-collapse/004-expected.txt:
  • platform/mac/fast/block/margin-collapse/062-expected.txt:
  • platform/mac/fast/block/margin-collapse/063-expected.txt:
  • platform/mac/fast/block/margin-collapse/104-expected.txt:
  • platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/mac/fast/block/positioning/002-expected.txt:
  • platform/mac/fast/block/positioning/047-expected.txt:
  • platform/mac/fast/block/positioning/049-expected.txt:
  • platform/mac/fast/block/positioning/051-expected.txt:
  • platform/mac/fast/block/positioning/auto-height-with-top-and-bottom-expected.txt:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt:
  • platform/mac/fast/blockflow/block-level-images-expected.txt:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/mac/fast/body-propagation/background-color/002-expected.txt:
  • platform/mac/fast/body-propagation/background-color/002-xhtml-expected.txt:
  • platform/mac/fast/body-propagation/background-image/002-expected.txt:
  • platform/mac/fast/body-propagation/background-image/002-xhtml-expected.txt:
  • platform/mac/fast/body-propagation/overflow/001-expected.txt:
  • platform/mac/fast/body-propagation/overflow/001-xhtml-expected.txt:
  • platform/mac/fast/body-propagation/overflow/005-declarative-expected.txt:
  • platform/mac/fast/body-propagation/overflow/005-expected.txt:
  • platform/mac/fast/body-propagation/overflow/005-xhtml-expected.txt:
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
  • platform/mac/fast/box-shadow/basic-shadows-expected.txt:
  • platform/mac/fast/box-sizing/box-sizing-expected.txt:
  • platform/mac/fast/clip/008-expected.txt:
  • platform/mac/fast/clip/009-expected.txt:
  • platform/mac/fast/clip/010-expected.txt:
  • platform/mac/fast/clip/011-expected.txt:
  • platform/mac/fast/clip/012-expected.txt:
  • platform/mac/fast/compact/001-expected.txt:
  • platform/mac/fast/css/color-correction-on-background-image-expected.txt:
  • platform/mac/fast/css/negative-leading-expected.txt:
  • platform/mac/fast/css/percentage-non-integer-expected.txt:
  • platform/mac/fast/css/word-space-extra-expected.txt:
  • platform/mac/fast/dom/clone-node-dynamic-style-expected.txt:
  • platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/mac/fast/events/focusingUnloadedFrame-expected.txt:
  • platform/mac/fast/flexbox/009-expected.txt:
  • platform/mac/fast/flexbox/016-expected.txt:
  • platform/mac/fast/flexbox/flex-hang-expected.txt:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac/fast/forms/file-input-direction-expected.txt:
  • platform/mac/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt:
  • platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/mac/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/mac/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/mac/fast/gradients/background-clipped-expected.txt:
  • platform/mac/fast/images/gif-large-checkerboard-expected.txt:
  • platform/mac/fast/images/pdf-as-image-landscape-expected.txt:
  • platform/mac/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/mac/fast/inline/long-wrapped-line-expected.txt:
  • platform/mac/fast/layers/layer-visibility-expected.txt:
  • platform/mac/fast/layers/layer-visibility-sublayer-expected.txt:
  • platform/mac/fast/lists/001-expected.txt:
  • platform/mac/fast/lists/001-vertical-expected.txt:
  • platform/mac/fast/lists/003-expected.txt:
  • platform/mac/fast/lists/003-vertical-expected.txt:
  • platform/mac/fast/lists/li-br-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-02-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-03-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-04-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-05-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-06-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-07-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-08-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-09-expected.txt:
  • platform/mac/fast/media/mq-width-absolute-01-expected.txt:
  • platform/mac/fast/media/mq-width-absolute-02-expected.txt:
  • platform/mac/fast/media/mq-width-absolute-03-expected.txt:
  • platform/mac/fast/media/mq-width-absolute-04-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.txt:
  • platform/mac/fast/multicol/float-paginate-complex-expected.txt:
  • platform/mac/fast/multicol/float-paginate-expected.txt:
  • platform/mac/fast/multicol/layers-in-multicol-expected.txt:
  • platform/mac/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/mac/fast/multicol/table-vertical-align-expected.txt:
  • platform/mac/fast/overflow/006-expected.txt:
  • platform/mac/fast/overflow/float-in-relpositioned-expected.txt:
  • platform/mac/fast/overflow/overflow-auto-table-expected.txt:
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt: Added.
  • platform/mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/mac/fast/reflections/reflection-direction-expected.txt:
  • platform/mac/fast/repaint/box-shadow-h-expected.checksum:
  • platform/mac/fast/repaint/box-shadow-h-expected.png:
  • platform/mac/fast/repaint/box-shadow-h-expected.txt:
  • platform/mac/fast/repaint/box-shadow-v-expected.txt:
  • platform/mac/fast/repaint/content-into-overflow-expected.txt:
  • platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt:
  • platform/mac/fast/repaint/float-overflow-expected.txt:
  • platform/mac/fast/repaint/float-overflow-right-expected.txt:
  • platform/mac/fast/repaint/overflow-into-content-expected.txt:
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.txt:
  • platform/mac/fast/repaint/subtree-root-clip-expected.txt:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.checksum:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/mac/fast/replaced/004-expected.txt:
  • platform/mac/fast/table/034-expected.txt:
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-expected.txt:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
  • platform/mac/fast/table/frame-and-rules-expected.txt:
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt:
  • platform/mac/fast/table/wide-colspan-expected.txt:
  • platform/mac/fast/table/wide-column-expected.txt:
  • platform/mac/fast/text/international/thai-line-breaks-expected.txt:
  • platform/mac/fast/text/large-text-composed-char-expected.txt:
  • platform/mac/fast/text/letter-spacing-negative-opacity-expected.txt:
  • platform/mac/fast/text/text-letter-spacing-expected.txt:
  • platform/mac/fast/text/whitespace/012-expected.txt:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/printing/return-from-printing-mode-expected.txt:
  • platform/mac/svg/custom/altglyph-expected.txt:
  • platform/mac/svg/custom/getscreenctm-in-mixed-content-expected.txt:
  • platform/mac/svg/custom/path-bad-data-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/mac/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/mac/svg/text/kerning-expected.txt:
  • platform/mac/svg/text/multichar-glyph-expected.txt:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug196870-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug23151-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug29314-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug43039-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug43854-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug45055-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug5797-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug625-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug72359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug83786-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug92143-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/core/nested1-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_index-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table_align_left-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table_align_right-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_td_nowrap-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_th_nowrap-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug67915-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
  • platform/mac/transforms/svg-vs-css-expected.txt:
  • svg/custom/text-zoom-expected.txt:
12:00 PM Changeset in webkit [73384] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-12-02 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

make webkit-patch command work when the git branch is not synced to the remote svn branch
​https://bugs.webkit.org/show_bug.cgi?id=50424

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
11:59 AM Changeset in webkit [73383] by andersca@apple.com
  • 5 edits in trunk/WebKit2

REGERSSION (r73310?): Contents of <select> popup menus are upside-down on Windows
​https://bugs.webkit.org/show_bug.cgi?id=50544
<rdar://problem/8732336>

Reviewed by Dan Bernstein.

  • Shared/BackingStore.cpp:
  • Shared/BackingStore.h:
  • Shared/cairo/BackingStoreCairo.cpp:

Remove BackingStore::createFlippedGraphicsContext.

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):
Don't create a flipped graphics context.

11:52 AM Changeset in webkit [73382] by andersca@apple.com
  • 2 edits in trunk/WebKit2

REGRESSION: Text in Find indicator is vertically flipped
​https://bugs.webkit.org/show_bug.cgi?id=50524
<rdar://problem/8732978>

Reviewed by Dan Bernstein.

Don't flip the graphics context.

  • UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::draw):

11:48 AM Changeset in webkit [73381] by andersca@apple.com
  • 11 edits in trunk

Dispatch keyboard events in the Carbon event model
​https://bugs.webkit.org/show_bug.cgi?id=50503

Reviewed by Sam Weinig.

WebKit2:

  • Shared/WebEvent.h:

(WebKit::WebKeyboardEvent::macCharCode):

  • Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::WebKeyboardEvent):
(WebKit::WebKeyboardEvent::encode):
(WebKit::WebKeyboardEvent::decode):
Add macCharCode field.

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebKeyboardEvent):

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebKeyboardEvent):

  • Shared/win/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebKeyboardEvent):
Pass along the Mac char code.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Convert the event to a Carobn event.

WebKitLibraries:

Make WKGetNSEventKeyChar available in 32-bit.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:35 AM Changeset in webkit [73380] by cmarrin@apple.com
  • 16 edits
    6 copies
    2 deletes in trunk

2010-12-06 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
​https://bugs.webkit.org/show_bug.cgi?id=49388

Replaced GraphicsLayerMac with GraphicsLayerCA. GraphicsLayerCA is essentially
identical to GraphicsLayerMac, but replaces all the CoreAnimation specific calls
with calls to PlatformCALayer and PlatformCAAnimation. This makes GraphicsLayerCA
platform neutral as long as implementations of those two classes are available.
Added implementations in PlatformCALayerMac and PlatformCAAnimationMac. Also got
rid of GraphicsLayer::nativeLayer() and replaced it with GraphicsLayer::platformLayer()
to avoid confusion since both names were used to refer to the same thing.

This patch is only for Mac. Windows implementation has not changed.

11:31 AM Changeset in webkit [73379] by Simon Fraser
  • 4 edits in trunk/WebCore

2010-12-06 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Font antialiasing (smoothing) changes when elements are rendered into compositing layers
​https://bugs.webkit.org/show_bug.cgi?id=23364

Text rendered by Core Graphics over a transparent background looks bad because of
font smoothing, so turn off smoothing when rendering text into compositing layers.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setAllowsFontSmoothing):
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents):
11:08 AM Changeset in webkit [73378] by Patrick Gansterer
  • 5 edits
    8 adds in trunk

2010-12-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Add build system
​https://bugs.webkit.org/show_bug.cgi?id=50522

  • cmake/OptionsWinCE.cmake: Added.
  • cmake/OptionsWindows.cmake: Added.

2010-12-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Add build system
​https://bugs.webkit.org/show_bug.cgi?id=50522

  • CMakeListsWinCE.txt: Added.
  • shell/CMakeListsWinCE.txt: Added.
  • wtf/CMakeListsWinCE.txt: Added.

2010-12-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Add build system
​https://bugs.webkit.org/show_bug.cgi?id=50522

  • CMakeListsWinCE.txt: Added.

2010-12-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Add build system
​https://bugs.webkit.org/show_bug.cgi?id=50522

  • CMakeListsWinCE.txt: Added.

2010-12-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Add build system
​https://bugs.webkit.org/show_bug.cgi?id=50522

  • CMakeListsWinCE.txt: Added.
10:46 AM Changeset in webkit [73377] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-12-06 John Tantalo <​john.tantalo@gmail.com>

Reviewed by Geoffrey Garen.

jsc does not ignore shebang
​https://bugs.webkit.org/show_bug.cgi?id=49576

  • jsc.cpp: (fillBufferWithContentsOfFile):
    • translate shebang into a valid JavaScript comment so the lexer ignores it
10:20 AM Changeset in webkit [73376] by mihaip@chromium.org
  • 1 edit
    512 moves
    51 adds in trunk/LayoutTests

2010-12-06 Mihai Parparita <​mihaip@chromium.org>

Unreviewed move of Chromium baselines.

In preparation for making pixel tests pass for Chromium on Snow Leopard,
move baselines for 273 tests from chromium-mac to chromium-mac-leopard.
These tests will then use the mac baselines, which will enable them
to pass on Snow Leopard, but keep passing for Leopard too.

List of files omitted due to length but composed entirely of moves from
platform/chromium-mac to platform/chromium-mac-leopard.

10:06 AM Changeset in webkit [73375] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-03 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Allow the Chromium port to have Leopard-specific baselines
​https://bugs.webkit.org/show_bug.cgi?id=50506

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
9:36 AM Changeset in webkit [73374] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX does not support HTML5 "required"
​https://bugs.webkit.org/show_bug.cgi?id=50507

Reviewed by Oliver Hunt.

WebCore:

Test: platform/mac/accessibility/html5-required-attribute.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isRequired):

LayoutTests:

  • platform/mac/accessibility/html5-required-attribute-expected.txt: Added.
  • platform/mac/accessibility/html5-required-attribute.html: Added.
9:35 AM Changeset in webkit [73373] by tony@chromium.org
  • 5 edits in trunk/WebKitTools

2010-12-03 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix 2 bugs with inspector tests in DRT
​https://bugs.webkit.org/show_bug.cgi?id=50492

Tasks can outlive the tasklist (even when canceled) so this was
causing a crash when ~WebTask() ran. Avoid this by unregistering
when a task is canceled.

Also fix an assert when closing devtool windows by copying some
logic from test_shell.

  • DumpRenderTree/chromium/Task.cpp: (WebTask::~WebTask): (TaskList::revokeAll):
  • DumpRenderTree/chromium/Task.h: Canceling a task now removes it from

the tasklist (since the task can outlive the tasklist).

  • DumpRenderTree/chromium/TestShell.h: (TestShell::devToolsWebView):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::~WebViewHost): Don't load about:blank when closing

a window if the window has devtools loaded. This avoids an
ASSERT and matches test_shell.

9:13 AM Changeset in webkit [73372] by victorw@chromium.org
  • 1 edit
    21 adds in trunk/LayoutTests

2010-12-06 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations.

  • platform/chromium-linux/fast/css/focus-ring-outline-color-expected.checksum: Added.
  • platform/chromium-linux/fast/css/focus-ring-outline-color-expected.png: Added.
  • platform/chromium-linux/fast/css/focus-ring-outline-offset-expected.checksum: Added.
  • platform/chromium-linux/fast/css/focus-ring-outline-offset-expected.png: Added.
  • platform/chromium-linux/fast/css/focus-ring-outline-width-expected.checksum: Added.
  • platform/chromium-linux/fast/css/focus-ring-outline-width-expected.png: Added.
  • platform/chromium-mac/fast/css/focus-ring-outline-color-expected.checksum: Added.
  • platform/chromium-mac/fast/css/focus-ring-outline-color-expected.png: Added.
  • platform/chromium-mac/fast/css/focus-ring-outline-offset-expected.checksum: Added.
  • platform/chromium-mac/fast/css/focus-ring-outline-offset-expected.png: Added.
  • platform/chromium-mac/fast/css/focus-ring-outline-width-expected.checksum: Added.
  • platform/chromium-mac/fast/css/focus-ring-outline-width-expected.png: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-color-expected.checksum: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-color-expected.png: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-offset-expected.checksum: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-offset-expected.png: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-offset-expected.txt: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-width-expected.checksum: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-width-expected.png: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-width-expected.txt: Added.
8:49 AM Changeset in webkit [73371] by Dimitri Glazkov
  • 3 edits
    2 copies in branches/chromium/597

Merge 73319 - 2010-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): input event fires twice when editing text inside a text input.
​https://bugs.webkit.org/show_bug.cgi?id=50477

  • fast/forms/text-input-event-expected.txt: Added.
  • fast/forms/text-input-event.html: Added.

2010-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): input event fires twice when editing text inside a text input.
​https://bugs.webkit.org/show_bug.cgi?id=50477

Now that events escape the shadow DOM boundary, the input event is fired twice
for each input, once triggered by editing, once triggered by value change.

Test: fast/forms/text-input-event.html

  • dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer): Added a check to ensure editable fields

don't fire an extra input event.

BUG=64750
TBR=Dimitri Glazkov
Review URL: ​http://codereview.chromium.org/5589004

8:45 AM Changeset in webkit [73370] by sullivan@apple.com
  • 4 edits in trunk/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=50504
Expose some more WebCore settings in WebKit2 preferences

Reviewed by Adam Roben.

  • Shared/WebPreferencesStore.h:

Changed name of existing FOR_EACH_WEBKIT_STRING_PREFERENCE macro to
FOR_EACH_WEBKIT_FONT_FAMILY_PREFERENCE since it was all about platform-specific
font families, and I'm now introducing a non-platform-spacific string, and
I didn't want to put the new preference in two platform-specific lists. Then
added a new FOR_EACH_WEBKIT_STRING_PREFERENCE to hold the new preference. Note
that the other preferences exposed in this patch were already declared here.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDefaultFontSize):
New wrapper.
(WKPreferencesGetDefaultFontSize):
Ditto.
(WKPreferencesSetDefaultFixedFontSize):
Ditto.
(WKPreferencesGetDefaultFixedFontSize):
Ditto.
(WKPreferencesSetDefaultTextEncodingName):
Ditto.
(WKPreferencesCopyDefaultTextEncodingName):
Ditto.

  • UIProcess/API/C/WKPreferences.h:

Declare new wrappers.

8:00 AM Changeset in webkit [73369] by alex
  • 3 edits in trunk/WebCore

2010-12-06 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] using shadows leaks memory
​https://bugs.webkit.org/show_bug.cgi?id=50541

Fixed leaks in the shadow code.

  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::drawPatternToCairoContext): adoptRef instead of just getting a new reference.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow): handle cairo_path_t with smart pointers.
7:59 AM Changeset in webkit [73368] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-12-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Build is broken after r73353
​https://bugs.webkit.org/show_bug.cgi?id=50568

Fix the gtk-doc build by making all members of the cache model
enum public. gtk-doc does not support making only some enum
members private. We should also expose it so that users querying
the cache model do not get mysterious, undocumented results.

  • webkit/webkitwebview.h: Fix gtk-doc for the cache model enum.
7:41 AM Changeset in webkit [73367] by alex
  • 2 edits in trunk/WebKitTools

2010-12-06 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix GtkLauncher.c style, use webkit style
​https://bugs.webkit.org/show_bug.cgi?id=50542

  • GtkLauncher/main.c: (activateUriEntryCb): (updateTitle): (linkHoverCb): (notifyTitleCb): (notifyLoadStatusCb): (notifyProgressCb): (destroyCb): (goBackCb): (goForwardCb): (create_webViewCb): (webViewReadyCb): (closeWebViewCb): (createBrowser): (createStatusbar): (createToolbar): (createWindow): (main):
7:40 AM Changeset in webkit [73366] by yurys@chromium.org
  • 11 edits in trunk/WebCore

2010-12-06 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: remove duplicate code for capturing stack trace
​https://bugs.webkit.org/show_bug.cgi?id=50461

No new tests. Covered with existing inspector tests.

  • bindings/js/ScriptCallStackFactory.cpp: (WebCore::createScriptCallStack):
  • bindings/js/ScriptCallStackFactory.h:
  • bindings/v8/ScriptCallStackFactory.cpp: (WebCore::toScriptCallFrame): (WebCore::toScriptCallFramesVector): (WebCore::createScriptCallStack):
  • bindings/v8/ScriptCallStackFactory.h:
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler):
  • inspector/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::isEqual): (WebCore::ScriptCallFrame::buildInspectorObject):
  • inspector/ScriptCallFrame.h: (WebCore::ScriptCallFrame::sourceURL):
  • inspector/ScriptCallStack.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
7:06 AM Changeset in webkit [73365] by Csaba Osztrogonác
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected result for test introduced in r73257.

  • platform/qt/media/controls-without-preload-expected.checksum: Added.
  • platform/qt/media/controls-without-preload-expected.png: Added.
  • platform/qt/media/controls-without-preload-expected.txt: Added.
7:04 AM Changeset in webkit [73364] by yurys@chromium.org
  • 2 edits in branches/chromium/597/WebCore/inspector/front-end

Merge 73229 - 2010-12-02 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix heap snapshots loading. Loading is now
conducted by the Profiles panel which prevents accidental
simultaneous attempts to load the same profile several times in
parallel.

​https://bugs.webkit.org/show_bug.cgi?id=50427

  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._loadProfile): (WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot):

TBR=​mnaganov@chromium.org
Review URL: ​http://codereview.chromium.org/5657001

6:52 AM Changeset in webkit [73363] by Csaba Osztrogonác
  • 2 edits
    2 copies in trunk

Unreviewed.

WebCore: == Rolled over to ChangeLog-2010-12-06 ==
LayoutTests: == Rolled over to ChangeLog-2010-12-06 ==

6:47 AM Changeset in webkit [73362] by yael.aharon@nokia.com
  • 3 edits
    21 adds in trunk

[Qt] Support focus ring outline color for links.
​https://bugs.webkit.org/show_bug.cgi?id=50428

Reviewed by Andreas Kling.

WebCore:

Take width and offset into account when drawing focus ring.

Tests: fast/css/focus-ring-outline-color.html

fast/css/focus-ring-outline-offset.html
fast/css/focus-ring-outline-width.html

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawFocusRing):

LayoutTests:

  • fast/css/focus-ring-outline-color.html: Added.
  • fast/css/focus-ring-outline-offset.html: Added.
  • fast/css/focus-ring-outline-width.html: Added.
  • platform/mac/fast/css/focus-ring-outline-color-expected.checksum: Added.
  • platform/mac/fast/css/focus-ring-outline-color-expected.png: Added.
  • platform/mac/fast/css/focus-ring-outline-color-expected.txt: Added.
  • platform/mac/fast/css/focus-ring-outline-offset-expected.checksum: Added.
  • platform/mac/fast/css/focus-ring-outline-offset-expected.png: Added.
  • platform/mac/fast/css/focus-ring-outline-offset-expected.txt: Added.
  • platform/mac/fast/css/focus-ring-outline-width-expected.checksum: Added.
  • platform/mac/fast/css/focus-ring-outline-width-expected.png: Added.
  • platform/mac/fast/css/focus-ring-outline-width-expected.txt: Added.
  • platform/qt/fast/css/focus-ring-outline-color-expected.checksum: Added.
  • platform/qt/fast/css/focus-ring-outline-color-expected.png: Added.
  • platform/qt/fast/css/focus-ring-outline-color-expected.txt: Added.
  • platform/qt/fast/css/focus-ring-outline-offset-expected.checksum: Added.
  • platform/qt/fast/css/focus-ring-outline-offset-expected.png: Added.
  • platform/qt/fast/css/focus-ring-outline-offset-expected.txt: Added.
  • platform/qt/fast/css/focus-ring-outline-width-expected.checksum: Added.
  • platform/qt/fast/css/focus-ring-outline-width-expected.png: Added.
  • platform/qt/fast/css/focus-ring-outline-width-expected.txt: Added.
6:33 AM Changeset in webkit [73361] by yael.aharon@nokia.com
  • 8 edits
    9 adds in trunk

[Qt] Fix focus ring outline color support
​https://bugs.webkit.org/show_bug.cgi?id=50325

Reviewed by Andreas Kling.

WebCore:

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawFocusRing):

Take the outline width into account when drawing the focus ring of image map.
Change the outline-style from dotted to solid. The default outline-width is
5 pixels, and dotted lines just don't make sense anymore.
Give the focus ring alpha of 50%, following what other ports do.
Save and restore the pen when drawing a focus ring.

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/fast/images/imagemap-focus-ring-expected.checksum:
  • platform/qt/fast/images/imagemap-focus-ring-expected.png:
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.checksum: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.checksum: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.checksum:
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png:
5:45 AM Changeset in webkit [73360] by yael.aharon@nokia.com
  • 3 edits in trunk/LayoutTests

Unreviewed.

Added a proper mime-type to images.

  • platform/qt/fast/images/imagemap-focus-ring-expected.png: Added property svn:mime-type.
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png: Added property svn:mime-type.
5:21 AM Changeset in webkit [73359] by Csaba Osztrogonác
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for tests introduced in r73296.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Added.
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
5:19 AM Changeset in webkit [73358] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2010-12-06 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][V8] Build fix after r73283.

No new tests needed.

  • WebCore.pri: Add missing webaudio directory to IDL generator includes.
4:31 AM Changeset in webkit [73357] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-12-06 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[soup] implement ResourceHandle::platformSetDefersLoading
​https://bugs.webkit.org/show_bug.cgi?id=44158

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::platformSetDefersLoading): Implemented using the soup_session_{,un}pause_message APIs.
4:24 AM Changeset in webkit [73356] by sergio@webkit.org
  • 2 edits in trunk/WebCore

2010-12-06 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Leak in webkit_soup_cache_load if file contents load fails
​https://bugs.webkit.org/show_bug.cgi?id=50558

g_file_get_contents() could return an error after allocating a
buffer for file contents. We must free that memory before
returning.

  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_load): Added a missing g_free().
3:59 AM Changeset in webkit [73355] by yurys@chromium.org
  • 11 edits in trunk/WebCore

2010-12-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73351.
​http://trac.webkit.org/changeset/73351
​https://bugs.webkit.org/show_bug.cgi?id=50560

"The change broke plugin tests in Chromium" (Requested by
yurys on #webkit).

  • bindings/js/ScriptCallStackFactory.cpp: (WebCore::ScriptCallStack::stackTrace):
  • bindings/js/ScriptCallStackFactory.h:
  • bindings/v8/ScriptCallStackFactory.cpp: (WebCore::toScriptCallFrame): (WebCore::toScriptCallFramesVector): (WebCore::createScriptCallStack): (WebCore::ScriptCallStack::stackTrace):
  • bindings/v8/ScriptCallStackFactory.h:
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler):
  • inspector/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::isEqual): (WebCore::ScriptCallFrame::buildInspectorObject):
  • inspector/ScriptCallFrame.h: (WebCore::ScriptCallFrame::sourceURL):
  • inspector/ScriptCallStack.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
3:23 AM Changeset in webkit [73354] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-12-06 Derek Weitzel <​djw8605@gmail.com>

Reviewed by Martin Robinson.

[GTK] API Documentation referencing depreciated GTK_WIDGET_TOPLEVEL
​https://bugs.webkit.org/show_bug.cgi?id=50512

Fixed reference to depreciated GTK_WIDGET_TOPLEVEL.

  • webkit/webkitwebview.cpp:
3:18 AM Changeset in webkit [73353] by Martin Robinson
  • 5 edits in trunk/WebKit/gtk

2010-12-06 Joone Hur <​joone@kldp.org>

Reviewed by Xan Lopez.

[GTK] The webkit cache model needs to be set when WebFrameLoaderClient::didPerformFirstNavigation() is called
​https://bugs.webkit.org/show_bug.cgi?id=50430

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didPerformFirstNavigation): Set the webview cache model.
  • webkit/webkitprivate.cpp: (webkit_init): Removed the code of setting the webview cache model.
2:55 AM QtWebKitFeaturePlanning edited by Henry Haverinen
(diff)
2:24 AM Changeset in webkit [73352] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

[Qt] Report zero width for zero size fonts

Patch by Robert Hogan <​robert@webkit.org> on 2010-12-06
Reviewed by Kenneth Rohde Christiansen.

Report zero width when font size is zero.

Fixes fast/text/font-size-zero.html

​https://bugs.webkit.org/show_bug.cgi?id=50539

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::floatWidthForComplexText):

2:13 AM Changeset in webkit [73351] by yurys@chromium.org
  • 11 edits in trunk/WebCore

2010-12-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: remove duplicate code for capturing stack trace
​https://bugs.webkit.org/show_bug.cgi?id=50461

No new tests. Covered with existing inspector tests.

  • bindings/js/ScriptCallStackFactory.cpp: (WebCore::createScriptCallStack):
  • bindings/js/ScriptCallStackFactory.h:
  • bindings/v8/ScriptCallStackFactory.cpp: (WebCore::toScriptCallFrame): (WebCore::toScriptCallFramesVector): (WebCore::createScriptCallStack):
  • bindings/v8/ScriptCallStackFactory.h:
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler):
  • inspector/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::isEqual): (WebCore::ScriptCallFrame::buildInspectorObject):
  • inspector/ScriptCallFrame.h: (WebCore::ScriptCallFrame::sourceURL):
  • inspector/ScriptCallStack.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
2:03 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
(diff)
2:01 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
(diff)
1:50 AM BuildingQtOnSymbian edited by jocelyn.turcotte@nokia.com
QtLauncher --> QtTestBrowser (diff)
1:49 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
QtLauncher --> QtTestBrowser (diff)
1:42 AM Changeset in webkit [73350] by sergio@webkit.org
  • 2 edits in trunk/WebCore

2010-12-06 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] webkit_soup_cache_clear() does not delete all entries in the cache
​https://bugs.webkit.org/show_bug.cgi?id=50462

Do not use g_hash_table_foreach to remove entries from the cache
entries hashtable. Iterate over a list of entries to remove them
from the hash table.

  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/soup/cache/webkit/soup-cache.c: (remove_cache_item): (webkit_soup_cache_finalize): (clear_cache_item): (webkit_soup_cache_clear):
Note: See TracTimeline for information about the timeline view.