⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 10, 2010:

11:29 PM Changeset in webkit [73846] by sfalken@apple.com
  • 3 edits in tags/Safari-534.14.2/WebCore

Merge r73840.

11:26 PM Changeset in webkit [73845] by sfalken@apple.com
  • 2 edits in tags/Safari-534.14.2/JavaScriptCore

Merge r73837.

11:21 PM Changeset in webkit [73844] by ap@apple.com
  • 2 edits in trunk/WebCore

Mac build fix.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit): Resolve string[0] ambiguity by passing 0U.
11:19 PM Changeset in webkit [73843] by sfalken@apple.com
  • 5 edits in tags/Safari-534.14.2

Versioning.

11:14 PM Changeset in webkit [73842] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-12-10 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Eric Seidel.

[Qt] Build fix for Symbian: don't compile POSIX memory management implementation
​https://bugs.webkit.org/show_bug.cgi?id=50707

  • wtf/wtf.pri:
11:10 PM Changeset in webkit [73841] by sfalken@apple.com
  • 1 copy in tags/Safari-534.14.2

New tag.

11:03 PM Changeset in webkit [73840] by sfalken@apple.com
  • 3 edits in trunk/WebCore

Windows production build fix.

Only the vsprops are indirected through WebKitVSPropsRedirectionDir, not the scripts in WebKitLibraries/win/tools/scripts.

  • WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
  • WebCore.vcproj/build-generated-files.sh:
10:50 PM Changeset in webkit [73839] by commit-queue@webkit.org
  • 1 edit
    2 deletes in trunk/WebCore

2010-12-10 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Eric Seidel.

Remove WebCore/platform/mac/GeolocationService.{h,mm}
​https://bugs.webkit.org/show_bug.cgi?id=50074

Remove unused non-client-based geolocation code.

  • platform/mac/GeolocationServiceMac.h: Removed.
  • platform/mac/GeolocationServiceMac.mm: Removed.
10:47 PM Changeset in webkit [73838] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-12-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue flaky test messages show cryptic version information for mac os x
​https://bugs.webkit.org/show_bug.cgi?id=50864

Turns out platform.platform() returns kernel version information
which isn't helpful, and just plain confusing on Mac
(OS X 10.6.5 uses Darwin Kernel 10.5.0).

So I've updated PlatformInfo.display_name() to special case
mac. I also found a bad use of sys.platform in the process
and fixed that. (sys.platform always returns 'darwin' on mac).

  • Scripts/webkitpy/common/system/platforminfo.py:
  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
10:40 PM Changeset in webkit [73837] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows production build fix.

Don't stop if react-to-vsprops-changes.py exits with an error,
since this will occur in production builds.

10:15 PM Changeset in webkit [73836] by ap@apple.com
  • 4 edits
    2 adds in trunk

2010-12-10 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=46573
<rdar://problem/8479389> REGRESSION: charset="utf-8" (with quotes) doesn't work

  • http/tests/mime/quoted-charset-expected.txt: Added.
  • http/tests/mime/quoted-charset.php: Added.

2010-12-10 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=46573
<rdar://problem/8479389> REGRESSION: charset="utf-8" (with quotes) doesn't work

Test: http/tests/mime/quoted-charset.php

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Work around a CFNetwork issue, strip quotes if they are present.
9:34 PM Changeset in webkit [73835] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-12-10 Eric Seidel <​eric@webkit.org>

Unreviewed.

Exception seen while reporting flaky test with commit-queue.
Just a missing include.

  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
8:58 PM Changeset in webkit [73834] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-12-10 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Eric Seidel.

[Qt][WK2] Make WebKit2 static library compile on Symbian
​https://bugs.webkit.org/show_bug.cgi?id=50861

  • WebKit2.pro:
7:25 PM Changeset in webkit [73833] by kinuko@chromium.org
  • 3 edits in trunk/WebKitTools

2010-12-10 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
​https://bugs.webkit.org/show_bug.cgi?id=50796

Also updating the test code to use JSONResultsGeneratorBase and
to improve test coverage for incremental cases.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
7:00 PM Changeset in webkit [73832] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-10 Vincent Scheib <​scheib@chromium.org>

Reviewed by James Robinson.

Shader::loadShader() must initialize variable passed to getShaderiv
​https://bugs.webkit.org/show_bug.cgi?id=50842

Test: fast/canvas/canvas-largedraws.html

  • platform/graphics/gpu/Shader.cpp: (WebCore::Shader::loadShader):
6:53 PM Changeset in webkit [73831] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-12-10 Vincent Scheib <​scheib@chromium.org>

Reviewed by James Robinson.

Texture::updateSubRect should pass IntRect by reference
​https://bugs.webkit.org/show_bug.cgi?id=50845

No test, changing to pass by ref.

  • platform/graphics/gpu/Texture.cpp: (WebCore::Texture::updateSubRect):
  • platform/graphics/gpu/Texture.h:
6:43 PM Changeset in webkit [73830] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-10 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium test expectation update.

Attach more specific bug IDs to Philip canvas test suite failures.

  • platform/chromium/test_expectations.txt:
6:20 PM Changeset in webkit [73829] by Darin Adler
  • 6 edits in trunk/WebCore

2010-12-10 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Move open and showModalDialog implementations from bindings into DOM class DOMWindow
​https://bugs.webkit.org/show_bug.cgi?id=50836

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::open): Removed most of the code and changed to call DOMWindow::open. (WebCore::DialogHandler::DialogHandler): Added. Object is used to handle the arguments and return value in showModalDialog. (WebCore::DialogHandler::dialogCreated): Ditto. (WebCore::DialogHandler::returnValue): Ditto. (WebCore::setUpDialog): Added. Function passed to showModalDialog that just casts pointer to DialogHandler can calls dialogCreated. (WebCore::JSDOMWindow::showModalDialog): Removed most of the code and changed to call DOMWindow::showModalDialog. (WebCore::JSDOMWindow::postMessage): Made style match the rest of the file by renaming local variables and getting rid of a needless ones.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::parseModalDialogFeatures): Moved body of this function to the WindowFeatures class. (WebCore::DOMWindow::allowPopUp): Renamed argument from activeFrame to firstFrame, because that's the frame we pass in here. Also added an overload so this can be called on a window rather than a frame. (WebCore::DOMWindow::setLocation): Renamed a couple variables so the names are the same as in open and showModalDialog. Factored the JavaScript security check into a new function named isInsecureScriptAccess. (WebCore::DOMWindow::isInsecureScriptAccess): Here is the new function. (WebCore::DOMWindow::createWindow): Added. Contains logic shared by open and showModalDialog just as the function named createWindow in JSDOMWindowCustom.cpp used to. (WebCore::DOMWindow::open): Added. Code from JSDOMWindowCustom without the JavaScript language binding part, and with a bit of refactoring to share code with the rest of the DOMWindow class. (WebCore::DOMWindow::showModalDialog): Ditto.
  • page/DOMWindow.h: Moved conditional parts of the file into separate paragraphs in alphabetical order so they are not scattered thorugh the file. Removed redundant includes. Added some blank lines for clarity. Added an open function and a showModalDialog function. Added private createWindow and isInsecureScriptAccess functions.
  • page/WindowFeatures.cpp: (WebCore::isWindowFeaturesSeparator): Renamed from isSeparator for clarity. (WebCore::WindowFeatures::WindowFeatures): Updated for name change. Used isEmpty instead of checking length. Added a new constructor for use when making dialogs, with code from the showModalDialog function. (WebCore::WindowFeatures::boolFeature): Use DialogFeaturesMap typedef. (WebCore::WindowFeatures::floatFeature): Use DialogFeaturesMap typedef. Renamed a local variable and tweaked the comments a bit. (WebCore::WindowFeatures::parseDialogFeatures): Added. Code moved here from DOMWindow::parseDialogFeatures and refactored a bit.
  • page/WindowFeatures.h: Added new constructor, new parseDialogFeatures function, DialogFeaturesMap typedef, and made setWindowFeature function private.
6:14 PM Changeset in webkit [73828] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Ensure that we are not getting too many wheel events
<rdar://problem/7881465>

Reviewed by Anders Carlsson.

Add simple coalescing of wheel events being sent to the WebProcess. This
adds two models, one which drops interim events and one which merges events
together. For now, we are using the simpler dropping model.

  • Shared/WebEvent.h:

(WebKit::WebEvent::modifiers):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::coalesceWheelEvents):
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::didReceiveEvent):

  • UIProcess/WebPageProxy.h:
6:08 PM Changeset in webkit [73827] by Joseph Pecoraro
  • 8 edits in trunk/WebKitTools

2010-12-10 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

prepare-ChangeLog --help doesn't mention --bug shorthand -b
​https://bugs.webkit.org/show_bug.cgi?id=50835

  • Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
6:02 PM Changeset in webkit [73826] by Joseph Pecoraro
  • 2 edits in trunk/WebKitTools

2010-12-10 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

prepare-ChangeLog --help doesn't mention --bug shorthand -b
​https://bugs.webkit.org/show_bug.cgi?id=50835

  • Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
6:00 PM Changeset in webkit [73825] by Chris Fleizach
  • 14 edits in trunk

AX: refactor AccessibilityRenderObject::doAccessibilityHitTest
​https://bugs.webkit.org/show_bug.cgi?id=50574

Reviewed by Darin Adler.

WebCore:

Refactors accessibility hit testing to allow for a more flexible model when handling elements
with fake sub-elements (like sliders or list boxes).

Renamed doAccessibilityHitTest -> accessibilityHitTest, which is called on the root
accessibility render object. Then subclassers are able to override
elementAccessibilityHitTest to return their own specific elements.

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::elementAccessibilityHitTest):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::accessibilityHitTest):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityHitTest):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::elementAccessibilityHitTest):

  • accessibility/AccessibilitySlider.h:
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_component_ref_accessible_at_point):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityHitTest:]):

WebKit/chromium:

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::hitTest):

WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::accHitTest):

5:48 PM Changeset in webkit [73824] by commit-queue@webkit.org
  • 6 edits
    5 adds
    40 deletes in trunk/LayoutTests

2010-12-10 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by Ojan Vafai.

Remove unnecessary pixel results, use platform-independent text results, re Changeset 72802
​https://bugs.webkit.org/show_bug.cgi?id=50233

First part of two-part patch to remove unnecessary pixel tests, and (in part two)
have a single set of text expectations for all platforms. The standardized text
expectations are added in this patch.

  • platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.png: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.png: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.png: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.png: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.png: Removed.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.png: Removed.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.png: Removed.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.png: Removed.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.png: Removed.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.png: Removed.
  • platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.png: Removed.
  • platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.png: Removed.
  • platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.png: Removed.
  • platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.png: Removed.
  • platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.png: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-1-expected.png: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-2-expected.png: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-3-expected.png: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-4-expected.png: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-5-expected.png: Removed.
  • svg/custom/svg-parse-overflow-1-expected.txt: Added.
  • svg/custom/svg-parse-overflow-1.html:
  • svg/custom/svg-parse-overflow-2-expected.txt: Added.
  • svg/custom/svg-parse-overflow-2.html:
  • svg/custom/svg-parse-overflow-3-expected.txt: Added.
  • svg/custom/svg-parse-overflow-3.html:
  • svg/custom/svg-parse-overflow-4-expected.txt: Added.
  • svg/custom/svg-parse-overflow-4.html:
  • svg/custom/svg-parse-overflow-5-expected.txt: Added.
  • svg/custom/svg-parse-overflow-5.html:
5:35 PM Changeset in webkit [73823] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-12-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
​https://bugs.webkit.org/show_bug.cgi?id=50853

I also discovered when doing this that the code was posting
the comment on the wrong bug, but that's fixed here too.

  • Scripts/webkitpy/common/net/bugzilla/bug.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
5:31 PM Changeset in webkit [73822] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
5:25 PM Changeset in webkit [73821] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-12-10 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Adler.

Clean up assertion in Extensions3DOpenGL.cpp
​https://bugs.webkit.org/show_bug.cgi?id=50852

Built Release mode to test. No functionality change.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::ensureEnabled):
5:23 PM Changeset in webkit [73820] by commit-queue@webkit.org
  • 9 edits
    4 adds in trunk

2010-12-10 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Eric Seidel.

Crash while processing ill-formed <textPath> ouside of <text>
​https://bugs.webkit.org/show_bug.cgi?id=47759

Ensure that ill-formed text content child elements do not crash.

  • svg/custom/invalid-text-content.svg: Added.
  • svg/custom/invalid-text-content-expected.checksum: Added.
  • svg/custom/invalid-text-content-expected.png: Added.
  • svg/custom/invalid-text-content-expected.txt: Added.

2010-12-10 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Eric Seidel.

Crash while processing ill-formed <textPath> ouside of <text>
​https://bugs.webkit.org/show_bug.cgi?id=47759

Renderers within a <text> subtree are created only when their corresponding elements
satisfy the content model.

Test: svg/custom/invalid-text-content.svg

  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::childShouldCreateRenderer): Fixed to comply with the content model. (WebCore::SVGTRefElement::rendererIsNeeded): Added.
  • svg/SVGTRefElement.h:
  • svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::childShouldCreateRenderer): Fixed to comply with the content model. (WebCore::SVGTSpanElement::rendererIsNeeded): Added.
  • svg/SVGTSpanElement.h: Changed indentation.
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::childShouldCreateRenderer): Reformatted.
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::childShouldCreateRenderer): Fixed to comply with the content model. (WebCore::SVGTextPathElement::rendererIsNeeded): Added.
  • svg/SVGTextPathElement.h:
5:19 PM Changeset in webkit [73819] by zmo@google.com
  • 24 edits in trunk

2010-12-10 Zhenyao Mo <​zmo@google.com>

Reviewed by Adam Barth.

Use enums instead of booleans in ImageSource/ImageDecoder constructors
​https://bugs.webkit.org/show_bug.cgi?id=50818

  • src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::init): Use enums instead of boolean in ImageDecoder constructor.

2010-12-10 Zhenyao Mo <​zmo@google.com>

Reviewed by Adam Barth.

Use enums instead of booleans in ImageSource/ImageDecoder constructors
​https://bugs.webkit.org/show_bug.cgi?id=50818

This patch basically defines two enum type in ImageSource: AlphaOption
and GammaAndColorProfileOption and use them as ImageSource and ImageDecoder
constructor parameters instead of boolean typs.

  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::setData):
  • platform/graphics/ImageSource.h: Define the two enum types.
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::ImageSource):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoder::create): (WebCore::ImageDecoderQt::ImageDecoderQt):
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create):
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder):
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder):
  • platform/image-decoders/bmp/BMPImageDecoder.h:
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::GIFImageDecoder):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::decodeAtIndex):
  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::JPEGImageDecoder):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::PNGImageDecoder):
  • platform/image-decoders/png/PNGImageDecoder.h:
  • platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::WEBPImageDecoder):
  • platform/image-decoders/webp/WEBPImageDecoder.h:
4:30 PM Changeset in webkit [73818] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-12-10 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r73799): editing/execCommand/4920488.html fails
​https://bugs.webkit.org/show_bug.cgi?id=50854

The regression was caused by Range::processContents's not extracting
m_end.container()->firstChild(). Fixed the bug by always adding the first child.

  • dom/Range.cpp: (WebCore::Range::processContents):
4:12 PM Changeset in webkit [73817] by abarth@webkit.org
  • 4 edits
    6 adds in trunk

2010-12-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: Infinite redirect on developer.apple.com
​https://bugs.webkit.org/show_bug.cgi?id=45627

Tests: fast/loader/form-submit-aborts-parsing.html

fast/loader/location-change-aborts-parsing.html

This patch is not pretty, but it fixes the bug. I stole this approach
from the old HTML parser (as suggested by Eric Seidel). The other
approaches that folks tried for this bug are better, but it's inclear
how to get them to work correctly. I've added a large FIXME comment.

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::isParsingFragment):

2010-12-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: Infinite redirect on developer.apple.com
​https://bugs.webkit.org/show_bug.cgi?id=45627

Tests originally by Tony Gentilcore.

  • fast/loader/form-submit-aborts-parsing-expected.txt: Added.
  • fast/loader/form-submit-aborts-parsing.html: Added.
  • fast/loader/location-change-aborts-parsing-expected.txt: Added.
  • fast/loader/location-change-aborts-parsing.html: Added.
  • fast/loader/resources/location-change-aborts-parsing-fail.html: Added.
  • fast/loader/resources/location-change-aborts-parsing-pass.html: Added.
3:49 PM Changeset in webkit [73816] by andersca@apple.com
  • 13 edits in trunk

Make WKContextGetStatistics gather global statistics
​https://bugs.webkit.org/show_bug.cgi?id=50850

Reviewed by John Sullivan.

WebKit2:

Change WKContextGetStatistics to work on all objects in the process, and
make it more robust by incrementing/decrementing the counts in the constructor
and destructor respectively.

Also, rename WKContextGetStatistics to WKContextGetGlobalStatistics to better match
what it's actually doing.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetStatistics):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:pageGroupRef:]):
(-[WKView dealloc]):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::statistics):

  • UIProcess/WebContext.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::~WebFrameProxy):

  • UIProcess/WebPageNamespace.cpp:
  • UIProcess/WebPageNamespace.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):

  • UIProcess/WebPageProxy.h:

WebKitTools:

Remove the code that gets the statistics and fills in the per context
statistics information for now.

  • MiniBrowser/mac/BrowserStatisticsWindowController.m:

(-[BrowserStatisticsWindowController refreshStatistics:]):

3:43 PM Changeset in webkit [73815] by bweinstein@apple.com
  • 4 edits in trunk/WebKit2

WebKit2: Context menu support on Windows
<​https://bugs.webkit.org/show_bug.cgi?id=50514>

Reviewed by Darin Adler.

Implment showing of the context menu on Windows for WebKit2, and calling through to
WebPageProxy::contextMenuItemSelected.

  • UIProcess/win/WebContextMenuProxyWin.cpp:

(WebKit::WebContextMenuProxyWin::WebContextMenuProxyWin): Initialize the member variables.
(WebKit::WebContextMenuProxyWin::populateMenu): Iterate over the vector of WebContextMenuItemData

that was passed in, adding the menu items and recursively calling back into this function to populate
any submenus that are needed. This function also sets up the map from action identifierss to WebContextMenuItemData,
to use to find the WebContextMenuItemData from a selected menu item.

(WebKit::WebContextMenuProxyWin::showContextMenu): Destroy any menu we have already created, populate the menu

to show, and show the context menu. Once TrackPopupMenuEx returns, it returns identifier of the selected menu item.
Look up that identifier in the map we created, and tell the WebPageProxy that a context menu item was selected.

(WebKit::WebContextMenuProxyWin::hideContextMenu): Destroy the HMENU if it is non-null, and clear the identifier map.

  • UIProcess/win/WebContextMenuProxyWin.h:

(WebKit::WebContextMenuProxyWin::create): Call through to the constructor, and change the arguments that it takes.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::createContextMenuProxy): Call with the correct arguments.

3:41 PM Changeset in webkit [73814] by jberlin@webkit.org
  • 2 edits in trunk/WebKit2

Qt Build Fix. Unreviewed.

  • WebKit2.pro:

Add the Messages.h and MessageReceivers.h.

3:41 PM Changeset in webkit [73813] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

When we are creating a ContextMenuItem, only call setSubMenu if we have
a subMenu to set.

Reviewed by Ada Chan.

  • platform/ContextMenuItem.cpp:

(WebCore::ContextMenuItem::ContextMenuItem):

3:40 PM Changeset in webkit [73812] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-12-10 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Regression: fast/canvas/webgl/constants.html failing
​https://bugs.webkit.org/show_bug.cgi?id=50851

  • fast/canvas/webgl/constants.html:
3:33 PM Changeset in webkit [73811] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-10 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium test expectation update.

Attach more specific bug IDs to Philip canvas test suite failures (for
existing bugs only).

  • platform/chromium/test_expectations.txt:
3:19 PM Changeset in webkit [73810] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-12-10 Kenneth Russell <​kbr@google.com>

Unreviewed, another build fix. #include <wtf/UnusedParam.h> needed
for Release builds.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:
3:14 PM Changeset in webkit [73809] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-12-10 Kenneth Russell <​kbr@google.com>

Unreviewed, build fix. Change #ifndef NDEBUG to #ifdef NDEBUG.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::ensureEnabled):
3:12 PM Changeset in webkit [73808] by jberlin@webkit.org
  • 20 edits
    6 adds in trunk/WebKit2

WebKit2: Need a WebKit2 equivalent of the WebKit1 WebDatabaseManager
​https://bugs.webkit.org/show_bug.cgi?id=50606

Reviewed by Adam Roben and Sam Weinig.

Add a WebDatabaseManagerProxy owned by the WebContext.

Expose API (similar to the WebKit1 API) to get a list of origins for which there are
Databases, delete all the databases for a given origin, and delete all the databases.

Add WebDatabaseManager and WebDatabaseManagerProxy as messages receivers.

  • DerivedSources.make:
  • Platform/CoreIPC/MessageID.h:

Add the WebDatabaseManagerProxy as a UIProcess type (DatabaseManager).

  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetDatabaseManager):
Expose API to get the DatabaseManager.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKDatabaseManager.cpp: Added.

(WKDatabaseManagerGetTypeID):
(WKDatabaseManagerGetDatabaseOrigins):
(callGetDatabaseOriginsBlockBlockAndDispose):
(WKDatabaseManagerGetDatabaseOrigins_b):
(WKDatabaseManagerDeleteDatabasesForOrigin):
(WKDatabaseManagerDeleteAllDatabases):

  • UIProcess/API/C/WKDatabaseManager.h: Added.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
Create the WebDatabaseManagerProxy.
(WebKit::WebContext::processDidClose):
Invalidate the WebDatabaseManagerProxy.
(WebKit::WebContext::didReceiveMessage):
Forward messages to the WebDatabaseManagerProxy.

  • UIProcess/WebContext.h:

(WebKit::WebContext::databaseManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.cpp: Added.

(WebKit::WebDatabaseManagerProxy::create):
(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy):
(WebKit::WebDatabaseManagerProxy::~WebDatabaseManagerProxy):
(WebKit::WebDatabaseManagerProxy::invalidate):
Invalidate the map of callbacks for getDatabaseOrigins.
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
Store the callback and send the request for the origins which have databases to the
WebProcess.
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
Call the callback function with the SecurityOrigins created from the identifiers received.
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
If the origin exists, send the message on to the WebProcess to delete the databases
associated with that origin.
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
Send the message to the WebProcess to delete all the databases.

  • UIProcess/WebDatabaseManagerProxy.h: Added.

(WebKit::WebDatabaseManagerProxy::type):

  • UIProcess/WebDatabaseManagerProxy.messages.in: Added.
  • UIProcess/WebPageProxy.cpp:

Move invalidateCallbackMap from here ...

  • UIProcess/GenericCallback.h:

(WebKit::invalidateCallbackMap):
.. to here so that it can be used elsewhere (e.g. by WebDatabaseManagerProxy).

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):
Forward on all messages destined for the WebDatabaseManagerProxy to the WebContext.

  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::didReceiveMessage):
(WebKit::WebDatabaseManager::getDatabaseOrigins):
Send an array of the identifiers for the SecurityOrigins for which there are databases to
the UIProcess.
(WebKit::WebDatabaseManager::deleteDatabasesForOrigin):
If the SecurityOrigin with that identifier exists, tell the DatabaseTracker to delete the
databases for that origin.
(WebKit::WebDatabaseManager::deleteAllDatabases):
Tell the DatabaseTracker to delete the databases for that origin.

  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.messages.in: Added.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):

  • WebKit2.pro:

Add WKDatabaseManager.cpp/.h and WebDatabaseManagerProxy.cpp/.h

  • WebKit2.xcodeproj/project.pbxproj:

Ditto, also add WebDatabaseManagerProxy.messages.in and WebDatabaseManager.messages.in.

  • win/WebKit2.vcproj:

Ditto.

  • win/WebKit2Generated.make:

Make sure WKDatabaseManager.h is copied into WebKitBuild on Windows.

2:58 PM Changeset in webkit [73807] by adachan@apple.com
  • 3 edits in trunk/WebKit2

Reviewed by Anders Carlsson.

Implement Download::start() and Download::startWithHandle() on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=50844

  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/cf/DownloadCFNet.cpp: (WebKit::Download::start): Create a CFURLDownloadRef and schedule it. (WebKit::Download::startWithHandle): Create a CFURLDownloadRef with the loading connection retrieved from the ResourceHandle. (WebKit::Download::platformInvalidate): (WebKit::downloadFromClientInfo): (WebKit::didStartCallback): (WebKit::willSendRequestCallback): (WebKit::didReceiveAuthenticationChallengeCallback): (WebKit::didReceiveResponseCallback): (WebKit::willResumeWithResponseCallback): (WebKit::didReceiveDataCallback): (WebKit::shouldDecodeDataOfMIMETypeCallback): (WebKit::decideDestinationWithSuggestedObjectNameCallback): (WebKit::didCreateDestinationCallback): (WebKit::didFinishCallback): (WebKit::didFailCallback):
2:50 PM Changeset in webkit [73806] by kbr@google.com
  • 29 edits
    5 adds in trunk

2010-12-10 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Implement extension entry points and remove EXTENSIONS enum
​https://bugs.webkit.org/show_bug.cgi?id=40316

Added support for ensuring that a particular OpenGL extension is
enabled.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::ensureEnabled):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::initializeExtensions): (WebCore::GraphicsContext3DInternal::supportsExtension): (WebCore::GraphicsContext3DInternal::ensureExtensionEnabled):
  • src/GraphicsContext3DInternal.h:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::getRequestableExtensionsCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::requestExtensionCHROMIUM):
  • src/WebGraphicsContext3DDefaultImpl.h:

2010-12-10 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Implement extension entry points and remove EXTENSIONS enum
​https://bugs.webkit.org/show_bug.cgi?id=40316

Implemented WebGLRenderingContext's getSupportedExtensions and
getExtensions entry points, and, to verify them, added support for
the first specified WebGL extension, OES_texture_float. This
extension is now advertised in the Chromium and WebKit ports when
the underlying hardware supports it.

The new OES_texture_float test in the WebGL conformance suite
verifies the allocation and population of floating point textures,
and their use as render targets. However, because this extension
is optional, it is not easily testable with a layout test; there
is only one set of expectations for a given test, and two would be
needed, one when the extension is available and one when it is not.

Tested with the oes-texture-float.html WebGL conformance test in
Chromium and WebKit on Mac OS X on hardware that supports the
extension. Also verified with a configuration that does not
advertise the extension that this same test passes.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::toJS): (WebCore::JSWebGLRenderingContext::markChildren): (WebCore::JSWebGLRenderingContext::getExtension): (WebCore::JSWebGLRenderingContext::getSupportedExtensions):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object): (WebCore::V8WebGLRenderingContext::getExtensionCallback): (WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
  • html/canvas/OESTextureFloat.cpp: Added. (WebCore::OESTextureFloat::OESTextureFloat): (WebCore::OESTextureFloat::~OESTextureFloat): (WebCore::OESTextureFloat::getName): (WebCore::OESTextureFloat::create):
  • html/canvas/OESTextureFloat.h: Added.
  • html/canvas/OESTextureFloat.idl: Added.
  • html/canvas/WebGLExtension.cpp: Added. (WebCore::WebGLExtension::WebGLExtension): (WebCore::WebGLExtension::~WebGLExtension):
  • html/canvas/WebGLExtension.h: Added.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getExtension): (WebCore::WebGLRenderingContext::getSupportedExtensions): (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType): (WebCore::WebGLRenderingContext::validateTexFuncData): (WebCore::WebGLRenderingContext::getNumberOfExtensions): (WebCore::WebGLRenderingContext::getExtensionNumber):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
  • platform/graphics/Extensions3D.h:
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::computeFormatAndTypeParameters): (WebCore::GraphicsContext3D::extractTextureData): (WebCore::doUnpackingAndPacking): (WebCore::doPacking): (WebCore::doFloatingPointPacking): (WebCore::GraphicsContext3D::packPixels):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::supports): (WebCore::Extensions3DOpenGL::ensureEnabled):
  • platform/graphics/opengl/Extensions3DOpenGL.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::texImage2D):
  • platform/graphics/qt/Extensions3DQt.cpp: (WebCore::Extensions3DQt::ensureEnabled):
  • platform/graphics/qt/Extensions3DQt.h:
2:30 PM Changeset in webkit [73805] by Darin Adler
  • 2 edits in trunk/WebCore

Try to fix Windows build.

  • dom/Range.cpp:

(WebCore::Range::processContents): Put typedef of NodeVector inside the function
instead of at the top of the file, since the use is restricted to this function.
There's another NodeVector in ContainerNode.cpp.

2:30 PM Changeset in webkit [73804] by eric@webkit.org
  • 3 edits
    1 move in trunk/WebKitTools

2010-12-10 Eric Seidel <​eric@webkit.org>

Unreviewed.

commit-queue should report port/platform information when commenting on flaky test bugs
​https://bugs.webkit.org/show_bug.cgi?id=50839

Renamed platform.py to platforminfo.py. This broke import platform in executive.py
which was only used by new run webkit tests (and clearly not unit tested).

  • Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
2:30 PM Changeset in webkit [73803] by enrica@apple.com
  • 4 edits in trunk/WebKit2

Windows build fix. Unreviewed.

Adding a dummy synchronous message for platforms
that don't have any.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::dummy):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
2:21 PM Changeset in webkit [73802] by bweinstein@apple.com
  • 22 edits
    2 adds in trunk

JavaScriptCore: Turn on USE(CROSS_PLATFORM_CONTEXT_MENUS) for Windows.

Reviewed by Adam Roben.

  • wtf/Platform.h:

WebCore: Prep for WebKit2: Context menu support on Windows
​https://bugs.webkit.org/show_bug.cgi?id=50514

Reviewed by Adam Roben.

Before this patch ContextMenu on Windows were backed by HMENUs, and ContextMenuItems
were backed by MENUITEMINFOs. This meant they couldn't be copied, and they needed to
be to work in WebKit2.

This patch adds a new USE flag - CROSS_PLATFORM_CONTEXT_MENUS that are for a cross-platform
representation of context menus. This patch also has Windows adopt them.

Cross-platform context menus change the API of context menus and the ContextMenuClient. There
is no more idea of a PlatformMenuDescription or a PlatformMenuItemDescription. Menus are backed
by a Vector of ContextMenuItems, and menu items are backed by the variables they need (enabled, checked
title, action, type, and submenu).

This patch also refactors the ContextMenuClient interface to use a variation on the getCustomMenuFromDefaultItems
function to allow for customization of the context menu.

For other ports to use CROSS_PLATFORM_CONTEXT_MENUS, all they need to do is write conversion functions from
a ContextMenu <-> native menu type, and ContextMenuItem <-> native menu item type. For Windows, this is done
in ContextMenuWin.cpp and ContextMenuItemWin.cpp.

No new tests, no change in behavior.

  • WebCore.vcproj/WebCore.vcproj: Add new files (only needed on Windows for now).
  • loader/EmptyClients.h:

(WebCore::EmptyContextMenuClient::customizeMenu): Define this function if CROSS_PLATFORM_CONTEXT_MENUS

is on.

  • page/ContextMenuClient.h: Ditto.
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::showContextMenu): Call customizeMenu instead of

getCustomMenuFromDefaultItems if CROSS_PLATFORM_CONTEXT_MENUS is on.

  • platform/ContextMenu.cpp: Added.

(WebCore::ContextMenu::ContextMenu): Empty constructor.
(WebCore::ContextMenu::setItems): Sets the items in the menu.
(WebCore::ContextMenu::items): Returns the items in the menu.
(WebCore::ContextMenu::itemAtIndex):
(WebCore::itemWithActionInMenu): Returns the item with the correct action, recursively descending

into submenus.

(WebCore::ContextMenu::itemWithAction): Calls through to itemWithActionInMenu.

  • platform/ContextMenu.h: Added a new set of functions and member variables that are defined for

CROSS_PLATFORM_CONTEXT_MENUS.

(WebCore::ContextMenu::appendItem): Appends an item to the menu.

  • platform/ContextMenuItem.cpp: Added.

(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
(WebCore::ContextMenuItem::setSubMenu):

  • platform/ContextMenuItem.h:

(WebCore::ContextMenuItem::type): Returns the type.
(WebCore::ContextMenuItem::setType): Sets the type.
(WebCore::ContextMenuItem::action): Returns the action.
(WebCore::ContextMenuItem::setAction): Sets the action.
(WebCore::ContextMenuItem::title): Returns the title.
(WebCore::ContextMenuItem::setTitle): Sets the title.
(WebCore::ContextMenuItem::checked): Returns whether or not the menu item is checked.
(WebCore::ContextMenuItem::setChecked): Sets whether ot not the menu item is checked.
(WebCore::ContextMenuItem::enabled): Returns whether or not the menu item is enabled.
(WebCore::ContextMenuItem::setEnabled): Sets whether or not the menu item is enabled.
(WebCore::ContextMenuItem::submenu): Returns the submenu.

  • platform/PlatformMenuDescription.h: Remove the idea if a PlatformMenuDescription if

CROSS_PLATFORM_CONTEXT_MENUS is on.

  • platform/win/ContextMenuItemWin.cpp:

(WebCore::ContextMenuItem::ContextMenuItem): Creates a ContextMenuItem from a MENUITEMINFO.
(WebCore::ContextMenuItem::nativeMenuItem): Creates and returns a MENUITEMINFO.

  • platform/win/ContextMenuWin.cpp:

(WebCore::ContextMenu::ContextMenu): Creates a ContextMenu from an HMENU.
(WebCore::ContextMenu::nativeMenu): Creates and returns an HMENU.

WebKit/win: Prep for WebKit2: Context menu support on Windows
​https://bugs.webkit.org/show_bug.cgi?id=50514

Reviewed by Adam Roben.

Update WebKit for the new CROSS_PLATFORM_CONTEXT_MENUS flag, and define customizeMenu
instead of getCustomMenuFromDefaultItems.

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::customizeMenu): getCustomMenuFromDefaultItems was turned into

this function, with refactoring using nativeMenu instead of platformDescription.

(WebContextMenuClient::contextMenuItemSelected): Use nativeMenu instead of platformDescription.

  • WebCoreSupport/WebContextMenuClient.h:
  • WebView.cpp:

(WebView::handleContextMenuEvent): Call nativeMenu instead of platformDescription.
(WebView::performContextMenuAction): Only call itemAtIndex with one argument, no need

for the second.

WebKit2: Prep for WebKit2: Context menu support on Windows
​https://bugs.webkit.org/show_bug.cgi?id=50514

Reviewed by Adam Roben.

Update WebKit2 to call the correct code when CROSS_PLATFORM_CONTEXT_MENUS is set.

  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::WebContextMenuItemData): Add a branch based on whether or not

CROSS_PLATFORM_CONTEXT_MENUS is set.

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::customizeMenu): Define different functions based on

whether or not CROSS_PLATFORM_CONTEXT_MENUS. Both of these are stubs, so functionality
doesn't need to be shared.

  • WebProcess/WebCoreSupport/WebContextMenuClient.h: Define different functions based on

whether or not CROSS_PLATFORM_CONTEXT_MENUS.

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show): Add a branch based on whether or not

CROSS_PLATFORM_CONTEXT_MENUS is set.

2:09 PM Changeset in webkit [73801] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-10 Emil Eklund <​eae@chromium.org>

Reviewed by Adam Barth.

Fix crash in ReplaceSelectionCommand::doApply when selection is modified
during execution.
​https://bugs.webkit.org/show_bug.cgi?id=50840

Test: editing/execCommand/insertHTML-mutation-crash.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::copyStyleToChildren): Replaced raw node pointer with RefPtr.


(WebCore::ReplaceSelectionCommand::doApply):
Replaced raw node pointer with RefPtr and added null check.

2010-12-10 Emil Eklund <​eae@chromium.org>

Reviewed by Adam Barth.

Add testcase for ReplaceSelectionCommand crash.
​https://bugs.webkit.org/show_bug.cgi?id=50840

  • editing/execCommand/insertHTML-mutation-crash.html: Added.
2:02 PM Changeset in webkit [73800] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

Fix broken expectation from r73797.

  • platform/chromium/test_expectations.txt:
1:42 PM Changeset in webkit [73799] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-10 Emil Eklund <​eae@chromium.org>

Reviewed by Adam Barth.

Fix crash in Range::processContents when modified during mutation event.
​https://bugs.webkit.org/show_bug.cgi?id=50710

Test: fast/dom/Range/range-extractContents.html

  • dom/Range.cpp: (WebCore::Range::processContents): Replace raw pointers with RefPtrs and add checks.

2010-12-10 Emil Eklund <​eae@chromium.org>

Reviewed by Adam Barth.

Add testcase for range.extractContents crash.
​https://bugs.webkit.org/show_bug.cgi?id=50710

  • fast/dom/Range/range-extractContents-expected.txt: Added.
  • fast/dom/Range/range-extractContents.html: Added.
1:42 PM Changeset in webkit [73798] by eric@webkit.org
  • 6 edits
    1 add in trunk/WebKitTools

2010-12-10 Eric Seidel <​eric@webkit.org>

Reviewed by Tony Chang.

commit-queue should report port/platform information when commenting on flaky test bugs
​https://bugs.webkit.org/show_bug.cgi?id=50839

This was a suggestion from Tony Chang this morning.
I added a platform.py class so I could easily mock the platform call,
but that may not be the final solution for this mocking.
We'll try it and see.

  • Scripts/webkitpy/common/system/platform.py: Added.
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
1:36 PM Changeset in webkit [73797] by pkasting@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

Unreviewed Chromium test expectations update.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/fast/encoding: Added.
  • platform/chromium/fast/encoding/meta-in-script-expected.txt: Added V8-specific expectation.
  • platform/chromium/test_expectations.txt:
1:24 PM Changeset in webkit [73796] by enrica@apple.com
  • 25 edits in trunk

WebCore: Implement IME support for Mac.
<rdar://problem/7660589> WebKit2: Implement IME support for Mac.
​https://bugs.webkit.org/show_bug.cgi?id=50788

Reviewed by Alexey Proskuryakov.

  • dom/KeyboardEvent.h:

(WebCore::KeypressCommand::KeypressCommand): Removed ASSERT in constructor,
since it is now used for more than one command.

WebKit2: Implement IME support for Mac.
<rdar://problem/7660589> WebKit2: Implement IME support for Mac.
​https://bugs.webkit.org/show_bug.cgi?id=50788

Reviewed by Alexey Proskuryakov.

This patch addes support for input methods in WebKit2.
In order to support IME, it was necessary to add synchronous calls from the UIProcess
to the WebProcess. These calls all have a timeout of 1 second.
The current implementation still uses the NSTextInput protocol, but the plan is to move
to the NSTextInputClient protocol. This has not been done yet for ease of comparison with
WebKit. attributedSubstringFromRange is the only method that has not been implemented, because
I have not yet decided what is the best way to send an NSAttributedString across the process
boundary.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction): Added template for member function.
with four reply arguments.

  • Scripts/webkit2/messages.py: Added CompositionUnderline and relevant header.
  • Shared/WebCoreArgumentCoders.h:

(CoreIPC::): Added encoder/decoder for CompositionUnderline.

  • UIProcess/API/mac/PageClientImpl.h: Added parameters to interceptKeyEvent and selectionChanged.
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::selectionChanged): Added parameters.
(WebKit::PageClientImpl::interceptKeyEvent): Added parameters.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:pageGroupRef:]): Added initialization of new private members.
(-[WKView insertText:]):
(-[WKView _selectionChanged:isEditable:isPassword:hasMarkedText:range:]): Added parameters.
(-[WKView _interceptKeyEvent:hasComposition:start:end:lines:WebCore::]): Added parameters.
(-[WKView keyDown:]): Modified to reset state on each keyDown.
(-[WKView selectedRange]): Added.
(-[WKView hasMarkedText]): Added.
(-[WKView unmarkText]): Added.
(-[WKView validAttributesForMarkedText]): Added.
(extractUnderlines): Added.
(-[WKView setMarkedText:selectedRange:]): Added.
(-[WKView markedRange]): Added.
(-[WKView attributedSubstringFromRange:]): Added.
(-[WKView characterIndexForPoint:]): Added.
(-[WKView firstRectForCharacterRange:]): Added.
(-[WKView conversationIdentifier]): Added.

  • UIProcess/API/mac/WKViewInternal.h: Added parameters to _interceptKeyEvent and _selectionChanged.
  • UIProcess/PageClient.h: Added parameters to interpretKeyEvent and selectionChanged.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getMarkedRange): Added.
(WebKit::WebPageProxy::characterIndexForPoint): Added.
(WebKit::WebPageProxy::firstRectForCharacterRange): Added.
(WebKit::WebPageProxy::interpretKeyEvent): Additional parameters.
(WebKit::WebPageProxy::didSelectionChange): Additional parameters for Mac platform.

  • UIProcess/WebPageProxy.h: Added new methods and parameters to didSelectionChange

and interpretKeyEvent.

  • UIProcess/WebPageProxy.messages.in: Added parameters to interpretKeyEvent and selectionChanged messages.
  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::sendSync): Added support for synchronous messages.
The default timeout is 1 second.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: respondToChangedSelection is now

only for non Mac platform.

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::respondToChangedSelection): Added implementation for Mac platform.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveSyncMessage): Added.

  • WebProcess/WebPage/WebPage.h: Added new methods and support for synchronous messages.
  • WebProcess/WebPage/WebPage.messages.in: Added new messages.
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::interceptEditingKeyboardEvent): Added parameters.
(WebKit::WebPage::convertRangeToPlatformRange): Added.
(WebKit::WebPage::getMarkedRange): Added.
(WebKit::characterRangeAtPoint): Added.
(WebKit::WebPage::characterIndexForPoint): Added.
(WebKit::convertToRange): Added.
(WebKit::WebPage::firstRectForCharacterRange): Added.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveSyncMessage): Added.

  • WebProcess/WebProcess.h: Added didReceiveSyncMessage.
1:15 PM Changeset in webkit [73795] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 73620

BUG=65764
Review URL: ​http://codereview.chromium.org/5787002

1:13 PM Changeset in webkit [73794] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/597

Merge 73559

BUG=65764
Review URL: ​http://codereview.chromium.org/5753004

1:10 PM Changeset in webkit [73793] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/552

Merge 73620

BUG=65764

1:08 PM Changeset in webkit [73792] by inferno@chromium.org
  • 5 edits
    2 copies in branches/chromium/552

Merge 73559

BUG=65764

1:06 PM Changeset in webkit [73791] by inferno@chromium.org
  • 19 edits
    2 copies in branches/chromium/597

Merge 73488

BUG=64331
Review URL: ​http://codereview.chromium.org/5772004

1:05 PM Changeset in webkit [73790] by cmarrin@apple.com
  • 3 edits in trunk/WebKitLibraries

2010-12-10 Chris Marrin <​cmarrin@apple.com>

Reviewed by Adam Roben.

Add CACFContextGetLastCommitTime to WebKitSystemInterface for Windows.
Also got rid of WebKitSystemInterface_debug.lib as recommended by
Adam Roben. No OpenSource builds use it since r72327.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib: Removed.
1:01 PM Changeset in webkit [73789] by chang.shu@nokia.com
  • 15 edits in trunk

2010-12-10 Krithigassree Sambamurthy <​krithigassree.sambamurthy@nokia.com>

Reviewed by Joseph Pecoraro.

Bug 43455 - [Qt]: Implement Application Cache Quotas
​https://bugs.webkit.org/show_bug.cgi?id=43455

Added new signal to report ApplicationCache Database
quota.

  • Api/qwebpage.cpp:
  • Api/qwebpage.h:

Added new functions to accomodate new appcache layout
test origin-quota.html.

  • Api/qwebsecurityorigin.cpp: (QWebSecurityOrigin::setApplicationCacheQuota):
  • Api/qwebsecurityorigin.h:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::clearAllApplicationCaches):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-12-10 Krithigassree Sambamurthy <​krithigassree.sambamurthy@nokia.com>

Reviewed by Joseph Pecoraro.

[Qt]: Implement Application Cache Quotas
​https://bugs.webkit.org/show_bug.cgi?id=43455

  • platform/qt/Skipped: Unskip now passing test origin-quota.html

2010-12-10 Krithigassree Sambamurthy <​krithigassree.sambamurthy@nokia.com>

Reviewed by Joseph Pecoraro.

Bug 43455 - [Qt]: Implement Application Cache Quotas
​https://bugs.webkit.org/show_bug.cgi?id=43455

Introduce functions to allow new appcache layout test origin-quota.html
to work correctly under Qt.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:

Introduce functions to allow new appcache layout test origin-quota.html
to be successful under qt. Changes required because LayoutTestControllerQt
does not inherit from LayoutController.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks): (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1:00 PM Changeset in webkit [73788] by inferno@chromium.org
  • 18 edits
    2 copies in branches/chromium/552

Merge 73488

BUG=64331

12:38 PM Changeset in webkit [73787] by timothy@apple.com
  • 1 delete in releases/Apple/Safari 4.0.6

Remove empty tag.

12:37 PM Changeset in webkit [73786] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0.3/WebKit

Tag for WebKit in Safari 5.0.3 (WebKit 533.19.4)

12:37 PM Changeset in webkit [73785] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0.3/WebCore

Tag for WebCore in Safari 5.0.3 (WebCore 533.19.4)

12:37 PM Changeset in webkit [73784] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0.3/JavaScriptCore

Tag for JavaScriptCore in Safari 5.0.3 (JavaScriptCore 533.19.4)

12:37 PM Changeset in webkit [73783] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0.3/JavaScriptGlue

Tag for JavaScriptGlue in Safari 5.0.3 (JavaScriptGlue 533.19.4)

12:35 PM Changeset in webkit [73782] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0.2/JavaScriptGlue

Tag for JavaScriptGlue in Safari 5.0.2 (unchanged from Safari 5.0)

12:35 PM Changeset in webkit [73781] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0.2/JavaScriptCore

Tag for JavaScriptCore in Safari 5.0.2 (JavaScriptCore 533.18.1)

12:34 PM Changeset in webkit [73780] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0.2/WebCore

Tag for WebCore in Safari 5.0.2 (WebCore 533.18.1)

12:34 PM Changeset in webkit [73779] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0.2/WebKit

Tag for WebKit in Safari 5.0.2 (WebKit 533.18.1)

12:29 PM Changeset in webkit [73778] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0.1/WebKit

Tag for WebKit in Safari 5.0.1 (WebKit 533.17.8)

12:29 PM Changeset in webkit [73777] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0.1/WebCore

Tag for WebCore in Safari 5.0.1 (WebCore 533.17.8)

12:29 PM Changeset in webkit [73776] by eric@webkit.org
  • 4 edits
    2 moves
    2 adds in trunk/WebKitTools

2010-12-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move buildbot.py into its own module so we can split it out into one-file-per-class
​https://bugs.webkit.org/show_bug.cgi?id=50806

We're adding more buildbot logic these days, so it makes sense
to give buildbot its own module.

  • Scripts/webkitpy/common/net/buildbot/init.py: Added.
  • Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/regressionwindow.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
12:29 PM Changeset in webkit [73775] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0.1/JavaScriptCore

Tag for JavaScriptCore in Safari 5.0.1 (JavaScriptCore 533.17.8)

12:28 PM Changeset in webkit [73774] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0.1/JavaScriptGlue

Tag for JavaScriptGlue in Safari 5.0.1 (unchanged from Safari 5.0)

12:26 PM Changeset in webkit [73773] by jberlin@webkit.org
  • 2 edits in trunk/WebCore

Windows build fix. Unreviewed.

  • WebCore.vcproj/WebCore.vcproj:

Remove duplicate </File> tag.

12:24 PM Changeset in webkit [73772] by timothy@apple.com
  • 1 add in releases/Apple/Safari 5.0.3

Release tag for Safari 5.0.3.

12:23 PM Changeset in webkit [73771] by timothy@apple.com
  • 1 add in releases/Apple/Safari 5.0.2

Release tag for Safari 5.0.2.

12:23 PM Changeset in webkit [73770] by timothy@apple.com
  • 1 add in releases/Apple/Safari 5.0.1

Release tag for Safari 5.0.1.

12:23 PM Changeset in webkit [73769] by tony@chromium.org
  • 3 edits in trunk/WebKitTools

2010-12-10 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

Use FileSystem::remove when cleaning up http lock files
​https://bugs.webkit.org/show_bug.cgi?id=50830

  • Scripts/webkitpy/layout_tests/port/http_lock.py:
12:23 PM Changeset in webkit [73768] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0/WebKit

Tag for WebKit in Safari 5.0 (WebKit 533.16)

12:22 PM Changeset in webkit [73767] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0/WebCore

Tag for WebCore in Safari 5.0 (WebCore 533.16)

12:22 PM Changeset in webkit [73766] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0/JavaScriptCore

Tag for JavaScriptCore in Safari 5.0 (JavaScriptCore 533.16)

12:22 PM Changeset in webkit [73765] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 5.0/JavaScriptGlue

Tag for JavaScriptGlue in Safari 5.0 (JavaScriptGlue 533.16)

12:22 PM Changeset in webkit [73764] by timothy@apple.com
  • 1 add in releases/Apple/Safari 5.0

Release tag for Safari 5.0.

12:06 PM Changeset in webkit [73763] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 4.0.5/WebKit

Tag for WebKit in Safari 4.0.5 (WebKit 531.22.7)

12:06 PM Changeset in webkit [73762] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 4.0.5/WebCore

Tag for WebCore in Safari 4.0.5 (WebCore 531.22.7)

12:05 PM Changeset in webkit [73761] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 4.0.5/JavaScriptCore

Tag for JavaScriptCore in Safari 4.0.5 (JavaScriptCore 531.22.7)

12:05 PM Changeset in webkit [73760] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 4.0.5/JavaScriptGlue

Tag for JavaScriptGlue in Safari 4.0.5 (JavaScriptGlue 531.22.7)

12:02 PM Changeset in webkit [73759] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 4.0.4/JavaScriptGlue

Tag for JavaScriptGlue in Safari 4.0.4 (unchanged from Safari 4.0.3)

11:57 AM Changeset in webkit [73758] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 4.0.4/WebCore

Tag for WebCore in Safari 4.0.4 (WebCore 531.21.11)

11:54 AM Changeset in webkit [73757] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 4.0.4/WebKit

Tag for WebKit in Safari 4.0.4 (WebKit 531.21.11)

11:50 AM Changeset in webkit [73756] by commit-queue@webkit.org
  • 13 edits
    152 adds in trunk

2010-12-09 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Adam Barth.

TextResourceDecoder::checkForHeadCharset can look way past the limit.
​https://bugs.webkit.org/show_bug.cgi?id=47397

Replaced charset detection algorithm with real parser.
Added tests for parser bugs mentioned in the thread for this bug report.
Converted hixie's encoding parsing tests to a layout test.

Tests: fast/encoding/bracket-in-script.html

fast/encoding/bracket-in-tag.html
fast/encoding/escaped-bracket.html
fast/encoding/meta-in-body.html
fast/encoding/meta-in-script.html
fast/encoding/meta-in-title.html
fast/encoding/mismatched-end-tag.html
fast/encoding/namespace-meta.html
fast/encoding/not-http-equiv-content.html
fast/encoding/parser-tests.html
fast/encoding/quotes-in-title.html
fast/encoding/tag-name-digit.html
http/tests/misc/charset-sniffer-end-sniffing.html

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLMetaCharsetParser.cpp: Added. (WebCore::HTMLMetaCharsetParser::HTMLMetaCharsetParser): (WebCore::HTMLMetaCharsetParser::~HTMLMetaCharsetParser): (WebCore::HTMLMetaCharsetParser::extractCharset): (WebCore::HTMLMetaCharsetParser::processMeta): (WebCore::HTMLMetaCharsetParser::checkForMetaCharset):
  • html/parser/HTMLMetaCharsetParser.h: Added. (WebCore::HTMLMetaCharsetParser::create): (WebCore::HTMLMetaCharsetParser::encoding):
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): (WebCore::TextResourceDecoder::checkForMetaCharset):
  • loader/TextResourceDecoder.h:

2010-12-09 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Adam Barth.

TextResourceDecoder::checkForHeadCharset can look way past the limit.
​https://bugs.webkit.org/show_bug.cgi?id=47397

Replaced charset detection algorithm with real parser.
Added tests for parser bugs mentioned in the thread for this bug report.
Converted hixie's encoding parsing tests to a layout test.
Added http-equiv attribute to meta tag in 2 existing tests.

  • fast/encoding/bracket-in-script-expected.txt: Added.
  • fast/encoding/bracket-in-script.html: Added.
  • fast/encoding/bracket-in-tag-expected.txt: Added.
  • fast/encoding/bracket-in-tag.html: Added.
  • fast/encoding/escaped-bracket-expected.txt: Added.
  • fast/encoding/escaped-bracket.html: Added.
  • fast/encoding/meta-in-body-expected.txt: Added.
  • fast/encoding/meta-in-body.html: Added.
  • fast/encoding/meta-in-script-expected.txt: Added.
  • fast/encoding/meta-in-script.html: Added.
  • fast/encoding/meta-in-title-expected.txt: Added.
  • fast/encoding/meta-in-title.html: Added.
  • fast/encoding/mismatched-end-tag-expected.txt: Added.
  • fast/encoding/mismatched-end-tag.html: Added.
  • fast/encoding/namespace-meta-expected.txt: Added.
  • fast/encoding/namespace-meta.html: Added.
  • fast/encoding/namespace-tolerance.html:
  • fast/encoding/not-http-equiv-content-expected.txt: Added.
  • fast/encoding/not-http-equiv-content.html: Added.
  • fast/encoding/parser-tests-expected.txt: Added.
  • fast/encoding/parser-tests.html: Added.
  • fast/encoding/quotes-in-title-expected.txt: Added.
  • fast/encoding/quotes-in-title.html: Added.
  • fast/encoding/resources/001.html: Added.
  • fast/encoding/resources/002.html: Added.
  • fast/encoding/resources/003.html: Added.
  • fast/encoding/resources/004.html: Added.
  • fast/encoding/resources/005.html: Added.
  • fast/encoding/resources/006.html: Added.
  • fast/encoding/resources/007.html: Added.
  • fast/encoding/resources/008.html: Added.
  • fast/encoding/resources/009.html: Added.
  • fast/encoding/resources/010.html: Added.
  • fast/encoding/resources/011.html: Added.
  • fast/encoding/resources/012.html: Added.
  • fast/encoding/resources/013.html: Added.
  • fast/encoding/resources/014.html: Added.
  • fast/encoding/resources/015.html: Added.
  • fast/encoding/resources/016.html: Added.
  • fast/encoding/resources/017.html: Added.
  • fast/encoding/resources/018.html: Added.
  • fast/encoding/resources/019.html: Added.
  • fast/encoding/resources/020.html: Added.
  • fast/encoding/resources/021.html: Added.
  • fast/encoding/resources/022.html: Added.
  • fast/encoding/resources/023.html: Added.
  • fast/encoding/resources/024.html: Added.
  • fast/encoding/resources/025.html: Added.
  • fast/encoding/resources/026.html: Added.
  • fast/encoding/resources/027.html: Added.
  • fast/encoding/resources/028.html: Added.
  • fast/encoding/resources/029.html: Added.
  • fast/encoding/resources/030.html: Added.
  • fast/encoding/resources/031.html: Added.
  • fast/encoding/resources/032.html: Added.
  • fast/encoding/resources/033.html: Added.
  • fast/encoding/resources/034.html: Added.
  • fast/encoding/resources/035.html: Added.
  • fast/encoding/resources/036.html: Added.
  • fast/encoding/resources/037.html: Added.
  • fast/encoding/resources/038.html: Added.
  • fast/encoding/resources/039.html: Added.
  • fast/encoding/resources/040.html: Added.
  • fast/encoding/resources/041.html: Added.
  • fast/encoding/resources/042.html: Added.
  • fast/encoding/resources/043.html: Added.
  • fast/encoding/resources/044.html: Added.
  • fast/encoding/resources/045.html: Added.
  • fast/encoding/resources/046.html: Added.
  • fast/encoding/resources/047.html: Added.
  • fast/encoding/resources/048.html: Added.
  • fast/encoding/resources/049.html: Added.
  • fast/encoding/resources/050.html: Added.
  • fast/encoding/resources/051.html: Added.
  • fast/encoding/resources/052.html: Added.
  • fast/encoding/resources/053.html: Added.
  • fast/encoding/resources/054.html: Added.
  • fast/encoding/resources/055.html: Added.
  • fast/encoding/resources/056.html: Added.
  • fast/encoding/resources/057.html: Added.
  • fast/encoding/resources/058.html: Added.
  • fast/encoding/resources/059.html: Added.
  • fast/encoding/resources/060.html: Added.
  • fast/encoding/resources/061.html: Added.
  • fast/encoding/resources/062.html: Added.
  • fast/encoding/resources/063.html: Added.
  • fast/encoding/resources/064.html: Added.
  • fast/encoding/resources/065.html: Added.
  • fast/encoding/resources/066.html: Added.
  • fast/encoding/resources/067.html: Added.
  • fast/encoding/resources/068.html: Added.
  • fast/encoding/resources/069.html: Added.
  • fast/encoding/resources/070.html: Added.
  • fast/encoding/resources/071.html: Added.
  • fast/encoding/resources/072.html: Added.
  • fast/encoding/resources/073.html: Added.
  • fast/encoding/resources/074.html: Added.
  • fast/encoding/resources/075.html: Added.
  • fast/encoding/resources/076.html: Added.
  • fast/encoding/resources/077.html: Added.
  • fast/encoding/resources/078.html: Added.
  • fast/encoding/resources/079.html: Added.
  • fast/encoding/resources/080.html: Added.
  • fast/encoding/resources/081.html: Added.
  • fast/encoding/resources/082.html: Added.
  • fast/encoding/resources/083.html: Added.
  • fast/encoding/resources/084.html: Added.
  • fast/encoding/resources/085.html: Added.
  • fast/encoding/resources/086.html: Added.
  • fast/encoding/resources/087.html: Added.
  • fast/encoding/resources/088.html: Added.
  • fast/encoding/resources/089.html: Added.
  • fast/encoding/resources/090.html: Added.
  • fast/encoding/resources/091.html: Added.
  • fast/encoding/resources/092.html: Added.
  • fast/encoding/resources/093.html: Added.
  • fast/encoding/resources/094.html: Added.
  • fast/encoding/resources/095.html: Added.
  • fast/encoding/resources/096.html: Added.
  • fast/encoding/resources/097.html: Added.
  • fast/encoding/resources/098.html: Added.
  • fast/encoding/resources/099.html: Added.
  • fast/encoding/resources/100.html: Added.
  • fast/encoding/resources/101.html: Added.
  • fast/encoding/resources/102.html: Added.
  • fast/encoding/resources/103.html: Added.
  • fast/encoding/resources/104.html: Added.
  • fast/encoding/resources/105.html: Added.
  • fast/encoding/resources/106.html: Added.
  • fast/encoding/resources/107.html: Added.
  • fast/encoding/resources/108.html: Added.
  • fast/encoding/resources/109.html: Added.
  • fast/encoding/resources/110.html: Added.
  • fast/encoding/resources/111.html: Added.
  • fast/encoding/resources/112.html: Added.
  • fast/encoding/resources/113.html: Added.
  • fast/encoding/resources/114.html: Added.
  • fast/encoding/resources/115.html: Added.
  • fast/encoding/resources/116.html: Added.
  • fast/encoding/resources/117.html: Added.
  • fast/encoding/resources/118.html: Added.
  • fast/encoding/resources/119.html: Added.
  • fast/encoding/resources/120.html: Added.
  • fast/encoding/resources/121.html: Added.
  • fast/encoding/resources/122.html: Added.
  • fast/encoding/resources/123.html: Added.
  • fast/encoding/tag-name-digit-expected.txt: Added.
  • fast/encoding/tag-name-digit.html: Added.
  • fast/text/international/bidi-innertext.html:
  • http/tests/misc/charset-sniffer-end-sniffing-expected.txt: Added.
  • http/tests/misc/charset-sniffer-end-sniffing.html: Added.
  • http/tests/misc/resources/charset-sniffer-end-sniffing.php: Added.
11:49 AM Changeset in webkit [73755] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 4.0.4/JavaScriptCore

Tag for JavaScriptCore in Safari 4.0.4 (JavaScriptCore 531.21.11)

11:44 AM Changeset in webkit [73754] by timothy@apple.com
  • 1 add in releases/Apple/Safari 4.0.6

Release tag for Safari 4.0.6.

11:43 AM Changeset in webkit [73753] by timothy@apple.com
  • 1 add in releases/Apple/Safari 4.0.5

Release tag for Safari 4.0.5.

11:43 AM Changeset in webkit [73752] by timothy@apple.com
  • 1 add in releases/Apple/Safari 4.0.4

Release tag for Safari 4.0.4.

11:41 AM Changeset in webkit [73751] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-12-10 Joone Hur <​joone@kldp.org>

Reviewed by Martin Robinson.

[GTK] DRT needs layoutTestController.setCacheModel
​https://bugs.webkit.org/show_bug.cgi?id=50705

webkit_set_cache_mode() is called to set the cache model.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCacheModel): Set the cache model.
11:40 AM Changeset in webkit [73750] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-10 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium test expectation update.

Group Philip canvas test suite expectations better (by platform).

  • platform/chromium/test_expectations.txt:
11:26 AM Changeset in webkit [73749] by Nate Chapin
  • 18 edits
    2 deletes in trunk/WebCore

2010-12-10 Nate Chapin <Nate Chapin>

Reviewed by Antti Koivisto.

Merge Loader and Request. Currently, Loader is a singleton attached
to MemoryCache. Our goal is to remove knowledge of the loading process
from MemoryCache, so we should attach Loader to CachedResourceLoader instead.
Once Loader is moved off of MemoryCache, there's no reason it needs to be a singleton,
which removes the main reason for Request existing as a separate class (to store per-request
state that Loader couldn't).

Loader will be given a more descriptive name in a later patch.

​https://bugs.webkit.org/show_bug.cgi?id=49837

Refactor only, no new tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • loader/FrameLoader.cpp:
  • loader/Request.cpp:
  • loader/Request.h:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::CachedResourceLoader): (WebCore::CachedResourceLoader::~CachedResourceLoader): (WebCore::CachedResourceLoader::requestImage): (WebCore::CachedResourceLoader::setAutoLoadImages): (WebCore::CachedResourceLoader::load): (WebCore::CachedResourceLoader::loadDone): Was setLoadInProgress(false),

plus other CachedResourceLoader cleanup that had been handled in Loader.

(WebCore::CachedResourceLoader::cancelRequests): Moved from Loader.
(WebCore::CachedResourceLoader::requestCount):

  • loader/cache/CachedResourceLoader.h: (WebCore::CachedResourceLoader::loadFinishing): Was setLoadInProgress(true)
  • loader/cache/MemoryCache.h:
  • loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::~Loader): (WebCore::Loader::load): (WebCore::Loader::willSendRequest): (WebCore::Loader::didFinishLoading): (WebCore::Loader::didFail): (WebCore::Loader::didReceiveResponse): (WebCore::Loader::didReceiveData): (WebCore::Loader::didReceiveCachedMetadata):
  • loader/loader.h: (WebCore::Loader::cachedResourceLoader):
11:24 AM Changeset in webkit [73748] by tony@chromium.org
  • 15 edits
    1 delete in trunk

2010-12-10 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] remove --use-drt and add --use-test-shell
​https://bugs.webkit.org/show_bug.cgi?id=50701

Remove drt_expectations.txt since we don't need it anymore.

  • platform/chromium/drt_expectations.txt: Removed.

2010-12-10 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] remove --use-drt and add --use-test-shell
​https://bugs.webkit.org/show_bug.cgi?id=50701

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/tool/commands/queries.py:
11:14 AM Changeset in webkit [73747] by alex
  • 2 edits in trunk/LayoutTests

2010-12-10 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, rolling out r73743.
​http://trac.webkit.org/changeset/73743

We need gtk+ specific results

  • http/tests/misc/dns-prefetch-control-expected.txt:
11:10 AM Changeset in webkit [73746] by Martin Robinson
  • 6 edits in trunk

2010-12-10 Martin Robinson <​mrobinson@igalia.com>

Unreviewed, rolling out r73703.
​http://trac.webkit.org/changeset/73703
​https://bugs.webkit.org/show_bug.cgi?id=49658

This patch is causing crashes on the GTK+ bots.

  • wtf/PlatformRefPtr.h:

2010-12-10 Martin Robinson <​mrobinson@igalia.com>

Unreviewed, rolling out r73703.
​http://trac.webkit.org/changeset/73703
​https://bugs.webkit.org/show_bug.cgi?id=49658

This patch is causing crashes on the GTK+ bots.

  • platform/ContextMenuItem.h: (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
  • platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::appendItem):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::createNativeMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled):
10:54 AM Changeset in webkit [73745] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

2010-12-10 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

[Chromium] Implement mocks for client-based geolocation
​https://bugs.webkit.org/show_bug.cgi?id=46895

  • WebKit.gyp:
  • public/WebGeolocationClientMock.h: Added. (WebKit::WebGeolocationClientMock::~WebGeolocationClientMock): (WebKit::WebGeolocationClientMock::WebGeolocationClientMock):
  • src/WebGeolocationClientMock.cpp: Added. (WebKit::WebGeolocationClientMock::create): (WebKit::WebGeolocationClientMock::initialize): (WebKit::WebGeolocationClientMock::reset): (WebKit::WebGeolocationClientMock::setMockGeolocationPosition): (WebKit::WebGeolocationClientMock::setMockGeolocationError): (WebKit::WebGeolocationClientMock::setMockGeolocationPermission): (WebKit::WebGeolocationClientMock::resetMock): (WebKit::WebGeolocationClientMock::startUpdating): (WebKit::WebGeolocationClientMock::stopUpdating): (WebKit::WebGeolocationClientMock::setEnableHighAccuracy): (WebKit::WebGeolocationClientMock::geolocationDestroyed): (WebKit::WebGeolocationClientMock::setController): (WebKit::WebGeolocationClientMock::lastPosition): (WebKit::WebGeolocationClientMock::requestPermission): (WebKit::WebGeolocationClientMock::cancelPermissionRequest):
  • src/WebGeolocationServiceMock.cpp:

2010-12-10 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

[Chromium] Implement mocks for client-based geolocation
​https://bugs.webkit.org/show_bug.cgi?id=46895

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationPosition): (LayoutTestController::setMockGeolocationError):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::geolocationClient): (WebViewHost::geolocationClientMock): (WebViewHost::reset):
  • DumpRenderTree/chromium/WebViewHost.h:
10:47 AM Changeset in webkit [73744] by mihaip@chromium.org
  • 5 edits
    2 adds in trunk

2010-12-08 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Adler.

fast/canvas/canvas-getImageData-negative-source.html fails on Mac
​https://bugs.webkit.org/show_bug.cgi?id=47901

Add test for rounding behavior. Remove now-passing tests from
test_expectations.txt.

  • fast/canvas/canvas-getImageData-rounding-expected.txt: Added.
  • fast/canvas/canvas-getImageData-rounding.html: Added.
  • platform/chromium/test_expectations.txt:

2010-12-08 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Adler.

fast/canvas/canvas-getImageData-negative-source.html fails on Mac
​https://bugs.webkit.org/show_bug.cgi?id=47901

Test: fast/canvas/canvas-getImageData-rounding.html

static_cast<unsigned> is generally not what we want in
convertLogicalToDevice. It produces inconsistent results when compiling
for 32-bit vs. 64-bit, and in any case we weren't getting correct
rounding behavior for source rectangles (e.g. we should get a source rect
of width 2 if the source X is 0.9 and the source width is 0.2, but we
were getting only one of width 1).

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::convertLogicalToDevice): (WebCore::HTMLCanvasElement::convertToValidDeviceSize):
  • html/HTMLCanvasElement.h:
10:39 AM Changeset in webkit [73743] by alex
  • 2 edits in trunk/LayoutTests

2010-12-10 Alejandro G. Castro <​alex@igalia.com>

Unreviewed GTK test expectation update.

  • http/tests/misc/dns-prefetch-control-expected.txt:
10:26 AM Changeset in webkit [73742] by pkasting@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed Chromium test expectation update.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
10:18 AM Changeset in webkit [73741] by alex
  • 2 edits in trunk/WebKit/gtk

2010-12-10 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, fixed small typo in the name of a function.

  • webkit/webkitwebsettings.cpp: (getAvailableDictionariesCallback): (webkit_web_settings_set_property):
10:16 AM Changeset in webkit [73740] by alex
  • 7 edits
    1 add in trunk

2010-12-09 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add hasSpellingMarker support to the DRT
​https://bugs.webkit.org/show_bug.cgi?id=50739

Added a new private API function to support the spelling marker
tests in the DRT.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2010-12-10 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add hasSpellingMarker support to the DRT
​https://bugs.webkit.org/show_bug.cgi?id=50739

Implemented the hasSpellingMarker to support spelling tests.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::hasSpellingMarker):

2010-12-10 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add hasSpellingMarker support to the DRT
​https://bugs.webkit.org/show_bug.cgi?id=50739

Unskipped spelling tests and added a bug for the one failing,
added results for a new ones also.

  • platform/gtk/Skipped:
  • platform/gtk/editing/spelling/inline_spelling_markers-expected.txt: Added.
9:56 AM Changeset in webkit [73739] by sfalken@apple.com
  • 2 edits in tags/Safari-534.14.1/WebCore

Merge r73723.

9:53 AM Changeset in webkit [73738] by sfalken@apple.com
  • 5 edits in tags/Safari-534.14.1

Versioning.

9:36 AM Changeset in webkit [73737] by alex
  • 2 edits in trunk/WebKit/gtk

2010-12-10 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Choose a dictionary in case there is no one defined or the
env LANG does not propose one
​https://bugs.webkit.org/show_bug.cgi?id=50738

In case no dict is set and we can not find one using the
environment just get the first dictionary installed in the list.

  • webkit/webkitwebsettings.cpp: (getAvilableDictionariesCallback): (webkit_web_settings_set_property):
9:16 AM Changeset in webkit [73736] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-10 Hironori Bono <​hbono@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] Use libjpeg-turbo instead of libjpeg
​https://bugs.webkit.org/show_bug.cgi?id=50054

This change replaces the hard-coded path to the GYP files of the JPEG
library with a 'libjpeg_gyp_path' variable, which is added by Chromium
r68453. (When building WebKit Chromium, this change sets its value to
'<(chromium_src_dir)/third_party/libjpeg/libjpeg.gyp' to avoid changing
the current behavior.)

No new tests since this does not change the code at all.

  • WebCore.gyp/WebCore.gyp:
9:16 AM Changeset in webkit [73735] by commit-queue@webkit.org
  • 7 edits in trunk

2010-12-10 Joone Hur <​joone@kldp.org>

Reviewed by Xan Lopez.

[GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
​https://bugs.webkit.org/show_bug.cgi?id=50808

Unskipping the following test cases:
userscripts/mixed-case-stylesheet.html
userscripts/simple-stylesheet.html
userscripts/user-style-all-frames.html

  • platform/gtk/Skipped:

2010-12-10 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Remove unnecessary variable names from DumpRenderTreeSupportGtk
​https://bugs.webkit.org/show_bug.cgi?id=50815

There were some unnecessary variable names in DumpRenderTreeSupportGtk,
so remove them.

  • WebCoreSupport/DumpRenderTreeSupportGtk.h: Do it.

2010-12-10 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

webkit-patch: not possible to use build-and-test with local commits
​https://bugs.webkit.org/show_bug.cgi?id=33378

Make --no-clean not even check if we have local commits.
It's unclear to me why the code was originally written this way.
I was unable to dig up a reason from svn history.

  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
9:12 AM Changeset in webkit [73734] by sfalken@apple.com
  • 1 copy in tags/Safari-534.14.1

New tag.

9:00 AM Changeset in webkit [73733] by eric@webkit.org
  • 2 edits
    1 copy in trunk/WebKitTools

2010-12-10 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

webkit-patch: not possible to use build-and-test with local commits
​https://bugs.webkit.org/show_bug.cgi?id=33378

Make --no-clean not even check if we have local commits.
It's unclear to me why the code was originally written this way.
I was unable to dig up a reason from svn history.

  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
8:50 AM Changeset in webkit [73732] by mario@webkit.org
  • 4 edits in trunk

2010-12-10 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] AX: implement isEnabled in DRT
​https://bugs.webkit.org/show_bug.cgi?id=50814

Unskip passing accessibility/aria-disabled.html test.

  • platform/gtk/Skipped: Unskip test.

2010-12-10 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] AX: implement isEnabled in DRT
​https://bugs.webkit.org/show_bug.cgi?id=50814

Implement AccessibilityUIElement::isEnabled() for GTK.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (checkElementState): New function to refactor common code. (AccessibilityUIElement::isEnabled): Implement this by checking the current state of the AtkObject. (AccessibilityUIElement::isSelected): Use the new checkElementState function.
8:41 AM Changeset in webkit [73731] by cmarrin@apple.com
  • 4 edits in trunk/WebCore

2010-12-10 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
​https://bugs.webkit.org/show_bug.cgi?id=49388

Got rid of the NonZeroBeginTimeFlag. Functionality is now hidden inside
the implementation.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setAnimationOnLayer):
  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm: (hasNonZeroBeginTimeFlag): (setNonZeroBeginTimeFlag): (PlatformCAAnimation::PlatformCAAnimation): (PlatformCAAnimation::setBeginTime):
8:33 AM Changeset in webkit [73730] by podivilov@chromium.org
  • 7 edits in trunk/WebCore

2010-12-10 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: eliminate SourceFrameDelegate by passing scripts to SourceFrame constructor.
​https://bugs.webkit.org/show_bug.cgi?id=50679

  • inspector/front-end/Script.js:
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype._breakpointAdded): (WebInspector.SourceFrame.prototype._doEditLine): (WebInspector.SourceFrame.prototype._commitEditLine): (WebInspector.SourceFrame.prototype._breakpoints): (WebInspector.SourceFrame.prototype._sourceIDForLine):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView):
8:05 AM Changeset in webkit [73729] by andreas.kling@nokia.com
  • 16 edits in trunk/WebCore

2010-12-10 Andreas Kling <​kling@webkit.org>

Reviewed by Eric Seidel.

Don't do GraphicsContext save/restore just to preserve the CompositeOperator
​https://bugs.webkit.org/show_bug.cgi?id=50070

Add GraphicsContext::compositeOperation() so we don't have to do a full
save/restore if the only context-tainting call is setCompositeOperation().

GraphicsContext::setCompositeOperation() now stores the op in its state
and calls a port-specific setPlatformCompositeOperation().

No new tests, this is an optimization.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::compositeOperation):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState):
  • platform/graphics/Image.cpp: (WebCore::Image::fillWithSolidColor):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • platform/graphics/skia/SkiaUtils.cpp: (WebCore::WebCoreCompositeToSkiaComposite):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
7:36 AM Changeset in webkit [73728] by reni@webkit.org
  • 14 edits
    1 delete in trunk/WebCore

GraphicsContext: Merge m_common and m_data
​https://bugs.webkit.org/show_bug.cgi?id=49914

Patch by Renata Hodovan <​reni@webkit.org> on 2010-12-10
Reviewed by Andreas Kling.

Move data members from GraphicsContextPrivate into GraphicsContext. So GraphicsContextPlatform.h
and m_common became unnecessary. They are removed.
Add two methods to GraphicsContext: platformInit() and platformDestroy(), which
make the constructor of GraphicsContext clearer.
Besides add a getter to the private GraphicsContext::m_state member, because some inline
functions in cairo need it.

No new test is needed, because this is a refactoring.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(WebCore::GraphicsContext::setStrokeThickness):
(WebCore::GraphicsContext::setStrokeStyle):
(WebCore::GraphicsContext::setStrokeColor):
(WebCore::GraphicsContext::setShadow):
(WebCore::GraphicsContext::clearShadow):
(WebCore::GraphicsContext::getShadow):
(WebCore::GraphicsContext::strokeThickness):
(WebCore::GraphicsContext::strokeStyle):
(WebCore::GraphicsContext::strokeColor):
(WebCore::GraphicsContext::strokeColorSpace):
(WebCore::GraphicsContext::fillRule):
(WebCore::GraphicsContext::setFillRule):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::fillColor):
(WebCore::GraphicsContext::fillColorSpace):
(WebCore::GraphicsContext::setShouldAntialias):
(WebCore::GraphicsContext::shouldAntialias):
(WebCore::GraphicsContext::state):
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):
(WebCore::GraphicsContext::fillGradient):
(WebCore::GraphicsContext::strokeGradient):
(WebCore::GraphicsContext::fillPattern):
(WebCore::GraphicsContext::strokePattern):
(WebCore::GraphicsContext::setShadowsIgnoreTransforms):
(WebCore::GraphicsContext::updatingControlTints):
(WebCore::GraphicsContext::setUpdatingControlTints):
(WebCore::GraphicsContext::setPaintingDisabled):
(WebCore::GraphicsContext::paintingDisabled):
(WebCore::GraphicsContext::textDrawingMode):
(WebCore::GraphicsContext::setTextDrawingMode):

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContextState::GraphicsContextState):

  • platform/graphics/GraphicsContextPrivate.h: Removed.
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
(WebCore::drawPathShadow):
(WebCore::fillCurrentCairoPath):
(WebCore::strokeCurrentCairoPath):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::getAlpha):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::strokeRect):

  • platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:

(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::addInnerRoundedRectClip):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformShadow):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::setPlatformShadow):

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::platformInit):

  • platform/graphics/win/GraphicsContextCairoWin.cpp:

(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::platformInit):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):

7:34 AM Changeset in webkit [73727] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-12-10 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Remove unnecessary variable names from DumpRenderTreeSupportGtk
​https://bugs.webkit.org/show_bug.cgi?id=50815

There were some unnecessary variable names in DumpRenderTreeSupportGtk,
so remove them.

  • WebCoreSupport/DumpRenderTreeSupportGtk.h: Do it.
7:33 AM Changeset in webkit [73726] by podivilov@chromium.org
  • 10 edits in trunk/WebCore

2010-12-10 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce a pair of set/remove methods for each breakpoint type.
​https://bugs.webkit.org/show_bug.cgi?id=50809

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setEventListenerBreakpoint): (WebCore::InspectorController::removeEventListenerBreakpoint): (WebCore::InspectorController::hasEventListenerBreakpoint): (WebCore::InspectorController::setXHRBreakpoint): (WebCore::InspectorController::removeXHRBreakpoint): (WebCore::InspectorController::hasXHRBreakpoint): (WebCore::InspectorController::clearNativeBreakpoints):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::descriptionForDOMEvent): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.NativeBreakpoint): (WebInspector.DOMBreakpoint): (WebInspector.EventListenerBreakpoint): (WebInspector.XHRBreakpoint):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.debuggerPaused):
7:17 AM Changeset in webkit [73725] by Csaba Osztrogonác
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed. Remove platform specific expected files after r73720.

  • platform/gtk/fast/forms/ValidityState-patternMismatch-expected.txt: Removed.
  • platform/qt/fast/forms/ValidityState-patternMismatch-expected.txt: Removed.
7:11 AM Changeset in webkit [73724] by commit-queue@webkit.org
  • 8 edits
    7 copies
    2 adds in trunk/WebKit/chromium

2010-12-10 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

[chromium] Implement client based geolocation bindings
​https://bugs.webkit.org/show_bug.cgi?id=45752

Implements the necessary plumbing to expose client-based geolocation in Chromium
webkit. The plan is to remove the non-client-based geolocation code (GeolocationService*)
in the future.

  • WebKit.gyp:
  • public/WebGeolocationClient.h: Added. (WebKit::WebGeolocationClient::~WebGeolocationClient):
  • public/WebGeolocationController.h: Added. (WebKit::WebGeolocationController::WebGeolocationController): (WebKit::WebGeolocationController::reset):
  • public/WebGeolocationError.h:
  • public/WebGeolocationPermissionRequest.h: Added. (WebKit::WebGeolocationPermissionRequest::WebGeolocationPermissionRequest): (WebKit::WebGeolocationPermissionRequest::geolocation):
  • public/WebGeolocationPermissionRequestManager.h: Added. (WebKit::WebGeolocationPermissionRequestManager::WebGeolocationPermissionRequestManager): (WebKit::WebGeolocationPermissionRequestManager::~WebGeolocationPermissionRequestManager):
  • public/WebGeolocationPosition.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::geolocationClient):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame): (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
  • src/GeolocationClientProxy.cpp: Added. (WebKit::GeolocationClientProxy::GeolocationClientProxy): (WebKit::GeolocationClientProxy::~GeolocationClientProxy): (WebKit::GeolocationClientProxy::setController): (WebKit::GeolocationClientProxy::geolocationDestroyed): (WebKit::GeolocationClientProxy::startUpdating): (WebKit::GeolocationClientProxy::stopUpdating): (WebKit::GeolocationClientProxy::setEnableHighAccuracy): (WebKit::GeolocationClientProxy::lastPosition): (WebKit::GeolocationClientProxy::requestPermission): (WebKit::GeolocationClientProxy::cancelPermissionRequest):
  • src/GeolocationClientProxy.h: Added.
  • src/WebGeolocationController.cpp: Added. (WebKit::WebGeolocationController::positionChanged): (WebKit::WebGeolocationController::errorOccurred): (WebKit::WebGeolocationController::controller):
  • src/WebGeolocationPermissionRequest.cpp: Added. (WebKit::WebGeolocationPermissionRequest::securityOrigin): (WebKit::WebGeolocationPermissionRequest::setIsAllowed):
  • src/WebGeolocationPermissionRequestManager.cpp: Added. (WebGeolocationPermissionRequestManager::add): (WebGeolocationPermissionRequestManager::remove): (WebGeolocationPermissionRequestManager::init): (WebGeolocationPermissionRequestManager::reset):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:
6:52 AM Changeset in webkit [73723] by Adam Roben
  • 2 edits in trunk/WebCore

Windows production build fix after r72555

  • WebCore.vcproj/WebCoreGeneratedCommon.vsprops: Use

"$(WebKitVSPropsRedirectionDir)..\..\WebKitLibraries\win" to find the
.vsprops files, rather than $(WebKitLibrariesDir).

6:48 AM Changeset in webkit [73722] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/WebCore

[Qt] Second attempt to fix the build with Qt 4.6 broken in 73710.

Reviewed by nobody, build fix.

  • platform/network/qt/QtNAMThreadSafeProxy.cpp:

(WebCore::QtNetworkReplyThreadSafeProxy::QtNetworkReplyThreadSafeProxy):
(WebCore::QtNetworkReplyThreadSafeProxy::localCustomRequest):

  • platform/network/qt/QtNAMThreadSafeProxy.h:
6:35 AM Changeset in webkit [73721] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-10 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, unskip passing accessibility tests on GTK.

  • platform/gtk/Skipped: Unskip passing tests.
6:20 AM Changeset in webkit [73720] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2010-12-10 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Get rid of spaces in ValidityState-patternMismatch test.

  • fast/forms/ValidityState-patternMismatch-expected.txt:
  • fast/forms/ValidityState-patternMismatch.html:
5:04 AM Changeset in webkit [73719] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. Add platform specific expected files after r73715.

  • platform/gtk/fast/forms/ValidityState-patternMismatch-expected.txt: Added.
  • platform/qt/fast/forms/ValidityState-patternMismatch-expected.txt: Added.
4:30 AM Changeset in webkit [73718] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/WebCore

[Qt] Fix the build with Qt 4.6 broken in 73710.

Reviewed by nobody, build fix.

  • platform/network/qt/QtNAMThreadSafeProxy.cpp:

(WebCore::QtNetworkReplyThreadSafeProxy::QtNetworkReplyThreadSafeProxy):

  • platform/network/qt/QtNAMThreadSafeProxy.h:
4:14 AM Changeset in webkit [73717] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-10 Emil Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Change EventHandler::dispatchMouseEvent code to use DOM traversal instead of render tree traversal
​https://bugs.webkit.org/show_bug.cgi?id=49982

  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Walk up DOM/hosted tree rather than render tree.
4:03 AM Changeset in webkit [73716] by jocelyn.turcotte@nokia.com
  • 12 edits
    2 copies
    1 add in trunk

2010-12-10 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Add the QWKContext API class to wrap the WebContext.
​https://bugs.webkit.org/show_bug.cgi?id=50750

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): Change the WKPageNamespaceRef argument to QWKContext*
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkcontext.cpp: Added.
  • UIProcess/API/qt/qwkcontext.h: Added.
  • UIProcess/API/qt/qwkcontext_p.h: Added.
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPage::QWKPage): Change the WKPageNamespaceRef argument to QWKContext*
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
  • WebKit2.pro:

2010-12-10 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Add the QWKContext API class to wrap the WebContext.
​https://bugs.webkit.org/show_bug.cgi?id=50750

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView):
  • MiniBrowser/qt/BrowserView.h:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WebView::WebView):
3:42 AM Changeset in webkit [73715] by commit-queue@webkit.org
  • 1 edit
    4 adds
    22 deletes in trunk/LayoutTests

2010-12-10 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

Refactor by merging tests for ValidityState (patternMismatch and customError)
​https://bugs.webkit.org/show_bug.cgi?id=50802

  • fast/forms/ValidityState-customError-expected.txt: Added.
  • fast/forms/ValidityState-customError.html: Added.
  • fast/forms/ValidityState-customError-001-expected.txt: Removed. Merged to ValidityState-customError-expected.txt.
  • fast/forms/ValidityState-customError-001.html: Removed. Merged to ValidityState-customError.html.
  • fast/forms/ValidityState-customError-002-expected.txt: Removed. Merged to ValidityState-customError-expected.txt.
  • fast/forms/ValidityState-customError-002.html: Removed. Merged to ValidityState-customError.html.
  • fast/forms/ValidityState-customError-003-expected.txt: Removed. Merged to ValidityState-customError-expected.txt.
  • fast/forms/ValidityState-customError-003.html: Removed. Merged to ValidityState-customError.html.
  • fast/forms/ValidityState-customError-004-expected.txt: Removed. Merged to ValidityState-customError-expected.txt.
  • fast/forms/ValidityState-customError-004.html: Removed. Merged to ValidityState-customError.html.
  • fast/forms/ValidityState-patternMismatch-expected.txt: Added.
  • fast/forms/ValidityState-patternMismatch.html: Added.
  • fast/forms/ValidityState-patternMismatch-001-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
  • fast/forms/ValidityState-patternMismatch-001.html: Removed. Merged to ValidityState-patternMismatch.html.
  • fast/forms/ValidityState-patternMismatch-002-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
  • fast/forms/ValidityState-patternMismatch-002.html: Removed. Merged to ValidityState-patternMismatch.html.
  • fast/forms/ValidityState-patternMismatch-003-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
  • fast/forms/ValidityState-patternMismatch-003.html: Removed. Merged to ValidityState-patternMismatch.html.
  • fast/forms/ValidityState-patternMismatch-004-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
  • fast/forms/ValidityState-patternMismatch-004.html: Removed. Merged to ValidityState-patternMismatch.html.
  • fast/forms/ValidityState-patternMismatch-005-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
  • fast/forms/ValidityState-patternMismatch-005.html: Removed. Merged to ValidityState-patternMismatch.html.
  • fast/forms/ValidityState-patternMismatch-006-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
  • fast/forms/ValidityState-patternMismatch-006.html: Removed. Merged to ValidityState-patternMismatch.html.
  • fast/forms/ValidityState-patternMismatch-007-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
  • fast/forms/ValidityState-patternMismatch-007.html: Removed. Merged to ValidityState-patternMismatch.html.
3:04 AM Changeset in webkit [73714] by commit-queue@webkit.org
  • 7 edits in trunk

2010-12-10 Joone Hur <​joone@kldp.org>

Reviewed by Eric Seidel.

[GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
​https://bugs.webkit.org/show_bug.cgi?id=50783

Unskip the following test cases:
printing/page-rule-selection.html
printing/page-format-data.html

  • platform/gtk/Skipped:

2010-12-10 Joone Hur <​joone@kldp.org>

Reviewed by Eric Seidel.

[GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
​https://bugs.webkit.org/show_bug.cgi?id=50783

This patch allows to unskip the following test cases:
printing/page-rule-selection.html
printing/page-format-data.html

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::pageProperty): Added. (DumpRenderTreeSupportGtk::isPageBoxVisible): Ditto. (DumpRenderTreeSupportGtk::pageSizeAndMarginsInPixels): Ditto. (DumpRenderTreeSupportGtk::addUserStyleSheet): Ditto.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2010-12-10 Joone Hur <​joone@kldp.org>

Reviewed by Eric Seidel.

[GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
​https://bugs.webkit.org/show_bug.cgi?id=50783

This patch allows to unskip the following test cases:
printing/page-rule-selection.html
printing/page-format-data.html

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageProperty): Added. (LayoutTestController::isPageBoxVisible): Ditto. (LayoutTestController::pageSizeAndMarginsInPixels): Ditto. (LayoutTestController::addUserStyleSheet): Ditto.
3:00 AM Changeset in webkit [73713] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-10 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Updated chromium test expectations.

  • platform/chromium/test_expectations.txt:
2:51 AM Changeset in webkit [73712] by jocelyn.turcotte@nokia.com
  • 5 edits in trunk/WebKitTools

2010-12-10 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Make QtTestBrowser spawn QNAM in a secondary thread.

A menu allows to switch QNAM back to the same thread.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView): (LauncherWindow::createChrome): (LauncherWindow::toggleThreadedQnam):
  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/webpage.cpp: (WebPage::WebPage): (WebPage::setQnamThreaded):
  • QtTestBrowser/webpage.h: (QnamThread::QnamThread): (QnamThread::~QnamThread): (QnamThread::networkAccessManager): (QnamThread::run):
2:50 AM Changeset in webkit [73711] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-10 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Mark inspector tests as slow in Chromium expectations.

  • platform/chromium/test_expectations.txt:
2:50 AM Changeset in webkit [73710] by jocelyn.turcotte@nokia.com
  • 10 edits
    2 adds in trunk

2010-12-10 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support a QNetworkAccessManager affined to a different thread.
​https://bugs.webkit.org/show_bug.cgi?id=50080

This patch introduce thread safe proxy classes for QNetworkAccessManager
and QNetworkReply.
If run in the same thread, these objects will forward the calls with
Qt::DirectConnection bindings, while in the other case they will use
Qt::QueuedConnection to carry requests accross threads.

This patch basically:

  • Makes sure that all access goes through these objects
  • Reorders signal connections to make sure we are connected when the signal comes
  • Makes sure that no QObject in the WebCore thread is a child of the reply which might be in a different thread.
  • Forward the data directly in QByteArrays in signals instead of collecting the data when the signal is handled.

New test: tst_QWebPage::networkAccessManagerOnDifferentThread

  • WebCore.pro:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::commitLoad):
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::FormDataIODevice::FormDataIODevice): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::~QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::setLoadMode): (WebCore::QNetworkReplyHandler::abort): (WebCore::QNetworkReplyHandler::release): (WebCore::ignoreHttpError): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::start): (WebCore::QNetworkReplyHandler::sendQueuedItems):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/QtNAMThreadSafeProxy.cpp: Added.
  • platform/network/qt/QtNAMThreadSafeProxy.h: Added.
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::willLoadFromCache):
  • platform/qt/CookieJarQt.cpp: (WebCore::networkAccessManager): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled):

2010-12-10 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support a QNetworkAccessManager affined to a different thread.
​https://bugs.webkit.org/show_bug.cgi?id=50080

This patch introduce thread safe proxy classes for QNetworkAccessManager
and QNetworkReply.
If run in the same thread, these objects will forward the calls with
Qt::DirectConnection bindings, while in the other case they will use
Qt::QueuedConnection to carry requests accross threads.

This patch basically:

  • Makes sure that all access goes through these objects
  • Reorders signal connections to make sure we are connected when the signal comes
  • Makes sure that no QObject in the WebCore thread is a child of the reply which might be in a different thread.
  • Forward the data directly in QByteArrays in signals instead of collecting the data when the signal is handled.

New test: tst_QWebPage::networkAccessManagerOnDifferentThread

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::download):
  • tests/qwebpage/tst_qwebpage.cpp: (QtNAMThread::QtNAMThread): (QtNAMThread::~QtNAMThread): (QtNAMThread::networkAccessManager): (QtNAMThread::run): (tst_QWebPage::networkAccessManagerOnDifferentThread):
2:49 AM Changeset in webkit [73709] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-12-10 Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Flush IPC connection send buffer after each message.

[Qt] [WK2] IPC messages are not sent until send buffer fills up
​https://bugs.webkit.org/show_bug.cgi?id=50667

  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::sendOutgoingMessage):
2:41 AM Changeset in webkit [73708] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Refactor QNetworkReplyHandler::finish() to prevent crashes.
​https://bugs.webkit.org/show_bug.cgi?id=50761

Reviewed by Kenneth Rohde Christiansen.

This patch change the order to check if m_reply is null instead,
explicitly deleting the reply before calling start() for a redirect,
or after calling didFinishLoading()/didFail() in other cases.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):

2:41 AM Changeset in webkit [73707] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/WebCore

[Qt] Make sure we send the response before any data.
​https://bugs.webkit.org/show_bug.cgi?id=50760

Reviewed by Kenneth Rohde Christiansen.

This patch make sure the data available flag is set before
we call sendResponseIfNeeded.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::resetState):

  • platform/network/qt/QNetworkReplyHandler.h:
2:36 AM Changeset in webkit [73706] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-10 Koan-Sin Tan <​koansin.tan@gmail.com>

Reviewed by Dan Bernstein.

Bopomofo should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp
​https://bugs.webkit.org/show_bug.cgi?id=50668

No new tests. Note that, as said in the bug report discussion,
I did have a test case for the bug. However, to show the test
case you need some "broken" Microsoft copyrighted fonts, such
as DFKai-SB.

  • platform/graphics/Font.cpp: (WebCore::Font::isCJKIdeograph):
2:34 AM Changeset in webkit [73705] by Philippe Normand
  • 3 edits in trunk/WebCore

2010-12-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] un-needed methods
​https://bugs.webkit.org/show_bug.cgi?id=50805

No new tests, code cleanup only.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2:33 AM Changeset in webkit [73704] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-12-10 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Cleanup StringWx.cpp
​https://bugs.webkit.org/show_bug.cgi?id=50525

Use StringImpl::createUninitialized to avoid memcpy and fix style issues.

  • wtf/wx/StringWx.cpp: (WTF::String::String):
2:31 AM Changeset in webkit [73703] by Martin Robinson
  • 6 edits in trunk

2010-12-10 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Simplify context-menu handling code
​https://bugs.webkit.org/show_bug.cgi?id=49658

  • wtf/PlatformRefPtr.h:

2010-12-10 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Simplify context-menu handling code
​https://bugs.webkit.org/show_bug.cgi?id=49658

  • platform/ContextMenuItem.h:
  • platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::appendItem):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled):
2:27 AM Changeset in webkit [73702] by kov@webkit.org
  • 6 edits
    1 add in trunk/WebKit/gtk

2010-12-09 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
​https://bugs.webkit.org/show_bug.cgi?id=50698

Split private bits of WebKitWebInspector to its own private
header, and to its implementation file.

  • WebCoreSupport/InspectorClientGtk.cpp:
  • webkit/webkitprivate.cpp:
  • webkit/webkitprivate.h:
  • webkit/webkitwebinspector.cpp: (isSchemaAvailable): (inspectorGSettings):
  • webkit/webkitwebinspectorprivate.h: Added.
  • webkit/webkitwebview.cpp:
2:26 AM Changeset in webkit [73701] by kov@webkit.org
  • 8 edits
    1 add in trunk/WebKit/gtk

2010-12-09 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
​https://bugs.webkit.org/show_bug.cgi?id=50698

Split private bits of WebKitNetworkRequest to its own private
header, and to its implementation file. Also take the opportunity
to use PlatformRefPtr for NetworkRequest where it makes sense, and
make the creation less verbose by adding kitNew.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::FrameLoaderClient::download): (WebKit::FrameLoaderClient::startDownload):
  • webkit/webkitdownload.cpp:
  • webkit/webkitnetworkrequest.cpp: (WebKit::kitNew): (WebKit::core):
  • webkit/webkitnetworkrequestprivate.h: Added.
  • webkit/webkitprivate.cpp:
  • webkit/webkitprivate.h:
  • webkit/webkitwebdatasource.cpp: (webkit_web_data_source_get_initial_request): (webkit_web_data_source_get_request):
  • webkit/webkitwebframe.cpp:
2:25 AM Changeset in webkit [73700] by Philippe Normand
  • 5 edits
    2 deletes in trunk

2010-12-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] data: source could also support non-base64 encoded URIs
​https://bugs.webkit.org/show_bug.cgi?id=30007

Removed our ancient implementation of dataurisrc. We should now
use the one in gst-plugins-bad which is more mature.

  • GNUmakefile.am:
  • platform/graphics/gstreamer/DataSourceGStreamer.cpp: Removed.
  • platform/graphics/gstreamer/DataSourceGStreamer.h: Removed.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::doGstInit):

LayoutTests:

Reviewed by Gustavo Noronha Silva.

[GStreamer] data: source could also support non-base64 encoded URIs
​https://bugs.webkit.org/show_bug.cgi?id=30007

  • platform/gtk/Skipped: Unskipped media/audio-data-url.html. It should now be much more reliable on the bots running latest GStreamer versions.
2:20 AM Changeset in webkit [73699] by zherczeg@webkit.org
  • 2 edits in trunk/WebCore

2010-12-10 Zoltan Herczeg <​zherczeg@webkit.org>

Reviewed by Eric Seidel.

[Qt] Fix crashes in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=49976

The m_methods hashmap of QtInstance contains InternalFunctions
whose depend on the current RuntimeObject. When we recreate the
RuntimeObject, we should also reset this hashmap.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::newRuntimeObject):
2:17 AM Changeset in webkit [73698] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-10 François Sausset <François Sausset>

Reviewed by Eric Seidel.

MathML: update baselinePosition() call in RenderMathMLBlock.cpp
​https://bugs.webkit.org/show_bug.cgi?id=50540

The call of baselinePosition() is outdated: new arguments added.

  • mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::paint):
2:12 AM Changeset in webkit [73697] by hans@chromium.org
  • 16 edits in trunk

2010-12-10 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
​https://bugs.webkit.org/show_bug.cgi?id=50674

Update layout tests to use floating-point values for keys.

  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html: Make sure creating the keys works.
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html: Make sure retrieving the keys from the DB objectstore works.

2010-12-10 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
​https://bugs.webkit.org/show_bug.cgi?id=50674

Use floating point to represent numeric keys,
add version meta data to the SQLite db,
and migrate object stores that use integers.

  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue):
  • bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables): (WebCore::migrateDatabase): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls):
  • storage/IDBKey.h: (WebCore::IDBKey::create): (WebCore::IDBKey::number):

2010-12-10 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
​https://bugs.webkit.org/show_bug.cgi?id=50674

Represent numeric keys as floating point values.

  • public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey):
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::number):
2:06 AM Changeset in webkit [73696] by kov@webkit.org
  • 12 edits
    1 add in trunk/WebKit/gtk

2010-12-09 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
​https://bugs.webkit.org/show_bug.cgi?id=50698

Split private bits of WebKitWebFrame to its own private header, and
to its implementation file.

  • GNUmakefile.am:
  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/DragClientGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • webkit/webkitprivate.cpp:
  • webkit/webkitprivate.h:
  • webkit/webkitwebdatasource.cpp:
  • webkit/webkitwebframe.cpp: (WebKit::getViewFromFrame): (WebKit::core): (WebKit::kit):
  • webkit/webkitwebframeprivate.h: Added.
  • webkit/webkitwebpolicydecision.cpp:
  • webkit/webkitwebview.cpp:
1:54 AM Changeset in webkit [73695] by Martin Robinson
  • 8 edits
    5 adds in trunk

2010-12-10 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] style="font-family: courier" makes text disappear
​https://bugs.webkit.org/show_bug.cgi?id=47452

Added a GTK+ test for invalid fonts.

  • platform/gtk/fonts/font-with-no-valid-encoding-expected.checksum: Added.
  • platform/gtk/fonts/font-with-no-valid-encoding-expected.png: Added.
  • platform/gtk/fonts/font-with-no-valid-encoding-expected.txt: Added.
  • platform/gtk/fonts/font-with-no-valid-encoding.html: Added.

2010-12-10 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] style="font-family: courier" makes text disappear
​https://bugs.webkit.org/show_bug.cgi?id=47452

Don't ever use fonts that do not have any of the three charmaps that
Fontconfig supports (Unicode, Apple Roman and Symbol). If we select
a font that doesn't have one of these charmaps, use the next font in
the list.

Test: platform/gtk/fonts/font-with-no-valid-encoding.html

  • platform/graphics/freetype/FontCacheFreeType.cpp: (WebCore::FontCache::createFontPlatformData): Check whether the font we selected has a valid Fontconfig charmap.
  • platform/graphics/freetype/FontPlatformData.h: Added new method definition.
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::hasCompatibleCharmap): Added this method which verifies that a font has a valid Fontconfig charmap.

2010-12-10 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] style="font-family: courier" makes text disappear
​https://bugs.webkit.org/show_bug.cgi?id=47452

Add a test that verifies that fonts without valid charmaps are
never selected.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Initialize DRT with our font (derived from Ahem) that has no valid charmap.
  • DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
  • DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users' settings which may disable selection of bitmap fonts.
1:29 AM Changeset in webkit [73694] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-12-10 Eric Seidel <​eric@webkit.org>

Unreviewed.

The commit-queue should file bugs about flaky tests it encounters
​https://bugs.webkit.org/show_bug.cgi?id=50803

create_bug_for_flaky_test was insufficiently tested, thus buggy.
Now it's tested.

  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1:13 AM Changeset in webkit [73693] by Csaba Osztrogonác
  • 5 edits
    2 adds in trunk/LayoutTests

Unreviewed fix after r73687.

[Qt] enable orientation flag when QtMobility available
​https://bugs.webkit.org/show_bug.cgi?id=50781

  • platform/qt/fast/dom/Orientation/create-event-orientationchange-expected.txt: Added.
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
12:31 AM Changeset in webkit [73692] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-12-10 Eric Seidel <​eric@webkit.org>

Unreviewed. Somehow this last-minute edit didn't quite get committed.

The commit-queue should file bugs about flaky tests it encounters
​https://bugs.webkit.org/show_bug.cgi?id=50803

  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
12:26 AM Changeset in webkit [73691] by eric@webkit.org
  • 15 edits
    2 copies
    1 add in trunk/WebKitTools

2010-12-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

The commit-queue should file bugs about flaky tests it encounters
​https://bugs.webkit.org/show_bug.cgi?id=50803

This change got a bit big. I also added a new config.urls file
because I needed to share the view_source_url code with committervalidator.py.

This adds a new class FlakyTestReporter which holds all the logic about
reporting flaky tests to bugzilla.

Right now this code knows how to look up bugs for flaky tests.
If it can't find a bug filed from the commit-queue, it will open a new
one, ccing the relevant people and adding information about the failure.

It is not yet smart enough to chase down duplicate chains, or to include
the actual failure diff. But those can be added in later iterations.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/commitinfo.py:
  • Scripts/webkitpy/common/config/committervalidator.py:
  • Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/comments.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/commit.py:

Dec 9, 2010:

11:48 PM Changeset in webkit [73690] by rniwa@webkit.org
  • 16 edits
    5 copies in trunk

2010-12-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Make DOM Mutation Events Asynchronous
​https://bugs.webkit.org/show_bug.cgi?id=46936

Implemented DOM mutations events as scoped events. A scoped event is an event whose
dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by
EventQueueScope objects (RAII idiom), which increments and decrements the scoping level
on its constructor and destructor respectively.

When the scoping level is 0 (initial level), scoped events are dispatched as soon as
they are enqueued and act like synchronous events. When the scoping level is greater than 0,
however, events are queued in ScopedEventQueue and their dispatches are delayed until
the scoping level goes back to 0 (by the destruction of EventQueueScope).

DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument,
DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as
scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
of the events until the completion of each call of EditCommand::doApply.

Test: fast/events/mutation/execCommands.html

  • Android.mk: Added ScopedEventQueue.cpp.
  • CMakeLists.txt: Ditto.
  • WebCore.pro: Ditto.
  • GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/project.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent. (WebCore::dispatchChildRemovalEvents): Ditto.
  • dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
  • dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): Ditto. (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
  • dom/Node.cpp: (WebCore::Node::dispatchScopedEvent): Added. (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent.
  • dom/Node.h:
  • dom/ScopedEventQueue.cpp: Added. (WebCore::ScopedEventQueue::initialize): Added. (WebCore::ScopedEventQueue::enqueueEvent): Added. (WebCore::ScopedEventQueue::dispatchAllEvents): Added. (WebCore::ScopedEventQueue::dispatchEvent): Added. (WebCore::ScopedEventQueue::instance): Added. (WebCore::ScopedEventQueue::incrementScopingLevel): Added. (WebCore::ScopedEventQueue::decrementScopingLevel): Added.
  • dom/ScopedEventQueue.h: Added. (WebCore::ScopedEventQueue::~ScopedEventQueue): Added. (WebCore::ScopedEventQueue::ScopedEventQueue): Added. (WebCore::EventQueueScope::EventQueueScope): Added. (WebCore::EventQueueScope::~EventQueueScope): Added.
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Instantiates EventQueueScope.

2010-12-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Make DOM Mutation Events Asynchronous
​https://bugs.webkit.org/show_bug.cgi?id=46936

Added a test to ensure no DOM mutation events are fired while execCommand is in progress.

  • fast/events/crash-on-mutate-during-drop.html: DOMNodeInserted is fired after BR is detached from the document, and can't be observed. Modify the DOM when text node is inserted.
  • fast/events/scoped: Added.
  • fast/events/scoped/editing-commands-expected.txt: Added.
  • fast/events/scoped/editing-commands.html: Added.
11:15 PM Changeset in webkit [73689] by rniwa@webkit.org
  • 16 edits
    3 deletes in trunk

2010-12-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73684.
​http://trac.webkit.org/changeset/73684
​https://bugs.webkit.org/show_bug.cgi?id=50801

"missing bug number" (Requested by rniwa on #webkit).

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
  • dom/DOMAllInOne.cpp:
  • dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent):
  • dom/Node.cpp: (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchUIEvent):
  • dom/Node.h:
  • dom/ScopedEventQueue.cpp: Removed.
  • dom/ScopedEventQueue.h: Removed.
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply):

2010-12-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73684.
​http://trac.webkit.org/changeset/73684
​https://bugs.webkit.org/show_bug.cgi?id=50801

"missing bug number" (Requested by rniwa on #webkit).

  • fast/events/crash-on-mutate-during-drop.html:
  • fast/events/scoped/editing-commands-expected.txt: Removed.
  • fast/events/scoped/editing-commands.html: Removed.
10:45 PM Changeset in webkit [73688] by eric@webkit.org
  • 4 edits
    1 add in trunk/WebKitTools

2010-12-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Teach webkit-patch how to search bugzilla
​https://bugs.webkit.org/show_bug.cgi?id=50500

This is a step towards teaching webkitpy how to file
new bugs for flaky tests and update them when new flakes occur.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/bugsearch.py: Added.
10:21 PM Changeset in webkit [73687] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-09 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] enable orientation flag when QtMobility available
​https://bugs.webkit.org/show_bug.cgi?id=50781

When QtMobility available, enable orientation flag by default.

  • features.pri:
9:59 PM Changeset in webkit [73686] by commit-queue@webkit.org
  • 14 edits
    3 adds in trunk

2010-12-09 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Improve validation API support of <object> and <keygen>
​https://bugs.webkit.org/show_bug.cgi?id=50663

Adds tests for validation API for <object>.
Tests for <output> and <keygen> are also added.

  • fast/dom/plugin-attributes-enumeration-expected.txt: Updated.
  • fast/forms/ValidityState-001-expected.txt: Updated.
  • fast/forms/ValidityState-001.html: Updated.
  • fast/forms/checkValidity-001-expected.txt: Updated.
  • fast/forms/checkValidity-001.html: Updated.
  • fast/forms/script-tests/setCustomValidity-existence.js: Added.
  • fast/forms/script-tests/validationMessage.js: Updated.
  • fast/forms/script-tests/willvalidate.js: Updated.
  • fast/forms/setCustomValidity-existence-expected.txt: Added.
  • fast/forms/setCustomValidity-existence.html: Added.
  • fast/forms/validationMessage-expected.txt: Updated.
  • fast/forms/willvalidate-expected.txt: Updated.

2010-12-09 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Improve validation API support of <object> and <keygen>
​https://bugs.webkit.org/show_bug.cgi?id=50663

Adds validation API to HTMLObjectElement class.
Makes HTMLKeygenElement::willValidate() return false.

Test: fast/forms/setCustomValidity-existence.html

  • html/HTMLKeygenElement.h: (WebCore::HTMLKeygenElement::willValidate): Added.
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::validationMessage): Added. (WebCore::HTMLObjectElement::checkValidity): Added. (WebCore::HTMLObjectElement::setCustomValidity): Added.
  • html/HTMLObjectElement.idl: Added validation API properties.
9:44 PM Changeset in webkit [73685] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-12-09 Sadrul Habib Chowdhury <​sadrul@chromium.org>

Reviewed by Kent Tamura.

Make sure a non-zero value is used for tile-width to avoid a crash
​https://bugs.webkit.org/show_bug.cgi?id=50341

The scaled tile width can be very small at times (e.g. with 'style: font 1
required'). So use a minimum width of 1 instead of using 0 (which leads to a
crash).

  • fast/dom/HTMLProgressElement/progress-element-with-style-crash.html: Added.
  • fast/dom/HTMLProgressElement/progress-element-with-style-crash-expected.txt: Added.

2010-12-09 Sadrul Habib Chowdhury <​sadrul@chromium.org>

Reviewed by Kent Tamura.

Make sure a non-zero value is used for tile-width to avoid a crash
​https://bugs.webkit.org/show_bug.cgi?id=50341

The scaled tile width can be very small at times (e.g. with 'style: font 1
required'). So use a minimum width of 1 instead of using 0 (which leads to a
crash).

Tests: fast/dom/HTMLProgressElement/progress-element-with-style-crash.html

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintProgressBar):
9:08 PM Changeset in webkit [73684] by rniwa@webkit.org
  • 16 edits
    5 adds in trunk

2010-12-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Implemented DOM mutations events as scoped events. A scoped event is an event whose
dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by
EventQueueScope objects (RAII idiom), which increments and decrements the scoping level
on its constructor and destructor respectively.

When the scoping level is 0 (initial level), scoped events are dispatched as soon as
they are enqueued and act like synchronous events. When the scoping level is greater than 0,
however, events are queued in ScopedEventQueue and their dispatches are delayed until
the scoping level goes back to 0 (by the destruction of EventQueueScope).

DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument,
DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as
scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
of the events until the completion of each call of EditCommand::doApply.

Test: fast/events/mutation/execCommands.html

  • Android.mk: Added ScopedEventQueue.cpp.
  • CMakeLists.txt: Ditto.
  • WebCore.pro: Ditto.
  • GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/project.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent. (WebCore::dispatchChildRemovalEvents): Ditto.
  • dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
  • dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): Ditto. (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
  • dom/Node.cpp: (WebCore::Node::dispatchScopedEvent): Added. (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent.
  • dom/Node.h:
  • dom/ScopedEventQueue.cpp: Added. (WebCore::ScopedEventQueue::initialize): Added. (WebCore::ScopedEventQueue::enqueueEvent): Added. (WebCore::ScopedEventQueue::dispatchAllEvents): Added. (WebCore::ScopedEventQueue::dispatchEvent): Added. (WebCore::ScopedEventQueue::instance): Added. (WebCore::ScopedEventQueue::incrementScopingLevel): Added. (WebCore::ScopedEventQueue::decrementScopingLevel): Added.
  • dom/ScopedEventQueue.h: Added. (WebCore::ScopedEventQueue::~ScopedEventQueue): Added. (WebCore::ScopedEventQueue::ScopedEventQueue): Added. (WebCore::EventQueueScope::EventQueueScope): Added. (WebCore::EventQueueScope::~EventQueueScope): Added.
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Instantiates EventQueueScope.

2010-12-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Added a test to ensure no DOM mutation events are fired while execCommand is in progress.

  • fast/events/crash-on-mutate-during-drop.html: DOMNodeInserted is fired after BR is detached from the document, and can't be observed. Modify the DOM when text node is inserted.
  • fast/events/mutation: Added.
  • fast/events/mutation/execCommands.html: Added.
8:54 PM Changeset in webkit [73683] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix scrolling with mouse wheel in WebKit2 views. Once
we coalesce wheel events, we can re-enable this.

Reviewed by Gavin Barraclough.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scroll):

8:53 PM Changeset in webkit [73682] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-12-09 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

commit-queue errors out due to local commits
​https://bugs.webkit.org/show_bug.cgi?id=50766

We seem to be tripping over having local commits in the working copy a
lot recently. I don't quite fully understand what the issue is, but
this patch attempts to solve the problem by adding an explicit clean
step before processing a patch. Previously, we did the cleaning as
part of the apply-attachment step, so this might not actually fix the
problem.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
8:43 PM Changeset in webkit [73681] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-12-09 Abhishek Arya <​inferno@chromium.org>

Reviewed by James Robinson.

For details element, ensure that if we ended up being inline that we set out replaced
flag so that we are treated like an inline block.
​https://bugs.webkit.org/show_bug.cgi?id=50671

Test: fast/html/details-element-render-inline-crash.html

  • rendering/RenderDetails.cpp: (WebCore::RenderDetails::styleDidChange): setReplaced to true if we are set as inline.
  • rendering/RenderDetails.h: function definition.

2010-12-09 Abhishek Arya <​inferno@chromium.org>

Reviewed by James Robinson.

Tests that we do not crash when we set details element with children to show as inline.
​https://bugs.webkit.org/show_bug.cgi?id=50671

  • fast/html/details-element-render-inline-crash-expected.txt: Added.
  • fast/html/details-element-render-inline-crash.html: Added.
8:29 PM Changeset in webkit [73680] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-12-09 James Robinson <​jamesr@chromium.org>

Unreviewed. Update Chromium GPU test expecations for canvas/philip.

  • platform/chromium-gpu/test_expectations.txt:
8:06 PM Changeset in webkit [73679] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-12-09 Jasmin Lapalme <​jlapalme@druide.com>

Reviewed by Alexey Proskuryakov.

Test for a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT transformation.
​https://bugs.webkit.org/show_bug.cgi?id=50708

  • fast/xsl/utf8-chunks-expected.txt: Added.
  • fast/xsl/utf8-chunks.xml: Added.
  • fast/xsl/utf8-chunks.xsl: Added.

2010-12-09 Jasmin Lapalme <​jlapalme@druide.com>

Reviewed by Alexey Proskuryakov.

Fix a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT transformation.
​https://bugs.webkit.org/show_bug.cgi?id=50708

Test: fast/xsl/utf8-chunks.xml

  • xml/XSLTProcessorLibxslt.cpp: (WebCore::writeToVector): now converts and returns the correct byte count when the end of the chunk is in the middle of a multibyte UTF-8 character.
7:56 PM Changeset in webkit [73678] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-09 Vincent Scheib <​scheib@chromium.org>

Reviewed by James Robinson.

Clip update rectangle for Texture::updateSubRect to texture size
​https://bugs.webkit.org/show_bug.cgi?id=49929

Test: fast/canvas/canvas-largedraws.html

  • platform/graphics/gpu/Texture.cpp: (WebCore::Texture::updateSubRect):

2010-12-09 Vincent Scheib <​scheib@chromium.org>

Reviewed by James Robinson.

Clip update rectangle for Texture::updateSubRect to texture size
​https://bugs.webkit.org/show_bug.cgi?id=49929

  • fast/canvas/canvas-largedraws-expected.txt: Added.
  • fast/canvas/canvas-largedraws.html: Added.
7:36 PM Changeset in webkit [73677] by jocelyn.turcotte@nokia.com
  • 8 edits in trunk/WebKit2

2010-12-09 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Use a single QNetworkAccessManager per web process.
​https://bugs.webkit.org/show_bug.cgi?id=50757

This allows a better management of network resources and the use
of global cookie jar and disk cache across all frames.

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp: (WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext): (WebCore::WebFrameNetworkingContext::networkAccessManager):
  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::initializeWebProcess): (WebKit::WebProcess::shutdownIfPossible):
  • WebProcess/WebProcess.h: (WebKit::WebProcess::networkAccessManager):
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown):
  • WebProcess/qt/WebProcessQt.cpp: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown):
6:53 PM Changeset in webkit [73676] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Fix the 32-bit build.

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::sizeForNumberType):

6:45 PM Changeset in webkit [73675] by mjs@apple.com
  • 2 edits in trunk/WebKit2

2010-12-09 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Brady Eidson.

WebKit2: Control-click doesn't invoke context menu
​https://bugs.webkit.org/show_bug.cgi?id=50793
<rdar://problem/8664800>

  • WebProcess/WebPage/WebPage.cpp: (WebKit::isContextClick): New helper function - on Mac, not only right clicks but also control-left-clicks are context clicks. (WebKit::handleMouseEvent): Use above.
6:45 PM Changeset in webkit [73674] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-12-09 Kenneth Russell <​kbr@google.com>

Unreviewed. Another speculative Gtk build fix after r73669. Add
needed derived sources to GNUmakefile.am.

  • GNUmakefile.am:
6:43 PM Changeset in webkit [73673] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-09 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Group canvas/philip failures together, fix some expectations (many tests
that were marked as flaky actually fail consistently).

  • platform/chromium/test_expectations.txt:
6:33 PM Changeset in webkit [73672] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-12-09 Kenneth Russell <​kbr@google.com>

Unreviewed. Speculative Gtk build fix after
​https://bugs.webkit.org/show_bug.cgi?id=36512 / r73669. Process
all of the WebGL classes' IDL files.

  • CMakeLists.txt:
6:00 PM Changeset in webkit [73671] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Fix clang++ build.

  • Scripts/webkit2/messages.py:

DrawingAreaInfo is a struct.

  • Shared/WebPreferencesStore.cpp:

(WebKit::valueForKey):
Move valueForKey above code that uses it.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WebInspectorProxyObjCAdapter windowWillClose:]):
Remove trailing semicolon.

5:59 PM Changeset in webkit [73670] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-09 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Was overly aggressive with r73661, canvas/philip/tests/
toDataURL.jpeg.alpha.html still fails.

  • platform/chromium/test_expectations.txt:
5:58 PM Changeset in webkit [73669] by zmo@google.com
  • 17 edits
    2 adds in trunk

2010-12-09 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Expose constructor functions for instanceof checks of WebGL objects
​https://bugs.webkit.org/show_bug.cgi?id=36512

Test: fast/canvas/webgl/instanceof-test.html

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::webGLActiveInfoEnabled): (WebCore::RuntimeEnabledFeatures::webGLBufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLFramebufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLProgramEnabled): (WebCore::RuntimeEnabledFeatures::webGLRenderbufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLShaderEnabled): (WebCore::RuntimeEnabledFeatures::webGLTextureEnabled): (WebCore::RuntimeEnabledFeatures::webGLUniformLocationEnabled):
  • html/canvas/WebGLActiveInfo.idl: Remove OmitConstructor.
  • html/canvas/WebGLBuffer.idl: Ditto.
  • html/canvas/WebGLFramebuffer.idl: Ditto.
  • html/canvas/WebGLProgram.idl: Ditto.
  • html/canvas/WebGLRenderbuffer.idl: Ditto.
  • html/canvas/WebGLShader.idl: Ditto.
  • html/canvas/WebGLTexture.idl: Ditto.
  • html/canvas/WebGLUniformLocation.idl: Ditto.
  • page/DOMWindow.idl: Expose constructors for WebGL objects in DOMWindow.

2010-12-09 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Expose constructor functions for instanceof checks of WebGL objects
​https://bugs.webkit.org/show_bug.cgi?id=36512

  • fast/canvas/webgl/instanceof-test-expected.txt: Added.
  • fast/canvas/webgl/instanceof-test.html: Added.
  • fast/dom/Window/script-tests/window-property-descriptors.js: Register newly added WebGL objects.
  • fast/dom/Window/window-properties.html: Ditto.
  • fast/dom/script-tests/prototype-inheritance-2.js: Ditto. (constructorNamesForWindow):
  • fast/dom/script-tests/prototype-inheritance.js: Ditto.
  • fast/js/script-tests/global-constructors.js: Ditto.
5:54 PM Changeset in webkit [73668] by andersca@apple.com
  • 6 edits in trunk

Cannot use NSKeyedArchiver in WK2 for ResourceResponses
​https://bugs.webkit.org/show_bug.cgi?id=50792
<rdar://problem/8741799>

Reviewed by Sam Weinig.

WebKit2:

When encoding, first convert the requests and responses to the serializable dictionary representation
and use the newly added CF CoreIPC encoders. When decoding, do the opposite.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):
(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
5:53 PM Changeset in webkit [73667] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix a bug uncovered by clang++.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):

5:51 PM Changeset in webkit [73666] by timothy@apple.com
  • 14 edits in trunk

WebCore: Export Color::white and Color::transparent.

Reviewed by Anders Carlsson.

  • WebCore.exp.in:

WebKit2: Add support for transparent WebKit2 WKViews.

​https://webkit.org/b/50785

Reviewed by Anders Carlsson.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode): Encode drawsBackground and drawsTransparentBackground.
(WebKit::WebPageCreationParameters::decode): Decode drawsBackground and drawsTransparentBackground.

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView setDrawsBackground:]): Added.
(-[WKView drawsBackground]): Added.
(-[WKView setDrawsTransparentBackground:]): Added.
(-[WKView drawsTransparentBackground]): Added.
(-[WKView drawRect:]): Only fill the background if the WebProcess isn't valid and drawsBackground.
Use white or clear based on setDrawsTransparentBackground.
(-[WKView isOpaque]): Return drawsBackground.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Initialize m_drawsBackground and m_drawsTransparentBackground.
(WebKit::WebPageProxy::setDrawsBackground): Added. Send a SetDrawsBackground message.
(WebKit::WebPageProxy::setDrawsTransparentBackground): Added. Send a SetDrawsTransparentBackground message.
(WebKit::WebPageProxy::creationParameters): Set drawsBackground and drawsTransparentBackground.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::drawsBackground): Added. Return m_drawsBackground.
(WebKit::WebPageProxy::drawsTransparentBackground): Added. Return m_drawsTransparentBackground.

  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:

(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint): Use the copy blend mode when drawing a background.
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore): Use the copy blend mode to replace existing content.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Setup the new view's background color and transparent flag.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialize m_drawsBackground and m_drawsTransparentBackground.
(WebKit::WebPage::setDrawsBackground): Added. Propagate the flag to the FrameViews.
(WebKit::WebPage::setDrawsTransparentBackground): Added. Propagate the background color to the FrameViews.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::drawsBackground): Added. Return m_drawsBackground.
(WebKit::WebPage::drawsTransparentBackground): Added. Return m_drawsTransparentBackground.

  • WebProcess/WebPage/WebPage.messages.in: Added SetDrawsBackground and SetDrawsTransparentBackground.
5:49 PM Changeset in webkit [73665] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix failing Mac tests.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scroll): Don't smooth scroll if the default
AppleScrollAnimationEnabled is false.

5:49 PM Changeset in webkit [73664] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

Clang++ build fixes.

Silence a couple of warnings.

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

  • WebView/WebTextCompletionController.mm:

(-[WebTextCompletionController filterKeyDown:]):

5:45 PM Changeset in webkit [73663] by jamesr@google.com
  • 22 edits
    13 adds in trunk

2010-12-09 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Compositor needs to manage its VRAM use
​https://bugs.webkit.org/show_bug.cgi?id=49629

Adds a few tests involving lots of visible image layers. The tests are designed
to require slightly more than 64MB of VRAM.

  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.png: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.png: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.txt: Added.
  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/compositing/lots-of-img-layers-with-opacity.html: Added.
  • platform/chromium/compositing/lots-of-img-layers.html: Added.
  • platform/chromium/test_expectations.txt:

2010-12-09 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Compositor needs to manage its VRAM use
​https://bugs.webkit.org/show_bug.cgi?id=49629

This adds a basic texture manager to the Chromium compositor to limit the amount of VRAM
used by compositor textures and switches ContentLayerChromium, ImageLayerChromium, and
RenderSurfaceChromium to use managed LayerTexture. The other *LayerChromium classes (Canvas,
Video, and WebGL) and the root layer are still unmanaged.

The TextureManager works by providing tokens to callers that want to use a managed texture.
The token can be used to request a texture, see if the previously requested texture is still
available, and to protect/unprotect textures when they cannot be collected. Whenever a
texture is created the manager attempts to free up the least recently used textures until the
total memory use is below the provided threshhold. If the manager cannot satisfy the memory
limit it will not return any new textures until some old textures are released.

A LayerTexture wraps a TextureManager token, size, and format. A LayerChromium can check if a
previously requested texture is still available for use and reserve the LayerTexture's underlying
storage between the updateContentsIfDirty() and the draw() call.

Also changes LayerChromium from having separate contentsDirty()/updateContents() calls to a single
updateContentsIfDirty().

Tests: platform/chromium/compositing/lots-of-img-layers-with-opacity.html

platform/chromium/compositing/lots-of-img-layers.html

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::updateContentsIfDirty): (WebCore::LayerChromium::draw):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::useShader): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::updateRootLayerTextureRect): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::getFramebufferPixels): (WebCore::LayerRendererChromium::createLayerTexture): (WebCore::LayerRendererChromium::deleteLayerTexture): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect): (WebCore::LayerRendererChromium::setDrawViewportRect): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::renderSurfaceSharedValues): (WebCore::LayerRendererChromium::textureManager):
  • platform/graphics/chromium/LayerTexture.cpp: Added. (WebCore::LayerTexture::LayerTexture): (WebCore::LayerTexture::~LayerTexture): (WebCore::LayerTexture::isValid): (WebCore::LayerTexture::reserve): (WebCore::LayerTexture::unreserve): (WebCore::LayerTexture::bindTexture): (WebCore::LayerTexture::framebufferTexture2D):
  • platform/graphics/chromium/LayerTexture.h: Added. (WebCore::LayerTexture::create):
  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/PluginLayerChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::SharedValues::SharedValues): (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues): (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::cleanupResources): (WebCore::RenderSurfaceChromium::prepareContentsTexture): (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.h: (WebCore::RenderSurfaceChromium::SharedValues::shaderProgram): (WebCore::RenderSurfaceChromium::SharedValues::shaderSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::shaderMatrixLocation): (WebCore::RenderSurfaceChromium::SharedValues::shaderAlphaLocation): (WebCore::RenderSurfaceChromium::SharedValues::initialized):
  • platform/graphics/chromium/TextureManager.cpp: Added. (WebCore::memoryUseBytes): (WebCore::TextureManager::TextureManager): (WebCore::TextureManager::getToken): (WebCore::TextureManager::releaseToken): (WebCore::TextureManager::hasTexture): (WebCore::TextureManager::protectTexture): (WebCore::TextureManager::unprotectTexture): (WebCore::TextureManager::reduceMemoryToLimit): (WebCore::TextureManager::addTexture): (WebCore::TextureManager::removeTexture): (WebCore::TextureManager::requestTexture):
  • platform/graphics/chromium/TextureManager.h: Added. (WebCore::TextureManager::create):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/WebGLLayerChromium.h:
5:31 PM Changeset in webkit [73662] by andersca@apple.com
  • 4 edits
    3 adds in trunk/WebKit2

[GTK] Support the Mozilla-style Fullscreen Javascript API
​https://bugs.webkit.org/show_bug.cgi?id=50572

Patch by Philippe Normand <​pnormand@igalia.com> on 2010-12-06
Reviewed by Martin Robinson.

  • configure.ac: new configure flag to disable the new Javascript

Fullscreen API build. It is enabled by default.

5:29 PM Changeset in webkit [73661] by mihaip@chromium.org
  • 2 edits
    15 deletes in trunk/LayoutTests

2010-12-09 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Delete a bunch of chromium-win specific baselines that were added by
r68608. That was done because r68568 checked in failing expectations,
but since Chromium was passing the tests with Skia, we wanted to keep
passing them. However, the failing expectations were rolled out by
r68737, so we no longer needed Chromium-specific expectations.

Later, with r71481 we updated to a new version of the Philip test suite,
which has a different output format, and the Chromium-specific
expectations were out of date. Since they're not needed (we should pass
with the base ones), they can just be deleted.

  • platform/chromium-mac/canvas/philip/tests/2d.drawImage.null-expected.txt: Removed.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.null-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.drawImage.null-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.line.cap.closed-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.line.join.parallel-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.pattern.image.null-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
5:06 PM Changeset in webkit [73660] by Darin Adler
  • 5 edits in trunk/WebCore

Rework my recent setLocation refactoring to use DOMWindow instead of Frame.
It's difficult to make correct security decisions based on Frame since a
Frame can navigate to a new document.

Reviewed by Sam Weinig.

Fixes some test failures that I somehow missed before the last check-in.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Call to the
shell DOMWindow; not sure this one matters, but it's closer to the old
code before my last patch. Also pass the DOMWindow rather than the
frame to crossDomainAccessErrorMessage.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setLocation): Pass DOMWindow rather than Frame
to the DOMWindow::setLocation function.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::setLocation): Take DOMWindow rather than Frame.
(WebCore::DOMWindow::crossDomainAccessErrorMessage): Ditto.

  • page/DOMWindow.h: Update new functions to take DOMWindow rather

than Frame.

4:56 PM Changeset in webkit [73659] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-09 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Remove test_expectations.txt entries for 4 Philip suite canvas tests
that pass consistently on all bots. 2d.drawImage.incomplete.html was
fixed by r71292, the rest have been passing for as long as we have
history in the Chromium test dashboard.

  • platform/chromium/test_expectations.txt:
4:28 PM Changeset in webkit [73658] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

4:26 PM Changeset in webkit [73657] by mrowe@apple.com
  • 1 copy in tags/Safari-534.14

New tag.

3:47 PM Changeset in webkit [73656] by weinig@apple.com
  • 2 edits in trunk/WebCore

Try and fix the mac build.

  • WebCore.exp.in:
3:24 PM Changeset in webkit [73655] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

Mark a test as timing out on Win Debug.

  • platform/chromium/test_expectations.txt:
3:22 PM Changeset in webkit [73654] by dpranke@chromium.org
  • 7 edits in trunk/WebKitTools

2010-12-09 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

Make new-run-webkit-tests --lint-test-files log slightly better
messages and return -1 if lint fails. Remove the
'suppress_errors' keyword param to the TestExpectationsFile
class, and clean up logging and exception raising for error
handling. Also add more unit tests and clean up the unit test code a bit.

​https://bugs.webkit.org/show_bug.cgi?id=50205

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3:02 PM Changeset in webkit [73653] by mitz@apple.com
  • 2 edits in trunk/WebCore

Removed an unused variable.

Reviewed by Dave Hyatt.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights): Removed parentLineHeight.

2:35 PM Changeset in webkit [73652] by beidson@apple.com
  • 2 edits in trunk/WebKit2

<rdar://problem/8749750> and ​https://bugs.webkit.org/show_bug.cgi?id=50786
WK2 authentication never consults WebCore session credential storage.

Reviewed by Sam Weinig.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Since we don't need to expose this as

API at this time, always return true.

2:32 PM Changeset in webkit [73651] by pkasting@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

Rebaseline a Linux test.

  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/chromium/test_expectations.txt:
2:31 PM Changeset in webkit [73650] by weinig@apple.com
  • 2 edits in trunk/WebKit2

WebKit2: Add support for access keys
​https://bugs.webkit.org/show_bug.cgi?id=49832

Reviewed by Alexey Proskuryakov.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleKeyEvent): Match windows WebKit and call
the event handler's for handleAccessKey function for
system keys. This will never be hit on the Mac.

2:30 PM Changeset in webkit [73649] by Darin Adler
  • 2 edits in trunk/WebKit2

Qt build fix.

  • WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Include "NotImplemented.h".
2:29 PM Changeset in webkit [73648] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Fix date.

2:24 PM Changeset in webkit [73647] by Darin Adler
  • 6 edits in trunk/WebCore

2010-12-08 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
​https://bugs.webkit.org/show_bug.cgi?id=50640

  • bindings/js/JSDOMBinding.cpp: (WebCore::printErrorMessageForFrame): Removed body; just call through to DOMWindow::printErrorMessage.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body; just call through to DOMWindow::crossDomainAccessErrorMessage.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFrame and firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most of the body and moved it into DOMWindow::setLocation.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): Added. Does all the same work that JSDOMWindow::setLocation used to do, but in a way that's not specific to JavaScript. (WebCore::DOMWindow::printErrorMessage): Added. (WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.
  • page/DOMWindow.h: Added setLocation, printErrorMessage, and crossDomainAccessErrorMessage.
2:17 PM Changeset in webkit [73646] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.

  • WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp:
1:49 PM Changeset in webkit [73645] by hyatt@apple.com
  • 2 edits in trunk/WebKit/mac

​https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
writing-mode. This first part of the patch just patches Mac WebKit 1 views.

Reviewed by Dan Bernstein.

  • WebView/WebFrameView.mm:

(-[WebFrameView _isVerticalDocument]):
(-[WebFrameView _isFlippedDocument]):
(-[WebFrameView _scrollToEndOfDocument]):
(-[WebFrameView _pageInBlockProgressionDirection:]):
(-[WebFrameView scrollPageUp:]):
(-[WebFrameView scrollPageDown:]):

1:47 PM Changeset in webkit [73644] by weinig@apple.com
  • 3 edits
    1 move in trunk/WebCore

WebKit2 needs smooth scrolling support on the mac
<rdar://problem/8219402>

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj: Change ScrollAnimatorMac.cpp to ScrollAnimatorMac.mm.
  • platform/mac/ScrollAnimatorMac.cpp: Removed.
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm: Copied from platform/mac/ScrollAnimatorMac.cpp.

(-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollAnimationHelperDelegate bounds]):
(-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
(-[ScrollAnimationHelperDelegate convertSizeToBase:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
(-[ScrollAnimationHelperDelegate superview]):
(-[ScrollAnimationHelperDelegate documentView]):
(-[ScrollAnimationHelperDelegate window]):
(-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::setScrollPositionAndStopAnimation):
(WebCore::ScrollAnimatorMac::currentPosition):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Add implementation of ScrollAnimator for the Mac.

1:12 PM Changeset in webkit [73643] by beidson@apple.com
  • 8 edits
    3 adds in trunk

<rdar://problem/8613779> and ​https://bugs.webkit.org/show_bug.cgi?id=50777
WebKit2 ContextMenuClient support

Reviewed by Anders Carlsson.

WebCore:

Export some symbols and headers needed by WebKit2 Mac:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

WebKit2:

Implement google search in a cross platform manner, and add a FIXME for download support:

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::downloadURL):
(WebKit::WebContextMenuClient::searchWithGoogle):

Mac implementations for speaking and searching:

  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm: Added.

(WebKit::WebContextMenuClient::lookUpInDictionary): Add a FIXME for now.
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):
(WebKit::WebContextMenuClient::searchWithSpotlight):

Stubs for Win and Qt:

  • WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Added.

(WebKit::WebContextMenuClient::lookUpInDictionary):
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):

  • WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp: Added.

(WebKit::WebContextMenuClient::lookUpInDictionary):
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):

Project file stuffs:

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
1:10 PM Changeset in webkit [73642] by commit-queue@webkit.org
  • 9 edits in trunk

2010-12-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73635.
​http://trac.webkit.org/changeset/73635
​https://bugs.webkit.org/show_bug.cgi?id=50778

'Side-effects on 3 css tests needs closer review' (Requested
by mwenge on #webkit).

  • platform/qt/Skipped:

2010-12-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73635.
​http://trac.webkit.org/changeset/73635
​https://bugs.webkit.org/show_bug.cgi?id=50778

'Side-effects on 3 css tests needs closer review' (Requested
by mwenge on #webkit).

  • platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintSearchField): (WebCore::RenderThemeQt::adjustSearchFieldStyle): (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
  • platform/qt/RenderThemeQt.h:

2010-12-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73635.
​http://trac.webkit.org/changeset/73635
​https://bugs.webkit.org/show_bug.cgi?id=50778

'Side-effects on 3 css tests needs closer review' (Requested
by mwenge on #webkit).

  • Api/qwebsettings.cpp: (graphics):
  • Api/qwebsettings.h:
1:06 PM Changeset in webkit [73641] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-12-09 Alex Bredariol Grilo <​abgrilo@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Add missing function in WebKit-EFL API

Add ewk_tiled_backing_store_zoom_weak_smooth_scale_set function in
WebKit-EFL API. This function was already implemented but missing in
header file.

  • ewk/ewk_tiled_backing_store.h:
1:06 PM Changeset in webkit [73640] by msaboff@apple.com
  • 5 edits in trunk

2010-12-09 Michael Saboff <​msaboff@apple.com>

Reviewed by Gavin Barraclough.

REGRESSION (r73065?): A regex no longer works
​https://bugs.webkit.org/show_bug.cgi?id=50570

Changed the handling of adjacent parentheses backtracks in two ways.
First, only outer most paren backtracks default to back tracking
to the "next character" looping code. Second, added a jump around
backtracks that fall through to the next backtrack where the
second backtrack has some greedy processing before the backtracking
from outside the parentheses code.
Also cleaned up extraneous white spce, removing white space at the
end of or that makes up a whole line.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::GenerationState::GenerationState): (JSC::Yarr::RegexGenerator::GenerationState::incrementParenNestingLevel): (JSC::Yarr::RegexGenerator::GenerationState::decrementParenNestingLevel): (JSC::Yarr::RegexGenerator::GenerationState::addParenthesesTail): (JSC::Yarr::RegexGenerator::GenerationState::emitParenthesesTail): (JSC::Yarr::RegexGenerator::ParenthesesTail::ParenthesesTail): (JSC::Yarr::RegexGenerator::ParenthesesTail::setNextIteration): (JSC::Yarr::RegexGenerator::ParenthesesTail::generateCode): (JSC::Yarr::RegexGenerator::generateParenthesesSingle):

2010-12-09 Michael Saboff <​msaboff@apple.com>

Reviewed by Gavin Barraclough.

REGRESSION (r73065?): A regex no longer works
​https://bugs.webkit.org/show_bug.cgi?id=50570

Added tests that came from submitter to validate change.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
12:57 PM Changeset in webkit [73639] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
12:56 PM Changeset in webkit [73638] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-09 Tony Chang <​tony@chromium.org>

Unreviewed, fix for windows code. We were catching the wrong
exception in Windows.

  • Scripts/webkitpy/common/system/filesystem.py:
12:51 PM Changeset in webkit [73637] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk/LayoutTests

2010-12-09 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Adam Barth.

Rebaseline svg/custom/text-linking.svg
​https://bugs.webkit.org/show_bug.cgi?id=50310

  • platform/chromium/test_expectations.txt:
  • platform/chromium-win/svg/custom/text-linking-expected.checksum: Added.
  • platform/chromium-win/svg/custom/text-linking-expected.png: Added.
  • platform/chromium-win/svg/custom/text-linking-expected.txt: Added.
  • platform/mac-leopard/svg/custom/text-linking-expected.checksum: Updated.
  • platform/mac-leopard/svg/custom/text-linking-expected.png: Updated.
12:09 PM Changeset in webkit [73636] by pkasting@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
11:54 AM Changeset in webkit [73635] by robert@webkit.org
  • 9 edits in trunk

2010-12-09 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Search input field doesn't have cancel button
Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.

Unskip a bunch of search field related tests that pass now:

fast/forms/search-cancel-button-mouseup.html
fast/forms/search-rtl.html
fast/forms/search-abs-pos-cancel-button.html
fast/forms/search-styled.html
fast/forms/search-transformed.html
fast/forms/search-zoomed.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-display-none-cancel-button.html
fast/forms/search-placeholder-value-changed.html
fast/repaint/search-field-cancel.html
fast/forms/search-cancel-button-events.html

​https://bugs.webkit.org/show_bug.cgi?id=42887

  • platform/qt/Skipped:

2010-12-09 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Search input field doesn't have cancel button

Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.

​https://bugs.webkit.org/show_bug.cgi?id=42887

  • platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintSearchField): (WebCore::RenderThemeQt::adjustSearchFieldStyle): (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeQt::convertToPaintingRect): (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
  • platform/qt/RenderThemeQt.h:

2010-12-09 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Search input field doesn't have cancel button

Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.

​https://bugs.webkit.org/show_bug.cgi?id=42887

  • Api/qwebsettings.cpp: (graphics):
  • Api/qwebsettings.h:
11:45 AM QtWebKitFeatures21 edited by Ademar Reis
(diff)
11:36 AM Changeset in webkit [73634] by yael.aharon@nokia.com
  • 3 edits
    2 adds in trunk

2010-12-09 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Crash when handling iframe of size 0.
​https://bugs.webkit.org/show_bug.cgi?id=50730

  • fast/spatial-navigation/snav-hidden-iframe-zero-size-expected.txt: Added.
  • fast/spatial-navigation/snav-hidden-iframe-zero-size.html: Added.

2010-12-09 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Crash when handling iframe of size 0.
​https://bugs.webkit.org/show_bug.cgi?id=50730

if we have a frame of size 0, we would get into infinite loop and eventually crash. The reason is
that when the algorithm sees a starting rect of size 0, it assumes that there is no focused node,
thus restarts itself. The solution is to avoid considering iframes with size 0 for the spatial
navigation algorithm.

Test: fast/spatial-navigation/snav-hidden-iframe-zero-size.html

  • page/FocusController.cpp: (WebCore::updateFocusCandidateIfNeeded):
11:35 AM Changeset in webkit [73633] by hans@chromium.org
  • 16 edits in trunk

2010-12-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73616.
​http://trac.webkit.org/changeset/73616
​https://bugs.webkit.org/show_bug.cgi?id=50772

Breaks chromium win build (Requested by hwennborg on #webkit).

  • public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey):
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::number):

2010-12-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73616.
​http://trac.webkit.org/changeset/73616
​https://bugs.webkit.org/show_bug.cgi?id=50772

Breaks chromium win build (Requested by hwennborg on #webkit).

  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue):
  • bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls):
  • storage/IDBKey.h: (WebCore::IDBKey::create): (WebCore::IDBKey::number):

2010-12-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73616.
​http://trac.webkit.org/changeset/73616
​https://bugs.webkit.org/show_bug.cgi?id=50772

Breaks chromium win build (Requested by hwennborg on #webkit).

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-cursor.html:
11:28 AM Changeset in webkit [73632] by bweinstein@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Land failing expected results for editing tests that have been failing since they were
added in r73548.

Fixing the failures is being tracked by: ​https://bugs.webkit.org/show_bug.cgi?id=50731.

  • platform/win/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/win/editing/selection/caret-rtl-2-left-expected.txt: Added.
  • platform/win/editing/selection/caret-rtl-right-expected.txt: Added.
11:17 AM Changeset in webkit [73631] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Don't leak the PDFDocument
​https://bugs.webkit.org/show_bug.cgi?id=50771

Reviewed by Sam Weinig.

  • UIProcess/API/mac/PDFViewController.mm:

(WebKit::PDFViewController::setPDFDocumentData):

10:58 AM Changeset in webkit [73630] by andersca@apple.com
  • 5 edits
    1 copy
    1 add in trunk/WebKit2

Add a basic implementation of PDF support on Mac
​https://bugs.webkit.org/show_bug.cgi?id=50768

Reviewed by Sam Weinig.

  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm: Added.

(-[WKPDFView initWithFrame:PDFViewController:WebKit::]):
Setup the view hierarchy.

(-[WKPDFView invalidate]):
Set the controller to null.

(-[WKPDFView pdfView]):
Return the PDF view.

(WebKit::PDFViewController::create):
(WebKit::PDFViewController::PDFViewController):
Create a WKPDFView and insert it as a subview of the WKView.

(WebKit::PDFViewController::~PDFViewController):
Remove the WKPDFView from the view hierarchy and invalidate it.

(WebKit::convertPostScriptDataSourceToPDF):
Convert the data in the data reference to PDF and return it as a CFDataRef.

(WebKit::PDFViewController::setPDFDocumentData):
Create a PDFDocument and set it on the PDF view.

(WebKit::PDFViewController::pdfDocumentClass):
(WebKit::PDFViewController::pdfPreviewViewClass):
(WebKit::PDFViewController::pdfKitBundle):
Add soft-linking helper functions.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
Call the WKView methods.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPageHasCustomRepresentation:]):
Create a PDF view controller if necessary.

(-[WKView _didFinishLoadingDataForCustomRepresentation:CoreIPC::]):
Pass the data along to the PDF view controller.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

10:54 AM Changeset in webkit [73629] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

2010-12-09 Antonio Gomes <​agomes@rim.com>

Rubber stamped by Gustavo Noronha.

Buildfix for GTK+ with building with -no-video.

paintStockIcon static function was implemented under the ENABLE(VIDEO) guard
but used from outside the guard. See RenderThemeGtk::paintSearchFieldResultsDecoration()
and RenderThemeGtk::paintSearchFieldCancelButton() methods.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::getMediaElementFromRenderObject):
10:54 AM Changeset in webkit [73628] by tonikitoo@webkit.org
  • 7 edits
    1 delete in trunk

2010-12-09 Antonio Gomes <​agomes@rim.com>

Reviewed by Martin Robinson.

[Gtk] Populate DumpRenderTreeSupportGtk (part IV)
​https://bugs.webkit.org/show_bug.cgi?id=48429

WebKit/gtk:
Moved also webkit_worker_thread_count() to DumpRenderTreeSupportGtk,
since it was only used by DRT for now.

Since this method was the only one in webkitworker.cpp, the file was
also removed.

  • GNUmakefile.am:
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::workerThreadCount):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • webkit/webkitprivate.h:
  • webkit/webkitworkers.cpp: Removed.

WebKitTools/DumpRenderTree/gtk:
Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::workerThreadCount):
10:53 AM Changeset in webkit [73627] by tonikitoo@webkit.org
  • 3 edits in trunk/WebCore

2010-12-07 Antonio Gomes <​agomes@rim.com>

Reviewed by Daniel Bates.

Spatial Navigation: code clean up
​https://bugs.webkit.org/show_bug.cgi?id=50666

Patch unifies two FocusCandidate constructors, making caller sites
simpler. Now the special handling HTMLAreaElement gets is done within
the non default constructor (i.e. FocusCanditate(Node*, FocusDirection)).

No new tests needed.

  • page/FocusController.cpp: (WebCore::FocusController::findFocusCandidateInContainer):
  • page/SpatialNavigation.cpp: (WebCore::FocusCandidate::FocusCandidate):
10:49 AM Changeset in webkit [73626] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-12-09 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] disable fullscreen on MacOS Tiger and Leopard
​https://bugs.webkit.org/show_bug.cgi?id=50748

Don't support fullscreen video on Tiger and Leopard, just like the
QTKit player.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::supportsFullscreen):
10:37 AM Changeset in webkit [73625] by andersca@apple.com
  • 20 edits in trunk/WebKit2

Add support for custom representation
​https://bugs.webkit.org/show_bug.cgi?id=50767

Reviewed by Sam Weinig.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add mimeTypesWithCustomRepresentation and encode and decode accordingly.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
Add empty stubs for now.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::didCommitLoadForMainFrame):
(QWKPagePrivate::didFinishLoadingDataForCustomRepresentation):

  • UIProcess/API/qt/qwkpage_p.h:

Add empty stubs.

  • UIProcess/PageClient.h:

Add new functions for custom representations.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canShowMIMEType):
Check that the mime type is not null.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):
This now takes an additional frameHasCustomRepresentation parameter.
Call the page client function.

(WebKit::WebPageProxy::didFinishLoadingDataForCustomRepresentation):
Call the page client function.

  • UIProcess/WebPageProxy.messages.in:

Change DidCommitLoadForFrame message, add DidFinishLoadingDataForCustomRepresentation message.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
We want to use custom representations for PDF and PostScript MIME types.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame):
(WebKit::WebView::didFinishLoadingDataForCustomRepresentation):

  • UIProcess/win/WebView.h:

Add stubs.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
Initialize m_frameHasCustomRepresentation.

(WebKit::WebFrameLoaderClient::hasHTMLView):
The frame has a HTML view unless it has a custom representation.

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
Pass along whether the frame has a custom representation.

(WebKit::WebFrameLoaderClient::committedLoad):
Don't send data back to WebCore if the frame has a custom representation.

(WebKit::WebFrameLoaderClient::finishedLoading):
Send all the data to the UI process.

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Update the m_frameHasCustomRepresentation state based on the MIME type.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebKit::WebFrameLoaderClient::frameHasCustomRepresentation):
Add getter.

  • WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp:

(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
Don't do any painting if the main frame has a custom representation.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Add all the MIME types with custom representations.

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::shouldUseCustomRepresentationForMIMEType):
Add getter.

10:31 AM Changeset in webkit [73624] by Philippe Normand
  • 15 edits in trunk

2010-12-06 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] Support the Mozilla-style Fullscreen Javascript API
​https://bugs.webkit.org/show_bug.cgi?id=50572

  • configure.ac: new configure flag to disable the new Javascript Fullscreen API build. It is enabled by default.

WebCore:

Reviewed by Martin Robinson.

[GTK] Support the Mozilla-style Fullscreen Javascript API
​https://bugs.webkit.org/show_bug.cgi?id=50572

  • GNUmakefile.am: enable the Javascript Fullscreen API feature if it's been requested at configure time.

WebKit/gtk:

Reviewed by Martin Robinson.

[GTK] Support the Mozilla-style Fullscreen Javascript API
​https://bugs.webkit.org/show_bug.cgi?id=50572

Fullscreen API support. It is controlled at runtime using a new
setting called enable-fullscreen, set to FALSE by default.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::supportsFullScreenForElement): (WebKit::ChromeClient::enterFullScreenForElement): (WebKit::ChromeClient::exitFullScreenForElement):
  • WebCoreSupport/ChromeClientGtk.h:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings):

WebKitTools:

Reviewed by Martin Robinson.

[GTK] Support the Mozilla-style Fullscreen Javascript API
​https://bugs.webkit.org/show_bug.cgi?id=50572

Enable the Javascript Fullscreen support in the GtkLauncher. Also
make DRT update the Chrome when the WebView settings have been
reset to consistent values.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • GtkLauncher/main.c: (create_window):
  • Scripts/build-webkit:

LayoutTests:

Reviewed by Martin Robinson.

[GTK] Support the Mozilla-style Fullscreen Javascript API
​https://bugs.webkit.org/show_bug.cgi?id=50572

  • platform/gtk/Skipped: Unskip now passing fullscreen tests.
10:27 AM Changeset in webkit [73623] by msaboff@apple.com
  • 6 edits
    3 adds in trunk

2010-12-09 Michael Saboff <​msaboff@apple.com>

Reviewed by Geoffrey Garen.

Addressed the "FIXME" issues in array sort for toString() methods that
mutate the array in either size or contents. The change is to mark
the temporary array contents so that they are not garbage collected
and to make sure the array is large enough to hold the contents
of the sorted temporary vector.
​https://bugs.webkit.org/show_bug.cgi?id=50718

  • runtime/Collector.cpp: (JSC::Heap::addTempSortVector): (JSC::Heap::removeTempSortVector): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/Collector.h:
  • runtime/JSArray.cpp: (JSC::JSArray::sort):
  • runtime/JSValue.h:

2010-12-09 Michael Saboff <​msaboff@apple.com>

Reviewed by Geoffrey Garen.

New test to verify that arrays sort per the standard even it
there is an override for toString() that modifies the array.
​https://bugs.webkit.org/show_bug.cgi?id=50718

  • fast/js/array-sort-modifying-tostring-expected.txt: Added.
  • fast/js/array-sort-modifying-tostring.html: Added.
  • fast/js/script-tests/array-sort-modifying-tostring.js: Added. (do_gc): (Item): (toString_Mutate): (test):
10:26 AM Changeset in webkit [73622] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-09 Yong Li <​yoli@rim.com>

Reviewed by Darin Adler.

Check the return value of ImageBuffer::create()
to avoid crash when ImageBuffer::create() fails.
​https://bugs.webkit.org/show_bug.cgi?id=50631

No new test because it relies on the platform implementation
of ImageBuffer. It is hard to make ImageBuffer::create() fail
in most ports.

  • platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
10:07 AM Changeset in webkit [73621] by mjs@apple.com
  • 6 edits in trunk

2010-12-09 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Implement "Use Selection for Find" in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=50737
<rdar://problem/8564881>

Implement a TakeFindStringFromSelection editor command. This is
used solely to implement the "Use Selection for Find" menu command
on Mac, and is not made available to script. On WebKit2, it is
very convenient to reuse the editing machinery since this command
is very similar to Copy.

  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeTakeFindStringFromSelection): Call to a mac-only Editor function. (WebCore::enabledTakeFindStringFromSelection): Check using Editor::canCopyExcludingStandaloneImage (WebCore::createCommandMap): Add "TakeFindStringFromSelection" command.
  • editing/mac/EditorMac.mm: (WebCore::Editor::canCopyExcludingStandaloneImages): Helper function; we can't use Editor::canCopy since it would make no sense to enable "Use Selection for Find" when viewing a standalone image document. (WebCore::Editor::takeFindStringFromSelection): Implement by copying the selected text to the special Find pasteboard.

2010-12-09 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Implement "Use Selection for Find" in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=50737
<rdar://problem/8564881>


  • UIProcess/API/mac/WKView.mm: Add support for the takeFindStringFromSelection: selector as a command.
9:51 AM Changeset in webkit [73620] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-09 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dimitri Glazkov.

As part of r73559, I added the referenceNode check to validate whether the root
node of the iterator matches the node which is getting moved to other document.
referenceNode is initialized to root, however can get moved using previousNode
and nextNode methods, so it is required to use root directly.
​https://bugs.webkit.org/show_bug.cgi?id=50764

Test: fast/dom/node-iterator-reference-node-moved-crash.html

  • dom/Document.cpp: (WebCore::Document::moveNodeIteratorsToNewDocument): change referenceNode to root.

2010-12-09 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when we move the referenceNode using node iterator
methods previousNode and nextNode.
​https://bugs.webkit.org/show_bug.cgi?id=50764

  • fast/dom/node-iterator-reference-node-moved-crash-expected.txt: Added.
  • fast/dom/node-iterator-reference-node-moved-crash.html: Added.
9:40 AM Changeset in webkit [73619] by xji@chromium.org
  • 2 edits in branches/chromium/597/WebCore

Merge 73586 - Fix regression from xji's wheel scroll patch. The vertical case is looking at the horizontal
maximum position and not the vertical position.

Reviewed by Simon Fraser.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

TBR=​hyatt@apple.com

9:31 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
9:23 AM QtWebKitFeatures21 edited by Henry Haverinen
(diff)
9:23 AM Changeset in webkit [73618] by Dimitri Glazkov
  • 22 edits in trunk/WebCore

2010-12-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Provide a generic way to store shadowParent on a Node.
​https://bugs.webkit.org/show_bug.cgi?id=50184

This patch makes TreeShared::m_parent act as either parentNode() or
shadowHost() for Node. The distinction is controlled by IsShadowRootFlag.

Refactoring, so no new tests. See performance result testing in bug.

  • dom/Element.cpp: (WebCore::Element::recalcStyle): Changed to use parentOrHostNode().
  • dom/Node.cpp: (WebCore::Node::shadowHost): Added. (WebCore::Node::setShadowHost): Added. (WebCore::Node::isContentEditable): Changed to use parentOrHostNode(). (WebCore::Node::isContentRichlyEditable): Ditto. (WebCore::Node::nextRenderer): Ditto. (WebCore::Node::virtualComputedStyle): Ditto. (WebCore::Node::canStartSelection): Ditto. (WebCore::Node::shadowTreeRootNode): Changed to use parentNodeGuaranteedHostFree(). (WebCore::Node::getEventAncestors): Ditto. (WebCore::Node::defaultEventHandler): Changed to use parentOrHostNode().
  • dom/Node.h: Added an extra flag and adjusted bit counts. (WebCore::Node::isShadowNode): Made non-virtual, switched to use flag. (WebCore::Node::parentNode): Made to recognize flag. (WebCore::Node::parentOrHostNode): Changed to use straight parent() and made const. (WebCore::Node::parentNodeGuaranteedHostFree): Added. (WebCore::Node::shadowParentNode): Made non-virtual and const.
  • editing/TextIterator.cpp: (WebCore::depthCrossingShadowBoundaries): Changed to use parentOrHostNode(); (WebCore::nextInPreOrderCrossingShadowBoundaries): Ditto. (WebCore::previousInPostOrderCrossingShadowBoundaries): Ditto. (WebCore::setUpFullyClippedStack): Ditto. (WebCore::TextIterator::advance): Ditto. (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto.
  • page/DOMSelection.cpp: (WebCore::DOMSelection::anchorNode): Changed to use parentNodeGuaranteedHostFree(). (WebCore::DOMSelection::focusNode): Ditto. (WebCore::DOMSelection::baseNode): Ditto. (WebCore::DOMSelection::extentNode): Ditto. (WebCore::DOMSelection::getRangeAt): Ditto.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):

Changed to setShadowHost().

(WebCore::MediaControlShadowRootElement::updateStyle): Changed to use shadowHost().
(WebCore::MediaControlShadowRootElement::detach): Added an override to

explicitly set shadowHost to 0. Otherwise, the element will leak.

  • rendering/MediaControlElements.h: Added detach def, removed members that are

no longer needed.

  • rendering/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):

Added explicit clearing of shadowHost to avoid leaking and crashes,
because SVG shadow DOM can be dynamically attached/detached, producing
stale nodes in over/out event handling.

  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::defaultEventHandler): Changed to use shadowHost().
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):

Added explicit clearing of shadowHost and explicit destruction to
avoid out-of-order removal of children.

  • rendering/RenderTreeAsText.cpp: (WebCore::nodePosition): Simplified code.
  • rendering/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): Added

setting of shadowHost.

(WebCore::SVGShadowTreeRootElement::attachElement): Changed to use shadowHost().
(WebCore::SVGShadowTreeRootElement::clearShadowHost): Added.

  • rendering/SVGShadowTreeElements.h: Added def, removed members that are

no longer needed.

  • rendering/ShadowElement.cpp: (WebCore::ShadowBlockElement::initAsPart): Changed to use shadowHost().
  • rendering/ShadowElement.h: Removed members that are no longer needed. (WebCore::ShadowElement::ShadowElement): Added setting of shadowHost. (WebCore::ShadowElement::detach): Added.
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): Added setting

of shadowHost.

(WebCore::TextControlInnerElement::attachInnerElement): Changed to use

isShadowNode().

(WebCore::TextControlInnerElement::detach): Added.

  • rendering/TextControlInnerElements.h: Removed members that are no

longer needed.

  • svg/SVGElement.cpp: (WebCore::SVGElement::ownerSVGElement): Simplified code. (WebCore::SVGElement::viewportElement): Ditto.
  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::computeCTM): Ditto.
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title): Ditto.
  • svg/SVGUseElement.cpp: (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
9:18 AM Changeset in webkit [73617] by msaboff@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

2010-12-09 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

Changed setting of backtrack labels to not overwrite a prior
label. Where losing prior labe which then reverted back to
next character label.
​https://bugs.webkit.org/show_bug.cgi?id=50579

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::BacktrackDestination::setBacktrackToLabel):
9:18 AM Changeset in webkit [73616] by hans@chromium.org
  • 16 edits in trunk

2010-12-09 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
​https://bugs.webkit.org/show_bug.cgi?id=50674

Update layout tests to use floating-point values for keys.

  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html: Make sure creating the keys works.
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html: Make sure retrieving the keys from the DB objectstore works.

2010-12-09 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
​https://bugs.webkit.org/show_bug.cgi?id=50674

Use floating point to represent numeric keys,
add version meta data to the SQLite db,
and migrate object stores that use integers.

  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue):
  • bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables): (WebCore::migrateDatabase): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls):
  • storage/IDBKey.h: (WebCore::IDBKey::create): (WebCore::IDBKey::number):

2010-12-09 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
​https://bugs.webkit.org/show_bug.cgi?id=50674

Represent numeric keys as floating point values.

  • public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey):
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::number):
9:14 AM Changeset in webkit [73615] by msaboff@apple.com
  • 5 edits in trunk

2010-06-28 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

Bug 41238 - RegExp performance slow on Dromaeo benchmark

Other javascript engines appear to cache prior results of regular
expression operations.

Suggest adding some sort of caching mechanism to regular expression
processing.

Added a single entry cache of match() results to RegExp class.

Also added performance improvements to UString == operator.
First check the impls for equality. Then get the length of
each of the non-null impls. Next check the sizes for equality.
Then check the data for the case of different impls that point
to the same data (most likely due to substrings from the beginning of
another string). Lastly we check the underlying data for equality.

Refactored Vector<>::operator=() method into a separate copy() method
that it calls. The copy() method is explicitly used for deep copying.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::match):
  • runtime/RegExp.h:
  • runtime/UString.h: (JSC::operator==):
  • wtf/Vector.h: (WTF::::operator): (WTF::::copy):

2010-12-09 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

Added test to verify proper operation of backtrack labels.
​https://bugs.webkit.org/show_bug.cgi?id=50579

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
8:55 AM Changeset in webkit [73614] by beidson@apple.com
  • 26 edits
    2 adds in trunk

<rdar://problem/7660733> and ​https://bugs.webkit.org/show_bug.cgi?id=50191
WebKit2 Authentication Support

Reviewed by Maciej Stachowiak.

WebCore:

  • WebCore.exp.in:

WebKit2:

Implement authentication-related coders:

  • Shared/WebCoreArgumentCoders.h:

Allow the ResourceResponse coders to handle null responses:

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

Add new API and Impl casts for ProtectionSpace and Credential enums:

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toAPI):
(WebKit::toCredentialPersistence):

Move the DecisionListener to be accessed off the challenge itself, and fill in other
necessary API:

  • UIProcess/API/C/WKAuthenticationChallenge.cpp:

(WKAuthenticationChallengeGetDecisionListener):
(WKAuthenticationChallengeGetProtectionSpace):
(WKAuthenticationChallengeGetProposedCredential):
(WKAuthenticationChallengeGetPreviousFailureCount):

  • UIProcess/API/C/WKAuthenticationChallenge.h:
  • UIProcess/Authentication/AuthenticationChallengeProxy.cpp:

(WebKit::AuthenticationChallengeProxy::~AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::proposedCredential):
(WebKit::AuthenticationChallengeProxy::protectionSpace):

  • UIProcess/Authentication/AuthenticationChallengeProxy.h:

(WebKit::AuthenticationChallengeProxy::previousFailureCount):

Fill in some credential API:

  • UIProcess/API/C/WKCredential.cpp:

(WKCredentialCreate):
(WKCredentialCopyUser):

  • UIProcess/API/C/WKCredential.h:
  • UIProcess/API/C/WKCredentialTypes.h: Added.
  • UIProcess/Authentication/WebCredential.cpp:

(WebKit::WebCredential::WebCredential):
(WebKit::WebCredential::user):

  • UIProcess/Authentication/WebCredential.h:

(WebKit::WebCredential::create):

Fill in some protection space API:

  • UIProcess/API/C/WKProtectionSpace.cpp:

(WKProtectionSpaceCopyHost):
(WKProtectionSpaceGetPort):
(WKProtectionSpaceCopyRealm):
(WKProtectionSpaceGetIsProxy):
(WKProtectionSpaceGetServerType):
(WKProtectionSpaceGetReceivesCredentialSecurely):
(WKProtectionSpaceGetAuthenticationScheme):

  • UIProcess/API/C/WKProtectionSpace.h:
  • UIProcess/API/C/WKProtectionSpaceTypes.h: Added.
  • UIProcess/Authentication/WebProtectionSpace.cpp:

(WebKit::WebProtectionSpace::WebProtectionSpace):
(WebKit::WebProtectionSpace::host):
(WebKit::WebProtectionSpace::port):
(WebKit::WebProtectionSpace::realm):
(WebKit::WebProtectionSpace::isProxy):
(WebKit::WebProtectionSpace::serverType):
(WebKit::WebProtectionSpace::receivesCredentialSecurely):
(WebKit::WebProtectionSpace::authenticationScheme):

  • UIProcess/Authentication/WebProtectionSpace.h:

Change the authentication challenge callback to reflect the new ownership of
the DecisionListener:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didReceiveAuthenticationChallengeInFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
8:40 AM Changeset in webkit [73613] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

2010-12-09 Peter Beverloo <​peter@lvp-media.com>

Reviewed by Maciej Stachowiak.

Default CSS definitions for the figure and figcaption elements.

  • fast/html/figcaption-element-expected.txt: Added.
  • fast/html/figcaption-element.html: Added.
  • fast/html/figure-element-expected.txt: Added.
  • fast/html/figure-element.html: Added.
  • fast/html/script-tests/figcaption-element.js: Added.
  • fast/html/script-tests/figure-element.js: Added.

2010-12-09 Peter Beverloo <​peter@lvp-media.com>

Reviewed by Maciej Stachowiak.

Default CSS definitions for the figure and figcaption elements.

Tests: fast/html/figcaption-element.html

fast/html/figure-element.html

  • css/html.css: (figure): The default figure-style equals a blockquote (figcaption): A non-sectioning block-level element
8:22 AM Changeset in webkit [73612] by yael.aharon@nokia.com
  • 1 edit
    4 adds in trunk/LayoutTests

2010-12-09 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: more tests.
​https://bugs.webkit.org/show_bug.cgi?id=50728

  • fast/spatial-navigation/snav-hidden-focusable-element-expected.txt: Added.
  • fast/spatial-navigation/snav-hidden-focusable-element.html: Added.
  • fast/spatial-navigation/snav-hidden-iframe-expected.txt: Added.
  • fast/spatial-navigation/snav-hidden-iframe.html: Added.
8:06 AM Changeset in webkit [73611] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKitTools

2010-12-09 Koan-Sin Tan <​koansin.tan@gmail.com>

Reviewed by Tor Arne Vestbø

[Qt] run-launcher doesn't start the browser on Mac OS X 10.6
​https://bugs.webkit.org/show_bug.cgi?id=50742

check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib

  • Scripts/webkitdirs.pm:
8:06 AM Changeset in webkit [73610] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-12-09 Alex Bredariol Grilo <​abgrilo@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Fix scroll operation in WebKit-EFL
​https://bugs.webkit.org/show_bug.cgi?id=50752

Add the _ewk_view_scroll_add call in WebKit-EFL scroll function. This
call was wrongly removed in previous commit and performs the scroll
operation on the page.

  • ewk/ewk_view.cpp: (ewk_view_scroll):
8:00 AM Changeset in webkit [73609] by Csaba Osztrogonác
  • 1 edit
    18 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for tests introduced in r73548.
Compared to Mac png files and Mac expected files.

  • platform/qt/editing/selection/caret-ltr-2-expected.checksum: Added.
  • platform/qt/editing/selection/caret-ltr-2-expected.png: Added.
  • platform/qt/editing/selection/caret-ltr-2-expected.txt: Added.
  • platform/qt/editing/selection/caret-ltr-2-left-expected.checksum: Added.
  • platform/qt/editing/selection/caret-ltr-2-left-expected.png: Added.
  • platform/qt/editing/selection/caret-ltr-2-left-expected.txt: Added.
  • platform/qt/editing/selection/caret-ltr-expected.checksum: Added.
  • platform/qt/editing/selection/caret-ltr-expected.png: Added.
  • platform/qt/editing/selection/caret-ltr-expected.txt: Added.
  • platform/qt/editing/selection/caret-ltr-right-expected.checksum: Added.
  • platform/qt/editing/selection/caret-ltr-right-expected.png: Added.
  • platform/qt/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/qt/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/qt/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/qt/editing/selection/caret-rtl-2-left-expected.txt: Added.
  • platform/qt/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/qt/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/qt/editing/selection/caret-rtl-right-expected.txt: Added.
6:56 AM Changeset in webkit [73608] by commit-queue@webkit.org
  • 22 edits
    2 adds in trunk

2010-12-09 Joone Hur <​joone@kldp.org>

Reviewed by Martin Robinson.

[GTK] Support for viewport meta tag
​https://bugs.webkit.org/show_bug.cgi?id=45443

Included viewport test cases for WebKitGtk

  • platform/gtk/Skipped: Unskip fast/viewport except viewport-45.html.

2010-12-09 Joone Hur <​joone@kldp.org>

Reviewed by Martin Robinson.

[GTK] Support for viewport meta tag
​https://bugs.webkit.org/show_bug.cgi?id=45443

This patch adds a new gobject to offer the viewport properties to user agents.
It is WebKitViewportAttributes that contains the viewport size, initial scale with limits,
and information about whether a user is able to scale the contents in the viewport.

This feature was introduced by Safari on the iPhone. For more information on
the viewport properties, refer to the Safari reference library at
​http://developer.apple.com/safari/library/documentation/appleapplications/reference/safarihtmlref/articles/metatags.html

  • GNUmakefile.am: Added webkitviewportattributes.h webkitviewportattributes.cpp.
  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::dispatchViewportDataDidChange): Added this callback to know whether the viewport arguments is available.
  • WebCoreSupport/ChromeClientGtk.h:
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): Added this function to compute the viewport attributes with the given availableWidth and availableHeight.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): Invalidate the viewport attributes.
  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitprivate.h: Added webkitViewportAttributesRecompute as a private function.
  • webkit/webkitviewportattributes.cpp: Added. (webkit_viewport_attributes_class_init): (webkit_viewport_attributes_init): (webkit_viewport_attributes_get_property): (webkit_viewport_attributes_set_property): (webkitViewportAttributesRecompute): Recompute the optimal viewport attributes and emit the viewport-attributes-changed signal. (webkit_viewport_attributes_recompute): a public API for calling webkitViewportAttributesRecompute.
  • webkit/webkitviewportattributes.h: Added.
  • webkit/webkitwebview.cpp: (webkit_web_view_get_property): Added PROP_VIEWPORT_ATTRIBUTES. (webkit_web_view_dispose): Deallocate the WebKitViewportAttributes instance. (webkit_web_view_class_init): Added the viewport-attributes-recompute-requested and viewport-attributes-changed signals. (webkit_web_view_init): Set the WebKitViewportAttributes instance. (webkit_web_view_get_viewport_attributes): Added a getter to obtain the WebKitViewportAttributes instance held by the given WebKitWebView.
  • webkit/webkitwebview.h:
  • webkit/webkitwebviewprivate.h: Added WebKitViewportAttributes as a private variable.

2010-12-09 Joone Hur <​joone@kldp.org>

Reviewed by Martin Robinson.

[GTK] Support for viewport meta tag
​https://bugs.webkit.org/show_bug.cgi?id=45443

Add support for testing the viewport properties for WebKitGtk.

  • DumpRenderTree/LayoutTestController.cpp: (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport. (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::dumpConfigurationForViewport): Ditto.
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::dumpConfigurationForViewport): Ditto.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::dumpConfigurationForViewport): Ditto.
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::dumpConfigurationForViewport): Ditto.
5:57 AM QtWebKitFeatures21 edited by Henry Haverinen
(diff)
5:34 AM Changeset in webkit [73607] by yurys@chromium.org
  • 14 edits
    1 copy
    1 add in trunk

2010-12-09 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Console records for failed XHRs should contain call stack and request method
​https://bugs.webkit.org/show_bug.cgi?id=50390

The expectations needed update ue to log format changes.

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
  • http/tests/inspector/console-resource-errors-expected.txt:
  • http/tests/inspector/console-xhr-logging-expected.txt:
  • platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Added.
  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Copied from LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt.

2010-12-09 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Console records for failed XHRs should contain call stack and request method
​https://bugs.webkit.org/show_bug.cgi?id=50390

When inspector front-end is open we capture call stack at the place where request is sent and
pass the stack along with other request data. There is a new type of console messages which
is NetworkErrorMessageType, all messages of that type will have requestId field initialized
with the corresponding network request identifier so that later on when we need to display
that message in the front-end we could pull request data from the Network panel using
this identifier. If there are no data for given requestId message formatting falls back to
the old implementation which lacks such things as call stack, request method and exact
source location.

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype.toString): (WebInspector.ConsoleMessage.prototype.isEqual):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
  • inspector/front-end/inspector.js: (WebInspector.addConsoleMessage):
  • page/Console.h:
5:07 AM Changeset in webkit [73606] by commit-queue@webkit.org
  • 23 edits
    5 adds in trunk

2010-12-09 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

Implement "required" attribute for select tags
​https://bugs.webkit.org/show_bug.cgi?id=50380

Added tests for require attributes, valueMissing and vadility check for select elements.

  • fast/forms/ValidityState-valueMissing-001-expected.txt:
  • fast/forms/ValidityState-valueMissing-001.html:
  • fast/forms/ValidityState-valueMissing-002-expected.txt:
  • fast/forms/ValidityState-valueMissing-002.html:
  • fast/forms/ValidityState-valueMissing-003-expected.txt:
  • fast/forms/ValidityState-valueMissing-003.html:
  • fast/forms/checkValidity-002-expected.txt:
  • fast/forms/checkValidity-002.html:
  • fast/forms/required-attribute-001-expected.txt:
  • fast/forms/required-attribute-001.html:
  • fast/forms/required-attribute-002-expected.txt:
  • fast/forms/required-attribute-002.html:
  • fast/forms/resources/select-live-pseudo-selectors.js: Added. (makeInvalid): (appendOption): (backgroundOf):
  • fast/forms/script-tests/validationMessage.js:
  • fast/forms/select-live-pseudo-selectors-expected.txt: Added.
  • fast/forms/select-live-pseudo-selectors.html: Added.
  • fast/forms/validationMessage-expected.txt:
  • platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Added.
  • platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Added.

2010-12-09 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

Implement "required" attribute for select tags
​https://bugs.webkit.org/show_bug.cgi?id=50380

Test: fast/forms/select-live-pseudo-selectors.html

platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::updateValidity): Added. It's a pure virtual function which is prepared so that HTMLSelectElement::updateValidity() calls HTMLSelectElement::setNeedsValidityCheck(). (WebCore::SelectElement::parseMultipleAttribute): Added calling updateValidity().
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface. (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified. (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180. (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated.. (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not. (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added. (WebCore::HTMLSelectElement::updateValidity): Added. It calls setNeedsValidityCheck().
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
  • html/HTMLSelectElement.idl: Added a required attribute to select elements..
  • html/ValidityState.cpp: (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
  • wml/WMLSelectElement.h: (WebCore::WMLSelectElement::updateValidity): Added. It does nothing.
4:29 AM Changeset in webkit [73605] by jorlow@chromium.org
  • 13 edits in trunk

2010-12-07 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB returns the wrong exceptions
​https://bugs.webkit.org/show_bug.cgi?id=50632

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

2010-12-07 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB returns the wrong exceptions
​https://bugs.webkit.org/show_bug.cgi?id=50632

IndexedDB exceptions need to have an offset so they can
be distinguished from DOM exceptions. We also need to
add strings for the various exceptions. Lastly, make
IDBDatabaseException use the common exception base class.

  • bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
  • dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription):
  • dom/ExceptionCode.h:
  • storage/IDBDatabaseError.h: (WebCore::IDBDatabaseError::code):
  • storage/IDBDatabaseException.h: (WebCore::IDBDatabaseException::create): (WebCore::IDBDatabaseException::ErrorCodeToExceptionCode): (WebCore::IDBDatabaseException::IDBDatabaseException):
  • storage/IDBDatabaseException.idl:
4:15 AM BuildingGtk edited by kov@webkit.org
(diff)
4:09 AM Changeset in webkit [73604] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-12-09 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix 'make install' woes with some versions of automake.

  • GNUmakefile.am: use $(top_builddir) instead of $(builddir), since we actually want a valid path for the file regardless of the place from where the script is called.
3:18 AM Changeset in webkit [73603] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-12-09 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Build fix for GTK+3. Use functions added for GTK+ 2.24 to get the
GDK window size.

  • plugins/gtk/gtk2xtbin.c: (gtk_xtbin_realize):
3:12 AM Changeset in webkit [73602] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-09 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

Use BUILDING_WEBKIT like other ports
​https://bugs.webkit.org/show_bug.cgi?id=50713

  • WebCore.pro: Change BUILD_WEBKIT to BUILDING_WEBKIT

2010-12-09 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

Use BUILDING_WEBKIT like other ports
​https://bugs.webkit.org/show_bug.cgi?id=50713

  • Api/qwebkitglobal.h: change BUILD_WEBKIT to BUILDING_WEBKIT
3:12 AM Changeset in webkit [73601] by pfeldman@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2010-12-09 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rebaselined Chromium expectations.
Reverts r73518 and r73522.

  • platform/chromium-linux/fast/forms/placeholder-position-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added.
  • platform/chromium-mac/fast/forms/placeholder-position-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/placeholder-position-expected.png: Added.
  • platform/chromium-win/fast/forms/placeholder-position-expected.checksum: Added.
  • platform/chromium-win/fast/forms/placeholder-position-expected.png: Added.
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:07 AM Changeset in webkit [73600] by Philippe Normand
  • 2 edits in trunk

2010-12-09 Philippe Normand <​pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] configure: error out if video is enabled and gstreamer pkg-config check fails
​https://bugs.webkit.org/show_bug.cgi?id=50741

  • configure.ac:
2:41 AM Changeset in webkit [73599] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. Add Qt specific expected results for tests introduced in r73529.

  • platform/qt/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/qt/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
2:03 AM Changeset in webkit [73598] by Martin Robinson
  • 16 edits in trunk/LayoutTests

2010-12-09 Martin Robinson <​mrobinson@igalia.com>

Update GTK+ baselines after r73561.

  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
1:37 AM Changeset in webkit [73597] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2010-12-09 Philippe Normand <​pnormand@igalia.com>

Unreviewed, update test baselines as asked by MORITA Hajime.

[GTK] r73488 broke fast/dom/HTMLProgressElement/progress-element.html
​https://bugs.webkit.org/show_bug.cgi?id=50687

  • platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/gtk/Skipped:
12:09 AM Changeset in webkit [73596] by yutak@chromium.org
  • 10 edits in trunk/LayoutTests

2010-12-09 Yuta Kitamura <​yutak@chromium.org>

Unreviewed.

Chromium rebaselines for r73488.

  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.