⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 30, 2010:

8:02 PM Changeset in webkit [74821] by mihaip@chromium.org
  • 5 edits
    2 adds in trunk

2010-12-30 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
​https://bugs.webkit.org/show_bug.cgi?id=51728

Add implementation of the Mac WebThemeEngine that uses an NSScroller
to render top-level scrollbars. This makes them match the Mac port's
use of an NSScrollView, which means that we'll be able to share more
pixel baselines.

The new rendering code will not be activated until the
USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
ScrollbarThemeChromiumMac.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestShellMac.mm: (platformInit):
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added. (+[FakeActiveWindow alwaysActiveWindow]): (+[FakeActiveWindow alwaysInactiveWindow]): (-[FakeActiveWindow initWithActiveControls:]): (-[FakeActiveWindow _hasActiveControls]): (WebThemeEngineDRTMac::paintScrollbarThumb): (stateToHIEnableState): (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb): (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):

2010-12-30 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
​https://bugs.webkit.org/show_bug.cgi?id=51728

Roll DEPS to pick up WebThemeEngine changes.

  • DEPS:
6:44 PM Changeset in webkit [74820] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2010-12-29 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Update validation of stencil mask and ref values
​https://bugs.webkit.org/show_bug.cgi?id=50716

  • fast/canvas/webgl/webgl-specific-expected.txt: Sync with khronos: refactor the test, also update the stencil setting test due to spec change.
  • fast/canvas/webgl/webgl-specific.html: Ditto.
5:53 PM Changeset in webkit [74819] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Skipping media/video-element-other-namespace-crash.html for chromium
since it uses codecs that chromium does not support.

  • platform/chromium/test_expectations.txt:
5:30 PM Changeset in webkit [74818] by zmo@google.com
  • 3 edits in trunk/WebCore

2010-12-29 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Update validation of stencil mask and ref values
​https://bugs.webkit.org/show_bug.cgi?id=50716

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): Initialize cached stencil settings. (WebCore::WebGLRenderingContext::drawArrays): Validate stencil settings. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::stencilFunc): Cache stencil settings, but generate no error. (WebCore::WebGLRenderingContext::stencilFuncSeparate): Ditto. (WebCore::WebGLRenderingContext::stencilMask): Ditto. (WebCore::WebGLRenderingContext::stencilMaskSeparate): Ditto. (WebCore::WebGLRenderingContext::validateStencilSettings): Helper function to validate stencil settings.
  • html/canvas/WebGLRenderingContext.h: Declare stencil setting members.

2010-12-29 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Update validation of stencil mask and ref values
​https://bugs.webkit.org/show_bug.cgi?id=50716

  • fast/canvas/webgl/webgl-specific-expected.txt: Sync with khronos: refactor the test, also update the stencil setting test due to spec change.
  • fast/canvas/webgl/webgl-specific.html: Ditto.
5:03 PM Changeset in webkit [74817] by Martin Robinson
  • 4 edits
    2 adds in trunk/WebCore

2010-12-30 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3
​https://bugs.webkit.org/show_bug.cgi?id=51755

Split out pieces of RenderThemeGtk into RenderThemeGtk2 and RenderThemeGtk3
if they are going to differ between GTK+ 2.x and GTK+ 3.x. This is the preliminary
step to landing support for the new GTK+ 3.x theming API.

No new tests. This should not change functionality.

  • GNUmakefile.am: Add RenderThemeGtk2 and RenderThemeGtk3 to the sources list.
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the setTextInputBorders static method. (WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto. (WebCore::RenderThemeGtk::paintMediaButton): Ditto. (WebCore::RenderThemeGtk::adjustProgressBarStyle): ditto.
  • platform/gtk/RenderThemeGtk.h: Make setTextInputBorders a method, so that it can be exist in RenderThemeGtk{2,3} and be called from RenderThemeGtk.
  • platform/gtk/RenderThemeGtk2.cpp: Added. A fork of the bits of RenderThemeGtk that will eventually be platform-dependent.
  • platform/gtk/RenderThemeGtk3.cpp: Added. Ditto.
4:50 PM Changeset in webkit [74816] by jschuh@chromium.org
  • 5 edits
    2 adds in trunk

2010-12-30 Justin Schuh <​jschuh@chromium.org>

Reviewed by James Robinson.

Reverting r74292 because it introduced a crash with ruby text.
​https://bugs.webkit.org/show_bug.cgi?id=51637

Test: fast/css/counters/counter-ruby-text-cleared.html

  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addChild):
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode):

2010-12-30 Justin Schuh <​jschuh@chromium.org>

Reviewed by James Robinson.

Check for crash when deleting ruby text with counters.
​https://bugs.webkit.org/show_bug.cgi?id=51637

  • fast/css/counters/counter-ruby-text-cleared-expected.txt: Added.
  • fast/css/counters/counter-ruby-text-cleared.html: Added.
4:39 PM Changeset in webkit [74815] by Patrick Gansterer
  • 3 edits in trunk/JavaScriptCore

2010-12-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Ariya Hidayat.

[CMake] Add WTF_HEADERS
​https://bugs.webkit.org/show_bug.cgi?id=51741

Add the WTF headers to show them in Visual Studio.

  • wtf/CMakeLists.txt:
  • wtf/CMakeListsWinCE.txt:
4:24 PM Changeset in webkit [74814] by Darin Adler
  • 7 edits
    2 deletes in trunk/WebCore

2010-12-30 Darin Adler <Darin Adler>

Reviewed by David Kilzer.

Remove unused JSBinding source files
​https://bugs.webkit.org/show_bug.cgi?id=51762

  • bindings/js/JSBinding.h: Removed.
  • bindings/js/specialization: Removed.
  • bindings/js/specialization/JSBindingState.cpp: Removed.
  • bindings/js/specialization/JSBindingState.h: Removed.
  • CMakeLists.txt: Removed references to files.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
3:47 PM Changeset in webkit [74813] by commit-queue@webkit.org
  • 7 edits in trunk

2010-12-30 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by David Kilzer.

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
​https://bugs.webkit.org/show_bug.cgi?id=51672

  • WebKit.pri: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1

2010-12-30 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by David Kilzer.

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
​https://bugs.webkit.org/show_bug.cgi?id=51672

  • wtf/wtf.pri: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1

2010-12-30 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by David Kilzer.

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
​https://bugs.webkit.org/show_bug.cgi?id=51672

  • DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1
  • WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1
3:41 PM Changeset in webkit [74812] by tonyg@chromium.org
  • 13 edits in trunk/WebCore

2010-12-30 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Adler.

Remove Document.h include from some headers where it isn't necessary
​https://bugs.webkit.org/show_bug.cgi?id=51730

No new tests because no new functionality.

  • editing/EditingStyle.cpp:
  • editing/EditingStyle.h:
  • editing/SelectionController.h:
  • editing/visible_units.h:
  • html/HTMLAudioElement.h:
  • html/HTMLBodyElement.h:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.h:
  • xml/DOMParser.cpp:
  • xml/DOMParser.h: (WebCore::DOMParser::create): (WebCore::DOMParser::DOMParser):
3:30 PM Changeset in webkit [74811] by Laszlo Gombos
  • 2 edits in trunk/Tools

2010-12-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by David Kilzer.

[Qt] [Symbian] Fix build-webkit script for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=51509

Set the OUTPUT_DIR for Symbian to be the same as the source
directory.

  • Scripts/webkitdirs.pm:
1:55 PM Changeset in webkit [74810] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-12-30 Benjamin C Meyer <​bmeyer@rim.com>

Reviewed by Darin Adler.

bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
which is required when NOTIFICATIONS is enabled.

​https://bugs.webkit.org/show_bug.cgi?id=51761

  • CMakeLists.txt:
1:46 PM Changeset in webkit [74809] by Martin Robinson
  • 3 edits in trunk/Tools

2010-12-30 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Darin Adler.

check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
​https://bugs.webkit.org/show_bug.cgi?id=51758

Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.

  • Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
12:59 PM Changeset in webkit [74808] by Antti Koivisto
  • 2 edits in trunk/WebCore

Not reviewed.

Revert accidental project file change.

  • WebCore.xcodeproj/project.pbxproj:
12:57 PM Changeset in webkit [74807] by Antti Koivisto
  • 11 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=51134
Move loading related code from MemoryCache to CachedResourceLoader

Reviewed by Darin Adler.

  • Merge MemoryCache::requestResource to CachedResourceLoader::requestResource
  • Merge MemoryCache::requestUserCSSStyleSheet to CachedResourceLoader::requestUserCSSStyleSheet
  • Move MemoryCache::revalidateResource to CachedResourceLoader::revalidateResource
  • Add MemoryCache::add
  • Refactor the decision on whether to reload, revalidate or use the existing resource to a single function, CachedResourceLoader::determineRevalidationPolicy
  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
if ever taken (since it passes null CachedResourceLoader pointer).


  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):

Moved tests that were not about cache headers to CachedResourceLoader::determineRevalidationPolicy and renamed.


(WebCore::CachedResource::setLoadPriority):

Check for Unresolved value before setting.


  • loader/cache/CachedResource.h:

(WebCore::CachedResource::setOwningCachedResourceLoader):

Rename to be bit less mysterious.


  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):

This was moved from MemoryCache.


(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):

This was moved/merged from MemoryCache.


(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):

This combines MemoryCache::requestResource and the existing method.


(WebCore::CachedResourceLoader::revalidateResource):

This was moved from MemoryCache.


(WebCore::CachedResourceLoader::loadResource):

New method for initiating loading.


(WebCore::CachedResourceLoader::notifyLoadedFromMemoryCache):

Renamed the mysterious CachedResourceLoader::checkCacheObjectStatus


  • loader/cache/CachedResourceLoader.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::add):

  • loader/cache/MemoryCache.h:

(WebCore::MemoryCache::remove):

12:53 PM Changeset in webkit [74806] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-12-30 Steve Block <​steveblock@google.com>

Reviewed by Gavin Barraclough.

Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
​https://bugs.webkit.org/show_bug.cgi?id=51740

This is a policy decision for Android.

No new tests, simply enabling existing, tested code on Android.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
12:29 PM Changeset in webkit [74805] by mihaip@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-12-30 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium baseline update.

[Chromium] svg/dom/length-list-parser.html fails on Chromium Linux after r74788 and r74803
​https://bugs.webkit.org/show_bug.cgi?id=51759

r74803 added chromium-win baselines for svg/dom/length-list-parser.html
but chromium-linux shouldn't use them (despite having them in its
fallback path). Copy the base expectations into chromium-linux.

  • platform/chromium-linux/svg/dom/length-list-parser-expected.txt: Added.
12:21 PM Changeset in webkit [74804] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Mark a few inspector tests as slow, they occasionally time out with
debug builds.

  • platform/chromium/test_expectations.txt:
11:40 AM Changeset in webkit [74803] by jschuh@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-12-30 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

chromium test expectations after r74788 for svg/dom/length-list-parser.html

  • platform/chromium-win/svg/dom/length-list-parser-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:34 AM Changeset in webkit [74802] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-12-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Use OS(WINDOWS) instead of COMPILER(MSVC) in FastMalloc.cpp
​https://bugs.webkit.org/show_bug.cgi?id=51743

Most of the ifdefs belong to windows and not to the MSVC compiler.

  • wtf/FastMalloc.cpp:
11:31 AM Changeset in webkit [74801] by yael.aharon@nokia.com
  • 6 edits
    2 adds in trunk

REGRESSION: fast/dom/cssTarget-crash.html fails
​https://bugs.webkit.org/show_bug.cgi?id=20342

Reviewed by Adam Barth.

WebCore:

Do not reload the page when submitting a form, using "GET" method, and the
form action url matches the location url, except for the fragment.

Test: fast/forms/submit-change-fragment.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::shouldScrollToAnchor):

  • loader/FrameLoader.h:

LayoutTests:

  • fast/forms/submit-change-fragment-expected.txt: Added.
  • fast/forms/submit-change-fragment.html: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
11:27 AM Changeset in webkit [74800] by Darin Adler
  • 13 edits in trunk/WebCore

2010-12-30 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move security logic out of the JavaScript binding for location into the DOM class
​https://bugs.webkit.org/show_bug.cgi?id=51714

  • WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h, and JSBinding.h. Later, we'll remove them from other project files and delete the source files.
  • bindings/js/JSBinding.h: Emptied out, marked for later deletion.
  • bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL function, unused toLexicalFrame function, unused completeURL function, unused getCachedDOMStructure and cacheDOMStructure overloads, and unused getCachedDOMConstructor and cacheDOMConstruction functions. (WebCore::activeDOMWindow): Added. (WebCore::firstDOMWindow): Added. (WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through JSBindingState, since the latter is an unneeded abstraction. (WebCore::processingUserGesture): Changed to call ScriptController's function rather than calling through JSBindingState, which is an unneeded abstraction
  • bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly named allowsAccessFromFrame functions, which answer the question of whether script is allowed access *to* a frame.
  • bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes. (WebCore::JSDOMWindow::setLocation): Streamlined by using the new activeDOMWindow and firstDOMWindow functions. (WebCore::JSDOMWindow::open): Ditto. (WebCore::JSDOMWindow::showModalDialog): Ditto. (WebCore::JSDOMWindow::postMessage): Ditto.
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): Changed to pass the active and first windows through to the Location::setHref function, with it doing the rest of the work. This moves work out of the DOM binding that belongs in the DOM itself. Eventually such functions could even be automatically generated by the bindings script. (WebCore::JSLocation::setProtocol): Ditto. (WebCore::JSLocation::setHost): Ditto. (WebCore::JSLocation::setHostname): Ditto. (WebCore::JSLocation::setPort): Ditto. (WebCore::JSLocation::setPathname): Ditto. (WebCore::JSLocation::setSearch): Ditto. (WebCore::JSLocation::setHash): Ditto. (WebCore::JSLocation::replace): Ditto. (WebCore::JSLocation::reload): Ditto. (WebCore::JSLocation::assign): Ditto.
  • bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
  • bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us to use this function for Location::replace, which is the same as setLocation except that it locks both history and the back/forward list.
  • page/DOMWindow.h: Ditto.
  • page/Location.cpp: (WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security logic there does not have to be repeated or even refactored. (WebCore::Location::setProtocol): Ditto. (WebCore::Location::setHost): Ditto. (WebCore::Location::setHostname): Ditto. (WebCore::Location::setPort): Ditto. (WebCore::Location::setPathname): Ditto. (WebCore::Location::setSearch): Ditto. (WebCore::Location::setHash): Ditto. (WebCore::Location::assign): Ditto. (WebCore::Location::replace): Ditto. (WebCore::Location::reload): Added. Security logic was refactored from the code in JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems possibly unneeded.
  • page/Location.h: Fixed indentation on the whole file. Added the new functions above. (WebCore::Location::create): (WebCore::Location::frame):
9:26 AM Changeset in webkit [74799] by apavlov@chromium.org
  • 3 edits in trunk/WebCore

2010-12-30 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Pasting a style property with value should automatically split it into prop/value
​https://bugs.webkit.org/show_bug.cgi?id=51581

The "paste" DOM event is handled for the CSS property name field to parse out the name and value parts
of a CSS property being pasted (by the first ':' found). The property is committed (if not a new one),
and the edit focus is transferred to the value field.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.selectElement): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.js: (WebInspector.completeURL): Drive-by: return full URLs as-is. (WebInspector.startEditing.cleanUpAfterEditing): (WebInspector.startEditing): (WebInspector.startEditing.pasteEventListener): (WebInspector.startEditing.keyDownEventListener):
7:32 AM Changeset in webkit [74798] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-12-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
​https://bugs.webkit.org/show_bug.cgi?id=51745

  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set enabled):
7:28 AM Changeset in webkit [74797] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-12-30 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: call stack shows "Paused on a JavaScript breakpoint" when stepping.
​https://bugs.webkit.org/show_bug.cgi?id=51748

  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts): (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
5:11 AM Changeset in webkit [74796] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-30 Philippe Normand <​pnormand@igalia.com>

Unreviewed, unskip the test, it's running fine locally.

media/audio-delete-while-slider-thumb-clicked.html fails
​https://bugs.webkit.org/show_bug.cgi?id=37546

  • platform/gtk/Skipped:
5:04 AM Changeset in webkit [74795] by mnaganov@chromium.org
  • 6 edits
    1 copy in trunk/WebCore

2010-12-30 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Fix leak of MemoryInfo wrappers introduced in r57004 (see issue 51712).

​https://bugs.webkit.org/show_bug.cgi?id=51713

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::memoryAccessorGetter):
  • bindings/v8/custom/V8PerformanceCustom.cpp: Copied from V8ConsoleCustom.cpp. (WebCore::V8Performance::memoryAccessorGetter):
  • page/Console.idl:
  • page/Performance.idl:
3:32 AM Changeset in webkit [74794] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-12-30 Steve Block <​steveblock@google.com>

Reviewed by Sam Weinig.

Visiting macnn.com often causes SQL spew via geolocation database
​https://bugs.webkit.org/show_bug.cgi?id=51557

If the Geolocation position cache database path has not been set, early-out
rather than using an empty path and thus failing to open the database.
This avoids SQL log spew.

Also, avoid starting the database thread until the path has been set, and
shorten the thread name to avoid warnings due to exceeding 30 characters.

No new tests, implementation clean-up only.

  • page/GeolocationPositionCache.cpp: (WebCore::GeolocationPositionCache::addUser): (WebCore::GeolocationPositionCache::removeUser): (WebCore::GeolocationPositionCache::setDatabasePath): (WebCore::GeolocationPositionCache::startBackgroundThread):
3:02 AM Changeset in webkit [74793] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-30 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skipping another editing flacky test.

  • platform/gtk/Skipped: skip editing/selection/extend-by-character-005.html.
2:17 AM Changeset in webkit [74792] by Philippe Normand
  • 8 edits in trunk

2010-12-29 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] minimal build fails at link time due to missing sqlite3 symbols
​https://bugs.webkit.org/show_bug.cgi?id=51327

  • configure.ac: Error out if SQLite3 wasn't found while at least one of the features depending on it has been enabled.

WebCore:

Reviewed by Martin Robinson.

[GTK] minimal build fails at link time due to missing sqlite3 symbols
​https://bugs.webkit.org/show_bug.cgi?id=51327

Guard the code calling sqlite3 with the ENABLE(DATABASE) check.

No new tests, build fix only.

  • platform/sql/SQLiteAuthorizer.cpp:
  • platform/sql/SQLiteDatabase.cpp:
  • platform/sql/SQLiteFileSystem.cpp:
  • platform/sql/SQLiteStatement.cpp:
  • platform/sql/SQLiteTransaction.cpp:
1:29 AM Changeset in webkit [74791] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Shinichiro Hamaji <​shinichiro.hamaji@gmail.com>

Chromium test expectation update for svg/dom/length-list-parser.html

  • platform/chromium/test_expectations.txt:
1:25 AM Changeset in webkit [74790] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Shinichiro Hamaji <​shinichiro.hamaji@gmail.com>

Chromium test expectation update for media/video-element-other-namespace-crash.html

  • platform/chromium/test_expectations.txt:
1:18 AM WinCE edited by Patrick Gansterer
(diff)
12:29 AM Changeset in webkit [74789] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Skip media/video-element-other-namespace-crash.html, like other media tests on qt platform.

  • platform/qt/Skipped:
12:12 AM Changeset in webkit [74788] by jschuh@chromium.org
  • 5 edits in trunk

2010-12-30 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Prevent stringToLengthType() from skipping past end-of-string on invalid length unit.
​https://bugs.webkit.org/show_bug.cgi?id=51692

  • svg/SVGLength.cpp: (WebCore::stringToLengthType): (WebCore::SVGLength::setValueAsString):

2010-12-30 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Adding long float string to improve test coverage.
​https://bugs.webkit.org/show_bug.cgi?id=51692

  • svg/dom/length-list-parser.html:
  • svg/dom/length-list-parser-expected.txt:
12:02 AM Changeset in webkit [74787] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-30 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Seidel.

Create a helper function for finding descendent video elements for a node.
​https://bugs.webkit.org/show_bug.cgi?id=51696

Test: media/video-element-other-namespace-crash.html

  • html/MediaDocument.cpp: (WebCore::descendentVideoElement): helper function. (WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions. (WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.

2010-12-30 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that we do not crash when trying to find video elements in the media document.
​https://bugs.webkit.org/show_bug.cgi?id=51696

  • media/video-element-other-namespace-crash-expected.txt: Added.
  • media/video-element-other-namespace-crash.html: Added.

Dec 29, 2010:

11:55 PM Changeset in webkit [74786] by inferno@chromium.org
  • 4 edits in trunk/LayoutTests

2010-12-29 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Add 'PASS' to layout test since test failing on chromium due to empty expectations.
Filed webkit bug 51734 to track gtk test failure and skipping test for now.

  • fast/multicol/span/double-merge-anonymous-block-crash-expected.txt:
  • fast/multicol/span/double-merge-anonymous-block-crash.html:
  • platform/gtk/Skipped:
11:41 PM Changeset in webkit [74785] by pfeldman@chromium.org
  • 15 edits
    1 copy
    2 moves
    1 add
    2 deletes in trunk

2010-12-29 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
​https://bugs.webkit.org/show_bug.cgi?id=51707

This change brushes up storage agents + removes redundant InspectorBackend class.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::inspectorDOMAgent):
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: Removed.
  • inspector/InspectorBackend.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::setInjectedScriptSource): (WebCore::InspectorController::dispatchOnInjectedScript): (WebCore::InspectorController::releaseWrapperObjectGroup):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMStorageAgent.cpp: Added. (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries): (WebCore::InspectorDOMStorageAgent::setDOMStorageItem): (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  • inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDOMStorageAgent::create): (WebCore::InspectorDOMStorageAgent::frontend):
  • inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp. (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  • inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDatabaseAgent::create): (WebCore::InspectorDatabaseAgent::frontend):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
11:20 PM Changeset in webkit [74784] by Patrick Gansterer
  • 2 edits in trunk/Tools

2010-12-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE buildfix.

  • WinCELauncher/main.cpp: Add missing include.
11:00 PM Changeset in webkit [74783] by krit@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-12-29 Dirk Schulze <​krit@webkit.org>

Unreviewed fix of the misspelled email address in commit 74782.

10:49 PM Changeset in webkit [74782] by krit@webkit.org
  • 32 edits in trunk/WebCore

2010-12-29 Dirk Schulze <​krit@wbekit.org>

Reviewed by Darin Adler.

Cleanup SVG code according to the webkit style rules 3
​https://bugs.webkit.org/show_bug.cgi?id=51490

Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
Just one file can't be fixed for check-webkit-style.

  • SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning

No changes of functionality, so no new tests.

  • svg/SVGAllInOne.cpp:
  • svg/SVGImage.cpp:
  • svg/SVGLength.cpp: (WebCore::SVGLength::setValue):
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.h:
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::transformRect):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport):
  • svg/SVGSetElement.h:
  • svg/SVGStylable.h: (WebCore::SVGStylable::~SVGStylable):
  • svg/SVGStyledLocatableElement.h: (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform): (WebCore::SVGStyledLocatableElement::isStyledLocatable):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::isKnownAttribute):
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::childShouldCreateRenderer):
  • svg/SVGTests.cpp: (WebCore::SVGTests::parseMappedAttribute):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::isKnownAttribute):
  • svg/SVGTextPathElement.cpp:
  • svg/SVGTextPathElement.h:
  • svg/SVGTitleElement.h: (WebCore::SVGTitleElement::rendererIsNeeded):
  • svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::scaledDistance): (WebCore::SVGTransformDistance::addSVGTransforms): (WebCore::SVGTransformDistance::addSVGTransform): (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::isZero):
  • svg/SVGTransformList.cpp:
  • svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
  • svg/SVGVKernElement.h:
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
  • svg/SVGZoomAndPan.h: (WebCore::SVGZoomAndPan::SVGZoomAndPan): (WebCore::SVGZoomAndPan::~SVGZoomAndPan): (WebCore::SVGZoomAndPan::zoomAndPan):
  • svg/SVGZoomEvent.h: (WebCore::SVGZoomEvent::create):
  • svg/animation/SMILTime.cpp: (WebCore::operator*):
  • svg/animation/SMILTime.h: (WebCore::SMILTime::SMILTime): (WebCore::SMILTime::unresolved): (WebCore::SMILTime::indefinite): (WebCore::SMILTime::operator=): (WebCore::SMILTime::value): (WebCore::SMILTime::isFinite): (WebCore::SMILTime::isIndefinite): (WebCore::SMILTime::isUnresolved): (WebCore::operator==): (WebCore::operator!): new operator checks for 0 or infinite values. (WebCore::operator!=): (WebCore::operator>): (WebCore::operator<): (WebCore::operator>=): (WebCore::operator<=):
  • svg/animation/SMILTimeContainer.h: (WebCore::SMILTimeContainer::create): (WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
  • svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::operator==): (WebCore::SVGSMILElement::repeatingDuration): (WebCore::SVGSMILElement::resolveInterval): (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
  • svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::timeContainer): (WebCore::SVGSMILElement::intervalBegin): (WebCore::SVGSMILElement::intervalEnd): (WebCore::SVGSMILElement::previousIntervalBegin): (WebCore::SVGSMILElement::documentOrderIndex): (WebCore::SVGSMILElement::setDocumentOrderIndex):
  • svg/graphics/SVGImage.h: (WebCore::SVGImage::create): (WebCore::SVGImage::destroyDecodedData): (WebCore::SVGImage::decodedSize): (WebCore::SVGImage::frameAtIndex):
  • svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::create): (WebCore::SVGFilterBuilder::lastEffect): (WebCore::SVGFilterBuilder::getEffectReferences): (WebCore::SVGFilterBuilder::addBuiltinEffects):
10:36 PM Changeset in webkit [74781] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-29 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Adler.

ASSERT(oldchild->parent() == owner) fails.
​https://bugs.webkit.org/show_bug.cgi?id=50480

In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
assertion failure when removeChildNode executes on the child(equal to prev or next).
Fix a typo in canMergeContiguousAnonymousBlocks.

Test: fast/multicol/span/double-merge-anonymous-block-crash.html

  • rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next. (WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.

2010-12-29 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Adler.

Tests that we do not crash when merging anonymous blocks.
​https://bugs.webkit.org/show_bug.cgi?id=50480

  • fast/multicol/span/double-merge-anonymous-block-crash-expected.txt: Added.
  • fast/multicol/span/double-merge-anonymous-block-crash.html: Added.
10:03 PM Changeset in webkit [74780] by dbates@webkit.org
  • 3 edits
    1 add in trunk/Tools

2010-12-29 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

svn-apply updates date of wrong change log entry for a change log diff that
contains two consecutive entries with the same author and date
​https://bugs.webkit.org/show_bug.cgi?id=46061

Fixes an issue where the date of the wrong change log entry may be modified.
Moreover, changes fixChangeLogPatch() to move entries inserted earlier
in a ChangeLog file to the top of the file.

Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
diff when it detects that the diff inserts a change log entry earlier in a
ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
change. With the advent of the commit-queue this functionality of bailing out
and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
Instead, we should always move the change log entry to the top of the ChangeLog file.

A side-effect of this change is that setChangeLogDateAndReviewer() now updates
the date line of the correct change log entry in a ChangeLog diff.

  • Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Updated the following unit tests now that we move entries inserted earlier to the top:
    • "fixChangeLogPatch: New entry inserted in middle." (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
  • "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date." (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
9:43 PM Changeset in webkit [74779] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-29 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Check SVG element type in FrameView::scrollToAnchor
​https://bugs.webkit.org/show_bug.cgi?id=51718

Test: svg/custom/scroll-to-anchor-in-symbol.svg

  • page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):

2010-12-29 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Check SVG element type in FrameView::scrollToAnchor
​https://bugs.webkit.org/show_bug.cgi?id=51718

  • svg/custom/scroll-to-anchor-in-symbol-expected.txt: Added.
  • svg/custom/scroll-to-anchor-in-symbol.svg: Added.
8:07 PM Changeset in webkit [74778] by antonm@chromium.org
  • 3 edits in trunk/WebCore

2010-12-29 Anton Muhin <​antonm@chromium.org>

Reviewed by Eric Seidel.

[v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
​https://bugs.webkit.org/show_bug.cgi?id=51704

  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
7:54 PM Changeset in webkit [74777] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2010-12-29 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

drawElements should raise INVALID_OPERATION if offset is not a multiple of the type size
​https://bugs.webkit.org/show_bug.cgi?id=51726

  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-elements-out-of-bounds.html: Add test cases to verify the behavior.
7:16 PM Changeset in webkit [74776] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2010-12-29 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by Eric Seidel.

[Qt] Fixed compatibility with gold linker on X11 platforms
​https://bugs.webkit.org/show_bug.cgi?id=51700

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Linked TestNetscapePlugin with libX11 on Unix platforms
7:16 PM Changeset in webkit [74775] by commit-queue@webkit.org
  • 7 edits in trunk/WebCore

2010-12-29 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Darin Adler.

Use a HashMap for m_continuation to save memory
​https://bugs.webkit.org/show_bug.cgi?id=43716

Saving memory consumption by applying a HashMap convention to
continuation pointers of RenderInline and RenderBlock classes.

  • rendering/RenderBlock.cpp: Removed m_continuation. (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::inlineElementContinuation): (WebCore::RenderBlock::blockElementContinuation):
  • rendering/RenderBlock.h: Removed m_continuation.
  • rendering/RenderBoxModelObject.cpp: Added a hash map for continuations. (WebCore::RenderBoxModelObject::destroy): Added an assertion. (WebCore::RenderBoxModelObject::continuation): Added. (WebCore::RenderBoxModelObject::setContinuation): Added.
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderInline.cpp: Removed m_continuation. (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::destroy): (WebCore::RenderInline::inlineElementContinuation):
  • rendering/RenderInline.h: Removed m_continuation.
6:08 PM Changeset in webkit [74774] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2010-12-29 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Darin Adler.

Circular dependency in webkitpy.common.checkout.changelog module
​https://bugs.webkit.org/show_bug.cgi?id=50475

Remove automatic import of api.Checkout module when any checkout/
submodule is imported (e.g.: when checkout.scm.Git is imported).

  • Scripts/webkitpy/common/checkout/init.py:
5:16 PM Changeset in webkit [74773] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove failing expectations for three Mac tests that no longer fail.
Remove failing expectations for two canvas tests that no longer crash
(r74561, which caused the failing assert, was rolled out with r74587).

  • platform/chromium/test_expectations.txt:
5:05 PM Changeset in webkit [74772] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.
fast/js/numeric-escapes-in-string-literals.html fails because V8 does
not support ECMAScript strict mode.

  • platform/chromium/test_expectations.txt:
5:00 PM Changeset in webkit [74771] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark two more inspector tests
as flaky.

  • platform/chromium/test_expectations.txt:
4:44 PM Changeset in webkit [74770] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark a few more tests as flaky.

  • platform/chromium/test_expectations.txt:
4:14 PM Changeset in webkit [74769] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

fast/canvas/shadow-offset-* are flaky when run in the GPU suite too.

  • platform/chromium-gpu/test_expectations.txt:
4:11 PM Changeset in webkit [74768] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Make expectation for http/tests/media/reload-after-dialog.html not
trigger a duplication error for the debug Linux builder.

Remove expectation for platform/gtk/fast/text/emphasis-overlap.html, it
was removed in r74346.

  • platform/chromium/test_expectations.txt:
4:00 PM Changeset in webkit [74767] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

Bug 51724 - In strict mode string literals should allow \0, but disallow \8 and \9.

Reviewed by Sam Weinig.

JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::Lexer::parseString):

LayoutTests:

  • fast/js/numeric-escapes-in-string-literals-expected.txt: Added.
  • fast/js/numeric-escapes-in-string-literals.html: Added.
  • fast/js/script-tests/numeric-escapes-in-string-literals.js: Added.

(test):

3:46 PM Changeset in webkit [74766] by Martin Robinson
  • 8 edits
    2 adds in trunk

2010-12-27 Amruth Raj <​amruthraj@motorola.com> and Ravi Kasibhatla <​ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] Enable building whatever already exists of WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=37369

No new functionality added or deleted. Only makefile change. Hence, no tests added.

  • GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and added them to WebKit/gtk/GNUmakefile.am
  • platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h> and declare WEBKIT_API directly

2010-12-15 Amruth Raj <​amruthraj@motorola.com> and Ravi Kasibhatla <​ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] Enable building whatever already exists of WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=37369

  • GNUmakefile.am: Added.
  • WebKit2Prefix.h: Included WebCore/config.h for GTK port as the first header file for WebKit2 sources files.
  • gtk: Added.
  • gtk/webkit2.pc.in: Added.
2:58 PM Changeset in webkit [74765] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-12-29 Martin Robinson <​mrobinson@igalia.com>

Build fix for GTK+.

  • webkit/webkitwebinspector.cpp: Add missing DumpRenderTreeSupportGtk include.
2:57 PM Changeset in webkit [74764] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-12-29 Eric Seidel <​eric@webkit.org>

Unreviewed.

Simplify make-hash-tools.pl
​https://bugs.webkit.org/show_bug.cgi?id=49922

Added HashTools.h to the project file now that its not autogenerated.
I also sorted the project file using sort-xcode-project-file

  • WebCore.xcodeproj/project.pbxproj:
2:56 PM Changeset in webkit [74763] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark another test as flaky.

  • platform/chromium/test_expectations.txt:
2:34 PM Changeset in webkit [74762] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-12-29 Martin Robinson <​mrobinson@igalia.com>

[GTK] GSettings warning is concealing real warnings on the build bots
​https://bugs.webkit.org/show_bug.cgi?id=51691

Reviewed by Xan Lopez.

Do not print the GSettings warning message when running in DumpRenderTree.

  • webkit/webkitwebinspector.cpp: (inspectorGSettings): Do not print the GSettings warning if we are running in DumpRenderTree. This should clean up the test results page a great deal.
2:22 PM Changeset in webkit [74761] by pfeldman@chromium.org
  • 15 edits
    1 copy
    2 moves
    1 add
    2 deletes in trunk

2010-12-29 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: revert r74755 and 74757.

2:20 PM Changeset in webkit [74760] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-12-29 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Sam Weinig.

JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
​https://bugs.webkit.org/show_bug.cgi?id=51722

Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
methods the fastcall calling convention, which leads to runtime errors when they are
called from C++. Also remove a bit of unnecessary code duplication.

No new tests. This is covered by fast/canvas/webgl/data-view-test.html.

  • bindings/js/JSDataViewCustom.cpp: (WebCore::getDataViewMember): Remove duplicated code. (WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL. (WebCore::JSDataView::getUint8): Ditto. (WebCore::JSDataView::getFloat32): Ditto. (WebCore::JSDataView::getFloat64): Ditto. (WebCore::setDataViewMember): Remove duplicated code. (WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL. (WebCore::JSDataView::setUint8): Ditto.
2:18 PM Changeset in webkit [74759] by mitz@apple.com
  • 5 edits in trunk/WebCore

A more robust fix for ​https://bugs.webkit.org/show_bug.cgi?id=51681

Reviewed by Kenneth Russel.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::attach): Added. Like recalcStyle(), calls
CanvasRenderingContext2D::updateFont() if necessary. This covers the case of a detach/
attach-type style recalc.

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the early return added in
r74716. A font that is loading custom fonts is okay to use, as long as it is valid.
(WebCore::CanvasRenderingContext2D::accessFont): Added a call to
Document::updateStyleIfNeeded(). This ensures that any pending style recalc will take place
and update the font if it is invalid.

  • platform/graphics/Font.h:

(WebCore::Font::loadingCustomFonts): Made this private.

1:43 PM Changeset in webkit [74758] by mihaip@chromium.org
  • 3 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

fast/canvas/webgl/tex-image-with-format-and-type.html is flaky in
the GPU suite too.

  • platform/chromium/test_expectations.txt:
  • platform/chromium-gpu/test_expectations.txt:
1:39 PM Changeset in webkit [74757] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-12-29 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Qt build fix.

  • inspector/InspectorController.cpp:
1:38 PM Changeset in webkit [74756] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove failure expectations for tests that no longer fail:

  • fast/images/svg-as-background.html has not timed out for as long as the flakiness dashboard has history
  • svg/W3C-SVG-1.1/animate-elem-03-t.svg has not failed for as long as the flakiness dashboard has history
  • platform/chromium/test_expectations.txt:
1:30 PM Changeset in webkit [74755] by pfeldman@chromium.org
  • 15 edits
    1 copy
    2 moves
    1 add
    2 deletes in trunk

2010-12-29 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract Database & DOM Storage
agents; remove InspectorBackend.
​https://bugs.webkit.org/show_bug.cgi?id=51707

This change brushes up storage agents + removes redundant
InspectorBackend class.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::inspectorDOMAgent):
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: Removed.
  • inspector/InspectorBackend.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::setInjectedScriptSource): (WebCore::InspectorController::dispatchOnInjectedScript): (WebCore::InspectorController::releaseWrapperObjectGroup):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMStorageAgent.cpp: Added. (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries): (WebCore::InspectorDOMStorageAgent::setDOMStorageItem): (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  • inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDOMStorageAgent::create): (WebCore::InspectorDOMStorageAgent::frontend):
  • inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp. (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  • inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDatabaseAgent::create): (WebCore::InspectorDatabaseAgent::frontend):
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show):
1:24 PM Changeset in webkit [74754] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.
Add recent upstream expectations Chromium changes.

  • platform/chromium/test_expectations.txt:
12:49 PM Changeset in webkit [74753] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.
Mark http/tests/incremental/split-hex-entities.pl as flaky.

  • platform/chromium/test_expectations.txt:
12:39 PM Changeset in webkit [74752] by tonyg@chromium.org
  • 3 edits
    5 adds in trunk

2010-12-29 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
​https://bugs.webkit.org/show_bug.cgi?id=51067

  • fast/dom/HTMLScriptElement/move-in-beforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/move-in-beforeload.html: Added.
  • fast/dom/HTMLScriptElement/remove-in-beforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/remove-in-beforeload.html: Added.

2010-12-29 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
​https://bugs.webkit.org/show_bug.cgi?id=51067

Typically when a script element is removed from the document, the cached script
client is removed. However, during the before load event, the cached script client
hasn't been created yet so it can't be removed.

This patch handles that case by explicitly checking if the script element was
removed during the beforeload event. Also, it avoids caching the Document references
over the arbitrary script execution in the before load event.

Test: fast/dom/HTMLScriptElement/move-in-beforeload.html

fast/dom/HTMLScriptElement/remove-in-beforeload.html

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::requestScript):
12:02 PM Changeset in webkit [74751] by mitz@apple.com
  • 4 edits in trunk/WebKit/mac

<rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
​https://bugs.webkit.org/show_bug.cgi?id=51717

Reviewed by Ada Chan.

Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.

  • WebView/WebDocumentInternal.h:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
(-[WebHTMLView _findString:options:]):

  • WebView/WebView.mm:

(findString):

11:20 AM Changeset in webkit [74750] by mihaip@chromium.org
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed, rolling out r74748.
​http://trac.webkit.org/changeset/74748

r74735 was rolled out with r74749, the expectations update
should be rolled out too

  • platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Added.
  • platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Added.
  • platform/chromium/fast/events/ime-composition-events-001-expected.txt: Removed.
11:13 AM Changeset in webkit [74749] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r74735.
​http://trac.webkit.org/changeset/74735
​https://bugs.webkit.org/show_bug.cgi?id=51715

assert failures on fast/forms/input-maxlength-ime-
completed.html (Requested by mihaip on #webkit).

  • platform/chromium/test_expectations.txt:

2010-12-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r74735.
​http://trac.webkit.org/changeset/74735
​https://bugs.webkit.org/show_bug.cgi?id=51715

assert failures on fast/forms/input-maxlength-ime-
completed.html (Requested by mihaip on #webkit).

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setMarkedText):
10:17 AM Changeset in webkit [74748] by mihaip@chromium.org
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium baselines. Update Chromium baselines for
fast/events/ime-composition-events-001.html after r74735 (the
new baselines are closer to the upstream Mac ones).

  • platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Removed.
  • platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Removed.
  • platform/chromium/fast/events/ime-composition-events-001-expected.txt: Added.
10:12 AM Changeset in webkit [74747] by mihaip@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium baselines. Add Chromium baselines for the
layout test added by r74743.

  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
10:03 AM Changeset in webkit [74746] by Martin Robinson
  • 2 edits in trunk/Tools

2010-12-29 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Ojan Vafai.

prepare-ChangeLog should support the -g option for specifying the git-commit
​https://bugs.webkit.org/show_bug.cgi?id=51708

Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
webkit-patch, though the exact meaning of the two options remain different.

  • Scripts/prepare-ChangeLog: Add -g.
10:01 AM Changeset in webkit [74745] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-12-29 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Element highlight tooltip displays wrong element size when zoomed in
​https://bugs.webkit.org/show_bug.cgi?id=51703

  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawElementTitle):
8:00 AM Changeset in webkit [74744] by yael.aharon@nokia.com
  • 16 edits
    9 adds in trunk

[HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
​https://bugs.webkit.org/show_bug.cgi?id=29071

Reviewed by Kent Tamura.

WebCore:

Use InputType::rangeUnderflow() and InputType::rangeOverflow()
to determine if a control is in-range or out-of-range.

Tests: fast/css/pseudo-in-range-invalid-value.html

fast/css/pseudo-in-range.html
fast/css/pseudo-out-of-range.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):

  • css/CSSSelector.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • dom/Element.h:

(WebCore::Element::isInRange):
(WebCore::Element::isOutOfRange):

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::supportsRangeLimitation):

  • html/BaseDateAndTimeInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isInRange):
(WebCore::HTMLInputElement::isOutOfRange):

  • html/HTMLInputElement.h:
  • html/InputType.cpp:

(WebCore::InputType::supportsRangeLimitation):

  • html/InputType.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::supportsRangeLimitation):

  • html/NumberInputType.h:
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::supportsRangeLimitation):

  • html/RangeInputType.h:

LayoutTests:

  • fast/css/pseudo-in-range-expected.txt: Added.
  • fast/css/pseudo-in-range-invalid-value-expected.txt: Added.
  • fast/css/pseudo-in-range-invalid-value.html: Added.
  • fast/css/pseudo-in-range.html: Added.
  • fast/css/pseudo-out-of-range-expected.txt: Added.
  • fast/css/pseudo-out-of-range.html: Added.
  • fast/css/script-tests/pseudo-in-range-invalid-value.js: Added.
  • fast/css/script-tests/pseudo-in-range.js: Added.
  • fast/css/script-tests/pseudo-out-of-range.js: Added.
7:50 AM Changeset in webkit [74743] by inferno@chromium.org
  • 3 edits
    4 adds in trunk

2010-12-29 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Seidel.

When cloning an anonymous block, make sure to set the childrenInline flag based
on the state of the block to be cloned.
​https://bugs.webkit.org/show_bug.cgi?id=51489

Test: fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clone): add code to handle cloning of anonymous blocks. (WebCore::RenderBlock::splitBlocks): remove anonymous block creation calls since it is now handled by clone().

2010-12-29 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that cloning an anonymous block with non inline children does not crash.
​https://bugs.webkit.org/show_bug.cgi?id=51489

  • fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
7:38 AM Changeset in webkit [74742] by Patrick Gansterer
  • 6 edits in trunk

2010-12-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix for WinCE after r73802.

Reapply parts from r72585:
Port ContextMenuWin.cpp to WinCE
​https://bugs.webkit.org/show_bug.cgi?id=48408

  • CMakeLists.txt:
  • platform/ContextMenu.h:
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::getContextMenuItems): (WebCore::ContextMenu::createNativeMenuFromItems):

2010-12-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix for WinCE after r73802.

  • WebCoreSupport/ContextMenuClientWinCE.cpp: (WebKit::ContextMenuClientWinCE::customizeMenu):
  • WebCoreSupport/ContextMenuClientWinCE.h:
5:39 AM Changeset in webkit [74741] by kent.hansen@nokia.com
  • 12 edits in trunk

2010-12-29 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with Qt in namespace
​https://bugs.webkit.org/show_bug.cgi?id=51701

  • QtTestBrowser/webview.h:

2010-12-29 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with Qt in namespace
​https://bugs.webkit.org/show_bug.cgi?id=51701

  • platform/graphics/ContextShadow.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/network/NetworkingContext.h:
  • platform/network/qt/QtNAMThreadSafeProxy.h:
  • plugins/PluginView.h:

2010-12-29 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with Qt in namespace
​https://bugs.webkit.org/show_bug.cgi?id=51701

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/InspectorServerQt.h:
  • tests/hybridPixmap/widget.h:
4:41 AM Fingerprinting edited by robert@roberthogan.net
(diff)
3:53 AM Changeset in webkit [74740] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-28 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: A disabled style property should get enabled when edited
​https://bugs.webkit.org/show_bug.cgi?id=51679

  • inspector/styles-disable-then-change-expected.txt: Added.
  • inspector/styles-disable-then-change.html: Added.

2010-12-28 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: A disabled style property should get enabled when edited
​https://bugs.webkit.org/show_bug.cgi?id=51679

Test: inspector/styles-disable-then-change.html

  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setText.callback):
3:35 AM Changeset in webkit [74739] by Patrick Gansterer
  • 4 edits in trunk

2010-12-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed. Use gcc as default preprocessor.

  • Sources/cmake/OptionsCommon.cmake:

2010-12-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Remove WebKitGenerators
​https://bugs.webkit.org/show_bug.cgi?id=50445

  • CMakeLists.txt: Pass preprocessor to generate-bindings.pl.
3:22 AM Changeset in webkit [74738] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2010-12-29 Juha Savolainen <​juha.savolainen@weego.fi>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] Added more webattributes to the qwkpreferences
​https://bugs.webkit.org/show_bug.cgi?id=51697

Added PrivateBrowsingEnabled, DeveloperExtrasEnabled, DnsPrefetchEnabled attributes

  • UIProcess/API/qt/qwkpreferences.cpp: (QWKPreferences::testAttribute): (QWKPreferences::setAttribute):
  • UIProcess/API/qt/qwkpreferences.h:
1:32 AM Changeset in webkit [74737] by commit-queue@webkit.org
  • 5 edits in trunk

2010-12-29 Helder Correia <​helder@sencha.com>

Reviewed by Eric Seidel.

<VT> and <FF> are not valid JSON whitespace characters
​https://bugs.webkit.org/show_bug.cgi?id=51671

Vertical Tab and Form Feed are not allowed white spaces by the JSON
RFC 4627: ​http://www.ietf.org/rfc/rfc4627.txt (2. JSON Grammar).

Tests: ietestcenter/Javascript/15.12.1.1-0-2.html

ietestcenter/Javascript/15.12.1.1-0-3.html

  • runtime/LiteralParser.cpp: (JSC::isJSONWhiteSpace): (JSC::LiteralParser::Lexer::lex):

2010-12-29 Helder Correia <​helder@sencha.com>

Reviewed by Eric Seidel.

<VT> and <FF> are not valid JSON whitespace characters
​https://bugs.webkit.org/show_bug.cgi?id=51671

Vertical Tab and Form Feed are not allowed white spaces by the JSON
RFC 4627: ​http://www.ietf.org/rfc/rfc4627.txt (2. JSON Grammar).

  • ietestcenter/Javascript/15.12.1.1-0-2-expected.txt:
  • ietestcenter/Javascript/15.12.1.1-0-3-expected.txt:
1:30 AM Changeset in webkit [74736] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-29 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip flaky test on GTK.

[GTK] editing/selection/extend-by-character-004.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=51699

  • platform/gtk/Skipped:
1:22 AM Changeset in webkit [74735] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-29 Zhe Su <​suzhe@chromium.org>

Reviewed by Eric Seidel.

Remove entry for editing/input/ime-composition-clearpreedit.html test.
​https://bugs.webkit.org/show_bug.cgi?id=51693

  • platform/chromium/test_expectations.txt:

2010-12-29 Zhe Su <​suzhe@chromium.org>

Reviewed by Eric Seidel.

Fix editing/input/ime-composition-clearpreedit.html test in chromium
by removing the line "editor->confirmComposition(text);" from
WebFrameImpl::setMarkedText() method, because that line will insert the
text into the focused node, which is apparently wrong.

​https://bugs.webkit.org/show_bug.cgi?id=51693

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setMarkedText):
Note: See TracTimeline for information about the timeline view.