Timeline
Jan 11, 2011:
- 11:57 PM Changeset in webkit [75588] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Fix typo in WebKit2 skipped list which was causing a test to not get skipped
https://bugs.webkit.org/show_bug.cgi?id=52277
- platform/mac-wk2/Skipped:
- 11:41 PM Changeset in webkit [75587] by
-
- 2 edits in trunk/Tools
2011-01-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Eric Seidel.
Close additional pages opened during a test once the test completes.
https://bugs.webkit.org/show_bug.cgi?id=52276
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
- 10:53 PM Changeset in webkit [75586] by
-
- 3 edits in trunk/Tools
2011-01-11 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Errors should be separated from the command line in bot messages.
https://bugs.webkit.org/show_bug.cgi?id=52275
- Scripts/webkitpy/common/system/executive.py: (ScriptError.message_with_output): Added a newline to separate the command line from the errors.
- Scripts/webkitpy/common/system/executive_unittest.py: (ScriptErrorTest.test_message_with_output): Added tests for the various code paths in message_with_output.
- 9:25 PM Changeset in webkit [75585] by
-
- 3 edits2 adds in trunk
2011-01-11 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Webkit crashes when a gradient is applied using the first-line pseudo element
https://bugs.webkit.org/show_bug.cgi?id=52225
When a pseudostyle references images, we fail to register/unregister
the relevant RenderObjects as clients of the image in the style.
For gradients, this caused a crash.
This patch fixes the crash by returning a null gradient image in this
situation.
Test: fast/gradients/gradient-on-pseudoelement-crash.html
- css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image):
- 7:35 PM Changeset in webkit [75584] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 Justin Schuh <jschuh@chromium.org>
Unreviewed chromium expectations update.
Windows exclusion for no-mime-with-valid-extension.html (from r75567)
- platform/chromium/test_expectations.txt:
- 7:20 PM Changeset in webkit [75583] by
-
- 5 edits in trunk/Tools
2011-01-11 Eric Seidel <eric@webkit.org>
Unreviewed.
commit-queue should know how to upload archived results (for test flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048
The zips are mostly empty due to forgetting -r.
Expected diffs were not being pulled from the archive due
to the archive having longer paths than I realized.
- Scripts/webkitpy/common/system/workspace.py:
- Scripts/webkitpy/common/system/workspace_unittest.py:
- Scripts/webkitpy/tool/bot/flakytestreporter.py:
- Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
- 6:38 PM Changeset in webkit [75582] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 Dirk Pranke <dpranke@chromium.org>
Unreviewed, fix typo in expectations file.
- platform/chromium-gpu/test_expectations.txt:
- 6:16 PM Changeset in webkit [75581] by
-
- 1 edit2 deletes in trunk/LayoutTests
2011-01-11 Nico Weber <thakis@chromium.org>
Unreviewed, test expectations.
Remove now-unnecessary xp-specific baseline.
https://bugs.webkit.org/show_bug.cgi?id=52105
- platform/chromium-win-xp/fast/gradients/radial-centered-expected.checksum: Removed.
- platform/chromium-win-xp/fast/gradients/radial-centered-expected.png: Removed.
- 5:57 PM Changeset in webkit [75580] by
-
- 2 edits in trunk/Source/WebCore
2011-01-11 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r71562): servePendingRequests() no longer called when
resources are done loading.
https://bugs.webkit.org/show_bug.cgi?id=52264
<rdar://problem/8767429>
In r71562, servePendingRequests() is no longer called in Loader's
didFinishLoading(), didFail() and didReceiveResponse() methods. Since
r71562 was intended only as a refactoring, these calls should be
restored. At least one WebKit-based Mac OS X application relies on this
for correct behavior.
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::loadDone): Call resourceLoadScheduler()->servePendingRequests().
- 5:36 PM Changeset in webkit [75579] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 Adrienne Walker <enne@google.com>
Unreviewed, test expectations update.
Revert expect change for Snow Leopard in r75570.
- platform/mac-snowleopard/Skipped:
- 5:28 PM Changeset in webkit [75578] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed; chromium test expectations update.
Remove failing expectations for tests that pass after r75569.
- platform/chromium/test_expectations.txt:
- 5:26 PM Changeset in webkit [75577] by
-
- 8 edits in trunk/Source/WebCore
2011-01-11 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
Add Document::setContent()
https://bugs.webkit.org/show_bug.cgi?id=52085
Add a method to Document to set the whole content at once.
This removes the hack of the insert method in the xml parser
and is a predecessor to feed the xml parser with raw data.
- dom/Document.cpp: (WebCore::Document::setContent):
- dom/Document.h:
- dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insert): Added ASSERT_NOT_REACHED().
- loader/cache/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData): Use setContent.
- xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString): Ditto.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Ditto.
- xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Ditto.
- 5:15 PM Changeset in webkit [75576] by
-
- 13 edits in trunk/Tools
2011-01-11 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
The current modifier parsing code in test_expectations is
fragile and hard-coded, so it's not easy to understand the logic
or easily add new types of modifiers (like GPU vs. CPU testing
for graphics tests, or 32-bit vs. 64-bit differences).
This is the first of two patches that will add in more generic
support and then eliminate the GPU-specific test expectations
files for Chromium.
This patch adds two standalone objects for handling modifiers. The
rules for interpreting modifiers, precedence, and conflicts are
given in the docstring to the ModifierMatcher class, which
returns ModifierMatchResult objects.
This patch also adds routines to the Port interface and a
default set of values in the base object, in order to obtain the
values needed on a given test run. These values are then passed
to the expectation parser. This also allows us to clean up the
logic used to lint all of the different configurations in a
single test_expectations.txt file.
The next patch will merge in the separate GPU expectations file.
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 4:56 PM Changeset in webkit [75575] by
-
- 5 edits in trunk/Tools
2011-01-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Make webkit-patch support subdirectories for SVN checkouts
https://bugs.webkit.org/show_bug.cgi?id=52261
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/style_references.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/steps/preparechangelog.py:
- 4:56 PM Changeset in webkit [75574] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 James Robinson <jamesr@chromium.org>
Update test to use layoutTestController.waitUntilDone()/notifyDone() since it relies on the scroll event which is now async.
- fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html:
- 4:53 PM Changeset in webkit [75573] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::addArc): Switch to MathExtra's piFloat define,
rather than M_PI which is not always available.
- 4:52 PM Changeset in webkit [75572] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed; chromium test expectations update.
Remove failing expectations for tests that pass after r75552.
- platform/chromium/test_expectations.txt:
- 4:43 PM Changeset in webkit [75571] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix difflink centering to be vertical, not horizontal
https://bugs.webkit.org/show_bug.cgi?id=52263
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 4:39 PM Changeset in webkit [75570] by
-
- 6 edits3 adds2 deletes in trunk/LayoutTests
2011-01-11 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Sync WebGL texImage2D video test from Khronos and re-enable it.
https://bugs.webkit.org/show_bug.cgi?id=44459
- fast/canvas/webgl/resources/quadrants.mp4: Removed.
- fast/canvas/webgl/resources/quadrants.ogv: Removed.
- fast/canvas/webgl/resources/red-green.mp4: Added.
- fast/canvas/webgl/resources/red-green.theora.ogv: Added.
- fast/canvas/webgl/resources/red-green.webmvp8.webm: Added.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html:
- platform/chromium-gpu/test_expectations.txt:
- platform/chromium/test_expectations.txt:
- platform/mac-snowleopard/Skipped:
- 4:36 PM Changeset in webkit [75569] by
-
- 8 edits38 adds2 deletes in trunk/LayoutTests
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed, new chromium-mac baselines.
Rebaseline after the scrollbar change (these tests still need
chromium-mac baselines since they have controls or images that render
slightly differently from the Mac port).
- platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
- platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum: Added.
- platform/chromium-mac/fast/block/margin-collapse/103-expected.png: Added.
- platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.checksum:
- platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-mac/fast/events/pointer-events-2-expected.checksum:
- platform/chromium-mac/fast/events/pointer-events-2-expected.png:
- platform/chromium-mac/fast/images/gif-large-checkerboard-expected.checksum: Removed.
- platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Removed.
- platform/chromium-mac/fast/replaced/width100percent-image-expected.checksum: Added.
- platform/chromium-mac/fast/replaced/width100percent-image-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
- platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
- platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug625-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png: Added.
- platform/chromium-mac/tables/mozilla/core/bloomberg-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png: Added.
- platform/chromium-mac/tables/mozilla/core/row_span-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/core/row_span-expected.png: Added.
- platform/chromium-mac/tables/mozilla/other/cell_widths-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/other/cell_widths-expected.png: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:33 PM Changeset in webkit [75568] by
-
- 2 edits in trunk/WebKit2
2011-01-11 Jeff Miller <jeffm@apple.com>
Reviewed by John Sullivan.
WebKit2: "Webpages not responding" dialog appears when <select> popup menu is showing
https://bugs.webkit.org/show_bug.cgi?id=52242
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showPopupMenu): On Windows, stop the responsiveness timer before calling showPopupMenu().
- 4:33 PM Changeset in webkit [75567] by
-
- 3 edits2 adds in trunk
2011-01-11 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Adam Barth.
Use plug-in DB for extensions to MIME type convertion
Plugins extension to MIME type conversion was not used in the
frameLoader. This was causing some fallback to be use which as the side
effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
This patch ensure that we try to convert the extension to MIME type
using the plugin database beofre using this fallback.
Attribute lost with Flash plugin without mime type set
https://bugs.webkit.org/show_bug.cgi?id=50657
- plugins/no-mime-with-valid-extension.html: Added.
- plugins/no-mime-with-valid-extension-expected.txt: Added.
2011-01-11 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Adam Barth.
Use plug-in DB for extensions to MIME type convertion
Plugins extension to MIME type conversion was not used in the
frameLoader. This was causing some fallback to be use which as the side
effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
This patch ensure that we try to convert the extension to MIME type
using the plugin database beofre using this fallback.
Attribute lost with Flash plugin without mime type set
https://bugs.webkit.org/show_bug.cgi?id=50657
Test: plugins/no-mime-with-valid-extension.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType): Use PluginDatabase for MIME
- 4:17 PM Changeset in webkit [75566] by
-
- 2 edits in trunk/WebKit2
2011-01-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
UIProcess kills the WebProcess sometimes when detached frames exist
https://bugs.webkit.org/show_bug.cgi?id=52227
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didSaveFrameToPageCache): Don't consider the message invalid if it came in for a detached frame.
- 3:56 PM Changeset in webkit [75565] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
remember diffstate for review tool
https://bugs.webkit.org/show_bug.cgi?id=52253
If you use the global sidebyside/unified links, store the diff type
in localstorage. Then, onload, use that diff type. That way, people
who prefer one diff type or the other can always get that by default.
- code-review.js:
- 3:44 PM Changeset in webkit [75564] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 Justin Schuh <jschuh@chromium.org>
Unreviewed, test expectations update.
Flaky expectations for textOnPath.svg.
- platform/chromium/test_expectations.txt:
- 3:41 PM Changeset in webkit [75563] by
-
- 2 edits in trunk/WebKit2
Build fix.
- WebKit2.xcodeproj/project.pbxproj:
- 3:40 PM Changeset in webkit [75562] by
-
- 2 edits2 adds in trunk/WebKit2
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a Region class which represents a graphical region
https://bugs.webkit.org/show_bug.cgi?id=52255
- Platform/Region.cpp: Added. (WebKit::Region::Region): (WebKit::Region::rects): (WebKit::Region::Shape::Shape): (WebKit::Region::Shape::appendSpan): (WebKit::Region::Shape::canCoalesce): (WebKit::Region::Shape::appendSpans): (WebKit::Region::Shape::appendSegment): (WebKit::Region::Shape::spans_begin): (WebKit::Region::Shape::spans_end): (WebKit::Region::Shape::segments_begin): (WebKit::Region::Shape::segments_end): (WebKit::Region::Shape::dump): (WebKit::Region::Shape::bounds): (WebKit::Region::Shape::move): (WebKit::Region::Shape::swap): (WebKit::Region::Shape::shapeOperation): (WebKit::Region::Shape::UnionOperation::trySimpleOperation): (WebKit::Region::Shape::unionShapes): (WebKit::Region::Shape::IntersectOperation::trySimpleOperation): (WebKit::Region::Shape::intersectShapes): (WebKit::Region::Shape::SubtractOperation::trySimpleOperation): (WebKit::Region::Shape::subtractShapes): (WebKit::Region::dump): (WebKit::Region::intersect): (WebKit::Region::unite): (WebKit::Region::subtract): (WebKit::Region::move):
- Platform/Region.h: Added. (WebKit::Region::bounds): (WebKit::Region::isEmpty): (WebKit::Region::Span::Span): (WebKit::Region::Shape::isEmpty):
- WebKit2.xcodeproj/project.pbxproj:
- 3:35 PM Changeset in webkit [75561] by
-
- 2 edits in trunk/WebKit/chromium
2011-01-11 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] copy test netscape plugin into TestNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=52232
- WebKit.gyp: Make a copy of the TestNetscapePlugIn in
TestNetscapePlugIn and WebKitTestNetscapePlugIn
- 3:19 PM Changeset in webkit [75560] by
-
- 16 edits in trunk
2011-01-11 James Simonsen <simonjam@chromium.org>
Reviewed by Eric Seidel.
[Web Timing] Rename sslHandshakeStart to secureConnectionStart
https://bugs.webkit.org/show_bug.cgi?id=52239
- fast/dom/Window/window-properties-performance-expected.txt:
- fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingOnDOMContentLoaded): (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
- fast/dom/webtiming-document-open-expected.txt:
- fast/dom/webtiming-expected.txt:
- fast/dom/webtiming-navigate-within-document-expected.txt:
- http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
- http/tests/misc/resources/webtiming-cross-origin-redirect.html:
- http/tests/misc/resources/webtiming-no-origin.html:
- http/tests/misc/resources/webtiming-ssl.html:
- http/tests/misc/webtiming-origins-expected.txt:
- http/tests/misc/webtiming-ssl-expected.txt:
2011-01-11 James Simonsen <simonjam@chromium.org>
Reviewed by Eric Seidel.
[Web Timing] Rename sslHandshakeStart to secureConnectionStart
https://bugs.webkit.org/show_bug.cgi?id=52239
- page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::secureConnectionStart):
- page/PerformanceTiming.h:
- page/PerformanceTiming.idl:
- 3:16 PM Changeset in webkit [75559] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
allow sidebysideifying individual files in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52226
- code-review.js:
- 2:58 PM Changeset in webkit [75558] by
-
- 9 edits1 add in trunk/WebKit2
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Add DidSetSize message
https://bugs.webkit.org/show_bug.cgi?id=52254
- DerivedSources.make: Add DrawingAReaProxy.messages.in.
- Platform/CoreIPC/MessageID.h: Add DrawingAreaProxy message class.
- UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::didSetSize): Add CoreIPC message handler function.
- UIProcess/DrawingAreaProxy.messages.in: Added.
- UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didSetSize): Add stub.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Handle DrawingAreaProxy messages.
- WebKit2.xcodeproj/project.pbxproj: Add new files.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Send a DidSetSize message for now.
- 2:53 PM Changeset in webkit [75557] by
-
- 5 edits in trunk/Source/WebCore
2011-01-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
This patch actually makes the display-isolated schemes display
isolated. The behavior should be the same as the previous iteration of
this patch, but re-organized a bit because reading the access white
list is expensive.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::isAccessToURLWhiteListed): (WebCore::SecurityOrigin::canDisplay):
- page/SecurityOrigin.h:
- platform/SchemeRegistry.cpp:
- platform/SchemeRegistry.h:
- 2:52 PM Changeset in webkit [75556] by
-
- 3 edits2 adds in branches/chromium/597
2011-01-11 Merge 75548 - BUGCR69275 - Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
RefPtr the FrameView to prevent scrollbar from getting deleted inside
its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238
Test: scrollbars/scrollable-iframe-remove-crash.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::scrollTo):
2011-01-11 Merge 75548 - Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that we do not crash when we remove scrollable iframe when executing
inside its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238
- scrollbars/scrollable-iframe-remove-crash-expected.txt: Added.
- scrollbars/scrollable-iframe-remove-crash.html: Added.
- 2:47 PM Changeset in webkit [75555] by
-
- 17 edits4 adds in trunk
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
Scroll event should be fired asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45631
Update existing tests that assumed that scroll events fired
synchronously.
- editing/input/page-up-down-scrolls-expected.txt:
- editing/input/page-up-down-scrolls.html:
- fast/events/fire-scroll-event-element-expected.txt: Copied from LayoutTests/fast/events/fire-scroll-event-expected.txt.
- fast/events/fire-scroll-event-element.html: Added. Does the same
tests as fire-scroll-event.html, but on an individual element instead
of the whole document.
- fast/events/fire-scroll-event-expected.txt:
- fast/events/fire-scroll-event.html: Now explicitly tests for
synchronous behavior when scrolling the document, and that we don't
fire the event more than once.
- fast/events/remove-child-onscroll.html:
- fast/events/scroll-during-zoom-change.html:
- fast/events/scroll-event-does-not-bubble.html:
- fast/events/scroll-event-phase-expected.txt: Added.
- fast/events/scroll-event-phase.html: Added. Checks that we can listen
for scroll events in both the capture and bubble phase.
- fast/layers/removed-by-scroll-handler.html:
- fast/overflow/onscroll-layer-self-destruct.html:
- fast/repaint/repaint-during-scroll.html:
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
Scroll event should be fired asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45631
Tests: fast/events/fire-scroll-event.html
fast/events/fire-scroll-event-element.html
fast/events/scroll-event-phase.html
Makes scroll events fire asynchronously to be in compliance with the
CSSOM View Module and consistent with Gecko, Opera and (to some degree)
IE.
Implemented via the EventQueue class added by r74062 (EventQueue now
has a convenience enqueueScrollEvent method).
- dom/EventQueue.cpp: (WebCore::EventQueue::enqueueScrollEvent): (WebCore::EventQueue::pendingEventTimerFired):
- dom/EventQueue.h:
- page/EventHandler.cpp: (WebCore::EventHandler::sendScrollEvent):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::valueChanged):
- 2:42 PM Changeset in webkit [75554] by
-
- 3 edits2 adds in branches/chromium/597
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
RefPtr text node in setOuterText since calling appendData
on a text node can fire away dom event listener which might
remove the text node from underneath.
https://bugs.webkit.org/show_bug.cgi?id=52163
Test: fast/dom/text-node-append-data-remove-crash.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterText):
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that calling append data on a text node which removes its
sibling text node does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=52163
- fast/dom/text-node-append-data-remove-crash-expected.txt: Added.
- fast/dom/text-node-append-data-remove-crash.html: Added.
- 2:16 PM Changeset in webkit [75553] by
-
- 5 edits3 deletes in trunk/WebKit/chromium
2011-01-11 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
[chromium] Move WebGraphicsContext3DDefaultImpl to Chromium repository
https://bugs.webkit.org/show_bug.cgi?id=52235
Deleted WebGraphicsContext3DDefaultImpl, which has been moved to
the Chromium repository under WebGraphicsContext3DInProcessImpl.
Removed WebGraphicsContext3D::createDefault(). Rolled forward
Chromium version to pick up needed changes.
Tested with build-webkit --chromium --debug and a run of the WebGL
layout tests in DRT.
- DEPS:
- WebKit.gyp:
- public/WebGraphicsContext3D.h:
- src/GraphicsContext3DChromium.cpp:
- src/WebGraphicsContext3D.cpp: Removed.
- src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
- src/WebGraphicsContext3DDefaultImpl.h: Removed.
- 2:03 PM Changeset in webkit [75552] by
-
- 10 edits7 adds in trunk/LayoutTests
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed; new and updated mac-leopard baselines.
Update stale or missing Leopard baselines (tests currently pass on Snow
Leopard).
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/editing/deleting/delete-line-end-ws-001-expected.checksum:
- platform/mac-leopard/editing/deleting/delete-line-end-ws-001-expected.png:
- platform/mac-leopard/editing/deleting/delete-line-end-ws-002-expected.checksum:
- platform/mac-leopard/editing/deleting/delete-line-end-ws-002-expected.png:
- platform/mac-leopard/fast/block/basic/016-expected.checksum: Added.
- platform/mac-leopard/fast/block/basic/016-expected.png: Added.
- platform/mac-leopard/fast/block/basic/truncation-rtl-expected.checksum: Added.
- platform/mac-leopard/fast/block/basic/truncation-rtl-expected.png: Added.
- platform/mac-leopard/fast/blockflow/fieldsets-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/fieldsets-expected.png: Added.
- platform/mac-leopard/fast/borders/border-image-scale-transform-expected.checksum:
- platform/mac-leopard/fast/borders/border-image-scale-transform-expected.png:
- platform/mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
- platform/mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
- 2:03 PM Changeset in webkit [75551] by
-
- 5 edits in trunk/WebKit2
Fix spelling mistake. Sharable -> Shareable.
Reviewed by Anders Carlsson.
- Shared/API/c/WKImage.h:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toImageOptions):
- Shared/ImageOptions.h:
- Shared/WebImage.cpp:
(WebKit::WebImage::create):
- 1:53 PM Changeset in webkit [75550] by
-
- 10 edits1 add in trunk/WebKit2
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add SetSize message
https://bugs.webkit.org/show_bug.cgi?id=52247
- DerivedSources.make: Add DrawingArea.messages.in
- Platform/CoreIPC/MessageID.h: Add DrawingArea message class.
- UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::sizeDidChange): Call sendSetSize.
(WebKit::DrawingAreaProxyImpl::sendSetSize):
Send a SetSize message.
- UIProcess/DrawingAreaProxyImpl.h: Add setSize override.
- WebKit2.xcodeproj/project.pbxproj: Add new files.
- WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): Add setSize member function.
- WebProcess/WebPage/DrawingArea.messages.in: Added.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
- WebProcess/WebPage/DrawingAreaImpl.h: Add setSize.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveMessage): Handle drawing area messages.
- 1:33 PM Changeset in webkit [75549] by
-
- 2 edits in trunk/Source/WebCore
2011-01-11 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r75523.
- platform/wince/DragDataWinCE.cpp: Added missing include.
- 1:28 PM Changeset in webkit [75548] by
-
- 3 edits2 adds in trunk
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
RefPtr the FrameView to prevent scrollbar from getting deleted inside
its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238
Test: scrollbars/scrollable-iframe-remove-crash.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::scrollTo):
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that we do not crash when we remove scrollable iframe when executing
inside its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238
- scrollbars/scrollable-iframe-remove-crash-expected.txt: Added.
- scrollbars/scrollable-iframe-remove-crash.html: Added.
- 1:24 PM Changeset in webkit [75547] by
-
- 2 edits in trunk/WebKit2
Replace ASSERTs with FIXMEs.
Reviewed by Sam Weinig.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::sizeDidChange):
(WebKit::DrawingAreaProxyImpl::setPageIsVisible):
- 1:20 PM Changeset in webkit [75546] by
-
- 4 edits2 adds in trunk/WebKit2
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add DrawingAreaImpl skeleton class
https://bugs.webkit.org/show_bug.cgi?id=52246
- UIProcess/API/mac/WKView.mm: (useNewDrawingArea): New function which controls which drawing area to use, through an environment variable.
(-[WKView drawRect:]):
Bail if we're using the new drawing area (for now).
(-[WKView WebKit::]):
Create a DrawingAreaProxyImpl when asked to.
- WebKit2.xcodeproj/project.pbxproj: Add new files.
- WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): Create a DrawingAreaImpl when asked to.
- WebProcess/WebPage/DrawingAreaImpl.cpp: Added.
- WebProcess/WebPage/DrawingAreaImpl.h: Added. Add DrawingAreaImpl class.
- 1:17 PM Changeset in webkit [75545] by
-
- 1 edit3 deletes in trunk/LayoutTests
2011-01-11 Martin Robinson <mrobinson@igalia.com>
Remove some GTK+-specific baselines. GTK+ now enough feature parity with the Mac
port to make these platform-specific results unnecessary.
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
- platform/gtk/fast/dom/prototype-inheritance-expected.txt: Removed.
- platform/gtk/fast/js/global-constructors-expected.txt: Removed.
- 1:08 PM Changeset in webkit [75544] by
-
- 3 edits in trunk/LayoutTests
2011-01-11 Nico Weber <thakis@chromium.org>
Unreviewed, test expectations.
Another new baselines due to updated skia
https://bugs.webkit.org/show_bug.cgi?id=52105
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
- 1:05 PM Changeset in webkit [75543] by
-
- 16 edits2 adds in trunk
2011-01-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Hyatt.
Make pseudo-style resolution less hard-coded when used to select a shadow node
https://bugs.webkit.org/show_bug.cgi?id=46595
New test that comprehensively travels the code paths affected by the change.
- fast/css/unknown-pseudo-element-matching-expected.txt: Added.
- fast/css/unknown-pseudo-element-matching.html: Added.
2011-01-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Hyatt.
Make pseudo-style resolution less hard-coded when used to select a shadow node
https://bugs.webkit.org/show_bug.cgi?id=46595
Essentially implements the plumbing for the XBL2 pseudo attribute:
http://dev.w3.org/2006/xbl2/#the-pseudo-attribute
Test: fast/css/unknown-pseudo-element-matching.html
- css/CSSGrammar.y: Changed to handle specifier_list structure with the
CSSParser::updateSpecifierWithElementName helper, added logic to
keep unknown pseudo-element selectors at the top of the selector chain,
so that we can easily check for them and grab them, and also because
they would either not match anything or act as a descendant selector
(descendant into a shadow DOM subtree that is), not a specifier.
- css/CSSParser.cpp: (WebCore::CSSParser::updateSpecifiersWithElementName): Generalized/combined
the logic adding element name to selectors and added the special case
to handle unknown pseudo-element selectors.
- css/CSSParser.h: Added def.
- css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed any mention of PseudoSliderThumb/SLIDER_THUMB. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
- css/CSSSelector.h: Added a new ShadowDescendant relation type,
removed PseudoSliderThumb def.
(WebCore::CSSSelector::isUnknownPseudoElement): Added a helper method.
- css/CSSSelectorList.cpp: (WebCore::SelectorHasUnknownPseudoElementFunctor::operator()): Added a functor
to check for an unknown pseudo-element in the list.
(WebCore::CSSSelectorList::hasUnknownPseudoElements): Added.
- css/CSSSelectorList.h: Added a def.
- css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::getPseudoRules): Added accessor to pseudo-element hash. (WebCore::CSSStyleSelector::matchRules): Added matching pseudo elements. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Added handling
of ShadowDescendant relation.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Enabled handling
of unknown pseudo-element selectors.
(WebCore::CSSRuleSet::addRule): Added populating unknown pseudo-element hash.
- css/html.css: (input[type="range"]::-webkit-slider-thumb): Added previously-hard-coded
display:block.
- dom/Element.h: (WebCore::Element::shadowPseudoId): Added new virtual method to allow
elements to provide the value of pseudo-element selector they would match.
- dom/Node.cpp: (WebCore::Node::querySelector): Added checking for unknown pseudo-element selectors,
so that we can throw a SYNTAX_ERR if found.
(WebCore::Node::querySelectorAll): Ditto.
- html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::shadowPseudoId): Added to return "-webkit-slider-thumb";
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Changed to use the new styleForElement logic.
- rendering/style/RenderStyleConstants.h: Removed SLIDER_THUMB.
- 1:03 PM Changeset in webkit [75542] by
-
- 5 edits in trunk
2011-01-11 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
WebKitCSSMatrix constructor should accept 'none'
as a valid string parameter.
- css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::setMatrixValue):
2011-01-11 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
Update WebKitCSSMatrix test to cover a constructor
that accepts 'none' as input.
- transforms/cssmatrix-2d-interface-expected.txt:
- transforms/cssmatrix-2d-interface.xhtml:
- 1:00 PM Changeset in webkit [75541] by
-
- 4 edits2 deletes in branches/chromium/597
Merged r75536.
- 12:56 PM Changeset in webkit [75540] by
-
- 5 edits2 adds in trunk/WebKit2
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add Mac-only DrawingAreaProxyImpl class skeleton
https://bugs.webkit.org/show_bug.cgi?id=52243
This is the proxy side of a new drawing area implementation. This is Mac only for now
while the design is being fleshed out.
- Shared/DrawingAreaInfo.h:
- UIProcess/API/mac/WKView.mm: (-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
- UIProcess/DrawingAreaProxyImpl.cpp: Added. (WebKit::DrawingAreaProxyImpl::create): (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): (WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl): (WebKit::DrawingAreaProxyImpl::didReceiveMessage): (WebKit::DrawingAreaProxyImpl::didReceiveSyncMessage): (WebKit::DrawingAreaProxyImpl::paint): (WebKit::DrawingAreaProxyImpl::sizeDidChange): (WebKit::DrawingAreaProxyImpl::setPageIsVisible): (WebKit::DrawingAreaProxyImpl::attachCompositingContext): (WebKit::DrawingAreaProxyImpl::detachCompositingContext):
- UIProcess/DrawingAreaProxyImpl.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
- 12:56 PM Changeset in webkit [75539] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Mihai Parparita.
fix exception when adding a comment to a side-by-side diff
https://bugs.webkit.org/show_bug.cgi?id=52240
prev() and next() won't get the previous and next lines in
side-by-side mode. Instead do a query to find them.
- code-review.js:
- 12:54 PM Changeset in webkit [75538] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Mihai Parparita.
maintain word diffs when converting to side-by-side and back
https://bugs.webkit.org/show_bug.cgi?id=52244
Using textContent would lose the spans use to make the word-diff highlighting.
Just move the span element itself.
- code-review.js:
- 12:47 PM Changeset in webkit [75537] by
-
- 11 edits in trunk/Source/WebCore
2011-01-11 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Set all RenderBlocks as replaced when an inline display type is specified
https://bugs.webkit.org/show_bug.cgi?id=50858
When a RenderBlock is created for an element with a specified display:inline style,
it should always be treated as inline-block. This situations often comes up for form
controls. Previously, RenderBlock::styleWillChange set the replaced flag for display
values of inline-block, inline-table, and inline-table and a number of subclasses of
RenderBlock set the replaced flag in styleDidChange for a display:inline. However
sometimes new subclasses would miss this step leading to bugs (such as with RenderDetails).
This patch sets the replaced flag for all inline display types in RenderBlock::styleWillChange.
Code cleanup only, no change in behavior so no new tests.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange):
- rendering/RenderButton.cpp: (WebCore::RenderButton::styleDidChange):
- rendering/RenderFieldset.cpp:
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::styleDidChange):
- rendering/RenderListBox.cpp:
- rendering/RenderListBox.h:
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::styleDidChange):
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::styleDidChange):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange):
- 12:44 PM Changeset in webkit [75536] by
-
- 5 edits2 deletes in trunk
2011-01-11 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
REGRESSION(r71934) Can't type in search edit field on skin-one.com
https://bugs.webkit.org/show_bug.cgi?id=52195
Restored original (pre-71934) check in the test to ensure that
selectstart does not propagate outside of the shadow DOM.
Consolidated shadow-boundary-crossing-2.html into shadow-boundary-crossing.html.
- fast/events/shadow-boundary-crossing-2-expected.txt: Renamed to
shadow-boundary-crossing-expected.txt.
- fast/events/shadow-boundary-crossing-2.html: Renamed to
shadow-boundary-crossing.html.
- fast/events/shadow-boundary-crossing-expected.txt: Removed.
- fast/events/shadow-boundary-crossing.html: Removed after folding the
test into the new shadow-boundary-crossing.html.
2011-01-11 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
REGRESSION(r71934) Can't type in search edit field on skin-one.com
https://bugs.webkit.org/show_bug.cgi?id=52195
Restored the original behavior, where the selectstart event is not
dispatched when selection changes inside of the shadow DOM.
- dom/Node.cpp: (WebCore::determineDispatchBehavior): Moved EventDispatchBehavior-determining
logic into a helper function, also added a check to keep selectstart
events inside of the shadow DOM.
(WebCore::Node::dispatchGenericEvent): Changed to use the helper function.
- 12:39 PM Changeset in webkit [75535] by
-
- 2 edits in trunk/Source/WebCore
2011-01-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Eric Seidel.
[Qt] Provide plugin coordinates to windowless plugins on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=52213
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
- 12:34 PM Changeset in webkit [75534] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectation update.
- platform/mac-snowleopard/Skipped:
- 12:33 PM Changeset in webkit [75533] by
-
- 2 edits in trunk
2011-01-11 Laszlo Gombos <Laszlo Gombos>
Reviewed by Csaba Osztrogonác.
[Qt] Add QT_NO_CONCURRENT to the qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=52223
Add QT_NO_CONCURRENT to the qt_minimal configuration to make sure
that QtWebKit builds with QT_NO_CONCURRENT defined.
- WebKit.pri:
- 12:28 PM Changeset in webkit [75532] by
-
- 2 edits in trunk/WebKit2
Fix Windows build.
- WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
- 12:24 PM Changeset in webkit [75531] by
-
- 3 edits3 adds in trunk
2011-01-11 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Missing call to popTempSortVector() for exception case in JSArray::sort.
https://bugs.webkit.org/show_bug.cgi?id=50718
Fix to patch of 50718 that added pushTempSortVector() and
popTempSortVector() to JSArray::sort() to mark elements during sort.
Need to add popTempSortVector() for the return case if toString()
had an exception.
- runtime/JSArray.cpp: (JSC::JSArray::sort): Added popTempSortVector()
2011-01-11 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Missing call to popTempSortVector() for exception case in JSArray::sort.
https://bugs.webkit.org/show_bug.cgi?id=50718
New test to validate balanced calls to pushTempSortVector() and
popTempSortVector().
- fast/js/array-sort-exception-expected.txt: Added.
- fast/js/array-sort-exception.html: Added.
- fast/js/script-tests/array-sort-exception.js: Added. (do_gc): (Item): (toString_throw): (test):
- 12:22 PM Changeset in webkit [75530] by
-
- 3 edits in trunk/LayoutTests
2011-01-11 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium-gpu/test_expectations.txt:
- platform/chromium/test_expectations.txt:
- 12:21 PM Changeset in webkit [75529] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-11 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix layout error with comments in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52230
- PrettyPatch/PrettyPatch.rb:
- 12:20 PM Changeset in webkit [75528] by
-
- 7 edits in trunk/WebKit2
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Rename ShareableBitmap::createSharable to createShareable
https://bugs.webkit.org/show_bug.cgi?id=52234
- Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::createShareable):
- Shared/ShareableBitmap.h:
- Shared/WebImage.cpp: (WebKit::WebImage::create):
- WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
- WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: (WebKit::WebPopupMenu::setUpPlatformData):
- WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):
- 12:13 PM Changeset in webkit [75527] by
-
- 21 edits5 moves in trunk/WebKit2
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Rename BackingStore to ShareableBitmap
https://bugs.webkit.org/show_bug.cgi?id=52228
- GNUmakefile.am:
- PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::geometryDidChange):
- PluginProcess/PluginControllerProxy.h:
- Shared/API/c/cg/WKImageCG.cpp: (WKImageCreateCGImage):
- Shared/BackingStore.cpp: Removed.
- Shared/BackingStore.h: Removed.
- Shared/PlatformPopupMenuData.cpp: (WebKit::PlatformPopupMenuData::decode):
- Shared/PlatformPopupMenuData.h:
- Shared/ShareableBitmap.cpp: Copied from WebKit2/Shared/BackingStore.cpp. (WebKit::ShareableBitmap::create): (WebKit::ShareableBitmap::createSharable): (WebKit::ShareableBitmap::createHandle): (WebKit::ShareableBitmap::ShareableBitmap): (WebKit::ShareableBitmap::~ShareableBitmap): (WebKit::ShareableBitmap::resize): (WebKit::ShareableBitmap::data):
- Shared/ShareableBitmap.h: Copied from WebKit2/Shared/BackingStore.h.
- Shared/UserMessageCoders.h: (WebKit::UserMessageEncoder::baseEncode): (WebKit::UserMessageDecoder::baseDecode):
- Shared/WebImage.cpp: (WebKit::WebImage::create): (WebKit::WebImage::WebImage): (WebKit::WebImage::~WebImage): (WebKit::WebImage::size):
- Shared/WebImage.h: (WebKit::WebImage::bitmap):
- Shared/cairo/BackingStoreCairo.cpp: (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
- Shared/cg/BackingStoreCG.cpp: Removed.
- Shared/cg/ShareableBitmapCG.cpp: Copied from WebKit2/Shared/cg/BackingStoreCG.cpp. (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
- Shared/gtk/BackingStoreGtk.cpp: Removed.
- Shared/gtk/ShareableBitmapGtk.cpp: Copied from WebKit2/Shared/gtk/BackingStoreGtk.cpp. (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
- Shared/qt/BackingStoreQt.cpp: Removed.
- Shared/qt/ShareableBitmapQt.cpp: Copied from WebKit2/Shared/qt/BackingStoreQt.cpp. (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
- UIProcess/FindIndicator.cpp: (WebKit::FindIndicator::create): (WebKit::FindIndicator::FindIndicator):
- UIProcess/FindIndicator.h: (WebKit::FindIndicator::contentImage):
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::snapshotInViewCoordinates): (WebKit::WebPage::snapshotInDocumentCoordinates):
- win/WebKit2.vcproj:
- 12:12 PM Changeset in webkit [75526] by
-
- 3 edits in trunk/LayoutTests
2011-01-11 Nico Weber <thakis@chromium.org>
Unreviewed, test expectations.
Another baseline for the recent skia roll.
https://bugs.webkit.org/show_bug.cgi?id=52105
- platform/chromium-linux/svg/custom/focus-ring-expected.checksum:
- platform/chromium-linux/svg/custom/focus-ring-expected.png:
- 12:05 PM Changeset in webkit [75525] by
-
- 2 edits in trunk/WebKit2
[WKView setFrameSize:] derefs _page->drawingArea() without null check
<https://bugs.webkit.org/show_bug.cgi?id=52231>
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
Null check drawingArea(). This is OK because if it doesn't exist then it will be
created later with the correct initial size.
- 11:49 AM Changeset in webkit [75524] by
-
- 8 edits in trunk
2011-01-10 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Use computeImageSizeInBytes. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::readPixels): Ditto, and fix a bug on generating the wrong error. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::validateTexFuncData): Use computeImageSizeInBytes.
- platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2DResourceSafe): Add a new parameter alignment. (WebCore::GraphicsContext3D::computeFormatAndTypeParameters): Add more supported format/type. (WebCore::GraphicsContext3D::computeImageSizeInBytes): Added.
- platform/graphics/GraphicsContext3D.h:
2011-01-10 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068
- fast/canvas/webgl/read-pixels-test-expected.txt:
- fast/canvas/webgl/read-pixels-test.html: Sync with khronos.
- fast/canvas/webgl/resources/webgl-test.js: Add finishTest().
- 11:47 AM Changeset in webkit [75523] by
-
- 39 edits2 deletes in trunk
Source/WebCore: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.
Reviewed by Alexey Proskuryakov.
No new tests. A test is already available for this
(editing/pasteboard/drag-image-to-contenteditable-in-iframe.html) but had incorrect results.
- WebCore.exp.in:
- loader/EmptyClients.h: Added two Mac only methods to call into WebKit to use functionality
that is in NSURLExtras.
(WebCore::EmptyEditorClient::canonicalizeURL):
(WebCore::EmptyEditorClient::canonicalizeURLString):
- page/DragController.cpp:
The following methods have been changed to pass a pointer to the Frame object
to the DragData class.
(WebCore::documentFragmentFromDragData):
(WebCore::DragController::performDrag):
(WebCore::DragController::dispatchTextInputEventFor):
(WebCore::DragController::concludeEditDrag):
- page/EditorClient.h: Added two Mac only methods to call into WebKit to use functionality
that is in NSURLExtras.
The following files have been modified to pass the Frame object to the DragData method calls.
- page/chromium/DragControllerChromium.cpp:
(WebCore::DragController::dragOperation):
- page/gtk/DragControllerGtk.cpp:
(WebCore::DragController::dragOperation):
- page/mac/DragControllerMac.mm:
(WebCore::DragController::dragOperation):
- page/qt/DragControllerQt.cpp:
(WebCore::DragController::dragOperation):
- page/win/DragControllerWin.cpp:
(WebCore::DragController::dragOperation):
- platform/DragData.h: Removed Mac specific constructor and reference to PasteboardHelper class.
- platform/Pasteboard.h: Added public constructor to create a Pasteboard object from an NSPasteboard.
The following files were all modified to match the new parameters of the methods listed.
- platform/android/DragDataAndroid.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):
- platform/gtk/DragDataGtk.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
- platform/haiku/DragDataHaiku.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
- platform/mac/DragDataMac.mm:
(WebCore::DragData::DragData):
(WebCore::DragData::asPlainText):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getBestURL):
(WebCore::Pasteboard::asURL):
- platform/qt/DragDataQt.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
- platform/win/DragDataWin.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):
- platform/wince/DragDataWinCE.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asFragment):
- platform/wx/DragDataWx.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
WebKit: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.
Reviewed by Alexey Proskuryakov.
- WebKit.xcodeproj/project.pbxproj: Removed WebPasteboardHelper.mm and WebPasteboardHelper.h.
WebKit/mac: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.
Reviewed by Alexey Proskuryakov.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
exposed by NSURLExtras.
(WebEditorClient::canonicalizeURL):
(WebEditorClient::canonicalizeURLString):
- WebCoreSupport/WebPasteboardHelper.h: Removed.
- WebCoreSupport/WebPasteboardHelper.mm: Removed.
- WebView/WebHTMLView.mm: Removed comment.
- WebView/WebView.mm: The following methods have been changed to use the new DragData
constructor that doesn't use the WebPasteboardHelper reference.
(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):
WebKit2: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.
Reviewed by Alexey Proskuryakov.
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Added two methods to provide to WebCore functionality
exposed by NSURLExtras.
(WebKit::WebEditorClient::canonicalizeURL):
(WebKit::WebEditorClient::canonicalizeURLString):
LayoutTests: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
Reviewed by Alexey Proskuryakov.
New test results added to match the correct behavior.
- platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
- platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
- platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
- 11:40 AM Changeset in webkit [75522] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed; chromium test expectations update.
Remove failing expectations for tests that pass after r75515.
- platform/chromium/test_expectations.txt:
- 11:40 AM Changeset in webkit [75521] by
-
- 2 edits in trunk/WebKit2
Fix crash on launch on Windows.
Reviewed by Anders Carlsson and Sam Weinig.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::onSizeEvent):
The drawing area is no longer initialized before the WebView is created and the first
onSize is receieved.
- 11:28 AM Changeset in webkit [75520] by
-
- 4 edits in trunk/Tools
2011-01-11 Eric Seidel <eric@webkit.org>
Unreviewed.
commit-queue should know how to upload archived results (for test flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048
I changed the API for archive_last_layout_test_results w/o updating the implementation. Oops.
This fixes an exception seen on the commit-queue when attempting to report flaky tests.
- Scripts/webkitpy/common/system/workspace.py:
- Scripts/webkitpy/common/system/workspace_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- 11:24 AM Changeset in webkit [75519] by
-
- 3 edits2 adds in trunk
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
RefPtr text node in setOuterText since calling appendData
on a text node can fire away dom event listener which might
remove the text node from underneath.
https://bugs.webkit.org/show_bug.cgi?id=52163
Test: fast/dom/text-node-append-data-remove-crash.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterText):
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that calling append data on a text node which removes its
sibling text node does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=52163
- fast/dom/text-node-append-data-remove-crash-expected.txt: Added.
- fast/dom/text-node-append-data-remove-crash.html: Added.
- 10:50 AM Changeset in webkit [75518] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium-gpu test expectations update.
Remove now-passing tests from text_expectations.txt.
- platform/chromium-gpu/test_expectations.txt:
- 10:49 AM Changeset in webkit [75517] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-11 Xan Lopez <xlopez@igalia.com>
Reviewed by Darin Adler.
Microoptimization in ~JSString
https://bugs.webkit.org/show_bug.cgi?id=52222
The case where m_fibers is 0 seems to be the most common one
(almost 1/2 of the time, followed at some distance by m_fibers = 1
in 1/4 of the cases in a typical SunSpider execution). We can save
one comparison in this common case by doing a bit of refactoring
in the JSString destructor; overall a 0.3% progression, but only
the string tests show improvement.
- runtime/JSString.h: (JSC::RopeBuilder::~JSString):
- 10:49 AM Changeset in webkit [75516] by
-
- 5 edits in trunk/WebKit2
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Automatically reinitialize the web page on relaunch
https://bugs.webkit.org/show_bug.cgi?id=52224
<rdar://problem/8765695>
- UIProcess/API/mac/WKView.mm: (-[WKView _didRelaunchProcess]): Remove call to reinitializeWebPage.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::relaunch): Call initializeWebPage().
(WebKit::WebPageProxy::initializeWebPage):
Assert that the web page is valid here.
- UIProcess/WebPageProxy.h: Remove reinitializeWebPage.
- UIProcess/win/WebView.cpp: (WebKit::WebView::didRelaunchProcess): Remove call to reinitializeWebPage.
- 10:46 AM Changeset in webkit [75515] by
-
- 6 edits10 adds in trunk/LayoutTests
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed; new and updated mac-leopard baselines.
Update stale or missing Leopard baselines (tests currently pass on Snow
Leopard).
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/fast/block/basic/fieldset-stretch-to-legend-expected.checksum:
- platform/mac-leopard/fast/block/basic/fieldset-stretch-to-legend-expected.png:
- platform/mac-leopard/fast/dom/focus-contenteditable-expected.checksum: Added.
- platform/mac-leopard/fast/dom/focus-contenteditable-expected.png: Added.
- platform/mac-leopard/fast/forms/fieldset-align-expected.checksum: Added.
- platform/mac-leopard/fast/forms/fieldset-align-expected.png: Added.
- platform/mac-leopard/fast/multicol/columns-shorthand-parsing-expected.checksum: Added.
- platform/mac-leopard/fast/multicol/columns-shorthand-parsing-expected.png: Added.
- platform/mac-leopard/fast/text/capitalize-boundaries-expected.checksum: Added.
- platform/mac-leopard/fast/text/capitalize-boundaries-expected.png: Added.
- platform/mac-leopard/fast/text/softHyphen-expected.checksum: Added.
- platform/mac-leopard/fast/text/softHyphen-expected.png: Added.
- platform/mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.checksum:
- platform/mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.png:
- 10:39 AM Changeset in webkit [75514] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-01-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
convert back to unified from sidebyside diff
https://bugs.webkit.org/show_bug.cgi?id=52180
Remove url fragment stuff. Having it be per-filediff is too complicated.
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 10:37 AM Changeset in webkit [75513] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 Martin Robinson <mrobinson@igalia.com>
Unskipping fast/multicol/span/double-merge-anonymous-block-crash.html. We
have been unsuccessful reproducing the crash locally or on the bots.
- platform/gtk/Skipped: Unskipping test.
- 10:36 AM Changeset in webkit [75512] by
-
- 4 edits in trunk/WebKit2
2011-01-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Pass the view size to the DrawingAreaProxy constructor
https://bugs.webkit.org/show_bug.cgi?id=52189
- UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewSize):
- UIProcess/WebPageProxy.h:
- 10:29 AM Changeset in webkit [75511] by
-
- 2 edits in trunk
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed. Update .gitignore with new Chromium dependency.
ui/ was added with http://crrev.com/70743, we picked that up with a
Chromium roll in r75311.
Also alphabetizes the dependency list.
- .gitignore:
- 10:27 AM Changeset in webkit [75510] by
-
- 4 edits6 adds in trunk
2011-01-10 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
ASSERTION Failure in JSC::binaryChop
https://bugs.webkit.org/show_bug.cgi?id=25614
Changed JITStubs::cti_register_file_check() to use the current stack's
return PC to find the bytecode for handling the exception in the prior
frame. Also added the appropriate arrity check routine call to the
JIT to bytecode vector (m_callReturnIndexVector) in the CodeBlock.
- jit/JIT.cpp: (JSC::JIT::privateCompile): Changed the arrity check call location so that it gets added to the m_calls list so that it's included in CodeBlock::m_callReturnIndexVector.
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): Use the current call frame's return PC.
2011-01-11 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
ASSERTION Failure in JSC::binaryChop
https://bugs.webkit.org/show_bug.cgi?id=25614
Added new test to check for proper handling of stack overflow
exceptions and arrity exceptions while close to the top of the stack.
- fast/js/script-tests/stack-overflow-arrity-catch.js: Added. (fWithTwoArgs): (test):
- fast/js/script-tests/stack-overflow-catch.js: Added. (test):
- fast/js/stack-overflow-arrity-catch-expected.txt: Added.
- fast/js/stack-overflow-arrity-catch.html: Added.
- fast/js/stack-overflow-catch-expected.txt: Added.
- fast/js/stack-overflow-catch.html: Added.
- 10:05 AM Changeset in webkit [75509] by
-
- 14 edits in trunk/LayoutTests
2011-01-11 Stephen White <senorblanco@chromium.org>
Unreviewed; new chromium GPU test baselines.
These tests required rebaselining after the skia roll in
http://src.chromium.org/viewvc/chrome?view=rev&revision=70835.
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.checksum:
- platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png:
- platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.txt:
- platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png:
- platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.txt:
- platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
- platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.txt:
- 9:56 AM Changeset in webkit [75508] by
-
- 27 edits8 adds in trunk
Tools: Roll r75474 back in.
WebKit2: Roll r75460 back in with build fix.
- 9:32 AM Changeset in webkit [75507] by
-
- 4 edits22 adds in trunk
2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add support for <meter> element
https://bugs.webkit.org/show_bug.cgi?id=48713
- platform/gtk/Skipped:
- platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
- platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add support for <meter> element
https://bugs.webkit.org/show_bug.cgi?id=48713
- GNUmakefile.am: Enable meter element.
- 9:22 AM Changeset in webkit [75506] by
-
- 13 edits in trunk/WebKit2
2011-01-11 Anders Carlsson <andersca@apple.com>
Reviewed by Andreas Kling.
Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=52184
Qt part made my Balazs Kelemen.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::createDrawingAreaProxy): Call -[WKView _createDrawingAreaProxy].
(WebKit::PageClientImpl::setViewNeedsDisplay):
Call setNeedsDisplayInRect on the WKView.
- UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): No need to set the drawing area proxy anymore.
(-[WKView _createDrawingAreaProxy]):
Create a chunked update drawing area proxy for now.
- UIProcess/API/qt/qgraphicswkview.cpp: Added a QGraphicsItem* member that is initialized in init to the accociated view. Implement the new functions. This is a temporary solution, in the long term the view and the page should be decoupled. (QGraphicsWKView::QGraphicsWKView):
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::init): (QWKPagePrivate::createDrawingAreaProxy): (QWKPagePrivate::setViewNeedsDisplay):
- UIProcess/API/qt/qwkpage.h:
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h: Add new pure virtual member functions.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::reinitializeWebPage): Set the new drawing area proxy.
- UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): No need to set the drawing area proxy anymore.
(WebKit::WebView::createDrawingAreaProxy):
Create a chunked update drawing area proxy for now.
(WebKit::WebView::setViewNeedsDisplay):
Invalidate the window.
- 8:49 AM Changeset in webkit [75505] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed buildfix.
[Qt][V8] Add missing include for debug build.
- loader/cache/CachedResourceLoader.cpp:
- 8:37 AM Changeset in webkit [75504] by
-
- 2 edits in trunk/LayoutTests
2011-01-11 Stephen White <senorblanco@chromium.org>
Unreviewed; yet another gpu test_expectations update.
All glory to the hypnotoad.
- platform/chromium-gpu/test_expectations.txt:
- 8:33 AM Changeset in webkit [75503] by
-
- 2 edits in trunk/Source/WebCore
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: redirects are lost from the network panel upon navigation.
https://bugs.webkit.org/show_bug.cgi?id=52210
- inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
- 8:19 AM Changeset in webkit [75502] by
-
- 7 edits in trunk
2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204
- platform/network/qt/QtNAMThreadSafeProxy.cpp: (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy): (WebCore::QtNAMThreadSafeProxy::localCookiesForUrl): (WebCore::QtNAMThreadSafeProxy::localWillLoadFromCache):
- platform/network/qt/QtNAMThreadSafeProxy.h: (WebCore::QtNAMThreadSafeProxy::cookiesForUrl): (WebCore::QtNAMThreadSafeProxy::willLoadFromCache):
2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204
- QtTestBrowser/webpage.h: (QtNAMThread::QtNAMThread): (QtNAMThread::networkAccessManager): (QtNAMThread::run):
2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204
- tests/qwebpage/tst_qwebpage.cpp: (QtNAMThread::QtNAMThread): (QtNAMThread::networkAccessManager): (QtNAMThread::run):
- 7:21 AM WebKit Team edited by
- (diff)
- 7:09 AM Changeset in webkit [75501] by
-
- 2 edits in trunk/Tools
2011-01-11 Peter Varga <pvarga@webkit.org>
Unreviewed.
Add myself to committers' list.
- Scripts/webkitpy/common/config/committers.py:
- 6:37 AM Changeset in webkit [75500] by
-
- 5 edits in trunk/Source/WebCore
2011-01-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: recreate script view after live edit.
https://bugs.webkit.org/show_bug.cgi?id=51751
- inspector/front-end/Script.js: (WebInspector.Script.prototype.set source):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource): (WebInspector.ScriptsPanel.prototype.viewRecreated):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._doEditLine):
- 6:33 AM Changeset in webkit [75499] by
-
- 2 edits in trunk/Source/WebCore
2011-01-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: frameDetachedFromParent notification handler is missing in NetworkManager.
https://bugs.webkit.org/show_bug.cgi?id=52205
- inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.frameDetachedFromParent):
- 6:11 AM Changeset in webkit [75498] by
-
- 4 edits in trunk/Source/WebCore
2011-01-11 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: "Audit present state" always disabled
https://bugs.webkit.org/show_bug.cgi?id=52199
Removed all traces of resource tracking checks, as we have it no more.
- English.lproj/localizedStrings.js:
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
- inspector/front-end/AuditsPanel.js:
- 6:09 AM Changeset in webkit [75497] by
-
- 3 edits in trunk/Source/WebCore
2011-01-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move delayed search implementation to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51753
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype.findSearchMatches): (WebInspector.SourceFrame.prototype.cancelFindSearchMatches):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.searchCanceled): (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches): (WebInspector.SourceView.prototype.performSearch):
- 6:07 AM Changeset in webkit [75496] by
-
- 3 edits2 deletes in trunk/LayoutTests
2011-01-11 Jeremy Orlow <jorlow@chromium.org>
[Chromium] Fix bad baselines
https://bugs.webkit.org/show_bug.cgi?id=52207
It looks like https://bugs.webkit.org/show_bug.cgi?id=51865 didn't quite
get the baselines right. Ran the rebaseline tool to get these.
- platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.txt: Removed.
- platform/chromium-linux/svg/custom/getPresentationAttribute-expected.txt: Removed.
- platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.txt:
- platform/chromium-win/svg/custom/getPresentationAttribute-expected.txt:
- 6:07 AM Changeset in webkit [75495] by
-
- 3 edits in trunk/Source/WebCore
2011-01-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: innerFirstChild has a side effect which should be called explicitly.
If a node is a frame's owner then innerFirstChild method
subscribes DOMAgent instance to the frame's doc's events.
I think this should be done explicitly when we meet with
the node for the first time. As I understand it happens
in buildArrayForContainerChildren method.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListeningFrameDoc): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::innerFirstChild):
- inspector/InspectorDOMAgent.h:
- 5:48 AM Changeset in webkit [75494] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Delete WKCACFLayer.{cpp,h}
These have been unused since r75262
- platform/graphics/win/WKCACFLayer.cpp: Removed.
- platform/graphics/win/WKCACFLayer.h: Removed.
- 5:40 AM Changeset in webkit [75493] by
-
- 3 edits in trunk/LayoutTests
Update test results after r75408
- platform/mac-leopard/fast/js/large-expressions-expected.txt:
- platform/win/fast/js/large-expressions-expected.txt:
- 5:26 AM Changeset in webkit [75492] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] DRT sideeffect revealed by r63657 and r75305
https://bugs.webkit.org/show_bug.cgi?id=42578
After r75305 24 tests fail. Add them to the Skipped list temporarily to make buildbot happy.
- platform/qt/Skipped:
- 5:19 AM Changeset in webkit [75491] by
-
- 2 edits in trunk/WebKit2
Fix a typo in a comment
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- 5:18 AM Changeset in webkit [75490] by
-
- 3 edits in trunk/Source/WebCore
Roll out r75487 since it broke the 32-bit build.
- 5:17 AM Changeset in webkit [75489] by
-
- 2 edits in trunk/Source/WebCore
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [regression] Cookies view does not allow columns resize.
https://bugs.webkit.org/show_bug.cgi?id=51877
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._updateWithCookies):
- 4:46 AM Changeset in webkit [75488] by
-
- 4 edits in trunk
2011-01-11 Noel Gordon <noel.gordon@gmail.com>
Reviewed by James Robinson.
[chromium] canvas.toDataURL("image/jpeg") should composite onto black.
https://bugs.webkit.org/show_bug.cgi?id=51237
canvas/philip/tests/toDataURL.jpeg.alpha.html only fails on chromium-mac
now, tracked by bug http://webkit.org/b/40147.
- platform/chromium/test_expectations.txt: win & linux pass.
2011-01-11 Noel Gordon <noel.gordon@gmail.com>
Reviewed by James Robinson.
[chromium] canvas.toDataURL("image/jpeg") should composite onto black.
https://bugs.webkit.org/show_bug.cgi?id=51237
The Canvas specification requires that the canvas image is composited using
the Porter-Duff operator source-over onto a black background; the resultant
image should be JPEG encoded and returned as a dataURL. To composite image
A and background B, for any Porter-Duff operator, produce pixels I with
I = c(A)F(A) + c(B)F(B)
where, F(X) is the fraction [0.0-1.0] contributed to the composite by image
X, and c(X) are the premultiplied RGB color components of image X. Note by
definition, c(B) = 0 since the background is black, so I = c(A)F(A). Since
F(A) = 1 in Porter-Duff operator source-over, the composited pixels satisfy
I = c(A). Hence, to conform to the Canvas spec, pass the premultiplied RGB
color components of the canvas image to the JPEG encoder.
Covered by canvas/philip/tests/toDataURL.jpeg.alpha.html
- platform/image-encoders/skia/JPEGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGB): Use Porter-Duff source-over black.
- 4:44 AM Changeset in webkit [75487] by
-
- 3 edits in trunk/Source/WebCore
2011-01-11 François Sausset <François Sausset>
Reviewed by Eric Seidel.
Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
https://bugs.webkit.org/show_bug.cgi?id=52201
Replace unneeded doubles by floats and remove unneeded casts.
- rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
- rendering/mathml/RenderMathMLFraction.h:
- 4:31 AM Changeset in webkit [75486] by
-
- 8 edits in trunk
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: get rid of APU-related code in WebKit/chromium.
https://bugs.webkit.org/show_bug.cgi?id=52152
- inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::setInjectedScriptSource):
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
- inspector/InspectorState.h:
- inspector/front-end/inspector.js:
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: get rid of APU-related code in WebKit/chromium.
https://bugs.webkit.org/show_bug.cgi?id=52152
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::frontendLoaded): (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend):
- src/WebDevToolsAgentImpl.h:
- 3:44 AM Changeset in webkit [75485] by
-
- 3 edits in trunk/Source/WebCore
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION] Load timing is requested
for all resources (not only for the main one).
https://bugs.webkit.org/show_bug.cgi?id=51749
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
- 3:38 AM Changeset in webkit [75484] by
-
- 1 edit2 deletes in trunk/LayoutTests
Unreviewed Chromium test expectations update.
Remove now unnecessary Chromium overrides.
- platform/chromium-mac/fast/regex/malformed-escapes-expected.txt: Removed.
- platform/chromium-win/fast/regex/malformed-escapes-expected.txt: Removed.
- 3:36 AM Changeset in webkit [75483] by
-
- 1 edit in branches/chromium/597/WebCore/inspector/front-end/StylesSidebarPane.js
Merge 74710 - 2010-12-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663
- inspector/elements-tests2.js: (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Drive-by: remove bad test exit code.
- inspector/resources/styles-url-linkify-iframe.html: Added.
- inspector/resources/styles-url-linkify.css: Added. (#local):
- inspector/styles-url-linkify-expected.txt: Added.
- inspector/styles-url-linkify.html: Added.
2010-12-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663
The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
optional quotes/apostrophes and spaces are now allowed inside uri(...).
Test: inspector/styles-url-linkify.html
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
TBR=apavlov@chromium.org
BUG=68159
Review URL: http://codereview.chromium.org/6115007
- 3:26 AM Changeset in webkit [75482] by
-
- 6 edits8 adds in trunk/LayoutTests
2011-01-11 Shane Stephens <shanestephens@google.com>
Reviewed by Eric Seidel.
[Chromium] Tests marked as WONTFIX SKIP but bug causing test failure fixed.
https://bugs.webkit.org/show_bug.cgi?id=51865
- platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.checksum: Added.
- platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.png: Added.
- platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.txt: Added.
- platform/chromium-linux/svg/custom/getPresentationAttribute-expected.checksum: Added.
- platform/chromium-linux/svg/custom/getPresentationAttribute-expected.png: Added.
- platform/chromium-linux/svg/custom/getPresentationAttribute-expected.txt: Added.
- platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.checksum:
- platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.png:
- platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.txt: Added.
- platform/chromium-win/svg/custom/getPresentationAttribute-expected.checksum:
- platform/chromium-win/svg/custom/getPresentationAttribute-expected.png:
- platform/chromium-win/svg/custom/getPresentationAttribute-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 3:18 AM Changeset in webkit [75481] by
-
- 10 edits in trunk
2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] GRefPtr should not be used with Gtk widgets
https://bugs.webkit.org/show_bug.cgi?id=51241
GRefPtr breaks the widget life-cycle, the main problem is
that GRefPtr calls g_object_unref() when it's destroyed,
which is undesirable for widgets. In gtk+ widgets are created with
a floating reference and when added to a container, the container
takes the ownership of the widget consuming the floating
reference. So you don't usually need to call g_object_ref/unref on
widgets (only for some operations like reparent a widget) and
toplevel widgets are destroyed with gtk_widget_destroy().
- platform/ContextMenuItem.h:
- platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::setPlatformDescription):
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled):
2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] GRefPtr should not be used with Gtk widgets
https://bugs.webkit.org/show_bug.cgi?id=51241
GRefPtr breaks the widget life-cycle, the main problem is
that GRefPtr calls g_object_unref() when it's destroyed,
which is undesirable for widgets. In gtk+ widgets are created with
a floating reference and when added to a container, the container
takes the ownership of the widget consuming the floating
reference. So you don't usually need to call g_object_ref/unref on
widgets (only for some operations like reparent a widget) and
toplevel widgets are destroyed with gtk_widget_destroy().
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::DragClient): (WebKit::DragClient::~DragClient): (WebKit::DragClient::startDrag):
- WebCoreSupport/DragClientGtk.h:
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup):
- webkit/webkitwebview.cpp: (webkit_web_view_dispose):
- webkit/webkitwebviewprivate.h:
- 2:36 AM Changeset in webkit [75480] by
-
- 10 edits2 adds in trunk/Tools
2011-01-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should know how to upload archived results (for test flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048
Now the queue will always upload results. Either the entire zip, or just
the diffs.txt in the case of text failures.
This should make understanding flakes much easier, and paves the way
for having the EWS run layout tests (and upload failures).
In order to upload .zip files I had to teach bugzilla.py to autodetect
mime types from the filename. Since mimetypes.py doesn't include a mapping
for .patch files, I have it add one before calling guess_type.
We may find that always uploading the whole zip instead of just the -diffs.txt
file is preferable, but for now I'm keeping the old behavior because it makes
quickly understanding text failures easy.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
- Scripts/webkitpy/common/system/workspace.py: Added.
- Scripts/webkitpy/common/system/workspace_unittest.py: Added.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/bot/flakytestreporter.py:
- Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 2:08 AM Changeset in webkit [75479] by
-
- 2 edits in trunk/WebKit/qt
2011-01-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix tst_QWebPage::geolocationRequestJS()
https://bugs.webkit.org/show_bug.cgi?id=46814
Skip the test when WebKit is compiled without geolocation.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::geolocationRequestJS):
Jan 10, 2011:
- 10:12 PM Changeset in webkit [75478] by
-
- 2 edits in trunk/LayoutTests
2011-01-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
Reorganized scrollbar-related failures.
- platform/chromium/test_expectations.txt:
- 10:07 PM Changeset in webkit [75477] by
-
- 2 edits in trunk/LayoutTests
2011-01-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
Remove entries for tests that now pass.
A bunch of tests with scrollbars started to pass after unncessary
Chromium baselines with removed with r75463, r75446 and
r75440.
ietestcenter/Javascript/15.4.4.14-9-b-i-6.html and ietestcenter/
Javascript/15.4.4.15-8-b-i-6.html started to pass after
http://crrev.com/70894, which rolled V8 to 3.0.7, which fixed
http://code.google.com/p/v8/issues/detail?id=1015.
fast/text/font-size-zero.html appears to always pass.
- platform/chromium/test_expectations.txt:
- 9:45 PM Changeset in webkit [75476] by
-
- 2 edits in trunk/LayoutTests
2011-01-10 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium-gpu test_expectations updates.
Mark 3 tests as failing after skia roll (chromium r75408).
- platform/chromium-gpu/test_expectations.txt:
- 8:50 PM Changeset in webkit [75475] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r75464.
http://trac.webkit.org/changeset/75464
https://bugs.webkit.org/show_bug.cgi?id=52193
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-10
Followup rollout for 75474 (Requested by Ossy on #webkit).
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
- WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
- 8:40 PM Changeset in webkit [75474] by
-
- 23 edits8 deletes in trunk/WebKit2
Unreviewed, rolling out r75460.
http://trac.webkit.org/changeset/75460
https://bugs.webkit.org/show_bug.cgi?id=52191
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-10
It broke Qt-WK2 build (Requested by Ossy on #webkit).
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKGeolocationPermissionRequest.cpp: Removed.
- UIProcess/API/C/WKGeolocationPermissionRequest.h: Removed.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WebKit2.h:
- UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
- UIProcess/GeolocationPermissionRequestManagerProxy.cpp: Removed.
- UIProcess/GeolocationPermissionRequestManagerProxy.h: Removed.
- UIProcess/GeolocationPermissionRequestProxy.cpp: Removed.
- UIProcess/GeolocationPermissionRequestProxy.h: Removed.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
- UIProcess/WebUIClient.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: Removed.
- WebProcess/Geolocation/GeolocationPermissionRequestManager.h: Removed.
- WebProcess/Geolocation/WebGeolocationManager.cpp:
- WebProcess/Geolocation/WebGeolocationManager.h:
- WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
(WebKit::WebGeolocationClient::requestPermission):
(WebKit::WebGeolocationClient::cancelPermissionRequest):
- WebProcess/WebCoreSupport/WebGeolocationClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
- 8:29 PM Changeset in webkit [75473] by
-
- 11 edits in trunk/WebKit2
Unreviewed, rolling out r75459
http://trac.webkit.org/changeset/75459
Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=52184
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/mac/WKView.mm:
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/API/qt/qwkpage.cpp:
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
- UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
- UIProcess/win/WebView.h:
- 8:14 PM Changeset in webkit [75472] by
-
- 3 edits2 adds in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=51119, transformed
elements not responding properly to :hover after r73385.
Just use the entire document area as the hit test area,
since there appears to be a rounding bug/issues with relying
on float math when mapping the hit test area into
transformed coordinates.
Patch by David Hyatt <hyatt@apple.com> on 2010-10-10
Reviewed by Simon Fraser.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=51119
Patch by David Hyatt <hyatt@apple.com> on 2011-01-10
Reviewed by Simon Fraser.
- fast/transforms/transform-hit-test-flipped-expected.txt: Added.
- fast/transforms/transform-hit-test-flipped.html: Added.
- 8:05 PM Changeset in webkit [75471] by
-
- 2 edits in trunk/LayoutTests
2011-01-10 Justin Schuh <jschuh@chromium.org>
Unreviewed Chromium test expectations update.
Fix path for: fast/js/kde/parse.html
- platform/chromium/test_expectations.txt:
- 7:48 PM Changeset in webkit [75470] by
-
- 2 edits in trunk/LayoutTests
2011-01-10 Justin Schuh <jschuh@chromium.org>
Unreviewed Chromium test expectations update.
Mark 3 tests as failing on chromium after r75408.
- platform/chromium/test_expectations.txt:
- 7:29 PM Changeset in webkit [75469] by
-
- 4 edits in trunk/Source/WebCore
2011-01-10 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
Fix canvas->canvas draws on the GPU path.
https://bugs.webkit.org/show_bug.cgi?id=52141
Two problems: according to the canvas spec, both source and
destination rects can have negative width or height, but this shouldn't
cause the image to be flipped. So we need to normalize the rects (in
the software path, this is done by BitmapImage*::draw). Secondly, in
the FBO->FBO path, the image needs to be flipped vertically, since it
is drawn upside down. We were doing this by flipping the destination
rect, but this doesn't work if the source rect is not the entire image,
since we extract the wrong part of the image. Fixed by flipping the
source rect instead (and flipping it within the image buffer's height,
not the source rect's height).
Covered by fast/canvas/drawImage-with-negative-source-destination.html.
- platform/graphics/skia/BitmapImageSingleFrameSkia.h: Put normalizeRect() in global scope.
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::draw): Fix as above: normalize both source and dest rects, and flip the source rect instead of the dest rect.
- platform/graphics/skia/ImageSkia.cpp: (WebCore::normalizeRect): Put normalizeRect() in global scope.
- 6:57 PM Changeset in webkit [75468] by
-
- 6 edits in trunk/WebKit2
2011-01-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Remove size parameter to WebPageProxy::initializeWebPage
https://bugs.webkit.org/show_bug.cgi?id=52188
- UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]):
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::init):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage):
- UIProcess/WebPageProxy.h:
- UIProcess/win/WebView.cpp: (WebKit::WebView::WebView):
- 6:50 PM Changeset in webkit [75467] by
-
- 20 edits in trunk
2011-01-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Csaba Osztrogonác.
[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313
- WebKit.pri: List the supported QT_NO_FEATURE flags under qt_minimal configuration.
2011-01-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Csaba Osztrogonác.
[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313
No new tests as there is no new functionality.
- platform/graphics/qt/GraphicsLayerQt.cpp: Fix the location of the QT_NO_ANIMATION guard.
- platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::applyDelta): Fix the location of the QT_NO_WHEELEVENT guard.
2011-01-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Csaba Osztrogonác.
[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add QT_NO_UNDOSTACK guard.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER guards. (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard. (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard. (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard. (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
- QtTestBrowser/launcherwindow.h:
- QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
- QtTestBrowser/locationedit.h: Ditto.
- QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and QT_NO_UNDOSTACK guards. (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard. (MainWindow::changeLocation): Ditto. (MainWindow::openFile): Add QT_NO_FILEDIALOG guard. (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
- QtTestBrowser/webpage.cpp: (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard. (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
- QtTestBrowser/webview.cpp: (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard. (WebViewGraphicsBased::animatedYFlip): Ditto.
2011-01-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Csaba Osztrogonác.
[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313
- WebCoreSupport/PopupMenuQt.cpp: (WebCore::PopupMenuQt::show): Add QT_NO_COMBOBOX guard.
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate): Add QT_NO_TOOLTIP guard.
- tests/qwebframe/tst_qwebframe.cpp: Add QT_NO_COMBOBOX guard.
- tests/qwebpage/tst_qwebpage.cpp: (PluginPage::createPlugin): Add QT_NO_INPUTDIALOG guard.
- 6:50 PM Changeset in webkit [75466] by
-
- 3 edits in trunk/WebKit2
Didn't mean to land this.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
- UIProcess/WebPageProxy.h:
- 6:49 PM Changeset in webkit [75465] by
-
- 4 edits in trunk/WebKit2
2011-01-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WebPageProxy::creationParameters no longer needs to take a size
https://bugs.webkit.org/show_bug.cgi?id=52187
WebPageProxy::creationParameters can just ask the page client for the view size now.
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::createInspectorPage):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::reinitializeWebPage): (WebKit::WebPageProxy::createNewPage): (WebKit::WebPageProxy::creationParameters):
- UIProcess/WebPageProxy.h:
- 6:48 PM Changeset in webkit [75464] by
-
- 4 edits in trunk/Tools
Fix build.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
- WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
- 6:46 PM Changeset in webkit [75463] by
-
- 7 edits2 adds6 deletes in trunk/LayoutTests
2011-01-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
Remove chromium-mac baselines for css1/ and css2.1/ tests that had them
because of scrollbars. Update stale mac-leopard baselines.
- platform/chromium-mac/css1/box_properties/clear-expected.checksum: Removed.
- platform/chromium-mac/css1/box_properties/clear-expected.png: Removed.
- platform/chromium-mac/css1/text_properties/text_transform-expected.checksum: Removed.
- platform/chromium-mac/css1/text_properties/text_transform-expected.png: Removed.
- platform/chromium-mac/css1/text_properties/vertical_align-expected.checksum: Removed.
- platform/chromium-mac/css1/text_properties/vertical_align-expected.png: Removed.
- platform/mac-leopard/css1/box_properties/clear_float-expected.checksum:
- platform/mac-leopard/css1/box_properties/clear_float-expected.png:
- platform/mac-leopard/css1/box_properties/float_elements_in_series-expected.checksum:
- platform/mac-leopard/css1/box_properties/float_elements_in_series-expected.png:
- platform/mac-leopard/css1/box_properties/float_on_text_elements-expected.checksum:
- platform/mac-leopard/css1/box_properties/float_on_text_elements-expected.png:
- platform/mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
- platform/mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
- 6:39 PM Changeset in webkit [75462] by
-
- 5 edits in trunk/WebKit2
2011-01-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Pass information about the view in the WebPageCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=52186
- Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode): Encode and decode the state flags.
- Shared/WebPageCreationParameters.h: Add new state flags.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): Initialize the state flags.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Update the page state from the state flags.
- 6:26 PM Changeset in webkit [75461] by
-
- 3 edits6 adds in trunk
2011-01-10 Joe Mason <jmason@rim.com>
Reviewed by Alexey Proskuryakov.
WebSockets: unbounded buffer growth when server sends bad data
https://bugs.webkit.org/show_bug.cgi?id=51253
Tests that a websocket handshake should fail after 1024 bytes without a
newline, or if it contains a null byte before the first newline.
- http/tests/websocket/tests/handshake-fail-by-maxlength-expected.txt: Added.
- http/tests/websocket/tests/handshake-fail-by-maxlength.html: Added.
- http/tests/websocket/tests/handshake-fail-by-maxlength_wsh.py: Added.
- http/tests/websocket/tests/handshake-fail-by-prepended-null-expected.txt: Added.
- http/tests/websocket/tests/handshake-fail-by-prepended-null.html: Added.
- http/tests/websocket/tests/handshake-fail-by-prepended-null_wsh.py: Added.
2011-01-10 Joe Mason <jmason@rim.com>
Reviewed by Alexey Proskuryakov.
WebSockets: unbounded buffer growth when server sends bad data
https://bugs.webkit.org/show_bug.cgi?id=51253
Fail a websocket handshake after 1024 bytes without a newline, or if it
contains a null byte before the first newline.
Tests: http/tests/websocket/tests/handshake-fail-by-maxlength.html
http/tests/websocket/tests/handshake-fail-by-prepended-null.html
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readStatusLine):
- 6:13 PM Changeset in webkit [75460] by
-
- 23 edits8 adds in trunk/WebKit2
Make Geolocation features work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52078
Reviewed by Anders Carlsson.
Step 2 - Add support for requesting and granting permission for geolocation.
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- UIProcess/API/C/WebKit2.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKGeolocationPermissionRequest.cpp: Added.
- UIProcess/API/C/WKGeolocationPermissionRequest.h: Added.
Add new API type, WKGeolocationPermissionRequestRef.
- UIProcess/API/C/WKPage.h:
Add new UIClient function for requesting permission.
- UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
Stub out the UIClient.
- UIProcess/GeolocationPermissionRequestManagerProxy.cpp: Added.
- UIProcess/GeolocationPermissionRequestManagerProxy.h: Added.
- UIProcess/GeolocationPermissionRequestProxy.cpp: Added.
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
- UIProcess/WebUIClient.h:
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: Added.
- WebProcess/Geolocation/GeolocationPermissionRequestManager.h: Added.
- WebProcess/Geolocation/WebGeolocationManager.cpp:
- WebProcess/Geolocation/WebGeolocationManager.h:
- WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
- WebProcess/WebCoreSupport/WebGeolocationClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::didReceiveGeolocationPermissionDecision):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::geolocationPermissionRequestManager):
- WebProcess/WebPage/WebPage.messages.in:
Track the permission request through both sides of the process divide.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
Add new files.
- 6:12 PM Changeset in webkit [75459] by
-
- 11 edits in trunk/WebKit2
2011-01-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=52184
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::createDrawingAreaProxy): Call -[WKView _createDrawingAreaProxy].
(WebKit::PageClientImpl::setViewNeedsDisplay):
Call setNeedsDisplayInRect on the WKView.
- UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): No need to set the drawing area proxy anymore.
(-[WKView _createDrawingAreaProxy]):
Create a chunked update drawing area proxy for now.
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy): (QWKPagePrivate::setViewNeedsDisplay): Add stubs.
- UIProcess/PageClient.h: Add new pure virtual member functions.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::reinitializeWebPage): Set the new drawing area proxy.
- UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): No need to set the drawing area proxy anymore.
(WebKit::WebView::createDrawingAreaProxy):
Create a chunked update drawing area proxy for now.
(WebKit::WebView::setViewNeedsDisplay):
Invalidate the window.
- 6:09 PM Changeset in webkit [75458] by
-
- 1 copy in releases/WebKitGTK/webkit-1.3.10
Branching for WebKitGTK+ release
- 5:33 PM Changeset in webkit [75457] by
-
- 2 edits in trunk/WebKit2
Fix Windows build again.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::isViewWindowActive):
- 5:06 PM Changeset in webkit [75456] by
-
- 2 edits in trunk/WebKit2
Fix Windows build.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::onShowWindowEvent):
- 5:02 PM Changeset in webkit [75455] by
-
- 9 edits in trunk
2011-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
This patch adds a Chromium API for registering schemes as
display-isolated. In a subsequent patch, I'll change the "chrome"
scheme in Chrome to be display isolated instead of local. That will
prevent file URLs from linking to chrome URLs.
- public/WebSecurityPolicy.h:
- src/WebSecurityPolicy.cpp: (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):
2011-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
Update to new function name.
- Api/qwebsecurityorigin.cpp: (QWebSecurityOrigin::localSchemes):
2011-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
This patch adds the basic plumbing for display-isolated URL schemes.
Originally, this patch also had the functional change, but I've split
that off into a separate patch because the original patch caused a
performance regression.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay):
- platform/SchemeRegistry.cpp: (WebCore::displayIsolatedURLSchemes): (WebCore::SchemeRegistry::registerURLSchemeAsLocal): (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal): (WebCore::SchemeRegistry::localSchemes): (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal): (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
- platform/SchemeRegistry.h:
- 4:51 PM Changeset in webkit [75454] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-01-10 Daniel Bates <dbates@rim.com>
Reviewed by Martin Robinson.
Remove extraneous COMPILER(GCC) condition when checking GCC_VERSION_AT_LEAST()
https://bugs.webkit.org/show_bug.cgi?id=52178
It is sufficient to test GCC_VERSION_AT_LEAST() instead of both COMPILER(GCC) and
GCC_VERSION_AT_LEAST(). Notice GCC_VERSION_AT_LEAST() is defined to be 0 when we
are not compiling with GCC.
Fixes style issues at the callsites (i.e. replace comma with comma-space in
macro function argument list). Also, makes a spelling correction in a comment.
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
- wtf/Platform.h:
- 4:47 PM Changeset in webkit [75453] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix: removed some uses of nextNumber that I missed last time.
- runtime/Heap.cpp:
(JSC::Heap::reset):
(JSC::Heap::collectAllGarbage):
- 4:45 PM Changeset in webkit [75452] by
-
- 17 edits in trunk/WebKit2
2011-01-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Use a pull model for view state changes
https://bugs.webkit.org/show_bug.cgi?id=52175
Instead of having the WKView call setFocused, setActive etc on the WebPageProxy, the
WKView now simply informs the WebPageProxy what has changed, using the WebPageProxy::viewStateDidChange
function. The WebPageProxy can then fetch the relevant information using newly added PageClient functions.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::viewSize): (WebKit::PageClientImpl::isViewWindowActive): (WebKit::PageClientImpl::isViewFocused): (WebKit::PageClientImpl::isViewVisible): (WebKit::PageClientImpl::isViewInWindow):
- UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): (-[WKView becomeFirstResponder]): (-[WKView resignFirstResponder]): (-[WKView viewDidMoveToWindow]): (-[WKView _windowDidBecomeKey:]): (-[WKView _windowDidResignKey:]): (-[WKView viewDidHide]): (-[WKView viewDidUnhide]): (-[WKView _isFocused]): (-[WKView _didRelaunchProcess]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::focusInEvent): (QGraphicsWKView::focusOutEvent):
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::viewSize): (QWKPagePrivate::isViewWindowActive): (QWKPagePrivate::isViewFocused): (QWKPagePrivate::isViewVisible): (QWKPagePrivate::isViewInWindow):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebContext.cpp: (WebKit::WebContext::createWebPage):
- UIProcess/WebContext.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::create): (WebKit::WebPageProxy::WebPageProxy): (WebKit::WebPageProxy::viewStateDidChange):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::createWebPage):
- UIProcess/WebProcessProxy.h:
- UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::onSetFocusEvent): (WebKit::WebView::onKillFocusEvent): (WebKit::WebView::onShowWindowEvent): (WebKit::WebView::updateActiveState): (WebKit::WebView::viewSize): (WebKit::WebView::isViewWindowActive): (WebKit::WebView::isViewFocused): (WebKit::WebView::isViewVisible): (WebKit::WebView::isViewInWindow): (WebKit::WebView::didRelaunchProcess): (WebKit::WebView::setIsInWindow):
- UIProcess/win/WebView.h:
- 4:41 PM Changeset in webkit [75451] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed dead number allocation code.
https://bugs.webkit.org/show_bug.cgi?id=52177
- runtime/Heap.h:
- 4:29 PM Changeset in webkit [75450] by
-
- 7 edits in trunk
2011-01-10 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=52095
REGRESSION (r75277): 2 test cases (<1%) had incorrect layout
Fixes tests:
fullscreen/full-screen-remove-ancestor.html
fullscreen/full-screen-remove.html
Revert change made in r75326, now that the underlying issue has been fixed.
- fullscreen/full-screen-remove-ancestor-expected.txt:
- fullscreen/full-screen-remove-expected.txt:
2011-01-10 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=52095
REGRESSION (r75277): 2 test cases (<1%) had incorrect layout
Fixes tests:
fullscreen/full-screen-remove-ancestor.html
fullscreen/full-screen-remove.html
Previously, the above tests were failing because DRT dumped the contents of their
<script> tags, though all the explicit tests were passing. This was caused by
the document's render tree being left in an inconsistent state when a full screen
element's ancestor was removed from the DOM.
In nodeWillBeRemoved(), match the code in webkitDidExitFullScreen().
Don't detach the documentElement, but rather simply call recalcStyle(Force).
- dom/Document.cpp: (WebCore::Document::nodeWillBeRemoved):
- rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating): #if ENABLED -> # if USE
- rendering/RenderFullScreen.h: (WebCore::RenderFullScreen::RenderFullScreen): RenderFullScreen should be an anonymous renderer.
- 4:29 PM Changeset in webkit [75449] by
-
- 2 edits in trunk/WebKit/gtk
2011-01-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Update the NEWS file in preparation for the 1.3.10 release.
- NEWS: Update the NEWS.
- 4:27 PM Changeset in webkit [75448] by
-
- 12 edits in trunk
2011-01-10 John Abd-El-Malek <jam@chromium.org>
Reviewed by James Robinson.
[chromium] Call WebAutoFillClient instead of WebViewClient for autofill related callbacks
https://bugs.webkit.org/show_bug.cgi?id=52169
- public/WebView.h:
- public/WebViewClient.h: (WebKit::WebViewClient::didUpdateInspectorSetting):
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionChanged): (WebKit::AutoFillPopupMenuClient::selectionCleared): (WebKit::AutoFillPopupMenuClient::popupDidHide):
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::textFieldDidBeginEditing): (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::textDidChangeInTextField): (WebKit::EditorClientImpl::doAutofill): (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted): (WebKit::EditorClientImpl::doTextFieldCommandFromEvent):
- src/WebViewImpl.cpp: (WebKit::WebView::create): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
- src/WebViewImpl.h: (WebKit::WebViewImpl::autoFillClient):
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::initializeLoader):
- 4:17 PM Changeset in webkit [75447] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-01-10 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Use builtin_expect when compiling using RVCT in GNU mode
https://bugs.webkit.org/show_bug.cgi?id=51866
We should only use builtin_expect if we are compiling with GCC or RVCT 3 or higher in GNU mode
as pointed out by Siddharth Mathur per <http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0202h/Cjabddedbde.html>.
- wtf/AlwaysInline.h:
- wtf/Platform.h: Removed define WTF_COMPILER_RVCT4_OR_GREATER. Instead added macro function RVCT_VERSION_AT_LEAST so that we can test for an arbitrary minimum RVCT version.
- 4:16 PM Changeset in webkit [75446] by
-
- 3 edits30 deletes in trunk/LayoutTests
2011-01-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
Remove chromium-mac baselines for svg/ tests that had them because of
scrollbars.
Also updates Snow Leopard (mac) baselines for svg/dom/
SVGLengthList-basics.xhtml after r72518.
- platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Removed.
- platform/chromium-mac/svg/hixie/links/003-broken-expected.checksum: Removed.
- platform/chromium-mac/svg/hixie/links/003-broken-expected.png: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
- platform/mac/svg/dom/SVGLengthList-basics-expected.checksum:
- platform/mac/svg/dom/SVGLengthList-basics-expected.png:
- 4:05 PM Changeset in webkit [75445] by
-
- 2 edits in trunk/WebKit/win
Try to fix Windows build.
- WebJavaScriptCollector.cpp: Updated for rename to Heap.*. (Didn't catch
this one before because it was miscapitalized.)
- 3:52 PM Changeset in webkit [75444] by
-
- 6 edits in trunk
2011-01-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Remove use of deprecated GTK+ methods before the 1.3.10 release
https://bugs.webkit.org/show_bug.cgi?id=52173
No new tests. This is only a build fix.
- platform/gtk/GRefPtrGtk.cpp: Guard the GdkCursor specialization against GTK+ 3.x. In GTK+ 3.x, GdkCursor is just a GObject.
- platform/gtk/GRefPtrGtk.h: Ditto.
2011-01-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Remove use of deprecated GTK+ methods before the 1.3.10 release
https://bugs.webkit.org/show_bug.cgi?id=52173
- WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::enterFullscreen): Use a GRefPtr here to avoid having to call either g_object_unref or gdk_cursor_unref.
- webkit/webkitwebview.cpp: Guard use of deprecated methods. (webkit_web_view_realize): Ditto. (webkit_web_view_drag_end): Ditto.
- 3:43 PM Changeset in webkit [75443] by
-
- 32 edits3 moves in trunk/Source
Moved Collector.* => Heap.*, since the file contains a class named "Heap".
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- API/JSCallbackObject.cpp:
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- interpreter/Interpreter.cpp:
- interpreter/RegisterFile.h:
- jit/JITStubs.cpp:
- runtime/Collector.cpp: Removed.
- runtime/Collector.h: Removed.
- runtime/CollectorHeapIterator.h:
- runtime/GCActivityCallbackCF.cpp:
- runtime/Heap.cpp: Copied from JavaScriptCore/runtime/Collector.cpp.
- runtime/Heap.h: Copied from JavaScriptCore/runtime/Collector.h.
- runtime/InitializeThreading.cpp:
- runtime/JSCell.h:
- runtime/JSGlobalData.cpp:
- runtime/JSGlobalData.h:
- runtime/JSLock.cpp:
- runtime/JSNumberCell.h:
- runtime/MachineStackMarker.cpp:
- runtime/MemoryStatistics.h:
- runtime/Protect.h:
- runtime/UString.cpp:
- runtime/WeakGCMap.h:
- runtime/WeakGCPtr.h:
Source/JavaScriptGlue:
- JSUtils.h:
Source/WebCore:
- ForwardingHeaders/runtime/Collector.h: Removed.
- ForwardingHeaders/runtime/Heap.h: Copied from WebCore/ForwardingHeaders/runtime/Collector.h.
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/GCController.cpp:
- bindings/js/ScriptGCEvent.cpp:
- 3:30 PM Changeset in webkit [75442] by
-
- 2 edits in trunk/LayoutTests
[chromium] Layout test fast/frames/iframe-reparenting-plugins.html is failing on windows
https://bugs.webkit.org/show_bug.cgi?id=52062
Patch by Jenn Braithwaite <jennb@chromium.org> on 2011-01-10
Reviewed by Dmitry Titov.
- platform/chromium/test_expectations.txt:
Skip the failing test. Same reason other tests using WebKit Test PlugIn fails.
- 3:14 PM Changeset in webkit [75441] by
-
- 4 edits in trunk/LayoutTests
2011-01-10 Martin Robinson <mrobinson@igalia.com>
Rebaseline some test results after r75389.
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 3:04 PM Changeset in webkit [75440] by
-
- 12 edits2 adds7 deletes in trunk/LayoutTests
2011-01-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
More scrollbar change rebaselines.
- platform/chromium-mac/fast/selectors/166-expected.checksum: Removed.
- platform/chromium-mac/fast/selectors/166-expected.png: Removed.
- platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/height-percent-test-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png: Removed.
- platform/chromium-mac/svg/css/composite-shadow-example-expected.checksum:
- platform/chromium-mac/svg/css/composite-shadow-example-expected.png:
- platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.checksum:
- platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.png:
- platform/chromium-mac/svg/css/stars-with-shadow-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
- platform/mac-leopard/fast/table/border-collapsing/004-vertical-expected.png: Added.
- platform/mac/fast/table/border-collapsing/004-vertical-expected.checksum:
- platform/mac/fast/table/border-collapsing/004-vertical-expected.png:
- platform/mac/fast/table/height-percent-test-vertical-expected.checksum:
- platform/mac/fast/table/height-percent-test-vertical-expected.png:
- 2:47 PM Changeset in webkit [75439] by
-
- 2 edits in trunk/Source/WebCore
2011-01-10 Leonid Ebril <leonid.ebril@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Set the PluginQuirkDontSetNullWindowHandleOnDestroy for Adobe Lite
plugin if Flash 10 or newer (for Symbian platform), setting a nulled
window handler on destroy crashes WebKit.
- plugins/symbian/PluginPackageSymbian.cpp: (WebCore::PluginPackage::fetchInfo): (WebCore::PluginPackage::determineQuirks):
- 2:37 PM Changeset in webkit [75438] by
-
- 3 edits in trunk/Tools
2011-01-10 Eric Seidel <eric@webkit.org>
Reviewed by Ojan Vafai.
style-queue messages are way too long for big patches
https://bugs.webkit.org/show_bug.cgi?id=52161
We definitely could build much fancier list-to-string-with-limit functions
but this should be sufficient for our needs at the moment.
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/common/system/executive_unittest.py:
- 2:04 PM Changeset in webkit [75437] by
-
- 8 edits1 move2 deletes in trunk/Source/WebCore
2011-01-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Remove unecessary RenderThemeGtk and WidgetRenderingContext code
https://bugs.webkit.org/show_bug.cgi?id=52170
Remove unnecessary code from RenderThemeGtk3 and RenderThemeGtk now that the
GtkStyleContext port is complete. Also remove WidgetRenderingContextGtk3 and
move WidgetRenderingRenderingContextGtk2 to WidgetRenderingContext and make it
GTK+ 2.x only. Some methods have been moved to RenderThemeGtk2 since they are
GTK+ 2.x only now.
No new tests. This should not change functionality.
- GNUmakefile.am: Remove WidgetRenderingContextGtk3 and gtk3drawing.c
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::gtkIconState): Made this method static. It isn't used outside RenderThemeGtk. (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): Updated to refelct gtkIconState change. (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): Ditto. (WebCore::RenderThemeGtk::paintMediaButton): Ditto
- platform/gtk/RenderThemeGtk.h: Move a few methods which are now GTK+ 2.x only.
- platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::platformInit): Added this platform initialization method that is only used for GTK+ 2.x at the moment. (WebCore::RenderThemeGtk::~RenderThemeGtk): Added. (WebCore::getGtkStateType): Made this method static. (WebCore::RenderThemeGtk::getIndicatorMetrics): Moved this here from RenderThemeGtk. (WebCore::setToggleSize): Updated to reflect changes to getGtkStateType. (WebCore::RenderThemeGtk::paintButton): Ditto. (WebCore::RenderThemeGtk::paintSliderTrack): Ditto. (WebCore::RenderThemeGtk::paintSliderThumb): Ditto.
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::gtkScrollbarStyle): Moved to the top of the file. (WebCore::RenderThemeGtk::platformInit): Added. (WebCore::RenderThemeGtk::~RenderThemeGtk): Added. (WebCore::RenderThemeGtk::initMediaColors): Changed to use the GtkStyleContext API to fetch these colors. This was the last dependency on the old API.
- platform/gtk/WidgetRenderingContext.cpp: Renamed from Source/WebCore/platform/gtk/WidgetRenderingContextGtk2.cpp.
- platform/gtk/WidgetRenderingContext.h: Made GTK+ 2.x only.
- platform/gtk/WidgetRenderingContextGtk3.cpp: Removed.
- platform/gtk/gtk3drawing.c: Removed.
- platform/gtk/gtkdrawing.h: Made GTK+ 2.x only.
- 2:03 PM Changeset in webkit [75436] by
-
- 1 edit in branches/chromium/597/WebCore/dom/Range.cpp
Merge 75002 - Merge 73818 Build Fix
BUG=65942
Review URL: http://codereview.chromium.org/6085014
- 2:02 PM Changeset in webkit [75435] by
-
- 2 edits in trunk/WebKit2
Don't pass a reference type to va_start
C++ says this results in undefined behavior:
The restrictions that ISO C places on the second parameter to the
va_start() macro in header <stdarg.h> are different in this
International Standard. The parameter parmN is the identifier of
the rightmost parameter in the variable parameter list of the
function definition (the one just before the ...).221) If the
parameter parmN is declared with a function, array, or reference
type, or with a type that is not compatible with the type that
results when passing an argument for which there is no parameter,
the behavior is undefined.
Fixes <http://webkit.org/b/52168> Title of standalone image document
includes bogus image dimensions
Rubber-stamped by Eric Seidel.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::formatLocalizedString): Don't use a reference type for
|format|.
- 2:01 PM Changeset in webkit [75434] by
-
- 1 edit in branches/chromium/597/WebCore/dom/Range.cpp
Merge 73818
BUG=65942
Review URL: http://codereview.chromium.org/6217002
- 2:00 PM Changeset in webkit [75433] by
-
- 5 edits2 adds in trunk
2011-01-10 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r75398, r75407,
http://trac.webkit.org/changeset/75398
https://bugs.webkit.org/show_bug.cgi?id=52008
Some layout tests are crashing on Chromium Win.
- platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.checksum: Added.
- platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.png: Added.
- platform/chromium/test_expectations.txt:
2011-01-10 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r75398.
http://trac.webkit.org/changeset/75398
https://bugs.webkit.org/show_bug.cgi?id=52008
Some layout tests are crashing on Chromium Win.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::updatePaintRect):
- DumpRenderTree/chromium/WebViewHost.h:
- 2:00 PM Changeset in webkit [75432] by
-
- 1 edit2 copies in branches/chromium/597
Merge 73799
BUG=65942
Review URL: http://codereview.chromium.org/6129003
- 1:57 PM Changeset in webkit [75431] by
-
- 14 edits4 adds in trunk/LayoutTests
2011-01-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
Rebaseline six tests in fast/repaint for chromium-mac. Even after the
scrollbar switch they need Chromium-specific results since repaint
regions are different from the mac port's.
Adds both Leopard (chromium-mac-leopard) and Snow Leopard (chromium-mac)
baselines.
- platform/chromium-mac-leopard/fast/repaint/fixed-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/repaint/fixed-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
- platform/chromium-mac/fast/repaint/fixed-expected.checksum:
- platform/chromium-mac/fast/repaint/fixed-expected.png:
- platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
- platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
- platform/chromium-mac/fast/repaint/fixed-tranformed-expected.checksum:
- platform/chromium-mac/fast/repaint/fixed-tranformed-expected.png:
- platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.checksum:
- platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
- platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.checksum:
- platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
- platform/chromium-mac/fast/repaint/repaint-during-scroll-expected.checksum:
- platform/chromium-mac/fast/repaint/repaint-during-scroll-expected.png:
- platform/chromium/test_expectations.txt:
- 1:56 PM Changeset in webkit [75430] by
-
- 4 edits2 copies in branches/chromium/597
Merge 75014 - Merge 74636
BUG=67363
Review URL: http://codereview.chromium.org/6186003
- 1:54 PM Changeset in webkit [75429] by
-
- 1 edit2 copies in branches/chromium/597
Merge 74979 - Merge 73801
BUG=66473
Review URL: http://codereview.chromium.org/6180005
- 1:23 PM Changeset in webkit [75428] by
-
- 2 edits4 copies in branches/chromium/597
Merge 75193 - Merge 75168
BUG=68558
Review URL: http://codereview.chromium.org/6139003
- 1:21 PM Changeset in webkit [75427] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Gavin Barraclough.
Remove unused isString() case in JSString::toPrimitiveString()
https://bugs.webkit.org/show_bug.cgi?id=52167
We never call toPrimitiveString() with strings, so remove the
check and add an ASSERT ensuring this never happens. 0.7% overall
progression in sunspider, since one of the call sites is very hot.
- runtime/JSString.h: (JSC::JSValue::toPrimitiveString):
- 1:21 PM Changeset in webkit [75426] by
-
- 3 edits2 copies in branches/chromium/597
Merge 75008 - Merge 74574
BUG=66748
Review URL: http://codereview.chromium.org/6206004
- 1:19 PM Changeset in webkit [75425] by
-
- 1 edit2 copies in branches/chromium/597
Merge 75028 - Merge 74779
BUG=68178
Review URL: http://codereview.chromium.org/6157003
- 1:17 PM Changeset in webkit [75424] by
-
- 1 edit2 copies in branches/chromium/597
Merge 74984 - Merge 74787
BUG=68181
Review URL: http://codereview.chromium.org/6222002
- 1:15 PM Changeset in webkit [75423] by
-
- 3 edits16 copies2 deletes in branches/chromium/597
Merge 74987 - Merge 74954
BUG=66760
Review URL: http://codereview.chromium.org/6200003
- 1:11 PM Changeset in webkit [75422] by
-
- 1 edit2 copies in branches/chromium/597
Merge 74986 - Merge 74364
BUG=66760
- 1:08 PM Changeset in webkit [75421] by
-
- 11 edits7 adds7 deletes in trunk/Source/JavaScriptCore
Rename the existing YARR files and classes
https://bugs.webkit.org/show_bug.cgi?id=51872
Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2011-01-10
Reviewed by Gavin Barraclough.
Replace the "Regex" prefix with "Yarr" in the name of YARR files and classes.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::match):
(JSC::RegExp::printTraceData):
- yarr/YarrInterpreter.cpp: Renamed from Source/JavaScriptCore/yarr/RegexInterpreter.cpp.
(JSC::Yarr::Interpreter::appendParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::popParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::DisjunctionContext::DisjunctionContext):
(JSC::Yarr::Interpreter::DisjunctionContext::operator new):
(JSC::Yarr::Interpreter::allocDisjunctionContext):
(JSC::Yarr::Interpreter::freeDisjunctionContext):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::operator new):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::restoreOutput):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::getDisjunctionContext):
(JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::InputStream::InputStream):
(JSC::Yarr::Interpreter::InputStream::next):
(JSC::Yarr::Interpreter::InputStream::rewind):
(JSC::Yarr::Interpreter::InputStream::read):
(JSC::Yarr::Interpreter::InputStream::readPair):
(JSC::Yarr::Interpreter::InputStream::readChecked):
(JSC::Yarr::Interpreter::InputStream::reread):
(JSC::Yarr::Interpreter::InputStream::prev):
(JSC::Yarr::Interpreter::InputStream::getPos):
(JSC::Yarr::Interpreter::InputStream::setPos):
(JSC::Yarr::Interpreter::InputStream::atStart):
(JSC::Yarr::Interpreter::InputStream::atEnd):
(JSC::Yarr::Interpreter::InputStream::checkInput):
(JSC::Yarr::Interpreter::InputStream::uncheckInput):
(JSC::Yarr::Interpreter::InputStream::isNotAvailableInput):
(JSC::Yarr::Interpreter::testCharacterClass):
(JSC::Yarr::Interpreter::checkCharacter):
(JSC::Yarr::Interpreter::checkCasedCharacter):
(JSC::Yarr::Interpreter::checkCharacterClass):
(JSC::Yarr::Interpreter::tryConsumeBackReference):
(JSC::Yarr::Interpreter::matchAssertionBOL):
(JSC::Yarr::Interpreter::matchAssertionEOL):
(JSC::Yarr::Interpreter::matchAssertionWordBoundary):
(JSC::Yarr::Interpreter::backtrackPatternCharacter):
(JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
(JSC::Yarr::Interpreter::matchCharacterClass):
(JSC::Yarr::Interpreter::backtrackCharacterClass):
(JSC::Yarr::Interpreter::matchBackReference):
(JSC::Yarr::Interpreter::backtrackBackReference):
(JSC::Yarr::Interpreter::recordParenthesesMatch):
(JSC::Yarr::Interpreter::resetMatches):
(JSC::Yarr::Interpreter::parenthesesDoBacktrack):
(JSC::Yarr::Interpreter::matchParenthesesOnceBegin):
(JSC::Yarr::Interpreter::matchParenthesesOnceEnd):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
(JSC::Yarr::Interpreter::matchParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::matchParenthesesTerminalEnd):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalEnd):
(JSC::Yarr::Interpreter::matchParentheticalAssertionBegin):
(JSC::Yarr::Interpreter::matchParentheticalAssertionEnd):
(JSC::Yarr::Interpreter::backtrackParentheticalAssertionBegin):
(JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd):
(JSC::Yarr::Interpreter::matchParentheses):
(JSC::Yarr::Interpreter::backtrackParentheses):
(JSC::Yarr::Interpreter::lookupForBeginChars):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::matchNonZeroDisjunction):
(JSC::Yarr::Interpreter::interpret):
(JSC::Yarr::Interpreter::Interpreter):
(JSC::Yarr::ByteCompiler::ParenthesesStackEntry::ParenthesesStackEntry):
(JSC::Yarr::ByteCompiler::ByteCompiler):
(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::checkInput):
(JSC::Yarr::ByteCompiler::assertionBOL):
(JSC::Yarr::ByteCompiler::assertionEOL):
(JSC::Yarr::ByteCompiler::assertionWordBoundary):
(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::popParenthesesStack):
(JSC::Yarr::ByteCompiler::dumpDisjunction):
(JSC::Yarr::ByteCompiler::closeAlternative):
(JSC::Yarr::ByteCompiler::closeBodyAlternative):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::ByteCompiler::regexEnd):
(JSC::Yarr::ByteCompiler::alternativeBodyDisjunction):
(JSC::Yarr::ByteCompiler::alternativeDisjunction):
(JSC::Yarr::ByteCompiler::emitDisjunction):
(JSC::Yarr::byteCompile):
(JSC::Yarr::interpret):
- yarr/YarrInterpreter.h: Renamed from Source/JavaScriptCore/yarr/RegexInterpreter.h.
(JSC::Yarr::ByteTerm::ByteTerm):
(JSC::Yarr::ByteTerm::BOL):
(JSC::Yarr::ByteTerm::CheckInput):
(JSC::Yarr::ByteTerm::EOL):
(JSC::Yarr::ByteTerm::WordBoundary):
(JSC::Yarr::ByteTerm::BackReference):
(JSC::Yarr::ByteTerm::BodyAlternativeBegin):
(JSC::Yarr::ByteTerm::BodyAlternativeDisjunction):
(JSC::Yarr::ByteTerm::BodyAlternativeEnd):
(JSC::Yarr::ByteTerm::AlternativeBegin):
(JSC::Yarr::ByteTerm::AlternativeDisjunction):
(JSC::Yarr::ByteTerm::AlternativeEnd):
(JSC::Yarr::ByteTerm::SubpatternBegin):
(JSC::Yarr::ByteTerm::SubpatternEnd):
(JSC::Yarr::ByteTerm::invert):
(JSC::Yarr::ByteTerm::capture):
(JSC::Yarr::ByteDisjunction::ByteDisjunction):
(JSC::Yarr::BytecodePattern::BytecodePattern):
(JSC::Yarr::BytecodePattern::~BytecodePattern):
- yarr/YarrJIT.cpp: Renamed from Source/JavaScriptCore/yarr/RegexJIT.cpp.
(JSC::Yarr::YarrGenerator::optimizeAlternative):
(JSC::Yarr::YarrGenerator::matchCharacterClassRange):
(JSC::Yarr::YarrGenerator::matchCharacterClass):
(JSC::Yarr::YarrGenerator::jumpIfNoAvailableInput):
(JSC::Yarr::YarrGenerator::jumpIfAvailableInput):
(JSC::Yarr::YarrGenerator::checkInput):
(JSC::Yarr::YarrGenerator::atEndOfInput):
(JSC::Yarr::YarrGenerator::notAtEndOfInput):
(JSC::Yarr::YarrGenerator::jumpIfCharEquals):
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::readCharacter):
(JSC::Yarr::YarrGenerator::storeToFrame):
(JSC::Yarr::YarrGenerator::storeToFrameWithPatch):
(JSC::Yarr::YarrGenerator::loadFromFrame):
(JSC::Yarr::YarrGenerator::loadFromFrameAndJump):
(JSC::Yarr::YarrGenerator::IndirectJumpEntry::IndirectJumpEntry):
(JSC::Yarr::YarrGenerator::IndirectJumpEntry::addJump):
(JSC::Yarr::YarrGenerator::AlternativeBacktrackRecord::AlternativeBacktrackRecord):
(JSC::Yarr::YarrGenerator::GenerationState::GenerationState):
(JSC::Yarr::YarrGenerator::GenerationState::addIndirectJumpEntry):
(JSC::Yarr::YarrGenerator::GenerationState::emitIndirectJumpTable):
(JSC::Yarr::YarrGenerator::GenerationState::incrementParenNestingLevel):
(JSC::Yarr::YarrGenerator::GenerationState::decrementParenNestingLevel):
(JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):
(JSC::Yarr::YarrGenerator::GenerationState::emitParenthesesTail):
(JSC::Yarr::YarrGenerator::GenerationState::addJumpToNextInteration):
(JSC::Yarr::YarrGenerator::GenerationState::addJumpsToNextInteration):
(JSC::Yarr::YarrGenerator::GenerationState::addDataLabelToNextIteration):
(JSC::Yarr::YarrGenerator::GenerationState::linkToNextIteration):
(JSC::Yarr::YarrGenerator::BacktrackDestination::BacktrackDestination):
(JSC::Yarr::YarrGenerator::BacktrackDestination::clear):
(JSC::Yarr::YarrGenerator::BacktrackDestination::clearDataLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::hasDestination):
(JSC::Yarr::YarrGenerator::BacktrackDestination::isStackOffset):
(JSC::Yarr::YarrGenerator::BacktrackDestination::isLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::isJumpList):
(JSC::Yarr::YarrGenerator::BacktrackDestination::hasDataLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::copyTarget):
(JSC::Yarr::YarrGenerator::BacktrackDestination::copyTo):
(JSC::Yarr::YarrGenerator::BacktrackDestination::addBacktrackJump):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setStackOffset):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setNextBacktrackLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::copyBacktrackToLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setBacktrackToLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setBacktrackJumpList):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setBacktrackSourceLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setDataLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setSubDataLabelPtr):
(JSC::Yarr::YarrGenerator::BacktrackDestination::linkToNextBacktrack):
(JSC::Yarr::YarrGenerator::BacktrackDestination::getStackOffset):
(JSC::Yarr::YarrGenerator::BacktrackDestination::getLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::getBacktrackJumps):
(JSC::Yarr::YarrGenerator::BacktrackDestination::getDataLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::jumpToBacktrack):
(JSC::Yarr::YarrGenerator::BacktrackDestination::linkDataLabelToHereIfExists):
(JSC::Yarr::YarrGenerator::BacktrackDestination::plantJumpToBacktrackIfExists):
(JSC::Yarr::YarrGenerator::BacktrackDestination::linkAlternativeBacktracks):
(JSC::Yarr::YarrGenerator::BacktrackDestination::linkAlternativeBacktracksTo):
(JSC::Yarr::YarrGenerator::TermGenerationState::TermGenerationState):
(JSC::Yarr::YarrGenerator::TermGenerationState::resetAlternative):
(JSC::Yarr::YarrGenerator::TermGenerationState::alternativeValid):
(JSC::Yarr::YarrGenerator::TermGenerationState::nextAlternative):
(JSC::Yarr::YarrGenerator::TermGenerationState::alternative):
(JSC::Yarr::YarrGenerator::TermGenerationState::isLastAlternative):
(JSC::Yarr::YarrGenerator::TermGenerationState::resetTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::termValid):
(JSC::Yarr::YarrGenerator::TermGenerationState::nextTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::term):
(JSC::Yarr::YarrGenerator::TermGenerationState::isLastTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::getSubParenNum):
(JSC::Yarr::YarrGenerator::TermGenerationState::isMainDisjunction):
(JSC::Yarr::YarrGenerator::TermGenerationState::setParenthesesTail):
(JSC::Yarr::YarrGenerator::TermGenerationState::getParenthesesTail):
(JSC::Yarr::YarrGenerator::TermGenerationState::lookaheadTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::isSinglePatternCharacterLookaheadTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::inputOffset):
(JSC::Yarr::YarrGenerator::TermGenerationState::clearBacktrack):
(JSC::Yarr::YarrGenerator::TermGenerationState::jumpToBacktrack):
(JSC::Yarr::YarrGenerator::TermGenerationState::plantJumpToBacktrackIfExists):
(JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
(JSC::Yarr::YarrGenerator::TermGenerationState::addBacktrackJump):
(JSC::Yarr::YarrGenerator::TermGenerationState::setBacktrackDataLabel):
(JSC::Yarr::YarrGenerator::TermGenerationState::setBackTrackStackOffset):
(JSC::Yarr::YarrGenerator::TermGenerationState::setBacktrackLabel):
(JSC::Yarr::YarrGenerator::TermGenerationState::linkAlternativeBacktracks):
(JSC::Yarr::YarrGenerator::TermGenerationState::linkAlternativeBacktracksTo):
(JSC::Yarr::YarrGenerator::TermGenerationState::setBacktrackLink):
(JSC::Yarr::YarrGenerator::TermGenerationState::chainBacktracks):
(JSC::Yarr::YarrGenerator::TermGenerationState::chainBacktrackJumps):
(JSC::Yarr::YarrGenerator::TermGenerationState::getBacktrackDestination):
(JSC::Yarr::YarrGenerator::TermGenerationState::propagateBacktrackingFrom):
(JSC::Yarr::YarrGenerator::ParenthesesTail::ParenthesesTail):
(JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks):
(JSC::Yarr::YarrGenerator::ParenthesesTail::setNextIteration):
(JSC::Yarr::YarrGenerator::ParenthesesTail::addAfterParenJump):
(JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode):
(JSC::Yarr::YarrGenerator::generateAssertionBOL):
(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::matchAssertionWordchar):
(JSC::Yarr::YarrGenerator::generateAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::generatePatternCharacterSingle):
(JSC::Yarr::YarrGenerator::generatePatternCharacterPair):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassSingle):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generateParenthesesDisjunction):
(JSC::Yarr::YarrGenerator::generateParenthesesSingle):
(JSC::Yarr::YarrGenerator::generateParenthesesGreedyNoBacktrack):
(JSC::Yarr::YarrGenerator::generateParentheticalAssertion):
(JSC::Yarr::YarrGenerator::generateTerm):
(JSC::Yarr::YarrGenerator::generateDisjunction):
(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::compile):
(JSC::Yarr::jitCompile):
- yarr/YarrJIT.h: Renamed from Source/JavaScriptCore/yarr/RegexJIT.h.
(JSC::Yarr::YarrCodeBlock::YarrCodeBlock):
(JSC::Yarr::YarrCodeBlock::~YarrCodeBlock):
(JSC::Yarr::YarrCodeBlock::setFallBack):
(JSC::Yarr::YarrCodeBlock::isFallBack):
(JSC::Yarr::YarrCodeBlock::set):
(JSC::Yarr::YarrCodeBlock::execute):
(JSC::Yarr::YarrCodeBlock::getAddr):
(JSC::Yarr::execute):
- yarr/YarrParser.h: Renamed from Source/JavaScriptCore/yarr/RegexParser.h.
(JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate):
(JSC::Yarr::Parser::CharacterClassParserDelegate::begin):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
(JSC::Yarr::Parser::CharacterClassParserDelegate::end):
(JSC::Yarr::Parser::CharacterClassParserDelegate::assertionWordBoundary):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBackReference):
(JSC::Yarr::Parser::Parser):
(JSC::Yarr::Parser::parseEscape):
(JSC::Yarr::Parser::parseAtomEscape):
(JSC::Yarr::Parser::parseCharacterClassEscape):
(JSC::Yarr::Parser::parseCharacterClass):
(JSC::Yarr::Parser::parseParenthesesBegin):
(JSC::Yarr::Parser::parseParenthesesEnd):
(JSC::Yarr::Parser::parseQuantifier):
(JSC::Yarr::Parser::parseTokens):
(JSC::Yarr::Parser::parse):
(JSC::Yarr::Parser::saveState):
(JSC::Yarr::Parser::restoreState):
(JSC::Yarr::Parser::atEndOfPattern):
(JSC::Yarr::Parser::peek):
(JSC::Yarr::Parser::peekIsDigit):
(JSC::Yarr::Parser::peekDigit):
(JSC::Yarr::Parser::consume):
(JSC::Yarr::Parser::consumeDigit):
(JSC::Yarr::Parser::consumeNumber):
(JSC::Yarr::Parser::consumeOctal):
(JSC::Yarr::Parser::tryConsume):
(JSC::Yarr::Parser::tryConsumeHex):
(JSC::Yarr::parse):
- yarr/YarrPattern.cpp: Renamed from Source/JavaScriptCore/yarr/RegexPattern.cpp.
(JSC::Yarr::CharacterClassConstructor::CharacterClassConstructor):
(JSC::Yarr::CharacterClassConstructor::reset):
(JSC::Yarr::CharacterClassConstructor::append):
(JSC::Yarr::CharacterClassConstructor::putChar):
(JSC::Yarr::CharacterClassConstructor::isUnicodeUpper):
(JSC::Yarr::CharacterClassConstructor::isUnicodeLower):
(JSC::Yarr::CharacterClassConstructor::putRange):
(JSC::Yarr::CharacterClassConstructor::charClass):
(JSC::Yarr::CharacterClassConstructor::addSorted):
(JSC::Yarr::CharacterClassConstructor::addSortedRange):
(JSC::Yarr::BeginCharHelper::BeginCharHelper):
(JSC::Yarr::BeginCharHelper::addBeginChar):
(JSC::Yarr::BeginCharHelper::merge):
(JSC::Yarr::BeginCharHelper::addCharacter):
(JSC::Yarr::BeginCharHelper::linkHotTerms):
(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPatternConstructor::~YarrPatternConstructor):
(JSC::Yarr::YarrPatternConstructor::reset):
(JSC::Yarr::YarrPatternConstructor::assertionBOL):
(JSC::Yarr::YarrPatternConstructor::assertionEOL):
(JSC::Yarr::YarrPatternConstructor::assertionWordBoundary):
(JSC::Yarr::YarrPatternConstructor::atomPatternCharacter):
(JSC::Yarr::YarrPatternConstructor::atomBuiltInCharacterClass):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassBegin):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassAtom):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassRange):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassBuiltIn):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassEnd):
(JSC::Yarr::YarrPatternConstructor::atomParenthesesSubpatternBegin):
(JSC::Yarr::YarrPatternConstructor::atomParentheticalAssertionBegin):
(JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
(JSC::Yarr::YarrPatternConstructor::atomBackReference):
(JSC::Yarr::YarrPatternConstructor::copyDisjunction):
(JSC::Yarr::YarrPatternConstructor::copyTerm):
(JSC::Yarr::YarrPatternConstructor::quantifyAtom):
(JSC::Yarr::YarrPatternConstructor::disjunction):
(JSC::Yarr::YarrPatternConstructor::regexBegin):
(JSC::Yarr::YarrPatternConstructor::regexEnd):
(JSC::Yarr::YarrPatternConstructor::regexError):
(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):
(JSC::Yarr::YarrPatternConstructor::setupDisjunctionOffsets):
(JSC::Yarr::YarrPatternConstructor::setupOffsets):
(JSC::Yarr::YarrPatternConstructor::checkForTerminalParentheses):
(JSC::Yarr::YarrPatternConstructor::optimizeBOL):
(JSC::Yarr::YarrPatternConstructor::addBeginTerm):
(JSC::Yarr::YarrPatternConstructor::setupDisjunctionBeginTerms):
(JSC::Yarr::YarrPatternConstructor::setupAlternativeBeginTerms):
(JSC::Yarr::YarrPatternConstructor::setupBeginChars):
(JSC::Yarr::compile):
(JSC::Yarr::YarrPattern::YarrPattern):
- yarr/YarrPattern.h: Renamed from Source/JavaScriptCore/yarr/RegexPattern.h.
(JSC::Yarr::CharacterRange::CharacterRange):
(JSC::Yarr::CharacterClassTable::create):
(JSC::Yarr::CharacterClassTable::CharacterClassTable):
(JSC::Yarr::CharacterClass::CharacterClass):
(JSC::Yarr::PatternTerm::PatternTerm):
(JSC::Yarr::PatternTerm::ForwardReference):
(JSC::Yarr::PatternTerm::BOL):
(JSC::Yarr::PatternTerm::EOL):
(JSC::Yarr::PatternTerm::WordBoundary):
(JSC::Yarr::PatternTerm::invert):
(JSC::Yarr::PatternTerm::capture):
(JSC::Yarr::PatternTerm::quantify):
(JSC::Yarr::PatternAlternative::PatternAlternative):
(JSC::Yarr::PatternAlternative::lastTerm):
(JSC::Yarr::PatternAlternative::removeLastTerm):
(JSC::Yarr::PatternAlternative::setOnceThrough):
(JSC::Yarr::PatternAlternative::onceThrough):
(JSC::Yarr::PatternDisjunction::PatternDisjunction):
(JSC::Yarr::PatternDisjunction::~PatternDisjunction):
(JSC::Yarr::PatternDisjunction::addNewAlternative):
(JSC::Yarr::TermChain::TermChain):
(JSC::Yarr::BeginChar::BeginChar):
(JSC::Yarr::YarrPattern::~YarrPattern):
(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::containsIllegalBackReference):
(JSC::Yarr::YarrPattern::newlineCharacterClass):
(JSC::Yarr::YarrPattern::digitsCharacterClass):
(JSC::Yarr::YarrPattern::spacesCharacterClass):
(JSC::Yarr::YarrPattern::wordcharCharacterClass):
(JSC::Yarr::YarrPattern::nondigitsCharacterClass):
(JSC::Yarr::YarrPattern::nonspacesCharacterClass):
(JSC::Yarr::YarrPattern::nonwordcharCharacterClass):
- 1:07 PM Changeset in webkit [75420] by
-
- 1 edit in branches/chromium/597/WebCore/svg/SVGLength.cpp
Merge 75026 - Merge 74788
BUG=68062
Review URL: http://codereview.chromium.org/6117004
- 1:03 PM Changeset in webkit [75419] by
-
- 1 edit2 copies in branches/chromium/597
Merge 75090 - Merge 75082
BUG=68439
Review URL: http://codereview.chromium.org/6192002
- 1:01 PM Changeset in webkit [75418] by
-
- 2 edits in trunk/LayoutTests
2011-01-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Skip layout tests in WebKit2 that fail for an obvious (missing DRT API) reason
https://bugs.webkit.org/show_bug.cgi?id=52166
- platform/mac-wk2/Skipped:
- 1:01 PM Changeset in webkit [75417] by
-
- 1 edit2 copies in branches/chromium/597
Merge 74982 - Merge 74781
BUG=66986
Review URL: http://codereview.chromium.org/6094016
- 12:59 PM Changeset in webkit [75416] by
-
- 3 edits2 copies in branches/chromium/597
Merge 75007 - Merge 73927
BUG=66560
Review URL: http://codereview.chromium.org/6150004
- 12:55 PM Changeset in webkit [75415] by
-
- 1 edit4 copies in branches/chromium/597
Merge 74981 - Merge 74743
BUG=65796
Review URL: http://codereview.chromium.org/6097012
- 12:45 PM Changeset in webkit [75414] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix.
- parser/SyntaxChecker.h:
- 12:39 PM Changeset in webkit [75413] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-10 Dave Tapuska <dtapuska@rim.com>
Reviewed by Gavin Barraclough.
Add CTI ASM versions for RVCT ARM THUMB2 mode.
- jit/JITStubs.cpp: (JSC::ctiTrampoline): (JSC::ctiVMThrowTrampoline): (JSC::ctiOpThrowNotCaught):
- 12:35 PM Changeset in webkit [75412] by
-
- 2 edits in trunk/Source/JavaScriptCore
Qt build fix.
- JavaScriptCore.pro:
- 12:30 PM Changeset in webkit [75411] by
-
- 4 edits in trunk
2011-01-10 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Navigator.cookiesEnabled return true for Qt even if there is no cookie jar
https://bugs.webkit.org/show_bug.cgi?id=52081
Test for the availability of cookie jar to return if cookies are enabled or not.
- platform/qt/CookieJarQt.cpp: (WebCore::cookiesEnabled):
2011-01-10 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Navigator.cookiesEnabled return true for Qt even if there is no cookie jar
https://bugs.webkit.org/show_bug.cgi?id=52081
Add an autotest for checking the result of Navigator.cookiesEnabled depending
on the status of the cookie jar.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::navigatorCookieEnabled):
- 12:29 PM Changeset in webkit [75410] by
-
- 5 edits in trunk/Source/WebCore
2011-01-10 W. James MacLean <wjmaclean@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Enable reuse of RenderSurface for drawing.
https://bugs.webkit.org/show_bug.cgi?id=51928
Modifies RenderSurfaceChromium::prepareContentsTexture to avoid trying to 'reserve' a texture
that is already reserved, should an attempt be made to re-select a previously drawn render surface
in order to continue drawing to it. This use case appears when compositing into an offscreen texture.
Covered by existing test (compositing/geometry/fixed-position.html) when offscreen compositing enabled.
- platform/graphics/chromium/LayerTexture.h: (WebCore::LayerTexture::isReserved):
- platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::prepareContentsTexture):
- platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::isProtected):
- platform/graphics/chromium/TextureManager.h:
- 12:22 PM Changeset in webkit [75409] by
-
- 2 edits in trunk/Source/WebCore
2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Port combo box painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51828
Use GtkStyleContext API to paint combo boxes when building with
GTK+ 3.x. Method paintButton() has been factored out and the new
static method renderButton() is used by both paintButton() and
paintMenuList().
No new tests. This should not change functionality.
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::renderButton): (WebCore::RenderThemeGtk::paintButton): (WebCore::getComboBoxMetrics): (WebCore::RenderThemeGtk::popupInternalPaddingLeft): (WebCore::RenderThemeGtk::popupInternalPaddingRight): (WebCore::RenderThemeGtk::popupInternalPaddingTop): (WebCore::RenderThemeGtk::popupInternalPaddingBottom): (WebCore::RenderThemeGtk::paintMenuList):
- 12:20 PM QtWebKitRelease22 edited by
- (diff)
- 12:20 PM Changeset in webkit [75408] by
-
- 91 edits2 adds in trunk
Bug 52079 - Syntax errors should be early errors.
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
From chapter 16 the spec:
An implementation must report most errors at the time the relevant ECMAScript language construct is
evaluated. An early error is an error that can be detected and reported prior to the evaluation of
any construct in the Program containing the error. An implementation must report early errors in a
Program prior to the first evaluation of that Program. Early errors in eval code are reported at
the time eval is called but prior to evaluation of any construct within the eval code. All errors
that are not early errors are runtime errors.
An implementation must treat any instance of the following kinds of errors as an early error:
- Any syntax error."
- JavaScriptCore.xcodeproj/project.pbxproj:
Added new files.
- bytecode/CodeBlock.cpp:
Removed op_throw_syntax_error.
- bytecode/Opcode.h:
Removed op_throw_syntax_error.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
If m_expressionTooDeep then throw a runtime error.
(JSC::BytecodeGenerator::BytecodeGenerator):
Initialize m_expressionTooDeep.
(JSC::BytecodeGenerator::emitThrowExpressionTooDeepException):
Sets m_expressionTooDeep.
- bytecompiler/BytecodeGenerator.h:
Added m_expressionTooDeep, removed emitThrowSyntaxError.
- bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
Conditions that threw syntax error are now handled during parsing;
during bytecompilation these are now just ASSERTs.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
- jit/JITOpcodes32_64.cpp:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
Removed op_throw_syntax_error.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createRegExp):
Renamed; added syntax check.
- parser/JSParser.cpp:
(JSC::JSParser::breakIsValid):
(JSC::JSParser::hasLabel):
(JSC::JSParser::Scope::Scope):
(JSC::JSParser::Scope::setIsFunction):
(JSC::JSParser::Scope::isFunctionBoundary):
(JSC::JSParser::ScopeRef::hasContainingScope):
(JSC::JSParser::ScopeRef::containingScope):
(JSC::JSParser::AutoPopScopeRef::AutoPopScopeRef):
(JSC::JSParser::AutoPopScopeRef::~AutoPopScopeRef):
(JSC::JSParser::AutoPopScopeRef::setPopped):
(JSC::JSParser::popScopeInternal):
(JSC::JSParser::popScope):
(JSC::jsParse):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseBreakStatement):
(JSC::JSParser::parseContinueStatement):
(JSC::JSParser::parseReturnStatement):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseExpressionOrLabelStatement):
(JSC::JSParser::parsePrimaryExpression):
- parser/JSParser.h:
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::Parser::parse):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createRegExp):
Renamed; added syntax check.
- runtime/ExceptionHelpers.cpp:
(JSC::createOutOfMemoryError):
(JSC::throwOutOfMemoryError):
- runtime/ExceptionHelpers.h:
Broke out createOutOfMemoryError.
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
Add check for exception after bytecode generation.
- runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
RegExp error prefixes not included in error string.
- yarr/RegexParser.h:
(JSC::Yarr::Parser::parse):
Removed regexBegin/regexEnd/regexError.
- yarr/RegexPattern.cpp:
(JSC::Yarr::RegexPatternConstructor::regexBegin):
Removed regexEnd/regexError.
(JSC::Yarr::compileRegex):
Add call to regexBegin (no longer called from the parser).
- yarr/YarrSyntaxChecker.cpp: Added.
(JSC::Yarr::SyntaxChecker::assertionBOL):
(JSC::Yarr::SyntaxChecker::assertionEOL):
(JSC::Yarr::SyntaxChecker::assertionWordBoundary):
(JSC::Yarr::SyntaxChecker::atomPatternCharacter):
(JSC::Yarr::SyntaxChecker::atomBuiltInCharacterClass):
(JSC::Yarr::SyntaxChecker::atomCharacterClassBegin):
(JSC::Yarr::SyntaxChecker::atomCharacterClassAtom):
(JSC::Yarr::SyntaxChecker::atomCharacterClassRange):
(JSC::Yarr::SyntaxChecker::atomCharacterClassBuiltIn):
(JSC::Yarr::SyntaxChecker::atomCharacterClassEnd):
(JSC::Yarr::SyntaxChecker::atomParenthesesSubpatternBegin):
(JSC::Yarr::SyntaxChecker::atomParentheticalAssertionBegin):
(JSC::Yarr::SyntaxChecker::atomParenthesesEnd):
(JSC::Yarr::SyntaxChecker::atomBackReference):
(JSC::Yarr::SyntaxChecker::quantifyAtom):
(JSC::Yarr::SyntaxChecker::disjunction):
(JSC::Yarr::checkSyntax):
- yarr/YarrSyntaxChecker.h: Added.
Check RegExp syntax.
LayoutTests:
Fix syntax errors in layout tests, and update expected results.
- editing/selection/select-crash-001.html:
- editing/selection/select-crash-002.html:
- fast/canvas/webgl/renderbuffer-initialization.html:
- fast/forms/25153.html:
- fast/forms/textfield-drag-into-disabled.html:
- fast/js/exception-codegen-crash-expected.txt:
- fast/js/exception-codegen-crash.html:
- fast/js/kde/parse-expected.txt:
- fast/js/kde/script-tests/parse.js:
- fast/js/large-expressions-expected.txt:
- fast/js/named-function-expression-expected.txt:
- fast/js/parser-syntax-check-expected.txt:
- fast/js/script-tests/large-expressions.js:
- fast/js/script-tests/named-function-expression.js:
- fast/js/script-tests/parser-syntax-check.js:
- fast/js/sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11.1_T3-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11_T3-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12.1_T3-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12_T3-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T1-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T2-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T3-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T4-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T1-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T2-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T3-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A6-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T1-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T2-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T1-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T2-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T3-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T4-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T1-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T2-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T3-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A6-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T1-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T2-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T1-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T10-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T2-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T3-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T4-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T5-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T6-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T7-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T8-expected.txt:
- fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T9-expected.txt:
- http/tests/security/isolatedWorld/events.html:
- http/tests/security/isolatedWorld/userGestureEvents.html:
- svg/custom/resources/use-instanceRoot-event-listeners.js:
- svg/custom/rgbcolor-syntax.svg:
- svg/custom/use-instanceRoot-modifications.svg:
- svg/custom/use-property-changes-through-svg-dom.svg:
- webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
- webarchive/resources/adopt-attribute-styled-body-iframe.html:
- 12:14 PM Changeset in webkit [75407] by
-
- 2 edits in trunk/LayoutTests
2011-01-10 Tony Chang <tony@chromium.org>
Unreviewed, remove duplicate test expectation for gif-loop-count.
- platform/chromium/test_expectations.txt:
- 12:14 PM Changeset in webkit [75406] by
-
- 2 edits in trunk/Tools
Roll out r75392
It isn't needed now that r75289 has been rolled out.
- Scripts/run-javascriptcore-tests:
- 12:13 PM Changeset in webkit [75405] by
-
- 2 edits in trunk/Source/JavaScriptCore
Roll out r75289
It was causing assertion failures. See <http://webkit.org/b/52156>.
- wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):
- 12:07 PM Changeset in webkit [75404] by
-
- 2 edits in trunk/WebKit2
2011-01-10 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Eric Seidel.
Support for ARM's RVCT(ARMCC) compiler in import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52146
- Shared/API/c/WKBase.h:
- 12:05 PM Changeset in webkit [75403] by
-
- 2 edits in trunk
2011-01-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[EFL] Enable JIT for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=52140
Enable JIT option for WebKit EFL. Enabled JIT's JS performance is
3 ~ 6 times faster than before.
- Source/cmake/OptionsEfl.cmake:
- 12:04 PM Changeset in webkit [75402] by
-
- 2 edits in trunk/LayoutTests
Unreviewed rolling out r75371, because it didn't fix Qt buildbot.
- platform/qt/Skipped:
- 12:00 PM Changeset in webkit [75401] by
-
- 2 edits in trunk/Tools
2011-01-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
https://bugs.webkit.org/show_bug.cgi?id=52160
- WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout. Anything that can make runUntil() conditions turn true will happen on a run loop cycle anyway.
- 11:58 AM Changeset in webkit [75400] by
-
- 2 edits in trunk/Source/WebCore
2011-01-10 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] simplify complex glyph positioning code
https://bugs.webkit.org/show_bug.cgi?id=52159
Before, we had roughly same code duplicated for RTL and LTR.
Now, use the same code for both directions by being careful about
flipping signs where appropriate.
- platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::shapeGlyphs): (WebCore::ComplexTextController::setGlyphXPositions):
- 11:31 AM Changeset in webkit [75399] by
-
- 2 edits in trunk/WebKit2
Fix the build.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- 11:31 AM Changeset in webkit [75398] by
-
- 5 edits2 deletes in trunk
2011-01-10 Tony Chang <tony@chromium.org>
Reviewed by Mihai Parparita.
[chromium] fix for animated gif layout tests
https://bugs.webkit.org/show_bug.cgi?id=52008
Remove incorrect baselines.
- platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.checksum: Removed.
- platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.png: Removed.
- platform/chromium/test_expectations.txt:
2011-01-10 Tony Chang <tony@chromium.org>
Reviewed by Mihai Parparita.
[chromium] fix for animated gif layout tests
https://bugs.webkit.org/show_bug.cgi?id=52008
- DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
to trigger gif animations.
(WebViewHostPaintTask::WebViewHostPaintTask):
(WebViewHostPaintTask::runIfValid):
(WebViewHost::updatePaintRect):
- DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::taskList):
- 11:29 AM Changeset in webkit [75397] by
-
- 7 edits in trunk
2011-01-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix gtk2 compilation for master
https://bugs.webkit.org/show_bug.cgi?id=51885
- platform/gtk/GtkVersioning.h: Replaced the 2.24.0 check with 2.23.0 to avoid using the old symbols in the 2.23 releases. Added support for gdk_pixmap_get_size before the 2.23.4.
- platform/gtk/WidgetRenderingContextGtk2.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext): Replaced the old gdk_drawable_get_size with gdk_pixmap_get_size.
2011-01-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix gtk2 compilation for master
https://bugs.webkit.org/show_bug.cgi?id=51885
- DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView): Replaced the old gdk_drawable_get_size with gdk_pixmap_get_size.
2011-01-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix gtk2 compilation for master
https://bugs.webkit.org/show_bug.cgi?id=51885
- webkit/webkitsoupauthdialog.c: (show_auth_dialog): Removed the call to gtk_dialog_set_has_separator API to remove a warning.
- 11:22 AM Changeset in webkit [75396] by
-
- 2 edits in trunk/Tools
2011-01-10 Patrick Gansterer <Patrick Gansterer>
Reviewed by Laszlo Gombos.
[WINCE] Reenable NPAPI after r75203
https://bugs.webkit.org/show_bug.cgi?id=52109
Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
it with !isEfl(), because EFL port does not support NPAPI (yet).
- Scripts/build-webkit:
- 11:20 AM Changeset in webkit [75395] by
-
- 22 edits17 adds in trunk/WebKit2
Make Geolocation features work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52078
Reviewed by Anders Carlsson.
Step 1 - Add enough support to get position data from a provider.
This does not include permission support.
- Platform/CoreIPC/HandleMessage.h:
Add #include of Arguments.h for CoreIPC::In and Out definitions.
- Platform/CoreIPC/MessageID.h:
Add new message types.
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
Add new API types.
- Shared/WebGeolocationPosition.cpp: Added.
- Shared/WebGeolocationPosition.h: Added.
Internal position representation.
- UIProcess/API/C/WKAPICast.h:
Add casts for new API types.
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/WKGeolocationManager.cpp: Added.
- UIProcess/API/C/WKGeolocationManager.h: Added.
- UIProcess/API/C/WKGeolocationPosition.cpp: Added.
- UIProcess/API/C/WKGeolocationPosition.h: Added.
- UIProcess/API/C/WebKit2.h:
Add API to provide and control geolocation data.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::processDidClose):
(WebKit::WebContext::didReceiveMessage):
- UIProcess/WebContext.h:
(WebKit::WebContext::geolocationManagerProxy):
- UIProcess/WebGeolocationManagerProxy.cpp: Added.
(WebKit::WebGeolocationManagerProxy::create):
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::~WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::invalidate):
(WebKit::WebGeolocationManagerProxy::initializeProvider):
(WebKit::WebGeolocationManagerProxy::providerDidChangePosition):
(WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):
(WebKit::WebGeolocationManagerProxy::didReceiveMessage):
(WebKit::WebGeolocationManagerProxy::startUpdating):
(WebKit::WebGeolocationManagerProxy::stopUpdating):
- UIProcess/WebGeolocationManagerProxy.h: Added.
(WebKit::WebGeolocationManagerProxy::clearContext):
(WebKit::WebGeolocationManagerProxy::type):
- UIProcess/WebGeolocationManagerProxy.messages.in: Added.
- UIProcess/WebGeolocationProvider.cpp: Added.
(WebKit::WebGeolocationProvider::startUpdating):
(WebKit::WebGeolocationProvider::stopUpdating):
- UIProcess/WebGeolocationProvider.h: Added.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
- WebProcess/Geolocation: Added.
- WebProcess/Geolocation/WebGeolocationManager.cpp: Added.
(WebKit::WebGeolocationManager::WebGeolocationManager):
(WebKit::WebGeolocationManager::~WebGeolocationManager):
(WebKit::WebGeolocationManager::didReceiveMessage):
(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):
- WebProcess/Geolocation/WebGeolocationManager.h: Added.
- WebProcess/Geolocation/WebGeolocationManager.messages.in: Added.
- WebProcess/WebCoreSupport/WebGeolocationClient.cpp: Added.
(WebKit::WebGeolocationClient::geolocationDestroyed):
(WebKit::WebGeolocationClient::startUpdating):
(WebKit::WebGeolocationClient::stopUpdating):
(WebKit::WebGeolocationClient::setEnableHighAccuracy):
(WebKit::WebGeolocationClient::lastPosition):
(WebKit::WebGeolocationClient::requestPermission):
(WebKit::WebGeolocationClient::cancelPermissionRequest):
- WebProcess/WebCoreSupport/WebGeolocationClient.h: Added.
(WebKit::WebGeolocationClient::WebGeolocationClient):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):
- WebProcess/WebProcess.h:
(WebKit::WebProcess::geolocationManager):
Pipe geolocation positions/errors from the UIProcess to the WebProcess.
- DerivedSources.make:
- DerivedSources.pro:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Common.vsprops:
- win/WebKit2Generated.make:
Add new files.
- 11:17 AM Changeset in webkit [75394] by
-
- 2 edits in trunk/Source/WebCore
2011-01-10 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; build fix for r75385.
- rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
- 11:15 AM Changeset in webkit [75393] by
-
- 5 edits3 deletes in trunk
2011-01-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75341.
http://trac.webkit.org/changeset/75341
https://bugs.webkit.org/show_bug.cgi?id=52157
Regressions on several pixel tests (Requested by jorlow on
#webkit).
- fast/canvas/canvas-fillPath-gradient-shadow-expected.txt: Removed.
- fast/canvas/canvas-fillPath-gradient-shadow.html: Removed.
- fast/canvas/script-tests/canvas-fillPath-gradient-shadow.js: Removed.
- platform/chromium/test_expectations.txt:
- platform/qt/Skipped:
2011-01-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75341.
http://trac.webkit.org/changeset/75341
https://bugs.webkit.org/show_bug.cgi?id=52157
Regressions on several pixel tests (Requested by jorlow on
#webkit).
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath):
- 11:10 AM Changeset in webkit [75392] by
-
- 2 edits in trunk/Tools
Skip some asserting JS tests
See <http://webkit.org/b/52156>.
- Scripts/run-javascriptcore-tests:
- 11:10 AM Changeset in webkit [75391] by
-
- 2 edits in trunk/Source/WebCore
2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Port check and radio button painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51815
Use GtkStyleContext API to paint check and radio buttons when
building with GTK+ 3.x.
No new tests. This should not change functionality.
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::setToggleSize): (WebCore::paintToggle): (WebCore::RenderThemeGtk::setCheckboxSize): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::setRadioSize): (WebCore::RenderThemeGtk::paintRadio):
- 10:53 AM Changeset in webkit [75390] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] fast/text/emphasis-avoid-ruby.html fails, because FontQt doesn’t implement
Font::emphasisMark{Ascent,Descent,Height} nor emphasis mark drawing.
https://bugs.webkit.org/show_bug.cgi?id=52155
- platform/qt/Skipped: Add fast/text/emphasis-avoid-ruby.html until fix.
- 10:52 AM Changeset in webkit [75389] by
-
- 2 edits in trunk/Tools
2011-01-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] build-webkit disable Blob support via arguments passed to automake
https://bugs.webkit.org/show_bug.cgi?id=52097
- Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via build-webkit.
- 10:45 AM Changeset in webkit [75388] by
-
- 6 edits2 copies2 adds in trunk/LayoutTests
2011-01-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
Rebaseline two tests in fast/forms for chromium-mac. Even after the
scrollbar switch they need Chromium-specific results since search and
file upload control rendering is different from the mac port's.
Adds both Leopard (chromium-mac-leopard) and Snow Leopard (chromium-mac)
baselines.
- platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/file-input-direction-expected.png.
- platform/chromium-mac-leopard/fast/forms/search-transformed-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/search-transformed-expected.png.
- platform/chromium-mac/fast/forms/file-input-direction-expected.checksum:
- platform/chromium-mac/fast/forms/file-input-direction-expected.png:
- platform/chromium-mac/fast/forms/search-transformed-expected.checksum:
- platform/chromium-mac/fast/forms/search-transformed-expected.png:
- platform/chromium/test_expectations.txt:
- 10:42 AM Changeset in webkit [75387] by
-
- 1 edit1 copy in trunk/LayoutTests
Unreviewed. Add Qt specific expected file.
- platform/qt/http/tests/navigation/forward-and-cancel-expected.txt: Copied from LayoutTests/http/tests/navigation/forward-and-cancel-expected.txt.
- 10:35 AM Changeset in webkit [75386] by
-
- 2 edits in trunk
2011-01-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha.
Bump the WebKitGTK+ versions in preparation for development release.
- configure.ac: Bump the library, libtool and user agent version.
- 10:34 AM Changeset in webkit [75385] by
-
- 8 edits in trunk
2011-01-10 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Updated tests and results to take into account new default fraction bar thickness.
https://bugs.webkit.org/show_bug.cgi?id=50018
- mathml/presentation/fractions.xhtml:
- platform/mac/mathml/presentation/fractions-expected.checksum:
- platform/mac/mathml/presentation/fractions-expected.png:
- platform/mac/mathml/presentation/fractions-expected.txt:
2011-01-10 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
MathML: vertical alignment & bar thickness adjustments of fractions.
https://bugs.webkit.org/show_bug.cgi?id=50018
The fraction bar thickness default value should follow the w3c MathML 3 recommendation:
http://www.w3.org/TR/MathML3/chapter3.html#presm.mfrac
The vertical alignment of the fraction bar should be more accurate, specially with operators (+,=,...).
Test: mathml/presentation/fractions.xhtml
- rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::RenderMathMLFraction): (WebCore::RenderMathMLFraction::updateFromElement): (WebCore::RenderMathMLFraction::layout): (WebCore::RenderMathMLFraction::paint): (WebCore::RenderMathMLFraction::baselinePosition):
- rendering/mathml/RenderMathMLFraction.h:
- 10:32 AM Changeset in webkit [75384] by
-
- 3 edits3 adds in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=52044
REGRESSION(r74807): No-store is ignored within a document
Reviewed by Alexey Proskuryakov.
Don't use cached resources with Cache-control: no-store (unless cache policy is CachePolicyHistoryBuffer).
This matches a behavior that got lost in r74807.
Test: http/tests/misc/script-no-store.html
(by Alexey Proskuryakov)
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=52044
REGRESSION(r74807): No-store is ignored within a document
Reviewed by Alexey Proskuryakov.
- http/tests/misc/script-no-store-expected.txt: Added.
- http/tests/misc/script-no-store.html: Added.
- http/tests/misc/resources/random-no-store.php: Added.
- 10:14 AM Changeset in webkit [75383] by
-
- 3 edits1 add in trunk/Source/WebCore
2011-01-10 Patrick Gansterer <Patrick Gansterer>
Reviewed by Laszlo Gombos.
[WIN] Add ProxyServerWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=52031
Add stub implementation to fix ENABLE_NETSCAPE_PLUGIN_API on WinCE.
- CMakeLists.txt:
- CMakeListsWinCE.txt:
- platform/network/win/ProxyServerWin.cpp: Added. (WebCore::proxyServersForURL):
- 10:09 AM Changeset in webkit [75382] by
-
- 2 edits in trunk/WebKit2
2011-01-10 Martin Robinson <mrobinson@igalia.com>
GTK+ build fix. Continue to fix 'make dist.'
- GNUmakefile.am: Remove more non-existent files from the WebKit2 build.
- 9:56 AM Changeset in webkit [75381] by
-
- 4 edits in trunk
2011-01-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869
We avoid the situation where we have to render the same arc
multiple times over itself. Now it renders just one oval and
moves to the end angle.
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):
2011-01-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869
Unskip canvas-largedraws.html after improving the performance for
big angles.
- platform/gtk/Skipped:
- 9:15 AM Changeset in webkit [75380] by
-
- 2 edits in trunk/WebKit2
2011-01-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Remove webkit2 files that are still not added to the
repository from the makefile
https://bugs.webkit.org/show_bug.cgi?id=52145
This change is required for the release, we can add the lines
again to the makefiles with the patches adding the files.
- GNUmakefile.am:
- 9:04 AM Changeset in webkit [75379] by
-
- 2 edits in trunk/Tools
Use the same name and description for TestNetscapePlugin on Windows and Mac
Fixes <http://webkit.org/b/52151>
fast/frames/iframe-reparenting-plugins.html fails on Windows
Reviewed by Steve Falkenburg.
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
the name and description from Mac's Info.plist.
- 9:00 AM Changeset in webkit [75378] by
-
- 2 edits in trunk/Source/WebCore
2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Port text input control painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51870
Use GtkStyleContext API to paint text input controls when building
with GTK+ 3.x.
No new tests. This should not change functionality.
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::RenderThemeGtk::paintTextField):
- 8:41 AM Changeset in webkit [75377] by
-
- 60 edits in trunk
2011-01-09 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Alexey Proskuryakov.
Forward declare some headers where possible
https://bugs.webkit.org/show_bug.cgi?id=52133
No new tests because no new functionality.
- css/CSSValue.h:
- dom/BeforeLoadEvent.h:
- dom/Event.cpp:
- dom/Event.h:
- dom/StyledElement.cpp:
- dom/StyledElement.h:
- loader/DocumentLoader.h:
- loader/FrameLoader.h:
- page/Frame.h:
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContext.h:
- platform/graphics/filters/FEBlend.cpp:
- platform/graphics/filters/FEColorMatrix.cpp:
- platform/graphics/filters/FEComponentTransfer.cpp:
- platform/graphics/filters/FEComposite.cpp:
- platform/graphics/filters/FEConvolveMatrix.cpp:
- platform/graphics/filters/FEDiffuseLighting.cpp:
- platform/graphics/filters/FEDisplacementMap.cpp:
- platform/graphics/filters/FEFlood.cpp:
- platform/graphics/filters/FEGaussianBlur.cpp:
- platform/graphics/filters/FEMerge.cpp:
- platform/graphics/filters/FEMorphology.cpp:
- platform/graphics/filters/FEOffset.cpp:
- platform/graphics/filters/FESpecularLighting.cpp:
- platform/graphics/filters/FETile.cpp:
- platform/graphics/filters/FETurbulence.cpp:
- platform/graphics/filters/FilterEffect.cpp:
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/filters/SourceAlpha.cpp:
- platform/graphics/filters/SourceGraphic.cpp:
- svg/SVGElement.cpp:
- svg/SVGElement.h:
- svg/SVGFEBlendElement.cpp:
- svg/SVGFEColorMatrixElement.cpp:
- svg/SVGFEComponentTransferElement.cpp:
- svg/SVGFECompositeElement.cpp:
- svg/SVGFEConvolveMatrixElement.cpp:
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.cpp:
- svg/SVGFEDisplacementMapElement.cpp:
- svg/SVGFEGaussianBlurElement.cpp:
- svg/SVGFEImageElement.h:
- svg/SVGFEMergeElement.cpp:
- svg/SVGFEMorphologyElement.cpp:
- svg/SVGFEOffsetElement.cpp:
- svg/SVGFESpecularLightingElement.cpp:
- svg/SVGFETileElement.cpp:
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGTextContentElement.cpp:
- svg/graphics/filters/SVGFEImage.cpp:
- svg/graphics/filters/SVGFEImage.h:
2011-01-09 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Alexey Proskuryakov.
Forward declare some headers where possible
https://bugs.webkit.org/show_bug.cgi?id=52133
- WebView/WebFrame.mm:
- 8:05 AM Changeset in webkit [75376] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix after r75313
- WebCore.vcproj/build-generated-files.sh: Updated for the change in
this script's path.
- 7:50 AM Changeset in webkit [75375] by
-
- 2 edits in trunk/LayoutTests
Add some new tests to the Windows Skipped file
The tests are failing due to unimplemented DRT features which are
already covered by bugs.
- platform/win/Skipped:
- 7:30 AM Changeset in webkit [75374] by
-
- 3 edits in trunk/Tools
2011-01-10 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][WK2] Guard gcc-specific syntax
Non-gcc based compliers choke on the "-include"
syntax for preinclude, place guard around it.
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
- WebKitTestRunner/qt/WebKitTestRunner.pro:
- 7:25 AM Changeset in webkit [75373] by
-
- 7 edits in trunk
2011-01-10 Andreas Kling <kling@webkit.org>
Reviewed by Simon Hausmann.
[Qt] [WK2] MiniBrowser does not load pages opened in new windows
https://bugs.webkit.org/show_bug.cgi?id=52111
When getting a createNewPage() callback from QWKPage, create the
new page with the same QWKContext as the page that is passed to
the callback.
- MiniBrowser/qt/BrowserView.h:
- MiniBrowser/qt/BrowserWindow.cpp: (newPageFunction): (BrowserWindow::BrowserWindow):
- MiniBrowser/qt/BrowserWindow.h:
2011-01-10 Andreas Kling <kling@webkit.org>
Reviewed by Simon Hausmann.
[Qt] [WK2] MiniBrowser does not load pages opened in new windows
https://bugs.webkit.org/show_bug.cgi?id=52111
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::context): Implement this method.
- 6:50 AM Changeset in webkit [75372] by
-
- 2 edits in trunk/Tools
2011-01-10 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] MiniBrowser: Remove superfluous createNewPage() callback
BrowserView set its own useless createNewPage() callback on QWKPage.
This was immediately overridden by BrowserWindow anyway, so remove
the BrowserView one.
- MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView):
- 6:49 AM Changeset in webkit [75371] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578
Add new tests introduced in r75305 to the skipped list temporarily to make buildbot happy.
- platform/qt/Skipped:
- 6:39 AM Changeset in webkit [75370] by
-
- 2 edits in trunk/Source/WebCore
2011-01-10 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: make properties on Array's prototype non-enumerable.
https://bugs.webkit.org/show_bug.cgi?id=51776
- inspector/front-end/utilities.js: ():
- 5:50 AM Changeset in webkit [75369] by
-
- 3 edits2 adds in trunk
Specificity of negated selectors apparently miscalculated
https://bugs.webkit.org/show_bug.cgi?id=41206
Reviewed by Simon Fraser.
Source/WebCore:
Give negated selectors the specificity of the selector they are negating.
This is the same as the behavior of other browsers.
Test: fast/css/pseudo-not.html
- css/CSSSelector.cpp:
(WebCore::CSSSelector::specificityForOneSelector):
LayoutTests:
- fast/css/pseudo-not-expected.txt: Added.
- fast/css/pseudo-not.html: Added.
- 5:30 AM Changeset in webkit [75368] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix after r75353
- WebCore.vcproj/WebCoreCommon.vsprops: Added rendering/mathml to the
include path.
- 3:41 AM Changeset in webkit [75367] by
-
- 15 edits8 deletes in trunk
2011-01-10 John Knottenbelt <jknotten@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] Remove non-client-based Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=50921
Code clean up, covered by existing tests.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/ChromiumBridge.h:
- platform/chromium/GeolocationServiceChromium.cpp: Removed.
- platform/chromium/GeolocationServiceChromium.h: Removed.
2011-01-10 John Knottenbelt <jknotten@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] Remove non-client-based Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=50921
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationPosition): (LayoutTestController::setMockGeolocationError):
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::geolocationClientMock): (WebViewHost::reset):
- DumpRenderTree/chromium/WebViewHost.h:
2011-01-10 John Knottenbelt <jknotten@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] Remove non-client-based Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=50921
- WebKit.gyp:
- public/WebGeolocationService.h: Removed.
- public/WebGeolocationServiceBridge.h: Removed.
- public/WebGeolocationServiceMock.h: Removed.
- src/AssertMatchingEnums.cpp:
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame): (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
- src/ChromiumBridge.cpp:
- src/WebGeolocationServiceBridgeImpl.cpp: Removed.
- src/WebGeolocationServiceBridgeImpl.h: Removed.
- src/WebGeolocationServiceMock.cpp: Removed.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
- 3:21 AM Changeset in webkit [75366] by
-
- 5 edits in trunk/Tools
2011-01-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Commit bot tried to land r? cq+ patch
https://bugs.webkit.org/show_bug.cgi?id=36638
It should now be possible to post a patch with r? and cq+ and the
commit-queue will correctly wait for the r+ before attempting to land the patch.
(This was a feature requested by several users.)
One caveat: We don't actually reject r-, cq+ patches from the queue
(we just ignore them), but I think that's OK for now.
I also noticed that setting r- once a commit-queue node had grabbed
a patch would not properly cancel the landing. That's fixed and
tested in this patch.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/bot/feeders.py:
- Scripts/webkitpy/tool/bot/feeders_unittest.py:
- 2:44 AM Changeset in webkit [75365] by
-
- 5 edits in trunk/Source/WebCore
2011-01-10 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: protocol related change. Rename stepIntoStatement, stepOutOfFunction, stepOverStatement.
stepIntoStatement => stepInto
stepOutOfFunction => stepOut
stepOverStatement => stepOver
- inspector/Inspector.idl:
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::stepOver): (WebCore::InspectorDebuggerAgent::stepInto): (WebCore::InspectorDebuggerAgent::stepOut):
- inspector/InspectorDebuggerAgent.h:
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._stepOverClicked): (WebInspector.ScriptsPanel.prototype._stepIntoClicked): (WebInspector.ScriptsPanel.prototype._stepOutClicked):
- 1:09 AM Changeset in webkit [75364] by
-
- 4 edits in trunk/Source/WebCore
2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Port progressbar painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=52054
Use GtkStyleContext API to paint progressbars when building with
GTK+ 3.x. Also add support for indeterminate progressbars.
No new tests. This should not change functionality.
- platform/gtk/RenderThemeGtk.cpp:
- platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeGtk::animationDurationForProgressBar):
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeGtk::animationDurationForProgressBar): (WebCore::RenderThemeGtk::paintProgressBar):
- 12:35 AM Changeset in webkit [75363] by
-
- 10 edits3 deletes in trunk/Source/WebCore
2011-01-10 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Remove unused class "Pen" in WebCore/platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=49955
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/Pen.cpp: Removed.
- platform/graphics/Pen.h: Removed.
- platform/graphics/haiku/GraphicsContextHaiku.cpp:
- platform/graphics/wx/GraphicsContextWx.cpp:
- platform/graphics/wx/PenWx.cpp: Removed.
- 12:27 AM Changeset in webkit [75362] by
-
- 6 edits in trunk
2011-01-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Create intermediate libWebCore library
https://bugs.webkit.org/show_bug.cgi?id=52116
- GNUmakefile.am: add XP_UNIX to the global CPP flags, since it's used by both libWebCore and libwebkitgtk now.
2011-01-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Create intermediate libWebCore library
https://bugs.webkit.org/show_bug.cgi?id=52116
Create intermediate libWebCore.la to avoid overflowing the linker
in the final link stage.
- GNUmakefile.am: define the new library.
2011-01-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Create intermediate libWebCore library
https://bugs.webkit.org/show_bug.cgi?id=52116
- GNUmakefile.am: add libWebCore.la to LIBADD and remove webcore sources from the libwebkit library SOURCES.
