Context Navigation

← Previous Period
Next Period →

Timeline

Mar 2, 2011:

10:28 PM Changeset in webkit [80210] by morrita@google.com

10 edits
2 adds in trunk/Source/WebCore

2011-03-02 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Refactoring] Make ScheduledEvent on FrameView abstract out to ScheduleAction
https://bugs.webkit.org/show_bug.cgi?id=54440

Extracted FrameActionScheduler from FrameView
Extracted FrameAction abstract class from ScheduledEvent, which has fire() virtual method.
Renamed ScheduledEvent EventFrameAction

With this change, Any action can be hooked up to the end of the layout.

No new tests. No behavioral change.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
page/FrameActionScheduler.cpp: Added. (WebCore::EventFrameAction::EventFrameAction): (WebCore::EventFrameAction::fire): (WebCore::FrameActionScheduler::FrameActionScheduler): (WebCore::FrameActionScheduler::~FrameActionScheduler): (WebCore::FrameActionScheduler::isEmpty): (WebCore::FrameActionScheduler::clear): (WebCore::FrameActionScheduler::pause): (WebCore::FrameActionScheduler::resume): (WebCore::FrameActionScheduler::dispatch): (WebCore::FrameActionScheduler::scheduleAction): (WebCore::FrameActionScheduler::scheduleEvent):
page/FrameActionScheduler.h: Added. (WebCore::FrameAction::FrameAction): (WebCore::FrameAction::~FrameAction): (WebCore::FrameActionScheduler::isScheduled):
page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::pauseScheduledEvents): (WebCore::FrameView::resumeScheduledEvents): (WebCore::FrameView::performPostLayoutTasks): (WebCore::FrameView::updateOverflowStatus):
page/FrameView.h:

10:18 PM Changeset in webkit [80209] by rniwa@webkit.org

9 edits in trunk/Source/WebCore

2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80201.
http://trac.webkit.org/changeset/80201
https://bugs.webkit.org/show_bug.cgi?id=55648

"caused tests to crash on several bots" (Requested by rniwa on
#webkit).

dom/Element.h: (WebCore::Node::hasTagName):
dom/Node.h:
html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLNames::hasImpliedEndTag): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody): (WebCore::HTMLConstructionSite::insertComment): (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement): (WebCore::HTMLConstructionSite::attachToCurrent): (WebCore::HTMLConstructionSite::insertScriptElement): (WebCore::HTMLConstructionSite::insertTextNode): (WebCore::HTMLConstructionSite::createElement): (WebCore::HTMLConstructionSite::createHTMLElement): (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion): (WebCore::HTMLConstructionSite::generateImpliedEndTags): (WebCore::HTMLConstructionSite::findFosterSite): (WebCore::HTMLConstructionSite::shouldFosterParent):
html/parser/HTMLConstructionSite.h:
html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isNumberedHeaderElement): (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isListItemScopeMarker): (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLNames::isTableBodyScopeMarker): (WebCore::HTMLNames::isTableRowScopeMarker): (WebCore::HTMLNames::isButtonScopeMarker): (WebCore::HTMLNames::isSelectScopeMarker): (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::replaceElement): (WebCore::HTMLElementStack::HTMLElementStack): (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement): (WebCore::HTMLElementStack::popAll): (WebCore::HTMLElementStack::popUntilTableScopeMarker): (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker): (WebCore::HTMLElementStack::popUntilTableRowScopeMarker): (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker): (WebCore::HTMLElementStack::pushHTMLHtmlElement): (WebCore::HTMLElementStack::push): (WebCore::HTMLElementStack::insertAbove): (WebCore::HTMLElementStack::find): (WebCore::HTMLElementStack::topmost): (WebCore::inScopeCommon): (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope): (WebCore::HTMLElementStack::htmlElement): (WebCore::HTMLElementStack::bodyElement): (WebCore::HTMLElementStack::pushCommon):
html/parser/HTMLElementStack.h: (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::top):
html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished): (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTagForInCell): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::finished):
html/parser/HTMLTreeBuilder.h:

10:12 PM Changeset in webkit [80208] by mihaip@chromium.org

32 edits
4 copies in trunk/LayoutTests

2011-03-02 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Snow Leopard baseline update

With the exception of fast/repaint/select-option-background-color.html
and fast/repaint/slider-thumb-drag-release.html (which didn't have any
SL baselines at all), this was updating of baselines after r78846.

platform/chromium-mac-leopard/fast/repaint/select-option-background-color-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/repaint/select-option-background-color-expected.checksum.
platform/chromium-mac-leopard/fast/repaint/select-option-background-color-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/repaint/select-option-background-color-expected.png.
platform/chromium-mac-leopard/fast/repaint/slider-thumb-drag-release-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum.
platform/chromium-mac-leopard/fast/repaint/slider-thumb-drag-release-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png.
platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.checksum:
platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png:
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
platform/chromium-mac/fast/repaint/select-option-background-color-expected.checksum:
platform/chromium-mac/fast/repaint/select-option-background-color-expected.png:
platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum:
platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png:
platform/chromium/test_expectations.txt:

10:10 PM Changeset in webkit [80207] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed Chromium expectations update

Mark http/tests/cache/subresource-expiration-*.html as SLOW on Win

platform/chromium/test_expectations.txt:

9:57 PM Changeset in webkit [80206] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2011-03-02 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update

Clean up svg/ expectations (there were some non-test files with
expectations, as well as a couple of tests that have never failed).

platform/chromium/test_expectations.txt:

9:55 PM Changeset in webkit [80205] by jberlin@webkit.org

2 edits in trunk/Source/WebKit/mac

Fix crashes in private browsing tests in WK1 on Snow Leopard.

Rubber-stamped by Dan Bernstein.

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Put the INIT call for wkCreatePrivateStorageSession outside of the
#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
guards.

9:43 PM Changeset in webkit [80204] by yurys@chromium.org

31 edits in trunk

2011-03-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: break down InspectorFrontend into domain-specific classes
https://bugs.webkit.org/show_bug.cgi?id=55584

inspector/elements/elements-panel-search.html:

2011-03-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: break down InspectorFrontend into domain-specific classes
https://bugs.webkit.org/show_bug.cgi?id=55584

inspector/CodeGeneratorInspector.pm: InspectorFrontend now contains nested classes for all domains that have event notifications.
inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole):
inspector/ConsoleMessage.h:
inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectImpl):
inspector/Inspector.idl:
inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired): (WebCore::InspectorAgent::postWorkerNotificationToFrontend): (WebCore::InspectorAgent::evaluateForTestInFrontend): (WebCore::InspectorAgent::showPanel):
inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
inspector/InspectorApplicationCacheAgent.h:
inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::setFrontend):
inspector/InspectorConsoleAgent.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::show): (WebCore::InspectorController::close):
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setFrontend):
inspector/InspectorDOMAgent.h:
inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
inspector/InspectorDOMStorageResource.h:
inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend): (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider): (WebCore::InspectorDatabaseAgent::setFrontend):
inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
inspector/InspectorDatabaseResource.h:
inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setFrontend):
inspector/InspectorDebuggerAgent.h:
inspector/InspectorProfilerAgent.cpp:
inspector/InspectorProfilerAgent.h: (WebCore::InspectorProfilerAgent::setFrontend): (WebCore::InspectorProfilerAgent::clearFrontend):
inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::InspectorResourceAgent):
inspector/InspectorResourceAgent.h:
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::setFrontend):
inspector/InspectorTimelineAgent.h:
inspector/front-end/DOMAgent.js: (WebInspector.DOMDispatcher.prototype.inspectElementRequested): (WebInspector.DOMDispatcher.prototype.addNodesToSearchResult):
inspector/front-end/inspector.js:

8:53 PM Changeset in webkit [80203] by tkent@chromium.org

2 edits in trunk/Source/WebCore

2011-03-02 Kent Tamura <tkent@chromium.org>

Unreviewed, a trivial regression fix.

Fix LocalizedNumberICU regression by r80198 and r80199.
https://bugs.webkit.org/show_bug.cgi?id=55629

platform/text/LocalizedNumberICU.cpp: We should use U_SUCCESS(). (WebCore::createFormatterForCurrentLocale): (WebCore::parseLocalizedNumber):

8:50 PM Changeset in webkit [80202] by mitz@apple.com

2 edits in trunk/Source/WebCore

Let Xcode know that Localizable.strings is UTF-16-encoded.

WebCore.xcodeproj/project.pbxproj:

8:40 PM Changeset in webkit [80201] by aestes@apple.com

9 edits in trunk/Source/WebCore

2011-03-02 Andy Estes <aestes@apple.com>

Reviewed by Eric Seidel.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
https://bugs.webkit.org/show_bug.cgi?id=48719

Instead of pushing a fake HTMLHtmlElement onto the open element stack
during fragment parsing only to later remove it and reparent its
children to the DocumentFragment, push the DocumentFragment directly
onto the open element stack as the root node. This requires refactoring
HTMLElementStack to hold ContainerNode pointers rather than Element
pointers, which has implications for HTMLConstructionSite and
HTMLTreeBuilder as well.

With this patch, the regression in Peacekeeper due to the introduction
of the HTML5 fragment parsing algorithm is ~14%. The regression from
Safari 5.0.3 is ~24%.

No new tests. No change in behavior.

dom/Element.h: (WebCore::Node::hasLocalName):
dom/Node.h:
html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLNames::hasImpliedEndTag): (WebCore::HTMLConstructionSite::HTMLConstructionSite): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody): (WebCore::HTMLConstructionSite::insertComment): (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement): (WebCore::HTMLConstructionSite::attachToCurrent): (WebCore::HTMLConstructionSite::insertScriptElement): (WebCore::HTMLConstructionSite::insertTextNode): (WebCore::HTMLConstructionSite::createElement): (WebCore::HTMLConstructionSite::createHTMLElement): (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion): (WebCore::HTMLConstructionSite::generateImpliedEndTags): (WebCore::HTMLConstructionSite::findFosterSite): (WebCore::HTMLConstructionSite::shouldFosterParent):
html/parser/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::currentNode):
html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isNumberedHeaderElement): (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isListItemScopeMarker): (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLNames::isTableBodyScopeMarker): (WebCore::HTMLNames::isTableRowScopeMarker): (WebCore::HTMLNames::isButtonScopeMarker): (WebCore::HTMLNames::isSelectScopeMarker): (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::replaceElement): (WebCore::HTMLElementStack::HTMLElementStack): (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement): (WebCore::HTMLElementStack::popAll): (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped): (WebCore::HTMLElementStack::popUntil): (WebCore::HTMLElementStack::popUntilPopped): (WebCore::HTMLElementStack::popUntilTableScopeMarker): (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker): (WebCore::HTMLElementStack::popUntilTableRowScopeMarker): (WebCore::HTMLElementStack::pushHTMLHtmlElement): (WebCore::HTMLElementStack::push): (WebCore::HTMLElementStack::insertAbove): (WebCore::HTMLElementStack::find): (WebCore::HTMLElementStack::topmost): (WebCore::HTMLElementStack::contains): (WebCore::inScopeCommon): (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope): (WebCore::HTMLElementStack::htmlElement): (WebCore::HTMLElementStack::rootNode): (WebCore::HTMLElementStack::pushCommon):
html/parser/HTMLElementStack.h: (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::ElementRecord::node): (WebCore::HTMLElementStack::topNode):
html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTagForInCell): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::finished):
html/parser/HTMLTreeBuilder.h:

8:21 PM Changeset in webkit [80200] by rniwa@webkit.org

9 edits in trunk/Source

2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80188.
http://trac.webkit.org/changeset/80188
https://bugs.webkit.org/show_bug.cgi?id=55647

Broke the WebKit API tests. (Requested by xenon on #webkit).

WebCore.exp.in:

2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80188.
http://trac.webkit.org/changeset/80188
https://bugs.webkit.org/show_bug.cgi?id=55647

Broke the WebKit API tests. (Requested by xenon on #webkit).

UIProcess/API/C/WKPage.cpp: (WKPageRunJavaScriptInMainFrame): (callRunJavaScriptBlockAndRelease):
UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): (WebKit::WebPageProxy::runJavaScriptInMainFrame): (WebKit::WebPageProxy::processDidCrash):
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::runJavaScriptInMainFrame):

7:44 PM Changeset in webkit [80199] by tkent@chromium.org

2 edits in trunk/Source/WebCore

2011-03-02 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix.

platform/text/LocalizedNumberICU.cpp: (WebCore::createFormatterForCurrentLocale): Fix a typo.

7:16 PM Changeset in webkit [80198] by tkent@chromium.org

3 edits in trunk/Source/WebCore

Caching number formatter instances in LocalizedNumber* implementations
https://bugs.webkit.org/show_bug.cgi?id=55629

Reviewed by Darin Adler.

No new tests. This change doesn't change existing behavior, and is
covered by existing tests.

platform/text/LocalizedNumberICU.cpp:

(WebCore::createFormatterForCurrentLocale):
(WebCore::numberFormatter): Introduce a function to return a static

instance of NumberFormat.

(WebCore::parseLocalizedNumber): Use numberFormatter().
(WebCore::formatLocalizedNumber): Use numberFormatter().

platform/text/mac/LocalizedNumberMac.mm:

(WebCore::createFormatterForCurrentLocale):
(WebCore::numberFormatter): Introduce a function to return a static

instance of NSNumberFormatter.

(WebCore::parseLocalizedNumber): Use numberFormatter().
(WebCore::formatLocalizedNumber): Use numberFormatter().

7:02 PM Changeset in webkit [80197] by ojan@chromium.org

2 edits in trunk/Tools

2011-03-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

[test-dashboard] make gtest JSON match layout-tests JSON
https://bugs.webkit.org/show_bug.cgi?id=55556

http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
Make this code match.

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

6:40 PM Changeset in webkit [80196] by jberlin@webkit.org

3 edits in trunk/WebKitLibraries

Update WebKitSystemInterface libraries. Library changes reviewed by Darin Adler.

libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:

6:30 PM Changeset in webkit [80195] by leviw@chromium.org

3 edits in trunk/Source/WebCore

2011-03-02 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

deprecatedEditingOffset should actually return the expected deprecated value for "after" positions
https://bugs.webkit.org/show_bug.cgi?id=54986

Calls to deprecatedEditingOffset needs to return the expected value for new Before/After positions
until we can update all the call sites to consider the new position types.

No tests. This is intended to simplify the transition to new Positions, not to change behavior.

dom/Position.cpp: (WebCore::Position::deprecatedEditingOffset): (WebCore::Position::offsetForPositionAfterAnchor): Added to do the right thing while ensuring inline-speed for most calls to deprecatedEditingOffset.
dom/Position.h:

5:59 PM Changeset in webkit [80194] by jeffm@apple.com

8 edits in trunk/Source/WebKit2

2011-03-02 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Rename WebKit::WebPage::validateMenuItem() to validateCommand()
https://bugs.webkit.org/show_bug.cgi?id=55636

Since this method can validate more than menu items, validateCommand() is a better name. Also rename various messages and WebKit::WebPageProxy::didValidateMenuItem() to didValidateCommand().

UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Call validateCommand() instead of validateMenuItem().
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::validateCommand): Renamed from validateMenuItem(). (WebKit::WebPageProxy::didValidateCommand): Renamed from didValidateMenuItem().
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in: Renamed DidValidateMenuItem to DidValidateCommand.
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::validateCommand): Renamed from validateMenuItem().
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Renamed ValidateMenuItem to ValidateCommand.

5:57 PM Changeset in webkit [80193] by mihaip@chromium.org

6 edits
4 adds
2 deletes in trunk/LayoutTests

2011-03-02 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Gentilcore.

Split up http/tests/cache/subresource-expiration.html so it stops timing out
https://bugs.webkit.org/show_bug.cgi?id=55639

http/tests/cache/subresource-expiration.html does a lot of sequential
loads, some with delays in between them. This seems unavoidable, so
to make the test less likely to time out (especially on debug bots),
the test cases are split across two tests.

http/tests/cache/subresource-expiration-1-expected.txt: Added.
http/tests/cache/subresource-expiration-1.html: Added.
http/tests/cache/subresource-expiration-2-expected.txt: Added.
http/tests/cache/subresource-expiration-2.html: Added.
http/tests/cache/subresource-expiration-expected.txt: Removed.
http/tests/cache/subresource-expiration.html: Removed.
platform/chromium/test_expectations.txt:
platform/mac-wk2/Skipped:
platform/mac/test_expectations.txt:
platform/qt-wk2/Skipped:
platform/win/Skipped:

5:45 PM Changeset in webkit [80192] by dpranke@chromium.org

9 edits in trunk/Tools

2011-03-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

NRWT - implement Linux Hardy 64-bit port support. This involves
adding support for non-'x86' architectures and updating the
"deduplicate_tests" script to correctly understand that
port.name() is not always equal to basename(port.baseline_path()).

This change introduces two new port names: 'chromium-linux-x86'
and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
flag will cause the code to determine which one to use at
runtime, just like we currently do with 'chromium-win'.

https://bugs.webkit.org/show_bug.cgi?id=55535

Scripts/webkitpy/common/system/executive_mock.py: Handle 'return_stderr' keyword arg to run_command()
Scripts/webkitpy/layout_tests/deduplicate_tests.py:
Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/chromium_linux.py:
Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
Scripts/webkitpy/layout_tests/port/factory.py:
Scripts/webkitpy/layout_tests/port/google_chrome.py:

5:41 PM Changeset in webkit [80191] by kevino@webkit.org

4 edits in trunk

[wx] Build fixes after recent changes.

5:38 PM Changeset in webkit [80190] by andersca@apple.com

6 edits in trunk/Source/WebKit2

2011-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WKPageSetMemoryCacheClientCallsEnabled doesn't persist if web process crashes
https://bugs.webkit.org/show_bug.cgi?id=55635

Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode): Encode and decode areMemoryCacheClientCallsEnabled.

Shared/WebPageCreationParameters.h: Add areMemoryCacheClientCallsEnabled member variable.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_areMemoryCacheClientCallsEnabled.

(WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled):
Update m_areMemoryCacheClientCallsEnabled. Send a message if necessary.

(WebKit::WebPageProxy::creationParameters):
Set areMemoryCacheClientCallsEnabled.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Call WebPage::setMemoryCacheMessagesEnabled.

5:32 PM Changeset in webkit [80189] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update

[chromium] xss-ALLOWED-from-javascript-url-sub-frame-to-javascript-url-sub-frame.html is crashy
https://bugs.webkit.org/show_bug.cgi?id=55634

platform/chromium/test_expectations.txt:

5:17 PM Changeset in webkit [80188] by timothy@apple.com

9 edits in trunk/Source

Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef.

Source/WebCore: Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).

Reviewed by Darin Adler.

WebCore.exp.in: Added ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.

Source/WebKit2: Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef.

https://webkit.org/b/55623

Reviewed by Darin Adler.

UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame): Use ScriptValueCallback.
(callRunJavaScriptBlockAndRelease): Use WKSerializedScriptValueRef.

UIProcess/API/C/WKPage.h: Use WKSerializedScriptValueRef.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Call invalidateCallbackMap for m_scriptValueCallbacks.
(WebKit::WebPageProxy::runJavaScriptInMainFrame): Take a ScriptValueCallback.
(WebKit::WebPageProxy::scriptValueCallback): Added. Create a WebSerializedScriptValue
from the DataReference before calling the callback.
(WebKit::WebPageProxy::processDidCrash): Call invalidateCallbackMap for m_scriptValueCallbacks.

UIProcess/WebPageProxy.h: Added ScriptValueCallback and m_scriptValueCallbacks.
UIProcess/WebPageProxy.messages.in: Added ScriptValueCallback.
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame): Create a DataReference from a WebCore::SerializedScriptValue.
And use ScriptValueCallback to send the message back.

5:12 PM Changeset in webkit [80187] by jberlin@webkit.org

2 edits in trunk/WebKitLibraries

Windows build fix. Unreviewed.

win/lib/WebKitSystemInterface.lib:

5:09 PM Changeset in webkit [80186] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2011-03-02 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Mark the other compositing/ directory as expected to fail on Leopard.

platform/chromium/test_expectations.txt:

5:00 PM Changeset in webkit [80185] by dcheng@chromium.org

13 edits in trunk/Source

2011-03-02 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Manually revert ChromiumDataObject changes.
https://bugs.webkit.org/show_bug.cgi?id=55627

No new tests since no functionality should change.

WebCore.gypi:
editing/chromium/EditorChromium.cpp: (WebCore::Editor::newGeneralClipboard):
page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::createDraggingClipboard):
platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clearData): (WebCore::ChromiumDataObject::clearAll): (WebCore::ChromiumDataObject::clearAllExceptFiles): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::getData): (WebCore::ChromiumDataObject::setData): (WebCore::ChromiumDataObject::ChromiumDataObject):
platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::copy): (WebCore::ChromiumDataObject::urlTitle): (WebCore::ChromiumDataObject::setUrlTitle): (WebCore::ChromiumDataObject::htmlBaseUrl): (WebCore::ChromiumDataObject::setHtmlBaseUrl): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::filenames): (WebCore::ChromiumDataObject::setFilenames): (WebCore::ChromiumDataObject::fileExtension): (WebCore::ChromiumDataObject::setFileExtension): (WebCore::ChromiumDataObject::fileContentFilename): (WebCore::ChromiumDataObject::setFileContentFilename): (WebCore::ChromiumDataObject::fileContent): (WebCore::ChromiumDataObject::setFileContent):
platform/chromium/ClipboardChromium.cpp:
platform/chromium/ClipboardChromium.h:

2011-03-02 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Manually revert ChromiumDataObject changes.
https://bugs.webkit.org/show_bug.cgi?id=55627

public/WebView.h:
src/WebDragData.cpp: (WebKit::WebDragData::initialize):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnter):
src/WebViewImpl.h:

4:49 PM Changeset in webkit [80184] by Martin Robinson

2 edits in trunk/Source/WebKit/gtk

2011-03-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Do a bit of cleanup in ChromeClientGtk. Instead of always fetching the
WebKitWebView from the frame, simply get it from the member variable of
the ChromeClientGtk instance itself.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scrollbarsVisible): (WebKit::ChromeClient::exceededDatabaseQuota): (WebKit::ChromeClient::requestGeolocationPermissionForFrame): (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame): (WebKit::ChromeClient::enterFullscreenForNode): (WebKit::ChromeClient::exitFullscreenForNode):

4:40 PM Changeset in webkit [80183] by jorlow@chromium.org

22 edits
5 copies in trunk

2011-03-02 David Grogan <dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: fire versionchange events when calling setVersion
https://bugs.webkit.org/show_bug.cgi?id=55095

storage/indexeddb/set_version_queue-expected.txt:
storage/indexeddb/set_version_queue.html:

2011-03-02 David Grogan <dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: fire versionchange events when calling setVersion
https://bugs.webkit.org/show_bug.cgi?id=55095

dom/EventNames.h:
storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close): (WebCore::IDBDatabase::onVersionChange): (WebCore::IDBDatabase::open): (WebCore::IDBDatabase::enqueueEvent): (WebCore::IDBDatabase::dispatchEvent):
storage/IDBDatabase.h: (WebCore::IDBDatabase::dispatchEvent):
storage/IDBDatabase.idl:
storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create): (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::databaseCallbacks): (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::PendingSetVersionCall): (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::open): (WebCore::IDBDatabaseBackendImpl::close):
storage/IDBDatabaseBackendImpl.h:
storage/IDBDatabaseBackendInterface.h:
storage/IDBDatabaseCallbacks.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.cpp. (WebCore::IDBDatabaseCallbacks::~IDBDatabaseCallbacks):
storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):
storage/IDBVersionChangeEvent.cpp: (WebCore::IDBVersionChangeEvent::create): (WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
storage/IDBVersionChangeEvent.h:
storage/IDBVersionChangeRequest.cpp: (WebCore::IDBVersionChangeRequest::onBlocked):

2011-03-02 David Grogan <dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: fire versionchange events when calling setVersion
https://bugs.webkit.org/show_bug.cgi?id=55095

WebKit.gyp:
src/IDBDatabaseCallbacksProxy.cpp: Copied from Source/WebCore/storage/IDBVersionChangeEvent.h. (WebCore::IDBDatabaseCallbacksProxy::create): (WebCore::IDBDatabaseCallbacksProxy::IDBDatabaseCallbacksProxy): (WebCore::IDBDatabaseCallbacksProxy::~IDBDatabaseCallbacksProxy): (WebCore::IDBDatabaseCallbacksProxy::onVersionChange):
src/IDBDatabaseCallbacksProxy.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.h.
src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::setVersion): (WebCore::IDBDatabaseProxy::close): (WebCore::IDBDatabaseProxy::open):
src/IDBDatabaseProxy.h:
src/WebIDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBVersionChangeEvent.cpp. (WebCore::WebIDBDatabaseCallbacksImpl::WebIDBDatabaseCallbacksImpl): (WebCore::WebIDBDatabaseCallbacksImpl::~WebIDBDatabaseCallbacksImpl): (WebCore::WebIDBDatabaseCallbacksImpl::onVersionChange):
src/WebIDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.h.
src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::setVersion): (WebKit::WebIDBDatabaseImpl::close): (WebKit::WebIDBDatabaseImpl::open):
src/WebIDBDatabaseImpl.h:

4:18 PM Changeset in webkit [80182] by ap@apple.com

2 edits in trunk/Source/WebCore

Fix assertion failures on Gtk bot.

page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks): Removed an overzealous assertion. We can get here with non-Tab key events when spatial navigation is enabled.

4:12 PM Changeset in webkit [80181] by mihaip@chromium.org

32 edits
9 deletes in trunk

2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80139.
http://trac.webkit.org/changeset/80139
https://bugs.webkit.org/show_bug.cgi?id=55620

failing and crashing tests on Snow Leopard bot (Requested by
mihaip1 on #webkit).

fast/dom/Geolocation/iframe-reparent-expected.txt: Removed.
fast/dom/Geolocation/iframe-reparent.html: Removed.
fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Removed.
fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Removed.
fast/dom/Geolocation/resources/iframe-reparent-page-iframe.html: Removed.
fast/dom/Geolocation/resources/iframe-reparent-page.html: Removed.
fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Removed.
fast/dom/Geolocation/script-tests/iframe-reparent.js: Removed.
fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Removed.
platform/gtk/Skipped:
platform/qt-wk2/Skipped:
platform/qt/Skipped:

2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80139.
http://trac.webkit.org/changeset/80139
https://bugs.webkit.org/show_bug.cgi?id=55620

failing and crashing tests on Snow Leopard bot (Requested by
mihaip1 on #webkit).

page/DOMWindow.cpp:
page/DOMWindow.h:
page/Frame.cpp: (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument):
page/Frame.h: (WebCore::Frame::detachFromPage):
page/Geolocation.cpp: (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::startUpdating): (WebCore::Geolocation::stopUpdating):
page/Geolocation.h:
page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
page/Navigator.cpp:
page/Navigator.h:
platform/mock/GeolocationClientMock.cpp:
platform/mock/GeolocationClientMock.h:

2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80139.
http://trac.webkit.org/changeset/80139
https://bugs.webkit.org/show_bug.cgi?id=55620

failing and crashing tests on Snow Leopard bot (Requested by
mihaip1 on #webkit).

public/WebGeolocationClientMock.h:
src/WebGeolocationClientMock.cpp:

2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80139.
http://trac.webkit.org/changeset/80139
https://bugs.webkit.org/show_bug.cgi?id=55620

failing and crashing tests on Snow Leopard bot (Requested by
mihaip1 on #webkit).

DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
DumpRenderTree/chromium/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
DumpRenderTree/mac/LayoutTestControllerMac.mm:
DumpRenderTree/mac/UIDelegate.h:
DumpRenderTree/mac/UIDelegate.mm:
DumpRenderTree/qt/LayoutTestControllerQt.cpp:
DumpRenderTree/qt/LayoutTestControllerQt.h:
DumpRenderTree/win/LayoutTestControllerWin.cpp:
DumpRenderTree/wx/LayoutTestControllerWx.cpp:

4:07 PM Changeset in webkit [80180] by jberlin@webkit.org

26 edits in trunk

Source/JavaScriptCore: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435

Reviewed by Adam Roben.

Add the ability to create a Private Browsing storage session.

wtf/Platform.h:

Add a new #define for using CF Storage Sessions.

Source/WebCore: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435

Reviewed by Adam Roben.

Add the ability to create a Private Browsing Storage Session.

WebCore.exp.in:

Export the symbol for ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase.

page/Settings.cpp:

(WebCore::Settings::setPrivateBrowsingEnabled):
Propagate the private browsing state to the ResourceHandle.

platform/mac/WebCoreSystemInterface.h:

Add the function declaration for wkCreatePrivateStorageSession.

platform/mac/WebCoreSystemInterface.mm:

platform/network/ResourceHandle.cpp:

(WebCore::privateStorageSession):
Since the same Private Browsing Storage Session will need to be accessed throughout the loading
code and will need to be used by all web pages and page groups, make it a global static.
(WebCore::privateBrowsingStorageSessionIdentifierBase):
Ditto, since the identifier is needed to create the Private Browsing Storage Session.
(WebCore::ResourceHandle::setPrivateBrowsingEnabled):
If enabled, create and store the Private Browsing Storage Session.
(WebCore::ResourceHandle::privateBrowsingStorageSession):
(WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase):

platform/network/ResourceHandle.h:

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
The call to wkCreatePrivateStorageSession needs to be in a file including the correct
version of WKSI.
(WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
Return the bundle identifier.

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
The call to wkCreatePrivateStorageSession needs to be in a file importing the correct
version of WKSI.
(WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
Return the bundle identifier.

Source/WebKit/mac: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Adam Roben.

Add the ability to create a Private Browsing Storage Session.

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Support calling wkCreatePrivateStorageSession from WebCore.

Source/WebKit2: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435

Reviewed by Adam Roben.

Add the ability to create a Private Browsing Storage Session.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
Encode the UI Process bundle identifier.
(WebKit::WebProcessCreationParameters::decode):
Decode the UI Process bundle identifier.

Shared/WebProcessCreationParameters.h:

UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
Grab the bundle identifier and use it to set the WebProcessCreationParameter.

UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Ditto.

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Support using the wkCreatePrivateStorageSession WKSI in WebCore.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Set the base for the Private Browsing Storage Session identifier to be the bundle identifier
from the UI Process so that WebKit1 would create a Private Browsing Storage Session with the
same identifier as WebKit2.

WebKitLibraries: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435

Rubber-stamped by Adam Roben.

Add the ability to create a Private Browsing Storage Session.

Update WebKitSystemInterface headers and libraries with the new functions.

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
win/include/WebKitSystemInterface/WebKitSystemInterface.h:
win/lib/WebKitSystemInterface.lib:

4:00 PM Changeset in webkit [80179] by oliver@apple.com

8 edits in trunk/Source/JavaScriptCore

2011-03-02 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove "register slot" concept from PropertySlot
https://bugs.webkit.org/show_bug.cgi?id=55621

PropertySlot had already stopped storing Register "slots"
so this patch is simply removing that api entirely.
This exposed a problem in the ProgramNode constructor for
BytecodeGenerator where it reads from the registerfile
before it has initialised it.

This bug wasn't a problem before as we were merely testing
for property existence rather than the actual value, and
used to work because setRegisterSlot didn't check that the
provided slot contained an initialised value.

To get around this issue we now use symbolTableHasProperty
to do the symbol table check without trying to read the
RegisterFile.

JavaScriptCore.xcodeproj/project.pbxproj:
bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator):
runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot):
runtime/JSActivation.cpp: (JSC::JSActivation::symbolTableGet):
runtime/JSGlobalObject.h: (JSC::JSGlobalObject::symbolTableHasProperty):
runtime/JSVariableObject.h: (JSC::JSVariableObject::symbolTableGet):
runtime/PropertySlot.h:

3:52 PM Changeset in webkit [80178] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2011-03-02 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

compositing/geometry/object-clip-rects-assertion.html no longer times
out on the Mac (was just a bad bot).

platform/chromium/test_expectations.txt:

3:44 PM Changeset in webkit [80177] by dcheng@chromium.org

13 edits in trunk/Source

2011-03-02 Daniel Cheng <dcheng@chromium.org>

Revert frame-specific WebClipboard changes
https://bugs.webkit.org/show_bug.cgi?id=55617

This code is no longer needed since we've decided to use the original
approach to copy/paste drag/drop handling in ClipboardChromium.

No new tests because no functionality changes.

platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::createReadable):
platform/chromium/ChromiumDataObject.h:
platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::create):
platform/chromium/PlatformBridge.h:
platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::create): (WebCore::ReadableDataObject::ReadableDataObject): (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
platform/chromium/ReadableDataObject.h:

2011-03-02 Daniel Cheng <dcheng@chromium.org>

Revert frame-specific WebClipboard changes
https://bugs.webkit.org/show_bug.cgi?id=55617

This code is no longer needed since we've decided to use the original
approach to copy/paste drag/drop handling in ClipboardChromium.

public/WebFrameClient.h:
src/PlatformBridge.cpp: (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames):
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::fromFrame):
src/WebFrameImpl.h:
src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnterNew):

3:37 PM Changeset in webkit [80176] by mihaip@chromium.org

1 edit
4 moves in trunk/LayoutTests

2011-03-02 Mihai Parparita <mihaip@chromium.org>

Unreviewed expectations update.

Promote expectations for fast/table/table-and-parts-outline.html and
svg/css/path-gradient-stroke-shadow.svg from chromium-mac/ to
mac-leopard/ so that 1) the test passes on mac-leopard 2) the test
on chromium-mac-snowlopard (which will now use the mac/ baselines).

platform/mac-leopard/fast/table/table-and-parts-outline-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/table/table-and-parts-outline-expected.checksum.
platform/mac-leopard/fast/table/table-and-parts-outline-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/table-and-parts-outline-expected.png.
platform/mac-leopard/svg/css/path-gradient-stroke-shadow-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/css/path-gradient-stroke-shadow-expected.checksum.
platform/mac-leopard/svg/css/path-gradient-stroke-shadow-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/css/path-gradient-stroke-shadow-expected.png.

3:19 PM Changeset in webkit [80175] by Adam Roben

2 edits in trunk/Tools

Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output

This matches DumpRenderTree on Windows.

Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
in WebKit2

Reviewed by Beth Dakin.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Moved code to force a paint here...
(WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.

3:15 PM Changeset in webkit [80174] by tony@chromium.org

4 edits in trunk/Source

2011-03-02 Tony Chang <tony@chromium.org>

Unreviewed, rolling chromium DEPS to r76362.

https://bugs.webkit.org/show_bug.cgi?id=55564

WebCore.gyp/WebCore.gyp: Switch to libjpeg_turbo to match chromium

2011-03-02 Tony Chang <tony@chromium.org>

Unreviewed, rolling chromium DEPS to r76362.

https://bugs.webkit.org/show_bug.cgi?id=55564

DEPS:

3:09 PM Changeset in webkit [80173] by ap@apple.com

2 edits in trunk/Source/WebCore

Build fix.

page/ChromeClient.h: (WebCore::ChromeClient::keyboardUIMode): I didn't mean to commit these changes yet.

2:51 PM Changeset in webkit [80172] by ap@apple.com

15 edits in trunk/Source/WebCore

Reviewed by John Sullivan.

Clean up WebCore tabsToLinks code a little
https://bugs.webkit.org/show_bug.cgi?id=55606

No change in behavior, so no tests.

html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isKeyboardFocusable): This is the only caller of tabsToAllControls(). Renamed this function to tabsToAllFormControls().

page/EventHandler.cpp: (WebCore::EventHandler::isKeyboardOptionTab): Moved from platform specific files. This function cannot be file static, because EventHandlerMac.mm uses it. (WebCore::eventInvertsTabsToLinksClientCallResult): Merged implementations from platform specific files. We can just as well have #if here. Renamed for clarity. (WebCore::EventHandler::tabsToLinks): Rewrote in a way that makes it clearer how "invert" works.

page/EventHandler.h: We no longer need invertSenseOfTabsToLinks() here, it's only used in EventHandler.cpp.

page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::tabsToAllFormControls):
page/brew/EventHandlerBrew.cpp: (WebCore::EventHandler::tabsToAllFormControls):
page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::tabsToAllFormControls):
page/efl/EventHandlerEfl.cpp: (WebCore::EventHandler::tabsToAllFormControls):
page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::tabsToAllFormControls):
page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::tabsToAllFormControls):
page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToAllFormControls):
page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::tabsToAllFormControls):
page/win/EventHandlerWin.cpp: (WebCore::EventHandler::tabsToAllFormControls):
page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::tabsToAllFormControls): Updating all port files.

2:46 PM Changeset in webkit [80171] by jorlow@chromium.org

37 edits
3 copies in trunk

2011-02-28 Jeremy Orlow <jorlow@chromium.org>

Reviewed by James Robinson.

Split IDBCursor.value into IDBCursor.primaryKey and IDBCursor.value
https://bugs.webkit.org/show_bug.cgi?id=55443

storage/indexeddb/cursor-delete-expected.txt:
storage/indexeddb/cursor-index-delete-expected.txt:
storage/indexeddb/cursor-update-expected.txt:
storage/indexeddb/cursor-update.html:
storage/indexeddb/duplicates-expected.txt:
storage/indexeddb/duplicates.html:
storage/indexeddb/index-basics-expected.txt:
storage/indexeddb/index-basics.html:
storage/indexeddb/index-cursor-expected.txt:
storage/indexeddb/index-cursor.html:

2011-02-28 Jeremy Orlow <jorlow@chromium.org>

Reviewed by James Robinson.

Split IDBCursor.value into IDBCursor.primaryKey and IDBCursor.value
https://bugs.webkit.org/show_bug.cgi?id=55443

Implement http://www.w3.org/Bugs/Public/show_bug.cgi?id=11948

The idea is to have an IDBCursor and an IDBCursorWithValue interface which
inherits from the former. index.openKeyCursor will return the former and
index/objectStore.openCursor will return the latter. We'll add a primaryKey
attribute to IDBCursor. It will always be the key of the associated object
store entry. For index.openCursor cursors, the key attribute will be the key
of the index. For objectStore.openCursors, it'll be the same as the
primaryKey. The value will be the value of the objectStore entry.

WebCore.gypi:
bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::deserializeAndSetProperty):
bindings/v8/SerializedScriptValue.h:
bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
storage/IDBAny.cpp: (WebCore::IDBAny::idbCursorWithValue): (WebCore::IDBAny::set):
storage/IDBAny.h:
storage/IDBCursor.cpp: (WebCore::IDBCursor::create): (WebCore::IDBCursor::primaryKey): (WebCore::IDBCursor::value):
storage/IDBCursor.h:
storage/IDBCursor.idl:
storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::primaryKey): (WebCore::IDBCursorBackendImpl::value): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::currentRowExists): (WebCore::IDBCursorBackendImpl::continueFunctionInternal): (WebCore::IDBCursorBackendImpl::deleteFunction): (WebCore::IDBCursorBackendImpl::loadCurrentRow):
storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
storage/IDBCursorBackendInterface.h:
storage/IDBCursorWithValue.cpp: Copied from Source/WebCore/storage/IDBCursor.idl. (WebCore::IDBCursorWithValue::create): (WebCore::IDBCursorWithValue::IDBCursorWithValue): (WebCore::IDBCursorWithValue::~IDBCursorWithValue):
storage/IDBCursorWithValue.h: Copied from Source/WebCore/storage/IDBCursorBackendInterface.h.
storage/IDBCursorWithValue.idl: Copied from Source/WebCore/storage/IDBCursor.idl.
storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursorInternal): (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::openKeyCursor):
storage/IDBIndexBackendImpl.h:
storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::openCursor):
storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::setCursorType): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
storage/IDBRequest.h:

2011-02-28 Jeremy Orlow <jorlow@chromium.org>

Reviewed by James Robinson.

Split IDBCursor.value into IDBCursor.primaryKey and IDBCursor.value
https://bugs.webkit.org/show_bug.cgi?id=55443

public/WebIDBCursor.h: (WebKit::WebIDBCursor::primaryKey): (WebKit::WebIDBCursor::value):
src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::primaryKey): (WebCore::IDBCursorBackendProxy::value):
src/IDBCursorBackendProxy.h:
src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::key): (WebKit::WebIDBCursorImpl::primaryKey): (WebKit::WebIDBCursorImpl::value):
src/WebIDBCursorImpl.h:

2:42 PM Changeset in webkit [80170] by Martin Robinson

5 edits in trunk/LayoutTests

2011-03-02 Martin Robinson <mrobinson@igalia.com>

Update GTK+ baselines after r80151.

platform/gtk/fast/css-generated-content/005-expected.txt:
platform/gtk/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
platform/gtk/fast/css-generated-content/no-openclose-quote-expected.txt:
platform/gtk/fast/invalid/residual-style-expected.txt:

2:40 PM Changeset in webkit [80169] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

Reviewed by Csaba Osztrogonác.

Patch by Aravind Akella <aravind.akella@nokia.com> on 2011-03-02

[Qt][WK2] Memory exhausted when building qtwebkit2 on linux
https://bugs.webkit.org/show_bug.cgi?id=55484

Using AllInOne files to avoid memory exhaustion for debug
builds on 32 bit linux machines.

No new tests. Fixing a build issue.

WebCore.pro:

2:39 PM Changeset in webkit [80168] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update

[chromium] plugins/embed-attributes-setting.html is crashy
https://bugs.webkit.org/show_bug.cgi?id=55616

platform/chromium/test_expectations.txt:

2:25 PM Changeset in webkit [80167] by mihaip@chromium.org

1 edit
8 deletes in trunk/LayoutTests

2011-03-02 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove chromium-gpu-mac/ text expectations mistakenly added by r80163
(tests should pass with mac/ expectations).

platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.txt: Removed.
platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.txt: Removed.
platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.txt: Removed.
platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.txt: Removed.
platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.txt: Removed.
platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.txt: Removed.
platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.txt: Removed.
platform/chromium-gpu-mac/compositing/self-painting-layers-expected.txt: Removed.

2:23 PM Changeset in webkit [80166] by dcheng@chromium.org

21 edits in trunk

2011-03-02 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsWinCE.cmake:
Source/cmakeconfig.h.cmake:
configure.ac:

2011-03-02 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

Configurations/FeatureDefines.xcconfig:
wtf/Platform.h:

2011-03-02 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
features.pri:

2011-03-02 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

features.gypi:

2011-03-02 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

Configurations/FeatureDefines.xcconfig:

2011-03-02 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

Scripts/build-webkit:

2011-03-02 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

2:14 PM Changeset in webkit [80165] by tonyg@chromium.org

5 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update

[chromium] Expectations update
https://bugs.webkit.org/show_bug.cgi?id=55615

platform/chromium-linux/fast/repaint/control-clip-expected.checksum:
platform/chromium-linux/fast/repaint/control-clip-expected.png:
platform/chromium-win/fast/repaint/control-clip-expected.checksum:
platform/chromium-win/fast/repaint/control-clip-expected.png:

1:56 PM Changeset in webkit [80164] by tonyg@chromium.org

3 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update

[chromium] Expectations to match r80157
https://bugs.webkit.org/show_bug.cgi?id=55613

platform/chromium-linux/fast/invalid/residual-style-expected.txt:
platform/chromium-win/fast/invalid/residual-style-expected.txt:

1:47 PM Changeset in webkit [80163] by mihaip@chromium.org

46 edits
124 adds in trunk/LayoutTests

2011-03-02 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Rebaseline Chromium GPU results for Snow Leopard.

platform/chromium-gpu-mac/compositing/animation/state-at-end-event-transform-layer-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.checksum:
platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
platform/chromium-gpu-mac/compositing/compositing-visible-descendant-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/compositing-visible-descendant-expected.png: Added.
platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.png: Added.
platform/chromium-gpu-mac/compositing/generated-content-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/generated-content-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.checksum:
platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.png:
platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.checksum:
platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png:
platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.txt: Added.
platform/chromium-gpu-mac/compositing/geometry/clipping-foreground-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/clipping-foreground-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/fixed-in-composited-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/fixed-in-composited-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/outline-change-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/outline-change-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/partial-layout-update-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/partial-layout-update-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/root-layer-update-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/root-layer-update-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/tall-page-composited-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/tall-page-composited-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.checksum:
platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.txt: Added.
platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.checksum:
platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png:
platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.txt: Added.
platform/chromium-gpu-mac/compositing/iframes/composited-iframe-scroll-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/iframes/composited-iframe-scroll-expected.png: Added.
platform/chromium-gpu-mac/compositing/iframes/iframe-content-flipping-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/iframes/iframe-content-flipping-expected.png: Added.
platform/chromium-gpu-mac/compositing/iframes/iframe-copy-on-scroll-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
platform/chromium-gpu-mac/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
platform/chromium-gpu-mac/compositing/images/direct-image-background-color-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/images/direct-image-background-color-expected.png: Added.
platform/chromium-gpu-mac/compositing/images/direct-svg-image-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/images/direct-svg-image-expected.png: Added.
platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.checksum:
platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.txt: Added.
platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.checksum:
platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.png:
platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.checksum:
platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.png:
platform/chromium-gpu-mac/compositing/masks/multiple-masks-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/masks/multiple-masks-expected.png: Added.
platform/chromium-gpu-mac/compositing/masks/simple-composited-mask-expected.checksum:
platform/chromium-gpu-mac/compositing/masks/simple-composited-mask-expected.png:
platform/chromium-gpu-mac/compositing/overflow/ancestor-overflow-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/overflow/ancestor-overflow-expected.png: Added.
platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.checksum:
platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.png: Added.
platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.checksum:
platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.png:
platform/chromium-gpu-mac/compositing/overflow/parent-overflow-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/overflow/parent-overflow-expected.png: Added.
platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.checksum:
platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.txt: Added.
platform/chromium-gpu-mac/compositing/overflow/scrollbar-painting-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/overflow/scrollbar-painting-expected.png: Added.
platform/chromium-gpu-mac/compositing/overflow/zero-size-overflow-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/overflow/zero-size-overflow-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/animation-inside-reflection-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/animation-inside-reflection-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/backface-hidden-reflection-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/backface-hidden-reflection-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.checksum:
platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.png:
platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.checksum:
platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png:
platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.txt: Added.
platform/chromium-gpu-mac/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-animated-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-animated-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-opacity-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-opacity-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-size-change-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-size-change-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/reflection-in-composited-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/reflection-in-composited-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/reflection-on-composited-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/reflection-on-composited-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/reflection-ordering-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/reflection-ordering-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/reflection-positioning-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/reflection-positioning-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/reflection-positioning2-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/reflection-positioning2-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/remove-add-reflection-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/remove-add-reflection-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/simple-composited-reflections-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.png: Added.
platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.checksum:
platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.png:
platform/chromium-gpu-mac/compositing/repaint/content-into-overflow-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/repaint/content-into-overflow-expected.png: Added.
platform/chromium-gpu-mac/compositing/repaint/layer-repaint-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/repaint/layer-repaint-expected.png: Added.
platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute-expected.png: Added.
platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.checksum:
platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.png:
platform/chromium-gpu-mac/compositing/repaint/overflow-into-content-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/repaint/overflow-into-content-expected.png: Added.
platform/chromium-gpu-mac/compositing/self-painting-layers-expected.checksum:
platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png:
platform/chromium-gpu-mac/compositing/self-painting-layers-expected.txt: Added.
platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.checksum:
platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
platform/chromium-gpu-mac/compositing/sibling-positioning-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/sibling-positioning-expected.png: Added.
platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.checksum:
platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.png:
platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.checksum:
platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
platform/chromium-gpu-mac/compositing/transitions/singular-scale-transition-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/transitions/singular-scale-transition-expected.png: Added.
platform/chromium-gpu-mac/compositing/webgl/webgl-reflection-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/webgl/webgl-reflection-expected.png: Added.
platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.checksum:
platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
platform/chromium/test_expectations.txt:

1:37 PM Changeset in webkit [80162] by tonyg@chromium.org

4 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update.

[chromium] Update expectations to match those in r80151
https://bugs.webkit.org/show_bug.cgi?id=55610

platform/chromium-win/fast/css-generated-content/005-expected.txt:
platform/chromium-win/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
platform/chromium-win/fast/css-generated-content/no-openclose-quote-expected.txt:

1:33 PM Changeset in webkit [80161] by Adam Roben

2 edits in trunk/Tools

Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer

ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
the former location, but was getting lucky on some SnowLeopard machines because symlinks
were being created there pointing into DiagnosticReports. For machines without these
symlinks, crash logs were not getting captured.

Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
SnowLeopard machines

Reviewed by Eric Seidel.

Scripts/old-run-webkit-tests:

(captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.

1:05 PM Changeset in webkit [80160] by Dimitri Glazkov

2 edits in trunk/Source/WebCore

2011-03-02 Dimitri Glazkov <Dimitri Glazkov>

Update location of media-file.js, which was moved in r79630.

manual-tests/media-controls.html: Updated location.

1:02 PM Changeset in webkit [80159] by tonyg@chromium.org

6 edits in trunk/Source/WebCore

2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80156.
http://trac.webkit.org/changeset/80156
https://bugs.webkit.org/show_bug.cgi?id=55604

"Broke SL compile" (Requested by tonyg-cr on #webkit).

bridge/jni/JNIBridge.h: (JSC::Bindings::JavaString::operator UString):
bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember):
bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass):
bridge/jni/jsc/JavaStringJSC.h: (JSC::Bindings::JavaStringImpl::uString):
bridge/jni/v8/JavaStringV8.h:

12:47 PM Changeset in webkit [80158] by Adam Roben

2 edits in trunk/Source/JavaScriptCore

Delete old .res files whenever any .vsprops file changes

Prospective fix for <http://webkit.org/b/55599> r80079 caused incremental Windows builds to
fail

Reviewed by Tony Chang.

JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:

(main): Restructured code to loop over a set of file extensions, deleting any old files that
have that extension. Now deletes .res files, too. (We previously deleted any file matching
*.manifest*, but that turned out to just be the union of *.manifest and *.res.)

12:43 PM Changeset in webkit [80157] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations

Updating expectations after r80151
https://bugs.webkit.org/show_bug.cgi?id=55601

platform/mac/fast/invalid/residual-style-expected.txt:

12:22 PM Changeset in webkit [80156] by steveblock@google.com

6 edits in trunk/Source/WebCore

2011-03-02 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaString API should be implementable by both JSC and V8
https://bugs.webkit.org/show_bug.cgi?id=55567

Remove JavaString's UString operator and replace it with a
script-engine-independent impl() method, which returns a
StringImpl and can be implemented with both JSC and V8.

No new tests, refactoring only.

bridge/jni/JNIBridge.h: (JSC::Bindings::JavaString::impl):
bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember):
bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass):
bridge/jni/jsc/JavaStringJSC.h: (JSC::Bindings::JavaStringImpl::impl):
bridge/jni/v8/JavaStringV8.h: (JSC::Bindings::JavaStringImpl::impl):

11:56 AM Changeset in webkit [80155] by mihaip@chromium.org

2 edits in trunk/Source/WebCore

2011-03-02 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Add CRASH() for CSSSelector double frees
https://bugs.webkit.org/show_bug.cgi?id=55596

To help track down bug 53045, add a CRASH call when the CSSSelector
destructor is invoked more than once.

Just a check, no new tests necessary.

css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::~CSSSelector):

11:54 AM Changeset in webkit [80154] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2011-03-02 Mihai Parparita <mihaip@chromium.org>

Unreviewed expectations update.

Add more Snow Leopard-only flakiness.

platform/chromium/test_expectations.txt:

11:48 AM Changeset in webkit [80153] by weinig@apple.com

13 edits
2 adds in trunk/Source/WebKit

Fix remaining localization issues by piping all localized strings through WebCore's
localization bottleneck.
<rdar://problem/8728860>

Reviewed by Anders Carlsson.

../WebKit:

WebKit.xcodeproj/project.pbxproj:

../WebKit/mac:

DefaultDelegates/WebDefaultContextMenuDelegate.mm:

(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):

Misc/WebKitErrors.m:
Misc/WebLocalizableStringsInternal.h: Added.
Misc/WebLocalizableStringsInternal.mm: Added.

(WebLocalizedStringInternal):

Panels/WebAuthenticationPanel.m:

(-[WebAuthenticationPanel setUpForChallenge:]):

Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost):

WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::updateWindowTitle):
(-[WebInspectorWindowController validateUserInterfaceItem:]):

WebCoreSupport/WebKeyGenerator.m:

(-[WebKeyGenerator strengthMenuItemTitles]):
(-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):

WebCoreSupport/WebPlatformStrategies.mm:
WebView/WebHTMLView.mm:

(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):

WebView/WebPDFView.mm:

(-[WebPDFView menuForEvent:]):

11:45 AM Changeset in webkit [80152] by Adam Roben

2 edits in trunk/Tools

Don't try to capture crash logs on platforms that haven't implemented that feature

Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash

Reviewed by Joseph Pecoraro.

Scripts/old-run-webkit-tests:

(captureSavedCrashLog): Bail if we don't have a crash log glob.
(findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
strictly required to fix bug 55504, but seems worthwhile.

11:34 AM Changeset in webkit [80151] by carol.szabo@nokia.com

31 edits
16 adds in trunk

content property doesn't support quotes
https://bugs.webkit.org/show_bug.cgi?id=6503

Patch by Carol Szabo <carol.szabo@nokia.com> on 2011-03-02
Reviewed by David Hyatt <hyatt@apple.com>

Source/WebCore:

Added full support for quotes as defined by CSS 2.1.

Tests: fast/css/content/content-quotes-01.html

fast/css/content/content-quotes-02.html
fast/css/content/content-quotes-03.html
fast/css/content/content-quotes-04.html
fast/css/content/content-quotes-05.html
fast/css/content/content-quotes-06.html

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseQuotes):

css/CSSParser.h:

Added needed stylesheet parsing support for quotes,
(no-)open-quote and (no-)close-quote

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Handled setting of the new quotes RenderStyle property and added
handling of quotes for the content property.

css/html.css:

(q:before):
(q:after):
replaced the '"' workaround with open/close-quote

rendering/RenderBlockLineLayout.cpp:

(WebCore::dirtyLineBoxesForRenderer):
Made RenderQuote behave like RenderCounter.
Needed to ensure that the Quote text is calculated before layout,
just as it is for RenderCounter.

rendering/RenderObject.h:

(WebCore::RenderObject::isQuote):

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Handled updating of quote depth when renderers are added and removed
from the tree.
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
Added support for Quote content.

rendering/RenderQuote.cpp: Added.

(WebCore::adjustDepth):
(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::renderName):
(WebCore::RenderQuote::placeQuote):
(WebCore::LanguageData::operator<):
(WebCore::defaultLanguageQuotes):
(WebCore::quotesMap):
(WebCore::quotesForLanguage):
(WebCore::defaultQuotes):
(WebCore::RenderQuote::originalText):
(WebCore::RenderQuote::computePreferredLogicalWidths):
(WebCore::RenderQuote::rendererSubtreeAttached):
(WebCore::RenderQuote::rendererRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):

rendering/RenderQuote.h: Added.

(WebCore::RenderQuote::isQuote):
(WebCore::toRenderQuote):

rendering/RenderingAllInOne.cpp:

Included RenderQuote.cpp

rendering/style/StyleAllInOne.cpp:

Included QuotesData.cpp

rendering/style/ContentData.cpp:

(WebCore::ContentData::dataEquivalent):
Checked for quotetype identity.
(WebCore::ContentData::deleteContent):
Accounted for the new QUOTE_TYPE.

rendering/style/ContentData.h:

(WebCore::ContentData::isQuote):
(WebCore::ContentData::quote):
(WebCore::ContentData::setQuote):

rendering/style/QuotesData.cpp: Added.

(WebCore::QuotesData::create):
(WebCore::QuotesData::operator==):
(WebCore::QuotesData::~QuotesData):

rendering/style/QuotesData.h: Added.

(WebCore::QuotesData::data):
(WebCore::QuotesData::operator delete):
(WebCore::QuotesData::QuotesData):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setContent):
(WebCore::RenderStyle::setQuotes):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::quotes):
(WebCore::InheritedFlags::setQuotes):

rendering/style/RenderStyleConstants.h:
rendering/style/StyleAllInOne.cpp:

Added QuotesData.cpp to the included files list.

rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::operator==):
Included quotes in equality check.

rendering/style/StyleRareInheritedData.h:

Added quotes

LayoutTests:

Added new tests for quotes. Fixed a few afected expected results.

fast/css/content/content-quotes-01-expected.txt: Added.
fast/css/content/content-quotes-01.html: Added.
fast/css/content/content-quotes-02-expected.txt: Added.
fast/css/content/content-quotes-02.html: Added.
fast/css/content/content-quotes-03-expected.txt: Added.
fast/css/content/content-quotes-03.html: Added.
fast/css/content/content-quotes-04-expected.txt: Added.
fast/css/content/content-quotes-04.html: Added.
fast/css/content/content-quotes-05-expected.txt: Added.
fast/css/content/content-quotes-05.html: Added.
fast/css/content/content-quotes-06-expected.txt: Added.
fast/css/content/content-quotes-06.html: Added.
platform/mac/fast/css-generated-content/005-expected.txt:
platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
platform/mac/fast/css-generated-content/no-openclose-quote-expected.txt:
platform/qt/fast/css-generated-content/005-expected.txt:
platform/qt/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
platform/qt/fast/css-generated-content/no-openclose-quote-expected.txt:

11:08 AM Changeset in webkit [80150] by Antti Koivisto

8 edits in trunk/Source/WebCore

Selector usage flags should not be set by the CSS parser
https://bugs.webkit.org/show_bug.cgi?id=55573

Reviewed by Dave Hyatt.

Currently flags like Document::usesSiblingRules() are set directly by the CSS parser. This is wrong as
we may parse stylesheets that are not actually used for document rendering. This is especially bad when
the page uses querySelectorAll(). As a result we may end up in various performance penalty boxes
triggered by complex selectors for no good reason.

Use the selector traversal in style selector constructor to figure out which flags are actually needed for the currently active style sheets.
Remove the selector flag related code from the CSS parser/grammar.
Remove the usesDescendantRules flag completely. We have descendant rules in the default style sheet, every document uses them.

css/CSSGrammar.y:
css/CSSParser.cpp:

(WebCore::CSSParser::updateSpecifiersWithElementName):

css/CSSStyleSelector.cpp:

(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::Features::Features):
(WebCore::CSSStyleSelector::Features::~Features):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromList):
(WebCore::RuleSet::collectFeatures):

css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::usesSiblingRules):
(WebCore::CSSStyleSelector::usesFirstLineRules):
(WebCore::CSSStyleSelector::usesBeforeAfterRules):
(WebCore::CSSStyleSelector::usesLinkRules):

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):

dom/Document.h:

(WebCore::Document::usesSiblingRules):
(WebCore::Document::setUsesSiblingRules):
(WebCore::Document::usesFirstLineRules):
(WebCore::Document::usesBeforeAfterRules):
(WebCore::Document::setUsesBeforeAfterRules):

dom/Element.cpp:

(WebCore::Element::recalcStyle):

10:57 AM Changeset in webkit [80149] by bweinstein@apple.com

2 edits in trunk/Source/WebKit/wince

WinCE build fix.

WebCoreSupport/PlatformStrategiesWinCE.h: Add a needed include.

10:52 AM Changeset in webkit [80148] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update

[chromium] svg/text/font-size-below-point-five.svg doesn't pass on mac release
https://bugs.webkit.org/show_bug.cgi?id=55593

platform/chromium/test_expectations.txt:

10:52 AM Changeset in webkit [80147] by bweinstein@apple.com

3 edits in trunk/Source/WebKit/wince

WinCE build fix. Have PlatformStrategiesWinCE inherit from CookiesStrategy,
and implement the needed methods.

WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::createCookiesStrategy):
(PlatformStrategiesWinCE::notifyCookiesChanged):

WebCoreSupport/PlatformStrategiesWinCE.h:

10:46 AM Changeset in webkit [80146] by bweinstein@apple.com

2 edits in trunk/Source/WebCore

Fix fallout from a last minute renaming.

platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):

10:44 AM Changeset in webkit [80145] by bweinstein@apple.com

21 edits
1 add in trunk/Source

Source/WebCore: Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add functions on CookieStorage that allow listening for changes in cookies. When
the cookies are changed, they call through to CookiesStrategy::notifyCookiesChanged.

No change in behavior requiring tests.

platform/CookiesStrategy.h: Added.

(WebCore::CookiesStrategy::~CookiesStrategy):

platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::cookiesStrategy):
(WebCore::PlatformStrategies::PlatformStrategies):

platform/network/CookieStorage.h: Add new function declarations.

platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::notifyCookiesChangedOnMainThread): Call through to CookiesStrategy::notifyCookiesChanged.
(WebCore::notifyCookiesChanged): Call notifyCookiesChangedOnMainThread on the main thread.
(WebCore::beginObservingCookieChanges): Set up cookie observers on the loader run loop.
(WebCore::finishObservingCookieChanges): Remove our cookie observers from the loader run loop.

platform/network/mac/CookieStorageMac.mm:

(-[CookieStorageObjCAdapter notifyCookiesChangedOnMainThread]): Call through to CookiesStrategy::notifyCookiesChanged.
(-[CookieStorageObjCAdapter cookiesChangedNotificationHandler:]): Call notifyCookiesChangedOnMainThread on

the main thread.

(-[CookieStorageObjCAdapter registerForCookieChangeNotifications]): Set up the observer for cookie change notifications.
(-[CookieStorageObjCAdapter unregisterForCookieChangeNotifications]): Remove the observer for cookie change notifications.
(WebCore::beginObservingCookieChanges): Create our CookieStorageObjCAdapter, and call registerForCookieChangeNotifications.
(WebCore::finishObservingCookieChanges): Call unregisterForCookieChangeNotifications.

Add new file.

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj: Set role on files we need to include in WebKit to private.

Source/WebKit/mac: Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add stubs for CookiesStrategy on Mac WebKit1.

WebCoreSupport/WebPlatformStrategies.h:
WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::createCookiesStrategy):
(WebPlatformStrategies::notifyCookiesChanged):

Source/WebKit/qt: Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add stubs for CookiesStrategy on Qt WebKit1.

WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::createCookiesStrategy):
(WebPlatformStrategies::notifyCookiesChanged):

WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit/win: Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add stubs for CookiesStrategy on Windows WebKit1.

WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::createCookiesStrategy):
(WebPlatformStrategies::notifyCookiesChanged):

WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit2: Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::dispatchDidModifyCookies): Add a stub with a FIXME to send a

message to the UI process.

WebProcess/Cookies/WebCookieManager.h:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::createCookiesStrategy):
(WebKit::WebPlatformStrategies::notifyCookiesChanged): Call WebCookieManager::dispatchDidModifyCookies.

WebProcess/WebCoreSupport/WebPlatformStrategies.h:

10:42 AM Changeset in webkit [80144] by jschuh@chromium.org

3 edits
2 adds in trunk

2011-03-02 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

A WebKitCSSKeyframesRule object should set itself as the parent for inserted rules
https://bugs.webkit.org/show_bug.cgi?id=55488

Test: fast/css/css-keyframe-parent.html

css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::append):

2011-03-02 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

A WebKitCSSKeyframesRule object should set itself as the parent for inserted rules
https://bugs.webkit.org/show_bug.cgi?id=55488

fast/css/css-keyframe-parent-expected.txt: Added.
fast/css/css-keyframe-parent.html: Added.

10:03 AM Changeset in webkit [80143] by sergio@webkit.org

2 edits in trunk/Source/WebCore

2011-03-02 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add support for external protocol handlers
https://bugs.webkit.org/show_bug.cgi?id=55473

Do not unconditionally create and replace the SoupRequester of the
SoupSession if there is already one. No new tests needed as we
just allow clients to create their our SoupRequesters.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):

9:50 AM Changeset in webkit [80142] by jknotten@chromium.org

2 edits in trunk/Source/WebCore

2011-03-02 John Knottenbelt <jknotten@chromium.org>

Reviewed by jknotten@chromium.org.

Fix build-breakage when GEOLOCATION not enabled.
https://bugs.webkit.org/show_bug.cgi?id=55586

Geolocation::reset needs to be defined if ENABLE(GEOLOCATION)
is not true.

page/Geolocation.cpp: (WebCore::Geolocation::reset):

9:39 AM Changeset in webkit [80141] by pfeldman@chromium.org

18 edits in trunk/Source/WebCore

2011-03-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove InjectedScriptHost -> DOMAgent dependency.
https://bugs.webkit.org/show_bug.cgi?id=55575

bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::inspectedNode):
bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluateOn): (WebCore::InjectedScript::wrapObject): (WebCore::InjectedScript::wrapNode): (WebCore::InjectedScript::inspectNode): (WebCore::InjectedScript::nodeAsScriptValue):
inspector/InjectedScript.h:
inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::addInspectedNode): (WebCore::InjectedScriptHost::clearInspectedNodes): (WebCore::InjectedScriptHost::copyText): (WebCore::InjectedScriptHost::inspectedNode):
inspector/InjectedScriptHost.h:
inspector/InjectedScriptHost.idl:
inspector/InjectedScriptSource.js:
inspector/Inspector.idl:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::addInspectedNode): (WebCore::InspectorDOMAgent::resolveNode): (WebCore::InspectorDOMAgent::injectedScriptForNode):
inspector/InspectorDOMAgent.h:
inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluateOn):
inspector/InspectorRuntimeAgent.h:
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved): (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady): (WebInspector.PropertiesSidebarPane.prototype.update.fillSection): (WebInspector.PropertiesSidebarPane.prototype.update):
inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.resolveNode): (WebInspector.RemoteObject.prototype.pushNodeToFrontend): (WebInspector.RemoteObject.prototype.evaluate):

9:28 AM Changeset in webkit [80140] by Adam Roben

2 edits in trunk/LayoutTests

Add some new tests to the WebKit2 Skipped file

platform/mac-wk2/Skipped:

9:15 AM Changeset in webkit [80139] by jknotten@chromium.org

32 edits
9 adds in trunk

2011-02-16 John Knottenbelt <jknotten@chromium.org>

Reviewed by Dmitry Titov.

Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

Ensure that all geolocation permission requests are cancelled
when the page is detached from its frame.

fast/dom/Geolocation/iframe-reparent-expected.txt: Added.
fast/dom/Geolocation/iframe-reparent.html: Added.
fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added.
fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added.
fast/dom/Geolocation/resources/iframe-reparent-page-iframe.html: Added.
fast/dom/Geolocation/resources/iframe-reparent-page.html: Added.
fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added.
fast/dom/Geolocation/script-tests/iframe-reparent.js: Added. (window2Loaded): (firstWatchUpdate): (secondWatchUpdate): (firstWatchError): (secondWatchError): (maybeFinish):
fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added.
platform/gtk/Skipped:
platform/qt-wk2/Skipped:
platform/qt/Skipped:

2011-01-21 John Knottenbelt <jknotten@chromium.org>

Reviewed by Dmitry Titov.

Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

On Page destruction, any outstanding Geolocation permission
requests should be cancelled, because the Geolocation can only
access the client indirectly via m_frame->page().

Additionally, if the Frame is reparented to another page, the
Geolocation should cancel watches, single-shots and requests on
the old page.

Page destruction is signalled by a call to the
Frame::pageDestroyed() method. This calls Frame::detachFromPage,
where we extend the call chain to Geolocation::detachFromPage()
where we call Geolocation::reset() which detaches from the
GeolocationController, cancels requests, watches and single shots,
and sets the permission state back to Unknown.

We also now call detachFromPage when the frame reparented in
Frame::transferChildFrameToNewDocument.

Frame::pageDestroyed() is also called by FrameLoader even though
the page is not destroyed. We should still cancel permission
requests, because the GeolocationClient will become inaccessible
to the Geolocation object after this call.

Since GeolocationController is owned by Page, and all Geolocation
objects will now unsubscribe from the GeolocationController on
pageDetached(), we no longer need to call stopUpdating() from the
GeolocationController's destructor. Instead we can simply assert
that there should be no no observers. See related bug
https://bugs.webkit.org/show_bug.cgi?id=52216 .

Introduced new method 'numberOfPendingPermissionRequests' on
GeolocationClientMock to count the number of outstanding pending
permission requests. This provides a reusable implementation for
client-based implementations of the LayoutTestController's
numberOfPendingGeolocationPermissionRequests method.

Tests: fast/dom/Geolocation/iframe-reparent.html

fast/dom/Geolocation/page-reload-cancel-permission-requests.html

page/DOMWindow.cpp: (WebCore::DOMWindow::resetGeolocationPermissions):
page/DOMWindow.h:
page/Frame.cpp: (WebCore::Frame::detachFromPage): (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument):
page/Frame.h:
page/Geolocation.cpp: (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::page): (WebCore::Geolocation::reset): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::startUpdating): (WebCore::Geolocation::stopUpdating):
page/Geolocation.h:
page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
page/Navigator.cpp: (WebCore::Navigator::resetGeolocationPermissions):
page/Navigator.h:
platform/mock/GeolocationClientMock.cpp: (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
platform/mock/GeolocationClientMock.h:

2011-01-26 John Knottenbelt <jknotten@chromium.org>

Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

Add accessors to the WebGeolocationClientMock to allow the number of
pending geolocation permission requests to be queried.

public/WebGeolocationClientMock.h:
src/WebGeolocationClientMock.cpp: (WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests):

2011-01-26 John Knottenbelt <jknotten@chromium.org>

Reviewed by Dmitry Titov.

Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

Extend the layout test controller to expose the number of pending
geolocation requests, so that we can test that the requests have
been cancelled on page close.

DumpRenderTree/LayoutTestController.cpp: (numberOfPendingGeolocationPermissionRequestsCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
DumpRenderTree/chromium/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
DumpRenderTree/mac/UIDelegate.h:
DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
DumpRenderTree/qt/LayoutTestControllerQt.h:
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):

9:11 AM Changeset in webkit [80138] by commit-queue@webkit.org

2 edits
3 adds in trunk/LayoutTests

2011-03-02 Martin Maly <mmaly@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Expectation updates for strict mode V8 features.
https://bugs.webkit.org/show_bug.cgi?id=55538

platform/chromium/fast/js/mozilla/strict/15.10.7-expected.txt: Added.
platform/chromium/fast/js/mozilla/strict/15.3.5.1-expected.txt: Added.
platform/chromium/fast/js/mozilla/strict/15.5.5.1-expected.txt: Added.
platform/chromium/test_expectations.txt:

9:04 AM Changeset in webkit [80137] by antonm@chromium.org

6 edits in trunk/LayoutTests/platform/chromium-mac/fast/blockflow

Unreviewed. Another rebaseline.

platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png
platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum
platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png
platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png

8:57 AM Changeset in webkit [80136] by Philippe Normand

3 edits in trunk/Source/WebKit/mac

2011-03-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] support in mac video fullscreen controller
https://bugs.webkit.org/show_bug.cgi?id=52280

Factored the code to configure the video overlay in a new private
method of the controller and added GStreamer support to it.

WebView/WebVideoFullscreenController.h:
WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController setupVideoOverlay:]): (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]): (-[WebVideoFullscreenController windowDidExitFullscreen]):

8:45 AM Changeset in webkit [80135] by mnaganov@chromium.org

17 edits
1 add in trunk/Source/WebCore

2011-03-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Landing detailed heap snapshots, part 4.
https://bugs.webkit.org/show_bug.cgi?id=55563

This part adds implementations for data grids used to display
different heap snapshots projections. We are almost done.

English.lproj/localizedStrings.js:
WebCore.gypi:
bindings/v8/ScriptHeapSnapshot.cpp: (WebCore::ScriptHeapSnapshot::getExactRetainedSize):
bindings/v8/ScriptHeapSnapshot.h:
inspector/Inspector.idl:
inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
inspector/InspectorProfilerAgent.h:
inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotObjectNode): (WebInspector.HeapSnapshotObjectNode.prototype._createProvider): (WebInspector.HeapSnapshotInstanceNode): (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider): (WebInspector.HeapSnapshotDominatorObjectNode): (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider): (MixInSnapshotNodeFunctions):
inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotContainmentDataGrid): (WebInspector.HeapSnapshotSortableDataGrid): (WebInspector.HeapSnapshotConstructorsDataGrid): (WebInspector.HeapSnapshotDiffDataGrid): (WebInspector.HeapSnapshotDominatorsDataGrid): (WebInspector.HeapSnapshotRetainingPathsList): (WebInspector.DetailedHeapshotView.profileCallback): (WebInspector.DetailedHeapshotView):
inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotEdge.prototype.get isInvisible): (WebInspector.HeapSnapshotEdge.prototype.toString): (WebInspector.HeapSnapshot.prototype._init): (WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes): (WebInspector.HeapSnapshot.prototype._markInvisibleEdges): (WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):
inspector/front-end/Images/helpButtonGlyph.png: Added.
inspector/front-end/Panel.js: (WebInspector.Panel.prototype.reset):
inspector/front-end/Popover.js: (WebInspector.Popover): (WebInspector.Popover.prototype.show): (WebInspector.Popover.prototype.hide): (WebInspector.Popover.prototype.get visible):
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset): (WebInspector.ProfilesPanel.prototype.getProfile):
inspector/front-end/heapProfiler.css:
inspector/front-end/inspector.js: (WebInspector.resetFocusElement):

8:33 AM Changeset in webkit [80134] by mnaganov@chromium.org

1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/StylesSidebarPane.js

Merge 76941 - 2011-01-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [STYLES] Up/Down-suggestion breaks an existing keyword
https://bugs.webkit.org/show_bug.cgi?id=53295

Select the current word suffix before switching to the next suggestion.

inspector/front-end/StylesSidebarPane.js: ():

TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/6591106

8:30 AM Changeset in webkit [80133] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2011-03-02 Ryosuke Niwa <rniwa@webkit.org>

Yet another unreviewed Chromium rebaselines for r80121.

platform/chromium-win/editing/pasteboard/subframe-dragndrop-1-expected.txt:

8:14 AM Changeset in webkit [80132] by rniwa@webkit.org

3 edits
1 add in trunk/LayoutTests

2011-03-02 Ryosuke Niwa <rniwa@webkit.org>

Another unreviewed Chromium rebaselines for r80121.

platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt: Added.
platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
platform/chromium/test_expectations.txt:

8:01 AM Changeset in webkit [80131] by abecsi@webkit.org

4 edits in trunk

2011-03-02 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt][WK2] generate-forwarding-headers.pl should generate paths with framework names
https://bugs.webkit.org/show_bug.cgi?id=55478

On case insensitive systems the generated forwarding headers cause build problems.

Source/WebKit.pri: Adjust INCLUDEPATH for the project.

2011-03-02 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt][WK2] generate-forwarding-headers.pl should generate paths with framework names
https://bugs.webkit.org/show_bug.cgi?id=55478

On case insensitive systems the generated forwarding headers cause build problems.

Scripts/generate-forwarding-headers.pl: The generated header should also contain the framework name.

7:54 AM Changeset in webkit [80130] by Adam Roben

2 edits in trunk/LayoutTests

Skip a crashing test on Windows

<http://webkit.org/b/55069> tracks the failure.

platform/win/Skipped: Added fast/text/international/text-combine-parser-test.html.

7:44 AM Changeset in webkit [80129] by Csaba Osztrogonác

1 edit
1 delete in trunk/LayoutTests

Unreviewed.

Assertion failure after removing a selection in keydown handler
https://bugs.webkit.org/show_bug.cgi?id=51389

Remove unnecessary Qt specific expected result.

platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Removed.

7:36 AM Changeset in webkit [80128] by rniwa@webkit.org

161 edits in trunk/LayoutTests

2011-03-02 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines for r80121; Added the failing expectation for
editing/input/setting-input-value-cancel-ime-composition.html due to the bug 55560.

platform/chromium/test_expectations.txt:
platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt: Updated.
platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt: Ditto.
platform/chromium-win/editing/ [...]: Ditto.

7:07 AM Changeset in webkit [80127] by rniwa@webkit.org

163 edits in trunk/LayoutTests

2011-03-02 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed GTK rebaselines for r80121; Also skip editing/input/setting-input-value-cancel-ime-composition.html
because GTK port doesn't implement textInputController.hasMarkedText().

platform/gtk/Skipped:
platform/gtk/editing/ [...]: Updated.
platform/gtk/fast/dom/delete-contents-expected.txt: Ditto.

7:01 AM Changeset in webkit [80126] by Adam Roben

2 edits in trunk/WebKitLibraries

Try to force a clean build on the Windows bots

Some of the bots are running into bogus linker errors due to MSVC's "minimal rebuild"
feature not rebuilding files it should. See <http://queues.webkit.org/results/8076907> for
an example.

win/tools/vsprops/common.vsprops: Touched to force a rebuild.

6:52 AM Changeset in webkit [80125] by jeffm@apple.com

4 edits in trunk/Source/WebKit2

2011-03-01 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Expose some selection state fields in WKPage
https://bugs.webkit.org/show_bug.cgi?id=55541

Added WKPageCanDelete(), WKPageHasSelectedRange(), and WKPageIsContentEditable() so we can enable some
Edit menu items properly on Windows when using WebKit2.

UIProcess/API/C/WKPage.cpp: (WKPageCanDelete): Added. (WKPageHasSelectedRange): Added. (WKPageIsContentEditable): Added.
UIProcess/API/C/WKPage.h: Added new functions.
UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::canDelete): Added. (WebKit::WebPageProxy::hasSelectedRange): Added. (WebKit::WebPageProxy::isContentEditable): Added.

6:47 AM Changeset in webkit [80124] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

<http://webkit.org/b/55534> Clean up macros in Extensions3DOpenGL.cpp

Reviewed by Darin Adler.

Change "#if GL_APPLE_vertex_array_object" macros to check that
GL_APPLE_vertex_array_object is both defined and non-zero.

platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES): Remove
empty #else clause.
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES): Add early
return check. Remove #else clause that would never have
compiled (since array is not a WTF::String).

6:45 AM Changeset in webkit [80123] by Csaba Osztrogonác

143 edits
13 copies
123 adds in trunk/LayoutTests

Unreviewed.

Assertion failure after removing a selection in keydown handler
https://bugs.webkit.org/show_bug.cgi?id=51389

Update Qt specific expected results after r80121.

platform/qt/Skipped: Add editing/input/setting-input-value-cancel-ime-composition.html because of missing feature.
platform/qt/editing/ [...] : Updated.

6:40 AM Changeset in webkit [80122] by Adam Roben

2 edits in trunk/LayoutTests

Skip new test added in r80121 on Windows

It depends on textInputController, which DRT doesn't have on Windows.

platform/win/Skipped: Added editing/input/setting-input-value-cancel-ime-composition.html.

5:57 AM Changeset in webkit [80121] by rniwa@webkit.org

189 edits
2 adds in trunk

2011-03-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Assertion failure after removing a selection in keydown handler
https://bugs.webkit.org/show_bug.cgi?id=51389

Added tests to ensure WebKit updates offset properly when deleting date
to editing/selection/character-data-mutation.html.

Added a test to ensure WebKit clears composition marks inside an input
element when the value is set programatically.

Many tests are rebaselined due to selection changed caused by the patch
and additional respondToChangedSelection calls.

editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
editing/deleting/delete-by-word-001-expected.txt:
editing/deleting/delete-by-word-002-expected.txt:
editing/deleting/delete-ligature-001-expected.txt:
editing/deleting/delete-ligature-002-expected.txt:
editing/deleting/delete-ligature-003-expected.txt:
editing/deleting/pruning-after-merge-1-expected.txt:
editing/deleting/skip-virama-001-expected.txt:
editing/execCommand/createLink-expected.txt:
editing/execCommand/hilitecolor-expected.txt:
editing/execCommand/outdent-nested-lists-1-expected.txt:
editing/execCommand/unlink-expected.txt:
editing/input/setting-input-value-cancel-ime-composition-expected.txt: Added.
editing/input/setting-input-value-cancel-ime-composition.html: Added.
editing/inserting/insert-thai-characters-001-expected.txt:
editing/pasteboard/copy-in-password-field-expected.txt:
editing/pasteboard/paste-into-anchor-text-expected.txt:
editing/selection/character-data-mutation-expected.txt:
editing/selection/character-data-mutation.html:
editing/style/remove-underline-from-stylesheet-expected.txt:
editing/style/style-3690704-fix-expected.txt:
editing/style/typing-style-003-expected.txt:
editing/undo/redo-style-expected.txt:
platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt:
platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
platform/mac/editing/deleting/delete-3608430-fix-expected.txt:
platform/mac/editing/deleting/delete-3608445-fix-expected.txt:
platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
platform/mac/editing/deleting/delete-3775172-fix-expected.txt:
platform/mac/editing/deleting/delete-3800834-fix-expected.txt:
platform/mac/editing/deleting/delete-3857753-fix-expected.txt:
platform/mac/editing/deleting/delete-3928305-fix-expected.txt:
platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
platform/mac/editing/deleting/delete-after-span-ws-001-expected.txt:
platform/mac/editing/deleting/delete-and-undo-expected.txt:
platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-012-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-013-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-014-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-015-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-016-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
platform/mac/editing/deleting/delete-block-table-expected.txt:
platform/mac/editing/deleting/delete-br-007-expected.txt:
platform/mac/editing/deleting/delete-character-001-expected.txt:
platform/mac/editing/deleting/delete-hr-expected.txt:
platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
platform/mac/editing/deleting/delete-listitem-001-expected.txt:
platform/mac/editing/deleting/delete-listitem-002-expected.txt:
platform/mac/editing/deleting/delete-selection-001-expected.txt:
platform/mac/editing/deleting/delete-tab-001-expected.txt:
platform/mac/editing/deleting/delete-tab-002-expected.txt:
platform/mac/editing/deleting/delete-tab-003-expected.txt:
platform/mac/editing/deleting/delete-tab-004-expected.txt:
platform/mac/editing/deleting/delete-trailing-ws-001-expected.txt:
platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
platform/mac/editing/deleting/delete-ws-fixup-003-expected.txt:
platform/mac/editing/deleting/delete-ws-fixup-004-expected.txt:
platform/mac/editing/deleting/forward-delete-expected.txt:
platform/mac/editing/deleting/list-item-1-expected.txt:
platform/mac/editing/deleting/paragraph-in-preserveNewline-expected.txt:
platform/mac/editing/deleting/whitespace-pre-1-expected.txt:
platform/mac/editing/execCommand/find-after-replace-expected.txt:
platform/mac/editing/execCommand/insertHorizontalRule-expected.txt:
platform/mac/editing/execCommand/paste-1-expected.txt:
platform/mac/editing/execCommand/paste-2-expected.txt:
platform/mac/editing/input/5576619-expected.txt:
platform/mac/editing/input/emacs-ctrl-o-expected.txt:
platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
platform/mac/editing/input/text-input-controller-expected.txt:
platform/mac/editing/inserting/4278698-expected.txt:
platform/mac/editing/inserting/editing-empty-divs-expected.txt:
platform/mac/editing/inserting/insert-3654864-fix-expected.txt:
platform/mac/editing/inserting/insert-3851164-fix-expected.txt:
platform/mac/editing/inserting/insert-after-delete-001-expected.txt:
platform/mac/editing/inserting/insert-br-003-expected.txt:
platform/mac/editing/inserting/insert-br-006-expected.txt:
platform/mac/editing/inserting/insert-br-007-expected.txt:
platform/mac/editing/inserting/insert-br-008-expected.txt:
platform/mac/editing/inserting/insert-br-009-expected.txt:
platform/mac/editing/inserting/insert-br-at-tabspan-002-expected.txt:
platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
platform/mac/editing/inserting/insert-div-003-expected.txt:
platform/mac/editing/inserting/insert-div-006-expected.txt:
platform/mac/editing/inserting/insert-div-007-expected.txt:
platform/mac/editing/inserting/insert-div-008-expected.txt:
platform/mac/editing/inserting/insert-div-024-expected.txt:
platform/mac/editing/inserting/insert-div-025-expected.txt:
platform/mac/editing/inserting/insert-space-in-empty-doc-expected.txt:
platform/mac/editing/inserting/insert-tab-003-expected.txt:
platform/mac/editing/inserting/insert-text-at-tabspan-001-expected.txt:
platform/mac/editing/inserting/insert-text-at-tabspan-002-expected.txt:
platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
platform/mac/editing/inserting/multiple-lines-selected-expected.txt:
platform/mac/editing/inserting/paragraph-separator-03-expected.txt:
platform/mac/editing/inserting/redo-expected.txt:
platform/mac/editing/inserting/return-key-with-selection-003-expected.txt:
platform/mac/editing/inserting/typing-001-expected.txt:
platform/mac/editing/inserting/typing-002-expected.txt:
platform/mac/editing/inserting/typing-003-expected.txt:
platform/mac/editing/inserting/typing-around-br-001-expected.txt:
platform/mac/editing/inserting/typing-around-image-001-expected.txt:
platform/mac/editing/pasteboard/4076267-2-expected.txt:
platform/mac/editing/pasteboard/4076267-3-expected.txt:
platform/mac/editing/pasteboard/4076267-expected.txt:
platform/mac/editing/pasteboard/4700297-expected.txt:
platform/mac/editing/pasteboard/8145-3-expected.txt:
platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
platform/mac/editing/pasteboard/cut-text-001-expected.txt:
platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
platform/mac/editing/pasteboard/interchange-newline-1-expected.txt:
platform/mac/editing/pasteboard/interchange-newline-2-expected.txt:
platform/mac/editing/pasteboard/merge-end-1-expected.txt:
platform/mac/editing/pasteboard/merge-end-2-expected.txt:
platform/mac/editing/pasteboard/merge-end-3-expected.txt:
platform/mac/editing/pasteboard/merge-end-4-expected.txt:
platform/mac/editing/pasteboard/merge-end-5-expected.txt:
platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
platform/mac/editing/pasteboard/merge-end-borders-expected.txt:
platform/mac/editing/pasteboard/merge-end-list-expected.txt:
platform/mac/editing/pasteboard/merge-end-table-expected.txt:
platform/mac/editing/pasteboard/paste-line-endings-007-expected.txt:
platform/mac/editing/pasteboard/paste-line-endings-008-expected.txt:
platform/mac/editing/pasteboard/paste-line-endings-009-expected.txt:
platform/mac/editing/pasteboard/paste-line-endings-010-expected.txt:
platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
platform/mac/editing/pasteboard/paste-pre-001-expected.txt:
platform/mac/editing/pasteboard/paste-pre-002-expected.txt:
platform/mac/editing/pasteboard/paste-table-003-expected.txt:
platform/mac/editing/pasteboard/paste-table-cells-expected.txt:
platform/mac/editing/pasteboard/paste-text-001-expected.txt:
platform/mac/editing/pasteboard/paste-text-002-expected.txt:
platform/mac/editing/pasteboard/paste-text-003-expected.txt:
platform/mac/editing/pasteboard/paste-text-004-expected.txt:
platform/mac/editing/pasteboard/paste-text-005-expected.txt:
platform/mac/editing/pasteboard/paste-text-008-expected.txt:
platform/mac/editing/pasteboard/paste-text-009-expected.txt:
platform/mac/editing/pasteboard/paste-text-019-expected.txt:
platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
platform/mac/editing/pasteboard/paste-xml-expected.txt:
platform/mac/editing/pasteboard/pasting-object-expected.txt:
platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
platform/mac/editing/pasteboard/smart-paste-003-expected.txt:
platform/mac/editing/pasteboard/smart-paste-004-expected.txt:
platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
platform/mac/editing/pasteboard/smart-paste-006-expected.txt:
platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
platform/mac/editing/selection/replace-selection-1-expected.txt:
platform/mac/editing/selection/select-all-iframe-expected.txt:
platform/mac/editing/spelling/spelling-expected.txt:
platform/mac/editing/style/relative-font-size-change-002-expected.txt:
platform/mac/editing/style/relative-font-size-change-003-expected.txt:
platform/mac/editing/style/smoosh-styles-001-expected.txt:
platform/mac/editing/style/style-3681552-fix-001-expected.txt:
platform/mac/editing/style/style-3681552-fix-002-expected.txt:
platform/mac/editing/style/style-boundary-002-expected.txt:
platform/mac/editing/style/style-boundary-003-expected.txt:
platform/mac/editing/style/style-boundary-005-expected.txt:
platform/mac/editing/style/typing-style-001-expected.txt:
platform/mac/editing/style/typing-style-002-expected.txt:
platform/mac/editing/style/unbold-in-bold-expected.txt:
platform/mac/editing/undo/4063751-expected.txt:
platform/mac/editing/undo/redo-typing-001-expected.txt:
platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
platform/mac/editing/undo/undo-combined-delete-expected.txt:
platform/mac/editing/undo/undo-delete-boundary-expected.txt:
platform/mac/editing/undo/undo-delete-expected.txt:
platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
platform/mac/editing/undo/undo-forward-delete-expected.txt:
platform/mac/editing/undo/undo-misspellings-expected.txt:
platform/mac/editing/undo/undo-typing-001-expected.txt:
platform/mac/editing/unsupported-content/list-type-after-expected.txt:
platform/mac/editing/unsupported-content/list-type-before-expected.txt:
platform/mac/editing/unsupported-content/table-type-after-expected.txt:
platform/mac/editing/unsupported-content/table-type-before-expected.txt:
platform/mac/fast/dom/delete-contents-expected.txt:

2011-03-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Assertion failure after removing a selection in keydown handler
https://bugs.webkit.org/show_bug.cgi?id=51389

The bug was caused by textWillBeReplaced's not always updating selection, and
shouldRemovePositionAfterAdoptingTextReplacement's not moving the end offset when it's
at the end of replaced data.

Fixed the bug by always updating selection in textWillBeReplaced and fixing the condition
to move the offset in shouldRemovePositionAfterAdoptingTextReplacement. Also added a call
to setSelection instead of directly modifying m_selection to notify all the clients.
Namely, the call to EditorClient::respondToChangedSelection is required for
setting-input-value-cancel-ime-composition.html.

Note that we must update layout before calling setSelection because setSelection calls
setFocusedNodeIfNeeded and it requires layout to be up-to-date. Without this call, tests
such as fast/forms/input-appearance-maxlength.html hits an assertion in Node::isFocusable.

Test: editing/input/setting-input-value-cancel-ime-composition.html

editing/SelectionController.cpp: (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): When replacing text, the offset of the selection end must be updated even if it was at the end of the replaced text. e.g. removing "world" from "hello world] WebKit" should result in "hello ] WebKit" not "hello WebK[it". Note we don't move the offset if no text is removed because appending "world" to "hello ]" should result in "hello ]world" not "hello world]". (WebCore::SelectionController::textWillBeReplaced): Calls setSelection to update the selection instead of modifying m_selection directly.

5:48 AM Changeset in webkit [80120] by sergio@webkit.org

2 edits in trunk/LayoutTests

2011-03-02 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Replaced 2 tests in GTK Skipped list that were skipped by mistake
by the ones that are actually failing.

platform/gtk/Skipped:

5:46 AM Changeset in webkit [80119] by podivilov@chromium.org

3 edits in trunk/Source/WebCore

2011-03-02 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: highlighted line does not span horizonally in scripts panel while debugging.
https://bugs.webkit.org/show_bug.cgi?id=54675

inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._syncScroll): (WebInspector.TextEditorChunkedPanel.prototype._buildChunks): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorGutterPanel): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly): (WebInspector.TextEditorMainPanel.prototype._getSelection): (WebInspector.TextEditorMainPanel.prototype._selectionToPosition): (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
inspector/front-end/textViewer.css: (.inner-container):

5:42 AM Changeset in webkit [80118] by mnaganov@chromium.org

1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/StylesSidebarPane.js

Merge 76913 - 2011-01-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [STYLES] Cancelled suggestion of a property name results in a visual artifact
https://bugs.webkit.org/show_bug.cgi?id=53242

inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):

TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/6596106

5:14 AM Changeset in webkit [80117] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2011-03-02 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; added the missing blank line at the end.

platform/qt/http/tests/security/xss-DENIED-xml-external-entity-expected.txt:

5:10 AM WebKit Team edited by andreas.kling@nokia.com

(diff)

5:02 AM WebKit Team edited by benjamin.poulain@nokia.com

(diff)

5:02 AM Changeset in webkit [80116] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-03-02 Oleg Romashin <romaxa@gmail.com>

Reviewed by Andreas Kling.

Fixing inspector compilation with JAVASCRIPT_DEBUGGER disabled
https://bugs.webkit.org/show_bug.cgi?id=55477

inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::populateScriptObjects):

5:00 AM Changeset in webkit [80115] by sergio@webkit.org

2 edits in trunk/LayoutTests

2011-03-02 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Adding 3 new tests to the skipped list waiting for better viewport
error/warning messages.

platform/gtk/Skipped:

4:41 AM Changeset in webkit [80114] by rniwa@webkit.org

1 edit
1 add in trunk/LayoutTests

2011-03-02 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Qt rebaselines for r80061.

platform/qt/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.

4:35 AM Changeset in webkit [80113] by sergio@webkit.org

3 edits in trunk/LayoutTests

2011-03-02 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Rebaseline after r80061 and r80107.

platform/gtk/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt:
platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:

4:27 AM Changeset in webkit [80112] by Csaba Osztrogonác

1 edit
3 adds in trunk/LayoutTests

Unreviewed.

REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
https://bugs.webkit.org/show_bug.cgi?id=55323

Add Qt specific expected result for test introduced in r79934.

platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.checksum: Added.
platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.
platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Added.

4:18 AM Changeset in webkit [80111] by antonm@chromium.org

1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

And another attempt to do proper GPU override.

platform/chromium/test_expectations.txt

3:55 AM Changeset in webkit [80110] by antonm@chromium.org

1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Another attempt to propertly rebaseling GPU variant of fast/canvas/canvas-strokePath-gradient-shadow.html

platform/chromium/test_expectations.txt

3:48 AM Changeset in webkit [80109] by antonm@chromium.org

1 edit
2 adds in trunk/LayoutTests/platform

Unreviewed. Rebaselining for Chromium after http://trac.webkit.org/changeset/80061/

platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt
platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt
platform/chromium-win/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt

3:45 AM Changeset in webkit [80108] by antonm@chromium.org

1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Remove invalid suppression.

platform/chromium/test_expectations.txt

3:42 AM Changeset in webkit [80107] by sergio@webkit.org

61 edits
12 adds in trunk/LayoutTests

2011-03-02 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed expectations update. This is a follow-up to r80061.

Viewport tests were expected to produce new error, warning,
and tip console messages. The current output is correct,
but many of the warnings are wrong. Fixing the incorrect
warnings will be handled by:
https://bugs.webkit.org/show_bug.cgi?id=53707

There are also a number of xsl tests that have extra warnings
in qt when "Running an XSL-T 1.0 stylesheet with a 2.0 processor".
These tests now have qt platform specific results.

fast/viewport/viewport-100-expected.txt:
fast/viewport/viewport-101-expected.txt:
fast/viewport/viewport-102-expected.txt:
fast/viewport/viewport-103-expected.txt:
fast/viewport/viewport-112-expected.txt:
fast/viewport/viewport-115-expected.txt:
fast/viewport/viewport-116-expected.txt:
fast/viewport/viewport-117-expected.txt:
fast/viewport/viewport-121-expected.txt:
fast/viewport/viewport-122-expected.txt:
fast/viewport/viewport-125-expected.txt:
fast/viewport/viewport-129-expected.txt:
fast/viewport/viewport-29-expected.txt:
fast/viewport/viewport-30-expected.txt:
fast/viewport/viewport-31-expected.txt:
fast/viewport/viewport-32-expected.txt:
fast/viewport/viewport-35-expected.txt:
fast/viewport/viewport-36-expected.txt:
fast/viewport/viewport-38-expected.txt:
fast/viewport/viewport-39-expected.txt:
fast/viewport/viewport-40-expected.txt:
fast/viewport/viewport-41-expected.txt:
fast/viewport/viewport-42-expected.txt:
fast/viewport/viewport-43-expected.txt:
fast/viewport/viewport-44-expected.txt:
fast/viewport/viewport-46-expected.txt:
fast/viewport/viewport-47-expected.txt:
fast/viewport/viewport-48-expected.txt:
fast/viewport/viewport-49-expected.txt:
fast/viewport/viewport-52-expected.txt:
fast/viewport/viewport-53-expected.txt:
fast/viewport/viewport-54-expected.txt:
fast/viewport/viewport-55-expected.txt:
fast/viewport/viewport-61-expected.txt:
fast/viewport/viewport-62-expected.txt:
fast/viewport/viewport-63-expected.txt:
fast/viewport/viewport-64-expected.txt:
fast/viewport/viewport-66-expected.txt:
fast/viewport/viewport-67-expected.txt:
fast/viewport/viewport-68-expected.txt:
fast/viewport/viewport-69-expected.txt:
fast/viewport/viewport-70-expected.txt:
fast/viewport/viewport-71-expected.txt:
fast/viewport/viewport-72-expected.txt:
fast/viewport/viewport-73-expected.txt:
fast/viewport/viewport-74-expected.txt:
fast/viewport/viewport-75-expected.txt:
fast/viewport/viewport-76-expected.txt:
fast/viewport/viewport-77-expected.txt:
fast/viewport/viewport-78-expected.txt:
fast/viewport/viewport-79-expected.txt:
fast/viewport/viewport-80-expected.txt:
fast/viewport/viewport-81-expected.txt:
fast/viewport/viewport-83-expected.txt:
fast/viewport/viewport-85-expected.txt:
fast/viewport/viewport-90-expected.txt:
platform/qt/fast/events/xsl-onload-expected.txt: Added.
platform/qt/fast/parser/xslt-with-html-expected.txt: Added.
platform/qt/fast/xsl/document-function-expected.txt:
platform/qt/fast/xsl/subframe-location-expected.txt: Added.
platform/qt/fast/xsl/transform-to-html-expected.txt: Added.
platform/qt/fast/xsl/utf8-chunks-expected.txt: Added.
platform/qt/fast/xsl/xslt-bad-import-uri-expected.txt: Added.
platform/qt/fast/xsl/xslt-doc-noenc-expected.txt: Added.
platform/qt/fast/xsl/xslt-entity-enc-expected.txt: Added.
platform/qt/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt:
platform/qt/fast/xsl/xslt-recursion-expected.txt: Added.
platform/qt/http/tests/misc/location-test-xsl-style-sheet-expected.txt: Added.
platform/qt/http/tests/security/xss-DENIED-xsl-document-expected.txt:
platform/qt/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt:
platform/qt/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
platform/qt/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Added.

3:35 AM Changeset in webkit [80106] by antonm@chromium.org

1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreivewed. Temporary disabling fast/canvas/canvas-strokePath-gradient-shadow.html

platform/chromium/test_expectations.txt

3:13 AM Changeset in webkit [80105] by tkent@chromium.org

4 edits in trunk

2011-03-02 Kent Tamura <tkent@chromium.org>

Unreviewed, a trivial fix for r80096.

REGRESSION (r80096): [Chromium] fast/forms/input-number-unacceptable-style.html failure
https://bugs.webkit.org/show_bug.cgi?id=55562

platform/chromium/test_expectations.txt:

2011-03-02 Kent Tamura <tkent@chromium.org>

Unreviewed, a trivial fix for r80096.

REGRESSION (r80096): [Chromium] fast/forms/input-number-unacceptable-style.html failure
https://bugs.webkit.org/show_bug.cgi?id=55562

platform/text/LocalizedNumberICU.cpp: (WebCore::parseLocalizedNumber): Check the ParsePosition after NumberFormat::parse() to reject strings with a valid number + extra letters.

2:02 AM Changeset in webkit [80104] by tkent@chromium.org

2 edits in trunk/LayoutTests

2011-03-02 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

platform/chromium/test_expectations.txt: Mark fast/forms/input-number-unacceptable-style.html as TEXT.

1:49 AM Changeset in webkit [80103] by steveblock@google.com

7 edits
2 copies in trunk/Source/WebCore

2011-03-02 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JObjectWrapper should be moved to its own file
https://bugs.webkit.org/show_bug.cgi?id=55384

No new tests, refactoring only.

Android.v8bindings.mk:
WebCore.gypi:
bridge/jni/v8/JNIBridgeV8.cpp: (JavaField::JavaField):
bridge/jni/v8/JNIBridgeV8.h:
bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::JavaInstance):
bridge/jni/v8/JavaInstanceV8.h:
bridge/jni/v8/JobjectWrapper.cpp: Copied from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h. (JobjectWrapper::JobjectWrapper): (JobjectWrapper::~JobjectWrapper):
bridge/jni/v8/JobjectWrapper.h: Copied from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h. (JSC::Bindings::JobjectWrapper::instance): (JSC::Bindings::JobjectWrapper::setInstance): (JSC::Bindings::JobjectWrapper::ref): (JSC::Bindings::JobjectWrapper::deref):

1:40 AM Changeset in webkit [80102] by caseq@chromium.org

9 edits
1 add in trunk/Source/WebCore

2011-02-25 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: factor search logic out of inspector.js
https://bugs.webkit.org/show_bug.cgi?id=54965

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.switchToAndFocus): (WebInspector.ElementsPanel.prototype._updateMatchesCount):
inspector/front-end/Panel.js: (WebInspector.Panel.prototype.searchCanceled): (WebInspector.Panel.prototype.performSearch.updateMatchesCount):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.searchCanceled): (WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback): (WebInspector.ScriptsPanel.prototype.performSearch):
inspector/front-end/SearchController.js: Added. (WebInspector.SearchController): (WebInspector.SearchController.prototype.updateSearchMatchesCount): (WebInspector.SearchController.prototype.updateSearchLabel): (WebInspector.SearchController.prototype.cancelSearch): (WebInspector.SearchController.prototype.handleShortcut): (WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch): (WebInspector.SearchController.prototype.activePanelChanged): (WebInspector.SearchController.prototype._updateSearchMatchesCount): (WebInspector.SearchController.prototype._focusSearchField): (WebInspector.SearchController.prototype._onSearchFieldManualFocus): (WebInspector.SearchController.prototype._onKeyDown): (WebInspector.SearchController.prototype._onSearch): (WebInspector.SearchController.prototype._performSearch):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:
inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.set attached): (WebInspector.doLoadedDone): (WebInspector.documentKeyDown):

1:22 AM Changeset in webkit [80101] by tkent@chromium.org

12 edits in trunk/LayoutTests

2011-03-02 Kent Tamura <tkent@chromium.org>

Unreviewed.

Update a test and test expectation for r80096.

fast/forms/input-number-unacceptable-style-expected.txt:
fast/forms/input-number-unacceptable-style.html: ICU seems to accept "-1+" as a number. So change it to "-1a".
platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum:
platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum:
platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:

12:47 AM Changeset in webkit [80100] by abarth@webkit.org

3 edits in trunk/Source/JavaScriptCore

2011-03-02 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Teach JavaScriptCore GYP build how to build minidom
https://bugs.webkit.org/show_bug.cgi?id=55536

JavaScriptCore.gypi:
gyp/JavaScriptCore.gyp:

12:40 AM Changeset in webkit [80099] by reni@webkit.org

5 edits in trunk/Source/WebCore

FEMorphologyElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55462

Reviewed by Andreas Kling.

When the FEMorphologyElement receives an update message but the given value remains the same we don't need
to relayout the filter.

No new tests are needed because this modification is covered by the dynamic update tests of FEMorphology.

platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::setMorphologyOperator):
(WebCore::FEMorphology::setRadiusX):
(WebCore::FEMorphology::setRadiusY):

platform/graphics/filters/FEMorphology.h:
svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):
(WebCore::SVGFEMorphologyElement::svgAttributeChanged):

svg/SVGFEMorphologyElement.h:

Mar 1, 2011:

11:34 PM Changeset in webkit [80098] by commit-queue@webkit.org

2 edits
1 add
3 deletes in trunk/LayoutTests

2011-03-01 Anna Cavender <annacc@chromium.org>

Reviewed by Eric Carlson.

Remove playing of video in media/video-replaces-poster.html and update text results.
https://bugs.webkit.org/show_bug.cgi?id=54910

media/video-replaces-poster-expected.txt: Added.
media/video-replaces-poster.html:
platform/chromium-win/media/video-replaces-poster-expected.txt: Removed.
platform/gtk/media/video-replaces-poster-expected.txt: Removed.
platform/mac/media/video-replaces-poster-expected.txt: Removed.

11:05 PM EFLWebKit edited by gyuyoung.kim@samsung.com

(diff)

11:04 PM Changeset in webkit [80097] by tkent@chromium.org

9 edits
2 adds in trunk

2011-03-01 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Assertion fails when a form validation bubble appears
https://bugs.webkit.org/show_bug.cgi?id=55550

fast/forms/interactive-validation-attach-assertion-expected.txt: Added.
fast/forms/interactive-validation-attach-assertion.html: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2011-03-01 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Assertion fails when a form validation bubble appears
https://bugs.webkit.org/show_bug.cgi?id=55550

Test: fast/forms/interactive-validation-attach-assertion.html

html/ValidationMessage.cpp: (WebCore::ValidationMessage::buildBubbleTree): Just remove unnecessary attach().

2011-03-01 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Assertion fails when a form validation bubble appears
https://bugs.webkit.org/show_bug.cgi?id=55550

Test: fast/forms/interactive-validation-attach-assertion.html

DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): Enable the interactive validation feature by default. This matches to Chromium browser.

10:54 PM Changeset in webkit [80096] by tkent@chromium.org

17 edits
2 copies
1 add in trunk

Support localized numbers in <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=42484

Reviewed by Dimitri Glazkov.

Source/WebCore:

This change adds support of localized numbers in <input type=number>.
This affects only the UI, and not HTMLInputElement::value.

Remove the keyboard input restriction feature because it is hard to retrieve characters usable for localized numbers in ICU.

Separate convertFromVisibleValue() from sanitizeValue(). sanitizeValue() is used for not only converting a renderer value to a DOM value.

Implement LocalizedNumber functions for ICU and NSNumberFormatter. It is used only in Chromium for now.

Test: manual-tests/input-number-localization.html

WebCore.gypi: Use LocalizedNumberICU.cpp.
WebCore.xcodeproj/project.pbxproj: Add LocalizedNumberMac.mm and remove LocalizedNumberNone.cpp.
dom/InputElement.h: Introduce convertFromVisibleValue().
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::convertFromVisibleValue):

html/HTMLInputElement.h:
html/InputType.cpp:

(WebCore::InputType::convertFromVisibleValue):

html/InputType.h:
html/NumberInputType.cpp: Remove isHTMLNumberCharacter(), isNumberCharacter(), and handleBeforeTextInsertedEvent() because we remove the keyboard input restriction feature for type=number.

(WebCore::NumberInputType::convertFromVisibleValue):
(WebCore::NumberInputType::sanitizeValue):

html/NumberInputType.h:
manual-tests/input-number-localization.html: Add a manual test because the behavior depends on the current locale.
platform/text/LocalizedNumber.h: Remove isLocalizedNumberCharacter().
platform/text/LocalizedNumberICU.cpp: Implement LocalizedNumber functions with ICU NumberFormat.

(WebCore::createFormatterForCurrentLocale):
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):

platform/text/LocalizedNumberNone.cpp: Remove isLocalizedNumberCharacter().
platform/text/mac/LocalizedNumberMac.mm: Implement LocalizedNumber functions with NSNumberFormatter.

(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::subtreeHasChanged):

wml/WMLInputElement.h:

(WebCore::WMLInputElement::convertFromVisibleValue):

Implemented as a function doing nothing.

LayoutTests:

Update an existing test because of removing the keyboard input
restriction feature.

fast/forms/input-number-keyoperation-expected.txt:
fast/forms/script-tests/input-number-keyoperation.js:

10:28 PM Changeset in webkit [80095] by gyuyoung.kim@samsung.com

2 edits in trunk/Tools

2011-03-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

Remove efl port style exception of Webcore/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=55549

WebCore and JavaScriptCore need to adhere WebKit coding style.

Scripts/webkitpy/style/checker.py:

10:14 PM Changeset in webkit [80094] by abarth@webkit.org

4 edits in trunk/Source/JavaScriptCore

2011-03-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

JavaScriptCore GYP build should copy some headers into the target framework
https://bugs.webkit.org/show_bug.cgi?id=55524

After this patch, all the framework headers are exported as public
headers. We need to teach GYP how to handle private headers.

I struggled to determine how to store the information about whether a
header was public, private, or project (i.e., not exported).
Generally, the GYPI should just list the files, but it seemed siliy to
have an almost duplicated list of files in the GYP file itself. If
this design doesn't scale, we might have to revisit it in the future.

JavaScriptCore.gyp/JavaScriptCore.gyp:
JavaScriptCore.gypi:
gyp/JavaScriptCore.gyp:

10:08 PM Changeset in webkit [80093] by tony@chromium.org

2 edits in trunk/Tools

2011-03-01 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] clean up temp files on chromium-mac builder too
https://bugs.webkit.org/show_bug.cgi?id=55525

BuildSlaveSupport/chromium/remove-crash-logs:

10:06 PM Changeset in webkit [80092] by yutak@chromium.org

3 edits in trunk/Source/WebCore

2011-03-01 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r78383): Failure to connect on websocketstest.com
https://bugs.webkit.org/show_bug.cgi?id=54811

After r78383, KURL::setPort() no longer appends ":port" part
if that port is the default port for URL scheme. This broke
SocketStreamHandleCFNet, whose code was based on an assumption
that KURL::setPort() always inserts ":port" part.

To fix this, KURL::port() call is removed from SocketStreamHandle
and the port number is calculated on-the-fly.

Unfortunately it is impossible to write a test; this bug only
affects WebSockets connecting to the default port (port 80
for ws, port 443 for wss), while we use different ports to test
WebSockets in LayoutTests.

platform/network/cf/SocketStreamHandle.h:
platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::createStreams): (WebCore::SocketStreamHandle::port):

9:49 PM Changeset in webkit [80091] by commit-queue@webkit.org

2 edits
56 adds in trunk/LayoutTests

2011-03-01 Victoria Kirst <vrk@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] videos are not painted for compositing/ tests
https://bugs.webkit.org/show_bug.cgi?id=54694

Videos are now painted for compositing tests. This patch uploads the
expected layout results and enables the tests again.

platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.checksum: Added.
platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png: Added.
platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.checksum: Added.
platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png: Added.
platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.checksum: Added.
platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png: Added.
platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png: Added.
platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.checksum: Added.
platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.checksum: Added.
platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png: Added.
platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.checksum: Added.
platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png: Added.
platform/chromium-gpu-linux/compositing/self-painting-layers-expected.checksum: Added.
platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png: Added.
platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png: Added.
platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png: Added.
platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png: Added.
platform/chromium-gpu-mac/compositing/self-painting-layers-expected.checksum: Added.
platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png: Added.
platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.checksum: Added.
platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png: Added.
platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.txt: Added.
platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.checksum: Added.
platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png: Added.
platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.txt: Added.
platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.checksum: Added.
platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png: Added.
platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.txt: Added.
platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png: Added.
platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.txt: Added.
platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.checksum: Added.
platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.checksum: Added.
platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png: Added.
platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.txt: Added.
platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.checksum: Added.
platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png: Added.
platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.txt: Added.
platform/chromium-gpu-win/compositing/self-painting-layers-expected.checksum: Added.
platform/chromium-gpu-win/compositing/self-painting-layers-expected.png: Added.
platform/chromium-gpu-win/compositing/self-painting-layers-expected.txt: Added.
platform/chromium/test_expectations.txt:

8:44 PM Changeset in webkit [80090] by ojan@chromium.org

5 edits in trunk/Tools

2011-02-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

wrap json in a function call to afford cross-domain loading
https://bugs.webkit.org/show_bug.cgi?id=55353

Also delete the code that compacts the JSON. It turns out this
breaks the rebaseline tool and is probably a premature optimization anyways.

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/tool/commands/rebaselineserver.py:

8:25 PM Changeset in webkit [80089] by mrowe@apple.com

2 edits in trunk/Source/WebKit2

Hide the typeinfo name symbols for std::exception and std::bad_alloc too.

Configurations/Base.xcconfig:

8:21 PM Changeset in webkit [80088] by Joseph Pecoraro

2 edits
2 adds in trunk/LayoutTests

2011-03-01 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed expectations update. This is a follow-up to r80061.

Leopard has a slightly different error message, so
platform/mac-leopard needs its own expected results for the
websocket test. Added platform specific expected results for
the other tests which are consistently failing with an extra
console message on the bots.

platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
platform/mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
platform/mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.

7:57 PM Changeset in webkit [80087] by jorlow@chromium.org

3 edits
1 add in trunk/Source/WebKit/chromium

2011-03-01 David Grogan <dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: public webkit interfaces for firing versionchange events to IDBDatabase objects
https://bugs.webkit.org/show_bug.cgi?id=55548

WebKit.gyp:
public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::open):
public/WebIDBDatabaseCallbacks.h: Added. (WebKit::WebIDBDatabaseCallbacks::~WebIDBDatabaseCallbacks): (WebKit::WebIDBDatabaseCallbacks::onVersionChange):

7:22 PM Changeset in webkit [80086] by rniwa@webkit.org

17 edits in trunk

2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547

"Broke the Win debug build?" (Requested by dcheng on #webkit).

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547

"Broke the Win debug build?" (Requested by dcheng on #webkit).

Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsWinCE.cmake:
Source/cmakeconfig.h.cmake:

2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547

"Broke the Win debug build?" (Requested by dcheng on #webkit).

wtf/Platform.h:

2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547

"Broke the Win debug build?" (Requested by dcheng on #webkit).

features.gypi:

2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547

"Broke the Win debug build?" (Requested by dcheng on #webkit).

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
features.pri:

2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547

"Broke the Win debug build?" (Requested by dcheng on #webkit).

Scripts/build-webkit:

7:14 PM Changeset in webkit [80085] by Joseph Pecoraro

2 edits in trunk/LayoutTests

2011-03-01 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed expectations update. This is expected
behavior after r80061, which enabled printing
of more console messages.

http/tests/xmlviewer/dumpAsText/wml-expected.txt:

7:05 PM Changeset in webkit [80084] by kevino@webkit.org

2 edits in trunk/Source/WebKit/wx

[wx] Build fix after removal of Frame::isContentEditable.

6:54 PM Changeset in webkit [80083] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80078.
http://trac.webkit.org/changeset/80078
https://bugs.webkit.org/show_bug.cgi?id=55545

underlying change was rolled out (Requested by tonyg-cr on
#webkit).

platform/chromium/test_expectations.txt:

6:45 PM Changeset in webkit [80082] by tonyg@chromium.org

1 edit
4 adds in trunk/LayoutTests

2011-03-01 Tony Gentilcore <tonyg@chromium.org>

Unreviewed new baselines

[chromium] Add expectations for new tests in r80049
https://bugs.webkit.org/show_bug.cgi?id=55543

platform/chromium-mac/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
platform/chromium-mac/svg/css/path-gradient-stroke-shadow-expected.png: Added.
platform/chromium-win/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
platform/chromium-win/svg/css/path-gradient-stroke-shadow-expected.png: Added.

6:35 PM Changeset in webkit [80081] by enne@google.com

8 edits
1 copy
3 adds in trunk/Source/WebCore

2011-02-25 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Abstract "pixels with a graphics context" into its own class
https://bugs.webkit.org/show_bug.cgi?id=55259

This creates new PlatformCanvas/PlatformImage classes which wrap
all of the #ifdef Skia/Cg warts from the compositor. All classes
(LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
modified to use these abstractions.

Tests: LayoutTests/compositing

WebCore.gypi:
platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::resizeUploadBuffer): (WebCore::ContentLayerChromium::updateTextureIfNeeded): (WebCore::ContentLayerChromium::updateTexture): (WebCore::ContentLayerChromium::draw):
platform/graphics/chromium/ContentLayerChromium.h:
platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty): (WebCore::ImageLayerChromium::updateTextureIfNeeded):
platform/graphics/chromium/ImageLayerChromium.h:
platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::updateFromPixels):
platform/graphics/chromium/LayerTilerChromium.h:
platform/graphics/chromium/PlatformCanvas.cpp: Added. (WebCore::PlatformCanvas::PlatformCanvas): (WebCore::PlatformCanvas::~PlatformCanvas): (WebCore::PlatformCanvas::resize): (WebCore::PlatformCanvas::AutoLocker::AutoLocker): (WebCore::PlatformCanvas::AutoLocker::~AutoLocker): (WebCore::PlatformCanvas::Painter::Painter): (WebCore::PlatformCanvas::Painter::~Painter):
platform/graphics/chromium/PlatformCanvas.h: Added. (WebCore::PlatformCanvas::AutoLocker::pixels): (WebCore::PlatformCanvas::Painter::context): (WebCore::PlatformCanvas::size):
platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp. (WebCore::PlatformImage::PlatformImage): (WebCore::PlatformImage::updateFromImage):
platform/graphics/chromium/PlatformImage.h: Added. (WebCore::PlatformImage::pixels): (WebCore::PlatformImage::size):

6:24 PM Changeset in webkit [80080] by mrowe@apple.com

11 edits in trunk

Source/WebKit2: Add verification scripts to WebKit2 project and fix the issues they reveal.

Reviewed by Sam Weinig.

Configurations/Base.xcconfig: Add linker flags to prevent C++ standard

library functions from being exported as weak externals.

Configurations/WebKit2.xcconfig: Inherit linker flags from the project level.
Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::separatorItem): Use DEFINE_STATIC_LOCAL.

UIProcess/WebPageGroup.cpp:

(WebKit::webPageGroupMap): Ditto.

WebKit2.xcodeproj/project.pbxproj: Don't copy .in files in to the framework.

Run verification scripts at the appropriate times.

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::didBeginEditing): Use DEFINE_STATIC_LOCAL.
(WebKit::WebEditorClient::respondToChangedContents): Ditto.
(WebKit::WebEditorClient::respondToChangedSelection): Ditto.
(WebKit::WebEditorClient::didEndEditing): Ditto.

WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::idToHistoryItemMap): Ditto.
(WebKit::historyItemToIDMap): Ditto.

Tools: Update verification scripts to handle WebKit2.

Reviewed by Sam Weinig.

Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for

WebKit2.

6:15 PM Changeset in webkit [80079] by dcheng@chromium.org

17 edits in trunk

2011-03-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsWinCE.cmake:
Source/cmakeconfig.h.cmake:

2011-03-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

wtf/Platform.h:

2011-03-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
features.pri:

2011-03-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

features.gypi:

2011-03-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

Scripts/build-webkit:

2011-03-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

6:10 PM Changeset in webkit [80078] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2011-03-01 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations

[chromium] Skip new viewport tests added by r80068
https://bugs.webkit.org/show_bug.cgi?id=55539

LayoutTestController doesn't implement dumpConfigurationForViewport() which is needed for this test.

platform/chromium/test_expectations.txt:

6:04 PM Changeset in webkit [80077] by Joseph Pecoraro

14 edits
7 deletes in trunk

2011-03-01 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.

6:02 PM Changeset in webkit [80076] by jorlow@chromium.org

9 edits in trunk

2011-03-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by James Robinson.

IDBKeyRange.bound() should not use the optional options object
https://bugs.webkit.org/show_bug.cgi?id=55419

storage/indexeddb/index-cursor.html:
storage/indexeddb/keyrange-expected.txt:
storage/indexeddb/keyrange.html:
storage/indexeddb/objectstore-cursor.html:

2011-03-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by James Robinson.

IDBKeyRange.bound() should not use the optional options object
https://bugs.webkit.org/show_bug.cgi?id=55419

http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#range-concept

Added some code to existing tests to cover these cases.

storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::bound):
storage/IDBKeyRange.h:
storage/IDBKeyRange.idl:

5:46 PM Changeset in webkit [80075] by mitz@apple.com

2 edits in trunk/Source/WebCore

Build fix.

dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):

5:39 PM Changeset in webkit [80074] by tkent@chromium.org

2 edits in trunk/Source/WebCore

2011-03-01 Kent Tamura <tkent@chromium.org>

Unreviewed. Apply sort-Xcode-project-file.

WebCore.xcodeproj/project.pbxproj:

5:30 PM Changeset in webkit [80073] by Joseph Pecoraro

2 edits in trunk/Source/WebKit2

2011-03-01 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed, missed updating a call to WebCore::computeViewportAttributes
who's prototype changed.

Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707

UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportAttributesForSize): pass in a value for the document argument.

5:23 PM Changeset in webkit [80072] by jorlow@chromium.org

12 edits
3 copies
10 adds in trunk/Source/WebCore

2011-03-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by James Robinson.

V8 code generator doesn't properly support a single SerializedScriptValue attribute
https://bugs.webkit.org/show_bug.cgi?id=55530

This is tested by the bindings tests changes.

bindings/scripts/CodeGeneratorV8.pm:
bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp: Added. (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterfacePrivate::WebDOMTestSerializedScriptValueInterfacePrivate): (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterface): (WebDOMTestSerializedScriptValueInterface::operator=): (WebDOMTestSerializedScriptValueInterface::impl): (WebDOMTestSerializedScriptValueInterface::~WebDOMTestSerializedScriptValueInterface): (WebDOMTestSerializedScriptValueInterface::value): (toWebCore): (toWebKit):
bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h: Added.
bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: Added. (WebKit::kit): (webkit_dom_test_serialized_script_value_interface_get_value): (WebKit::core): (webkit_dom_test_serialized_script_value_interface_finalize): (webkit_dom_test_serialized_script_value_interface_set_property): (webkit_dom_test_serialized_script_value_interface_get_property): (webkit_dom_test_serialized_script_value_interface_constructed): (webkit_dom_test_serialized_script_value_interface_class_init): (webkit_dom_test_serialized_script_value_interface_init): (WebKit::wrapTestSerializedScriptValueInterface):
bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: Added.
bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h: Added.
bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor): (WebCore::JSTestInterface::JSTestInterface):
bindings/scripts/test/JS/JSTestInterface.h:
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor): (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener): (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjConstructor::JSTestObjConstructor): (WebCore::JSTestObj::JSTestObj): (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows): (WebCore::jsTestObjPrototypeFunctionSerializedValue): (WebCore::jsTestObjPrototypeFunctionIdbKey): (WebCore::jsTestObjPrototypeFunctionOptionsObject): (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Added. (WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure): (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor): (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot): (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor): (WebCore::JSTestSerializedScriptValueInterfacePrototype::self): (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface): (WebCore::JSTestSerializedScriptValueInterface::createPrototype): (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot): (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor): (WebCore::jsTestSerializedScriptValueInterfaceValue): (WebCore::jsTestSerializedScriptValueInterfaceConstructor): (WebCore::JSTestSerializedScriptValueInterface::getConstructor): (WebCore::toJS): (WebCore::toTestSerializedScriptValueInterface):
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Copied from Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h. (WebCore::JSTestSerializedScriptValueInterface::createStructure): (WebCore::JSTestSerializedScriptValueInterface::impl): (WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure): (WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: Added.
bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: Added. (-[DOMTestSerializedScriptValueInterface dealloc]): (-[DOMTestSerializedScriptValueInterface finalize]): (-[DOMTestSerializedScriptValueInterface value]): (core): (kit):
bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h: Added.
bindings/scripts/test/TestSerializedScriptValueInterface.idl: Added.
bindings/scripts/test/V8/V8TestInterface.cpp: (WebCore::ConfigureV8TestInterfaceTemplate):
bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Copied from Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp. (WebCore::TestSerializedScriptValueInterfaceInternal::V8_USE): (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate): (WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate): (WebCore::V8TestSerializedScriptValueInterface::GetTemplate): (WebCore::V8TestSerializedScriptValueInterface::HasInstance): (WebCore::V8TestSerializedScriptValueInterface::wrapSlow): (WebCore::V8TestSerializedScriptValueInterface::derefObject):
bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Added. (WebCore::V8TestSerializedScriptValueInterface::toNative): (WebCore::V8TestSerializedScriptValueInterface::wrap): (WebCore::toV8):

5:23 PM Changeset in webkit [80071] by tonyg@chromium.org

1 edit
5 adds in trunk/LayoutTests

2011-03-01 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update

[chromium] Expectations updates from r80061
https://bugs.webkit.org/show_bug.cgi?id=55533

platform/chromium-linux/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Added.
platform/chromium-linux/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
platform/chromium-linux/http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.

5:23 PM Changeset in webkit [80070] by oliver@apple.com

4 edits in trunk/Source

2011-03-01 Oliver Hunt <oliver@apple.com>

Reviewed by Joseph Pecoraro.

Misaligned memory access in CloneDeserializer on all ARM arch.
https://bugs.webkit.org/show_bug.cgi?id=48742

Add a CPU class for architectures that need aligned addresses
for memory access.

wtf/Platform.h:

2011-03-01 Oliver Hunt <oliver@apple.com>

Reviewed by Joseph Pecoraro.

Misaligned memory access in CloneDeserializer on all ARM arch.
https://bugs.webkit.org/show_bug.cgi?id=48742

Push platforms that need aligned memory access down the
endian independent serialization and deserialization
paths.

bindings/js/SerializedScriptValue.cpp:

5:16 PM Changeset in webkit [80069] by helder@sencha.com

2 edits in trunk/LayoutTests

2011-03-01 Helder Correia <helder@sencha.com>

Unreviewed Qt skipped tests update.

The manually committed patch didn't include the update to
fast/canvas/canvas-strokePath-gradient-shadow.html by mistake:
No shadow when stroking a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=55436

platform/qt/Skipped: Skip new test since it fails.

4:59 PM Changeset in webkit [80068] by Joseph Pecoraro

12 edits
7 adds in trunk

2011-03-01 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707

Added tests specifically to test Console warnings.

fast/viewport/viewport-warnings-1.html: Added.
fast/viewport/viewport-warnings-2.html: Added.
fast/viewport/viewport-warnings-3.html: Added.
fast/viewport/viewport-warnings-4.html: Added.
fast/viewport/viewport-warnings-5.html: Added.
fast/viewport/viewport-warnings-6.html: Added.
fast/viewport/viewport-warnings-7.html: Added.

2011-03-01 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707

Correct and improve the error messages for viewport
parsing. Clarify the difference between incorrect
keys, values, and when to use the device-width or
device-height constants.

dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes): suggest using keywords if fixed input matches device width or height. (WebCore::numericPrefix): (WebCore::findSizeValue): remove incorrect warnings about fixed numbers because we don't know the device width or height. (WebCore::setViewportFeature): report a warning for an unrecognized key. (WebCore::viewportErrorMessageTemplate): added template for unrecognized key. (WebCore::viewportErrorMessageLevel):
dom/ViewportArguments.h:

4:56 PM Changeset in webkit [80067] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-03-01 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WKPluginSiteDataManagerClearAllSiteData is not working
https://bugs.webkit.org/show_bug.cgi?id=55528
<rdar://problem/9071823>

Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::tryGetSitesWithData): Remove version checks, checking that the function pointer is not null is enough.

(WebKit::NetscapePluginModule::tryClearSiteData):
Remove version checks, checking that the function pointer is not null is enough.
Also, correctly convert a null String to a null CString.

4:50 PM Changeset in webkit [80066] by tonyg@chromium.org

1 edit
2 adds in trunk/LayoutTests

2011-03-01 Tony Gentilcore <tonyg@chromium.org>

Unreviewed baseline

[chromium] Add baseline for test added by r80040
https://bugs.webkit.org/show_bug.cgi?id=55529

platform/chromium-mac/fast/table/table-and-parts-outline-expected.checksum: Added.
platform/chromium-mac/fast/table/table-and-parts-outline-expected.png: Added.

4:47 PM Changeset in webkit [80065] by abarth@webkit.org

4 edits in trunk/Source

2011-03-01 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add pre- and post-build actions for JavaScriptCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55507

After this patch, we have all the steps for building the main
JavaScriptCore framework except the "copy headers" step, which I'll do
next.

gyp/JavaScriptCore.gyp:

2011-03-01 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add pre- and post-build actions for JavaScriptCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55507

Remove the portion of this file that was split out into common.gypi.

gyp/JavaScriptGlue.gyp:

4:45 PM Changeset in webkit [80064] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2011-03-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix a bug in platform/mac/editing/input/selection-change-closes-typing.html
https://bugs.webkit.org/show_bug.cgi?id=55523

The marked text is at offset 0 with length 1, not at offset 1 with length 0.

platform/mac/editing/input/selection-change-closes-typing.html:

4:34 PM Changeset in webkit [80063] by tonyg@chromium.org

2 edits
2 adds in trunk/LayoutTests

2011-03-01 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations

[chromium] Add expectations for new tests in r80049
https://bugs.webkit.org/show_bug.cgi?id=55526

platform/chromium-linux/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
platform/chromium-linux/svg/css/path-gradient-stroke-shadow-expected.png: Added.
platform/chromium/test_expectations.txt:

4:28 PM Changeset in webkit [80062] by Joseph Pecoraro

1 edit
1 add in trunk/LayoutTests

2011-03-01 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705

Adding expected results generated from the build-bot. They look
correct, as the viewport "123x135" has the expected width of "123".

fast/viewport/viewport-129-expected.txt: Added.

4:21 PM Changeset in webkit [80061] by Joseph Pecoraro

24 edits in trunk

2011-02-23 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

LayoutTests:

2011-02-23 Joseph Pecoraro <Joseph Pecoraro>

All Console Messages should be passed to ChromeClients.
https://bugs.webkit.org/show_bug.cgi?id=54926

Passing more message types to the ChromeClient allows
some more messages to get output during tests. Specifically
HTML, XML, and Other message types.

inspector/audits/audits-panel-functional.html: correct a legitimate HTML parse error.
http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt:
http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt:
http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt:
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
http/tests/security/xss-DENIED-xsl-document-expected.txt:
http/tests/security/xss-DENIED-xsl-external-entity-expected.txt:
platform/mac/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt:
platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
platform/mac/http/tests/inspector/console-websocket-error-expected.txt:

Source/WebCore:

2011-02-23 Joseph Pecoraro <Joseph Pecoraro>

All Console Messages should be passed to ChromeClients.
https://bugs.webkit.org/show_bug.cgi?id=54926

Do not filter the message type here, allow clients
to filter and deal with the different message types.

page/Console.cpp: (WebCore::Console::addMessage):

Source/WebKit/mac:

2011-02-23 Joseph Pecoraro <Joseph Pecoraro>

All Console Messages should be passed to ChromeClients.
https://bugs.webkit.org/show_bug.cgi?id=54926

Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
which supersedes -webView:addMessageToConsole if it exists. The new delegate
does not filter to only JavaScript originated console messages. The old
delegate is left around for clients that expect filtered messages, like
DashCode and older versions of Safari.

The dictionary message passed to the delegate now includes more information
about the message source, type, and level.

WebCoreSupport/WebChromeClient.mm: (stringForMessageSource): (stringForMessageType): (stringForMessageLevel): (WebChromeClient::addMessageToConsole):
WebView/WebUIDelegatePrivate.h:

Tools:

2011-02-23 Joseph Pecoraro <Joseph Pecoraro>

All Console Messages should be passed to ChromeClients.
https://bugs.webkit.org/show_bug.cgi?id=54926

Update DumpRenderTree's UIDelegate to use the new console message delegate.

DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:withSource:]):

4:14 PM Changeset in webkit [80060] by rniwa@webkit.org

8 edits
2 adds in trunk

2011-03-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

WebKit does not merge text decorations in the typing style and the selected element properly
https://bugs.webkit.org/show_bug.cgi?id=55349

Added a test to ensure WebKit merges text decorations in the typing style and the inline style
of the element around the caret when computing the style at the selection start.

editing/execCommand/merge-text-decoration-with-typing-style-expected.txt: Added.
editing/execCommand/merge-text-decoration-with-typing-style.html: Added.
editing/style/push-down-inline-styles-expected.txt: Rebaselined due to the change in which text decoration values appear.
editing/style/script-tests/push-down-inline-styles.js: Ditto.

2011-03-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

WebKit does not merge text decorations in the typing style and the selected element properly
https://bugs.webkit.org/show_bug.cgi?id=55349

The bug was caused by EditingStyle::mergeTypingStyle's not properly merging text decoration property.
Fixed the bug by extracting a function from ApplyStyleCommand::pushDownInlineStyleAroundNode and
calling it in pushDownInlineStyleAroundNode and in mergeTypingStyle.

Test: editing/execCommand/merge-text-decoration-with-typing-style.html

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Takes EditingStyle*; calls mergeInlineStyleOfElement. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls applyInlineStyleToPushDown. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
editing/ApplyStyleCommand.h:
editing/EditingStyle.cpp: (WebCore::EditingStyle::mergeTypingStyle): Added; calls mergeStyle. (WebCore::EditingStyle::mergeInlineStyleOfElement): Ditto. (WebCore::EditingStyle::mergeStyle): Extracted from applyInlineStyleToPushDown.
editing/EditingStyle.h:

4:06 PM Changeset in webkit [80059] by leviw@chromium.org

27 edits in trunk/Source

2011-03-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919

Changing usage of legacy VisiblePosition constructor. Since we were dealing
with positions from DOM Ranges, we're guaranteed a parent-anchored position.

WebView/WebFrame.mm: (-[WebFrame _caretRectAtPosition:affinity:]):
WebView/WebFrameInternal.h:
WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):

2011-03-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919

Changing VisiblePosition completely away from legacy positions.

No new tests since this is functionaly equivalent.

WebCore.exp.in: Removing the legacy VisiblePosition constructor and adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions outside of WebCore, they should be parent anchored.
accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
accessibility/AccessibilityObject.cpp: (WebCore::startOfStyleRange): (WebCore::endOfStyleRange):
accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
dom/Position.cpp: (WebCore::Position::document): Added this inline function to avoid the necessity of calling anchorNode to assure a document from a Position. (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor (WebCore::Position::downstream): ditto
dom/Range.cpp: (WebCore::Range::editingStartPosition):
editing/Editor.cpp: (WebCore::Editor::canDeleteRange):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectedRange):
editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::canonicalPosition): (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::localCaretRect): (WebCore::makeRange): (WebCore::startVisiblePosition): (WebCore::endVisiblePosition): (WebCore::setStart): (WebCore::setEnd): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
editing/VisiblePosition.h: (WebCore::VisiblePosition::VisiblePosition):
editing/htmlediting.cpp: (WebCore::firstInSpecialElement): (WebCore::lastInSpecialElement): (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::endOfBlock): (WebCore::startOfDocument): (WebCore::endOfDocument): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend):
page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex):
svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):

4:04 PM Changeset in webkit [80058] by tonyg@chromium.org

1 edit
2 adds in trunk/LayoutTests

2011-03-01 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update

[chromium] Rebaseline fast/ruby/base-shorter-than-text.html
https://bugs.webkit.org/show_bug.cgi?id=55522

This changed as a result of r80015.

platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.checksum: Added.
platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png: Added.

3:57 PM Changeset in webkit [80057] by dpranke@chromium.org

2 edits in trunk/Tools

2011-03-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Tragically, we stopped running the python unit tests
on Chromium Win just as I was getting them to be green.
This patch turns them back on.

https://bugs.webkit.org/show_bug.cgi?id=55521

BuildSlaveSupport/build.webkit.org-config/master.cfg:

3:57 PM Changeset in webkit [80056] by jorlow@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-03-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by James Robinson.

Add a primaryKey method to IDBCursor
https://bugs.webkit.org/show_bug.cgi?id=55518

In prep for https://bugs.webkit.org/show_bug.cgi?id=55443

public/WebIDBCursor.h: (WebKit::WebIDBCursor::primaryKey):

3:55 PM Changeset in webkit [80055] by jorlow@chromium.org

14 edits
2 adds in trunk

2011-03-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
https://bugs.webkit.org/show_bug.cgi?id=54785

storage/indexeddb/transaction-abort.html: Added
storage/indexeddb/transaction-abort-expected.txt: Added

2011-03-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
https://bugs.webkit.org/show_bug.cgi?id=54785

This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
the right thing and continue to do the right thing. It also modifies EventQueue
so that we can cancel an event. To do this efficiently, the vector is now a
ListHashSet.

Cancelling the event is harder/messier, but the most deterministic thing to do.
To the user, the work isn't done until we fire the onsuccess/onerror handler.
So the event (which does fire that) needs to be cancelable.

transaction-abort.html tests this.

dom/EventQueue.cpp: (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::cancelEvent): (WebCore::EventQueue::pendingEventTimerFired): (WebCore::EventQueue::dispatchEvent):
dom/EventQueue.h:
dom/ExceptionCode.cpp:
storage/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::deleteFunction):
storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::close):
storage/IDBDatabaseException.h:
storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::clear): (WebCore::IDBObjectStore::openCursor):
storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::markEarlyDeath): (WebCore::IDBRequest::source): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent):
storage/IDBRequest.h:
storage/IDBTransaction.cpp: (WebCore::IDBTransaction::registerRequest): (WebCore::IDBTransaction::unregisterRequest): (WebCore::IDBTransaction::onAbort):
storage/IDBTransaction.h:

3:54 PM Changeset in webkit [80054] by jorlow@chromium.org

4 edits in trunk/Source/WebCore

2011-03-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Mihai Parparita.

EventQueue needs to be ref counted
https://bugs.webkit.org/show_bug.cgi?id=55512

EventQueue needs to be ref counted because it's possible for its instance
to be deleted while it's dispatching events. This is the reason why
https://bugs.webkit.org/show_bug.cgi?id=54785 had to be reverted.

No change of behavior, so no tests.

dom/Document.h:
dom/EventQueue.cpp: (WebCore::EventQueue::create):
dom/EventQueue.h:

3:45 PM Changeset in webkit [80053] by Adam Roben

2 edits in trunk/Source/WebKit2

Incorporate a review comment I missed in r80051

Shared/Plugins/Netscape/NetscapePluginModule.cpp: Clarified error message.

3:36 PM Changeset in webkit [80052] by ggaren@apple.com

10 edits in trunk/Source/JavaScriptCore

2011-03-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Rolled back in r79627 now that the underlying cause for it crashing is fixed.
https://bugs.webkit.org/show_bug.cgi?id=55159

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/Heap.cpp: (JSC::Heap::allocateSlowCase):
runtime/Heap.h:
runtime/JSCell.h: (JSC::JSCell::MarkedSpace::sizeClassFor): (JSC::JSCell::Heap::allocate): (JSC::JSCell::JSCell::operator new):
runtime/MarkedBlock.h:
runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::reset):
runtime/MarkedSpace.h: (JSC::MarkedSpace::SizeClass::SizeClass):

3:36 PM Changeset in webkit [80051] by Adam Roben

4 edits in trunk/Source/WebKit2

Make the PLUGIN_ARCHITECTURE() macro work with MSVC

Fixes <http://webkit.org/b/55513> <rdar://problem/9069189> REGRESSION (r79925): Lots of
plugins tests crashing in NetscapePlugin::initialize on Windows

Reviewed by Anders Carlsson.

Shared/Plugins/Netscape/NetscapePluginModule.cpp: Added a compile-time check to make sure

PLUGIN_ARCHITECTURE() is defined for some platform.

config.h: Removed the parentheses from the use of "defined" in the PLUGIN_ARCHITECTURE()

macro. This matches PLATFORM(), OS(), etc., and makes the macro work on Windows. Also
replaced the nonsense OS(WIN) with OS(WINDOWS).

win/WebKit2.vcproj: Added config.h for editing convenience. Let VS do its thang.

3:27 PM Changeset in webkit [80050] by tonyg@chromium.org

1 edit
3 adds in trunk/LayoutTests

2011-03-01 Tony Gentilcore <tonyg@chromium.org>

Unreviewed new baseline

[chromium] Add win baseline for fast/table/table-and-parts-outline.html
https://bugs.webkit.org/show_bug.cgi?id=55517

Test was added by r80040

platform/chromium-win/fast/table/table-and-parts-outline-expected.checksum: Added.
platform/chromium-win/fast/table/table-and-parts-outline-expected.png: Added.
platform/chromium-win/fast/table/table-and-parts-outline-expected.txt: Added.

3:24 PM Changeset in webkit [80049] by helder@sencha.com

3 edits
7 adds in trunk

2011-03-01 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

No shadow when stroking a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=55436

This happens in CG and is related to bug 52509, this time to be fixed
in GraphicsContext::strokePath(). The gradient needs to be drawn
clipped to the stroke on a CGLayer first, then the layer drawn on the
GraphicsContext.

fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
fast/canvas/canvas-strokePath-gradient-shadow.html: Added.
fast/canvas/script-tests/canvas-strokePath-gradient-shadow.js: Added.
platform/chromium/test_expectations.txt: Skip new test since it fails.
platform/mac/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
platform/mac/svg/css/path-gradient-stroke-shadow-expected.png: Added.
platform/mac/svg/css/path-gradient-stroke-shadow-expected.txt: Added.
platform/qt/Skipped: Skip new test since it fails.
platform/qt/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
platform/qt/svg/css/path-gradient-stroke-shadow-expected.png: Added.
platform/qt/svg/css/path-gradient-stroke-shadow-expected.txt: Added.
svg/css/path-gradient-stroke-shadow.svg: Added.

2011-03-01 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

No shadow when stroking a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=55436

This happens in CG and is related to bug 52509, this time to be fixed
in GraphicsContext::strokePath(). The gradient needs to be drawn
clipped to the stroke on a CGLayer first, then the layer drawn on the
GraphicsContext.

Tests: fast/canvas/canvas-strokePath-gradient-shadow.html

svg/css/path-gradient-stroke-shadow.svg

platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::strokePath):

3:19 PM Changeset in webkit [80048] by dpranke@chromium.org

2 edits in trunk/Tools

2011-03-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Roben.

Disable
webkitpy.common.system.executive_unittest.ExecutiveTest.\

test_kill_all fails on win until it can be properly triaged.

https://bugs.webkit.org/show_bug.cgi?id=54790

Scripts/webkitpy/common/system/executive_unittest.py:

2011-03-01 Helder Correia <helder@sencha.com>

Unreviewed. Add myself to committers.py.

Scripts/webkitpy/common/config/committers.py:

3:13 PM Changeset in webkit [80047] by hyatt@apple.com

2 edits in trunk/Source/WebCore

Fix Font::spaceWidth() to be a float instead of an int.

Reviewed by Dan Bernstein.

platform/graphics/Font.h:

(WebCore::Font::spaceWidth):

3:01 PM Changeset in webkit [80046] by helder@sencha.com

2 edits in trunk/Tools

2011-03-01 Helder Correia <helder@sencha.com>

Unreviewed. Add myself to committers.py.

Scripts/webkitpy/common/config/committers.py:

2:56 PM Changeset in webkit [80045] by steveblock@google.com

3 edits in trunk/Source/WebCore

2011-02-28 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Chromium gypi file should include Java bridge files from WebCore/bridge
https://bugs.webkit.org/show_bug.cgi?id=55387

No new tests, no code changes.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:

2:55 PM Changeset in webkit [80044] by tonyg@chromium.org

1 edit
3 adds in trunk/LayoutTests

2011-03-01 Tony Gentilcore <tonyg@chromium.org>

Unreviewed new baseline

[chromium] Add linux baseline for fast/table/table-and-parts-outline.html
https://bugs.webkit.org/show_bug.cgi?id=55511

Test was added by r80040

platform/chromium-linux/fast/table/table-and-parts-outline-expected.checksum: Added.
platform/chromium-linux/fast/table/table-and-parts-outline-expected.png: Added.
platform/chromium-linux/fast/table/table-and-parts-outline-expected.txt: Added.

2:47 PM TriagingTestFailures edited by Adam Roben

Show only open bugs with the MakingBotsRed keyword (diff)

2:45 PM TriagingTestFailures edited by Adam Roben

Put the more useful numbuilds=N suggestion first (diff)

2:34 PM Changeset in webkit [80043] by simonjam@chromium.org

4 edits in trunk

2011-03-01 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[Web Timing] Handle the case where no responseEnd time is available.
https://bugs.webkit.org/show_bug.cgi?id=55444

platform/chromium/test_expectations.txt: Remove CRASH from fast/dom/prototype-inheritance-2.html

2011-03-01 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[Web Timing] Handle the case where no responseEnd time is available.
https://bugs.webkit.org/show_bug.cgi?id=55444

loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): Initialize to 0. (WebCore::MainResourceLoader::didFinishLoading): Fall back to current time if no other time is available.

2:31 PM Changeset in webkit [80042] by Patrick Gansterer

2 edits in trunk/Source/WebCore

2011-03-01 Patrick Gansterer <Patrick Gansterer>

Unreviewed, adding missing change for r80034.

Add a handler class for Win32 HANDLE
https://bugs.webkit.org/show_bug.cgi?id=55334

platform/win/Win32Handle.h: Added missing WTF_MAKE_NONCOPYABLE macro.

2:23 PM TriagingTestFailures edited by Adam Roben

Moved the expected failure policy discussion link to a more … (diff)

2:22 PM Changeset in webkit [80041] by tonyg@chromium.org

25 edits
16 deletes in trunk

2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80037.
http://trac.webkit.org/changeset/80037
https://bugs.webkit.org/show_bug.cgi?id=55508

broke compile on SL (Requested by tonyg-cr on #webkit).

fast/css/content/content-quotes-01-expected.txt: Removed.
fast/css/content/content-quotes-01.html: Removed.
fast/css/content/content-quotes-02-expected.txt: Removed.
fast/css/content/content-quotes-02.html: Removed.
fast/css/content/content-quotes-03-expected.txt: Removed.
fast/css/content/content-quotes-03.html: Removed.
fast/css/content/content-quotes-04-expected.txt: Removed.
fast/css/content/content-quotes-04.html: Removed.
fast/css/content/content-quotes-05-expected.txt: Removed.
fast/css/content/content-quotes-05.html: Removed.
fast/css/content/content-quotes-06-expected.txt: Removed.
fast/css/content/content-quotes-06.html: Removed.

2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80037.
http://trac.webkit.org/changeset/80037
https://bugs.webkit.org/show_bug.cgi?id=55508

broke compile on SL (Requested by tonyg-cr on #webkit).

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
css/CSSParser.h:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
css/html.css: (q:before): (q:after):
rendering/RenderBlockLineLayout.cpp: (WebCore::dirtyLineBoxesForRenderer):
rendering/RenderObject.h:
rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode): (WebCore::RenderObjectChildList::updateBeforeAfterContent):
rendering/RenderQuote.cpp: Removed.
rendering/RenderQuote.h: Removed.
rendering/RenderingAllInOne.cpp:
rendering/style/ContentData.cpp: (WebCore::ContentData::dataEquivalent): (WebCore::ContentData::deleteContent):
rendering/style/ContentData.h:
rendering/style/QuotesData.cpp: Removed.
rendering/style/QuotesData.h: Removed.
rendering/style/RenderStyle.cpp:
rendering/style/RenderStyle.h:
rendering/style/RenderStyleConstants.h:
rendering/style/StyleAllInOne.cpp:
rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::operator==):
rendering/style/StyleRareInheritedData.h:

2:18 PM Changeset in webkit [80040] by inferno@chromium.org

3 edits
4 adds in trunk

2011-03-01 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Paint outline for tables.
https://bugs.webkit.org/show_bug.cgi?id=55474

Test: fast/table/table-and-parts-outline.html

rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject):

2011-03-01 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we draw outlines for table and table cells.
https://bugs.webkit.org/show_bug.cgi?id=55474

fast/table/table-and-parts-outline.html: Added.
platform/mac/fast/table/table-and-parts-outline-expected.checksum: Added.
platform/mac/fast/table/table-and-parts-outline-expected.png: Added.
platform/mac/fast/table/table-and-parts-outline-expected.txt: Added.

2:07 PM Changeset in webkit [80039] by mrowe@apple.com

2 edits in trunk/Source/JavaScriptCore

Replace two script phases that do nothing but copy files with copy files build phases.

Reviewed by Sam Weinig.

This speeds up the build by a few seconds on high-end Mac Pros.

JavaScriptCore.xcodeproj/project.pbxproj:

2:05 PM Changeset in webkit [80038] by tonyg@chromium.org

14 edits
2 deletes in trunk

2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80028.
http://trac.webkit.org/changeset/80028
https://bugs.webkit.org/show_bug.cgi?id=55502

'caused crashes; rolling out while investigating' (Requested
by jorlow on #webkit).

storage/indexeddb/transaction-abort-expected.txt: Removed.
storage/indexeddb/transaction-abort.html: Removed.

2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80028.
http://trac.webkit.org/changeset/80028
https://bugs.webkit.org/show_bug.cgi?id=55502

'caused crashes; rolling out while investigating' (Requested
by jorlow on #webkit).

dom/EventQueue.cpp: (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired): (WebCore::EventQueue::dispatchEvent):
dom/EventQueue.h:
dom/ExceptionCode.cpp:
storage/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::deleteFunction):
storage/IDBDatabaseException.h:
storage/IDBDatabaseException.idl:
storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::clear): (WebCore::IDBObjectStore::openCursor):
storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent): (WebCore::IDBRequest::source):
storage/IDBRequest.h:
storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort):
storage/IDBTransaction.h:

2:01 PM Changeset in webkit [80037] by carol.szabo@nokia.com

27 edits
16 adds in trunk

content property doesn't support quotes
https://bugs.webkit.org/show_bug.cgi?id=6503

Reviewed by David Hyatt <hyatt@apple.com>

Source/WebCore:

Added full support for quotes as defined by CSS 2.1.

Tests: fast/css/content/content-quotes-01.html

fast/css/content/content-quotes-02.html
fast/css/content/content-quotes-03.html
fast/css/content/content-quotes-04.html
fast/css/content/content-quotes-05.html

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseQuotes):

css/CSSParser.h:

Added needed stylesheet parsing support for quotes,
(no-)open-quote and (no-)close-quote

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Handled setting of the new quotes RenderStyle property and added
handling of quotes for the content property.

css/html.css:

(q:before):
(q:after):
replaced the '"' workaround with open/close-quote

rendering/RenderBlockLineLayout.cpp:

(WebCore::dirtyLineBoxesForRenderer):
Made RenderQuote behave like RenderCounter.
Needed to ensure that the Quote text is calculated before layout,
just as it is for RenderCounter.

rendering/RenderObject.h:

(WebCore::RenderObject::isQuote):

rendering/RenderObjectChildList.cpp:

rendering/RenderQuote.cpp: Added.

(WebCore::adjustDepth):
(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::renderName):
(WebCore::RenderQuote::placeQuote):
(WebCore::RenderQuote::originalText):
(WebCore::RenderQuote::computePreferredLogicalWidths):
(WebCore::RenderQuote::rendererSubtreeAttached):
(WebCore::RenderQuote::rendererRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):

rendering/RenderQuote.h: Added.

(WebCore::RenderQuote::isQuote):
(WebCore::toRenderQuote):

rendering/RenderingAllInOne.cpp:

Included RenderQuote.cpp

rendering/style/StyleAllInOne.cpp:

Included QuotesData.cpp

rendering/style/ContentData.cpp:

(WebCore::ContentData::dataEquivalent):
Checked for quotetype identity.
(WebCore::ContentData::deleteContent):
Accounted for the new QUOTE_TYPE.

rendering/style/ContentData.h:

(WebCore::ContentData::isQuote):
(WebCore::ContentData::quote):
(WebCore::ContentData::setQuote):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setContent):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::quotes):
(WebCore::InheritedFlags::setQuotes):

rendering/style/RenderStyleConstants.h:
rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::operator==):
Included quotes in equality check.

rendering/style/StyleRareInheritedData.h:

Added quotes

LayoutTests:

Added new tests for quotes.

fast/css/content/content-quotes-01-expected.txt: Added.
fast/css/content/content-quotes-01.html: Added.
fast/css/content/content-quotes-02-expected.txt: Added.
fast/css/content/content-quotes-02.html: Added.
fast/css/content/content-quotes-03-expected.txt: Added.
fast/css/content/content-quotes-03.html: Added.
fast/css/content/content-quotes-04-expected.txt: Added.
fast/css/content/content-quotes-04.html: Added.
fast/css/content/content-quotes-05-expected.txt: Added.
fast/css/content/content-quotes-05.html: Added.

1:57 PM Changeset in webkit [80036] by Michael Nordman

5 edits
5 adds in trunk

2011-03-01 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

Tests for the correct relative priorities of network vs fallback namespaces in the appcache.
If a resource url is in an appcache's network namespace and fallback namespace, the network
namespace wins (with the exception of the special '*' network namespace which does not take
priority over the fallback namespace.
https://bugs.webkit.org/show_bug.cgi?id=49292

http/tests/appcache/online-fallback-layering-expected.txt: Added.
http/tests/appcache/online-fallback-layering.html: Added.
http/tests/appcache/resources/fallbacknamespace-fallback-resource.txt: Added.
http/tests/appcache/resources/fallbacknamespace-networknamespace-existing-resource.html: Added.
http/tests/appcache/resources/online-fallback-layering.manifest: Added.

2011-03-01 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

Alter the relative priorities of network vs fallback namespaces in the appcache.
If a resource url is in an appcache's network namespace and fallback namespace, the network
namespace wins (with the exception of the special '*' network namespace which does not take
priority over the fallback namespace.
https://bugs.webkit.org/show_bug.cgi?id=49292

Test: http/tests/appcache/online-fallback-layering.html

loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::isURLInOnlineWhitelist):
loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache): (WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource):
loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):

1:55 PM Changeset in webkit [80035] by jennb@chromium.org

1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed. Add myself to the list of committers.

1:38 PM Changeset in webkit [80034] by Patrick Gansterer

1 edit
1 add in trunk/Source/WebCore

2011-03-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add a handler class for Win32 HANDLE
https://bugs.webkit.org/show_bug.cgi?id=55334

This class will call CloseHandle in the destructor for valid handles.

platform/win/Win32Handle.h: Added.

1:29 PM Changeset in webkit [80033] by Adam Roben

2 edits in trunk/Tools

Give up if a crash log for the web process is taking too long to be saved on Windows

This should keep the bots from getting stuck while waiting for a crash log, if writing a
crash log ever hangs or the UI process for some reason doesn't notice it's finished.

Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
to be saved for the web process

Reviewed by Steve Falkenburg.

WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
Generalized the code slightly to handle the optional object to wait on.
(WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
it (with a timeout) when waiting for a crash log for the web process to be saved. This will
prevent us from waiting forever.

1:13 PM Changeset in webkit [80032] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2011-03-01 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update.

[chromium] fast/text/font-size-zero.html
https://bugs.webkit.org/show_bug.cgi?id=55497

Appears to have been fixed by r79694.

platform/chromium/test_expectations.txt:

1:07 PM Changeset in webkit [80031] by Joseph Pecoraro

2 edits in trunk/LayoutTests

Unreviewed, fix GTK DumpRenderTree crash.

2011-03-01 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed, fix GTK DumpRenderTree crash.

Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705

Follow-up fix. Pass the correct number of arguments
into layoutTestController.dumpConfigurationForViewport.

fast/viewport/viewport-129.html:

12:54 PM Changeset in webkit [80030] by eric.carlson@apple.com

10 edits in trunk/Source/WebCore

2011-03-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Chris Marrin.

<audio> and <video> should respect private browsing mode
https://bugs.webkit.org/show_bug.cgi?id=55287
<rdar://problem/9057699>

No new tests, this is just the plumbing.

dom/Document.cpp: (WebCore::Document::privateBrowsingStateDidChange): New. (WebCore::Document::registerForPrivateBrowsingStateChangedCallbacks): Ditto. (WebCore::Document::unregisterForPrivateBrowsingStateChangedCallbacks): Ditto.
dom/Document.h:

dom/Element.h: (WebCore::Element::privateBrowsingStateDidChange): New.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Register for privacy mode changes. (WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister for privacy mode changes. (WebCore::HTMLMediaElement::loadResource): Tell player current privacy mode. (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): New, call through to MediaPlayer.
html/HTMLMediaElement.h:

page/Page.cpp: (WebCore::Page::privateBrowsingStateChanged): Call document()->privateBrowsingStateDidChange.

platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setPrivateBrowsingMode): New, call through to media engine.
platform/graphics/MediaPlayer.h:

platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode): Declare new interface.

12:45 PM Changeset in webkit [80029] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/gtk

2011-03-01 Kamil Blank <k.blank@samsung.com>

Reviewed by Martin Robinson.

[GTK] Fixing headers order in webkit.h.
https://bugs.webkit.org/show_bug.cgi?id=55316

webkit/webkit.h: Style fix.

12:42 PM Changeset in webkit [80028] by jorlow@chromium.org

14 edits
2 adds in trunk

2011-02-18 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
https://bugs.webkit.org/show_bug.cgi?id=54785

storage/indexeddb/transaction-abort.html: Added
storage/indexeddb/transaction-abort-expected.txt: Added

2011-02-18 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
https://bugs.webkit.org/show_bug.cgi?id=54785

This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
the right thing and continue to do the right thing. It also modifies EventQueue
so that we can cancel an event. To do this efficiently, the vector is now a
ListHashSet.

Canelling the event is harder/messier, but the most deterministic thing to do.
To the user, the work isn't done until we fire the onsuccess/onerror handler.
So the event (which does fire that) needs to be cancelable.

transaction-abort.html tests this.

dom/EventQueue.cpp: (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::cancelEvent): (WebCore::EventQueue::pendingEventTimerFired): (WebCore::EventQueue::dispatchEvent):
dom/EventQueue.h:
dom/ExceptionCode.cpp:
storage/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::deleteFunction):
storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::close):
storage/IDBDatabaseException.h:
storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::clear): (WebCore::IDBObjectStore::openCursor):
storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::markEarlyDeath): (WebCore::IDBRequest::source): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent):
storage/IDBRequest.h:
storage/IDBTransaction.cpp: (WebCore::IDBTransaction::registerRequest): (WebCore::IDBTransaction::unregisterRequest): (WebCore::IDBTransaction::onAbort):
storage/IDBTransaction.h:

12:40 PM Changeset in webkit [80027] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2011-03-01 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

[chromium] Skip test added w/o expectations
https://bugs.webkit.org/show_bug.cgi?id=55496

Added by r80012 without expectations

platform/chromium/test_expectations.txt:

12:39 PM Changeset in webkit [80026] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2011-03-01 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations change. Remove failing expectations for
editing/ tests that pass after r79961.

platform/chromium/test_expectations.txt:

12:37 PM Changeset in webkit [80025] by jorlow@chromium.org

8 edits in trunk

2011-02-28 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Only IndexedDB's error event should be cancelable
https://bugs.webkit.org/show_bug.cgi?id=55413

Add checks to existing tests.

storage/indexeddb/objectstore-basics.html:
storage/indexeddb/transaction-basics.html:

2011-02-28 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Only IndexedDB's error event should be cancelable
https://bugs.webkit.org/show_bug.cgi?id=55413

storage/IDBRequest.cpp: (WebCore::createSuccessEvent):
storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):

12:34 PM Changeset in webkit [80024] by Adam Roben

2 edits in trunk/Tools

Give WebKitLauncherWin's PDB file a name different from WebKit's

WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
fighting over the same PDB file, meaning that one of them was going to lose and not have
symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.

Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
runs (due to missing symbols)

Reviewed by David Kilzer.

WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,

"WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.

12:31 PM Changeset in webkit [80023] by commit-queue@webkit.org

25 edits
2 copies
2 adds in trunk

2011-03-01 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Remove CorrectionIndicator markers sooner.
https://bugs.webkit.org/show_bug.cgi?id=54893
<rdar://problem/8997524>

See WebCore/ChangeLog for detail.

platform/mac-leopard/Skipped:
platform/mac-snowleopard/Skipped:
platform/mac-tiger/Skipped:
platform/mac-wk2/Skipped:
platform/mac/editing/spelling/autocorrection-simple-expected.checksum:
platform/mac/editing/spelling/autocorrection-simple-expected.png:
platform/mac/editing/spelling/autocorrection-simple-expected.txt:
platform/mac/editing/spelling/autocorrection-simple.html:
platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum:
platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.checksum: Added.
platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png: Added.
platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt: Copied from LayoutTests/platform/mac/editing/spelling/autocorrection-simple-expected.txt.
platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html: Copied from LayoutTests/platform/mac/editing/spelling/autocorrection-simple.html.

2011-03-01 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Remove CorrectionIndicator markers sooner.
https://bugs.webkit.org/show_bug.cgi?id=54893
<rdar://problem/8997524>

Test: platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html

This patch changes the autocorrection behavior on Mac OS X. We want to remove CorrectionIndicator
marker after any editing command if the command:

is not a SpellingCorrectionCommand itself.
is not the command that triggers the autocorrection. This is achieved by adding shouldRetainAutocorrectionIndicator() function to EditCommand. This function returns false for all commands derived from EditCommand, except SpellingCorrectionCommand and TypingCommand. This function always returns true for SpellingCorrectionCommand. For TypingCommand, the return value is determined by member variable m_shouldRetainAutocorrectionIndicator, which can be modified by passing option into the TypingCommand's public functions.

To avoid constantly searching marker list, we use variable DocumentMarkerController::m_absentMarkerTypeCache
to cache whether there is any marker of a particular type.

This patch also fixes two minor existing bugs.

We used to show reversion panel for word with CorrectionIndicator marker. This is incorrect because CorrectionIndicator marker can be removed from corrected words. Since all autocorrected words have Replacement marker unless the whole word is deleted, the correct behavior is to show reversion panel for word with Replacement marker, since all autocorrected words have such marker. However, since we don't want to show the reversion panel if an autocorrected word has been edited, we also check to see if the Replacement marker's description is null.

This works as following:
When we apply an autocorrection, we add Replacement marker to corrected word, and store original word
as the marker's description. If the user edited the corrected word afterward, we set description to null.
So when we decide whether to show a reversion panel, we not only check for the existence of Replacement
marker, but also check if description is null.

Fixed an assertion violation in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited(), which would occur when deleting the first character in an editable area.

dom/DocumentMarker.h: Added m_possiblyExistingMarkerTypes to allow quickly checking whether a marker type is

completely in from the document.

dom/DocumentMarkerController.cpp: Most of the functions listed here are optimized for early return by checking

the return value of possiblyHasMarkers() at beginning.

(WebCore::DocumentMarkerController::possiblyHasMarkers):
(WebCore::DocumentMarkerController::DocumentMarkerController):
(WebCore::DocumentMarkerController::detach):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::copyMarkers):
(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::shiftMarkers):
(WebCore::DocumentMarkerController::setMarkersActive):
(WebCore::DocumentMarkerController::hasMarkers):
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):

dom/DocumentMarkerController.h:
editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::shouldRetainAutocorrectionIndicator): (WebCore::EditCommand::setShouldRetainAutocorrectionIndicator):
editing/EditCommand.h:
editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): (WebCore::Editor::appliedEditing): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::insertLineBreak): (WebCore::Editor::insertParagraphSeparator): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited): (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
editing/Editor.h:
editing/EditorCommand.cpp: (WebCore::executeInsertLineBreak): (WebCore::executeInsertParagraph): (WebCore::executeInsertText):
editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::shouldRetainAutocorrectionIndicator):
editing/SpellingCorrectionCommand.h:
editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::deleteSelection): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): (WebCore::TypingCommand::insertParagraphSeparator):
editing/TypingCommand.h: (WebCore::TypingCommand::create): (WebCore::TypingCommand::shouldRetainAutocorrectionIndicator): (WebCore::TypingCommand::setShouldRetainAutocorrectionIndicator):
manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html:

12:15 PM Changeset in webkit [80022] by reni@webkit.org

5 edits in trunk/Source/WebCore

2011-03-01 Renata Hodovan <reni@webkit.org>

Reviewed by Andreas Kling.

FEDisplacementMapElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55454

When the FEDisplacementMapElement receives an update message but the given value remains the same we don't need
to relayout the filter.

No new tests are needed because this modification is covered by the dynamic update tests of FEDisplacementMap.

platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::setXChannelSelector): (WebCore::FEDisplacementMap::setYChannelSelector): (WebCore::FEDisplacementMap::setScale):
platform/graphics/filters/FEDisplacementMap.h:
svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute): (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
svg/SVGFEDisplacementMapElement.h:

12:10 PM Changeset in webkit [80021] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

Spring cleaning!

Rubber-stamped by Mark Rowe.

JavaScriptCore.xcodeproj/project.pbxproj:

(Copy Into Framework): Remove "set -x" and its comment.

12:03 PM Changeset in webkit [80020] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2011-03-01 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

[chromium] pass fast/table/fixed-with-auto-with-colspan-vertical.html
https://bugs.webkit.org/show_bug.cgi?id=55491

Fixed by r79760.

platform/chromium/test_expectations.txt:

12:02 PM Changeset in webkit [80019] by Adam Roben

2 edits in trunk/Tools

Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit

Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
--exit-after-n-crashes-or-timeouts limit

Reviewed by David Kilzer.

Scripts/old-run-webkit-tests:

(stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
the number of tests that caused the web process to crash when exiting early.

11:54 AM Changeset in webkit [80018] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

2011-03-01 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

TinyMCE not working in nightlies
https://bugs.webkit.org/show_bug.cgi?id=54978

Disabling setupBeginChars() to temporarily work arround the test
failure. Filed https://bugs.webkit.org/show_bug.cgi?id=55479
to track fixing the issue.

yarr/YarrPattern.cpp: (JSC::Yarr::YarrPattern::compile):

11:53 AM Changeset in webkit [80017] by commit-queue@webkit.org

4 edits
2 adds
2 deletes in trunk/LayoutTests

2011-03-01 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Create layout test for progress event and remove test for suspend event.

LayoutTests/http/tests/media/video-play-suspend is now hanging on chromium
https://bugs.webkit.org/show_bug.cgi?id=55198

http/tests/media/video-play-progress-expected.txt: Added.
http/tests/media/video-play-progress.html: Added.
http/tests/media/video-play-suspend-expected.txt: Removed.
http/tests/media/video-play-suspend.html: Removed.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/win/Skipped:

11:49 AM Changeset in webkit [80016] by Martin Robinson

1 edit
6 adds in trunk/LayoutTests

2011-03-01 Martin Robinson <mrobinson@igalia.com>

REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
https://bugs.webkit.org/show_bug.cgi?id=55323

Add new GTK+ test results.

platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
platform/gtk/fast/spatial-navigation/snav-multiple-select-focusring-expected.checksum: Added.
platform/gtk/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.

11:48 AM Changeset in webkit [80015] by mitz@apple.com

18 edits in trunk

<rdar://problem/8902714> Expand ruby text when it is shorter than the ruby base
https://bugs.webkit.org/show_bug.cgi?id=55487

Reviewed by Darin Adler.

Source/WebCore:

css/html.css:

(ruby > rt): Changed the default text-align value to -webkit-auto to signal
the default expansion behavior.

rendering/RenderBlock.h:

(WebCore::RenderRubyText::textAlignmentForLine): Made protected.
(WebCore::RenderBlock::adjustInlineDirectionLineBounds): Made protected.

rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::textAlignmentForLine): Added. If text-align is
-webkit-auto, returns JUSTIFY to allow expansion.
(WebCore::RenderRubyText::adjustInlineDirectionLineBounds): Added. If
text-align is -webkit-auto, insets the line such that the inset on each side
is the half the inter-ideograph expansion, or one ruby character wide,
whichever is smaller.

rendering/RenderRubyText.h:

LayoutTests:

platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:

11:41 AM Changeset in webkit [80014] by weinig@apple.com

13 edits
1 copy
1 move
1 add in trunk/Source

WebKit2 needs to be made localizable
https://bugs.webkit.org/show_bug.cgi?id=55483

Reviewed by Timothy Hatcher.

Source/WebCore:

English.lproj/Localizable.strings: Copied from Source/WebKit/English.lproj/Localizable.strings.
WebCore.xcodeproj/project.pbxproj:

Move Localizable.strings to WebCore.

WebCore.exp.in:

Add export for localizedString function.

platform/LocalizedStrings.h:
platform/mac/LocalizedStringsMac.mm: Added.

Add function to get localized version of a string from the WebCore bundle.

Source/WebKit:

StringsNotToBeLocalized.txt: Removed.
WebKit.xcodeproj/project.pbxproj:

Copied Localizable.strings to WebCore, it can't be removed entirely
yet since Windows is still using it.

Source/WebKit/mac:

WebCoreSupport/WebPlatformStrategies.mm:

Use WebCore's localizedString function instead of WebLocalizableStrings
since WebCore is now responsible for localization.

Source/WebKit2:

PluginProcess/mac/PluginProcessMainMac.mm:
WebProcess/mac/WebProcessMainMac.mm:

Set the default localization from the passed in parameter.

UIProcess/Launcher/mac/ProcessLauncherMac.mm:

Add the preferred localization as a parameter when launching processes
so that they can set their localization to match the launching app.

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

Use WebCore's localizedString function on the mac, to actually localize
these strings.

(WebKit::WebPlatformStrategies::imageTitle):
Switch to using replace, instead of concatenation, to give localizers a chance
to rearrange the wording.

11:34 AM TriagingTestFailures edited by Adam Roben

Added an example URL using numbuilds=N (diff)

11:26 AM Changeset in webkit [80013] by sergio@webkit.org

1 edit
44 adds in trunk/LayoutTests

2011-03-01 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Added new GTK test expectations.

platform/gtk/fast/block/positioning/auto/vertical-lr/: 7 tests.
platform/gtk/fast/block/positioning/auto/vertical-rl/: 7 tests.

11:03 AM Changeset in webkit [80012] by Joseph Pecoraro

10 edits
1 add in trunk

Viewport parsing no longer accepts "1.0;" value as valid.

Reviewed by Kenneth Rohde Christiansen.

LayoutTests:

2011-02-23 Joseph Pecoraro <Joseph Pecoraro>

Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705

Add a new test to check viewport argument parsing of
value "123x456", which although not completely a number
should return the numeric prefix "123" as the value.
Note that this affects "semicolons as separators" even
though semicolons are not valid separators.

fast/viewport/viewport-129.html: Added.

Source/JavaScriptCore:

2011-02-23 Joseph Pecoraro <Joseph Pecoraro>

Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705

Include a didReadNumber parameter to String -> float / double
conversion functions. This way, if the "ok" boolean out
parameter is false, you can check to see if there in fact
was a valid number parsed with garbage at the end. Examples
of that would be parsing "123x456" would have ok = false,
but didReadNumber = true.

JavaScriptCore.exp:
wtf/text/StringImpl.cpp: (WTF::StringImpl::toDouble): (WTF::StringImpl::toFloat):
wtf/text/StringImpl.h:
wtf/text/WTFString.cpp: (WTF::String::toDouble): (WTF::String::toFloat): (WTF::charactersToDouble): (WTF::charactersToFloat):
wtf/text/WTFString.h:

Source/WebCore:

2011-02-23 Joseph Pecoraro <Joseph Pecoraro>

Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705

When parsing numeric values, the "css-viewport" spec says
to use the number prefix, and the non numeric part of the
string can be ignored. This matches our behavior before
r67376. The change was that checking the error out condition
of String::toFloat doesn't necessarily mean that there
was a non-numeric prefix. This patch checks if there was
or wasn't a non-numeric prefix.

There is a console warning in any case where a numeric
value is not parsed cleanly. There is an error warning
when it is not a number at all, and a tip warning when
it has been truncated.

Error messages are slightly improved to provide more
context, both the key and value, when an error happens.

Test: fast/viewport/viewport-129.html

dom/ViewportArguments.cpp: (WebCore::numericPrefix): (WebCore::findSizeValue): (WebCore::findScaleValue): (WebCore::findUserScalableValue): (WebCore::findTargetDensityDPIValue): (WebCore::viewportErrorMessageTemplate): (WebCore::viewportErrorMessageLevel): (WebCore::reportViewportWarning):
dom/ViewportArguments.h:

10:45 AM Changeset in webkit [80011] by weinig@apple.com

4 edits in trunk/WebKitLibraries

WebKit2 needs to be made localizable
<rdar://problem/8728860>

Reviewed by Anders Carlsson.

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:

10:26 AM Changeset in webkit [80010] by sergio@webkit.org

2 edits in trunk/LayoutTests

2011-03-01 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Removed accessibility/canvas-fallback-content.html from Skipped
list as it was removed in 79920

platform/gtk/Skipped:

10:13 AM Changeset in webkit [80009] by Adam Roben

11 edits in trunk/Tools

Save a crash log when the web process crashes

On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
until it has finished crashing, which guarantees that the crash log will have had time to be
saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
log, so all we have to do is choose the right crash log out of the CrashReporter directory.

Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive

Reviewed by Sam Weinig.

Scripts/old-run-webkit-tests:

(testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
(captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
WebProces_*.crash files when the web process crashes.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
along to platformInitialize.

WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.

WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:

(WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.

WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:

(WTR::InjectedBundle::platformInitialize):
Updated function signature.

WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:

(WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
webProcessCrashingEvent, then lets the crash continue as normal.

(WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
event we should use to tell the UI process we're crashing from the initializationUserData,
and get a handle to that event.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController): Initialize new members.
(WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
only print the "#CRASHED - WebProcess" message once, since this can be called more than once
when a crash log is being saved on Windows. Exit right away if specified. (This is the
default.)

WebKitTestRunner/TestController.h: Added new members.

WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformInitialize): Set up the event the web process will use to tell
us it's crashing.
(WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
so the test harness will know the web process has crashed and not try to kill us, then wait
for the web process to finish crashing so a crash log will have time to be saved.
(WTR::toWK): Simple hepler function.
(WTR::TestController::platformInitializeContext): Pass along the name of the event the web
process should use to tell us it is crashing in the context's initialization user data.

10:00 AM Changeset in webkit [80008] by Dimitri Glazkov

2 edits in trunk/Tools

2011-03-01 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Tony Gentilcore.

Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
https://bugs.webkit.org/show_bug.cgi?id=55476

Chromium Win uses BuildAndTestFactory, not TestFactory.

BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.

9:47 AM Changeset in webkit [80007] by kbalazs@webkit.org

8 edits in trunk/Source/WebKit2

2011-03-01 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Anders Carlsson.

[Qt][WK2] Plugin initialization
https://bugs.webkit.org/show_bug.cgi?id=48127

Apply the quirks that are necessary for the flash plugin
to not crash on X11.

Platform/qt/ModuleQt.cpp: (WebKit::Module::load): Use the ResolveAllSymbols hint as we do in WebCore.
Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::tryLoad): Call applyX11QuirksBeforeLoad if PLUGIN_ARCHITECTURE is X11.
Shared/Plugins/Netscape/NetscapePluginModule.h:
Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp: (WebKit::initializeGTK): The same hack that we do in WebCore. Call gtk_init because flash don't do it for itself. (WebKit::NetscapePluginModule::applyX11QuirksBeforeLoad): Added for X11. Do the hacks that we need to do before calling NP_Initialize on the flash plugin to save it form crashing.
Shared/Plugins/PluginQuirks.h: Use PLUGIN_ARCHITECTURE macros. Added RequiresGTKToolKit quirk for X11.
WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Handle the RequiresGTKToolKit quirk on X11.
WebProcess/Plugins/Netscape/NetscapePlugin.h: (WebKit::NetscapePlugin::quirks): Added getter for the PluginModule's quirks to be available in NPN_GetValue.

9:41 AM Changeset in webkit [80006] by ggaren@apple.com

3 edits in trunk/Source/JavaScriptCore

2011-02-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

Past-the-end writes in VM exceptions (caused crashes in r79627)
https://bugs.webkit.org/show_bug.cgi?id=55448

Some exceptions had the wrong structures, so they misoverestimated their
inline storage sizes.

runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Use the right structure.

runtime/JSObject.h: (JSC::JSNonFinalObject::JSNonFinalObject): (JSC::JSFinalObject::JSFinalObject): ASSERT that our structure capacity is correct to verify this doesn't happen again.

9:28 AM Changeset in webkit [80005] by loislo@chromium.org

2 edits in trunk/Source/WebCore

2011-03-01 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: InjectedScript.setPropertyValue doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=55475

inspector/InjectedScript.cpp: (WebCore::InjectedScript::setPropertyValue):

9:23 AM Changeset in webkit [80004] by steveblock@google.com

4 edits in trunk/Source/WebCore

2011-03-01 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Remove unused JavaString::uchars()
https://bugs.webkit.org/show_bug.cgi?id=55465

No new tests, removing dead code only.

bridge/jni/JNIBridge.h:
bridge/jni/jsc/JavaStringJSC.h: (JSC::Bindings::JavaStringImpl::utf8):
bridge/jni/v8/JavaStringV8.h:

8:51 AM Changeset in webkit [80003] by apavlov@chromium.org

4 edits in trunk/Source/WebCore

2011-03-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Extremely slow DOM search in GMail
https://bugs.webkit.org/show_bug.cgi?id=55456

The solution comprises three major parts:

avoid multiple invocations of highlightSearchResults(), one per each nodeIds chunk.
cache highlighted node's innerHTML so that no extra _nodeTitleInfo() calls will be needed.
replace hand-written Text nodes iteration with a snapshot-based ".text()" XPathResult.

inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.highlightSearchResults): (WebInspector.ElementsTreeElement.prototype.updateTitle): ():
inspector/front-end/utilities.js: ():

7:42 AM Changeset in webkit [80002] by Adam Roben

2 edits in trunk/Source/WebCore

Fix multiple-definition linker warnings introduced by r79978 on Windows

rendering/RenderingAllInOne.cpp: Removed TextControlInnerElements.cpp, as it is now being

compiled separately.

7:29 AM Changeset in webkit [80001] by Adam Roben

9 edits
1 copy
1 add in trunk

Convert seconds to milliseconds before calling ::SetTimer

Fixes <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
early on Windows

Reviewed by Anders Carlsson.

Source/WebKit2:

Platform/win/RunLoopWin.cpp:

(RunLoop::TimerBase::start): Convert the timeout interval to milliseconds, since that's what
::SetTimer expects.

Tools:

Test that the WebKit2 responsiveness timer doesn't fire too early

TestWebKitAPI/PlatformUtilities.h: Added sleep().

TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::processDidBecomeUnresponsive):
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::setPageLoaderClient):
Simple helper functions.

(TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
tell the web process to pause and press the spacebar key. The spacebar keypress should cause
the responsiveness timer to start, but the web process should unpause before it has a chance
to fire. Run until the web process has unpaused, and assert that the timer didn't fire.

TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.

(TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
Call up to the base class.
(TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
pause, sleep for 0.5 seconds, then send back a message saying we paused.

TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::sleep): Added. Calls through to usleep.

TestWebKitAPI/win/PlatformUtilitiesWin.cpp:

(TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/win/TestWebKitAPI.vcproj:
TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:

Added new files.

7:14 AM Changeset in webkit [80000] by antonm@chromium.org

1 edit
4 adds in trunk/LayoutTests/platform

Unreviewed. Rebaselining Chromium expectations.

platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png
platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png
platform/chromium/test_expectations.txt

7:13 AM Changeset in webkit [79999] by abecsi@webkit.org

17 edits in trunk

2011-03-01 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Clean up the project files and move common options to WebKit.pri.

Mac related changes suggested by Prasanth Ullattil <prasanth.ullattil@nokia.com>

Source/WebKit.pri: Common options should be here. Also move Mac options to this file to fix the Mac build.

2011-03-01 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Clean up the project files and move common options to WebKit.pri.

JavaScriptCore.pri: Move options also needed in WebCore into WebKit.pri.
JavaScriptCore.pro: Deduplicate options.
jsc.pro: Ditto.

2011-03-01 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Clean up the project files and move common options to WebKit.pri.

api/QtScript.pro: Deduplicate options.

2011-03-01 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Clean up the project files and move common options to WebKit.pri.

No new tests needed.

WebCore.pri: Move common options to WebKit.pri.
WebCore.pro: Ditto.

2011-03-01 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Clean up the project files and move common options to WebKit.pri.

QtWebKit.pro: Move common options to WebKit.pri.

2011-03-01 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Clean up the project files and move common options to WebKit.pri.

WebKit2.pro: Deduplicate options.

2011-03-01 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Clean up the project files and move common options to WebKit.pri.

WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.

6:31 AM Changeset in webkit [79998] by steveblock@google.com

11 edits in trunk/Source/WebCore

2011-03-01 Steve Block <steveblock@google.com>

Reviewed by Pavel Feldman.

JNI code in Java bridge is not correctly guarded
https://bugs.webkit.org/show_bug.cgi?id=55459

No new tests, build fix only.

bridge/jni/v8/JNIBridgeV8.cpp:
bridge/jni/v8/JNIBridgeV8.h:
bridge/jni/v8/JNIUtilityPrivate.cpp:
bridge/jni/v8/JNIUtilityPrivate.h:
bridge/jni/v8/JavaClassV8.cpp:
bridge/jni/v8/JavaClassV8.h:
bridge/jni/v8/JavaInstanceV8.cpp:
bridge/jni/v8/JavaInstanceV8.h:
bridge/jni/v8/JavaNPObjectV8.cpp:
bridge/jni/v8/JavaNPObjectV8.h:

6:13 AM Changeset in webkit [79997] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

2011-03-01 Juha Savolainen <juha.savolainen@weego.fi>

Reviewed by Andreas Kling.

[Qt] WebKit2 needs to support font size changing and getting default font size
https://bugs.webkit.org/show_bug.cgi?id=53671

Added new enum for font size type and added methods to set and get default font sizes.

UIProcess/API/qt/qwkpreferences.cpp: (QWKPreferences::setFontSize): Added. (QWKPreferences::fontSize): Added.
UIProcess/API/qt/qwkpreferences.h:

6:01 AM Changeset in webkit [79996] by commit-queue@webkit.org

3 edits
3 adds in trunk/Source/WebKit/qt

2011-03-01 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Simon Hausmann.

[Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
https://bugs.webkit.org/show_bug.cgi?id=55319

The test case required internet connection to be able to connect to
google.com. Added new html file which refers to local html file.

tests/qwebpage/resources/content.html: Added.
tests/qwebpage/resources/frame_c.html: Added.
tests/qwebpage/resources/framedindex.html: Added.
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::backActionUpdate):
tests/qwebpage/tst_qwebpage.qrc:

5:55 AM Changeset in webkit [79995] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2011-03-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove manual watchdog from the inspector tests.
https://bugs.webkit.org/show_bug.cgi?id=55447

http/tests/inspector/inspector-test.js:

5:53 AM Changeset in webkit [79994] by Adam Roben

2 edits in trunk/LayoutTests

Skip another timing-out test on Windows XP

<http://webkit.org/b/51596> tracks the failure.

platform/win-xp/Skipped: Added http/tests/xmlhttprequest/basic-auth-nouser.html.

5:52 AM Changeset in webkit [79993] by Adam Roben

2 edits in trunk/Tools

Skip another multiprocessing test on Windows

It is sometimes failing (and may be leaving child Python processes around).
<http://webkit.org/b/55087> tracks the failure.

Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:

(FuncitonTests.test_getprocesses): Skip this test on Windows.

5:52 AM Changeset in webkit [79992] by Adam Roben

2 edits
1 delete in trunk/LayoutTests

Skip fast/events/pageshow-pagehide-on-back-cached.html on Windows

It is flaky. The failure is tracked by <http://webkit.org/b/55329>.

platform/win/Skipped:
platform/win/fast/events/pageshow-pagehide-on-back-cached-expected.txt: Removed.

5:51 AM Changeset in webkit [79991] by Adam Roben

1 edit
2 adds in trunk/LayoutTests

Check in Windows pixel results to match text results added in r79979

Fixes <http://webkit.org/b/55451> [Win] select-listbox-multiple-no-focusring.html needs
rebaseline

platform/win/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
platform/win/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.

5:14 AM Changeset in webkit [79990] by Philippe Normand

2 edits in trunk/LayoutTests

2011-03-01 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip one crashing tests on GTK. See also
https://bugs.webkit.org/show_bug.cgi?id=53146

platform/gtk/Skipped:

4:09 AM Changeset in webkit [79989] by Philippe Normand

2 edits in trunk/LayoutTests

2011-03-01 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip 2 crashing tests on GTK. See also
https://bugs.webkit.org/show_bug.cgi?id=53146

platform/gtk/Skipped:

3:51 AM Changeset in webkit [79988] by steveblock@google.com

44 edits in trunk/Source

2011-03-01 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Bridge.h should not include BridgeJSC.h
https://bugs.webkit.org/show_bug.cgi?id=55212

Instead, BridgeJSC.h should include Bridge.h and code should include
BridgeJSC.h as appropriate.

This prevents ports that use V8 from having to include JSC-specific
files, even if the contents of those files are guarded.

No new tests, cleanup only.

bindings/js/JSPluginElementFunctions.cpp:
bindings/js/ScriptControllerBrew.cpp:
bindings/js/ScriptControllerGtk.cpp:
bindings/js/ScriptControllerHaiku.cpp:
bindings/js/ScriptControllerQt.cpp:
bindings/js/ScriptControllerMac.mm:
bindings/js/ScriptControllerWin.cpp:
bindings/js/ScriptControllerWx.cpp:
bindings/js/ScriptInstance.h:
bindings/objc/WebScriptObject.mm:
bridge/Bridge.h:
bridge/c/c_class.h:
bridge/c/c_instance.h:
bridge/c/c_runtime.h:
bridge/jni/jsc/JNIBridgeJSC.h:
bridge/jni/jsc/JavaInstanceJSC.h:
bridge/jsc/BridgeJSC.h:
bridge/objc/objc_runtime.h:
bridge/qt/qt_class.h:
bridge/qt/qt_instance.h:
bridge/qt/qt_pixmapruntime.h:
bridge/qt/qt_runtime.h:
bridge/runtime_array.h:
bridge/runtime_method.h:
bridge/runtime_object.h:
bridge/runtime_root.cpp:
bridge/testbindings.cpp:
bridge/testbindings.mm:
bridge/testqtbindings.cpp:
page/win/FrameWin.cpp:
platform/graphics/wince/MediaPlayerProxy.cpp:
plugins/PluginView.cpp:
plugins/PluginViewNone.cpp:
plugins/gtk/PluginViewGtk.cpp:
plugins/mac/PluginViewMac.mm:
plugins/qt/PluginViewQt.cpp:
plugins/symbian/PluginViewSymbian.cpp:
plugins/win/PluginViewWin.cpp:

2011-02-25 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Bridge.h should not include BridgeJSC.h
https://bugs.webkit.org/show_bug.cgi?id=55212

Include BridgeJSC.h directly instead.

Plugins/Hosted/ProxyInstance.h:
Plugins/Hosted/WebHostedNetscapePluginView.mm:

2011-02-25 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Bridge.h should not include BridgeJSC.h
https://bugs.webkit.org/show_bug.cgi?id=55212

Include BridgeJSC.h directly instead.

Api/qwebframe.cpp:

3:35 AM Changeset in webkit [79987] by antonm@chromium.org

1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Changing Chromium expectations for recently added tests.

chromium/test_expectations.txt

2:53 AM Changeset in webkit [79986] by antonm@chromium.org

1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Temporary disabling tests which may affect others.

chromium/test_expectations.txt

2:52 AM Changeset in webkit [79985] by Nikolas Zimmermann

25 edits
16 adds in trunk

2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Antti Koivisto.

SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
https://bugs.webkit.org/show_bug.cgi?id=54800

Add new layout test from the SVG 1.1 2nd Edition test suite, covering currentColor handling.
Add tests ensuring that mutating a previously shared SVGPaint object makes it unique, so that
mutations take affect, but don't affect other renderers which shared the SVGPaint object before.

platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.checksum: Added.
platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.checksum: Added.
platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.png: Added.
platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.txt: Added.
platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.checksum: Added.
platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.png: Added.
platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Added.
svg/W3C-SVG-1.1-SE/color-prop-05-t.svg: Added.
svg/animations/animate-color-fill-currentColor-expected.txt: Added.
svg/animations/animate-color-fill-currentColor.html: Added.
svg/animations/script-tests/animate-color-fill-currentColor.js: Added.
svg/custom/SVGPaint-mutate-attribute.svg: Added.
svg/custom/SVGPaint-mutate-inline-style.svg: Added.
svg/dom/SVGColor-expected.txt: SVGColor mutations now reflected in style/computed style.
svg/dom/SVGPaint-expected.txt: Same for SVGPaint.

2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Antti Koivisto.

SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
https://bugs.webkit.org/show_bug.cgi?id=54800

Wrong handling of currentColor on inherit
https://bugs.webkit.org/show_bug.cgi?id=38102

Stop storing RefPtr<SVGPaint> objects in the SVGRenderStyle for fill/stroke. These are the last
two objects that held references to CSSValues, they're all gone now, aligning better with RenderStyle.
It's also dangerous, as a SVGPaint object can be shared by multiple SVGRenderStyles (MappedAttribute will
once create a CSSStyleDeclaration for fill="red" and reuse it where possible), and it was easy to
accidently mutate the object, affecting multiple styles. Instead store a Color, an URI and a paint
type in SVGRenderStyle, enough to create a SVGPaint object, if needed (eg for computed styles).

<g color="green"><rect fill="currentColor"/> already worked fine in trunk, but
<g fill="currentColor" color="green"><rect color="red"/> procuded a red rectangle.

In order to fix to bug we have to resolve all currentColor values for SVGPaint objects, in SVGCSSStyleSelector,
as it's already done for SVGColor objects (stop-color, flood-color, etc.) instead of in RenderSVGResource::fill/strokePaintingResource,
when trying to use the paint server. The correct "color" value that should be used from the RenderStyle, is directly
available in CSSStyleSelector: in applyProperty m_style->color() gives the desired value. In CSSStyleSelector it's handled
exactly this way for non-SVG currentColor properties. Also fix computed styles, which did not resolve currentColor for SVGPaint/SVGColor.

A previous patch implemented the SVGPaint/SVGColor API. SVG demands these CSSValues to be mutable. Introduce
CSSMutableValue, which extends CSSValue by a Node pointer, and let SVGPaint/SVGColor inherit from it.
Mutating a SVGPaint/SVGColor object now takes immediate effect, which is reflected in the inline style / computed style.
(Note that getPresentationAttribute() already takes care of removing the CSSValue from the mapped attribute cache, so that it's no longer shared.)

Add several new tests covering the patch.

Tests: svg/W3C-SVG-1.1-SE/color-prop-05-t.svg

svg/animations/animate-color-fill-currentColor.html
svg/custom/SVGPaint-mutate-attribute.svg
svg/custom/SVGPaint-mutate-inline-style.svg

GNUMakefile.am: Add CSSMutableValue.h
WebCore.gypi: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
css/CSSMutableStyleDeclaration.cpp: Reset the Node pointer in all CSSMutableValues belonging to this style declaration. (WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
css/CSSMutableStyleDeclaration.h: Add destructor.
css/CSSMutableValue.h: Added. (WebCore::CSSMutableValue::CSSMutableValue): (WebCore::CSSMutableValue::~CSSMutableValue): (WebCore::CSSMutableValue::isMutableValue): (WebCore::CSSMutableValue::node): (WebCore::CSSMutableValue::setNode): (WebCore::CSSMutableValue::setNeedsStyleRecalc):
css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Set the Node object of a CSSMutableValue to the Node, this style declaration belongs to.
css/CSSValue.h: (WebCore::CSSValue::isMutableValue): Return false, default.
css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor): Add helper function, resolving currentColor values for SVGPaint objects. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Use currentColorOrValidColor/adjustSVGPaintForCurrentColor to resolve SVGColor/SVGPaint values.
css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): Store fill/stroke uri, color, paint type seperated in SVGRenderStyle, don't store the full SVGPaint object anymore.
rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff): Adapt to SVGPaint changes.
rendering/style/SVGRenderStyle.h: Ditto. (WebCore::SVGRenderStyle::initialFillOpacity): (WebCore::SVGRenderStyle::initialFillPaintType): (WebCore::SVGRenderStyle::initialFillPaintColor): (WebCore::SVGRenderStyle::initialFillPaintUri): (WebCore::SVGRenderStyle::initialStrokeOpacity): (WebCore::SVGRenderStyle::initialStrokePaintType): (WebCore::SVGRenderStyle::initialStrokePaintColor): (WebCore::SVGRenderStyle::initialStrokePaintUri): (WebCore::SVGRenderStyle::initialStrokeMiterLimit): (WebCore::SVGRenderStyle::initialStopOpacity): (WebCore::SVGRenderStyle::initialFloodOpacity): (WebCore::SVGRenderStyle::setFillPaint): (WebCore::SVGRenderStyle::setStrokePaint): (WebCore::SVGRenderStyle::fillPaintType): (WebCore::SVGRenderStyle::fillPaintColor): (WebCore::SVGRenderStyle::fillPaintUri): (WebCore::SVGRenderStyle::strokePaintType): (WebCore::SVGRenderStyle::strokePaintColor): (WebCore::SVGRenderStyle::strokePaintUri): (WebCore::SVGRenderStyle::hasStroke): (WebCore::SVGRenderStyle::hasFill):
rendering/style/SVGRenderStyleDefs.cpp: Ditto. (WebCore::StyleFillData::StyleFillData): (WebCore::StyleFillData::operator==): (WebCore::StyleStrokeData::StyleStrokeData): (WebCore::StyleStrokeData::operator==):
rendering/style/SVGRenderStyleDefs.h: Ditto.
rendering/svg/RenderSVGResource.cpp: Ditto. (WebCore::requestPaintingResource):
rendering/svg/RenderSVGResourceClipper.cpp: Ditto. (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
rendering/svg/SVGResources.cpp: Ditto. (WebCore::paintingResourceFromSVGPaint): (WebCore::SVGResources::buildCachedResources):
svg/SVGColor.cpp: Call setNeedsStyleRecalc() after mutating the object. (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::setRGBColorICCColor): (WebCore::SVGColor::setColor):
svg/SVGColor.h:
svg/SVGPaint.cpp: Ditto. (WebCore::SVGPaint::setUri): (WebCore::SVGPaint::setPaint):
svg/SVGPaint.h:

2:21 AM Changeset in webkit [79984] by podivilov@chromium.org

3 edits in trunk/Source/WebCore

2011-03-01 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Handle decorated lines in the editor
https://bugs.webkit.org/show_bug.cgi?id=55373

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._startEditing): (WebInspector.SourceFrame.prototype._endEditing): (WebInspector.SourceFrame.prototype._createTextViewer):
inspector/front-end/TextViewer.js: (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorGutterChunk.prototype.addDecoration): (WebInspector.TextEditorGutterChunk.prototype.removeDecoration): (WebInspector.TextEditorMainPanel.prototype.set readOnly): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates): (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified): (WebInspector.TextEditorMainPanel.prototype._markDirtyLines): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._removeDecorationsInRange): (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges): (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv): (WebInspector.TextEditorMainChunk.prototype.addDecoration): (WebInspector.TextEditorMainChunk.prototype.removeDecoration): (WebInspector.TextEditorMainChunk.prototype.removeAllDecorations): (WebInspector.TextEditorMainChunk.prototype.get decorated):

1:31 AM Changeset in webkit [79983] by Philippe Normand

2 edits in trunk/Source/WebCore

2011-03-01 Philippe Normand <pnormand@igalia.com>

Unreviewed GTK build fix after r79978

GNUmakefile.am:

1:29 AM Changeset in webkit [79982] by abecsi@webkit.org

4 edits in trunk

2011-03-01 Andras Becsi <abecsi@webkit.org>

Unreviewed build fix.

[Qt] Fix minimal build.

Source/WebKit.pri: Move the XP_UNIX define back to WebCore.pri.

2011-03-01 Andras Becsi <abecsi@webkit.org>

Unreviewed build fix.

[Qt] Fix minimal build.

No new tests needed.

WebCore.pri: Is included in WebKit2.pro, so XP_UNIX can remain here.

12:59 AM Changeset in webkit [79981] by yurys@chromium.org

2 edits in trunk/Source/WebCore

2011-03-01 anthony taranto <anthony.taranto@gmail.com>

Return undefined value from ScriptController::evaluate(), allowing the
caller to distinguish between an error and an undefined return value.
https://bugs.webkit.org/show_bug.cgi?id=51528

bindings/v8/ScriptController.cpp:

12:58 AM Changeset in webkit [79980] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2011-03-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fixing flaky snow XMLViewer test on snow leopard.

http/tests/xmlviewer/dumpAsText/frames.html:

12:56 AM Changeset in webkit [79979] by rniwa@webkit.org

1 edit
1 add in trunk/LayoutTests

2011-03-01 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Windows rebaseline. The bug 55451 tracks this rebaseline.

platform/win/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.

12:48 AM Changeset in webkit [79978] by rolandsteiner@chromium.org

9 edits
2 moves in trunk/Source/WebCore

2011-03-01 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Bug 54853 - Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow
https://bugs.webkit.org/show_bug.cgi?id=54853

Moving the files from rendering to html/shadow, with the exception of
the class RenderTextControlInnerBlock, which I moved to RenderTextControlSingleLine
(this place is not ideal, but only a temporary state during the larger refactoring
for <input>).

No new tests. (refactoring)

Android.mk:
CMakeLists.txt:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
html/shadow/TextControlInnerElements.cpp: Copied from Source/WebCore/rendering/TextControlInnerElements.cpp.
html/shadow/TextControlInnerElements.h: Copied from Source/WebCore/rendering/TextControlInnerElements.h.
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint):
rendering/RenderTextControlSingleLine.h: (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
rendering/TextControlInnerElements.cpp: Removed.
rendering/TextControlInnerElements.h: Removed.

12:46 AM Changeset in webkit [79977] by joone.hur@collabora.co.uk

2 edits in trunk/Source/WebKit/gtk

2011-03-01 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp
https://bugs.webkit.org/show_bug.cgi?id=55437

webkit/webkitwebview.cpp: Convert use of cairo_t to RefPtr<cairo_t>. (webkit_web_view_expose_event):

12:39 AM Changeset in webkit [79976] by rniwa@webkit.org

7 edits in trunk/Source/WebCore

2011-03-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55338

Deployed EditingStyle in applyInlineStyleToPushDown and removeInlineStyleFromElement.

Also added a convenience function EditingStyle::setProperty, which lazily instantiates
new CSSMutableStyleDeclaration for m_mutableStyle.

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle*. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Ditto. (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls the above three functions. (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownInlineStyleAroundNode.
editing/ApplyStyleCommand.h:
editing/EditingStyle.cpp: (WebCore::HTMLElementEquivalent::addToStyle): Takes EditingStyle*; calls EditingStyle::setProperty. (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto. (WebCore::EditingStyle::setProperty): Added. This member function lazily instantiates new CSSMutableStyleDeclaration for m_mutableStyle. (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Takes EditingStyle*. (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Ditto. (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Ditto.
editing/EditingStyle.h: Added HTMLElementEquivalent and HTMLAttributeEquivalent as friends. (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Ditto.
editing/InsertTextCommand.cpp: Removed unnecessary includes.
editing/RemoveCSSPropertyCommand.h: Ditto.

12:14 AM Changeset in webkit [79975] by loislo@chromium.org

3 edits in trunk/Tools

2011-03-01 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: reduce inspector tests flakiness.
https://bugs.webkit.org/show_bug.cgi?id=55401

DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest):
DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset):

12:14 AM Changeset in webkit [79974] by abarth@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-03-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Teach JavaScriptCore GYP build about DEPTH
https://bugs.webkit.org/show_bug.cgi?id=55425

In addition to teaching the JavaScriptCore GYP build about DEPTH, this
change overrides the GCC warning configuration to disable a warning
that's causing probems in Assertions.cpp. With that warning disabled,
JavaScriptCore builds again.

gyp/JavaScriptCore.gyp:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed