⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 3, 2011:

11:20 PM Changeset in webkit [80331] by bweinstein@apple.com
  • 11 edits in trunk/Source

Cleanup from ​https://bugs.webkit.org/show_bug.cgi?id=55427.

Reviewed by Adam Roben.

Source/WebCore:

Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
on all platforms, and stub the functions on platforms that don't implement them.

Add startObservingCookieChanges and stopObservingCookieChanges to TemporaryLinkStubs
for platforms that don't implement them.

  • platform/android/TemporaryLinkStubs.cpp:
  • platform/brew/TemporaryLinkStubs.cpp:
  • platform/chromium/TemporaryLinkStubs.cpp:
  • platform/efl/TemporaryLinkStubs.cpp:
  • platform/gtk/TemporaryLinkStubs.cpp:
  • platform/haiku/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubsQt.cpp:
  • platform/win/TemporaryLinkStubs.cpp:

Source/WebKit2:

Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
on all platforms, and stub the functions on platforms that don't implement them.

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::stopObservingCookieChanges):

11:03 PM Changeset in webkit [80330] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-03 Eric Seidel <​eric@webkit.org>

Reviewed by Dimitri Glazkov.

Refactor createRendererIfNeeded to avoid premature nextRenderer calculation
​https://bugs.webkit.org/show_bug.cgi?id=55720

There are two thing going on here:

  1. Delaying nextRenderer calculation until we actually use it, previously we would always compute nextRenderer (expensive!) even if no renderer insertion was to occur.
  2. Fix fullscreen elements to be inserted into the right place in the rendering tree. Previously they would always be the last child in their parent's list, even if that wasn't the right place.

I don't know of any way to trigger the fullscreen bug,
but I tested this with peacekeeper and saw no performance change.

Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
but I don't really trust the stability of peacekeeper to begin with.

This paves the way for further improvement in our nextRenderer calculation.

  • dom/Node.cpp: (WebCore::Node::attach): (WebCore::Node::previousRenderer): (WebCore::Node::nextRenderer): (WebCore::Node::createRendererAndStyle): (WebCore::wrapWithRenderFullScreen): (WebCore::Node::createRendererIfNeeded):
  • dom/Node.h:
10:43 PM Changeset in webkit [80329] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-03 Adam Klein <​adamk@chromium.org>

Reviewed by David Levin.

Correct EntrySync.toURI test expectations to get the test passing under Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=55724

  • fast/filesystem/workers/file-entry-to-uri-sync-expected.txt:
10:25 PM Changeset in webkit [80328] by rniwa@webkit.org
  • 7 edits in trunk/Source

2011-03-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
​https://bugs.webkit.org/show_bug.cgi?id=55554

  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::copyGlobalsTo): Pass nullptr instead of 0. (JSC::JSGlobalObject::resizeRegisters): Ditto; also use OwnArrayPtr instead of a raw pointer.
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::addStaticGlobals): Ditto.
  • wtf/PassOwnArrayPtr.h: Removed #define LOOSE_PASS_OWN_ARRAY_PTR (WTF::PassOwnArrayPtr::PassOwnArrayPtr): Added a constructor that takes nullptr_t.

2011-03-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
​https://bugs.webkit.org/show_bug.cgi?id=55554

  • platform/Length.cpp: (WebCore::newLengthArray): Pass nullptr instead of 0.
10:22 PM Changeset in webkit [80327] by commit-queue@webkit.org
  • 25 edits
    2 adds in trunk/Source

2011-03-03 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Create a LayerChromium layerTreeAsText. Add HUD to
LayerRendererChromium that draws compositor FPS and, optionally,
the layer tree.
​https://bugs.webkit.org/show_bug.cgi?id=54710

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.h: (WebCore::Canvas2DLayerChromium::drawsContent):
  • platform/graphics/chromium/CanvasLayerChromium.h: (WebCore::CanvasLayerChromium::layerTypeAsString):
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::writeIndent): (WebCore::ContentLayerChromium::dumpLayerProperties):
  • platform/graphics/chromium/ContentLayerChromium.h: (WebCore::ContentLayerChromium::drawsContent): (WebCore::ContentLayerChromium::layerTypeAsString):
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setName): (WebCore::GraphicsLayerChromium::updateNames): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): (WebCore::GraphicsLayerChromium::setupContentsLayer):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.h: (WebCore::ImageLayerChromium::drawsContent): (WebCore::ImageLayerChromium::layerTypeAsString):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::setName): (WebCore::LayerChromium::layerTreeAsText): (WebCore::writeIndent): (WebCore::LayerChromium::dumpLayer): (WebCore::LayerChromium::dumpLayerProperties):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::name): (WebCore::LayerChromium::drawsContent): (WebCore::LayerChromium::debugID): (WebCore::LayerChromium::layerTypeAsString):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::present): (WebCore::LayerRendererChromium::layerTreeAsText): (WebCore::LayerRendererChromium::dumpRenderSurfaces):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::getHeadsUpDisplay): (WebCore::LayerRendererChromium::rootVisibleRect):
  • platform/graphics/chromium/PluginLayerChromium.h: (WebCore::PluginLayerChromium::drawsContent): (WebCore::PluginLayerChromium::layerTypeAsString):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::name): (WebCore::writeIndent): (WebCore::RenderSurfaceChromium::dumpSurface):
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::drawsContent): (WebCore::VideoLayerChromium::layerTypeAsString):
  • platform/graphics/chromium/WebGLLayerChromium.h: (WebCore::WebGLLayerChromium::drawsContent): (WebCore::WebGLLayerChromium::layerTypeAsString):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added. (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay): (WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay): (WebCore::CCHeadsUpDisplay::draw): (WebCore::CCHeadsUpDisplay::drawHudContents): (WebCore::CCHeadsUpDisplay::onPresent):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added. (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::showFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree): (WebCore::CCHeadsUpDisplay::showPlatformLayerTree): (WebCore::CCHeadsUpDisplay::enabled):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl): (WebCore::writeIndent): (WebCore::CCLayerImpl::dumpLayerProperties):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::debugID): (WebCore::CCLayerImpl::setName): (WebCore::CCLayerImpl::name):

2011-03-03 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Create a LayerChromium layerTreeAsText. Add HUD to
LayerRendererChromium that draws compositor FPS and, optionally,
the layer tree.
​https://bugs.webkit.org/show_bug.cgi?id=54710

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::WebSettingsImpl): (WebKit::WebSettingsImpl::setShowFPSCounter): (WebKit::WebSettingsImpl::setShowPlatformLayerTree):
  • src/WebSettingsImpl.h: (WebKit::WebSettingsImpl::showFPSCounter): (WebKit::WebSettingsImpl::showPlatformLayerTree):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doComposite):
10:20 PM Changeset in webkit [80326] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-02 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

crash in adoptNode with mutation events
​https://bugs.webkit.org/show_bug.cgi?id=50046

  • fast/dom/adopt-node-crash.html:

2011-03-02 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

crash in adoptNode with mutation events
​https://bugs.webkit.org/show_bug.cgi?id=50046

If the DOM is modified during the removeChild call in adoptNode,
then the setDocument call that follows can leave the DOM in an
inconsistent state.

  • dom/Document.cpp: (WebCore::Document::adoptNode):
10:02 PM Changeset in webkit [80325] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add audio tag tests to the media controls manual test suite.
​https://bugs.webkit.org/show_bug.cgi?id=55722

  • manual-tests/media-controls.html: Added 4 audio tests.
9:50 PM Changeset in webkit [80324] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-03-03 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
​https://bugs.webkit.org/show_bug.cgi?id=54392

Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKit coding style.
WebCore's functions should adhere WebKit coding style.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::themePartCacheEntryReset): (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate): (WebCore::RenderThemeEfl::cacheThemePartNew): (WebCore::RenderThemeEfl::cacheThemePartReset): (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset): (WebCore::RenderThemeEfl::cacheThemePartGet): (WebCore::RenderThemeEfl::cacheThemePartFlush): (WebCore::RenderThemeEfl::applyEdjeStateFromForm): (WebCore::RenderThemeEfl::paintThemePart): (WebCore::renderThemeEflColorClassSelectionActive): (WebCore::renderThemeEflColorClassSelectionInactive): (WebCore::renderThemeEflColorClassFocusRing): (WebCore::renderThemeEflColorClassButtonText): (WebCore::renderThemeEflColorClassComboText): (WebCore::renderThemeEflColorClassEntryText): (WebCore::renderThemeEflColorClassSearchText): (WebCore::RenderThemeEfl::applyPartDescription): (WebCore::RenderThemeEfl::applyPartDescriptions): (WebCore::RenderThemeEfl::controlSupportsTints): (WebCore::RenderThemeEfl::baselinePosition): (WebCore::RenderThemeEfl::paintSliderTrack): (WebCore::RenderThemeEfl::adjustSliderTrackStyle): (WebCore::RenderThemeEfl::adjustSliderThumbStyle): (WebCore::RenderThemeEfl::paintSliderThumb): (WebCore::RenderThemeEfl::adjustCheckboxStyle): (WebCore::RenderThemeEfl::paintCheckbox): (WebCore::RenderThemeEfl::adjustRadioStyle): (WebCore::RenderThemeEfl::paintRadio): (WebCore::RenderThemeEfl::adjustButtonStyle): (WebCore::RenderThemeEfl::paintButton): (WebCore::RenderThemeEfl::adjustMenuListStyle): (WebCore::RenderThemeEfl::paintMenuList): (WebCore::RenderThemeEfl::adjustTextFieldStyle): (WebCore::RenderThemeEfl::paintTextField): (WebCore::RenderThemeEfl::adjustTextAreaStyle): (WebCore::RenderThemeEfl::paintTextArea): (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeEfl::paintSearchFieldDecoration): (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeEfl::paintSearchFieldResultsButton): (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration): (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeEfl::paintSearchFieldCancelButton): (WebCore::RenderThemeEfl::adjustSearchFieldStyle): (WebCore::RenderThemeEfl::paintSearchField): (WebCore::RenderThemeEfl::adjustProgressBarStyle): (WebCore::RenderThemeEfl::paintProgressBar): (WebCore::RenderThemeEfl::paintMediaFullscreenButton): (WebCore::RenderThemeEfl::paintMediaMuteButton): (WebCore::RenderThemeEfl::paintMediaPlayButton): (WebCore::RenderThemeEfl::paintMediaSeekBackButton): (WebCore::RenderThemeEfl::paintMediaSeekForwardButton): (WebCore::RenderThemeEfl::paintMediaSliderTrack): (WebCore::RenderThemeEfl::paintMediaSliderThumb): (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer): (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack): (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb): (WebCore::RenderThemeEfl::paintMediaCurrentTime):
9:36 PM Changeset in webkit [80323] by abarth@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-03 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add jsc to JavaScriptCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=55711

  • JavaScriptCore.gypi:
    • Move jsc.cpp into jsc_files because it's really part of the jsc target.
  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Remove extraneous files from the normal jsc build. I probably added these by mistake at some point.
  • gyp/JavaScriptCore.gyp:
    • Add the jsc target to the GYP file.
9:36 PM Changeset in webkit [80322] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-03 Jeff Miller <​jeffm@apple.com>

Reviewed by Darin Adler.

Refactor classes in GenericCallback.h
​https://bugs.webkit.org/show_bug.cgi?id=55732


Since we're going to need to add additional callback classes, make a CallbackBase class that manages
the context and the callback ID. The existing callback classes (VoidCallback, GenericCallback, and
ComputedPagesCallback) now all derive from CallbackBase.


Fix bug in VoidCallback where we meant to implement the destructor, but we were implementing the default
constructor instead (we forgot the leading ~).


  • UIProcess/GenericCallback.h: (WebKit::CallbackBase::~CallbackBase): (WebKit::CallbackBase::callbackID): (WebKit::CallbackBase::CallbackBase): (WebKit::CallbackBase::context): (WebKit::CallbackBase::generateCallbackID): (WebKit::VoidCallback::~VoidCallback): (WebKit::VoidCallback::performCallback): (WebKit::VoidCallback::invalidate): (WebKit::VoidCallback::VoidCallback): (WebKit::GenericCallback::create): (WebKit::GenericCallback::~GenericCallback): (WebKit::GenericCallback::performCallbackWithReturnValue): (WebKit::GenericCallback::invalidate): (WebKit::GenericCallback::GenericCallback): (WebKit::ComputedPagesCallback::create): (WebKit::ComputedPagesCallback::~ComputedPagesCallback): (WebKit::ComputedPagesCallback::performCallbackWithReturnValue): (WebKit::ComputedPagesCallback::invalidate): (WebKit::ComputedPagesCallback::ComputedPagesCallback):
9:24 PM Changeset in webkit [80321] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-03 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add testapi to JavaScriptCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=55707

The new testapi target is slightly incomplete. There's a resource
copying step that we don't quite have yet.

This patch also cleans up some of the configuration issues in
JavaScriptCore.xcodeproj. It seems kind of wordy to repeat these for
each target. I suspect there's a more compact way of defining the
configurations, but this removes the "Default" configuration, which is
progress.

9:15 PM Changeset in webkit [80320] by aestes@apple.com
  • 3 edits
    2 adds in trunk

2011-03-03 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

Assertion failure in toElement(WebCore::Node*)
​https://bugs.webkit.org/show_bug.cgi?id=55697

  • fast/parser/fragment-foreign-content-expected.txt: Added.
  • fast/parser/fragment-foreign-content.html: Added.

2011-03-03 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

Assertion failure in toElement(WebCore::Node*)
​https://bugs.webkit.org/show_bug.cgi?id=55697

Test: fast/parser/fragment-foreign-content.html

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): The current element in the HTMLElementStack might be a DocumentFragment if a fragment is being parsed who's first node is foreign content.
9:13 PM Changeset in webkit [80319] by commit-queue@webkit.org
  • 13 edits in trunk

2011-03-03 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[QT] Implement mock client-based geolocation for layout testing
​https://bugs.webkit.org/show_bug.cgi?id=54334

Re-enable geolocation layout testing for qt port. Also enable a long pending
failure with geolocation as it works with client-based geolocation.
Skipped one last case related to multiple window which needs some code cleanup in qt DRT.

  • platform/qt/Skipped:

2011-03-03 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[QT] Implement mock client-based geolocation for layout testing
​https://bugs.webkit.org/show_bug.cgi?id=54334

Implements client() to GeolocationController to re-use geolocationClientMock class
for layout testing purpose.

  • page/GeolocationController.h: (WebCore::GeolocationController::client):

2011-03-03 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[QT] Implement mock client-based geolocation for layout testing
​https://bugs.webkit.org/show_bug.cgi?id=54334

Implement layout testing for Client-Based geolocation. If drt_run is set
then create mock geolocationClient and update the same with controller.

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::mockGeolocationReset): (DumpRenderTreeSupportQt::setMockGeolocationPermission): (DumpRenderTreeSupportQt::setMockGeolocationPosition): (DumpRenderTreeSupportQt::setMockGeolocationError):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/GeolocationClientQt.cpp: (WebCore::GeolocationClientQt::GeolocationClientQt):
  • WebCoreSupport/GeolocationClientQt.h:

2011-03-03 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[QT] Implement mock client-based geolocation for layout testing
​https://bugs.webkit.org/show_bug.cgi?id=54334

Implement testing for Client-Based geolocation for QtWebkit.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationError): (LayoutTestController::setMockGeolocationPosition):
9:00 PM Changeset in webkit [80318] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Update GPU media/media-document-audio-repaint.html
​http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20GPU%20Mesa%20-%20chromium.org&tests=media%2Fmedia-document-audio-repaint.html

  • platform/chromium/test_expectations.txt:
8:58 PM Changeset in webkit [80317] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Stop calling deprecatedNode and deprecatedEditingOffset in InsertTextCommand
​https://bugs.webkit.org/show_bug.cgi?id=55352

Stopped calling deprecatedNode and deprecatedEditingOffset in the following functions:

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionOutsideTabSpan): Takes care of all types of positions and no longer calls deprecated functions.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::positionInsideTextNode): Ditto; renamed from prepareForTextInsertion. Check if the text node inside a tab span before checking if the container node is a text node because the position before or after a text node can still be inside a tab span. (WebCore::InsertTextCommand::input): No longer calls deprecated functions.
  • editing/InsertTextCommand.h:
  • editing/ModifySelectionListLevel.cpp: (WebCore::getStartEndListChildren): Call anchorNode() instead of deprecatedNode() because the start or the end of selection could be an immediate child of a list node (e.g. br inside ul)
8:55 PM Changeset in webkit [80316] by jeremy@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-03 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

Annotate bidi tests which we intentionally fail.
​https://bugs.webkit.org/show_bug.cgi?id=48522

Add a readme file in fast/text/international detailing
a bunch of tests that we intentionally fail. This
mimics a similar file in fast/block/positioning/.

  • fast/text/international/readme.txt: Added.
8:52 PM Changeset in webkit [80315] by hans@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-03-03 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Move last bits of SQL into IDBBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=55668

After this, all SQL code for IndexedDB is in IDBBackingStore.cpp.

No new tests: refactoring only.

  • storage/IDBBackingStore.cpp: (WebCore::IDBBackingStore::createTransaction):
  • storage/IDBBackingStore.h:
  • storage/IDBCursorBackendImpl.h:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::backingStore):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBIndexBackendImpl.h:
  • storage/IDBKey.h:
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h:
  • storage/IDBTransactionCoordinator.cpp:
8:50 PM Changeset in webkit [80314] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-03 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebFrame::setUrl works only from second time if url fragment is present
​https://bugs.webkit.org/show_bug.cgi?id=32723

Create an auto-test for Qt based on the bug description.

  • tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
8:25 PM Changeset in webkit [80313] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Adam Klein <​adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Tighten up ResolveURICallbacks
​https://bugs.webkit.org/show_bug.cgi?id=55638

Two changes:

  • Retry only on TYPE_MISMATCH_ERR now that Chromium properly sets that error code.
  • Call DirectoryEntry instead of DOMFileSystem methods.

No change in behavior, so no new tests.

  • fileapi/FileSystemCallbacks.cpp: (WebCore::ResolveURICallbacks::didOpenFileSystem):
8:09 PM Changeset in webkit [80312] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-03 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Teach JavaScriptCore GYP build about private headers
​https://bugs.webkit.org/show_bug.cgi?id=55532

This patch distinguishes between public and private framework headers
so that public headers are copied into the Headers directory and
private headers are copied into the PrivateHeaders directory.

  • gyp/JavaScriptCore.gyp:
7:41 PM Changeset in webkit [80311] by levin@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-03-03 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

Need web worker referer layout test for xhr requests.
​https://bugs.webkit.org/show_bug.cgi?id=55590

Verify that the referrer is set for sync and async XHR requests
from both workers and shared workers.

  • http/tests/xmlhttprequest/workers/referer-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/referer.html: Added.
  • http/tests/xmlhttprequest/workers/resources/referer-test.js: Added.
  • http/tests/xmlhttprequest/workers/resources/referer.js: Added.
  • http/tests/xmlhttprequest/workers/shared-worker-referer-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/shared-worker-referer.html: Added.
7:21 PM Changeset in webkit [80310] by andersca@apple.com
  • 19 edits in trunk/Source

2011-03-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of Page::globalHistoryItem
​https://bugs.webkit.org/show_bug.cgi?id=55738

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Get the current history item and update it using WebView::setGlobalHistoryItem.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebView.cpp: (WebView::globalHistoryItem): (WebView::setGlobalHistoryItem):
  • WebView.h:

2011-03-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of Page::globalHistoryItem
​https://bugs.webkit.org/show_bug.cgi?id=55738

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Get the current history item and update it using -[WebView _setGlobalHistoryItem:].


  • WebView/WebView.mm: (-[WebView _globalHistoryItem]): (-[WebView _setGlobalHistoryItem:]): Set _globalHistoryItem ivar.
  • WebView/WebViewData.h:
  • WebView/WebViewData.mm: Add _globalHistoryItem ivar.

2011-03-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of Page::globalHistoryItem
​https://bugs.webkit.org/show_bug.cgi?id=55738

The m_globalHistoryItem is only used by Mac and Windows WebKit1.
Instead of having WebCore updating this member variable, just call out
to a FrameLoaderClient member function and let WebKit keep it up to date.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem): (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryItemForPage):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::updateGlobalHistoryItemForPage):
  • loader/HistoryController.cpp: (WebCore::HistoryController::goToItem): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
  • page/Page.cpp:
  • page/Page.h:
7:00 PM Changeset in webkit [80309] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Don't assume the web process has had a chance to paint before the view has to paint

Fixes <​http://webkit.org/b/55739> REGRESSION (r80307): Lots of tests crashing in
BackingStore::paint

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::paint): Bail if the web process hasn't had a chance to paint
yet.

6:18 PM Changeset in webkit [80308] by jorlow@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-02 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Cursor.continue with a key param should test less than, not equal to
​https://bugs.webkit.org/show_bug.cgi?id=55640

  • storage/indexeddb/cursor-continue-expected.txt: Added.
  • storage/indexeddb/cursor-continue.html: Added.

2011-03-02 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Cursor.continue with a key param should test less than, not equal to
​https://bugs.webkit.org/show_bug.cgi?id=55640

If you supply a param to cursor.continue, we sould guarantee that
the item we continue to is greater than or equal to the parameter.
Right now, we only test equality.

​http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-continue
​http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-iterating-a-cursor

Test: storage/indexeddb/cursor-continue.html

  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
  • storage/IDBKey.cpp: (WebCore::IDBKey::isLessThan): (WebCore::IDBKey::isEqual):
  • storage/IDBKey.h:
5:37 PM Changeset in webkit [80307] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Throw away DrawingAreaProxyImpl's backing store after not painting for 5 seconds

The intent is to save memory for views that aren't painting.

Fixes <​http://webkit.org/b/51262> <rdar://problem/8782537> WebPageProxy should delete its
backing store after not painting for a while

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize our timer.
(WebKit::DrawingAreaProxyImpl::paint): Don't bail if we don't have a backing store (but do
bail if we're in accelerated compositing mode); we might have thrown it away to save memory
but now are being asked to paint by the view. The existing code in this function will handle
getting a new backing store if possible by blocking for a little while to try to receive a
DidUpdateBackingStoreState message. Added an assertion that we do have a backing store if we
don't have any outstanding UpdateBackingStoreState requests. After painting, call
discardBackingStoreSoon to update our timer.
(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon): Set the timer for 5 seconds in the
future.
(WebKit::DrawingAreaProxyImpl::discardBackingStore): Throw away the backing store, and tell
the web process we'll need a full backing store update on the next paint.

  • UIProcess/DrawingAreaProxyImpl.h: Added m_discardBackingStoreTimer.
5:36 PM Changeset in webkit [80306] by Adam Roben
  • 7 edits in trunk/Source/WebKit2

Add a way to tell the web process to perform a full backing store update on its next paint

Messages::DrawingArea::UpdateBackingStoreState now takes a boolean specifying whether the
full backing store update should happen immediately or should be deferred until the next
paint or compositing mode change occurs. The deferred update isn't used yet, but will be
used when we start throwing away backing stores to save memory.

Fixes <​http://webkit.org/b/55730> UI process needs a way to tell the web process its backing
store needs a full update on the next paint

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::paint): If we have an outstanding backing store state change
request, tell the web process to perform the backing store update right away, in case we
previously told it it could defer the update.
(WebKit::DrawingAreaProxyImpl::sizeDidChange): Specify that we need an immediate backing
store update.
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): We can no longer assert that we
were waiting for a DidUpdateBackingStoreState message when we receive one, as it's possible
for the web process to decide to send us this message on its own (if we asked it to do a
deferred backing store update and then it needed to paint some part of the page). Specify
that we need an immediate backing store update if the web process hasn't updated to our
latest state, as we're about to draw potentially out-of-date bits to the screen and want to
get the right bits as soon as possible. Also added a FIXME about a potential optimization.
(WebKit::DrawingAreaProxyImpl::backingStoreStateDidChange): Added a RespondImmediatelyOrNot
parameter, which is just passed through to sendUpdateBackingStoreState.
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState): Added a RespondImmediatelyOrNot
parameter that is used to specify to the web process whether to perform the full backing
store update immediately. We now only wait for a DidUpdateBackingStoreState message (and
thus suppress any more UpdateBackingStoreState messages until one is received) when we ask
the web process for an immediate response; otherwise we could end up accidentally calling
waitForAndDispatchDidUpdateBackingStoreState when the web process hasn't been told to send
us such a message.

  • UIProcess/DrawingAreaProxyImpl.h: Added RespondImmediatelyOrNot.
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updateBackingStoreState): Added respondImmediately argument.

  • WebProcess/WebPage/DrawingArea.messages.in: Added respondImmediately argument to

UpdateBackingStoreState message.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize new member that's used to track
whether we should send a DidUpdateBackingStoreState message instead of an Update or
compositing mode change message. This will be set to true when a deferred backing store
update is pending.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers): If a deferred update is pending, send a
DidUpdateBackingStoreState message instead of a compositing mode change message.
(WebKit::DrawingAreaImpl::updateBackingStoreState): Added respondImmediately argument. If
we've already been told about this state ID (as can happen when the UI process decides it
needs an immediate update to a state that it previously requested a deferred update to),
don't bother updating the page's size, etc. In addition, if we've already sent a
DidUpdateBackingStoreState message for this state, we don't have to do anything at all.
Moved code to send the DidUpdateBackingStoreState message from here...
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): ...to here.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Always update our dirty region,
even if painting is suspended or we're in the process of updating the backing store state.
It causes no harm and simplifies the code. If a deferred update is pending, send a
DidUpdateBackingStoreState message instead of a compositing mode change message. Also
removed a redundant if.
(WebKit::DrawingAreaImpl::display): Added an assertion that this isn't called while updating
backing store state, as otherwise we might end up sending two DidUpdateBackingStoreState
messages. If a deferred update is pending, send a DidUpdateBackingStoreState message instead
of an Update message.

  • WebProcess/WebPage/DrawingAreaImpl.h: Updated updateBackingStoreState to match the base

class. Added sendDidUpdateBackingStoreState and m_shouldSendDidUpdateBackingStoreState.

5:36 PM Changeset in webkit [80305] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Unreviewed build correction.

  • WebFrame.cpp:

(scaleFactor): Update after 77286 to replace right/bottom
with new maxX/maxY terminology.

5:31 PM Changeset in webkit [80304] by bfulgham@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore

Build fix. Need win/cURL DownloadBundle stub.

  • platform/network/curl/DownloadBundle.h: Added.
5:27 PM Changeset in webkit [80303] by ggaren@apple.com
  • 30 edits in trunk/Source

2011-03-03 Geoffrey Garen <​ggaren@apple.com>

Rolled out 80277 and 80280 because they caused event handler layout test
failures.

4:58 PM Changeset in webkit [80302] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

4:55 PM Changeset in webkit [80301] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80237.
​http://trac.webkit.org/changeset/80237
​https://bugs.webkit.org/show_bug.cgi?id=55714

Windows bots aren't ready to be core (Requested by aroben on
#webkit).

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4:55 PM Changeset in webkit [80300] by mrowe@apple.com
  • 1 copy in tags/Safari-534.23

New tag.

4:52 PM Changeset in webkit [80299] by beidson@apple.com
  • 24 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=55721
Global IconDatabase should be returned by reference, not as a pointer

Reviewed by Darin Adler.

../WebCore:

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::icon):
(WebCore::HistoryItem::setURLString):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::commitIconURLToIconDatabase):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • loader/icon/IconDatabase.cpp:

(WebCore::iconDatabase):

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseNone.cpp:

(WebCore::iconDatabase):

  • loader/icon/wince/IconDatabaseWinCE.cpp:

(WebCore::iconDatabase):

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::finishLoading):

../WebKit/efl:

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_path_set):
(ewk_settings_icon_database_path_get):
(ewk_settings_icon_database_clear):
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):

../WebKit/gtk:

  • webkit/webkitglobals.cpp:

(closeIconDatabaseOnExit):
(WebKit::setIconDatabaseEnabled):

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_icon_uri):

../WebKit/mac:

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics iconPageURLMappingCount]):
(+[WebCoreStatistics iconRetainedPageURLCount]):
(+[WebCoreStatistics iconRecordCount]):
(+[WebCoreStatistics iconsWithDataCount]):

  • Misc/WebIconDatabase.mm:

(-[WebIconDatabase init]):
(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconURLForURL:]):
(-[WebIconDatabase defaultIconWithSize:]):
(-[WebIconDatabase retainIconForURL:]):
(-[WebIconDatabase releaseIconForURL:]):
(-[WebIconDatabase isEnabled]):
(-[WebIconDatabase setEnabled:]):
(-[WebIconDatabase removeAllIcons]):
(+[WebIconDatabase _checkIntegrityBeforeOpening]):
(-[WebIconDatabase _startUpIconDatabase]):
(-[WebIconDatabase _applicationWillTerminate:]):
(-[WebIconDatabase _resetCachedWebPreferences:]):
(importToWebCoreFormat):

  • WebView/WebView.mm:

(-[WebView _dispatchDidReceiveIconFromWebFrame:]):

../WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettings::setIconDatabasePath):
(QWebSettings::iconDatabasePath):
(QWebSettings::clearIconDatabase):
(QWebSettings::iconForUrl):

../WebKit/win:

  • WebCoreStatistics.cpp:

(WebCoreStatistics::iconPageURLMappingCount):
(WebCoreStatistics::iconRetainedPageURLCount):
(WebCoreStatistics::iconRecordCount):
(WebCoreStatistics::iconsWithDataCount):

  • WebIconDatabase.cpp:

(WebIconDatabase::init):
(WebIconDatabase::startUpIconDatabase):
(WebIconDatabase::iconForURL):
(WebIconDatabase::retainIconForURL):
(WebIconDatabase::releaseIconForURL):
(WebIconDatabase::removeAllIcons):
(WebIconDatabase::iconURLForURL):
(WebIconDatabase::isEnabled):
(WebIconDatabase::setEnabled):
(WebIconDatabase::hasIconForURL):
(WebIconDatabase::getOrCreateDefaultIconBitmap):

  • WebKitDLL.cpp:

(shutDownWebKit):

4:49 PM Changeset in webkit [80298] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Martin Robinson.

Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
​https://bugs.webkit.org/show_bug.cgi?id=52742

Use firstPositionInOrBeforeNode to instantiate appropriate position.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusInDocumentOrder):
4:42 PM Changeset in webkit [80297] by aestes@apple.com
  • 11 edits in trunk/Source

When displaying the missing plug-in sheet, pass the 'pluginspage'
attribute to the UI process.
​https://bugs.webkit.org/show_bug.cgi?id=55553

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.exp.in: Export ZN7WebCore9HTMLNames15pluginspageAttrE.
  • html/HTMLAttributeNames.in: Add 'pluginspage' as a known content

attribute.

Source/WebKit2:

  • UIProcess/API/C/WKPage.h: Add pluginsPageURL as the third argument to

missingPluginButtonClicked.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::missingPluginButtonClicked): Ditto.

  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::missingPluginButtonClicked): Ditto.

  • UIProcess/WebUIClient.h: Ditto.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::missingPluginButtonClicked): Get the value of
pluginspageAttr.

4:32 PM Changeset in webkit [80296] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Suggested by Dan Bernstein.

Move "const" around "NSString *", so that it suddenly begins to make sense.

  • WebProcess/mac/FullKeyboardAccessWatcher.mm:
4:11 PM Changeset in webkit [80295] by jeffm@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-03 Jeff Miller <​jeffm@apple.com>

Reviewed by Anders Carlsson.

WebKit2: Add WKViewRef API for executing edit commands
​https://bugs.webkit.org/show_bug.cgi?id=49829

Added WKViewExecuteCommand() and documented some of the WebCore EditorCommand strings.

  • UIProcess/API/C/win/WKView.cpp: (WKViewExecuteCommand): Added.
  • UIProcess/API/C/win/WKView.h: Added WKViewExecuteCommand() and comment block with WebCore EditorCommand strings.
3:43 PM Changeset in webkit [80294] by jberlin@webkit.org
  • 19 edits in trunk

Source/WebCore: WebKit2: Use CFNetwork Sessions API.
​https://bugs.webkit.org/show_bug.cgi?id=55435

Reviewed by Adam Roben.

Set the Private Browsing Storage Session on requests when Private Browsing is enabled.

  • WebCore.exp.in:

Support using WKCopyRequestWithStorageSession in WebCore.

  • platform/mac/WebCoreSystemInterface.h:

Ditto.

  • platform/mac/WebCoreSystemInterface.mm:

Ditto.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):
If Private Browsing is enabled, set the Private Browsing Storage Session on the request.
(WebCore::ResourceHandle::willSendRequest):
Ditto.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.

  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::setStorageSession):
Call through to WKSI.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::setStorageSession):
Ditto.

Source/WebKit/mac: WebKit2: Use CFNetwork Sessions API.
​https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Adam Roben.

Set the Private Browsing Storage Session on requests when Private Browsing is enabled.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Support using WKCopyRequestWithStorageSession in WebCore.

Source/WebKit2: WebKit2: Use CFNetwork Sessions API.
​https://bugs.webkit.org/show_bug.cgi?id=55435

Reviewed by Adam Roben.

Set the Private Browsing Storage Session on requests when Private Browsing is enabled.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Support using WKCopyRequestWithStorageSession in WebCore.

WebKitLibraries: WebKit2: Use CFNetwork Sessions API.
​https://bugs.webkit.org/show_bug.cgi?id=55435

Reviewed by Adam Roben.

Set the Private Browsing Storage Session on requests when Private Browsing is enabled.

Update WebKitSystemInterface headers and libraries with the new functions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
3:36 PM Changeset in webkit [80293] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-03 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium Snow Leopard expectations update.

Fix a couple more media/ expectations.

  • platform/chromium/test_expectations.txt:
3:33 PM Changeset in webkit [80292] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Don't try to paint outside the page's bounds

When the page is resized smaller, we would allocate a ShareableBitmap at the old, larger
size, even though we only needed to paint at the new, smaller size.

The assertion added in this patch will fire during the WebKit2/ResizeViewWhileHidden API
test if this fix gets broken in the future.

Fixes <​http://webkit.org/b/55715> DrawingAreaImpl allocates more memory than necessary when
the page is resized smaller

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updateBackingStoreState): Update our dirty region even if painting
is suspended (but still refrain from updating it when in accelerated compositing mode).
Rather than unite our existing dirty region with the page's new bounds, overwrite our dirty
region with the page's new bounds. This prevents us from accumulating a dirty region that is
larger than the page in the case where the page is being resized smaller.
(WebKit::DrawingAreaImpl::display): Added an assertion that we're not trying to paint
outside of the page's bounds.

3:28 PM Changeset in webkit [80291] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-03 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium Snow Leopard expectations update.

Add another media/ crash.

  • platform/chromium/test_expectations.txt:
3:24 PM Changeset in webkit [80290] by mihaip@chromium.org
  • 32 edits
    27 copies
    27 adds in trunk/LayoutTests

2011-03-03 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium Snow Leopard rebaseline.

Rebaseline tables/mozilla/bugs/ tests for Snow Leopard. The current
expectations were just checksums, I also added their corresponding PNGs.

We can't use the mac/ baselines since we scale the images differently
(most likely due to CG i386 vs. x86_64 differences, see bug 52335).

  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-1-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12910-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1296-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1296-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1430-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1430-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug14929-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug14929-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2981-2-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4093-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4093-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4427-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4427-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4523-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug56563-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug56563-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug5797-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug5797-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug625-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug625-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug625-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug6404-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug6404-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug97383-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug97383-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png.
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium/test_expectations.txt:
3:15 PM Changeset in webkit [80289] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-03 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

REGRESSION: Accelerated transitions are jumpy
​https://bugs.webkit.org/show_bug.cgi?id=55022

Changed the way default TimingFunction is stored according to Adam Roben's
suggestion.

  • platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
3:09 PM Changeset in webkit [80288] by mitz@apple.com
  • 15 edits in trunk

Rename -webkit-hyphenate-locale to -webkit-locale
​https://bugs.webkit.org/show_bug.cgi?id=55709

Reviewed by Sam Weinig.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::cssPropertyID):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::locale):
(WebCore::InheritedFlags::setLocale):
(WebCore::InheritedFlags::initialLocale):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

  • fast/text/hyphenate-character.html:
  • fast/text/hyphenate-first-word.html:
  • fast/text/hyphenate-locale.html:
  • fast/text/hyphens.html:
2:51 PM Changeset in webkit [80287] by kevino@webkit.org
  • 8 edits in trunk

[wx] Build fixes for Windows.

2:41 PM Changeset in webkit [80286] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-03 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Two tests crash on Snow Leopard on the GPU path.

  • platform/chromium/test_expectations.txt:
2:30 PM Changeset in webkit [80285] by oliver@apple.com
  • 15 edits in trunk/Source

2011-03-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

JSVariableObject needs to use WriteBarrier for symboltable property storage
​https://bugs.webkit.org/show_bug.cgi?id=55698

Replace the direct usage of Register in JSVariableObject (and descendents)
with WriteBarrier. This requires updating the Arguments object to use
WriteBarrier as well.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/ArgList.h: (JSC::MarkedArgumentBuffer::initialize):
  • runtime/Arguments.cpp: (JSC::Arguments::markChildren): (JSC::Arguments::copyToRegisters): (JSC::Arguments::fillArgList): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put):
  • runtime/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments): (JSC::Arguments::copyRegisters): (JSC::JSActivation::copyRegisters):
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): (JSC::JSActivation::symbolTableGet): (JSC::JSActivation::symbolTablePut): (JSC::JSActivation::symbolTablePutWithAttributes): (JSC::JSActivation::put): (JSC::JSActivation::putWithAttributes): (JSC::JSActivation::argumentsGetter):
  • runtime/JSActivation.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::put): (JSC::JSGlobalObject::putWithAttributes): (JSC::JSGlobalObject::markChildren): (JSC::JSGlobalObject::copyGlobalsFrom): (JSC::JSGlobalObject::copyGlobalsTo): (JSC::JSGlobalObject::resizeRegisters):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::setRegisters): (JSC::JSGlobalObject::addStaticGlobals):
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::put): (JSC::JSStaticScopeObject::putWithAttributes):
  • runtime/JSVariableObject.cpp: (JSC::JSVariableObject::symbolTableGet):
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::registerAt): (JSC::JSVariableObject::JSVariableObjectData::JSVariableObjectData): (JSC::JSVariableObject::symbolTableGet): (JSC::JSVariableObject::symbolTablePut): (JSC::JSVariableObject::symbolTablePutWithAttributes): (JSC::JSVariableObject::copyRegisterArray): (JSC::JSVariableObject::setRegisters):

2011-03-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

JSVariableObject needs to use WriteBarrier for symboltable property storage
​https://bugs.webkit.org/show_bug.cgi?id=55698

Update to pass JSGlobalData for the symbol table write used
to set the document property.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::updateDocument):
2:18 PM Changeset in webkit [80284] by mihaip@chromium.org
  • 5 edits in trunk/Tools

2011-03-03 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
​https://bugs.webkit.org/show_bug.cgi?id=55694

Fixes for interruptions in NRWT:

  • Make TestRunInterruptedException be pickleable correctly (the base Exception class defines a reduce that does not include the reason)
  • Fix ordering of returned arguments from TestRunner2._run_tests (interrupted and keyboard_interrupted were reversed)
  • Fix cancel_workers callsites (was using old name).
  • In handle_exception re-raise actual exception instance that was thrown
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2:04 PM Changeset in webkit [80283] by ap@apple.com
  • 2 edits
    1 move in trunk/Source/WebCore

More build fixing. Move WebCoreKeyboardUIMode.h to a cross-platform location.

  • WebCore.xcodeproj/project.pbxproj:
  • page/WebCoreKeyboardUIMode.h: Copied from WebCore/page/mac/WebCoreKeyboardUIMode.h.
  • page/mac/WebCoreKeyboardUIMode.h: Removed.
1:55 PM Changeset in webkit [80282] by ap@apple.com
  • 18 edits in trunk/Source

Build fix. Should include WebCoreKeyboardUIMode.h on all platforms now.

  • page/ChromeClient.h:
1:46 PM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
1:45 PM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
1:45 PM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
1:44 PM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
1:42 PM Changeset in webkit [80281] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-03 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Brady Eidson.

WebProcess is calling CFURLCacheRemoveAllCachedResponses when loading, results in origin-load for all resources
​https://bugs.webkit.org/show_bug.cgi?id=55701
<rdar://problem/9074017>

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Initialize cache-clearing flag parameters to false. (WebKit::WebProcessCreationParameters::encode): Serialize them properly. (WebKit::WebProcessCreationParameters::decode): And deserialize.
1:42 PM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
1:42 PM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
1:41 PM QtWebKitCheckList created by alexis.menard@openbossa.org
1:39 PM Changeset in webkit [80280] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Try to fix Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed obsolete symbol.
  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::getOwnPropertySlot): Don't mark this function
inline -- it's virtual.

1:34 PM Changeset in webkit [80279] by ap@apple.com
  • 41 edits
    2 adds in trunk/Source

Reviewed by Darin Adler.

REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
​https://bugs.webkit.org/show_bug.cgi?id=55633
<rdar://problem/8963023>

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/mac/FullKeyboardAccessWatcher.h: Added.
  • WebProcess/mac/FullKeyboardAccessWatcher.mm: Added. (-[FullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]): (-[FullKeyboardAccessWatcher init]): (+[FullKeyboardAccessWatcher fullKeyboardAccessEnabled]): Get the current state of full keyboard access, listening for change notifications.
  • WebProcess/WebProcess.h: Added fullKeyboardAccessEnabled().
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::fullKeyboardAccessEnabled): WebKit1 also doesn't implement this on platforms other than Mac.
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::fullKeyboardAccessEnabled): Just ask FullKeyboardAccessWatcher.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::keyboardUIMode):
  • WebProcess/WebCoreSupport/WebChromeClient.h: Added keyboardUIMode(), removed tabsToLinks().
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::keyboardUIMode):
  • WebProcess/WebPage/WebPage.h: Generate keyboard UI mode from tabToLinks preference and current state of FKA.
1:28 PM Changeset in webkit [80278] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-03 Dimitri Glazkov <Dimitri Glazkov>

Fix Win compile break, caused by r80276.

  • rendering/RenderThemeWin.h: Changed signature of volumeSliderOffsetFromMuteButton

to match RenderTheme.h.

1:24 PM Changeset in webkit [80277] by ggaren@apple.com
  • 27 edits in trunk/Source

2011-03-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Moved all variable object storage inline -- upping the object size limit to 1K
​https://bugs.webkit.org/show_bug.cgi?id=55653

  • JavaScriptCore.exp:
  • bytecompiler/BytecodeGenerator.cpp:
  • jit/JITOpcodes.cpp:
  • runtime/Arguments.h:
  • runtime/JSActivation.h: Removed out-of-line storage. Changed d-> to m_.
  • runtime/JSCell.h: (JSC::JSCell::MarkedSpace::sizeClassFor): Added an imprecise size class to accomodate objects up to 1K.
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h: Removed out-of-line storage. Changed d-> to m_.
  • runtime/JSObject.cpp: Don't ASSERT that JSFinalObject fills the maximum object size, since it doesn't anymore.
  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/JSVariableObject.h: Removed out-of-line storage. Changed d-> to m_.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: Added an imprecise size class to accomodate objects up to 1K.

2011-03-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Moved all variable object storage inline -- upping the object size limit to 1K
​https://bugs.webkit.org/show_bug.cgi?id=55653

  • JSRun.cpp: (JSGlueGlobalObject::JSGlueGlobalObject):
  • JSRun.h: (JSGlueGlobalObject::Flags): (JSGlueGlobalObject::userObjectStructure): Removed out-of-line storage. Changed d-> to m_.

2011-03-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Moved all variable object storage inline -- upping the object size limit to 1K
​https://bugs.webkit.org/show_bug.cgi?id=55653

  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.h:
  • bindings/js/JSWorkerContextBase.cpp: Removed out-of-line storage. Changed d-> to m_.
1:19 PM Changeset in webkit [80276] by Dimitri Glazkov
  • 11 edits in trunk/Source/WebCore

2011-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
​https://bugs.webkit.org/show_bug.cgi?id=55099

Cleanup, no behavior change.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::updateVolumeSliderContainer): Changed to pass RenderBox

instead of Node.

  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Changed

to use RenderBox as argument.

  • rendering/RenderMediaControls.h: Ditto.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): Ditto.
  • rendering/RenderTheme.h: Ditto.
  • rendering/RenderThemeChromiumMac.h: Ditto.
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton): Ditto.
  • rendering/RenderThemeMac.h: Ditto.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Ditto.
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Ditto.
1:06 PM Changeset in webkit [80275] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-03 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Give the Bundle's policy client the option of deciding the policy
​https://bugs.webkit.org/show_bug.cgi?id=55699

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add WKBundlePagePolicyAction enum and make it the return value of the WKBundlePagePolicyClient functions.
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: (WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction): (WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction): (WebKit::InjectedBundlePagePolicyClient::decidePolicyForMIMEType):
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: Pass the return value back to the caller. For unimplemented functions, return WKBundlePagePolicyActionPassThrough.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Call the policy function early if the bundle handles it.
1:03 PM Changeset in webkit [80274] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-03-03 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

When building with DEFINES+=USE_GSTREAMER=1 we don't want to define ENABLE_QT_MULTIMEDIA to 1.
Also add the new files added after ​https://bugs.webkit.org/show_bug.cgi?id=54870 to support GRefPtr
for GstElement.

  • WebCore.pro:
  • features.pri:
1:00 PM Changeset in webkit [80273] by loislo@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

2011-03-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80272.
​http://trac.webkit.org/changeset/80272
​https://bugs.webkit.org/show_bug.cgi?id=55700

the test are flaky (Requested by loislo_ on #webkit).

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.addObject):
  • http/tests/inspector/protocol-test.js: Removed.
  • inspector/protocol/runtime-agent-expected.txt: Removed.
  • inspector/protocol/runtime-agent.html: Removed.
12:22 PM Changeset in webkit [80272] by loislo@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2011-03-03 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce a protocol test for RuntimeAgent API.
​https://bugs.webkit.org/show_bug.cgi?id=55482

  • http/tests/inspector/protocol-test.js: Added. (initialize_ProtocolTest.InspectorTest.filterProps): (initialize_ProtocolTest.InspectorTest._dumpStepResult): (initialize_ProtocolTest.InspectorTest._runNextStep): (initialize_ProtocolTest.InspectorTest.runProtocolTestSuite): (initialize_ProtocolTest):
  • inspector/protocol/runtime-agent-expected.txt: Added.
  • inspector/protocol/runtime-agent.html: Added.
11:58 AM Changeset in webkit [80271] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Try to fix the Windows build again.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
11:58 AM Changeset in webkit [80270] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-03-03 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
​https://bugs.webkit.org/show_bug.cgi?id=55568

We should use updateMicroFocus() from QGraphicsItem rather than the implementation
in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
in QGraphicsItem.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::setPage):
  • Api/qgraphicswebview.h:
11:54 AM Changeset in webkit [80269] by mihaip@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Add another CRASH() for CSSSelector double frees
​https://bugs.webkit.org/show_bug.cgi?id=55693

To help track down bug 53045, add a CRASH call when the the array and/or
CSSSelector member in CSSSelectorList is disposed of more than once.

Just a check, no new tests necessary.

  • css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::deleteSelectors):
11:51 AM Changeset in webkit [80268] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Yet another attempt at fixing the Windows build.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:
  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
11:36 AM Changeset in webkit [80267] by qi.2.zhang@nokia.com
  • 2 edits in trunk/Tools

Unreviewed.

Adding myself as a committer.

11:33 AM Changeset in webkit [80266] by cmarrin@apple.com
  • 5 edits in trunk/Source/WebCore

2011-03-02 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

REGRESSION: Accelerated transitions are jumpy
​https://bugs.webkit.org/show_bug.cgi?id=55022

Got rid of default TimingFunction values from PlatformCAAnimation*. A TimingFunction
is now always passed in. The TimingFunction class now has a static method to get
a default object which has the 'ease' values in it. I now assert in both Mac and
Win implementations if a null TimingFunction pointer is seen.

  • platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (WebCore::CubicBezierTimingFunction::defaultTimingFunction): (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm: (toCAMediaTimingFunction):
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (toCACFTimingFunction):
11:28 AM Changeset in webkit [80265] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Tony Gentilcore <​tonyg@chromium.org>

Unreviewed build fix.

Fix clang compile after r80220
​https://bugs.webkit.org/show_bug.cgi?id=55692

  • storage/IDBBackingStore.cpp: (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
11:21 AM Changeset in webkit [80264] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Attempt to fix the Windows build.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
11:16 AM Changeset in webkit [80263] by bweinstein@apple.com
  • 16 edits
    2 adds in trunk/Source

Source/WebCore: Rest of WebKit2: Need a way to send notifications to client when cookies change
​https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add functions to be exported.

  • WebCore.exp.in:

Source/WebKit2: Rest of WebKit2: Need a way to send notifications to client when cookies change
​https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

This patch adds the communication from the WebProcess <-> UIProcess about starting/stopping
listening for cookies changing, and adds a mechanism for the WebProcess to notify the UIProcess
when the cookies have changed. The WebProcess sends a message to the UIProcess when the cookies
change, and the UIProcess passes this along to the WebCookieManagerProxyClient.

  • UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetClient): Call through to WebCookieManagerProxy.
(WKCookieManagerStartObservingCookieChanges): Ditto.
(WKCookieManagerStopObservingCookieChanges): Ditto.

  • UIProcess/API/C/WKCookieManager.h: Add new functions and a WKCookieManagerClient

which is responsible for cookiesDidChange.

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::initializeClient):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges): Send the message down to the web process.
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges): Ditto.
(WebKit::WebCookieManagerProxy::cookiesDidChange): Tell the WKCookieManagerClient the cookies were

modified.

  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebCookieManagerProxy.messages.in: Add new messages.
  • UIProcess/WebCookieManagerProxyClient.cpp: Added.

(WebKit::WebCookieManagerProxyClient::cookiesDidChange): Calls through to the client saying that

cookies changed.

  • UIProcess/WebCookieManagerProxyClient.h: Added.


  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::startObservingCookieChanges): Call through to WebCore::startObservingCookieChanges

(on platforms that support it).

(WebKit::WebCookieManager::stopObservingCookieChanges): Ditto (for stopObservingCookieChanges).
(WebKit::WebCookieManager::dispatchDidModifyCookies): Send a message to the UI process that cookies changed.

  • WebProcess/Cookies/WebCookieManager.h:
  • WebProcess/Cookies/WebCookieManager.messages.in:


Add new files.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • GNUmakefile.am:
  • win/WebKit2.vcproj:
11:15 AM Changeset in webkit [80262] by tonyg@chromium.org
  • 4 edits in trunk/Tools

2011-03-03 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Mihai Parparita.

Teach sheriffbot to answer whois commands
​https://bugs.webkit.org/show_bug.cgi?id=55687

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
11:14 AM Changeset in webkit [80261] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit2

2011-03-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Remove CanRunBeforeUnloadConfirmPanel sync message
​https://bugs.webkit.org/show_bug.cgi?id=55689

  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode): Encode and decode canRunBeforeUnloadConfirmPanel, as well as canRunModal, which wasn't being encoded/decoded.
  • Shared/WebPageCreationParameters.h: Add canRunBeforeUnloadConfirmPanel.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeUIClient): Send SetCanRunBeforeUnloadConfirmPanel and SetCanRunModal messages.

(WebKit::WebPageProxy::creationParameters):
Initialize parameters.canRunBeforeUnloadConfirmPanel.

  • UIProcess/WebPageProxy.messages.in: Remove CanRunBeforeUnloadConfirmPanel message.
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::canRunBeforeUnloadConfirmPanel):
  • UIProcess/WebUIClient.h: Make canRunBeforeUnloadConfirmPanel const.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::canRunBeforeUnloadConfirmPanel): Ask the web page instead of sending a synchronous message.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Initialize m_canRunBeforeUnloadConfirmPanel.
  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::canRunBeforeUnloadConfirmPanel): (WebKit::WebPage::setCanRunBeforeUnloadConfirmPanel): Add getter and setter for m_canRunBeforeUnloadConfirmPanel.

(WebKit::WebPage::setCanRunModal):
Add setter for m_canRunModal.

  • WebProcess/WebPage/WebPage.messages.in: Add SetCanRunBeforeUnloadConfirmPanel and SetCanRunModal messages.
11:01 AM Changeset in webkit [80260] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

2011-03-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Improve WebCore build time by ~5%
​https://bugs.webkit.org/show_bug.cgi?id=55688

Forward declare the CATransform3D and CGAffineTransform structs instead of including
large chunks of QuartzCore and Core Graphics.

On an 8 core Mac Pro, this sped up building WebCore by about 5%.

  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/TransformationMatrixCA.cpp:
  • platform/graphics/transforms/TransformationMatrix.h:
10:57 AM Changeset in webkit [80259] by imasaki@chromium.org
  • 3 edits
    2 copies in trunk/LayoutTests

2011-03-03 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by Mihai Parparita.

[Chromium] Snow Leopard rebaseline of media/video-layer-crash
​http://code.google.com/p/chromium/issues/detail?id=60744

  • platform/chromium-mac-leopard/media/video-layer-crash-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-layer-crash-expected.checksum.
  • platform/chromium-mac-leopard/media/video-layer-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-layer-crash-expected.png.
  • platform/chromium-mac/media/video-layer-crash-expected.checksum:
  • platform/chromium-mac/media/video-layer-crash-expected.png:
10:48 AM Changeset in webkit [80258] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Adjusted call to a method renamed in r80102.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._startEditing):
10:39 AM Changeset in webkit [80257] by mihaip@chromium.org
  • 4 edits in trunk

2011-03-03 Victoria Kirst <​vrk@google.com>

Reviewed by Eric Carlson.

Enable media tests in chromium-gpu/test_expectations
​https://bugs.webkit.org/show_bug.cgi?id=53608

Suppressing the test failures until baselines are added.

  • platform/chromium/test_expectations.txt:

2011-03-03 Victoria Kirst <​vrk@google.com>

Reviewed by Eric Carlson.

Enable media tests in chromium-gpu/test_expectations
​https://bugs.webkit.org/show_bug.cgi?id=53608

Add media folder to the list of GPU test paths.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
10:37 AM Changeset in webkit [80256] by timothy@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Attempt to fix the Windows build.

10:36 AM Changeset in webkit [80255] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-03 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by Tony Gentilcore.

[Chromium] Revert the change in http/tests/media/video-referer.html
in rev80227

  • platform/chromium/test_expectations.txt:
10:28 AM Changeset in webkit [80254] by timothy@apple.com
  • 8 edits
    1 add in trunk/Source

Use APIEntryShim instead of JSLock in SerializedScriptValue.

Source/JavaScriptCore: Make APIShims usable from WebCore.

Reviewed by Oliver Hunt.

Source/WebCore: Use APIEntryShim instead of JSLock in SerializedScriptValue to allow it to be used
by contexts not created by WebCore.

​https://webkit.org/b/55642

Reviewed by Oliver Hunt.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create): Use APIEntryShim instead of JSLock.
(WebCore::SerializedScriptValue::deserialize): Ditto.

10:19 AM Changeset in webkit [80253] by mihaip@chromium.org
  • 26 edits
    24 copies
    48 adds in trunk/LayoutTests

2011-03-03 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium Snow Leopard rebaseline.

Rebaseline tables/mozilla/marvin/ tests for Snow Leopard. The current
expectations were just checksums, I also added their corresponding PNGs.

We can't use the mac/ baselines since we scale the raptor image
differently (most likely due to CG i386 vs. x86_64 differences, see
bug 52335).

  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:10 AM Changeset in webkit [80252] by ap@apple.com
  • 4 edits
    6 adds in trunk

Reviewed by Darin Adler.

WebCore should check for "Upgrade" and "Connection" header fields in WebSockets handshake
​https://bugs.webkit.org/show_bug.cgi?id=55498
<rdar://problem/8752706>

Tests: http/tests/websocket/tests/handshake-fail-by-no-connection-header.html

http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html

  • websockets/WebSocketHandshake.h: Removed unused and meaningless setters for response header fields. Removed separate member variables for those, as they were duplicating data available in response, and there is no reason to squeeze microsecods here.
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::reset): There are no longer member variables for header field values to reset here. (WebCore::WebSocketHandshake::readServerHandshake): Removed a call for processHeaders(). (WebCore::WebSocketHandshake::serverWebSocketOrigin): Changed to get the value from response. (WebCore::WebSocketHandshake::serverWebSocketLocation): Ditto. (WebCore::WebSocketHandshake::serverWebSocketProtocol): Ditto. (WebCore::WebSocketHandshake::serverSetCookie): Ditto. (WebCore::WebSocketHandshake::serverSetCookie2): Ditto. (WebCore::WebSocketHandshake::serverUpgrade): Added. (WebCore::WebSocketHandshake::serverConnection): Added. (WebCore::WebSocketHandshake::checkResponseHeaders): Added checks for Upgrade and Connection header field presence and values.
9:54 AM QtWebKitReleases edited by Ademar Reis
(diff)
9:48 AM Changeset in webkit [80251] by mihaip@chromium.org
  • 6 edits
    4 copies
    8 adds in trunk/LayoutTests

2011-03-03 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium Snow Leopard rebaseline.

Rebaseline remaining editing/ tests for Snow Leopard. The current
expectations were just checksums, I also added their corresponding PNGs.

We can't use the mac/ baselines since we render selections differently.

  • platform/chromium-mac-leopard/editing/selection/4402375-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/4402375-expected.checksum.
  • platform/chromium-mac-leopard/editing/selection/4402375-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/image-before-linebreak-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/image-before-linebreak-expected.checksum.
  • platform/chromium-mac-leopard/editing/selection/image-before-linebreak-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/replaced-boundaries-1-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.checksum.
  • platform/chromium-mac-leopard/editing/selection/replaced-boundaries-1-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/replaced-boundaries-2-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.checksum.
  • platform/chromium-mac-leopard/editing/selection/replaced-boundaries-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/4402375-expected.checksum:
  • platform/chromium-mac/editing/selection/4402375-expected.png: Added.
  • platform/chromium-mac/editing/selection/image-before-linebreak-expected.checksum:
  • platform/chromium-mac/editing/selection/image-before-linebreak-expected.png: Added.
  • platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.checksum:
  • platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.png: Added.
  • platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.checksum:
  • platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.png: Added.
  • platform/chromium/test_expectations.txt:
9:43 AM Changeset in webkit [80250] by helder@sencha.com
  • 4 edits in trunk

[Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
​https://bugs.webkit.org/show_bug.cgi?id=55651

Reviewed by Andreas Kling.

When relying on ContextShadow and using a gradient stroke for a path,
the alpha of the shadow is incorrect.

Source/WebCore:

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::strokePath):

LayoutTests:

  • platform/qt/Skipped: Remove test from skipped list.
9:36 AM Changeset in webkit [80249] by Adam Roben
  • 2 edits in trunk/Tools

Work around a bug in KURL's parsing of Windows-style absolute file: URLs

Fixes <​http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
incorrect parsing of absolute Windows-style file: URLs

Reviewed by Tim Hatcher.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
<​http://webkit.org/b/55683>.

9:34 AM Changeset in webkit [80248] by tony@chromium.org
  • 3 edits in trunk/Tools

2011-03-03 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Run kill-old-processes on the chromium-win bot too
​https://bugs.webkit.org/show_bug.cgi?id=55630

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
9:18 AM Changeset in webkit [80247] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-03 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing test on GTK. See bug 55682.

  • platform/gtk/Skipped: Skip fast/images/support-broken-image-delegate.html
9:03 AM Changeset in webkit [80246] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-03-03 Martin Robinson <​mrobinson@igalia.com>

XHTMLMP build broken after r78342
​https://bugs.webkit.org/show_bug.cgi?id=55286

Fix XHTMLMP build now that the DocumentWriter is a member of DocumentLoader
instead of FrameLoader.

No new tests. This is a build fix.

  • dom/Document.cpp: (WebCore::Document::isXHTMLMPDocument):
8:59 AM Changeset in webkit [80245] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-03 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip svg test failing on 32-bits Release, likely due
to a rounding error, see bug 39022.

  • platform/gtk/Skipped:
8:54 AM Changeset in webkit [80244] by tonyg@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80219.
​http://trac.webkit.org/changeset/80219
​https://bugs.webkit.org/show_bug.cgi?id=55680

"Causes several media test crashes" (Requested by tonyg-cr on
#webkit).

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading): (WebKit::AssociatedURLLoader::prepareRequest): (WebKit::AssociatedURLLoader::willSendRequest): (WebKit::AssociatedURLLoader::didSendData): (WebKit::AssociatedURLLoader::didReceiveResponse): (WebKit::AssociatedURLLoader::didDownloadData): (WebKit::AssociatedURLLoader::didReceiveData): (WebKit::AssociatedURLLoader::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::didFinishLoading): (WebKit::AssociatedURLLoader::didFail):
  • src/AssociatedURLLoader.h:
8:42 AM Changeset in webkit [80243] by Carlos Garcia Campos
  • 4 edits in trunk

2011-03-03 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
​https://bugs.webkit.org/show_bug.cgi?id=53960

  • platform/gtk/Skipped: Unskip fast/events/popup-blocking-click-in-iframe.html that passes now.

2011-03-03 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
​https://bugs.webkit.org/show_bug.cgi?id=53960

  • DumpRenderTree/gtk/EventSender.cpp: (sendClick): (scheduleAsynchronousClickCallback):
8:40 AM Changeset in webkit [80242] by Dimitri Glazkov
  • 4 edits in trunk/Source/WebCore

2011-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Tweak MediaControlMuteButtonElement class hierarchy.
​https://bugs.webkit.org/show_bug.cgi?id=55614

This allows the mute button on the panel to have event handlers that are
different from the mute button in the volume slider.

No change in behavior, covered by existing tests.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::createMuteButton): Changed to use MediaControlPanelMuteButtonElement.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlMuteButtonElement::updateDisplayType): (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): Added. (WebCore::MediaControlPanelMuteButtonElement::create): Added. (WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Moved.
  • rendering/MediaControlElements.h: Added defs.
8:29 AM Changeset in webkit [80241] by Martin Robinson
  • 2 edits
    1 add in trunk/LayoutTests

2011-03-03 Martin Robinson <​mrobinson@igalia.com>

Unskipped one test that just needs platform-independent results (it
does not fail on GTK+) and one failure so that we can get a test diff
from it (not failing locally or when run manually on the bots).

8:21 AM Changeset in webkit [80240] by Adam Roben
  • 6 edits
    2 copies in trunk

Make Inspector tests work in WebKit2 on Windows

Fixes <​http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time out or crash on
Windows 7 Release (WebKit2 Tests)

Reviewed by Darin Adler.

Source/WebKit2:

Create the CFBundleRef for WebKit.dll on Windows if needed

  • Shared/win/WebKitBundle.cpp: Added.

(WebKit::createWebKitBundle): Returns a pre-existing bundle, if possible, otherwise creates
and returns a new bundle.
(WebKit::webKitBundle): Creates and caches a bundle, and returns it.

  • Shared/win/WebKitBundle.h: Added.
  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL):

  • WebProcess/WebPage/win/WebInspectorWin.cpp:

(WebKit::WebInspector::localizedStringsURL):
Changed to use webKitBundle() to ensure that the bundle has been created.

  • win/WebKit2.vcproj: Added new files.

Tools:

Look for Windows-style paths when checking whether a test is an Inspector test

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
Windows.

7:52 AM Changeset in webkit [80239] by yurys@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-03-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Resource agent should have same lifetime as Inspector agent
​https://bugs.webkit.org/show_bug.cgi?id=55461

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): disconnectFrontend is called before the agent is destroyed to clear frontend reference in all agents. (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorAgent.h: (WebCore::InspectorAgent::resourceAgent):
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCreateWebSocketImpl): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): (WebCore::InspectorInstrumentation::didCloseWebSocketImpl): (WebCore::InspectorInstrumentation::retrieveResourceAgent):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setFrontend): (WebCore::InspectorResourceAgent::clearFrontend): (WebCore::InspectorResourceAgent::restore): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::enable): (WebCore::InspectorResourceAgent::disable): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::restore):
  • inspector/InspectorTimelineAgent.h:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.frontendReused):
  • inspector/front-end/inspector.js: (WebInspector.frontendReused):
7:02 AM Changeset in webkit [80238] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-03 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing test on GTK.

  • platform/gtk/Skipped: Skip fast/canvas/rgba-parsing.html
6:39 AM CommitterTips edited by Adam Roben
Added a tip about using auto-props to set the MIME type for PNGs correctly (diff)
6:31 AM Changeset in webkit [80237] by Adam Roben
  • 3 edits in trunk/Tools

Make Windows 7 Release (Tests) a core builder

We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
give it a few more days of greenness first.

Fixes <​http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder

Reviewed by Andreas Kling.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot): Added a regexp to match Windows 7 Release (Tests).

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
Updated the core regexps to match the buildbot module. Updated the expected results to match
the current set of core builders.

6:28 AM Changeset in webkit [80236] by Philippe Normand
  • 2 edits
    55 adds in trunk/LayoutTests

2011-03-03 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

5:48 AM Changeset in webkit [80235] by abecsi@webkit.org
  • 3 edits
    3 adds in trunk

2011-03-03 Andras Becsi <​abecsi@webkit.org>

Reviewed by Andreas Kling.

CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
​https://bugs.webkit.org/show_bug.cgi?id=55661

Test case originally written by Andreas Kling <​andreas.kling@nokia.com>

Add a test of rgba() color parsing for the edge cases.

  • fast/canvas/rgba-parsing-expected.txt: Added.
  • fast/canvas/rgba-parsing.html: Added.
  • fast/canvas/script-tests/rgba-parsing.js: Added. (parse):

2011-03-03 Andras Becsi <​abecsi@webkit.org>

Reviewed by Andreas Kling.

CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
​https://bugs.webkit.org/show_bug.cgi?id=55661

Test case originally written by Andreas Kling <​andreas.kling@nokia.com>

Test: fast/canvas/rgba-parsing.html

  • css/CSSParser.cpp: (WebCore::isValidDouble): Check whether the given string is a valid double. (WebCore::parseAlphaValue): Out-of-range alpha values should be clamped to the (0.0, 1.0) range.
5:43 AM Changeset in webkit [80234] by antonm@chromium.org
  • 6 edits
    6 deletes in trunk/LayoutTests/platform

Unreviewed. Making expectations platform specific.

  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png
4:16 AM Changeset in webkit [80233] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Tools

Adding myself as a reviewer.

Reviewed by Andreas Kling.

  • Scripts/webkitpy/common/config/committers.py:
4:15 AM Changeset in webkit [80232] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-03 David Holloway <​dhollowa@chromium.org>

Reviewed by Dimitri Glazkov.

Changes HTMLTextFormControlElement::placeholderShouldBeVisible to account
for non-empty suggestion text. The visibility of the placeholder text
now turned off when suggestion text is set.
​https://bugs.webkit.org/show_bug.cgi?id=55245

No new tests because, by design, the suggestion text is not accessible
through the DOM.

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
  • html/HTMLFormControlElement.h: (WebCore::HTMLTextFormControlElement::isEmptySuggestedValue):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isEmptySuggestedValue):
4:13 AM Changeset in webkit [80231] by aestes@apple.com
  • 9 edits in trunk/Source/WebCore

2011-03-03 Andy Estes <​aestes@apple.com>

Reviewed by Eric Seidel.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
​https://bugs.webkit.org/show_bug.cgi?id=48719


Instead of pushing a fake HTMLHtmlElement onto the open element stack
during fragment parsing only to later remove it and reparent its
children to the DocumentFragment, push the DocumentFragment directly
onto the open element stack as the root node. This requires refactoring
HTMLElementStack to hold ContainerNode pointers rather than Element
pointers, which has implications for HTMLConstructionSite and
HTMLTreeBuilder as well.


With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
is ~14%. However, if you discount the 'domDynamicCreationCreateElement'
test, ToT is now ~4% faster than Safari 5.0.3. This indicates that the
regression no longer lies in fragment parsing.

No new tests. No change in behavior.

  • dom/Element.h: (WebCore::Node::hasLocalName):
  • dom/Node.h:
  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLNames::hasImpliedEndTag): (WebCore::HTMLConstructionSite::HTMLConstructionSite): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody): (WebCore::HTMLConstructionSite::insertComment): (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement): (WebCore::HTMLConstructionSite::attachToCurrent): (WebCore::HTMLConstructionSite::insertScriptElement): (WebCore::HTMLConstructionSite::insertTextNode): (WebCore::HTMLConstructionSite::createElement): (WebCore::HTMLConstructionSite::createHTMLElement): (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion): (WebCore::HTMLConstructionSite::generateImpliedEndTags): (WebCore::HTMLConstructionSite::findFosterSite): (WebCore::HTMLConstructionSite::shouldFosterParent):
  • html/parser/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::currentNode):
  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isNumberedHeaderElement): (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isListItemScopeMarker): (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLNames::isTableBodyScopeMarker): (WebCore::HTMLNames::isTableRowScopeMarker): (WebCore::HTMLNames::isButtonScopeMarker): (WebCore::HTMLNames::isSelectScopeMarker): (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::replaceElement): (WebCore::HTMLElementStack::HTMLElementStack): (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement): (WebCore::HTMLElementStack::popAll): (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped): (WebCore::HTMLElementStack::popUntil): (WebCore::HTMLElementStack::popUntilPopped): (WebCore::HTMLElementStack::popUntilTableScopeMarker): (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker): (WebCore::HTMLElementStack::popUntilTableRowScopeMarker): (WebCore::HTMLElementStack::pushHTMLHtmlElement): (WebCore::HTMLElementStack::push): (WebCore::HTMLElementStack::insertAbove): (WebCore::HTMLElementStack::find): (WebCore::HTMLElementStack::topmost): (WebCore::HTMLElementStack::contains): (WebCore::inScopeCommon): (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope): (WebCore::HTMLElementStack::htmlElement): (WebCore::HTMLElementStack::rootNode): (WebCore::HTMLElementStack::pushCommon):
  • html/parser/HTMLElementStack.h: (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::ElementRecord::node): (WebCore::HTMLElementStack::topNode):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTagForInCell): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::finished):
  • html/parser/HTMLTreeBuilder.h:
3:58 AM Changeset in webkit [80230] by yurys@chromium.org
  • 5 edits in trunk

2011-03-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector protocol should allow different domains to have methods with same name
​https://bugs.webkit.org/show_bug.cgi?id=55558

  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-03-02 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector protocol should allow different domains to have methods with same name
​https://bugs.webkit.org/show_bug.cgi?id=55558

  • inspector/CodeGeneratorInspector.pm: each command is now identified by domain + command-name(was command-name only).
3:28 AM Changeset in webkit [80229] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-03 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add an equals() method to WebAccessibilityObject.
​https://bugs.webkit.org/show_bug.cgi?id=55631

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::equals):
3:27 AM Changeset in webkit [80228] by podivilov@chromium.org
  • 7 edits in trunk/Source

2011-03-02 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make selected call frame debugger presentation model property.
​https://bugs.webkit.org/show_bug.cgi?id=55582

  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame): (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.getCompletionsOnCallFrame): (WebInspector.ScriptsPanel.prototype._debuggerResumed): (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded): (WebInspector.ScriptsPanel.prototype._callFrameSelected):

2011-03-03 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make selected call frame debugger presentation model property.
​https://bugs.webkit.org/show_bug.cgi?id=55582

  • src/js/Tests.js:
3:21 AM Changeset in webkit [80227] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-03 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Remove non-flaky tests and update bugs/comments in
media related layout tests in test expectation

  • platform/chromium/test_expectations.txt:
3:13 AM Changeset in webkit [80226] by commit-queue@webkit.org
  • 29 edits in trunk

2011-03-03 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

On Mac OS X, spelling suggestion panel stops showing up after change set 80121
​https://bugs.webkit.org/show_bug.cgi?id=55628

Rebaselined tests affected by changeset 80121.

  • platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
  • platform/mac/editing/spelling/autocorrection-delete-expected.txt:
  • platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
  • platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
  • platform/mac/editing/spelling/autocorrection-simple-expected.txt:
  • platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/click-autocorrected-word.html:
  • platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum:
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/delete-into-autocorrected-word.html:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.checksum:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.checksum:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.checksum:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:
  • platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt:

2011-03-03 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

On Mac OS X, spelling suggestion panel stops showing up after change set 80121
​https://bugs.webkit.org/show_bug.cgi?id=55628

Removed a call to stopCorrectionPanelTimer() to fix a regression introduced by changeset 80121.

  • editing/Editor.cpp: (WebCore::Editor::appliedEditing):
  • manual-tests/autocorrection/autocorrection-contraction.html:
3:06 AM Changeset in webkit [80225] by commit-queue@webkit.org
  • 6 edits
    1 add
    1 delete in trunk

2011-03-03 Lukasz Slachciak <​l.slachciak@samsung.com>

Reviewed by Xan Lopez.

[GTK] Extended application cache database API and added unit tests file.
​https://bugs.webkit.org/show_bug.cgi?id=55335

  • GNUmakefile.am: Add testapplicationcache.c and remove webkitapplicationcacheprivate.h.
  • tests/testapplicationcache.c: Added. (test_applicationcache_maximum_size): Tests if application cache storage is set/get correctly. (test_applicationcache_database_directory_path): Tests if application cache directory path is set/get correctly. (main):
  • webkit/webkitapplicationcache.cpp: (webkit_application_cache_get_maximum_size): New API for getting application cache maximum storage size.
  • webkit/webkitapplicationcache.h: Declaration of API for getting/setting application cache maximum storage size.

2011-03-03 Lukasz Slachciak <​l.slachciak@samsung.com>

Reviewed by Xan Lopez.

[GTK] Extended application cache database API and added unit tests file.
​https://bugs.webkit.org/show_bug.cgi?id=55335

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration of webkit_application_cache_set_maximum_size due to API exposal.
3:03 AM Changeset in webkit [80224] by podivilov@chromium.org
  • 5 edits in trunk

2011-03-03 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
​https://bugs.webkit.org/show_bug.cgi?id=55569

  • inspector/debugger/scripts-panel.html:

2011-03-03 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
​https://bugs.webkit.org/show_bug.cgi?id=55569

sourceFileId better reflects the intention to have unique identifier for each source that is shown in scripts panel.

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/ScriptsPanel.js:
2:58 AM Changeset in webkit [80223] by jeremy@chromium.org
  • 2 edits
    1 add
    14 deletes in trunk/LayoutTests

2011-03-03 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

Convert offsetLeft-offsetTop-borders.html to dumpAsText()
​https://bugs.webkit.org/show_bug.cgi?id=55612

This test outputs the values of offsetLeft/offsetTop for portions
of the DOM. It appears it would do just as well as a text-based test.

  • fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Added.
  • fast/block/positioning/offsetLeft-offsetTop-borders.html:
  • platform/chromium-linux/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
  • platform/chromium-linux/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
  • platform/gtk/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
  • platform/gtk/fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Removed.
  • platform/mac-leopard/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
  • platform/mac-leopard/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
  • platform/mac/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
  • platform/mac/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
  • platform/mac/fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Removed.
  • platform/qt/fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Removed.
2:51 AM Changeset in webkit [80222] by steveblock@google.com
  • 8 edits in trunk/Source/WebCore

2011-03-03 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

JavaString API should be implementable by both JSC and V8
​https://bugs.webkit.org/show_bug.cgi?id=55567

Remove JavaString's UString operator and replace it with a
script-engine-independent impl() method, which returns a
StringImpl and can be implemented with both JSC and V8.

No new tests, refactoring only.

  • bridge/jni/JNIBridge.h: (JSC::Bindings::JavaString::impl):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember):
  • bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance):
  • bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/jsc/JavaStringJSC.h: (JSC::Bindings::JavaStringImpl::impl):
  • bridge/jni/v8/JavaStringV8.h: (JSC::Bindings::JavaStringImpl::impl):
2:44 AM Changeset in webkit [80221] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Benjamin Poulain <​ikipou@gmail.com>

Reviewed by Adam Roben.

REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=55602

Delete the FloatingObject referenced by m_floatingObjects when clearing the floats.

The DeprecatedPtrList was deleting the objects automatically due to its autoDelete behavior. The
objects need to be deleted manually with ListHashSet.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloats):
2:37 AM Changeset in webkit [80220] by hans@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-03-03 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Move SQL code, especially for cursors, to IDBBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=55376

Move SQL code from IDBKey, IDBKeyRange, IDBIndexBackendImpl,
IDBObjectStoreBackendImpl, and especially IDBCursorBackendImpl.

No new functionality, so no new tests.

  • storage/IDBBackingStore.cpp: (WebCore::lowerCursorWhereFragment): (WebCore::upperCursorWhereFragment): (WebCore::IDBBackingStore::deleteObjectStoreRecord): (WebCore::IDBBackingStore::keyExistsInObjectStore): (WebCore::IDBBackingStore::getObjectViaIndex): (WebCore::keyFromQuery): (WebCore::IDBBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBBackingStore::keyExistsInIndex): (WebCore::CursorImplCommon::CursorImplCommon::continueInternal): (WebCore::CursorImplCommon::ObjectStoreCursorImpl::ObjectStoreCursorImpl): (WebCore::CursorImplCommon::ObjectStoreCursorImpl::objectStoreDataId): (WebCore::CursorImplCommon::ObjectStoreCursorImpl::key): (WebCore::CursorImplCommon::ObjectStoreCursorImpl::value): (WebCore::CursorImplCommon::ObjectStoreCursorImpl::continueFunction): (WebCore::IDBBackingStore::openObjectStoreCursor): (WebCore::ObjectStoreCursorImpl::loadCurrentRow): (WebCore::ObjectStoreCursorImpl::currentRowExists): (WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl): (WebCore::IndexKeyCursorImpl::indexDataId): (WebCore::IndexKeyCursorImpl::key): (WebCore::IndexKeyCursorImpl::primaryKey): (WebCore::IndexKeyCursorImpl::continueFunction): (WebCore::IDBBackingStore::openIndexKeyCursor): (WebCore::IndexKeyCursorImpl::loadCurrentRow): (WebCore::IndexKeyCursorImpl::currentRowExists): (WebCore::IndexCursorImpl::IndexCursorImpl): (WebCore::IndexCursorImpl::indexDataId): (WebCore::IndexCursorImpl::key): (WebCore::IndexCursorImpl::primaryKey): (WebCore::IndexCursorImpl::value): (WebCore::IndexCursorImpl::continueFunction): (WebCore::IDBBackingStore::openIndexCursor): (WebCore::IndexCursorImpl::loadCurrentRow): (WebCore::IndexCursorImpl::currentRowExists):
  • storage/IDBBackingStore.h: (WebCore::IDBBackingStore::Cursor::~Cursor):
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::key): (WebCore::IDBCursorBackendImpl::value): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunctionInternal): (WebCore::IDBCursorBackendImpl::deleteFunction):
  • storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursorInternal): (WebCore::IDBIndexBackendImpl::getInternal): (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
  • storage/IDBIndexBackendImpl.h:
  • storage/IDBKey.cpp: (WebCore::IDBKey::isEqual):
  • storage/IDBKey.h:
  • storage/IDBKeyRange.cpp:
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::putInternal): (WebCore::IDBObjectStoreBackendImpl::deleteInternal): (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
  • storage/IDBObjectStoreBackendImpl.h:
2:28 AM Changeset in webkit [80219] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-03 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

AssociatedURLLoader does not support Cross Origin Requests
​https://bugs.webkit.org/show_bug.cgi?id=53925

No tests needed. Exposes no new functionality.

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::create): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest): (WebKit::AssociatedURLLoader::ClientAdapter::didSendData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading):
  • src/AssociatedURLLoader.h: (WebKit::AssociatedURLLoaderOptions::AssociatedURLLoaderOptions):
2:24 AM Changeset in webkit [80218] by commit-queue@webkit.org
  • 13 edits in trunk

2011-03-03 Peter Kasting <​pkasting@google.com>

Reviewed by James Robinson.

Drop redundant "Windows; " from the Windows-specific User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54567

  • http/tests/navigation/useragent-expected.txt:
  • http/tests/navigation/useragent.php:

2011-03-03 Peter Kasting <​pkasting@google.com>

Reviewed by James Robinson.

Drop redundant "Windows; " from the Windows-specific User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54567

  • StringsNotToBeLocalized.txt:

2011-03-03 Peter Kasting <​pkasting@google.com>

Reviewed by James Robinson.

Drop redundant "Windows; " from the Windows-specific User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54567

  • webkit/webkitwebsettings.cpp: (webkitPlatform): (webkitUserAgent):

2011-03-03 Peter Kasting <​pkasting@google.com>

Reviewed by James Robinson.

Drop redundant "Windows; " from the Windows-specific User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54567

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):

2011-03-03 Peter Kasting <​pkasting@google.com>

Reviewed by James Robinson.

Drop redundant "Windows; " from the Windows-specific User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54567

  • WebView.cpp: (WebView::standardUserAgentWithApplicationName):

2011-03-03 Peter Kasting <​pkasting@google.com>

Reviewed by James Robinson.

Drop redundant "Windows; " from the Windows-specific User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54567

  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::standardUserAgent):
2:22 AM Changeset in webkit [80217] by pvarga@webkit.org
  • 3 edits
    3 adds in trunk

2011-03-03 Peter Varga <​pvarga@webkit.org>

Reviewed by Oliver Hunt.

Begin Characters Optimization Causes YARR Interpreter Errors
​https://bugs.webkit.org/show_bug.cgi?id=55479

The addBeginTerm function is removed because it doesn't correctly handle those
cases when an "invalid" term has been
collected (e.g. CharacterClass). Move the removed function to the
setupAlternativeBeginTerms method's switch-case
where the non-allowed cases are correctly handled.

Reenable the Beginning Character Optimization in the YARR Interpreter again.

  • fast/js/regexp-alternatives-expected.txt: Added.
  • fast/js/regexp-alternatives.html: Added.
  • fast/js/script-tests/regexp-alternatives.js: Added.

2011-03-03 Peter Varga <​pvarga@webkit.org>

Reviewed by Oliver Hunt.

Begin Characters Optimization Causes YARR Interpreter Errors
​https://bugs.webkit.org/show_bug.cgi?id=55479

The addBeginTerm function is removed because it doesn't correctly handle those
cases when an "invalid" term has been
collected (e.g. CharacterClass). Move the removed function to the
setupAlternativeBeginTerms method's switch-case
where the non-allowed cases are correctly handled.

Reenable the Beginning Character Optimization in the YARR Interpreter again.

  • yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::setupAlternativeBeginTerms): (JSC::Yarr::YarrPattern::compile):
2:09 AM Changeset in webkit [80216] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-03 Philippe Normand <​pnormand@igalia.com>

Unreviewed, unskip tests fixed by r80214 on GTK.

  • platform/gtk/Skipped:
1:33 AM Changeset in webkit [80215] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-03-03 Steve Lacey <​sjl@chromium.org>

Reviewed by Darin Fisher.

Wire up webkit metrics changes to chromium changes.
​https://bugs.webkit.org/show_bug.cgi?id=54580

  • features.gypi:
  • public/WebMediaPlayer.h:
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::decodedFrameCount): (WebKit::WebMediaPlayerClientImpl::droppedFrameCount): (WebKit::WebMediaPlayerClientImpl::audioDecodedByteCount): (WebKit::WebMediaPlayerClientImpl::videoDecodedByteCount):
  • src/WebMediaPlayerClientImpl.h:
1:00 AM Changeset in webkit [80214] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-03 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Combo boxes should emit object:selection-changed even when collapsed
​https://bugs.webkit.org/show_bug.cgi?id=53146

New GTK-specific layout test to check the right signals are emitted.

  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Added.
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Added.

2011-03-03 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Combo boxes should emit object:selection-changed even when collapsed
​https://bugs.webkit.org/show_bug.cgi?id=53146

Emit the selection-changed signals when the menu list value has changed

Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::getListObject): New, return the right list object for menu lists and list boxes. (WebCore::notifyChildrenSelectionChange): Support menu lists. (WebCore::AXObjectCache::postPlatformNotification): Call function notifyChildrenSelectionChange for AXMenuListValueChanged.
12:35 AM Changeset in webkit [80213] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
​https://bugs.webkit.org/show_bug.cgi?id=55338

Include wtf/Forward.h instead of wtf/text/String.h

  • editing/EditingStyle.h:
12:32 AM Changeset in webkit [80212] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed trivial fix after r80169.

[Qt][WK2] Memory exhausted when building qtwebkit2 on linux
​https://bugs.webkit.org/show_bug.cgi?id=55484

  • WebCore.pro: Typo fix. We have to use linux-g++* instead of linux-g++.
12:02 AM Changeset in webkit [80211] by ojan@chromium.org
  • 4 edits in trunk/Tools

2011-03-02 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

make webkit-patch upload work for security bugs
​https://bugs.webkit.org/show_bug.cgi?id=55655

The problem is that we shell out to prepare-ChangeLog,
which does not authenticate with bugzilla. All it needs from
bugzilla is the bug title though. We just pass it through from
webkit-patch instead.

  • Scripts/prepare-ChangeLog:
  • Scripts/webkitpy/common/net/bugzilla/bug.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:

Mar 2, 2011:

10:28 PM Changeset in webkit [80210] by morrita@google.com
  • 10 edits
    2 adds in trunk/Source/WebCore

2011-03-02 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Refactoring] Make ScheduledEvent on FrameView abstract out to ScheduleAction
​https://bugs.webkit.org/show_bug.cgi?id=54440

  • Extracted FrameActionScheduler from FrameView
  • Extracted FrameAction abstract class from ScheduledEvent, which has fire() virtual method.
  • Renamed ScheduledEvent EventFrameAction

With this change, Any action can be hooked up to the end of the layout.

No new tests. No behavioral change.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameActionScheduler.cpp: Added. (WebCore::EventFrameAction::EventFrameAction): (WebCore::EventFrameAction::fire): (WebCore::FrameActionScheduler::FrameActionScheduler): (WebCore::FrameActionScheduler::~FrameActionScheduler): (WebCore::FrameActionScheduler::isEmpty): (WebCore::FrameActionScheduler::clear): (WebCore::FrameActionScheduler::pause): (WebCore::FrameActionScheduler::resume): (WebCore::FrameActionScheduler::dispatch): (WebCore::FrameActionScheduler::scheduleAction): (WebCore::FrameActionScheduler::scheduleEvent):
  • page/FrameActionScheduler.h: Added. (WebCore::FrameAction::FrameAction): (WebCore::FrameAction::~FrameAction): (WebCore::FrameActionScheduler::isScheduled):
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::pauseScheduledEvents): (WebCore::FrameView::resumeScheduledEvents): (WebCore::FrameView::performPostLayoutTasks): (WebCore::FrameView::updateOverflowStatus):
  • page/FrameView.h:
10:18 PM Changeset in webkit [80209] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-03-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80201.
​http://trac.webkit.org/changeset/80201
​https://bugs.webkit.org/show_bug.cgi?id=55648

"caused tests to crash on several bots" (Requested by rniwa on
#webkit).

  • dom/Element.h: (WebCore::Node::hasTagName):
  • dom/Node.h:
  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLNames::hasImpliedEndTag): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody): (WebCore::HTMLConstructionSite::insertComment): (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement): (WebCore::HTMLConstructionSite::attachToCurrent): (WebCore::HTMLConstructionSite::insertScriptElement): (WebCore::HTMLConstructionSite::insertTextNode): (WebCore::HTMLConstructionSite::createElement): (WebCore::HTMLConstructionSite::createHTMLElement): (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion): (WebCore::HTMLConstructionSite::generateImpliedEndTags): (WebCore::HTMLConstructionSite::findFosterSite): (WebCore::HTMLConstructionSite::shouldFosterParent):
  • html/parser/HTMLConstructionSite.h:
  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isNumberedHeaderElement): (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isListItemScopeMarker): (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLNames::isTableBodyScopeMarker): (WebCore::HTMLNames::isTableRowScopeMarker): (WebCore::HTMLNames::isButtonScopeMarker): (WebCore::HTMLNames::isSelectScopeMarker): (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::replaceElement): (WebCore::HTMLElementStack::HTMLElementStack): (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement): (WebCore::HTMLElementStack::popAll): (WebCore::HTMLElementStack::popUntilTableScopeMarker): (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker): (WebCore::HTMLElementStack::popUntilTableRowScopeMarker): (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker): (WebCore::HTMLElementStack::pushHTMLHtmlElement): (WebCore::HTMLElementStack::push): (WebCore::HTMLElementStack::insertAbove): (WebCore::HTMLElementStack::find): (WebCore::HTMLElementStack::topmost): (WebCore::inScopeCommon): (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope): (WebCore::HTMLElementStack::htmlElement): (WebCore::HTMLElementStack::bodyElement): (WebCore::HTMLElementStack::pushCommon):
  • html/parser/HTMLElementStack.h: (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::top):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished): (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTagForInCell): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::finished):
  • html/parser/HTMLTreeBuilder.h:
10:12 PM Changeset in webkit [80208] by mihaip@chromium.org
  • 32 edits
    4 copies in trunk/LayoutTests

2011-03-02 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium Snow Leopard baseline update

With the exception of fast/repaint/select-option-background-color.html
and fast/repaint/slider-thumb-drag-release.html (which didn't have any
SL baselines at all), this was updating of baselines after r78846.

  • platform/chromium-mac-leopard/fast/repaint/select-option-background-color-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/repaint/select-option-background-color-expected.checksum.
  • platform/chromium-mac-leopard/fast/repaint/select-option-background-color-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/repaint/select-option-background-color-expected.png.
  • platform/chromium-mac-leopard/fast/repaint/slider-thumb-drag-release-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum.
  • platform/chromium-mac-leopard/fast/repaint/slider-thumb-drag-release-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png.
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.checksum:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac/fast/repaint/select-option-background-color-expected.checksum:
  • platform/chromium-mac/fast/repaint/select-option-background-color-expected.png:
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum:
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png:
  • platform/chromium/test_expectations.txt:
10:10 PM Changeset in webkit [80207] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium expectations update

Mark http/tests/cache/subresource-expiration-*.html as SLOW on Win

  • platform/chromium/test_expectations.txt:
9:57 PM Changeset in webkit [80206] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update

Clean up svg/ expectations (there were some non-test files with
expectations, as well as a couple of tests that have never failed).

  • platform/chromium/test_expectations.txt:
9:55 PM Changeset in webkit [80205] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

Fix crashes in private browsing tests in WK1 on Snow Leopard.

Rubber-stamped by Dan Bernstein.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Put the INIT call for wkCreatePrivateStorageSession outside of the
#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
guards.

9:43 PM Changeset in webkit [80204] by yurys@chromium.org
  • 31 edits in trunk

2011-03-02 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: break down InspectorFrontend into domain-specific classes
​https://bugs.webkit.org/show_bug.cgi?id=55584

  • inspector/elements/elements-panel-search.html:

2011-03-02 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: break down InspectorFrontend into domain-specific classes
​https://bugs.webkit.org/show_bug.cgi?id=55584

  • inspector/CodeGeneratorInspector.pm: InspectorFrontend now contains nested classes for all domains that have event notifications.
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectImpl):
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired): (WebCore::InspectorAgent::postWorkerNotificationToFrontend): (WebCore::InspectorAgent::evaluateForTestInFrontend): (WebCore::InspectorAgent::showPanel):
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::setFrontend):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::show): (WebCore::InspectorController::close):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
  • inspector/InspectorDOMStorageResource.h:
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend): (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider): (WebCore::InspectorDatabaseAgent::setFrontend):
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setFrontend):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.cpp:
  • inspector/InspectorProfilerAgent.h: (WebCore::InspectorProfilerAgent::setFrontend): (WebCore::InspectorProfilerAgent::clearFrontend):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::setFrontend):
  • inspector/InspectorTimelineAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMDispatcher.prototype.inspectElementRequested): (WebInspector.DOMDispatcher.prototype.addNodesToSearchResult):
  • inspector/front-end/inspector.js:
8:53 PM Changeset in webkit [80203] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-02 Kent Tamura <​tkent@chromium.org>

Unreviewed, a trivial regression fix.

Fix LocalizedNumberICU regression by r80198 and r80199.
​https://bugs.webkit.org/show_bug.cgi?id=55629

  • platform/text/LocalizedNumberICU.cpp: We should use U_SUCCESS(). (WebCore::createFormatterForCurrentLocale): (WebCore::parseLocalizedNumber):
8:50 PM Changeset in webkit [80202] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Let Xcode know that Localizable.strings is UTF-16-encoded.

  • WebCore.xcodeproj/project.pbxproj:
8:40 PM Changeset in webkit [80201] by aestes@apple.com
  • 9 edits in trunk/Source/WebCore

2011-03-02 Andy Estes <​aestes@apple.com>

Reviewed by Eric Seidel.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
​https://bugs.webkit.org/show_bug.cgi?id=48719


Instead of pushing a fake HTMLHtmlElement onto the open element stack
during fragment parsing only to later remove it and reparent its
children to the DocumentFragment, push the DocumentFragment directly
onto the open element stack as the root node. This requires refactoring
HTMLElementStack to hold ContainerNode pointers rather than Element
pointers, which has implications for HTMLConstructionSite and
HTMLTreeBuilder as well.


With this patch, the regression in Peacekeeper due to the introduction
of the HTML5 fragment parsing algorithm is ~14%. The regression from
Safari 5.0.3 is ~24%.

No new tests. No change in behavior.

  • dom/Element.h: (WebCore::Node::hasLocalName):
  • dom/Node.h:
  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLNames::hasImpliedEndTag): (WebCore::HTMLConstructionSite::HTMLConstructionSite): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody): (WebCore::HTMLConstructionSite::insertComment): (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement): (WebCore::HTMLConstructionSite::attachToCurrent): (WebCore::HTMLConstructionSite::insertScriptElement): (WebCore::HTMLConstructionSite::insertTextNode): (WebCore::HTMLConstructionSite::createElement): (WebCore::HTMLConstructionSite::createHTMLElement): (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion): (WebCore::HTMLConstructionSite::generateImpliedEndTags): (WebCore::HTMLConstructionSite::findFosterSite): (WebCore::HTMLConstructionSite::shouldFosterParent):
  • html/parser/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::currentNode):
  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isNumberedHeaderElement): (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isListItemScopeMarker): (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLNames::isTableBodyScopeMarker): (WebCore::HTMLNames::isTableRowScopeMarker): (WebCore::HTMLNames::isButtonScopeMarker): (WebCore::HTMLNames::isSelectScopeMarker): (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::replaceElement): (WebCore::HTMLElementStack::HTMLElementStack): (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement): (WebCore::HTMLElementStack::popAll): (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped): (WebCore::HTMLElementStack::popUntil): (WebCore::HTMLElementStack::popUntilPopped): (WebCore::HTMLElementStack::popUntilTableScopeMarker): (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker): (WebCore::HTMLElementStack::popUntilTableRowScopeMarker): (WebCore::HTMLElementStack::pushHTMLHtmlElement): (WebCore::HTMLElementStack::push): (WebCore::HTMLElementStack::insertAbove): (WebCore::HTMLElementStack::find): (WebCore::HTMLElementStack::topmost): (WebCore::HTMLElementStack::contains): (WebCore::inScopeCommon): (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope): (WebCore::HTMLElementStack::htmlElement): (WebCore::HTMLElementStack::rootNode): (WebCore::HTMLElementStack::pushCommon):
  • html/parser/HTMLElementStack.h: (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::ElementRecord::node): (WebCore::HTMLElementStack::topNode):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTagForInCell): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::finished):
  • html/parser/HTMLTreeBuilder.h:
8:21 PM Changeset in webkit [80200] by rniwa@webkit.org
  • 9 edits in trunk/Source

2011-03-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80188.
​http://trac.webkit.org/changeset/80188
​https://bugs.webkit.org/show_bug.cgi?id=55647

Broke the WebKit API tests. (Requested by xenon on #webkit).

  • WebCore.exp.in:

2011-03-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80188.
​http://trac.webkit.org/changeset/80188
​https://bugs.webkit.org/show_bug.cgi?id=55647

Broke the WebKit API tests. (Requested by xenon on #webkit).

  • UIProcess/API/C/WKPage.cpp: (WKPageRunJavaScriptInMainFrame): (callRunJavaScriptBlockAndRelease):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): (WebKit::WebPageProxy::runJavaScriptInMainFrame): (WebKit::WebPageProxy::processDidCrash):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::runJavaScriptInMainFrame):
7:44 PM Changeset in webkit [80199] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-02 Kent Tamura <​tkent@chromium.org>

Unreviewed, build fix.

  • platform/text/LocalizedNumberICU.cpp: (WebCore::createFormatterForCurrentLocale): Fix a typo.
7:16 PM Changeset in webkit [80198] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Caching number formatter instances in LocalizedNumber* implementations
​https://bugs.webkit.org/show_bug.cgi?id=55629

Reviewed by Darin Adler.

No new tests. This change doesn't change existing behavior, and is
covered by existing tests.

  • platform/text/LocalizedNumberICU.cpp:

(WebCore::createFormatterForCurrentLocale):
(WebCore::numberFormatter): Introduce a function to return a static

instance of NumberFormat.

(WebCore::parseLocalizedNumber): Use numberFormatter().
(WebCore::formatLocalizedNumber): Use numberFormatter().

  • platform/text/mac/LocalizedNumberMac.mm:

(WebCore::createFormatterForCurrentLocale):
(WebCore::numberFormatter): Introduce a function to return a static

instance of NSNumberFormatter.

(WebCore::parseLocalizedNumber): Use numberFormatter().
(WebCore::formatLocalizedNumber): Use numberFormatter().

7:02 PM Changeset in webkit [80197] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-03-01 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

[test-dashboard] make gtest JSON match layout-tests JSON
​https://bugs.webkit.org/show_bug.cgi?id=55556

​http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
Make this code match.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
6:40 PM Changeset in webkit [80196] by jberlin@webkit.org
  • 3 edits in trunk/WebKitLibraries

Update WebKitSystemInterface libraries. Library changes reviewed by Darin Adler.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
6:30 PM Changeset in webkit [80195] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-02 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

deprecatedEditingOffset should actually return the expected deprecated value for "after" positions
​https://bugs.webkit.org/show_bug.cgi?id=54986

Calls to deprecatedEditingOffset needs to return the expected value for new Before/After positions
until we can update all the call sites to consider the new position types.

No tests. This is intended to simplify the transition to new Positions, not to change behavior.

  • dom/Position.cpp: (WebCore::Position::deprecatedEditingOffset): (WebCore::Position::offsetForPositionAfterAnchor): Added to do the right thing while ensuring inline-speed for most calls to deprecatedEditingOffset.
  • dom/Position.h:
5:59 PM Changeset in webkit [80194] by jeffm@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-03-02 Jeff Miller <​jeffm@apple.com>

Reviewed by Darin Adler.

Rename WebKit::WebPage::validateMenuItem() to validateCommand()
​https://bugs.webkit.org/show_bug.cgi?id=55636


Since this method can validate more than menu items, validateCommand() is a better name. Also rename various messages and WebKit::WebPageProxy::didValidateMenuItem() to didValidateCommand().

  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Call validateCommand() instead of validateMenuItem().
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::validateCommand): Renamed from validateMenuItem(). (WebKit::WebPageProxy::didValidateCommand): Renamed from didValidateMenuItem().
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Renamed DidValidateMenuItem to DidValidateCommand.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::validateCommand): Renamed from validateMenuItem().
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Renamed ValidateMenuItem to ValidateCommand.
5:57 PM Changeset in webkit [80193] by mihaip@chromium.org
  • 6 edits
    4 adds
    2 deletes in trunk/LayoutTests

2011-03-02 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Gentilcore.

Split up http/tests/cache/subresource-expiration.html so it stops timing out
​https://bugs.webkit.org/show_bug.cgi?id=55639

http/tests/cache/subresource-expiration.html does a lot of sequential
loads, some with delays in between them. This seems unavoidable, so
to make the test less likely to time out (especially on debug bots),
the test cases are split across two tests.

  • http/tests/cache/subresource-expiration-1-expected.txt: Added.
  • http/tests/cache/subresource-expiration-1.html: Added.
  • http/tests/cache/subresource-expiration-2-expected.txt: Added.
  • http/tests/cache/subresource-expiration-2.html: Added.
  • http/tests/cache/subresource-expiration-expected.txt: Removed.
  • http/tests/cache/subresource-expiration.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-wk2/Skipped:
  • platform/mac/test_expectations.txt:
  • platform/qt-wk2/Skipped:
  • platform/win/Skipped:
5:45 PM Changeset in webkit [80192] by dpranke@chromium.org
  • 9 edits in trunk/Tools

2011-03-02 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

NRWT - implement Linux Hardy 64-bit port support. This involves
adding support for non-'x86' architectures and updating the
"deduplicate_tests" script to correctly understand that
port.name() is not always equal to basename(port.baseline_path()).

This change introduces two new port names: 'chromium-linux-x86'
and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
flag will cause the code to determine which one to use at
runtime, just like we currently do with 'chromium-win'.

​https://bugs.webkit.org/show_bug.cgi?id=55535

  • Scripts/webkitpy/common/system/executive_mock.py: Handle 'return_stderr' keyword arg to run_command()
  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome.py:
5:41 PM Changeset in webkit [80191] by kevino@webkit.org
  • 4 edits in trunk

[wx] Build fixes after recent changes.

5:38 PM Changeset in webkit [80190] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-03-02 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

WKPageSetMemoryCacheClientCallsEnabled doesn't persist if web process crashes
​https://bugs.webkit.org/show_bug.cgi?id=55635

  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode): Encode and decode areMemoryCacheClientCallsEnabled.
  • Shared/WebPageCreationParameters.h: Add areMemoryCacheClientCallsEnabled member variable.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_areMemoryCacheClientCallsEnabled.

(WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled):
Update m_areMemoryCacheClientCallsEnabled. Send a message if necessary.

(WebKit::WebPageProxy::creationParameters):
Set areMemoryCacheClientCallsEnabled.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Call WebPage::setMemoryCacheMessagesEnabled.
5:32 PM Changeset in webkit [80189] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <​tonyg@chromium.org>

Unreviewed expectations update

[chromium] xss-ALLOWED-from-javascript-url-sub-frame-to-javascript-url-sub-frame.html is crashy
​https://bugs.webkit.org/show_bug.cgi?id=55634

  • platform/chromium/test_expectations.txt:
5:17 PM Changeset in webkit [80188] by timothy@apple.com
  • 9 edits in trunk/Source

Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef.

Source/WebCore: Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).

Reviewed by Darin Adler.

  • WebCore.exp.in: Added ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.

Source/WebKit2: Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef.

​https://webkit.org/b/55623

Reviewed by Darin Adler.

  • UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame): Use ScriptValueCallback.
(callRunJavaScriptBlockAndRelease): Use WKSerializedScriptValueRef.

  • UIProcess/API/C/WKPage.h: Use WKSerializedScriptValueRef.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Call invalidateCallbackMap for m_scriptValueCallbacks.
(WebKit::WebPageProxy::runJavaScriptInMainFrame): Take a ScriptValueCallback.
(WebKit::WebPageProxy::scriptValueCallback): Added. Create a WebSerializedScriptValue
from the DataReference before calling the callback.
(WebKit::WebPageProxy::processDidCrash): Call invalidateCallbackMap for m_scriptValueCallbacks.

  • UIProcess/WebPageProxy.h: Added ScriptValueCallback and m_scriptValueCallbacks.
  • UIProcess/WebPageProxy.messages.in: Added ScriptValueCallback.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame): Create a DataReference from a WebCore::SerializedScriptValue.
And use ScriptValueCallback to send the message back.

5:12 PM Changeset in webkit [80187] by jberlin@webkit.org
  • 2 edits in trunk/WebKitLibraries

Windows build fix. Unreviewed.

  • win/lib/WebKitSystemInterface.lib:
5:09 PM Changeset in webkit [80186] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Mark the other compositing/ directory as expected to fail on Leopard.

  • platform/chromium/test_expectations.txt:
5:00 PM Changeset in webkit [80185] by dcheng@chromium.org
  • 13 edits in trunk/Source

2011-03-02 Daniel Cheng <​dcheng@chromium.org>

Reviewed by David Levin.

Manually revert ChromiumDataObject changes.
​https://bugs.webkit.org/show_bug.cgi?id=55627

No new tests since no functionality should change.

  • WebCore.gypi:
  • editing/chromium/EditorChromium.cpp: (WebCore::Editor::newGeneralClipboard):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clearData): (WebCore::ChromiumDataObject::clearAll): (WebCore::ChromiumDataObject::clearAllExceptFiles): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::getData): (WebCore::ChromiumDataObject::setData): (WebCore::ChromiumDataObject::ChromiumDataObject):
  • platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::copy): (WebCore::ChromiumDataObject::urlTitle): (WebCore::ChromiumDataObject::setUrlTitle): (WebCore::ChromiumDataObject::htmlBaseUrl): (WebCore::ChromiumDataObject::setHtmlBaseUrl): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::filenames): (WebCore::ChromiumDataObject::setFilenames): (WebCore::ChromiumDataObject::fileExtension): (WebCore::ChromiumDataObject::setFileExtension): (WebCore::ChromiumDataObject::fileContentFilename): (WebCore::ChromiumDataObject::setFileContentFilename): (WebCore::ChromiumDataObject::fileContent): (WebCore::ChromiumDataObject::setFileContent):
  • platform/chromium/ClipboardChromium.cpp:
  • platform/chromium/ClipboardChromium.h:

2011-03-02 Daniel Cheng <​dcheng@chromium.org>

Reviewed by David Levin.

Manually revert ChromiumDataObject changes.
​https://bugs.webkit.org/show_bug.cgi?id=55627

  • public/WebView.h:
  • src/WebDragData.cpp: (WebKit::WebDragData::initialize):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnter):
  • src/WebViewImpl.h:
4:49 PM Changeset in webkit [80184] by Martin Robinson
  • 2 edits in trunk/Source/WebKit/gtk

2011-03-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Do a bit of cleanup in ChromeClientGtk. Instead of always fetching the
WebKitWebView from the frame, simply get it from the member variable of
the ChromeClientGtk instance itself.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scrollbarsVisible): (WebKit::ChromeClient::exceededDatabaseQuota): (WebKit::ChromeClient::requestGeolocationPermissionForFrame): (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame): (WebKit::ChromeClient::enterFullscreenForNode): (WebKit::ChromeClient::exitFullscreenForNode):
4:40 PM Changeset in webkit [80183] by jorlow@chromium.org
  • 22 edits
    5 copies in trunk

2011-03-02 David Grogan <​dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: fire versionchange events when calling setVersion
​https://bugs.webkit.org/show_bug.cgi?id=55095

  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/set_version_queue.html:

2011-03-02 David Grogan <​dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: fire versionchange events when calling setVersion
​https://bugs.webkit.org/show_bug.cgi?id=55095

  • dom/EventNames.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close): (WebCore::IDBDatabase::onVersionChange): (WebCore::IDBDatabase::open): (WebCore::IDBDatabase::enqueueEvent): (WebCore::IDBDatabase::dispatchEvent):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::dispatchEvent):
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create): (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::databaseCallbacks): (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::PendingSetVersionCall): (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::open): (WebCore::IDBDatabaseBackendImpl::close):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBDatabaseCallbacks.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.cpp. (WebCore::IDBDatabaseCallbacks::~IDBDatabaseCallbacks):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):
  • storage/IDBVersionChangeEvent.cpp: (WebCore::IDBVersionChangeEvent::create): (WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
  • storage/IDBVersionChangeEvent.h:
  • storage/IDBVersionChangeRequest.cpp: (WebCore::IDBVersionChangeRequest::onBlocked):

2011-03-02 David Grogan <​dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: fire versionchange events when calling setVersion
​https://bugs.webkit.org/show_bug.cgi?id=55095

  • WebKit.gyp:
  • src/IDBDatabaseCallbacksProxy.cpp: Copied from Source/WebCore/storage/IDBVersionChangeEvent.h. (WebCore::IDBDatabaseCallbacksProxy::create): (WebCore::IDBDatabaseCallbacksProxy::IDBDatabaseCallbacksProxy): (WebCore::IDBDatabaseCallbacksProxy::~IDBDatabaseCallbacksProxy): (WebCore::IDBDatabaseCallbacksProxy::onVersionChange):
  • src/IDBDatabaseCallbacksProxy.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.h.
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::setVersion): (WebCore::IDBDatabaseProxy::close): (WebCore::IDBDatabaseProxy::open):
  • src/IDBDatabaseProxy.h:
  • src/WebIDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBVersionChangeEvent.cpp. (WebCore::WebIDBDatabaseCallbacksImpl::WebIDBDatabaseCallbacksImpl): (WebCore::WebIDBDatabaseCallbacksImpl::~WebIDBDatabaseCallbacksImpl): (WebCore::WebIDBDatabaseCallbacksImpl::onVersionChange):
  • src/WebIDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.h.
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::setVersion): (WebKit::WebIDBDatabaseImpl::close): (WebKit::WebIDBDatabaseImpl::open):
  • src/WebIDBDatabaseImpl.h:
4:18 PM Changeset in webkit [80182] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Fix assertion failures on Gtk bot.

  • page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks): Removed an overzealous assertion. We can get here with non-Tab key events when spatial navigation is enabled.
4:12 PM Changeset in webkit [80181] by mihaip@chromium.org
  • 32 edits
    9 deletes in trunk

2011-03-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80139.
​http://trac.webkit.org/changeset/80139
​https://bugs.webkit.org/show_bug.cgi?id=55620

failing and crashing tests on Snow Leopard bot (Requested by
mihaip1 on #webkit).

  • fast/dom/Geolocation/iframe-reparent-expected.txt: Removed.
  • fast/dom/Geolocation/iframe-reparent.html: Removed.
  • fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Removed.
  • fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Removed.
  • fast/dom/Geolocation/resources/iframe-reparent-page-iframe.html: Removed.
  • fast/dom/Geolocation/resources/iframe-reparent-page.html: Removed.
  • fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Removed.
  • fast/dom/Geolocation/script-tests/iframe-reparent.js: Removed.
  • fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Removed.
  • platform/gtk/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:

2011-03-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80139.
​http://trac.webkit.org/changeset/80139
​https://bugs.webkit.org/show_bug.cgi?id=55620

failing and crashing tests on Snow Leopard bot (Requested by
mihaip1 on #webkit).

  • page/DOMWindow.cpp:
  • page/DOMWindow.h:
  • page/Frame.cpp: (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument):
  • page/Frame.h: (WebCore::Frame::detachFromPage):
  • page/Geolocation.cpp: (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::startUpdating): (WebCore::Geolocation::stopUpdating):
  • page/Geolocation.h:
  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
  • page/Navigator.cpp:
  • page/Navigator.h:
  • platform/mock/GeolocationClientMock.cpp:
  • platform/mock/GeolocationClientMock.h:

2011-03-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80139.
​http://trac.webkit.org/changeset/80139
​https://bugs.webkit.org/show_bug.cgi?id=55620

failing and crashing tests on Snow Leopard bot (Requested by
mihaip1 on #webkit).

  • public/WebGeolocationClientMock.h:
  • src/WebGeolocationClientMock.cpp:

2011-03-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80139.
​http://trac.webkit.org/changeset/80139
​https://bugs.webkit.org/show_bug.cgi?id=55620

failing and crashing tests on Snow Leopard bot (Requested by
mihaip1 on #webkit).

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/mac/UIDelegate.h:
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4:07 PM Changeset in webkit [80180] by jberlin@webkit.org
  • 26 edits in trunk

Source/JavaScriptCore: WebKit2: Use CFNetwork Sessions API.
​https://bugs.webkit.org/show_bug.cgi?id=55435

Reviewed by Adam Roben.

Add the ability to create a Private Browsing storage session.

  • wtf/Platform.h:

Add a new #define for using CF Storage Sessions.

Source/WebCore: WebKit2: Use CFNetwork Sessions API.
​https://bugs.webkit.org/show_bug.cgi?id=55435

Reviewed by Adam Roben.

Add the ability to create a Private Browsing Storage Session.

  • WebCore.exp.in:

Export the symbol for ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase.

  • page/Settings.cpp:

(WebCore::Settings::setPrivateBrowsingEnabled):
Propagate the private browsing state to the ResourceHandle.

  • platform/mac/WebCoreSystemInterface.h:

Add the function declaration for wkCreatePrivateStorageSession.

  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/ResourceHandle.cpp:

(WebCore::privateStorageSession):
Since the same Private Browsing Storage Session will need to be accessed throughout the loading
code and will need to be used by all web pages and page groups, make it a global static.
(WebCore::privateBrowsingStorageSessionIdentifierBase):
Ditto, since the identifier is needed to create the Private Browsing Storage Session.
(WebCore::ResourceHandle::setPrivateBrowsingEnabled):
If enabled, create and store the Private Browsing Storage Session.
(WebCore::ResourceHandle::privateBrowsingStorageSession):
(WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase):

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
The call to wkCreatePrivateStorageSession needs to be in a file including the correct
version of WKSI.
(WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
Return the bundle identifier.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
The call to wkCreatePrivateStorageSession needs to be in a file importing the correct
version of WKSI.
(WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
Return the bundle identifier.

Source/WebKit/mac: WebKit2: Use CFNetwork Sessions API.
​https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Adam Roben.

Add the ability to create a Private Browsing Storage Session.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Support calling wkCreatePrivateStorageSession from WebCore.

Source/WebKit2: WebKit2: Use CFNetwork Sessions API.
​https://bugs.webkit.org/show_bug.cgi?id=55435

Reviewed by Adam Roben.

Add the ability to create a Private Browsing Storage Session.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
Encode the UI Process bundle identifier.
(WebKit::WebProcessCreationParameters::decode):
Decode the UI Process bundle identifier.

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
Grab the bundle identifier and use it to set the WebProcessCreationParameter.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Ditto.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Support using the wkCreatePrivateStorageSession WKSI in WebCore.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Set the base for the Private Browsing Storage Session identifier to be the bundle identifier
from the UI Process so that WebKit1 would create a Private Browsing Storage Session with the
same identifier as WebKit2.

WebKitLibraries: WebKit2: Use CFNetwork Sessions API.
​https://bugs.webkit.org/show_bug.cgi?id=55435

Rubber-stamped by Adam Roben.

Add the ability to create a Private Browsing Storage Session.

Update WebKitSystemInterface headers and libraries with the new functions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
4:00 PM Changeset in webkit [80179] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-03-02 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove "register slot" concept from PropertySlot
​https://bugs.webkit.org/show_bug.cgi?id=55621

PropertySlot had already stopped storing Register "slots"
so this patch is simply removing that api entirely.
This exposed a problem in the ProgramNode constructor for
BytecodeGenerator where it reads from the registerfile
before it has initialised it.

This bug wasn't a problem before as we were merely testing
for property existence rather than the actual value, and
used to work because setRegisterSlot didn't check that the
provided slot contained an initialised value.

To get around this issue we now use symbolTableHasProperty
to do the symbol table check without trying to read the
RegisterFile.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator):
  • runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot):
  • runtime/JSActivation.cpp: (JSC::JSActivation::symbolTableGet):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::symbolTableHasProperty):
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::symbolTableGet):
  • runtime/PropertySlot.h:
3:52 PM Changeset in webkit [80178] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

compositing/geometry/object-clip-rects-assertion.html no longer times
out on the Mac (was just a bad bot).

  • platform/chromium/test_expectations.txt:
3:44 PM Changeset in webkit [80177] by dcheng@chromium.org
  • 13 edits in trunk/Source

2011-03-02 Daniel Cheng <​dcheng@chromium.org>

Revert frame-specific WebClipboard changes
​https://bugs.webkit.org/show_bug.cgi?id=55617

This code is no longer needed since we've decided to use the original
approach to copy/paste drag/drop handling in ClipboardChromium.

No new tests because no functionality changes.

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::createReadable):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::create):
  • platform/chromium/PlatformBridge.h:
  • platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::create): (WebCore::ReadableDataObject::ReadableDataObject): (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
  • platform/chromium/ReadableDataObject.h:

2011-03-02 Daniel Cheng <​dcheng@chromium.org>

Revert frame-specific WebClipboard changes
​https://bugs.webkit.org/show_bug.cgi?id=55617

This code is no longer needed since we've decided to use the original
approach to copy/paste drag/drop handling in ClipboardChromium.

  • public/WebFrameClient.h:
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::fromFrame):
  • src/WebFrameImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnterNew):
3:37 PM Changeset in webkit [80176] by mihaip@chromium.org
  • 1 edit
    4 moves in trunk/LayoutTests

2011-03-02 Mihai Parparita <​mihaip@chromium.org>

Unreviewed expectations update.

Promote expectations for fast/table/table-and-parts-outline.html and
svg/css/path-gradient-stroke-shadow.svg from chromium-mac/ to
mac-leopard/ so that 1) the test passes on mac-leopard 2) the test
on chromium-mac-snowlopard (which will now use the mac/ baselines).

  • platform/mac-leopard/fast/table/table-and-parts-outline-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/table/table-and-parts-outline-expected.checksum.
  • platform/mac-leopard/fast/table/table-and-parts-outline-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/table-and-parts-outline-expected.png.
  • platform/mac-leopard/svg/css/path-gradient-stroke-shadow-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/css/path-gradient-stroke-shadow-expected.checksum.
  • platform/mac-leopard/svg/css/path-gradient-stroke-shadow-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/css/path-gradient-stroke-shadow-expected.png.
3:19 PM Changeset in webkit [80175] by Adam Roben
  • 2 edits in trunk/Tools

Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output

This matches DumpRenderTree on Windows.

Fixes <​http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
in WebKit2

Reviewed by Beth Dakin.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Moved code to force a paint here...
(WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.

3:15 PM Changeset in webkit [80174] by tony@chromium.org
  • 4 edits in trunk/Source

2011-03-02 Tony Chang <​tony@chromium.org>

Unreviewed, rolling chromium DEPS to r76362.

​https://bugs.webkit.org/show_bug.cgi?id=55564

  • WebCore.gyp/WebCore.gyp: Switch to libjpeg_turbo to match chromium

2011-03-02 Tony Chang <​tony@chromium.org>

Unreviewed, rolling chromium DEPS to r76362.

​https://bugs.webkit.org/show_bug.cgi?id=55564

  • DEPS:
3:09 PM Changeset in webkit [80173] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • page/ChromeClient.h: (WebCore::ChromeClient::keyboardUIMode): I didn't mean to commit these changes yet.
2:51 PM Changeset in webkit [80172] by ap@apple.com
  • 15 edits in trunk/Source/WebCore

Reviewed by John Sullivan.

Clean up WebCore tabsToLinks code a little
​https://bugs.webkit.org/show_bug.cgi?id=55606

No change in behavior, so no tests.

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isKeyboardFocusable): This is the only caller of tabsToAllControls(). Renamed this function to tabsToAllFormControls().
  • page/EventHandler.cpp: (WebCore::EventHandler::isKeyboardOptionTab): Moved from platform specific files. This function cannot be file static, because EventHandlerMac.mm uses it. (WebCore::eventInvertsTabsToLinksClientCallResult): Merged implementations from platform specific files. We can just as well have #if here. Renamed for clarity. (WebCore::EventHandler::tabsToLinks): Rewrote in a way that makes it clearer how "invert" works.


  • page/EventHandler.h: We no longer need invertSenseOfTabsToLinks() here, it's only used in EventHandler.cpp.
  • page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  • page/brew/EventHandlerBrew.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  • page/efl/EventHandlerEfl.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  • page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToAllFormControls):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::tabsToAllFormControls):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::tabsToAllFormControls): Updating all port files.
2:46 PM Changeset in webkit [80171] by jorlow@chromium.org
  • 37 edits
    3 copies in trunk

2011-02-28 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by James Robinson.

Split IDBCursor.value into IDBCursor.primaryKey and IDBCursor.value
​https://bugs.webkit.org/show_bug.cgi?id=55443

  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:

2011-02-28 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by James Robinson.

Split IDBCursor.value into IDBCursor.primaryKey and IDBCursor.value
​https://bugs.webkit.org/show_bug.cgi?id=55443

Implement ​http://www.w3.org/Bugs/Public/show_bug.cgi?id=11948

The idea is to have an IDBCursor and an IDBCursorWithValue interface which
inherits from the former. index.openKeyCursor will return the former and
index/objectStore.openCursor will return the latter. We'll add a primaryKey
attribute to IDBCursor. It will always be the key of the associated object
store entry. For index.openCursor cursors, the key attribute will be the key
of the index. For objectStore.openCursors, it'll be the same as the
primaryKey. The value will be the value of the objectStore entry.

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::deserializeAndSetProperty):
  • bindings/v8/SerializedScriptValue.h:
  • bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
  • storage/IDBAny.cpp: (WebCore::IDBAny::idbCursorWithValue): (WebCore::IDBAny::set):
  • storage/IDBAny.h:
  • storage/IDBCursor.cpp: (WebCore::IDBCursor::create): (WebCore::IDBCursor::primaryKey): (WebCore::IDBCursor::value):
  • storage/IDBCursor.h:
  • storage/IDBCursor.idl:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::primaryKey): (WebCore::IDBCursorBackendImpl::value): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::currentRowExists): (WebCore::IDBCursorBackendImpl::continueFunctionInternal): (WebCore::IDBCursorBackendImpl::deleteFunction): (WebCore::IDBCursorBackendImpl::loadCurrentRow):
  • storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBCursorWithValue.cpp: Copied from Source/WebCore/storage/IDBCursor.idl. (WebCore::IDBCursorWithValue::create): (WebCore::IDBCursorWithValue::IDBCursorWithValue): (WebCore::IDBCursorWithValue::~IDBCursorWithValue):
  • storage/IDBCursorWithValue.h: Copied from Source/WebCore/storage/IDBCursorBackendInterface.h.
  • storage/IDBCursorWithValue.idl: Copied from Source/WebCore/storage/IDBCursor.idl.
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursorInternal): (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::openKeyCursor):
  • storage/IDBIndexBackendImpl.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::setCursorType): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBRequest.h:

2011-02-28 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by James Robinson.

Split IDBCursor.value into IDBCursor.primaryKey and IDBCursor.value
​https://bugs.webkit.org/show_bug.cgi?id=55443

  • public/WebIDBCursor.h: (WebKit::WebIDBCursor::primaryKey): (WebKit::WebIDBCursor::value):
  • src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::primaryKey): (WebCore::IDBCursorBackendProxy::value):
  • src/IDBCursorBackendProxy.h:
  • src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::key): (WebKit::WebIDBCursorImpl::primaryKey): (WebKit::WebIDBCursorImpl::value):
  • src/WebIDBCursorImpl.h:
2:42 PM Changeset in webkit [80170] by Martin Robinson
  • 5 edits in trunk/LayoutTests

2011-03-02 Martin Robinson <​mrobinson@igalia.com>

Update GTK+ baselines after r80151.

  • platform/gtk/fast/css-generated-content/005-expected.txt:
  • platform/gtk/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
  • platform/gtk/fast/css-generated-content/no-openclose-quote-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
2:40 PM Changeset in webkit [80169] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Reviewed by Csaba Osztrogonác.

Patch by Aravind Akella <​aravind.akella@nokia.com> on 2011-03-02

[Qt][WK2] Memory exhausted when building qtwebkit2 on linux
​https://bugs.webkit.org/show_bug.cgi?id=55484

Using AllInOne files to avoid memory exhaustion for debug
builds on 32 bit linux machines.

No new tests. Fixing a build issue.

  • WebCore.pro:
2:39 PM Changeset in webkit [80168] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <​tonyg@chromium.org>

Unreviewed expectations update

[chromium] plugins/embed-attributes-setting.html is crashy
​https://bugs.webkit.org/show_bug.cgi?id=55616

  • platform/chromium/test_expectations.txt:
2:25 PM Changeset in webkit [80167] by mihaip@chromium.org
  • 1 edit
    8 deletes in trunk/LayoutTests

2011-03-02 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove chromium-gpu-mac/ text expectations mistakenly added by r80163
(tests should pass with mac/ expectations).

  • platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.txt: Removed.
  • platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.txt: Removed.
  • platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.txt: Removed.
  • platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.txt: Removed.
  • platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.txt: Removed.
  • platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.txt: Removed.
  • platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.txt: Removed.
  • platform/chromium-gpu-mac/compositing/self-painting-layers-expected.txt: Removed.
2:23 PM Changeset in webkit [80166] by dcheng@chromium.org
  • 21 edits in trunk

2011-03-02 Daniel Cheng <​dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
​https://bugs.webkit.org/show_bug.cgi?id=55510

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

2011-03-02 Daniel Cheng <​dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
​https://bugs.webkit.org/show_bug.cgi?id=55510

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

2011-03-02 Daniel Cheng <​dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
​https://bugs.webkit.org/show_bug.cgi?id=55510

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • features.pri:

2011-03-02 Daniel Cheng <​dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
​https://bugs.webkit.org/show_bug.cgi?id=55510

  • features.gypi:

2011-03-02 Daniel Cheng <​dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
​https://bugs.webkit.org/show_bug.cgi?id=55510

  • Configurations/FeatureDefines.xcconfig:

2011-03-02 Daniel Cheng <​dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
​https://bugs.webkit.org/show_bug.cgi?id=55510

  • Scripts/build-webkit:

2011-03-02 Daniel Cheng <​dcheng@chromium.org>

Reviewed by David Levin.

Add feature define for data transfer items
​https://bugs.webkit.org/show_bug.cgi?id=55510

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
2:14 PM Changeset in webkit [80165] by tonyg@chromium.org
  • 5 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <​tonyg@chromium.org>

Unreviewed expectations update

[chromium] Expectations update
​https://bugs.webkit.org/show_bug.cgi?id=55615

  • platform/chromium-linux/fast/repaint/control-clip-expected.checksum:
  • platform/chromium-linux/fast/repaint/control-clip-expected.png:
  • platform/chromium-win/fast/repaint/control-clip-expected.checksum:
  • platform/chromium-win/fast/repaint/control-clip-expected.png:
1:56 PM Changeset in webkit [80164] by tonyg@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <​tonyg@chromium.org>

Unreviewed expectations update

[chromium] Expectations to match r80157
​https://bugs.webkit.org/show_bug.cgi?id=55613

  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
1:47 PM Changeset in webkit [80163] by mihaip@chromium.org
  • 46 edits
    124 adds in trunk/LayoutTests

2011-03-02 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Rebaseline Chromium GPU results for Snow Leopard.

  • platform/chromium-gpu-mac/compositing/animation/state-at-end-event-transform-layer-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.checksum:
  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-mac/compositing/compositing-visible-descendant-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/compositing-visible-descendant-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/generated-content-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/generated-content-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.checksum:
  • platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.checksum:
  • platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/geometry/clipping-foreground-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/fixed-in-composited-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/outline-change-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/outline-change-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/partial-layout-update-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/partial-layout-update-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/root-layer-update-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/root-layer-update-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/tall-page-composited-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/tall-page-composited-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.checksum:
  • platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.checksum:
  • platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/iframes/composited-iframe-scroll-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/iframes/composited-iframe-scroll-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/iframes/iframe-content-flipping-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/iframes/iframe-content-flipping-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/iframes/iframe-copy-on-scroll-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/images/direct-image-background-color-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/images/direct-image-background-color-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/images/direct-svg-image-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/images/direct-svg-image-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.checksum:
  • platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.checksum:
  • platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.png:
  • platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.checksum:
  • platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-mac/compositing/masks/multiple-masks-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/masks/simple-composited-mask-expected.checksum:
  • platform/chromium-gpu-mac/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/ancestor-overflow-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/overflow/ancestor-overflow-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.checksum:
  • platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.checksum:
  • platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/parent-overflow-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/overflow/parent-overflow-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.checksum:
  • platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/overflow/scrollbar-painting-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/overflow/scrollbar-painting-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/overflow/zero-size-overflow-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/overflow/zero-size-overflow-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/animation-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/backface-hidden-reflection-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/backface-hidden-reflection-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.checksum:
  • platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.checksum:
  • platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-animated-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-opacity-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-size-change-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-size-change-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/reflection-in-composited-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/reflection-on-composited-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/reflection-on-composited-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/reflection-ordering-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/reflection-positioning-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/reflection-positioning2-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/remove-add-reflection-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/remove-add-reflection-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.checksum:
  • platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.png:
  • platform/chromium-gpu-mac/compositing/repaint/content-into-overflow-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/repaint/content-into-overflow-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/repaint/layer-repaint-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/repaint/layer-repaint-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.checksum:
  • platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.png:
  • platform/chromium-gpu-mac/compositing/repaint/overflow-into-content-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/repaint/overflow-into-content-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/self-painting-layers-expected.checksum:
  • platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-mac/compositing/self-painting-layers-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.checksum:
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-mac/compositing/sibling-positioning-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/sibling-positioning-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.checksum:
  • platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.png:
  • platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.checksum:
  • platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-mac/compositing/transitions/singular-scale-transition-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/transitions/singular-scale-transition-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/webgl/webgl-reflection-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/webgl/webgl-reflection-expected.png: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.checksum:
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium/test_expectations.txt:
1:37 PM Changeset in webkit [80162] by tonyg@chromium.org
  • 4 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <​tonyg@chromium.org>

Unreviewed expectations update.

[chromium] Update expectations to match those in r80151
​https://bugs.webkit.org/show_bug.cgi?id=55610

  • platform/chromium-win/fast/css-generated-content/005-expected.txt:
  • platform/chromium-win/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
  • platform/chromium-win/fast/css-generated-content/no-openclose-quote-expected.txt:
1:33 PM Changeset in webkit [80161] by Adam Roben
  • 2 edits in trunk/Tools

Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer

ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
the former location, but was getting lucky on some SnowLeopard machines because symlinks
were being created there pointing into DiagnosticReports. For machines without these
symlinks, crash logs were not getting captured.

Fixes <​http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
SnowLeopard machines

Reviewed by Eric Seidel.

  • Scripts/old-run-webkit-tests:

(captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.

1:05 PM Changeset in webkit [80160] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-02 Dimitri Glazkov <Dimitri Glazkov>

Update location of media-file.js, which was moved in r79630.

  • manual-tests/media-controls.html: Updated location.
1:02 PM Changeset in webkit [80159] by tonyg@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-03-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80156.
​http://trac.webkit.org/changeset/80156
​https://bugs.webkit.org/show_bug.cgi?id=55604

"Broke SL compile" (Requested by tonyg-cr on #webkit).

  • bridge/jni/JNIBridge.h: (JSC::Bindings::JavaString::operator UString):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember):
  • bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass):
  • bridge/jni/jsc/JavaStringJSC.h: (JSC::Bindings::JavaStringImpl::uString):
  • bridge/jni/v8/JavaStringV8.h:
12:47 PM Changeset in webkit [80158] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Delete old .res files whenever any .vsprops file changes

Prospective fix for <​http://webkit.org/b/55599> r80079 caused incremental Windows builds to
fail

Reviewed by Tony Chang.

(main): Restructured code to loop over a set of file extensions, deleting any old files that
have that extension. Now deletes .res files, too. (We previously deleted any file matching
*.manifest*, but that turned out to just be the union of *.manifest and *.res.)

12:43 PM Changeset in webkit [80157] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <​tonyg@chromium.org>

Unreviewed expectations

Updating expectations after r80151
​https://bugs.webkit.org/show_bug.cgi?id=55601

  • platform/mac/fast/invalid/residual-style-expected.txt:
12:22 PM Changeset in webkit [80156] by steveblock@google.com
  • 6 edits in trunk/Source/WebCore

2011-03-02 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaString API should be implementable by both JSC and V8
​https://bugs.webkit.org/show_bug.cgi?id=55567

Remove JavaString's UString operator and replace it with a
script-engine-independent impl() method, which returns a
StringImpl and can be implemented with both JSC and V8.

No new tests, refactoring only.

  • bridge/jni/JNIBridge.h: (JSC::Bindings::JavaString::impl):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember):
  • bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass):
  • bridge/jni/jsc/JavaStringJSC.h: (JSC::Bindings::JavaStringImpl::impl):
  • bridge/jni/v8/JavaStringV8.h: (JSC::Bindings::JavaStringImpl::impl):
11:56 AM Changeset in webkit [80155] by mihaip@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-02 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Add CRASH() for CSSSelector double frees
​https://bugs.webkit.org/show_bug.cgi?id=55596

To help track down bug 53045, add a CRASH call when the CSSSelector
destructor is invoked more than once.

Just a check, no new tests necessary.

  • css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::~CSSSelector):
11:54 AM Changeset in webkit [80154] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Mihai Parparita <​mihaip@chromium.org>

Unreviewed expectations update.

Add more Snow Leopard-only flakiness.

  • platform/chromium/test_expectations.txt:
11:48 AM Changeset in webkit [80153] by weinig@apple.com
  • 13 edits
    2 adds in trunk/Source/WebKit

Fix remaining localization issues by piping all localized strings through WebCore's
localization bottleneck.
<rdar://problem/8728860>

Reviewed by Anders Carlsson.

../WebKit:

  • WebKit.xcodeproj/project.pbxproj:

../WebKit/mac:

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:

(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):

  • Misc/WebKitErrors.m:
  • Misc/WebLocalizableStringsInternal.h: Added.
  • Misc/WebLocalizableStringsInternal.mm: Added.

(WebLocalizedStringInternal):

  • Panels/WebAuthenticationPanel.m:

(-[WebAuthenticationPanel setUpForChallenge:]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost):

  • WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::updateWindowTitle):
(-[WebInspectorWindowController validateUserInterfaceItem:]):

  • WebCoreSupport/WebKeyGenerator.m:

(-[WebKeyGenerator strengthMenuItemTitles]):
(-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):

  • WebCoreSupport/WebPlatformStrategies.mm:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):

  • WebView/WebPDFView.mm:

(-[WebPDFView menuForEvent:]):

11:45 AM Changeset in webkit [80152] by Adam Roben
  • 2 edits in trunk/Tools

Don't try to capture crash logs on platforms that haven't implemented that feature

Fixes <​http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash

Reviewed by Joseph Pecoraro.

  • Scripts/old-run-webkit-tests:

(captureSavedCrashLog): Bail if we don't have a crash log glob.
(findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
strictly required to fix bug 55504, but seems worthwhile.

11:34 AM Changeset in webkit [80151] by carol.szabo@nokia.com
  • 31 edits
    16 adds in trunk

content property doesn't support quotes
​https://bugs.webkit.org/show_bug.cgi?id=6503

Patch by Carol Szabo <​carol.szabo@nokia.com> on 2011-03-02
Reviewed by David Hyatt <​hyatt@apple.com>

Source/WebCore:

Added full support for quotes as defined by CSS 2.1.

Tests: fast/css/content/content-quotes-01.html

fast/css/content/content-quotes-02.html
fast/css/content/content-quotes-03.html
fast/css/content/content-quotes-04.html
fast/css/content/content-quotes-05.html
fast/css/content/content-quotes-06.html

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseQuotes):

  • css/CSSParser.h:

Added needed stylesheet parsing support for quotes,
(no-)open-quote and (no-)close-quote

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Handled setting of the new quotes RenderStyle property and added
handling of quotes for the content property.

  • css/html.css:

(q:before):
(q:after):
replaced the '"' workaround with open/close-quote

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::dirtyLineBoxesForRenderer):
Made RenderQuote behave like RenderCounter.
Needed to ensure that the Quote text is calculated before layout,
just as it is for RenderCounter.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isQuote):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Handled updating of quote depth when renderers are added and removed
from the tree.
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
Added support for Quote content.

  • rendering/RenderQuote.cpp: Added.

(WebCore::adjustDepth):
(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::renderName):
(WebCore::RenderQuote::placeQuote):
(WebCore::LanguageData::operator<):
(WebCore::defaultLanguageQuotes):
(WebCore::quotesMap):
(WebCore::quotesForLanguage):
(WebCore::defaultQuotes):
(WebCore::RenderQuote::originalText):
(WebCore::RenderQuote::computePreferredLogicalWidths):
(WebCore::RenderQuote::rendererSubtreeAttached):
(WebCore::RenderQuote::rendererRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):

  • rendering/RenderQuote.h: Added.

(WebCore::RenderQuote::isQuote):
(WebCore::toRenderQuote):

  • rendering/RenderingAllInOne.cpp:

Included RenderQuote.cpp

  • rendering/style/StyleAllInOne.cpp:

Included QuotesData.cpp

  • rendering/style/ContentData.cpp:

(WebCore::ContentData::dataEquivalent):
Checked for quotetype identity.
(WebCore::ContentData::deleteContent):
Accounted for the new QUOTE_TYPE.

  • rendering/style/ContentData.h:

(WebCore::ContentData::isQuote):
(WebCore::ContentData::quote):
(WebCore::ContentData::setQuote):

  • rendering/style/QuotesData.cpp: Added.

(WebCore::QuotesData::create):
(WebCore::QuotesData::operator==):
(WebCore::QuotesData::~QuotesData):

  • rendering/style/QuotesData.h: Added.

(WebCore::QuotesData::data):
(WebCore::QuotesData::operator delete):
(WebCore::QuotesData::QuotesData):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setContent):
(WebCore::RenderStyle::setQuotes):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::quotes):
(WebCore::InheritedFlags::setQuotes):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleAllInOne.cpp:

Added QuotesData.cpp to the included files list.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::operator==):
Included quotes in equality check.

  • rendering/style/StyleRareInheritedData.h:

Added quotes

LayoutTests:

Added new tests for quotes. Fixed a few afected expected results.

  • fast/css/content/content-quotes-01-expected.txt: Added.
  • fast/css/content/content-quotes-01.html: Added.
  • fast/css/content/content-quotes-02-expected.txt: Added.
  • fast/css/content/content-quotes-02.html: Added.
  • fast/css/content/content-quotes-03-expected.txt: Added.
  • fast/css/content/content-quotes-03.html: Added.
  • fast/css/content/content-quotes-04-expected.txt: Added.
  • fast/css/content/content-quotes-04.html: Added.
  • fast/css/content/content-quotes-05-expected.txt: Added.
  • fast/css/content/content-quotes-05.html: Added.
  • fast/css/content/content-quotes-06-expected.txt: Added.
  • fast/css/content/content-quotes-06.html: Added.
  • platform/mac/fast/css-generated-content/005-expected.txt:
  • platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
  • platform/mac/fast/css-generated-content/no-openclose-quote-expected.txt:
  • platform/qt/fast/css-generated-content/005-expected.txt:
  • platform/qt/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
  • platform/qt/fast/css-generated-content/no-openclose-quote-expected.txt:
11:08 AM Changeset in webkit [80150] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

Selector usage flags should not be set by the CSS parser
​https://bugs.webkit.org/show_bug.cgi?id=55573

Reviewed by Dave Hyatt.

Currently flags like Document::usesSiblingRules() are set directly by the CSS parser. This is wrong as
we may parse stylesheets that are not actually used for document rendering. This is especially bad when
the page uses querySelectorAll(). As a result we may end up in various performance penalty boxes
triggered by complex selectors for no good reason.

  • Use the selector traversal in style selector constructor to figure out which flags are actually needed for the currently active style sheets.
  • Remove the selector flag related code from the CSS parser/grammar.
  • Remove the usesDescendantRules flag completely. We have descendant rules in the default style sheet, every document uses them.
  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::updateSpecifiersWithElementName):

  • css/CSSStyleSelector.cpp:

(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::Features::Features):
(WebCore::CSSStyleSelector::Features::~Features):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::collectFeaturesFromSelector):
(WebCore::collectFeaturesFromList):
(WebCore::RuleSet::collectFeatures):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::usesSiblingRules):
(WebCore::CSSStyleSelector::usesFirstLineRules):
(WebCore::CSSStyleSelector::usesBeforeAfterRules):
(WebCore::CSSStyleSelector::usesLinkRules):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):

  • dom/Document.h:

(WebCore::Document::usesSiblingRules):
(WebCore::Document::setUsesSiblingRules):
(WebCore::Document::usesFirstLineRules):
(WebCore::Document::usesBeforeAfterRules):
(WebCore::Document::setUsesBeforeAfterRules):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

10:57 AM Changeset in webkit [80149] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit/wince

WinCE build fix.

  • WebCoreSupport/PlatformStrategiesWinCE.h: Add a needed include.
10:52 AM Changeset in webkit [80148] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Tony Gentilcore <​tonyg@chromium.org>

Unreviewed expectations update

[chromium] svg/text/font-size-below-point-five.svg doesn't pass on mac release
​https://bugs.webkit.org/show_bug.cgi?id=55593

  • platform/chromium/test_expectations.txt:
10:52 AM Changeset in webkit [80147] by bweinstein@apple.com
  • 3 edits in trunk/Source/WebKit/wince

WinCE build fix. Have PlatformStrategiesWinCE inherit from CookiesStrategy,
and implement the needed methods.

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::createCookiesStrategy):
(PlatformStrategiesWinCE::notifyCookiesChanged):

  • WebCoreSupport/PlatformStrategiesWinCE.h:
10:46 AM Changeset in webkit [80146] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

Fix fallout from a last minute renaming.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):

10:44 AM Changeset in webkit [80145] by bweinstein@apple.com
  • 21 edits
    1 add in trunk/Source

Source/WebCore: Part of WebKit2: Need a way to send notifications to client when cookies change
​https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add functions on CookieStorage that allow listening for changes in cookies. When
the cookies are changed, they call through to CookiesStrategy::notifyCookiesChanged.

No change in behavior requiring tests.

  • platform/CookiesStrategy.h: Added.

(WebCore::CookiesStrategy::~CookiesStrategy):

  • platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::cookiesStrategy):
(WebCore::PlatformStrategies::PlatformStrategies):

  • platform/network/CookieStorage.h: Add new function declarations.
  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::notifyCookiesChangedOnMainThread): Call through to CookiesStrategy::notifyCookiesChanged.
(WebCore::notifyCookiesChanged): Call notifyCookiesChangedOnMainThread on the main thread.
(WebCore::beginObservingCookieChanges): Set up cookie observers on the loader run loop.
(WebCore::finishObservingCookieChanges): Remove our cookie observers from the loader run loop.

  • platform/network/mac/CookieStorageMac.mm:

(-[CookieStorageObjCAdapter notifyCookiesChangedOnMainThread]): Call through to CookiesStrategy::notifyCookiesChanged.
(-[CookieStorageObjCAdapter cookiesChangedNotificationHandler:]): Call notifyCookiesChangedOnMainThread on

the main thread.

(-[CookieStorageObjCAdapter registerForCookieChangeNotifications]): Set up the observer for cookie change notifications.
(-[CookieStorageObjCAdapter unregisterForCookieChangeNotifications]): Remove the observer for cookie change notifications.
(WebCore::beginObservingCookieChanges): Create our CookieStorageObjCAdapter, and call registerForCookieChangeNotifications.
(WebCore::finishObservingCookieChanges): Call unregisterForCookieChangeNotifications.

Add new file.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Set role on files we need to include in WebKit to private.

Source/WebKit/mac: Part of WebKit2: Need a way to send notifications to client when cookies change
​https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add stubs for CookiesStrategy on Mac WebKit1.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::createCookiesStrategy):
(WebPlatformStrategies::notifyCookiesChanged):

Source/WebKit/qt: Part of WebKit2: Need a way to send notifications to client when cookies change
​https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add stubs for CookiesStrategy on Qt WebKit1.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::createCookiesStrategy):
(WebPlatformStrategies::notifyCookiesChanged):

  • WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit/win: Part of WebKit2: Need a way to send notifications to client when cookies change
​https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add stubs for CookiesStrategy on Windows WebKit1.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::createCookiesStrategy):
(WebPlatformStrategies::notifyCookiesChanged):

  • WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit2: Part of WebKit2: Need a way to send notifications to client when cookies change
​https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::dispatchDidModifyCookies): Add a stub with a FIXME to send a

message to the UI process.

  • WebProcess/Cookies/WebCookieManager.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::createCookiesStrategy):
(WebKit::WebPlatformStrategies::notifyCookiesChanged): Call WebCookieManager::dispatchDidModifyCookies.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
10:42 AM Changeset in webkit [80144] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-02 Sergey Glazunov <​serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

A WebKitCSSKeyframesRule object should set itself as the parent for inserted rules
​https://bugs.webkit.org/show_bug.cgi?id=55488

Test: fast/css/css-keyframe-parent.html

  • css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::append):

2011-03-02 Sergey Glazunov <​serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

A WebKitCSSKeyframesRule object should set itself as the parent for inserted rules
​https://bugs.webkit.org/show_bug.cgi?id=55488

  • fast/css/css-keyframe-parent-expected.txt: Added.
  • fast/css/css-keyframe-parent.html: Added.
10:03 AM Changeset in webkit [80143] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-02 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add support for external protocol handlers
​https://bugs.webkit.org/show_bug.cgi?id=55473

Do not unconditionally create and replace the SoupRequester of the
SoupSession if there is already one. No new tests needed as we
just allow clients to create their our SoupRequesters.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):
9:50 AM Changeset in webkit [80142] by jknotten@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-02 John Knottenbelt <​jknotten@chromium.org>

Reviewed by ​jknotten@chromium.org.

Fix build-breakage when GEOLOCATION not enabled.
​https://bugs.webkit.org/show_bug.cgi?id=55586

Geolocation::reset needs to be defined if ENABLE(GEOLOCATION)
is not true.

  • page/Geolocation.cpp: (WebCore::Geolocation::reset):
9:39 AM Changeset in webkit [80141] by pfeldman@chromium.org
  • 18 edits in trunk/Source/WebCore

2011-03-02 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove InjectedScriptHost -> DOMAgent dependency.
​https://bugs.webkit.org/show_bug.cgi?id=55575

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::inspectedNode):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluateOn): (WebCore::InjectedScript::wrapObject): (WebCore::InjectedScript::wrapNode): (WebCore::InjectedScript::inspectNode): (WebCore::InjectedScript::nodeAsScriptValue):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::addInspectedNode): (WebCore::InjectedScriptHost::clearInspectedNodes): (WebCore::InjectedScriptHost::copyText): (WebCore::InjectedScriptHost::inspectedNode):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::addInspectedNode): (WebCore::InspectorDOMAgent::resolveNode): (WebCore::InspectorDOMAgent::injectedScriptForNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluateOn):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved): (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady): (WebInspector.PropertiesSidebarPane.prototype.update.fillSection): (WebInspector.PropertiesSidebarPane.prototype.update):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.resolveNode): (WebInspector.RemoteObject.prototype.pushNodeToFrontend): (WebInspector.RemoteObject.prototype.evaluate):
9:28 AM Changeset in webkit [80140] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add some new tests to the WebKit2 Skipped file

  • platform/mac-wk2/Skipped:
9:15 AM Changeset in webkit [80139] by jknotten@chromium.org
  • 32 edits
    9 adds in trunk

2011-02-16 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Dmitry Titov.

Detach Geolocation from Frame when Page destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=52877

Ensure that all geolocation permission requests are cancelled
when the page is detached from its frame.

  • fast/dom/Geolocation/iframe-reparent-expected.txt: Added.
  • fast/dom/Geolocation/iframe-reparent.html: Added.
  • fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added.
  • fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added.
  • fast/dom/Geolocation/resources/iframe-reparent-page-iframe.html: Added.
  • fast/dom/Geolocation/resources/iframe-reparent-page.html: Added.
  • fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added.
  • fast/dom/Geolocation/script-tests/iframe-reparent.js: Added. (window2Loaded): (firstWatchUpdate): (secondWatchUpdate): (firstWatchError): (secondWatchError): (maybeFinish):
  • fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added.
  • platform/gtk/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:

2011-01-21 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Dmitry Titov.

Detach Geolocation from Frame when Page destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=52877

On Page destruction, any outstanding Geolocation permission
requests should be cancelled, because the Geolocation can only
access the client indirectly via m_frame->page().

Additionally, if the Frame is reparented to another page, the
Geolocation should cancel watches, single-shots and requests on
the old page.

Page destruction is signalled by a call to the
Frame::pageDestroyed() method. This calls Frame::detachFromPage,
where we extend the call chain to Geolocation::detachFromPage()
where we call Geolocation::reset() which detaches from the
GeolocationController, cancels requests, watches and single shots,
and sets the permission state back to Unknown.

We also now call detachFromPage when the frame reparented in
Frame::transferChildFrameToNewDocument.

Frame::pageDestroyed() is also called by FrameLoader even though
the page is not destroyed. We should still cancel permission
requests, because the GeolocationClient will become inaccessible
to the Geolocation object after this call.

Since GeolocationController is owned by Page, and all Geolocation
objects will now unsubscribe from the GeolocationController on
pageDetached(), we no longer need to call stopUpdating() from the
GeolocationController's destructor. Instead we can simply assert
that there should be no no observers. See related bug
​https://bugs.webkit.org/show_bug.cgi?id=52216 .

Introduced new method 'numberOfPendingPermissionRequests' on
GeolocationClientMock to count the number of outstanding pending
permission requests. This provides a reusable implementation for
client-based implementations of the LayoutTestController's
numberOfPendingGeolocationPermissionRequests method.

Tests: fast/dom/Geolocation/iframe-reparent.html

fast/dom/Geolocation/page-reload-cancel-permission-requests.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::resetGeolocationPermissions):
  • page/DOMWindow.h:
  • page/Frame.cpp: (WebCore::Frame::detachFromPage): (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument):
  • page/Frame.h:
  • page/Geolocation.cpp: (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::page): (WebCore::Geolocation::reset): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::startUpdating): (WebCore::Geolocation::stopUpdating):
  • page/Geolocation.h:
  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
  • page/Navigator.cpp: (WebCore::Navigator::resetGeolocationPermissions):
  • page/Navigator.h:
  • platform/mock/GeolocationClientMock.cpp: (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
  • platform/mock/GeolocationClientMock.h:

2011-01-26 John Knottenbelt <​jknotten@chromium.org>

Detach Geolocation from Frame when Page destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=52877

Add accessors to the WebGeolocationClientMock to allow the number of
pending geolocation permission requests to be queried.

  • public/WebGeolocationClientMock.h:
  • src/WebGeolocationClientMock.cpp: (WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests):

2011-01-26 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Dmitry Titov.

Detach Geolocation from Frame when Page destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=52877

Extend the layout test controller to expose the number of pending
geolocation requests, so that we can test that the requests have
been cancelled on page close.

  • DumpRenderTree/LayoutTestController.cpp: (numberOfPendingGeolocationPermissionRequestsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/mac/UIDelegate.h:
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
9:11 AM Changeset in webkit [80138] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-03-02 Martin Maly <​mmaly@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Expectation updates for strict mode V8 features.
​https://bugs.webkit.org/show_bug.cgi?id=55538

  • platform/chromium/fast/js/mozilla/strict/15.10.7-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/15.3.5.1-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/15.5.5.1-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
9:04 AM Changeset in webkit [80137] by antonm@chromium.org
  • 6 edits in trunk/LayoutTests/platform/chromium-mac/fast/blockflow

Unreviewed. Another rebaseline.

  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png
8:57 AM Changeset in webkit [80136] by Philippe Normand
  • 3 edits in trunk/Source/WebKit/mac

2011-03-01 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] support in mac video fullscreen controller
​https://bugs.webkit.org/show_bug.cgi?id=52280

Factored the code to configure the video overlay in a new private
method of the controller and added GStreamer support to it.

  • WebView/WebVideoFullscreenController.h:
  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController setupVideoOverlay:]): (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]): (-[WebVideoFullscreenController windowDidExitFullscreen]):
8:45 AM Changeset in webkit [80135] by mnaganov@chromium.org
  • 17 edits
    1 add in trunk/Source/WebCore

2011-03-02 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Landing detailed heap snapshots, part 4.
​https://bugs.webkit.org/show_bug.cgi?id=55563

This part adds implementations for data grids used to display
different heap snapshots projections. We are almost done.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • bindings/v8/ScriptHeapSnapshot.cpp: (WebCore::ScriptHeapSnapshot::getExactRetainedSize):
  • bindings/v8/ScriptHeapSnapshot.h:
  • inspector/Inspector.idl:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
  • inspector/InspectorProfilerAgent.h:
  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotObjectNode): (WebInspector.HeapSnapshotObjectNode.prototype._createProvider): (WebInspector.HeapSnapshotInstanceNode): (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider): (WebInspector.HeapSnapshotDominatorObjectNode): (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider): (MixInSnapshotNodeFunctions):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotContainmentDataGrid): (WebInspector.HeapSnapshotSortableDataGrid): (WebInspector.HeapSnapshotConstructorsDataGrid): (WebInspector.HeapSnapshotDiffDataGrid): (WebInspector.HeapSnapshotDominatorsDataGrid): (WebInspector.HeapSnapshotRetainingPathsList): (WebInspector.DetailedHeapshotView.profileCallback): (WebInspector.DetailedHeapshotView):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotEdge.prototype.get isInvisible): (WebInspector.HeapSnapshotEdge.prototype.toString): (WebInspector.HeapSnapshot.prototype._init): (WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes): (WebInspector.HeapSnapshot.prototype._markInvisibleEdges): (WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):
  • inspector/front-end/Images/helpButtonGlyph.png: Added.
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.reset):
  • inspector/front-end/Popover.js: (WebInspector.Popover): (WebInspector.Popover.prototype.show): (WebInspector.Popover.prototype.hide): (WebInspector.Popover.prototype.get visible):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset): (WebInspector.ProfilesPanel.prototype.getProfile):
  • inspector/front-end/heapProfiler.css:
  • inspector/front-end/inspector.js: (WebInspector.resetFocusElement):
8:33 AM Changeset in webkit [80134] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/StylesSidebarPane.js

Merge 76941 - 2011-01-28 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [STYLES] Up/Down-suggestion breaks an existing keyword
​https://bugs.webkit.org/show_bug.cgi?id=53295

Select the current word suffix before switching to the next suggestion.

  • inspector/front-end/StylesSidebarPane.js: ():

TBR=​apavlov@chromium.org
Review URL: ​http://codereview.chromium.org/6591106

8:30 AM Changeset in webkit [80133] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Ryosuke Niwa <​rniwa@webkit.org>

Yet another unreviewed Chromium rebaselines for r80121.

  • platform/chromium-win/editing/pasteboard/subframe-dragndrop-1-expected.txt:
8:14 AM Changeset in webkit [80132] by rniwa@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

2011-03-02 Ryosuke Niwa <​rniwa@webkit.org>

Another unreviewed Chromium rebaselines for r80121.

  • platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt: Added.
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium/test_expectations.txt:
8:01 AM Changeset in webkit [80131] by abecsi@webkit.org
  • 4 edits in trunk

2011-03-02 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt][WK2] generate-forwarding-headers.pl should generate paths with framework names
​https://bugs.webkit.org/show_bug.cgi?id=55478

On case insensitive systems the generated forwarding headers cause build problems.

  • Source/WebKit.pri: Adjust INCLUDEPATH for the project.

2011-03-02 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt][WK2] generate-forwarding-headers.pl should generate paths with framework names
​https://bugs.webkit.org/show_bug.cgi?id=55478

On case insensitive systems the generated forwarding headers cause build problems.

  • Scripts/generate-forwarding-headers.pl: The generated header should also contain the framework name.
7:54 AM Changeset in webkit [80130] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a crashing test on Windows

<​http://webkit.org/b/55069> tracks the failure.

  • platform/win/Skipped: Added fast/text/international/text-combine-parser-test.html.
7:44 AM Changeset in webkit [80129] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed.

Assertion failure after removing a selection in keydown handler
​https://bugs.webkit.org/show_bug.cgi?id=51389

Remove unnecessary Qt specific expected result.

  • platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Removed.
7:36 AM Changeset in webkit [80128] by rniwa@webkit.org
  • 161 edits in trunk/LayoutTests

2011-03-02 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium rebaselines for r80121; Added the failing expectation for
editing/input/setting-input-value-cancel-ime-composition.html due to the bug 55560.

  • platform/chromium/test_expectations.txt:
  • platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt: Updated.
  • platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt: Ditto.
  • platform/chromium-win/editing/ [...]: Ditto.
7:07 AM Changeset in webkit [80127] by rniwa@webkit.org
  • 163 edits in trunk/LayoutTests

2011-03-02 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed GTK rebaselines for r80121; Also skip editing/input/setting-input-value-cancel-ime-composition.html
because GTK port doesn't implement textInputController.hasMarkedText().

  • platform/gtk/Skipped:
  • platform/gtk/editing/ [...]: Updated.
  • platform/gtk/fast/dom/delete-contents-expected.txt: Ditto.
7:01 AM Changeset in webkit [80126] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Try to force a clean build on the Windows bots

Some of the bots are running into bogus linker errors due to MSVC's "minimal rebuild"
feature not rebuilding files it should. See <​http://queues.webkit.org/results/8076907> for
an example.

  • win/tools/vsprops/common.vsprops: Touched to force a rebuild.
6:52 AM Changeset in webkit [80125] by jeffm@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-01 Jeff Miller <​jeffm@apple.com>

Reviewed by Darin Adler.

Expose some selection state fields in WKPage
​https://bugs.webkit.org/show_bug.cgi?id=55541


Added WKPageCanDelete(), WKPageHasSelectedRange(), and WKPageIsContentEditable() so we can enable some
Edit menu items properly on Windows when using WebKit2.

  • UIProcess/API/C/WKPage.cpp: (WKPageCanDelete): Added. (WKPageHasSelectedRange): Added. (WKPageIsContentEditable): Added.
  • UIProcess/API/C/WKPage.h: Added new functions.
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::canDelete): Added. (WebKit::WebPageProxy::hasSelectedRange): Added. (WebKit::WebPageProxy::isContentEditable): Added.
6:47 AM Changeset in webkit [80124] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/55534> Clean up macros in Extensions3DOpenGL.cpp

Reviewed by Darin Adler.

Change "#if GL_APPLE_vertex_array_object" macros to check that
GL_APPLE_vertex_array_object is both defined and non-zero.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES): Remove
empty #else clause.
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES): Add early
return check. Remove #else clause that would never have
compiled (since array is not a WTF::String).

6:45 AM Changeset in webkit [80123] by Csaba Osztrogonác
  • 143 edits
    13 copies
    123 adds in trunk/LayoutTests

Unreviewed.

Assertion failure after removing a selection in keydown handler
​https://bugs.webkit.org/show_bug.cgi?id=51389

Update Qt specific expected results after r80121.

  • platform/qt/Skipped: Add editing/input/setting-input-value-cancel-ime-composition.html because of missing feature.
  • platform/qt/editing/ [...] : Updated.
6:40 AM Changeset in webkit [80122] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip new test added in r80121 on Windows

It depends on textInputController, which DRT doesn't have on Windows.

  • platform/win/Skipped: Added editing/input/setting-input-value-cancel-ime-composition.html.
5:57 AM Changeset in webkit [80121] by rniwa@webkit.org
  • 189 edits
    2 adds in trunk

2011-03-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Assertion failure after removing a selection in keydown handler
​https://bugs.webkit.org/show_bug.cgi?id=51389

Added tests to ensure WebKit updates offset properly when deleting date
to editing/selection/character-data-mutation.html.

Added a test to ensure WebKit clears composition marks inside an input
element when the value is set programatically.

Many tests are rebaselined due to selection changed caused by the patch
and additional respondToChangedSelection calls.

  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • editing/deleting/delete-by-word-001-expected.txt:
  • editing/deleting/delete-by-word-002-expected.txt:
  • editing/deleting/delete-ligature-001-expected.txt:
  • editing/deleting/delete-ligature-002-expected.txt:
  • editing/deleting/delete-ligature-003-expected.txt:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/deleting/skip-virama-001-expected.txt:
  • editing/execCommand/createLink-expected.txt:
  • editing/execCommand/hilitecolor-expected.txt:
  • editing/execCommand/outdent-nested-lists-1-expected.txt:
  • editing/execCommand/unlink-expected.txt:
  • editing/input/setting-input-value-cancel-ime-composition-expected.txt: Added.
  • editing/input/setting-input-value-cancel-ime-composition.html: Added.
  • editing/inserting/insert-thai-characters-001-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/pasteboard/paste-into-anchor-text-expected.txt:
  • editing/selection/character-data-mutation-expected.txt:
  • editing/selection/character-data-mutation.html:
  • editing/style/remove-underline-from-stylesheet-expected.txt:
  • editing/style/style-3690704-fix-expected.txt:
  • editing/style/typing-style-003-expected.txt:
  • editing/undo/redo-style-expected.txt:
  • platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt:
  • platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3608430-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3608445-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3775172-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3800834-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3857753-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3928305-fix-expected.txt:
  • platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
  • platform/mac/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-and-undo-expected.txt:
  • platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
  • platform/mac/editing/deleting/delete-block-table-expected.txt:
  • platform/mac/editing/deleting/delete-br-007-expected.txt:
  • platform/mac/editing/deleting/delete-character-001-expected.txt:
  • platform/mac/editing/deleting/delete-hr-expected.txt:
  • platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/mac/editing/deleting/delete-listitem-001-expected.txt:
  • platform/mac/editing/deleting/delete-listitem-002-expected.txt:
  • platform/mac/editing/deleting/delete-selection-001-expected.txt:
  • platform/mac/editing/deleting/delete-tab-001-expected.txt:
  • platform/mac/editing/deleting/delete-tab-002-expected.txt:
  • platform/mac/editing/deleting/delete-tab-003-expected.txt:
  • platform/mac/editing/deleting/delete-tab-004-expected.txt:
  • platform/mac/editing/deleting/delete-trailing-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-003-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-004-expected.txt:
  • platform/mac/editing/deleting/forward-delete-expected.txt:
  • platform/mac/editing/deleting/list-item-1-expected.txt:
  • platform/mac/editing/deleting/paragraph-in-preserveNewline-expected.txt:
  • platform/mac/editing/deleting/whitespace-pre-1-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/execCommand/insertHorizontalRule-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/execCommand/paste-2-expected.txt:
  • platform/mac/editing/input/5576619-expected.txt:
  • platform/mac/editing/input/emacs-ctrl-o-expected.txt:
  • platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
  • platform/mac/editing/input/text-input-controller-expected.txt:
  • platform/mac/editing/inserting/4278698-expected.txt:
  • platform/mac/editing/inserting/editing-empty-divs-expected.txt:
  • platform/mac/editing/inserting/insert-3654864-fix-expected.txt:
  • platform/mac/editing/inserting/insert-3851164-fix-expected.txt:
  • platform/mac/editing/inserting/insert-after-delete-001-expected.txt:
  • platform/mac/editing/inserting/insert-br-003-expected.txt:
  • platform/mac/editing/inserting/insert-br-006-expected.txt:
  • platform/mac/editing/inserting/insert-br-007-expected.txt:
  • platform/mac/editing/inserting/insert-br-008-expected.txt:
  • platform/mac/editing/inserting/insert-br-009-expected.txt:
  • platform/mac/editing/inserting/insert-br-at-tabspan-002-expected.txt:
  • platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
  • platform/mac/editing/inserting/insert-div-003-expected.txt:
  • platform/mac/editing/inserting/insert-div-006-expected.txt:
  • platform/mac/editing/inserting/insert-div-007-expected.txt:
  • platform/mac/editing/inserting/insert-div-008-expected.txt:
  • platform/mac/editing/inserting/insert-div-024-expected.txt:
  • platform/mac/editing/inserting/insert-div-025-expected.txt:
  • platform/mac/editing/inserting/insert-space-in-empty-doc-expected.txt:
  • platform/mac/editing/inserting/insert-tab-003-expected.txt:
  • platform/mac/editing/inserting/insert-text-at-tabspan-001-expected.txt:
  • platform/mac/editing/inserting/insert-text-at-tabspan-002-expected.txt:
  • platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
  • platform/mac/editing/inserting/multiple-lines-selected-expected.txt:
  • platform/mac/editing/inserting/paragraph-separator-03-expected.txt:
  • platform/mac/editing/inserting/redo-expected.txt:
  • platform/mac/editing/inserting/return-key-with-selection-003-expected.txt:
  • platform/mac/editing/inserting/typing-001-expected.txt:
  • platform/mac/editing/inserting/typing-002-expected.txt:
  • platform/mac/editing/inserting/typing-003-expected.txt:
  • platform/mac/editing/inserting/typing-around-br-001-expected.txt:
  • platform/mac/editing/inserting/typing-around-image-001-expected.txt:
  • platform/mac/editing/pasteboard/4076267-2-expected.txt:
  • platform/mac/editing/pasteboard/4076267-3-expected.txt:
  • platform/mac/editing/pasteboard/4076267-expected.txt:
  • platform/mac/editing/pasteboard/4700297-expected.txt:
  • platform/mac/editing/pasteboard/8145-3-expected.txt:
  • platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
  • platform/mac/editing/pasteboard/cut-text-001-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/pasteboard/interchange-newline-1-expected.txt:
  • platform/mac/editing/pasteboard/interchange-newline-2-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-1-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-2-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-3-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-4-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-5-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-list-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-table-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-pre-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-pre-002-expected.txt:
  • platform/mac/editing/pasteboard/paste-table-003-expected.txt:
  • platform/mac/editing/pasteboard/paste-table-cells-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-002-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-003-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-004-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-005-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-008-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-009-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-019-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/mac/editing/pasteboard/paste-xml-expected.txt:
  • platform/mac/editing/pasteboard/pasting-object-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-006-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/mac/editing/selection/replace-selection-1-expected.txt:
  • platform/mac/editing/selection/select-all-iframe-expected.txt:
  • platform/mac/editing/spelling/spelling-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-002-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-003-expected.txt:
  • platform/mac/editing/style/smoosh-styles-001-expected.txt:
  • platform/mac/editing/style/style-3681552-fix-001-expected.txt:
  • platform/mac/editing/style/style-3681552-fix-002-expected.txt:
  • platform/mac/editing/style/style-boundary-002-expected.txt:
  • platform/mac/editing/style/style-boundary-003-expected.txt:
  • platform/mac/editing/style/style-boundary-005-expected.txt:
  • platform/mac/editing/style/typing-style-001-expected.txt:
  • platform/mac/editing/style/typing-style-002-expected.txt:
  • platform/mac/editing/style/unbold-in-bold-expected.txt:
  • platform/mac/editing/undo/4063751-expected.txt:
  • platform/mac/editing/undo/redo-typing-001-expected.txt:
  • platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-combined-delete-expected.txt:
  • platform/mac/editing/undo/undo-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-delete-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-expected.txt:
  • platform/mac/editing/undo/undo-misspellings-expected.txt:
  • platform/mac/editing/undo/undo-typing-001-expected.txt:
  • platform/mac/editing/unsupported-content/list-type-after-expected.txt:
  • platform/mac/editing/unsupported-content/list-type-before-expected.txt:
  • platform/mac/editing/unsupported-content/table-type-after-expected.txt:
  • platform/mac/editing/unsupported-content/table-type-before-expected.txt:
  • platform/mac/fast/dom/delete-contents-expected.txt:

2011-03-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Assertion failure after removing a selection in keydown handler
​https://bugs.webkit.org/show_bug.cgi?id=51389

The bug was caused by textWillBeReplaced's not always updating selection, and
shouldRemovePositionAfterAdoptingTextReplacement's not moving the end offset when it's
at the end of replaced data.

Fixed the bug by always updating selection in textWillBeReplaced and fixing the condition
to move the offset in shouldRemovePositionAfterAdoptingTextReplacement. Also added a call
to setSelection instead of directly modifying m_selection to notify all the clients.
Namely, the call to EditorClient::respondToChangedSelection is required for
setting-input-value-cancel-ime-composition.html.

Note that we must update layout before calling setSelection because setSelection calls
setFocusedNodeIfNeeded and it requires layout to be up-to-date. Without this call, tests
such as fast/forms/input-appearance-maxlength.html hits an assertion in Node::isFocusable.

Test: editing/input/setting-input-value-cancel-ime-composition.html

  • editing/SelectionController.cpp: (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): When replacing text, the offset of the selection end must be updated even if it was at the end of the replaced text. e.g. removing "world" from "hello world] WebKit" should result in "hello ] WebKit" not "hello WebK[it". Note we don't move the offset if no text is removed because appending "world" to "hello ]" should result in "hello ]world" not "hello world]". (WebCore::SelectionController::textWillBeReplaced): Calls setSelection to update the selection instead of modifying m_selection directly.
5:48 AM Changeset in webkit [80120] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

Replaced 2 tests in GTK Skipped list that were skipped by mistake
by the ones that are actually failing.

  • platform/gtk/Skipped:
5:46 AM Changeset in webkit [80119] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-02 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: highlighted line does not span horizonally in scripts panel while debugging.
​https://bugs.webkit.org/show_bug.cgi?id=54675

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._syncScroll): (WebInspector.TextEditorChunkedPanel.prototype._buildChunks): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorGutterPanel): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly): (WebInspector.TextEditorMainPanel.prototype._getSelection): (WebInspector.TextEditorMainPanel.prototype._selectionToPosition): (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
  • inspector/front-end/textViewer.css: (.inner-container):
5:42 AM Changeset in webkit [80118] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/StylesSidebarPane.js

Merge 76913 - 2011-01-27 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [STYLES] Cancelled suggestion of a property name results in a visual artifact
​https://bugs.webkit.org/show_bug.cgi?id=53242

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):

TBR=​apavlov@chromium.org
Review URL: ​http://codereview.chromium.org/6596106

5:14 AM Changeset in webkit [80117] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; added the missing blank line at the end.

  • platform/qt/http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
5:10 AM WebKit Team edited by andreas.kling@nokia.com
(diff)
5:02 AM WebKit Team edited by benjamin.poulain@nokia.com
(diff)
5:02 AM Changeset in webkit [80116] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-02 Oleg Romashin <​romaxa@gmail.com>

Reviewed by Andreas Kling.

Fixing inspector compilation with JAVASCRIPT_DEBUGGER disabled
​https://bugs.webkit.org/show_bug.cgi?id=55477

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::populateScriptObjects):
5:00 AM Changeset in webkit [80115] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

Adding 3 new tests to the skipped list waiting for better viewport
error/warning messages.

  • platform/gtk/Skipped:
4:41 AM Changeset in webkit [80114] by rniwa@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-02 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Qt rebaselines for r80061.

  • platform/qt/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
4:35 AM Changeset in webkit [80113] by sergio@webkit.org
  • 3 edits in trunk/LayoutTests

2011-03-02 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

Rebaseline after r80061 and r80107.

  • platform/gtk/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt:
  • platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
4:27 AM Changeset in webkit [80112] by Csaba Osztrogonác
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed.

REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
​https://bugs.webkit.org/show_bug.cgi?id=55323

Add Qt specific expected result for test introduced in r79934.

  • platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.checksum: Added.
  • platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.
  • platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Added.
4:18 AM Changeset in webkit [80111] by antonm@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

And another attempt to do proper GPU override.

  • platform/chromium/test_expectations.txt
3:55 AM Changeset in webkit [80110] by antonm@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Another attempt to propertly rebaseling GPU variant of fast/canvas/canvas-strokePath-gradient-shadow.html

  • platform/chromium/test_expectations.txt
3:48 AM Changeset in webkit [80109] by antonm@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests/platform

Unreviewed. Rebaselining for Chromium after ​http://trac.webkit.org/changeset/80061/

  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt
  • platform/chromium-win/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt
3:45 AM Changeset in webkit [80108] by antonm@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Remove invalid suppression.

  • platform/chromium/test_expectations.txt
3:42 AM Changeset in webkit [80107] by sergio@webkit.org
  • 61 edits
    12 adds in trunk/LayoutTests

2011-03-02 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed expectations update. This is a follow-up to r80061.

Viewport tests were expected to produce new error, warning,
and tip console messages. The current output is correct,
but many of the warnings are wrong. Fixing the incorrect
warnings will be handled by:
​https://bugs.webkit.org/show_bug.cgi?id=53707

There are also a number of xsl tests that have extra warnings
in qt when "Running an XSL-T 1.0 stylesheet with a 2.0 processor".
These tests now have qt platform specific results.

  • fast/viewport/viewport-100-expected.txt:
  • fast/viewport/viewport-101-expected.txt:
  • fast/viewport/viewport-102-expected.txt:
  • fast/viewport/viewport-103-expected.txt:
  • fast/viewport/viewport-112-expected.txt:
  • fast/viewport/viewport-115-expected.txt:
  • fast/viewport/viewport-116-expected.txt:
  • fast/viewport/viewport-117-expected.txt:
  • fast/viewport/viewport-121-expected.txt:
  • fast/viewport/viewport-122-expected.txt:
  • fast/viewport/viewport-125-expected.txt:
  • fast/viewport/viewport-129-expected.txt:
  • fast/viewport/viewport-29-expected.txt:
  • fast/viewport/viewport-30-expected.txt:
  • fast/viewport/viewport-31-expected.txt:
  • fast/viewport/viewport-32-expected.txt:
  • fast/viewport/viewport-35-expected.txt:
  • fast/viewport/viewport-36-expected.txt:
  • fast/viewport/viewport-38-expected.txt:
  • fast/viewport/viewport-39-expected.txt:
  • fast/viewport/viewport-40-expected.txt:
  • fast/viewport/viewport-41-expected.txt:
  • fast/viewport/viewport-42-expected.txt:
  • fast/viewport/viewport-43-expected.txt:
  • fast/viewport/viewport-44-expected.txt:
  • fast/viewport/viewport-46-expected.txt:
  • fast/viewport/viewport-47-expected.txt:
  • fast/viewport/viewport-48-expected.txt:
  • fast/viewport/viewport-49-expected.txt:
  • fast/viewport/viewport-52-expected.txt:
  • fast/viewport/viewport-53-expected.txt:
  • fast/viewport/viewport-54-expected.txt:
  • fast/viewport/viewport-55-expected.txt:
  • fast/viewport/viewport-61-expected.txt:
  • fast/viewport/viewport-62-expected.txt:
  • fast/viewport/viewport-63-expected.txt:
  • fast/viewport/viewport-64-expected.txt:
  • fast/viewport/viewport-66-expected.txt:
  • fast/viewport/viewport-67-expected.txt:
  • fast/viewport/viewport-68-expected.txt:
  • fast/viewport/viewport-69-expected.txt:
  • fast/viewport/viewport-70-expected.txt:
  • fast/viewport/viewport-71-expected.txt:
  • fast/viewport/viewport-72-expected.txt:
  • fast/viewport/viewport-73-expected.txt:
  • fast/viewport/viewport-74-expected.txt:
  • fast/viewport/viewport-75-expected.txt:
  • fast/viewport/viewport-76-expected.txt:
  • fast/viewport/viewport-77-expected.txt:
  • fast/viewport/viewport-78-expected.txt:
  • fast/viewport/viewport-79-expected.txt:
  • fast/viewport/viewport-80-expected.txt:
  • fast/viewport/viewport-81-expected.txt:
  • fast/viewport/viewport-83-expected.txt:
  • fast/viewport/viewport-85-expected.txt:
  • fast/viewport/viewport-90-expected.txt:
  • platform/qt/fast/events/xsl-onload-expected.txt: Added.
  • platform/qt/fast/parser/xslt-with-html-expected.txt: Added.
  • platform/qt/fast/xsl/document-function-expected.txt:
  • platform/qt/fast/xsl/subframe-location-expected.txt: Added.
  • platform/qt/fast/xsl/transform-to-html-expected.txt: Added.
  • platform/qt/fast/xsl/utf8-chunks-expected.txt: Added.
  • platform/qt/fast/xsl/xslt-bad-import-uri-expected.txt: Added.
  • platform/qt/fast/xsl/xslt-doc-noenc-expected.txt: Added.
  • platform/qt/fast/xsl/xslt-entity-enc-expected.txt: Added.
  • platform/qt/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt:
  • platform/qt/fast/xsl/xslt-recursion-expected.txt: Added.
  • platform/qt/http/tests/misc/location-test-xsl-style-sheet-expected.txt: Added.
  • platform/qt/http/tests/security/xss-DENIED-xsl-document-expected.txt:
  • platform/qt/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt:
  • platform/qt/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
  • platform/qt/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Added.
3:35 AM Changeset in webkit [80106] by antonm@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreivewed. Temporary disabling fast/canvas/canvas-strokePath-gradient-shadow.html

  • platform/chromium/test_expectations.txt
3:13 AM Changeset in webkit [80105] by tkent@chromium.org
  • 4 edits in trunk

2011-03-02 Kent Tamura <​tkent@chromium.org>

Unreviewed, a trivial fix for r80096.

REGRESSION (r80096): [Chromium] fast/forms/input-number-unacceptable-style.html failure
​https://bugs.webkit.org/show_bug.cgi?id=55562

  • platform/chromium/test_expectations.txt:

2011-03-02 Kent Tamura <​tkent@chromium.org>

Unreviewed, a trivial fix for r80096.

REGRESSION (r80096): [Chromium] fast/forms/input-number-unacceptable-style.html failure
​https://bugs.webkit.org/show_bug.cgi?id=55562

  • platform/text/LocalizedNumberICU.cpp: (WebCore::parseLocalizedNumber): Check the ParsePosition after NumberFormat::parse() to reject strings with a valid number + extra letters.
2:02 AM Changeset in webkit [80104] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-02 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Mark fast/forms/input-number-unacceptable-style.html as TEXT.
1:49 AM Changeset in webkit [80103] by steveblock@google.com
  • 7 edits
    2 copies in trunk/Source/WebCore

2011-03-02 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

JObjectWrapper should be moved to its own file
​https://bugs.webkit.org/show_bug.cgi?id=55384

No new tests, refactoring only.

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bridge/jni/v8/JNIBridgeV8.cpp: (JavaField::JavaField):
  • bridge/jni/v8/JNIBridgeV8.h:
  • bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::JavaInstance):
  • bridge/jni/v8/JavaInstanceV8.h:
  • bridge/jni/v8/JobjectWrapper.cpp: Copied from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h. (JobjectWrapper::JobjectWrapper): (JobjectWrapper::~JobjectWrapper):
  • bridge/jni/v8/JobjectWrapper.h: Copied from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h. (JSC::Bindings::JobjectWrapper::instance): (JSC::Bindings::JobjectWrapper::setInstance): (JSC::Bindings::JobjectWrapper::ref): (JSC::Bindings::JobjectWrapper::deref):
1:40 AM Changeset in webkit [80102] by caseq@chromium.org
  • 9 edits
    1 add in trunk/Source/WebCore

2011-02-25 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: factor search logic out of inspector.js
​https://bugs.webkit.org/show_bug.cgi?id=54965

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.switchToAndFocus): (WebInspector.ElementsPanel.prototype._updateMatchesCount):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.searchCanceled): (WebInspector.Panel.prototype.performSearch.updateMatchesCount):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.searchCanceled): (WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback): (WebInspector.ScriptsPanel.prototype.performSearch):
  • inspector/front-end/SearchController.js: Added. (WebInspector.SearchController): (WebInspector.SearchController.prototype.updateSearchMatchesCount): (WebInspector.SearchController.prototype.updateSearchLabel): (WebInspector.SearchController.prototype.cancelSearch): (WebInspector.SearchController.prototype.handleShortcut): (WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch): (WebInspector.SearchController.prototype.activePanelChanged): (WebInspector.SearchController.prototype._updateSearchMatchesCount): (WebInspector.SearchController.prototype._focusSearchField): (WebInspector.SearchController.prototype._onSearchFieldManualFocus): (WebInspector.SearchController.prototype._onKeyDown): (WebInspector.SearchController.prototype._onSearch): (WebInspector.SearchController.prototype._performSearch):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.set attached): (WebInspector.doLoadedDone): (WebInspector.documentKeyDown):
1:22 AM Changeset in webkit [80101] by tkent@chromium.org
  • 12 edits in trunk/LayoutTests

2011-03-02 Kent Tamura <​tkent@chromium.org>

Unreviewed.

Update a test and test expectation for r80096.

  • fast/forms/input-number-unacceptable-style-expected.txt:
  • fast/forms/input-number-unacceptable-style.html: ICU seems to accept "-1+" as a number. So change it to "-1a".
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
12:47 AM Changeset in webkit [80100] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-02 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Teach JavaScriptCore GYP build how to build minidom
​https://bugs.webkit.org/show_bug.cgi?id=55536

12:40 AM Changeset in webkit [80099] by reni@webkit.org
  • 5 edits in trunk/Source/WebCore

FEMorphologyElement changes doesn't require relayout
​https://bugs.webkit.org/show_bug.cgi?id=55462

Reviewed by Andreas Kling.

When the FEMorphologyElement receives an update message but the given value remains the same we don't need
to relayout the filter.

No new tests are needed because this modification is covered by the dynamic update tests of FEMorphology.

  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::setMorphologyOperator):
(WebCore::FEMorphology::setRadiusX):
(WebCore::FEMorphology::setRadiusY):

  • platform/graphics/filters/FEMorphology.h:
  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):
(WebCore::SVGFEMorphologyElement::svgAttributeChanged):

  • svg/SVGFEMorphologyElement.h:
Note: See TracTimeline for information about the timeline view.