⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 13, 2011:

11:51 PM Changeset in webkit [83820] by jamesr@google.com
  • 60 edits
    3 copies
    29 adds
    8 deletes in trunk

2011-04-13 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Allow setting composited backing stores for scrollbars and scroll corners
​https://bugs.webkit.org/show_bug.cgi?id=57202

Adds some new tests for composited scrollbars, updates test expectations to take into account scrollbar layers.

  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/iframe-size-from-zero-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/repaint-after-losing-scrollbars-expected.checksum: Added.
  • compositing/iframes/repaint-after-losing-scrollbars-expected.png: Added.
  • compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Added.
  • compositing/iframes/repaint-after-losing-scrollbars.html: Added.
  • compositing/iframes/resources/repaint-after-losing-scrollbars-iframe.html: Added.
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/overflow/clip-content-under-overflow-controls-expected.checksum: Added.
  • compositing/overflow/clip-content-under-overflow-controls-expected.png: Added.
  • compositing/overflow/clip-content-under-overflow-controls-expected.txt: Added.
  • compositing/overflow/clip-content-under-overflow-controls.html: Added.
  • compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • compositing/overflow/content-gains-scrollbars.html: Added.
  • compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • compositing/overflow/content-loses-scrollbars.html: Added.
  • compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • compositing/overflow/overflow-scrollbar-layers.html: Added.
  • compositing/overflow/repaint-after-losing-scrollbars-expected.checksum: Added.
  • compositing/overflow/repaint-after-losing-scrollbars-expected.png: Added.
  • compositing/overflow/repaint-after-losing-scrollbars-expected.txt: Added.
  • compositing/overflow/repaint-after-losing-scrollbars.html: Added.
  • compositing/tiling/huge-layer-img-expected.png:
  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.png:
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/iframe-resize-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/overflow/resize-painting-expected.txt:
  • platform/chromium-gpu/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/become-composited-nested-iframes-expected.txt: Copied from LayoutTests/compositing/iframes/become-composited-nested-iframes-expected.txt.
  • platform/chromium-gpu/compositing/iframes/become-overlapped-iframe-expected.txt: Copied from LayoutTests/compositing/iframes/become-overlapped-iframe-expected.txt.
  • platform/chromium-gpu/compositing/iframes/overlapped-nested-iframes-expected.txt: Copied from LayoutTests/compositing/iframes/become-composited-nested-iframes-expected.txt.
  • platform/chromium-gpu/compositing/iframes/repaint-after-losing-scrollbars-expected.checksum: Added.
  • platform/chromium-gpu/compositing/iframes/repaint-after-losing-scrollbars-expected.png: Added.
  • platform/chromium-gpu/compositing/iframes/scrolling-iframe-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/repaint-after-losing-scrollbars-expected.checksum: Added.
  • platform/chromium-gpu/compositing/overflow/repaint-after-losing-scrollbars-expected.png: Copied from LayoutTests/compositing/tiling/huge-layer-img-expected.png.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:

2011-04-13 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Allow setting composited backing stores for scrollbars and scroll corners
​https://bugs.webkit.org/show_bug.cgi?id=57202

This teaches ScrollableArea to manage GraphicsLayer backings for the two scrollbars and
scroll corner. ScrollableArea can position the layers and route invalidation and paint calls to
the correct place but depends on subclasses to manage the lifetime of the GraphicsLayers and
place them into the correct place in the hierarchy.

FrameView and RenderLayerCompositor updated to provide layers for frames with overflow controls.
that need them. The overflow control layers are siblings of the frame's clip layer.

RenderLayer and RenderLayerBacking updated to provide overflow control layers for layers that
need them. Currently, layers are only created for overflow controls on layers that are already composited
for other reasons and not necessarily for every RenderLayer with overflow. Overflow control layers are siblings
of the RenderLayerBacking's clipping layer if it exists, otherwise they are siblings of the layer's normal
children.

Tested by a number of compositing/ tests that have scrollbars and by these new tests:

compositing/iframes/repaint-after-losing-scrollbars.html
compositing/overflow/clip-content-under-overflow-controls.html
compositing/overflow/content-gains-scrollbars.html
compositing/overflow/content-loses-scrollbars.html
compositing/overflow/overflow-scrollbar-layers.html
compositing/overflow/repaint-after-losing-scrollbars.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • page/FrameView.cpp: (WebCore::FrameView::layerForHorizontalScrollbar): (WebCore::FrameView::layerForVerticalScrollbar): (WebCore::FrameView::layerForScrollCorner): (WebCore::FrameView::syncCompositingStateForThisFrame): (WebCore::FrameView::contentsResized): (WebCore::FrameView::updateScrollCorner):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::invalidateScrollbar): (WebCore::ScrollableArea::invalidateScrollCorner):
  • platform/ScrollableArea.h: (WebCore::ScrollableArea::paintScrollCorner): (WebCore::ScrollableArea::layerForHorizontalScrollbar): (WebCore::ScrollableArea::layerForVerticalScrollbar): (WebCore::ScrollableArea::layerForScrollCorner):
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::invalidateRect):
  • platform/Scrollbar.h:
  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint):
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::paintContentsIfDirty):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::invalidateRootLayerRect): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::setRootLayer): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/mac/ScrollAnimatorMac.mm: (-[ScrollbarPartAnimation setCurrentProgress:]):
  • platform/win/PopupMenuWin.h: (WebCore::PopupMenuWin::invalidateScrollCornerRect): (WebCore::PopupMenuWin::isScrollCornerVisible): (WebCore::PopupMenuWin::scrollCornerRect):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollCornerRect): (WebCore::RenderLayer::scrollCornerAndResizerRect): (WebCore::RenderLayer::isScrollCornerVisible): (WebCore::RenderLayer::invalidateScrollbarRect): (WebCore::RenderLayer::invalidateScrollCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::layerForHorizontalScrollbar): (WebCore::RenderLayer::layerForVerticalScrollbar): (WebCore::RenderLayer::layerForScrollCorner):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::horizontalScrollbar): (WebCore::RenderLayer::verticalScrollbar):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::~RenderLayerBacking): (WebCore::RenderLayerBacking::updateAfterWidgetResize): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::updateInternalHierarchy): (WebCore::RenderLayerBacking::updateClippingLayers): (WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer): (WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer): (WebCore::RenderLayerBacking::requiresScrollCornerLayer): (WebCore::RenderLayerBacking::updateOverflowControlsLayers): (WebCore::paintScrollbar): (WebCore::RenderLayerBacking::paintContents):
  • rendering/RenderLayerBacking.h: (WebCore::RenderLayerBacking::layerForHorizontalScrollbar): (WebCore::RenderLayerBacking::layerForVerticalScrollbar): (WebCore::RenderLayerBacking::layerForScrollCorner):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::frameViewDidChangeLocation): (WebCore::RenderLayerCompositor::frameViewDidChangeSize): (WebCore::RenderLayerCompositor::rootPlatformLayer): (WebCore::RenderLayerCompositor::updateRootLayerPosition): (WebCore::paintScrollbar): (WebCore::RenderLayerCompositor::paintContents): (WebCore::shouldCompositeOverflowControls): (WebCore::RenderLayerCompositor::requiresHorizontalScrollbarLayer): (WebCore::RenderLayerCompositor::requiresVerticalScrollbarLayer): (WebCore::RenderLayerCompositor::requiresScrollCornerLayer): (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): (WebCore::RenderLayerCompositor::detachRootPlatformLayer):
  • rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::layerForHorizontalScrollbar): (WebCore::RenderLayerCompositor::layerForVerticalScrollbar): (WebCore::RenderLayerCompositor::layerForScrollCorner):
  • rendering/RenderListBox.h: (WebCore::RenderListBox::isScrollCornerVisible): (WebCore::RenderListBox::scrollCornerRect): (WebCore::RenderListBox::invalidateScrollCornerRect):

2011-04-13 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Allow setting composited backing stores for scrollbars and scroll corners
​https://bugs.webkit.org/show_bug.cgi?id=57202

Remove a lot of scrollbar hacks from the chromium compositor implementation now that
scrollbars go to real layers.

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::invalidateScrollCornerRect): (WebKit::WebScrollbarImpl::scrollCornerPresent):
  • src/WebScrollbarImpl.h: (WebKit::WebScrollbarImpl::scrollCornerRect):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::reallocateRenderer):

2011-04-13 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Allow setting composited backing stores for scrollbars and scroll corners
​https://bugs.webkit.org/show_bug.cgi?id=57202

Update WebScrollBar to reflect ScrollableArea interface changes.

  • WebScrollBar.h: (WebScrollBar::invalidateScrollCornerRect): (WebScrollBar::scrollCornerPresent): (WebScrollBar::scrollCornerRect):

2011-04-13 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Allow setting composited backing stores for scrollbars and scroll corners
​https://bugs.webkit.org/show_bug.cgi?id=57202

Update WebPopupMenuProxyWin to reflect ScrollableArea interface changes.

  • UIProcess/win/WebPopupMenuProxyWin.h: (WebKit::WebPopupMenuProxyWin::invalidateScrollCornerRect): (WebKit::WebPopupMenuProxyWin::scrollCornerPresent): (WebKit::WebPopupMenuProxyWin::scrollCornerRect):
11:26 PM Changeset in webkit [83819] by caseq@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-04-13 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Added chromium expectations for test added in r83803.

  • platform/chromium/iframe-outline-expected.png: Added.
11:25 PM Changeset in webkit [83818] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

2011-04-13 Cary Clark <​caryclark@chromium.org>

Reviewed by Eric Seidel.

[Chromium] allow concurrent Skia and CG datatypes
​https://bugs.webkit.org/show_bug.cgi?id=57848

The Chromium port is experimenting with running Skia as the WebKit rendering engine, and CoreGraphics
as the UI rendering engine. This permits Chromium to unify its graphics story while leveraging OS X to
draw elements like scrollbars and buttons.

Restructure the common graphics units, points, and rectangles, to convert to Sk-types and CG-types at
the same time. This requires only adding to the existing preprocessor commands, and will have no effect
on any existing platform.

Eventually, WTF_USE_SKIA_ON_MAC_CHROME will be defined to enable this, but for now, there's no
functional change.

No new tests as this provides no new functionality.

  • platform/graphics/FloatPoint.h: Add USE(SKIA_ON_MAC_CHROME) to make CG type and operators visible to a Skia-based Chrome Mac build.
  • platform/graphics/FloatRect.h: Ditto.
  • platform/graphics/FloatSize.h: Ditto.
  • platform/graphics/IntPoint.h: Ditto.
  • platform/graphics/IntRect.h: Ditto.
  • platform/graphics/IntSize.h: Ditto.
  • platform/graphics/cg/FloatPointCG.cpp: Ditto.
  • platform/graphics/cg/FloatRectCG.cpp: Ditto.
  • platform/graphics/cg/FloatSizeCG.cpp: Ditto.
  • platform/graphics/cg/IntPointCG.cpp: Ditto.
  • platform/graphics/cg/IntRectCG.cpp: Ditto.
  • platform/graphics/cg/IntSizeCG.cpp: Ditto.
10:56 PM Changeset in webkit [83817] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-04-13 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

Perl unit test removeEOL.pl should print test case name on failure
​https://bugs.webkit.org/show_bug.cgi?id=58513

  • Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as second argument of Test::Simple::ok().
10:44 PM Changeset in webkit [83816] by rolandsteiner@chromium.org
  • 20 edits in trunk/Source/WebCore

2011-04-13 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 58460 - childTypeAllowed() should be const
​https://bugs.webkit.org/show_bug.cgi?id=58460

Made childTypeAllowed const.

No new tests. (minor refactoring).

  • dom/Attr.cpp: (WebCore::Attr::childTypeAllowed):
  • dom/Attr.h:
  • dom/CDATASection.cpp: (WebCore::CDATASection::childTypeAllowed):
  • dom/CDATASection.h:
  • dom/Comment.cpp: (WebCore::Comment::childTypeAllowed):
  • dom/Comment.h:
  • dom/Document.cpp: (WebCore::Document::childTypeAllowed):
  • dom/Document.h:
  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::childTypeAllowed):
  • dom/DocumentFragment.h:
  • dom/Element.cpp: (WebCore::Element::childTypeAllowed):
  • dom/Element.h:
  • dom/Node.h: (WebCore::Node::childTypeAllowed):
  • dom/Notation.cpp: (WebCore::Notation::childTypeAllowed):
  • dom/Notation.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::childTypeAllowed):
  • dom/ProcessingInstruction.h:
  • dom/Text.cpp: (WebCore::Text::childTypeAllowed):
  • dom/Text.h:
10:41 PM Changeset in webkit [83815] by levin@chromium.org
  • 1 edit
    184 adds in trunk

Add GTest unit-testing framework to WebKit
​https://bugs.webkit.org/show_bug.cgi?id=58507

Patch by Dmitry Lomov <​dslomov@google.com> on 2011-04-13
Reviewed by David Levin.

  • Source/ThirdParty/gtest/CHANGES: Added.
  • Source/ThirdParty/gtest/CMakeLists.txt: Added.
  • Source/ThirdParty/gtest/CONTRIBUTORS: Added.
  • Source/ThirdParty/gtest/COPYING: Added.
  • Source/ThirdParty/gtest/Makefile.am: Added.
  • Source/ThirdParty/gtest/README: Added.
  • Source/ThirdParty/gtest/README.WebKit: Added.
  • Source/ThirdParty/gtest/codegear/gtest.cbproj: Added.
  • Source/ThirdParty/gtest/codegear/gtest.groupproj: Added.
  • Source/ThirdParty/gtest/codegear/gtest_all.cc: Added.
  • Source/ThirdParty/gtest/codegear/gtest_link.cc: Added.
  • Source/ThirdParty/gtest/codegear/gtest_main.cbproj: Added.
  • Source/ThirdParty/gtest/codegear/gtest_unittest.cbproj: Added.
  • Source/ThirdParty/gtest/configure.ac: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-death-test.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-message.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-param-test.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-param-test.h.pump: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-spi.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-test-part.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-typed-test.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest_pred_impl.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest_prod.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-death-test-internal.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-filepath.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-linked_ptr.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h.pump: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-string.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-tuple.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-tuple.h.pump: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-type-util.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-type-util.h.pump: Added.
  • Source/ThirdParty/gtest/m4/acx_pthread.m4: Added.
  • Source/ThirdParty/gtest/m4/gtest.m4: Added.
  • Source/ThirdParty/gtest/make/Makefile: Added.
  • Source/ThirdParty/gtest/msvc/gtest-md.sln: Added.
  • Source/ThirdParty/gtest/msvc/gtest-md.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest.sln: Added.
  • Source/ThirdParty/gtest/msvc/gtest.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest_main-md.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest_main.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest_prod_test-md.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest_prod_test.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest_unittest-md.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest_unittest.vcproj: Added.
  • Source/ThirdParty/gtest/run_tests.py: Added.
  • Source/ThirdParty/gtest/samples/prime_tables.h: Added.
  • Source/ThirdParty/gtest/samples/sample1.cc: Added.
  • Source/ThirdParty/gtest/samples/sample1.h: Added.
  • Source/ThirdParty/gtest/samples/sample10_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample1_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample2.cc: Added.
  • Source/ThirdParty/gtest/samples/sample2.h: Added.
  • Source/ThirdParty/gtest/samples/sample2_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample3-inl.h: Added.
  • Source/ThirdParty/gtest/samples/sample3_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample4.cc: Added.
  • Source/ThirdParty/gtest/samples/sample4.h: Added.
  • Source/ThirdParty/gtest/samples/sample4_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample5_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample6_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample7_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample8_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample9_unittest.cc: Added.
  • Source/ThirdParty/gtest/scripts/fuse_gtest_files.py: Added.
  • Source/ThirdParty/gtest/scripts/gen_gtest_pred_impl.py: Added.
  • Source/ThirdParty/gtest/scripts/gtest-config.in: Added.
  • Source/ThirdParty/gtest/scripts/pump.py: Added.
  • Source/ThirdParty/gtest/scripts/test/Makefile: Added.
  • Source/ThirdParty/gtest/scripts/upload.py: Added.
  • Source/ThirdParty/gtest/scripts/upload_gtest.py: Added.
  • Source/ThirdParty/gtest/src/gtest-all.cc: Added.
  • Source/ThirdParty/gtest/src/gtest-death-test.cc: Added.
  • Source/ThirdParty/gtest/src/gtest-filepath.cc: Added.
  • Source/ThirdParty/gtest/src/gtest-internal-inl.h: Added.
  • Source/ThirdParty/gtest/src/gtest-port.cc: Added.
  • Source/ThirdParty/gtest/src/gtest-test-part.cc: Added.
  • Source/ThirdParty/gtest/src/gtest-typed-test.cc: Added.
  • Source/ThirdParty/gtest/src/gtest.cc: Added.
  • Source/ThirdParty/gtest/src/gtest_main.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-death-test_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-filepath_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-linked_ptr_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-listener_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-message_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-options_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-param-test2_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-param-test_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-param-test_test.h: Added.
  • Source/ThirdParty/gtest/test/gtest-port_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-test-part_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-tuple_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-typed-test2_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-typed-test_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-typed-test_test.h: Added.
  • Source/ThirdParty/gtest/test/gtest-unittest-api_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_all_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_break_on_failure_unittest.py: Added.
  • Source/ThirdParty/gtest/test/gtest_break_on_failure_unittest_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_color_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_color_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_env_var_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_env_var_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_environment_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_filter_unittest.py: Added.
  • Source/ThirdParty/gtest/test/gtest_filter_unittest_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_help_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_help_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_list_tests_unittest.py: Added.
  • Source/ThirdParty/gtest/test/gtest_list_tests_unittest_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_main_unittest.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_nc.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_nc_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_no_test_unittest.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_output_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_output_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_output_test_golden_lin.txt: Added.
  • Source/ThirdParty/gtest/test/gtest_output_test_golden_win.txt: Added.
  • Source/ThirdParty/gtest/test/gtest_pred_impl_unittest.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_prod_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_repeat_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_shuffle_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_shuffle_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_sole_header_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_stress_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_test_utils.py: Added.
  • Source/ThirdParty/gtest/test/gtest_throw_on_failure_ex_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_throw_on_failure_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_throw_on_failure_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_uninitialized_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_uninitialized_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_unittest.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_xml_outfile1_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_xml_outfile2_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_xml_outfiles_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_xml_output_unittest.py: Added.
  • Source/ThirdParty/gtest/test/gtest_xml_output_unittest_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_xml_test_utils.py: Added.
  • Source/ThirdParty/gtest/test/production.cc: Added.
  • Source/ThirdParty/gtest/test/production.h: Added.
  • Source/ThirdParty/gtest/test/run_tests_util.py: Added.
  • Source/ThirdParty/gtest/test/run_tests_util_test.py: Added.
  • Source/ThirdParty/gtest/xcode/Config/DebugProject.xcconfig: Added.
  • Source/ThirdParty/gtest/xcode/Config/FrameworkTarget.xcconfig: Added.
  • Source/ThirdParty/gtest/xcode/Config/General.xcconfig: Added.
  • Source/ThirdParty/gtest/xcode/Config/ReleaseProject.xcconfig: Added.
  • Source/ThirdParty/gtest/xcode/Config/StaticLibraryTarget.xcconfig: Added.
  • Source/ThirdParty/gtest/xcode/Config/TestTarget.xcconfig: Added.
  • Source/ThirdParty/gtest/xcode/Resources/Info.plist: Added.
  • Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/Info.plist: Added.
  • Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/WidgetFramework.xcodeproj/project.pbxproj: Added.
  • Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/runtests.sh: Added.
  • Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/widget.cc: Added.
  • Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/widget.h: Added.
  • Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/widget_test.cc: Added.
  • Source/ThirdParty/gtest/xcode/Scripts/runtests.sh: Added.
  • Source/ThirdParty/gtest/xcode/Scripts/versiongenerate.py: Added.
  • Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj: Added.
10:40 PM Changeset in webkit [83814] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-04-13 Jon Lee <​jonlee@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION(r81880): Paste menu is disabled for many edit fields (yahoo and google search, yahoo mail msg, forms, etc)
​https://bugs.webkit.org/show_bug.cgi?id=58284
<rdar://problem/9246149>

  • WebCore.exp.in: Exporting EditingBehavior.h for use in WebKit2
  • editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldClearSelectionWhenLosingWebPageFocus): moving the platform-specific code out of an #ifdef and into this class for run-time instead of compile-time checking

2011-04-13 Jon Lee <​jonlee@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION(r81880): Paste menu is disabled for many edit fields (yahoo and google search, yahoo mail msg, forms, etc)
​https://bugs.webkit.org/show_bug.cgi?id=58284
<rdar://problem/9246149>

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setFocused): Check for whether we are not supposed to be focused AND whether our platform behavior dictates to clear out the selection
10:35 PM Changeset in webkit [83813] by yael.aharon@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-04-13 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Eric Seidel.

constructLine should take bidiRuns as a parameter
​https://bugs.webkit.org/show_bug.cgi?id=58458

Pass bidiRuns to constructLine and move reachedEndOfTextRenderer so that it is
declared before constructLine.

No new tests as this is refactoring only.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::reachedEndOfTextRenderer): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::layoutInlineChildren):
10:35 PM Changeset in webkit [83812] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed a bug where WKView changed the cursor when the mouse was moving over other views.

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView mouseMoved:]): If getting this message because this view is the first responder,
ignore it unless it is inside the visible rect.

10:05 PM Changeset in webkit [83811] by Simon Fraser
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-04-13 Simon Fraser <Simon Fraser>

Revert ​http://trac.webkit.org/changeset/83750 because it broke PrettyPatch.
​https://bugs.webkit.org/show_bug.cgi?id=58510

  • PrettyPatch/PrettyPatch.rb:
9:01 PM Changeset in webkit [83810] by oliver@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/heap/Heap.cpp

Accidentally made us GC on every allocation.

8:57 PM Changeset in webkit [83809] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix 32bit tests.

8:44 PM April 2011 Meeting edited by abarth@webkit.org
(diff)
8:28 PM Changeset in webkit [83808] by oliver@apple.com
  • 192 edits in trunk

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Additional structures are allocated beyond the expected threshold
so we preflight the test to get them allocated.

  • fast/dom/gc-10.html:

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Turn Structure into a GC allocated object. Most of this patch
is the mechanical change of replacing variations on RefPtr<Structure>
with either Structure* (for arguments and locals), WriteBarrier<Structure>
for the few cases where Structures are held by GC allocated objects
and Strong<Structure> for the root structure objects in GlobalData.

  • API/JSCallbackConstructor.cpp: (JSC::JSCallbackConstructor::JSCallbackConstructor):
  • API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
  • API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
  • API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
  • API/JSCallbackObjectFunctions.h: (JSC::::JSCallbackObject):
  • API/JSContextRef.cpp:
  • JavaScriptCore.JSVALUE32_64only.exp:
  • JavaScriptCore.JSVALUE64only.exp:
  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::markStructures): (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::MethodCallLinkInfo::setSeen): (JSC::GlobalResolveInfo::GlobalResolveInfo):
  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList): (JSC::PolymorphicAccessStructureList::markAggregate): (JSC::Instruction::Instruction):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref): (JSC::StructureStubInfo::markAggregate):
  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::initGetByIdSelf): (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::initPutByIdTransition): (JSC::StructureStubInfo::initPutByIdReplace):
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation):
  • debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure):
  • heap/Handle.h:
  • heap/MarkStack.cpp: (JSC::MarkStack::markChildren): (JSC::MarkStack::drain):
  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep):
  • heap/Strong.h: (JSC::Strong::Strong): (JSC::Strong::set):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::uncachePutByID): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::uncacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchMethodCallProto): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchMethodCallProto): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION): (JSC::getPolymorphicAccessStructureListSlot):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::storePtrWithWriteBarrier):
  • jsc.cpp: (cleanupGlobalData):
  • runtime/Arguments.h: (JSC::Arguments::createStructure): (JSC::Arguments::Arguments): (JSC::JSActivation::copyRegisters):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::ArrayPrototype): (JSC::arrayProtoFuncSplice):
  • runtime/ArrayPrototype.h: (JSC::ArrayPrototype::createStructure):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
  • runtime/BooleanConstructor.h:
  • runtime/BooleanObject.cpp: (JSC::BooleanObject::BooleanObject):
  • runtime/BooleanObject.h: (JSC::BooleanObject::createStructure):
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateConstructor.h:
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DateInstance.h: (JSC::DateInstance::createStructure):
  • runtime/DatePrototype.cpp: (JSC::DatePrototype::DatePrototype):
  • runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
  • runtime/Error.cpp: (JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • runtime/ErrorConstructor.h:
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance): (JSC::ErrorInstance::create):
  • runtime/ErrorInstance.h: (JSC::ErrorInstance::createStructure):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/ErrorPrototype.h:
  • runtime/ExceptionHelpers.cpp: (JSC::InterruptedExecutionError::InterruptedExecutionError): (JSC::TerminatedExecutionError::TerminatedExecutionError):
  • runtime/Executable.cpp:
  • runtime/Executable.h: (JSC::ExecutableBase::ExecutableBase): (JSC::ExecutableBase::createStructure): (JSC::NativeExecutable::createStructure): (JSC::NativeExecutable::NativeExecutable): (JSC::ScriptExecutable::ScriptExecutable): (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::createStructure):
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
  • runtime/GetterSetter.h: (JSC::GetterSetter::GetterSetter): (JSC::GetterSetter::createStructure):
  • runtime/InitializeThreading.cpp: (JSC::initializeThreadingOnce):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/InternalFunction.h: (JSC::InternalFunction::createStructure):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation):
  • runtime/JSActivation.h: (JSC::JSActivation::createStructure):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray):
  • runtime/JSArray.h: (JSC::JSArray::createStructure):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray): (JSC::JSByteArray::createStructure):
  • runtime/JSByteArray.h: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.cpp: (JSC::isZombie):
  • runtime/JSCell.h: (JSC::JSCell::JSCell::JSCell): (JSC::JSCell::JSCell::addressOfStructure): (JSC::JSCell::JSCell::structure): (JSC::JSCell::JSCell::markChildren): (JSC::JSCell::JSValue::isZombie):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction):
  • runtime/JSFunction.h: (JSC::JSFunction::createStructure):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::clearBuiltinStructures): (JSC::JSGlobalData::createLeaked):
  • runtime/JSGlobalData.h: (JSC::allocateGlobalHandle):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::markChildren): (JSC::JSGlobalObject::copyGlobalsFrom):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject): (JSC::JSGlobalObject::createStructure): (JSC::Structure::prototypeChain): (JSC::Structure::isValid): (JSC::constructEmptyArray):
  • runtime/JSNotAnObject.h: (JSC::JSNotAnObject::JSNotAnObject): (JSC::JSNotAnObject::createStructure):
  • runtime/JSONObject.cpp: (JSC::JSONObject::JSONObject):
  • runtime/JSONObject.h: (JSC::JSONObject::createStructure):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::seal): (JSC::JSObject::freeze): (JSC::JSObject::preventExtensions): (JSC::JSObject::removeDirect): (JSC::JSObject::createInheritorID):
  • runtime/JSObject.h: (JSC::JSObject::createStructure): (JSC::JSObject::JSObject): (JSC::JSNonFinalObject::createStructure): (JSC::JSNonFinalObject::JSNonFinalObject): (JSC::JSFinalObject::create): (JSC::JSFinalObject::createStructure): (JSC::JSFinalObject::JSFinalObject): (JSC::constructEmptyObject): (JSC::createEmptyObjectStructure): (JSC::JSObject::~JSObject): (JSC::JSObject::setPrototype): (JSC::JSObject::setStructure): (JSC::JSObject::inheritorID): (JSC::JSObject::putDirectInternal): (JSC::JSObject::transitionTo): (JSC::JSObject::markChildrenDirect):
  • runtime/JSObjectWithGlobalObject.cpp: (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
  • runtime/JSObjectWithGlobalObject.h: (JSC::JSObjectWithGlobalObject::createStructure): (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): (JSC::JSPropertyNameIterator::create): (JSC::JSPropertyNameIterator::get):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure): (JSC::JSPropertyNameIterator::setCachedStructure): (JSC::Structure::setEnumerationCache):
  • runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::JSStaticScopeObject): (JSC::JSStaticScopeObject::createStructure):
  • runtime/JSString.h: (JSC::RopeBuilder::JSString): (JSC::RopeBuilder::createStructure):
  • runtime/JSType.h:
  • runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo):
  • runtime/JSValue.h:
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::createStructure): (JSC::JSVariableObject::JSVariableObject): (JSC::JSVariableObject::copyRegisterArray):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::createStructure): (JSC::JSWrapperObject::JSWrapperObject):
  • runtime/JSZombie.cpp:
  • runtime/JSZombie.h: (JSC::JSZombie::JSZombie): (JSC::JSZombie::createStructure):
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/MathObject.h: (JSC::MathObject::createStructure):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor): (JSC::NativeErrorConstructor::markChildren):
  • runtime/NativeErrorConstructor.h: (JSC::NativeErrorConstructor::createStructure):
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NativeErrorPrototype.h:
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
  • runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
  • runtime/NumberObject.cpp: (JSC::NumberObject::NumberObject):
  • runtime/NumberObject.h: (JSC::NumberObject::createStructure):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
  • runtime/ObjectConstructor.h: (JSC::ObjectConstructor::createStructure):
  • runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype):
  • runtime/ObjectPrototype.h:
  • runtime/PropertyMapHashTable.h: (JSC::PropertyTable::PropertyTable):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor): (JSC::RegExpMatchesArray::RegExpMatchesArray):
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure):
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::RegExpObject):
  • runtime/RegExpObject.h: (JSC::RegExpObject::createStructure):
  • runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype):
  • runtime/RegExpPrototype.h:
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::ScopeChainNode): (JSC::ScopeChainNode::createStructure):
  • runtime/StrictEvalActivation.cpp: (JSC::StrictEvalActivation::StrictEvalActivation):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringConstructor.h:
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringObject.h: (JSC::StringObject::createStructure):
  • runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined): (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/StringPrototype.h: (JSC::StringPrototype::createStructure):
  • runtime/Structure.cpp: (JSC::StructureTransitionTable::remove): (JSC::StructureTransitionTable::add): (JSC::Structure::Structure): (JSC::Structure::~Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::removePropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::toCacheableDictionaryTransition): (JSC::Structure::toUncacheableDictionaryTransition): (JSC::Structure::sealTransition): (JSC::Structure::freezeTransition): (JSC::Structure::preventExtensionsTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::copyPropertyTable): (JSC::Structure::put): (JSC::Structure::markChildren):
  • runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::setPrototypeWithoutTransition): (JSC::Structure::createStructure): (JSC::JSCell::createDummyStructure): (JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::keyForFinalizer):
  • runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain): (JSC::StructureChain::markChildren):
  • runtime/StructureChain.h: (JSC::StructureChain::create): (JSC::StructureChain::head): (JSC::StructureChain::createStructure):
  • runtime/StructureTransitionTable.h: (JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::finalizerContextFor): (JSC::StructureTransitionTable::~StructureTransitionTable): (JSC::StructureTransitionTable::slot): (JSC::StructureTransitionTable::setMap): (JSC::StructureTransitionTable::singleTransition): (JSC::StructureTransitionTable::clearSingleTransition): (JSC::StructureTransitionTable::setSingleTransition):
  • runtime/WeakGCMap.h: (JSC::DefaultWeakGCMapFinalizerCallback::finalizerContextFor): (JSC::DefaultWeakGCMapFinalizerCallback::keyForFinalizer): (JSC::WeakGCMap::contains): (JSC::WeakGCMap::find): (JSC::WeakGCMap::remove): (JSC::WeakGCMap::add): (JSC::WeakGCMap::set): (JSC::WeakGCMap::finalize):
  • runtime/WriteBarrier.h: (JSC::writeBarrier): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->): (JSC::WriteBarrierBase::setWithoutWriteBarrier):

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Fix up JSG to correctly mark Structure, et al.

  • JSRun.cpp: (JSGlueGlobalObject::JSGlueGlobalObject):
  • JSRun.h:
  • JSUtils.cpp: (JSObjectKJSValue):
  • UserObjectImp.cpp: (UserObjectImp::UserObjectImp):
  • UserObjectImp.h: (UserObjectImp::createStructure):

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Update WebCore for Structure being a GC allocated object

  • WebCore.exp.in:
  • bindings/js/JSAudioConstructor.h: (WebCore::JSAudioConstructor::createStructure):
  • bindings/js/JSDOMBinding.cpp: (WebCore::cacheDOMStructure):
  • bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::createStructure): (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer): (WebCore::DOMConstructorObject::createStructure): (WebCore::DOMConstructorObject::DOMConstructorObject): (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::JSDOMGlobalObject): (WebCore::JSDOMGlobalObject::markChildren):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::createStructure):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase):
  • bindings/js/JSDOMWindowBase.h: (WebCore::JSDOMWindowBase::createStructure):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
  • bindings/js/JSDOMWrapper.h: (WebCore::DOMObject::DOMObject):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener):
  • bindings/js/JSImageConstructor.h: (WebCore::JSImageConstructor::createStructure):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSOptionConstructor.h: (WebCore::JSOptionConstructor::createStructure):
  • bindings/js/JSWorkerContextBase.cpp: (WebCore::JSWorkerContextBase::JSWorkerContextBase):
  • bindings/js/JSWorkerContextBase.h: (WebCore::JSWorkerContextBase::createStructure):
  • bindings/js/ScriptCachedFrameData.h:
  • bindings/js/SerializedScriptValue.h:
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/CRuntimeObject.h: (JSC::Bindings::CRuntimeObject::createStructure):
  • bridge/c/c_instance.cpp: (JSC::Bindings::CRuntimeMethod::createStructure):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaRuntimeMethod::createStructure):
  • bridge/jni/jsc/JavaRuntimeObject.h: (JSC::Bindings::JavaRuntimeObject::createStructure):
  • bridge/objc/ObjCRuntimeObject.h: (JSC::Bindings::ObjCRuntimeObject::createStructure):
  • bridge/objc/objc_instance.mm: (ObjCRuntimeMethod::createStructure):
  • bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
  • bridge/runtime_array.cpp: (JSC::RuntimeArray::RuntimeArray):
  • bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
  • bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod):
  • bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
  • bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::RuntimeObject):
  • bridge/runtime_object.h: (JSC::Bindings::RuntimeObject::createStructure):
  • history/HistoryItem.h:

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Update WebKit for the world of GC allocated Structure

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyRuntimeMethod::createStructure):
  • Plugins/Hosted/ProxyRuntimeObject.h: (WebKit::ProxyRuntimeObject::createStructure):

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Update WK2 for the world of GC allocated Structure

  • WebProcess/Plugins/Netscape/JSNPMethod.h: (WebKit::JSNPMethod::createStructure):
  • WebProcess/Plugins/Netscape/JSNPObject.h: (WebKit::JSNPObject::createStructure):
8:22 PM April 2011 Meeting created by rniwa@webkit.org
Adding a new page for April 2011 meeting
7:38 PM Writing Reftests edited by hayato@chromium.org
(diff)
7:20 PM Changeset in webkit [83807] by tkent@chromium.org
  • 2 edits in trunk/Tools

2011-04-13 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

gdb-safari should pass arguments to safari.
​https://bugs.webkit.org/show_bug.cgi?id=58439

We can do:

gdb-safari --debug LayoutTests/.../foo.html

  • Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
7:14 PM Changeset in webkit [83806] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.
​https://bugs.webkit.org/show_bug.cgi?id=52763

r83799 broke test-webkitpy because it assumed we always have
access to a real filesystem (we don't during the unit tests).
Stubbing out the copy for now but we might need a better
solution at some point.

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
7:13 PM Changeset in webkit [83805] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-13 Cary Clark <​caryclark@google.com>

Reviewed by Eric Seidel.

Allow CG Font support in Chrome Darwin build using Skia
​https://bugs.webkit.org/show_bug.cgi?id=58321

This allows Chrome to use Skia to do WebKit rendering, while
using CoreGraphics for glyph creation and computing font metrics.
It relies on an undefined platform token, WTF_USE_SKIA_ON_MAC_CHROME.

No new tests needed, no functionality change.

  • loader/cache/CachedFont.cpp: Make CGFontRef functions and CG-specific font code available to Chrome builds on Darwin using Skia.
  • platform/graphics/FontPlatformData.h: Ditto. (WebCore::FontPlatformData::hash): Ditto.
  • platform/graphics/GlyphBuffer.h: Ditto. (WebCore::GlyphBuffer::advanceAt): Ditto. (WebCore::GlyphBuffer::add): Ditto. (WebCore::GlyphBuffer::expandLastAdvance): Ditto.
  • platform/graphics/SimpleFontData.h: Ditto.
6:47 PM Changeset in webkit [83804] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Dimitri Glazkov.

The timeline of the video controls is unusable if the multimedia backend returns a
infinite duration.
​https://bugs.webkit.org/show_bug.cgi?id=58452

In case the underlaying media element backend returns crazy values, e.g.
an infinite duration for the video we need to bail out and hide the timeline
rather than in a broken state where you can't use it. The previous code was just
checking if the duration was NaN.

We can't control from JS what the backend will return as a duration for the video
so we can't make an test for it.

  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset):
6:41 PM Changeset in webkit [83803] by inferno@chromium.org
  • 3 edits
    4 adds in trunk

2011-04-13 Abhishek Arya <​inferno@chromium.org>

Reviewed by James Robinson.

Tests that iframe outline is drawn.
​https://bugs.webkit.org/show_bug.cgi?id=57439

  • fast/frames/iframe-outline.html: Added.
  • platform/mac/fast/frames/iframe-outline-expected.checksum: Added.
  • platform/mac/fast/frames/iframe-outline-expected.png: Added.
  • platform/mac/fast/frames/iframe-outline-expected.txt: Added.

2011-04-13 Abhishek Arya <​inferno@chromium.org>

Reviewed by James Robinson.

Draw outline for render widgets.
​https://bugs.webkit.org/show_bug.cgi?id=57439

Test: fast/frames/iframe-outline.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
6:39 PM Changeset in webkit [83802] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change - remove tests that are no longer
failing.

  • platform/mac/test_expectations.txt:
6:37 PM Changeset in webkit [83801] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests --run-singly option is busted
​https://bugs.webkit.org/show_bug.cgi?id=55909

Python's broken lexical scoping strikes again :(.

  • Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
6:24 PM Changeset in webkit [83800] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-13 Geoffrey Garen <​ggaren@apple.com>

Try to fix ASSERTs seen on Windows bots.

  • wtf/HashTable.h: (WTF::hashTableSwap): Force MSVC to use the right version of swap.
6:13 PM Changeset in webkit [83799] by ojan@chromium.org
  • 2 edits
    1 add in trunk/Tools

2011-04-13 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

generated unexpected_results.html from unexpected_results.json
​https://bugs.webkit.org/show_bug.cgi?id=52763

Eventually, we'll merge this with results.html and have a single richer results page.
For now, I just want to get something checked in that we can iterate on.

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
6:12 PM Changeset in webkit [83798] by jianli@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

Unreviewed, rebaseline 4 tests added as r83787.

  • platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
6:12 PM Changeset in webkit [83797] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-04-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Up the failure limit to allow the commit-queue to actually land when the tree is red
​https://bugs.webkit.org/show_bug.cgi?id=58499

This change increases the --exit-after-N-failures limit used by the commit-queue
from 1 to 10. This will cause the code added in bug 58494 to actually get
exercised and the queues should start being able to land when the trees are red.

When testing I found that test_runtests_leopard_commit_queue_hack_command was the
only unit test to actually detect this change! Since we don't actually
run on leopard anymore, I removed the hack code and repurposed the test.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
6:11 PM Changeset in webkit [83796] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-13 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Change the representation of ShadowRoot nodes in render tree dumps
​https://bugs.webkit.org/show_bug.cgi?id=58432

Show "#shadow-root" for ShadorRoot nodes instead of "#document-fragment"
in DRT results.

No new tests. This change doesn't affect existing tests yet.

  • dom/DocumentFragment.h: Make nodeName() protected in order that ShdowRoot can override it.
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::nodeName): Returns "#shadow-root".
  • dom/ShadowRoot.h: Declare nodeName().
  • rendering/RenderTreeAsText.cpp: (WebCore::nodePosition): Don't show "child N " if the node is a shadow boundary. We don't use isShadowRoot() here because the legacy shadow root nodes return true for isShadowRoot() and we don't want to update existing test results.
6:08 PM Changeset in webkit [83795] by eric@webkit.org
  • 8 edits
    2 adds in trunk/Tools

2011-04-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should be able to land when tree is red
​https://bugs.webkit.org/show_bug.cgi?id=58494

There is some yak hair on my hands, I will admit.

This change is mostly about adding an ExpectedFailures
class to track when the bots are red and we should be
ignoring failures when landing from the commit-queue.

However, to make intelligent decisions about patches we
need to know whether the run hit the --exit-after-N-failures limit
or not. Right now that information is not saved off in results.html
so we have to pull the information from RunTests.

I've plumbed the --exit-after-N-failures information into
LayoutTestResults for now to make the ExpectedFailures code cleaner.

As a result of adding all these additional calls to delegate.layout_test_results()
I broke some of our flaky test detection tests and had to re-write them
to not depend on the number of layout_test_results code.

At the same time I updated the commit-queue to use the newer filesystem
API (to allow us to use MockFileSystem) which required further changes
to the layout tests. Changes were required in either case, since
we're now calling layout_test_results() in more cases, which previously
would try and hit the disk (until I moved it to use tool.filesystem).

I should note that *all* of this code is disabled for now, since our
--exit-after-N-failures limit is currently 1! (Thus were always in the
case where we can't actually tell if the layout test results are legit.)
I will up that limit in a second patch (which may require a couple more unit test tweaks).

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
5:58 PM Changeset in webkit [83794] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-13 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Merge LineOffsets and LineWidth
​https://bugs.webkit.org/show_bug.cgi?id=58411

Merged lineOffsets into LineWidth.

After this patch, available width is updated in positionNewFloatOnLine via updateAvailableWidth and
shrinkAvailableWidthForNewFloatIfNeeded instead of findNextBreak. This is correct because

  • LineOffsets::update and LineOffsets::shrinkWidthForNewFloatIfNeeded were only called in positionNewFloatOnLine besides LineOffsets' constructor
  • positionNewFloatOnLine was only called in skipLeadingWhitespace and findNextLineBreak
  • findNextLineBreak updates the available width whenever it calls skipLeadingWhitespace or positionNewFloatOnLine
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineWidth instead of LineOffset (WebCore::LineWidth::LineWidth): Takes RenderBlock* and boolean isFirstLine; call updateAvailableWidth because the initial available width was used to be computed from lineOffsets.width(). (WebCore::LineWidth::computeAvailableWidthFromLeftAndRight): Added. (WebCore::LineWidth::updateAvailableWidth): Renamed from LineOffsets::update; this function now updates m_availableWidth via computeAvailableWidthFromLeftAndRight as well as m_left and m_right. (WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Renamed from LineOffsets::shrinkWidthForNewFloatIfNeeded. This function also calls computeAvailableWidthFromLeftAndRight. (WebCore::LineWidth::applyOverhang): No longer takes arguments since both arguments were member variables of LineOffsets. (WebCore::LineWidth::fitBelowFloats): No longer takes isFirstLine. (WebCore::RenderBlock::findNextLineBreak): Uses LineWidth. (WebCore::RenderBlock::positionNewFloatOnLine): Takes a reference to LineWidth.
5:45 PM Changeset in webkit [83793] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Unreviewed build correction.

  • TestWebKitAPI/PlatformWebView.h: Limit include of <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
5:44 PM Changeset in webkit [83792] by commit-queue@webkit.org
  • 13 edits in trunk

2011-04-13 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Separate DerivedSources.
​https://bugs.webkit.org/show_bug.cgi?id=58427

Seperate DerivedSources/ to DerivedSources/WebCore and
DerivedSources/JavaScriptCore.

  • Source/CMakeLists.txt:
  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/WebKitFS.cmake:
  • Source/cmake/WebKitHelpers.cmake:
  • Source/cmake/WebKitMacros.cmake:

2011-04-13 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Separate DerivedSources.
​https://bugs.webkit.org/show_bug.cgi?id=58427

  • CMakeLists.txt: Change DERIVED_SOURCES_DIR to DERIVED_SOURCES_JAVASCRIPTCORE_DIR.

2011-04-13 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Separate DerivedSources.
​https://bugs.webkit.org/show_bug.cgi?id=58427

No new tests since these are refactoring only.

  • CMakeLists.txt:
  • UseJSC.cmake:

2011-04-13 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Separate DerivedSources.
​https://bugs.webkit.org/show_bug.cgi?id=58427

  • CMakeLists.txt: Change DERIVED_SOURCES_DIR to DERIVED_SOURCES_WEBCORE_DIR
5:36 PM Changeset in webkit [83791] by mdelaney@apple.com
  • 1 edit in trunk/Source/WebCore/WebCore.gypi

Fixing burning chromium mac tree.

5:25 PM Changeset in webkit [83790] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Kenneth Russell.

[chromium] Fix canvas.toDataURL mimeType assertion
​https://bugs.webkit.org/show_bug.cgi?id=58425

Following r81213, reassert expected toDataURL() mimeType, remove an unused variable.

No new tests. Covered by existing tests.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageToDataURL): (WebCore::ImageBuffer::toDataURL):
4:54 PM Changeset in webkit [83789] by tony@chromium.org
  • 2 edits in trunk

2011-04-13 Tony Chang <​tony@chromium.org>

Ignore files generated from glu.gyp.

  • .gitignore:
4:54 PM Changeset in webkit [83788] by luiz@webkit.org
  • 4 edits in trunk/Source/WebCore

[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
​https://bugs.webkit.org/show_bug.cgi?id=58375

Reviewed by Andreas Kling.

As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.

Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::start):

  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):

4:52 PM Changeset in webkit [83787] by rolandsteiner@chromium.org
  • 5 edits
    8 adds in trunk

2011-04-13 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by David Hyatt.

Bug 55930 - Incorrect handling of 'display:' property within nested <ruby> tags
​https://bugs.webkit.org/show_bug.cgi?id=55930

Test that 'display: block' and 'display: table' on generated :before/:after content
within <ruby> doesn't crash.

  • fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • fast/ruby/after-block-doesnt-crash.html: Added.
  • fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • fast/ruby/after-table-doesnt-crash.html: Added.
  • fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • fast/ruby/before-block-doesnt-crash.html: Added.
  • fast/ruby/before-table-doesnt-crash-expected.txt: Added.
  • fast/ruby/before-table-doesnt-crash.html: Added.

2011-04-13 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by David Hyatt.

Bug 55930 - Incorrect handling of 'display:' property within nested <ruby> tags
​https://bugs.webkit.org/show_bug.cgi?id=55930

Non-inline :before/:after generated content is now wrapped with an anonymous inline block.

Also, added an additional check in RenderObjectChildList::updateBeforeAfterContent()
to verify that the created render object is legal under the parent.

Tests: fast/ruby/after-block-doesnt-crash.html

fast/ruby/after-table-doesnt-crash.html
fast/ruby/before-block-doesnt-crash.html
fast/ruby/before-table-doesnt-crash.html

  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  • rendering/RenderRuby.cpp: (WebCore::isAnonymousRubyInlineBlock): (WebCore::rubyBeforeBlock): (WebCore::rubyAfterBlock): (WebCore::createAnonymousRubyInlineBlock): (WebCore::lastRubyRun): (WebCore::RenderRubyAsInline::addChild): (WebCore::RenderRubyAsInline::removeChild): (WebCore::RenderRubyAsBlock::addChild): (WebCore::RenderRubyAsBlock::removeChild):
  • rendering/RenderRuby.h:
4:49 PM Changeset in webkit [83786] by mdelaney@apple.com
  • 6 edits
    9 adds
    7 deletes in trunk/Source/WebCore

2011-04-13 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

[CG] Refactor get/putImageData routines from ImageBufferCG into a (new) ImageBufferDataCG.cpp
​https://bugs.webkit.org/show_bug.cgi?id=58084

No new tests. Does not affect outward behavior.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/ImageBufferData.h: Added.
  • platform/graphics/cairo/ImageBufferData.h: Removed.
  • platform/graphics/cairo/ImageBufferDataCairo.h: Added.
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/cg/ImageBufferDataCG.cpp: Added. (WebCore::ImageBufferData::ImageBufferData): (WebCore::haveVImageRoundingErrorFix): (WebCore::ImageBufferData::getData): (WebCore::ImageBufferData::putData):
  • platform/graphics/cg/ImageBufferData.h: Removed.
  • platform/graphics/cg/ImageBufferDataCG.h: Added.
  • platform/graphics/chromium/ImageBufferData.h: Removed.
  • platform/graphics/chromium/ImageBufferDataSkia.h: Added.
  • platform/graphics/haiku/ImageBufferData.h: Removed.
  • platform/graphics/haiku/ImageBufferDataHaiku.h: Added.
  • platform/graphics/qt/ImageBufferData.h: Removed.
  • platform/graphics/qt/ImageBufferDataQt.h: Added.
  • platform/graphics/wince/ImageBufferData.h: Removed.
  • platform/graphics/wince/ImageBufferDataWince.h: Added.
  • platform/graphics/wx/ImageBufferData.h: Removed.
  • platform/graphics/wx/ImageBufferDataWx.h: Added.
4:36 PM Changeset in webkit [83785] by mdelaney@apple.com
  • 1 edit
    4 moves in trunk/LayoutTests

2011-04-13 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Chris Marrin.

Update layout test expected result files' locations
​https://bugs.webkit.org/show_bug.cgi?id=58492

  • platform/mac-snowleopard/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.miter.lineedge-expected.txt.
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt.
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.shadow.enable.x-expected.txt.
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.shadow.enable.y-expected.txt.
  • platform/mac/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.
4:33 PM Changeset in webkit [83784] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-04-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Remove std
prefix on some min/max calls ​https://bugs.webkit.org/show_bug.cgi?id=58493
Remove std
namespacing on min/max in favor of a 'using' clause.
  • platform/graphics/RoundedIntRect.cpp: (WebCore::RoundedIntRect::Radii::expand):
  • rendering/style/RenderStyle.cpp: (WebCore::calcConstraintScaleFor):
4:04 PM Changeset in webkit [83783] by mihaip@chromium.org
  • 5 edits in trunk/Tools

2011-04-13 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Eric Seidel.

[NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
​https://bugs.webkit.org/show_bug.cgi?id=58489

r83743 added --additional-platform-directory to old-run-webkit-tests,
rename the equivalent flag in new-run-webkit-tests to be consistent.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:03 PM Changeset in webkit [83782] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-04-13 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Jian Li.

[chromium] Remove unnecessary #define now that chrome has rolled to the latest WebKit
​https://bugs.webkit.org/show_bug.cgi?id=58474

  • DEPS:
  • public/WebSpellCheckClient.h:
3:54 PM Changeset in webkit [83781] by mihaip@chromium.org
  • 1 edit
    19 adds in trunk/Tools

2011-04-13 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Eric Seidel.

Rebaseline queue server
​https://bugs.webkit.org/show_bug.cgi?id=57891

Adds a simple rebaseline queue server (meant to run at
​http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
builders and their failing tests, and allows those tests to be added to
a per-builer rebaseline queue.

A subsequent change will add a mode to NRWT (and/or a wrapper script)
for pulling the tests to be rebaselined from the server and running them
with --reset-results (the initial use-case is for the GPU hardware bots,
which do not have checked-in baselines, therefore there is no need for a
check-in step yet).

  • RebaselineQueueServer/app.yaml: Added.
  • RebaselineQueueServer/handlers/init.py: Added.
  • RebaselineQueueServer/handlers/builderqueue.py: Added.
  • RebaselineQueueServer/handlers/pages.py: Added.
  • RebaselineQueueServer/index.yaml: Added.
  • RebaselineQueueServer/main.py: Added.
  • RebaselineQueueServer/model/init.py: Added.
  • RebaselineQueueServer/model/queueentry.py: Added.
  • RebaselineQueueServer/static/builder-frame-empty.html: Added.
  • RebaselineQueueServer/static/styles.css: Added.
  • RebaselineQueueServer/templates/builder-picker.html: Added.
  • RebaselineQueueServer/templates/builder-queue-edit.html: Added.
  • RebaselineQueueServer/templates/builder-queue-list.html: Added.
  • RebaselineQueueServer/templates/home.html: Added.
3:52 PM Changeset in webkit [83780] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, more chromium test expectations update.

  • platform/chromium/test_expectations.txt:
3:45 PM Changeset in webkit [83779] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebCore

2011-04-13 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

Replace our own RenderThemeQt::getMediaElementFromRenderObject by
MediaControlsElement::toParentMediaElement used by every other port.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMediaFullscreenButton): (WebCore::RenderThemeQt::paintMediaMuteButton): (WebCore::RenderThemeQt::paintMediaPlayButton): (WebCore::RenderThemeQt::paintMediaSliderTrack):
  • platform/qt/RenderThemeQt.h:
3:40 PM Changeset in webkit [83778] by enrica@apple.com
  • 3 edits in trunk/Source/WebKit2

Should not rely on WKEditableLinkBehavior being in synch
with WebCore::EditableLinkBehavior.
​https://bugs.webkit.org/show_bug.cgi?id=58473

Reviewed by Dan Bernstein.

Adding conversion routines.

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toAPI):
(WebKit::toEditableLinkBehavior):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetEditableLinkBehavior):
(WKPreferencesGetEditableLinkBehavior):

3:38 PM Changeset in webkit [83777] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

After closing the last window, re-opening my last visited website is over 2X slower
​https://bugs.webkit.org/show_bug.cgi?id=58488
<rdar://problem/9233518>

Give the web process a 60 second termination timeout.

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess):
3:29 PM Changeset in webkit [83776] by jberlin@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

inspector/debugger/script-formatter.html broken on a bunch of platforms since introduction
in r83748
​https://bugs.webkit.org/show_bug.cgi?id=58487

Disable the test until it is fixed to get the bots green.

  • inspector/debugger/script-formatter.html: Removed.
  • inspector/debugger/script-formatter.html-disabled: Copied from inspector/debugger/script-formatter.html.
3:24 PM Changeset in webkit [83775] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change / build fix. The file had
multiple checksums which confused NRWT.

  • platform/mac/compositing/framesets/composited-frame-alignment-expected.checksum:
3:24 PM Changeset in webkit [83774] by andersca@apple.com
  • 13 edits in trunk/Source/WebKit2

2011-04-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Convert WebProcess over to using disableTermination/enableTermination
​https://bugs.webkit.org/show_bug.cgi?id=58485

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::getSitesWithData): (WebKit::PluginProcess::clearSiteData): Use the LocalTerminationDisabler RAII class.
  • Shared/ChildProcess.h: (WebKit::ChildProcess::LocalTerminationDisabler::LocalTerminationDisabler): (WebKit::ChildProcess::LocalTerminationDisabler::~LocalTerminationDisabler): Add RAII class for calling disableTermination/enableTermination.
  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: (WebKit::WebApplicationCacheManager::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManager::deleteAllEntries): Use the LocalTerminationDisabler RAII class.
  • WebProcess/Cookies/WebCookieManager.cpp: (WebKit::WebCookieManager::getHostnamesWithCookies): (WebKit::WebCookieManager::deleteCookiesForHostname): (WebKit::WebCookieManager::deleteAllCookies): (WebKit::WebCookieManager::startObservingCookieChanges): (WebKit::WebCookieManager::setHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::getHTTPCookieAcceptPolicy): Use the LocalTerminationDisabler RAII class.
  • WebProcess/Downloads/Download.cpp: (WebKit::Download::Download): Call disableTermination().

(WebKit::Download::~Download):
Call enableTermination().

  • WebProcess/Downloads/DownloadManager.cpp: (WebKit::DownloadManager::downloadFinished): Remove call to terminateIfPossible.
  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp: (WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins): (WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin): (WebKit::WebKeyValueStorageManager::deleteAllEntries): Use the LocalTerminationDisabler RAII class.


  • WebProcess/MediaCache/WebMediaCacheManager.cpp: (WebKit::WebMediaCacheManager::getHostnamesWithMediaCache): (WebKit::WebMediaCacheManager::clearCacheForHostname): (WebKit::WebMediaCacheManager::clearCacheForAllHostnames): Use the LocalTerminationDisabler RAII class.


  • WebProcess/ResourceCache/WebResourceCacheManager.cpp: (WebKit::WebResourceCacheManager::getCacheOrigins): (WebKit::WebResourceCacheManager::clearCacheForOrigin): (WebKit::WebResourceCacheManager::clearCacheForAllOrigins): Use the LocalTerminationDisabler RAII class.


  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp: (WebKit::WebDatabaseManager::getDatabasesByOrigin): (WebKit::WebDatabaseManager::getDatabaseOrigins): (WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin): (WebKit::WebDatabaseManager::deleteDatabasesForOrigin): (WebKit::WebDatabaseManager::deleteAllDatabases): (WebKit::WebDatabaseManager::setQuotaForOrigin): Use the LocalTerminationDisabler RAII class.


  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::createWebPage): Call disableTermination().

(WebKit::WebProcess::removeWebPage):
Call enableTermination().

(WebKit::WebProcess::shouldTerminate):
Move logic from terminateIfPossible over here.

(WebKit::WebProcess::terminate):
Move logic from terminateIfPossible over here.

(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):
Use the LocalTerminationDisabler RAII class.

  • WebProcess/WebProcess.h: Publically inherit from ChildProcess, LocalTerminationDisabler needs to be accessible from the WebProcess class.
3:15 PM Changeset in webkit [83773] by ggaren@apple.com
  • 11 edits in trunk/Source

2011-04-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Switched DOM wrappers to use HashMap of Weak<T> instead of WeakGCMap<T>
​https://bugs.webkit.org/show_bug.cgi?id=58482


This will allow wrappers to make individual decisions about their lifetimes.

  • heap/HandleHeap.h: (JSC::HandleHeap::copyWeak): New function for copying a weak handle. It's wasn't previously possible to perform this operation using HandleHeap API because the HandleHeap doesn't expose its underlying Node structure.
  • heap/Local.h: (JSC::::set):
  • heap/Strong.h: (JSC::Strong::set): Added ASSERTs to verify that dead objects are not resurrected by placement into handles.

(JSC::swap): Added a swap helper, so use of Strong<T> inside a hash table
is efficient.

  • heap/Weak.h: (JSC::Weak::Weak): Fixed a bug where copying a weak pointer would not copy its weak callback and context.

(JSC::Weak::operator=): Added an assignment operator, since the default
C++ assignment operator did the wrong thing.

(JSC::Weak::set): Added ASSERTs to verify that dead objects are not
resurrected by placement into handles.

(JSC::swap): Added a swap helper, so use of Strong<T> inside a hash table
is efficient, and can be done without copying, which is illegal during
the handle finalization phase.

2011-04-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Switched DOM wrappers to use HashMap of Weak<T> instead of WeakGCMap<T>
​https://bugs.webkit.org/show_bug.cgi?id=58482

This will allow wrappers to make individual decisions about their lifetimes.

  • bindings/js/DOMWrapperWorld.cpp: (WebCore::DOMWrapperWorld::DOMWrapperWorld): (WebCore::JSNodeHandleOwner::isReachableFromOpaqueRoots): (WebCore::JSNodeHandleOwner::finalize): (WebCore::DOMObjectHandleOwner::isReachableFromOpaqueRoots): (WebCore::DOMObjectHandleOwner::finalize):
  • bindings/js/DOMWrapperWorld.h: (WebCore::JSNodeHandleOwner::JSNodeHandleOwner): (WebCore::DOMObjectHandleOwner::DOMObjectHandleOwner): (WebCore::DOMWrapperWorld::jsNodeHandleOwner): (WebCore::DOMWrapperWorld::domObjectHandleOwner): Added handle owners for JSNode and DOMObject, our two hash table values. For now, the owners just take care to remove their handles from their respective hash tables.


Changed the hash table type to be a standard HashMap of weak pointers,
instead of a WeakGCMap.

  • bindings/js/JSDOMBinding.cpp: (WebCore::getCachedDOMObjectWrapper): (WebCore::cacheDOMObjectWrapper): (WebCore::cacheDOMNodeWrapper): (WebCore::isObservableThroughDOM): (WebCore::markDOMNodesForDocument): (WebCore::takeWrappers): (WebCore::updateDOMNodeDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper): Updated wrapper hash table access to accomodate its new data type.
  • bindings/js/JSNodeCustom.h: (WebCore::getCachedDOMNodeWrapper): Ditto.
  • dom/Document.h: Updated declaration to match the above.
3:11 PM Changeset in webkit [83772] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Follow-up to: WebKit2 will load two copies of the same plugin, but should not
​https://bugs.webkit.org/show_bug.cgi?id=49075


Use pathGetFileName instead of Win32 PathFindFileNameW.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::shouldUsePlugin):
2:50 PM Changeset in webkit [83771] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Mac builds.

  • WebCore.exp.in:
2:39 PM Changeset in webkit [83770] by weinig@apple.com
  • 10 edits in trunk/Source

WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
<rdar://problem/9260518>

Reviewed by Gavin Barraclough.

Source/WebCore:

Notify the scrollbar painter controller when gesture scrolls begin and end.

  • WebCore.exp.in:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::endScrollGesture):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Initialize new WKSI functions.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Initialize new WKSI functions.

2:38 PM Changeset in webkit [83769] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver Hunt.

WebKit2 will load two copies of the same plugin, but should not
​https://bugs.webkit.org/show_bug.cgi?id=49075
<rdar://problem/8635947>

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::shouldUsePlugin): Don't use a plug-in if we've already allowed a plug-in with the same filename.
2:31 PM Changeset in webkit [83768] by timothy@apple.com
  • 5 edits in trunk/Source/WebKit2

Hide the dictionary panel when navigating or crashing.

<rdar://problem/9261202>

Reviewed by Sam Weinig.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::dismissDictionaryLookupPanel): Added. Call WKHideWordDefinitionWindow.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame): Call PageClient::dismissDictionaryLookupPanel.
(WebKit::WebPageProxy::processDidCrash): Call dismissCorrectionPanel and PageClient::dismissDictionaryLookupPanel.

2:29 PM Changeset in webkit [83767] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-04-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Add support for disabling/enabling termination to ChildProcess
​https://bugs.webkit.org/show_bug.cgi?id=58476

Add ChildProcess::disableTermination and ChildProcess::enableTermination and convert
the PluginProcess class over to using them.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::PluginProcess): The child process now takes a terminationTimeout argument. Get rid of the shutdown timer.

(WebKit::PluginProcess::removeWebProcessConnection):
Call enableTermination().

(WebKit::PluginProcess::shouldTerminate):
Always return true.

(WebKit::PluginProcess::createWebProcessConnection):
Call disableTermination().

(WebKit::PluginProcess::getSitesWithData):
Call disableTermination()/enableTermination().

(WebKit::PluginProcess::clearSiteData):
Ditto.

  • Shared/ChildProcess.cpp: (WebKit::ChildProcess::disableTermination): Increment the counter and stop the timer.

(WebKit::ChildProcess::enableTermination):
Decrement the counter; if it's zero, start the timer.

(WebKit::ChildProcess::terminationTimerFired):
Call shouldTerminate(). If it returns true, call terminate().

(WebKit::ChildProcess::terminate):
Call RunLoop::quit().

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): Just initialize the termination timeout to 0 for now.

(WebKit::WebProcess::shouldTerminate):
Always return true; this isn't used yet.

  • WebProcess/WebProcess.h:
2:26 PM Changeset in webkit [83766] by enrica@apple.com
  • 6 edits in trunk/Source/WebKit2

REGRESSION: Links are clickable when a contentEditable is set to true.
​https://bugs.webkit.org/show_bug.cgi?id=58473
<rdar://problem/9256793>

Reviewed by Dan Bernstein.

Added support for editable link behavior property.

  • Shared/WebPreferencesStore.cpp:
  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetEditableLinkBehavior):
(WKPreferencesGetEditableLinkBehavior):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

2:24 PM Changeset in webkit [83765] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

MediaPlayerPrivateAVFoundationObjC should adopt [AVURLAsset isPlayableExtendedMIMEType:]
​https://bugs.webkit.org/show_bug.cgi?id=58451
<rdar://problem/9278468>

No new tests, supported MIME types haven't changed.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType): Use [AVURLAsset isPlayableExtendedMIMEType] instead of just the list of types.
2:22 PM Changeset in webkit [83764] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

nrwt: enable multiple processes by default on Chromium Win.
​https://bugs.webkit.org/show_bug.cgi?id=55163

Re-land r79268; it should be more stable now and will hopefully
work.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2:11 PM Changeset in webkit [83763] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.

Media engine fallback doesn't always work
​https://bugs.webkit.org/show_bug.cgi?id=58462

No new tests, this was verified manually with the url noted in the bug.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::networkStateChanged):
2:08 PM Changeset in webkit [83762] by zmo@google.com
  • 12 edits in trunk/Source

2011-04-13 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Extension3D needs to provide a way to check if an extension is enabled
​https://bugs.webkit.org/show_bug.cgi?id=58410

Implement isEnabled() in chromium port.

  • src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::isEnabled):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::isExtensionEnabled):
  • src/GraphicsContext3DInternal.h:

2011-04-13 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Extension3D needs to provide a way to check if an extension is enabled
​https://bugs.webkit.org/show_bug.cgi?id=58410

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::setupFlags): Use isEnabled() instead of supports().
  • platform/graphics/Extensions3D.h: Add isEnabled().
  • platform/graphics/chromium/Extensions3DChromium.h: Ditto.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Ditto. (WebCore::Extensions3DOpenGL::isEnabled):
  • platform/graphics/opengl/Extensions3DOpenGL.h: Ditto.
  • platform/graphics/qt/Extensions3DQt.cpp: Ditto. (WebCore::Extensions3DQt::isEnabled):
  • platform/graphics/qt/Extensions3DQt.h: Ditto.
2:04 PM Changeset in webkit [83761] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations per change in r83756.

  • platform/chromium/test_expectations.txt:
2:01 PM Changeset in webkit [83760] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: configure logging in child processes properly
​https://bugs.webkit.org/show_bug.cgi?id=58296

Logging propagated properly from manager to worker processes on
Unix but not on Windows; this fixes that.

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
1:58 PM Changeset in webkit [83759] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: suppress extraneous pretty patch warnings
​https://bugs.webkit.org/show_bug.cgi?id=58295

NRWT wasn't being careful about when it logged messages from
PrettyPatch not being available; it should only log during
check_build(), and be silent otherwise. This was causing us to
get multiple errors at runtime, which was confusing.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
1:37 PM Changeset in webkit [83758] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations to work around a bug
in gpu test expectations handling.

  • platform/chromium/test_expectations.txt:
1:13 PM Changeset in webkit [83757] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Mark compositing/webgl/webgl-reflection.html as failed for all platforms
in chromium.

  • platform/chromium/test_expectations.txt:
1:11 PM Changeset in webkit [83756] by cmarrin@apple.com
  • 2 edits
    13 adds
    4 deletes in trunk/LayoutTests

2011-04-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

compositing/objects/composited-object-alignment.html causing failures in other tests since its introduction in r83518
​https://bugs.webkit.org/show_bug.cgi?id=58323

Got rid of unnecessary JS from composited-subframe.html. This was mistakenly left in from previous experiments.
Also moved pixel results to be platform specific. These are for Mac WebKit and WebKit2. There are color diffs
between the two platforms, so I will make them all platform specific.

  • compositing/framesets/composited-frame-alignment-expected.checksum: Removed.
  • compositing/framesets/composited-frame-alignment-expected.png: Removed.
  • compositing/objects/composited-object-alignment-expected.checksum: Removed.
  • compositing/objects/composited-object-alignment-expected.png: Removed.
  • compositing/objects/resources/composited-subframe.html:
  • platform/mac-wk2/compositing: Added.
  • platform/mac-wk2/compositing/framesets: Added.
  • platform/mac-wk2/compositing/framesets/composited-frame-alignment-expected.checksum: Added.
  • platform/mac-wk2/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/mac-wk2/compositing/objects: Added.
  • platform/mac-wk2/compositing/objects/composited-object-alignment-expected.checksum: Added.
  • platform/mac-wk2/compositing/objects/composited-object-alignment-expected.png: Added.
  • platform/mac/compositing/framesets: Added.
  • platform/mac/compositing/framesets/composited-frame-alignment-expected.checksum: Added.
  • platform/mac/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/mac/compositing/objects: Added.
  • platform/mac/compositing/objects/composited-object-alignment-expected.checksum: Copied from LayoutTests/compositing/objects/composited-object-alignment-expected.checksum.
  • platform/mac/compositing/objects/composited-object-alignment-expected.png: Copied from LayoutTests/compositing/objects/composited-object-alignment-expected.png.
12:30 PM Changeset in webkit [83755] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<​http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm

Reviewed by Anders Carlsson.

Fixes the following warning with -Wcast-align enabled:

Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]

archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));

~

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage isNativeLibraryData:]): Added
COMPILE_ASSERT() to make sure our pointer math is valid.
Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
by sizeof(uint32_t) to fix the pointer math. Replaced C-style
casts with reinterpret_cast.

12:08 PM Changeset in webkit [83754] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Exclude webkitGetUserMedia from the navigator-detached-no-crash test.
​https://bugs.webkit.org/show_bug.cgi?id=58459

Patch by Leandro Gracia Gil <​leandrogracia@chromium.org> on 2011-04-13
Reviewed by Jian Li.

Exclude the MediaStream API methods from the test until the feature
is supported by most platforms.

  • fast/dom/navigator-detached-no-crash.html:
11:58 AM Changeset in webkit [83753] by jianli@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed, rebaseline 2 tests for linux64 in chromium.

  • platform/chromium-linux-x86_64/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
11:52 AM Changeset in webkit [83752] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Jian Li.

add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=58461

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
11:48 AM Changeset in webkit [83751] by oliver@apple.com
  • 26 edits in trunk/Source

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Make PropertyMapEntry use a WriteBarrier for specificValue
​https://bugs.webkit.org/show_bug.cgi?id=58407

Make PropertyMapEntry use a WriteBarrier for specificValue, and then
propagate the required JSGlobalData through all the methods it ends
up being needed.

  • API/JSClassRef.cpp: (OpaqueJSClass::prototype):
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp: (JSObjectMake): (JSObjectSetPrototype):
  • JavaScriptCore.exp:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator):
  • interpreter/Interpreter.cpp: (JSC::appendSourceToError): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::name): (JSC::InternalFunction::displayName):
  • runtime/JSActivation.cpp: (JSC::JSActivation::getOwnPropertySlot):
  • runtime/JSFunction.cpp: (JSC::JSFunction::name): (JSC::JSFunction::displayName): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::putWithAttributes): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype):
  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::deleteProperty): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::lookupGetter): (JSC::JSObject::lookupSetter): (JSC::JSObject::getPropertySpecificValue): (JSC::JSObject::getOwnPropertyNames): (JSC::JSObject::seal): (JSC::JSObject::freeze): (JSC::JSObject::preventExtensions): (JSC::JSObject::removeDirect): (JSC::JSObject::getOwnPropertyDescriptor): (JSC::JSObject::defineOwnProperty):
  • runtime/JSObject.h: (JSC::JSObject::getDirect): (JSC::JSObject::getDirectLocation): (JSC::JSObject::isSealed): (JSC::JSObject::isFrozen): (JSC::JSObject::setPrototypeWithCycleCheck): (JSC::JSObject::setPrototype): (JSC::JSObject::inlineGetOwnPropertySlot): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/ObjectConstructor.cpp: (JSC::objectConstructorCreate): (JSC::objectConstructorSeal): (JSC::objectConstructorFreeze): (JSC::objectConstructorPreventExtensions): (JSC::objectConstructorIsSealed): (JSC::objectConstructorIsFrozen):
  • runtime/Operations.h: (JSC::normalizePrototypeChain):
  • runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry): (JSC::PropertyTable::PropertyTable): (JSC::PropertyTable::copy):
  • runtime/Structure.cpp: (JSC::Structure::materializePropertyMap): (JSC::Structure::despecifyDictionaryFunction): (JSC::Structure::addPropertyTransition): (JSC::Structure::removePropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::toCacheableDictionaryTransition): (JSC::Structure::toUncacheableDictionaryTransition): (JSC::Structure::sealTransition): (JSC::Structure::freezeTransition): (JSC::Structure::preventExtensionsTransition): (JSC::Structure::isSealed): (JSC::Structure::isFrozen): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::removePropertyWithoutTransition): (JSC::Structure::copyPropertyTable): (JSC::Structure::get): (JSC::Structure::despecifyFunction): (JSC::Structure::despecifyAllFunctions): (JSC::Structure::put): (JSC::Structure::getPropertyNames):
  • runtime/Structure.h: (JSC::Structure::get): (JSC::Structure::materializePropertyMapIfNecessary):

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Make PropertyMapEntry use a WriteBarrier for specificValue
​https://bugs.webkit.org/show_bug.cgi?id=58407

Pass JSGlobalData reference on to APIs that now need them

  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::all):
11:05 AM LayoutTestResultFallbackOrder edited by tony@chromium.org
(diff)
11:04 AM Changeset in webkit [83750] by tony@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-04-12 Tony Chang <​tony@chromium.org>

Reviewed by Adam Roben.

make PrettyPatch.rb aware of checksums in png files
​https://bugs.webkit.org/show_bug.cgi?id=58387

  • PrettyPatch/PrettyPatch.rb:
10:22 AM Changeset in webkit [83749] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-04-13 Tony Chang <​tony@chromium.org>

Unreviewed, fix NRWT. Stack:

return super(ChromiumPort, self).results_directory(self)

TypeError: results_directory() takes exactly 1 argument (2 given)

  • Scripts/webkitpy/layout_tests/port/chromium.py:
10:06 AM LayoutTestResultFallbackOrder edited by tony@chromium.org
(diff)
10:05 AM LayoutTestResultFallbackOrder created by tony@chromium.org
from …
10:01 AM WikiStart edited by tony@chromium.org
(diff)
9:45 AM Changeset in webkit [83748] by podivilov@chromium.org
  • 7 edits
    1 add in trunk

2011-04-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix source mapping for deobfuscated scripts.
​https://bugs.webkit.org/show_bug.cgi?id=58231

  • inspector/debugger/resources/obfuscated.js: Added.
  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:

2011-04-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix source mapping for de-obfuscated scripts.
​https://bugs.webkit.org/show_bug.cgi?id=58231

  • inspector/front-end/ScriptFormatterWorker.js: (buildMapping):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceMapping): (WebInspector.SourceMapping.prototype.sourceLineToScriptLocation): (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation): (WebInspector): (WebInspector.FormattedSourceMapping): (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine): (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
9:33 AM Changeset in webkit [83747] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Consider editable and non editable nodes when calculating selection offsets
​https://bugs.webkit.org/show_bug.cgi?id=58431

Use firstPositionInOrBeforeNode() and lastPositionInOrAfterNode().

This is needed to ensure that getSelectionOffsetsForObject() works
well when non editable nodes are present in the selection, since
firstPositionInNode() and lastPositionInNode() don't work in those
cases (they assume the node is editable).

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getSelectionOffsetsForObject): Updated calls.
9:27 AM Changeset in webkit [83746] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Missing nullchecks in GTK's a11y wrapper
​https://bugs.webkit.org/show_bug.cgi?id=58429

Add missing nullchecks for coreObject->document().

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkParentOfRootObject): Add missing nullcheck. (getPangoLayoutForAtk): Ditto. (webkit_accessible_text_get_caret_offset): Ditto. (textExtents): Ditto. (webkit_accessible_editable_text_insert_text): Ditto. (webkit_accessible_editable_text_delete_text): Ditto.
9:17 AM Changeset in webkit [83745] by Martin Robinson
  • 3 edits in trunk/Source/WebCore

2011-04-13 Thierry Reding <​thierry.reding@avionic-design.de>

Gtk+ port fails to build when enabling WebGL
​https://bugs.webkit.org/show_bug.cgi?id=58434

Fix the GTK+ WebGL build after the introduction of PlatformContextCairo.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: (WebCore::GraphicsContext3D::paintToCanvas):
9:15 AM Changeset in webkit [83744] by Philippe Normand
  • 2 edits
    4 adds in trunk/LayoutTests

2011-04-13 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK platform results for full-screen-zIndex.html test.

[GTK] fullscreen/full-screen-zIndex.html fails
​https://bugs.webkit.org/show_bug.cgi?id=58444

  • platform/gtk/Skipped:
  • platform/gtk/fullscreen/full-screen-zIndex-expected.checksum: Added.
  • platform/gtk/fullscreen/full-screen-zIndex-expected.png: Added.
  • platform/gtk/fullscreen/full-screen-zIndex-expected.txt: Added.
9:12 AM Changeset in webkit [83743] by Adam Roben
  • 2 edits in trunk/Tools

Teach ORWT about extra platform-specific directories to be searched before the default ones

Fixes <​http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
platform-specific results

Reviewed by Anders Carlsson.

  • Scripts/old-run-webkit-tests:

(top-level): Added @additionalPlatformDirectories and hooked up
--additional-platform-directories to populate it.
(buildPlatformResultHierarchy): Prepend the additional platform directories to the default
list (after filtering out any of the additional directories that don't exist).

8:55 AM Changeset in webkit [83742] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/inspector/extensions-resources-redirect.html and
inspector/extensions/extensions-resources.html sometimes fail on Windows 7 Release (WebKit2
Tests).
​https://bugs.webkit.org/show_bug.cgi?id=57491

Add the tests to the win-wk2 Skipped list to get the bots green.

  • platform/win-wk2/Skipped:
8:49 AM Changeset in webkit [83741] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-04-12 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

REGRESSION(r83561): doesn't pause in-window playback during fullscreen playback
​https://bugs.webkit.org/show_bug.cgi?id=58312

Make sure to link the videoValve in all cases, fpsdisplaysink
being used or not.

No new test, this patch fixes an internal feature of the player,
not publicly exposed. Having two video sinks and pausing one while
the other displays the fullscreen video is an implementation
detail of the GStreamer player.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
8:45 AM Changeset in webkit [83740] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-04-13 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing fullscreen test on GTK.

  • platform/gtk/Skipped:
8:44 AM Changeset in webkit [83739] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: there is a problem if an optional param is not at the end of a params list.
​https://bugs.webkit.org/show_bug.cgi?id=58440

In InspectorBackend.dispatch method we are converting the message's params object into array of arguments
for a callback. But in some cases the optional parameter is declared in the middle of the params list.
That gets us into a problem if this param has been skipped in the message. In that case the tail of the
event params will be shifted. We can slightly modify dispatcher and it will put the params in right places.

  • inspector/CodeGeneratorInspector.pm:
8:33 AM Changeset in webkit [83738] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Windows XP Debug Tests] fast/events/pageshow-pagehide-on-back-cached-with-frames.html
failing since r83699
​https://bugs.webkit.org/show_bug.cgi?id=58441

Add the Windows-XP specific expected failing results to get the bots green.

  • platform/win-xp/fast/events: Added.
  • platform/win-xp/fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt: Added.
8:02 AM Changeset in webkit [83737] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-04-13 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline of an svg test updated in r83710 and
skip an http test using unimplemented DRT features.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/text-dom-01-f-expected.txt:
7:58 AM Changeset in webkit [83736] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=57337

Work around a bug in ternary opertions in the Solaris Studio
12/12.1/12.2 compilers, using an if clause.

  • dom/NodeRenderStyle.h: (WebCore::Node::renderStyle):
7:57 AM Changeset in webkit [83735] by Lucas Forschler
  • 2 edits in trunk/Tools

Add /T to TaskKill.exe

7:55 AM Changeset in webkit [83734] by Lucas Forschler
  • 2 edits in trunk/Tools

Sort task kill list

7:33 AM Changeset in webkit [83733] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-13 Brian Salomon <​bsalomon@google.com>

Reviewed by Kenneth Russell.

Use new skia API for wrapping DrawingBuffer's FBO/Tex IDs in skia object
​https://bugs.webkit.org/show_bug.cgi?id=58363

No new tests needed, exercised by all existing canvas2d tests.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::getGrPlatformSurfaceDesc):
  • platform/graphics/gpu/DrawingBuffer.h:
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
7:28 AM Changeset in webkit [83732] by Lucas Forschler
  • 2 edits in trunk/Tools

2011-04-13 Lucas Forschler <Lucas Forschler>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=58384
Update kill-old-processes to include a few new ones.

  • BuildSlaveSupport/win/kill-old-processes:
7:26 AM Changeset in webkit [83731] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Fix chromium clang build problem:
ApplyPropertyExpandingSuppressValue::applyValue() shadows a virtual method
with a different signature in base class instead of overriding it.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyExpandingSuppressValue::applyValue):
7:25 AM Changeset in webkit [83730] by caseq@chromium.org
  • 5 edits
    16 adds
    4 deletes in trunk/LayoutTests

2011-04-13 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Rebaselined SVG test expectations following mac expectations change in r83710.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-dom-01-f-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/text-dom-01-f-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-dom-01-f-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/text-dom-01-f-expected.png:
  • platform/chromium-win/svg/custom/text-dom-01-f-expected.txt:
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
  • platform/chromium-win/svg/text/lengthAdjust-text-metrics-expected.txt:
7:20 AM Changeset in webkit [83729] by kinuko@chromium.org
  • 8 edits
    8 adds in trunk/Source

2011-04-13 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Add mock implementation and plumbing code for unified Quota API
​https://bugs.webkit.org/show_bug.cgi?id=57927

Added plumbing code for the quota API, that is based on the
discussion on public-webapps:
​http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html

  • WebKit.gyp: Added new file entries.
  • src/StorageInfoChromium.cpp: Added.
  • src/WebStorageQuotaCallbacksImpl.cpp: Added. An implementation of WebStorageQuotaCallbacks.
  • src/WebStorageQuotaCallbacksImpl.h: Added.

2011-04-13 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Add mock implementation and plumbing code for unified Quota API
​https://bugs.webkit.org/show_bug.cgi?id=57927

Added mock implementation and some plumbing code for the quota API,
that is based on the discussion on public-webapps:
​http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html

No new tests: tests will be added when we expose the API.

  • CMakeLists.txt: Added new file entries.
  • DerivedSources.cpp: Added new file entries.
  • DerivedSources.make: Added new file entries.
  • GNUmakefile.am: Added new file entries.
  • WebCore.gypi: Added new file entries.
  • WebCore.pro: Added new file entries.
  • WebCore.vcproj/WebCore.vcproj: Added new file entries.
  • WebCore.xcodeproj/project.pbxproj: Added new file entries.
  • storage/StorageInfo.cpp: Added.
  • storage/StorageInfo.h: Added.
  • storage/StorageInfoErrorCallback.h: Added.
  • storage/StorageInfoQuotaCallback.h: Added.
  • storage/StorageInfoUsageCallback.h: Added.
7:05 AM Changeset in webkit [83728] by commit-queue@webkit.org
  • 4 edits in trunk

2011-04-13 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Martin Robinson.

[GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
​https://bugs.webkit.org/show_bug.cgi?id=58297

Make sure we do not load plugins that use symbols of a different
GTK+ major version to avoid bugs and crashes.

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::moduleMixesGtkSymbols): (WebCore::PluginPackage::load):

2011-04-13 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Martin Robinson.

[GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
​https://bugs.webkit.org/show_bug.cgi?id=58297

Do not disable flash specifically when built with GTK+ 3 -
PluginPackage should do the right thing while loading plugins.

  • GtkLauncher/main.c: (main):
7:04 AM Changeset in webkit [83727] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit/efl

2011-04-13 Grzegorz Czajkowski <​g.czajkowski@samsung.com>

Reviewed by Kent Tamura.

[EFL] Doxygen documentation for ewk_main, ewk_history and tools
​https://bugs.webkit.org/show_bug.cgi?id=58428

  • ewk/EWebKit.h:
  • ewk/ewk_eapi.h:
  • ewk/ewk_history.h:
  • ewk/ewk_logging.h:
  • ewk/ewk_main.cpp:
  • ewk/ewk_main.h:
  • ewk/ewk_private.h:
  • ewk/ewk_util.cpp:
  • ewk/ewk_util.h:
7:01 AM Changeset in webkit [83726] by tonyg@chromium.org
  • 3 edits
    1 move in trunk/LayoutTests

2011-04-13 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by David Levin.

[chromium] Regression(r80861): fast/dom/Window/window-lookup-precedence.html started failing on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=56608

Previously the test unintentionally navigated the iframe when setting
window.location. Instead, now, we just skip setting window.location.

  • fast/dom/Window/window-lookup-precedence.html:
  • platform/chromium-win/fast/dom/Window/window-lookup-precedence-expected.txt: Moved to chromium.
  • platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt: Moved from chromium-win.
  • platform/chromium/test_expectations.txt:
6:39 AM Changeset in webkit [83725] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-13 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Implement undo/redo in text editor
​https://bugs.webkit.org/show_bug.cgi?id=58426

Native undo/redo does not work because we modify DOM structure (highlights, chunks and etc.)
Implement it via keyboard shortcuts for now (Cmd/Ctrl+Z and Cmd/Ctrl+Shift+Z).
FIXME: Do something with the popup's Undo and Redo menu options - they invoke native's undo/redo.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.endEditing):
  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype.setText): (WebInspector.TextEditorModel.prototype._innerSetText): (WebInspector.TextEditorModel.prototype._pushUndoableCommand): (WebInspector.TextEditorModel.prototype.undo): (WebInspector.TextEditorModel.prototype.redo): (WebInspector.TextEditorModel.prototype._doUndo):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._textChanged): (WebInspector.TextViewer.prototype._enterInternalTextChangeMode): (WebInspector.TextViewer.prototype._exitInternalTextChangeMode): (WebInspector.TextViewer.prototype._registerShortcuts): (WebInspector.TextViewer.prototype._cancelEditing): (WebInspector.TextViewer.prototype._handleUndoRedo): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo.callback): (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo): (WebInspector.TextEditorMainPanel.prototype._restoreSelection): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
6:24 AM Changeset in webkit [83724] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-04-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make optional event parameter last to prevent regressions.
​https://bugs.webkit.org/show_bug.cgi?id=58433

  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::willSendRequest):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
6:12 AM Changeset in webkit [83723] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

LayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work in WK2
​http://webkit.org/b/58334

Make same changes in Qt WK2 Skipped list as r83595 in Mac WK2 Skipped list.

  • platform/qt-wk2/Skipped: Skip a new test due to an identified bug in WKTR and classify three other skipped tests with that same bug.
5:24 AM Changeset in webkit [83722] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: revert Inspector.json change for breaking world.

  • inspector/Inspector.json:
5:14 AM Changeset in webkit [83721] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: swap methods in the Inspector.json.

  • inspector/Inspector.json:
4:41 AM Changeset in webkit [83720] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebCore

2011-04-13 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r83695.
​http://trac.webkit.org/changeset/83695
​https://bugs.webkit.org/show_bug.cgi?id=58375

[Qt][WK2]It broke http tests

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::start): (WebCore::QNetworkReplyHandler::synchronousLoad):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::resourceResponse): (WebCore::WebCoreSynchronousLoader::resourceError): (WebCore::WebCoreSynchronousLoader::data): (WebCore::WebCoreSynchronousLoader::setReplyFinished): (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::WebCoreSynchronousLoader::didReceiveResponse): (WebCore::WebCoreSynchronousLoader::didReceiveData): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::WebCoreSynchronousLoader::waitForCompletion): (WebCore::ResourceHandle::loadResourceSynchronously):
4:37 AM Changeset in webkit [83719] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-13 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inactive style sheets should be read only.
​https://bugs.webkit.org/show_bug.cgi?id=58423

  • inspector/front-end/ResourceView.js: (WebInspector.CSSSourceFrame): (WebInspector.CSSSourceFrame.prototype.isContentEditable): (WebInspector.CSSSourceFrame.prototype._loadStyleSheet.didGetAllStyleSheets.didCreateForId): (WebInspector.CSSSourceFrame.prototype._loadStyleSheet):
4:35 AM Changeset in webkit [83718] by mnaganov@chromium.org
  • 12 edits
    1 add in trunk

2011-04-13 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Prepare to move detailed heap snapshots storage and processing into workers.
​https://bugs.webkit.org/show_bug.cgi?id=58320

Introduce a proxy object that emulates worker behavior and change UI code to cope with it.

  • inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest):

2011-04-13 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Prepare to move detailed heap snapshots storage and processing into workers.
​https://bugs.webkit.org/show_bug.cgi?id=58320

Introduce a proxy object that emulates worker behavior and change UI code to cope with it.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate.sorted): (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate): (WebInspector.HeapSnapshotGridNode.prototype._populate): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren): (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort.afterPopulate): (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort): (WebInspector.HeapSnapshotGridNode.prototype.sort): (WebInspector.HeapSnapshotGenericObjectNode): (WebInspector.HeapSnapshotGenericObjectNode.prototype.get _shallowSizePercent): (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren): (WebInspector.HeapSnapshotObjectNode): (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode): (WebInspector.HeapSnapshotObjectNode.prototype._createProvider): (WebInspector.HeapSnapshotInstanceNode): (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode): (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider): (WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode): (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotIteratorsTuple.prototype.sortAndRewind): (WebInspector.HeapSnapshotDiffNode.prototype._calculateDiff): (WebInspector.HeapSnapshotDiffNode.prototype._createChildNode): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotDiffNode.prototype._childHashForEntity): (WebInspector.HeapSnapshotDiffNode.prototype._childHashForNode): (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated): (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated): (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren): (WebInspector.HeapSnapshotDominatorObjectNode): (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode): (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged): (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting): (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource): (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.baseSnapshotNodeIdsReceived): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.pushBaseSnapshotNodeIds): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.snapshotNodeIdsReceived): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren): (WebInspector.HeapSnapshotRetainingPathsList): (WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths): (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource): (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext): (WebInspector.DetailedHeapshotView.profileCallback): (WebInspector.DetailedHeapshotView): (WebInspector.DetailedHeapshotView.prototype.get profileWrapper): (WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper): (WebInspector.DetailedHeapshotView.prototype.show.profileCallback1): (WebInspector.DetailedHeapshotView.prototype.show.profileCallback2): (WebInspector.DetailedHeapshotView.prototype.show): (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
  • inspector/front-end/HeapSnapshot.js:
  • inspector/front-end/HeapSnapshotProxy.js: Added.
  • inspector/front-end/PleaseWaitMessage.js:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset): (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
3:45 AM Changeset in webkit [83717] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Update Qt specific expected results after r83710.

  • platform/qt/svg/custom/text-dom-01-f-expected.txt:
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt:
3:20 AM Changeset in webkit [83716] by apavlov@chromium.org
  • 4 edits in trunk

2011-04-13 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Web Page Performance auditing fails
​https://bugs.webkit.org/show_bug.cgi?id=58322

  • inspector/audits/audits-panel-functional.html:

2011-04-13 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Web Page Performance auditing fails
​https://bugs.webkit.org/show_bug.cgi?id=58322

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
2:51 AM Changeset in webkit [83715] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: enumerate properties in Inspector.json using array, not object keys.
​https://bugs.webkit.org/show_bug.cgi?id=58418

  • inspector/Inspector.json:
2:33 AM Changeset in webkit [83714] by hans@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-04-12 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

Chromium: Set ENABLE_LEVELDB=1 and add leveldb and snappy to DEPS
​https://bugs.webkit.org/show_bug.cgi?id=58343

Set ENABLE_LEVELDB=1 so that code gets compiled by the EWS bots.
Add the necessary dependencies to the DEPS file.

  • DEPS:
  • features.gypi:
2:32 AM Changeset in webkit [83713] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-06 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add "De-obfuscate Source" item to source frame text area context menu.
​https://bugs.webkit.org/show_bug.cgi?id=57942

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.formatSourceFilesToggled):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.toggleFormatSourceFiles): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._contextMenu): (WebInspector.SourceFrame.prototype._populateLineGutterContextMenu): (WebInspector.SourceFrame.prototype._populateTextAreaContextMenu): (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult): (WebInspector.SourceFrameDelegate.prototype.toggleFormatSourceFiles): (WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled):
2:22 AM Changeset in webkit [83712] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2011-04-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg has different output on Windows
​https://bugs.webkit.org/show_bug.cgi?id=58421

  • platform/win/Skipped: Skip svdgdom-over-01-f.svg test. The test is fine, but its missing a line compared to the mac output.
2:00 AM Changeset in webkit [83711] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-04-13 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed.
Rebaselined expectations following console message format change in V8 bindings.

  • platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt:
  • platform/chromium/fast/js/recursion-limit-equal-expected.txt:
1:42 AM Changeset in webkit [83710] by Nikolas Zimmermann
  • 19 edits
    24 adds in trunk

2011-04-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGTextContentElements textLength returns 0
​https://bugs.webkit.org/show_bug.cgi?id=52543

Add proper handling of the SVGTextContentElement textLength property, according to SVG 1.1 2nd edition.

If the textLength attributes is not explicitely set "textContentElement.textLength.baseVal"
will return the same as "textContentElement.getComputedTextLength()". If it's set the values
aren't equal anymore. getComputedTextLength() ignores the textLength attributes as well as the
lengthAdjust attribute. Adapt all of SVGTextQuery to ignore the lengthAdjust/textLength attributes.
This is how Opera implements it, and it makes sense to a certain degree, as otherwhise getComputedTextLength()
and textLength.baseVal.value would always be the same. Nor does the spec mention that textLength is honored
in the SVG Text DOM API.

Fixes svg/custom/text-dom-01-f.svg (from SVG 1.1 2nd edition, should be moved into the new W3C-SVG-1.1-SE directory).
Fixes svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg (last subtest related to textLength now passes).

Added new svg/dynamic-updates testcases covering dynamic changes of lengthAdjust/textLength and the synchronization
with getComputedTextLength().

Tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg

svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html
svg/dynamic-updates/SVGTextElement-dom-textLength-attr.html
svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html
svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop.html

  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint):
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::offsetForPositionInFragment): (WebCore::SVGInlineTextBox::selectionRect): (WebCore::SVGInlineTextBox::paintSelectionBackground): (WebCore::SVGInlineTextBox::paint): (WebCore::SVGInlineTextBox::calculateBoundaries):
  • rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::buildTextChunks): (WebCore::SVGTextChunkBuilder::layoutTextChunks): (WebCore::SVGTextChunkBuilder::addTextChunk): (WebCore::SVGTextChunkBuilder::processTextChunk): (WebCore::SVGTextChunkBuilder::processTextLengthSpacingCorrection): (WebCore::SVGTextChunkBuilder::processTextAnchorCorrection):
  • rendering/svg/SVGTextFragment.h: (WebCore::SVGTextFragment::SVGTextFragment): (WebCore::SVGTextFragment::buildFragmentTransform): (WebCore::SVGTextFragment::transformAroundOrigin): (WebCore::SVGTextFragment::buildTransformForTextOnPath): (WebCore::SVGTextFragment::buildTransformForTextOnLine):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): (WebCore::SVGTextLayoutEngine::beginTextPathLayout): (WebCore::dumpTextBoxes): (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices): (WebCore::SVGTextLayoutEngine::finishLayout): (WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
  • rendering/svg/SVGTextQuery.cpp: (WebCore::SVGTextQuery::textLengthCallback): (WebCore::SVGTextQuery::subStringLengthCallback): (WebCore::SVGTextQuery::startPositionOfCharacterCallback): (WebCore::SVGTextQuery::endPositionOfCharacterCallback): (WebCore::SVGTextQuery::rotationOfCharacterCallback): (WebCore::calculateGlyphBoundaries):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::SVGTextContentElement): (WebCore::SVGTextContentElement::synchronizeTextLength): (WebCore::SVGTextContentElement::textLengthAnimated): (WebCore::SVGTextContentElement::parseMappedAttribute): (WebCore::SVGTextContentElement::svgAttributeChanged):
  • svg/SVGTextContentElement.h: (WebCore::SVGTextContentElement::specifiedTextLength):
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::svgAttributeChanged):
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged):

2011-04-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGTextContentElements textLength returns 0
​https://bugs.webkit.org/show_bug.cgi?id=52543

Add new testcases from SVG 1.1 2nd edition. Correct all existing tests using textLength + SVG DOM Text API,
as we're not including textLength/lengthAdjust="spacingAndGlyphs" anymore in the SVGTextQuery results.
This matches Opera and a discussion on www-svg some time ago: ​http://www.w3.org/2010/05/24-svg-minutes.html.

  • platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
  • platform/mac/svg/custom/text-dom-01-f-expected.checksum:
  • platform/mac/svg/custom/text-dom-01-f-expected.png:
  • platform/mac/svg/custom/text-dom-01-f-expected.txt:
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
  • svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg: Added.
  • svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html: Added.
  • svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-dom-textLength-attr.html: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGTextElement-dom-lengthAdjust-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-dom-textLength-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-lengthAdjust-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-textLength-prop.js: Added. (executeTest):
  • svg/text/lengthAdjust-text-metrics-expected.txt:
  • svg/text/resources/SelectionTestCase.js: (transformPoint): (transformRect): (toAbsoluteCoordinates): (selectRange):
  • svg/text/script-tests/lengthAdjust-text-metrics.js: (transformPoint): (transformRect): (numberToString): (lengthToString): (pointToString): (rectToString):
1:14 AM Changeset in webkit [83709] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-13 Paul Knight <​pknight@apple.com>

Reviewed by Gavin Barraclough.

BACKTRACE() macro should check for Debug configuration in macro, not WTFReportBacktrace definition
​https://bugs.webkit.org/show_bug.cgi?id=58405

The BACKTRACE() macro requires JavaScriptCore be built with a Debug
configuration in order for it to be enabled. Move the NDEBUG check to
the header so it will be enabled when the calling framework or
application is built with a Debug configuration, similar to how
ASSERT() and friends work.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
12:52 AM Changeset in webkit [83708] by caseq@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Fixed chromium test expectations.

12:22 AM Changeset in webkit [83707] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: requestDocument can result in race condition in DOMAgent.js
​https://bugs.webkit.org/show_bug.cgi?id=58415

  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.requestDocument.onDocumentAvailable): (WebInspector.DOMAgent.prototype.requestDocument):
12:04 AM Changeset in webkit [83706] by pfeldman@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-04-12 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: another pass of protocol renames.
​https://bugs.webkit.org/show_bug.cgi?id=58340

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getDocument): (WebCore::InspectorDOMAgent::performSearch): (WebCore::InspectorDOMAgent::setSearchingForNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._setSearchingForNode): (WebInspector.ElementsPanel.prototype.setSearchingForNode):

Apr 12, 2011:

11:54 PM Changeset in webkit [83705] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-12 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Adjusted chromium test expectations

  • adding WIN crash for webgl-reflection.html
  • platform/chromium/test_expectations.txt:
11:45 PM Changeset in webkit [83704] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-12 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=58131

Provide a workaround for an obscure Studio 12 compiler bug, which
couldn't call src->~T() on a const T *src.

  • wtf/Vector.h:
11:34 PM Changeset in webkit [83703] by caseq@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Fixed malformed chromium test expectations line.

11:05 PM Changeset in webkit [83702] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-12 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Adjusted chromium test expectations:

  • missing expectations for child-layer-3d-sorting.html
  • adopt-node-crash.html crash of mac debug gpu
  • platform/chromium/test_expectations.txt:
10:47 PM Changeset in webkit [83701] by tkent@chromium.org
  • 8 edits in trunk

2011-04-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add WebSettings::setValidationMessageTimerMagnification()
​https://bugs.webkit.org/show_bug.cgi?id=57426

  • platform/chromium/test_expectations.txt: Remove validation-message-appearance.html because it becomes non-flaky by the DRT change.

2011-04-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add WebSettings::setValidationMessageTimerMagnification()
​https://bugs.webkit.org/show_bug.cgi?id=57426

  • public/WebSettings.h: Declare new function.
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setValidationMessageTimerMagnification): Passing the specified value to WebCore::Settings.
  • src/WebSettingsImpl.h: Declare new function.

2011-04-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add WebSettings::setValidationMessageTimerMagnification()
​https://bugs.webkit.org/show_bug.cgi?id=57426

  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): Disable the validation message timer.
10:12 PM Changeset in webkit [83700] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-12 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Implement remaining Background and Mask css properties in CSSStyleApplyProperty
​https://bugs.webkit.org/show_bug.cgi?id=58390

No new tests required as no functionality changed.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyExpanding): Class to expand one property to 0-4 properties. (WebCore::ApplyPropertyExpandingSuppressValue): Expand properties but suppress applyValue.

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
(WebCore::CSSStyleSelector::applyProperty): Remove implementations that have been moved to CSSStyleApplyProperty.

10:07 PM Changeset in webkit [83699] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-04-12 Sergey Glazunov <​serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

Element::setAttribute should check the namespace of an id attribute
​https://bugs.webkit.org/show_bug.cgi?id=58359

  • fast/dom/id-attribute-with-namespace-crash-expected.txt: Added.
  • fast/dom/id-attribute-with-namespace-crash.html: Added.

2011-04-12 Sergey Glazunov <​serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

Element::setAttribute should check the namespace of an id attribute
​https://bugs.webkit.org/show_bug.cgi?id=58359

Test: fast/dom/id-attribute-with-namespace-crash.html

  • dom/Element.cpp: (WebCore::Element::setAttribute):
9:49 PM Changeset in webkit [83698] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-12 Mike Lawther <​mikelawther@chromium.org>

Reviewed by James Robinson.

Update boolean operators in RenderStyle to be compatible with check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=58409

No new functionality, so no new tests.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::operator==): (WebCore::RenderStyle::inheritedNotEqual): (WebCore::positionedObjectMoved): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::applyTransform):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::isOriginalDisplayInlineType):
9:35 PM Changeset in webkit [83697] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-12 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Oliver Hunt.

REGRESSION (WebKit2): Input methods are active in non-editable content
​https://bugs.webkit.org/show_bug.cgi?id=58404
<rdar://problem/9275940>

  • UIProcess/API/mac/WKView.mm: (-[WKView insertText:]): Re-add the old variant of this function, because it's not only part of deprecated NSTextInput protocol, but it's also part of NSResponder, and it's called when the input context in nil. (-[WKView inputContext]): Return nil when not in editable content.
9:31 PM Changeset in webkit [83696] by caseq@chromium.org
  • 2 edits
    17 adds in trunk/LayoutTests

2011-04-12 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Added chromium baselines for new tests.

  • platform/chromium/test_expectations.txt:
  • platform/chromium-linux/fast/borders/bidi-002-expected.png: Added.
  • platform/chromium-linux/fast/borders/bidi-004-expected.png: Added.
  • platform/chromium-linux/fast/borders/bidi-009a-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-zIndex-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/borders/bidi-002-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/bidi-004-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/bidi-009a-expected.png: Added.
  • platform/chromium-win/fast/borders/bidi-002-expected.png: Added.
  • platform/chromium-win/fast/borders/bidi-002-expected.txt: Added.
  • platform/chromium-win/fast/borders/bidi-004-expected.png: Added.
  • platform/chromium-win/fast/borders/bidi-004-expected.txt: Added.
  • platform/chromium-win/fast/borders/bidi-009a-expected.png: Added.
  • platform/chromium-win/fast/borders/bidi-009a-expected.txt: Added.
  • platform/chromium-win/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.
  • platform/chromium-win/fullscreen/full-screen-zIndex-expected.txt: Added.
9:30 PM Changeset in webkit [83695] by luiz@webkit.org
  • 4 edits in trunk/Source/WebCore

[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
​https://bugs.webkit.org/show_bug.cgi?id=58375

Reviewed by Andreas Kling.

As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.

Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::start):

  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):

9:13 PM Changeset in webkit [83694] by vangelis@chromium.org
  • 4 edits
    4 adds in trunk

2011-04-12 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Adding layout test for:
​https://bugs.webkit.org/show_bug.cgi?id=58397

  • platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.checksum: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Added.
  • platform/chromium/compositing/child-layer-3d-sorting.html: Added.
  • platform/chromium/test_expectations.txt:

2011-04-12 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Move the calculation of the layer's z coordinate to the
right spot so that it can be picked up by its sublayers.
​https://bugs.webkit.org/show_bug.cgi?id=58397

Test: platform/chromium/compositing/child-layer-3d-sorting.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
9:04 PM Changeset in webkit [83693] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-12 Antoine Labour <​piman@chromium.org>

Reviewed by Kenneth Russell.

Allow WebView users to recreate dependent contexts after a context lost
event. Similarly to the startup case, a temporary context gets created,
that gets used by the layer renderer once it itself gets recreated.
​https://bugs.webkit.org/show_bug.cgi?id=58385

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::reallocateRenderer): use the temporary context to recreate the layer renderer if it's valid. (WebKit::WebViewImpl::graphicsContext3D): create a temporary context if the layer renderer's context is lost.
8:57 PM BuildingCairoOnWindows edited by bfulgham@webkit.org
No manual edits to Visual Studio needed! (diff)
8:55 PM Changeset in webkit [83692] by koz@chromium.org
  • 2 edits in trunk/Tools

2011-04-12 James Kozianski <​koz@chromium.org>

Unreviewed.

Adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
8:30 PM Changeset in webkit [83691] by luiz@webkit.org
  • 4 edits in trunk/Source/WebCore

[Qt] QNetworkReplyHandler refactoring: signal queue
​https://bugs.webkit.org/show_bug.cgi?id=57075

Reviewed by Andreas Kling.

The idea is to make all signals that come from the QNetworkReply to pass through a queue and to
stop that queue when loading is deferred. This way almost all the deferred logic can be removed
from QNetworkReplyHandler class and encapsulated in its own class.

To stop the queue during wrapper methods execution avoids stacking handler methods over wrapper
methods. Because of this there is no chance for the wrapper to be destroyed inside one of its methods.
This together with empting the queue at wrapper destruction time makes sure that the handler will
not receive calls from a dead wrapper.

The new class is named QNetworkReplyHandlerCallQueue.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandlerCallQueue::QNetworkReplyHandlerCallQueue):
(WebCore::QNetworkReplyHandlerCallQueue::push):
(WebCore::QNetworkReplyHandlerCallQueue::lock):
(WebCore::QNetworkReplyHandlerCallQueue::unlock):
(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
(WebCore::QNetworkReplyHandlerCallQueue::flush):
(WebCore::QueueLocker::QueueLocker):
(WebCore::QueueLocker::~QueueLocker):
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::readyRead):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::synchronousLoad):

  • platform/network/qt/QNetworkReplyHandler.h:

(WebCore::QNetworkReplyHandlerCallQueue::deferSignals):
(WebCore::QNetworkReplyHandlerCallQueue::clear):
(WebCore::QNetworkReplyWrapper::synchronousLoad):
(WebCore::QNetworkReplyHandler::setLoadingDeferred):

  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

8:24 PM Changeset in webkit [83690] by tkent@chromium.org
  • 3 edits
    4 adds in trunk

2011-04-12 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

Fix wrong calculation of HTMLFormElement::m_associatedElementsAfterIndex.
​https://bugs.webkit.org/show_bug.cgi?id=58247

Added tests which ensure calculation of m_associatedElementsAfterIndex
doesn't get wrong.

  • fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1-expected.txt: Added.
  • fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html: Added.
  • fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2-expected.txt: Added.
  • fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2.html: Added.

2011-04-12 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Kent Tamura.

Fix wrong calculation of HTMLFormElement::m_associatedElementsAfterIndex.
​https://bugs.webkit.org/show_bug.cgi?id=58247

  • Increment m_associatedElementsAfterIndex when the form owner and an inserted form associated element have the same parent chain.
  • Always iterate over m_associatedElements to decrease indexes when a form associated element is removed. This is needed for a case that the form associated element is removed from the form element due to deleting the 'form' attribute. No behavioral change expected with this change.

Tests: fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html

fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formElementIndexWithFormAttribute): Incremet m_associatedElementsAfterIndex when compareDocumentPosition() returns DOCUMENT_POSITION_CONTAINED_BY. (WebCore::HTMLFormElement::removeFormElement): Always iterate m_associatedElements to adjust indexes.
7:43 PM Changeset in webkit [83689] by diegohcg@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-12 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Do not show scrollbars when use mobile theme
​https://bugs.webkit.org/show_bug.cgi?id=58380

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::scrollbarThickness):
7:27 PM Changeset in webkit [83688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-12 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by Alexey Proskuryakov.

The default backspace event handler should mark the event as handled if navigation succeeds.
​https://bugs.webkit.org/show_bug.cgi?id=58379

We should mark the event as handled only if we were able to successfully navigate backwards or forwards.
These navigations can fail if there is now back/forward history. This can occur in cases like ChromeFrame
where history is managed by an external browser like IE.

No new tests added as this scenario can occur when the history view is split across two browsers (WebKit and IE)
It is non trivial to simulate this environment.

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultBackspaceEventHandler):
7:24 PM Changeset in webkit [83687] by beidson@apple.com
  • 7 edits in trunk/Source/WebKit2

<rdar://problem/9029193> and ​https://bugs.webkit.org/show_bug.cgi?id=58406
Bringing up the context menu on a link might also follow the link.

Reviewed by Maciej Stachowiak.

This patch adds a flag that is set just before the WebProcess tells the UIProcess to show a context menu.

As long as this flag is set, the WebProcess will ignore any other mouse events that might have queued up
by the time the UIProcess gets around to showing the menu.

After the UIProcess is done showing the menu, it messages back telling the WebProcess to clear the flag
and resume normal MouseEvent handling.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu): No matter what internalShowContextMenu does, always notify

the WebProcess that any context menu is now hidden.

(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show): Since we're telling the UIProcess to show the menu, tell the WebPage a

context menu is showing so it will stop handling mouse events.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::mouseEvent): Don't try to handle mouse events if a context menu is flagged as showing.

Add accessors to twiddle the "context menu showing" flag:

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::contextMenuShowing):
(WebKit::WebPage::contextMenuHidden):

  • WebProcess/WebPage/WebPage.messages.in: Add the ContextMenuHidden message.
7:22 PM Changeset in webkit [83686] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Quarantine related sandbox denial when downloading files
<rdar://problem/9203736>

Reviewed by Maciej Stachowiak.

  • WebProcess/com.apple.WebProcess.sb:
7:15 PM Changeset in webkit [83685] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Sandbox violations dragging an image to the desktop.
<rdar://problem/9261834>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
7:13 PM Changeset in webkit [83684] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-12 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Make availableWidth and totalOverhangWidth in findNextLineBreak member variables of LineWidth
​https://bugs.webkit.org/show_bug.cgi?id=58400

Added m_availableWidth and m_overhangWidth to LineWidth this allows us to encapsulate m_overhangWidth.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::LineWidth::LineWidth): (WebCore::LineWidth::fitsOnLine): Added; returns true if current width + first argument <= availableWidth. (WebCore::LineWidth::availableWidth): Added. (WebCore::LineWidth::setAvailableWidth): Added; takes LineOffsets. (WebCore::LineWidth::applyOverhang): Added; obtains the overhang width from ruby run and inflates the available width. (WebCore::LineWidth::fitBelowFloats): Moved from RenderBlock. (WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
6:57 PM Changeset in webkit [83683] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-04-12 Alexis Menard <​alexis.menard@openbossa.org>

Unreviewed warning fix.

MediaControlElements has been moved to html/shadow.

  • WebCore.pro:
6:39 PM Changeset in webkit [83682] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Sandbox violations trying to access ~/Library/Keyboard Layouts and ~/Library/Input Methods
<rdar://problem/8973159>

Reviewed by Cameron Zwarich.

  • WebProcess/com.apple.WebProcess.sb:
6:38 PM Changeset in webkit [83681] by mrowe@apple.com
  • 12 edits in tags/Safari-534.28.5/Source/WebCore

Merge r83667.

6:38 PM Changeset in webkit [83680] by mrowe@apple.com
  • 5 edits in tags/Safari-534.28.5/Source

Versioning.

6:35 PM Changeset in webkit [83679] by yael.aharon@nokia.com
  • 3 edits in trunk/Source/WebCore

Rename onEndChain and make it a static method.
​https://bugs.webkit.org/show_bug.cgi?id=58403

Reviewed by Eric Seidel.

No new tests since this is refactoring only.

  • rendering/InlineFlowBox.cpp:

(WebCore::isLastChildForRenderer):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):

  • rendering/InlineFlowBox.h:
6:27 PM Changeset in webkit [83678] by mrowe@apple.com
  • 1 copy in tags/Safari-534.28.5

New tag.

6:24 PM Changeset in webkit [83677] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Mark array-proto-func-property-getter-except.html and full-screen-zIndex.html
as filed in chromium.

  • platform/chromium/test_expectations.txt:
6:21 PM Changeset in webkit [83676] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-12 Eric Carlson <​eric.carlson@apple.com>

Not reviewed, build fix.

Fix non-accelerated build after r83667.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): Guard call to

mediaPlayerRenderingModeChanged with USE(ACCELERATED_COMPOSITING.

6:01 PM Changeset in webkit [83675] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-04-12 Xan Lopez <​xlopez@igalia.com>

Unreviewed build fix.

  • webkit/webkitwebhistoryitem.cpp:
5:54 PM BuildingCairoOnWindows edited by bfulgham@webkit.org
You no longer need to manually locate the build requirements! (diff)
5:50 PM Changeset in webkit [83674] by enne@google.com
  • 4 edits in trunk/Source

2011-04-12 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] TilingData mishandles very small texture sizes
​https://bugs.webkit.org/show_bug.cgi?id=58364

Use zero tiles when the texture size is too small for tiling.

  • platform/graphics/gpu/TilingData.cpp: (WebCore::TilingData::TilingData): (WebCore::TilingData::setMaxTextureSize):

2011-04-12 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] TilingData mishandles very small texture sizes
​https://bugs.webkit.org/show_bug.cgi?id=58364

Update test to properly handle texture sizes of 0-3.

  • tests/TilingDataTest.cpp: (WebCore::TEST):
5:24 PM Changeset in webkit [83673] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebCore

2011-04-12 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r83634 and r83659.
​http://trac.webkit.org/changeset/83634
​http://trac.webkit.org/changeset/83659
​https://bugs.webkit.org/show_bug.cgi?id=57075

It made 2 tests time out

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper): (WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper): (WebCore::QNetworkReplyWrapper::receiveMetaData): (WebCore::QNetworkReplyWrapper::didReceiveFinished): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::resetState): (WebCore::QNetworkReplyHandler::setLoadingDeferred): (WebCore::QNetworkReplyHandler::resumeDeferredLoad): (WebCore::QNetworkReplyHandler::release): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::resourceResponse): (WebCore::WebCoreSynchronousLoader::resourceError): (WebCore::WebCoreSynchronousLoader::data): (WebCore::WebCoreSynchronousLoader::setReplyFinished): (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::WebCoreSynchronousLoader::didReceiveResponse): (WebCore::WebCoreSynchronousLoader::didReceiveData): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::WebCoreSynchronousLoader::waitForCompletion): (WebCore::ResourceHandle::loadResourceSynchronously):
5:20 PM Changeset in webkit [83672] by weinig@apple.com
  • 6 edits in trunk/Source/WebCore

2011-04-12 Sam Weinig <​sam@webkit.org>

Reviewed by Simon Fraser.

Frames prevent scrolling containing page
<rdar://problem/8990409>
​https://bugs.webkit.org/show_bug.cgi?id=58392

Also fixes:
Should rubber-band on pages with no scrollbars
<rdar://problem/9034280>

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): Make the main frame rubber-band horizontally and vertically always.
  • platform/ScrollTypes.h: Add ScrollElasticity enum.
  • platform/ScrollableArea.cpp: Default to no elasticity.

(WebCore::ScrollableArea::ScrollableArea):

  • platform/ScrollableArea.h: (WebCore::ScrollableArea::setVerticalScrollElasticity): (WebCore::ScrollableArea::verticalScrollElasticity): (WebCore::ScrollableArea::setHorizontalScrollElasticity): (WebCore::ScrollableArea::horizontalScrollElasticity): Add state for horizontal and vertical elasticity.
  • platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::handleWheelEvent): Bail out of new scrolling behavior if we can't rubber-band. By bailing before accepting the wheel event, we allow the wheel event to be forwarded. We will need to refine this logic to allow subframe scrolling in the future.

(WebCore::ScrollAnimatorMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
Switch stretching behavior based on the ScrollableArea's elasticity.

5:18 PM Changeset in webkit [83671] by ggaren@apple.com
  • 4 edits in trunk/Source/WebCore

2011-04-12 Geoffrey Garen <​ggaren@apple.com>

Not reviewed.

Try to fix the Chromium build.


Why have one URL when you can have two at twice the price?

  • platform/KURL.h: (WebCore::KURL::KURL): (WebCore::KURL::isHashTableDeletedValue):
  • platform/KURLGoogle.cpp: (WebCore::KURLGooglePrivate::KURLGooglePrivate):
  • platform/KURLGooglePrivate.h: Added a GoogleURL path for KURL's hash table deleted value constructor.
5:18 PM Changeset in webkit [83670] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/misc/favicon-loads-with-icon-loading-override.html fails
​https://bugs.webkit.org/show_bug.cgi?id=58396

  • platform/qt/Skipped: Add http/tests/misc/favicon-loads-with-icon-loading-override.html
5:13 PM Changeset in webkit [83669] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=58395
Exceptions thrown from property getters called from Array prototype functions can be missed

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This is caught by an ASSERT in the top of Interpreter::executeCall.
Check for exceptions after accessing properties that could be getters.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):

  • Add exception checks.

LayoutTests:

Added layout test.

  • fast/js/array-proto-func-property-getter-except-expected.txt: Added.
  • fast/js/array-proto-func-property-getter-except.html: Added.
  • fast/js/script-tests/array-proto-func-property-getter-except.js: Added.

(test.propertyGetter):

5:13 PM Changeset in webkit [83668] by Stephanie Lewis
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=58280
Fix a layout test by correctly comparing enums, and not adding exceptions.

Reviewed by Oliver Hunt.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/js/SerializedScriptValue.h:
5:01 PM Changeset in webkit [83667] by eric.carlson@apple.com
  • 12 edits in trunk/Source/WebCore

2011-04-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Apple movie trailers play only audio
​https://bugs.webkit.org/show_bug.cgi?id=58339
<rdar://problem/9237606>

No new tests, covered by existing layout and manual tests.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerEngineUpdated): Do the logging before calling any functions. (WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): New, if still displaying the poster

change the display mode to Video and force a style recalc so the video layer gets hooked
up the the render tree.

  • html/HTMLMediaElement.h: Define new display mode, PosterWaitingForVideo, to signal that we

want to stop displaying the poster as soon as the first frame of video is available.

  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::setDisplayMode): Change display mode to PosterWaitingForVideo when

we want to display Video but the media engines doesn't have the first frame yet.

  • html/HTMLVideoElement.h: (WebCore::HTMLVideoElement::shouldDisplayPosterImage): Update to return true when display mode

is PosterWaitingForVideo.

  • manual-tests/media-elements/video-replaces-poster.html: Clean up bit-rot from patch changes.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::firstVideoFrameAvailable): New, passthrough from media engien to element.
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerFirstVideoFrameAvailable):
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Initialize

m_haveReportedFirstVideoFrame and m_playWhenFramesAvailable.

(WebCore::MediaPlayerPrivateAVFoundation::play): Don't actually start playback until the first

frame of video has loaded, or audio will begin to play before we can show video.

(WebCore::MediaPlayerPrivateAVFoundation::pause): Clear m_playWhenFramesAvailable.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): When first frame of video is

available, inform elment and begin playback if it was previousl requested.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer): Correct logging. (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Ditto. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay): Renamed from play. (WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause): Rename from pause.
4:56 PM Changeset in webkit [83666] by jianli@chromium.org
  • 16 edits in trunk/Source

2011-04-12 Jian Li <​jianli@chromium.org>

Unreviewed, rolling out r83649.
​http://trac.webkit.org/changeset/83649
​https://bugs.webkit.org/show_bug.cgi?id=57563

This patch causes compiling errors for chromium

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): (WebCore::Font::drawComplexText):
  • platform/graphics/chromium/ImageBufferData.h:
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize):
  • platform/graphics/chromium/PlatformCanvas.h:
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeTextComposite): (WebCore::TransparencyWin::makeLayerOpaque):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): (WebCore::Image::drawPattern):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::PlatformContextSkia): (WebCore::PlatformContextSkia::setCanvas): (WebCore::PlatformContextSkia::isPrinting): (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
  • platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::canvas):

2011-04-12 Jian Li <​jianli@chromium.org>

Unreviewed, rolling out r83649.
​http://trac.webkit.org/changeset/83649
​https://bugs.webkit.org/show_bug.cgi?id=57563

This patch causes compiling errors for chromium

  • public/WebCanvas.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::printPage):
  • tests/TransparencyWinTest.cpp: (WebCore::drawNativeRect): (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::TEST):
4:51 PM Changeset in webkit [83665] by enrica@apple.com
  • 9 edits in trunk/Source

Implement non-activating clicks to allow dragging out of a background window.
​https://bugs.webkit.org/show_bug.cgi?id=55053
<rdar://problem/9042197>

Source/WebCore:

Reviewed by Alexey Proskuryakov.

  • WebCore.exp.in: Added new exported method.

Source/WebKit2:

Reviewed by Alexey Proskuryakov and Sam Weinig.

Added methods to WKView to support non activating click. Unfortunately both
methods require a synchronous call to the WebProcess to decide what to do.
acceptFirstMouse is called only if shouldDelayWindowOrderingForEvent returns
true. In order to minimize the number of synchronous calls, we send the request
only if our window is not the key window.

  • UIProcess/API/mac/WKView.mm:

(-[WKView acceptsFirstMouse:]):
(-[WKView shouldDelayWindowOrderingForEvent:]):

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent):
(WebKit::WebPageProxy::acceptsFirstMouse):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):

4:48 PM Changeset in webkit [83664] by ggaren@apple.com
  • 14 edits in trunk/Source

2011-04-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make API callback objects use weak handles to run their finalizers
​https://bugs.webkit.org/show_bug.cgi?id=58389

Make the API object's private data struct act as a finalizer for
an api object if the callback object has a API defined finalizer.

  • API/JSCallbackObject.cpp: (JSC::JSCallbackObjectData::finalize):
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: (JSC::::init):
  • heap/Handle.h:

2011-04-12 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Geoffrey Garen.

Cleaned up hash traits, and added hash traits for handles
​https://bugs.webkit.org/show_bug.cgi?id=58381

  • dom/QualifiedName.h: Use new SimpleClassHashTraits to avoid duplication.
  • platform/KURL.h: (WebCore::KURL::KURL): (WebCore::KURL::isHashTableDeletedValue): Added explicit hash table deleted value constructor, to be more explicit and enable use of SimpleClassHashTraits.
  • platform/KURLHash.h: Use new SimpleClassHashTraits to avoid duplication.
  • platform/graphics/FontCache.cpp: Ditto.
  • platform/network/ProtectionSpaceHash.h: Ditto.
  • svg/properties/SVGAnimatedPropertyDescription.h: Ditto.
4:37 PM Changeset in webkit [83663] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; add two new tests to the mac-wk2 SkippedList.

Skip fullscreen/video-specified-size.html and fullscreen/full-screen-zIndex.html

  • platform/mac-wk2/Skipped:
4:34 PM Changeset in webkit [83662] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Oliver Hunt.

Crash when serializing a null AttributedString
​https://bugs.webkit.org/show_bug.cgi?id=58393
<rdar://problem/9275326>

  • Shared/mac/AttributedString.mm: (WebKit::AttributedString::encode): (WebKit::AttributedString::decode): Prefix the serialized value with an isNull tag.
4:27 PM Changeset in webkit [83661] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-04-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make API callback objects use weak handles to run their finalizers
​https://bugs.webkit.org/show_bug.cgi?id=58389

Make the API object's private data struct act as a finalizer for
an api object if the callback object has a API defined finalizer.

  • API/JSCallbackObject.cpp: (JSC::JSCallbackObjectData::finalize):
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: (JSC::::init):
  • heap/Handle.h:
4:22 PM Changeset in webkit [83660] by jam@chromium.org
  • 4 edits in trunk

2011-04-12 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Jian Li.

[chromium] Fix spellcheck regression in context menus
​https://bugs.webkit.org/show_bug.cgi?id=58386

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

2011-04-12 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Jian Li.

[chromium] Fix spellcheck regression in context menus
​https://bugs.webkit.org/show_bug.cgi?id=58386

  • platform/chromium/test_expectations.txt:
4:20 PM Changeset in webkit [83659] by luiz@webkit.org
  • 4 edits in trunk/Source/WebCore

[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
​https://bugs.webkit.org/show_bug.cgi?id=58375

Reviewed by Andreas Kling.

As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.

Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::start):

  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):

4:11 PM Changeset in webkit [83658] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-04-12 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Tony Chang.

[chromium] Use new dragTargetDragEnter() function signature
​https://bugs.webkit.org/show_bug.cgi?id=58303

After WebKit/chromium/DEPS rolls to chromium r80907, the drag identity
based version of dragTargetDragEnter() is no longer used; remove it.

  • public/WebView.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
3:59 PM Changeset in webkit [83657] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Unreviewed build correction for WinCairo bot after r83639.
​https://bugs.webkit.org/show_bug.cgi?id=51790

Correct typo for the new "update-webkit-wincairo-libs" script.

  • Scripts/build-webkit: Incorrectly calling the update-webkit-cairo-libs which does not exist.
3:56 PM ThreadCommunication edited by levin@chromium.org
Formatting changes. (diff)
3:55 PM ThreadCommunication edited by levin@chromium.org
More details. (diff)
3:49 PM Changeset in webkit [83656] by alice.liu@apple.com
  • 2 edits in trunk/Tools

A change that should have been part of ​http://trac.webkit.org/changeset/83628

Reviewed by Jon Honeycutt.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.

3:48 PM Changeset in webkit [83655] by enrica@apple.com
  • 4 edits in trunk/Source

Infinite recursion in WebHTMLView executeSavedKeypressCommands.
​https://bugs.webkit.org/show_bug.cgi?id=58382
<rdar://problem/9239370>

Reviewed by Alexey Proskuryakov.

Execution of some editing commands could trigger a call to selectedRange that
internally calls executeSavedKeypressCommands creating an infinite recursion.

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
(-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView _executeSavedKeypressCommands]): Added flag to avoid recursion.
(-[WKView _interpretKeyEvent:withCachedTextInputState:savingCommandsTo:WebCore::]):
Added flag initialization.

3:46 PM Changeset in webkit [83654] by jer.noble@apple.com
  • 7 edits
    7 adds in trunk

2011-04-11 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

REGRESSION: Vimeo fullscreen video displays incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=58291

  • fullscreen/video-specified-size-expected.txt: Added.
  • fullscreen/video-specified-size.html: Added.
  • fullscreen/full-screen-test.js:
  • fullscreen/full-screen-zIndex-expected.txt: Added.
  • fullscreen/full-screen-zIndex.html: Added.
  • platform/mac/fullscreen/full-screen-zIndex-expected.checksum: Added.
  • platform/mac/fullscreen/full-screen-zIndex-expected.png: Added.

2011-04-11 Jer Noble <​jer.noble@apple.com>

Reviewed by Simon Fraser.

REGRESSION: Vimeo fullscreen video displays incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=58291

Set the RenderFullScreen's zIndex to the max. And make sure to override
a video element's specified width and height by making its full screen rules
important. Also, always show the controls when a media element is in full
screen mode.

Test: fullscreen/video-specified-size.html
Test: fullscreen/full-screen-zIndex.html

  • css/fullscreen.css: (video:-webkit-full-screen):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::controls): Always show controls in full screen mode. (WebCore::HTMLMediaElement::preDispatchEventHandler): Added. Handle the fullscreen

change event and hide or show the controls accordingly.

  • html/HTMLMediaElement.h:
  • rendering/RenderFullScreen.cpp: (RenderFullScreen::createFullScreenStyle): Set the zIndex to INT_MAX and use a

vertical flexbox instead of a horizontal one.

3:43 PM Changeset in webkit [83653] by cmarrin@apple.com
  • 5 edits in trunk/Source

2011-04-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Page tears and stutters in WebKit2 when page is > 2048 pixels wide
​https://bugs.webkit.org/show_bug.cgi?id=58330

Added API to GraphicsLayer to disable switching to tiled layers. This is
set in the nonCompositedContentLayer in WK2, causing that layer to never
switch to tiles and avoiding the asynchronous update of the content during
scroll.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

Implement setAllowTiledLayer() to simulate a SizeChanged action to
properly switch between tiled and untiled layer.

  • platform/graphics/ca/GraphicsLayerCA.h:

2011-04-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Page tears and stutters in WebKit2 when page is > 2048 pixels wide
​https://bugs.webkit.org/show_bug.cgi?id=58330

Turn off tiling for nonCompositedContentLayer to avoid tearing when
scrolling very wide (> 2048) windows.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp: (WebKit::LayerTreeHostCA::initialize):
3:43 PM ThreadCommunication created by levin@chromium.org
Starting page.
3:43 PM Changeset in webkit [83652] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Unskip t0805-c5519-ibrdr-r-00-a.html, since it is now passing.

  • platform/qt/Skipped:
3:41 PM Changeset in webkit [83651] by alice.liu@apple.com
  • 2 edits in trunk/LayoutTests

Added http/tests/misc/favicon-loads-with-icon-loading-override.html
to mac-wk2 skipped list because resource load callbacks aren't implemented
in WebKitTestRunner.

  • platform/mac-wk2/Skipped:
3:35 PM Changeset in webkit [83650] by yael.aharon@nokia.com
  • 4 edits in trunk/LayoutTests

Unreviewed.

Update results after r83638.

  • platform/qt/css1/box_properties/padding_right_inline-expected.checksum:
  • platform/qt/css1/box_properties/padding_right_inline-expected.png:
  • platform/qt/css1/box_properties/padding_right_inline-expected.txt:
3:27 PM Changeset in webkit [83649] by commit-queue@webkit.org
  • 16 edits in trunk/Source

2011-04-12 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Remove dependency on chromium skia::PlatformCanvas
​https://bugs.webkit.org/show_bug.cgi?id=57563

This patch does not change any functionality, just the type of object skia::PlatformCanvas -> SkCanvas.
The object is still being created by a factory method skia::CreateBitmapCanvas defined in Chromium.
We will eventually define an API that every port using skia will define.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): (WebCore::Font::drawComplexText):
  • platform/graphics/chromium/ImageBufferData.h:
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize):
  • platform/graphics/chromium/PlatformCanvas.h:
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeTextComposite): (WebCore::TransparencyWin::makeLayerOpaque):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): (WebCore::Image::drawPattern):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::PlatformContextSkia): (WebCore::PlatformContextSkia::setCanvas): (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
  • platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::canvas): (WebCore::PlatformContextSkia::printing): (WebCore::PlatformContextSkia::setPrinting):

2011-04-12 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Remove dependency on chromium skia::PlatformCanvas
​https://bugs.webkit.org/show_bug.cgi?id=57563

  • public/WebCanvas.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::printPage):
  • tests/TransparencyWinTest.cpp: (WebCore::drawNativeRect): (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::TEST):
3:20 PM Changeset in webkit [83648] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Mark 3 bidi related layout tests as failed in chromium.

  • platform/chromium/test_expectations.txt:
3:05 PM Changeset in webkit [83647] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Assertion in DrawingAreaImpl::resumePainting() (m_isPaintingSuspended) when clicking a link at twitter.com
​https://bugs.webkit.org/show_bug.cgi?id=58377
<rdar://problem/8976531>

Remove the assertion.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::resumePainting):
3:02 PM Changeset in webkit [83646] by dpranke@chromium.org
  • 9 edits in trunk/Tools

2011-04-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
​https://bugs.webkit.org/show_bug.cgi?id=58272

NRWT was interpreting the --results-directory cmd line arg as
relative to the build directory, not the current working
directory (ORWT uses the latter, which is much more intuitive).

This patch fixes the base case, but includes an override for
Chromium that is needed until the bots can be updated.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2:50 PM Changeset in webkit [83645] by Stephanie Lewis
  • 15 edits in trunk/Source

../WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=58280
<rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception
Currently serialization and deserialization can throw javascript exceptions. Since SerializedScriptValue is called in
several places that do not always involve direct calls into javascript have the functions return an error code and the callers
decide whether or not to throw exceptions.

Reviewed by Oliver Hunt.

Don't allow SerializedScriptValue to attempt to serialize objects that inherit from JSNavigator.h. Walking that object creates
additional objects which eventually causes serialization to end up throwing a stack overflow error. Instead fail immediately.

Untangle header includes. SerializedScriptValue was inheriting ScriptValue.h, but not using it. Since ScriptValue depends on
SerializedScriptValue this could lead to a circular header dependency.

No change in functionality, covered by current tests

  • WebCore.exp.in:
  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::deserialize):

  • bindings/js/ScriptValue.h:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):
(WebCore::SerializedScriptValue::serializationDidCompleteSuccessfully):

  • bindings/js/SerializedScriptValue.h:
  • bindings/js/JSWorkerContextBase.cpp: header include fix
  • loader/FrameLoader.h: header include fix
  • page/Frame.cpp: header include fix

../WebKit/gtk: ​https://bugs.webkit.org/show_bug.cgi?id=58280
<rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception.

Reviewed by Oliver Hunt.

Add a header include. Fallout from untangling some header files in WebCore.

  • webkit/webkitwebhistoryitem.cpp:

../WebKit2: ​https://bugs.webkit.org/show_bug.cgi?id=58280
<rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception
Change use of SerializedScriptValue::Create to use the same api as the rest of WebKit2. This has the benefit
of handling any exceptions so Javascript is not in an inconsistent state.

Reviewed by Oliver Hunt.

  • Shared/API/c/WKSerializedScriptValue.h: fix a typo
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

2:46 PM Changeset in webkit [83644] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Mark 3 layout tests as failed in chromium.

  • platform/chromium/test_expectations.txt:
2:42 PM Changeset in webkit [83643] by Philippe Normand
  • 3 edits in trunk/Tools

2011-04-12 Philippe Normand <​pnormand@igalia.com>

Unreviewed, roll out r83621 as it broke the GTK build.

[GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
​https://bugs.webkit.org/show_bug.cgi?id=58333

  • Scripts/build-jsc:
  • Scripts/build-webkit:
2:39 PM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
2:36 PM Changeset in webkit [83642] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-04-12 Adam Barth <​abarth@webkit.org>

Revert unintentional changes to WebKit.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:
2:34 PM Changeset in webkit [83641] by abarth@webkit.org
  • 28 edits
    1 copy
    1 add
    1 delete in trunk

Move libtess from WebCore/thirdparty to ThirdParty
​https://bugs.webkit.org/show_bug.cgi?id=57288

Reviewed by Kenneth Russell.

We're putting third party code in Source/ThirdParty these days.

  • Source/ThirdParty/glu: Copied from Source/WebCore/thirdparty/glu.
  • Source/ThirdParty/glu/glu.gyp: Added.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
    • Add libtess as a legit dependency.
  • WebCore.gypi:
    • Remove libtess files from the gypi.
  • thirdparty/glu: Removed.
2:32 PM Changeset in webkit [83640] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-12 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by David Hyatt.

Bundle w and tmpW in findNextLineBreak together as a class
​https://bugs.webkit.org/show_bug.cgi?id=58362

Renamed w, tempW, and width in findNextLineBreak to committedWidth, uncommittedWidth,
and availableWidth respectively. Also bundled committedWidth and uncommittedWith as a class
named LineWidth.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::LineWidth::LineWidth): Added. (WebCore::LineWidth::currentWidth): Added; returns the sum of committed and uncommitted width. (WebCore::LineWidth::uncommittedWidth): Added. (WebCore::LineWidth::committedWidth): Added. (WebCore::LineWidth::addUncommittedWidth): Added; adds the specified width to the uncommitted width. (WebCore::LineWidth::commit): Added; commits the current width and clears the uncommitted width. (WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
2:28 PM Changeset in webkit [83639] by bfulgham@webkit.org
  • 5 edits
    1 copy
    1 add in trunk/Tools

2011-04-12 Carl Lobo <​carllobo@gmail.com> and Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Adam Roben.

Patch to download the WinCairo dependancies as part of build-webkit.
​https://bugs.webkit.org/show_bug.cgi?id=51790

This patch downloads the dependancies from

​http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip

checking the modification timestamp etc.

  • Tools/Scripts/build-webkit
  • Tools/Scripts/update-webkit: Modified to understand the --wincairo flag, and to update WinCairo dependencies when used.
  • Tools/Scripts/update-webkit-cairo-libs: added
  • Tools/Scripts/update-webkit-dependency: added
  • Tools/Scripts/update-webkit-auxiliary-libs
2:28 PM Changeset in webkit [83638] by yael.aharon@nokia.com
  • 6 edits
    12 adds in trunk

2011-04-12 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Eric Seidel.

REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html
​https://bugs.webkit.org/show_bug.cgi?id=57459

  • fast/borders/bidi-002.html: Added.
  • fast/borders/bidi-004.html: Added.
  • fast/borders/bidi-009a.html: Added.
  • platform/mac/fast/borders/bidi-002-expected.checksum: Added.
  • platform/mac/fast/borders/bidi-002-expected.png: Added.
  • platform/mac/fast/borders/bidi-002-expected.txt: Added.
  • platform/mac/fast/borders/bidi-004-expected.checksum: Added.
  • platform/mac/fast/borders/bidi-004-expected.png: Added.
  • platform/mac/fast/borders/bidi-004-expected.txt: Added.
  • platform/mac/fast/borders/bidi-009a-expected.checksum: Added.
  • platform/mac/fast/borders/bidi-009a-expected.png: Added.
  • platform/mac/fast/borders/bidi-009a-expected.txt: Added.

2011-04-12 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Eric Seidel.

REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html
​https://bugs.webkit.org/show_bug.cgi?id=57459

Slightly change the way we decide if a InlineFlowBox is the last box for its renderer.
We include the border in that box under these conditions:
(1) The next line was not created, or it is constructed. We check the previous line for rtl.
(2) The logicallyLastRun is not a descendant of this renderer.
(3) The logicallyLastRun is a descendant of this renderer, but it is the last child of this renderer and it does not wrap to the next line.
I added the tests from bug 47210, because now the draw the borders correctly.

Tests: fast/borders/bidi-002.html

fast/borders/bidi-004.html
fast/borders/bidi-009a.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::onEndChain): (WebCore::isAnsectorAndWithinBlock): (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::layoutInlineChildren):
2:25 PM BuildingQtOnOSX edited by Dimitri Glazkov
Added note about qt-mobility (diff)
2:12 PM Changeset in webkit [83637] by ggaren@apple.com
  • 10 edits in trunk/Source

2011-04-12 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Cleaned up some Vector traits, and added missing Vector traits for handles
​https://bugs.webkit.org/show_bug.cgi?id=58372

  • heap/Local.h: Inherit from SimpleClassVectorTraits to avoid duplication.
  • heap/Strong.h: Ditto.
  • heap/Weak.h: Ditto.
  • parser/JSParser.cpp: Fixed a traits error. No test case because this particular trait is not currently exercised by the parser.
  • runtime/UString.h: No need to override canInitializeWithMemset, since our base class sets it to true.
  • wtf/VectorTraits.h: Inherit from VectorTraitsBase to avoid duplication.
  • wtf/text/WTFString.h: No need to override canInitializeWithMemset, since our base class sets it to true.

2011-04-12 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Cleaned up some Vector traits, and added missing Vector traits for handles
​https://bugs.webkit.org/show_bug.cgi?id=58372

  • platform/graphics/BitmapImage.h: Added a FIXME because the current Vector traits for FrameData are logically incorrect, but I couldn't find a place where this currently results in bad behavior, and it's not immediately obvious what the right solution is.
1:59 PM Changeset in webkit [83636] by Dimitri Glazkov
  • 9 edits
    2 moves in trunk/Source/WebCore

2011-04-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Move MediaControlElements to html/shadow.
​https://bugs.webkit.org/show_bug.cgi?id=58347

Mechanical move of the files.

  • Android.mk: Updated the build file.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto, also ran sort-XCode-project-files.
  • html/shadow/MediaControlElements.cpp: Copied from Source/WebCore/rendering/MediaControlElements.cpp. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
  • html/shadow/MediaControlElements.h: Copied from Source/WebCore/rendering/MediaControlElements.h.
  • rendering/MediaControlElements.cpp: Removed.
  • rendering/MediaControlElements.h: Removed.
  • rendering/RenderingAllInOne.cpp: Removed the files that were moved.
1:53 PM Changeset in webkit [83635] by dpranke@chromium.org
  • 9 edits in trunk/Tools

2011-04-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
​https://bugs.webkit.org/show_bug.cgi?id=58290

This is some preliminary refactoring for bug 58272.

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1:46 PM Changeset in webkit [83634] by luiz@webkit.org
  • 4 edits in trunk/Source/WebCore

[Qt] QNetworkReplyHandler refactoring: signal queue
​https://bugs.webkit.org/show_bug.cgi?id=57075

Reviewed by Andreas Kling.

The idea is to make all signals that come from the QNetworkReply to pass through a queue and to
stop that queue when loading is deferred. This way almost all the deferred logic can be removed
from QNetworkReplyHandler class and encapsulated in its own class.

To stop the queue during wrapper methods execution avoids stacking handler methods over wrapper
methods. Because of this there is no chance for the wrapper to be destroyed inside one of its methods.
This together with empting the queue at wrapper destruction time makes sure that the handler will
not receive calls from a dead wrapper.

The new class is named QNetworkReplyHandlerCallQueue.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandlerCallQueue::QNetworkReplyHandlerCallQueue):
(WebCore::QNetworkReplyHandlerCallQueue::push):
(WebCore::QNetworkReplyHandlerCallQueue::lock):
(WebCore::QNetworkReplyHandlerCallQueue::unlock):
(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
(WebCore::QueueLocker::QueueLocker):
(WebCore::QueueLocker::~QueueLocker):
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::readyRead):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::synchronousLoad):

  • platform/network/qt/QNetworkReplyHandler.h:

(WebCore::QNetworkReplyHandlerCallQueue::deferSignals):
(WebCore::QNetworkReplyHandlerCallQueue::clear):
(WebCore::QNetworkReplyWrapper::synchronousLoad):
(WebCore::QNetworkReplyHandler::setLoadingDeferred):

  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

1:44 PM Changeset in webkit [83633] by jeffm@apple.com
  • 11 edits
    1 add in trunk

2011-04-12 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
​https://bugs.webkit.org/show_bug.cgi?id=56020

Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
since WebKit will do this for us. If we didn't do this, TranslateMessage() would be called twice,
which would generate two characters for every keypress (for example). I didn't bother doing this for
WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.


Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.

  • MiniBrowser/win/main.cpp: (shouldTranslateMessage): Added. (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
  • TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
  • TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
  • TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added. (TestWebKitAPI::didNotHandleKeyEventCallback): Added. (TestWebKitAPI::runAndWatchForWMChar): Added. (TestWebKitAPI::TEST): Added.
  • TestWebKitAPI/win/PlatformUtilitiesWin.cpp: (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to. (TestWebKitAPI::Util::shouldTranslateMessage): Added.
  • TestWebKitAPI/win/PlatformWebViewWin.cpp: (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.

2011-04-12 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
​https://bugs.webkit.org/show_bug.cgi?id=56020

Safari was always calling TranslateMessage() on key events since it has no way to know whether
WebKit handled the event without a PageUIClient (which Safari only installs on pages inside
a Safari window), which was generating a WM_CHAR message containing the tab in this case. The fix
is for Safari to never call TranslateMessage() on key events outside of a Safari window, but this
means the WebPageProxy needs to do this for unhandled key events if there is no didNotHandleKeyEvent
callback in the PageUIClient.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveEvent): Call TranslateMessage() on Windows for unhandled key events that can't be handled by the PageUIClient.
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::canNotHandleKeyEvent): Added.
  • UIProcess/WebUIClient.h: Added canNotHandleKeyEvent().
1:40 PM Changeset in webkit [83632] by jam@chromium.org
  • 2 edits in trunk/Tools/DumpRenderTree/chromium

[chromium] Fix spelling layout test. BUG=​https://bugs.webkit.org/show_bug.cgi?id=58371

1:34 PM Changeset in webkit [83631] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-04-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

webkitpy: fix mock_filesystem abspath to handle relative paths
and add filesystem.chdir() and filesystem.getcwd() to be able
to test this and mock it out.

​https://bugs.webkit.org/show_bug.cgi?id=58288

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
1:34 PM Changeset in webkit [83630] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Windows XP Debug Tests] http/tests/inspector/resource-tree-model.html failing since introduction in r83584
​https://bugs.webkit.org/show_bug.cgi?id=58367

Add expected failing results to get the bots green.

  • platform/win-xp/http: Added.
  • platform/win-xp/http/tests: Added.
  • platform/win-xp/http/tests/inspector: Added.
  • platform/win-xp/http/tests/inspector/resource-tree-model-expected.txt: Added.
1:31 PM Changeset in webkit [83629] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=58176

Reviewed by Dan Bernstein.

Inline replaced elements following positioned elements on lines are not rendered. Make sure the
logic for skipping run construction in appendRunsForObject matches the new logic that I added
to findNextLineBreak. If they don't match up, you risk confusing the run construction code and
causing it to not make runs for objects that follow the positioned object on the line.

Source/WebCore:

Added fast/inline/positioned-object-between-replaced-elements.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::appendRunsForObject):

LayoutTests:

  • fast/inline/positioned-object-between-replaced-elements.html: Added.
  • platform/mac/fast/inline/positioned-object-between-replaced-elements-expected.checksum: Added.
  • platform/mac/fast/inline/positioned-object-between-replaced-elements-expected.png: Added.
  • platform/mac/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.
1:22 PM Changeset in webkit [83628] by alice.liu@apple.com
  • 25 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=58292
Provide new setting to allow site icon loading despite disabling automatic image loading in general.

Reviewed by Sam Weinig.

Source/WebCore:

Test: http/tests/misc/favicon-loads-with-icon-loading-override.html

  • WebCore.exp.in: Added export symbol
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::startIconLoader): Check new setting before deciding that site icon images shouldn't be loaded.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Add initializer for new setting
(WebCore::Settings::setLoadsSiteIconsIgnoringImageLoadingSetting): Add setter for new setting.

  • page/Settings.h: Explain nuances regarding loadsImagesAutomatically setting.

(WebCore::Settings::loadsSiteIconsIgnoringImageLoadingSetting): Added getter.

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h: Add preference key.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Initialize to false.
(-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
(-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.

  • WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes.

Source/WebKit/win:

  • Interfaces/IWebPreferencesPrivate.idl: Added prefs.
  • Interfaces/WebKit.idl: Touch file to force autogeneration
  • WebPreferenceKeysPrivate.h: Add preference key.
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Initialize setting to false.
(WebPreferences::setLoadsSiteIconsIgnoringImageLoadingPreference): Added setter
(WebPreferences::loadsSiteIconsIgnoringImageLoadingPreference): Added getter

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Add to settings that get propagated upon changes.

Source/WebKit2:

  • Shared/WebPreferencesStore.h: Add macro for setting default value.
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLoadsSiteIconsIgnoringImageLoadingPreference): Added setter.
(WKPreferencesGetLoadsSiteIconsIgnoringImageLoadingPreference): Added getter.

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Add to list of WebCore settings that get propagated to WebKit preferences.

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.

LayoutTests:

  • http/tests/misc/favicon-loads-with-icon-loading-override-expected.txt: Added.
  • http/tests/misc/favicon-loads-with-icon-loading-override.html: Added.
1:14 PM Changeset in webkit [83627] by jberlin@webkit.org
  • 7 edits in trunk/Source/WebKit2

WebKit2: Spelling and Grammar Checking: Make sure to remove the markings from the document
when spelling and/or grammar checking is disabled.
​https://bugs.webkit.org/show_bug.cgi?id=58350

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView toggleContinuousSpellChecking:]):
Move the call to unmark the errors to the WebProcess.
(-[WKView setGrammarCheckingEnabled:]):
Ditto.
(-[WKView toggleGrammarChecking:]):
Ditto.

  • UIProcess/WebPageProxy.cpp:

Remove unused functions.

  • UIProcess/WebPageProxy.h:

Ditto.

  • WebProcess/WebPage/WebPage.messages.in:

Ditto.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setTextCheckerState):
If grammar or spelling checking is disabled, unmark all the pages.
Doing it here allows makes it possible to unmark all pages in a cross-platform way that is
triggered both by selecting the the context menu items and by any other methods of updating
the enabled / disabled state.

1:05 PM Changeset in webkit [83626] by commit-queue@webkit.org
  • 8 edits in trunk

2011-04-12 Thouraya ANDOLSI <​thouraya.andolsi@st.com>

Reviewed by Eric Seidel.

[QT] Enable JIT build for SH4 platforms.
​https://bugs.webkit.org/show_bug.cgi?id=58317
add disable_uitools for SH4 platforms.

  • Source/WebKit.pri:

2011-04-12 Thouraya ANDOLSI <​thouraya.andolsi@st.com>

Reviewed by Eric Seidel.

[Qt] Enable JIT build for SH4 platforms.
​https://bugs.webkit.org/show_bug.cgi?id=58317
enable JIT build for QT backend for SH4 platforms.

2011-04-12 Thouraya ANDOLSI <​thouraya.andolsi@st.com>

Reviewed by Eric Seidel.

[Qt] Enable JIT build for SH4 platforms.
​https://bugs.webkit.org/show_bug.cgi?id=58317

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • QtTestBrowser/QtTestBrowser.pro:
  • Scripts/webkitdirs.pm:
12:56 PM Changeset in webkit [83625] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Cisco Meeting Center will not download or launch from Safari
​https://bugs.webkit.org/show_bug.cgi?id=58366
<rdar://problem/8987139>

It's OK if a plug-in has less (or more) MIME type descriptions than actual MIME types.


  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getPluginInfoFromCarbonResources):
12:45 PM Changeset in webkit [83624] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-04-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Call PluginControllerProxy::platformGeometryDidChange before Plugin::geometryDidChange
​https://bugs.webkit.org/show_bug.cgi?id=58361

Since Plugin::geometryDidChange ends up calling plug-in code it can resize the plug-in which causes
platformGeometryDidChange to be called with the wrong rect.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::geometryDidChange): Call platformGeometryDidChange.
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/mac/PluginControllerProxyMac.mm: (WebKit::PluginControllerProxy::platformGeometryDidChange): Remove the parameters to platformGeometryDidChange and just use m_frameRect instead.
12:37 PM Changeset in webkit [83623] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Move three Mac specific functions to PluginControllerProxyMac.mm.

Reviewed by Sam Weinig.

12:36 PM QtWebKitRelease22 edited by Laszlo Gombos
(diff)
12:35 PM Changeset in webkit [83622] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-04-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Cache the window and plug-in element NPObjects
​https://bugs.webkit.org/show_bug.cgi?id=58355

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::PluginControllerProxy): (WebKit::PluginControllerProxy::~PluginControllerProxy): (WebKit::PluginControllerProxy::windowScriptNPObject): (WebKit::PluginControllerProxy::pluginElementNPObject):
  • PluginProcess/PluginControllerProxy.h:
12:24 PM Changeset in webkit [83621] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-04-12 Thouraya ANDOLSI <​thouraya.andolsi@st.com>

Reviewed by Eric Seidel.

[GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
​https://bugs.webkit.org/show_bug.cgi?id=58333

  • Scripts/build-jsc:
  • Scripts/build-webkit:
12:17 PM Changeset in webkit [83620] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-04-12 George Guo <​George.Guo@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] On Symbian got "Update Error" when installing QtWebkit.sis
​http://bugs.webkit.org/show_bug.cgi?id=58141

If QtWebKit is already in Symbian ROM, we need package to be
both SA and RU type

12:10 PM Changeset in webkit [83619] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-04-12 Tony Chang <​tony@chromium.org>

Reviewed by Andreas Kling.

[Qt] embed checksums in PNGs written by Qt-DRT
​https://bugs.webkit.org/show_bug.cgi?id=58173

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
12:02 PM Changeset in webkit [83618] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-12 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Move StyleChange and other global functions from ApplyStyleCommand to EditingStyle
​https://bugs.webkit.org/show_bug.cgi?id=55974

Moved StyleChange, getIdentifierValue, and legacyFontSizeFromCSSValue from ApplyStyleCommand
to EditingStyle. Also moved reconcileTextDecorationProperties, getIdentifierValue,
setTextDecorationProperty, isCSSValueLength, legacyFontSizeFromCSSValue, extractTextStyles,
diffTextDecorations, fontWeightIsBold, getTextAlignment, and getPropertiesNotIn.

Because of this move, getPropertiesNotIn is no longer visible outside of EditingStyle.cpp

  • editing/ApplyStyleCommand.cpp:
  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp: (WebCore::reconcileTextDecorationProperties): (WebCore::StyleChange::StyleChange): (WebCore::setTextDecorationProperty): (WebCore::getRGBAFontColor): (WebCore::StyleChange::extractTextStyles): (WebCore::diffTextDecorations): (WebCore::fontWeightIsBold): (WebCore::getTextAlignment): (WebCore::getPropertiesNotIn): (WebCore::getIdentifierValue): (WebCore::isCSSValueLength): (WebCore::legacyFontSizeFromCSSValue):
  • editing/EditingStyle.h: (WebCore::StyleChange::cssStyle): (WebCore::StyleChange::applyBold): (WebCore::StyleChange::applyItalic): (WebCore::StyleChange::applyUnderline): (WebCore::StyleChange::applyLineThrough): (WebCore::StyleChange::applySubscript): (WebCore::StyleChange::applySuperscript): (WebCore::StyleChange::applyFontColor): (WebCore::StyleChange::applyFontFace): (WebCore::StyleChange::applyFontSize): (WebCore::StyleChange::fontColor): (WebCore::StyleChange::fontFace): (WebCore::StyleChange::fontSize): (WebCore::StyleChange::operator==): (WebCore::StyleChange::operator!=):
11:45 AM Changeset in webkit [83617] by jam@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

2011-04-11 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium]: Get the list of misspelled words in the WebKit code insetad of in chromium's RenderView
​https://bugs.webkit.org/show_bug.cgi?id=58260

  • public/WebContextMenuData.h:
  • public/WebSpellCheckClient.h: (WebKit::WebSpellCheckClient::spellCheck):
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::checkSpellingOfString):
11:40 AM Changeset in webkit [83616] by abarth@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-04-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Review tool should work well on iPad
​https://bugs.webkit.org/show_bug.cgi?id=58351

On the iPad, the toolbar ends up at some random position in the middle
of the page because of how position:fixed interacts with scrolling on
the iPad. I feel a bit dirty using a user agent detect, but I'm not
sure if there's a better way to detect whether the user agent has this
behavior.

  • code-review.js:
11:30 AM Changeset in webkit [83615] by diegohcg@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-12 Diego Gonzalez <​diegohcg@webkit.org>

[Qt] Better padding for inputs and comboxes in mobile theme
​https://bugs.webkit.org/show_bug.cgi?id=58248

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::setButtonPadding): (WebCore::RenderThemeQt::adjustTextFieldStyle): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::adjustMenuListStyle):
11:30 AM Changeset in webkit [83614] by eric@webkit.org
  • 11 edits
    2 adds in trunk/Tools

2011-04-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should upload failure diffs when tests fail
​https://bugs.webkit.org/show_bug.cgi?id=58348

This change was mostly just plumbing. We were already saving
this information for flaky test reporting. I just made it possible
for normal failures to report archives as well.

I did a little abstraction work to try and share some code between
flakytestreporter.py and this new code. There is still more we could do.

In making this change I also went through and updated the various
places we have urls hard-coded in our python and pointed them at
common.config.urls.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/statusserver.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/tool/bot/botinfo.py: Added.
  • Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
11:19 AM Changeset in webkit [83613] by commit-queue@webkit.org
  • 5 edits
    1 copy in trunk/Source/WebKit/chromium

2011-04-12 Bill Budge <​bbudge@chromium.org>

Reviewed by Darin Fisher.

Move the WebURLLoaderOptions struct into its own file and rename the CrossOriginRequestPolicy enum to conform to the WebKit coding standard.
​https://bugs.webkit.org/show_bug.cgi?id=58287

No new tests. No new functionality exposed.

  • WebKit.gyp:
  • public/WebURLLoader.h:
  • public/WebURLLoaderOptions.h: Added. (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::AssociatedURLLoader):
  • src/AssociatedURLLoader.h:
11:00 AM Changeset in webkit [83612] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/editing/inserting

Update pixel results for editable-inline-element.html since it progressed following r83075.

10:59 AM QtWebKitTesting edited by Ademar Reis
(diff)
10:59 AM QtWebKitCheckList edited by Ademar Reis
(diff)
10:52 AM Changeset in webkit [83611] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-04-11 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when reparenting a runin to a details block.
​https://bugs.webkit.org/show_bug.cgi?id=58228

  • fast/runin/runin-reparent-crash-expected.txt: Added.
  • fast/runin/runin-reparent-crash.html: Added.

2011-04-11 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Replace insertChildNode with addChild in handleRunIn's reparenting
of inlineRunIn to currBlock.
​https://bugs.webkit.org/show_bug.cgi?id=58228

Use addChild instead of insertChildNode since it handles
correct placement of the children, esp where we cannot insert
anything before the first child. e.g. details tag requires that its
first child be a summary child and won't be able to remove child if
that is not the case.

Test: fast/runin/runin-reparent-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
10:50 AM Changeset in webkit [83610] by senorblanco@chromium.org
  • 9 edits
    6 deletes in trunk/LayoutTests

2011-04-12 Stephen White <​senorblanco@chromium.org>

Unreviewed; new chromium layout test baselines.

New baselines after r83541. Note that these look worse, but that's
because we went from greyscale antialiasing to ClearType antialiasing,
but the layout tests turn off ClearType, so they don't get any AA
at all. It looks fine in Chrome.

  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum: Removed.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/text/shadow-translucent-fill-expected.checksum: Removed.
  • platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.checksum: Removed.
  • platform/chromium-win/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-win/svg/css/shadow-changes-expected.checksum: Removed.
  • platform/chromium-win/svg/css/shadow-changes-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.checksum: Removed.
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.checksum: Removed.
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
  • platform/chromium/test_expectations.txt:
10:46 AM Changeset in webkit [83609] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fixing Leopard build.

REGRESSION: WK2: misspelled AX attributes no longer returned from text fields
​https://bugs.webkit.org/show_bug.cgi?id=58304

checkTextOfParagraph is not available on Leopard. That code needs to be conditionalized with USE(UNIFIED_TEXT_CHECKING).

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(AXAttributeStringSetSpelling):

10:40 AM Changeset in webkit [83608] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-12 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed. Added missing files to GNUmakefile.list.am.

  • GNUmakefile.list.am: Added IDBLevelDBBackingStore.[h|cpp].
10:39 AM Changeset in webkit [83607] by cdn@chromium.org
  • 7 edits
    2 adds in trunk

2011-04-12 Cris Neckar <​cdn@chromium.org>

Reviewed by Nikolas Zimmermann.

Tests for crash when non-svg inline text boxes exist in the list of text boxes.
​https://bugs.webkit.org/show_bug.cgi?id=57933

  • svg/text/svg-rtl-text-crash-expected.txt: Added.
  • svg/text/svg-rtl-text-crash.html: Added.

2011-04-12 Cris Neckar <​cdn@chromium.org>

Reviewed by Nikolas Zimmermann.

Add handling for non-svg inline text boxes in text box lists.
​https://bugs.webkit.org/show_bug.cgi?id=57933

Test: svg/text/svg-rtl-text-crash.html

  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint):
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGInlineTextBoxes):
  • rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::closestLeafChildForPosition): (WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
  • rendering/svg/SVGTextQuery.cpp: (WebCore::SVGTextQuery::collectTextBoxesInFlowBox):
10:35 AM Changeset in webkit [83606] by mario@webkit.org
  • 5 edits
    2 adds in trunk

2011-04-12 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Expose menu items and menus as children of a menu bar
​https://bugs.webkit.org/show_bug.cgi?id=56659

New cross-platform test. Skipped in platforms with no results yet.

  • accessibility/aria-menubar-menuitems.html: Added.
  • platform/gtk/accessibility/aria-menubar-menuitems-expected.txt: Added.
  • platform/mac/Skipped: Skipped the new test.
  • platform/win/Skipped: Ditto.

2011-04-12 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Expose menu items and menus as children of a menu bar
​https://bugs.webkit.org/show_bug.cgi?id=56659

Ensure menu items get exposed when they're children of menu bars.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute): Consider menu bars as potential parent objects for menu items.
10:29 AM Changeset in webkit [83605] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[WebKit2 Release Tests] fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html flakey
​https://bugs.webkit.org/show_bug.cgi?id=58337

Skip the test to get the bots green.

  • platform/mac-wk2/Skipped:
10:23 AM Changeset in webkit [83604] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Mark access-zero-sized-canvas as crash on chromium.

  • platform/chromium/test_expectations.txt:
10:18 AM Changeset in webkit [83603] by dbates@webkit.org
  • 3 edits
    2 adds in trunk/Tools

2011-04-12 Daniel Bates <​dbates@rim.com>

Rubber-stamped by Eric Seidel.

svn-apply and/or patch(1) has trouble applying patches that makes changes to files
with Windows line endings
​https://bugs.webkit.org/show_bug.cgi?id=53625

Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
applied to an SCM checkout on a Windows file system and vice-versa.

This issue manifests itself due to custom SCM settings as well as differences in
gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
into svn-apply/unapply to compensate for differences in line endings by converting
the line endings in a patch to match the line endings in the target file (if it exists).

  • Scripts/VCSUtils.pm:
    • Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the content read from the specified file handle. Obviously, this heuristic will not work for files with mixed line endings, but I don't envision such files to be the norm. If this turns out to be an issue then we can improve the heuristic.
    • Added firstEOLInFile().
    • Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash. In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line endings in the diff instead of the line endings in the target file.
    • Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be re-used in parseDiff().
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1} to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
10:11 AM Changeset in webkit [83602] by weinig@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
​https://bugs.webkit.org/show_bug.cgi?id=58336

Reviewed by Adam Roben.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
Remove cache clearing as that is causing tests to crash on Windows 7.

10:07 AM Changeset in webkit [83601] by pfeldman@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-04-12 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: remove scriptWorldType from the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=58324

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/ScriptDebugListener.h: (WebCore::ScriptDebugListener::~ScriptDebugListener):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
  • inspector/front-end/Script.js: (WebInspector.Script):
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile):
9:44 AM Changeset in webkit [83600] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-04-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Should MediaControls::changedNetworkState fiddle with Fullscreen controls?
​https://bugs.webkit.org/show_bug.cgi?id=58163

Covered by existing tests and manual-tests/media-controls.html.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::reset): Moved fullscreen showing/hiding here. (WebCore::MediaControls::changedNetworkState): ... from here.
9:36 AM Changeset in webkit [83599] by loislo@chromium.org
  • 8 edits in trunk

2011-04-12 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
​https://bugs.webkit.org/show_bug.cgi?id=58335

It was the method for Inspector layout tests.
We can use RuntimeAgent.evaluate instead.

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.completeTest):

2011-04-12 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
​https://bugs.webkit.org/show_bug.cgi?id=58335

It was the method for Inspector layout tests.
We can use RuntimeAgent.evaluate instead.

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend):
  • inspector/front-end/TestController.js: (WebInspector.TestController.prototype.notifyDone):
9:34 AM Changeset in webkit [83598] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

Merge branch 'bug/58307' into staging

9:29 AM Changeset in webkit [83597] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-04-12 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] advertize HTTP Live Streaming mime-type
​https://bugs.webkit.org/show_bug.cgi?id=58318

Register the hls mime-type in the internal cache if found in the
typefind factories.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
9:24 AM Changeset in webkit [83596] by morrita@google.com
  • 11 edits
    2 deletes in trunk/Source/WebCore

2011-04-11 MORITA Hajime <​morrita@google.com>

Reviewed by Ryosuke Niwa.

RenderIndicator and ShadowBlockElement are no longer used.
​https://bugs.webkit.org/show_bug.cgi?id=58277

Removed RenderIndicator and ShadowBlockElement.

No new tests. Just removed unused code.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderIndicator.cpp: Removed.
  • rendering/RenderIndicator.h: Removed.
  • rendering/RenderMeter.h:
  • rendering/RenderingAllInOne.cpp:
  • rendering/ShadowElement.cpp:
  • rendering/ShadowElement.h:
9:22 AM Changeset in webkit [83595] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=58334
LayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work in WK2

Rubberstamped by Adam Roben.

  • platform/mac-wk2/Skipped: Skip a new test due to an identified bug in WKTR and classify three other skipped tests with that same bug.
9:13 AM Changeset in webkit [83594] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-12 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Adjusted chromium test expectations (webgl-reflection.html sometimes crashes on chromium mac debug)

  • platform/chromium/test_expectations.txt:
8:58 AM Changeset in webkit [83593] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

fast/css/dashboard-regions-attr-crash.html asserts
​https://bugs.webkit.org/show_bug.cgi?id=58233

Reviewed by Benjamin Poulain.

Move DASHBOARD_SUPPORT feature detection from features.pri to CodeGenerators.pri
not to generate incorrect properties into CSSPropertyNames.h.

  • CodeGenerators.pri:
  • features.pri:
8:56 AM Changeset in webkit [83592] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Leopard Intel Debug Tests] fast/events/tabindex-focus-blur-all.html crashing since (83513,
83521].
​https://bugs.webkit.org/show_bug.cgi?id=58327

Skip the test on Leopard to get the bots green.

  • platform/mac-leopard/Skipped:
8:50 AM Changeset in webkit [83591] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows expected failure results for a new test

<​http://webkit.org/b/58325> tracks the failure.

  • platform/win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Added.
8:49 AM Changeset in webkit [83590] by Adam Roben
  • 1 edit
    1 delete in trunk/LayoutTests

Remove no-longer-needed Windows-specific results for an arraybuffer test

Fixes <​http://webkit.org/b/58326> REGRESSION (r83532):
http/tests/xmlhttprequest/send-array-buffer.html failing on Windows

  • platform/win/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Removed.
8:45 AM Changeset in webkit [83589] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

REGRESSION: WK2: misspelled AX attributes no longer returned from text fields
​https://bugs.webkit.org/show_bug.cgi?id=58304

Reviewed by Dan Bernstein.

checkSpellingOfString is no longer implemented in WK2. Accessibility needs to change to use
checkTextOfParagraph in order to retrieve misspelled ranges.

Existing tests cover this functionality.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(AXAttributeStringSetSpelling):

8:35 AM Changeset in webkit [83588] by jberlin@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

compositing/objects/composited-object-alignment.html causing failures in other tests since
it's introduction in r83518
​https://bugs.webkit.org/show_bug.cgi?id=58323

Disabling the test until it is fixed in order to get the bots green.

  • compositing/objects/composited-object-alignment.html: Removed.
  • compositing/objects/composited-object-alignment.html-disabled: Copied from LayoutTests/compositing/objects/composited-object-alignment.html.
7:58 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
7:46 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
7:43 AM Changeset in webkit [83587] by sergio@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-12 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove m_idleHandler from ResourceHandleSoup
​https://bugs.webkit.org/show_bug.cgi?id=58319

The m_idleHandler attribute is no longer used in ResourceHandleSoup.
No new tests needed, no functionality change.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
7:43 AM QtWebKitFeatures22 edited by Ademar Reis
(diff)
7:32 AM QtWebKit edited by Ademar Reis
(diff)
7:31 AM QtWebKit edited by Ademar Reis
(diff)
7:01 AM Changeset in webkit [83586] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-12 Andrey Adaikin <​aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Breakpoints and execution line decoration should stay in place if the edited line is not whitespace
​https://bugs.webkit.org/show_bug.cgi?id=58314

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._lineNumberAfterEditing):
6:52 AM Changeset in webkit [83585] by podivilov@chromium.org
  • 5 edits in trunk

2011-04-11 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move shortcut handlers from SourceFrame to TextViewer.
​https://bugs.webkit.org/show_bug.cgi?id=58238

  • inspector/debugger/live-edit.html:

2011-04-11 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move shortcut handlers from SourceFrame to TextViewer.
​https://bugs.webkit.org/show_bug.cgi?id=58238

Commit/cancel editing functionality is common for all resource types, and it deals with TextViewer state.

6:25 AM Changeset in webkit [83584] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

2011-04-12 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: cookies view is empty even for sites with cookies.
​https://bugs.webkit.org/show_bug.cgi?id=58316

  • http/tests/inspector/resource-tree-model-expected.txt: Added.
  • http/tests/inspector/resource-tree-model.html: Added.

2011-04-12 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: cookies view is empty even for sites with cookies.
​https://bugs.webkit.org/show_bug.cgi?id=58316

Test: http/tests/inspector/resource-tree-model.html

  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
6:03 AM Changeset in webkit [83583] by loislo@chromium.org
  • 7 edits in trunk/LayoutTests

2011-04-12 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: InspectorTest.addObject dumps inner array properties as objects.
​https://bugs.webkit.org/show_bug.cgi?id=58310

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.addObject): (initialize_InspectorTest.InspectorTest.addArray): (initialize_InspectorTest.InspectorTest.dump):
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-parameters-expected.txt:
  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/report-protocol-errors-expected.txt:
5:57 AM Changeset in webkit [83582] by senorblanco@chromium.org
  • 3 edits
    3 adds in trunk

2011-04-11 Stephen White <​senorblanco@chromium.org>

Reviewed by James Robinson.

[chromium] GPU-accelerated canvas-to-canvas drawImage is incorrect.
​https://bugs.webkit.org/show_bug.cgi?id=58258

When one accelerated canvas is drawn to another via drawImage(), if the
prior call in the source canvas was non-accelerated, the
hardware canvas is not up-to-date, and the results will be incorrect.
Fixed by calling prepareForHardwareDraw() on the source context.

Test: fast/canvas/canvas-to-canvas.html

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::draw):

2011-04-11 Stephen White <​senorblanco@chromium.org>

Reviewed by James Robinson.

[chromium] Accelerated canvas-to-canvas drawImage() is incorrect.
​https://bugs.webkit.org/show_bug.cgi?id=58258

Add a new test to cover canvas-to-canvas drawImage() after a
non-accelerated (strokeRect()) call.

  • fast/canvas/canvas-to-canvas-expected.txt: Added.
  • fast/canvas/canvas-to-canvas.html: Added.
  • fast/canvas/script-tests/canvas-to-canvas.js: Added.
5:28 AM Changeset in webkit [83581] by mnaganov@chromium.org
  • 5 edits
    2 copies
    35 adds in trunk

2011-04-12 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add some more tests for detailed heap snapshots UI.
​https://bugs.webkit.org/show_bug.cgi?id=58146

Tests: inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html

inspector/profiler/detailed-heapshots-comparison-show-all.html
inspector/profiler/detailed-heapshots-comparison-show-next.html
inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-comparison-sorting.html
inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-dominators-show-all.html
inspector/profiler/detailed-heapshots-dominators-show-next.html
inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html
inspector/profiler/detailed-heapshots-dominators-sorting.html
inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html

  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotDiffDataGrid):

2011-04-12 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add some more tests for detailed heap snapshots UI.
​https://bugs.webkit.org/show_bug.cgi?id=58146

  • inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-comparison-show-all.html: Added.
  • inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-comparison-show-next.html: Added.
  • inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html: Copied from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html.
  • inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-comparison-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-dominators-show-all.html: Added.
  • inspector/profiler/detailed-heapshots-dominators-show-next-actual.txt: Added.
  • inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-dominators-show-next.html: Added.
  • inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-dominators-sorting.html: Added.
  • inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html:
  • inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt: Added.
  • inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html: Copied from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html.
  • inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest.): (initialize_DetailedHeapshotTest):
  • platform/chromium/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt: Added.
  • platform/chromium/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt: Added.
5:12 AM Changeset in webkit [83580] by loislo@chromium.org
  • 5 edits in trunk

2011-04-12 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: there was incorrect value of id property of responses for malformed json-rpc 2.0 requests.
​https://bugs.webkit.org/show_bug.cgi?id=58305

It was 0 if the message is not a json object or it has no id property. But according to spec it must be null.

  • inspector/CodeGeneratorInspector.pm:

2011-04-12 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: there was incorrect value of id property of responses for malformed json-rpc 2.0 requests.
​https://bugs.webkit.org/show_bug.cgi?id=58305

It was 0 if the message is not a json object or it has no id property. But according to spec it must be null.

  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:
5:00 AM Changeset in webkit [83579] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-04-12 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
​https://bugs.webkit.org/show_bug.cgi?id=58251

Fix an issue with slot names after ​http://trac.webkit.org/changeset/83512.

  • Api/qwebframe.cpp: (QWebFrame::QWebFrame):
4:39 AM Changeset in webkit [83578] by podivilov@chromium.org
  • 4 edits in trunk/Source

2011-04-11 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [chromium] script formatting doesn't work when chromium is built with debug_devtools=1.
​https://bugs.webkit.org/show_bug.cgi?id=58232

  • WebCore.gypi:

2011-04-11 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [chromium] script formatting doesn't work when chromium is built with debug_devtools=1.
​https://bugs.webkit.org/show_bug.cgi?id=58232

  • WebKit.gyp:
4:38 AM Changeset in webkit [83577] by podivilov@chromium.org
  • 5 edits in trunk

2011-04-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Most resources in the Network panel show a blank panel when clicked.
​https://bugs.webkit.org/show_bug.cgi?id=58273

  • inspector/debugger/source-frame-expected.txt:
  • inspector/debugger/source-frame.html:

2011-04-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Most resources in the Network panel show a blank panel when clicked.
​https://bugs.webkit.org/show_bug.cgi?id=58273

4:37 AM Changeset in webkit [83576] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-12 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: document runtime agent, share remote object definition between domains.
​https://bugs.webkit.org/show_bug.cgi?id=58246

  • inspector/Inspector.json:
4:35 AM Changeset in webkit [83575] by pfeldman@chromium.org
  • 10 edits in trunk

2011-04-12 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: document console domain, support cross-domain type references.
​https://bugs.webkit.org/show_bug.cgi?id=58240

  • inspector/protocol/console-agent-expected.txt:

2011-04-12 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: document console domain, support cross-domain type references.
​https://bugs.webkit.org/show_bug.cgi?id=58240

  • inspector/ConsoleMessage.cpp: (WebCore::messageSourceValue): (WebCore::messageTypeValue): (WebCore::messageLevelValue): (WebCore::ConsoleMessage::addToFrontend):
  • inspector/Inspector.json:
  • inspector/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::buildInspectorObject):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement): (WebInspector.ConsoleMessage.prototype.isEqual):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
  • inspector/generate-inspector-idl:
  • page/Console.h:
4:09 AM Changeset in webkit [83574] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] inspector/styles/styles-disable-then-enable.html make inspector/styles/styles-iframe.html fail in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=58313

  • platform/qt/Skipped: Add inspector/styles/styles-disable-then-enable.html.
3:57 AM Changeset in webkit [83573] by Philippe Normand
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-12 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for 2 new tests.

  • platform/gtk/fast/multicol/huge-column-count-expected.txt: Added.
  • platform/gtk/fast/overflow/trailing-float-linebox-expected.txt: Added.
3:05 AM Changeset in webkit [83572] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] 9 tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
[Qt] 6 tests have different results on 64 bit compared to 32 bit
​https://bugs.webkit.org/show_bug.cgi?id=52810
​https://bugs.webkit.org/show_bug.cgi?id=52812

  • platform/qt/Skipped: Add one more test.
2:35 AM Changeset in webkit [83571] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

Skip a test on WebKit2 that depends on layoutTestController.setGeolocationPermission.

Rubber-stamped by Csaba Osztrogonác.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
2:18 AM Changeset in webkit [83570] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-04-12 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline of fast/block/float/021.html and
skipping 2 failing tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/block/float/021-expected.txt:
2:11 AM Changeset in webkit [83569] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-12 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Adjusted chromium test expectations (negative-z-index.html may crash on win & linux debug)

  • platform/chromium/test_expectations.txt:
2:06 AM Changeset in webkit [83568] by alex
  • 3 edits in trunk/Source/WebKit2

2011-04-12 Alejandro G. Castro <​alex@igalia.com>

Fixed GTK compilation after r83454.

  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::findStringInCustomRepresentation): (WebKit::WebView::countStringMatchesInCustomRepresentation):
  • UIProcess/gtk/WebView.h:
1:54 AM Changeset in webkit [83567] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-12 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Adjusted chromium test expectations (webgl-nonpremultiplied-blend.html crashes on Mac OS 10.6 DEBUG)

  • platform/chromium/test_expectations.txt:
1:53 AM Changeset in webkit [83566] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

2011-04-06 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] RTSP playback broken
​https://bugs.webkit.org/show_bug.cgi?id=56930

Rely on {audio,video}-changed playbin2 signals instead of the
-tags-changed signals because some media don't provide tags and
then can trick the media-player to not paint video, for instance.

Also trigger a video size calculation after the video sink
negotiated its caps. This is useful in the cases where
audio-changed signal is emitted but the video sink takes more time
to negociate caps with its peer.

This patch also fixes the rtsp manual-test with a new stream url
which seems to be more permanent than the previous WWDC keynote
stream.

  • manual-tests/video-rtsp.html:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateVideoChangedCallback): (WebCore::mediaPlayerPrivateAudioChangedCallback): (WebCore::mediaPlayerPrivateAudioChangeTimeoutCallback): (WebCore::mediaPlayerPrivateVideoChangeTimeoutCallback): (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::naturalSize): (WebCore::MediaPlayerPrivateGStreamer::videoChanged): (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo): (WebCore::MediaPlayerPrivateGStreamer::audioChanged): (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio): (WebCore::MediaPlayerPrivateGStreamer::paint): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
1:39 AM Changeset in webkit [83565] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] 9 tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
[Qt] 6 tests have different results on 64 bit compared to 32 bit
​https://bugs.webkit.org/show_bug.cgi?id=52810
​https://bugs.webkit.org/show_bug.cgi?id=52812

  • platform/qt/Skipped: Add failing tests until fix.
1:29 AM Changeset in webkit [83564] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-04-12 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Failed/canceled resource requests kept showing as Pending in network panel.
​https://bugs.webkit.org/show_bug.cgi?id=58135

Added statuses for failed/canceled resource loading.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didFailLoading):
  • inspector/front-end/NetworkManager.js:
  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/Resource.js:
1:14 AM Changeset in webkit [83563] by Csaba Osztrogonác
  • 1 edit
    6 adds in trunk/LayoutTests

[Qt] Add platform specific expected files for new tests introduced in r83514 and r83470.

  • platform/qt/fast/multicol/huge-column-count-expected.checksum: Added.
  • platform/qt/fast/multicol/huge-column-count-expected.png: Added.
  • platform/qt/fast/multicol/huge-column-count-expected.txt: Added.
  • platform/qt/fast/overflow/trailing-float-linebox-expected.checksum: Added.
  • platform/qt/fast/overflow/trailing-float-linebox-expected.png: Added.
  • platform/qt/fast/overflow/trailing-float-linebox-expected.txt: Added.
1:13 AM Changeset in webkit [83562] by steveblock@google.com
  • 5 edits in trunk

2011-04-12 Steve Block <​steveblock@google.com>

Reviewed by Oliver Hunt.

Callable objects created via JavaScriptCore API cannot be used as Geolocation callbacks
​https://bugs.webkit.org/show_bug.cgi?id=40012

Covered by fast/dom/Geolocation/argument-types.html
This is a revert of ​http://trac.webkit.org/changeset/60522

  • fast/dom/Geolocation/argument-types-expected.txt:
  • fast/dom/Geolocation/script-tests/argument-types.js:

2011-04-12 Steve Block <​steveblock@google.com>

Reviewed by Oliver Hunt.

Callable objects created via JavaScriptCore API cannot be used as Geolocation callbacks
​https://bugs.webkit.org/show_bug.cgi?id=40012

Covered by fast/dom/Geolocation/argument-types.html

  • bindings/js/CallbackFunction.cpp: (WebCore::checkFunctionOnlyCallback):
12:52 AM Changeset in webkit [83561] by Philippe Normand
  • 3 edits
    1 add in trunk/Source/WebCore

2011-04-07 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] report playback statistics
​https://bugs.webkit.org/show_bug.cgi?id=58033

Provide media playback statistics using fpsdisplaysink and
position queries.

  • manual-tests/video-statistics.html: Added.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::decodedFrameCount): (WebCore::MediaPlayerPrivateGStreamer::droppedFrameCount): (WebCore::MediaPlayerPrivateGStreamer::audioDecodedByteCount): (WebCore::MediaPlayerPrivateGStreamer::videoDecodedByteCount): (WebCore::MediaPlayerPrivateGStreamer::updateAudioSink): (WebCore::MediaPlayerPrivateGStreamer::updateStates): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
12:48 AM Changeset in webkit [83560] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-04-11 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] warnings in media/video-set-rate-from-pause.html
​https://bugs.webkit.org/show_bug.cgi?id=58220

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::setRate): Pause the pipeline if new rate is zero, like advised in the GStreamer documentation of gst_event_new_seek().
12:13 AM Changeset in webkit [83559] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-12 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Adjusted chrome test exceptations (state-url-sets-links-visited.html fails
because of ​https://bugs.webkit.org/show_bug.cgi?id=37297)

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.