Context Navigation

WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::webView):
WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged):
webkit/webkitwebview.cpp: (WebKit::kit):

9:54 PM Changeset in webkit [85831] by rniwa@webkit.org

3 edits in trunk/Source/WebKit/win

2011-05-04 Ryosuke Niwa <rniwa@webkit.org>

Windows build fix attempt after r85823

WebCoreSupport/WebChromeClient.h: (WebChromeClient::webView):
WebView.cpp: (kit):

9:43 PM Changeset in webkit [85830] by morrita@google.com

2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Marking at r85822 was not enough. Re-marked it.

platform/chromium/test_expectations.txt:

9:35 PM Changeset in webkit [85829] by morrita@google.com

2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed flaky marking to full-screen-stacking-context.html.

platform/chromium/test_expectations.txt:

9:22 PM Changeset in webkit [85828] by kerz@chromium.org

1 edit in branches/chromium/742/LayoutTests/platform/chromium/test_expectations.txt

getting chromium continuous branch builder tests working again

8:55 PM Changeset in webkit [85827] by eric@webkit.org

3 edits in trunk/Tools

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add more missing imports from scm refactor
https://bugs.webkit.org/show_bug.cgi?id=60239

Scripts/webkitpy/common/checkout/scm/git.py:
Scripts/webkitpy/common/checkout/scm/svn.py:

8:07 PM Changeset in webkit [85826] by rniwa@webkit.org

4 edits in trunk/Source/WebCore

2011-05-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Make more member functions in EventHandler private
https://bugs.webkit.org/show_bug.cgi?id=60200

Reduced the number of public member functions in EventHandler.

WebCore.exp.in:
page/EventHandler.cpp: (WebCore::EventHandler::handleAutoscroll): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
page/EventHandler.h: (WebCore::EventHandler::mouseDownMayStartSelect):

8:03 PM Changeset in webkit [85825] by commit-queue@webkit.org

3 edits
3 adds in trunk

2011-05-04 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
https://bugs.webkit.org/show_bug.cgi?id=60202

Adds a regression test for composited content changing from transform-style: preserve-3d to flat.

compositing/repaint/transform-style-change-expected.png: Added.
compositing/repaint/transform-style-change-expected.txt: Added.
compositing/repaint/transform-style-change.html: Added.

2011-05-04 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
https://bugs.webkit.org/show_bug.cgi?id=60202

In r85136 I accidentally transposed two lines in GraphicsLayerChromium when adding a null check. This switches
the order back and adds a regression test.

Test: compositing/repaint/transform-style-change.html

platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

7:42 PM Changeset in webkit [85824] by morrita@google.com

1 edit
2 adds in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed expectations update.

platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.txt: Added.
platform/chromium-win/fullscreen/full-screen-stacking-context-expected.txt: Added.

7:36 PM Changeset in webkit [85823] by cdn@chromium.org

32 edits
2 adds in trunk

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Tests whether a style media specifier inside an svg image will crash.
https://bugs.webkit.org/show_bug.cgi?id=49902

fast/media/media-svg-crash-expected.txt: Added.
fast/media/media-svg-crash.html: Added.

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

Test: fast/media/media-svg-crash.html

loader/EmptyClients.h: (WebCore::EmptyChromeClient::webView):
page/ChromeClient.h:
page/brew/ChromeClientBrew.h: (WebCore::ChromeClientBrew::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getWebView):
src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::webView):
src/ChromeClientImpl.h:
src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::initialize):
src/PlatformBridge.cpp: (WebCore::toWebWidgetClient):
src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::fromPage):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

WebCoreSupport/ChromeClientEfl.h: (WebCore::ChromeClientEfl::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

WebCoreSupport/ChromeClientHaiku.h: (WebCore::ChromeClientHaiku::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

WebCoreSupport/WebChromeClient.h: (WebChromeClient::webView):
WebView/WebFrame.mm: (kit):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

WebCoreSupport/WebChromeClient.h: (WebChromeClient::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

WebCoreSupport/ChromeClientWinCE.h: (WebKit::ChromeClientWinCE::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

WebProcess/WebCoreSupport/WebChromeClient.h: (WebKit::WebChromeClient::webView):

7:32 PM Changeset in webkit [85822] by morrita@google.com

2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed skipping text-block-child-crash.xhtml

platform/chromium/test_expectations.txt:

7:24 PM Changeset in webkit [85821] by eric@webkit.org

4 edits in trunk/Tools

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

sheriff-bot is having more exception trouble
https://bugs.webkit.org/show_bug.cgi?id=60233

A webpage-forced build was causing SB to throw an exception.
We've long had this bug, but we just didn't notice it until now.

In debugging this I found we fetch an absurd amount of data now
that we use buildbot's json (instead of xmlrpc), so I added
the filter=1 parameter to reduce it a little. That required
me to handle the case where filter=1 would strip
result=0 in some cases (it's unclear why it does that).

Scripts/webkitpy/common/net/buildbot/buildbot.py:
Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

7:08 PM Changeset in webkit [85820] by ojan@chromium.org

1 edit
3 adds in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Commit failing result. It's not clear to me why this test is failing.
There's nothing platform specific about it, it doesn't depend on the
system environment and it's not failing on the chromium win7 bot.

Committing this for now to green the tree.

platform/win-7sp0/fast/harness/results-expected.txt: Added.

7:07 PM Changeset in webkit [85819] by xan@webkit.org

2 edits in trunk

2011-05-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix warnings in webkit.m4 with autoconf 2.68
https://bugs.webkit.org/show_bug.cgi?id=60189

Use AC_LANG_SOURCE when passing source code to AC_COMPILE_IFELSE
to remove warnings.

Source/autotools/webkit.m4: ditto.

6:16 PM Changeset in webkit [85818] by Joseph Pecoraro

3 edits
2 adds in trunk

2011-05-04 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Unable to Paste After Deleting Text from Input due to -webkit-user-select
https://bugs.webkit.org/show_bug.cgi?id=60219

editing/pasteboard/paste-placeholder-input-expected.txt: Added.
editing/pasteboard/paste-placeholder-input.html: Added.

2011-05-04 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Unable to Paste After Deleting Text from Input due to -webkit-user-select
https://bugs.webkit.org/show_bug.cgi?id=60219

When deleting all the text inside the input a placeholder <br>
element was inserted for the selection point. However, when
pasting, the test run computes the -webkit-user-select for the
<br> element, instead of what would be the text inside the
<input> and incorrectly disallows selection and prevented
the paste.

Test: editing/pasteboard/paste-placeholder-input.html

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering): skip <br> elements above us as those are likely placeholder elements.

5:49 PM Changeset in webkit [85817] by morrita@google.com

2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed marking flaky tests.

platform/chromium/test_expectations.txt:

5:43 PM Changeset in webkit [85816] by cdn@chromium.org

2 edits in trunk/Tools

2011-05-04 Cris Neckar <cdn@chromium.org>

Unreviewed, Adding Cris Neckar as a committer

Scripts/webkitpy/common/config/committers.py:

5:43 PM Changeset in webkit [85815] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Windows build of WebKit GTK needs to be able to find SystemInfo.h
https://bugs.webkit.org/show_bug.cgi?id=60221

GNUmakefile.am: add Source/WebCore/platform/win to the paths searched for headers, since Source/WebCore/platform/win/SystemInfo.h header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp on Windows.

5:42 PM Changeset in webkit [85814] by vangelis@chromium.org

7 edits
5 adds in trunk

2011-05-04 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding a new layout test for perpendicular layers.
https://bugs.webkit.org/show_bug.cgi?id=59255

platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Added.
platform/chromium/compositing/perpendicular-layer-sorting.html: Added.
platform/chromium/test_expectations.txt:

2011-05-04 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Improve sorting of layers in hierarchies that preserve-3d
by testing for overlapping regions between layer pairs and doing a
topological sort to determine the right order.
https://bugs.webkit.org/show_bug.cgi?id=59255

Test: platform/chromium/compositing/perpendicular-layer-sorting.html

WebCore.gypi:
platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
platform/graphics/chromium/LayerRendererChromium.h:
platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::clearRenderSurface):
platform/graphics/chromium/cc/CCLayerSorter.cpp: Added. (WebCore::perpProduct): (WebCore::innerProduct): (WebCore::pointInColinearEdge): (WebCore::edgeEdgeTest): (WebCore::CCLayerSorter::LayerIntersector::LayerIntersector): (WebCore::CCLayerSorter::LayerIntersector::go): (WebCore::CCLayerSorter::LayerIntersector::edgeTriangleTest): (WebCore::CCLayerSorter::LayerIntersector::triangleTriangleTest): (WebCore::CCLayerSorter::LayerIntersector::checkZDiff): (WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint): (WebCore::CCLayerSorter::CCLayerSorter): (WebCore::CCLayerSorter::checkOverlap): (WebCore::CCLayerSorter::createGraphNodes): (WebCore::CCLayerSorter::createGraphEdges): (WebCore::CCLayerSorter::removeEdgeFromList): (WebCore::CCLayerSorter::sort):
platform/graphics/chromium/cc/CCLayerSorter.h: Added. (WebCore::CCLayerSorter::GraphNode::GraphNode): (WebCore::CCLayerSorter::GraphEdge::GraphEdge):

5:23 PM Changeset in webkit [85813] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Geoffrey Garen.

Port MachineStackMarker.cpp to Windows x64
https://bugs.webkit.org/show_bug.cgi?id=60216

heap/MachineStackMarker.cpp: (JSC::getPlatformThreadRegisters): the CONTEXT struct is usable also on 64-bit Windows. (JSC::otherThreadStackPointer): return the Rsp register on Windows x64.

5:09 PM Changeset in webkit [85812] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Link libjavascriptcoregtk on Windows with winmm.dll
https://bugs.webkit.org/show_bug.cgi?id=60215

GNUmakefile.am:

5:07 PM Changeset in webkit [85811] by jer.noble@apple.com

9 edits
3 adds in trunk

2011-05-03 Jer Noble <jer.noble@apple.com>

Reviewed by Antti Koivisto.

Safari: Video at apple.com cannot play at full screen mode with layout distortion
https://bugs.webkit.org/show_bug.cgi?id=60140

fullscreen/full-screen-stacking-context-expected.txt: Added.
fullscreen/full-screen-stacking-context.html: Added.
platform/mac/fullscreen/full-screen-stacking-context-expected.png: Added.

2011-05-03 Jer Noble <jer.noble@apple.com>

Reviewed by Antti Koivisto.

Safari: Video at apple.com cannot play at full screen mode with layout distortion
https://bugs.webkit.org/show_bug.cgi?id=60140

Because a fullscreen element may be in a stacking context with a lower z-index than
a sibling stacking context, those higher contexts would sometimes "pop" through the
full screen renderer. To facilitate eliminating all the stacking contexts aside from
the full screen renderer, added a new pseudo-class specific to video or audio full
screen elements. Then, added a new UA rule which resets the z-index and opacities of
all elements under said pseudo-class to auto and 1 respectively. To facilitate quick
identity checking of HTMLMediaElements, added isMediaElement() virtual function to
Element and HTMLMediaElement.

Test: fullscreen/full-screen-stacking-context.html

css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Support PseudoFullScreenMediaDocument. (WebCore::nameToPseudoTypeMap): Support fullScreenMediaDocument. (WebCore::CSSSelector::extractPseudoType): Support PseudoFullScreenMediaDocument.
css/CSSSelector.h: Add PseudoFullScreenMediaDocument.
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Support PseudoFullScreenMediaDocument.
css/fullscreen.css: (:root:-webkit-full-screen-document:not(:-webkit-full-screen)): Corrected these names,

which were missing the -webkit prefix.

(:root:-webkit-full-screen-media-document *:not(-webkit-full-screen)): Added.

dom/Element.h: (WebCore::Element::isMediaElement): Added, returns false.
html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::isMediaElement): Added, returns true.
rendering/style/RenderStyleConstants.h: Added FULL_SCREEN_MEDIA_DOCUMENT.

5:01 PM Changeset in webkit [85810] by leviw@chromium.org

3 edits in trunk/Source/WebCore

2011-05-04 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Split findNextLineBreak into a LineBreaker class
https://bugs.webkit.org/show_bug.cgi?id=60209

Breaking findNextLineBreak into a new class inside RenderBlock. Currently it's tracking
nearly no state, but subsequent patches will move some of the local variables used throughout
the nextLineBreak function into member variables to simplify breaking off helper functions from
the bloated function.

No new tests since this is just moving code around.

WebCore.xcodeproj/project.pbxproj:
rendering/RenderBlock.h: (WebCore::RenderBlock::LineBreaker::LineBreaker): (WebCore::RenderBlock::LineBreaker::lineWasHyphenated): Accessor. (WebCore::RenderBlock::LineBreaker::positionedObjects): Ditto. (WebCore::RenderBlock::LineBreaker::clear): Ditto.
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace): (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): (WebCore::RenderBlock::LineBreaker::reset): (WebCore::RenderBlock::LineBreaker::nextLineBreak):

4:56 PM Changeset in webkit [85809] by ojan@chromium.org

4 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] Hide the entire table if all failures are expected
https://bugs.webkit.org/show_bug.cgi?id=60225

If in a port that uses expected results and all failures are expected,
hide the table as well as the rows when hiding expected failures.

fast/harness/resources/results-test.js:
fast/harness/results-expected.txt:
fast/harness/results.html:

4:49 PM Changeset in webkit [85808] by jeffm@apple.com

7 edits in trunk/Source/WebKit2

2011-05-04 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Send unhandled wheel events to parent window on Windows
https://bugs.webkit.org/show_bug.cgi?id=60220

Keep track of wheel events using NativeWebWheelEvent instead of WebWheelEvent in WebPageProxy
so we can send the native event to the parent window if WebKit doesn't handle it.

UIProcess/API/mac/WKView.mm: Use NativeWebWheelEvent instead of WebWheelEvent.

UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::wheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Removed initialization of obsolete m_processingWheelEvent member variable. (WebKit::coalesceWheelEvents): Use NativeWebWheelEvent instead of WebWheelEvent and add a note that this won't work if we ever enable MERGE_WHEEL_EVENTS. (WebKit::WebPageProxy::handleWheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent, keep track of the current event in m_currentlyProcessedWheelEvent. (WebKit::WebPageProxy::didReceiveEvent): Call wheelEventNotHandled() on Windows if wheel event is not handled. (WebKit::WebPageProxy::processDidCrash): Clear out m_currentlyProcessedWheelEvent.
UIProcess/WebPageProxy.h: Change handleWheelEvent() to take a NativeWebWheelEvent, added wheelEventNotHandled() on Windows, remove m_processingWheelEvent, add m_currentlyProcessedWheelEvent.

UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::wheelEventNotHandled): Added.

UIProcess/win/WebView.cpp: (WebKit::WebView::onWheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent.

4:46 PM Changeset in webkit [85807] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

2011-05-04 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: odd result order
https://bugs.webkit.org/show_bug.cgi?id=60193

This test uses setTimeout to check that the result property of
asynchronous requests persists into the setTimeout callback.

storage/indexeddb/mozilla/odd-result-order-expected.txt: Added.
storage/indexeddb/mozilla/odd-result-order.html: Added.

4:42 PM Changeset in webkit [85806] by andersca@apple.com

5 edits in trunk/Source/WebKit2

2011-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add bundle API for making a page paint as the background of another page
https://bugs.webkit.org/show_bug.cgi?id=60227

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetUnderlayPage): Call WebPage::setUnderlayPage.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Null out the underlay page.

(WebKit::WebPage::layoutIfNeeded):
Layout the underlay page if necessary.

(WebKit::WebPage::drawRect):
Draw the underlay page.

4:36 PM Changeset in webkit [85805] by hclam@chromium.org

3 edits in trunk/LayoutTests

2011-05-04 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Test expectations.

platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
platform/chromium/test_expectations.txt:

4:34 PM Changeset in webkit [85804] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

2011-05-04 Tomasz Morawski <t.morawski@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Added error check for _ewk_init_body result.
https://bugs.webkit.org/show_bug.cgi?id=60149

The ewk_init function should be failed when _ewk_init_body function
return false.

ewk/ewk_main.cpp: (ewk_init):

4:26 PM Changeset in webkit [85803] by commit-queue@webkit.org

4 edits in trunk

2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
https://bugs.webkit.org/show_bug.cgi?id=59462

WebProcess.pro: Add Symbian OS capabilities to web process executable. Also enable data paging flag and prevent application's icon from showing up in the application grid.

2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
https://bugs.webkit.org/show_bug.cgi?id=59462

MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging.

4:22 PM Changeset in webkit [85802] by eric@webkit.org

8 edits in trunk/Tools

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

The testing EWS bots should upload layout-test-results.zip to bugs after failures
https://bugs.webkit.org/show_bug.cgi?id=60223

This required sharing a bit of code between the commit-queue
(which already knew how to do this) and the new EWS testing bots.

In the process I also cleaned up EWS testing a little and
removed some dead code from the commit-queue.

Scripts/webkitpy/common/config/committervalidator.py:
Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:

4:08 PM Changeset in webkit [85801] by Nate Chapin

3 edits in branches/chromium/742/Source/WebKit/chromium

2011-05-04 Nate Chapin <Nate Chapin>

Reviewed by Mihai Parparita.

Ensure we don't overwrite user-specified scroll positions
on same document HistoryItem navigations.
https://bugs.webkit.org/show_bug.cgi?id=59877

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::currentHistoryItem): (WebKit::WebFrameImpl::WebFrameImpl):
src/WebFrameImpl.h:

3:55 PM Changeset in webkit [85800] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Adam Barth.

Add COMPILER(MINGW) to the compilers using the Microsoft C Runtime's vsnprintf.
The vsnprintf is part of Microsoft C runtime used also by MinGW (GCC) toolchain.
https://bugs.webkit.org/show_bug.cgi?id=58579

dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::error):

3:54 PM Changeset in webkit [85799] by alexis.menard@openbossa.org

8 edits in trunk/Source

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed warning fix.

The variable is just unused.

tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed warning fix.

The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
a warning in Release build.

dom/Node.cpp: (WebCore::Node::removeEventListener):
platform/DateComponents.cpp: (WebCore::DateComponents::parseTime):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::convertToLayerCoords):
storage/StorageMap.cpp: (WebCore::StorageMap::importItem):
svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildShadowTree): (WebCore::SVGUseElement::expandUseElementsInShadowTree):

3:50 PM Changeset in webkit [85798] by ojan@chromium.org

4 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] put flaky tests into their own table
https://bugs.webkit.org/show_bug.cgi?id=60214

fast/harness/resources/results-test.js:
fast/harness/results-expected.txt:
fast/harness/results.html:

3:45 PM Changeset in webkit [85797] by koz@chromium.org

6 edits in trunk/Tools

2011-05-04 James Kozianski <koz@chromium.org>

Reviewed by Eric Seidel.

Add method to make a Port able to retrieve TestOutputSets from its builders.
https://bugs.webkit.org/show_bug.cgi?id=58211

This will be used in the new rebaseline script - TestOutputs are
potential new baselines.

Scripts/webkitpy/common/config/urls.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/factory.py:
Scripts/webkitpy/layout_tests/port/webkit.py:

3:44 PM Changeset in webkit [85796] by ojan@chromium.org

4 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] fix apply options on page load
https://bugs.webkit.org/show_bug.cgi?id=60217

This broke when we started storing options in localstorage.
Also fixes regressions exposed by fixing this.

fast/harness/resources/results-test.js:
fast/harness/results.html:

3:32 PM Changeset in webkit [85795] by Adam Roben

13 edits in trunk/Source/WebKit2

Clip and reposition windowed plugins when the UI process paints

This ensures that their geometry updates in sync with the rest of the page.

Most of this patch is just plumbing the scheduleWindowedPluginGeometryUpdate and
scheduleChildWindowGeometryUpdate calls through from NetscapePlugin all the way over to
WebView. I've tried to call out the other parts below.

Fixes <http://webkit.org/b/60210> <rdar://problem/8483441> REGRESSION (WebKit2): Windowed
plugins don't scroll at the same speed as the rest of the page

Reviewed by Darin Adler and Anders Carlsson.

UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::scheduleChildWindowGeometryUpdate):
Added plumbing.

UIProcess/win/WebView.cpp:

(WebKit::WebView::onPaintEvent): Update child windows before painting so that they will stay
in sync with the rest of the page.
(WebKit::WebView::scheduleChildWindowGeometryUpdate): Add this update information to the
set of geometries to update on the next paint.
(WebKit::setWindowRegion): Moved this helper function here from NetscapePluginWin.cpp.
(WebKit::WebView::updateChildWindowGeometries): Update the size, position, and clip rects of
all the child windows with scheduled geometry updates.

UIProcess/win/WebView.h: Added new members to track and update child window geometries.

WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformPostInitialize): Don't show the window immediately. Let the
UI process take care of it.
(WebKit::NetscapePlugin::platformGeometryDidChange): Don't update the window's position or
clip rect. Let the UI process take care of it.

WebProcess/Plugins/PluginController.h:
WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate):

WebProcess/Plugins/PluginView.h:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::scheduleChildWindowGeometryUpdate):
Added plumbing.

3:20 PM Changeset in webkit [85794] by andersca@apple.com

4 edits in trunk/Source/WebKit2

2011-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

WKView on Windows has no equivalent of Mac's -[WKView setDraws[Transparent]Background:]
https://bugs.webkit.org/show_bug.cgi?id=52009
<rdar://problem/8829746>

Add and implement WKViewSetDrawsTransparentBackground on windows.

UIProcess/API/C/win/WKView.cpp: (WKViewSetDrawsTransparentBackground): (WKViewDrawsTransparentBackground): Call through to the WebPageProxy object.

UIProcess/API/C/win/WKView.h:
UIProcess/win/WebView.cpp: (WebKit::drawPageBackground): Don't fill the rect with white if WebPageProxy::drawsBackground() or WebPageProxy::drawsTransparentBackground() returns false. Because of limitations in Win32, both drawsBackground and drawsTransparentBackground are pretty much equivalent.

(WebKit::WebView::paint):
Pass the WebPageProxy object to drawPageBackground.

3:08 PM Changeset in webkit [85793] by Martin Robinson

2 edits in trunk

2011-05-04 Martin Robinson <mrobinson@igalia.com>

Fix the WebKitGTK+ build.

configure.ac: Added option parsing code for loading touch icons.

3:02 PM Changeset in webkit [85792] by eric@webkit.org

2 edits in trunk/Tools

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Ojan Vafai.

sheriff-bot can't parse results.html
https://bugs.webkit.org/show_bug.cgi?id=60196

The problem was that the NRWT bots are currently core
and so sheriff-bot was trying to diagnose failures on
them. It was trying to parse their results.html file
and BeautifulSoup was throwing an exception.

It seems our version of BeautifulSoup was quite old
and unable to handle <script> tags correctly.
This moves us to 3.2 which doesn't seem to have this bug.

Scripts/webkitpy/thirdparty/BeautifulSoup.py:

2:52 PM Changeset in webkit [85791] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebCore

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed warning fix.

The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
a warning in Release build.

accessibility/AccessibilityRenderObject.cpp: (WebCore::lastChildConsideringContinuation):

2:46 PM Changeset in webkit [85790] by Dimitri Glazkov

2 edits in trunk/Source/WebCore

2011-05-04 Dimitri Glazkov <Dimitri Glazkov>

Sort xcodeproj files.

The WebCore.xcodeproj got out of sorts again.

WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.

2:42 PM Changeset in webkit [85789] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebCore

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Adam Barth.

Warning fix.

bindings/js/DOMObjectHashTableMap.h: (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):

2:32 PM Changeset in webkit [85788] by rwlbuis@webkit.org

3 edits
8 adds in trunk

2011-05-04 Rob Buis <rbuis@rim.com>

Reviewed by Darin Adler.

NULL deref when SVG elements have table styles
https://bugs.webkit.org/show_bug.cgi?id=45561

Restrict computed CSS values for SVG display property to block, inline or none.

Tests: svg/custom/display-table-caption-foreignObject.svg

svg/custom/display-table-caption-inherit-foreignObject.xhtml
svg/custom/display-table-caption-inherit-text.xhtml
svg/custom/display-table-caption-text.svg

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):

2:32 PM Changeset in webkit [85787] by Nate Chapin

3 edits in trunk/Source/WebKit/chromium

2011-05-04 Nate Chapin <Nate Chapin>

Reviewed by Mihai Parparita.

Ensure we don't overwrite user-specified scroll positions
on same document HistoryItem navigations.
https://bugs.webkit.org/show_bug.cgi?id=59877

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::currentHistoryItem): (WebKit::WebFrameImpl::WebFrameImpl):
src/WebFrameImpl.h:

2:12 PM Changeset in webkit [85786] by abarth@webkit.org

3 edits in trunk/Tools

2011-05-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make the EWS test logging less verbose
https://bugs.webkit.org/show_bug.cgi?id=60201

This should help us generate less than a hundred MB of logs per hour.

Scripts/webkitpy/common/config/ports.py:
Scripts/webkitpy/common/config/ports_unittest.py:

2:02 PM Changeset in webkit [85785] by commit-queue@webkit.org

55 edits
2 adds in trunk

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Configurations/FeatureDefines.xcconfig:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Parsed and populated apple-touch-icon url to FrameLoaderClient.
Changed favicon to be a type of icon.

CMakeLists.txt:
Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp: (WebCore::Document::iconURL): (WebCore::Document::setIconURL):
dom/Document.h:
dom/IconURL.cpp: Added. (WebCore::toIconIndex):
dom/IconURL.h: Added. (WebCore::IconURL::IconURL):
features.pri:
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute): (WebCore::HTMLLinkElement::isEnabledViaScript):
html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::iconURL): (WebCore::DocumentLoader::setIconURL):
loader/DocumentLoader.h:
loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::iconURLs): (WebCore::FrameLoader::fillIconURL): (WebCore::FrameLoader::getDefaultIconURL): (WebCore::FrameLoader::setIconURL): (WebCore::FrameLoader::didChangeIcons):
loader/FrameLoader.h:
loader/FrameLoaderClient.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respected the change of FrameLoaderClient.

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
src/FrameLoaderClientImpl.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient

WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):
WebCoreSupport/FrameLoaderClientEfl.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
WebCoreSupport/FrameLoaderClientGtk.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

Configurations/FeatureDefines.xcconfig:
WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidChangeIcons):

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
WebCoreSupport/FrameLoaderClientQt.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidChangeIcons):
WebCoreSupport/WebFrameLoaderClient.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::dispatchDidChangeIcons):
WebCoreSupport/FrameLoaderClientWinCE.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidChangeIcons):
WebKitSupport/FrameLoaderClientWx.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respected the change of FrameLoaderClient.
Added WebIconURL and WebIconType responding the new IconURL and IconType.
Supported to get the multiple icon urls.

Configurations/FeatureDefines.xcconfig:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidChangeIcons):
WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Disable touch icon by default.

Scripts/build-webkit:

1:40 PM Changeset in webkit [85784] by luiz@webkit.org

4 edits in trunk/LayoutTests

Unreviewed build fix.

Skipping test http/tests/navigation/response204.html for Mac, Win and GTK.

platform/gtk/Skipped:
platform/mac/Skipped:
platform/win/Skipped:

1:33 PM Changeset in webkit [85783] by andersca@apple.com

8 edits in trunk/Source/WebKit2

2011-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Can't save a link from "Save Linked File to Download" popup menu
https://bugs.webkit.org/show_bug.cgi?id=60190
<rdar://problem/9367927>

Make sure that suggestedFilenameForResourceWithURL and resourceDataForFrame both look
in the cache if the resource can't be found in the current web page. This matches WebKit1.

WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::suggestedFilenameForResourceWithURL): Call WebPage::cachedSuggestedFilenameForURL if we can't find a resource in the page.

WebProcess/WebPage/WebPage.cpp: (WebKit::resourceDataForFrame): Move code out from getResourceDataFromFrame.

(WebKit::WebPage::getResourceDataFromFrame):
Call resourceDataForFrame first and then cachedResponseDataForURL.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/gtk/WebPageGtk.cpp: (WebKit::WebPage::platformHasLocalDataForURL): (WebKit::WebPage::cachedResponseMIMETypeForURL): (WebKit::WebPage::platformCanHandleRequest): (WebKit::WebPage::cachedSuggestedFilenameForURL): (WebKit::WebPage::cachedResponseDataForURL): Add stubs.

WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::cachedResponseForURL): Add helper function.

(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::cachedResponseDataForURL):
Call helper function.

WebProcess/WebPage/qt/WebPageQt.cpp: (WebKit::WebPage::platformHasLocalDataForURL): (WebKit::WebPage::cachedResponseMIMETypeForURL): (WebKit::WebPage::platformCanHandleRequest): (WebKit::WebPage::cachedSuggestedFilenameForURL): (WebKit::WebPage::cachedResponseDataForURL): Add stubs.

WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::cachedResponseForURL): Add helper function.

(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseDataForURL):
Call helper function.

1:26 PM Changeset in webkit [85782] by imasaki@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Update bug numbers in media related test cases.
https://bugs.webkit.org/show_bug.cgi?id=60078

Reviewed by David Levin.

platform/chromium/test_expectations.txt:

1:17 PM Changeset in webkit [85781] by cmarrin@apple.com

2 edits in trunk/Source/WebCore

2011-05-04 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer
https://bugs.webkit.org/show_bug.cgi?id=60191

Skip replaceSublayer when there is no superlayer rather than asserting.
This is probably not a problem and happens when restructuring the layer
tree. Avoiding this crash will allow us to get more testing.

platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

1:08 PM Changeset in webkit [85780] by Simon Fraser

4 edits
2 adds in trunk

2011-05-04 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

WebKit2 flashes if entering and exiting compositing rapidly
https://bugs.webkit.org/show_bug.cgi?id=60198

If a page enters then immediately leaves compositing mode, the
DrawingAreaImpl would send a message to the UI process that it
had entered compositing even after all the layers had been torn
down. Fix this by never sending the 'enter' message if we're
waiting for the 'exit' timer to fire.

Also fix an assertion in the UI process caused by sending mismatched
'enter' and 'leave' messages by keeping track of which messages
we've sent.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::layerHostDidFlushLayers): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon):
WebProcess/WebPage/DrawingAreaImpl.h: (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModePending):

12:37 PM Changeset in webkit [85779] by jberlin@webkit.org

2 edits in trunk/LayoutTests

Windows DRT needs an implementation of shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=59081

Add another test for the shadow dom to the Windows Skipped list to get the bots green.

platform/win/Skipped:

12:26 PM Changeset in webkit [85778] by ojan@chromium.org

3 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] Don't show actual failure type column for ports that don't use expectations files
https://bugs.webkit.org/show_bug.cgi?id=60199

For the most part, the links shown tell you what type of failure it is.
The only case where we lose some information here is for a test that
failed one run, but passed or had a different failure on retry.i
We should probably put those tests in their own table anyways.

fast/harness/resources/results-test.js:
fast/harness/results.html:

12:20 PM Changeset in webkit [85777] by commit-queue@webkit.org

6 edits in trunk/Tools

2011-05-04 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Add gpu acceleration flags to DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=60168
Adding support for command line flags
enable-accelerated-2d-canvas an
enable-accelerated-drawing in DumpRenderTree.

DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings):
DumpRenderTree/chromium/TestShell.h: (TestShell::setLegacyAccelerated2dCanvasEnabled): (TestShell::setAcceleratedDrawingEnabled):
DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
DumpRenderTree/chromium/WebPreferences.h:

12:19 PM Changeset in webkit [85776] by Ademar Reis

2 edits in trunk/Tools

2011-05-04 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Csaba Osztrogonác.

[Qt] run-qtwebkit-tests misses exec bit
https://bugs.webkit.org/show_bug.cgi?id=60188

Also removing an unecessary import (mostly to let this bugfix goes
through the system, as this is just a chmod).

Scripts/run-qtwebkit-tests:

12:07 PM Changeset in webkit [85775] by caseq@chromium.org

2 edits in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Skipped inspector/elements/shadow-dom.html on win.
https://bugs.webkit.org/show_bug.cgi?id=60195

platform/win/Skipped:

12:04 PM Changeset in webkit [85774] by luiz@webkit.org

4 edits
4 adds in trunk

[Qt] Qt WebKit updates view on HTTP 204 response
https://bugs.webkit.org/show_bug.cgi?id=42529

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/qt:

Ignoring http responses which have status code equal to 204 (No Content)
or 205 (Reset Content).

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):

LayoutTests:

Responses which have status code equal to 204 should be ignored.

http/tests/navigation/response204-expected.txt: Added.
http/tests/navigation/response204.html: Added.
http/tests/navigation/resources/response204.pl: Added.

12:01 PM Changeset in webkit [85773] by Martin Robinson

5 edits in trunk/Source/WebCore

2011-05-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Fix the GTK+ 2.x build for Windows. Instead of making getStockIcon a RenderTheme
method, just use extern declarations to avoid having to declare it in the header.
This will prevent having to include glib.h in RenderThemeGtk.h, which is included
in many C++ files.

No new tests. This is just a build fix.

platform/gtk/RenderThemeGtk.cpp: Update getStockIcon calls to say getStockIconForWidgetType. (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::paintCapsLockIndicator): (WebCore::RenderThemeGtk::paintMediaButton):
platform/gtk/RenderThemeGtk.h: Removed getStockIcon declaration. Make gtkContainer() and gtkEntry() public because they are now accessed externally from getStockIcon().
platform/gtk/RenderThemeGtk2.cpp: Update getStockIcon calls. (WebCore::getStockIconForWidgetType):
platform/gtk/RenderThemeGtk3.cpp: Ditto. (WebCore::getStockIconForWidgetType):

12:00 PM Changeset in webkit [85772] by caio.oliveira@openbossa.org

2 edits in trunk/Source/WebKit/qt

2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Fix signals emitted in FakeReply used in autotests
https://bugs.webkit.org/show_bug.cgi?id=60049

The signals emitted for each case of FakeReply were swapped (error case
emitting metaDataChanged() and redirect case emitting error()). Emitting
readyRead() is not necessary.

tests/qwebframe/tst_qwebframe.cpp: (FakeReply::FakeReply): Choose the different continue function for each case of FakeReply. This removes the need of the if-statement in timeout() and let us replace timeout() with two simpler functions.

(FakeReply::continueRedirect):
(FakeReply::continueError):
Continuation cases, emitting the minimal set of signals needed for each case.

11:56 AM Changeset in webkit [85771] by ggaren@apple.com

3 edits
2 adds in trunk

<rdar://problem/9366557> Various crashes due to bad DFG codegen at canalplus.fr

Reviewed by Darin Adler.

Source/JavaScriptCore:

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes): Removed a stray line of
code that accidentally survived the conversion to a switch statement,
causing a lot of important code not to run most of the time.

Since this is not a trivial finger-picking mistake, I will not call it a
typo.

LayoutTests:

fast/js/trivial-functions-expected.txt: Added.
fast/js/trivial-functions.html: Added.

11:55 AM Changeset in webkit [85770] by commit-queue@webkit.org

4 edits
2 adds in trunk

2011-05-04 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB open (database) should fail if name is null
https://bugs.webkit.org/show_bug.cgi?id=60022

storage/indexeddb/mozilla/open-database-null-name-expected.txt: Added.
storage/indexeddb/mozilla/open-database-null-name.html: Added.

2011-05-04 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB open (database) should fail if name is null
https://bugs.webkit.org/show_bug.cgi?id=60022

Test: storage/indexeddb/mozilla/open-database-null-name.html

Combination problem: Bug in IDL didn't pass null values to .cpp layer,
then .cpp layer didn't check for null value anyway.

storage/IDBFactory.cpp: (WebCore::IDBFactory::open): check for null name
storage/IDBFactory.idl: pass null name as null

11:50 AM Changeset in webkit [85769] by ojan@chromium.org

2 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Improve styling on the toolbar. Make the background opaque.

fast/harness/results.html:

11:49 AM Changeset in webkit [85768] by abarth@webkit.org

2 edits in trunk/Tools

2011-05-04 Adam Barth <abarth@webkit.org>

Fix import of ircproxy module to actually import the module. I don't
really understand how this code could have worked before.

Scripts/webkitpy/common/host.py:

11:39 AM Changeset in webkit [85767] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

2011-05-04 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Entering full screen fails >= second time on Vimeo.com.
https://bugs.webkit.org/show_bug.cgi?id=60143

Force the RenderFullScreen's layer backing to be recreated when setAnimating() is called.
Previously, the RenderLayerCompositor would fail to reparent the RenderFullScreen's layer
at the end of an animation, if it determined that the RenderFullScreen would still require
a layer even when not animating.

rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating): Clear the renderer's layer.

11:24 AM Changeset in webkit [85766] by hclam@chromium.org

1 edit
2 adds in trunk/LayoutTests

2011-05-04 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Test expectations for Linux.

platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.

11:22 AM Changeset in webkit [85765] by ojan@chromium.org

4 edits in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Another shot at fixing flakiness under win (also renamed a couple of obsolete things).

inspector/elements/shadow-dom-expected.txt:
inspector/elements/shadow-dom.html:

11:03 AM Changeset in webkit [85764] by jeffm@apple.com

2 edits in trunk/Source/WebKit2

Fix typo in svn property in r85756.

Shared/mac/NativeWebWheelEventMac.mm: Added property svn:eol-style. Removed property snv:eol-style.

11:02 AM Changeset in webkit [85763] by commit-queue@webkit.org

2 edits in trunk/Tools

2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Andreas Kling.

[Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=60172

MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser (BrowserWindow::BrowserWindow):

11:00 AM Changeset in webkit [85762] by ddkilzer@apple.com

2 edits in trunk/Source/ThirdParty/ANGLE

Part 2 of 2: <http://webkit.org/b/56337> Enable -Werror on ANGLE

Reviewed by Adam Barth.

Configurations/Base.xcconfig:

(GCC_TREAT_WARNINGS_AS_ERRORS): Set to YES.

11:00 AM Changeset in webkit [85761] by ddkilzer@apple.com

5 edits in trunk/Source/ThirdParty/ANGLE

Part 1 of 2: <http://webkit.org/b/56337> Enable -Werror on ANGLE

Merge ANGLE upstream commits r572, r573, r574, r575.

This unblocks enabling -Werror on ANGLE. Since all changes are
in the upstream repository, they may be safely overwritten
during the next ANGLE update.

src/compiler/ConstantUnion.h:

(ConstantUnion::operator==): Added a default case.

src/compiler/Intermediate.cpp:

(TIntermBinary::promote): Added parentheses.

src/compiler/ParseHelper.cpp:

(TParseContext::precisionErrorCheck): Added a default case.

src/compiler/PoolAlloc.cpp:

(TAllocation::checkGuardBlock): Changed '%u' to '%lu' for size_t
variable. Put for loop inside #ifdef GUARD_BLOCKS/#endif macros
to fix tautological-compare warning.
(TAllocation::checkAllocList): Added newline to end of file.

10:50 AM Changeset in webkit [85760] by Simon Fraser

4 edits in trunk/Source/WebCore

2011-05-04 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Avoid allocating a new image buffer in ~CanvasRenderingContext2D()
https://bugs.webkit.org/show_bug.cgi?id=59849

When attempting to unwind the graphics state stack in the
CanvasRenderingContext2D destructor, don't allow HTMLCanvasElement
to create a new ImageBuffer.

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::existingDrawingContext):
html/HTMLCanvasElement.h:
html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):

10:47 AM Changeset in webkit [85759] by jcivelli@chromium.org

3 edits in trunk/Source/WebKit/chromium

2011-05-04 Jay Civelli <jcivelli@chromium.org>

Reviewed by Ojan Vafai.

Send the char events to the select popup if one is showing to fix
a bug were pressing a letter would not select the matching option.
https://bugs.webkit.org/show_bug.cgi?id=47769

src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::charEvent):
src/WebViewImpl.h:

10:46 AM Changeset in webkit [85758] by caseq@chromium.org

3 edits in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Another shot at fixing flakiness under win (also renamed a couple of obsolete things).

inspector/elements/shadow-dom-expected.txt:
inspector/elements/shadow-dom.html:

10:37 AM Changeset in webkit [85757] by ojan@chromium.org

4 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] bucket crashes/timeouts into their own test lists
https://bugs.webkit.org/show_bug.cgi?id=60181

Also, don't show the "expected to fail but passed" table for ports
that don't use an expectation file.

fast/harness/resources/results-test.js:
fast/harness/results.html:

10:29 AM Changeset in webkit [85756] by jeffm@apple.com

5 edits
5 adds in trunk/Source/WebKit2

2011-05-04 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Add NativeWebWheelEvent class
https://bugs.webkit.org/show_bug.cgi?id=60182

This will be needed soon when we start notifying the UI process that a mouse wheel event wasn't handled by WebKit.

GNUmakefile.am: Added NativeWebWheelEventGtk.cpp and NativeWebWheelEvent.h.
Shared/NativeWebWheelEvent.h: Added. (WebKit::NativeWebWheelEvent::nativeEvent): Added.
Shared/gtk/NativeWebWheelEventGtk.cpp: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
Shared/mac/NativeWebWheelEventMac.mm: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
Shared/qt/NativeWebWheelEventQt.cpp: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
Shared/win/NativeWebWheelEventWin.cpp: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent):Added.
WebKit2.pro: Added NativeWebWheelEventQt.cpp and NativeWebWheelEvent.h.
WebKit2.xcodeproj/project.pbxproj: Added NativeWebWheelEventMac.mm and NativeWebWheelEvent.h.
win/WebKit2.vcproj: Added NativeWebWheelEventWin.cpp and NativeWebWheelEvent.h.

9:59 AM Changeset in webkit [85755] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Anders Carlsson.

ArgumentDecoder should use aligned memory for its internal copy of data
https://bugs.webkit.org/show_bug.cgi?id=59960

Since we check for memory alignment when unpacking primitive types from the buffer,
insure alignment of the base address.
As uint64_t is the largest type we use in Argument encoder/decoder, use 8 byte alignment.

Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::ArgumentDecoder::~ArgumentDecoder): free m_alignedBase (CoreIPC::roundUpToAlignment): move this up in the source file (CoreIPC::ArgumentDecoder::initialize): m_buffer is now guaranteed sizeof(uint64_t) aligned
Platform/CoreIPC/ArgumentDecoder.h: add m_alignedBase member which needs to be freed in d'tor

9:58 AM Changeset in webkit [85754] by Adam Roben

6 edits
2 adds in trunk/Source/WebKit2

Make ShareableBitmap::makeCGImageCopy use a copy-on-write copy on Windows when possible

Fixes <http://webkit.org/b/57269> <rdar://problem/9198788> REGRESSION (r82151): Every WKView
paint now makes an extra copy of the painted bits

Reviewed by Anders Carlsson.

Platform/SharedMemory.h:
Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::createCopyOnWriteCopy):
Added this new function. Creates a copy-on-write copy of the first |size| bytes of the
original SharedMemory.

Shared/ShareableBitmap.h: Added createCGImage helper function.

Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::makeCGImageCopy): Don't compile this version of this function on
Windows; we'll provide our own implementation since CGBitmapContextCreateImage isn't smart
enough to make a copy-on-write copy on Windows.
(WebKit::ShareableBitmap::makeCGImage): Moved some code from here...
(WebKit::ShareableBitmap::createCGImage): ...to this new function.

Shared/cg/win/ShareableBitmapCGWin.cpp: Added.

(WebKit::derefSharedMemory): This function is called when the CGDataProvider is finalized.
All we have to do is deref the SharedMemory that was backing the CGDataProvider.
(WebKit::ShareableBitmap::makeCGImageCopy): Create a copy-on-write copy of the image data
when possible. We use the copy-on-write copy to back this ShareableBitmap from here on out,
and use the original SharedMemory to back the CGImage. This should prevent future
modifications to the ShareableBitmap from affecting the CGImage. If we can't make a
copy-on-write copy, we fall back to just copying the data normally.

win/WebKit2.vcproj: Added ShareableBitmapCGWin.cpp.

9:53 AM Changeset in webkit [85753] by Adam Roben

2 edits in trunk/Source/WebKit2

Let transparent windowless plugins draw into a graphics context with an alpha channel

Fixes <http://webkit.org/b/57647> <rdar://problem/9168462> Flash plugins with
wmode=transparent have black (instead of transparent) background in WebKit2 on Windows

I had trouble writing a test case for this, so I split that task out into
<http://webkit.org/b/60169>.

Reviewed by Sam Weinig.

WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformPaint): Give the graphics context an alpha channel if this
is a transparent windowless plugin.

9:28 AM Changeset in webkit [85752] by caseq@chromium.org

2 edits in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Attempt to resolve flakiness on windows.

inspector/elements/shadow-dom.html:

8:07 AM Changeset in webkit [85751] by caseq@chromium.org

12 edits
2 adds in trunk

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: expose shadow DOM in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=60160

Test: inspector/elements/shadow-dom.html

dom/Element.cpp: (WebCore::Element::ensureShadowRoot): (WebCore::Element::removeShadowRoot):
inspector/Inspector.json:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::isContainerNode):
inspector/InspectorDOMAgent.h:
inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype.inShadowTree): (WebInspector.DOMNode.prototype._setShadowRootPayload): (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype.querySelectorAll): (WebInspector.DOMAgent.prototype._shadowRootUpdated): (WebInspector.DOMDispatcher.prototype.searchResults): (WebInspector.DOMDispatcher.prototype.shadowRootUpdated):
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._nodeUpdated): (WebInspector.ElementsPanel.prototype._attributesUpdated): (WebInspector.ElementsPanel.prototype._nodeRemoved): (WebInspector.ElementsPanel.prototype.updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): ():
inspector/front-end/inspector.css: (#elements-content .dom-shadow-root): (.outline-disclosure li .webkit-html-tag.shadow):
inspector/front-end/utilities.js:

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: expose shadow DOM in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=60160

http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.nodeWithId.processChildren): (initialize_ElementTest.InspectorTest.nodeWithId.documentRequested): (initialize_ElementTest.InspectorTest.nodeWithId):
inspector/elements/shadow-dom-expected.txt: Added.
inspector/elements/shadow-dom.html: Added.

7:55 AM Changeset in webkit [85750] by caio.oliveira@openbossa.org

2 edits in trunk/Websites/bugs.webkit.org

2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Adam Roben.

REGRESSION (r85657): webkitpy.common.prettypatch_unittest.PrettyPatchTest.test_pretty_diff_encodings failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=60164

Use Array#length to get the number of elements in an array. Array#count
was added in Ruby 1.8.7, but Leopard have Ruby 1.8.6.

PrettyPatch/PrettyPatch.rb:

7:31 AM Changeset in webkit [85749] by Adam Roben

3 edits in trunk/Source/JavaScriptCore

Another attempted build fix

wtf/OwnPtr.h:

(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):

wtf/PassOwnPtr.h:

(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Added a return statement. And made a tweak based on a suggestion from Anders Carlsson.

7:25 AM Changeset in webkit [85748] by Adam Roben

3 edits in trunk/Source/JavaScriptCore

Try to fix Leopard, Qt, and probably others

wtf/OwnPtr.h:

(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):

wtf/PassOwnPtr.h:

(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Try to get the compiler not to instantiate these function templates unnecessarily.

7:25 AM Changeset in webkit [85747] by Ademar Reis

1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed: Adding myself to the committers' list.

7:11 AM Changeset in webkit [85746] by Adam Roben

8 edits in trunk/Source

Disallow equality comparisons between [Pass]OwnPtrs

If you have two OwnPtrs that are equal, you've already lost. (Unless you're doing something
really sneaky, in which case you should stop!)

Fixes <http://webkit.org/b/60053> Testing OwnPtrs for equality should cause a compiler error

Reviewed by Anders Carlsson and Antti Koivisto.

Source/JavaScriptCore:

wtf/OwnPtr.h:

(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):

wtf/PassOwnPtr.h:

(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Added private equality operators that fail to compile when used. (When not used, the
compiler will skip over them because they are function templates.)

Source/WebCore:

Remove an unnecessary OwnPtr equality check in XSLT code

dom/Document.cpp:

(WebCore::Document::setTransformSource): No need to check for equality. If the pointers are
equal, we're screwed anyway. (And the caller always passes in a newly-allocated object, so
we're safe.)

Source/WebKit2:

Remove WebPageProxy::setDrawingArea

It is unused. It also does a useless equality comparison between OwnPtrs; if they are equal,
we've already lost.

UIProcess/WebPageProxy.cpp:
UIProcess/WebPageProxy.h:

Removed setDrawingArea.

(WebKit::WebPageProxy::drawingArea):
(WebKit::WebPageProxy::backForwardList):
Made these functions const while I was at it.

6:57 AM Changeset in webkit [85745] by commit-queue@webkit.org

11 edits
5 adds in trunk/Source/WebCore

2011-05-04 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add the skeleton of the frame and page controllers and the embedder client.
https://bugs.webkit.org/show_bug.cgi?id=56922

Add the basic outlines of the page controller, the per-frame controller and the embedder
client interface for the Media Stream API. Provide methods to handle the situations
where a frame is detached from the page or transferred between pages.

Tests for the Media Stream API will be provided by the bug 56587.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument):
page/Frame.h: (WebCore::Frame::mediaStreamFrameController):
page/MediaStreamClient.h: Added. (WebCore::MediaStreamClient::~MediaStreamClient):
page/MediaStreamController.cpp: Added. (WebCore::MediaStreamController::Request::Request): (WebCore::MediaStreamController::Request::localId): (WebCore::MediaStreamController::Request::frameController): (WebCore::MediaStreamController::MediaStreamController): (WebCore::MediaStreamController::~MediaStreamController): (WebCore::MediaStreamController::unregisterFrameController): (WebCore::MediaStreamController::registerRequest):
page/MediaStreamController.h: Added.
page/MediaStreamFrameController.cpp: Added. (WebCore::MediaStreamFrameController::Request::Request): (WebCore::MediaStreamFrameController::Request::~Request): (WebCore::MediaStreamFrameController::Request::scriptExecutionContext): (WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest): (WebCore::MediaStreamFrameController::Request::isRecordedDataRequest): (WebCore::MediaStreamFrameController::RequestMap::abort): (WebCore::MediaStreamFrameController::RequestMap::abortAll): (WebCore::MediaStreamFrameController::MediaStreamFrameController): (WebCore::MediaStreamFrameController::~MediaStreamFrameController): (WebCore::MediaStreamFrameController::securityOrigin): (WebCore::MediaStreamFrameController::scriptExecutionContext): (WebCore::MediaStreamFrameController::pageController): (WebCore::MediaStreamFrameController::enterDetachedState): (WebCore::MediaStreamFrameController::disconnectPage): (WebCore::MediaStreamFrameController::disconnectFrame): (WebCore::MediaStreamFrameController::transferToNewPage):
page/MediaStreamFrameController.h: Added.
page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::PageClients::PageClients):
page/Page.h: (WebCore::Page::mediaStreamController):

6:48 AM Changeset in webkit [85744] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

2011-05-04 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Double-click in a read-only style rule results in a non-editable blank property
https://bugs.webkit.org/show_bug.cgi?id=60150

inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):

6:46 AM Changeset in webkit [85743] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912

platform/qt/Skipped: Unskip http/tests/websocket/tests.

6:36 AM Changeset in webkit [85742] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-05-04 Dominic Battre <battre@chromium.org>

Reviewed by Tony Gentilcore.

Fix missing header in case SVG is disabled
https://bugs.webkit.org/show_bug.cgi?id=60153

dom/EventDispatcher.cpp:

6:26 AM WebKit Team edited by Ademar Reis

(diff)

6:25 AM Changeset in webkit [85741] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebKit/efl

2011-05-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Initialize viewport argument in ewk_view.cpp
https://bugs.webkit.org/show_bug.cgi?id=60147

viewport computation logic can't be worked correctly because viewport argument
isn't initialized. So, we need to initialize viewport argument.

ewk/ewk_view.cpp: (_ewk_view_priv_new):

6:18 AM Changeset in webkit [85740] by Philippe Normand

2 edits in trunk/LayoutTests

2011-05-04 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip fast/dom/Geolocation/argument-types.html crashing
on GTK.

[GTK] fast/dom/Geolocation/argument-types.html flaky crash on 32-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=60158

platform/gtk/Skipped:

6:14 AM Changeset in webkit [85739] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

2011-05-04 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: readyState
https://bugs.webkit.org/show_bug.cgi?id=60069

Checks the value of the request.readyState property during and
after opening a database, setting the version, creating a datastore,
adding a record, and retrieving a record.

storage/indexeddb/mozilla/readyState-expected.txt: Added.
storage/indexeddb/mozilla/readyState.html: Added.

6:06 AM Changeset in webkit [85738] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

2011-05-04 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Rename CSSStyleApplyProperty::propertyValue and setPropertyValue.
https://bugs.webkit.org/show_bug.cgi?id=60006

No new tests as no functionality added. Simple rename only.

css/CSSStyleApplyProperty.cpp: Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
css/CSSStyleApplyProperty.h: Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.

6:03 AM Changeset in webkit [85737] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

2011-05-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Cleanup conditionals in findNextLineBreak
https://bugs.webkit.org/show_bug.cgi?id=60117

Simplified conditional statements in findNextLineBreak.

rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):

5:44 AM Changeset in webkit [85736] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-05-04 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSStyleSelector::applyProperty() CSSPropertyWebkitHyphens case use appropriate macro.
https://bugs.webkit.org/show_bug.cgi?id=60114

No new tests as no functionality changes.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to remove code duplication.

5:39 AM Changeset in webkit [85735] by mihaip@chromium.org

11 edits in trunk/Tools

2011-05-04 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

[NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
https://bugs.webkit.org/show_bug.cgi?id=60088

Makes --new-baseline put new baselines into the first entry in the
baseline search path, including any additional directories passed in via
--additional-platform-directory.

Simplifies baseline_path() by making it return the first entry in the
baseline search path instead of requiring each port to have an
implementation (should not result in any behavior change).

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/base_unittest.py:
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
Scripts/webkitpy/layout_tests/port/chromium_linux.py:
Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/port/webkit.py:

5:24 AM Changeset in webkit [85734] by caio.oliveira@openbossa.org

4 edits in trunk/Source/WebCore

2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix QNetworkReplyWrapper to not depend on QNetworkReply::isFinished() method
https://bugs.webkit.org/show_bug.cgi?id=59070

Applications using our API and our autotests subclass QNetworkReply as part of providing a
custom QNetworkAccessManager. But there's an API limitation in Qt 4.7, that makes
QNetworkReply::isFinished() always be false for these custom replies. This was fixed in Qt
4.8, see http://bugreports.qt.nokia.com/browse/QTBUG-11737.

The consequence is that QtWebKit cannot rely on this function. So now QNetworkReplyWrapper
watches for the finished() signal and set a dynamic property "_q_isFinished" on the reply
indicating that it is finished. When there's no finished signal (synchronous) we set the
dynamic property once we get the reply.

This fixes tst_QWebFrame::requestedUrl(), that was breaking because sniffer was not
emitting its own finished() signal, causing QWebFrame::loadFinished() to not be emitted.

platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper): Connect the finished signal to the new setFinished() slot.

(WebCore::QNetworkReplyWrapper::synchronousLoad):
Since we don't get the finished signal for synchronous loads, set the dynamic property
before processing it.

(WebCore::QNetworkReplyWrapper::resetConnections):
Do not reset the connection to setFinished().

(WebCore::QNetworkReplyWrapper::setFinished):
Set the dynamic property in the reply.

(WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
(WebCore::QNetworkReplyHandler::start):
Change to use wrapper's isFinished() instead of asking the reply directly.

platform/network/qt/QNetworkReplyHandler.h: (WebCore::QNetworkReplyWrapper::isFinished): Checks the dynamic property of the reply.

platform/network/qt/QtMIMETypeSniffer.cpp: (QtMIMETypeSniffer::sniff): Use the dynamic property to check if the reply is finished.

4:58 AM Changeset in webkit [85733] by Philippe Normand

2 edits in trunk/LayoutTests

2011-05-04 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline after r85669.

platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:

4:51 AM Changeset in webkit [85732] by eric@webkit.org

3 edits in trunk/Source/WebCore

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
https://bugs.webkit.org/show_bug.cgi?id=60080

No functional change, just moving code.

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::createLineBoxesFromBidiRuns): (WebCore::RenderBlock::layoutRunsAndFloats):

4:42 AM Changeset in webkit [85731] by andreas.kling@nokia.com

2 edits in trunk/Source/WebCore

2011-05-04 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove unused function FontPlatformData::pixelSize()
https://bugs.webkit.org/show_bug.cgi?id=60156

platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::pixelSize): Removed.

4:35 AM Changeset in webkit [85730] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-05-04 Luke Macpherson <macpherson@chromium.org>

Reviewed by Darin Adler.

Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=60011

No new tests added as no functionality changed.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove reundant check for auto table layout.

4:34 AM Changeset in webkit [85729] by alexis.menard@openbossa.org

2 edits in trunk/Source/JavaScriptCore

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Gavin Barraclough.

JITArithmetic.cpp produces a warning on a unused variable.
https://bugs.webkit.org/show_bug.cgi?id=60060

Just properly use what we already have converted.

jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlow_op_mul):

4:08 AM Changeset in webkit [85728] by mihaip@chromium.org

3 edits in trunk/Source/WebCore

2011-05-04 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Adler.

Remove double-free checks for bug 56124
https://bugs.webkit.org/show_bug.cgi?id=60037

Antti's speculative fix for bug 56124 (r84151) appears to have worked,
these CRASH() calls are not triggering anymore.

css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::~CSSSelector):
css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::deleteSelectors):

3:44 AM Changeset in webkit [85727] by abarth@webkit.org

12 edits in trunk/Tools

2011-05-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix circular dependency in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=60075

These functions don't belong in bugzilla.py. They only exist there
because they are old. Really, these functions shouldn't be free
functions at all, but that's a patch for another day.

Scripts/webkitpy/common/checkout/changelog.py:
Scripts/webkitpy/common/checkout/changelog_unittest.py:
Scripts/webkitpy/common/checkout/checkout.py:
Scripts/webkitpy/common/config/urls.py:
Scripts/webkitpy/common/net/bugzilla/init.py:
Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
Scripts/webkitpy/style/checkers/changelog.py:
Scripts/webkitpy/tool/bot/irc_command.py:
Scripts/webkitpy/tool/bot/sheriff.py:
Scripts/webkitpy/tool/commands/upload.py:

2:41 AM Changeset in webkit [85726] by satish@chromium.org

6 edits in trunk

2011-05-04 Satish Sampath <satish@chromium.org>

Reviewed by Tony Gentilcore.

Layout the speech input button to the left of outer spin button properly.
https://bugs.webkit.org/show_bug.cgi?id=59742

platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
platform/chromium/test_expectations.txt:

2011-05-04 Satish Sampath <satish@chromium.org>

Reviewed by Tony Gentilcore.

Layout the speech input button to the left of outer spin button properly.
https://bugs.webkit.org/show_bug.cgi?id=59742

rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout):

1:33 AM Changeset in webkit [85725] by alexis.menard@openbossa.org

4 edits in trunk/Source/JavaScriptCore

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Geoffrey Garen.

JITPropertyAccess produces a unused but set variable warning in gcc 4.6.0.
https://bugs.webkit.org/show_bug.cgi?id=60050

This patch fix a compilation warning. The new warning scenario -Wunused-but-set-variable
in gcc 4.6.0 is included in -Wall and therefore stops the compilation when warnings are treated
as errors. The patch introduces a new macro ASSERT_JIT_OFFSET_UNUSED and ASSERT_WITH_MESSAGE_UNUSED
which copy the idea of ASSERT_UNUSED.

jit/JIT.h:
jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id):
wtf/Assertions.h: (assertWithMessageUnused):

12:03 AM Changeset in webkit [85724] by yurys@chromium.org

2 edits in trunk/Source/WebCore

2011-05-04 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Build fix.

bindings/js/JSInjectedScriptHostCustom.cpp: fix includes declaration

12:00 AM Changeset in webkit [85723] by psolanki@apple.com

2 edits in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=60141 Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit

Reviewed by Dan Bernstein.

Scripts/build-webkit:

May 3, 2011:

11:45 PM Changeset in webkit [85722] by yurys@chromium.org

6 edits
2 adds in trunk

2011-05-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: can't inspect element in an iframe when element originates from non-frame document
https://bugs.webkit.org/show_bug.cgi?id=60031

inspector/elements/elements-inspect-iframe-from-different-domain-expected.txt: Added.
inspector/elements/elements-inspect-iframe-from-different-domain.html: Added.

2011-05-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: can't inspect element in an iframe when element originates from non-frame document
https://bugs.webkit.org/show_bug.cgi?id=60031

Inspected object type evaluation has moved into native bindings. This way it doesn't
depend on the current JS context.

Test: inspector/elements/elements-inspect-iframe-from-different-domain.html

bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::isHTMLAllCollection): this method helps distinguish real undefined values from HTMLAllCollection (WebCore::JSInjectedScriptHost::type): method that returns presice type of the passed value
bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback): (WebCore::V8InjectedScriptHost::typeCallback):
inspector/InjectedScriptHost.idl:
inspector/InjectedScriptSource.js: (.):

11:36 PM Changeset in webkit [85721] by psolanki@apple.com

8 edits in trunk/Source

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Reviewed by Antti Koivisto.

Source/WebCore:

Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one. Clean
up some warnings and #if USE(CFNETWORK) around code.

platform/mac/CookieJar.mm:
platform/network/CookieStorage.h:
platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::privateBrowsingCookieStorage):
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
(WebCore::notifyCookiesChangedOnMainThread):
(WebCore::notifyCookiesChanged):

platform/network/cf/CookieStorageCFNet.h:
platform/network/mac/CookieStorageMac.mm:

Source/WebKit2:

Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one.

WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):

11:25 PM Changeset in webkit [85720] by commit-queue@webkit.org

9 edits in trunk/Source

2011-05-03 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Make accelerated 2d canvas enabled by default with skia
https://bugs.webkit.org/show_bug.cgi?id=59929

No new tests. Covered by existing layout tests

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Initialized for accelerated canvas if either the accelerated2dCanvas or the legacyAccelerated2dCanvas flags are enabled
page/Page.cpp: (WebCore::Page::sharedGraphicsContext3D): This is where the code goes to implement the functionality for the legacy vs current acceleration paths for the 2D canvas. Currently, this is a no-op, and always select the legacy path. This is temporary until we are ready to sort the GPU layout tests (rebasline vs. bug)
page/Settings.cpp: Added new flage for legacyAccelerated2dCanvas (WebCore::Settings::Settings): (WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
page/Settings.h: (WebCore::Settings::legacyAccelerated2dCanvasEnabled):

2011-05-03 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Make accelerated 2d canvas enabled by default with skia
https://bugs.webkit.org/show_bug.cgi?id=59929
Added new flag for enabling the legacy accelerated 2d canvas
The flag is not yet functional with this change.

public/WebSettings.h:
src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setLegacyAccelerated2dCanvasEnabled):
src/WebSettingsImpl.h:

11:21 PM Changeset in webkit [85719] by jer.noble@apple.com

7 edits in trunk

2011-04-29 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Seidel.

Implement FULLSCREEN_API on Windows, Part 4: Enable it
https://bugs.webkit.org/show_bug.cgi?id=59798

wtf/Platform.h: Set ENABLE_FULLSCREEN_API on win.

2011-04-29 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Seidel.

Implement FULLSCREEN_API on Windows, Part 4: Enable it
https://bugs.webkit.org/show_bug.cgi?id=59798

WebCore.vcproj/WebCore.vcproj: Add missing full screen related

files to the project.

2011-04-29 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Seidel.

Implement FULLSCREEN_API on Windows, Part 4: Enable it
https://bugs.webkit.org/show_bug.cgi?id=59798

win/tools/vsprops/FeatureDefines.vsprops: Set ENABLE_FULLSCREEN_API to true.

11:08 PM Changeset in webkit [85718] by alexis.menard@openbossa.org

2 edits in trunk/Source/JavaScriptCore

2011-05-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Eric Seidel.

Unused but set variable warning in MacroAssemberX86_64
https://bugs.webkit.org/show_bug.cgi?id=59482

assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::call): (JSC::MacroAssemblerX86_64::tailRecursiveCall): (JSC::MacroAssemblerX86_64::makeTailRecursiveCall):

10:46 PM Changeset in webkit [85717] by hclam@chromium.org

6 edits in trunk/Source/WebKit/chromium

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

More 0 to nullptr.

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::pluginLoadObserver):
src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::~GraphicsContext3D):
src/WebAudioBus.cpp: (WebKit::WebAudioBus::release):
src/WebBlobData.cpp: (WebKit::WebBlobData::reset):
src/WebViewImpl.cpp: (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet):

10:30 PM Changeset in webkit [85716] by hclam@chromium.org

11 edits in trunk/Source/WebCore

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

More places from 0 to nullptr.

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::precompileScript):
platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create):
platform/graphics/gpu/BicubicShader.cpp: (WebCore::BicubicShader::create):
platform/graphics/gpu/ConvolutionShader.cpp: (WebCore::ConvolutionShader::create):
platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: (WebCore::LoopBlinnSolidFillShader::create):
platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::create):
platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia):
platform/leveldb/LevelDBDatabase.cpp: (WebCore::LevelDBDatabase::createIterator):
platform/text/LocalizedNumberICU.cpp: (WebCore::createFormatterForCurrentLocale):

10:07 PM Changeset in webkit [85715] by mitz@apple.com

2 edits in trunk/LayoutTests

Updated expected results after updating this test in r85676.

platform/mac/fast/text/ligature-subdivision-expected.txt:

9:59 PM Changeset in webkit [85714] by hclam@chromium.org

2 edits in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Quick suppresion for layout test failures.

platform/chromium/test_expectations.txt:

9:52 PM Changeset in webkit [85713] by hclam@chromium.org

2 edits in trunk/Source/WebCore

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Using nullptr instead of 0. This makes visual studio happy.

storage/IDBTransactionBackendInterface.h:

8:54 PM Changeset in webkit [85712] by dpranke@chromium.org

3 edits
5 adds
1 delete in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations triage and new baselines.

platform/chromium-linux/fast/borders/bidi-012-expected.png: Added.
platform/chromium-mac-leopard/fast/borders/bidi-012-expected.png: Added.
platform/chromium-mac-leopard/fast/multicol/client-rects-expected.png: Added.
platform/chromium-mac/fast/repaint/box-shadow-h-expected.png: Removed.
platform/chromium-win/fast/borders/bidi-012-expected.png: Added.
platform/chromium-win/fast/borders/bidi-012-expected.txt: Added.
platform/chromium/test_expectations.txt:
platform/mac/fast/block/float/float-overhangs-root-expected.png:

8:36 PM Changeset in webkit [85711] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-05-03 Luke Macpherson <macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Add template parameter to ApplyPropertyColor to improve clarity by removing constructor parameter side effects.
https://bugs.webkit.org/show_bug.cgi?id=59774

No new tests required as on new functionality.

css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyColor::applyValue): Added template parameter "inheritColorFromParent = false". (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Use template parameter where appropriate.

8:15 PM Changeset in webkit [85710] by demarchi@webkit.org

2 edits in trunk

2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Xan Lopez.

[CMAKE] Remove C++0x compat mode warnings for GCC >= 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=60041

Hardcode -Wno-c++0x-compat for the default compiler (if version >=
4.6.0) until our codebase is ready. This is the same as done for
autotools.

Source/cmake/WebKitHelpers.cmake: ditto.

8:13 PM Changeset in webkit [85709] by dpranke@chromium.org

11 edits
1 add
2 deletes in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations triage and new baselines.

platform/chromium-linux/fast/box-shadow/inset-expected.png:
platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
platform/chromium-linux/fast/forms/basic-selects-expected.png:
platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium-mac-leopard/fast/box-shadow/inset-expected.png: Added.
platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
platform/chromium-mac/fast/box-shadow/inset-expected.png: Removed.
platform/chromium-mac/fast/forms/basic-selects-expected.png: Removed.
platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium-win/fast/box-shadow/inset-expected.png:
platform/chromium-win/fast/forms/basic-selects-expected.png:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium/test_expectations.txt:

8:07 PM Changeset in webkit [85708] by demarchi@webkit.org

2 edits in trunk

2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed, rolling out r85624.
http://trac.webkit.org/changeset/85624

The same command is used also for make_names.pl, which breaks
the build.

Source/cmake/OptionsCommon.cmake: ditto.

7:48 PM Changeset in webkit [85707] by dpranke@chromium.org

6 edits
2 adds in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change and new baselines.

platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png: Added.
platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png: Added.
platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
platform/chromium/test_expectations.txt:

7:34 PM Changeset in webkit [85706] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations triage.

platform/chromium/test_expectations.txt:

7:20 PM Changeset in webkit [85705] by mitz@apple.com

4 edits in trunk/Source/WebCore

<rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.

Reviewed by Darin Adler.

Added a pointer from FloatingObject to its originating line, if there is one, and made sure to
dirty the line when the float is removed, instead of relying on the float always intersecting
its originating line.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::clearFloats):

rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::appendFloatingObjectToLastLine):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::determineStartPosition):

7:14 PM Changeset in webkit [85704] by dpranke@chromium.org

2 edits
1 delete in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations triage.

platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Removed.
platform/chromium/test_expectations.txt:

7:08 PM Changeset in webkit [85703] by jam@chromium.org

8 edits in trunk/Source/WebKit/chromium

2011-05-03 John Abd-El-Malek <jam@chromium.org>

Reviewed by James Robinson.

[chromium] Go through WebPermissionClient for local storage access. Also cleanup left over code from previous WebPermissionClient change.
https://bugs.webkit.org/show_bug.cgi?id=60066

public/WebFrameClient.h:
public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowLocalStorage):
src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowScriptExtension): (WebKit::FrameLoaderClientImpl::allowJavaScript): (WebKit::FrameLoaderClientImpl::allowPlugins): (WebKit::FrameLoaderClientImpl::allowImages): (WebKit::FrameLoaderClientImpl::didNotAllowScript): (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::setItem):

6:59 PM Changeset in webkit [85702] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations triage.

platform/chromium/test_expectations.txt:

6:36 PM Changeset in webkit [85701] by dpranke@chromium.org

2 edits
4 deletes in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, remove obsolete baselines.

platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
platform/chromium/test_expectations.txt:

6:32 PM Changeset in webkit [85700] by oliver@apple.com

5 edits in trunk/Source/JavaScriptCore

2011-05-03 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make malloc validation useful
https://bugs.webkit.org/show_bug.cgi?id=57502

Reland this patch (rolled out in 82905) without
turning it on by default.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
wtf/FastMalloc.cpp: (WTF::tryFastMalloc): (WTF::fastMalloc): (WTF::tryFastCalloc): (WTF::fastCalloc): (WTF::fastFree): (WTF::tryFastRealloc): (WTF::fastRealloc): (WTF::fastMallocSize): (WTF::TCMalloc_PageHeap::isScavengerSuspended): (WTF::TCMalloc_PageHeap::scheduleScavenger): (WTF::TCMalloc_PageHeap::suspendScavenger): (WTF::TCMalloc_PageHeap::signalScavenger): (WTF::TCMallocStats::malloc): (WTF::TCMallocStats::free): (WTF::TCMallocStats::fastCalloc): (WTF::TCMallocStats::tryFastCalloc): (WTF::TCMallocStats::calloc): (WTF::TCMallocStats::fastRealloc): (WTF::TCMallocStats::tryFastRealloc): (WTF::TCMallocStats::realloc): (WTF::TCMallocStats::fastMallocSize):
wtf/FastMalloc.h: (WTF::Internal::fastMallocValidationHeader): (WTF::Internal::fastMallocValidationSuffix): (WTF::Internal::fastMallocMatchValidationType): (WTF::Internal::setFastMallocMatchValidationType): (WTF::fastMallocMatchValidateFree): (WTF::fastMallocValidate):

6:28 PM Changeset in webkit [85699] by jer.noble@apple.com

15 edits
1 copy
1 move
1 add
1 delete in trunk/Source

2011-05-02 Jer Noble <jer.noble@apple.com>

Reviewed by Adam Roben.

Implement FULLSCREEN_API on Windows, Part 3: WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59845

Move WebFullScreenController into WebCore to facilitate code sharing between WebKit
and WebKit2. WebFullScreenController now uses a Client class to request work on its
behalf by WebKit and WebKit2. MediaPlayerPrivateFullscreenWindow now only creates a
CALayerHost once a root layer is set, as the CALayerHost was causing child window drawing
problems, and because a CALayerHost is overkill if the window is only drawing black to
its client area.

WebCore.vcproj/WebCore.vcproj:
platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow): Do not create

m_layerHost in the constructor.

(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): NULL check m_layerHost.
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Lazily instantiate m_layerHost.
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): NULL check m_layerHost; if a root layer is

not present, fill the window with black in WM_PAINT.

platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
platform/graphics/win/FullScreenController.cpp: Renamed from Source/WebKit/win/WebFullScreenController.cpp.
platform/graphics/win/FullScreenController.h: Renamed from Source/WebKit/win/WebFullScreenController.h.
platform/graphics/win/FullScreenControllerClient.h: Split out from FullScreenController.h (WebCore::FullScreenControllerClient::~FullScreenControllerClient):

2011-05-02 Jer Noble <jer.noble@apple.com>

Reviewed by Adam Roben.

Implement FULLSCREEN_API on Windows, Part 3: WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59845

Implementation of WebFullScreenController has been moved into WebCore, and
required virutal functions of WebFullScreenControllerClient have been added to
WebView. These functions are mostly simple accessors of existing ivars, but
m_fullScreenElement and its accessors have also been added to WebView.

WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::enterFullScreenForElement):
WebFullScreenController.cpp: Removed.
WebKit.vcproj/WebKit.vcproj:
WebView.cpp: (WebView::setFullScreenElement): Added accessor. (WebVIew::fullScreenElement): Ditto. (WebView::fullScreenClientWindow): Ditto. (WebView::fullScreenClientParentWindow): Ditto. (WebView::fullScreenClientSetParentWindow): Ditto. (WebView::fullScreenClientWillEnterFullScreen): Pass through to Document. (WebView::fullScreenClientDidEnterFullScreen): Ditto. (WebView::fullScreenClientWillExitFullScreen): Ditto. (WebView::fullScreenClientDidExitFullScreen): Ditto.
WebView.h:

2011-05-02 Jer Noble <jer.noble@apple.com>

Reviewed by Adam Roben.

Implement FULLSCREEN_API on Windows, Part 3: WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59845

Implement a similar full screen mode to WebKit; Re-use the same
full screen window class used in WebKit in the new WebFullScreenController.
No animations (yet), so many of the stubs remain unimplemented.

UIProcess/win/WebView.cpp: (WebKit::WebView::onKeyEvent): Handle VK_ESCAPE and cancel full screen

mode if caught.

(WebKit::WebView::fullScreenController): Lazily instantiate m_fullScreenController.
(WebKit::WebView::fullScreenClientWindow): Added accessor.
(WebKit::WebView::fullScreenClientParentWindow): Ditto.
(WebKit::WebView::fullScreenClientSetParentWindow): Ditto.
(WebKit::WebView::fullScreenClientWillEnterFullScreen): Pass through to WebFullScreenManagerProxy.
(WebKit::WebView::fullScreenClientDidEnterFullScreen): Ditto.
(WebKit::WebView::fullScreenClientWillExitFullScreen): Ditto.
(WebKit::WebView::fullScreenClientDidExitFullScreen): Ditto.

UIProcess/win/WebView.h:
UIProcess/win/WebFullScreenManagerProxyWin.cpp: (WebKit::WebFullScreenManagerProxy::enterFullScreen): Pass through to

WebFullScreenController.

(WebKit::WebFullScreenManagerProxy::exitFullScreen): Ditto.

UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::onKeyEvent): Handle the escape key and exit

full screen mode when detected.

(WebKit::WebView::fullScreenWindowController): Added.

UIProcess/win/WebView.h:
WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp: (WebKit::WebFullScreenManagerWin::~WebFullScreenManagerWin): (WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Host the root

full screen layer if it gets detached.

WebProcess/FullScreen/win/WebFullScreenManagerWin.h:
win/WebKit2.vcproj:

6:14 PM Changeset in webkit [85698] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations triaging.

platform/chromium/test_expectations.txt:

5:38 PM Changeset in webkit [85697] by beidson@apple.com

7 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
WK2 Icon Database should provide access to all image representations in the icon.

Reviewed by Sam Weinig.

../WebCore:

Add an accessor for CG platforms to get a CFArrayRef of all the CGImageRefs represented:

platform/graphics/BitmapImage.h:
platform/graphics/Image.h:

(WebCore::Image::getCGImageArray):

platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::getCGImageArray):

../WebKit2:

Expose a CFArrayRef of CGImageRefs as API for CG platforms:

UIProcess/API/C/cg/WKIconDatabaseCG.cpp:

(WKIconDatabaseTryCopyCGImageArrayForURL):

UIProcess/API/C/cg/WKIconDatabaseCG.h:

5:38 PM Changeset in webkit [85696] by Lucas Forschler

5 edits in trunk/Source

Versioning.

5:38 PM Changeset in webkit [85695] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

2011-05-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

findNextLineBreak splits InlineIterator into 3 pieces
https://bugs.webkit.org/show_bug.cgi?id=60082

Avoid splitting InlineIterator into 3 variables with inter-dependencies.

rendering/InlineIterator.h: (WebCore::InlineIterator::fastIncrementInTextNode): Added. (WebCore::InlineIterator::previousInSameNode): Added.
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):

5:36 PM Changeset in webkit [85694] by Lucas Forschler

1 copy in tags/Safari-534.33

New tag.

5:31 PM Changeset in webkit [85693] by dino@apple.com

3 edits
3 adds in trunk

2011-05-03 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

Interrupted transitions are not correctly removed
https://bugs.webkit.org/show_bug.cgi?id=60062

CompositeAnimation was replacing any existing
transition as a new one was created. However, it wasn't
clearing the lists in AnimationControllerPrivate that
signal when a hardware animation starts. Rather than
simple removing the existing transition, we now tell
AnimationControllerPrivate that is has gone.

Test: transitions/3d/interrupted-transition.html

page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):

2011-05-03 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

Interrupted transitions are not correctly removed
https://bugs.webkit.org/show_bug.cgi?id=60062

transitions/3d/interrupted-transition-expected.txt: Added.
transitions/3d/interrupted-transition.html: Added.

5:23 PM Changeset in webkit [85692] by mihaip@chromium.org

2 edits in trunk/Tools

2011-05-03 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

Update rebaseline queue server to handle hierarchical test results
https://bugs.webkit.org/show_bug.cgi?id=60063

Update test result parsing done by the rebaseline queue server to handle
the hierarchical test result output that is generated as of r85254.

RebaselineQueueServer/templates/builder-queue-edit.html:

4:59 PM Changeset in webkit [85691] by bweinstein@apple.com

3 edits in trunk/Source/WebKit/win

REGRESSION(r84990): Nightly builds don't launch on Windows
https://bugs.webkit.org/show_bug.cgi?id=60081
<rdar://problem/9358635>

Reviewed by Steve Falkenburg.

Fix nightlies on Window by moving the layered window functions to the bottom
of IWebViewPrivate and touch WebKit.idl to make sure Interfaces rebuild.

Interfaces/IWebViewPrivate.idl: Move functions added in r84990 to the bottom of the file.
Interfaces/WebKit.idl: Touch to force a rebuild.

4:51 PM Changeset in webkit [85690] by hclam@chromium.org

1 edit
5 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Adding rebaseline for recent changes for mac.

platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png: Added.

4:46 PM Changeset in webkit [85689] by weinig@apple.com

3 edits in trunk/Source/WebKit2

2011-05-03 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

WebKit2 should treat API calls that start/stop loads as user gestures for responsiveness timer
https://bugs.webkit.org/show_bug.cgi?id=60083

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcessWithItem): (WebKit::WebPageProxy::tryClose): (WebKit::WebPageProxy::loadURL): (WebKit::WebPageProxy::loadURLRequest): (WebKit::WebPageProxy::loadHTMLString): (WebKit::WebPageProxy::loadAlternateHTMLString): (WebKit::WebPageProxy::loadPlainTextString): (WebKit::WebPageProxy::stopLoading): (WebKit::WebPageProxy::reload): (WebKit::WebPageProxy::goForward): (WebKit::WebPageProxy::goBack): (WebKit::WebPageProxy::goToBackForwardItem): Start responsiveness timer for load start/stop and close.

WebProcess/WebPage/WebPage.cpp: (WebKit::SendStopResponsivenessTimer::SendStopResponsivenessTimer): (WebKit::SendStopResponsivenessTimer::~SendStopResponsivenessTimer): Add simple RAII class to ensure the StopResponsivenessTimer is called.

(WebKit::WebPage::tryClose):
(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadData):
(WebKit::WebPage::stopLoading):
(WebKit::WebPage::reload):
(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
Sends a message back to the UIProcess to indicate the WebProcess
is still responsive.

4:45 PM Changeset in webkit [85688] by hclam@chromium.org

1 edit
5 adds in trunk/LayoutTests

2011-05-03 Enrica Casucci <enrica@apple.com>

Reviewed by Ryosuke Niwa.

Crash in SpellingCorrectionController::respondToChangedSelection.
https://bugs.webkit.org/show_bug.cgi?id=60071
<rdar://problem/9358190>

editing/selection/undo-crash-expected.txt: Added.
editing/selection/undo-crash.html: Added.

4:40 PM Changeset in webkit [85687] by enrica@apple.com

3 edits
2 adds in trunk

Crash in SpellingCorrectionController::respondToChangedSelection.
https://bugs.webkit.org/show_bug.cgi?id=60071
<rdar://problem/9358190>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Creating a Visible position could trigger a layout and there is no
guarantee that the selection is still valid after that.

Tests: editing/selection/undo-crash.html

editing/SpellingCorrectionController.cpp:

(WebCore::SpellingCorrectionController::respondToChangedSelection):

LayoutTests:

editing/selection/undo-crash-expected.txt: Added.
editing/selection/undo-crash.html: Added.

4:35 PM Changeset in webkit [85686] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][WK2] Incorrect line number dumping
https://bugs.webkit.org/show_bug.cgi?id=60074

[Qt][WK2] editing/pasteboard/do-not-copy-body-color.html fails
https://bugs.webkit.org/show_bug.cgi?id=60076

platform/qt-wk2/Skipped: Add a couple of failing tests.

4:28 PM Changeset in webkit [85685] by leviw@chromium.org

3 edits in trunk/Source/WebCore

2011-05-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Refactor computeInlineDirectionPositionsForLine into smaller functions
https://bugs.webkit.org/show_bug.cgi?id=60072

Split three functions off from computeInlineDirectionPositionsForLine
to improve its readability.

No new tests since this is just moving code around.

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::setMarginsForRubyRun): (WebCore::setLogicalWidthForTextRun): (WebCore::computeExpansionForJustifiedText): (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

4:25 PM Changeset in webkit [85684] by ddkilzer@apple.com

6 edits in trunk/Source

<http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking

Reviewed by Antti Koivisto.

Source/WebCore:

platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the
priority on the request if HTTP pipelining is enabled.
(WebCore::ResourceRequest::doUpdateResourceRequest): Read the
priority from the request if HTTP pipelining is enabled.
(readBooleanPreference): Enable code when compiling with
USE(CFNETWORK).
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto.
Comment out setting the minimum fast lane priority on Windows
since it's not currently available.

Source/WebKit/win:

Interfaces/IWebViewPrivate.idl:

(IWebViewPrivate::httpPipeliningEnabled): Added declaration.
(IWebViewPrivate::setHTTPPipeliningEnabled): Added declaration.

WebView.cpp:

(WebView::httpPipeliningEnabled): Added.
(WebView::setHTTPPipeliningEnabled): Added.

WebView.h:

(WebView::httpPipeliningEnabled): Added declaration.
(WebView::setHTTPPipeliningEnabled): Added declaration.

4:20 PM Changeset in webkit [85683] by tony@chromium.org

2 edits in trunk/LayoutTests

2011-05-03 Tony Chang <tony@chromium.org>

Add a bug number for a recent regression to test_expectations.txt.

platform/chromium/test_expectations.txt:

4:18 PM Changeset in webkit [85682] by hclam@chromium.org

2 edits
10 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Test expectations.

platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.png: Added.
platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt: Added.
platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.png: Added.
platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt: Added.
platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.png: Added.
platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt: Added.
platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.png: Added.
platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt: Added.
platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.png: Added.
platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt: Added.
platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:

4:14 PM Changeset in webkit [85681] by Simon Fraser

2 edits in trunk/Source/WebCore

2011-05-03 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/9278296> Flicker zooming on Google Maps satellite view with accelerated compositing turned on

Conditionalize compositing tiled layer size-constraining logic to older
OSes.

platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::constrainedSize):

4:08 PM Changeset in webkit [85680] by rolandsteiner@chromium.org

5 edits in trunk/Source/WebCore

2011-05-03 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Allow access keys to be used in shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=59979

Move access key methods and members back to Document from TreeScope.
Also traverse into shadow trees when building the access key map.

No new tests. (refactoring)

dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::getElementByAccessKey): (WebCore::Document::buildAccessKeyMap): (WebCore::Document::invalidateAccessKeyMap):
dom/Document.h:
dom/TreeScope.cpp: (WebCore::TreeScope::TreeScope): (WebCore::TreeScope::destroyTreeScopeData):
dom/TreeScope.h:

4:03 PM Changeset in webkit [85679] by kerz@chromium.org

1 edit in branches/chromium/742/LayoutTests/platform/chromium/test_expectations.txt

fixing chrome continuous webkit tests after bad test-expectations merge

4:00 PM Changeset in webkit [85678] by hclam@chromium.org

1 edit
11 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Build fix. Not reviewed.

Add test expectations for new tests.

platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.png: Added.
platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt: Added.
platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.png: Added.
platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.txt: Added.
platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.png: Added.
platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.txt: Added.
platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.png: Added.
platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt: Added.
platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.png: Added.
platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt: Added.
platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt: Added.

3:33 PM Changeset in webkit [85677] by mitz@apple.com

2 edits in trunk/Source/WebCore

<rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
https://bugs.webkit.org/show_bug.cgi?id=60067

Reviewed by Darin Adler.

No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.

rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
results for flipped writing modes.

3:30 PM Changeset in webkit [85676] by mitz@apple.com

2 edits in trunk/LayoutTests

Account for font metric differences exposed by r85411.
Fixes <rdar://problem/9377892> REGRESSION (r85403-r85475): platform/mac/fast/text/ligature-subdivision.html failing

Rubber-stamped by Darin Adler.

platform/mac/fast/text/script-tests/ligature-subdivision.js:

3:29 PM Changeset in webkit [85675] by tony@chromium.org

3 edits in trunk/LayoutTests

2011-05-03 Tony Chang <tony@chromium.org>

Update results for fast/harness/results.html. We shouldn't be
ignoring these failures :(

fast/harness/results-expected.txt:
platform/chromium/test_expectations.txt:

3:25 PM Changeset in webkit [85674] by tony@chromium.org

25 edits in trunk/LayoutTests

2011-05-03 Tony Chang <tony@chromium.org>

Update chromium linux test results after r85013. The vertical
positioning of the glyphs have improved.

platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png:
platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png:
platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
platform/chromium-linux/svg/text/text-intro-05-t-expected.png:
platform/chromium/test_expectations.txt:

3:22 PM Changeset in webkit [85673] by antonm@chromium.org

2 edits in trunk/Source/WebCore

2011-05-03 Anton Muhin <antonm@chromium.org>

Reviewed by Yury Semikhatsky.

[v8] remove an ASSERT from grouping logic
https://bugs.webkit.org/show_bug.cgi?id=60024

This ASSERT was exploratory. Alas, right now I am aware of no easy way to
repro it. Removing for now for greener bots.

No new tests, only an ASSERT removal.

bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId):

3:20 PM Changeset in webkit [85672] by eric@webkit.org

2 edits in trunk/Tools

2011-05-03 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

webkit-patch post-commits HEAD^{.. throws an exception

https://bugs.webkit.org/show_bug.cgi?id=60027}

Scripts/webkitpy/common/checkout/scm/git.py:

3:16 PM Changeset in webkit [85671] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] REGRESSION(r85648) Skip data-transfer-items.html test because data-transfer-items is not a Qt default build option
https://bugs.webkit.org/show_bug.cgi?id=60068

Patch by Igor Oliveira <igor.oliveira@openbossa.org> on 2011-05-03
Reviewed by Csaba Osztrogonác.

Skip data-transfer-items.html test because data-transfer-items
is not a Qt default build option

platform/qt/Skipped:

3:16 PM Changeset in webkit [85670] by luiz@webkit.org

1 edit in trunk/Tools/ChangeLog

[Qt] Layout tests may timeout if loadFinished receives false
https://bugs.webkit.org/show_bug.cgi?id=60064

Fixing ChangeLog.

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::maybeDump):

3:14 PM Changeset in webkit [85669] by rniwa@webkit.org

5 edits
16 adds in trunk

2011-05-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

WebKit allows selection that crosses the shadow boundary of a readonly input element
https://bugs.webkit.org/show_bug.cgi?id=60000

Added pixel tests to ensure WebKit doesn't create a selection that spans across
the shadow DOM boundary of a readonly input element. Also rebaselined a test that
previously exhibited this behavior.

editing/selection/resources/select-across-readonly-input.js: Added. (moveMouseToMiddleOfElement):
editing/selection/select-across-readonly-input-1.html: Added.
editing/selection/select-across-readonly-input-2.html: Added.
editing/selection/select-across-readonly-input-3.html: Added.
editing/selection/select-across-readonly-input-4.html: Added.
editing/selection/select-across-readonly-input-5.html: Added.
platform/mac/editing/selection/select-across-readonly-input-1-expected.png: Added.
platform/mac/editing/selection/select-across-readonly-input-1-expected.txt: Added.
platform/mac/editing/selection/select-across-readonly-input-2-expected.png: Added.
platform/mac/editing/selection/select-across-readonly-input-2-expected.txt: Added.
platform/mac/editing/selection/select-across-readonly-input-3-expected.png: Added.
platform/mac/editing/selection/select-across-readonly-input-3-expected.txt: Added.
platform/mac/editing/selection/select-across-readonly-input-4-expected.png: Added.
platform/mac/editing/selection/select-across-readonly-input-4-expected.txt: Added.
platform/mac/editing/selection/select-across-readonly-input-5-expected.png: Added.
platform/mac/editing/selection/select-across-readonly-input-5-expected.txt: Added.
platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:

2011-05-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

WebKit allows selection that crosses the shadow boundary of a readonly input element
https://bugs.webkit.org/show_bug.cgi?id=60000

The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
in its validation process.

Tests: editing/selection/select-across-readonly-input-1.html

editing/selection/select-across-readonly-input-2.html
editing/selection/select-across-readonly-input-3.html
editing/selection/select-across-readonly-input-4.html
editing/selection/select-across-readonly-input-5.html

editing/VisibleSelection.cpp: (WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
editing/VisibleSelection.h:

3:11 PM Changeset in webkit [85668] by eric@webkit.org

3 edits in trunk/Source/WebCore

2011-05-03 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Split out layoutRunsAndFloats from layoutInlineChildren
https://bugs.webkit.org/show_bug.cgi?id=60052

No new tests, just moving code here. There should be
no change in behavior.

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::layoutInlineChildren):

3:05 PM Changeset in webkit [85667] by luiz@webkit.org

2 edits in trunk/Tools

[Qt] Layout tests may timeout if loadFinished receives false
https://bugs.webkit.org/show_bug.cgi?id=60064

Reviewed by NOBODY Kenneth Rohde Christiansen.

When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
a response is ignored, like it should be for 204 responses. It is a problem for creating
tests for 204 responses for example.

This change has been tested and it causes no regressions in layout tests.

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::maybeDump):

3:05 PM Changeset in webkit [85666] by hclam@chromium.org

2 edits in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Add expectation to suppress new failure.

platform/chromium/test_expectations.txt:

2:51 PM Changeset in webkit [85665] by dpranke@chromium.org

5 edits in trunk/Tools

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, rolling out r85659.
http://trac.webkit.org/changeset/85659
https://bugs.webkit.org/show_bug.cgi?id=59977

restarting isn't working correctly

Scripts/webkitpy/layout_tests/port/apache_http_server.py:
Scripts/webkitpy/layout_tests/port/http_server.py:
Scripts/webkitpy/layout_tests/port/http_server_base.py:
Scripts/webkitpy/layout_tests/port/websocket_server.py:

2:47 PM Changeset in webkit [85664] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
https://bugs.webkit.org/show_bug.cgi?id=59638

platform/qt-wk2/Skipped: Add failing tests until fix.

2:40 PM Changeset in webkit [85663] by hclam@chromium.org

2 edits
1 add in trunk/LayoutTests

2011-05-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
https://bugs.webkit.org/show_bug.cgi?id=59965

Adds a test with a canvas rendered once with normal width/height dimensions then resized to very large dimensions.

fast/canvas/canvas-resize-after-paint-expected.txt: Added.
fast/canvas/canvas-resize-after-paint.html: Added.

2:33 PM Changeset in webkit [85662] by Darin Adler

2 edits in trunk/Source/WebKit2

<rdar://problem/9250444> Enter key doesn't work in a web text field (but Return key does)

Reviewed by Sam Weinig.

No test at this time because the WebKit2 eventSender doesn't use this code path.

Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebKeyboardEvent): Copied the code to special-case certain
keys from the corresponding Mac WebKit1 code path.

2:21 PM Changeset in webkit [85661] by jamesr@google.com

5 edits
2 adds in trunk

2011-05-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
https://bugs.webkit.org/show_bug.cgi?id=59965

Adds a test with a canvas rendered once with normal width/height dimensions then resized to very large dimensions.

fast/canvas/canvas-resize-after-paint-expected.txt: Added.
fast/canvas/canvas-resize-after-paint.html: Added.

2011-05-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
https://bugs.webkit.org/show_bug.cgi?id=59965

Fixes a few bugs leading to a crash if a canvas already being composited was resized to huge dimensions.

Test: fast/canvas/canvas-resize-after-paint.html

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset):

Mark the canvas's layer as needing a synthetic style recalculation when creating or destroying the backing
DrawingBuffer so that we exit compositing mode properly if we can't handle the canvas dimensions.

platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::setLayerRenderer):

Add a null check for m_drawingBuffer

platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear):

Avoid clearing the m_context pointer in reset() - we destroy the DrawingBuffer whenever reset() fails, so
this is unnecessary.

2:21 PM Changeset in webkit [85660] by tony@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-05-03 Tony Chang <tony@chromium.org>

Unreviewed, rolling the version of chromium to r83922.

DEPS:

2:18 PM Changeset in webkit [85659] by dpranke@chromium.org

5 edits in trunk/Tools

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: fix http server startup/shutdown

Previous versions of the code had three problems that made startup
and shutdown flaky. The first is that it would throw exceptions
if it couldn't delete stale log files, which was overly
paranoid. The second is that some of the exceptions weren't
defined properly. The third, and most important, is that it was
using urllib to check if ports were available, which was leaving
sockets in a half-closed state, and keeping ports from being
reused. By switching to raw sockets, we are able to now reliably
restart.

This change also switches the code to using Executives to stop
processes, which will let us delete a bunch of code in the
port/* implementations and fix a weird layering problem in a
subsequent patch.

https://bugs.webkit.org/show_bug.cgi?id=59977

Scripts/webkitpy/layout_tests/port/apache_http_server.py:
Scripts/webkitpy/layout_tests/port/http_server.py:
Scripts/webkitpy/layout_tests/port/http_server_base.py:
Scripts/webkitpy/layout_tests/port/websocket_server.py:

2:14 PM Changeset in webkit [85658] by dpranke@chromium.org

2 edits in trunk/Tools

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

fix failing printing_unittest on win32
https://bugs.webkit.org/show_bug.cgi?id=59963

Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:

1:57 PM Changeset in webkit [85657] by caio.oliveira@openbossa.org

2 edits
1 add in trunk/Websites/bugs.webkit.org

2011-05-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Adam Roben.

Add tests to PrettyPatch
https://bugs.webkit.org/show_bug.cgi?id=57298

Verify that 'prettify' parse the right number of files and parts
(add/remove/shared) by checking a set of patches available in
bugs.webkit.org.

PrettyPatch/PrettyPatch.rb: exported a couple a globals with statistics information for our test script.
PrettyPatch/PrettyPatch_test.rb: Added.

1:55 PM Changeset in webkit [85656] by Adam Roben

2 edits in trunk/Source/WebKit/win

Add some missing virtual keywords on derived-class destructors

Darin Adler noticed one, I noticed the other. This doesn't change the generated code; it
just matches our style of explicitly marking overrides "virtual".

WebCoreSupport/WebInspectorClient.h: Made the WebInspectorClient and

WebInspectorFrontendClient destructors explicitly virtual.

1:54 PM Changeset in webkit [85655] by jeffm@apple.com

3 edits in trunk/Source/WebKit2

2011-05-03 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Unreachable URL is lost when canceling load of a new page
https://bugs.webkit.org/show_bug.cgi?id=60057
<rdar://problem/9049135>

When setting the unreachable URL in the WebFrameProxy, keep track of any previous unreachable URL
so we can restore it if the page load fails.

UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::didFailProvisionalLoad): Restore m_unreachableURL to previous value. (WebKit::WebFrameProxy::setUnreachableURL): Keep track of previous unreachable URL in m_lastUnreachableURL.
UIProcess/WebFrameProxy.h: Moved setUnreachableURL() implementation to .cpp file, added m_lastUnreachableURL.

1:51 PM Changeset in webkit [85654] by ojan@chromium.org

3 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

store results.html options in localstorage
https://bugs.webkit.org/show_bug.cgi?id=60048

This makes options persistent per-domain. It's not perfect,
but it should make it possible to have preferences for how
people would like the results.html page to render.

fast/harness/resources/results-test.js:
fast/harness/results.html:

1:51 PM Changeset in webkit [85653] by Adam Roben

20 edits in trunk

Fix most strict PassOwnPtr violations on Windows

Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
enabled

Reviewed by Anders Carlsson.

Source/WebCore:

loader/EmptyClients.h:
platform/GeolocationService.cpp:
platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
platform/mock/GeolocationServiceMock.cpp:
rendering/RenderTheme.cpp:
rendering/RenderThemeSafari.cpp:

Source/WebKit/win:

WebCoreSupport/WebInspectorClient.h: Made the destructor public, which is required now

that this type is put into a PassOwnPtr. (Previously, only
WebCore::InspectorFrontendClientLocal was put into a [Pass]OwnPtr.)

FullscreenVideoController.cpp:
WebCoreSupport/WebFrameLoaderClient.cpp:
WebCoreSupport/WebInspectorClient.cpp:
WebHistory.cpp:
WebHistoryItem.cpp:
WebView.cpp:

Source/WebKit2:

Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::writeEventHandler): Use nullptr.

Tools:

WebKitAPITest/Test.h: Use adoptPtr.

1:49 PM Changeset in webkit [85652] by leviw@chromium.org

3 edits in trunk/Source/WebCore

2011-05-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Extract LineInfo class
https://bugs.webkit.org/show_bug.cgi?id=60044

Created a LineInfo class in RenderBlockLineLayout.cpp that brings together the relevant
layout information about a line. This simplifies function signatures and clears up initialization.

No new tests as this is refactoring.

rendering/RenderBlock.h: Updated internal layout function signatures to use LineInfo.
rendering/RenderBlockLineLayout.cpp: (WebCore::LineInfo::LineInfo): (WebCore::LineInfo::isFirstLine): (WebCore::LineInfo::isLastLine): (WebCore::LineInfo::isEmpty): (WebCore::LineInfo::previousLineBrokeCleanly): (WebCore::LineInfo::setFirstLine): (WebCore::LineInfo::setLastLine): (WebCore::LineInfo::setEmpty): (WebCore::LineInfo::setPreviousLineBrokeCleanly): (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::skipNonBreakingSpace): (WebCore::shouldCollapseWhiteSpace): (WebCore::requiresLineBox): Moved from RenderBlock.h and made it locally scoped to RenderBlockLineLayout.cpp (WebCore::RenderBlock::generatesLineBoxesForInlineChild): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::RenderBlock::findNextLineBreak):

1:39 PM Changeset in webkit [85651] by leandro@webkit.org

4 edits in trunk

2011-05-03 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix for NETWORK_BACKEND=curl.

Force linking with zlib so that uncompress() exists.

Source/cmake/OptionsEfl.cmake: Find zlib.

2011-05-03 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix for NETWORK_BACKEND=curl.

Force linking with zlib so that uncompress() exists.

CMakeListsEfl.txt: Append zlib libraries.

1:35 PM Changeset in webkit [85650] by rolandsteiner@chromium.org

5 edits in trunk/Source/WebCore

2011-05-03 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Update node list cache count on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59983

Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
Make setDocument() and setDocumentRecursively() private.

No new tests. (refactoring)

dom/ContainerNode.cpp: (WebCore::ContainerNode::childrenChanged):
dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument): (WebCore::Node::setTreeScopeRecursively): (WebCore::Node::childNodes): (WebCore::Node::registerDynamicNodeList): (WebCore::Node::unregisterDynamicNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
dom/Node.h:
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):

1:33 PM Changeset in webkit [85649] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

2011-05-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Bundle trailingSpaceObject and trailingPositionedBoxes in findNextLineBreak as a class
https://bugs.webkit.org/show_bug.cgi?id=60046

Extracted TrailingObjects that encapsulates trailingSpaceObject and trailingPositionedBoxes.

rendering/RenderBlockLineLayout.cpp: (WebCore::TrailingObjects::TrailingObjects): (WebCore::TrailingObjects::setTrailingWhitespace): (WebCore::TrailingObjects::clear): (WebCore::TrailingObjects::appendBoxIfNeeded): (WebCore::TrailingObjects::addMidpoints): (WebCore::RenderBlock::findNextLineBreak):

1:29 PM Changeset in webkit [85648] by commit-queue@webkit.org

9 edits
2 copies
3 adds in trunk

2011-05-03 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Eric Seidel.

[Qt] Implement initial support to DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=58448

Remove data-transfer-items.html from Qt skipped tests and create an expected
result file for data-transfer-items.html test. The need to create a expected result
file is because the test presuppose that the type of the first element in
DataTransferItems list is a html but when Qt selects a data, it first copies a text
and then it copies the html, so for Qt expected test file the first element is a
text and the second one is a html.

platform/qt/Skipped:
platform/qt/editing/pasteboard/data-transfer-items-expected.txt: Added.

2011-05-03 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Eric Seidel.

[Qt] Implement initial support to DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=58448

Implement initial support to DataTransferItems. DataTransferItems are used to
hold data for drag and drop operations. DataTransferItems hold a list of
DataTransferItem objects each of which holds an item being dragged.

WebCore.pro:
dom/DataTransferItems.idl:
editing/qt/EditorQt.cpp: (WebCore::Editor::newGeneralClipboard):
page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard):
platform/chromium/DataTransferItemsChromium.h:
platform/qt/ClipboardQt.cpp: (WebCore::Clipboard::create): (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::items):
platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::create):
platform/qt/DataTransferItemQt.cpp: Added. (WebCore::DataTransferItem::create): (WebCore::DataTransferItemQt::createFromPasteboard): (WebCore::DataTransferItemQt::create): (WebCore::DataTransferItemQt::DataTransferItemQt): (WebCore::DataTransferItemQt::getAsString): (WebCore::DataTransferItemQt::getAsFile):
platform/qt/DataTransferItemQt.h: Added.
platform/qt/DataTransferItemsQt.cpp: Copied from Source/WebCore/editing/qt/EditorQt.cpp. (WebCore::DataTransferItemsQt::create): (WebCore::DataTransferItemsQt::DataTransferItemsQt): (WebCore::DataTransferItemsQt::addPasteboardItem):
platform/qt/DataTransferItemsQt.h: Copied from Source/WebCore/editing/qt/EditorQt.cpp.

1:22 PM Changeset in webkit [85647] by caio.oliveira@openbossa.org

2 edits in trunk/Tools

2011-05-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

Add myself to the committers list.

Scripts/webkitpy/common/config/committers.py:

1:16 PM Changeset in webkit [85646] by hclam@chromium.org

1 edit
1 add in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

new baseline for SVG test.

platform/chromium-win-vista/svg/text/text-intro-05-t-expected.txt: Added.

1:11 PM Changeset in webkit [85645] by hclam@chromium.org

1 edit
4 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

New baseline for GPU layout tests.

platform/chromium-gpu-mac/animations/3d/matrix-transform-type-animation-expected.png: Added.
platform/chromium-gpu-mac/animations/3d/state-at-end-event-transform-expected.png: Added.

1:08 PM Changeset in webkit [85644] by commit-queue@webkit.org

17 edits in trunk/Source

2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703

No new tests, refactoring only.

dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties): (WebCore::Element::insertedIntoDocument): (WebCore::Element::removedFromDocument): (WebCore::Element::insertedIntoTree): (WebCore::Element::removedFromTree): (WebCore::Element::attach): (WebCore::Element::detach): (WebCore::Element::recalcStyle): (WebCore::Element::shadowRoot): (WebCore::Element::ensureShadowRoot): (WebCore::Element::childrenChanged):
dom/Node.cpp: (WebCore::Node::setTreeScopeRecursively): (WebCore::shadowRoot): (WebCore::Node::setDocumentRecursively): (WebCore::NodeRendererFactory::findVisualParent): Updated all the call sites for shadowRoot and ensureShadowRoot in the 2 previous classes.

dom/Element.h: Updated 2 methods' signature to return a ShadowRoot*.

dom/ShadowRoot.h: Removed toShadowRoot as it is not used anymore.

html/HTMLDetailsElement.cpp:
html/HTMLSummaryElement.cpp: Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703

src/WebElement.cpp: Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703

WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703

DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shadowRoot): Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703

WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Added #include for ShadowRoot.h.

1:07 PM Changeset in webkit [85643] by gyuyoung.kim@samsung.com

3 edits in trunk/Source/WebCore

2011-05-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement mediaSliderTrack
https://bugs.webkit.org/show_bug.cgi?id=59998

Implement paintMediaSliderTrack.

platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::RenderThemeEfl): (WebCore::RenderThemeEfl::paintMediaSliderTrack):
platform/efl/RenderThemeEfl.h:

1:03 PM Changeset in webkit [85642] by mnaganov@chromium.org

4 edits in trunk/Source/WebCore

2011-05-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: [Chromium] Fix slowness of Summary view nodes expansion in detailed heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=60023

inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotConstructorNode): (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype.aggregates): (WebInspector.HeapSnapshot.prototype._buildAggregates): (WebInspector.HeapSnapshot.prototype._sortAggregateIndexes): (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass): (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotNodesProvider):
inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotProxy.prototype.aggregates): (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):

12:52 PM Changeset in webkit [85641] by mnaganov@chromium.org

3 edits in trunk/Source/WebCore

2011-05-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: [Chromium] Hint user that to display retaining paths, an object entry must be clicked.
https://bugs.webkit.org/show_bug.cgi?id=60029

English.lproj/localizedStrings.js:
inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.reset): (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):

12:51 PM Changeset in webkit [85640] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/qt

2011-05-03 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtDeclarative Webview element has a fixed white background
https://bugs.webkit.org/show_bug.cgi?id=40918

QProperty REVISION feature is not present in certain Qt Trunk clones.
These builds report their version as 4.8.0, and therefore break on the
prior #if QT_VERSION >= 0x040704. The proper fix is to check based on
the existance of Q_REVISION.

declarative/plugin.cpp: (WebKitQmlPlugin::registerTypes):
declarative/qdeclarativewebview.cpp:
declarative/qdeclarativewebview_p.h:

12:50 PM Changeset in webkit [85639] by mario@webkit.org

2 edits in trunk/LayoutTests

2011-05-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping test timing out in the GTK 64-bit bot.

platform/gtk/Skipped: Skipped media/video-volume-slider.html.

12:47 PM Changeset in webkit [85638] by ojan@chromium.org

2 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <ojan@chromium.org>

improve styling of options menu in results.html file

fast/harness/results.html:

12:42 PM Changeset in webkit [85637] by hclam@chromium.org

2 edits
3 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

New baseline and add test expectation to suppress failure.

platform/chromium-gpu-win/animations/3d/replace-filling-transform-expected.png: Added.
platform/chromium/test_expectations.txt:

12:34 PM Changeset in webkit [85636] by ojan@chromium.org

2 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

Don't include the test itself in expanded test results
https://bugs.webkit.org/show_bug.cgi?id=60051

When loading from local disk, we can't force it to render as
plain text, which causes the page to actually run. Also,
the extra clutter of another iframe is probably not worth it.

If we decide we want this later, we can add it back in as a
preference that's off by default.

fast/harness/results.html:

12:31 PM Changeset in webkit [85635] by hclam@chromium.org

2 edits in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Test expectation for a slow test to avoid flakiness.

platform/chromium/test_expectations.txt:

12:25 PM Changeset in webkit [85634] by ojan@chromium.org

3 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <ojan@chromium.org>

Fix test that broke after adding CSS animations.

fast/harness/resources/results-test.js:
fast/harness/results-expected.txt:

12:19 PM Changeset in webkit [85633] by ojan@chromium.org

4 edits in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Adding test expectations for some SVG tests on Windows.

platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png: Removed.
platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.png: Added.
platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Added.
platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Added.
platform/chromium-win/svg/text/text-fonts-01-t-expected.txt: Added.
platform/chromium-win/svg/text/text-intro-05-t-expected.png:
platform/chromium-win/svg/text/text-intro-05-t-expected.txt:
platform/chromium/test_expectations.txt:

12:17 PM Changeset in webkit [85632] by hclam@chromium.org

4 edits
5 adds
1 delete in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Adding test expectations for some SVG tests on Windows.

platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png: Removed.
platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.png: Added.
platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Added.
platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Added.
platform/chromium-win/svg/text/text-fonts-01-t-expected.txt: Added.
platform/chromium-win/svg/text/text-intro-05-t-expected.png:
platform/chromium-win/svg/text/text-intro-05-t-expected.txt:
platform/chromium/test_expectations.txt:

12:11 PM Changeset in webkit [85631] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

2011-05-03 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: cursor update updates indexes
https://bugs.webkit.org/show_bug.cgi?id=59995

This test creates an object store, adds both a unique and a non-unique index,
adds a record, opens a cursor, changes the record, and verifies that both
indexes correctly updated to reflect the modified record.

storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt: Added.
storage/indexeddb/mozilla/cursor-update-updates-indexes.html: Added.

11:45 AM Changeset in webkit [85630] by jamesr@google.com

2 edits in trunk/LayoutTests

2011-05-03 James Robinson <jamesr@chromium.org>

Remove stale expectations for animations/3d in chromium test_expectations.txt

platform/chromium/test_expectations.txt:

11:45 AM Changeset in webkit [85629] by Beth Dakin

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=60045
Scrollbar thumb sometimes leaves artifacts in the track after scrolling
-and corresponding-
<rdar://problem/9015376>

Reviewed by Dan Bernstein.

When we're using WK_SCROLLBAR_PAINTER, the AppleScrollBarVariant default should
always be ignored.

platform/mac/ScrollbarThemeMac.mm:

(WebCore::updateArrowPlacement):

11:43 AM Changeset in webkit [85628] by jamesr@google.com

4 edits in trunk

2011-05-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Layout test animations/3d/replace-filling-transform.html failing
https://bugs.webkit.org/show_bug.cgi?id=59839

Ignore animations/3d when run in CPU mode as these are compositor tests.

platform/chromium/test_expectations.txt:

2011-05-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Layout test animations/3d/replace-filling-transform.html failing
https://bugs.webkit.org/show_bug.cgi?id=59839

Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.

Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

11:42 AM Changeset in webkit [85627] by Dimitri Glazkov

3 edits
2 copies in branches/chromium/696

Merge 84270 - 2011-04-19 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Tony Chang.

[chromium] Clicking on plugin for first time blocks focus shift
https://bugs.webkit.org/show_bug.cgi?id=58419

Added new test for cross-iframe focus changes on plugin clicks.

plugins/mouse-click-iframe-to-plugin-expected.txt: Added.
plugins/mouse-click-iframe-to-plugin.html: Added.

2011-04-19 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Tony Chang.

[chromium] Clicking on plugin for first time blocks focus shift
https://bugs.webkit.org/show_bug.cgi?id=58419

Switched to using FocusController when moving focus to a plugin
so that cross-frame focus changes are handled correctly.

src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent):

TBR=commit-queue@webkit.org

11:18 AM Changeset in webkit [85626] by ojan@chromium.org

2 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

make pixel zooming in results.html file less jarring
https://bugs.webkit.org/show_bug.cgi?id=60038

-Hide zoomed images when you mouse out of the document or
mouseover an iframe.
-Handle the case where the zoomed images overlap the actual images.

fast/harness/results.html:

11:15 AM Changeset in webkit [85625] by demarchi@webkit.org

2 edits in trunk/Tools

2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed, rolling out r85471.
http://trac.webkit.org/changeset/85471
https://bugs.webkit.org/show_bug.cgi?id=59922

The rule of thumb in EFL is that you init in all the places
you use it. So, if in your application you call ecore_evas_*
functions, you have to call ecore_evas_init() first.

EWebLauncher/main.c: always call *_init() functions when you use that namespace. (quit): (main):

11:10 AM Changeset in webkit [85624] by demarchi@webkit.org

2 edits in trunk

2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

[CMAKE] Unreviewed build fix for gcc >= 4.6

Same fix as done in r84123. CMake explicitly pass the arguments to
make_names.pl, so let's make them the same.

Source/cmake/OptionsCommon.cmake: ditto.

11:00 AM Changeset in webkit [85623] by hyatt@apple.com

3 edits
2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=60040
<rdar://problem/9261591>

Reviewed by Dan Bernstein.

Links broken at iplanwebsites.com. Make sure that culledInlineAbsoluteQuads still does
a translation of a 0,0 point to absolute coordinates so that the top left position is
accurate.

Source/WebCore:

Added fast/inline/skipped-whitespace-client-rect.html

rendering/RenderInline.cpp:

(WebCore::RenderInline::culledInlineAbsoluteQuads):

LayoutTests:

Added fast/inline/skipped-whitespace-client-rect.html

fast/inline/skipped-whitespace-client-rect-expected.txt: Added.
fast/inline/skipped-whitespace-client-rect.html: Added.

10:43 AM Changeset in webkit [85622] by weinig@apple.com

2 edits in trunk/Source/WebKit2

More quarantine related sandbox denial when downloading files
<rdar://problem/9362626>

Reviewed by Anders Carlsson.

WebProcess/com.apple.WebProcess.sb:

10:34 AM Changeset in webkit [85621] by alexis.menard@openbossa.org

3 edits in trunk/Source/JavaScriptCore

2011-05-03 Xan Lopez <xlopez@igalia.com>

Reviewed by Anders Carlsson.

Compile error with GCC 4.6.0, tries to assign unsigned& to bitfield
https://bugs.webkit.org/show_bug.cgi?id=59261

Use unary '+' to force proper type detection in template arguments
with GCC 4.6.0. See bug report for more details.

runtime/Structure.cpp: (JSC::StructureTransitionTable::remove): Use '+' to force precise type detection. (JSC::StructureTransitionTable::add): ditto.
runtime/Structure.h: (JSC::StructureTransitionTable::keyForWeakGCMapFinalizer): ditto.

10:27 AM Changeset in webkit [85620] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix chromium build.

page/Settings.cpp:

10:20 AM Changeset in webkit [85619] by rolandsteiner@chromium.org

3 edits in trunk/Source/WebCore

2011-05-02 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 59974 - Update image map on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59974

No new tests. (reefactoring)

html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute): (WebCore::HTMLMapElement::insertedIntoDocument): (WebCore::HTMLMapElement::removedFromDocument):
rendering/RenderImage.cpp: (WebCore::RenderImage::imageMap):

10:18 AM Changeset in webkit [85618] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix chromium build.

loader/HistoryController.cpp:

10:17 AM Changeset in webkit [85617] by rolandsteiner@chromium.org

25 edits in trunk/Source/WebCore

2011-05-02 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 59966 - Update ID hash on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59966

No new tests. (refactoring)

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::elementsFromAttribute): (WebCore::AccessibilityRenderObject::activeDescendant):
accessibility/AccessibilityRenderObject.h: (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
css/CSSCursorImageValue.cpp: (WebCore::resourceReferencedByCursorElement): (WebCore::CSSCursorImageValue::~CSSCursorImageValue): (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): (WebCore::CSSCursorImageValue::cachedImage):
dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
dom/Element.h: (WebCore::Element::updateId):
dom/Node.cpp: (WebCore::Node::querySelector):
html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoTree): (WebCore::FormAssociatedElement::resetFormOwner):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dataList):
html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::control):
rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath):
svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::glyphElement):
svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource): (WebCore::SVGFEImageElement::build):
svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes):
svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::pathElement):
svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):
svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes):
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getElementById):
svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::updateReferencedText):
svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::insertedIntoDocument):
svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildPendingResource): (WebCore::SVGUseElement::hasCycleUseReferencing): (WebCore::SVGUseElement::expandUseElementsInShadowTree):
svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::viewTarget):
svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::eventBaseFor): (WebCore::SVGSMILElement::connectConditions): (WebCore::SVGSMILElement::targetElement):
xml/XPathFunctions.cpp: (WebCore::XPath::FunId::evaluate):

10:14 AM Changeset in webkit [85616] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix chromium build.

css/StyleMedia.cpp:

10:11 AM Changeset in webkit [85615] by weinig@apple.com

6 edits in trunk/Source/WebCore

Prune #includes from FrameView.h (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=59957

Reviewed by Anders Carlsson.

page/FrameView.h:

Prune #includes.

accessibility/chromium/AXObjectCacheChromium.cpp:
page/win/FrameCGWin.cpp:
platform/Scrollbar.cpp:

Add not necessary #includes.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:

Add now necessary forward declaration.

9:45 AM Changeset in webkit [85614] by ojan@chromium.org

2 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <ojan@chromium.org>

Fix test accidentally modified in http://trac.webkit.org/changeset/85610.

fullscreen/full-screen-zIndex.html:

9:42 AM Changeset in webkit [85613] by Dimitri Glazkov

5 edits in branches/chromium/742

Merge 84587 - 2011-04-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adele Peterson.

REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
https://bugs.webkit.org/show_bug.cgi?id=59053

fast/events/shadow-boundary-crossing-expected.txt: Updated expected results.
fast/events/shadow-boundary-crossing.html: Added new sub-test.

2011-04-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adele Peterson.

REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
https://bugs.webkit.org/show_bug.cgi?id=59053

Turns out, the relatedTarget of an event could be also an ancestor of an event,
not just its parent. Duh.

dom/EventDispatcher.cpp: (WebCore::EventDispatcher::adjustToShadowBoundaries): Changed to use shadowHost

explicitly.

TBR=Dimitri Glazkov
Review URL: http://codereview.chromium.org/6914018

9:39 AM Changeset in webkit [85612] by ojan@chromium.org

3 edits in trunk/Tools

2011-05-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

remove no longer used method
https://bugs.webkit.org/show_bug.cgi?id=59981

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

9:33 AM Changeset in webkit [85611] by ddkilzer@apple.com

3 edits in trunk/WebKitLibraries

Part 1 of 2: <http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
<rdar://problem/8924448>

Reviewed by Adam Roben.

win/include/WebKitSystemInterface/WebKitSystemInterface.h:

(wkGetHTTPPipeliningPriority): Added declaration.
(wkSetHTTPPipeliningMaximumPriority): Added declaration.
(wkSetHTTPPipeliningPriority): Added declaration.

win/lib/WebKitSystemInterface.lib: Updated.

9:30 AM Changeset in webkit [85610] by ojan@chromium.org

7 edits in trunk

2011-05-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

add image toggling behavior from old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=59978

Add a checkbox to switch between image toggling (default)
and just showing results for expected/actual images.

fast/harness/resources/results-test.js:
fast/harness/results-expected.txt:
fast/harness/results.html:

2011-05-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

add image toggling behavior from old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=59978

Output -diffs.html files. This matches old-run-webkit-tests.
In theory, we could use data urls in the results.html file, but
data urls don't currently have access to local files.

Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:

9:25 AM Changeset in webkit [85609] by tony@chromium.org

7 edits in trunk/Tools

2011-05-02 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[nrwt] remove some obsolete references to .checksum files
https://bugs.webkit.org/show_bug.cgi?id=59971

Scripts/webkitpy/layout_tests/layout_package/printing.py:
Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

9:22 AM Changeset in webkit [85608] by satish@chromium.org

7 edits
1 delete in trunk/LayoutTests

2011-05-03 Satish Sampath <satish@chromium.org>

Unreviewed, update test expectations for chromium.

platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.txt: Removed.

9:21 AM Changeset in webkit [85607] by adamk@chromium.org

4 edits in trunk

2011-05-02 Adam Klein <adamk@chromium.org>

Reviewed by Tony Chang.

Roll chromium DEPS to r83722, add new crypto directory to DEPS
https://bugs.webkit.org/show_bug.cgi?id=59992

.gitignore: Ignore new chromium/crypto directory.

2011-05-02 Adam Klein <adamk@chromium.org>

Reviewed by Tony Chang.

Roll chromium DEPS to r83722, add new crypto directory to DEPS
https://bugs.webkit.org/show_bug.cgi?id=59992

DEPS:

9:18 AM Changeset in webkit [85606] by caseq@chromium.org

2 edits in trunk/Source/WebCore

2011-05-03 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
https://bugs.webkit.org/show_bug.cgi?id=60026

Return a wrapper for Node in toV8(Node*) when called with a node of type
SHADOW_ROOT_NODE instead of entering infinite recursion.

bindings/v8/custom/V8NodeCustom.cpp: (WebCore::toV8Slow):

8:41 AM Changeset in webkit [85605] by jberlin@webkit.org

4 edits in trunk/Source/JavaScriptCore

Revert r85550 and r85575.

Rubber-stamped by Adam Roben.

Variables cannot be exported via the .def file. Instead, they should be annotated with
JS_EXPORTDATA.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):

runtime/Structure.h:

(JSC::Structure::typeInfo):
(JSC::Structure::previousID):
(JSC::Structure::propertyStorageCapacity):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):
(JSC::Structure::materializePropertyMapIfNecessary):

8:14 AM April 2011 Meeting edited by vestbo@webkit.org

(diff)

8:05 AM Changeset in webkit [85604] by satish@chromium.org

12 edits in trunk/LayoutTests

2011-05-03 Satish Sampath <satish@chromium.org>

Reviewed by Tony Gentilcore.

Rebaseline speech input layout test expectations for chromium.
https://bugs.webkit.org/show_bug.cgi?id=59742

platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
platform/chromium/test_expectations.txt:

6:54 AM Changeset in webkit [85603] by Adam Roben

43 edits in trunk

Allow implicit conversion from nullptr_t to PassOwnPtr

This makes it a lot easier to write code that just wants a null PassOwnPtr, especially in
strict PassOwnPtr mode.

Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
doesn't work, but should

Reviewed by Adam Barth.

Source/JavaScriptCore:

wtf/PassOwnPtr.h:

(WTF::PassOwnPtr::PassOwnPtr): Added a non-explicit constructor that takes a nullptr_t.

wtf/MessageQueue.h:

(WTF::::waitForMessageFilteredWithTimeout):
(WTF::::tryGetMessage):
Use the new implicit conversion.

Source/WebCore:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

bindings/js/ScheduledAction.cpp:
css/CSSStyleSelector.cpp:
css/MediaList.cpp:
css/MediaQueryMatcher.cpp:
css/SVGCSSStyleSelector.cpp:
dom/MessagePort.cpp:
html/InputType.cpp:
html/canvas/WebGLRenderingContext.cpp:
inspector/InspectorStyleSheet.cpp:
page/ContextMenuController.cpp:
page/Page.cpp:
platform/PlatformGestureRecognizer.cpp:
platform/PurgeableBuffer.h:
platform/graphics/ImageBuffer.h:
platform/leveldb/LevelDBDatabase.cpp:
platform/mac/PurgeableBufferMac.cpp:
platform/text/RegularExpression.cpp:
rendering/RenderTheme.cpp:
rendering/RenderThemeMac.mm:
rendering/style/RenderStyle.h:
rendering/style/SVGRenderStyleDefs.cpp:
rendering/style/ShadowData.cpp:
rendering/style/StyleRareInheritedData.cpp:
rendering/style/StyleRareNonInheritedData.cpp:
rendering/svg/RenderSVGResourcePattern.cpp:

Source/WebKit/chromium:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

src/WebMediaPlayerClientImpl.cpp:

Source/WebKit/mac:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

History/WebHistory.mm:
Plugins/WebNetscapePluginEventHandler.mm:
WebView/WebView.mm:

Source/WebKit2:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

Platform/CoreIPC/Connection.cpp:
UIProcess/qt/WebContextMenuProxyQt.cpp:
WebProcess/InjectedBundle/InjectedBundle.cpp:
WebProcess/WebPage/DrawingArea.cpp:

Tools:

Take advantage of implicit nullptr_t -> PassOwnPtr conversion

DumpRenderTree/chromium/CppBoundClass.h:
DumpRenderTree/chromium/WebViewHost.cpp:

6:37 AM Changeset in webkit [85602] by apavlov@chromium.org

2 edits in branches/chromium/742/Source/WebCore/inspector/front-end

Merge 85415 - 2011-05-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: address stack frame scriptName -> url rename in timeline panel.

inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6914017

6:25 AM Changeset in webkit [85601] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

2011-05-03 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix inspector status bar image glyph reference in network panel.

inspector/front-end/networkPanel.css: (.network-larger-resources-status-bar-item .glyph):

6:11 AM Changeset in webkit [85600] by yurys@chromium.org

1 edit
1 add in trunk/LayoutTests

2011-05-03 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Provide Chromium test expectaions for new test.

platform/chromium/inspector/console/console-log-document-proto-expected.txt: Added.

6:10 AM Changeset in webkit [85599] by pfeldman@chromium.org

3 edits in trunk/LayoutTests

2011-05-03 Pavel Feldman <pfeldman@google.com>

Not reviewed: rebaseline inspector test.

inspector/storage-panel-dom-storage-expected.txt:
inspector/storage-panel-dom-storage.html:

6:02 AM Changeset in webkit [85598] by rgabor@webkit.org

2 edits in trunk/LayoutTests

[Qt] Add failing tests to ARM specific Skipped list

Rubber-stamped by Csaba Osztrogonác.

platform/qt-arm/Skipped:

5:56 AM Changeset in webkit [85597] by pfeldman@chromium.org

7 edits in trunk/Source/WebCore

2011-05-03 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: rename BrowserDebugger agent to DOMDebugger.
https://bugs.webkit.org/show_bug.cgi?id=60019

inspector/CodeGeneratorInspector.pm:
inspector/Inspector.json:
inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend):
inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
inspector/generate-inspector-idl:

5:48 AM Changeset in webkit [85596] by yurys@chromium.org

5 edits
2 adds in trunk

2011-05-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove special logic for type of document.proto
https://bugs.webkit.org/show_bug.cgi?id=60014

inspector/console/console-log-document-proto-expected.txt: Added.
inspector/console/console-log-document-proto.html: Added.
inspector/console/console-log-toString-object-expected.txt:
inspector/console/console-log-toString-object.html:

2011-05-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove special logic for type of document.proto
https://bugs.webkit.org/show_bug.cgi?id=60014

Test: inspector/console/console-log-document-proto.html

inspector/InjectedScriptSource.js: removed unnecessary check nodeType === undefined

2:53 AM Changeset in webkit [85595] by Carlos Garcia Campos

5 edits in trunk

2011-05-03 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Eric Seidel.

[GTK] Build webkit1 even when webkit2 is enabled
https://bugs.webkit.org/show_bug.cgi?id=59695

GNUmakefile.am:
configure.ac:

2011-05-03 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Eric Seidel.

[GTK] Build webkit1 even when webkit2 is enabled
https://bugs.webkit.org/show_bug.cgi?id=59695

GNUmakefile.am:

2:30 AM Changeset in webkit [85594] by Philippe Normand

2 edits in trunk/LayoutTests

2011-05-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskip now passing test.

[GTK] media/video-controls-transformed.html fails
https://bugs.webkit.org/show_bug.cgi?id=50706

platform/gtk/Skipped:

2:17 AM Changeset in webkit [85593] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

2011-05-03 Pavel Feldman <pfeldman@google.com>

Not reviewed: fixed typo in inspector style.

inspector/front-end/inspector.css: (.status-bar-item > .glyph):

2:13 AM Changeset in webkit [85592] by pfeldman@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-05-03 Pavel Feldman <pfeldman@google.com>

Not reviewed: re-applied r85589.

src/js/DevTools.js: (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

2:01 AM Changeset in webkit [85591] by pfeldman@chromium.org

4 edits in trunk/Source

2011-05-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: revision history storage is too slow.
https://bugs.webkit.org/show_bug.cgi?id=59939

It turns out that iterating localStorage keys is very
expensive (results in slow inspector start), refactor revision
history in order not to rely upon that operation.

inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource._resourceRevisionRegistry): (WebInspector.Resource.restoreRevisions.persist): (WebInspector.Resource.restoreRevisions): (WebInspector.Resource.persistRevision): (WebInspector.Resource.prototype._persistRevision):
inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._processCachedResources): (WebInspector.ResourceTreeModel.prototype._frameNavigated):

1:55 AM Changeset in webkit [85590] by mario@webkit.org

2 edits in trunk/LayoutTests

2011-05-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, needed rebaseline after revision r85499.

platform/gtk/fast/replaced/table-percent-height-expected.txt:

1:00 AM Changeset in webkit [85589] by pfeldman@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-05-03 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [remote debugging] use document.title to set window name.
https://bugs.webkit.org/show_bug.cgi?id=60012

src/js/DevTools.js: (WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

12:54 AM Changeset in webkit [85588] by pfeldman@chromium.org

6 edits
2 adds
8 deletes in trunk/Source/WebCore

2011-05-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: combine toolbar icon images.
https://bugs.webkit.org/show_bug.cgi?id=59931

WebCore.gypi:
inspector/front-end/Images/auditsIcon.png: Removed.
inspector/front-end/Images/consoleIcon.png: Removed.
inspector/front-end/Images/elementsIcon.png: Removed.
inspector/front-end/Images/networkIcon.png: Removed.
inspector/front-end/Images/profilesIcon.png: Removed.
inspector/front-end/Images/resourcesIcon.png: Removed.
inspector/front-end/Images/scriptsIcon.png: Removed.
inspector/front-end/Images/timelineIcon.png: Removed.
inspector/front-end/Images/toolbarIcons.png: Added.
inspector/front-end/Images/toolbarIconsSmall.png: Added.
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.css: (.toolbar-icon): (#toolbar-dropdown .toolbar-icon): (.toolbar-item:active .toolbar-icon): (#toolbar-dropdown .toolbar-item:active .toolbar-icon): (.toolbar-item.elements .toolbar-icon): (.toolbar-item.resources .toolbar-icon): (#toolbar-dropdown .toolbar-item.resources .toolbar-icon): (.toolbar-item.network .toolbar-icon): (#toolbar-dropdown .toolbar-item.network .toolbar-icon): (.toolbar-item.scripts .toolbar-icon): (#toolbar-dropdown .toolbar-item.scripts .toolbar-icon): (.toolbar-item.timeline .toolbar-icon): (#toolbar-dropdown .toolbar-item.timeline .toolbar-icon): (.toolbar-item.profiles .toolbar-icon): (#toolbar-dropdown .toolbar-item.profiles .toolbar-icon): (.toolbar-item.audits .toolbar-icon): (#toolbar-dropdown .toolbar-item.audits .toolbar-icon): (.toolbar-item.console .toolbar-icon): (#toolbar-dropdown .toolbar-item.console .toolbar-icon): (.status-bar-item > .glyph):

12:52 AM Changeset in webkit [85587] by pfeldman@chromium.org

5 edits
1 add
21 deletes in trunk/Source/WebCore

2011-05-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: combine status bar button glyphs.
https://bugs.webkit.org/show_bug.cgi?id=59885

WebCore.gypi:
inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Removed.
inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Removed.
inspector/front-end/Images/clearConsoleButtonGlyph.png: Removed.
inspector/front-end/Images/consoleButtonGlyph.png: Removed.
inspector/front-end/Images/dockButtonGlyph.png: Removed.
inspector/front-end/Images/enableOutlineButtonGlyph.png: Removed.
inspector/front-end/Images/enableSolidButtonGlyph.png: Removed.
inspector/front-end/Images/excludeButtonGlyph.png: Removed.
inspector/front-end/Images/focusButtonGlyph.png: Removed.
inspector/front-end/Images/garbageCollectButtonGlyph.png: Removed.
inspector/front-end/Images/gearButtonGlyph.png: Removed.
inspector/front-end/Images/helpButtonGlyph.png: Removed.
inspector/front-end/Images/largerResourcesButtonGlyph.png: Removed.
inspector/front-end/Images/nodeSearchButtonGlyph.png: Removed.
inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Removed.
inspector/front-end/Images/percentButtonGlyph.png: Removed.
inspector/front-end/Images/prettyPrintButtonGlyph.png: Removed.
inspector/front-end/Images/recordButtonGlyph.png: Removed.
inspector/front-end/Images/recordToggledButtonGlyph.png: Removed.
inspector/front-end/Images/reloadButtonGlyph.png: Removed.
inspector/front-end/Images/statusBarButtonGlyphs.png: Added.
inspector/front-end/Images/undockButtonGlyph.png: Removed.
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.css: (.status-bar-item > .glyph): (#dock-status-bar-item .glyph): (body.detached #dock-status-bar-item .glyph): (#console-status-bar-item .glyph): (.clear-status-bar-item .glyph): (button.enable-toggle-status-bar-item .glyph): (button.enable-toggle-status-bar-item.toggled-on .glyph): (.scripts-pause-on-exceptions-status-bar-item .glyph): (.scripts-toggle-pretty-print-status-bar-item .glyph): (.toggle-breakpoints .glyph): (.toggle-breakpoints.toggled-on .glyph): (.resources-larger-resources-status-bar-item .glyph): (.timeline-filter-status-bar-item .glyph): (.garbage-collect-status-bar-item .glyph): (.record-profile-status-bar-item .glyph): (.record-profile-status-bar-item.toggled-on .glyph): (.heap-snapshot-status-bar-item .glyph): (.node-search-status-bar-item .glyph): (.percent-time-status-bar-item .glyph): (.focus-profile-node-status-bar-item .glyph): (.exclude-profile-node-status-bar-item .glyph): (.reset-profile-status-bar-item .glyph): (.delete-storage-status-bar-item .glyph): (.refresh-storage-status-bar-item .glyph):
inspector/front-end/inspector.js:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed