Context Navigation

Add the ability to disable WebProcess side display throttling that
takes place in DrawingAreaImpl::displayTimerFired. Disable the throttling
when in a user or animated scroll.

WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didStartRubberBandForFrame): (WebKit::WebChromeClient::didCompleteRubberBandForFrame): (WebKit::WebChromeClient::didStartAnimatedScroll): (WebKit::WebChromeClient::didCompleteAnimatedScroll):
WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::enableDisplayThrottling): (WebKit::DrawingArea::disableDisplayThrottling):
WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::enableDisplayThrottling): (WebKit::DrawingAreaImpl::disableDisplayThrottling): (WebKit::DrawingAreaImpl::displayTimerFired):
WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::wheelEvent):

5:46 PM Changeset in webkit [88126] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-1.4/Source/JavaScriptCore

2011-06-04 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed, MIPS build fix.

WebKitGTK+ tarball fails to build on MIPS.
https://buildd.debian.org/status/fetch.php?pkg=webkitgtk%2B&arch=mips&ver=1.4.0-1&stamp=1304786691

GNUmakefile.am: Add missing MIPS-related file to the list of files that are added to the tarball on make dist, and fix sorting.

5:37 PM Changeset in webkit [88125] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

2011-06-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez

Update the news file for the 1.4.1 release.

NEWS: Update news.

5:09 PM Changeset in webkit [88124] by kov@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-06-04 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed, MIPS build fix.

WebKitGTK+ tarball fails to build on MIPS.
https://buildd.debian.org/status/fetch.php?pkg=webkitgtk%2B&arch=mips&ver=1.4.0-1&stamp=1304786691

GNUmakefile.list.am: Add missing MIPS-related file to the list of files that are added to the tarball on make dist, and fix sorting.

2:03 PM Changeset in webkit [88123] by Darin Adler

9 edits
2 adds in trunk/Source

2011-06-04 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

[Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
https://bugs.webkit.org/show_bug.cgi?id=62094
rdar://problem/9539204

WebCore.exp.in: Export ResourceHandle::synchronousLoadRunLoopMode.
platform/network/ResourceHandle.h: Add synchronousLoadRunLoopMode.
platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added. (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.
platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added. (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.

2011-06-04 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

[Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
https://bugs.webkit.org/show_bug.cgi?id=62094
rdar://problem/9539204

WebKit2.xcodeproj/project.pbxproj: Added new source files.
WebProcess/mac/CoreIPCClientRunLoop.h: Added.
WebProcess/mac/CoreIPCClientRunLoop.mm: Added. (-[WKFunctionAdapter perform]): Added. (WebKit::createCoreIPCRunLoopModesArray): Added. (WebKit::coreIPCRunLoopModesArray): Added. (WebKit::callOnCoreIPCClientRunLoopAndWait): Added.

WebProcess/mac/KeychainItemShimMethods.mm: (WebKit::webFreeAttributeListContent): Use callOnCoreIPCClientRunLoopAndWait. (WebKit::webFreeKeychainItemContent): Ditto. (WebKit::webSecKeychainItemCopyContent): Ditto. (WebKit::webSecKeychainItemCreateFromContent): Ditto. (WebKit::webSecKeychainItemModifyContent): Ditto.
WebProcess/mac/SecItemShimMethods.mm: (WebKit::webSecItemCopyMatching): Ditto. (WebKit::webSecItemAdd): Ditto. (WebKit::webSecItemUpdate): Ditto. (WebKit::webSecItemDelete): Ditto.

12:34 PM Changeset in webkit [88122] by eric@webkit.org

4 edits in trunk/Source/WebCore

2011-06-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add InlineWalker class to hold state for repeated calls to bidiNext
https://bugs.webkit.org/show_bug.cgi?id=60724

This is one more little step towards removing (naked) bidiNext usage.
More refactoring is required before all callers of bidiNext can move
onto using an InlineWalker instead of bidiNext directly.

No change in behavior, thus no tests.

rendering/InlineIterator.h: (WebCore::InlineWalker::InlineWalker): (WebCore::InlineWalker::root): (WebCore::InlineWalker::current): (WebCore::InlineWalker::atEndOfInline): (WebCore::InlineWalker::atEnd): (WebCore::InlineWalker::advance):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::simplifiedNormalFlowLayout):
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):

12:20 PM Changeset in webkit [88121] by weinig@apple.com

10 edits in trunk/Source

2011-06-04 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
https://bugs.webkit.org/show_bug.cgi?id=62093

Add additional ChromeClient functions to indicate the beginning and end of
the various ScrollAnimator animations. Change existing notification that a
rubber-band has completed for the main frame to be triggered for all frames.

page/ChromeClient.h: (WebCore::ChromeClient::didStartRubberBandForFrame): (WebCore::ChromeClient::didCompleteRubberBandForFrame): (WebCore::ChromeClient::didStartAnimatedScroll): (WebCore::ChromeClient::didCompleteAnimatedScroll):
page/FrameView.cpp: (WebCore::FrameView::didStartRubberBand): (WebCore::FrameView::didCompleteRubberBand): (WebCore::FrameView::didStartAnimatedScroll): (WebCore::FrameView::didCompleteAnimatedScroll):
page/FrameView.h:
platform/ScrollableArea.h: (WebCore::ScrollableArea::didStartRubberBand): (WebCore::ScrollableArea::didStartAnimatedScroll): (WebCore::ScrollableArea::didCompleteAnimatedScroll):
platform/mac/ScrollAnimatorMac.h:
platform/mac/ScrollAnimatorMac.mm: (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (WebCore::ScrollAnimatorMac::scroll): (WebCore::ScrollAnimatorMac::immediateScrollToPointForScrollAnimation): (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

2011-06-04 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
https://bugs.webkit.org/show_bug.cgi?id=62093

Stub out new ChromeClient functions regarding the start and end of ScrollAnimator
animated scrolls, and update logic for rubber-band ending to check for main frame
now that it is called for all frames.

WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didStartRubberBandForFrame): (WebKit::WebChromeClient::didCompleteRubberBandForFrame): (WebKit::WebChromeClient::didStartAnimatedScroll): (WebKit::WebChromeClient::didCompleteAnimatedScroll):
WebProcess/WebCoreSupport/WebChromeClient.h:

11:59 AM Changeset in webkit [88120] by Martin Robinson

2 edits in trunk/Source/WebCore

2011-06-04 Martin Robinson <mrobinson@igalia.com>

Touch a file to try to fix the GTK+ build on the 32-bit bot.

testing/Internals.idl: Touch this IDL file in an effort to fix the build.

11:55 AM Changeset in webkit [88119] by weinig@apple.com

2 edits in trunk/Source/JavaScriptCore

2011-06-04 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix formatting of the output generated by KeywordLookupGenerator.py
https://bugs.webkit.org/show_bug.cgi?id=62083

Uses correct year for copyright.
Puts ending brace on same line as "else if"
Puts starting brace of function on its own line.
Adds some tasteful whitespace.
Adds comments to make clear that scopes are ending
Make macros actually split on two lines.

KeywordLookupGenerator.py:

11:18 AM Changeset in webkit [88118] by Martin Robinson

3 edits in releases/WebKitGTK/webkit-1.4

Merging r87696

10:45 AM Changeset in webkit [88117] by dcheng@chromium.org

8 edits
2 copies in branches/chromium/782

Merge 87848 - 2011-06-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887

fast/events/drag-image-filename-expected.txt: Added.
fast/events/drag-image-filename.html: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2011-06-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887

We try to guess an appropriate filename when dragging out images. In order, we try to use:

The filename suggested in the HTTP header.
The last path component of the source URL.
The alt text. This matches the behavior of the other WebKit ports.

Test: fast/events/drag-image-filename.html

platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
platform/chromium/ClipboardChromiumMac.cpp: (WebCore::isInvalidFileCharacter): (WebCore::ClipboardChromium::validateFileName):

2011-06-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887

DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::dumpFilenameBeingDragged):
DumpRenderTree/chromium/EventSender.h:

TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/7054067

10:23 AM Changeset in webkit [88116] by Martin Robinson

4 edits in trunk

2011-06-04 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build.

bindings/gobject/GNUmakefile.am: Make the GObject build less noisy.

2011-06-04 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build.

GNUmakefile.am: Add some missing newline escape.

10:14 AM Changeset in webkit [88115] by Dimitri Glazkov

10 edits in trunk/Source/WebCore

2011-06-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Convert file <input> to use the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=59005

Refactoring, covered by existing tests.

css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed FILE_UPLOAD_BUTTON pseudoId and all references to it. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
css/CSSSelector.h: Ditto.
css/html.css: (input[type="button"], input[type="submit"], input[type="reset"]): Moved -webkit-file-upload-button to its own rule. (input[type="file"]::-webkit-file-upload-button): Added and moved all previously hard-coded properties there.
html/FileInputType.cpp: (WebCore::UploadButtonElement::create): Added. (WebCore::UploadButtonElement::UploadButtonElement): Added. (WebCore::UploadButtonElement::shadowPseudoId): Added. (WebCore::FileInputType::createShadowSubtree): Added.
html/FileInputType.h: Added createShadowSubtree decl.
page/DragController.cpp: (WebCore::asFileInput): Changed the logic to use new shadow DOM.
rendering/RenderFileUploadControl.cpp: Removed UploadButton class. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed initializer for m_button. (WebCore::RenderFileUploadControl::updateFromElement): Removed attachment logic that's no longer necessary. (WebCore::nodeWidth): Added a helper. (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use uploadButton and nodeWidth. (WebCore::RenderFileUploadControl::paintObject): Ditto. (WebCore::RenderFileUploadControl::uploadButton): Added a helper to retrieve the button. (WebCore::RenderFileUploadControl::buttonValue): Changed to use uploadButton.
rendering/RenderFileUploadControl.h: Changed decls.
rendering/style/RenderStyleConstants.h: Removed FILE_UPLOAD_BUTTON decls.

9:15 AM Changeset in webkit [88114] by kov@webkit.org

7 edits
3 adds in releases/WebKitGTK/webkit-1.4

Merging http://trac.webkit.org/changeset/87523

5:56 AM Changeset in webkit [88113] by abarth@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

KeywordLookupGenerator.py spams stdout in Chromium Linux build
https://bugs.webkit.org/show_bug.cgi?id=62087

This action does not appear to be needed.

JavaScriptCore.gyp/JavaScriptCore.gyp:

5:06 AM Changeset in webkit [88112] by thakis@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make ResourceHandleInternal's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62073

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):

4:35 AM Changeset in webkit [88111] by Laszlo Gombos

2 edits in trunk/LayoutTests

2011-06-04 Laszlo Gombos <Laszlo Gombos>

Reviewed by Andreas Kling.

[Qt] Enable passing File API tests
https://bugs.webkit.org/show_bug.cgi?id=62020

File API has been enabled for QtWebKit in r74115,
let's also enable the passing related tests.

platform/qt/Skipped:

4:23 AM Changeset in webkit [88110] by ap@apple.com

6 edits
1 delete in trunk

2011-06-04 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

Input value sanitization for text fields is incorrect
https://bugs.webkit.org/show_bug.cgi?id=62061
<rdar://problem/9553273>

fast/forms/input-value-sanitization-expected.txt:
fast/forms/input-value-sanitization.html:
fast/forms/paste-multiline-text-input.html:
fast/forms/script-tests/input-value-sanitization.js: Removed.

2011-06-04 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

Input value sanitization for text fields is incorrect
https://bugs.webkit.org/show_bug.cgi?id=62061
<rdar://problem/9553273>

Newline characters should be removed according to HTML5, not replaced with spaces.
This also matches Safari 5 behavior.

html/TextFieldInputType.cpp: (WebCore::isASCIILineBreak): A functor for removeCharacters(). (WebCore::limitLength): Do one thing at once. (WebCore::TextFieldInputType::sanitizeValue): Sanitization removes newlines. (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Moved (somewhat surprising) code that replaces newlines with spaces here.

4:14 AM Changeset in webkit [88109] by thakis@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make ChromePrintContext's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62076

Since WebFrameImpl's m_printContext is a OnwPtr<ChromePrintContext>
that is dynamically set to either a ChromePrintContext or a
ChromePluginPrintContext, this fixes an actual bug.

src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::~ChromePrintContext): (WebKit::ChromePluginPrintContext::~ChromePluginPrintContext):

4:06 AM Changeset in webkit [88108] by thakis@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebTextCheckingCompletionImpl's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62074

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

src/WebTextCheckingCompletionImpl.h: (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):

3:58 AM Changeset in webkit [88107] by thakis@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make PlatformMessagePortChannel's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62072

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

src/PlatformMessagePortChannel.h:

3:50 AM Changeset in webkit [88106] by thakis@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Give VoidCallbackClient a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=62067

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

src/NotificationPresenterImpl.cpp: (WebKit::VoidCallbackClient::~VoidCallbackClient):

3:42 AM Changeset in webkit [88105] by thakis@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebFrameImpl destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62065

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

src/WebFrameImpl.h:

3:32 AM Changeset in webkit [88104] by commit-queue@webkit.org

3 edits
2 adds in trunk

2011-06-04 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Beth Dakin.

Crash in WebCore::RenderMathMLSubSup::baselinePosition()
https://bugs.webkit.org/show_bug.cgi?id=57897

Added simple test that hits the relevant code.

mathml/msubsup-remove-children-expected.txt: Added.
mathml/msubsup-remove-children.xhtml: Added.

2011-06-04 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Beth Dakin.

Crash in WebCore::RenderMathMLSubSup::baselinePosition()
https://bugs.webkit.org/show_bug.cgi?id=57897

Simple patch adding NULL checks in each function.
Test: mathml/msubsup-remove-children.xhtml

rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::stretchToHeight): (WebCore::RenderMathMLSubSup::baselinePosition):

3:24 AM Changeset in webkit [88103] by thakis@chromium.org

2 edits in trunk/Source/WebCore

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

Give IDBBackingStore::Transaction a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=62063

IDBLevelDBBackingStore::createTransaction() hands out a
PassRefPtr<IDBBackingStore::Transaction>, which means the missing
virtual destructor is a real bug.

storage/IDBBackingStore.h: (WebCore::IDBBackingStore::Transaction::~Transaction):

2:53 AM Changeset in webkit [88102] by eae@chromium.org

13 edits in trunk/Source/WebCore

2011-06-04 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::overflowClipRect to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62032

Covered by existing tests.

editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
platform/graphics/IntRect.h: (WebCore::IntRect::contract):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip): (WebCore::RenderBox::overflowClipRect):
rendering/RenderBox.h:
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::repaintBlockSelectionGaps):
rendering/RenderLayerBacking.cpp: (WebCore::clipBox):
rendering/RenderTable.cpp: (WebCore::RenderTable::overflowClipRect): (WebCore::RenderTable::nodeAtPoint):
rendering/RenderTable.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):

2:24 AM Changeset in webkit [88101] by abarth@webkit.org

2 edits in trunk/Source/ThirdParty

glu: Added property svn:ignore.
- For glu.xcodeproj, which is generated from glu.gyp.

2:22 AM Changeset in webkit [88100] by abarth@webkit.org

4 edits in trunk/Source/WebCore

2011-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

V8Proxy::disconnectFrame doesn't do anything
https://bugs.webkit.org/show_bug.cgi?id=62051

Dead code should die.

bindings/v8/ScriptController.cpp: (WebCore::ScriptController::~ScriptController):
bindings/v8/V8Proxy.cpp:
bindings/v8/V8Proxy.h:

2:05 AM Changeset in webkit [88099] by thakis@chromium.org

3 edits in trunk/Source/WebCore

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

Make the destructors of DataTransferItem and DataTransferItems virtual
https://bugs.webkit.org/show_bug.cgi?id=62052

Clang has grown a new warning that warns on |delete ptr| if ptr's
class is non-final, has virtual methods, but no virtual destructor.
This warning finds real bugs, so we want to keep it enabled. However,
it also warns about DataTransferItem[s]. Since these are subclassed,
they can't be made final, so make their destructors virtual. (Maybe
clang's warning even points out an actual bug here.)

dom/DataTransferItem.h: (WebCore::DataTransferItem::~DataTransferItem):
dom/DataTransferItems.h: (WebCore::DataTransferItems::~DataTransferItems):

2:02 AM Changeset in webkit [88098] by thakis@chromium.org

2 edits in trunk/Source/WebCore

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make LayerPainterChromium destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62056

LayerTextureUpdaterCanvas has an OwnPtr<LayerPainterChromium>, which
means that without this patch, the destructor of classes implementing
LayerPainterChromium wasn't called correctly in that case.

platform/graphics/chromium/LayerPainterChromium.h: (WebCore::LayerPainterChromium::~LayerPainterChromium):

1:08 AM Changeset in webkit [88097] by commit-queue@webkit.org

1 edit in trunk/ChangeLog

Configure new commit-queue instance. (Please ignore.)

12:02 AM Changeset in webkit [88096] by eae@chromium.org

2 edits in trunk/Source/WebCore

2011-06-04 Emil A Eklund <eae@chromium.org>

Reviewed by Andreas Kling.

Fix IntRect::expand(const IntSize& size)
https://bugs.webkit.org/show_bug.cgi?id=62042

No new tests.

platform/graphics/IntRect.h: (WebCore::IntRect::expand): Fix IntRect::expand to expand the size rather than move the location. Currently unused.

Jun 3, 2011:

11:45 PM Changeset in webkit [88095] by vangelis@chromium.org

2 edits in trunk/LayoutTests

2011-06-03 Vangelis Kokkevis <vangelis@chromium.org>

Unreviewed. Fixes test expectatations.

[chromium] Fixing redefinitions of test_expectations entries
for chrome gpu tests.

platform/chromium/test_expectations.txt:

11:15 PM Changeset in webkit [88094] by oliver@apple.com

6 edits in trunk/Source/JavaScriptCore

2011-06-03 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Lexer needs to provide Identifier for reserved words
https://bugs.webkit.org/show_bug.cgi?id=62086

Alas it is necessary to provide an Identifier reference for keywords
so that we can do the right thing when they're used in object literals.
We now keep Identifiers for all reserved words in the CommonIdentifiers
structure so that we can access them without a hash lookup.

KeywordLookupGenerator.py:
parser/Lexer.cpp: (JSC::Lexer::parseIdentifier):
parser/Lexer.h:
runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers):
runtime/CommonIdentifiers.h:

10:25 PM Changeset in webkit [88093] by barraclough@apple.com

3 edits in trunk/Source/JavaScriptCore

Add debug code to break on speculation failures.

Reviewed by Sam Weinig.

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileFunction):

dfg/DFGNode.h:

10:13 PM Changeset in webkit [88092] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=62082
DFG JIT - bug passing arguments that need swap

Reviewed by Sam Weinig.

This is really just a typo.
When setting up the arguments for a call out to a C operation, we'll
fail to swap arguments where this is necessary. For example, in the
case of 2 arg calls, where the first argument is in %rdx & the second
is in %rsi we should swap (exec will be passed in %rdi), but we don't.

This can also affect function calls passing three arguments.

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::setupTwoStubArgs):

Call swap with the correct arguments.

9:59 PM Changeset in webkit [88091] by ap@apple.com

2 edits in trunk/Source/WebCore

2011-06-03 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

ResourceHandleMac should always respond to an authentication challenge
https://bugs.webkit.org/show_bug.cgi?id=61667

I don't know if this can actually happen in practice, so no new tests.

platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Cancel authentication challenge if we don't have a client. We must always respond to the challenge to release the connection, and there is nothing else to do in this state anyway.

9:35 PM Changeset in webkit [88090] by mitz@apple.com

3 edits in trunk/Source/WebCore

Try to fix the Apple LLVM Compiler build after r88087.

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintMask):

rendering/RenderTableCell.h:

8:06 PM Changeset in webkit [88089] by crogers@google.com

2 edits in trunk/Source/WebCore

Fix clang build - take 2

7:57 PM Changeset in webkit [88088] by crogers@google.com

2 edits in trunk/Source/WebCore

Fix clang build

7:25 PM Changeset in webkit [88087] by leviw@chromium.org

21 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintMask and paintObject to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62077

Switching paintMask and paintObject to use IntPoint for their paint offset instead of
a pair of ints. paintObject is still on tx/ty, but paintMask was converted to IntSize
passed by value -- bringing it in-line with the agreed-upon convention of a const IntPoint&.

No new tests since this is simple refactoring.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintObject):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::paintMask): (WebCore::RenderBox::pushContentsClip): (WebCore::RenderBox::popContentsClip):
rendering/RenderBox.h: (WebCore::RenderBox::paintObject):
rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask):
rendering/RenderFieldset.h:
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
rendering/RenderFileUploadControl.h:
rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
rendering/RenderListBox.h:
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintMask):
rendering/RenderTable.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::paintObject):
rendering/RenderTableSection.h:
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder): (WebCore::RenderTextControl::paintObject):
rendering/RenderTextControl.h:
rendering/RenderView.cpp: (WebCore::RenderView::paint):
rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):

6:58 PM Changeset in webkit [88086] by cevans@google.com

1 edit
2 copies in branches/chromium/782

Merge 88071
BUG=83743
Review URL: http://codereview.chromium.org/7058060

6:55 PM Changeset in webkit [88085] by cevans@google.com

1 edit
2 copies in branches/chromium/742

Merge 88071
BUG=83743
Review URL: http://codereview.chromium.org/7112025

6:34 PM Changeset in webkit [88084] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

2011-06-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Force inlining of some hot lexer functions
https://bugs.webkit.org/show_bug.cgi?id=62079

Fix more GCC stupidity

parser/Lexer.h: (JSC::Lexer::isWhiteSpace): (JSC::Lexer::isLineTerminator):

5:43 PM Changeset in webkit [88083] by oliver@apple.com

4 edits in trunk/Source/JavaScriptCore

2011-06-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

GCC not inlining some functions that it really should be
https://bugs.webkit.org/show_bug.cgi?id=62075

Add ALWAYS_INLINE to a number of parsing and lexing functions
that should always be inlined. This gets us ~1.4% on my ad hoc
parser test.

KeywordLookupGenerator.py:
parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::nextTokenIsColon): (JSC::JSParser::consume): (JSC::JSParser::match): (JSC::JSParser::tokenStart): (JSC::JSParser::tokenLine): (JSC::JSParser::tokenEnd):
parser/Lexer.cpp: (JSC::isIdentPart):

5:39 PM Changeset in webkit [88082] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Whoops, fix last minute bug.

5:22 PM Changeset in webkit [88081] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

2011-06-03 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Support FontCustomPlatformData on Skia-Mac-Chrome variant
https://bugs.webkit.org/show_bug.cgi?id=62040

Canvas text is only recognized by Skia if it is registered
by creating a new SkTypeface. Skia uses CGFont to measure
and render the glyphs, then takes care of managing the glyph
cache.

Skia on Mac Chrome is not yet enabled, so this change
does not affect existing code, and requires no new tests.

platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::RemoteFontStream::RemoteFontStream): (WebCore::RemoteFontStream::~RemoteFontStream): (WebCore::RemoteFontStream::rewind): (WebCore::RemoteFontStream::read): Turn the buffer into a stream. This is identical to the implementation in skia/FontCustomPlatformData.cpp. While that file could be modified instead of this one, it was simpler to add SkTypeface streaming to this instead of adding all CGFont support to the skia platform file.

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
Release the SkTypeface reference.

(WebCore::createFontCustomPlatformData):
Associate the buffer stream with a SkTypeface so Skia
can find the custom font data.

platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Add a slot to hold the SkTypeface.

5:16 PM Changeset in webkit [88080] by sfalken@apple.com

2 edits in trunk/Source/WebCore

2011-06-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Brian Weinstein.

HistoryItem children persist across page loads
https://bugs.webkit.org/show_bug.cgi?id=62071
<rdar://problem/9552129>

Not testable since there's no way to check for the presence/absence
of children for a HistoryItem.

history/HistoryItem.cpp: (WebCore::HistoryItem::reset): Call clearChildren when we're reusing a HistoryItem.

5:09 PM Changeset in webkit [88079] by jamesr@google.com

2 edits in trunk/LayoutTests

2011-06-03 James Robinson <jamesr@chromium.org>

[chromium] Mark GPU-only expectations as GPU.

platform/chromium/test_expectations.txt:

4:57 PM Changeset in webkit [88078] by Martin Robinson

5 edits in trunk

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Try to fix the GTK+ build.

GNUmakefile.am: Clean up some spaces that should be tabs.
GNUmakefile.list.am: Add KeywordLookup.h to the source list and clean up some spaces that should be tabs.

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Try to fix the GTK+ bulid.

GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals source list.

4:53 PM Changeset in webkit [88077] by scherkus@chromium.org

36 edits in trunk/LayoutTests

2011-06-03 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, rebaselining Chromium GPU media pixel results after Chromium commit 87830.

platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
platform/chromium-gpu-linux/media/controls-strict-expected.png:
platform/chromium-gpu-linux/media/controls-styling-expected.png:
platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png:
platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
platform/chromium-gpu-linux/media/video-no-audio-expected.png:
platform/chromium-gpu-linux/media/video-transformed-expected.png:
platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
platform/chromium-gpu-mac/media/controls-strict-expected.png:
platform/chromium-gpu-mac/media/controls-styling-expected.png:
platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png:
platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
platform/chromium-gpu-mac/media/video-layer-crash-expected.png:
platform/chromium-gpu-mac/media/video-no-audio-expected.png:
platform/chromium-gpu-mac/media/video-transformed-expected.png:
platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
platform/chromium-gpu-win/media/controls-after-reload-expected.png:
platform/chromium-gpu-win/media/controls-strict-expected.png:
platform/chromium-gpu-win/media/controls-styling-expected.png:
platform/chromium-gpu-win/media/controls-without-preload-expected.png:
platform/chromium-gpu-win/media/video-aspect-ratio-expected.png:
platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
platform/chromium-gpu-win/media/video-display-toggle-expected.png:
platform/chromium-gpu-win/media/video-layer-crash-expected.png:
platform/chromium-gpu-win/media/video-no-audio-expected.png:
platform/chromium-gpu-win/media/video-transformed-expected.png:
platform/chromium-gpu-win/media/video-volume-slider-expected.png:
platform/chromium-gpu-win/media/video-zoom-controls-expected.png:

4:30 PM Changeset in webkit [88076] by oliver@apple.com

10 edits
1 add in trunk/Source/JavaScriptCore

2011-06-03 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Improve keyword lookup
https://bugs.webkit.org/show_bug.cgi?id=61913

Rather than doing multiple hash lookups as we currently
do when trying to identify keywords we now use an
automatically generated decision tree (essentially it's
a hard coded patricia trie). We still use the regular
lookup table for the last few characters of an input as
this allows us to completely skip all bounds checks.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pro:
GNUmakefile.am:
JavaScriptCore.gyp/JavaScriptCore.gyp:
JavaScriptCore.xcodeproj/project.pbxproj:
KeywordLookupGenerator.py: Added.
make-generated-sources.sh:
parser/Lexer.cpp: (JSC::Lexer::internalShift): (JSC::Lexer::shift): (JSC::Lexer::parseIdentifier):
parser/Lexer.h:

4:29 PM Changeset in webkit [88075] by beidson@apple.com

2 edits in trunk/Source/WebKit2

<rdar://problem/9553645> and https://bugs.webkit.org/show_bug.cgi?id=62064
WebBackForwardListItem::setBackForwardData actually appends data

Reviewed by Steve Falkenburg.

Shared/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::setBackForwardData): Clear the Vector out before appending

the replacement data.

4:03 PM Changeset in webkit [88074] by crogers@google.com

8 edits in trunk/Source/WebCore

2011-06-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Allow existing AudioParams to use scheduled parameter changes
https://bugs.webkit.org/show_bug.cgi?id=62046

No new tests since audio API is not yet implemented.

platform/audio/AudioBus.cpp: (WebCore::AudioBus::processWithGainFrom): (WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom):
platform/audio/AudioBus.h:
webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
webaudio/AudioGainNode.cpp: (WebCore::AudioGainNode::AudioGainNode): (WebCore::AudioGainNode::process):
webaudio/AudioGainNode.h:
webaudio/HighPass2FilterNode.cpp: (WebCore::HighPass2FilterNode::HighPass2FilterNode):
webaudio/LowPass2FilterNode.cpp: (WebCore::LowPass2FilterNode::LowPass2FilterNode):

4:02 PM Changeset in webkit [88073] by dpranke@chromium.org

5 edits in trunk

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, merge in downstream lines from Chromium as part of
landing the fix for bug 61888.

platform/chromium/test_expectations.txt:

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

nrwt: should skip chromium test expectation overrides on upstream bots
https://bugs.webkit.org/show_bug.cgi?id=61888

Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

3:52 PM Changeset in webkit [88072] by crogers@google.com

3 edits in trunk/Source/WebCore

2011-06-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Biquad filter coefficient naming is incorrect
https://bugs.webkit.org/show_bug.cgi?id=62053

No new tests since audio API is not yet implemented.

platform/audio/Biquad.cpp: (WebCore::Biquad::Biquad): (WebCore::Biquad::process): (WebCore::Biquad::processFast): (WebCore::Biquad::setLowpassParams): (WebCore::Biquad::setHighpassParams): (WebCore::Biquad::setLowShelfParams): (WebCore::Biquad::setZeroPolePairs):
platform/audio/Biquad.h:

3:42 PM Changeset in webkit [88071] by abarth@webkit.org

3 edits
2 adds in trunk

2011-06-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

DOMWindow::setLocation doesn't understand that DOMWindow can be inactive
https://bugs.webkit.org/show_bug.cgi?id=62057

Test that some esoteric combination of eval, load, and Location don't
do something goofy.

http/tests/security/xss-DENIED-contentWindow-eval-expected.txt: Added.
http/tests/security/xss-DENIED-contentWindow-eval.html: Added.

2011-06-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

DOMWindow::setLocation doesn't understand that DOMWindow can be inactive
https://bugs.webkit.org/show_bug.cgi?id=62057

This code gets confused when dealing with inactive DOMWindows. We
should just block inactive DOMWindows because there's no compatibility
reason to support them in this code path.

Test: http/tests/security/xss-DENIED-contentWindow-eval.html

page/DOMWindow.cpp: (WebCore::DOMWindow::isInsecureScriptAccess):

3:38 PM QtWebKitFeatures22 edited by Laszlo Gombos

(diff)

3:34 PM Changeset in webkit [88070] by dpranke@chromium.org

3 edits in trunk/Tools

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: minor logging, code cleanup
https://bugs.webkit.org/show_bug.cgi?id=62055

Scripts/webkitpy/layout_tests/layout_package/manager.py:
Scripts/webkitpy/layout_tests/layout_package/worker.py:

3:22 PM Changeset in webkit [88069] by Martin Robinson

2 edits in trunk/Tools

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Try to fix the build failure on the GTK+ 32-bit Release bot.

GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.

3:14 PM Changeset in webkit [88068] by simonjam@chromium.org

2 edits
1 add in trunk/LayoutTests

2011-06-03 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, baseline for full-screen-placeholder. More flakiness for svg/zoom and navigator.

platform/chromium-win/fullscreen/full-screen-placeholder-expected.txt: Added.
platform/chromium/test_expectations.txt:

3:03 PM Changeset in webkit [88067] by enne@google.com

2 edits in branches/chromium/782/Source

Merge 87868 - 2011-06-01 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix syncing of removed mask and replica layers
https://bugs.webkit.org/show_bug.cgi?id=61895

platform/graphics/chromium/TreeSynchronizer.cpp: (WebCore::TreeSynchronizer::synchronizeTreeRecursive):

2011-06-01 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix syncing of removed mask and replica layers
https://bugs.webkit.org/show_bug.cgi?id=61895

tests/TreeSynchronizerTest.cpp: (WebCore::TEST):

TBR=enne@google.com

2:55 PM Changeset in webkit [88066] by Martin Robinson

22 edits in trunk

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Unskip tests which are now passing and update results for other tests
which vary depending on smart replace support.

platform/gtk/Skipped: Unskip tests which are now passing.
platform/gtk/editing/deleting/smart-delete-003-expected.txt:
platform/gtk/editing/deleting/smart-delete-004-expected.txt:
platform/gtk/editing/pasteboard/4944770-2-expected.txt:
platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
platform/gtk/fast/lists/drag-into-marker-expected.txt:

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Add smart replace support to WebCore and add hooks for it in WebKit
via DumpRenderTreeSupportGtk. When a platform supports smart replace,
WebCore will remove extra spaces that appear when pasting text. Eventually
WebKitGTK+ may want to expose this in the public API.

platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection): Now pass whether or not to use smart replace when calling writeSelection. (WebCore::Pasteboard::canSmartReplace): Added an implementation that checks the clipboard for whether or not it supports smart paste.
platform/gtk/PasteboardHelper.cpp: (WebCore::initGdkAtoms): Added initialization for smart replace atom. (WebCore::PasteboardHelper::fillSelectionData): Added no-op handler for smart replace atom. (WebCore::PasteboardHelper::targetListForDataObject): Properly handle new smart replace parameter. (WebCore::PasteboardHelper::writeClipboardContents): Properly handle new smart replace parameter. (WebCore::PasteboardHelper::clipboardContentSupportsSmartReplace): Added helper for Pasteboard.
platform/gtk/PasteboardHelper.h: Add new method definition.

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Add the EditorClient and DumpRenderTreeSupportGtk hooks for enabling
smart replace in the tests.

WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): targeListForDataObject now takes another parameter determining whether or not to add smart paste support. Add it here.
WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled): Added.
WebCoreSupport/DumpRenderTreeSupportGtk.h: Add new method definition.
WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::toggleSmartInsertDelete): Added implementation. (WebKit::EditorClient::smartInsertDeleteEnabled): Added. (WebKit::EditorClient::EditorClient):
WebCoreSupport/EditorClientGtk.h: Add new method definition.

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
This is required to produce consistent test results.

DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this methods which calls into DumpRenderTreeSupportGtk.

2:53 PM Changeset in webkit [88065] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/qt

2011-06-03 Rafael Brandao <rafael.lobo@openbossa.org>

Reviewed by Andreas Kling.

[Qt] It made two Qt API tests fail
https://bugs.webkit.org/show_bug.cgi?id=58847

Modified failing test's base url so it could get a valid origin
and make use of local storage. Also added another test that checks
local storage visibility in both scenarios.

tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::testOptionalJSObjects): (checkLocalStorageVisibility): (tst_QWebPage::testLocalStorageVisibility):

2:49 PM Changeset in webkit [88064] by scherkus@chromium.org

2 edits in trunk/LayoutTests

2011-06-03 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, updating media/video-display-aspect-ratio.html expectations for Chromium.

platform/chromium/test_expectations.txt:

2:45 PM Changeset in webkit [88063] by leviw@chromium.org

3 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintCell to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62033

Switching paintCell to take an IntPoint representing the paint offset
instead of a pair of ints.

No new tests since this is simple refactoring.

rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintCell): (WebCore::RenderTableSection::paintObject):
rendering/RenderTableSection.h:

2:39 PM Changeset in webkit [88062] by Martin Robinson

9 edits in trunk

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dimitri Glazkov.

Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071

Source/autotools/symbols.filter: Added some symbols necessary for window.internals to function to the global symbol list.

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dimitri Glazkov.

Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071

platform/gtk/Skipped: Unskip the one new window.internals test.

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dimitri Glazkov.

Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071

GNUmakefile.am: Add new internals directories to the VPATH (for idl processing) and the include list.

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dimitri Glazkov.

Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071

DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): Inject the new internals object when the window object clears.
GNUmakefile.am: Add new source files and includes necessary for window.internals. Also do a little bit of cleanup.

2:37 PM Changeset in webkit [88061] by Lucas Forschler

5 edits in branches/safari-534-branch/Source

Versioning.

2:34 PM Changeset in webkit [88060] by Lucas Forschler

1 copy in tags/Safari-534.43

New tag.

2:33 PM Changeset in webkit [88059] by Lucas Forschler

1 delete in tags/Safari-534.43

remove tag.

2:33 PM Changeset in webkit [88058] by Lucas Forschler

1 delete in tags/Safari-534.43/safari-534-branch

remove tag.

2:31 PM Changeset in webkit [88057] by Lucas Forschler

1 copy in tags/Safari-534.43/safari-534-branch

New tag.

2:31 PM Changeset in webkit [88056] by Lucas Forschler

8 edits in branches/safari-534-branch/Source/WebKit2

Merge r87839.

2:26 PM Changeset in webkit [88055] by Lucas Forschler

1 copy in tags/Safari-534.43

New tag.

2:26 PM Changeset in webkit [88054] by Laszlo Gombos

2 edits in trunk/LayoutTests

2011-06-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Antonio Gomes.

[Qt] Enable ArrayBuffer passing tests as ArrayBuffer is enabled by default
https://bugs.webkit.org/show_bug.cgi?id=62025

platform/qt/Skipped:

2:24 PM Changeset in webkit [88053] by scherkus@chromium.org

1 edit
1 add in trunk/LayoutTests

2011-06-03 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, adding Ogg Theora version of media/content/test-par-16-9.mp4.

media/content/test-par-16-9.ogv: Added.

2:02 PM Changeset in webkit [88052] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebKit/qt

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Warning fixes on comparisons between a signed and an unsigned.

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo): (DumpRenderTreeSupportQt::nodesFromRect):

1:59 PM Changeset in webkit [88051] by leviw@chromium.org

5 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintBackgroundsBehindCell to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62031

Switching paintBackgroundsBehindCell to take an IntPoint representing
the paint offset instead of a pair of ints.

No new tests as this is simple refactoring.

rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
rendering/RenderTableCell.h:
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintCell):

1:57 PM Changeset in webkit [88050] by leviw@chromium.org

5 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintCaret and paintDragCaret to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62037

Switching paintCaret and paintDragCaret to use an IntPoint representing
the paint offset instead of a pair of ints.

No new tests since this is simple refactoring.

editing/FrameSelection.cpp: (WebCore::FrameSelection::paintCaret): (WebCore::CaretBase::paintCaret): (WebCore::DragCaretController::paintDragCaret):
editing/FrameSelection.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::positionForPoint): (WebCore::RenderBlock::offsetForContents):
rendering/RenderBlock.h:

1:55 PM Changeset in webkit [88049] by leviw@chromium.org

3 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintItemForeground and paintItemForeground to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62035

Switching paintItemFore/Background to use IntPoint instead of a pair of ints.

No new tests since this is simple refactoring.

rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground):
rendering/RenderListBox.h:

1:53 PM Changeset in webkit [88048] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-06-03 Anders Carlsson <andersca@apple.com>

Reviewed by Brady Eidson.

Disable the sync message timeout for the Microsoft SharePoint plug-in
https://bugs.webkit.org/show_bug.cgi?id=62043
<rdar://problem/9536303>

WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::defaultSyncMessageTimeout):

1:49 PM Changeset in webkit [88047] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change. Fix conflict in expectations.

platform/chromium/test_expectations.txt:

1:35 PM Changeset in webkit [88046] by andreas.kling@nokia.com

2 edits in trunk/Source/WebKit2

2011-06-03 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] TiledDrawingArea: Initialize tiles to transparent.

UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::incorporateUpdate): When constructing new back buffers, fill them with transparent pixels.

1:32 PM Changeset in webkit [88045] by alexis.menard@openbossa.org

4 edits in trunk/Source

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.

WebCoreSupport/FrameLoaderClientQt.h:

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.

platform/network/qt/QtMIMETypeSniffer.h:

1:29 PM Changeset in webkit [88044] by mnaganov@chromium.org

1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed test expectations update for inspector/profiler/cpu-profiler-profiling* on Linux. https://bugs.webkit.org/show_bug.cgi?id=61533

1:28 PM Changeset in webkit [88043] by kov@webkit.org

6 edits in releases/WebKitGTK/webkit-1.4

Merging http://trac.webkit.org/changeset/85207

1:22 PM Changeset in webkit [88042] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-1.4

http://trac.webkit.org/changeset/86084

1:07 PM Changeset in webkit [88041] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebKit/qt

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed build fix after r87902.

To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE but
only on classes inside Qt.

WebCoreSupport/DumpRenderTreeSupportQt.h:

12:43 PM Changeset in webkit [88040] by dpranke@chromium.org

3 edits in trunk/Tools

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Worker may not be stopped after LT.
https://bugs.webkit.org/show_bug.cgi?id=61847

Re-submit a variant of the first fix for this bug. It's possible
that actually calling cleanup() in the worker threads was taking
too long and we triggered the assertions in the manager thread.

I've bumped up the timeout in the manager and added better
diagnostics. I also cleaned up the cleanup() code a bit because
there was some unnecessary if-checks.

Scripts/webkitpy/layout_tests/layout_package/manager.py:
Scripts/webkitpy/layout_tests/layout_package/worker.py:

12:35 PM Changeset in webkit [88039] by rwlbuis@webkit.org

5 edits in trunk/Source/WebCore

2011-06-03 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Cleanup member variable usage in svg/animation classes
https://bugs.webkit.org/show_bug.cgi?id=62029

Cleanup member variables.

svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::SMILTimeContainer): (WebCore::SMILTimeContainer::sampleAnimationAtTime): (WebCore::SMILTimeContainer::updateAnimations):
svg/animation/SMILTimeContainer.h:
svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::SVGSMILElement):
svg/animation/SVGSMILElement.h:

12:18 PM Changeset in webkit [88038] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebKit/qt

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

Some warning fixes. Values in switch not handled, and
a comparison between a signed and an unsigned.

Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::action):

12:17 PM Changeset in webkit [88037] by crogers@google.com

6 edits
2 adds in trunk/Source/WebCore

2011-06-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioParam parameter scheduling implementation
https://bugs.webkit.org/show_bug.cgi?id=61830

No new tests since audio API is not yet implemented.

WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
webaudio/AudioParam.cpp: (WebCore::AudioParam::value): (WebCore::AudioParam::smoothedValue): (WebCore::AudioParam::smooth): (WebCore::AudioParam::calculateSampleAccurateValues):
webaudio/AudioParam.h: (WebCore::AudioParam::setContext): (WebCore::AudioParam::context): (WebCore::AudioParam::setValueAtTime): (WebCore::AudioParam::linearRampToValueAtTime): (WebCore::AudioParam::exponentialRampToValueAtTime): (WebCore::AudioParam::setTargetValueAtTime): (WebCore::AudioParam::setValueCurveAtTime): (WebCore::AudioParam::cancelScheduledValues): (WebCore::AudioParam::hasTimelineValues):
webaudio/AudioParam.idl:
webaudio/AudioParamTimeline.cpp: Added. (WebCore::AudioParamTimeline::setValueAtTime): (WebCore::AudioParamTimeline::linearRampToValueAtTime): (WebCore::AudioParamTimeline::exponentialRampToValueAtTime): (WebCore::AudioParamTimeline::setTargetValueAtTime): (WebCore::AudioParamTimeline::setValueCurveAtTime): (WebCore::isValidNumber): (WebCore::AudioParamTimeline::insertEvent): (WebCore::AudioParamTimeline::cancelScheduledValues): (WebCore::AudioParamTimeline::valueForContextTime): (WebCore::AudioParamTimeline::valuesForTimeRange): (WebCore::timeToSampleFrame): (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
webaudio/AudioParamTimeline.h: Added. (WebCore::AudioParamTimeline::AudioParamTimeline): (WebCore::AudioParamTimeline::hasValues): (WebCore::AudioParamTimeline::ParamEvent::ParamEvent): (WebCore::AudioParamTimeline::ParamEvent::type): (WebCore::AudioParamTimeline::ParamEvent::value): (WebCore::AudioParamTimeline::ParamEvent::time): (WebCore::AudioParamTimeline::ParamEvent::timeConstant): (WebCore::AudioParamTimeline::ParamEvent::duration): (WebCore::AudioParamTimeline::ParamEvent::curve):

12:05 PM QtWebKitFeatures22 edited by Ademar Reis

(diff)

12:03 PM QtWebKitFeatures22 edited by Ademar Reis

(diff)

12:02 PM QtWebKitFeatures22 edited by Ademar Reis

(diff)

12:02 PM Changeset in webkit [88036] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging http://trac.webkit.org/changeset/87366

12:00 PM Changeset in webkit [88035] by dpranke@chromium.org

2 edits in trunk/Tools

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: fix duplicate logging regression
https://bugs.webkit.org/show_bug.cgi?id=61981

Scripts/webkitpy/layout_tests/layout_package/printing.py:

11:57 AM QtWebKitFeatures22 edited by Ademar Reis

(diff)

11:51 AM QtWebKitFeatures22 edited by Ademar Reis

(diff)

11:48 AM Changeset in webkit [88034] by jer.noble@apple.com

7 edits
2 adds in trunk

2011-06-01 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Flash of broken page when exiting full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61897
<rdar://problem/9522985>

fullscreen/full-screen-placeholder-expected.txt: Added.
fullscreen/full-screen-placeholder.html: Added.

2011-06-01 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Flash of broken page when exiting full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61897
<rdar://problem/9522985>

Test: fullscreen/full-screen-placeholder.html

Entering full-screen mode is causing the page layout to change because the full-screen
element is taken out of the normal flow. To counteract this effect, insert a placeholder
block as a parent of the full-screen renderer with the same size and style as the full-screen
element pre-full-screen.

Only create a placeholder for block-level elements; the technique required for inline elements
would be vastly more complicated.

dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): Create a placeholder

based on the size and style of the full-screen element.

(WebCore::Document::setFullScreenRenderer): Persist the placeholder size and

style across new renderers.

rendering/RenderFullScreen.cpp: (RenderFullScreen::RenderFullScreen): Added ivar. (RenderFullScreen::destroy): Make sure to safely destroy our placeholder. (RenderFullScreen::createPlaceholder): Added.
rendering/RenderFullScreen.h: (WebCore::RenderFullScreen::placeholder): Ivar accessor.

11:43 AM Changeset in webkit [88033] by leviw@chromium.org

17 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintBoxDecorations to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61968

Switching paintBoxDecorations to take an IntPoint representing
the paint offset instead of a pair of ints. Also cleaning up
some duplicated code in InlineFlowBox related to constraining
the paint rect to the linetop and linebottom.

No new tests since this is just refactoring.

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded): Added to remove duplicate code in paintBoxDecorations and paintMask. (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
rendering/InlineFlowBox.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations):
rendering/RenderBox.h:
rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
rendering/RenderFieldset.h:
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintBoxDecorations):
rendering/RenderTable.h:
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
rendering/RenderTableCell.h:
rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
rendering/RenderView.h:
rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):

11:37 AM QtWebKitFeatures22 edited by Ademar Reis

(diff)

11:33 AM Changeset in webkit [88032] by commit-queue@webkit.org

4 edits in trunk

2011-06-03 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Adam Barth.

Removed test_expectations failure entry for BUGCR36415 as is fixed
with patch in https://bugs.webkit.org/show_bug.cgi?id=62016

platform/chromium/test_expectations.txt:

2011-06-03 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Adam Barth.

Modified addTouchPoint to correctly re-use touchPoint id values starting
from the lowest not-un-use touchPoint id as is done by the embedder
APIs. (Fixes BUGCR36415)

https://bugs.webkit.org/show_bug.cgi?id=62016

DumpRenderTree/chromium/EventSender.cpp: (EventSender::addTouchPoint):

11:22 AM Changeset in webkit [88031] by simonjam@chromium.org

1 edit
5 adds in trunk/LayoutTests

2011-06-03 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, pixel baselines for selectlist-minsize.html.

platform/chromium-linux/fast/forms/selectlist-minsize-expected.png: Added.
platform/chromium-linux/fast/forms/selectlist-minsize-expected.txt: Added.
platform/chromium-mac/fast/forms/selectlist-minsize-expected.png: Added.
platform/chromium-win/fast/forms/selectlist-minsize-expected.png: Added.
platform/chromium-win/fast/forms/selectlist-minsize-expected.txt: Added.

10:39 AM Changeset in webkit [88030] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/chromium

2011-06-03 Philippe Beauchamp <philippe.beauchamp@gmail.com>

Reviewed by Dimitri Glazkov.

Add the feature "Add as search engine..." in a search text field context menu for chromium
https://bugs.webkit.org/show_bug.cgi?id=47980

public/WebContextMenuData.h:
public/WebSearchableFormData.h:
src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
src/WebSearchableFormData.cpp: (WebKit::WebSearchableFormData::WebSearchableFormData):

10:03 AM Changeset in webkit [88029] by commit-queue@webkit.org

28 edits
3 adds in trunk

2011-06-03 Doreen Jiang <doreen.jiang@nokia.com>

Reviewed by Benjamin Poulain.

[Qt]The minimum size of the select menu list is incorrect for qtwebkit
https://bugs.webkit.org/show_bug.cgi?id=56752

The test is to get the render tree of select menu lists with varying widths based on content.
Some select list based tests are rebaselined because minimum width of RenderMenuList changes
based on the content with this fix.

fast/forms/selectlist-minsize.html: Added.
platform/mac/fast/forms/selectlist-minsize-expected.txt: Added.
platform/qt/editing/pasteboard/4641033-expected.txt:
platform/qt/editing/pasteboard/4944770-1-expected.txt:
platform/qt/editing/pasteboard/4944770-2-expected.txt:
platform/qt/editing/selection/caret-before-select-expected.txt:
platform/qt/fast/forms/003-expected.txt:
platform/qt/fast/forms/004-expected.txt:
platform/qt/fast/forms/HTMLOptionElement_label06-expected.txt:
platform/qt/fast/forms/HTMLOptionElement_label07-expected.txt:
platform/qt/fast/forms/basic-selects-expected.txt:
platform/qt/fast/forms/menulist-deselect-update-expected.txt:
platform/qt/fast/forms/menulist-separator-painting-expected.txt:
platform/qt/fast/forms/menulist-style-color-expected.txt:
platform/qt/fast/forms/option-script-expected.txt:
platform/qt/fast/forms/select-background-none-expected.txt:
platform/qt/fast/forms/select-baseline-expected.txt:
platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt:
platform/qt/fast/forms/select-empty-option-height-expected.txt:
platform/qt/fast/forms/select-size-expected.txt:
platform/qt/fast/forms/select-style-expected.txt:
platform/qt/fast/forms/selectlist-minsize-expected.txt: Added.
platform/qt/fast/invalid/014-expected.txt:
platform/qt/fast/replaced/replaced-breaking-expected.txt:
platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
platform/qt/fast/replaced/three-selects-break-expected.txt:
platform/qt/tables/mozilla/bugs/bug29326-expected.txt:
platform/qt/tables/mozilla/core/margins-expected.txt:

2011-06-03 Doreen Jiang <doreen.jiang@nokia.com>

Reviewed by Benjamin Poulain.

[Qt]The minimum size of the select menu list is incorrect for qtwebkit
https://bugs.webkit.org/show_bug.cgi?id=56752

The minimum width of the select-box is calculated to be as small as possible
instead of hardcoded value (width of 7 characters) in minimumMenuListSize() function
This will avoid overapping the select lists in popular websites.

Test: fast/forms/selectlist-minsize.html

platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::minimumMenuListSize):

10:00 AM Changeset in webkit [88028] by bulach@chromium.org

2 edits in trunk/LayoutTests

2011-06-03 Marcus Bulach <bulach@chromium.org>

Reviewed by Unreviewed rebaseline.

[chromium] Rebaseline following r88020
https://bugs.webkit.org/show_bug.cgi?id=62028

platform/chromium/fast/dom/prototype-inheritance-expected.txt:

9:54 AM Changeset in webkit [88027] by andreas.kling@nokia.com

3 edits in trunk/Source/WebKit2

2011-06-03 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt][WK2] Make tiling on WebKit2 more responsive.
https://bugs.webkit.org/show_bug.cgi?id=50064

Instead of creating and destroying pixmaps, and copying them using QPixmap::copy()
or relying on the implicit sharing functionality, we keep the QPixmaps alive
and just make sure their content is synchronized.

This seems to improve responsiveness noticably, as now the UI process doesn't deal
with allocating/deallocating pixmaps, and the copies are done with the optimized
path (QPainter) vs the unoptimized ones (QPixmap::copy().)

UIProcess/TiledDrawingAreaTile.h:
UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile): (WebKit::TiledDrawingAreaTile::isReadyToPaint): (WebKit::TiledDrawingAreaTile::hasReadyBackBuffer): (WebKit::TiledDrawingAreaTile::swapBackBufferToFront): (WebKit::TiledDrawingAreaTile::incorporateUpdate):

9:26 AM Changeset in webkit [88026] by Dimitri Glazkov

6 edits in trunk

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Prevent event dispatch for events with related target when host is the target.
https://bugs.webkit.org/show_bug.cgi?id=61979

fast/events/shadow-boundary-crossing-expected.txt: Added test.
fast/events/shadow-boundary-crossing.html: Added expectations.

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Prevent event dispatch for events with related target when host is the target.
https://bugs.webkit.org/show_bug.cgi?id=61979

Turns out, even if we trim the ancestor chain to 0, the event is still dispatched during AT_TARGET.
So might as well be explicit about what we are trying to do and add a flag to prevent dispatch in these cases.

dom/EventDispatcher.cpp: (WebCore::EventDispatcher::adjustToShadowBoundaries): Added preventing dispatch when the ancestor chain is trimmed to nothing. (WebCore::EventDispatcher::EventDispatcher): Added initializer. (WebCore::EventDispatcher::dispatchEvent): Added a check to prevent dispatch.
dom/EventDispatcher.h: Added a def.

9:24 AM Changeset in webkit [88025] by mario@webkit.org

1 edit
7 adds in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, new baselines for GTK after r88007 and r8009.

platform/gtk/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
platform/gtk/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
platform/gtk/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
platform/gtk/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.

9:14 AM Changeset in webkit [88024] by mario@webkit.org

1 edit
6 adds in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, new baselines for GTK after r88011.

platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.

9:08 AM Changeset in webkit [88023] by mitz@apple.com

2 edits in trunk/Source/WebCore

Mac build fix.

WebCore.xcodeproj/project.pbxproj:

9:07 AM Changeset in webkit [88022] by mario@webkit.org

6 edits
5 adds in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, tests rebaselines for GTK after r88011.

platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.

9:00 AM Changeset in webkit [88021] by commit-queue@webkit.org

9 edits
1 add in trunk/Source

2011-06-03 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Eric Seidel.

[Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
https://bugs.webkit.org/show_bug.cgi?id=61260
http://code.google.com/p/chromium/issues/detail?id=12721

Manual test: select-popup-tooltip-test.html

manual-tests/select-popup-tooltip-test.html: Added.
platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::getSelectedItemToolTip): Get selected item tooltip string according to hovering mouse position.
platform/chromium/PopupMenuChromium.h: Add getSelectedItemToolTip() declaration.

2011-06-03 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Eric Seidel.

[Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
https://bugs.webkit.org/show_bug.cgi?id=61260
http://code.google.com/p/chromium/issues/detail?id=12721

public/WebMenuItemInfo.h: Add toolTip.
public/WebViewClient.h: Remove setToolTipText().
public/WebWidgetClient.h: Add setTooTipText(). (WebKit::WebWidgetClient::setToolTipText):
src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::getPopupMenuInfo): Add popupItem.toolTip set.
src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::MouseMove): Call setToolTipText().

8:45 AM Changeset in webkit [88020] by rwlbuis@webkit.org

15 edits in trunk

2011-06-03 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Creating <animateMotion> elements via javascript do not execute
https://bugs.webkit.org/show_bug.cgi?id=34301

Update test results.

fast/dom/Window/window-properties-expected.txt:
fast/dom/Window/window-property-descriptors-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/dom/prototype-inheritance-expected.txt:
fast/js/global-constructors-expected.txt:
svg/custom/global-constructors-expected.txt:

2011-06-03 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Creating <animateMotion> elements via javascript do not execute
https://bugs.webkit.org/show_bug.cgi?id=34301

Enable constructors for SVGMPathElement and SVGAnimateMotionElement.

DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
page/DOMWindow.idl:

8:37 AM BuildingQtOnLinux edited by siddharth.mathur@nokia.com

added note on ICU (diff)

8:02 AM Changeset in webkit [88019] by hans@chromium.org

6 edits in trunk/Source

2011-06-03 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=62009

This constant should only be needed inside IDBLevelDBCoding.cpp.

No new functionality, no new tests.

storage/IDBLevelDBBackingStore.cpp: (WebCore::getNewDatabaseId): (WebCore::IDBLevelDBBackingStore::getObjectStores): (WebCore::getNewObjectStoreId): (WebCore::IDBLevelDBBackingStore::deleteObjectStore): (WebCore::getNewIndexId):
storage/IDBLevelDBCoding.cpp: (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::IndexFreeListKey::encodeMaxKey):
storage/IDBLevelDBCoding.h:

2011-06-03 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=62009

Don't use INT64_MAX, use the various encodeMaxKey() functions instead.

tests/IDBLevelDBCodingTest.cpp: (IDBLevelDBCoding::TEST):

7:58 AM Changeset in webkit [88018] by bulach@chromium.org

2 edits
11 adds in trunk/LayoutTests

2011-06-03 Marcus Bulach <bulach@chromium.org>

Reviewed by Unreviewed rebaseline.

[chromium] Rebaseline following r88007-88008
https://bugs.webkit.org/show_bug.cgi?id=62018

platform/chromium-linux-x86/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
platform/chromium-linux-x86/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
platform/chromium-linux/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
platform/chromium-win/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
platform/chromium-win/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
platform/chromium/test_expectations.txt:

7:53 AM Changeset in webkit [88017] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88014.
http://trac.webkit.org/changeset/88014
https://bugs.webkit.org/show_bug.cgi?id=62017

Broken EFL build (Requested by tonikitoo on #webkit).

WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload):

7:47 AM Changeset in webkit [88016] by commit-queue@webkit.org

11 edits
1 add in trunk/Source

2011-06-03 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] Build flag for experimental ICU library support
https://bugs.webkit.org/show_bug.cgi?id=60786

Adds a build-time flag (CONFIG+=use_system_icu) that enables experimental
ICU powered Unicode support.

JavaScriptCore.pri: Support for use_system_icu CONFIG flag.
wtf/unicode/qt4/UnicodeQt4.h: Guard an include file with USE(ICU_UNICODE).

2011-06-03 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] Build flag for experimental ICU library support
https://bugs.webkit.org/show_bug.cgi?id=60786

Adds a build-time flag (CONFIG+=use_system_icu) that enables experimental
ICU powered Unicode support.

No new tests as no new features added.

WebCore.pri: Removed text_breaking_with_icu CONFIG flag.
WebCore.pro: Added TextCodecICU.cpp and qt/TextBreakIteratorInternalICUQt.cpp.
editing/qt/SmartReplaceQt.cpp:
features.pri: Support for use_system_icu CONFIG flag.
platform/text/TextCodecICU.cpp: Guard with USE(ICU_UNICODE).
platform/text/qt/TextBreakIteratorInternalICUQt.cpp: Added. (WebCore::Q_GLOBAL_STATIC_WITH_INITIALIZER): (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
platform/text/qt/TextBreakIteratorQt.cpp: Moved out currentTextBreakLocaleID(). (WebCore::isTextBreak):
platform/text/qt/TextCodecQt.cpp: Guard with USE(QT4_UNICODE). (WebCore::TextCodecQt::registerEncodingNames): (WebCore::TextCodecQt::registerCodecs):

7:39 AM Changeset in webkit [88015] by commit-queue@webkit.org

2 edits in trunk/Tools

2011-06-03 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Draw DRT scroll bar thumb with CG when WebKit renders with Skia
https://bugs.webkit.org/show_bug.cgi?id=61534

Skia on Mac uses Skia to render WebKit, and CG
to render UI elements. The CG elements need a
transcribed graphics context that preserves the
canvas matrix, and the canvas clip.

The SkiaBitLocker utility class sets up a CGContext
from the SkCanvas, locks the bitmap's bits, and
releases the lock when the class goes out of scope.

The SkiaBitLocker implementation is described by
this patch:
http://codereview.chromium.org/7031006/

When WebKit uses Skia for rendering, the WebCanvas
is an SkCanvas. Create an equivalent CGContext to
draw the scrollbar thumb.

As the Chrome Mac port does not yet use Skia, this
patch has no effect and requires no tests.

DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):

7:17 AM Changeset in webkit [88014] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebKit/efl

2011-06-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Implement startDownload() in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=61998

Implement startDownload() with download().

WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload):

7:12 AM Changeset in webkit [88013] by abecsi@webkit.org

2 edits in trunk/Tools

2011-06-03 Andras Becsi <abecsi@webkit.org>

Unreviewed build fix.

Fix typo.

Scripts/old-run-webkit-tests:

6:56 AM Changeset in webkit [88012] by abecsi@webkit.org

3 edits in trunk/Tools

2011-06-03 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

Print error message when there is no httpd present on the system
https://bugs.webkit.org/show_bug.cgi?id=61939

Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
Scripts/webkitperl/httpd.pm:

6:47 AM Changeset in webkit [88011] by yael.aharon@nokia.com

3 edits
9 adds in trunk

2011-06-03 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491

fast/frames/flattening/iframe-flattening-out-of-view.html: Added.
platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html
platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.

2011-06-03 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491

Do not flatten offscreen iframes during frame flattening, as flattening might make them visible.

Test: fast/frames/flattening/iframe-flattening-out-of-view.html

fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html

rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::flattenFrame):

6:29 AM Changeset in webkit [88010] by mnaganov@chromium.org

19 edits
2 adds in trunk

2011-06-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533

Skip cpu-profiler-profiling in debug, implement a fast headless alternative.

inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt: Added.
inspector/profiler/cpu-profiler-profiling-without-inspector.html: Added.
platform/chromium/test_expectations.txt:

2011-06-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533

Skip cpu-profiler-profiling in debug, implement a fast headless alternative.

public/WebDevToolsAgent.h:
src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setJavaScriptProfilingEnabled):
src/WebDevToolsAgentImpl.h:

2011-06-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533

Skip cpu-profiler-profiling in debug, implement a fast headless alternative.

DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
DumpRenderTree/chromium/DRTDevToolsAgent.h:
DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setJavaScriptProfilingEnabled):
DumpRenderTree/chromium/LayoutTestController.h:
DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setJavaScriptProfilingEnabled):
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
WebKitTestRunner/InjectedBundle/LayoutTestController.h:

2011-06-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533

Skip cpu-profiler-profiling in debug, implement a fast headless alternative.

WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: (WKBundleInspectorSetJavaScriptProfilingEnabled):
WebProcess/InjectedBundle/API/c/WKBundleInspector.h:
WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::setJavaScriptProfilingEnabled):
WebProcess/WebPage/WebInspector.h:

5:43 AM Changeset in webkit [88009] by Nikolas Zimmermann

3 edits
9 adds in trunk

2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Incorrect embedded document replaced size calculation for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=62007

When using <object style="box-sizing: border-box" data="foo.svg"/> to embed foo.svg
which has an intrinsic width/height, the embedded document intrinsic size is incorrect.

platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
platform/mac/svg/as-object: Added.
platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
svg/as-image/img-preserveAspectRatio-support-2.html: Added.
svg/as-image/resources/circle-default-default.svg: Added.
svg/as-object: Added.
svg/as-object/object-box-sizing-no-width-height.html: Added.

2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Incorrect embedded document replaced size calculation for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=62007

When using <object style="box-sizing: border-box" data="foo.svg"/> to embed foo.svg
which has an intrinsic width/height, the embedded document intrinsic size is incorrect.

RenderPart::computeEmbeddedDocumentReplacedWidth/Height has to ask the content renderer for the replaced width/height not ourselves.

Tests: svg/as-image/img-preserveAspectRatio-support-2.html

svg/as-object/object-box-sizing-no-width-height.html

rendering/RenderPart.cpp: (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth): (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):

5:36 AM Changeset in webkit [88008] by commit-queue@webkit.org

3 edits
2 deletes in trunk

2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88004.
http://trac.webkit.org/changeset/88004
https://bugs.webkit.org/show_bug.cgi?id=62008

This patch broke 4 tests in the GTK bots (Requested by
msanchez on #webkit).

platform/gtk/accessibility/caret-browsing-anchor-followed-expected.txt: Removed.
platform/gtk/accessibility/caret-browsing-anchor-followed.html: Removed.

2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88004.
http://trac.webkit.org/changeset/88004
https://bugs.webkit.org/show_bug.cgi?id=62008

This patch broke 4 tests in the GTK bots (Requested by
msanchez on #webkit).

accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleScrolledToAnchor):

5:11 AM Changeset in webkit [88007] by Nikolas Zimmermann

9 edits
4 adds in trunk

2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Zooming <object style="width/height: auto" data="foo.svg"/> doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=62005

Zooming an object with auto size, that references a svg with fixed size was broken. The svg size stayed the same.
Added new tests covering this zooming.

platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
svg/zoom/page/resources/circle.svg: Added.
svg/zoom/page/zoom-svg-through-object-with-auto-size.html: Added.

2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Zooming <object style="width/height: auto" data="foo.svg"/> doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=62005

Zooming an object with auto size, that references a svg with fixed size was broken. The svg size stayed the same.
Get rid of the dependency between RenderSVGRoot and SVGSVGElement::currentScale(), always ask for the effective
zoom in the RenderStyle instead of asking SVGSVGElement.

The SVGSVGElement::currentScale()/setCurrentScale() methods are now only used when called from the bindings (eg. JS).
They only take effect on the outermost <svg> element in standalone documents, otherwhise they are no-ops.

Test: svg/zoom/page/zoom-svg-through-object-with-auto-size.html

rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computeIntrinsicWidth): (WebCore::RenderSVGRoot::computeIntrinsicHeight): (WebCore::RenderSVGRoot::localToBorderBoxTransform):
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale):
svg/SVGSVGElement.h:

5:04 AM Changeset in webkit [88006] by alexis.menard@openbossa.org

4 edits in trunk

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957

When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks. We need to append in both case because qmake behave differently
when called with -spec or via SUBDIR+=.

Source/WebKit.pri:

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957

When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks. We need to append in both case because qmake behave differently
when called with -spec or via SUBDIR+=. This patch unbreak r87950 on Mac for Qt port.

JavaScriptCore.pro:

4:20 AM Changeset in webkit [88005] by Csaba Osztrogonác

1 edit
2 adds in trunk/LayoutTests

[Qt][WK2] Update platform specific expected file after r87873.

platform/qt-wk2/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.

4:10 AM Changeset in webkit [88004] by mario@webkit.org

3 edits
2 adds in trunk

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

Focus and caret position should be updated when same-page links are followed
https://bugs.webkit.org/show_bug.cgi?id=59737

Update the caret position to the anchor's position after scrolling.

This behavior is specific to the Gtk port and requested because of
accessibility needs, that's why it's implemented in AXObjectCache.

Test: platform/gtk/accessibility/caret-browsing-anchor-followed.html

accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleScrolledToAnchor): Make sure the caret is updated to be in the anchor's position after scrolling.

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

Focus and caret position should be updated when same-page links are followed
https://bugs.webkit.org/show_bug.cgi?id=59737

New layout test for testing this GTK-specific feature.

platform/gtk/accessibility/caret-browsing-anchor-followed-expected.txt: Added.
platform/gtk/accessibility/caret-browsing-anchor-followed.html: Added.

3:44 AM Changeset in webkit [88003] by tonyg@chromium.org

13 edits in branches/chromium/782

Merge 87802 - 2011-06-01 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Renaming the Page Visibility attributes as per the modified spec draft.
https://bugs.webkit.org/show_bug.cgi?id=61825

Spec draft:
http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html

Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
The attribute webkitIsVisible needs to change to webkitHidden

fast/events/page-visibility-iframe-delete-test.html:
fast/events/page-visibility-iframe-move-test-expected.txt:
fast/events/page-visibility-iframe-move-test.html:
fast/events/page-visibility-iframe-propagation-test-expected.txt:
fast/events/page-visibility-iframe-propagation-test.html:
fast/events/page-visibility-transition-test-expected.txt:
fast/events/page-visibility-transition-test.html:

2011-06-01 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Renaming the Page Visibility attributes as per the modified spec draft.
https://bugs.webkit.org/show_bug.cgi?id=61825

Spec draft:
http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html

Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
The attribute webkitIsVisible needs to change to webkitHidden

dom/Document.cpp: (WebCore::Document::webkitHidden): (WebCore::Document::dispatchVisibilityStateChangeEvent):
dom/Document.h:
dom/Document.idl:
dom/EventNames.h:

BUG=84840
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7065057

3:35 AM Changeset in webkit [88002] by dominicc@chromium.org

4 edits
2 adds in trunk

2011-06-03 Dominic Cooney <dominicc@chromium.org>

Reviewed by Kent Tamura.

Adds a test that keygen clones have the right shadow pseudoclass.
https://bugs.webkit.org/show_bug.cgi?id=61984

fast/html/clone-keygen-expected.txt: Added.
fast/html/clone-keygen.html: Added.
platform/win/Skipped: Test needs DRT functionality not in this port.

2011-06-03 Dominic Cooney <dominicc@chromium.org>

Reviewed by Kent Tamura.

Cloned keygen shadows should have -webkit-keygen-select pseudoclass.
https://bugs.webkit.org/show_bug.cgi?id=61984

When cloneNode's tag name-based cloning algorithm clones the
KeygenSelectElements of a keygen shadow as select elements. These
lack the -webkit-keygen-select pseudoclass.

Test: fast/html/clone-keygen.html

html/HTMLKeygenElement.cpp: (WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Create a KeygenSelectElement when being cloned.

3:31 AM Changeset in webkit [88001] by morrita@google.com

1 edit in trunk/Source/WebCore/ChangeLog

2011-06-02 MORITA Hajime <morrita@google.com>

Unreviewed ChangeLog fix.

3:08 AM Changeset in webkit [88000] by mario@webkit.org

2 edits in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping test with different results in 32-bit and 64-bit.

platform/gtk/Skipped: Skipped test.

3:05 AM Changeset in webkit [87999] by sergio@webkit.org

2 edits in trunk/Source/WebKit/gtk

2011-06-03 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Unref the SoupSession used by WebKitGtk+ at exit
https://bugs.webkit.org/show_bug.cgi?id=60165

WebKitGtk+ creates a SoupSession instance to handle network stuff
that is never freed. We should unref that object at exit time.

webkit/webkitglobals.cpp: (webkitExit): (webkitInit):

2:53 AM Changeset in webkit [87998] by Csaba Osztrogonác

1 edit
2 adds in trunk/LayoutTests

[Qt] Update platform specific expected files after r87873.

platform/qt/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
platform/qt/plugins/document-open-expected.txt: Added.

1:57 AM Changeset in webkit [87997] by pvarga@webkit.org

3 edits in trunk/Source/WebCore

[Qt][V8] build fix.

1:36 AM Changeset in webkit [87996] by mario@webkit.org

2 edits in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed. Test rebaseline for GTK after revision 87936.

platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:

1:36 AM Changeset in webkit [87995] by dominicc@chromium.org

4 edits
2 adds in trunk

2011-06-03 Dominic Cooney <dominicc@chromium.org>

Reviewed by Kent Tamura.

Adds a test that range input clones have the right kind of slider.
https://bugs.webkit.org/show_bug.cgi?id=61982

fast/html/clone-range-expected.txt: Added.
fast/html/clone-range.html: Added.
platform/win/Skipped: Test needs DRT functionality not in this port.

2011-06-03 Dominic Cooney <dominicc@chromium.org>

Reviewed by Kent Tamura.

Cloned range input sliders should be SliderThumbElements, not divs.
https://bugs.webkit.org/show_bug.cgi?id=61982

Test: fast/html/clone-range.html

html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren): Create a SliderThumbElement when being cloned.

1:22 AM Changeset in webkit [87994] by Laszlo Gombos

2 edits in trunk/LayoutTests

2011-06-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Organize the disabled features section in the Skipped list
https://bugs.webkit.org/show_bug.cgi?id=61994

Move all the tests for disabled features under the "Disabled
features" section in the Skipped list. Use the name of the build flags to
identify the features for better tracking.

platform/qt/Skipped:

12:47 AM Changeset in webkit [87993] by mario@webkit.org

2 edits in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, unskipping tests, now passing after reverting r87901.

platform/gtk/Skipped: Unskipped 3 tests.

12:23 AM Changeset in webkit [87992] by yurys@chromium.org

12 edits in trunk/Source

2011-06-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add an option for automatically attaching to new workers
https://bugs.webkit.org/show_bug.cgi?id=61930

Worker list is extended with a checkbox that makes inspector attach to each
new worker. Whenever a new worker context starts a new inspector window will
be opened for it.

Also worker agent and worker list will be updated when worker context is terminated.

inspector/Inspector.json:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::workerContextTerminatedImpl):
inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::workerContextTerminated):
inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::create): (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::setAutoconnectToWorkers): (WebCore::InspectorWorkerAgent::didStartWorkerContext): (WebCore::InspectorWorkerAgent::workerContextTerminated):
inspector/InspectorWorkerAgent.h:
inspector/front-end/WorkerManager.js: (WebInspector.WorkerManager.prototype._workerCreated): (WebInspector.WorkerManager.prototype._workerTerminated): (WebInspector.WorkerManager.prototype.openWorkerInspector): (WebInspector.WorkerManager.prototype._openInspectorWindow): (WebInspector.WorkerManager.prototype.reset): (WebInspector.WorkerMessageForwarder.prototype.workerCreated): (WebInspector.WorkerMessageForwarder.prototype.workerTerminated):
inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkerListSidebarPane): (WebInspector.WorkerListSidebarPane.prototype._workerAdded): (WebInspector.WorkerListSidebarPane.prototype._workerRemoved): (WebInspector.WorkerListSidebarPane.prototype._workersCleared): (WebInspector.WorkerListSidebarPane.prototype._addWorker): (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked): (WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
inspector/front-end/inspector.js: (WebInspector.reset):

2011-06-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add an option for automatically attaching to new workers
https://bugs.webkit.org/show_bug.cgi?id=61930

Notification about worker context termination are now sent to the inspector.

src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::terminateWorkerContext): (WebKit::WebWorkerClientImpl::disconnectFromInspector): (WebKit::WebWorkerClientImpl::workerContextDestroyed):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed