⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 7, 2011:

11:41 PM Changeset in webkit [90612] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

WebSocket: Clear cookies after test in httponly-cookie.pl
​https://bugs.webkit.org/show_bug.cgi?id=64145

Reviewed by Kent Tamura.

This test leaks cookies, which would cause a test failure if we put
a copy of this test under http/tests/websocket/tests.

To avoid this issue, cookies should be removed before the test ends.

  • http/tests/websocket/tests/hixie76/httponly-cookie.pl:

After the test, send an XHR request to itself with a query parameter,
which erases cookies used in this test by setting "Max-Age=0".

9:59 PM Changeset in webkit [90611] by kevino@webkit.org
  • 2 edits
    1 delete in trunk/Tools

[wx] Unreviewed build fix, remove old files from the tree and update paths to new ones.

9:53 PM Changeset in webkit [90610] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix, more fixes for install name issues.

8:53 PM Changeset in webkit [90609] by tkent@chromium.org
  • 5 edits
    1 delete in trunk/LayoutTests

[Chromium] Update baseline files for input-appearance-range.html.

  • platform/chromium-linux/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-range-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-appearance-range-expected.png:
  • platform/chromium/test_expectations.txt:
7:46 PM Changeset in webkit [90608] by morrita@google.com
  • 8 edits
    4 adds in trunk/LayoutTests

dump-as-markup.js should support shadow tree
​https://bugs.webkit.org/show_bug.cgi?id=62447

Reviewed by Ryosuke Niwa.

  • Added shadow support to Markup._get()
  • Updated expectations caused by this change.
  • Added explanatory test cases for shadows.
  • editing/inserting/5607069-2-expected.txt:
  • editing/inserting/5607069-3-expected.txt:
  • editing/pasteboard/copy-null-characters-expected.txt:
  • editing/selection/dump-as-markup-expected.txt:
  • editing/selection/dump-as-markup-form-text-expected.txt:
  • fast/parser/object-with-textarea-fallback-expected.txt:
  • fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-element-markup.html: Added.
  • fast/dom/HTMLProgressElement/progress-element-markup-expected.txt: Added.
  • fast/dom/HTMLProgressElement/progress-element-markup.html: Added.
  • fast/dom/HTMLMeterElement/meter-element-markup.html:
  • fast/dom/HTMLProgressElement/progress-element-markup.html:
  • resources/dump-as-markup.js:

(Markup._get):

7:22 PM Changeset in webkit [90607] by dpranke@chromium.org
  • 5 edits in trunk/Tools

test-webkitpy fails on chromium win
​https://bugs.webkit.org/show_bug.cgi?id=64137

Reviewed by Eric Seidel.

test-webkitpy doesn't play nicely with the multiprocessing
module on win32. An earlier change actually reenabled the tests
on win32 by mistake.

This patch also fixes a few cases where path names will trip
things up on win32 (e.g., by testing unix paths on windows).
We do not lose any real coverage here with those fixes.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
7:13 PM Changeset in webkit [90606] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[ImageDiff] Calculate/print difference right after reading baseline image.
​https://bugs.webkit.org/show_bug.cgi?id=64117

Patch by Leandro Pereira <​leandro@profusion.mobi> on 2011-07-07
Reviewed by Kent Tamura.

Otherwise, ImageDiff will block on fgets() until the universe ends or you C
it. Whichever happens first.

  • DumpRenderTree/efl/ImageDiff.cpp:

(main):

6:16 PM Changeset in webkit [90605] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] DRT: Leak cairo_t to make the pixel tests stop crashing
​https://bugs.webkit.org/show_bug.cgi?id=64107

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-07-07
Reviewed by Kent Tamura.

The pointer is later managed by BitmapContext, but it was being
de-refed and deleted earlier by our RefPtr, causing crashes in all
pixel tests.

We now call leakRef() to make sure it is not removed when our
createBitmapContextFromWebView goes out of context.

  • DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView):

5:49 PM Changeset in webkit [90604] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

WebSocket: Use jsTestIsAsync and finishJSTest() in httponly-cookie.pl
​https://bugs.webkit.org/show_bug.cgi?id=64087

Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hixie76/httponly-cookie.pl:
5:17 PM Changeset in webkit [90603] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

Switch HitTestResult to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=64131

Reviewed by Eric Seidel.

No new tests, no functionality changes.

  • page/MouseEventWithHitTestResults.cpp:

(WebCore::MouseEventWithHitTestResults::localPoint):

  • page/MouseEventWithHitTestResults.h:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
(WebCore::HitTestResult::rectForPoint):

  • rendering/HitTestResult.h:

(WebCore::HitTestResult::point):
(WebCore::HitTestResult::localPoint):
(WebCore::HitTestResult::setPoint):
(WebCore::HitTestResult::setLocalPoint):
(WebCore::HitTestResult::rectForPoint):

4:54 PM Changeset in webkit [90602] by commit-queue@webkit.org
  • 11 edits in trunk/Source/JavaScriptCore

DFG JIT does not implement op_construct.
​https://bugs.webkit.org/show_bug.cgi?id=64066

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-07
Reviewed by Gavin Barraclough.

  • dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::recordConstruct):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor):

  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:48 PM Changeset in webkit [90601] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

DFG JIT does not implement get_by_id prototype caching.
​https://bugs.webkit.org/show_bug.cgi?id=64077

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-07
Reviewed by Gavin Barraclough.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::tryCacheGetByID):

  • runtime/JSObject.h:

(JSC::JSObject::addressOfPropertyAtOffset):

4:35 PM LayoutTestResultFallbackOrder edited by dpranke@chromium.org
(diff)
4:35 PM LayoutTestResultFallbackOrder edited by dpranke@chromium.org
(diff)
4:18 PM LayoutTestsSearchPath edited by dpranke@chromium.org
(diff)
4:17 PM Changeset in webkit [90600] by leviw@chromium.org
  • 37 edits in trunk/Source/WebCore

Switch remaining paint functions to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=64116

Reviewed by Eric Seidel.

Switching all functions with IntPoint paintOffsets to the new Layout types.

No new tests, no functionality changes.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::paintSelection):

  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp:

(WebCore::InlineBox::paint):

  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paint):

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintCustomHighlight):

  • rendering/InlineTextBox.h:
  • rendering/LayoutTypes.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintContents):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintCaret):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::paintSelection):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintCustomHighlight):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):

  • rendering/RenderLayer.h:
  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintScrollbar):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintFocusRing):
(WebCore::RenderObject::paintOutline):

  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

  • rendering/RenderReplaced.h:
  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::paintIntoRect):

  • rendering/RenderScrollbarPart.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintCell):

  • rendering/RenderTableSection.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::paintPlaceholder):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paintEllipsisBox):
(WebCore::RootInlineBox::paintCustomHighlight):
(WebCore::RootInlineBox::paint):

  • rendering/RootInlineBox.h:
  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::paint):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::paint):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint):

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::paint):

4:16 PM Changeset in webkit [90599] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Work around Skia PDF's lack of inverted path support.
​https://bugs.webkit.org/show_bug.cgi?id=64032

Patch by Steve VanDeBogart <​vandebo@chromium.org> on 2011-07-07
Reviewed by James Robinson.

The trick used in ​http://neugierig.org/software/chromium/notes/2010/07/clipping.html
to support antialiased clips doesn't work when printing to Skia's PDF backend because
the backend does not support inverted paths. This manifests as rounded buttons not being
drawn when printing, tracked as Chrome bug 79519.

However, when the output is a vector device, like PDF, we don't need antialiased clips.
It's up to the PDF rendering engine to do that. So we can simply disable the antialiased
clip code if the output is a vector device.

I think the fix isn't testable because it requires examining the printed output.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):

4:07 PM Changeset in webkit [90598] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT method_check implementation does not link to optimized get_by_id
slow path.
​https://bugs.webkit.org/show_bug.cgi?id=64073

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-07
Reviewed by Gavin Barraclough.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchGetMethodFast):

3:58 PM TestExpectations edited by dpranke@chromium.org
(diff)
3:58 PM TestExpectations edited by dpranke@chromium.org
(diff)
3:55 PM TestExpectations edited by dpranke@chromium.org
(diff)
3:45 PM Changeset in webkit [90597] by jamesr@google.com
  • 2 edits
    1 add in trunk/LayoutTests

[chromium] Add text baseline for spanOverlapsCanvas

  • platform/chromium-gpu-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:37 PM Changeset in webkit [90596] by eae@chromium.org
  • 16 edits in trunk/Source/WebCore

Switch rendering tree selection code to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=63762

Reviewed by Eric Seidel.

Switch selection getters and selection gap calculation methods over to
new layout abstraction.

No new tests, no functionality changes.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionTop):
(WebCore::InlineTextBox::selectionBottom):
(WebCore::InlineTextBox::selectionHeight):
(WebCore::InlineTextBox::isSelected):

  • rendering/InlineTextBox.h:
  • rendering/RenderBR.h:

(WebCore::RenderBR::selectionRectForRepaint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionOffset):
(WebCore::RenderBlock::logicalRightSelectionOffset):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::desiredColumnWidth):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::selectionRectForRepaint):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::selectionRectForRepaint):

  • rendering/RenderListMarker.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::selectionRect):
(WebCore::RenderObject::selectionRectForRepaint):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::selectionRectForRepaint):

  • rendering/RenderReplaced.h:
  • rendering/RenderSelectionInfo.h:

(WebCore::RenderSelectionInfo::RenderSelectionInfo):

  • rendering/RenderText.cpp:

(WebCore::RenderText::selectionRectForRepaint):

  • rendering/RenderText.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::selectionHeight):

3:29 PM Changeset in webkit [90595] by gavinp@chromium.org
  • 7 edits
    2 adds in trunk

Reviewed by Alexey Proskuryakov.

fast/dom/HTMLLinkElement/link-and-subresource-test.html is flaky on chromium debug bots
​https://bugs.webkit.org/show_bug.cgi?id=60097

The culprit was that CachedResource:stopLoading() was using *this
after a call to checkNotify(), which isn't kosher. This patch
uses a CachedResourceHandle to keep the CachedResource alive.

Source/WebCore:

The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test. The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.
Test: fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::stopLoading):

LayoutTests:

The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test. The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.

  • fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:20 PM Changeset in webkit [90594] by Adam Roben
  • 2 edits in trunk/Tools

Update TestFailures's title and header immediately upon navigation

Fixes <​http://webkit.org/b/64125> TestFailures page seems slow to react on link clicks

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype.loaded): Create and store an h1 element for displaying the page's
title.
(ViewController.prototype._displayBuilder): Set the page's title and clear out any old
content immediately instead of waiting for the first set of results for the history
analyzer. As we receive new results from the analyzer we'll just clear out the main content
area and replace it with the new info.
(ViewController.prototype._displayTesters): Set the page's title and clear out any old
content immediately instead of waiting for the list of testers from the buildbot. Sprinkled
in a little use of our removeAllChildren helper, too.
(ViewController.prototype._setTitle): Added. Set's the page's title and the header text.

3:14 PM NewRunWebKitTests edited by dpranke@chromium.org
(diff)
3:12 PM NewRunWebKitTests edited by dpranke@chromium.org
(diff)
3:11 PM NewRunWebKitTests edited by dpranke@chromium.org
(diff)
3:09 PM Changeset in webkit [90593] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-07-07
Reviewed by Stephen White.

Mark layout tests as failing in Chromium after skia roll r1799:r1814
​https://bugs.webkit.org/show_bug.cgi?id=64121

  • platform/chromium/test_expectations.txt:
3:09 PM Changeset in webkit [90592] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

Patch by James Robinson <​jamesr@chromium.org> on 2011-07-07
Reviewed by Kenneth Russell.

Use v8::AdjustAmountOfExternalAllocatedMemory for ArrayBuffers
​https://bugs.webkit.org/show_bug.cgi?id=42912

This calls v8's AdjustAmountOfExternalAllocatedMemory when ArrayBuffers are allocated/deallocated so that V8's
garbage collection heuristics can account for the memory held by these objects. On the new test page, this
reduces the peak memory use from 5BG+ (or a crash in 32-bit systems) to <300MB.

Test: WebCore/manual-tests/array-buffer-memory.html

  • html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::~ArrayBuffer):
(WebCore::ArrayBuffer::tryAllocate):

3:05 PM TestExpectations edited by dpranke@chromium.org
(diff)
3:05 PM TestExpectations edited by dpranke@chromium.org
(diff)
3:04 PM TestExpectations edited by dpranke@chromium.org
(diff)
3:04 PM TestExpectations edited by dpranke@chromium.org
(diff)
3:00 PM NewRunWebKitTests edited by dpranke@chromium.org
(diff)
2:52 PM NewRunWebKitTests edited by dpranke@chromium.org
(diff)
2:52 PM HackingOnNewRunWebKitTests created by dpranke@chromium.org
2:50 PM LayoutTestsSearchPath created by dpranke@chromium.org
2:49 PM HackingOnNRWT created by dpranke@chromium.org
2:48 PM TestExpectations created by dpranke@chromium.org
2:47 PM NewRunWebKitTests edited by dpranke@chromium.org
(diff)
2:45 PM NewRunWebKitTests edited by dpranke@chromium.org
(diff)
2:44 PM NewRunWebKitTests created by dpranke@chromium.org
2:37 PM WikiStart edited by dpranke@chromium.org
(diff)
2:37 PM Changeset in webkit [90591] by rniwa@webkit.org
  • 14 edits in trunk/Source/WebCore

Move all code related to cachedSelection to HTMLTextFormControlElement
​https://bugs.webkit.org/show_bug.cgi?id=64118

Reviewed by Alexey Proskuryakov.

Moved m_cachedSelectionStart and m_cachedSelectionEnd from HTMLInputElement
and HTMLTextAreaElement to HTMLTextFormControlElement

Also removed cached selection related functions from RenderTextControl,
RenderTextControlSingleLine, and RenderTextControlMultiLine because they were
merely providing wrapper functions to enable polymorphism between
input and textarea elements and their WML equivalents.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::notifyRendererOfSelectionChange): Calls HTMLTextFormControlElement's
selectionChanged instead of RenderTextControl's.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): Initialize
m_cachedSelectionStart and m_cachedSelectionEnd.
(WebCore::HTMLTextFormControlElement::selectionStart):
(WebCore::HTMLTextFormControlElement::selectionEnd):
(WebCore::HTMLTextFormControlElement::selection):
(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Added.
(WebCore::HTMLTextFormControlElement::selectionChanged): Extracted from
RenderTextControl::selectionChanged.

  • html/HTMLFormControlElement.h:

(WebCore::HTMLTextFormControlElement::cacheSelection): Extracted from HTMLInputElement
and HTMLTextAreaElement.
(WebCore::HTMLTextFormControlElement::hasCachedSelectionStart): Added.
(WebCore::HTMLTextFormControlElement::hasCachedSelectionEnd): Added.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::updateFocusAppearance):

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
(WebCore::HTMLTextAreaElement::updateFocusAppearance):

  • html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::isEmptyValue):

  • rendering/RenderTextControl.cpp:

(WebCore::setSelectionRange):

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderTextControlSingleLine.h:
2:16 PM Changeset in webkit [90590] by eae@chromium.org
  • 19 edits in trunk/Source/WebCore

Switch addFocusRingRects to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=64114

Reviewed by Eric Seidel.

No new tests, no functionality changes.

  • rendering/LayoutTypes.h:

(WebCore::flooredLayoutPoint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addFocusRingRects):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addFocusRingRects):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::addFocusRingRects):

  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::addFocusRingRects):

  • rendering/RenderListBox.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::addFocusRingRects):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::addFocusRingRects):

  • rendering/RenderTextControl.h:
  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::addFocusRingRects):

  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::addFocusRingRects):

  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::addFocusRingRects):

  • rendering/svg/RenderSVGPath.h:
2:06 PM Changeset in webkit [90589] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Reduce compositor texture memory by skipping layers and clipping surfaces
​https://bugs.webkit.org/show_bug.cgi?id=64052

Reviewed by James Robinson.

Layers and surfaces that are entirely transparent are now skipped.
Parent scissor rects are now applied to the content rect of surfaces
so that offscreen surfaces can be skipped.

Landing this for ​vangelis@chromium.org.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::calculateVisibleRect):
(WebCore::calculateVisibleLayerRect):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::updateCompositorResources):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):

1:45 PM Changeset in webkit [90588] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r90581.
​http://trac.webkit.org/changeset/90581
​https://bugs.webkit.org/show_bug.cgi?id=64124

Broke a bunch of inspector tests (Requested by ojan on
#webkit).

  • inspector/front-end/ExtensionAPI.js:

(WebInspector.injectedExtensionAPI.Panels.prototype.create):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
(WebInspector.injectedExtensionAPI.expandURL):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._onWindowMessage):
(WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):

1:37 PM Changeset in webkit [90587] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Fix crash when compositing gets disabled mid-paint
​https://bugs.webkit.org/show_bug.cgi?id=64119

Reviewed by James Robinson.

WebKit paint can disable compositing and call setRootLayer(0). Adding
a check for this in drawLayers prevents a null pointer deref.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

1:26 PM Changeset in webkit [90586] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Encode jump and link sizes into the appropriate enums
​https://bugs.webkit.org/show_bug.cgi?id=64123

Reviewed by Sam Weinig.

Finally kill off the out of line jump and link size arrays,
so we can avoid icky loads and constant fold the linking arithmetic.

  • assembler/ARMv7Assembler.cpp:
  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::computeJumpType):

1:17 PM Changeset in webkit [90585] by krit@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-07-07 Dirk Schulze <​krit@webkit.org>

SVGAnimateTransform does not support calcMode=discrete
​https://bugs.webkit.org/show_bug.cgi?id=63914

Reviewed by Rob Buis.

CalcMode discrete specifies that the animation function will jump from one value to the next without any interpolation.
Implemented calcMode discrete by checking current progress of animation. If we are in the first half of the animation,
we use the start value of the aniamtion, end value for the second half of the animation. The key time at 50% is used on
all other animations as well as on other SVG viewers.

Added a manual test. DRT crashes on an automated test with the SVG animation API. Opened a new bug report: 64104.

  • manual-tests/svg-animateTransform-calcMode-discrete.svg: Added.
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
12:13 PM Changeset in webkit [90584] by Adam Roben
  • 3 edits in trunk/Tools

Make Checkout use SCM's Executive instead of conjuring up its own

This will improve integration with the rest of webkitpy, particularly when invoked via
webkit-patch.

Fixes <​http://webkit.org/b/64115> REGRESSION (r90564): webkitpy's Checkout class uses
Executive inappropriately

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.commit_message_for_this_commit): Use SCM.run instead of creating an Executive for
our own use. SCM might have some super-special Executive that it uses under the covers, and
we want to use it, too!

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Mock the SCM.run
method to call through to Executive.run_command.

11:47 AM Changeset in webkit [90583] by Adam Roben
  • 2 edits in trunk/Tools

Make Term/ReadKey.pm an optional dependency of commit-log-editor

When Term/ReadKey.pm isn't present, the --regenerate-log switch will be non-functional.

Fixes <​http://webkit.org/b/64113> REGRESSION (r90564):
webkitpy.common.checkout.checkout_unittest failing on GTK bots due to missing
Term/ReadKey.pm module

Reviewed by Xan Lopez.

  • Scripts/commit-log-editor: Use Module::Load::Conditional::can_load to only load

Term/ReadKey.pm if it's present. If it isn't present, ignore the --regenerate-log switch so
that existing commit messages will be preserved. (Users can manually remove existing commit
messages using git-reset.)

11:43 AM Changeset in webkit [90582] by krit@webkit.org
  • 5 edits
    3 adds in trunk

Reviewed by Rob Buis.

Source/WebCore:

SVGAnimatedPath needs fallback for 'by' animation
​https://bugs.webkit.org/show_bug.cgi?id=63865

Added fallback to 'to' animation for 'by' animated SVGAnimatedPathAnimator.

Clenup of SVGAnimateElement. Removed all switches since we support all AnimatedTypes
with the exception of AnimatedEnumeration. AnimatedEnumeration gets animated as AnimatedString at the moment.

Test: svg/animations/svgpath-animation-1.html

  • svg/SVGAnimateElement.cpp:

(WebCore::getPropertyValue):
(WebCore::inheritsFromProperty):
(WebCore::attributeValueIsCurrentColor):
(WebCore::SVGAnimateElement::adjustForCurrentColor):
(WebCore::SVGAnimateElement::determineAnimatedAttributeType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore::SVGAnimateElement::calculateDistance):

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::calculateFromAndByValues):

LayoutTests:

SVGAnimatedPath needs fallback for 'by' animation
​https://bugs.webkit.org/show_bug.cgi?id=63865

Test fallback to 'to' animation for 'by' animated SVGPath.

  • svg/animations/script-tests/svgpath-animation-1.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/svgpath-animation-1-expected.txt: Added.
  • svg/animations/svgpath-animation-1.html: Added.
11:38 AM Changeset in webkit [90581] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-07-07 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: secure access to extensions API
​https://bugs.webkit.org/show_bug.cgi?id=64080

Reviewed by Pavel Feldman.

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionPanel):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onSetSidebarPage): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler): (WebInspector.ExtensionServer.prototype._expandResourcePath):
11:33 AM CommitterTips edited by adele@apple.com
(diff)
11:15 AM Changeset in webkit [90580] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-07 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed.

Re-skip the inspector tests, they are still timing out on the
release bot for some reason.

  • platform/gtk/Skipped:
11:02 AM Changeset in webkit [90579] by Adam Roben
  • 2 edits in trunk/Tools

Keep testing that commit messages containing Unicode are handled properly by webkitpy

Fixes <​http://webkit.org/b/64109> REGRESSION (r90571): test-webkitpy no longer tests that we
correctly handle Unicode in commit messages

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/checkout_unittest.py: Put some Unicode characters in

places in the ChangeLog that will end up being included in the commit message.

10:45 AM Changeset in webkit [90578] by andreas.kling@nokia.com
  • 15 edits
    1 delete in trunk

[Qt][WK2] Remove Symbian code.
​https://bugs.webkit.org/show_bug.cgi?id=64101

Reviewed by Benjamin Poulain.

Source/WebKit2:

  • DerivedSources.pro:
  • Platform/CoreIPC/Attachment.h:
  • Platform/CoreIPC/Connection.h:
  • Platform/SharedMemory.h:
  • Platform/qt/SharedMemorySymbian.cpp: Removed.
  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • WebKit2.pri:
  • WebKit2.pro:
  • WebProcess.pro:
  • config.h:

Tools:

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::screenshot):

  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):

10:43 AM Changeset in webkit [90577] by andreas.kling@nokia.com
  • 13 edits in trunk

[Qt][WK2] Don't support ridiculous matrix of QT_NO_FEATURE combinations.
​https://bugs.webkit.org/show_bug.cgi?id=64099

Reviewed by Benjamin Poulain.

Source/WebKit2:

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::setCursor):
(QtWebPageProxy::registerEditCommand):
(QtWebPageProxy::clearAllEditCommands):
(QtWebPageProxy::canUndoRedo):
(QtWebPageProxy::executeUndoRedo):
(QtWebPageProxy::updateAction):
(QtWebPageProxy::webActionTriggered):
(QtWebPageProxy::triggerAction):
(QtWebPageProxy::action):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::didChangeCursor):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
  • UIProcess/qt/WebUndoCommandQt.cpp:

(WebUndoCommandQt::WebUndoCommandQt):

  • UIProcess/qt/WebUndoCommandQt.h:
  • WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:

(WebKit::WebDragClient::startDrag):

Tools:

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::openFile):
(BrowserWindow::screenshot):
(BrowserWindow::loadURLListFromFile):

10:39 AM Changeset in webkit [90576] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another test that uses beginDragWithFiles on Windows

  • platform/win/Skipped: Added fast/forms/file-input-change-event.html.
10:33 AM Changeset in webkit [90575] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Updated change log

10:29 AM Changeset in webkit [90574] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

The return value of SharedBuffer::createWithContentsOfFile must have valid m_size.
​https://bugs.webkit.org/show_bug.cgi?id=63313

Patch by Kyusun Kim <​maniagoon@company100.net> on 2011-07-07
Reviewed by Eric Seidel.

  • platform/posix/SharedBufferPOSIX.cpp:

(WebCore::SharedBuffer::createWithContentsOfFile):

10:27 AM Changeset in webkit [90573] by mitz@apple.com
  • 5 edits in trunk

<rdar://problem/9737435> Re-enable -webkit-column-break-inside: avoid
​https://bugs.webkit.org/show_bug.cgi?id=64102

Reviewed by Simon Fraser.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild): Treat the child as unsplittable if
'-webkit-column-break-inside: avoid' was specified.

LayoutTests:

  • fast/multicol/break-properties-expected.txt:
  • fast/multicol/break-properties.html:
10:27 AM Changeset in webkit [90572] by andreas.kling@nokia.com
  • 8 edits in trunk/Source/WebKit2

[Qt][WK2] Views should know about WebProcess crash/relaunch.
​https://bugs.webkit.org/show_bug.cgi?id=64093

Reviewed by Benjamin Poulain.

Add processDidCrash() and didRelaunchProcess() to ViewInterface.

QDesktopWebView now displays a simple sad smiley ":(" when the
web process crashes.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(paintCrashedPage):
(QDesktopWebView::paint):
(QDesktopWebViewPrivate::processDidCrash):
(QDesktopWebViewPrivate::didRelaunchProcess):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::showContextMenu):
(WebKit::TouchViewInterface::hideContextMenu):
(WebKit::TouchViewInterface::processDidCrash):
(WebKit::TouchViewInterface::didRelaunchProcess):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
10:18 AM Changeset in webkit [90571] by Adam Roben
  • 2 edits in trunk/Tools

Completely ignore too-many-failures builds in TestFailures in most circumstances

Because a semi-arbitrary subset of tests are run in a too-many-failures build, we can't
really use them to perform regression analysis. The only time we want to pay attention to
too-many-failures builds is when we're trying to explain when the current bout of
too-many-failures started.

Fixes <​http://webkit.org/b/64106> TestFailures page sometimes claims a test started failing
in a build that didn't even run it (because it exited early due to too many failues)

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Removed old, broken
too-many-failures handling that would cause us to blame builds that didn't even run a given
test for breaking it. Instead, skip over all too-many-failures builds unless the most recent
build was itself a too-many-failures build.

10:17 AM Changeset in webkit [90570] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
​https://bugs.webkit.org/show_bug.cgi?id=63255

Unreviewed gardening.

  • platform/qt/Skipped: Skip tests.
10:15 AM Changeset in webkit [90569] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: visual regressions in network panel
​https://bugs.webkit.org/show_bug.cgi?id=64089

Reviewed by Pavel Feldman.

  • inspector/front-end/networkPanel.css:

(.data-grid.network-log-grid tr.filler td):
(.network.panel .sidebar):

10:05 AM Changeset in webkit [90568] by jchaffraix@webkit.org
  • 3 edits
    6 adds in trunk

Patch by Julien Chaffraix <​jchaffraix@webkit.org> on 2011-07-07
Reviewed by David Hyatt.

Partial layout when a flex-box has visibility: collapse
​https://bugs.webkit.org/show_bug.cgi?id=63776

Source/WebCore:

Tests: fast/flexbox/crash-button-input-autofocus.html

fast/flexbox/crash-button-keygen.html
fast/flexbox/crash-button-relayout.html

The issue is that FlexBoxIterator would skip any child if it has visibility: collapsed.
However if one of the child is anonymous, it may wrap some other child that would be skipped.
Now FlexBoxIterator is called during the layout phase and thus some nodes would not relayouted
as expected.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next): When iterating, don't skip anonymous content as there may
be real content hiding below.

LayoutTests:

Those tests checks some variation of the same underlying issue.

  • fast/flexbox/crash-button-input-autofocus-expected.txt: Added.
  • fast/flexbox/crash-button-input-autofocus.html: Added.
  • fast/flexbox/crash-button-keygen-expected.txt: Added.
  • fast/flexbox/crash-button-keygen.html: Added.
  • fast/flexbox/crash-button-relayout-expected.txt: Added.
  • fast/flexbox/crash-button-relayout.html: Added.
9:53 AM Changeset in webkit [90567] by vsevik@chromium.org
  • 5 edits in trunk

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: URL links in styles open new tab instead of showing resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=64090

Reviewed by Pavel Feldman.

  • inspector/styles/styles-url-linkify-expected.txt:
  • inspector/styles/styles-url-linkify.html:

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: URL links in styles open new tab instead of showing resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=64090

Reviewed by Pavel Feldman.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
9:52 AM Changeset in webkit [90566] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(90557) http/tests/inspector/network/network-embed.html fails
​https://bugs.webkit.org/show_bug.cgi?id=64103

Unreviewed gardening.

  • platform/qt/Skipped: Skip test.
9:48 AM Changeset in webkit [90565] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-07 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: active panel does not receive resize event when drawer is resized
​https://bugs.webkit.org/show_bug.cgi?id=64094

Reviewed by Pavel Feldman.

  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype._statusBarDragging):
9:36 AM Changeset in webkit [90564] by Adam Roben
  • 3 edits in trunk/Tools

Teach webkitpy's Checkout class to use commit-log-editor to create commit messages

Fixes <​http://webkit.org/b/26755> webkit-patch's commit messages are less readable than
commit-log-editor's

Reviewed by David Kilzer.

  • Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.commit_message_for_this_commit): Run commit-log-editor, passing it the paths of
the modified ChangeLogs, to generate the commit message, rather than trying to generate one
ourselves.

  • Scripts/webkitpy/common/checkout/checkout_unittest.py: Updated the expected commit message

to match commit-log-editor's format.
(CommitMessageForThisCommitTest.setUp): Write the ChangeLogs into Tools and LayoutTests
directories so we can see how the various entries get labeled in the commit message.
(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Create a mock SCM
instance that knows how to find commit-log-editor and pass it to our Checkout instance.
Don't bother capturing output, since there shouldn't be any.

9:36 AM Changeset in webkit [90563] by Adam Roben
  • 2 edits in trunk/Tools

Add a --print-log option to commit-log-editor

When specified, commit-log-editor takes a set of ChangeLog paths on the command line,
generates a commit message from those ChangeLogs, prints it to stdout, and exits.

Prep work for fixing <​http://webkit.org/b/26755> webkit-patch's commit messages are less
readable than commit-log-editor's

Reviewed by David Kilzer.

  • Scripts/commit-log-editor: Changed to use Getopt::Long to parse options. Added --print-log

option, which calls through to createCommitMessage, prints the result, and exits.
(printUsageAndExit): Renamed from "usage" for clarity. Beefed up the usage statement to
explain commit-log-editor's 2.5 (normal, --print-log, and --help) modes of operation.

9:35 AM Changeset in webkit [90562] by Adam Roben
  • 2 edits in trunk/Tools

Extract commit-log-editor's commit-message-generation code into a separate function

As a bonus, we now skip a bunch of work in the case where we are generating a commit message
for staged git changes.

Prep work for fixing <​http://webkit.org/b/26755> webkit-patch's commit messages are less
readable than commit-log-editor's

Reviewed by David Kilzer.

  • Scripts/commit-log-editor: Moved the default definition of $endl up toward the top of the

file so that it will be defined even if we aren't operating on an existing log message.
Moved a bunch of top-level code to generate the commit message from here...
(createCommitMessage): ...to here.

9:20 AM Changeset in webkit [90561] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-07 Pavel Feldman <​pfeldman@chromium.org>

Web Inspector: prevent default action during drag'n'drop in the Elements panel.
​https://bugs.webkit.org/show_bug.cgi?id=64081

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype._ondragstart): (WebInspector.ElementsTreeOutline.prototype._ondragover): (WebInspector.ElementsTreeOutline.prototype._ondragend):
  • inspector/front-end/treeoutline.js: (TreeOutline.prototype.treeElementFromPoint):
7:18 AM Changeset in webkit [90560] by Nikolas Zimmermann
  • 26 edits in trunk/Source/WebCore

2011-07-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Move remaining enums out of SVG*Element classes
​https://bugs.webkit.org/show_bug.cgi?id=64075

Reviewed by Dirk Schulze.

Move remaining enums out of SVG*Element classes. This is a preparation patch for bug 63797.
Also move the SVGPropertyTraits template specializations for enum types before the class
definition in the header, otherwhise we can't use SVGPropertyTraits<FooType>::fromString/toString
in the DECLARE_ANIMATED* macros, which is needed soon.

No new tests, just refactoring.

  • rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::angle): (WebCore::RenderSVGResourceMarker::markerTransformation):
  • rendering/svg/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::markerUnits):
  • rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::RenderSVGTextPath): (WebCore::RenderSVGTextPath::exactAlignment): (WebCore::RenderSVGTextPath::stretchMethod):
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeCommonGradientProperties):
  • rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
  • svg/GradientAttributes.h: (WebCore::GradientAttributes::GradientAttributes): (WebCore::GradientAttributes::spreadMethod): (WebCore::GradientAttributes::setSpreadMethod):
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement):
  • svg/SVGGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle): (WebCore::SVGMarkerElement::synchronizeOrientType): (WebCore::SVGMarkerElement::orientTypeAnimated):
  • svg/SVGMarkerElement.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::SVGTextContentElement):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::SVGTextPathElement):
  • svg/SVGTextPathElement.h:
6:47 AM Changeset in webkit [90559] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-07 Xan Lopez <​xlopez@igalia.com>

Unreviewed.

Enable inspector tests again (they should work now), and skip test
that is timing out in all GTK+ bots.

  • platform/gtk/Skipped:
6:44 AM Changeset in webkit [90558] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-07 Ilya Tikhonovsky <​loislo@chromium.org>

Web Inspector: Protocol: pointers to optional "in" parameters passing to the
backend methods should be NULL if they are not specified in the message.
​https://bugs.webkit.org/show_bug.cgi?id=64083

Reviewed by Pavel Feldman.

  • inspector/CodeGeneratorInspector.pm: (generateBackendFunction): (generateArgumentGetters):
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode):
6:12 AM Changeset in webkit [90557] by vsevik@chromium.org
  • 12 edits in trunk/LayoutTests

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Move resetting NetworkResourcesData out of tests unrelated to replacement testing.
​https://bugs.webkit.org/show_bug.cgi?id=64078

Reviewed by Pavel Feldman.

  • http/tests/inspector/network-test.js: (initialize_NetworkTest.InspectorTest.resetInspectorResourcesData.nextStep): (initialize_NetworkTest.InspectorTest.resetInspectorResourcesData): (resetInspectorResourcesData):
  • http/tests/inspector/network/network-clear-cache-expected.txt:
  • http/tests/inspector/network/network-clear-cache.html-disabled:
  • http/tests/inspector/network/network-clear-cookies-expected.txt:
  • http/tests/inspector/network/network-clear-cookies.html-disabled:
  • http/tests/inspector/network/network-embed-expected.txt:
  • http/tests/inspector/network/network-embed.html:
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/network/network-xhr-sync.html:
5:06 AM Changeset in webkit [90556] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-07 Ilya Tikhonovsky <​loislo@chromium.org>

Web Inspector: Searching on the Network panel doesn't do anything?
​https://bugs.webkit.org/show_bug.cgi?id=55489

This is initial implementation of search in Network panel.
It is pretty simple search only for names and paths.

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refresh): (WebInspector.NetworkPanel.prototype._reset): (WebInspector.NetworkPanel.prototype._updateOffscreenRows): (WebInspector.NetworkPanel.prototype._matchResource): (WebInspector.NetworkPanel.prototype._clearSearchMatchedList): (WebInspector.NetworkPanel.prototype._highlightNthMatchedResource): (WebInspector.NetworkPanel.prototype.performSearch): (WebInspector.NetworkDataGridNode.prototype.createCells):
  • inspector/front-end/utilities.js: (String.prototype.escapeHTML): ():
4:33 AM Changeset in webkit [90555] by vsevik@chromium.org
  • 4 edits
    4 adds in trunk

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
​https://bugs.webkit.org/show_bug.cgi?id=63936

Reviewed by Pavel Feldman.

  • http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-non-unique-url.html: Added.
  • http/tests/inspector/resource-tree/resource-tree-test.js: (initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
  • http/tests/inspector/resource-tree/resources/resource-tree-non-unique-url-iframe.html: Added.
  • http/tests/inspector/resource-tree/resources/styles-non-unique-url.css: Added. (body):

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
​https://bugs.webkit.org/show_bug.cgi?id=63936

Reviewed by Pavel Feldman.

Test: http/tests/inspector/resource-tree/resource-tree-non-unique-url.html

  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameTreeElement.prototype.appendResource):
4:18 AM Changeset in webkit [90554] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Reviewed by Eric Carlson.

GTK: media/video-src-invalid-poster.html Failed
​https://bugs.webkit.org/show_bug.cgi?id=61160

Wait for loadstart event to check the poster dimensions and avoid a
potential timeout of the test.

  • media/video-src-invalid-poster-expected.txt:
  • media/video-src-invalid-poster.html:
  • platform/gtk/Skipped:
3:47 AM Changeset in webkit [90553] by vsevik@chromium.org
  • 16 edits
    6 adds in trunk

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Add support for clearing cache and cookies from network panel.
​https://bugs.webkit.org/show_bug.cgi?id=63999

Added clear cache and cookies tests. Since no port currently supports
this functionality, the tests are disabled.

Reviewed by Pavel Feldman.

  • http/tests/inspector/network/network-clear-cache-expected.txt: Added.
  • http/tests/inspector/network/network-clear-cache.html-disabled: Added.
  • http/tests/inspector/network/network-clear-cookies-expected.txt: Added.
  • http/tests/inspector/network/network-clear-cookies.html-disabled: Added.
  • http/tests/inspector/network/resources/random-cached.php: Added.
  • http/tests/inspector/network/resources/set-cookie.php: Added.

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Add support for clearing cache and cookies from network panel.
​https://bugs.webkit.org/show_bug.cgi?id=63999

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorClient.h: (WebCore::InspectorClient::clearBrowserCache): (WebCore::InspectorClient::clearBrowserCookies):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::clearBrowserCache): (WebCore::InspectorResourceAgent::clearBrowserCookies): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu): (WebInspector.NetworkPanel.prototype._clearBrowserCache): (WebInspector.NetworkPanel.prototype._clearBrowserCookies):
  • inspector/front-end/Settings.js:

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Add support for clearing cache and cookies from network panel.
​https://bugs.webkit.org/show_bug.cgi?id=63999

Reviewed by Pavel Feldman.

  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::clearBrowserCache): (WebKit::WebDevToolsAgentClient::clearBrowserCookies):
  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::clearBrowserCache): (WebKit::InspectorClientImpl::clearBrowserCookies):
  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::clearBrowserCache): (WebKit::WebDevToolsAgentImpl::clearBrowserCookies):
  • src/WebDevToolsAgentImpl.h:
3:37 AM Changeset in webkit [90552] by commit-queue@webkit.org
  • 5 edits in trunk

2011-07-07 Shinya Kawanaka <​shinyak@google.com>

Added more key bindings for input[type=range].
​https://bugs.webkit.org/show_bug.cgi?id=52262

Added PageUp/PageDown/Home/End key bindings tests for input[type=range].

Reviewed by Kent Tamura.

  • fast/forms/range-keyoperation-expected.txt: Regenerated.
  • fast/forms/range-keyoperation.html: Added more key bindings tests.

2011-07-07 Shinya Kawanaka <​shinyak@google.com>

Added more key bindings for input[type=range].
​https://bugs.webkit.org/show_bug.cgi?id=52262

Added PageUp/PageDown/Home/End key bindings for input[type=range].
PageUp/PageDown change value by about 10%.
Home/End change value to minimum/maximum.

Reviewed by Kent Tamura.

  • html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): Added key bindings.
3:29 AM Changeset in webkit [90551] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

2011-07-07 Carlos Garcia Campos <​cgarcia@igalia.com>

[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=63988

Reviewed by Martin Robinson.

  • MiniBrowser/gtk/BrowserWindow.c: (browserWindowConstructed): (decidePolicyForNavigationAction): Ignore the action if a link is clicked with the middle buttonm and open the link in a new window. (browserWindowPolicyClientInit):
2:06 AM Changeset in webkit [90550] by commit-queue@webkit.org
  • 11 edits
    2 copies in trunk/Source/WebKit2

2011-07-07 Benjamin Poulain <​benjamin@webkit.org>

[Qt] [WK2] Improve the handling of touch events to use them as main input
​https://bugs.webkit.org/show_bug.cgi?id=63991

Reviewed by Kenneth Rohde Christiansen.

Promote touch event for use as primary input.

The touch events now use the responsiveness timer like the other input events.

The touch events also have a callback to the UI signaling if the event was used
or not: PageClient::doneWithTouchEvent().
This is similar to what is done with key events (PageClient::doneWithKeyEvent()).

  • Shared/NativeWebTouchEvent.h: Copied from Source/WebKit2/Shared/qt/WebEventFactoryQt.h. (WebKit::NativeWebTouchEvent::nativeEvent):
  • Shared/qt/NativeWebTouchEventQt.cpp: Copied from Source/WebKit2/Shared/qt/WebEventFactoryQt.h. (WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
  • Shared/qt/WebEventFactoryQt.cpp: (WebKit::webEventTypeForEvent): (WebKit::WebEventFactory::createWebTouchEvent):
  • Shared/qt/WebEventFactoryQt.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleTouchEvent): (WebKit::WebPageProxy::didReceiveEvent):
  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp: (QDesktopWebPageProxy::doneWithTouchEvent):
  • UIProcess/qt/qdesktopwebpageproxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp: (QTouchWebPageProxy::doneWithTouchEvent): (QTouchWebPageProxy::touchEvent):
  • UIProcess/qt/qtouchwebpageproxy.h:
  • WebKit2.pro:
1:03 AM Changeset in webkit [90549] by abarth@webkit.org
  • 8 edits
    1 delete in trunk/Tools

2011-07-07 Adam Barth <​abarth@webkit.org>

Remove style_references.py
​https://bugs.webkit.org/show_bug.cgi?id=64070

Reviewed by Eric Seidel.

We never really adopted the _references design, and this file is a bit
of an orphan at this point.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/style/checkers/python.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  • Scripts/webkitpy/style/main_unittest.py:
  • Scripts/webkitpy/style_references.py: Removed.
12:44 AM Changeset in webkit [90548] by eric@webkit.org
  • 2 edits
    1 add in trunk/Tools

2011-07-07 Eric Seidel <​eric@webkit.org>

Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=64056

Unreviewed.

I had written this unittest prior to landing my change, but
had named it qt_unitest.py, so it wasn't running (nor was
it added to my git repo).

Once I fixe the name of the unittest file, it was very easy
to fix the error in webkit.py (which already had a FIXME).

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
12:26 AM Changeset in webkit [90547] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-07-07 Eric Seidel <​eric@webkit.org>

Unreviewed. Add more debug logging about which test expectations we're using.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
12:25 AM Changeset in webkit [90546] by abarth@webkit.org
  • 8 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Remove unexpected_results.json
​https://bugs.webkit.org/show_bug.cgi?id=64065

Reviewed by Eric Seidel.

No one should be using this file any more. This patch removes it from
the face of the earth. This patch also removes two NRWT-specific
command line options that were implemented using
unexpected_results.json.

  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
12:16 AM Changeset in webkit [90545] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-07-07 Adam Barth <​abarth@webkit.org>

REGRESSION(90520): chromium GPU tests produce output in the LayoutTests directory
​https://bugs.webkit.org/show_bug.cgi?id=64067

Reviewed by Eric Seidel.

The author of r90520 forgot to change the chromium_gpu.py implemenation
of this method as well.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
12:07 AM Changeset in webkit [90544] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-07 Oleg Romashin <​romaxa@gmail.com>

Fix InspectorInstrumentation compilation.
​https://bugs.webkit.org/show_bug.cgi?id=64033

Reviewed by Yury Semikhatsky.

No new tests. just compile fix.

  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):

Jul 6, 2011:

11:56 PM Changeset in webkit [90543] by eric@webkit.org
  • 13 edits in trunk/Tools

2011-07-06 Eric Seidel <​eric@webkit.org>

Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=64056

Reviewed by Adam Barth.

This fixes the MacPort's version of baseline_search_path to include
wk2 fallback like WebKitPort's does. This also re-works the QtPort
to set self._name (as other ports do) so that WebKitPort's default
implementations will understand Qt operating system flavors correctly
(including when running wk2 tests).

In trying to test this, I realized that nearly all of our port-tests
use the default FileSystem(), User() and Executive() objects, which
is really bad, because they expose details of your system in the unittest results!

Once I fixed many of the Port() calls to pass MockFileSystem(), then
MacPort.test_tests_for_other_platforms started failing, and I had to
teach MockFileSystem.glob how to handle directories to make it work again.

I removed the useless PortTestCase.test_baseline_search_path and replaced
it with more useful test_baseline_search_path tests in MacPortTest and QtPortTest.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/to_be_moved/deduplicate_tests.py:
  • Scripts/webkitpy/tool/mocktool.py:
11:19 PM Changeset in webkit [90542] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Wean rebaseline-server off unexpected_results.json
​https://bugs.webkit.org/show_bug.cgi?id=64063

Reviewed by Eric Seidel.

In the process of changing this code to use full_results.json, I
noticed that the code was broken (because it wasn't tested). This
patch also adds test coverage for the broken code.

  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
10:36 PM Changeset in webkit [90541] by commit-queue@webkit.org
  • 11 edits
    5 adds in trunk

2011-07-06 Mihnea Ovidenie <​mihnea@adobe.com>

Reviewed by David Hyatt.

[CSSRegions] Parse flow property
​https://bugs.webkit.org/show_bug.cgi?id=61730

  • fast/regions/script-tests/TEMPLATE.html: Added.
  • fast/regions/script-tests/webkit-flow-parsing.js: Added. (test): (testComputedStyle): (testNotInherited):
  • fast/regions/webkit-flow-parsing-expected.txt: Added.
  • fast/regions/webkit-flow-parsing.html: Added.

2011-07-06 Mihnea Ovidenie <​mihnea@adobe.com>

Reviewed by David Hyatt.

[CSSRegions] Parse flow property
​https://bugs.webkit.org/show_bug.cgi?id=61730

Test: fast/regions/webkit-flow-parsing.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFlowThread):
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::flowThread): (WebCore::InheritedFlags::setFlowThread): (WebCore::InheritedFlags::initialFlowThread):
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h:
10:24 PM Changeset in webkit [90540] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-07-06 Adam Barth <​abarth@webkit.org>

Unreviewed. Rolled DEPS.

  • DEPS:
10:24 PM Changeset in webkit [90539] by abarth@webkit.org
  • 5 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Wean resultsjsonparser off unexpected_results.json
​https://bugs.webkit.org/show_bug.cgi?id=64061

Reviewed by Eric Seidel.

We're about to delete unexpected_results.json, so we need to remove all
the users.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
9:42 PM Changeset in webkit [90538] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Cleanup result_summary.py
​https://bugs.webkit.org/show_bug.cgi?id=64057

Reviewed by Eric Seidel.

This class had a bunch of out-of-date docstrings that no longer make
any sense.

  • Scripts/webkitpy/layout_tests/models/result_summary.py:
9:33 PM Changeset in webkit [90537] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Tweak the ChangeLog for DEPS rolls to say "Unreviewed" so that the
patches can be landed by the commit-queue.

  • Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
9:22 PM Changeset in webkit [90536] by morrita@google.com
  • 3 edits
    2 adds in trunk

2011-07-06 MORITA Hajime <​morrita@google.com>

[ShadowContentElement] Redundant RenderText objects are created on the content boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=63977

Reviewed by Dimitri Glazkov.

This test have two set of fixture DOM tree:
One is for shadow tree which has one content element,
another is for light DOM tree, whose root is to have a shadow DOM.

Then the test makes 2 complete DOM trees (DOM tree with shadow and
flattened dom) for each combination of the fixture items. And
compare their layout result.

  • fast/dom/shadow/content-element-renderers-expected.txt: Added.
  • fast/dom/shadow/content-element-renderers.html: Added.

2011-07-06 MORITA Hajime <​morrita@google.com>

[ShadowContentElement] Redundant RenderText objects are created on the content boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=63977

Reviewed by Dimitri Glazkov.

NodeRenderingContext::nextRenderer() and previousRenderer() didn't work well
when it crosses content elements:

  • It doesn't step into forwarded children of ShadowContentElement.
  • It doesn't step out from traversing forwarded children to neighbors of the content element of that forwarded chidren.

This change makes it to step into and out from content element.

Test: fast/dom/shadow/content-element-renderers.html

  • dom/NodeRenderingContext.cpp: (WebCore::firstRendererOf): Added (WebCore::lastRendererOf): Added (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::previousRenderer):
9:20 PM Changeset in webkit [90535] by commit-queue@webkit.org
  • 15 edits
    4 adds in trunk

2011-07-06 Juan C. Montemayor <​jmont@apple.com>

ASSERT_NOT_REACHED running test 262
​https://bugs.webkit.org/show_bug.cgi?id=63951

Added a test to check compliance with reserved words in strict mode.
Updated test results.

Reviewed by Gavin Barraclough.

  • fast/js/kde/parse-expected.txt:
  • fast/js/reserved-words-as-property-expected.txt:
  • fast/js/reserved-words-strict-expected.txt: Added.
  • fast/js/reserved-words-strict.html: Added.
  • fast/js/script-tests/reserved-words-strict.js: Added. (isReserved):
  • platform/chromium/fast/js/reserved-words-strict-expected.txt: Added.
  • sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T5-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T4-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13-expected.txt:

2011-07-06 Juan C. Montemayor <​jmont@apple.com>

ASSERT_NOT_REACHED running test 262
​https://bugs.webkit.org/show_bug.cgi?id=63951

Added a case to the switch statement where the code was failing. Fixed
some logic as well that gave faulty error messages.

Reviewed by Gavin Barraclough.

  • parser/JSParser.cpp: (JSC::JSParser::getTokenName): (JSC::JSParser::updateErrorMessageSpecialCase): (JSC::JSParser::updateErrorMessage):
9:11 PM Changeset in webkit [90534] by abarth@webkit.org
  • 31 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Normalize callers of logging.getLogger to use name
​https://bugs.webkit.org/show_bug.cgi?id=64054

Reviewed by Eric Seidel.

Most callers were already using name. This patch makes everyone
consistent.

  • Scripts/webkitpy/common/checkout/diff_parser.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/net/statusserver.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/file_lock.py:
  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/models/result_summary.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/http_lock.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/servers/http_server.py:
  • Scripts/webkitpy/layout_tests/servers/http_server_base.py:
  • Scripts/webkitpy/layout_tests/servers/websocket_server.py:
  • Scripts/webkitpy/layout_tests/views/printing.py:
  • Scripts/webkitpy/python24/versioning.py:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/style/patchreader.py:
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
9:04 PM Changeset in webkit [90533] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-07-06 Filip Pizlo <​fpizlo@apple.com>

DFG JIT implementation of op_call results in regressions on sunspider
controlflow-recursive.
​https://bugs.webkit.org/show_bug.cgi?id=64039

Reviewed by Gavin Barraclough.

  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::isSmallInt32Constant): (JSC::DFG::ByteCodeParser::parseBlock):
  • dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::isInteger):
8:55 PM Changeset in webkit [90532] by abarth@webkit.org
  • 24 edits
    8 moves
    2 adds in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Move model classes out of layout_package and into models
​https://bugs.webkit.org/show_bug.cgi?id=64053

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/controllers/worker.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/result_summary.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_input.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/models: Added.
  • Scripts/webkitpy/layout_tests/models/init.py: Added.
  • Scripts/webkitpy/layout_tests/models/result_summary.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/result_summary.py.
  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py.
  • Scripts/webkitpy/layout_tests/models/test_failures.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py.
  • Scripts/webkitpy/layout_tests/models/test_failures_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py.
  • Scripts/webkitpy/layout_tests/models/test_input.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_input.py.
  • Scripts/webkitpy/layout_tests/models/test_results.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results.py.
  • Scripts/webkitpy/layout_tests/models/test_results_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py.
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/views/printing.py:
  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
8:49 PM Changeset in webkit [90531] by gyuyoung.kim@samsung.com
  • 5 edits in trunk

2011-07-06 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

[EFL] Add Fullscreen API feature
​https://bugs.webkit.org/show_bug.cgi?id=63975

This is just to add disabled ENABLE_FULLSCREEN_API to OptionEFl.cmake.
ENABLE_FULLSCREEN_API will be enabled after finishing missing implementations.

Reviewed by Adam Barth.

  • Source/cmake/OptionsEfl.cmake: Add disabled ENABLE_FULLSCREEN_API feature.
  • Source/cmakeconfig.h.cmake: ditto.

2011-07-06 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

[EFL] Add Fullscreen API feature
​https://bugs.webkit.org/show_bug.cgi?id=63975

Add needed files for enabling ENABLE_FULLSCREEN_API feature.

Reviewed by Adam Barth.

  • CMakeLists.txt: Add RenderFullScreen.cpp, fullscreen.css
8:48 PM Changeset in webkit [90530] by eae@chromium.org
  • 17 edits in trunk/Source/WebCore

2011-07-06 Emil A Eklund <​eae@chromium.org>

Switch absoluteRects to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=64035

Reviewed by Eric Seidel.

Move absoluteRects over to new layout unit abstraction.
Add flooredLayoutPoint, mapped to flooredIntPoint.

No new tests, no functionality changes.

  • rendering/LayoutTypes.h: (WebCore::flooredLayoutPoint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect):
  • rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
  • rendering/RenderView.h:
  • rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::absoluteRects):
  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteRects):
  • rendering/svg/RenderSVGModelObject.h:
8:42 PM Changeset in webkit [90529] by commit-queue@webkit.org
  • 17 edits in trunk/Source/JavaScriptCore

2011-07-06 Filip Pizlo <​fpizlo@apple.com>

DFG JIT does not support method_check
​https://bugs.webkit.org/show_bug.cgi?id=63972

Reviewed by Gavin Barraclough.

  • assembler/CodeLocation.h: (JSC::CodeLocationPossiblyNearCall::CodeLocationPossiblyNearCall):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
  • bytecode/CodeBlock.h: (JSC::MethodCallLinkInfo::MethodCallLinkInfo): (JSC::MethodCallLinkInfo::seenOnce): (JSC::MethodCallLinkInfo::setSeen):
  • dfg/DFGAliasTracker.h: (JSC::DFG::AliasTracker::recordGetMethod):
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::cachedGetById): (JSC::DFG::JITCodeGenerator::cachedGetMethod):
  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::addMethodGet): (JSC::DFG::JITCompiler::MethodGetRecord::MethodGetRecord):
  • dfg/DFGNode.h: (JSC::DFG::Node::hasIdentifier):
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp: (JSC::DFG::dfgRepatchGetMethodFast): (JSC::DFG::tryCacheGetMethod): (JSC::DFG::dfgRepatchGetMethod):
  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
  • jit/JITWriteBarrier.h: (JSC::JITWriteBarrier::set):
8:18 PM Changeset in webkit [90528] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-07-06 Dirk Pranke <​dpranke@chromium.org>

nrwt: fix typo preventing http startup on windows
​https://bugs.webkit.org/show_bug.cgi?id=64050

Reviewed by Eric Siedel.

NRWT checks whether it needs to start the servers by looking
for "/http/" in the test names. After r90520, the leading slash
is not present, so the check isn't quite right.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
7:49 PM Changeset in webkit [90527] by dpranke@chromium.org
  • 10 edits in trunk/Tools

2011-07-06 Dirk Pranke <​dpranke@chromium.org>

nrwt: remove --use-apache from the command line
​https://bugs.webkit.org/show_bug.cgi?id=63358

Reviewed by Adam Barth.

Re-land the fix in bug 63358 - the prior fix was flawed in that
we were trying to start the http server during check_sys_deps()
but not actually setting up the environment properly. This
broken prior to this change, but exposed by it, since the patch
changes the chromium port to call the base class's checks.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:45 PM Changeset in webkit [90526] by abarth@webkit.org
  • 6 edits
    4 moves
    2 adds in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Move view-related code out of layout_package and into views
​https://bugs.webkit.org/show_bug.cgi?id=64051

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/printing.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/views: Added.
  • Scripts/webkitpy/layout_tests/views/init.py: Added.
  • Scripts/webkitpy/layout_tests/views/metered_stream.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream.py.
  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py.
  • Scripts/webkitpy/layout_tests/views/printing.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py.
  • Scripts/webkitpy/layout_tests/views/printing_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py.
7:32 PM Changeset in webkit [90525] by eae@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-07-06 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Switch offsetFromContainer and related to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=63659

Switch offsetFromContainer and related mapping methods to new layout unit
abstraction.

No new tests, no functionality changes.

  • rendering/LayoutTypes.h: (WebCore::enclosingLayoutRect): (WebCore::roundedLayoutPoint): (WebCore::roundedLayoutUnit): Add LayoutUnit versions of enclosingIntRect, roundedIntPoint and lroundf. For now these map to their int counterpart but once we switch to float or fixed point they'll be no-ops and eventually will be removed.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint): (WebCore::RenderBox::offsetFromContainer):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::linesBoundingBox): (WebCore::RenderInline::offsetFromContainer): (WebCore::RenderInline::mapLocalToContainer): (WebCore::RenderInline::mapAbsoluteToLocalPoint): (WebCore::RenderInline::relativePositionedInlineOffset):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetFromContainer): (WebCore::RenderObject::offsetFromAncestorContainer):
  • rendering/RenderObject.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::offsetFromContainer):
  • rendering/RenderTableCell.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::convertToPaintingRect):
7:24 PM Changeset in webkit [90524] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Add goofy comments to explain why we have these files.

  • Scripts/webkitpy/layout_tests/controllers/init.py:
  • Scripts/webkitpy/layout_tests/layout_package/init.py:
7:16 PM Changeset in webkit [90523] by abarth@webkit.org
  • 3 edits
    8 moves
    2 adds in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Move a bunch of classes out of layout_tests.layout_package and into layout_tests.controllers
​https://bugs.webkit.org/show_bug.cgi?id=64048

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/controllers: Added.
  • Scripts/webkitpy/layout_tests/controllers/init.py: Added.
  • Scripts/webkitpy/layout_tests/controllers/manager.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py.
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py.
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py.
  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py.
  • Scripts/webkitpy/layout_tests/controllers/message_broker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker.py.
  • Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py.
  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py.
  • Scripts/webkitpy/layout_tests/controllers/worker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py.
  • Scripts/webkitpy/layout_tests/layout_package/manager.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/worker.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:10 PM Changeset in webkit [90522] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-07-06 Levi Weintraub <​leviw@chromium.org>

Switch FrameSelection to new Layout Types
​https://bugs.webkit.org/show_bug.cgi?id=64043

Reviewed by Eric Seidel.

Switching the selection classes to the new layout types. Changing
NoXPosForVerticalArrowNavigation to a static inline since as it stood it violated
our global initializer rule when converted to numeric_limits from INT_MIN.

No new tests, no functionality changes.

  • editing/FrameSelection.cpp: (WebCore::FrameSelection::modify): (WebCore::absoluteCaretY): (WebCore::FrameSelection::lineDirectionPointForBlockDirectionNavigation): (WebCore::CaretBase::clearCaretRect): (WebCore::CaretBase::updateCaretRect): (WebCore::FrameSelection::localCaretRect): (WebCore::CaretBase::absoluteBoundsForLocalRect): (WebCore::FrameSelection::absoluteCaretBounds): (WebCore::repaintRectForCaret): (WebCore::CaretBase::caretRepaintRect): (WebCore::FrameSelection::recomputeCaretRect): (WebCore::FrameSelection::paintCaret): (WebCore::CaretBase::paintCaret): (WebCore::FrameSelection::contains): (WebCore::DragCaretController::paintDragCaret): (WebCore::FrameSelection::bounds): (WebCore::FrameSelection::revealSelection):
  • editing/FrameSelection.h: (WebCore::CaretBase::localCaretRectWithoutUpdate):
6:50 PM Changeset in webkit [90521] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Attempt to fix unittest on Leopard. Let's enumerate the keys in sorted
order so the test results are predictable.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
6:22 PM Changeset in webkit [90520] by dpranke@chromium.org
  • 35 edits in trunk/Tools

2011-07-06 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Siedel.

nrwt: make the code be consistent about using test names instead of filenames or paths

​https://bugs.webkit.org/show_bug.cgi?id=63597

It can be hard to figure out where in the code we're assuming
test names are listed as unix-style relative filenames and where
they are either absolute paths or relative paths following the
host filesystem convention.

This patch changes things so that everything outside of the
Port object uses (and must assume) unix-style relative
filenames (with one exception, which is specifying host-local
filenames as a list of test arguments on the command line).

This should make things clearer and more consistent, and also
removes a lot of path conversion calls.

The changes in this patch outside of port/base.py are largely
cosmetic changes of "filename" to "test". We add a few routines
to the base Port implementation to manipulate test names to
split them, figure out if we're referring to a directory of
tests, etc.

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_input.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
5:36 PM Changeset in webkit [90519] by ctguil@chromium.org
  • 2 edits in trunk/Tools

2011-07-06 Chris Guillory <​ctguil@chromium.org>

No review necessary.

Adding myself to committers list in committers.py.
​https://bugs.webkit.org/show_bug.cgi?id=63478

  • Scripts/webkitpy/common/config/committers.py:
5:09 PM Changeset in webkit [90518] by jnd@chromium.org
  • 7 edits in trunk

2011-07-06 Johnny Ding <​jnd@chromium.org>

​https://bugs.webkit.org/show_bug.cgi?id=63857
Remove some crash expectation after implementing "createPopupMenu"

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:

2011-07-06 Johnny Ding <​jnd@chromium.org>

​https://bugs.webkit.org/show_bug.cgi?id=63857
Check WebWidgetClient before calling it to close widget.

Reviewed by Tony Chang.

  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::popupClosed):

2011-07-06 Johnny Ding <​jnd@chromium.org>

​https://bugs.webkit.org/show_bug.cgi?id=63857
Implement createPopupMenu for Chromium DRT.

Reviewed by Tony Chang.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createPopupMenu): (WebViewHost::~WebViewHost):
  • DumpRenderTree/chromium/WebViewHost.h:
4:55 PM Changeset in webkit [90517] by leviw@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-07-06 Levi Weintraub <​leviw@chromium.org>

Switch Overflow and FrameRect methods in InlineBox to Layout Units
​https://bugs.webkit.org/show_bug.cgi?id=64034

Reviewed by Eric Seidel.

Switching Overflow and FrameRect methods on InlineBox to new Layout Unit abstraction and
cleaning up some compilation errors that crop up when building with floating point layout units.

No new tests, no functionality changes.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::sizingBox):
  • dom/Document.h:
  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::drawNodeHighlight):
  • page/animation/AnimationBase.cpp: (WebCore::blendFunc):
  • platform/ScrollView.h: (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight):
  • platform/ScrollableArea.h: (WebCore::ScrollableArea::visibleHeight): (WebCore::ScrollableArea::visibleWidth):
  • platform/graphics/FloatPoint.h: Adding FloatPoint and FloatSize move[By] functions (WebCore::FloatPoint::move): (WebCore::FloatPoint::moveBy):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::computePreferredLogicalWidths): (WebCore::AutoTableLayout::layout):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::layoutOverflowRect): (WebCore::InlineFlowBox::logicalLeftLayoutOverflow): (WebCore::InlineFlowBox::logicalRightLayoutOverflow): (WebCore::InlineFlowBox::logicalTopLayoutOverflow): (WebCore::InlineFlowBox::logicalBottomLayoutOverflow): (WebCore::InlineFlowBox::logicalLayoutOverflowRect): (WebCore::InlineFlowBox::visualOverflowRect): (WebCore::InlineFlowBox::logicalLeftVisualOverflow): (WebCore::InlineFlowBox::logicalRightVisualOverflow): (WebCore::InlineFlowBox::logicalTopVisualOverflow): (WebCore::InlineFlowBox::logicalBottomVisualOverflow): (WebCore::InlineFlowBox::logicalVisualOverflowRect): (WebCore::InlineFlowBox::frameRectIncludingLineHeight): (WebCore::InlineFlowBox::logicalFrameRectIncludingLineHeight):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault): (WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault): (WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault): (WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):
4:49 PM Changeset in webkit [90516] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Mihai Parparita <​mihaip@chromium.org>

Update Chromium GPU expectations with downstream changes
(​http://crrev.com/91625/).

  • platform/chromium/test_expectations.txt:
4:38 PM Changeset in webkit [90515] by eae@chromium.org
  • 48 edits in trunk/Source/WebCore

2011-07-06 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Switch nodeAtPoint to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=63663

No new tests, no functionality changes.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/InlineTextBox.h:
  • rendering/LayoutTypes.h: (WebCore::toLayoutSize): (WebCore::toLayoutPoint): (WebCore::roundedLayoutPoint): (WebCore::roundedLayoutUnit):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
  • rendering/RenderBox.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint):
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::nodeAtPoint):
  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::nodeAtPoint):
  • rendering/RenderObject.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::nodeAtPoint):
  • rendering/RenderTable.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h: (WebCore::RenderText::nodeAtPoint):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::nodeAtPoint):
  • rendering/RenderWidget.h:
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint):
  • rendering/RootInlineBox.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::nodeAtFloatPoint): (WebCore::RenderSVGForeignObject::nodeAtPoint):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::nodeAtPoint):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtPoint):
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint):
  • rendering/svg/SVGInlineTextBox.h:
4:37 PM Changeset in webkit [90514] by mihaip@chromium.org
  • 9 edits in trunk/Tools

2011-07-06 Mihai Parparita <​mihaip@chromium.org>

Unreviewed, rolling out r90503.
​http://trac.webkit.org/changeset/90503
​https://bugs.webkit.org/show_bug.cgi?id=63358

Makes Chromium Windows canary bots hang.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4:34 PM Changeset in webkit [90513] by abarth@webkit.org
  • 7 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Move buildbot URL in webkitpy to config.urls
​https://bugs.webkit.org/show_bug.cgi?id=64041

Reviewed by Eric Seidel.

This patch prepares for using the buildbot class to talk to the
Chromium buildbots.

  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
4:25 PM Changeset in webkit [90512] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Sreeram Ramachandran <​sreeram@chromium.org>

Fix fast/loader/page-dismissal-modal-dialogs.html.
​https://bugs.webkit.org/show_bug.cgi?id=64020

Fix by removing an unnecessary call to setPopupBlockingEnabled() (which
doesn't seem to be implemented in WebKit2's layoutTestController).

Reviewed by Adam Roben.

  • fast/loader/page-dismissal-modal-dialogs.html:
4:21 PM Changeset in webkit [90511] by jamesr@google.com
  • 2 edits in branches/chromium/782/Source/WebKit/chromium

Merge 90185 - 2011-06-30 John Bates <​jbates@google.com>

Reviewed by James Robinson.

Chromium bug: Compositing on a lost context causes latch deadlocks.
The cause of deadlock was that a setLatch command is added to the lost
compositor GL context, and a waitLatch would never complete on a child context.
This change checks whether the compositor context is in error state before
doing the compositing.
​https://bugs.webkit.org/show_bug.cgi?id=63681

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):

TBR=​commit-queue@webkit.org
BUG=87996
Review URL: ​http://codereview.chromium.org/7316012

4:14 PM Changeset in webkit [90510] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix, add the correct path to the waf build settings.

4:13 PM Changeset in webkit [90509] by kevino@webkit.org
  • 2 edits in trunk/Source/WebKit/wx

[wx] Unreviewed build fix. Don't expose the kit function to the swig wrappers.

4:09 PM Changeset in webkit [90508] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Add missing include.

  • Scripts/webkitpy/tool/bot/irc_command.py:
3:49 PM Changeset in webkit [90507] by abarth@webkit.org
  • 8 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Add roll-chromium-deps command to sheriff-bot
​https://bugs.webkit.org/show_bug.cgi?id=64037

Reviewed by Eric Seidel.

Lo, and the DEPS were rolled on command.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/commands/roll.py:
  • Scripts/webkitpy/tool/commands/roll_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
3:34 PM Changeset in webkit [90506] by eric@webkit.org
  • 13 edits
    1 add in trunk/Tools

2011-07-06 Eric Seidel <​eric@webkit.org>

Split Driver, DriverOutput and DriverInput out into a new driver.py file
​https://bugs.webkit.org/show_bug.cgi?id=64031

Reviewed by Adam Barth.

This ended up kinda large and I'm happy to break it up if desired.

As part of cleaning up the Port module, I split Driver, DriverInput and DriverOutput
out into its own driver.py file.

I also cleaned up how we import Port objects, by making port/init.py
expose Port, Driver, DriverInput, and DriverOutput. I removed exposure of
some various test objects as they were causing circular dependencies.
base.py is now an implementation detail of port. No longer is "base" referenced
anywhere in the code.

I also made Driver.init non-virtual so that sub-classers could all share
the data storage on Driver. This more closely matches how other subclasses
work throughout our python code.

Standard line-unwrapping and doc-string removal as I went through the code.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/driver.py: Added.
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3:33 PM Changeset in webkit [90505] by enne@google.com
  • 9 edits in trunk/Source

2011-07-06 Adrienne Walker <​enne@google.com>

[chromium] Add compositor texture manager soft limits and lost focus reclaiming
​https://bugs.webkit.org/show_bug.cgi?id=64009

Reviewed by James Robinson.

Add a soft limit for texture memory. Unprotected textures will get
reclaimed when above this limit. Increase the hard limit for maximum
texture memory as well, now that there is a better heuristic and
textures are reclaimed from tabs without focus.

Landing this for ​vangelis@chromium.org.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::releaseTextures): (WebCore::LayerRendererChromium::initializeSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::protectTileTextures):
  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::TextureManager): (WebCore::TextureManager::requestTexture):
  • platform/graphics/chromium/TextureManager.h: (WebCore::TextureManager::create):

2011-07-06 Adrienne Walker <​enne@google.com>

[chromium] Add compositor texture manager soft limits and lost focus reclaiming
​https://bugs.webkit.org/show_bug.cgi?id=64009

Reviewed by James Robinson.

Reclaim textures when the tab loses focus.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setVisibilityState):
2:57 PM Changeset in webkit [90504] by Adam Roben
  • 2 edits in trunk/Tools

Clear TestFailures's getNumberOfFailingTests cache

Now that we support NRWT, we need to clear out old zero values for the NRWT bots that might
have been cached by old versions of TestFailures.

Fixes <​http://webkit.org/b/64029> TestFailures page still doesn't show NRWT bots if you've
used it recently

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Added a .version property to the cache data
that must match the current version. Otherwise we'll ignore the cached data.

2:46 PM Changeset in webkit [90503] by dpranke@chromium.org
  • 9 edits in trunk/Tools

2011-06-24 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

nrwt: remove --use-apache from the command line
​https://bugs.webkit.org/show_bug.cgi?id=63358

This change removes the --use-apache command line argument. It
was initially put in when we were trying to get the cygwin
apache instance to work with Chromium win, but that code has
bitrotted and doesn't work at all now.

Arguably we should remove all of the code to allow for a choice
of web servers, but since we may still want to switch off of
LigHTTPd at some point on Windows, I'll leave the rest in for
now (or at least yank it in a different change.)

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:40 PM Changeset in webkit [90502] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-07-06 Filip Pizlo <​fpizlo@apple.com>

DFG JIT op_call implementation will flush registers even when those registers are dead
​https://bugs.webkit.org/show_bug.cgi?id=64023

Reviewed by Gavin Barraclough.

  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::emitCall):
  • dfg/DFGJITCodeGenerator.h: (JSC::DFG::JITCodeGenerator::integerResult): (JSC::DFG::JITCodeGenerator::noResult): (JSC::DFG::JITCodeGenerator::cellResult): (JSC::DFG::JITCodeGenerator::jsValueResult): (JSC::DFG::JITCodeGenerator::doubleResult):
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
2:39 PM Changeset in webkit [90501] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Mihai Parparita <​mihaip@chromium.org>

Fix duplicate Chromium expectations from r90500 and add additional flakiness
expectations.

  • platform/chromium/test_expectations.txt:
2:20 PM Changeset in webkit [90500] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Mihai Parparita <​mihaip@chromium.org>

Add Chromium Windows 7 timeout expectations.

  • platform/chromium/test_expectations.txt:
2:19 PM Changeset in webkit [90499] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-07-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Web Inspector: fixing typo introduced in the r90397.

  • inspector/front-end/StylesSidebarPane.js:
2:16 PM Changeset in webkit [90498] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-07-06 Mike Reed <​reed@google.com>

[skia] don't include deprecated header
​https://bugs.webkit.org/show_bug.cgi?id=64025

Reviewed by James Robinson.

No new tests. Just removing #include of an unused header that will be gone soon

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
  • platform/graphics/skia/PlatformContextSkia.cpp:
2:13 PM Changeset in webkit [90497] by cdn@chromium.org
  • 10 edits in trunk/Source

2011-06-30 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Fisher.

Add versioning to Chromium clipboard and prevent polling from inside events.
​https://bugs.webkit.org/show_bug.cgi?id=63738

  • public/WebClipboard.h: (WebKit::WebClipboard::getSequenceNumber):
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::clipboardGetSequenceNumber):

2011-06-30 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Fisher.

Add versioning to Chromium clipboard and prevent polling from inside events.
​https://bugs.webkit.org/show_bug.cgi?id=63738

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::getSequenceNumber):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::ClipboardChromium): (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::platformClipboardChanged):
  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/DataTransferItemChromium.cpp: (WebCore::DataTransferItemChromium::getAsString): (WebCore::DataTransferItemChromium::getAsFile):
  • platform/chromium/PlatformBridge.h:
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
2:10 PM Changeset in webkit [90496] by Dimitri Glazkov
  • 4 edits
    2 adds in trunk/Tools

2011-07-06 Dimitri Glazkov <Dimitri Glazkov>

garden-o-matic should use a favicon to indicate current state.
​https://bugs.webkit.org/show_bug.cgi?id=64027

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added blurb about icons.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added setting icon state.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Allowed the use of favicons.
2:09 PM Changeset in webkit [90495] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Daniel Bates <​dbates@rim.com>

Fix webkitpy error after changeset 90483 <​http://trac.webkit.org/changeset/90483>; Add missing
parameter to _fetch_file_from_results lamdba function.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1:58 PM Changeset in webkit [90494] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Mihai Parparita <​mihaip@chromium.org>

Add Chromium flaky expectations.

  • platform/chromium/test_expectations.txt:
1:58 PM Changeset in webkit [90493] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix. Generate the proper install_name for dylibs on Mac.

1:56 PM Changeset in webkit [90492] by jamesr@google.com
  • 17 edits in trunk/Source/WebCore

2011-07-01 James Robinson <​jamesr@chromium.org>

Reviewed by Stephen White.

[chromium] Externalize layer visibility calculation
​https://bugs.webkit.org/show_bug.cgi?id=63847

This moves the layer visibility calculation from the layer itself out to LayerRendererChromium, like the other
calculated properties. Previously, we were doing this calculating at paint time and again at draw time and
relying on the fact that this produced the same value. This avoids the redundant calculation.

Covered by existing compositing/ layout tests.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::tilingTransform): (WebCore::ContentLayerChromium::contentBounds): (WebCore::ContentLayerChromium::updateLayerSize): (WebCore::ContentLayerChromium::draw): (WebCore::ContentLayerChromium::setTilingOption): (WebCore::ContentLayerChromium::setIsMask):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::contentBounds):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::pushPropertiesTo):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::contentBounds): (WebCore::LayerChromium::visibleLayerRect): (WebCore::LayerChromium::setVisibleLayerRect): (WebCore::LayerChromium::draw):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::calculateVisibleLayerRect): (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::drawLayer):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: (WebCore::CCCanvasLayerImpl::draw):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::draw):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::contentBounds): (WebCore::CCLayerImpl::setContentBounds): (WebCore::CCLayerImpl::visibleLayerRect): (WebCore::CCLayerImpl::setVisibleLayerRect): (WebCore::CCLayerImpl::doubleSided): (WebCore::CCLayerImpl::setDoubleSided):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: (WebCore::CCPluginLayerImpl::draw):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::draw):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:
1:50 PM Changeset in webkit [90491] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Xan Lopez <​xlopez@igalia.com>

[GTK] Only set env. variables in start when strictly needed
​https://bugs.webkit.org/show_bug.cgi?id=64026

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/gtk.py: add a setup_environ_for_server method in GtkPort and set as many env. variables as possible there.
1:49 PM Changeset in webkit [90490] by rniwa@webkit.org
  • 1 edit
    18 copies
    1 add in trunk/LayoutTests

2011-07-06 Ryosuke Niwa <​rniwa@webkit.org>

REGRESSION (r90275): 18 editing tests failing on Windows 7 Release (WebKit2 Tests)
​https://bugs.webkit.org/show_bug.cgi?id=64019

These tests just need rebaselines. While Windows WebKit port ignores editing delegate dumps, Windows WebKit2 does not.
Since rebaselined in r90275 should only affect Mac port, we need to undo rebaselines done in r90275 for Windows port.

  • platform/win/editing/deleting/delete-br-002-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-br-002-expected.txt.
  • platform/win/editing/deleting/delete-br-004-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-br-004-expected.txt.
  • platform/win/editing/deleting/delete-br-005-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-br-005-expected.txt.
  • platform/win/editing/deleting/delete-br-006-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-br-006-expected.txt.
  • platform/win/editing/deleting/delete-br-009-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-br-009-expected.txt.
  • platform/win/editing/deleting/delete-br-010-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-br-010-expected.txt.
  • platform/win/editing/inserting/insert-3800346-fix-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-3800346-fix-expected.txt.
  • platform/win/editing/inserting/insert-at-end-01-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-at-end-01-expected.txt.
  • platform/win/editing/inserting/insert-at-end-02-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-at-end-02-expected.txt.
  • platform/win/editing/inserting/insert-div-010-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-div-010-expected.txt.
  • platform/win/editing/inserting/insert-div-013-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-div-013-expected.txt.
  • platform/win/editing/inserting/insert-div-015-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-div-015-expected.txt.
  • platform/win/editing/inserting/insert-div-019-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-div-019-expected.txt.
  • platform/win/editing/inserting/insert-paragraph-03-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-paragraph-03-expected.txt.
  • platform/win/editing/selection/4932260-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4932260-1-expected.txt.
  • platform/win/editing/selection/move-by-word-001-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/move-by-word-001-expected.txt.
  • platform/win/editing/selection/triple-click-in-pre-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/triple-click-in-pre-expected.txt.
  • platform/win/editing/style: Added.
  • platform/win/editing/style/create-block-for-style-008-expected.txt: Copied from LayoutTests/platform/mac/editing/style/create-block-for-style-008-expected.txt.
1:42 PM Changeset in webkit [90489] by Adam Roben
  • 5 edits
    1 add in trunk/Tools

Teach TestFailures how to load, parse, and interpret NRWT test results

Fixes <​http://webkit.org/b/61877> TestFailures page doesn't show testers that use
new-run-webkit-tests

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.failureDiagnosisTextAndURL): Added support for the new 'flaky' failure
type. For now we don't account for image-only flakes (but TestFailures doesn't deal with
pixel tests at all currently).
(Builder.prototype.getNumberOfFailingTests): Relaxed the regex used for parsing the number
of failing tests from the buildbot output. Make sure not to count "new passes" (a new
category introduced by NRWT) as failures.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Moved a bunch of code from here to
_fetchAndParseORWTResults. This function now attempts to load NRWT results, then falls back
to loading ORWT results.
(LayoutTestResultsLoader.prototype._fetchAndParseNRWTResults): Added. Tries to load and
parse the full_results.json file for the given build.
(LayoutTestResultsLoader.prototype._fetchAndParseORWTResults): Added. Code came from start.
Fixed a bug along the way where we were sometimes calling the error callback instead of the
success callback when all tests passed.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Added.

(NRWTResultsParser): Do-nothing constructor.
(NRWTResultsParser.prototype.parse): Uses eval() (eww!) to get the test results out of the
JS string, then iterates over all the tests in the results data and builds up a data
structure matching what ORWTResultsParser returns.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(Array.prototype.contains):
(String.prototype.contains):
Added these simple helper functions.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

NRWTResultsParser.js.

1:42 PM Changeset in webkit [90488] by Adam Roben
  • 3 edits
    1 add in trunk/Tools

Extract code to parse ORWT's results.html file into its own class

Prep work for fixing <​http://webkit.org/b/61877> TestFailures page doesn't show testers that
use new-run-webkit-tests

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Moved a bunch of code from here...

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Added.

(ORWTResultsParser):
(ORWTResultsParser.prototype.parse):
...to here.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

ORWTResultsParser.js.

1:40 PM Changeset in webkit [90487] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-07-06 Filip Pizlo <​fpizlo@apple.com>

DFG speculative JIT may crash when speculating int on a non-int JSConstant.
​https://bugs.webkit.org/show_bug.cgi?id=64017

Reviewed by Gavin Barraclough.

  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal): (JSC::DFG::SpeculativeJIT::compile):
1:27 PM Changeset in webkit [90486] by sullivan@apple.com
  • 2 edits in trunk/Source/WebCore

IconDatabase::synchronousIconForPageURL() has inconsistent API when no custom icon is available
<​https://bugs.webkit.org/show_bug.cgi?id=64015>
<rdar://problem/9706277>

For some URLs it would return a particular size of default icon; for other
URLs it would return 0.

Reviewed by Ada Chan.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousIconForPageURL):
Return 0 in all cases where there is no custom icon.

1:20 PM Changeset in webkit [90485] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-07-06 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Switch RenderLayer::hitTest* to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=63640

Switch hit testing and supporting methods for RenderLayer over to the new
layout unit abstraction.

No new tests, no functionality changes.

  • rendering/LayoutTypes.h: (WebCore::roundedLayoutPoint): Add roundedLayoutPoint abstraction, calls roundedIntPoint now but will be a no-op (and eventually go away) once we switch to float or fixed point.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createLocalTransformState): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::hitTestList): (WebCore::RenderLayer::hitTestPaginatedChildLayer): (WebCore::RenderLayer::hitTestChildLayerColumns): (WebCore::RenderLayer::calculateRects):
  • rendering/RenderLayer.h:
1:15 PM Changeset in webkit [90484] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

2011-07-06 Simon Fraser <Simon Fraser>

Have RenderLayerCompositor take care of clearing backing store when entering the page cache
​https://bugs.webkit.org/show_bug.cgi?id=64018

Reviewed by Joseph Pecoraro.

Move responsibility for tearing down all RenderLayer backing stores from
RenderLayer itself to RenderLayerCompositor, since RenderLayerCompositor
manages backing store creation and destruction in general.

  • page/FrameView.cpp: (WebCore::FrameView::clearBackingStores):
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::clearBackingForLayerIncludingDescendants): (WebCore::RenderLayerCompositor::clearBackingForAllLayers):
  • rendering/RenderLayerCompositor.h:
12:52 PM Changeset in webkit [90483] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Eric Seidel <​eric@webkit.org>

Unreviewed. Fix a unittest from hitting the network. :)

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
12:45 PM Changeset in webkit [90482] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Eric Seidel <​eric@webkit.org>

Unreviewed. Fixing an exception in test-webkitpy, caused by bug 64006.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
12:21 PM Changeset in webkit [90481] by kov@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Gustavo Noronha Silva <​gustavo.noronha@collabora.com>

Run an Xvfb instance to run the API tests on, like we do for the
layout tests.

Reviewed by Xan Lopez.

  • Scripts/run-gtk-tests:
12:10 PM Changeset in webkit [90480] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Daniel Bates <​dbates@webkit.org>

Make SCM unit tests faster
​https://bugs.webkit.org/show_bug.cgi?id=63883

Speeds up the SCM unit tests by a factor of 4. Currently, we create a
mock SVN repo for each test_ method in SVNTest and GitTest and creating
this repo is expensive.

Instead, it is significantly faster to create the mock SVN repo once
and then perform a filesystem copy of it for each test_ method.

Note, Python 2.7's unittest module implements support for per class and
per module setup and tear down methods which could be used to implement
similar functionality. At the time of writing, test-webkitpy is designed
to support Python 2.5. So, we can't take advantage of these Python 2.7
features :(

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
12:07 PM Changeset in webkit [90479] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Remove unused parameter from _add_test in test_expectations.py
​https://bugs.webkit.org/show_bug.cgi?id=64008

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
12:04 PM Changeset in webkit [90478] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-07-06 Ryuan Choi <​ryuan.choi@samsung.com>

[Performance] Only call sendContentResizeNotification when the scrollbar actually did change
​https://bugs.webkit.org/show_bug.cgi?id=47320

Reviewed by Eric Seidel.

Move avoidScrollbarCreation checking code from setHasHorizontalScrollbar
and setHasVerticalScrollbar to their caller in order to keep sendContentResizedNotification
false in case scrollbar is not really changed.
As a result, it will remove unnecessary relayout in the above case.

No new tests as this is very hard to write tests for. The bug only
occured when scrolling the sites which contain frame in browser with
frameFlattening. This should not change functionality in other case.

  • platform/ScrollView.cpp: (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::updateScrollbars):
11:58 AM Changeset in webkit [90477] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-07-06 Dmitriy Vyukov <​dvyukov@google.com>

Reviewed by David Levin.

Allow substitution of dynamic annotations and prevent identical code folding by the linker.
​https://bugs.webkit.org/show_bug.cgi?id=62443

  • wtf/DynamicAnnotations.cpp: (WTFAnnotateBenignRaceSized): (WTFAnnotateHappensBefore): (WTFAnnotateHappensAfter):
11:58 AM Changeset in webkit [90476] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Use old-run-webkit-tests when --leaks is present
​https://bugs.webkit.org/show_bug.cgi?id=64012

Reviewed by Adam Roben.

We'll remove this branch once support of --leaks is added to
new-run-webkit-tests.

  • Scripts/run-webkit-tests:
11:41 AM Changeset in webkit [90475] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Tools

[Qt] [WK2] Add touch mocking to Qt's MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=63995

Reviewed by Andreas Kling.

The mouse events are intercepted through QCoreApplication::notify(),
and fake touch events are generated for mouse events when necessary.

If touch events are received from the platform, we assume the current
hardware has a touch screen and we stop generating fake events.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(isTouchEvent):
(isMouseEvent):
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):

  • MiniBrowser/qt/MiniBrowserApplication.h:
11:31 AM Changeset in webkit [90474] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

  • Scripts/webkitpy/layout_tests/port/gtk.py: use Popen correctly.
11:26 AM Changeset in webkit [90473] by mihaip@chromium.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

2011-07-06 Mihai Parparita <​mihaip@chromium.org>

Remove Chromium Mac failing expectation for fast/text/font-size-zero.html
(fixed by r89933)

Add Chromium Windows and Linux baselines for
fast/forms/textfield-overflow-by-value-update.html (needed due to
different form control metrics).

Remove a bunch of commented out test expectations.

  • platform/chromium-mac/svg/hittest/svg-rect-hit-expected.txt: Removed.
  • platform/chromium-win/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:13 AM Changeset in webkit [90472] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-07-06 Eric Seidel <​eric@webkit.org>

webkit-patch failure-reason does not understand NRWT results
​https://bugs.webkit.org/show_bug.cgi?id=64006

Reviewed by Adam Barth.

Adam Barth tells me failure-reason should be deleted soon,
but aroben's fancy new TestFailures/ page doesn't work for
NRWT yet, and I needed to know when
third-party-cookie-relaxing started failing.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/tool/commands/queries.py:
10:59 AM Changeset in webkit [90471] by Nate Chapin
  • 8 edits in trunk

2011-07-06 Nate Chapin <Nate Chapin>

Don't let all subresources keep isLoadingInAPISense() from
returning false, only requests that affect
CachedResourceRequest::requestCount().
​https://bugs.webkit.org/show_bug.cgi?id=62066

Reviewed by Adam Barth.

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::dispatchWindowLoadEvent):
  • dom/Document.h: (WebCore::Document::loadEventFinished):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
10:57 AM Changeset in webkit [90470] by mihaip@chromium.org
  • 2 edits
    5 adds
    1 delete in trunk/LayoutTests

2011-07-06 Mihai Parparita <​mihaip@chromium.org>

Rebaseline some imagemap focus ring tests for Chromium Mac (mainly for
Leopard, due to text anti-aliasing differences).

  • platform/chromium-mac/fast/images/imagemap-case-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/images/imagemap-case-expected.png: Added.
  • platform/mac-leopard/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/mac-leopard/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/mac-leopard/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/mac-leopard/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
10:11 AM Changeset in webkit [90469] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Xan Lopez <​xlopez@igalia.com>

[GTK] Add missing environment variables in NWRT
​https://bugs.webkit.org/show_bug.cgi?id=64004

Reviewed by Gustavo Noronha Silva.

Add missing environment variables needed by the GTK+ port.

  • Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
10:04 AM Changeset in webkit [90468] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-07-06 Ryosuke Niwa <​rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
9:59 AM Changeset in webkit [90467] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andras Becsi <​abecsi@webkit.org>

[Qt] Seems that I still don't get the syntax right

Unreviewed.

  • platform/qt/test_expectations.txt: Use BUGWK instead of BUG.
9:56 AM Changeset in webkit [90466] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Fixed test_expectations syntax.

  • platform/chromium/test_expectations.txt:
9:50 AM Changeset in webkit [90465] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Marked media/video-delay-load-event.html as flaky on mac.

  • platform/chromium/test_expectations.txt:
9:42 AM Changeset in webkit [90464] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andras Becsi <​abecsi@webkit.org>

[Qt] Fix the syntax of test_expectations.txt

Unreviewed gardening.

  • platform/qt/test_expectations.txt: Add a bug for the flaky tests.
9:35 AM Changeset in webkit [90463] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed, mark fast/events/click-focus-anchor.html as flaky.

  • platform/chromium/test_expectations.txt:
8:48 AM Changeset in webkit [90462] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andras Becsi <​abecsi@webkit.org>

[Qt] Try to make the bot green by marking tests flaky.

Rubber-stamped by Andreas Kling.

  • platform/qt/test_expectations.txt:
8:44 AM Changeset in webkit [90461] by Adam Roben
  • 2 edits in trunk/Tools

Make run-api-tests output intelligible on the bots

run-api-tests's output on the bots was very hard to read for two reasons:

1) It was mixing its own output with gtest's
2) It was using ANSI escape sequences to print colored text, but the bots don't support

that

Now, the --verbose flag turns off almost all of run-api-tests's own output so that gtest's
output will not be obscured. We still print "Timeout" messages even in verbose mode, since
gtest doesn't have any native support for timeouts. Also, when our output is being
redirected to a file, we don't print ANSI escape sequences.

Fixes <​http://webkit.org/b/63996> It's very hard to read run-api-tests output on the bots

Reviewed by Sam Weinig.

  • Scripts/run-api-tests: Don't use the :constants interface of Term::ANSIColor. We want to

use the colored function instead.
(runAllTestsInSuite): Don't print out suite names in verbose mode; gtest will give us enough
context that they aren't needed.
(runTest): Don't print out test names or pass/fail messages in verbose mode; gtest will do
that for us. Also, use the new possiblyColored function instead of always coloring output.
(possiblyColored): Added. When printing to a tty, returns the string with the appropriate
ANSI color escape sequences added. Otherwise just returns the string unmodified.

8:25 AM Changeset in webkit [90460] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-07-06 Pavel Feldman <​pfeldman@google.com>

Web Inspector: implement drag'n'drop in the elements panel for reordering nodes.
​https://bugs.webkit.org/show_bug.cgi?id=63990

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::moveTo):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._removeChild): (WebInspector.DOMNode.prototype.ownerDocumentElement): (WebInspector.DOMNode.prototype.moveTo): (WebInspector.DOMAgent.prototype._childNodeRemoved):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype._ondragstart): (WebInspector.ElementsTreeOutline.prototype._ondragover): (WebInspector.ElementsTreeOutline.prototype._ondragleave): (WebInspector.ElementsTreeOutline.prototype._isValidDragSourceOrTarget): (WebInspector.ElementsTreeOutline.prototype._ondragend.callback): (WebInspector.ElementsTreeOutline.prototype._ondragend): (WebInspector.ElementsTreeOutline.prototype._clearDragOverTreeElementMarker): (WebInspector.ElementsTreeOutline.prototype.populateContextMenu.focusElement): (WebInspector.ElementsTreeOutline.prototype.populateContextMenu): (WebInspector.ElementsTreeElement.prototype.onattach):
  • inspector/front-end/inspector.css: (.outline-disclosure li.elements-drag-over .selection):
  • inspector/front-end/treeoutline.js: (TreeOutline.prototype.treeElementFromEvent):
8:25 AM Changeset in webkit [90459] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Launch Xvfb (mostly) the same way we were launching it in the
bots, for maximum compatibility.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
8:22 AM Changeset in webkit [90458] by andreas.kling@nokia.com
  • 23 edits
    42 adds
    26 deletes in trunk

2011-07-06 Andreas Kling <​kling@webkit.org>

[Qt][WK2] Split Qt API into two different web views (touch and desktop)
​https://bugs.webkit.org/show_bug.cgi?id=63950

Co-authored with Benjamin Poulain <​benjamin@webkit.org>.

Reviewed by Kenneth Rohde Christiansen.

Port WTR/Qt to use QDesktopWebView and force a 800x600 viewport.

The Qt MiniBrowser now defaults to QDesktopWebView but can be started
in QTouchWebView mode by passing -touch on the command line.

A lot of functionality has been removed and/or disabled from
MiniBrowser until we reintroduce the necessary API's.

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): (BrowserView::~BrowserView): (BrowserView::load): (BrowserView::view): (BrowserView::touchWebView): (BrowserView::desktopWebView):
  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp: (newPageFunction): (BrowserWindow::BrowserWindow): (BrowserWindow::webView): (BrowserWindow::newWindow): (BrowserWindow::showUserAgentDialog): (BrowserWindow::updateUserAgentList):
  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::handleUserOptions):
  • MiniBrowser/qt/MiniBrowserApplication.h: (WindowOptions::WindowOptions):
  • MiniBrowser/qt/UrlLoader.cpp: (UrlLoader::UrlLoader):
  • MiniBrowser/qt/main.cpp: (main):
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WebView::wkView): (WTR::WebView::pageRef): (WTR::WebView::WebView): (WTR::PlatformWebView::page): (WTR::PlatformWebView::windowFrame): (WTR::PlatformWebView::setWindowFrame):

2011-07-06 Andreas Kling <​kling@webkit.org>

[Qt][WK2] Split Qt API into two different web views (touch and desktop)
​https://bugs.webkit.org/show_bug.cgi?id=63950

Co-authored with Benjamin Poulain <​benjamin@webkit.org>.

Reviewed by Kenneth Rohde Christiansen.

Replace the QGraphicsWKView/QWKPage mess with QDesktopWebView and QTouchWebView.

QDesktopWebView is a traditional web view, similar to QGraphicsWebView. It will
will have the expected "desktop" behavior for things like subframes and
fixed-position elements.

QTouchWebView is intended for use on touch devices, and will manage the viewport,
gestures, tiled rendering, and other things that the user should never have to
worry about. It will use "resize to contents" and frame flattening by default.

API-wise, the biggest difference between the two is that QTouchWebView is really
a viewport that contains a QTouchWebPage. These are decoupled for flexibility in
UI design. This decoupling is not necessary for the desktop use-case, and so
QDesktopWebView is the only class we need.

Much of the Qt/WebKit2 API has been removed (snapshots, history, preferences..)
but will be re-added incrementally in a way that fits the new API vision.

  • UIProcess/API/qt/WKView.h:
  • UIProcess/API/qt/qdesktopwebview.cpp: Added. (QDesktopWebViewPrivate::QDesktopWebViewPrivate): (QDesktopWebViewPrivate::setViewNeedsDisplay): (QDesktopWebViewPrivate::drawingAreaSize): (QDesktopWebViewPrivate::contentSizeChanged): (QDesktopWebViewPrivate::isActive): (QDesktopWebViewPrivate::hasFocus): (QDesktopWebViewPrivate::isVisible): (QDesktopWebViewPrivate::startDrag): (QDesktopWebViewPrivate::didChangeUrl): (QDesktopWebViewPrivate::didChangeTitle): (QDesktopWebViewPrivate::didChangeToolTip): (QDesktopWebViewPrivate::didChangeStatusText): (QDesktopWebViewPrivate::didChangeCursor): (QDesktopWebViewPrivate::loadDidBegin): (QDesktopWebViewPrivate::loadDidSucceed): (QDesktopWebViewPrivate::didChangeLoadProgress): (QDesktopWebViewPrivate::showContextMenu): (QDesktopWebViewPrivate::hideContextMenu): (QDesktopWebView::QDesktopWebView): (QDesktopWebView::init): (QDesktopWebView::~QDesktopWebView): (QDesktopWebView::load): (QDesktopWebView::url): (QDesktopWebView::title): (QDesktopWebView::resizeEvent): (QDesktopWebView::paint): (QDesktopWebView::event): (QDesktopWebView::pageRef):
  • UIProcess/API/qt/qdesktopwebview.h: Added.
  • UIProcess/API/qt/qdesktopwebview_p.h: Added.
  • UIProcess/API/qt/qgraphicswkview.cpp: Removed.
  • UIProcess/API/qt/qgraphicswkview.h: Removed.
  • UIProcess/API/qt/qtouchwebpage.cpp: Added. (QTouchWebPage::QTouchWebPage): (QTouchWebPage::~QTouchWebPage): (QTouchWebPage::paint): (QTouchWebPage::load): (QTouchWebPage::url): (QTouchWebPage::title): (QTouchWebPage::focusNextPrevChildCallback): (QTouchWebPage::focusNextPrevChild): (QTouchWebPage::event): (QTouchWebPage::timerEvent): (QTouchWebPage::resizeEvent): (QTouchWebPagePrivate::QTouchWebPagePrivate): (QTouchWebPage::visibleRect): (QTouchWebPagePrivate::prepareScaleChange): (QTouchWebPagePrivate::commitScaleChange): (QTouchWebPagePrivate::onScaleChanged): (QTouchWebPagePrivate::setPage):
  • UIProcess/API/qt/qtouchwebpage.h: Added.
  • UIProcess/API/qt/qtouchwebpage_p.h: Added. (QTouchWebPagePrivate::getPageViewPrivate):
  • UIProcess/API/qt/qtouchwebview.cpp: Added. (QTouchWebViewPrivate::QTouchWebViewPrivate): (QTouchWebView::QTouchWebView): (QTouchWebView::~QTouchWebView): (QTouchWebView::page):
  • UIProcess/API/qt/qtouchwebview.h: Added.
  • UIProcess/API/qt/qtouchwebview_p.h: Added.
  • UIProcess/API/qt/qwkpage.cpp: Removed.
  • UIProcess/API/qt/qwkpage.h: Removed.
  • UIProcess/API/qt/tests/commonviewtests/commonviewtests.pro: Added.
  • UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp: Added. (tst_CommonViewTests::init): (tst_CommonViewTests::cleanup): (tst_CommonViewTests::baseUrl): (tst_CommonViewTests::loadEmptyUrl): (tst_CommonViewTests::loadEmptyPageViewVisible): (tst_CommonViewTests::loadEmptyPageViewHidden): (tst_CommonViewTests::show):
  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp: Added. (WebViewAbstraction::WebViewAbstraction): (WebViewAbstraction::show): (WebViewAbstraction::hide): (WebViewAbstraction::load): (WebViewAbstraction::url): (WebViewAbstraction::touchViewLoadStarted): (WebViewAbstraction::desktopViewLoadStarted): (WebViewAbstraction::touchViewLoadSucceeded): (WebViewAbstraction::desktopViewLoadSucceeded): (WebViewAbstraction::touchWebView): (WebViewAbstraction::desktopWebView):
  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h: Copied from Source/WebKit2/UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp.
  • UIProcess/API/qt/tests/html/a.htm: Removed.
  • UIProcess/API/qt/tests/html/b.htm: Removed.
  • UIProcess/API/qt/tests/html/c.htm: Removed.
  • UIProcess/API/qt/tests/html/d.htm: Removed.
  • UIProcess/API/qt/tests/qdesktopwebview/qdesktopwebview.pro: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qgraphicswkview/qgraphicswkview.pro.
  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp. (tst_QDesktopWebView::init): (tst_QDesktopWebView::cleanup): (tst_QDesktopWebView::webView):
  • UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: Removed.
  • UIProcess/API/qt/tests/qtouchwebview/qtouchwebview.pro: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qwkhistory/qwkhistory.pro.
  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp: Added. (tst_QTouchWebView::tst_QTouchWebView): (tst_QTouchWebView::init): (tst_QTouchWebView::cleanup): (tst_QTouchWebView::webView): (tst_QTouchWebView::accessPage):
  • UIProcess/API/qt/tests/qwkhistory/tst_qwkhistory.cpp: Removed.
  • UIProcess/API/qt/tests/qwkpage/qwkpage.pro: Removed.
  • UIProcess/API/qt/tests/tests.pro:
  • UIProcess/API/qt/tests/testwindow.h: Added. (TestWindow::TestWindow): (TestWindow::resizeEvent):
  • UIProcess/TiledDrawingAreaProxy.cpp:
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/WebFullScreenManagerProxy.h:
  • UIProcess/qt/ClientImpl.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/ClientImpl.cpp. (toQWKContext): (toQtWebPageProxy): (loadFinished): (qt_wk_didStartProvisionalLoadForFrame): (qt_wk_didReceiveServerRedirectForProvisionalLoadForFrame): (qt_wk_didFailProvisionalLoadWithErrorForFrame): (qt_wk_didCommitLoadForFrame): (qt_wk_didFinishDocumentLoadForFrame): (qt_wk_didFinishLoadForFrame): (qt_wk_didFailLoadWithErrorForFrame): (qt_wk_didReceiveTitleForFrame): (qt_wk_didFirstLayoutForFrame): (qt_wk_didRemoveFrameFromHierarchy): (qt_wk_didFirstVisuallyNonEmptyLayoutForFrame): (qt_wk_didStartProgress): (qt_wk_didChangeProgress): (qt_wk_didFinishProgress): (qt_wk_didBecomeUnresponsive): (qt_wk_didBecomeResponsive): (qt_wk_createNewPage): (qt_wk_showPage): (qt_wk_close): (qt_wk_takeFocus): (qt_wk_runJavaScriptAlert): (qt_wk_setStatusText): (qt_wk_didSameDocumentNavigationForFrame): (qt_wk_didChangeIconForPageURL): (qt_wk_didRemoveAllIcons):
  • UIProcess/qt/ClientImpl.h: Renamed from Source/WebKit2/UIProcess/API/qt/ClientImpl.h.
  • UIProcess/qt/QtWebPageProxy.cpp: Added. (defaultWKContext): (contextMenuActionForWebAction): (dragOperationToDropActions): (dropActionToDragOperation): (QtWebPageProxy::QtWebPageProxy): (QtWebPageProxy::init): (QtWebPageProxy::~QtWebPageProxy): (QtWebPageProxy::handleEvent): (QtWebPageProxy::handleKeyPressEvent): (QtWebPageProxy::handleKeyReleaseEvent): (QtWebPageProxy::handleFocusInEvent): (QtWebPageProxy::handleFocusOutEvent): (QtWebPageProxy::setCursor): (QtWebPageProxy::setViewNeedsDisplay): (QtWebPageProxy::displayView): (QtWebPageProxy::scrollView): (QtWebPageProxy::viewSize): (QtWebPageProxy::isViewWindowActive): (QtWebPageProxy::isViewFocused): (QtWebPageProxy::isViewVisible): (QtWebPageProxy::isViewInWindow): (QtWebPageProxy::enterAcceleratedCompositingMode): (QtWebPageProxy::exitAcceleratedCompositingMode): (QtWebPageProxy::pageDidRequestScroll): (QtWebPageProxy::didChangeContentsSize): (QtWebPageProxy::toolTipChanged): (QtWebPageProxy::registerEditCommand): (QtWebPageProxy::clearAllEditCommands): (QtWebPageProxy::canUndoRedo): (QtWebPageProxy::executeUndoRedo): (QtWebPageProxy::convertToDeviceSpace): (QtWebPageProxy::screenToWindow): (QtWebPageProxy::windowToScreen): (QtWebPageProxy::convertToUserSpace): (QtWebPageProxy::selectionChanged): (QtWebPageProxy::doneWithKeyEvent): (QtWebPageProxy::createPopupMenuProxy): (QtWebPageProxy::createContextMenuProxy): (QtWebPageProxy::setFindIndicator): (QtWebPageProxy::didCommitLoadForMainFrame): (QtWebPageProxy::didFinishLoadingDataForCustomRepresentation): (QtWebPageProxy::flashBackingStoreUpdates): (QtWebPageProxy::pageRef): (QtWebPageProxy::didChangeUrl): (QtWebPageProxy::didChangeTitle): (QtWebPageProxy::didChangeStatusText): (QtWebPageProxy::showContextMenu): (QtWebPageProxy::hideContextMenu): (QtWebPageProxy::loadDidBegin): (QtWebPageProxy::loadDidSucceed): (QtWebPageProxy::didChangeLoadProgress): (QtWebPageProxy::paint): (QtWebPageProxy::updateAction): (QtWebPageProxy::updateNavigationActions): (QtWebPageProxy::webActionTriggered): (QtWebPageProxy::didRelaunchProcess): (QtWebPageProxy::processDidCrash): (QtWebPageProxy::setActualVisibleContentsRect): (QtWebPageProxy::preferences): (QtWebPageProxy::setCreateNewPageFunction): (QtWebPageProxy::setCustomUserAgent): (QtWebPageProxy::customUserAgent): (QtWebPageProxy::load): (QtWebPageProxy::url): (QtWebPageProxy::title): (QtWebPageProxy::setDrawingAreaSize): (QtWebPageProxy::textZoomFactor): (QtWebPageProxy::setTextZoomFactor): (QtWebPageProxy::pageZoomFactor): (QtWebPageProxy::setPageZoomFactor): (QtWebPageProxy::setPageAndTextZoomFactors): (QtWebPageProxy::history): (QtWebPageProxy::setResizesToContentsUsingLayoutSize): (QtWebPageProxy::triggerAction): (QtWebPageProxy::action): (QtWebPageProxy::findZoomableAreaForPoint): (QtWebPageProxy::didFindZoomableArea): (QtWebPageProxy::startDrag): (QtWebPageProxy::viewportVisibleRect): (QtWebPageProxy::isConnectedToEngine): (QtWebPageProxy::setPageIsVisible):
  • UIProcess/qt/QtWebPageProxy.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkpage_p.h. (QtWebPageProxy::pageClosed): (QtWebPageProxy::customRepresentationZoomFactor): (QtWebPageProxy::setCustomRepresentationZoomFactor): (QtWebPageProxy::didChangeScrollbarsForMainFrame): (QtWebPageProxy::findStringInCustomRepresentation): (QtWebPageProxy::countStringMatchesInCustomRepresentation): (QtWebPageProxy::userSpaceScaleFactor): (QtWebPageProxy::createNewPageFunction):
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: (WebKit::TiledDrawingAreaProxy::page):
  • UIProcess/qt/TouchViewInterface.cpp: Added. (WebKit::TouchViewInterface::TouchViewInterface): (WebKit::TouchViewInterface::setViewNeedsDisplay): (WebKit::TouchViewInterface::drawingAreaSize): (WebKit::TouchViewInterface::contentSizeChanged): (WebKit::TouchViewInterface::isActive): (WebKit::TouchViewInterface::hasFocus): (WebKit::TouchViewInterface::isVisible): (WebKit::TouchViewInterface::startDrag): (WebKit::TouchViewInterface::didChangeUrl): (WebKit::TouchViewInterface::didChangeTitle): (WebKit::TouchViewInterface::didChangeToolTip): (WebKit::TouchViewInterface::didChangeStatusText): (WebKit::TouchViewInterface::didChangeCursor): (WebKit::TouchViewInterface::loadDidBegin): (WebKit::TouchViewInterface::loadDidSucceed): (WebKit::TouchViewInterface::didChangeLoadProgress): (WebKit::TouchViewInterface::showContextMenu): (WebKit::TouchViewInterface::hideContextMenu):
  • UIProcess/qt/TouchViewInterface.h: Added. (WebKit::TouchViewInterface::pageView):
  • UIProcess/qt/ViewInterface.cpp: Added. (WebKit::ViewInterface::ownerWidget):
  • UIProcess/qt/ViewInterface.h: Added.
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::webActionForContextMenuAction): (WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt): (WebKit::WebContextMenuProxyQt::create): (WebKit::WebContextMenuProxyQt::showContextMenu): (WebKit::WebContextMenuProxyQt::hideContextMenu): (WebKit::WebContextMenuProxyQt::createContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp: Added. (dragOperationToDropAction): (QDesktopWebPageProxy::QDesktopWebPageProxy): (QDesktopWebPageProxy::createDrawingAreaProxy): (QDesktopWebPageProxy::paintContent): (QDesktopWebPageProxy::setViewportArguments): (QDesktopWebPageProxy::handleEvent): (QDesktopWebPageProxy::handleMouseMoveEvent): (QDesktopWebPageProxy::handleMousePressEvent): (QDesktopWebPageProxy::handleMouseReleaseEvent): (QDesktopWebPageProxy::handleMouseDoubleClickEvent): (QDesktopWebPageProxy::handleWheelEvent): (QDesktopWebPageProxy::handleHoverMoveEvent): (QDesktopWebPageProxy::handleDragEnterEvent): (QDesktopWebPageProxy::handleDragLeaveEvent): (QDesktopWebPageProxy::handleDragMoveEvent): (QDesktopWebPageProxy::handleDropEvent): (QDesktopWebPageProxy::timerEvent):
  • UIProcess/qt/qdesktopwebpageproxy.h: Added.
  • UIProcess/qt/qtouchwebpageproxy.cpp: Added. (QTouchWebPageProxy::QTouchWebPageProxy): (QTouchWebPageProxy::createDrawingAreaProxy): (QTouchWebPageProxy::paintContent): (QTouchWebPageProxy::setViewportArguments): (QTouchWebPageProxy::handleEvent): (QTouchWebPageProxy::touchEvent):
  • UIProcess/qt/qtouchwebpageproxy.h: Added. (QTouchWebPageProxy::touchViewInterface): (QTouchWebPageProxy::pageView):
  • UIProcess/qt/qwkcontext.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qwkcontext.cpp. (initializePlatformStrategiesIfNeeded): (QWKContextPrivate::QWKContextPrivate): (QWKContextPrivate::~QWKContextPrivate): (QWKContext::QWKContext): (QWKContext::~QWKContext): (QWKContext::setIconDatabasePath): (QWKContext::iconForPageURL):
  • UIProcess/qt/qwkcontext.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkcontext.h.
  • UIProcess/qt/qwkcontext_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkcontext_p.h.
  • UIProcess/qt/qwkhistory.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qwkhistory.cpp. (QWKHistoryItemPrivate::QWKHistoryItemPrivate): (QWKHistoryItemPrivate::~QWKHistoryItemPrivate): (QWKHistoryItem::QWKHistoryItem): (QWKHistoryItem::QWKHistoryItem::operator=): (QWKHistoryItem::~QWKHistoryItem): (QWKHistoryItem::title): (QWKHistoryItem::url): (QWKHistoryPrivate::QWKHistoryPrivate): (QWKHistoryPrivate::createHistory): (QWKHistoryPrivate::~QWKHistoryPrivate): (QWKHistory::QWKHistory): (QWKHistory::~QWKHistory): (QWKHistory::backListCount): (QWKHistory::forwardListCount): (QWKHistory::count): (QWKHistory::currentItem): (QWKHistory::backItem): (QWKHistory::forwardItem): (QWKHistory::itemAt): (QWKHistory::goToItemAt): (QWKHistory::backItems): (QWKHistory::forwardItems):
  • UIProcess/qt/qwkhistory.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkhistory.h.
  • UIProcess/qt/qwkhistory_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkhistory_p.h.
  • UIProcess/qt/qwkpreferences.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qwkpreferences.cpp. (QWKPreferencesPrivate::createPreferences): (QWKPreferencesPrivate::createSharedPreferences): (QWKPreferences::sharedPreferences): (QWKPreferences::QWKPreferences): (QWKPreferences::~QWKPreferences): (QWKPreferences::setFontFamily): (QWKPreferences::fontFamily): (QWKPreferences::testAttribute): (QWKPreferences::setAttribute): (QWKPreferences::setFontSize): (QWKPreferences::fontSize):
  • UIProcess/qt/qwkpreferences.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkpreferences.h.
  • UIProcess/qt/qwkpreferences_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwkpreferences_p.h.
  • WebKit2.pro:
  • WebKit2API.pri:
  • WebProcess/WebPage/TiledDrawingArea.cpp:
  • WebProcess/WebPage/TiledDrawingArea.h:
7:24 AM Changeset in webkit [90457] by jeffm@apple.com
  • 4 edits in trunk/Source/WebKit2

Add WKPageCopyStandardUserAgentWithApplicationName
​https://bugs.webkit.org/show_bug.cgi?id=63953

Reviewed by Adam Roben.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCopyStandardUserAgentWithApplicationName): Added.

  • UIProcess/API/C/WKPagePrivate.h: Added WKPageCopyStandardUserAgentWithApplicationName().
  • UIProcess/WebPageProxy.h: Make standardUserAgent() public.
6:45 AM Changeset in webkit [90456] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-06 Andras Becsi <​abecsi@webkit.org>

Fix "warning: a `;' might be needed at the end of action code"

Unreviewed gardening.

No new tests needed.

  • css/CSSGrammar.y: Future versions of Bison will not add the ';' so add it.
6:41 AM Changeset in webkit [90455] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Andras Becsi <​abecsi@webkit.org>

[Qt] DumpRenderTree needs a beginDragWithFiles implementation
​https://bugs.webkit.org/show_bug.cgi?id=50902

Unreviewed gardening.

  • platform/qt/Skipped: Skip failing test added in r90438.
6:17 AM Changeset in webkit [90454] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-06 Andras Becsi <​abecsi@webkit.org>

[Qt] Revome unused but set shadowBlur variable after r90406.

Unreviewed build fix.

No new tests needed.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): Use the GraphicsContext brush.
5:18 AM Changeset in webkit [90453] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Xan Lopez <​xlopez@igalia.com>

Unreviewed.

Remove non-existing test from Skipped.

  • platform/gtk/Skipped:
5:13 AM Changeset in webkit [90452] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Xan Lopez <​xlopez@igalia.com>

Unreviewed.

Missed these inspector tests before.

  • platform/gtk/Skipped:
4:34 AM Changeset in webkit [90451] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-06 Xan Lopez <​xlopez@igalia.com>

Unreviewed.

Skip inspector tests while we figure why they fail in the
NWRT/debug bots.

  • platform/gtk/Skipped:
4:15 AM Changeset in webkit [90450] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-07-06 Andras Becsi <​abecsi@webkit.org>

[Qt] Remove duplicate entries of ShadowBlur sources from project file.

Rubber-stamped by Csaba Osztrogonác.

No new tests needed.

  • WebCore.pro: These files were already added in r84410.
4:03 AM Changeset in webkit [90449] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Eric Seidel <​eric@webkit.org>

Unreviewed..

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
    • Fix the pass-thru of --gtk and --qt for old-run-webkit-tests, it was previously broken by the existence of isGtk/isQt checks which removed the --gtk/--qt args from @ARGV.
3:28 AM Changeset in webkit [90448] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-07-06 Eric Seidel <​eric@webkit.org>

new-run-webkit-tests uses a 35s timeout for Mac and 6s for all other ports
​https://bugs.webkit.org/show_bug.cgi?id=63983

Reviewed by Xan Lopez.

All WebKit ports want to use a 35s timeout. Only chromium currently
uses a 6s timeout. Eventually we'll move all WebKit ports to 6s too
to further speed up new-run-webkit-tests runs, but that's going to be a while.

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3:13 AM Changeset in webkit [90447] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Xan Lopez <​xlopez@igalia.com>

Unreviewed.

NWRT actually seems to work locally, so it should work in the bots
as long as we take care of the TIMEOUT issue (which is being fixed
as I write this). Let's give this another shot and fix whatever
breaks.

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
2:14 AM Changeset in webkit [90446] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Xan Lopez <​xlopez@igalia.com>

Unreviewed.

Disable NWRT on GTK. At the very least it needs an updated exected
results file since NWRT is more sensitive to timeouts, not sure
what the exact problem is.

  • Scripts/run-webkit-tests: (useNewRunWebKitTests):
1:06 AM Changeset in webkit [90445] by yutak@chromium.org
  • 6 edits
    160 moves
    9 adds
    1 delete in trunk/LayoutTests

2011-07-05 Yuta Kitamura <​yutak@chromium.org>

WebSocket: Move current WebSocket tests to a new directory
​https://bugs.webkit.org/show_bug.cgi?id=63931

Reviewed by Kent Tamura.

In order to put tests for new WebSocket protocol, existing tests for the old protocol
need to be moved to a subdirectory (namely "hixie76").

Minimum changes have been made to tests and test results, such as:

  • Update links to resource files (e.g. "../../../js-test-pre.js" to "../../../../js-test-pre.js"), and
  • Update WebSocket URLs in the tests (i.e. adding "hixie76/" to ws:// and wss:// URLs).

Skipped and test_expectations.txt are also updated accordingly.

  • http/tests/websocket/tests/handler_map.txt: This is the only file left in the current directory. This file defines the handler location to which accesses to the root directory (e.g. "ws://example.com/") are redirected, and cannot be moved.
  • http/tests/websocket/tests/hixie76/alert-in-event-handler-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/alert-in-event-handler-expected.txt.
  • http/tests/websocket/tests/hixie76/alert-in-event-handler.html: Renamed from LayoutTests/http/tests/websocket/tests/alert-in-event-handler.html.
  • http/tests/websocket/tests/hixie76/bad-handshake-crash-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/bad-handshake-crash-expected.txt.
  • http/tests/websocket/tests/hixie76/bad-handshake-crash.html: Renamed from LayoutTests/http/tests/websocket/tests/bad-handshake-crash.html.
  • http/tests/websocket/tests/hixie76/bad-handshake-crash_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/bad-handshake-crash_wsh.py.
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars.html: Renamed from LayoutTests/http/tests/websocket/tests/bad-sub-protocol-control-chars.html.
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-empty-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/bad-sub-protocol-empty-expected.txt.
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-empty.html: Renamed from LayoutTests/http/tests/websocket/tests/bad-sub-protocol-empty.html.
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/bad-sub-protocol-non-ascii-expected.txt.
  • http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii.html: Renamed from LayoutTests/http/tests/websocket/tests/bad-sub-protocol-non-ascii.html.
  • http/tests/websocket/tests/hixie76/bufferedAmount-after-close-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/bufferedAmount-after-close-expected.txt.
  • http/tests/websocket/tests/hixie76/bufferedAmount-after-close.html: Renamed from LayoutTests/http/tests/websocket/tests/bufferedAmount-after-close.html.
  • http/tests/websocket/tests/hixie76/client-close-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/client-close-expected.txt.
  • http/tests/websocket/tests/hixie76/client-close.html: Renamed from LayoutTests/http/tests/websocket/tests/client-close.html.
  • http/tests/websocket/tests/hixie76/client-close_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/client-close_wsh.py.
  • http/tests/websocket/tests/hixie76/close-before-open-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-before-open-expected.txt.
  • http/tests/websocket/tests/hixie76/close-before-open.html: Renamed from LayoutTests/http/tests/websocket/tests/close-before-open.html.
  • http/tests/websocket/tests/hixie76/close-event-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-event-expected.txt.
  • http/tests/websocket/tests/hixie76/close-event.html: Renamed from LayoutTests/http/tests/websocket/tests/close-event.html.
  • http/tests/websocket/tests/hixie76/close-on-navigate-new-location-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-on-navigate-new-location-expected.txt.
  • http/tests/websocket/tests/hixie76/close-on-navigate-new-location.html: Renamed from LayoutTests/http/tests/websocket/tests/close-on-navigate-new-location.html.
  • http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload-and-force-gc-expected.txt.
  • http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload-and-force-gc.html.
  • http/tests/websocket/tests/hixie76/close-on-unload-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload-expected.txt.
  • http/tests/websocket/tests/hixie76/close-on-unload-reference-in-parent-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload-reference-in-parent-expected.txt.
  • http/tests/websocket/tests/hixie76/close-on-unload-reference-in-parent.html: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload-reference-in-parent.html.
  • http/tests/websocket/tests/hixie76/close-on-unload.html: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload.html.
  • http/tests/websocket/tests/hixie76/close-on-unload_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/close-on-unload_wsh.py.
  • http/tests/websocket/tests/hixie76/close-unref-websocket-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/close-unref-websocket-expected.txt.
  • http/tests/websocket/tests/hixie76/close-unref-websocket.html: Renamed from LayoutTests/http/tests/websocket/tests/close-unref-websocket.html.
  • http/tests/websocket/tests/hixie76/cross-origin-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/cross-origin-expected.txt.
  • http/tests/websocket/tests/hixie76/cross-origin.html: Renamed from LayoutTests/http/tests/websocket/tests/cross-origin.html.
  • http/tests/websocket/tests/hixie76/echo-challenge_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/echo-challenge_wsh.py.
  • http/tests/websocket/tests/hixie76/echo-cookie_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/echo-cookie_wsh.py.
  • http/tests/websocket/tests/hixie76/echo-location_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/echo-location_wsh.py.
  • http/tests/websocket/tests/hixie76/echo_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/echo_wsh.py.
  • http/tests/websocket/tests/hixie76/error-detect-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/error-detect-expected.txt.
  • http/tests/websocket/tests/hixie76/error-detect.html: Renamed from LayoutTests/http/tests/websocket/tests/error-detect.html.
  • http/tests/websocket/tests/hixie76/fixed-origin_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/fixed-origin_wsh.py.
  • http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-longer-than-buffer-expected.txt.
  • http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer.html: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-longer-than-buffer.html.
  • http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py.
  • http/tests/websocket/tests/hixie76/frame-length-overflow-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-overflow-expected.txt.
  • http/tests/websocket/tests/hixie76/frame-length-overflow.html: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-overflow.html.
  • http/tests/websocket/tests/hixie76/frame-length-overflow_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-overflow_wsh.py.
  • http/tests/websocket/tests/hixie76/frame-length-skip-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-skip-expected.txt.
  • http/tests/websocket/tests/hixie76/frame-length-skip.html: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-skip.html.
  • http/tests/websocket/tests/hixie76/frame-length-skip_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/frame-length-skip_wsh.py.
  • http/tests/websocket/tests/hixie76/frame-lengths-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/frame-lengths-expected.txt.
  • http/tests/websocket/tests/hixie76/frame-lengths.html: Renamed from LayoutTests/http/tests/websocket/tests/frame-lengths.html.
  • http/tests/websocket/tests/hixie76/handshake-challenge-randomness-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-challenge-randomness-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-challenge-randomness.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-challenge-randomness.html.
  • http/tests/websocket/tests/hixie76/handshake-error-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-error-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-error.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-error.html.
  • http/tests/websocket/tests/hixie76/handshake-error_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/handshake-error_wsh.py.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-cross-origin-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-cross-origin-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-cross-origin.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-cross-origin.html.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-maxlength-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-maxlength.html.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-maxlength_wsh.py.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-connection-header-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-connection-header.html.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-connection-header_wsh.py.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-cr-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-cr.html.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-cr_wsh.py.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-upgrade-header-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-no-upgrade-header_wsh.py.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-prepended-null-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-prepended-null.html.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-prepended-null_wsh.py.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-sub-protocol-mismatch-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt.
  • http/tests/websocket/tests/hixie76/handshake-fail-by-sub-protocol-mismatch.html: Renamed from LayoutTests/http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html.
  • http/tests/websocket/tests/hixie76/hanging-handshake_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/hanging-handshake_wsh.py.
  • http/tests/websocket/tests/hixie76/httponly-cookie-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/httponly-cookie-expected.txt.
  • http/tests/websocket/tests/hixie76/httponly-cookie.pl: Renamed from LayoutTests/http/tests/websocket/tests/httponly-cookie.pl.
  • http/tests/websocket/tests/hixie76/long-invalid-header-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/long-invalid-header-expected.txt.
  • http/tests/websocket/tests/hixie76/long-invalid-header.html: Renamed from LayoutTests/http/tests/websocket/tests/long-invalid-header.html.
  • http/tests/websocket/tests/hixie76/long-invalid-header_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/long-invalid-header_wsh.py.
  • http/tests/websocket/tests/hixie76/multiple-connections-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/multiple-connections-expected.txt.
  • http/tests/websocket/tests/hixie76/multiple-connections.html: Renamed from LayoutTests/http/tests/websocket/tests/multiple-connections.html.
  • http/tests/websocket/tests/hixie76/no-query_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/no-query_wsh.py.
  • http/tests/websocket/tests/hixie76/null-character-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/null-character-expected.txt.
  • http/tests/websocket/tests/hixie76/null-character.html: Renamed from LayoutTests/http/tests/websocket/tests/null-character.html.
  • http/tests/websocket/tests/hixie76/origin-test_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/origin-test_wsh.py.
  • http/tests/websocket/tests/hixie76/protocol-test_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/protocol-test_wsh.py.
  • http/tests/websocket/tests/hixie76/reload-crash-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/reload-crash-expected.txt.
  • http/tests/websocket/tests/hixie76/reload-crash.html: Renamed from LayoutTests/http/tests/websocket/tests/reload-crash.html.
  • http/tests/websocket/tests/hixie76/resources/close-on-unload-iframe-reference-in-parent.html: Renamed from LayoutTests/http/tests/websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html.
  • http/tests/websocket/tests/hixie76/resources/close-on-unload-iframe.html: Renamed from LayoutTests/http/tests/websocket/tests/resources/close-on-unload-iframe.html.
  • http/tests/websocket/tests/hixie76/resources/reload-crash-iframe.html: Added.
  • http/tests/websocket/tests/hixie76/send-after-close-on-unload-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/send-after-close-on-unload-expected.txt.
  • http/tests/websocket/tests/hixie76/send-after-close-on-unload.html: Renamed from LayoutTests/http/tests/websocket/tests/send-after-close-on-unload.html.
  • http/tests/websocket/tests/hixie76/send-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/send-expected.txt.
  • http/tests/websocket/tests/hixie76/send-throw-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/send-throw-expected.txt.
  • http/tests/websocket/tests/hixie76/send-throw.html: Renamed from LayoutTests/http/tests/websocket/tests/send-throw.html.
  • http/tests/websocket/tests/hixie76/send.html: Renamed from LayoutTests/http/tests/websocket/tests/send.html.
  • http/tests/websocket/tests/hixie76/send2_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/send2_wsh.py.
  • http/tests/websocket/tests/hixie76/send_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/send_wsh.py.
  • http/tests/websocket/tests/hixie76/server-close-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/server-close-expected.txt.
  • http/tests/websocket/tests/hixie76/server-close.html: Renamed from LayoutTests/http/tests/websocket/tests/server-close.html.
  • http/tests/websocket/tests/hixie76/server-close_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/server-close_wsh.py.
  • http/tests/websocket/tests/hixie76/simple-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/simple-expected.txt.
  • http/tests/websocket/tests/hixie76/simple-stress-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/simple-stress-expected.txt.
  • http/tests/websocket/tests/hixie76/simple-stress.html: Renamed from LayoutTests/http/tests/websocket/tests/simple-stress.html.
  • http/tests/websocket/tests/hixie76/simple.html: Renamed from LayoutTests/http/tests/websocket/tests/simple.html.
  • http/tests/websocket/tests/hixie76/simple_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/simple_wsh.py.
  • http/tests/websocket/tests/hixie76/sub-protocol-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/sub-protocol-expected.txt.
  • http/tests/websocket/tests/hixie76/sub-protocol-with-space-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/sub-protocol-with-space-expected.txt.
  • http/tests/websocket/tests/hixie76/sub-protocol-with-space.html: Renamed from LayoutTests/http/tests/websocket/tests/sub-protocol-with-space.html.
  • http/tests/websocket/tests/hixie76/sub-protocol.html: Renamed from LayoutTests/http/tests/websocket/tests/sub-protocol.html.
  • http/tests/websocket/tests/hixie76/unicode-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/unicode-expected.txt.
  • http/tests/websocket/tests/hixie76/unicode.html: Renamed from LayoutTests/http/tests/websocket/tests/unicode.html.
  • http/tests/websocket/tests/hixie76/unicode_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/unicode_wsh.py.
  • http/tests/websocket/tests/hixie76/unknown-frame-type_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/unknown-frame-type_wsh.py.
  • http/tests/websocket/tests/hixie76/url-no-trailing-slash-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/url-no-trailing-slash-expected.txt.
  • http/tests/websocket/tests/hixie76/url-no-trailing-slash.html: Renamed from LayoutTests/http/tests/websocket/tests/url-no-trailing-slash.html.
  • http/tests/websocket/tests/hixie76/url-parsing-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/url-parsing-expected.txt.
  • http/tests/websocket/tests/hixie76/url-parsing.html: Renamed from LayoutTests/http/tests/websocket/tests/url-parsing.html.
  • http/tests/websocket/tests/hixie76/url-with-credential-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/url-with-credential-expected.txt.
  • http/tests/websocket/tests/hixie76/url-with-credential.html: Renamed from LayoutTests/http/tests/websocket/tests/url-with-credential.html.
  • http/tests/websocket/tests/hixie76/url-with-empty-query-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/url-with-empty-query-expected.txt.
  • http/tests/websocket/tests/hixie76/url-with-empty-query.html: Renamed from LayoutTests/http/tests/websocket/tests/url-with-empty-query.html.
  • http/tests/websocket/tests/hixie76/url-with-query-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/url-with-query-expected.txt.
  • http/tests/websocket/tests/hixie76/url-with-query-for-no-query-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/url-with-query-for-no-query-expected.txt.
  • http/tests/websocket/tests/hixie76/url-with-query-for-no-query.html: Renamed from LayoutTests/http/tests/websocket/tests/url-with-query-for-no-query.html.
  • http/tests/websocket/tests/hixie76/url-with-query.html: Renamed from LayoutTests/http/tests/websocket/tests/url-with-query.html.
  • http/tests/websocket/tests/hixie76/websocket-event-target-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/websocket-event-target-expected.txt.
  • http/tests/websocket/tests/hixie76/websocket-event-target.html: Renamed from LayoutTests/http/tests/websocket/tests/websocket-event-target.html.
  • http/tests/websocket/tests/hixie76/websocket-pending-activity-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/websocket-pending-activity-expected.txt.
  • http/tests/websocket/tests/hixie76/websocket-pending-activity.html: Renamed from LayoutTests/http/tests/websocket/tests/websocket-pending-activity.html.
  • http/tests/websocket/tests/hixie76/websocket-protocol-ignored-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/websocket-protocol-ignored-expected.txt.
  • http/tests/websocket/tests/hixie76/websocket-protocol-ignored.html: Renamed from LayoutTests/http/tests/websocket/tests/websocket-protocol-ignored.html.
  • http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/workers/close-in-onmessage-crash-expected.txt.
  • http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html: Renamed from LayoutTests/http/tests/websocket/tests/workers/close-in-onmessage-crash.html.
  • http/tests/websocket/tests/hixie76/workers/close-in-shared-worker-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/workers/close-in-shared-worker-expected.txt.
  • http/tests/websocket/tests/hixie76/workers/close-in-shared-worker.html: Renamed from LayoutTests/http/tests/websocket/tests/workers/close-in-shared-worker.html.
  • http/tests/websocket/tests/hixie76/workers/close-in-worker-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/workers/close-in-worker-expected.txt.
  • http/tests/websocket/tests/hixie76/workers/close-in-worker.html: Renamed from LayoutTests/http/tests/websocket/tests/workers/close-in-worker.html.
  • http/tests/websocket/tests/hixie76/workers/resources/close-in-onmessage-crash.js: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/close-in-onmessage-crash.js. (runTests.try.ws.onopen): (runTests.try.ws.onmessage): (runTests.try.ws.onclose): (runTests):
  • http/tests/websocket/tests/hixie76/workers/resources/close-in-worker.js: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/close-in-worker.js. (handleConnect.self.postMessage): (handleConnect): (runTests.try.ws.onopen): (runTests.try.ws.onclose): (runTests):
  • http/tests/websocket/tests/hixie76/workers/resources/echo-challenge_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/echo-challenge_wsh.py.
  • http/tests/websocket/tests/hixie76/workers/resources/echo_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/echo_wsh.py.
  • http/tests/websocket/tests/hixie76/workers/resources/simple_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/simple_wsh.py.
  • http/tests/websocket/tests/hixie76/workers/resources/worker-handshake-challenge-randomness.js: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/worker-handshake-challenge-randomness.js. (endTest): (runTests.try.ws1.onmessage): (runTests.try.ws1.onclose.ws2.onmessage): (runTests.try.ws1.onclose.ws2.onclose): (runTests.try.ws1.onclose): (runTests):
  • http/tests/websocket/tests/hixie76/workers/resources/worker-simple.js: Renamed from LayoutTests/http/tests/websocket/tests/workers/resources/worker-simple.js. (handleConnect.self.postMessage): (handleConnect): (runTests.try.ws.onopen): (runTests.try.ws.onmessage): (runTests.try.ws.onclose): (runTests):
  • http/tests/websocket/tests/hixie76/workers/shared-worker-simple-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/workers/shared-worker-simple-expected.txt.
  • http/tests/websocket/tests/hixie76/workers/shared-worker-simple.html: Renamed from LayoutTests/http/tests/websocket/tests/workers/shared-worker-simple.html.
  • http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/workers/worker-handshake-challenge-randomness-expected.txt.
  • http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness.html: Renamed from LayoutTests/http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html.
  • http/tests/websocket/tests/hixie76/workers/worker-simple-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/workers/worker-simple-expected.txt.
  • http/tests/websocket/tests/hixie76/workers/worker-simple.html: Renamed from LayoutTests/http/tests/websocket/tests/workers/worker-simple.html.
  • http/tests/websocket/tests/resources/reload-crash-iframe.html: Removed.
  • platform/chromium-linux/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt: Renamed from LayoutTests/platform/chromium-linux/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • platform/chromium-linux/http/tests/websocket/tests/hixie76/url-parsing-expected.txt: Renamed from LayoutTests/platform/chromium-win/http/tests/websocket/tests/url-parsing-expected.txt.
  • platform/chromium-mac/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt: Renamed from LayoutTests/platform/chromium-mac/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • platform/chromium-mac/http/tests/websocket/tests/hixie76/url-parsing-expected.txt: Renamed from LayoutTests/platform/chromium-linux/http/tests/websocket/tests/url-parsing-expected.txt.
  • platform/chromium-win/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt: Renamed from LayoutTests/platform/chromium-win/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • platform/chromium-win/http/tests/websocket/tests/hixie76/url-parsing-expected.txt: Renamed from LayoutTests/platform/chromium-mac/http/tests/websocket/tests/url-parsing-expected.txt.
  • platform/chromium/test_expectations.txt:
  • platform/qt-arm/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/websocket/tests/bad-sub-protocol-non-ascii-expected.txt.
  • platform/win/Skipped:
12:56 AM Changeset in webkit [90444] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Fix global variable leak detected by noglobals.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
12:44 AM Changeset in webkit [90443] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Calls on 32 bit machines are failed after r90423
​https://bugs.webkit.org/show_bug.cgi?id=63980

Patch by Zoltan Herczeg <​zherczeg@inf.u-szeged.hu> on 2011-07-06
Reviewed by Gavin Barraclough.

Copy the necessary lines from JITCall.cpp.

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

12:39 AM Changeset in webkit [90442] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

garden-o-matic shouldn't show flaky tests by default
​https://bugs.webkit.org/show_bug.cgi?id=63979

Reviewed by Ojan Vafai.

If any of the actual test results are PASS, the test is flaky and we
can ignore it (at least for now). If we get awesome at dealing with
failing tests, we might want to tackle flaky tests by refering the user
to the flakiness dashboard, which is way more awesome at dealing with
flaky tests that this tool ever will be.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
12:04 AM Changeset in webkit [90441] by abarth@webkit.org
  • 7 edits
    3 adds in trunk/Tools

2011-07-05 Adam Barth <​abarth@webkit.org>

garden-o-matic should list the failing tests
​https://bugs.webkit.org/show_bug.cgi?id=63978

Reviewed by Eric Seidel.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Added.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Added.
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
Note: See TracTimeline for information about the timeline view.