Timeline

Jul 8, 2011:

11:05 PM Changeset in webkit [90676] by krit@webkit.org

• 5 edits in trunk/Source/WebCore

Refactoring luminance code in RenderSVGResourceMasker
​https://bugs.webkit.org/show_bug.cgi?id=64146

Reviewed by Simon Fraser.

Moved luminance calculcation code to ImageBuffer. The code is doing pixel manipulations and can now get replaced
by platform specific algorithms in the ImmageBuffer*.cpp files.

No change of functionality. No new tests.

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::transformColorSpace):
(WebCore::ImageBuffer::genericConvertToLuminanceMask):
(WebCore::ImageBuffer::convertToLuminanceMask):

• platform/graphics/ImageBuffer.h:
• rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):

5:43 PM Changeset in webkit [90675] by Simon Fraser

• 42 edits in trunk/Source/WebCore

2011-07-08 Simon Fraser <Simon Fraser>

Clean up RenderWidget::destroy() to share more code
​https://bugs.webkit.org/show_bug.cgi?id=64138

Reviewed by James Robinson.

RenderWidget::destroy() copied code from various other
destroy() methods, which made code maintenance in this
area very risky.

Fix by adding a virtual willBeDestroyed() method, which
replaces most instances of destroy(). Now, only RenderWidget
and RenderObject implement destroy(), and each just calls
willBeDestroyed(). Code duplication is averted.

No behavior change, so no tests.

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::willBeDestroyed):
• rendering/RenderBlock.h:
• rendering/RenderBox.cpp: (WebCore::RenderBox::willBeDestroyed):
• rendering/RenderBox.h:
• rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::willBeDestroyed):
• rendering/RenderBoxModelObject.h:
• rendering/RenderFullScreen.cpp: (RenderFullScreenPlaceholder::willBeDestroyed): (RenderFullScreen::willBeDestroyed):
• rendering/RenderFullScreen.h:
• rendering/RenderInline.cpp: (WebCore::RenderInline::willBeDestroyed):
• rendering/RenderInline.h:
• rendering/RenderListItem.cpp: (WebCore::RenderListItem::willBeDestroyed):
• rendering/RenderListItem.h:
• rendering/RenderObject.cpp: (WebCore::RenderObject::willBeDestroyed): (WebCore::RenderObject::destroy):
• rendering/RenderObject.h:
• rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::willBeDestroyed):
• rendering/RenderReplaced.h:
• rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::willBeDestroyed):
• rendering/RenderTableCell.h:
• rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::willBeDestroyed):
• rendering/RenderTableRow.h:
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::willBeDestroyed):
• rendering/RenderTableSection.h:
• rendering/RenderText.cpp: (WebCore::RenderText::willBeDestroyed):
• rendering/RenderText.h:
• rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::willBeDestroyed):
• rendering/RenderTextFragment.h:
• rendering/RenderWidget.cpp: (WebCore::RenderWidget::willBeDestroyed): (WebCore::RenderWidget::destroy):
• rendering/RenderWidget.h:
• rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::willBeDestroyed):
• rendering/svg/RenderSVGBlock.h:
• rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::willBeDestroyed):
• rendering/svg/RenderSVGInline.h:
• rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::willBeDestroyed):
• rendering/svg/RenderSVGInlineText.h:
• rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::willBeDestroyed):
• rendering/svg/RenderSVGModelObject.h:
• rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::willBeDestroyed):
• rendering/svg/RenderSVGResourceContainer.h:
• rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::willBeDestroyed):
• rendering/svg/RenderSVGRoot.h:
• rendering/svg/SVGResourcesCache.h:

5:39 PM WikiStart edited by dpranke@chromium.org

(diff)

5:02 PM Changeset in webkit [90674] by ojan@chromium.org

• 6 edits
  14 adds
  4 deletes in trunk/Tools

pull static dashboard files into the appengine server from the chromium repository
​https://bugs.webkit.org/show_bug.cgi?id=64208

Reviewed by Dirk Pranke.

These files belong in the WebKit repo since they are tied primarily to the webkit tests.
They have some extra bits to support chromium's gtests, but that seems fine.
Mainly, this will allow other WebKit hackers to hack on the dashboards.

As a nice side-effect, we can now push the dashboard files when we do appengine pushes
instead of the weird thing we used to do of pulling them from the Chromium repository
and storing them in the appengine datastore. This allows for cleaning up a lot of code
and will likely make the dashboards load a bit faster.

The new JS files don't fully match WebKit style, but I'd like to clean that up in a
followup patch if possible to maintain my sanity with this patch.

• TestResultServer/app.yaml:
• TestResultServer/handlers/dashboardhandler.py: Removed.
• TestResultServer/handlers/menu.py:
• TestResultServer/main.py:
• TestResultServer/model/dashboardfile.py: Removed.
• TestResultServer/static-dashboards/LICENSE.dygraph.txt: Added.
• TestResultServer/static-dashboards/README.dygraph.txt: Added.
• TestResultServer/static-dashboards/README.webtreemap.txt: Added.
• TestResultServer/static-dashboards/aggregate_results.html: Added.
• TestResultServer/static-dashboards/builders.js: Added.
• TestResultServer/static-dashboards/dashboard_base.js: Added.
• TestResultServer/static-dashboards/dygraph-combined.js: Added.
• TestResultServer/static-dashboards/flakiness_dashboard.html: Added.
• TestResultServer/static-dashboards/flakiness_dashboard_tests.js: Added.
• TestResultServer/static-dashboards/timeline_explorer.html: Added.
• TestResultServer/static-dashboards/treemap.html: Added.
• TestResultServer/static-dashboards/webtreemap.css: Added.
• TestResultServer/static-dashboards/webtreemap.js: Added.
• TestResultServer/stylesheets/dashboardfile.css: Removed.
• TestResultServer/stylesheets/menu.css:
• TestResultServer/templates/dashboardfilelist.html: Removed.
• TestResultServer/templates/menu.html:

4:40 PM Changeset in webkit [90673] by barraclough@apple.com

• 12 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=64181
REGRESSION (r90602): Gmail doesn't load

Rolling out r90601, r90602.

• dfg/DFGAliasTracker.h:
• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

• dfg/DFGNode.h:
• dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):
(JSC::DFG::dfgLinkCall):

• dfg/DFGRepatch.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• runtime/JSObject.h:

(JSC::JSObject::isUsingInlineStorage):

4:35 PM Changeset in webkit [90672] by Adam Roben

• 3 edits in trunk/Tools

Make TestFailures's list of flaky tests look more like the list of non-flaky tests

Fixes <​http://webkit.org/b/64204> TestFailures page's flaky tests list is ugly!

Reviewed by Daniel Bates.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(#failure-history, #possibly-flaky-tests): Expanded this rule to apply to the list of flaky
tests.
(#failure-history > li, #possibly-flaky-tests > li): Ditto, but moved the 50px left padding
from here...
(#failure-history > li): ...to here.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForPossiblyFlakyTests): Give the list an id attribute for
styling purposes.

3:57 PM Changeset in webkit [90671] by abarth@webkit.org

• 9 edits in trunk/Source

Unreviewed, rolling out r90662.
​http://trac.webkit.org/changeset/90662
​https://bugs.webkit.org/show_bug.cgi?id=64210

Introduced regressions in Chromium browser tests (Requested by
rniwa on #webkit).

Source/WebCore:

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedText):
(WebCore::AccessibilityRenderObject::selectedTextRange):
(WebCore::AccessibilityRenderObject::setSelectedTextRange):

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setSelectionRange):
(WebCore::HTMLTextFormControlElement::selectionStart):
(WebCore::HTMLTextFormControlElement::selectionEnd):
(WebCore::HTMLTextFormControlElement::selection):
(WebCore::HTMLTextFormControlElement::restoreCachedSelection):
(WebCore::HTMLTextFormControlElement::selectionChanged):

• html/HTMLFormControlElement.h:
• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):

• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::selectionStart):
(WebCore::RenderTextControl::selectionEnd):
(WebCore::RenderTextControl::hasVisibleTextArea):
(WebCore::setSelectionRange):
(WebCore::setContainerAndOffsetForRange):
(WebCore::RenderTextControl::selection):

• rendering/RenderTextControl.h:

Source/WebKit/qt:

• Api/qwebpage.cpp:

(QWebPagePrivate::inputMethodEvent):

3:32 PM Changeset in webkit [90670] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Make GL context current before updating layer texture using skia-gpu
​https://bugs.webkit.org/show_bug.cgi?id=64206

Patch by Brian Salomon <​bsalomon@google.com> on 2011-07-08
Reviewed by James Robinson.

Covered by existing tests (when accelerated drawing and compositing are on).

• platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):

3:25 PM Changeset in webkit [90669] by jpfau@apple.com

• 2 edits in trunk/Tools

2011-07-08 Jeffrey Pfau <​jpfau@apple.com>

Unreviewed, add myself as committer.

• Scripts/webkitpy/common/config/committers.py:

3:15 PM Changeset in webkit [90668] by tony@chromium.org

• 8 edits in trunk/Source/WebCore

Refactor override size to be a size rather than just an int
​https://bugs.webkit.org/show_bug.cgi?id=64195

Reviewed by David Hyatt.

Also convert to LayoutSize and LayoutUnit.

Covered by existing tests.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::overrideSize): Pass in a LayoutSize.
(WebCore::RenderBox::setOverrideSize):
(WebCore::RenderBox::clearOverrideSize): New method for clearing the

override size (previous we would pass in -1)

(WebCore::RenderBox::overrideWidth):
(WebCore::RenderBox::overrideHeight):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):

• rendering/RenderBox.h:
• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::setOverrideSizeFromRowHeight):

• rendering/RenderTableCell.h: Remove setOverrideSize since it was

only called in one place to clear the override size. Inline this
logic instead.

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

• rendering/RenderWidget.cpp:

(WebCore::RenderWidget::destroy):

3:01 PM Changeset in webkit [90667] by eae@chromium.org

• 16 edits in trunk/Source/WebCore

Switch pointInContainer and accumulatedOffset to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=64112

Reviewed by Eric Seidel.

Convert remaining IntPoint versions of the pointInContainer and
accumulatedOffset arguments to the new layout abstraction.

No new tests, no functionality changes.

• rendering/HitTestResult.cpp:

(WebCore::HitTestResult::addNodeToRectBasedTestResult):

• rendering/HitTestResult.h:
• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isPointInOverflowControl):

• rendering/RenderBlock.h:
• rendering/RenderBox.cpp:

(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::popContentsClip):

• rendering/RenderBox.h:
• rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):

• rendering/RenderEmbeddedObject.h:
• rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::hitTest):

• rendering/RenderLineBoxList.h:
• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::isPointInOverflowControl):

• rendering/RenderListBox.h:
• rendering/RenderObject.cpp:

(WebCore::RenderObject::hitTest):

• rendering/RenderObject.h:
• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::hitInnerTextElement):

• rendering/RenderTextControl.h:
• rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::nodeAtPoint):

2:50 PM Changeset in webkit [90666] by senorblanco@chromium.org

• 4 edits in trunk/LayoutTests

Unreviewed; new chromium GPU pixel results for overflow-scroll-expected.

• platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.png:
• platform/chromium-gpu-win/compositing/overflow/overflow-scroll-expected.png:
• platform/chromium/test_expectations.txt:

2:18 PM Changeset in webkit [90665] by abarth@webkit.org

• 3 edits
  1 add in trunk/Tools

TestResultsServer should keep old test results
​https://bugs.webkit.org/show_bug.cgi?id=64199

Reviewed by Ojan Vafai.

Having historical data will help us do failure archeology.

• TestResultServer/handlers/testfilehandler.py:
• TestResultServer/model/testfile.py:
• TestResultServer/templates/showfilelist.jsonp: Added.

1:58 PM Changeset in webkit [90664] by Adam Roben

• 2 edits in trunk/Tools

Remove commit-log-editor's dependency on Module::Load::Conditional

This module isn't available in Perl 5.8.8 (the version used on Leopard).

Fixes <​http://webkit.org/b/64198> REGRESSION (r90583):
webkitpy.common.checkout.checkout_unittest failing on Leopard

Reviewed by Daniel Bates.

• Scripts/commit-log-editor: Use the new loadTermReadKey() function instead of

Module::Load::Conditional::can_load.
(loadTermReadKey): Added. Tries to load Term::ReadKey and returns true if it's successful.

1:37 PM Changeset in webkit [90663] by Adam Roben

• 2 edits in trunk/LayoutTests

Skip all HTMLProgressElement tests on Windows

<​http://webkit.org/b/49769> tracks implementing this element on Windows. For now it's just a
source of failing tests.

• platform/win/Skipped: Skip the entire HTMLProgressElement directory so we don't have to

keep adding new tests one-by-one.

1:30 PM Changeset in webkit [90662] by rniwa@webkit.org

• 9 edits in trunk/Source

Move selection related code from RenderTextControl to HTMLTextFormControlElement
​https://bugs.webkit.org/show_bug.cgi?id=64133

Reviewed by Dimitri Glazkov.

Source/WebCore:

Moved selectionStart, selectionEnd, hasVisibleTextArea, setSelectionRange, setContainerAndOffsetForRange
and selection from RenderTextControl.cpp to HTMLFormControlElement.cpp.

This refactoring removes RenderTextControl's dependency on FrameSelection.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedText): Calls HTMLTextFromControl::selectedText.
(WebCore::AccessibilityRenderObject::selectedTextRange): Calls selectionStart and selectionEnd.
(WebCore::AccessibilityRenderObject::setSelectedTextRange): Ditto.

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::selectedText): Extracted from AccessibilityRenderObject::selectedText.
(WebCore::hasVisibleTextArea):
(WebCore::HTMLTextFormControlElement::setSelectionRange): Merged with the function of the same name in
RenderTextControl.
(WebCore::HTMLTextFormControlElement::selectionStart): Ditto.
(WebCore::HTMLTextFormControlElement::selectionEnd): Ditto.
(WebCore::setContainerAndOffsetForRange): Moved from RenderTextControl.cpp
(WebCore::HTMLTextFormControlElement::selection): Merged with the function of the same name in RenderTextControl.
(WebCore::HTMLTextFormControlElement::selectionChanged): Calls selectionStart and selectionEnd.

• html/HTMLFormControlElement.h:

(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Moved from HTMLFormControlElement.cpp now that
all functions are self-contained in HTMLTextFormControlElement.

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Calls setSelectionRange.

• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement): Added.

• rendering/RenderTextControl.h:

Source/WebKit/qt:

Replaced calls to WebCore::setSelectionRange by calls to HTMLTextFormControlElement::setSelectionRange.

• Api/qwebpage.cpp:

(QWebPagePrivate::inputMethodEvent):

1:28 PM Changeset in webkit [90661] by commit-queue@webkit.org

• 3 edits
  1 delete in trunk/Source/WebCore

remove (empty) indirection between GraphicsContextPlatformPrivate and PlatformContextSkia
​https://bugs.webkit.org/show_bug.cgi?id=64178

Patch by Mike Reed <​reed@google.com> on 2011-07-08
Reviewed by Stephen White.

No new tests. no functionality change, other than removing an indirection that is not needed

• platform/graphics/GraphicsContext.h:
• platform/graphics/skia/GraphicsContextPlatformPrivate.h: Removed.
• platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::platformContext):

1:28 PM Changeset in webkit [90660] by senorblanco@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed; chromium test_expectations update.

Add some MAC GPU failing tests from r90464.

• platform/chromium/test_expectations.txt:

1:02 PM Changeset in webkit [90659] by Adam Roben

• 2 edits in trunk/Tools

Make checkout_unittest more robust against files moving around

Fixes <​http://webkit.org/b/64197> checkout_unittest contains ugly, fragile code to find the
Scripts directory

Reviewed by Adam Barth.

• Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Instantiate a real SCM
object and use it to get the path to the Scripts directory, rather than hard-coding the
relative path from this file to Scripts.

1:01 PM Changeset in webkit [90658] by senorblanco@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed; chromium test_expectations update.

Add some WIN GPU failing tests from r90464 to test_expectations.txt.

• platform/chromium/test_expectations.txt:

12:54 PM Changeset in webkit [90657] by senorblanco@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed; chromium test rebaseline.

New baseline for a failing test on GPU linux introduced in r90646.

• platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:

12:51 PM Changeset in webkit [90656] by Adam Roben

• 2 edits in trunk/Tools

Make TestFailures remember that run-webkit-tests timed out, even across reloads

Fixes <​http://webkit.org/b/64193> TestFailures page incorrectly thinks all tests passed in
​http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14589 after a reload

Reviewed by Daniel Bates.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Store an "error" attribute in the cached data.
When true, it indicates that there was an error retrieving the results for this build and
that the errorCallback should be called.

12:47 PM Changeset in webkit [90655] by senorblanco@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed; chromium test expectations cleanup.

Removed some duplicate expectations.

• platform/chromium/test_expectations.txt:

12:31 PM Changeset in webkit [90654] by jpfau@apple.com

• 3 edits
  2 adds in trunk/Source/WebCore

Add framework for a new/dummy XMLDocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=63955

Reviewed by Adam Barth.

Added a dummy framework NewXMLDocumentParser

• WebCore.xcodeproj/project.pbxproj:
• dom/Document.cpp:

(WebCore::Document::createParser):

• xml/parser/NewXMLDocumentParser.cpp: Added.

(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::textPosition):
(WebCore::NewXMLDocumentParser::lineNumber):
(WebCore::NewXMLDocumentParser::insert):
(WebCore::NewXMLDocumentParser::append):
(WebCore::NewXMLDocumentParser::finish):
(WebCore::NewXMLDocumentParser::detach):
(WebCore::NewXMLDocumentParser::hasInsertionPoint):
(WebCore::NewXMLDocumentParser::finishWasCalled):
(WebCore::NewXMLDocumentParser::processingData):
(WebCore::NewXMLDocumentParser::prepareToStopParsing):
(WebCore::NewXMLDocumentParser::stopParsing):
(WebCore::NewXMLDocumentParser::isWaitingForScripts):
(WebCore::NewXMLDocumentParser::isExecutingScript):
(WebCore::NewXMLDocumentParser::executeScriptsWaitingForStylesheets):

• xml/parser/NewXMLDocumentParser.h: Added.

(WebCore::NewXMLDocumentParser::create):

12:27 PM Changeset in webkit [90653] by ojan@chromium.org

• 2 edits in trunk/Source/WebCore

Remove unused function parameters.

Patch by David Reveman <​reveman@chromium.org> on 2011-07-08
Reviewed by Ryosuke Niwa.

• platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::textureOffset):

12:26 PM Changeset in webkit [90652] by abarth@webkit.org

• 9 edits in trunk/Tools

Teach garden-o-matic how to display test results
​https://bugs.webkit.org/show_bug.cgi?id=64141

Reviewed by Ojan Vafai.

This patch includes basic infrastructure for probing build.chromium.org
for test results. We only handle text and image tests, not anything
complicated like reftests. Also, we're using the revision/build
independent results store on the server, so we're avoiding that
complication for now.

It's slightly hacky that we need to probe the server to see what kinds
of results exist. A better solution would be to add CORS support to
the server or to use the local server to help.

• Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
• Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
• Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
• Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
• Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
• Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:

12:21 PM Changeset in webkit [90651] by dpranke@chromium.org

• 3 edits in trunk/Tools

REGRESSION(90419) NRWT's httpd locking is broken for --child-processes=1
​https://bugs.webkit.org/show_bug.cgi?id=64092

Reviewed by Tony Chang.

The code was incorrectly creating empty shards in the
shard_in_two case.

• Scripts/webkitpy/layout_tests/controllers/manager.py:
• Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

12:05 PM Changeset in webkit [90650] by Adam Roben

• 2 edits in trunk/Tools

Teach buildbot to figure out how many webkitpy/webkitperl tests failed

Fixes <​http://webkit.org/b/64192> It's hard to tell how many test-webkitpy/test-webkitperl
tests failed when looking at build.webkit.org

Reviewed by Eric Seidel.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestWithFailureCount): New class that represents a test build step which has an associated
failure count. Eventually we should move more of our test classes to deriving from this.
(TestWithFailureCount.countFailures): Method for subclasses to override to say how many
failures occurred.

(TestWithFailureCount.commandComplete):
(TestWithFailureCount.evaluateCommand):
(TestWithFailureCount.getText):
(TestWithFailureCount.getText2):
These were all based on RunGtkAPITests.

(RunPythonTests): Changed to inherit from TestWithFailureCount.
(RunPythonTests.countFailures): Parses the test-webkitpy output looking for the count of
failures.
(RunPerlTests): Changed to inherit from TestWithFailureCount.
(RunPerlTests.countFailures): Parses the test-webkitperl output looking for the count of
failures.

11:59 AM Changeset in webkit [90649] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Patch by Kalev Lember <​kalev@smartlink.ee> on 2011-07-08
Reviewed by Adam Roben.

Add missing _WIN32_WINNT and WINVER definitions
​https://bugs.webkit.org/show_bug.cgi?id=59702

Moved _WIN32_WINNT and WINVER definitions to config.h so that they are
available for all source files.

In particular, wtf/FastMalloc.cpp uses CreateTimerQueueTimer and
DeleteTimerQueueTimer which are both guarded by
#if (_WIN32_WINNT >= 0x0500)
in MinGW headers.

• config.h:
• wtf/Assertions.cpp:

11:47 AM Changeset in webkit [90648] by Adam Roben

• 2 edits in trunk/Tools

Ensure $CHANGE_LOG_EMAIL_ADDRESS is set when testing webkitpy's commit-log-editor integration

Fixes <​http://webkit.org/b/64180> REGRESSION (r90564): test-webkitpy failing on multiple
bots due to commit-log-editor errors

Reviewed by Adam Barth.

• Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Set
$CHANGE_LOG_EMAIL_ADDRESS to the patch author's email address. This ensures that
commit-log-editor can find a value for the committer's email, and that the committer and
author email addresses match, which will prevent commit-log-editor from inserting a "Patch
by" line in the commit message.

11:37 AM Changeset in webkit [90647] by andreas.kling@nokia.com

• 16 edits
  2 adds in trunk

[Qt][WK2] Views should expose QActions for basic navigation.
​https://bugs.webkit.org/show_bug.cgi?id=64174

Source/WebKit2:

Add navigationAction() methods to the views to provide default
QActions for Back, Forward, Stop and Reload.

Reviewed by Benjamin Poulain.

• UIProcess/API/qt/WKView.h:
• UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::navigationAction):

• UIProcess/API/qt/qdesktopwebview.h:
• UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::navigationAction):

• UIProcess/API/qt/qtouchwebpage.h:
• UIProcess/API/qt/qwebkittypes.h: Added.
• UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:

(tst_CommonViewTests::backAndForward):
(tst_CommonViewTests::reload):
(tst_CommonViewTests::stop):

• UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::triggerNavigationAction):

• UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
• UIProcess/API/qt/tests/html/basic_page2.html: Added.
• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::navigationAction):

• UIProcess/qt/QtWebPageProxy.h:
• WebKit2API.pri:

Tools:

Reviewed by Benjamin Poulain.

Bring the toolbar in Qt's MiniBrowser back to life.

• MiniBrowser/qt/BrowserView.cpp:

(BrowserView::navigationAction):

• MiniBrowser/qt/BrowserView.h:
• MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

11:33 AM Changeset in webkit [90646] by commit-queue@webkit.org

• 13 edits
  3 adds in trunk

Patch by David Reveman <​reveman@chromium.org> on 2011-07-08
Reviewed by Stephen White.

[Chromium] Edge anti-aliasing for composited layers.
​https://bugs.webkit.org/show_bug.cgi?id=61388

Source/WebCore:

Add transparent outer border to tiled layers and adjust vertex
coordinates so that use of a bilinear filter creates a smooth
layer edge.

Tests: platform/chromium/compositing/tiny-layer-rotated.html

platform/chromium/compositing/huge-layer-rotated.html (existing)
TilingDataTest in webkit_unit_tests

• platform/graphics/chromium/ContentLayerChromium.cpp:

Change maxUntiledSize to 510 to ensure that tiles are not greater
than 512 with outer borders.
(WebCore::ContentLayerChromium::updateLayerSize): We can't use the
layer size as tile size when we want to avoid tiling as this will
not be enough space to include possible outer borders. We instead use
an empty size, which allows the tiler to automatically adjust the
tile size to be large enough for the layer to fit in one tile.
(WebCore::ContentLayerChromium::createTilerIfNeeded):
(WebCore::ContentLayerChromium::setIsMask): Don't use border texels
for layer used as mask.

• platform/graphics/chromium/ContentLayerChromium.h:

(WebCore::ContentLayerChromium::m_borderTexels) Added.

• platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::tileTexRect): Added.
(WebCore::LayerTilerChromium::tileLayerRect): m_tileSize is no
longer the correct layer size. Size of bounds with border should
be the correct layer size.
(WebCore::LayerTilerChromium::growLayerToContain): Adjust texture
size to include outer borders and handle empty m_tileSize.
(WebCore::LayerTilerChromium::invalidateRect): Use size of rectangle
returned by tileTexRect instead of m_tileSize for texture size.
(WebCore::LayerTilerChromium::prepareToUpdate): Ditto.
(WebCore::LayerTilerChromium::draw): Compute and intersect tile edges
instead of using tile coordinates directly. Edges are adjusted to
include outer borders and make sure all partially covered pixels are
processed.
(WebCore::LayerTilerChromium::drawTexturedQuad): Pass quad to
shader using point uniform.
(WebCore::LayerTilerChromium::invalidateRect): Invalidate old layer
area to clear any contents left from previous layer size.

• platform/graphics/chromium/LayerTilerChromium.h:

(WebCore::LayerTilerChromium::tileTexRect) Added.
(WebCore::LayerTilerChromium::drawTexturedQuad): Add quad parameter.

• platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexTransform::getShaderString) Get X/Y vertex
components from point uniform.
(WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform)
Added point uniform.
(WebCore::VertexShaderPosTexTransform::init) Ditto.
(WebCore::VertexShaderPosTexTransform::pointLocation) Added.

• platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderPosTexTransform::pointLocation) Added.

• platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::tileBoundsWithOuterBorder): Added.
(WebCore::TilingData::computeNumTiles): Adjust for outer border.
(WebCore::TilingData::tileXIndexFromSrcCoord): Ditto.
(WebCore::TilingData::tileYIndexFromSrcCoord): Ditto.
(WebCore::TilingData::tileSizeX): Ditto.
(WebCore::TilingData::tileSizeY): Ditto.
(WebCore::TilingData::intersectDrawQuad): Ditto.
(WebCore::TilingData::textureOffset): Ditto.

• platform/graphics/gpu/TilingData.h:

(WebCore::TilingData::tileBoundsWithOuterBorder): Added.

Source/WebKit:

Track changes to TilingData class which now uses an outer border.

• chromium/tests/TilingDataTest.cpp:

LayoutTests:

• platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
• platform/chromium/compositing/tiny-layer-rotated-expected.txt: Added.
• platform/chromium/compositing/tiny-layer-rotated.html: Added.
• platform/chromium/test_expectations.txt:

11:13 AM Changeset in webkit [90645] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[skia] don't rely on lockPixels failure to detect gpu-backed device (in prep for skia roll)
​https://bugs.webkit.org/show_bug.cgi?id=64162

Patch by Mike Reed <​reed@google.com> on 2011-07-08
Reviewed by Stephen White.

No new tests. preparing for skia roll, where lockPixels always succeeds (but slowly for gpu-backed)

• platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::putImageData):

11:06 AM Changeset in webkit [90644] by benjamin.poulain@nokia.com

• 6 edits in trunk/Source/WebKit2

[Qt][WK2] Get rid of the check for TILED_BACKING_STORE in Qt
​https://bugs.webkit.org/show_bug.cgi?id=64175

Reviewed by Kenneth Rohde Christiansen.

Qt no longer supports building WebKit2 without TILED_BACKING_STORE.

• UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::onScaleChanged):

• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::setResizesToContentsUsingLayoutSize):

• UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
• UIProcess/qt/TiledDrawingAreaTileQt.cpp:
• WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp:

10:54 AM Changeset in webkit [90643] by commit-queue@webkit.org

• 11 edits in trunk/Source

Source/JavaScriptCore: Rename "makeSecure" to "fill" and remove the support for displaying last character
to avoid layering violatation.
​https://bugs.webkit.org/show_bug.cgi?id=59114

Patch by Chang Shu <​cshu@webkit.org> on 2011-07-08
Reviewed by Alexey Proskuryakov.

• JavaScriptCore.exp:
• JavaScriptCore.order:
• wtf/text/StringImpl.cpp:

(WTF::StringImpl::fill):

• wtf/text/StringImpl.h:
• wtf/text/WTFString.h:

(WTF::String::fill):

Source/WebCore: Update calling sites after function renamed.
​https://bugs.webkit.org/show_bug.cgi?id=59114

Patch by Chang Shu <​cshu@webkit.org> on 2011-07-08
Reviewed by Alexey Proskuryakov.

No new tests, just refactoring.

• editing/visible_units.cpp:

(WebCore::previousBoundary):
(WebCore::nextBoundary):

• rendering/RenderText.cpp:

(WebCore::RenderText::setTextInternal):

Source/WebKit/win: Update calling sites after function renamed.
​https://bugs.webkit.org/show_bug.cgi?id=59114

Patch by Chang Shu <​cshu@webkit.org> on 2011-07-08
Reviewed by Alexey Proskuryakov.

• WebKitGraphics.cpp:

(WebDrawText):

10:51 AM WebKit2 edited by andreas.kling@nokia.com

(diff)

10:29 AM Changeset in webkit [90642] by commit-queue@webkit.org

• 12 edits
  3 adds in trunk

[CSSRegions]Parse content: -webkit-from-flow
​https://bugs.webkit.org/show_bug.cgi?id=63133

Patch by Mihnea Ovidenie <​mihnea@adobe.com> on 2011-07-08
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/content-webkit-from-flow-parsing.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::contentToCSSValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFromFlowContent):

• css/CSSParser.h:
• css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::cssText):

• css/CSSPrimitiveValue.h:
• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

• rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::regionThread):
(WebCore::InheritedFlags::setRegionThread):
(WebCore::InheritedFlags::initialRegionThread):

• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

• rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

• fast/regions/content-webkit-from-flow-parsing-expected.txt: Added.
• fast/regions/content-webkit-from-flow-parsing.html: Added.
• fast/regions/script-tests/content-webkit-from-flow-parsing.js: Added.

10:24 AM Changeset in webkit [90641] by Nate Chapin

• 2 edits in trunk/Source/WebKit/chromium

Check activeDocumentLoader() in
WebFrameImpl::currentHistoryItem() and return
early if null, since that should mean we're
shutting down.
​https://bugs.webkit.org/show_bug.cgi?id=52923

Reviewed by Darin Fisher.

No known repro, so no new test.

• src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::currentHistoryItem):

9:13 AM Changeset in webkit [90640] by vsevik@chromium.org

• 4 edits in trunk/LayoutTests

REGRESSION (r90557): http/tests/inspector/network/network-embed.html fails
​https://bugs.webkit.org/show_bug.cgi?id=64103

Unreviewed test fix (typo).

• http/tests/inspector/network/network-embed.html:

9:09 AM Changeset in webkit [90639] by Adam Roben

• 3 edits in trunk/Tools

Teach TestFailures how to find test names in commit-log-editor-style commit messages

TestFailures was relying on Trac turning the list of modified files in our commit messages
into an HTML list. But Trac only does this when the list of modified files is indented.
commit-log-editor doesn't indent the file list, so the list wasn't being turned into an HTML
list, which was confusing TestFailures.

TestFailures now does much simpler parsing of the commit message (i.e., just a substring
search) without relying at all on its structure.

Fixes <​http://webkit.org/b/64173> TestFailures page fails to blame r90608 for breaking
fast/dom/HTMLProgressElement/progress-element-markup.html on Windows

Reviewed by David Kilzer.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:

(Trac.prototype.getCommitDataForRevisionRange): Instead of trying to parse the commit
message, just return its text.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForRegressionRange): Instead of searching for test names in
each commit's list of modified files, just search for test names anywhere in the commit's
message.

9:04 AM Changeset in webkit [90638] by pfeldman@chromium.org

• 3 edits in trunk/LayoutTests

Web Inspector: styles-disable-then-delete was flaky.
​https://bugs.webkit.org/show_bug.cgi?id=64170

Reviewed by Yury Semikhatsky.

• inspector/styles/styles-add-invalid-property.html:
• inspector/styles/styles-disable-then-delete.html:

9:01 AM Changeset in webkit [90637] by vsevik@chromium.org

• 2 edits
  2 adds in trunk/LayoutTests

Web Inspector: inspector/styles/styles-url-linkify.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=64171

Added image files because the behavior differs when they are not available.

Unreviewed test fix: added image files.

• inspector/styles/resources/fromcss.png: Added.
• inspector/styles/resources/iframed.png: Added.
• inspector/styles/styles-url-linkify-expected.txt:

8:58 AM Changeset in webkit [90636] by abarth@webkit.org

• 3 edits in trunk/Tools

sheriffbot is too spammy in IRC
​https://bugs.webkit.org/show_bug.cgi?id=64153

Reviewed by Eric Seidel.

Reporting failures in IRC worked well when the tree was greener than it
is today. Nowadays, this feature mostly just results in spam about
false positives. If we reach a greener state, we can bring this code
back.

(Another possibility is to restrict this feature to builder bots,
rather than including testers, as we did before this patch.)

• Scripts/webkitpy/tool/commands/sheriffbot.py:
• Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

8:53 AM Changeset in webkit [90635] by loislo@chromium.org

• 3 edits in trunk/Source/WebCore

Web Inspector: NetworkPanel search failed if the matched sting is in the query part of url
​https://bugs.webkit.org/show_bug.cgi?id=64167

Reviewed by Yury Semikhatsky.

• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype._matchResource):
(WebInspector.NetworkPanel.prototype._highlightNthMatchedResource):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):

• inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.get folder):

8:50 AM Changeset in webkit [90634] by benjamin.poulain@nokia.com

• 2 edits in trunk/Source/WebCore

[Qt] Enable HTTP Pipelining by default
​https://bugs.webkit.org/show_bug.cgi?id=64169

Reviewed by Andreas Kling.

QNetworkAccessManager disables HTTP pipelining by default. We enable it by
setting an attribute on the request.

• platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

8:46 AM Changeset in webkit [90633] by abecsi@webkit.org

• 3 edits in trunk/LayoutTests

[Qt] http/tests/plugins/get-url.html is crashing on the bot
​https://bugs.webkit.org/show_bug.cgi?id=64168

Unreviewed gardening.

The cause of the crash revealed itself as a side effect thus
it is better to expect the test to CRASH rather than skipping it.

• platform/qt/Skipped: Unskip test.
• platform/qt/test_expectations.txt: Mark as CRASH

8:22 AM Changeset in webkit [90632] by Adam Roben

• 2 edits in trunk/Tools

Ensure commit-log-editor adds a "Patch by" line when the author and committer are different

Previously we were only adding a "Patch by" line when the ChangeLog contained a "Reviewed
by" line. But some patches (like rollout patches) don't contain that line. Now we always add
"Patch by" to the commit log regardless of the ChangeLog's contents.

Fixes <​http://webkit.org/b/64127> Committer for r90588 is ​commit-queue@webkit.org, but
should have been ​abarth@webkit.org

Reviewed by Anders Carlsson.

• Scripts/commit-log-editor:

(createCommitMessage): Try to put the "Patch by" line just above the "Reviewed by" line, as
before. If there is no "Reviewed by" line, try to put it just above the first modified file.
If all else fails, put it at the end of the commit message.
(patchAuthorshipString): Added. Code came from createCommitMessage.

7:58 AM Changeset in webkit [90631] by abecsi@webkit.org

• 2 edits in trunk/LayoutTests

[Qt] http/tests/plugins/get-url.html is crashing on the bot
​https://bugs.webkit.org/show_bug.cgi?id=64168

Unreviewed gardening.

• platform/qt/Skipped: Skip the test.

7:51 AM Changeset in webkit [90630] by apavlov@chromium.org

• 5 edits in trunk

Web Inspector: CSS inspector gets confused about specificity of !important properties
​https://bugs.webkit.org/show_bug.cgi?id=64074

Reviewed by Yury Semikhatsky.

Source/WebCore:

• inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._markUsedProperties):

LayoutTests:

• inspector/elements/elements-panel-styles-expected.txt:
• inspector/elements/resources/elements-panel-styles.css:

(#container .foo):
(.foo):

7:42 AM Changeset in webkit [90629] by benjamin.poulain@nokia.com

• 7 edits in trunk/Source

[WK2] Do not forward touch events to the web process when it does not need them
​https://bugs.webkit.org/show_bug.cgi?id=64164

Reviewed by Kenneth Rohde Christiansen.

Source/JavaScriptCore:

Add a convenience function to obtain a reference to the last element of a Deque.

• wtf/Deque.h:

(WTF::Deque::last):

Source/WebKit2:

The call to ChromeClient::needTouchEvent() is now forwarded to the WebPageProxy
to change the way events are delivered.

When the WebPage does not need touch events, and there is no queued touch events,
the incoming events just bounce back through PageClient::doneWithTouchEvent().

In the case when new events come to WebPageProxy and there are still touch events
incoming from the WebProcess, the new events are deferred with the corresponding
pending touch events.
Deferring the new events iafter the corresponding forwarded event ensure
the delivery is always done in order when PageClient::doneWithTouchEvent()
is called.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::needTouchEvents):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::processDidCrash):

• UIProcess/WebPageProxy.h:

(WebKit::QueuedTouchEvents:::forwardedEvent):

• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::needTouchEvents):

7:34 AM Changeset in webkit [90628] by apavlov@chromium.org

• 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed, clang build fix.

• inspector/InspectorStyleTextEditor.h:

6:51 AM TestExpectations edited by Adam Roben

A few small formatting tweaks, and replaced the Contents section with … (diff)

6:44 AM NewRunWebKitTests edited by Adam Roben

Just a few formatting tweaks, and replaced the Contents section with … (diff)

6:42 AM Changeset in webkit [90627] by kov@webkit.org

• 2 edits in trunk/Source/WebKit/gtk

[GTK] testwebview API test fails after ​http://trac.webkit.org/changeset/90471
​https://bugs.webkit.org/show_bug.cgi?id=64159

Rework the icon-uri change test so that the condition for quitting
the mainloop is the icon-uri change itself, along with a timeout
to avoid taking too long in case of failure. Since the conditions
for considering a page loaded were changed we can't rely on that
for this test anymore.

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2011-07-08
Reviewed by Xan Lopez.

• tests/testwebview.c:

(timeout_cb): error out if it takes too long for the icon-uri
change to happen.
(icon_uri_changed_cb): quit the loop here instead of waiting on
the page being loaded.
(test_webkit_web_view_icon_uri):

6:25 AM Changeset in webkit [90626] by pfeldman@chromium.org

• 4 edits in trunk/Source/WebCore

Web Inspector: add support for drag'n'drop of non-elements (comments, text, etc.)
​https://bugs.webkit.org/show_bug.cgi?id=64163

Reviewed by Yury Semikhatsky.

• inspector/Inspector.json:
• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::moveTo):

• inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._isValidDragSourceOrTarget):

6:21 AM Changeset in webkit [90625] by caseq@chromium.org

• 6 edits in trunk

2011-07-08 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: secure access to extensions API
​https://bugs.webkit.org/show_bug.cgi?id=64080

Reviewed by Pavel Feldman.

• inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
• inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionPanel):
• inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onSetSidebarPage): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler): (WebInspector.ExtensionServer.prototype._expandResourcePath): (WebInspector.ExtensionServer.prototype._normalizePath):

2011-07-08 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: secure access to extensions API
​https://bugs.webkit.org/show_bug.cgi?id=64080

Reviewed by Pavel Feldman.

• inspector/extensions/extensions.html: add explicit base paths to extension resource being loaded.

6:19 AM Changeset in webkit [90624] by zherczeg@webkit.org

• 2 edits in trunk/Tools

Reviewed by Andreas Kling.

Adding myself as a reviewer.

• Scripts/webkitpy/common/config/committers.py:

5:55 AM Changeset in webkit [90623] by abecsi@webkit.org

• 2 edits in trunk/LayoutTests

Add BUG modifier which was accidentally removed in the previous commit

Unreviewed.

• platform/qt/test_expectations.txt:

5:29 AM Changeset in webkit [90622] by abecsi@webkit.org

• 2 edits in trunk/LayoutTests

[Qt] Some tests are flaky with NRWT
​https://bugs.webkit.org/show_bug.cgi?id=64002

Unreviewed gardening.

• platform/qt/test_expectations.txt: Skip fast/forms/textfield-overflow-by-value-update.html

because it sometimes does not produce any output.

4:56 AM Changeset in webkit [90621] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r90615.
​http://trac.webkit.org/changeset/90615
​https://bugs.webkit.org/show_bug.cgi?id=64158

broke inspector/extensions/extensions.html (Requested by caseq
on #webkit).

• inspector/front-end/ExtensionAPI.js:

(WebInspector.injectedExtensionAPI.Panels.prototype.create):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
(WebInspector.injectedExtensionAPI.expandURL):

• inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel):

• inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._onWindowMessage):
(WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):

4:53 AM Changeset in webkit [90620] by abecsi@webkit.org

• 2 edits in trunk/LayoutTests

Rebaseline expected file after r90567

Unreviewed.

• inspector/styles/styles-url-linkify-expected.txt:

4:32 AM Changeset in webkit [90619] by apavlov@chromium.org

• 14 edits
  4 adds in trunk

Web Inspector: Adding CSS properties results in messy style rules
​https://bugs.webkit.org/show_bug.cgi?id=63622

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/styles-formatting.html

• CMakeLists.txt:
• GNUmakefile.list.am:
• WebCore.gypi:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSPropertySourceData.cpp:

(WebCore::SourceRange::length):

• css/CSSPropertySourceData.h:
• inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::InspectorStyle):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::toggleProperty):
(WebCore::InspectorStyle::applyStyleText):
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):

• inspector/InspectorStyleSheet.h:
• inspector/InspectorStyleTextEditor.cpp: Added.

(WebCore::InspectorStyleTextEditor::InspectorStyleTextEditor):
(WebCore::InspectorStyleTextEditor::insertProperty):
(WebCore::InspectorStyleTextEditor::replaceProperty):
(WebCore::InspectorStyleTextEditor::removeProperty):
(WebCore::InspectorStyleTextEditor::enableProperty):
(WebCore::InspectorStyleTextEditor::disableProperty):
(WebCore::InspectorStyleTextEditor::disabledIndexByOrdinal):
(WebCore::InspectorStyleTextEditor::shiftDisabledProperties):
(WebCore::InspectorStyleTextEditor::internalReplaceProperty):

• inspector/InspectorStyleTextEditor.h: Added.

(WebCore::InspectorStyleTextEditor::styleText):

LayoutTests:

• inspector/styles/styles-formatting-expected.txt: Added.
• inspector/styles/styles-formatting.html: Added.
• inspector/styles/styles-new-API-expected.txt:
• inspector/styles/styles-new-API.html:

4:25 AM Changeset in webkit [90618] by commit-queue@webkit.org

• 9 edits
  2 adds in trunk/Source/WebKit2

[Qt][WK2] Add basic support for panning gestures to the QTouchWebView
​https://bugs.webkit.org/show_bug.cgi?id=64105

Patch by Benjamin Poulain <​benjamin@webkit.org> on 2011-07-08
Reviewed by Kenneth Rohde Christiansen.

This patch adds basic support for the panning gesture on the UI process side.

The events coming back from the WebProcess are processed through
the QtPanGestureRecognizer to recognize the pan gesture. When the
gesture is recognized, the actions are performed on the view through
the TouchViewInterface.

Currently, the viewport just move the page around without limit.
This will be improved when a physics engine is integrated.

• UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::scroll):

• UIProcess/API/qt/qtouchwebview.h:
• UIProcess/API/qt/qtouchwebview_p.h:
• UIProcess/qt/QtPanGestureRecognizer.cpp: Added.

(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::recognize):
(WebKit::QtPanGestureRecognizer::reset):

• UIProcess/qt/QtPanGestureRecognizer.h: Added.
• UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::panGestureStarted):
(WebKit::TouchViewInterface::panGestureRequestScroll):
(WebKit::TouchViewInterface::panGestureEnded):
(WebKit::TouchViewInterface::panGestureCancelled):

• UIProcess/qt/TouchViewInterface.h:
• UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::QTouchWebPageProxy):
(QTouchWebPageProxy::processDidCrash):
(QTouchWebPageProxy::doneWithTouchEvent):

• UIProcess/qt/qtouchwebpageproxy.h:
• WebKit2.pro:

4:16 AM Changeset in webkit [90617] by apavlov@chromium.org

• 5 edits in trunk

Web Inspector: Quotes are rendered as &quot; in the DOM tree
​https://bugs.webkit.org/show_bug.cgi?id=64154

Reviewed by Yury Semikhatsky.

Source/WebCore:

Since we currently rely on setting textContent rather than innerHTML for the DOM tree elements,
escapeHTML() calls unnecessarily HTML-escape certain characters in the DOM tree contents.

• inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
():

LayoutTests:

• inspector/elements/elements-panel-structure-expected.txt:
• inspector/elements/elements-panel-structure.html:

4:03 AM Changeset in webkit [90616] by vsevik@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Remove unused code from InspectorAgent.h.
​https://bugs.webkit.org/show_bug.cgi?id=64120

Reviewed by Joseph Pecoraro.

• inspector/InspectorAgent.h:

3:39 AM Changeset in webkit [90615] by caseq@chromium.org

• 4 edits in trunk/Source/WebCore

2011-07-08 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: secure access to extensions API
​https://bugs.webkit.org/show_bug.cgi?id=64080

Reviewed by Pavel Feldman.

• inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
• inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionPanel):
• inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onSetSidebarPage): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler): (WebInspector.ExtensionServer.prototype._expandResourcePath): (WebInspector.ExtensionServer.prototype._normalizePath):

3:12 AM Changeset in webkit [90614] by yurys@chromium.org

• 3 edits
  3 adds in trunk

Web Inspector: typing undefined = 1 in console crashes browser
​https://bugs.webkit.org/show_bug.cgi?id=64155

Source/WebCore:

Do not access undefined value directly when producing JSON objects as undefined
may be overriden by the inspected page.

Reviewed by Pavel Feldman.

Test: inspector/console/console-eval-undefined-override.html

• inspector/InjectedScriptSource.js:

(.):
():

LayoutTests:

Reviewed by Pavel Feldman.

• inspector/console/console-eval-undefined-override-expected.txt: Added.
• inspector/console/console-eval-undefined-override.html: Added.
• platform/chromium/inspector/console/console-eval-undefined-override-expected.txt: Added.

1:37 AM Changeset in webkit [90613] by caseq@chromium.org

• 1 edit
  1 move in trunk/LayoutTests

2011-07-08 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Moving test expectation from platform-specific to generic.

• fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt.

Jul 7, 2011:

11:41 PM Changeset in webkit [90612] by yutak@chromium.org

• 2 edits in trunk/LayoutTests

WebSocket: Clear cookies after test in httponly-cookie.pl
​https://bugs.webkit.org/show_bug.cgi?id=64145

Reviewed by Kent Tamura.

This test leaks cookies, which would cause a test failure if we put
a copy of this test under http/tests/websocket/tests.

To avoid this issue, cookies should be removed before the test ends.

• http/tests/websocket/tests/hixie76/httponly-cookie.pl:

After the test, send an XHR request to itself with a query parameter,
which erases cookies used in this test by setting "Max-Age=0".

9:59 PM Changeset in webkit [90611] by kevino@webkit.org

• 2 edits
  1 delete in trunk/Tools

[wx] Unreviewed build fix, remove old files from the tree and update paths to new ones.

9:53 PM Changeset in webkit [90610] by kevino@webkit.org

• 2 edits in trunk/Tools

[wx] Unreviewed build fix, more fixes for install name issues.

8:53 PM Changeset in webkit [90609] by tkent@chromium.org

• 5 edits
  1 delete in trunk/LayoutTests

[Chromium] Update baseline files for input-appearance-range.html.

• platform/chromium-linux/fast/forms/input-appearance-range-expected.png:
• platform/chromium-mac-leopard/fast/forms/input-appearance-range-expected.png:
• platform/chromium-mac/fast/forms/input-appearance-range-expected.png: Removed.
• platform/chromium-win/fast/forms/input-appearance-range-expected.png:
• platform/chromium/test_expectations.txt:

7:46 PM Changeset in webkit [90608] by morrita@google.com

• 8 edits
  4 adds in trunk/LayoutTests

dump-as-markup.js should support shadow tree
​https://bugs.webkit.org/show_bug.cgi?id=62447

Reviewed by Ryosuke Niwa.

• Added shadow support to Markup._get()
• Updated expectations caused by this change.
• Added explanatory test cases for shadows.

• editing/inserting/5607069-2-expected.txt:
• editing/inserting/5607069-3-expected.txt:
• editing/pasteboard/copy-null-characters-expected.txt:
• editing/selection/dump-as-markup-expected.txt:
• editing/selection/dump-as-markup-form-text-expected.txt:
• fast/parser/object-with-textarea-fallback-expected.txt:
• fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: Added.
• fast/dom/HTMLMeterElement/meter-element-markup.html: Added.
• fast/dom/HTMLProgressElement/progress-element-markup-expected.txt: Added.
• fast/dom/HTMLProgressElement/progress-element-markup.html: Added.
• fast/dom/HTMLMeterElement/meter-element-markup.html:
• fast/dom/HTMLProgressElement/progress-element-markup.html:
• resources/dump-as-markup.js:

(Markup._get):

7:22 PM Changeset in webkit [90607] by dpranke@chromium.org

• 5 edits in trunk/Tools

test-webkitpy fails on chromium win
​https://bugs.webkit.org/show_bug.cgi?id=64137

Reviewed by Eric Seidel.

test-webkitpy doesn't play nicely with the multiprocessing
module on win32. An earlier change actually reenabled the tests
on win32 by mistake.

This patch also fixes a few cases where path names will trip
things up on win32 (e.g., by testing unix paths on windows).
We do not lose any real coverage here with those fixes.

• Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
• Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
• Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

7:13 PM Changeset in webkit [90606] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[ImageDiff] Calculate/print difference right after reading baseline image.
​https://bugs.webkit.org/show_bug.cgi?id=64117

Patch by Leandro Pereira <​leandro@profusion.mobi> on 2011-07-07
Reviewed by Kent Tamura.

Otherwise, ImageDiff will block on fgets() until the universe ends or you ^{C
it. Whichever happens first.}

• DumpRenderTree/efl/ImageDiff.cpp:

(main):

6:16 PM Changeset in webkit [90605] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[EFL] DRT: Leak cairo_t to make the pixel tests stop crashing
​https://bugs.webkit.org/show_bug.cgi?id=64107

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-07-07
Reviewed by Kent Tamura.

The pointer is later managed by BitmapContext, but it was being
de-refed and deleted earlier by our RefPtr, causing crashes in all
pixel tests.

We now call leakRef() to make sure it is not removed when our
createBitmapContextFromWebView goes out of context.

• DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView):

5:49 PM Changeset in webkit [90604] by yutak@chromium.org

• 2 edits in trunk/LayoutTests

WebSocket: Use jsTestIsAsync and finishJSTest() in httponly-cookie.pl
​https://bugs.webkit.org/show_bug.cgi?id=64087

Reviewed by Kent Tamura.

• http/tests/websocket/tests/hixie76/httponly-cookie.pl:

5:17 PM Changeset in webkit [90603] by eae@chromium.org

• 5 edits in trunk/Source/WebCore

Switch HitTestResult to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=64131

Reviewed by Eric Seidel.

No new tests, no functionality changes.

• page/MouseEventWithHitTestResults.cpp:

(WebCore::MouseEventWithHitTestResults::localPoint):

• page/MouseEventWithHitTestResults.h:
• rendering/HitTestResult.cpp:

(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
(WebCore::HitTestResult::rectForPoint):

• rendering/HitTestResult.h:

(WebCore::HitTestResult::point):
(WebCore::HitTestResult::localPoint):
(WebCore::HitTestResult::setPoint):
(WebCore::HitTestResult::setLocalPoint):
(WebCore::HitTestResult::rectForPoint):

4:54 PM Changeset in webkit [90602] by commit-queue@webkit.org

• 11 edits in trunk/Source/JavaScriptCore

DFG JIT does not implement op_construct.
​https://bugs.webkit.org/show_bug.cgi?id=64066

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-07
Reviewed by Gavin Barraclough.

• dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::recordConstruct):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

• dfg/DFGNode.h:
• dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor):

• dfg/DFGRepatch.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:48 PM Changeset in webkit [90601] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

DFG JIT does not implement get_by_id prototype caching.
​https://bugs.webkit.org/show_bug.cgi?id=64077

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-07
Reviewed by Gavin Barraclough.

• dfg/DFGRepatch.cpp:

(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::tryCacheGetByID):

• runtime/JSObject.h:

(JSC::JSObject::addressOfPropertyAtOffset):

4:35 PM LayoutTestResultFallbackOrder edited by dpranke@chromium.org

(diff)

4:35 PM LayoutTestResultFallbackOrder edited by dpranke@chromium.org

(diff)

4:18 PM LayoutTestsSearchPath edited by dpranke@chromium.org

(diff)

4:17 PM Changeset in webkit [90600] by leviw@chromium.org

• 37 edits in trunk/Source/WebCore

Switch remaining paint functions to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=64116

Reviewed by Eric Seidel.

Switching all functions with IntPoint paintOffsets to the new Layout types.

No new tests, no functionality changes.

• rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::paintSelection):

• rendering/EllipsisBox.h:
• rendering/InlineBox.cpp:

(WebCore::InlineBox::paint):

• rendering/InlineBox.h:
• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paint):

• rendering/InlineFlowBox.h:
• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintCustomHighlight):

• rendering/InlineTextBox.h:
• rendering/LayoutTypes.h:
• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintContents):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintCaret):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::paintSelection):

• rendering/RenderBlock.h:
• rendering/RenderBox.cpp:

(WebCore::RenderBox::paintCustomHighlight):

• rendering/RenderBox.h:
• rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):

• rendering/RenderInline.h:
• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):

• rendering/RenderLayer.h:
• rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintScrollbar):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

• rendering/RenderListBox.h:
• rendering/RenderObject.cpp:

(WebCore::RenderObject::paintFocusRing):
(WebCore::RenderObject::paintOutline):

• rendering/RenderObject.h:
• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

• rendering/RenderReplaced.h:
• rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::paintIntoRect):

• rendering/RenderScrollbarPart.h:
• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell):

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintCell):

• rendering/RenderTableSection.h:
• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::paintPlaceholder):

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paintEllipsisBox):
(WebCore::RootInlineBox::paintCustomHighlight):
(WebCore::RootInlineBox::paint):

• rendering/RootInlineBox.h:
• rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::paint):

• rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::paint):

• rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint):

• rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::paint):

4:16 PM Changeset in webkit [90599] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Work around Skia PDF's lack of inverted path support.
​https://bugs.webkit.org/show_bug.cgi?id=64032

Patch by Steve VanDeBogart <​vandebo@chromium.org> on 2011-07-07
Reviewed by James Robinson.

The trick used in ​http://neugierig.org/software/chromium/notes/2010/07/clipping.html
to support antialiased clips doesn't work when printing to Skia's PDF backend because
the backend does not support inverted paths. This manifests as rounded buttons not being
drawn when printing, tracked as Chrome bug 79519.

However, when the output is a vector device, like PDF, we don't need antialiased clips.
It's up to the PDF rendering engine to do that. So we can simply disable the antialiased
clip code if the output is a vector device.

I think the fix isn't testable because it requires examining the printed output.

• platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):

4:07 PM Changeset in webkit [90598] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

DFG JIT method_check implementation does not link to optimized get_by_id
slow path.
​https://bugs.webkit.org/show_bug.cgi?id=64073

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-07
Reviewed by Gavin Barraclough.

• dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchGetMethodFast):

3:58 PM TestExpectations edited by dpranke@chromium.org

(diff)

3:58 PM TestExpectations edited by dpranke@chromium.org

(diff)

3:55 PM TestExpectations edited by dpranke@chromium.org

(diff)

3:45 PM Changeset in webkit [90597] by jamesr@google.com

• 2 edits
  1 add in trunk/LayoutTests

[chromium] Add text baseline for spanOverlapsCanvas

• platform/chromium-gpu-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
• platform/chromium/test_expectations.txt:

3:37 PM Changeset in webkit [90596] by eae@chromium.org

• 16 edits in trunk/Source/WebCore

Switch rendering tree selection code to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=63762

Reviewed by Eric Seidel.

Switch selection getters and selection gap calculation methods over to
new layout abstraction.

No new tests, no functionality changes.

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionTop):
(WebCore::InlineTextBox::selectionBottom):
(WebCore::InlineTextBox::selectionHeight):
(WebCore::InlineTextBox::isSelected):

• rendering/InlineTextBox.h:
• rendering/RenderBR.h:

(WebCore::RenderBR::selectionRectForRepaint):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionOffset):
(WebCore::RenderBlock::logicalRightSelectionOffset):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::desiredColumnWidth):

• rendering/RenderBlock.h:

(WebCore::RenderBlock::selectionRectForRepaint):

• rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::selectionRectForRepaint):

• rendering/RenderListMarker.h:
• rendering/RenderObject.h:

(WebCore::RenderObject::selectionRect):
(WebCore::RenderObject::selectionRectForRepaint):

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::selectionRectForRepaint):

• rendering/RenderReplaced.h:
• rendering/RenderSelectionInfo.h:

(WebCore::RenderSelectionInfo::RenderSelectionInfo):

• rendering/RenderText.cpp:

(WebCore::RenderText::selectionRectForRepaint):

• rendering/RenderText.h:
• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):

• rendering/RootInlineBox.h:

(WebCore::RootInlineBox::selectionHeight):

3:29 PM Changeset in webkit [90595] by gavinp@chromium.org

• 7 edits
  2 adds in trunk

Reviewed by Alexey Proskuryakov.

fast/dom/HTMLLinkElement/link-and-subresource-test.html is flaky on chromium debug bots
​https://bugs.webkit.org/show_bug.cgi?id=60097

The culprit was that CachedResource:stopLoading() was using *this
after a call to checkNotify(), which isn't kosher. This patch
uses a CachedResourceHandle to keep the CachedResource alive.

Source/WebCore:

The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test. The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.
Test: fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::stopLoading):

LayoutTests:

The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test. The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.

• fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt: Added.
• fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html: Added.
• platform/gtk/Skipped:
• platform/mac/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:

3:20 PM Changeset in webkit [90594] by Adam Roben

• 2 edits in trunk/Tools

Update TestFailures's title and header immediately upon navigation

Fixes <​http://webkit.org/b/64125> TestFailures page seems slow to react on link clicks

Reviewed by Daniel Bates.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype.loaded): Create and store an h1 element for displaying the page's
title.
(ViewController.prototype._displayBuilder): Set the page's title and clear out any old
content immediately instead of waiting for the first set of results for the history
analyzer. As we receive new results from the analyzer we'll just clear out the main content
area and replace it with the new info.
(ViewController.prototype._displayTesters): Set the page's title and clear out any old
content immediately instead of waiting for the list of testers from the buildbot. Sprinkled
in a little use of our removeAllChildren helper, too.
(ViewController.prototype._setTitle): Added. Set's the page's title and the header text.

3:14 PM NewRunWebKitTests edited by dpranke@chromium.org

(diff)

3:12 PM NewRunWebKitTests edited by dpranke@chromium.org

(diff)

3:11 PM NewRunWebKitTests edited by dpranke@chromium.org

(diff)

3:09 PM Changeset in webkit [90593] by ojan@chromium.org

• 2 edits in trunk/LayoutTests

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-07-07
Reviewed by Stephen White.

Mark layout tests as failing in Chromium after skia roll r1799:r1814
​https://bugs.webkit.org/show_bug.cgi?id=64121

• platform/chromium/test_expectations.txt:

3:09 PM Changeset in webkit [90592] by commit-queue@webkit.org

• 2 edits
  1 add in trunk/Source/WebCore

Patch by James Robinson <​jamesr@chromium.org> on 2011-07-07
Reviewed by Kenneth Russell.

Use v8::AdjustAmountOfExternalAllocatedMemory for ArrayBuffers
​https://bugs.webkit.org/show_bug.cgi?id=42912

This calls v8's AdjustAmountOfExternalAllocatedMemory when ArrayBuffers are allocated/deallocated so that V8's
garbage collection heuristics can account for the memory held by these objects. On the new test page, this
reduces the peak memory use from 5BG+ (or a crash in 32-bit systems) to <300MB.

Test: WebCore/manual-tests/array-buffer-memory.html

• html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::~ArrayBuffer):
(WebCore::ArrayBuffer::tryAllocate):

3:05 PM TestExpectations edited by dpranke@chromium.org

(diff)

3:05 PM TestExpectations edited by dpranke@chromium.org

(diff)

3:04 PM TestExpectations edited by dpranke@chromium.org

(diff)

3:04 PM TestExpectations edited by dpranke@chromium.org

(diff)

3:00 PM NewRunWebKitTests edited by dpranke@chromium.org

(diff)

2:52 PM NewRunWebKitTests edited by dpranke@chromium.org

(diff)

2:52 PM HackingOnNewRunWebKitTests created by dpranke@chromium.org

2:50 PM LayoutTestsSearchPath created by dpranke@chromium.org

2:49 PM HackingOnNRWT created by dpranke@chromium.org

2:48 PM TestExpectations created by dpranke@chromium.org

2:47 PM NewRunWebKitTests edited by dpranke@chromium.org

(diff)

2:45 PM NewRunWebKitTests edited by dpranke@chromium.org

(diff)

2:44 PM NewRunWebKitTests created by dpranke@chromium.org

2:37 PM WikiStart edited by dpranke@chromium.org

(diff)

2:37 PM Changeset in webkit [90591] by rniwa@webkit.org

• 14 edits in trunk/Source/WebCore

Move all code related to cachedSelection to HTMLTextFormControlElement
​https://bugs.webkit.org/show_bug.cgi?id=64118

Reviewed by Alexey Proskuryakov.

Moved m_cachedSelectionStart and m_cachedSelectionEnd from HTMLInputElement
and HTMLTextAreaElement to HTMLTextFormControlElement

Also removed cached selection related functions from RenderTextControl,
RenderTextControlSingleLine, and RenderTextControlMultiLine because they were
merely providing wrapper functions to enable polymorphism between
input and textarea elements and their WML equivalents.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::notifyRendererOfSelectionChange): Calls HTMLTextFormControlElement's
selectionChanged instead of RenderTextControl's.

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): Initialize
m_cachedSelectionStart and m_cachedSelectionEnd.
(WebCore::HTMLTextFormControlElement::selectionStart):
(WebCore::HTMLTextFormControlElement::selectionEnd):
(WebCore::HTMLTextFormControlElement::selection):
(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Added.
(WebCore::HTMLTextFormControlElement::selectionChanged): Extracted from
RenderTextControl::selectionChanged.

• html/HTMLFormControlElement.h:

(WebCore::HTMLTextFormControlElement::cacheSelection): Extracted from HTMLInputElement
and HTMLTextAreaElement.
(WebCore::HTMLTextFormControlElement::hasCachedSelectionStart): Added.
(WebCore::HTMLTextFormControlElement::hasCachedSelectionEnd): Added.

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::updateFocusAppearance):

• html/HTMLInputElement.h:
• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
(WebCore::HTMLTextAreaElement::updateFocusAppearance):

• html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::isEmptyValue):

• rendering/RenderTextControl.cpp:

(WebCore::setSelectionRange):

• rendering/RenderTextControl.h:
• rendering/RenderTextControlMultiLine.cpp:
• rendering/RenderTextControlMultiLine.h:
• rendering/RenderTextControlSingleLine.cpp:
• rendering/RenderTextControlSingleLine.h:

2:16 PM Changeset in webkit [90590] by eae@chromium.org

• 19 edits in trunk/Source/WebCore

Switch addFocusRingRects to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=64114

Reviewed by Eric Seidel.

No new tests, no functionality changes.

• rendering/LayoutTypes.h:

(WebCore::flooredLayoutPoint):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addFocusRingRects):

• rendering/RenderBlock.h:
• rendering/RenderBox.cpp:

(WebCore::RenderBox::addFocusRingRects):

• rendering/RenderBox.h:
• rendering/RenderInline.cpp:

(WebCore::RenderInline::addFocusRingRects):

• rendering/RenderInline.h:
• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::addFocusRingRects):

• rendering/RenderListBox.h:
• rendering/RenderObject.h:

(WebCore::RenderObject::addFocusRingRects):

• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::addFocusRingRects):

• rendering/RenderTextControl.h:
• rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::addFocusRingRects):

• rendering/svg/RenderSVGContainer.h:
• rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::addFocusRingRects):

• rendering/svg/RenderSVGImage.h:
• rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::addFocusRingRects):

• rendering/svg/RenderSVGPath.h:

2:06 PM Changeset in webkit [90589] by enne@google.com

• 3 edits in trunk/Source/WebCore

[chromium] Reduce compositor texture memory by skipping layers and clipping surfaces
​https://bugs.webkit.org/show_bug.cgi?id=64052

Reviewed by James Robinson.

Layers and surfaces that are entirely transparent are now skipped.
Parent scissor rects are now applied to the content rect of surfaces
so that offscreen surfaces can be skipped.

Landing this for ​vangelis@chromium.org.

Covered by existing tests.

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::calculateVisibleRect):
(WebCore::calculateVisibleLayerRect):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::updateCompositorResources):
(WebCore::LayerRendererChromium::drawLayer):

• platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):

1:45 PM Changeset in webkit [90588] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r90581.
​http://trac.webkit.org/changeset/90581
​https://bugs.webkit.org/show_bug.cgi?id=64124

Broke a bunch of inspector tests (Requested by ojan on
#webkit).

• inspector/front-end/ExtensionAPI.js:

(WebInspector.injectedExtensionAPI.Panels.prototype.create):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
(WebInspector.injectedExtensionAPI.expandURL):

• inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel):

• inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._onWindowMessage):
(WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):

1:37 PM Changeset in webkit [90587] by enne@google.com

• 2 edits in trunk/Source/WebCore

[chromium] Fix crash when compositing gets disabled mid-paint
​https://bugs.webkit.org/show_bug.cgi?id=64119

Reviewed by James Robinson.

WebKit paint can disable compositing and call setRootLayer(0). Adding
a check for this in drawLayers prevents a null pointer deref.

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

1:26 PM Changeset in webkit [90586] by oliver@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Encode jump and link sizes into the appropriate enums
​https://bugs.webkit.org/show_bug.cgi?id=64123

Reviewed by Sam Weinig.

Finally kill off the out of line jump and link size arrays,
so we can avoid icky loads and constant fold the linking arithmetic.

• assembler/ARMv7Assembler.cpp:
• assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::computeJumpType):

1:17 PM Changeset in webkit [90585] by krit@webkit.org

• 2 edits
  1 add in trunk/Source/WebCore

2011-07-07 Dirk Schulze <​krit@webkit.org>

SVGAnimateTransform does not support calcMode=discrete
​https://bugs.webkit.org/show_bug.cgi?id=63914

Reviewed by Rob Buis.

CalcMode discrete specifies that the animation function will jump from one value to the next without any interpolation.
Implemented calcMode discrete by checking current progress of animation. If we are in the first half of the animation,
we use the start value of the aniamtion, end value for the second half of the animation. The key time at 50% is used on
all other animations as well as on other SVG viewers.

Added a manual test. DRT crashes on an automated test with the SVG animation API. Opened a new bug report: 64104.

• manual-tests/svg-animateTransform-calcMode-discrete.svg: Added.
• svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):

12:13 PM Changeset in webkit [90584] by Adam Roben

• 3 edits in trunk/Tools

Make Checkout use SCM's Executive instead of conjuring up its own

This will improve integration with the rest of webkitpy, particularly when invoked via
webkit-patch.

Fixes <​http://webkit.org/b/64115> REGRESSION (r90564): webkitpy's Checkout class uses
Executive inappropriately

Reviewed by Adam Barth.

• Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.commit_message_for_this_commit): Use SCM.run instead of creating an Executive for
our own use. SCM might have some super-special Executive that it uses under the covers, and
we want to use it, too!

• Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Mock the SCM.run
method to call through to Executive.run_command.

11:47 AM Changeset in webkit [90583] by Adam Roben

• 2 edits in trunk/Tools

Make Term/ReadKey.pm an optional dependency of commit-log-editor

When Term/ReadKey.pm isn't present, the --regenerate-log switch will be non-functional.

Fixes <​http://webkit.org/b/64113> REGRESSION (r90564):
webkitpy.common.checkout.checkout_unittest failing on GTK bots due to missing
Term/ReadKey.pm module

Reviewed by Xan Lopez.

• Scripts/commit-log-editor: Use Module::Load::Conditional::can_load to only load

Term/ReadKey.pm if it's present. If it isn't present, ignore the --regenerate-log switch so
that existing commit messages will be preserved. (Users can manually remove existing commit
messages using git-reset.)

11:43 AM Changeset in webkit [90582] by krit@webkit.org

• 5 edits
  3 adds in trunk

Reviewed by Rob Buis.

Source/WebCore:

SVGAnimatedPath needs fallback for 'by' animation
​https://bugs.webkit.org/show_bug.cgi?id=63865

Added fallback to 'to' animation for 'by' animated SVGAnimatedPathAnimator.

Clenup of SVGAnimateElement. Removed all switches since we support all AnimatedTypes
with the exception of AnimatedEnumeration. AnimatedEnumeration gets animated as AnimatedString at the moment.

Test: svg/animations/svgpath-animation-1.html

• svg/SVGAnimateElement.cpp:

(WebCore::getPropertyValue):
(WebCore::inheritsFromProperty):
(WebCore::attributeValueIsCurrentColor):
(WebCore::SVGAnimateElement::adjustForCurrentColor):
(WebCore::SVGAnimateElement::determineAnimatedAttributeType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore::SVGAnimateElement::calculateDistance):

• svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::calculateFromAndByValues):

LayoutTests:

SVGAnimatedPath needs fallback for 'by' animation
​https://bugs.webkit.org/show_bug.cgi?id=63865

Test fallback to 'to' animation for 'by' animated SVGPath.

• svg/animations/script-tests/svgpath-animation-1.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

• svg/animations/svgpath-animation-1-expected.txt: Added.
• svg/animations/svgpath-animation-1.html: Added.

11:38 AM Changeset in webkit [90581] by caseq@chromium.org

• 4 edits in trunk/Source/WebCore

2011-07-07 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: secure access to extensions API
​https://bugs.webkit.org/show_bug.cgi?id=64080

Reviewed by Pavel Feldman.

• inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
• inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionPanel):
• inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onSetSidebarPage): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler): (WebInspector.ExtensionServer.prototype._expandResourcePath):

11:33 AM CommitterTips edited by adele@apple.com

(diff)

11:15 AM Changeset in webkit [90580] by kov@webkit.org

• 2 edits in trunk/LayoutTests

2011-07-07 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed.

Re-skip the inspector tests, they are still timing out on the
release bot for some reason.

• platform/gtk/Skipped:

11:02 AM Changeset in webkit [90579] by Adam Roben

• 2 edits in trunk/Tools

Keep testing that commit messages containing Unicode are handled properly by webkitpy

Fixes <​http://webkit.org/b/64109> REGRESSION (r90571): test-webkitpy no longer tests that we
correctly handle Unicode in commit messages

Reviewed by Eric Seidel.

• Scripts/webkitpy/common/checkout/checkout_unittest.py: Put some Unicode characters in

places in the ChangeLog that will end up being included in the commit message.

10:45 AM Changeset in webkit [90578] by andreas.kling@nokia.com

• 15 edits
  1 delete in trunk

[Qt][WK2] Remove Symbian code.
​https://bugs.webkit.org/show_bug.cgi?id=64101

Reviewed by Benjamin Poulain.

Source/WebKit2:

• DerivedSources.pro:
• Platform/CoreIPC/Attachment.h:
• Platform/CoreIPC/Connection.h:
• Platform/SharedMemory.h:
• Platform/qt/SharedMemorySymbian.cpp: Removed.
• UIProcess/API/qt/tests/tests.pri:
• UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
• WebKit2.pri:
• WebKit2.pro:
• WebProcess.pro:
• config.h:

Tools:

• MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::screenshot):

• MiniBrowser/qt/MiniBrowser.pro:
• MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):

10:43 AM Changeset in webkit [90577] by andreas.kling@nokia.com

• 13 edits in trunk

[Qt][WK2] Don't support ridiculous matrix of QT_NO_FEATURE combinations.
​https://bugs.webkit.org/show_bug.cgi?id=64099

Reviewed by Benjamin Poulain.

Source/WebKit2:

• Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

• UIProcess/API/qt/qdesktopwebview_p.h:
• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::setCursor):
(QtWebPageProxy::registerEditCommand):
(QtWebPageProxy::clearAllEditCommands):
(QtWebPageProxy::canUndoRedo):
(QtWebPageProxy::executeUndoRedo):
(QtWebPageProxy::updateAction):
(QtWebPageProxy::webActionTriggered):
(QtWebPageProxy::triggerAction):
(QtWebPageProxy::action):

• UIProcess/qt/QtWebPageProxy.h:
• UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::didChangeCursor):

• UIProcess/qt/TouchViewInterface.h:
• UIProcess/qt/ViewInterface.h:
• UIProcess/qt/WebUndoCommandQt.cpp:

(WebUndoCommandQt::WebUndoCommandQt):

• UIProcess/qt/WebUndoCommandQt.h:
• WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:

(WebKit::WebDragClient::startDrag):

Tools:

• MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::openFile):
(BrowserWindow::screenshot):
(BrowserWindow::loadURLListFromFile):

10:39 AM Changeset in webkit [90576] by Adam Roben

• 2 edits in trunk/LayoutTests

Skip another test that uses beginDragWithFiles on Windows

• platform/win/Skipped: Added fast/forms/file-input-change-event.html.

10:33 AM Changeset in webkit [90575] by mitz@apple.com

• 1 edit in trunk/Source/WebCore/ChangeLog

Updated change log

10:29 AM Changeset in webkit [90574] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

The return value of SharedBuffer::createWithContentsOfFile must have valid m_size.
​https://bugs.webkit.org/show_bug.cgi?id=63313

Patch by Kyusun Kim <​maniagoon@company100.net> on 2011-07-07
Reviewed by Eric Seidel.

• platform/posix/SharedBufferPOSIX.cpp:

(WebCore::SharedBuffer::createWithContentsOfFile):

10:27 AM Changeset in webkit [90573] by mitz@apple.com

• 5 edits in trunk

<rdar://problem/9737435> Re-enable -webkit-column-break-inside: avoid
​https://bugs.webkit.org/show_bug.cgi?id=64102

Reviewed by Simon Fraser.

Source/WebCore:

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild): Treat the child as unsplittable if
'-webkit-column-break-inside: avoid' was specified.

LayoutTests:

• fast/multicol/break-properties-expected.txt:
• fast/multicol/break-properties.html:

10:27 AM Changeset in webkit [90572] by andreas.kling@nokia.com

• 8 edits in trunk/Source/WebKit2

[Qt][WK2] Views should know about WebProcess crash/relaunch.
​https://bugs.webkit.org/show_bug.cgi?id=64093

Reviewed by Benjamin Poulain.

Add processDidCrash() and didRelaunchProcess() to ViewInterface.

QDesktopWebView now displays a simple sad smiley ":(" when the
web process crashes.

• UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(paintCrashedPage):
(QDesktopWebView::paint):
(QDesktopWebViewPrivate::processDidCrash):
(QDesktopWebViewPrivate::didRelaunchProcess):

• UIProcess/API/qt/qdesktopwebview_p.h:
• UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):

• UIProcess/qt/QtWebPageProxy.h:
• UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::showContextMenu):
(WebKit::TouchViewInterface::hideContextMenu):
(WebKit::TouchViewInterface::processDidCrash):
(WebKit::TouchViewInterface::didRelaunchProcess):

• UIProcess/qt/TouchViewInterface.h:
• UIProcess/qt/ViewInterface.h:

10:18 AM Changeset in webkit [90571] by Adam Roben

• 2 edits in trunk/Tools

Completely ignore too-many-failures builds in TestFailures in most circumstances

Because a semi-arbitrary subset of tests are run in a too-many-failures build, we can't
really use them to perform regression analysis. The only time we want to pay attention to
too-many-failures builds is when we're trying to explain when the current bout of
too-many-failures started.

Fixes <​http://webkit.org/b/64106> TestFailures page sometimes claims a test started failing
in a build that didn't even run it (because it exited early due to too many failues)

Reviewed by David Kilzer.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Removed old, broken
too-many-failures handling that would cause us to blame builds that didn't even run a given
test for breaking it. Instead, skip over all too-many-failures builds unless the most recent
build was itself a too-many-failures build.

10:17 AM Changeset in webkit [90570] by abecsi@webkit.org

• 2 edits in trunk/LayoutTests

[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
​https://bugs.webkit.org/show_bug.cgi?id=63255

Unreviewed gardening.

• platform/qt/Skipped: Skip tests.

10:15 AM Changeset in webkit [90569] by caseq@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: visual regressions in network panel
​https://bugs.webkit.org/show_bug.cgi?id=64089

Reviewed by Pavel Feldman.

• inspector/front-end/networkPanel.css:

(.data-grid.network-log-grid tr.filler td):
(.network.panel .sidebar):

10:05 AM Changeset in webkit [90568] by jchaffraix@webkit.org

• 3 edits
  6 adds in trunk

Patch by Julien Chaffraix <​jchaffraix@webkit.org> on 2011-07-07
Reviewed by David Hyatt.

Partial layout when a flex-box has visibility: collapse
​https://bugs.webkit.org/show_bug.cgi?id=63776

Source/WebCore:

Tests: fast/flexbox/crash-button-input-autofocus.html

fast/flexbox/crash-button-keygen.html
fast/flexbox/crash-button-relayout.html

The issue is that FlexBoxIterator would skip any child if it has visibility: collapsed.
However if one of the child is anonymous, it may wrap some other child that would be skipped.
Now FlexBoxIterator is called during the layout phase and thus some nodes would not relayouted
as expected.

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next): When iterating, don't skip anonymous content as there may
be real content hiding below.

LayoutTests:

Those tests checks some variation of the same underlying issue.

• fast/flexbox/crash-button-input-autofocus-expected.txt: Added.
• fast/flexbox/crash-button-input-autofocus.html: Added.
• fast/flexbox/crash-button-keygen-expected.txt: Added.
• fast/flexbox/crash-button-keygen.html: Added.
• fast/flexbox/crash-button-relayout-expected.txt: Added.
• fast/flexbox/crash-button-relayout.html: Added.

9:53 AM Changeset in webkit [90567] by vsevik@chromium.org

• 5 edits in trunk

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: URL links in styles open new tab instead of showing resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=64090

Reviewed by Pavel Feldman.

• inspector/styles/styles-url-linkify-expected.txt:
• inspector/styles/styles-url-linkify.html:

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: URL links in styles open new tab instead of showing resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=64090

Reviewed by Pavel Feldman.

• inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):

9:52 AM Changeset in webkit [90566] by abecsi@webkit.org

• 2 edits in trunk/LayoutTests

REGRESSION(90557) http/tests/inspector/network/network-embed.html fails
​https://bugs.webkit.org/show_bug.cgi?id=64103

Unreviewed gardening.

• platform/qt/Skipped: Skip test.

9:48 AM Changeset in webkit [90565] by caseq@chromium.org

• 2 edits in trunk/Source/WebCore

2011-07-07 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: active panel does not receive resize event when drawer is resized
​https://bugs.webkit.org/show_bug.cgi?id=64094

Reviewed by Pavel Feldman.

• inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype._statusBarDragging):

9:36 AM Changeset in webkit [90564] by Adam Roben

• 3 edits in trunk/Tools

Teach webkitpy's Checkout class to use commit-log-editor to create commit messages

Fixes <​http://webkit.org/b/26755> webkit-patch's commit messages are less readable than
commit-log-editor's

Reviewed by David Kilzer.

• Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.commit_message_for_this_commit): Run commit-log-editor, passing it the paths of
the modified ChangeLogs, to generate the commit message, rather than trying to generate one
ourselves.

• Scripts/webkitpy/common/checkout/checkout_unittest.py: Updated the expected commit message

to match commit-log-editor's format.
(CommitMessageForThisCommitTest.setUp): Write the ChangeLogs into Tools and LayoutTests
directories so we can see how the various entries get labeled in the commit message.
(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Create a mock SCM
instance that knows how to find commit-log-editor and pass it to our Checkout instance.
Don't bother capturing output, since there shouldn't be any.

9:36 AM Changeset in webkit [90563] by Adam Roben

• 2 edits in trunk/Tools

Add a --print-log option to commit-log-editor

When specified, commit-log-editor takes a set of ChangeLog paths on the command line,
generates a commit message from those ChangeLogs, prints it to stdout, and exits.

Prep work for fixing <​http://webkit.org/b/26755> webkit-patch's commit messages are less
readable than commit-log-editor's

Reviewed by David Kilzer.

• Scripts/commit-log-editor: Changed to use Getopt::Long to parse options. Added --print-log

option, which calls through to createCommitMessage, prints the result, and exits.
(printUsageAndExit): Renamed from "usage" for clarity. Beefed up the usage statement to
explain commit-log-editor's 2.5 (normal, --print-log, and --help) modes of operation.

9:35 AM Changeset in webkit [90562] by Adam Roben

• 2 edits in trunk/Tools

Extract commit-log-editor's commit-message-generation code into a separate function

As a bonus, we now skip a bunch of work in the case where we are generating a commit message
for staged git changes.

Prep work for fixing <​http://webkit.org/b/26755> webkit-patch's commit messages are less
readable than commit-log-editor's

Reviewed by David Kilzer.

• Scripts/commit-log-editor: Moved the default definition of $endl up toward the top of the

file so that it will be defined even if we aren't operating on an existing log message.
Moved a bunch of top-level code to generate the commit message from here...
(createCommitMessage): ...to here.

9:20 AM Changeset in webkit [90561] by pfeldman@chromium.org

• 3 edits in trunk/Source/WebCore

2011-07-07 Pavel Feldman <​pfeldman@chromium.org>

Web Inspector: prevent default action during drag'n'drop in the Elements panel.
​https://bugs.webkit.org/show_bug.cgi?id=64081

Reviewed by Yury Semikhatsky.

• inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype._ondragstart): (WebInspector.ElementsTreeOutline.prototype._ondragover): (WebInspector.ElementsTreeOutline.prototype._ondragend):
• inspector/front-end/treeoutline.js: (TreeOutline.prototype.treeElementFromPoint):

7:18 AM Changeset in webkit [90560] by Nikolas Zimmermann

• 26 edits in trunk/Source/WebCore

2011-07-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Move remaining enums out of SVG*Element classes
​https://bugs.webkit.org/show_bug.cgi?id=64075

Reviewed by Dirk Schulze.

Move remaining enums out of SVG*Element classes. This is a preparation patch for bug 63797.
Also move the SVGPropertyTraits template specializations for enum types before the class
definition in the header, otherwhise we can't use SVGPropertyTraits<FooType>::fromString/toString
in the DECLARE_ANIMATED* macros, which is needed soon.

No new tests, just refactoring.

• rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource):
• rendering/svg/RenderSVGResourceGradient.h:
• rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::angle): (WebCore::RenderSVGResourceMarker::markerTransformation):
• rendering/svg/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::markerUnits):
• rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::RenderSVGTextPath): (WebCore::RenderSVGTextPath::exactAlignment): (WebCore::RenderSVGTextPath::stretchMethod):
• rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeCommonGradientProperties):
• rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk):
• rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
• svg/GradientAttributes.h: (WebCore::GradientAttributes::GradientAttributes): (WebCore::GradientAttributes::spreadMethod): (WebCore::GradientAttributes::setSpreadMethod):
• svg/SVGComponentTransferFunctionElement.h:
• svg/SVGFEBlendElement.h:
• svg/SVGFEColorMatrixElement.h:
• svg/SVGFECompositeElement.h:
• svg/SVGFEConvolveMatrixElement.h:
• svg/SVGFEDisplacementMapElement.h:
• svg/SVGFEMorphologyElement.h:
• svg/SVGFETurbulenceElement.h:
• svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement):
• svg/SVGGradientElement.h:
• svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle): (WebCore::SVGMarkerElement::synchronizeOrientType): (WebCore::SVGMarkerElement::orientTypeAnimated):
• svg/SVGMarkerElement.h:
• svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::SVGTextContentElement):
• svg/SVGTextContentElement.h:
• svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::SVGTextPathElement):
• svg/SVGTextPathElement.h:

6:47 AM Changeset in webkit [90559] by xan@webkit.org

• 2 edits in trunk/LayoutTests

2011-07-07 Xan Lopez <​xlopez@igalia.com>

Unreviewed.

Enable inspector tests again (they should work now), and skip test
that is timing out in all GTK+ bots.

• platform/gtk/Skipped:

6:44 AM Changeset in webkit [90558] by loislo@chromium.org

• 3 edits in trunk/Source/WebCore

2011-07-07 Ilya Tikhonovsky <​loislo@chromium.org>

Web Inspector: Protocol: pointers to optional "in" parameters passing to the
backend methods should be NULL if they are not specified in the message.
​https://bugs.webkit.org/show_bug.cgi?id=64083

Reviewed by Pavel Feldman.

• inspector/CodeGeneratorInspector.pm: (generateBackendFunction): (generateArgumentGetters):
• inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode):

6:12 AM Changeset in webkit [90557] by vsevik@chromium.org

• 12 edits in trunk/LayoutTests

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Move resetting NetworkResourcesData out of tests unrelated to replacement testing.
​https://bugs.webkit.org/show_bug.cgi?id=64078

Reviewed by Pavel Feldman.

• http/tests/inspector/network-test.js: (initialize_NetworkTest.InspectorTest.resetInspectorResourcesData.nextStep): (initialize_NetworkTest.InspectorTest.resetInspectorResourcesData): (resetInspectorResourcesData):
• http/tests/inspector/network/network-clear-cache-expected.txt:
• http/tests/inspector/network/network-clear-cache.html-disabled:
• http/tests/inspector/network/network-clear-cookies-expected.txt:
• http/tests/inspector/network/network-clear-cookies.html-disabled:
• http/tests/inspector/network/network-embed-expected.txt:
• http/tests/inspector/network/network-embed.html:
• http/tests/inspector/network/network-xhr-async-expected.txt:
• http/tests/inspector/network/network-xhr-async.html:
• http/tests/inspector/network/network-xhr-sync-expected.txt:
• http/tests/inspector/network/network-xhr-sync.html:

5:06 AM Changeset in webkit [90556] by loislo@chromium.org

• 3 edits in trunk/Source/WebCore

2011-07-07 Ilya Tikhonovsky <​loislo@chromium.org>

Web Inspector: Searching on the Network panel doesn't do anything?
​https://bugs.webkit.org/show_bug.cgi?id=55489

This is initial implementation of search in Network panel.
It is pretty simple search only for names and paths.

Reviewed by Pavel Feldman.

• inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refresh): (WebInspector.NetworkPanel.prototype._reset): (WebInspector.NetworkPanel.prototype._updateOffscreenRows): (WebInspector.NetworkPanel.prototype._matchResource): (WebInspector.NetworkPanel.prototype._clearSearchMatchedList): (WebInspector.NetworkPanel.prototype._highlightNthMatchedResource): (WebInspector.NetworkPanel.prototype.performSearch): (WebInspector.NetworkDataGridNode.prototype.createCells):
• inspector/front-end/utilities.js: (String.prototype.escapeHTML): ():

4:33 AM Changeset in webkit [90555] by vsevik@chromium.org

• 4 edits
  4 adds in trunk

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
​https://bugs.webkit.org/show_bug.cgi?id=63936

Reviewed by Pavel Feldman.

• http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt: Added.
• http/tests/inspector/resource-tree/resource-tree-non-unique-url.html: Added.
• http/tests/inspector/resource-tree/resource-tree-test.js: (initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
• http/tests/inspector/resource-tree/resources/resource-tree-non-unique-url-iframe.html: Added.
• http/tests/inspector/resource-tree/resources/styles-non-unique-url.css: Added. (body):

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
​https://bugs.webkit.org/show_bug.cgi?id=63936

Reviewed by Pavel Feldman.

Test: http/tests/inspector/resource-tree/resource-tree-non-unique-url.html

• inspector/front-end/ResourcesPanel.js: (WebInspector.FrameTreeElement.prototype.appendResource):

4:18 AM Changeset in webkit [90554] by Philippe Normand

• 4 edits in trunk/LayoutTests

Reviewed by Eric Carlson.

GTK: media/video-src-invalid-poster.html Failed
​https://bugs.webkit.org/show_bug.cgi?id=61160

Wait for loadstart event to check the poster dimensions and avoid a
potential timeout of the test.

• media/video-src-invalid-poster-expected.txt:
• media/video-src-invalid-poster.html:
• platform/gtk/Skipped:

3:47 AM Changeset in webkit [90553] by vsevik@chromium.org

• 16 edits
  6 adds in trunk

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Add support for clearing cache and cookies from network panel.
​https://bugs.webkit.org/show_bug.cgi?id=63999

Added clear cache and cookies tests. Since no port currently supports
this functionality, the tests are disabled.

Reviewed by Pavel Feldman.

• http/tests/inspector/network/network-clear-cache-expected.txt: Added.
• http/tests/inspector/network/network-clear-cache.html-disabled: Added.
• http/tests/inspector/network/network-clear-cookies-expected.txt: Added.
• http/tests/inspector/network/network-clear-cookies.html-disabled: Added.
• http/tests/inspector/network/resources/random-cached.php: Added.
• http/tests/inspector/network/resources/set-cookie.php: Added.

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Add support for clearing cache and cookies from network panel.
​https://bugs.webkit.org/show_bug.cgi?id=63999

Reviewed by Pavel Feldman.

• English.lproj/localizedStrings.js:
• inspector/Inspector.json:
• inspector/InspectorClient.h: (WebCore::InspectorClient::clearBrowserCache): (WebCore::InspectorClient::clearBrowserCookies):
• inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
• inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::clearBrowserCache): (WebCore::InspectorResourceAgent::clearBrowserCookies): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
• inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
• inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu): (WebInspector.NetworkPanel.prototype._clearBrowserCache): (WebInspector.NetworkPanel.prototype._clearBrowserCookies):
• inspector/front-end/Settings.js:

2011-07-07 Vsevolod Vlasov <​vsevik@chromium.org>

Web Inspector: Add support for clearing cache and cookies from network panel.
​https://bugs.webkit.org/show_bug.cgi?id=63999

Reviewed by Pavel Feldman.

• public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::clearBrowserCache): (WebKit::WebDevToolsAgentClient::clearBrowserCookies):
• src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::clearBrowserCache): (WebKit::InspectorClientImpl::clearBrowserCookies):
• src/InspectorClientImpl.h:
• src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::clearBrowserCache): (WebKit::WebDevToolsAgentImpl::clearBrowserCookies):
• src/WebDevToolsAgentImpl.h:

3:37 AM Changeset in webkit [90552] by commit-queue@webkit.org

• 5 edits in trunk

2011-07-07 Shinya Kawanaka <​shinyak@google.com>

Added more key bindings for input[type=range].
​https://bugs.webkit.org/show_bug.cgi?id=52262

Added PageUp/PageDown/Home/End key bindings tests for input[type=range].

Reviewed by Kent Tamura.

• fast/forms/range-keyoperation-expected.txt: Regenerated.
• fast/forms/range-keyoperation.html: Added more key bindings tests.

2011-07-07 Shinya Kawanaka <​shinyak@google.com>

Added more key bindings for input[type=range].
​https://bugs.webkit.org/show_bug.cgi?id=52262

Added PageUp/PageDown/Home/End key bindings for input[type=range].
PageUp/PageDown change value by about 10%.
Home/End change value to minimum/maximum.

Reviewed by Kent Tamura.

• html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): Added key bindings.

3:29 AM Changeset in webkit [90551] by Carlos Garcia Campos

• 2 edits in trunk/Tools

2011-07-07 Carlos Garcia Campos <​cgarcia@igalia.com>

[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=63988

Reviewed by Martin Robinson.

• MiniBrowser/gtk/BrowserWindow.c: (browserWindowConstructed): (decidePolicyForNavigationAction): Ignore the action if a link is clicked with the middle buttonm and open the link in a new window. (browserWindowPolicyClientInit):

2:06 AM Changeset in webkit [90550] by commit-queue@webkit.org

• 11 edits
  2 copies in trunk/Source/WebKit2

2011-07-07 Benjamin Poulain <​benjamin@webkit.org>

[Qt] [WK2] Improve the handling of touch events to use them as main input
​https://bugs.webkit.org/show_bug.cgi?id=63991

Reviewed by Kenneth Rohde Christiansen.

Promote touch event for use as primary input.

The touch events now use the responsiveness timer like the other input events.

The touch events also have a callback to the UI signaling if the event was used
or not: PageClient::doneWithTouchEvent().
This is similar to what is done with key events (PageClient::doneWithKeyEvent()).

• Shared/NativeWebTouchEvent.h: Copied from Source/WebKit2/Shared/qt/WebEventFactoryQt.h. (WebKit::NativeWebTouchEvent::nativeEvent):
• Shared/qt/NativeWebTouchEventQt.cpp: Copied from Source/WebKit2/Shared/qt/WebEventFactoryQt.h. (WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
• Shared/qt/WebEventFactoryQt.cpp: (WebKit::webEventTypeForEvent): (WebKit::WebEventFactory::createWebTouchEvent):
• Shared/qt/WebEventFactoryQt.h:
• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleTouchEvent): (WebKit::WebPageProxy::didReceiveEvent):
• UIProcess/WebPageProxy.h:
• UIProcess/qt/qdesktopwebpageproxy.cpp: (QDesktopWebPageProxy::doneWithTouchEvent):
• UIProcess/qt/qdesktopwebpageproxy.h:
• UIProcess/qt/qtouchwebpageproxy.cpp: (QTouchWebPageProxy::doneWithTouchEvent): (QTouchWebPageProxy::touchEvent):
• UIProcess/qt/qtouchwebpageproxy.h:
• WebKit2.pro:

1:03 AM Changeset in webkit [90549] by abarth@webkit.org

• 8 edits
  1 delete in trunk/Tools

2011-07-07 Adam Barth <​abarth@webkit.org>

Remove style_references.py
​https://bugs.webkit.org/show_bug.cgi?id=64070

Reviewed by Eric Seidel.

We never really adopted the _references design, and this file is a bit
of an orphan at this point.

• Scripts/check-webkit-style:
• Scripts/webkitpy/style/checker.py:
• Scripts/webkitpy/style/checker_unittest.py:
• Scripts/webkitpy/style/checkers/python.py:
• Scripts/webkitpy/style/checkers/test_expectations.py:
• Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
• Scripts/webkitpy/style/main_unittest.py:
• Scripts/webkitpy/style_references.py: Removed.

12:44 AM Changeset in webkit [90548] by eric@webkit.org

• 2 edits
  1 add in trunk/Tools

2011-07-07 Eric Seidel <​eric@webkit.org>

Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=64056

Unreviewed.

I had written this unittest prior to landing my change, but
had named it qt_unitest.py, so it wasn't running (nor was
it added to my git repo).

Once I fixe the name of the unittest file, it was very easy
to fix the error in webkit.py (which already had a FIXME).

• Scripts/webkitpy/layout_tests/port/qt_unittest.py: Added.
• Scripts/webkitpy/layout_tests/port/webkit.py:

12:26 AM Changeset in webkit [90547] by eric@webkit.org

• 3 edits in trunk/Tools

2011-07-07 Eric Seidel <​eric@webkit.org>

Unreviewed. Add more debug logging about which test expectations we're using.

• Scripts/webkitpy/layout_tests/models/test_expectations.py:
• Scripts/webkitpy/layout_tests/port/webkit.py:

12:25 AM Changeset in webkit [90546] by abarth@webkit.org

• 8 edits in trunk/Tools

2011-07-06 Adam Barth <​abarth@webkit.org>

Remove unexpected_results.json
​https://bugs.webkit.org/show_bug.cgi?id=64065

Reviewed by Eric Seidel.

No one should be using this file any more. This patch removes it from
the face of the earth. This patch also removes two NRWT-specific
command line options that were implemented using
unexpected_results.json.

• Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
• Scripts/webkitpy/layout_tests/controllers/manager.py:
• Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
• Scripts/webkitpy/tool/commands/rebaselineserver.py:
• Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:

12:16 AM Changeset in webkit [90545] by abarth@webkit.org

• 3 edits in trunk/Tools

2011-07-07 Adam Barth <​abarth@webkit.org>

REGRESSION(90520): chromium GPU tests produce output in the LayoutTests directory
​https://bugs.webkit.org/show_bug.cgi?id=64067

Reviewed by Eric Seidel.

The author of r90520 forgot to change the chromium_gpu.py implemenation
of this method as well.

• Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

12:07 AM Changeset in webkit [90544] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

2011-07-07 Oleg Romashin <​romaxa@gmail.com>

Fix InspectorInstrumentation compilation.
​https://bugs.webkit.org/show_bug.cgi?id=64033

Reviewed by Yury Semikhatsky.

No new tests. just compile fix.

• inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):