Timeline
Sep 13, 2011:
- 11:58 PM Changeset in webkit [95078] by
-
- 2 edits in trunk/Tools
committers.py is missing some contributors
https://bugs.webkit.org/show_bug.cgi?id=68059
Reviewed by Adam Barth.
Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
- Scripts/webkitpy/common/config/committers.py:
- 11:46 PM Changeset in webkit [95077] by
-
- 4 edits3 deletes in trunk
Unreviewed, rolling out r95058.
http://trac.webkit.org/changeset/95058
https://bugs.webkit.org/show_bug.cgi?id=68058
It made css3/calc/regression-62276.html crash (Requested by
Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-13
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::allowBreak):
(WebCore::BorderImageParseContext::allowWidth):
(WebCore::BorderImageParseContext::allowOutset):
(WebCore::BorderImageParseContext::allowRepeat):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):
- css/CSSParserValues.h:
LayoutTests:
- fast/borders/border-image-scrambled.html: Removed.
- platform/mac/fast/borders/border-image-scrambled-expected.png: Removed.
- platform/mac/fast/borders/border-image-scrambled-expected.txt: Removed.
- 11:32 PM Changeset in webkit [95076] by
-
- 2 edits in trunk/Tools
Fix webkit python test after r95061.
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- 9:37 PM Changeset in webkit [95075] by
-
- 2 edits in trunk/Tools
Add wangxianzhu@chromium.org as a contributor.
- 9:19 PM Changeset in webkit [95074] by
-
- 3 edits2 adds in trunk
Crash in RenderScrollbarPart::imageChanged.
https://bugs.webkit.org/show_bug.cgi?id=68009
Reviewed by Simon Fraser.
Source/WebCore:
When a custom scrollbar is removed from its FrameView, its destruction
can be delayed because of RefPtr maintained in EventHandler class
(m_lastScrollbarUnderMouse). Upon removal, we delete all the scrollbar
parts so that they don't link back to scrollbar. However, because of the
delay, we can have a call to updateScrollbarPart which recreates it.
When scrollbar is getting destroyed, we just check to see if there are
remaining scrollbar parts and if yes, we destroy them.
Test: scrollbars/scrollbar-part-created-with-no-parent-crash.html
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::~RenderScrollbar):
LayoutTests:
- scrollbars/scrollbar-part-created-with-no-parent-crash-expected.txt: Added.
- scrollbars/scrollbar-part-created-with-no-parent-crash.html: Added.
- 8:36 PM Changeset in webkit [95073] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium test expectations.
- platform/chromium/test_expectations.txt: failures on GPU starting from r95058
- 7:45 PM Changeset in webkit [95072] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium test expectations.
- platform/chromium/test_expectations.txt: failures starting from r95058
- 7:09 PM Changeset in webkit [95071] by
-
- 3 edits2 adds in trunk
Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized read
https://bugs.webkit.org/show_bug.cgi?id=68021
Reviewed by Tony Chang.
Source/WebCore:
Reported by valgrind in http://crbug.com/60653.
Besides fixing the uninitialized read, add support for outputting the
list separator for counters() calls and the list-style name.
Test: fast/css/counters/counter-cssText.html
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText):
LayoutTests:
- fast/css/counters/counter-cssText-expected.txt: Added.
- fast/css/counters/counter-cssText.html: Added.
- 6:58 PM Changeset in webkit [95070] by
-
- 3 edits3 adds in trunk
WebFont followed tiny monospace text displays weird
https://bugs.webkit.org/show_bug.cgi?id=67996
Reviewed by Darin Adler.
Source/WebCore:
Always call wkSetCGFontRenderingMode() in Font::drawGlyphs() so that the rendering mode is set correctly.
Test: platform/mac/fast/text/webfont-after-tiny-monospace-text.html
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
LayoutTests:
This test ensures that webfont followed tiny monospace text is displayed correctly.
- platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.png: Added.
- platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.txt: Added.
- platform/mac/fast/text/webfont-after-tiny-monospace-text.html: Added.
- 6:24 PM Changeset in webkit [95069] by
-
- 6 edits in trunk/Tools
garden-o-matic has unfriendly error messages when the local server is not available
https://bugs.webkit.org/show_bug.cgi?id=68042
Reviewed by Dimitri Glazkov.
This patch moves us from using alert to showing the error inline in the
progress dialog.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- 6:23 PM Changeset in webkit [95068] by
-
- 5 edits in trunk/Tools
FailureGrid in garden-o-matic should link to the builder's waterfall page
https://bugs.webkit.org/show_bug.cgi?id=68036
Reviewed by Dimitri Glazkov.
One of the users in the user study thought the configurations names in
the failure grid would link to the underlying bots. That makes sense,
so this patch adds the behavior.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
- 6:21 PM Changeset in webkit [95067] by
-
- 6 edits in trunk/Tools
garden-o-matic should be able to mark failures as expected
https://bugs.webkit.org/show_bug.cgi?id=68027
Reviewed by Dimitri Glazkov.
All the back-end infrastructure exists for this operation. This patch
just adds some UI to the front-end and wires that UI up to the back
end. This exact UI will likely need some more polish, but this should
be a reasonable first cut.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- 6:20 PM Changeset in webkit [95066] by
-
- 7 edits in trunk/Tools
garden-o-matic should tell you about the progress of your rebaseline
https://bugs.webkit.org/show_bug.cgi?id=67967
Reviewed by Dimitri Glazkov.
This patch adds ui.MessageBox, which is a light wrapper around jQuery
UI's dialog widget. We then use ui.MessageBox to show status messages
about in-progress rebaselines. As each baseline is downloaded, the
MessageBox updates. This UI replaces our temporary "alert"-based UI.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
- 6:19 PM Changeset in webkit [95065] by
-
- 7 edits6 adds in trunk
Fix XSS auditor bypass when inline handlers contain comments.
https://bugs.webkit.org/show_bug.cgi?id=27895
Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-13
Reviewed by Adam Barth.
Source/WebCore:
Tests: http/tests/security/xssAuditor/property-escape-comment.html
http/tests/security/xssAuditor/property-escape-entity.html
http/tests/security/xssAuditor/property-escape-quote.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::snippetForAttribute):
LayoutTests:
- http/tests/security/xssAuditor/malformed-HTML-expected.txt:
- http/tests/security/xssAuditor/open-attribute-body-expected.txt:
- http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-comment.html: Added.
- http/tests/security/xssAuditor/property-escape-entity-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-entity.html: Added.
- http/tests/security/xssAuditor/property-escape-quote-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-quote.html: Added.
- http/tests/security/xssAuditor/resources/echo-property.pl:
- 6:13 PM Changeset in webkit [95064] by
-
- 2 edits1 add in trunk/LayoutTests
Update chromium-mac test expectations
https://bugs.webkit.org/show_bug.cgi?id=67917
Reviewed by Darin Adler.
- platform/chromium-cg-mac-leopard/svg/custom/simple-text-double-shadow-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 6:05 PM Changeset in webkit [95063] by
-
- 5 edits in trunk
Implement a HashChangeEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67969
Reviewed by Nate Chapin.
Source/WebCore:
Test: fast/events/constructors/hash-change-event-constructor.html
- bindings/v8/custom/V8EventConstructors.cpp: Added the HashChangeEvent constructor.
- dom/HashChangeEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled hash-change-event-constructor.html, since now V8 has a HashChangeEvent constructor.
- platform/chromium/test_expectations.txt:
- 6:03 PM Changeset in webkit [95062] by
-
- 2 edits in trunk/Tools
GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
https://bugs.webkit.org/show_bug.cgi?id=68024
Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-13
Reviewed by Gustavo Noronha Silva.
Using g_list_count() and g_list_nth_data() together on a loop is
inneficient since they're both O(n). Iterate over lists in a saner
way.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(dumpHistoryItem): Reduce the scope for the 'kids' variable, and
iterate on it using g_list_next(). Free the list after done with it.
(dumpBackForwardListForWebView): Instead of appending (which is
expensive in GLists) history items and then iterating from the tail
of the itemsToPrint list, prepend items and walk forwards as usual.
(dumpBackForwardListForAllWebViews): Walk the list in a saner way,
remove the (unneeded) viewList variable.
- 6:00 PM Changeset in webkit [95061] by
-
- 2 edits in trunk/Tools
Add Eric's IRC nick.
- Scripts/webkitpy/common/config/committers.py:
- 5:37 PM Changeset in webkit [95060] by
-
- 12 edits in trunk/Source/JavaScriptCore
SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should
return false if either node can be double
https://bugs.webkit.org/show_bug.cgi?id=67985
Reviewed by Geoffrey Garen.
This is a 17% speed-up on 3d-cube.
This required allowing us to check if a constant is double but not
integer, and making the shouldSpeculateInteger() check test for
any hints of doubly-ness in its operands. This also required
changing some terminology: previously "isDouble" often meant
"isDouble or isInt32". Now "isDouble" means exactly what the name
suggests, and "isNumber" means "isDouble or isInt32".
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGenerationInfo.h:
(JSC::DFG::isJSFormat):
(JSC::DFG::isJSInteger):
(JSC::DFG::isJSDouble):
(JSC::DFG::isJSCell):
(JSC::DFG::isJSBoolean):
(JSC::DFG::GenerationInfo::isJSFormat):
(JSC::DFG::GenerationInfo::isJSInteger):
(JSC::DFG::GenerationInfo::isJSDouble):
(JSC::DFG::GenerationInfo::isJSCell):
(JSC::DFG::GenerationInfo::isJSBoolean):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::isNumberConstant):
(JSC::DFG::Graph::valueOfNumberConstant):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::isNumberConstant):
(JSC::DFG::JITCodeGenerator::valueOfNumberConstant):
(JSC::DFG::JITCodeGenerator::initConstantInfo):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillToJS):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isNumberConstant):
(JSC::DFG::JITCompiler::valueOfNumberConstant):
- dfg/DFGNode.h:
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::valueOfNumberConstant):
(JSC::DFG::Node::hasNumberResult):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):
(JSC::DFG::SpeculativeJIT::shouldNotSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
- 5:29 PM Changeset in webkit [95059] by
-
- 3 edits2 adds in trunk
Source/WebCore: Fix crash when an iframe element is removed during a transition to
fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=67960
Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-13
Reviewed by Adam Barth.
Test: fullscreen/full-screen-remove-ancestor-during-transition.html
- dom/Document.cpp:
(WebCore::Document::~Document):
Clear the list of elements to which we need to send a fullscreenchange
event.
LayoutTests: Removing an iframe from the document during a transition to fullscreen
should not crash.
https://bugs.webkit.org/show_bug.cgi?id=67960
Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-13
Reviewed by Adam Barth.
- fullscreen/full-screen-remove-ancestor-during-transition-expected.txt: Added.
- fullscreen/full-screen-remove-ancestor-during-transition.html: Added.
- 5:17 PM Changeset in webkit [95058] by
-
- 4 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=68040
Make sure border image sub-properties can be specified in any order.
Reviewed by Beth Dakin.
Source/WebCore:
New tests in fast/borders.
- css/CSSParser.cpp:
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::canAdvance):
(WebCore::BorderImageParseContext::setCanAdvance):
(WebCore::BorderImageParseContext::allowCommit):
(WebCore::BorderImageParseContext::allowImage):
(WebCore::BorderImageParseContext::allowImageSlice):
(WebCore::BorderImageParseContext::allowSlash):
(WebCore::BorderImageParseContext::requireWidth):
(WebCore::BorderImageParseContext::requireOutset):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):
- css/CSSParserValues.h:
(WebCore::CSSParserValueList::previous):
LayoutTests:
- fast/borders/border-image-scrambled.html: Added.
- platform/mac/fast/borders/border-image-scrambled-expected.png: Added.
- platform/mac/fast/borders/border-image-scrambled-expected.txt: Added.
- 5:05 PM Changeset in webkit [95057] by
-
- 2 edits in trunk/Source/WebCore
WebCore::Cursor::ensurePlatformCursor() should always set a valid platform cursor on Windows
https://bugs.webkit.org/show_bug.cgi?id=68043
Make sure we set a valid platform cursor in the Cursor::NoDrop case, and add a default
clause that uses the arrow cursor in case another cursor type is added in the future
and we forget to update ensurePlatformCursor().
Reviewed by Anders Carlsson.
- platform/win/CursorWin.cpp:
(WebCore::Cursor::ensurePlatformCursor): Always set a valid platform cursor.
- 4:32 PM Changeset in webkit [95056] by
-
- 3 edits2 adds in trunk
MSAA: WebKit reports the document state as disabled
https://bugs.webkit.org/show_bug.cgi?id=67974
<rdar://problem/10095898>
Reviewed by Brian Weinstein.
Source/WebCore:
Test: platform/win/accessibility/document-enabled-state.html
- accessibility/AccessibilityScrollView.h:
(WebCore::AccessibilityScrollView::isEnabled):
This object backs the AccessibleDocument on Windows - always return
true for its enabled state.
LayoutTests:
- platform/win/accessibility/document-enabled-state-expected.txt: Added.
- platform/win/accessibility/document-enabled-state.html: Added.
- 4:10 PM Changeset in webkit [95055] by
-
- 4 edits1 add in trunk/Source/WebKit/qt
[Qt] Fix state of stop/reload actions in QWebPage
https://bugs.webkit.org/show_bug.cgi?id=65977
FrameLoader does ask its DocumentLoader to stop loading subresources before
setting the state to FrameStateCommittedPage. But it does
not check if the the DocumentLoader actually stopped loading before
it changes the state.
Therefore a subresourceLoader can still be active, when we receive the
call to dispatchDidFinishLoad(). This leads to an inconsistent behavior
of the stop/reload actions in QWebPage.
This changeset fixes the inconsistent state by updating the action states
also when frameLoadCompleted() is called.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-09-13
Reviewed by Chang Shu.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::frameLoadCompleted):
- 3:49 PM Changeset in webkit [95054] by
-
- 4 edits2 adds in trunk
Source/WebCore: Fixes several bugs when adding CounterNodes to a tree which can cause asymetrical relationships.
https://bugs.webkit.org/show_bug.cgi?id=65996
Reviewed by Eric Seidel.
Test: fast/css/counters/counter-reparent-table-children-crash.html
- rendering/CounterNode.cpp:
(WebCore::CounterNode::insertAfter):
- rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
LayoutTests: Test for crash when reparenting table elements with associated counters outside the table.
https://bugs.webkit.org/show_bug.cgi?id=65996
Reviewed by Eric Seidel.
- fast/css/counters/counter-reparent-table-children-crash-expected.txt: Added.
- fast/css/counters/counter-reparent-table-children-crash.html: Added.
- 3:41 PM Changeset in webkit [95053] by
-
- 2 edits in trunk/Source/WebCore
Adding a comment I forgot to add before.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
- 3:38 PM Changeset in webkit [95052] by
-
- 5 edits in trunk/Source/WebCore
Move identifier filter from CSSStyleSelector to SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=68025
Reviewed by Sam Weinig.
This is a more logical place for this code. It also makes CSSStyleSelector slightly less bloated.
It will make it possible to use fastRejectSelector for querySelectorAll in the future.
- css/CSSStyleSelector.cpp:
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::RuleData::RuleData):
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
- css/SelectorChecker.cpp:
(WebCore::collectElementIdentifierHashes):
(WebCore::SelectorChecker::pushParentStackFrame):
(WebCore::SelectorChecker::popParentStackFrame):
(WebCore::SelectorChecker::pushParent):
(WebCore::SelectorChecker::popParent):
(WebCore::collectDescendantSelectorIdentifierHashes):
(WebCore::SelectorChecker::collectIdentifierHashes):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::parentStackIsConsistent):
(WebCore::SelectorChecker::ParentStackFrame::ParentStackFrame):
(WebCore::SelectorChecker::fastRejectSelector):
- 3:33 PM Changeset in webkit [95051] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Restoring a ChangeLog entry that I accidentally trampled.
- 3:31 PM Changeset in webkit [95050] by
-
- 3 edits4 adds in trunk
For compatibility, execCommand should support deprecated 'useCSS' alias for 'styleWithCSS'
https://bugs.webkit.org/show_bug.cgi?id=36683
Patch by Kiyoto Tamura <owenestea@gmail.com> on 2011-09-13
Reviewed by Ryosuke Niwa.
Source/WebCore:
In addition to supporting the deprecated 'useCSS', 'styleWithCSS' now accepts any argument other than
the boolean false or the case-insensitive string "false". This is per
http://aryeh.name/spec/editing/editing.html#the-stylewithcss-command
Tests: editing/execCommand/style-with-css.html
editing/execCommand/use-css.html
- editing/EditorCommand.cpp:
(WebCore::executeStyleWithCSS):
(WebCore::executeUseCSS):
(WebCore::createCommandMap):
LayoutTests:
Testing useCSS, the command previously unsupported by WebKit. Also, we are testing
styleWithCSS accepts anything that is not the boolean false or the string "false" as true.
Furthermore, we test that queryCommandValue/State('useCSS') return boolean false and
queryCommandValue/State('useStyleWithCSS') returns booleans (as opposed to 'true'/'false'
strings)
- editing/execCommand/style-with-css-expected.txt: Added.
- editing/execCommand/style-with-css.html: Added.
- editing/execCommand/use-css-expected.txt: Added.
- editing/execCommand/use-css.html: Added.
- 3:28 PM Changeset in webkit [95049] by
-
- 16 edits in trunk
Disable C++ exceptions when building with clang
https://bugs.webkit.org/show_bug.cgi?id=68031
<rdar://problem/9556880>
Reviewed by Mark Rowe.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
Source/JavaScriptGlue:
- Configurations/Base.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
Tools:
- MiniBrowser/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- 3:17 PM Changeset in webkit [95048] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=67885
Outline for the high-resolution broken image icon draws at 2x
-and corresponding-
<rdar://problem/10104637>
Reviewed by Dan Bernstein.
Scaled the image size to account for the deviceScaleFactor.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
- 2:54 PM Changeset in webkit [95047] by
-
- 4 edits3 adds in trunk
REGRESSION (64275): Shape pattern-image fill turns black
https://bugs.webkit.org/show_bug.cgi?id=51061
<rdar://problem/8504705>
Reviewed by Simon Fraser.
Source/WebCore:
When destroying a resource, register clients who are losing their
resource as having pending resources, so they can be resolved in the case a
resource with that id is re-registered.
Test: svg/custom/pending-resource-after-removal.xhtml
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::resourceDestroyed):
- svg/SVGStyledElement.h:
(WebCore::toSVGStyledElement): Added.
LayoutTests:
Add a test ensuring that replacing a SVG pattern without changing
the id causes the clients to be updated properly.
- svg/custom/pending-resource-after-removal-expected.png: Added.
- svg/custom/pending-resource-after-removal-expected.txt: Added.
- svg/custom/pending-resource-after-removal.xhtml: Added.
- 2:50 PM Changeset in webkit [95046] by
-
- 3 edits in trunk/Tools
[chromium] fix flakiness dashboard for chromium interactive tests
https://bugs.webkit.org/show_bug.cgi?id=68029
Reviewed by Tony Chang.
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
- 2:43 PM Changeset in webkit [95045] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] The checked state of WebPopupMenuItem isn't initialized
https://bugs.webkit.org/show_bug.cgi?id=67889
Reviewed by Darin Fisher.
It seems we're failing to initialize the checked state of
WebPopupMenuItems, potentially because Android is the first platform to
use popup menus for <select> elements.
- src/ExternalPopupMenu.cpp:
(WebKit::ExternalPopupMenu::getPopupMenuInfo):
- 2:29 PM QtWebKitRelease22 edited by
- (diff)
- 2:08 PM Changeset in webkit [95044] by
-
- 2 edits in trunk/Tools
Add Alice and Aryeh to the list of contributors.
- Scripts/webkitpy/common/config/committers.py:
- 1:59 PM Changeset in webkit [95043] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed; new baselines (Skia on Mac)
Updated reference images.
- platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
- platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.png: Added.
- 1:51 PM Changeset in webkit [95042] by
-
- 3 edits in trunk/Tools
sheriffbot whois should also tell us email addresses
https://bugs.webkit.org/show_bug.cgi?id=67975
Reviewed by Eric Seidel and David Levin.
Taught sheriffbot how to tell us contributor's email addresses.
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- 1:35 PM Changeset in webkit [95041] by
-
- 1 edit7 adds1 delete in trunk/LayoutTests
Unreviewed; new baselines (Skia on Mac)
Updated reference images, text.
- platform/chromium-mac/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Removed.
- platform/chromium-mac/platform/chromium/fast/repaint: Added.
- platform/chromium-mac/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
- platform/chromium-mac/fast/lists/list-marker-before-content-table-expected.png: Added.
- platform/chromium-mac/fast/runin/runin-generated-before-content-expected.png: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
- platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png: Added.
- platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png: Added.
- 1:19 PM Changeset in webkit [95040] by
-
- 38 edits in trunk
Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
https://bugs.webkit.org/show_bug.cgi?id=68018
Reviewed by Ryosuke Niwa.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.exp.in:
- dom/DOMImplementation.cpp:
(WebCore::isSVG10Feature):
(WebCore::isSVG11Feature):
- dom/Text.cpp:
(WebCore::Text::createRenderer):
- features.pri:
- page/DOMWindow.idl:
- rendering/svg/RenderSVGForeignObject.cpp:
- rendering/svg/RenderSVGForeignObject.h:
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
- svg/SVGForeignObjectElement.cpp:
- svg/SVGForeignObjectElement.h:
- svg/SVGForeignObjectElement.idl:
- svg/SVGLocatable.cpp:
(WebCore::isViewportElement):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::isOutermostSVG):
- svg/SVGUseElement.cpp:
(WebCore::isDisallowedElement):
(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
- svg/svgtags.in:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/build-webkit:
- waf/build/settings.py:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 12:26 PM Changeset in webkit [95039] by
-
- 21 edits1 copy1 add in trunk
[WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
https://bugs.webkit.org/show_bug.cgi?id=57515
Source/WebKit2:
The code change in WebKit2 allows key events being sent to WebProcess from UIProcess synchronously.
Patch by Chang Shu <cshu@webkit.org> on 2011-09-13
Reviewed by Darin Adler.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetShouldSendKeyboardEventSynchronously):
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleKeyboardEvent):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::setShouldSendKeyboardEventSynchronously):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::keyEventSyncForTesting):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
TestController synchronously. The latter then sends simulated event to WebKit2 module,
which is synchronous, too.
Patch by Chang Shu <cshu@webkit.org> on 2011-09-13
Reviewed by Darin Adler.
- WebKitTestRunner/EventSenderProxy.h: Added.
(WTR::EventSenderProxy::EventSenderProxy):
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::keyDown):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
- WebKitTestRunner/PlatformWebView.h:
(WTR::PlatformWebView::platformWindow):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/mac/EventSenderProxy.mm: Added.
(WTR::buildModifierFlags):
(WTR::EventSenderProxy::keyDown):
LayoutTests:
Unskip passed tests for Mac.
Patch by Chang Shu <cshu@webkit.org> on 2011-09-13
Reviewed by Darin Adler.
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
- platform/win-wk2/Skipped:
- platform/wk2/Skipped:
- 12:24 PM Changeset in webkit [95038] by
-
- 3 edits3 adds in trunk
<http://webkit.org/b/67983> CRASH under WebCore::ArchiveResourceCollection::addAllResources loading WebArchive
Reviewed by Darin Adler.
Source/WebCore:
Null mimetypes are okay for subresources, but as previously discovered
in bug 41082 they were required for main resources. Here we ensure
that they are required for main resources, but we allow null mimetypes
for subresources.
To fix a crash for bad input we never add a null ArchiveResource to the
Archive's subresource collection. It is useless and causes crashes whenever
someone iterates the Archive's subresource collection.
Test: webarchive/loading/test-loading-archive-subresource-null-mimetype.html
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createResource):
Allow a null mimetype, just type check from the dictionary.
(WebCore::LegacyWebArchive::extract):
Require a mimetype for the main resource. Do not add null
subresources to the subresource list.
LayoutTests:
Test a WebArchive that has been constructed to have a null
mimetype for a subresource.
- webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt: Added.
- webarchive/loading/test-loading-archive-subresource-null-mimetype.html: Added.
- webarchive/loading/resources/subresource-null-mimetype.webarchive: Added.
- 12:18 PM Changeset in webkit [95037] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-09-13 James Simonsen <simonjam@chromium.org>
[Chromium] Ref protect element in FrameLoaderClientImpl::createPlugin
https://bugs.webkit.org/show_bug.cgi?id=68014
Reviewed by Nate Chapin.
Test: plugins/destroy-during-npp-new.htm under valgrind
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
- 11:33 AM Changeset in webkit [95036] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-13
- DEPS:
- 11:25 AM Changeset in webkit [95035] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Remove javascript_engine from WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=68001
Reviewed by Tony Chang.
Remove javascript_engine GYP variable (similar to the removal done on
the Chromium side with http://crrev.com/100692)
- WebCore.gyp/WebCore.gyp:
- 10:58 AM Changeset in webkit [95034] by
-
- 1 edit in branches/chromium/874/Source/WebCore/platform/graphics/Gradient.cpp
Merge 95010 - Fix out-of-bounds access in Gradient::sortStopsIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=67958
Reviewed by Darin Adler.
Reported by Valgrind in http://crbug.com/77049.
The errant code was added as an optimization in r67804.
This patch reverts that one, as all parties agree that the optimization
doesn't seem worthwhile, and there clearly aren't any tests covering
the special case.
No new tests, as existing tests should cover the remaining call to
|std::stable_sort|.
- platform/graphics/Gradient.cpp:
(WebCore::Gradient::sortStopsIfNecessary):
TBR=adamk@chromium.org
Review URL: http://codereview.chromium.org/7891013
- 10:54 AM Changeset in webkit [95033] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Do not always return the cached frame name.
https://bugs.webkit.org/show_bug.cgi?id=66856
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-13
Reviewed by Antonio Gomes.
When a frame has its parent changed (via adoptNode and appendChild,
for example), the frame name will change, so we need to account for
that case and change the cached name when needed.
This should make fast/frames/iframe-reparenting-unique-name.html pass.
- ewk/ewk_frame.cpp:
(ewk_frame_name_get):
- 10:46 AM Changeset in webkit [95032] by
-
- 2 edits in trunk/LayoutTests
Update chromium test expectation since fast/borders/border-image-omit-right-slice.html no longer hits an assertion.
- platform/chromium/test_expectations.txt:
- 10:31 AM Changeset in webkit [95031] by
-
- 2 edits in trunk/Source/WebCore
[CSS3 Backgrounds and Borders] Add unprefixed border-image shorthand.
https://bugs.webkit.org/show_bug.cgi?id=67970
Reviewed by David Hyatt.
Also update CSSStyleSelector.cpp to support border-image to suppress assertion in
fast/borders/border-image-omit-right-slice.html
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
- 9:44 AM Changeset in webkit [95030] by
-
- 3 edits2 adds in trunk
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-13
Reviewed by Darin Adler.
Source/WebCore:
Webkit wraps between hyphen-minus and numeric characters
https://bugs.webkit.org/show_bug.cgi?id=20677
Disallow wrapping between a hyphen-minus and a digit if the hyphen-minus
is not directly after a digit or a letter.
Test: fast/text/line-breaks-after-hyphen-before-number.html
- rendering/break_lines.cpp:
(WebCore::asciiLineBreakTable): Disabled line-breaking after '-' and before '.', '0'-'9'. Note: the change for '0'-'9' doesn't really matter because the case is handled hard-coded in shouldBreakAfter().
(WebCore::shouldBreakAfter): Changed line-breaking behavior after '-'.
(WebCore::nextBreakablePosition): Passes lastLastCh to shouldBreakAfter.
LayoutTests:
Webkit wraps between hyphen-minus and numeric characters
https://bugs.webkit.org/show_bug.cgi?id=20677
Disallow wrapping between a hyphen-minus and a digit if the hyphen-minus
is not directly after a digit or a letter.
- fast/text/line-breaks-after-hyphen-before-number-expected.txt: Added.
- fast/text/line-breaks-after-hyphen-before-number.html: Added.
- 9:23 AM Changeset in webkit [95029] by
-
- 2 edits in trunk/Source/WebCore
platform/graphics/gtk/FontGtk.cpp was renamed to platform/graphics/pango/FontPango.cpp . Reflect this change in WebCore.gypi to fix a Chromium build breakage.
https://bugs.webkit.org/show_bug.cgi?id=68000
Patch by Erik Wright <erikwright@chromium.org> on 2011-09-13
Reviewed by Tony Gentilcore.
No change in functionality, thus no new tests.
- WebCore.gypi:
- 9:01 AM Changeset in webkit [95028] by
-
- 3 edits3 adds in trunk
Object.getPrototypeOf should use JSValue::get()
https://bugs.webkit.org/show_bug.cgi?id=67973
Reviewed by Darin Adler.
Source/JavaScriptCore:
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
Pipe through JSValue::get() to allow overrides.
LayoutTests:
- http/tests/security/cross-frame-access-object-getPrototypeOf-expected.txt: Added.
- http/tests/security/cross-frame-access-object-getPrototypeOf.html: Added.
- http/tests/security/resources/cross-frame-iframe-for-object-getPrototypeOf-test.html: Added.
- 8:32 AM Changeset in webkit [95027] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Profiler: Fix overlapping data in function names column.
https://bugs.webkit.org/show_bug.cgi?id=67896
Reviewed by Pavel Feldman.
- inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.createCell):
- inspector/front-end/dataGrid.css:
(.data-grid table.data):
(.data-grid td):
- 8:20 AM Changeset in webkit [95026] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r95025.
http://trac.webkit.org/changeset/95025
https://bugs.webkit.org/show_bug.cgi?id=68005
Test failed on Snow Leopard bots. (Requested by yutak_home on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-13
- websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- 6:53 AM QtWebKitFeatures22 edited by
- (diff)
- 6:52 AM QtWebKitFeatures22 edited by
- (diff)
- 6:52 AM QtWebKitFeatures22 edited by
- (diff)
- 6:25 AM Changeset in webkit [95025] by
-
- 3 edits in trunk/Source/WebCore
ThreadableWebSocketChannelClientWrapper shouldn't have a String in it.
https://bugs.webkit.org/show_bug.cgi?id=67908
Reviewed by David Levin.
Replace a String member variable in ThreadableWebSocketChannelClientWrapper with Vector<UChar>.
No change in functionality, thus no new tests. WebSocket worker tests
(tests under http/tests/websocket/tests/{hixie76,hybi}/workers/) should keep passing.
- websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
Create a String from Vector<UChar>.
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
Copy the content of the given String into Vector.
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- 6:00 AM Changeset in webkit [95024] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium test expectations
- platform/chromium/test_expectations.txt: fast/borders/border-image-omit-right-slice.html fails on release
- 3:39 AM Changeset in webkit [95023] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, build fix.
CSSPropertyBorderImage was added in r94989, but not yet added in
WebCore::CSSStyleSelector::applyProperty
CSSStyleSelector.cpp:2481: warning: enumeration value 'CSSPropertyBorderImage' not handled in switch
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- 2:33 AM QtWebKitRelease22 edited by
- Add link to the waterfall of QtWebKit 2.2 buildbots (diff)
- 1:26 AM Changeset in webkit [95022] by
-
- 2 edits in trunk/LayoutTests
eventSender.keyDown is unimplemented (WKTR)
https://bugs.webkit.org/show_bug.cgi?id=57515
Unreviewed gardening.
- platform/qt-wk2/Skipped:
Sep 12, 2011:
- 11:57 PM Changeset in webkit [95021] by
-
- 2 edits in trunk/LayoutTests
[chromium] fast/js/parseInt.html does not fail any more.
https://bugs.webkit.org/show_bug.cgi?id=65366
parseInt bug was fixed in v8 version 3.6.0.
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-12
Reviewed by Eric Seidel.
- platform/chromium/test_expectations.txt:
- 11:18 PM Changeset in webkit [95020] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Roll DEPS again.
- DEPS:
- 11:14 PM Changeset in webkit [95019] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r95015.
http://trac.webkit.org/changeset/95015
https://bugs.webkit.org/show_bug.cgi?id=67987
compiled failed on Chromium Win bot (Requested by ukai on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-12
- DEPS:
- 11:10 PM Changeset in webkit [95018] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test that ensures that the accessibility tree
does not contain duplicate child nodes.
https://bugs.webkit.org/show_bug.cgi?id=58930
This test failed when the bug was originally filed, but was
fixed in: https://bugs.webkit.org/show_bug.cgi?id=61805
so no code changes are accompanying this new layout test.
Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-12
Reviewed by Chris Fleizach.
- accessibility/duplicate-child-nodes-expected.txt: Added.
- accessibility/duplicate-child-nodes.html: Added.
- 10:57 PM Changeset in webkit [95017] by
-
- 3 edits2 adds in trunk
Crashes in WebCore::InsertListCommand::unlistifyParagraph.
https://bugs.webkit.org/show_bug.cgi?id=67918
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-12
Reviewed by Ryosuke Niwa.
Source/WebCore:
execCommand("InsertUnorderedList") was crashing if the parent node of the target is
a kind of list element and it is not contenteditable.
This patch checks the parent node is contenteditable.
Test: editing/execCommand/insert-list-in-noneditable-list-parent.html
- editing/htmlediting.cpp:
(WebCore::enclosingListChild): Checks the parent node is contenteditable.
LayoutTests:
Added tests.
- editing/execCommand/insert-list-in-noneditable-list-parent-expected.txt: Added.
- editing/execCommand/insert-list-in-noneditable-list-parent.html: Added.
- 10:35 PM Changeset in webkit [95016] by
-
- 23 edits4 adds1 delete in trunk/Source/JavaScriptCore
JavaScriptCore does not have baseline->speculative OSR
https://bugs.webkit.org/show_bug.cgi?id=67920
Reviewed by Oliver Hunt.
This adds the ability to on-stack-replace (OSR) from code that is
running hot in the old JIT to code compiled by the new JIT. This
ensures that long-running loops benefit from DFG optimization.
It also ensures that if code experiences a speculation failure
in DFG code, it has an opportunity to reenter the DFG once every
1,000 loop iterations or so.
This results in a 2.88x speed-up on Kraken/imaging-desaturate,
and is a pure win on the main three benchmark suites (SunSpider,
V8, Kraken), when tiered compilation is enabled.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
- bytecode/CodeBlock.h:
- bytecode/Opcode.h:
- bytecode/PredictedType.h: Added.
(JSC::isCellPrediction):
(JSC::isArrayPrediction):
(JSC::isInt32Prediction):
(JSC::isDoublePrediction):
(JSC::isNumberPrediction):
(JSC::isBooleanPrediction):
(JSC::isStrongPrediction):
(JSC::predictionToString):
(JSC::mergePredictions):
(JSC::mergePrediction):
(JSC::makePrediction):
- bytecode/PredictionTracker.h: Added.
(JSC::operandIsArgument):
(JSC::PredictionSlot::PredictionSlot):
(JSC::PredictionTracker::PredictionTracker):
(JSC::PredictionTracker::initializeSimilarTo):
(JSC::PredictionTracker::copyLocalsFrom):
(JSC::PredictionTracker::numberOfArguments):
(JSC::PredictionTracker::numberOfVariables):
(JSC::PredictionTracker::argumentIndexForOperand):
(JSC::PredictionTracker::predictArgument):
(JSC::PredictionTracker::predict):
(JSC::PredictionTracker::predictGlobalVar):
(JSC::PredictionTracker::getArgumentPrediction):
(JSC::PredictionTracker::getPrediction):
(JSC::PredictionTracker::getGlobalVarPrediction):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoopHint):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
- dfg/DFGNode.h:
- dfg/DFGOSREntry.cpp: Added.
(JSC::DFG::predictionIsValid):
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSREntry.h: Added.
(JSC::DFG::prepareOSREntry):
- dfg/DFGPredictionTracker.h: Removed.
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::mergeUse):
(JSC::DFG::Propagator::mergePrediction):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/CompactJITCodeMap.h:
(JSC::CompactJITCodeMap::numberOfEntries):
(JSC::CompactJITCodeMap::decode):
(JSC::CompactJITCodeMap::Decoder::Decoder):
(JSC::CompactJITCodeMap::Decoder::numberOfEntriesRemaining):
(JSC::CompactJITCodeMap::Decoder::read):
- jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::emitTimeoutCheck):
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
(JSC::JIT::emit_op_loop_hint):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- 9:50 PM Changeset in webkit [95015] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-12
- DEPS:
- 9:44 PM Changeset in webkit [95014] by
-
- 38 edits3 deletes in trunk
Unreviewed, rolling out r94975.
http://trac.webkit.org/changeset/94975
https://bugs.webkit.org/show_bug.cgi?id=67984
crash in PrerenderBrowserTest.PrerenderHTML5VideoJs (Requested
by ukai on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-12
Source/WebCore:
- platform/graphics/chromium/CanvasLayerChromium.h:
(WebCore::CanvasLayerChromium::layerTypeAsString):
- platform/graphics/chromium/ContentLayerChromium.h:
(WebCore::ContentLayerChromium::layerTypeAsString):
- platform/graphics/chromium/ImageLayerChromium.h:
(WebCore::ImageLayerChromium::layerTypeAsString):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::layerTreeAsText):
(WebCore::writeIndent):
(WebCore::LayerChromium::dumpLayer):
(WebCore::LayerChromium::dumpLayerProperties):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::layerTypeAsString):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::textureMemoryReclaimLimit):
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::close):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::owner):
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::rootLayerImpl):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::contentsTextureManager):
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
- platform/graphics/chromium/PluginLayerChromium.h:
(WebCore::PluginLayerChromium::layerTypeAsString):
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::name):
(WebCore::writeIndent):
(WebCore::RenderSurfaceChromium::dumpSurface):
- platform/graphics/chromium/RenderSurfaceChromium.h:
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):
- platform/graphics/chromium/TextureManager.h:
(WebCore::TextureManager::setAssociatedContextDebugOnly):
(WebCore::TextureManager::associatedContextDebugOnly):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::writeIndent):
(WebCore::TiledLayerChromium::dumpLayerProperties):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/VideoLayerChromium.h:
(WebCore::VideoLayerChromium::layerTypeAsString):
- platform/graphics/chromium/WebGLLayerChromium.h:
(WebCore::WebGLLayerChromium::layerTypeAsString):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
- platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
- platform/graphics/chromium/cc/CCLayerImpl.h:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::contentsTextureManager):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
- platform/graphics/chromium/cc/CCPluginLayerImpl.h:
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::contentsTextureManager):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::contentsTextureManager):
(WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::dumpLayerProperties):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
LayoutTests:
- platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
- platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.txt: Removed.
- platform/chromium/compositing/lost-compositor-context-with-rendersurface.html: Removed.
- 9:41 PM Changeset in webkit [95013] by
-
- 2 edits in trunk/Source/WebCore
Possible ASSERT(!storageTracker) in Lazily Initialized StorageTracker
https://bugs.webkit.org/show_bug.cgi?id=67957
Reviewed by Darin Adler.
The storageTracker singleton may already have been created
through StorageTracker::tracker before initializeTracker
gets called. Update the ASSERT in this case to check that
there is no client for the tracker.
No test, this depends on how the port initializes the tracker.
- storage/StorageTracker.cpp:
(WebCore::StorageTracker::initializeTracker):
- 9:15 PM Changeset in webkit [95012] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=67943
Reviewed by Adam Barth.
- src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess
allowing the automatic ref counting to work. This was previous needed when
the ref counting wasn't working but that was fixed in r94986. Note that the
design was to have ref counting since the methods take PassRefPtr and the
class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
adding in AllowCrossThreadAccess.)
(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
(WebKit::WorkerFileWriterCallbacksBridge::didFail):
(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):
- 9:01 PM Changeset in webkit [95011] by
-
- 5 edits in trunk
Don't allow setting proto to be a getter or setter
https://bugs.webkit.org/show_bug.cgi?id=67982
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
Disallow setting a getter or setter on proto.
LayoutTests:
- fast/js/prototypes-expected.txt:
- fast/js/script-tests/prototypes.js:
Add test that we disallow setting a getter or setter on proto.
- 8:55 PM Changeset in webkit [95010] by
-
- 2 edits in trunk/Source/WebCore
Fix out-of-bounds access in Gradient::sortStopsIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=67958
Reviewed by Darin Adler.
Reported by Valgrind in http://crbug.com/77049.
The errant code was added as an optimization in r67804.
This patch reverts that one, as all parties agree that the optimization
doesn't seem worthwhile, and there clearly aren't any tests covering
the special case.
No new tests, as existing tests should cover the remaining call to
|std::stable_sort|.
- platform/graphics/Gradient.cpp:
(WebCore::Gradient::sortStopsIfNecessary):
- 8:50 PM Changeset in webkit [95009] by
-
- 3 edits2 adds in trunk
Setting document.title doesn't affect contents of title tag of XHTML documents
https://bugs.webkit.org/show_bug.cgi?id=57537
Patch by Jacky Jiang <zhajiang@rim.com> on 2011-09-12
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Update the contents of the <title> tag of XHTML documents when setting
document.title.
Test: fast/dom/title-content-set-innerText-get.xhtml
- dom/Document.cpp:
(WebCore::Document::setTitle):
LayoutTests:
- fast/dom/title-content-set-innerText-get-expected.txt: Added.
- fast/dom/title-content-set-innerText-get.xhtml: Added.
- 8:44 PM Changeset in webkit [95008] by
-
- 1 edit4 adds in trunk/LayoutTests
Add GTK & Win expectations for two recently added
accessibility layout tests.
https://bugs.webkit.org/show_bug.cgi?id=67948
Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-12
Reviewed by Chris Fleizach.
- platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
- platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Added.
- platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
- platform/win/accessibility/div-within-anchors-causes-crash-expected.txt: Added.
- 8:38 PM Changeset in webkit [95007] by
-
- 2 edits1 add in trunk/Tools
[EFL] DRT: Add DumpRenderTreeEfl.h
https://bugs.webkit.org/show_bug.cgi?id=63993
Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-12
Reviewed by Eric Seidel.
This header contains some global variables used by EFL's
DumpRenderTree implementation.
- DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
appropriate.
- DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
- 8:34 PM Changeset in webkit [95006] by
-
- 2 edits in trunk/Tools
[EFL] Send the right key names for PageUp and PageDown.
https://bugs.webkit.org/show_bug.cgi?id=67044
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-12
Reviewed by Kenneth Rohde Christiansen.
PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
PageDown (which is close to the defines in WindowsKeyboardCodes.h).
However, EventSender was sending "Page_Up" and "Page_Down", so tests
such as editing/input/page-up-down-scrolls.html were timing out due to
the right key down events not being sent.
- DumpRenderTree/efl/EventSender.cpp:
(keyPadNameFromJSValue):
(keyNameFromJSValue):
- 8:30 PM Changeset in webkit [95005] by
-
- 3 edits in trunk/Source/WebKit2
Reviewed by Eric Seidel.
[CMAKE][WK2] include cmakeconfig.h in WebKit2/config.h
https://bugs.webkit.org/show_bug.cgi?id=62692
- CMakeLists.txt: define WTF_USE_JSC=1.
- config.h: add cmakeconfig.h and define necessary macros for CMake build.
- 8:24 PM Changeset in webkit [95004] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Initialize m_unmodifiedText in PlatformKeyboardEventEfl.
https://bugs.webkit.org/show_bug.cgi?id=67038
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-12
Reviewed by Kenneth Rohde Christiansen.
Since most of the time it will return the same thing as text(), we
initialize it the same way we initialize m_text. The other case (what
would have been generated if no modifiers were pressed) should be
covered by this as well.
As this method is used when handling access keys, tests such as
fast/events/access-key-self-destruct.html should now pass.
No new tests, as this fixes a problem uncovered by the existing ones.
- platform/efl/PlatformKeyboardEventEfl.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- 8:13 PM Changeset in webkit [95003] by
-
- 1 edit1 copy2 moves1 add11 deletes in trunk/LayoutTests
Patch by Wyatt Carss <wcarss@chromium.org> on 2011-09-12
Reviewed by Eric Seidel.
convert editing/deleting/5390681-2.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=63293
Renamed editing/deleting/5390681* to editing/deleting/smart-delete-across-editable-boundaries,
Added doctype/html/body to both tests, and converted smart-delete-across-editable-boundaries-2
to dump-as-markup test in the same style as the first. Also updated results.
- editing/deleting/5390681.html: Removed.
- editing/deleting/5390681-expected.txt: Removed.
- editing/deleting/5390681-2.html: Removed.
- editing/deleting/smart-delete-across-editable-boundaries.html: Added.
- editing/deleting/smart-delete-across-editable-boundaries-expected.txt: Added.
- editing/deleting/smart-delete-across-editable-boundaries-2.html: Added.
- editing/deleting/smart-delete-across-editable-boundaries-2-expected.txt: Added.
- platform/chromium-linux/editing/deleting/5390681-2-expected.png: Removed.
- platform/chromium-win/editing/deleting/5390681-2-expected.png: Removed.
- platform/chromium-win/editing/deleting/5390681-2-expected.txt: Removed.
- platform/gtk/editing/deleting/5390681-2-expected.txt: Removed.
- platform/mac-leopard/editing/deleting/5390681-2-expected.png: Removed.
- platform/mac/editing/deleting/5390681-2-expected.png: Removed.
- platform/mac/editing/deleting/5390681-2-expected.txt: Removed.
- platform/qt/editing/deleting/5390681-2-expected.png: Removed.
- platform/qt/editing/deleting/5390681-2-expected.txt: Removed.
- platform/qt/editing/deleting/5390681-expected.png: Removed.
- 8:12 PM Changeset in webkit [95002] by
-
- 1 edit1 add in trunk/Source/WebCore
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2011-09-12
Reviewed by Eric Seidel.
[EFL] Add GraphicsContext3DEfl for WebGL and accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=62709
Add GraphicsContext3D implementation for EFL port.
GraphicsContext3D delegates to GraphicsContext3DInternal.
- platform/graphics/efl/GraphicsContext3DEfl.cpp: Added.
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::getImageData):
- 8:02 PM Changeset in webkit [95001] by
-
- 2 edits in trunk/Source/WebCore
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2011-09-12
Reviewed by Eric Seidel.
[CMAKE] Remove platform/graphics/opengl/*OpenGL.cpp files in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=62707
No change in fuctionality so no new tests.
Bug 62376 makes all ports use GraphicsContext3DOpenGL and
Extensions3DOpenGL when enabling WebGL.
However, some ports already have their own GC3D implementation.
In QT and chromium, for example, GC3D delegates to GC3DInternal.
So, it would be better to allow each port to decide whether or not
to include files in platform/graphics/opengl.
- CMakeLists.txt:
- 7:59 PM Changeset in webkit [95000] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium test expectations.
- platform/chromium/test_expectations.txt: fast/borders/border-image-omit-right-slice.html crash on debug
- 7:43 PM Changeset in webkit [94999] by
-
- 2 edits in trunk/LayoutTests
Unreviewred, update chromium test expectations.
- platform/chromium/test_expectations.txt: fast/events/constructors/progress-event-constructor.html on mac
- 7:25 PM Changeset in webkit [94998] by
-
- 2 edits in trunk/LayoutTests
[chromium] Remove bad expectation that was causing us to run a compositing/ test on Leopard. Tsk tsk, Mike
Reed!
- platform/chromium/test_expectations.txt:
- 6:57 PM Changeset in webkit [94997] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for chromium.
Guard access to UString::latin1() with USE(JSC) since it is defined in JavaScriptCore/runtime/UString.cpp, which
is currently only compiled in by ports that use JavaScriptCore. This code is currently unreachable in builds so
no change in functionality.
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::CharAccess::CharAccess):
- 6:33 PM Changeset in webkit [94996] by
-
- 20 edits1 add in trunk/Source/JavaScriptCore
JavaScriptCore does not have speculative->baseline OSR
https://bugs.webkit.org/show_bug.cgi?id=67826
Reviewed by Oliver Hunt.
This adds the ability to bail out of DFG speculative JIT execution by
performing an on-stack replacement (OSR) that results in the control
flow going to the equivalent code generated by the old JIT.
This required a number of new features, as well as taking advantage of
some features that happened to already be present:
We already had a policy of storing the bytecode index for which a DFG
node was generated inside the DFG::Node class. This was previously
called exceptionInfo. It's now renamed to codeOrigin to reflect that
it's used for more than just excpetions. OSR uses this to figure out
which bytecode index to use to look up the machine code location in
the code generated by the old JIT that we should be jumping to.
CodeBlock now stores a mapping between bytecode indices and machine
code offsets for code generated by the old JIT. This is implemented
by CompactJITCodeMap, which tries to compress this data a bit. The
OSR compiler decodes this and uses it to find the machine code
locations it should be jumping to.
We already had a mechanism that emitted SetLocal nodes in the DFG graph
that told us the time at which the old JIT would have stored something
into its register file, and the DFG::Node that corresponds to the value
that it would have stored. These SetLocal's were mostly dead-code-
eliminated, but our DCE leaves the nodes intact except for making them
have 0 as the ref count. This allows the OSR compiler to construct a
mapping between the state as it would have been seen by the old JIT
and the state as the DFG JIT sees it. The OSR compiler uses this to
generate code that reshapes the call frame so that it is like what the
old JIT would expect.
Finally, when DFG_OSR is enabled (the default for TIERED_COMPILATION)
we no longer emit the non-speculative path.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addToGraph):
- dfg/DFGGPRInfo.h:
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::alive):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheck):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::CallRecord::CallRecord):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::appendCallWithExceptionCheck):
(JSC::DFG::JITCompiler::appendCallWithFastExceptionCheck):
(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord):
- dfg/DFGNode.h:
(JSC::DFG::CodeOrigin::CodeOrigin):
(JSC::DFG::CodeOrigin::isSet):
(JSC::DFG::CodeOrigin::bytecodeIndex):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1Unchecked):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::nodeIndex):
(JSC::DFG::ValueRecovery::ValueRecovery):
(JSC::DFG::ValueRecovery::alreadyInRegisterFile):
(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::inFPR):
(JSC::DFG::ValueRecovery::displacedInRegisterFile):
(JSC::DFG::ValueRecovery::constant):
(JSC::DFG::ValueRecovery::technique):
(JSC::DFG::ValueRecovery::gpr):
(JSC::DFG::ValueRecovery::fpr):
(JSC::DFG::ValueRecovery::virtualRegister):
(JSC::DFG::OSRExit::numberOfRecoveries):
(JSC::DFG::OSRExit::valueRecovery):
(JSC::DFG::OSRExit::isArgument):
(JSC::DFG::OSRExit::argumentForIndex):
(JSC::DFG::OSRExit::variableForIndex):
(JSC::DFG::OSRExit::operandForIndex):
(JSC::DFG::SpeculativeJIT::osrExits):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::valueSourceForOperand):
(JSC::DFG::SpeculativeJIT::setNodeIndexForOperand):
(JSC::DFG::SpeculativeJIT::valueSourceReferenceForOperand):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculationCheckIndexIterator::SpeculationCheckIndexIterator):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
- jit/CompactJITCodeMap.h: Added.
(JSC::BytecodeAndMachineOffset::BytecodeAndMachineOffset):
(JSC::BytecodeAndMachineOffset::getBytecodeIndex):
(JSC::BytecodeAndMachineOffset::getMachineCodeOffset):
(JSC::CompactJITCodeMap::~CompactJITCodeMap):
(JSC::CompactJITCodeMap::decode):
(JSC::CompactJITCodeMap::CompactJITCodeMap):
(JSC::CompactJITCodeMap::at):
(JSC::CompactJITCodeMap::decodeNumber):
(JSC::CompactJITCodeMap::Encoder::Encoder):
(JSC::CompactJITCodeMap::Encoder::~Encoder):
(JSC::CompactJITCodeMap::Encoder::append):
(JSC::CompactJITCodeMap::Encoder::finish):
(JSC::CompactJITCodeMap::Encoder::appendByte):
(JSC::CompactJITCodeMap::Encoder::encodeNumber):
(JSC::CompactJITCodeMap::Encoder::ensureCapacityFor):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):
- jit/JIT.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
- runtime/JSGlobalData.h:
(JSC::JSGlobalData::osrScratchBufferForSize):
- runtime/JSValue.cpp:
(JSC::JSValue::description):
- 6:26 PM Changeset in webkit [94995] by
-
- 1 edit1 move in trunk/Source/WebKit/gtk/po
Unreviewed. Rename Greek translation file, the correct code is el
(http://www.science.co.il/language/Locale-Codes.asp?s=decimal).
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2011-09-12
- el.po: Renamed from Source/WebKit/gtk/po/gr.po.
- 5:26 PM Changeset in webkit [94994] by
-
- 1 edit2 copies in branches/chromium/874
Merge 94988 - REGRESSION: Moving up doesn't work in some cases
https://bugs.webkit.org/show_bug.cgi?id=67522
Reviewed by Eric Seidel.
Source/WebCore:
The bug was caused by previousLinePosition's attempting to obtain the last root line box using
a position at minCaretOffset (which is, in practice, located at the beginning of wrapped lines).
Fix the bug by calling maxCaretOffset instead. Because isCandidate returns false at (br, 1),
use the positionBeforeNode for br elements.
Test: editing/selection/move-up-into-wrapped-line.html
- editing/visible_units.cpp:
(WebCore::previousLinePosition):
LayoutTests:
Add a test to move caret upwards from an empty line below wrapped lines.
WebKit used to skip wrapped lines and placed caret at the beginning of the first of those wrapped lines
instead of before the last.
- editing/selection/move-up-into-wrapped-line-expected.txt: Added.
- editing/selection/move-up-into-wrapped-line.html: Added.
Review URL: http://codereview.chromium.org/7878009
- 5:07 PM Changeset in webkit [94993] by
-
- 5 edits in trunk/Tools
sheriffbot whois is case sensitive
https://bugs.webkit.org/show_bug.cgi?id=67972
Reviewed by Adam Barth.
I also fixed a typo in the "More than 5 contributors" message
from my previous commit.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/committers_unittest.py:
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- 5:06 PM Changeset in webkit [94992] by
-
- 2 edits in trunk/Source/JavaScriptCore
Re-enabled ENABLE(LAZY_BLOCK_FREEING).
Reviewed by Stephanie Lewis.
I accidentally disabled this in r94890, causing a big performance regression.
- wtf/Platform.h:
- 5:02 PM Changeset in webkit [94991] by
-
- 4 edits3 adds in trunk
<rdar://problem/10054615> Floats in ruby text intrude into the base
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/ruby/float-overhang-from-ruby-text.html
- rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::avoidsFloats): Added. Returns true. This ensures that
RenderBlock::clearFloats() will not consider ruby text as having intruding floats.
- rendering/RenderRubyText.h:
LayoutTests:
- fast/ruby/float-overhang-from-ruby-text-expected.png: Added.
- fast/ruby/float-overhang-from-ruby-text-expected.txt: Added.
- fast/ruby/float-overhang-from-ruby-text.html: Added.
- 4:43 PM Changeset in webkit [94990] by
-
- 4 edits in trunk/Tools
sheriffbot whois should be smarter
https://bugs.webkit.org/show_bug.cgi?id=67971
Reviewed by Adam Barth.
This makes sheriffbot whois basically grep the committers list
making it much easier to find a contributor by name.
Unfortunately the current unittests depend on the real committers.py
file, so as we add more eric's to the project, this unittest result will
change. I think that's OK for now. We'll fix it when it breaks.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- 4:38 PM Changeset in webkit [94989] by
-
- 4 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=67970
Add unprefixed border-image property.
Reviewed by Beth Dakin.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- 4:32 PM Changeset in webkit [94988] by
-
- 3 edits2 adds in trunk
REGRESSION: Moving up doesn't work in some cases
https://bugs.webkit.org/show_bug.cgi?id=67522
Reviewed by Eric Seidel.
Source/WebCore:
The bug was caused by previousLinePosition's attempting to obtain the last root line box using
a position at minCaretOffset (which is, in practice, located at the beginning of wrapped lines).
Fix the bug by calling maxCaretOffset instead. Because isCandidate returns false at (br, 1),
use the positionBeforeNode for br elements.
Test: editing/selection/move-up-into-wrapped-line.html
- editing/visible_units.cpp:
(WebCore::previousLinePosition):
LayoutTests:
Add a test to move caret upwards from an empty line below wrapped lines.
WebKit used to skip wrapped lines and placed caret at the beginning of the first of those wrapped lines
instead of before the last.
- editing/selection/move-up-into-wrapped-line-expected.txt: Added.
- editing/selection/move-up-into-wrapped-line.html: Added.
- 4:14 PM Changeset in webkit [94987] by
-
- 2 edits in trunk/Source/JavaScriptCore
Broken Build for ARM - lshift32() needs TrustedImm32 arg
https://bugs.webkit.org/show_bug.cgi?id=67965
Change lshift32(16, ARMRegisters::S1); to lshift32(TrustedImm32(16), ARMRegisters::S1);
Reviewed by Anders Carlsson.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch16):
- 3:48 PM Changeset in webkit [94986] by
-
- 3 edits in trunk/Source/WebCore
Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*.
https://bugs.webkit.org/show_bug.cgi?id=67947
Reviewed by Adam Barth.
The changes are tested by compiling and added compile asserts to do some verification as well.
- platform/CrossThreadCopier.cpp:
Added some compile asserts to verify various match and non-matches for CrossThreadCopier.
- platform/CrossThreadCopier.h:
Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr.
Added a compile assert to verify that only one of the typedefs did anything.
(CrossThreadCopierBase<false, true, T>::copy): Remove "get" as it is unnecessary.
It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently
convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method.
- 3:43 PM Changeset in webkit [94985] by
-
- 2 edits in trunk/Source/JavaScriptCore
Broken ARM build - missing semicolon in JavaScriptCore/assembler/MacroAssemblerARM.h
https://bugs.webkit.org/show_bug.cgi?id=67961
Added missing semicolon.
Reviewed by Ryosuke Niwa.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch16):
- 3:43 PM Changeset in webkit [94984] by
-
- 2 edits in trunk/Source/WebCore
Address lifetime issues in OfflineAudioDestinationNode
https://bugs.webkit.org/show_bug.cgi?id=67949
Reviewed by Kenneth Russell.
No new tests. This does not change JavaScript API.
- webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::render):
(WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch):
- 3:21 PM Changeset in webkit [94983] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r94976.
http://trac.webkit.org/changeset/94976
https://bugs.webkit.org/show_bug.cgi?id=67953
Broke a bunch of security/load& tests (Requested by rniwa on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-12
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::pathToLocalResource):
- 3:19 PM Changeset in webkit [94982] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Prevent a crash when tearing down an ImageBuffer that was not successfully initialized.
https://bugs.webkit.org/show_bug.cgi?id=67944
Patch by Jeff Timanus <twiz@chromium.org> on 2011-09-12
Reviewed by Stephen White.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::~ImageBuffer):
- 3:17 PM Changeset in webkit [94981] by
-
- 24 edits in trunk/Source
Update RegExp and related classes to use 8 bit strings when available
https://bugs.webkit.org/show_bug.cgi?id=67337
Source/JavaScriptCore:
Modified both the Yarr interpreter and JIT to handle 8 bit subject strings.
The code paths are triggered by the UString::is8bit() method which currently
returns false. Implemented JIT changes for all current architectures.
Tested X86_64 and ARM v7.
This includes some code that will likely change as we complete the
8 bit string changes. This includes the way the raw buffer pointers
are accessed as well as replacing the CharAccess class with a
string interator returned from UString.
Fixed build breakage in testRegExp.cpp due to globalObject construction
changes.
Reviewed by Gavin Barraclough.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- testRegExp.cpp:
(GlobalObject::finishCreation):
(GlobalObject::GlobalObject):
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::baseIndexTransfer32):
- assembler/ARMAssembler.h:
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::ubfx):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp12Reg40Imm3Reg4Imm20Imm5):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::branch8):
(JSC::MacroAssemblerARM::branch16):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load8):
(JSC::MacroAssemblerARMv7::branch16):
(JSC::MacroAssemblerARMv7::branch8):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load8):
(JSC::MacroAssemblerMIPS::branch8):
(JSC::MacroAssemblerMIPS::branch16):
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::branch8):
(JSC::MacroAssemblerSH4::branch16):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load8):
(JSC::MacroAssemblerX86Common::branch16):
(JSC::MacroAssemblerX86Common::branch8):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::extub):
(JSC::SH4Assembler::printInstr):
- assembler/X86Assembler.h:
(JSC::X86Assembler::cmpw_ir):
(JSC::X86Assembler::movzbl_mr):
- runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::compileIfNecessary):
(JSC::RegExp::match):
(JSC::RegExp::matchCompareWithInterpreter):
- runtime/RegExp.h:
- runtime/UString.h:
(JSC::UString::is8Bit):
- yarr/Yarr.h:
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::CharAccess::CharAccess):
(JSC::Yarr::Interpreter::CharAccess::~CharAccess):
(JSC::Yarr::Interpreter::CharAccess::operator[]):
(JSC::Yarr::Interpreter::InputStream::InputStream):
(JSC::Yarr::Interpreter::Interpreter):
(JSC::Yarr::interpret):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::readCharacter):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateDotStarEnclosure):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):
(JSC::Yarr::jitCompile):
(JSC::Yarr::execute):
- yarr/YarrJIT.h:
(JSC::Yarr::YarrCodeBlock::has8BitCode):
(JSC::Yarr::YarrCodeBlock::has16BitCode):
(JSC::Yarr::YarrCodeBlock::set8BitCode):
(JSC::Yarr::YarrCodeBlock::set16BitCode):
(JSC::Yarr::YarrCodeBlock::execute):
- yarr/YarrParser.h:
(JSC::Yarr::Parser::Parser):
Source/WebCore:
Updated call to match to use UString& instead of UChar*.
Reviewed by Gavin Barraclough.
No new tests, Covered by existing tests.
- platform/text/RegularExpression.cpp:
(WebCore::RegularExpression::match):
- 2:52 PM Changeset in webkit [94980] by
-
- 6 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=67898
REGRESSION(r94900): fast/images/support-broken-image-delegate.html fails on Mac
Reviewed by Simon Fraser.
Source/WebCore:
New function willPaintBrokenImage() returns true when there has been an error
loading the image and the broken image icon will be used in its place. This is
necessary since it is possible to have an error loading an image and to NOT use
the broken image icon.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::willPaintBrokenImage):
- loader/cache/CachedImage.h:
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
LayoutTests:
- platform/mac/Skipped:
- 2:41 PM Changeset in webkit [94979] by
-
- 9 edits in trunk/Source/WebKit2
2011-09-12 Igor Oliveira <igor.oliveira@openbossa.org>
[Qt] [WK2] implement support to upload files in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67228
This patch implements support to upload files in the Desktop Qt WebKit2 implementation.
Reviewed by Andreas Kling.
- Shared/WebOpenPanelParameters.h: (WebKit::WebOpenPanelParameters::selectedFileNames):
- UIProcess/API/qt/qdesktopwebview.cpp: (QDesktopWebViewPrivate::chooseFiles): (QDesktopWebViewPrivate::onOpenPanelFilesSelected): (QDesktopWebViewPrivate::onOpenPanelFinished):
- UIProcess/API/qt/qdesktopwebview_p.h:
- UIProcess/qt/ClientImpl.cpp:
qt_wk_runOpenPanel supports single and multiple files selection.
(qt_wk_runOpenPanel):
- UIProcess/qt/ClientImpl.h:
- UIProcess/qt/QtWebPageProxy.cpp: (QtWebPageProxy::init):
- UIProcess/qt/TouchViewInterface.h: (WebKit::TouchViewInterface::chooseFiles):
- UIProcess/qt/ViewInterface.h:
- 2:11 PM Changeset in webkit [94978] by
-
- 10 edits1 delete in trunk/Tools
Rubber-stamped by Adam Barth.
Remove the "the tree is burning!" warning previously shown
when landing patches. It was a dream. But it's just noise now.
Some bots will require a restart to notice the removal of the option
so I've left the --ignore-builders option in for now.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/steps/init.py:
- Scripts/webkitpy/tool/steps/commit.py:
- Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
- Scripts/webkitpy/tool/steps/postdiffforrevert.py:
- 2:05 PM Changeset in webkit [94977] by
-
- 3 edits in trunk/LayoutTests
Fix a test added by r94966 to work on Mac.
- fast/events/selectstart-by-arrow-keys.html:
- platform/chromium/test_expectations.txt:
- 1:54 PM Changeset in webkit [94976] by
-
- 2 edits in trunk/Tools
[NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
https://bugs.webkit.org/show_bug.cgi?id=65781
Reviewed by Ryosuke Niwa.
Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
to resolve the passed in url relative to the absolute url for the test.
I believe this is a better approach than the on used in the Qt and Chromium DRT's
(which resolves the path relative to the built location of the DRT executable)
and we should move this new code into a shared location in a follow-up patch.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::pathToLocalResource):
- 1:30 PM Changeset in webkit [94975] by
-
- 37 edits3 adds in trunk
[chromium] Move contents texture manager from LayerRendererChromium to CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=67440
Reviewed by Kenneth Russell.
This moves the contents TextureManager over to the CCLayerTreeHost, where it belongs, and adds in a commit path
to make sure that textures are deleted even if the page is not visible. This move also removed the need for
LayerRendererChromium's CCLayerTreeHost pointer, so I removed that as well. That meant moving the
layerTreeAsText() logic over to the CCLayerImpl side, which is where it really belonged anyway.
Covered by existing compositing/ tests and
platform/chromium/compositor/lost-compositor-context-with-rendersurface.html
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::setContentsTextureMemoryUseBytes):
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):
(WebCore::TextureManager::lowLimitBytes):
- platform/graphics/chromium/TextureManager.h:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTextures):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::contentsTextureManager):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setVisible):
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
- 1:15 PM Changeset in webkit [94974] by
-
- 2 edits in trunk/LayoutTests
2011-09-12 Nate Chapin <Nate Chapin>
Fix up duplicate expectations and add expected failure
for selectstart-by-arrow-keys.html for chromium mac.
- platform/chromium/test_expectations.txt:
- 1:06 PM Changeset in webkit [94973] by
-
- 3 edits in trunk/Tools
Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
https://bugs.webkit.org/show_bug.cgi?id=67530
Reviewed by Adam Barth.
I believe I've fixed the bug in the original patch which prompted the rollout.
The previous patch was using the wrong deadline for the initial read,
subtracting time.time() twice from the deadline value.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
- 1:05 PM Changeset in webkit [94972] by
-
- 20 edits1 delete in trunk/LayoutTests
Rebaseline for r94703.
https://bugs.webkit.org/show_bug.cgi?id=67945
Patch by David Reveman <reveman@chromium.org> on 2011-09-12
Reviewed by James Robinson.
- platform/chromium-gpu-cg-mac/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-gpu-cg-mac/compositing/flat-with-transformed-child-expected.png:
- platform/chromium-gpu-cg-mac/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-cg-mac/compositing/reflections/nested-reflection-transformed-expected.png:
- platform/chromium-gpu-cg-mac/compositing/reflections/nested-reflection-transformed2-expected.png:
- platform/chromium-gpu-cg-mac/compositing/reflections/reflection-in-composited-expected.png:
- platform/chromium-gpu-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png:
- platform/chromium-gpu-cg-mac/media/video-layer-crash-expected.png:
- platform/chromium-gpu-cg-mac/media/video-transformed-expected.png:
- platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-gpu-win/compositing/flat-with-transformed-child-expected.png:
- platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png:
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png:
- platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.png:
- platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png:
- platform/chromium-gpu-win/media/video-layer-crash-expected.png:
- platform/chromium-gpu-win/media/video-transformed-expected.png:
- platform/chromium/test_expectations.txt:
- platform/mac-snowleopard/media/video-layer-crash-expected.txt: Removed.
- 1:05 PM Porting Macros plan edited by
- (diff)
- 12:53 PM Changeset in webkit [94971] by
-
- 7 edits in trunk/Source/WebKit/chromium
[chromium] Add GraphicsContext3DPrivate:createGraphicsContextForAnotherThread
https://bugs.webkit.org/show_bug.cgi?id=67832
The compositor thread needs to create a GraphicsContext3D without
actually making it current. In previous attempts at doing this, we
modified all graphics3D creation to not make the contexts current, but
this prove to be shockingly fragile. Since this is a very
Chromium-specific behavior, this patch makes creationForAnotherThread a
method on the private GraphicsContext3D interface.
GraphicsContext3D::create behaves as usual.
Reviewed by Kenneth Russell.
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextForAnotherThread):
(WebCore::GraphicsContext3D::create):
- src/GraphicsContext3DPrivate.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):
- tests/MockGraphicsContext3DTest.cpp:
(TEST):
- 12:50 PM Changeset in webkit [94970] by
-
- 2 edits in trunk/LayoutTests
Implement a HashChangeEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67924
Unreviewed. Updating results which were forgotten.
- fast/dom/constructed-objects-prototypes-expected.txt:
- 12:35 PM WebKit Team edited by
- Adding myself to list of committers. (diff)
- 11:55 AM Changeset in webkit [94969] by
-
- 3 edits2 adds in trunk
DelayNode delay buffer is not correctly wrapping around
https://bugs.webkit.org/show_bug.cgi?id=67872
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webaudio/delaynode.html
- webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::process):
LayoutTests:
- webaudio/delaynode-expected.txt: Added.
- webaudio/delaynode.html: Added.
- 11:12 AM Changeset in webkit [94968] by
-
- 4 edits in trunk/Source/WebKit/qt
[Qt] Fix "Unmatched parentheses are deprecated." warnings
https://bugs.webkit.org/show_bug.cgi?id=67775
Reviewed by Zoltan Herczeg.
Modify function declarations to single line to make qmake happier.
- Api/qwebframe.h:
- Api/qwebpluginfactory.h:
- Api/qwebview.h:
- 11:00 AM Changeset in webkit [94967] by
-
- 6 edits in branches/chromium/874/Source/WebCore
Merge 94964 - [chromium] REGRESSION(94353): Compositor textures and resources leaked when tab closed that is not last tab in the process
https://bugs.webkit.org/show_bug.cgi?id=67816
Reviewed by Kenneth Russell.
We lack infrastructure to construct an automated test for this today. To test manually, open up a composited
page (like the poster circle), duplicate the tab many times, close all the duplicates, and verify that the
memory use returns to the single tab level.
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::setLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::clearRenderSurfacesRecursive):
(WebCore::CCLayerTreeHost::setRootLayer):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
TBR=jamesr@google.com
BUG=96288
Review URL: http://codereview.chromium.org/7873004
- 10:55 AM Changeset in webkit [94966] by
-
- 4 edits4 adds in trunk
Selectstart is not fired when selection was created by arrow keys.
https://bugs.webkit.org/show_bug.cgi?id=60430
Patch by Arko Saha <arko@motorola.com> on 2011-09-12
Reviewed by Ryosuke Niwa.
Source/WebCore:
Fire selectstart when a user starts extending the selection using arrow key.
Fixed by Arko Saha <arko@motorola.com> and Kaustubh Atrawalkar <Kaustubh Atrawalkar>
Tests: fast/events/selectstart-by-arrow-keys-prevent-default.html
fast/events/selectstart-by-arrow-keys.html
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::shouldChangeSelection):
(WebCore::FrameSelection::dispatchSelectStart):
- editing/FrameSelection.h:
LayoutTests:
- fast/events/selectstart-by-arrow-keys-expected.txt: Added.
- fast/events/selectstart-by-arrow-keys-prevent-default-expected.txt: Added.
- fast/events/selectstart-by-arrow-keys-prevent-default.html: Added.
- fast/events/selectstart-by-arrow-keys.html: Added.
- 10:54 AM Changeset in webkit [94965] by
-
- 5 edits4 adds in trunk/Source/WebKit/efl
Patch by Flavio Ceolin <flavio.ceolin@profusion.mobi> on 2011-09-12
Reviewed by Martin Robinson.
[EFL] Add custom network resource handler
https://bugs.webkit.org/show_bug.cgi?id=44759
This patch adds support for handling user-specific protocols.
It allows browsers to intercept and handle non-standard url schemes (such as preferences://)
allowing to load some resource from non-http/file storage, like a tar/zip/eet.
- CMakeListsEfl.txt:
- ewk/ewk_protocol_handler.cpp: Added.
- ewk/ewk_protocol_handler.h: Added.
- ewk/ewk_protocol_handler_soup.cpp: Added.
- ewk/ewk_protocol_handler_soup.h: Added.
- ewk/ewk_private.h:
- ewk/ewk_view.cpp:
(ewk_view_protocol_handler_set):
(ewk_view_protocol_handler_unset):
(ewk_view_protocol_handler_resource_get):
- ewk/ewk_view.h:
- 10:52 AM Changeset in webkit [94964] by
-
- 6 edits in trunk/Source/WebCore
[chromium] REGRESSION(94353): Compositor textures and resources leaked when tab closed that is not last tab in the process
https://bugs.webkit.org/show_bug.cgi?id=67816
Reviewed by Kenneth Russell.
We lack infrastructure to construct an automated test for this today. To test manually, open up a composited
page (like the poster circle), duplicate the tab many times, close all the duplicates, and verify that the
memory use returns to the single tab level.
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::setLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::clearRenderSurfacesRecursive):
(WebCore::CCLayerTreeHost::setRootLayer):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- 10:45 AM Changeset in webkit [94963] by
-
- 2 edits in trunk/LayoutTests
Chromium shadow-buffer-partial test change.
https://bugs.webkit.org/show_bug.cgi?id=67849
Patch by Ben Wagner <bungeman@chromium.org> on 2011-09-12
Reviewed by Kenneth Russell.
- platform/chromium/test_expectations.txt:
- 10:44 AM Rebaseline edited by
- (diff)
- 10:40 AM Changeset in webkit [94962] by
-
- 7 edits2 adds in trunk
Implement a HashChangeEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67924
Patch by Kentaro Hara <haraken@google.com> on 2011-09-12
Reviewed by Sam Weinig.
Source/WebCore:
The spec for the HashChangeEvent constructor is here:
http://www.whatwg.org/specs/web-apps/current-work/#hashchangeevent
Test: fast/events/constructors/hash-change-event-constructor.html
- bindings/generic/EventConstructors.h: Added a definition for the HashChangeEvent constructor.
- bindings/js/JSEventConstructors.cpp: Added #includes for HashChangeEvent.
- dom/HashChangeEvent.h: Added a definition for HashChangeEventInit.
(WebCore::HashChangeEventInit::HashChangeEventInit):
(WebCore::HashChangeEvent::create):
(WebCore::HashChangeEvent::HashChangeEvent):
- dom/HashChangeEvent.idl: Makes HashChangeEvent constructible.
LayoutTests:
hash-change-event-constructor.html checks the behavior of the HashChangeEvent constructor.
- fast/events/constructors/hash-change-event-constructor-expected.txt: Added.
- fast/events/constructors/hash-change-event-constructor.html: Added.
- platform/chromium/test_expectations.txt: Skipped hash-change-event-constructor.html, since V8 does not yet have the HashChangeEvent constructor.
- 10:31 AM Changeset in webkit [94961] by
-
- 2 edits in trunk/Source/WebCore
[skia] remove dead code, no functionality change
https://bugs.webkit.org/show_bug.cgi?id=67844
Reviewed by Kenneth Russell.
No new tests. just removing dead-code, existing tests apply
- platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):
- 10:02 AM Changeset in webkit [94960] by
-
- 2 edits in trunk/Source/WebKit2
[Qt]Style error fix.
Reviewed by Andreas Kling.
- UIProcess/qt/QtWebPageProxy.cpp:
- 9:46 AM Changeset in webkit [94959] by
-
- 2 edits in trunk/LayoutTests
2011-09-12 Nate Chapin <Nate Chapin>
Add video-zoom-controls.html to chromium expectations
for leopard gpu.
- platform/chromium/test_expectations.txt:
- 8:24 AM Changeset in webkit [94958] by
-
- 5 edits in trunk
Web Inspector: Runtime.callFunctionOn does not accept arguments that evaluate to false.
https://bugs.webkit.org/show_bug.cgi?id=67934
Reviewed by Tony Gentilcore.
Source/WebCore:
- inspector/InjectedScriptSource.js:
LayoutTests:
- inspector/runtime/runtime-setPropertyValue.html:
- 8:22 AM Changeset in webkit [94957] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: event dividers do not update timeline boundaries.
https://bugs.webkit.org/show_bug.cgi?id=67932
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._onLoadEventFired):
(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkTimeCalculator.prototype.updateBoundariesForEventTime):
- 7:54 AM Changeset in webkit [94956] by
-
- 1 edit in trunk/Tools/ChangeLog
Oops. Missed the reviewer in my the previous commit.
- 7:20 AM Changeset in webkit [94955] by
-
- 2 edits in trunk/Tools
[Qt][WK2] WebKitTestRunner does not produce crash logs
https://bugs.webkit.org/show_bug.cgi?id=67714
Added a simple way of generating backtrace on crash
to the web process. The implementation is similar what
we have in DRT. It depends on GNU libc functionality
so it is only enabled where we are running in such an environment.
- WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::printBacktrace):
(WTR::crashHandler):
(WTR::InjectedBundle::platformInitialize):
- 6:33 AM Changeset in webkit [94954] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Build fails after r94920 with strict compiler
https://bugs.webkit.org/show_bug.cgi?id=67928
Reviewed by Csaba Osztrogonác.
- wtf/RedBlackTree.h:
(WTF::RedBlackTree::insert): Remove dead variables updateStart and newSubTreeRoot.
- 4:09 AM Changeset in webkit [94953] by
-
- 5 edits in trunk
Implement a WebKitAnimationEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67922
Patch by Kentaro Hara <haraken@google.com> on 2011-09-12
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/webkit-animation-event-constructor.html
- bindings/v8/custom/V8EventConstructors.cpp: Added the WebKitAnimationEvent constructor.
- dom/WebKitAnimationEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled webkit-animation-event-constructor.html, since now V8 has a WebKitAnimationEvent constructor.
- platform/chromium/test_expectations.txt:
- 4:03 AM Changeset in webkit [94952] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed build fix after r94871.
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- wtf/FastMalloc.cpp:
- wtf/RefCountedLeakCounter.h:
- 2:48 AM Changeset in webkit [94951] by
-
- 3 edits in trunk/Source/WebCore
Shrink CanvasGradient for builds without ENABLE(DASHBOARD_SUPPORT).
https://bugs.webkit.org/show_bug.cgi?id=67916
Patch by Andreas Kling <kling@webkit.org> on 2011-09-12
Reviewed by Kenneth Rohde Christiansen.
- html/canvas/CanvasGradient.cpp:
(WebCore::CanvasGradient::CanvasGradient):
(WebCore::CanvasGradient::addColorStop):
- html/canvas/CanvasGradient.h:
- 1:45 AM Changeset in webkit [94950] by
-
- 2 edits in trunk/LayoutTests
[Qt][ARMv5] fast/events/constructors/progress-event-constructor.html is failing
https://bugs.webkit.org/show_bug.cgi?id=67927
Skip it.
- platform/qt-arm/Skipped:
- 1:09 AM Changeset in webkit [94949] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium test expectations.
- platform/chromium/test_expectations.txt: add fast/events/constructors/progress-event-constructor.html
- 12:21 AM Changeset in webkit [94948] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium test expectations.
- platform/chromium/test_expectations.txt: perf/show-hide-table-rows.html slow to timeout
- 12:14 AM Changeset in webkit [94947] by
-
- 3 edits2 adds in trunk
Characters beyond U+10000 should be deleted by one pressing delete key.
https://bugs.webkit.org/show_bug.cgi?id=40351
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-12
Reviewed by Kent Tamura.
Source/WebCore:
If a character is the trail part of unicode surrogate pair, the lead part of it
should also be deleted. Also, If in MacOSX, the deletion should honor Mac's behavior.
Test: editing/deleting/delete-surrogatepair.html
- rendering/RenderText.cpp:
(WebCore::RenderText::previousOffsetForBackwardDeletion):
Added if-macro to support chromium on mac, and added trail part check for unicode character.
LayoutTests:
Added deletion tests.
- editing/deleting/delete-surrogatepair-expected.txt: Added.
- editing/deleting/delete-surrogatepair.html: Added.
