⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 14, 2011:

11:55 PM Changeset in webkit [95174] by mdelaney@apple.com
  • 5 edits in trunk/Source/WebCore

Use isAcceleratedContext() on the GraphicsContext instead of flags in ImageBuffer
​https://bugs.webkit.org/show_bug.cgi?id=68137

Reviewed by Simon Fraser.

No new tests. No change in behavior.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::isAccelerated): Have all just query the context directly.
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere): just use isAccelerated directly

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer): Set isAcceleratedContext on the GraphicsContext instead of carrying the

bit around on the ImageBuffer itself.

(WebCore::ImageBuffer::copyNativeImage): Update the check. Same for all below...
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):

  • platform/graphics/skia/ImageBufferSkia.cpp: Set isAcceleratedContext on the GraphicsContext instead of carrying the

bit around on the ImageBuffer itself.

(WebCore::ImageBuffer::ImageBuffer): Remove m_acceleratesRendering flag and getter.

11:09 PM Changeset in webkit [95173] by keishi@webkit.org
  • 1 edit
    7 adds
    3 deletes in trunk/LayoutTests

[chromium] rebaseline expectations due to r95096, r95121, and r95129

  • platform/chromium-cg-mac-leopard/fast/borders/block-mask-overlay-image-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/borders/border-color-inherit-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/borders/inline-mask-overlay-image-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Removed.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
10:49 PM Changeset in webkit [95172] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG does not speculate aggressively enough on comparisons
​https://bugs.webkit.org/show_bug.cgi?id=68138

Reviewed by Oliver Hunt.

This is a 75% speed-up on Kraken/ai-astar. It's a 1% win on
V8 and an 8.5% win on Kraken. Neutral on SunSpider.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArray):
(JSC::DFG::SpeculativeJIT::shouldSpeculateObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateCell):

10:48 PM Changeset in webkit [95171] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Remove some dependencies of DRT for Android.
​https://bugs.webkit.org/show_bug.cgi?id=68126

Patch by Hao Zheng <​zhenghao@chromium.org> on 2011-09-14
Reviewed by Tony Chang.

We don't need mesa and TestNetscapePlugIn on Android, so remove them.
As copy_TNPI depends on TNPI, adding copy_TNPI is enough.

  • WebKit.gyp:
10:44 PM Changeset in webkit [95170] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG JIT does not leverage integer speculations on branches
​https://bugs.webkit.org/show_bug.cgi?id=68140

Reviewed by Oliver Hunt.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isStrictInt32):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10:26 PM Changeset in webkit [95169] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

libxml2 fragment parser loses prefix namespaces
​https://bugs.webkit.org/show_bug.cgi?id=66423

Source/WebCore:

This makes the loop over the elements outside of the context actually update the element it's processing.

Patch by Jeffrey Pfau <​jeffrey@endrift.com> on 2011-09-14
Reviewed by Eric Seidel.

Test: fast/parser/innerhtml-with-prefixed-elements.xhtml

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

LayoutTests:

Added a test to ensure that elements inserted when the prefix is already declared are inserted properly.

Patch by Jeffrey Pfau <​jeffrey@endrift.com> on 2011-09-14
Reviewed by Eric Seidel.

  • fast/parser/innerhtml-with-prefixed-elements.xhtml: Added.
  • platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
  • platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
10:17 PM Changeset in webkit [95168] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[n]stricteq code is bogus in JSValue32_64 JIT
​https://bugs.webkit.org/show_bug.cgi?id=68141

Reviewed by Sam Weinig.

The code tries to check for both ints or cells, but this check also
catches cases where values that are undefined, null, etc (probably
was incorrectly assuming cell was the 2nd highest tag?).

Also, there is no need not to handle int on the fast path.
stricteq is just a case of comparing the payloads, if we:

  • handle cases of differing tags on a slow path
  • handle doubles a slow path
  • handle both-are-string on a slow path
  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):

10:15 PM Changeset in webkit [95167] by mhahnenberg@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Make JSCell::toBoolean non-virtual
​https://bugs.webkit.org/show_bug.cgi?id=67727

Reviewed by Sam Weinig.

JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
before it was simply virtual and would crash if its implementation was called).
Its descendants in JSObject and JSString have also been made non-virtual. JSCell now
explicitly covers all cases of toBoolean, so having a virtual implementation of
JSCell::toBoolean is no longer necessary. This is part of a larger process of un-virtualizing JSCell.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSNotAnObject.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:

(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

  • runtime/StringObjectThatMasqueradesAsUndefined.h:
10:12 PM Changeset in webkit [95166] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

[V8] Null-check the v8::Context in
V8DOMWindowShell:namedItemAdded() before using it.
Also, add some logging to figure out how we're getting
into this bad state.
​https://bugs.webkit.org/show_bug.cgi?id=68099

Reviewed by Adam Barth.

No new tests, no known repro.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::namedItemAdded):

9:46 PM Changeset in webkit [95165] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Replace ENABLE_XHR_RESPONSE_BLOB preprocessor statements in IDL files with Conditional attribute
​https://bugs.webkit.org/show_bug.cgi?id=64960

Reviewed by Ryosuke Niwa.

  • xml/XMLHttpRequest.idl:
9:43 PM Changeset in webkit [95164] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] Add slow to debug version of styles-source-lines.html.

  • platform/chromium/test_expectations.txt:
9:33 PM Changeset in webkit [95163] by alexis.menard@openbossa.org
  • 4 edits in trunk

[Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.
​https://bugs.webkit.org/show_bug.cgi?id=68114

Reviewed by Kenneth Rohde Christiansen.

.:

Replace QT_GCC_X variables, they have been removed in Qt5. It was
actually wrong to use them because they tell about which GCC version
Qt has been compiled, not the current version of GCC use to build webkit.
I use gcc -dumpversion to get it.

  • Source/WebKit.pri:

Source/JavaScriptCore:

Use the new GCC_X variables defined in WebKit.pri to replace
the usage of QT_GCC_X.

9:27 PM Changeset in webkit [95162] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r95145.
​http://trac.webkit.org/changeset/95145
​https://bugs.webkit.org/show_bug.cgi?id=68139

The GTK+ build is working now, so revert this trial build fix.
(Requested by mrobinson on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-14

  • GNUmakefile.list.am:
9:24 PM Changeset in webkit [95161] by commit-queue@webkit.org
  • 61 edits in trunk/LayoutTests

Fix tests made trivial by the bugfix to 27895, by removing leading punctuation
which would cause early truncation of the page snippet.

​https://bugs.webkit.org/show_bug.cgi?id=27895

Patch by Tom Sepez <​tsepez@chromium.org> on 2011-09-14
Reviewed by Adam Barth.

  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char.html:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event.html:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location.html:
  • http/tests/security/xssAuditor/dom-write-URL.html:
  • http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt:
  • http/tests/security/xssAuditor/dom-write-innerHTML.html:
  • http/tests/security/xssAuditor/dom-write-location-inline-event.html:
  • http/tests/security/xssAuditor/dom-write-location-javascript-URL.html:
  • http/tests/security/xssAuditor/dom-write-location.html:
  • http/tests/security/xssAuditor/full-block-get-from-iframe.html:
  • http/tests/security/xssAuditor/full-block-javascript-link.html:
  • http/tests/security/xssAuditor/full-block-link-onclick.html:
  • http/tests/security/xssAuditor/full-block-post-from-iframe.html:
  • http/tests/security/xssAuditor/full-block-script-tag.html:
  • http/tests/security/xssAuditor/get-from-iframe.html:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html:
  • http/tests/security/xssAuditor/img-onerror-tricky.html:
  • http/tests/security/xssAuditor/javascript-link-null-char.html:
  • http/tests/security/xssAuditor/javascript-link-one-plus-one.html:
  • http/tests/security/xssAuditor/javascript-link.html:
  • http/tests/security/xssAuditor/link-onclick-ampersand.html:
  • http/tests/security/xssAuditor/link-onclick-control-char.html:
  • http/tests/security/xssAuditor/link-onclick-entities.html:
  • http/tests/security/xssAuditor/link-onclick-null-char.html:
  • http/tests/security/xssAuditor/link-onclick.html:
  • http/tests/security/xssAuditor/link-opens-new-window.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header.html:
  • http/tests/security/xssAuditor/open-attribute-body.html:
  • http/tests/security/xssAuditor/open-event-handler-iframe.html:
  • http/tests/security/xssAuditor/post-from-iframe.html:
  • http/tests/security/xssAuditor/property-escape-comment.html:
  • http/tests/security/xssAuditor/property-escape-entity.html:
  • http/tests/security/xssAuditor/property-escape-noquotes-expected.txt:
  • http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt:
  • http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html:
  • http/tests/security/xssAuditor/property-escape-noquotes.html:
  • http/tests/security/xssAuditor/property-escape-quote.html:
  • http/tests/security/xssAuditor/property-escape.html:
  • http/tests/security/xssAuditor/property-inject-expected.txt:
  • http/tests/security/xssAuditor/property-inject.html:
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash.html:
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html:
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char.html:
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html:
  • http/tests/security/xssAuditor/script-tag-control-char.html:
  • http/tests/security/xssAuditor/script-tag-entities.html:
  • http/tests/security/xssAuditor/script-tag-null-char.html:
  • http/tests/security/xssAuditor/script-tag-open-redirect.html:
  • http/tests/security/xssAuditor/script-tag-post-control-char.html:
  • http/tests/security/xssAuditor/script-tag-post-null-char.html:
  • http/tests/security/xssAuditor/script-tag-post.html:
  • http/tests/security/xssAuditor/script-tag-redirect.html:
  • http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html:
  • http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding.html:
  • http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode.html:
  • http/tests/security/xssAuditor/script-tag.html:
  • http/tests/security/xssAuditor/xss-protection-parsing-01.html:
9:15 PM Changeset in webkit [95160] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Make WEB_AUDIO conditional and fix the build when disabled
​https://bugs.webkit.org/show_bug.cgi?id=68107

Patch by Peter Beverloo <​peter@chromium.org> on 2011-09-14
Reviewed by Kenneth Russell.

  • features.gypi:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::audioSourceProvider):

  • src/WebMediaPlayerClientImpl.h:
9:08 PM Changeset in webkit [95159] by commit-queue@webkit.org
  • 3 edits in trunk/Websites/bugs.webkit.org

PrettyPatch should handle "delta" patch mechanism in git binary patches
​https://bugs.webkit.org/show_bug.cgi?id=67628

Git patches are encoded using two mechanisms - "literal" and "delta".
For details of these mechanisms, see the function emit_binary_diff_body
in the git source file diff.c (​https://github.com/git/git/blob/master/diff.c).

When determining if a binary file patch is an image or not we should accept
both literal and delta patch encodings.

When reconstructing the images from the patches, if we have a delta patch
we may download the previous revision from svn.webkit.org to get the image data.

Patch by Ben Wells <​benwells@chromium.org> on 2011-09-14
Reviewed by Adam Roben.

  • PrettyPatch/PrettyPatch.rb:
  • PrettyPatch/PrettyPatch_test.rb:
9:06 PM Changeset in webkit [95158] by commit-queue@webkit.org
  • 9 edits
    25 adds in trunk

Chromium: Add a layer for rubber-band overhang painting to the hardware path.
​https://bugs.webkit.org/show_bug.cgi?id=66969

Also, add layout tests for rubber-band overhang drawing for compositing path.

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-09-14
Reviewed by James Robinson.

  • page/FrameView.cpp:

(WebCore::FrameView::layerForOverhangAreas):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::layerForOverhangAreas):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::paintContents):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::destroyRootLayer):

  • rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::layerForOverhangAreas):

8:28 PM Changeset in webkit [95157] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

[v8] Improve performance of typed array copy constructor taking Array
​https://bugs.webkit.org/show_bug.cgi?id=68015

Patch by Ulan Degenbaev <​ulan@chromium.org> on 2011-09-14
Reviewed by Kenneth Russell.

Invoke the 'set' method of the constructed array instead of
copying the elements of the source array one by one.

Copy constructor tests already exist.

  • ../../Source/WebCore/WebCore.gypi:
  • ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Added.
  • ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
8:04 PM Changeset in webkit [95156] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Return correct value for getContextAttributes().preserveDrawingBuffer
​https://bugs.webkit.org/show_bug.cgi?id=68082

Patch by John Bauman <​jbauman@chromium.org> on 2011-09-14
Reviewed by Kenneth Russell.

WebKit::WebGraphicsContext3D::Attributes doesn't save
preserveDrawingBuffer, so that has to be saving in
GraphicsContext3DPrivate.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):

  • src/GraphicsContext3DPrivate.h:
8:01 PM Changeset in webkit [95155] by levin@chromium.org
  • 2 edits
    1 copy
    3 moves
    2 adds
    1 delete in trunk/LayoutTests

[chromium] rebaselines due to r95096, and r95121.

  • platform/chromium-cg-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-expected.txt.
  • platform/chromium-cg-mac-leopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
  • platform/chromium-cg-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/svg/css/getComputedStyle-basic-expected.txt.
  • platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
  • platform/chromium-win-xp/svg/as-border-image/svg-as-border-image-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt:
7:53 PM Changeset in webkit [95154] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Eliminate WebKit2 compilation warnings.
​https://bugs.webkit.org/show_bug.cgi?id=65025

Warnings found with gcc on linux.

Patch by Wajahat Siddiqui <​mdwajahatali.siddiqui@motorola.com> on 2011-09-14
Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::~ArgumentEncoder):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):

7:40 PM Changeset in webkit [95153] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Port MachineStackMarker to Windows ARM and MIPS
​https://bugs.webkit.org/show_bug.cgi?id=68068

Reviewed by Geoffrey Garen.

Use the correct memeber of the CONTEXT struct for the stackpointer for CPU(ARM) and CPU(MIPS).
Only query CONTEXT_INTEGER and CONTEXT_CONTROL, since CONTEXT_SEGMENTS isn't defined for
CPU(ARM) and CPU(MIPS) and the stackpointer is defined in the CONTEXT_CONTROL section for
CPU(ARM), CPU(X86) and CPU(X86_64) and in the CONTEXT_INTEGER section for CPU(MIPS).

  • heap/MachineStackMarker.cpp:

(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):

7:34 PM Changeset in webkit [95152] by jamesr@google.com
  • 8 edits in trunk/Source

Remove the dependency on GraphicsLayer from CCLayerTreeHost.
Move root layer management into the NonCompositedContentHost.
Have WebViewImpl create a NonCompositedContentHost explicitly.
​https://bugs.webkit.org/show_bug.cgi?id=67883

Patch by Antoine Labour <​piman@chromium.org> on 2011-09-14
Reviewed by James Robinson.

Source/WebCore:

Covered by compositing/ layout tests.

  • platform/graphics/chromium/NonCompositedContentHost.cpp:

(WebCore::NonCompositedContentHost::setRootLayer):
(WebCore::NonCompositedContentHost::setViewport):
(WebCore::NonCompositedContentHost::setVisible):
(WebCore::NonCompositedContentHost::clearRenderSurfacesRecursive):
(WebCore::NonCompositedContentHost::invalidateRect):

  • platform/graphics/chromium/NonCompositedContentHost.h:

(WebCore::NonCompositedContentHost::topLevelRootLayer):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::rootLayer):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::updateLayerTreeViewport):
(WebKit::WebViewImpl::setVisibilityState):

  • src/WebViewImpl.h:
7:26 PM Changeset in webkit [95151] by commit-queue@webkit.org
  • 6 edits in trunk

MediaStream API: Change PeerConnection constructor name to webkitPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=67843

Patch by Henrik Grunell <​grunell@google.com> on 2011-09-14
Reviewed by Tony Gentilcore.

Tests for the MediaStream API will be provided by the bug 56587, pending enough landed code.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPeerConnectionEnabled):

  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/call-a-constructor-as-a-function.html:
  • platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
7:12 PM Changeset in webkit [95150] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make sure to GC decoded images that are only used with WebGL
​https://bugs.webkit.org/show_bug.cgi?id=67899

Patch by John Bauman <​jbauman@chromium.org> on 2011-09-14
Reviewed by James Robinson.

Tell CachedImage that the WebGL image was drawn so WebGL-only
content will have decoded images collected.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::extractImageData):

6:46 PM Changeset in webkit [95149] by levin@chromium.org
  • 19 edits
    3 copies
    9 adds in trunk/LayoutTests

[chromium] rebaselines due to r95096, r95121, and r95129.

  • platform/chromium-cg-mac-leopard/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • platform/chromium-cg-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
  • platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
  • platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.txt: Added.
  • platform/chromium-cg-mac/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
  • platform/chromium-linux/fast/borders/border-image-border-radius-expected.png:
  • platform/chromium-linux/fast/borders/border-image-massive-scale-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/fast/borders/border-image-01-expected.png:
  • platform/chromium-win/fast/borders/border-image-border-radius-expected.png:
  • platform/chromium-win/fast/borders/border-image-longhand-expected.png:
  • platform/chromium-win/fast/borders/border-image-massive-scale-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-massive-scale-expected.txt: Added.
  • platform/chromium-win/fast/borders/border-image-repeat-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-win/fast/borders/border-image-slices-expected.png:
  • platform/chromium-win/fast/borders/border-image-source-expected.png:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
6:32 PM Changeset in webkit [95148] by jamesr@google.com
  • 19 edits in trunk/Source/WebCore

Added a pure virtual class CCLayerDelegate which helps to isolate
the chromium compositor from the rest of WebCore, and aids unit
testing by being easily mockable. The compositor layers no longer
directly see instances of GraphicsLayerChromium, instead they use
this interface.
​https://bugs.webkit.org/show_bug.cgi?id=67750

Patch by Antoine Labour <​piman@chromium.org> on 2011-09-14
Reviewed by James Robinson.

No new tests: changes already covered by existing compositing layout
tests.

  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::CanvasLayerChromium):

  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerChromium::create):
(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::drawsContent):

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::getDrawsContent):
(WebCore::GraphicsLayerChromium::getPreserves3D):
(WebCore::GraphicsLayerChromium::paintingGoesToWindow):
(WebCore::GraphicsLayerChromium::doPaintGraphicsLayerContents):
(WebCore::GraphicsLayerChromium::notifySyncRequired):

  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::create):
(WebCore::ImageLayerChromium::ImageLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::create):
(WebCore::LayerChromium::LayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::CCLayerDelegate::~CCLayerDelegate):
(WebCore::LayerChromium::preserves3D):
(WebCore::LayerChromium::setOwner):

  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::create):
(WebCore::PluginLayerChromium::PluginLayerChromium):

  • platform/graphics/chromium/PluginLayerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::create):
(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::create):
(WebCore::WebGLLayerChromium::WebGLLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.h:
6:24 PM Changeset in webkit [95147] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG JIT always speculates that ValueAdd is a numeric addition
​https://bugs.webkit.org/show_bug.cgi?id=67956

Reviewed by Geoffrey Garen.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownNotNumber):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::shouldSpeculateNumber):

6:22 PM Changeset in webkit [95146] by levin@chromium.org
  • 7 edits
    1 move
    21 adds
    8 deletes in trunk/LayoutTests

[chromium] rebaselines due to r95121, r95070, and r95099.

  • platform/chromium-cg-mac-leopard/fast/borders/border-image-border-radius-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-cg-mac-leopard/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-cg-mac-leopard/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-cg-mac/fast/borders/bidi-002-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/bidi-009a-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/bidi-012-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/block-mask-overlay-image-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/border-color-inherit-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/border-image-border-radius-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/border-image-massive-scale-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-cg-mac/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-cg-mac/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-cg-mac/fast/borders/inline-mask-overlay-image-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/outline-alpha-block-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/outline-alpha-inline-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/rtl-border-01-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/rtl-border-02-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/rtl-border-03-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/rtl-border-04-expected.png: Added.
  • platform/chromium-cg-mac/fast/borders/rtl-border-05-expected.png: Added.
  • platform/chromium-cg-mac/fast/writing-mode/border-image-horizontal-bt-expected.png: Added.
  • platform/chromium-cg-mac/fast/writing-mode/border-image-vertical-lr-expected.png: Added.
  • platform/chromium-cg-mac/fast/writing-mode/border-image-vertical-rl-expected.png: Added.
  • platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-image-scrambled-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-image-scrambled-expected.txt: Removed.
  • platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.png: Removed.
  • platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.txt: Removed.
  • platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.png: Removed.
  • platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.txt: Removed.
  • platform/chromium-win/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-scrambled-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.txt.
5:50 PM Changeset in webkit [95145] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Stop building BinarySemaphore to see if that's what's breaking the GTK+ build.

  • GNUmakefile.list.am:
5:48 PM Changeset in webkit [95144] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

This is getting old. Yet another build fix attempt.

5:39 PM Changeset in webkit [95143] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Yet another build fix attempt.

5:31 PM Changeset in webkit [95142] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

How I &quot;love&quot; Visual Studio...

Try to fix build again.

5:26 PM Changeset in webkit [95141] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix Windows build.

5:15 PM Changeset in webkit [95140] by andersca@apple.com
  • 6 edits
    3 copies in trunk/Source/JavaScriptCore

Add BinarySemaphore class from WebKit2 to WTF
​https://bugs.webkit.org/show_bug.cgi?id=68132

Reviewed by Sam Weinig.

Update build systems.

  • wtf/threads: Added.
  • wtf/threads/BinarySemaphore.cpp: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.cpp.
  • wtf/threads/BinarySemaphore.h: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.h.
  • wtf/threads/win: Added.
  • wtf/threads/win/BinarySemaphoreWin.cpp: Copied from Source/WebKit2/Platform/CoreIPC/win/BinarySemaphoreWin.cpp.
4:55 PM Changeset in webkit [95139] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for Interpreter.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

4:44 PM Changeset in webkit [95138] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix GTK+ build.

  • GNUmakefile.list.am:
4:27 PM Changeset in webkit [95137] by andersca@apple.com
  • 1 edit
    2 adds in trunk/Source/JavaScriptCore

Add wtf/threads and wtf/threads/win, so we can be sure that the EWS
bots can correctly build the patch in ​https://bugs.webkit.org/show_bug.cgi?id=68132

Rubber-stamped by Sam Weinig.

  • wtf/threads: Added.
  • wtf/threads/win: Added.
4:06 PM Changeset in webkit [95136] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG JIT should not speculate integer if the value is always going to be
used as a double anyway
​https://bugs.webkit.org/show_bug.cgi?id=68127

Reviewed by Oliver Hunt.

Added a ValueToDouble node, which is a variant of ValueToNumber that
hints that it will only be used as a double and never as an integer.
Thus, it turns off integer speculation even if the value profiler
told us that the value source is an int. The logic for converting a
ValueToNumber into a ValueToDouble is found in Propagator.

This appears to be a 22% speed-up in imaging-darkroom.

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

4:01 PM Changeset in webkit [95135] by jamesr@google.com
  • 18 edits in trunk/Source/WebCore

[chromium] LayerRendererChromium shouldn't be RefCounted
​https://bugs.webkit.org/show_bug.cgi?id=68121

Reviewed by Kenneth Russell.

LayerRendererChromium is owned exclusively by CCLayerTreeHostImpl, so there's no reason to have it be
refcounted. Making it an OwnPtr<> makes the lifecycle for these objects much cleaner and reduces the chance of
introducing accidental reference cycles. This also removes the LayerRendererChromium pointers from CCLayerImpls
since it only needed at draw time.

Covered by compositing/ tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::drawLayer):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::draw):

  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::draw):
(WebCore::CCLayerImpl::bindContentsTexture):
(WebCore::CCLayerImpl::drawDebugBorder):

  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::draw):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:
  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::cleanupResources):
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::draw):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:
4:00 PM Changeset in webkit [95134] by fpizlo@apple.com
  • 17 edits
    1 add in trunk/Source/JavaScriptCore

Tiered compilation heuristics do not account for value profile fullness
​https://bugs.webkit.org/show_bug.cgi?id=68116

Reviewed by Oliver Hunt.

Tiered compilation avoids invoking the DFG JIT if it finds that value
profiles contain insufficient information. Instead, it produces a
prediction from the current value profile, and then clears the value
profile. This allows the value profile to heat up from scratch for
some number of additional executions. The new profiles will then be
merged with the previous prediction. Once the amount of information
in predictions is enough according to heuristics in CodeBlock.cpp,
DFG optimization is allowed to proceed.

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::visitWeakReferences):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/CodeBlock.h:
  • bytecode/PredictedType.cpp:

(JSC::predictionToString):

  • bytecode/PredictedType.h:
  • bytecode/ValueProfile.cpp: Added.

(JSC::ValueProfile::computeStatistics):
(JSC::ValueProfile::computeUpdatedPrediction):

  • bytecode/ValueProfile.h:

(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::totalNumberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):
(JSC::getValueProfileBytecodeOffset):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::stronglyPredict):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

  • jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

3:44 PM Changeset in webkit [95133] by eric.carlson@apple.com
  • 9 edits in trunk/LayoutTests

Media element tests should look up controller element locations
​https://bugs.webkit.org/show_bug.cgi?id=68038

Get the position of controller elements from the shadow DOM.

Reviewed by Darin Adler.

  • media/audio-delete-while-slider-thumb-clicked.html:
  • media/audio-delete-while-step-button-clicked.html:
  • media/controls-drag-timebar.html:
  • media/controls-right-click-on-timebar.html:
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-zoomed.html:
  • media/video-volume-slider.html:
3:42 PM Changeset in webkit [95132] by tony@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Changed WebKit.gyp to use the new grit version of the scripts that handle
.pak files.
​https://bugs.webkit.org/show_bug.cgi?id=68013

Patch by Nebojsa Ciric <​cira@chromium.org> on 2011-09-14
Reviewed by Tony Chang.

  • DEPS:
  • WebKit.gyp:
3:37 PM Changeset in webkit [95131] by levin@chromium.org
  • 2 edits
    13 adds in trunk/LayoutTests

[chromium] Update baselines due to r95070 and r95099.

  • platform/chromium-cg-mac-leopard/fast/writing-mode/broken-ideographic-font-expected.png: Added.
  • platform/chromium-cg-mac/fast/writing-mode/broken-ideographic-font-expected.png: Added.
  • platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added.
  • platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.txt: Added.
  • platform/chromium-linux/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-scrambled-expected.txt: Added.
  • platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.txt: Added.
  • platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:31 PM Changeset in webkit [95130] by andersca@apple.com
  • 10 edits
    4 deletes in trunk/Source

Get rid of WebCoreViewFactory and its WebViewFactory subclass
​https://bugs.webkit.org/show_bug.cgi?id=68124

Reviewed by Sam Weinig.

../WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/mac/FrameSelectionMac.mm:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreViewFactory.h: Removed.
  • page/mac/WebCoreViewFactory.m: Removed.

../WebKit:

  • WebKit.xcodeproj/project.pbxproj:

../WebKit/mac:

  • WebCoreSupport/WebContextMenuClient.mm:
  • WebCoreSupport/WebViewFactory.h: Removed.
  • WebCoreSupport/WebViewFactory.mm: Removed.
  • WebView/WebFrameView.mm:

(-[WebFrameView initWithFrame:]):

3:24 PM Changeset in webkit [95129] by hyatt@apple.com
  • 8 edits
    6 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=52736

Tiles were not being properly centered within border image sides for the "repeat"
keyword. This patch fixes the buggy math behind the pattern tiling to actually get
the initial phases correct.

Source/WebCore:

Reviewed by Sam Weinig.

Added new tests in fast/borders and updated broken existing tests.

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

LayoutTests:

Reviewed by Sam Weinig.

  • fast/borders/border-image-massive-scale.html: Added.
  • fast/borders/border-image-scaled-gradient.html: Added.
  • platform/mac/fast/borders/border-image-massive-scale-expected.png: Added.
  • platform/mac/fast/borders/border-image-massive-scale-expected.txt: Added.
  • platform/mac/fast/borders/border-image-outset-expected.png:
  • platform/mac/fast/borders/border-image-outset-in-shorthand-expected.png:
  • platform/mac/fast/borders/border-image-outset-split-inline-expected.png:
  • platform/mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png:
  • platform/mac/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • platform/mac/fast/borders/border-image-scaled-gradient-expected.txt: Added.
  • platform/mac/fast/borders/border-image-side-reduction-expected.png:
3:14 PM Changeset in webkit [95128] by andersca@apple.com
  • 10 edits
    1 delete in trunk/Source/WebCore

Remove DocTypeStrings.gperf
​https://bugs.webkit.org/show_bug.cgi?id=68119

Reviewed by Sam Weinig.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/DocTypeStrings.gperf: Removed.
  • make-hash-tools.pl:
  • platform/HashTools.h:
3:04 PM Changeset in webkit [95127] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG should not speculate that the child of LogicalNot is a boolean if
predictions tell us otherwise
​https://bugs.webkit.org/show_bug.cgi?id=68118

Reviewed by Geoffrey Garen.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeLogicalNot):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

2:58 PM Changeset in webkit [95126] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Change mousedown events to keydown events, since eventSender.mouseDown
wasn't firing onmousedown events on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=67960

Patch by Jeremy Apthorp <​jeremya@chromium.org> on 2011-09-14
Reviewed by Adam Barth.

  • fullscreen/full-screen-remove-ancestor-during-transition.html:
2:39 PM Changeset in webkit [95125] by senorblanco@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp

Merge 94982 - [chromium] Prevent a crash when tearing down an ImageBuffer that was not successfully initialized.
​https://bugs.webkit.org/show_bug.cgi?id=67944

Patch by Jeff Timanus <​twiz@chromium.org> on 2011-09-12
Reviewed by Stephen White.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::~ImageBuffer):

TBR=​twiz@chromium.org
Review URL: ​http://codereview.chromium.org/7888057

2:39 PM Changeset in webkit [95124] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Address lifetime issues in OfflineAudioDestinationNode (take 2)
​https://bugs.webkit.org/show_bug.cgi?id=68111

Reviewed by Kenneth Russell.

No new tests. This fixes existing layout tests.

  • webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::startRendering):
(WebCore::OfflineAudioDestinationNode::render):

2:33 PM Changeset in webkit [95123] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/chromium

Fix Chromium build.

  • src/ResourceHandle.cpp:
2:29 PM Changeset in webkit [95122] by adachan@apple.com
  • 10 edits
    2 adds in trunk

Source/WebKit2: Implement WKBundleFrameCopyWebArchive().
​http://bugs.webkit.org/show_bug.cgi?id=67857

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyWebArchive): Call WebFrame::webArchiveData() and create a WKDataRef from the returned CFDataRef.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::webArchiveData): Add WebFrame::webArchiveData().

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getWebArchiveOfFrame): Move the logic to WebFrame::webArchiveData() and call that method here.

Tools: Add test for WKBundleFrameCopyWebArchive().
​https://bugs.webkit.org/show_bug.cgi?id=67857

Reviewed by Anders Carlsson.

  • TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
the returned data is a valid webarchive.
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST): Load simple.html in a WebView. Wait for it to finish loading, and then ask the
injected bundle for the webarchive and check the returned webarchive.

  • TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.

(TestWebKitAPI::WebArchiveTest::WebArchiveTest):
(TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
the web archive.

Add files to project.

  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2:15 PM Changeset in webkit [95121] by hyatt@apple.com
  • 91 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=68103

Centered portions of border images don't render correctly. Make the tile scale factor have to be
explicitly passed in and modify paintNinePieceImage to compute it for all sides. The attempts to
implicitly compute the scale for the pattern based off the source and destination rects just don't
work, since the center image rects don't provide the right information to be able to infer the
scale factor.

Reviewed by Sam Weinig.

Reset all the existing fast/borders pixel results to Lion for these changes.

Source/WebCore:

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawTiledImage):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):

LayoutTests:

  • platform/mac/fast/borders/bidi-002-expected.png:
  • platform/mac/fast/borders/bidi-009a-expected.png:
  • platform/mac/fast/borders/bidi-012-expected.png:
  • platform/mac/fast/borders/block-mask-overlay-image-expected.png:
  • platform/mac/fast/borders/border-antialiasing-expected.png:
  • platform/mac/fast/borders/border-color-inherit-expected.png:
  • platform/mac/fast/borders/border-fit-expected.png:
  • platform/mac/fast/borders/border-image-01-expected.png:
  • platform/mac/fast/borders/border-image-border-radius-expected.png:
  • platform/mac/fast/borders/border-image-longhand-expected.png:
  • platform/mac/fast/borders/border-image-omit-right-slice-expected.png:
  • platform/mac/fast/borders/border-image-outset-expected.png:
  • platform/mac/fast/borders/border-image-outset-in-shorthand-expected.png:
  • platform/mac/fast/borders/border-image-repeat-expected.png:
  • platform/mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/mac/fast/borders/border-image-scaled-expected.png:
  • platform/mac/fast/borders/border-image-scrambled-expected.png:
  • platform/mac/fast/borders/border-image-slices-expected.png:
  • platform/mac/fast/borders/border-image-source-expected.png:
  • platform/mac/fast/borders/border-radius-circle-expected.png:
  • platform/mac/fast/borders/border-radius-constraints-expected.png:
  • platform/mac/fast/borders/border-radius-different-width-001-expected.png:
  • platform/mac/fast/borders/border-radius-groove-01-expected.png:
  • platform/mac/fast/borders/border-radius-groove-02-expected.png:
  • platform/mac/fast/borders/border-radius-groove-03-expected.png:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.png:
  • platform/mac/fast/borders/border-radius-inline-flow-expected.png:
  • platform/mac/fast/borders/border-radius-inset-outset-expected.png:
  • platform/mac/fast/borders/border-radius-split-inline-expected.png:
  • platform/mac/fast/borders/border-radius-wide-border-01-expected.png:
  • platform/mac/fast/borders/border-radius-wide-border-02-expected.png:
  • platform/mac/fast/borders/border-radius-wide-border-03-expected.png:
  • platform/mac/fast/borders/border-radius-wide-border-04-expected.png:
  • platform/mac/fast/borders/border-styles-split-expected.png:
  • platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/mac/fast/borders/borderRadiusArcs01-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed01-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed02-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed03-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed04-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed05-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed06-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted01-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted02-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted03-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted04-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted05-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted06-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble01-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble02-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble03-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble04-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble05-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble06-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble07-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble08-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble09-expected.png:
  • platform/mac/fast/borders/borderRadiusGroove01-expected.png:
  • platform/mac/fast/borders/borderRadiusGroove02-expected.png:
  • platform/mac/fast/borders/borderRadiusInset01-expected.png:
  • platform/mac/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/mac/fast/borders/borderRadiusOutset01-expected.png:
  • platform/mac/fast/borders/borderRadiusRidge01-expected.png:
  • platform/mac/fast/borders/borderRadiusSolid01-expected.png:
  • platform/mac/fast/borders/borderRadiusSolid02-expected.png:
  • platform/mac/fast/borders/borderRadiusSolid03-expected.png:
  • platform/mac/fast/borders/borderRadiusSolid04-expected.png:
  • platform/mac/fast/borders/different-color-borders-expected.png:
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/mac/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/mac/fast/borders/mixed-border-styles-expected.png:
  • platform/mac/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/mac/fast/borders/mixed-border-styles-radius2-expected.png:
  • platform/mac/fast/borders/outline-alpha-block-expected.png:
  • platform/mac/fast/borders/outline-alpha-inline-expected.png:
  • platform/mac/fast/borders/outline-offset-min-assert-expected.png:
  • platform/mac/fast/borders/rtl-border-01-expected.png:
  • platform/mac/fast/borders/rtl-border-02-expected.png:
  • platform/mac/fast/borders/rtl-border-03-expected.png:
  • platform/mac/fast/borders/rtl-border-04-expected.png:
  • platform/mac/fast/borders/rtl-border-05-expected.png:
  • platform/mac/fast/borders/table-borders-expected.png:
  • platform/mac/fast/borders/webkit-border-radius-expected.png:
2:03 PM Changeset in webkit [95120] by andersca@apple.com
  • 9 edits in trunk/Source/WebCore

Get rid of ResourceHandle::bufferedData()
​https://bugs.webkit.org/show_bug.cgi?id=68112

Reviewed by David Hyatt.

ResourceHandle::bufferedData() was only implemented on Mac, and the support in the underlying
NSURLConnection class hasn't been there for several OS releases.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::resourceData):
(WebCore::ResourceLoader::addData):

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:
  • platform/network/curl/ResourceHandleCurl.cpp:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/qt/ResourceHandleQt.cpp:
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/win/ResourceHandleWin.cpp:
1:59 PM Changeset in webkit [95119] by Csaba Osztrogonác
  • 2 edits in trunk

[GTK] Unreviewed buildfix after r95107.

  • configure.ac:
1:58 PM Changeset in webkit [95118] by rniwa@webkit.org
  • 5 edits in trunk/Tools

committers.py should support multiple IRC nicknames
​https://bugs.webkit.org/show_bug.cgi?id=68110

Reviewed by Eric Seidel.

Add multiple IRC nickname support to committers.py

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/committers_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
1:51 PM Changeset in webkit [95117] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

REGRESSION: r95108 broke Qt Linux tests
​https://bugs.webkit.org/show_bug.cgi?id=68104

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-09-14
Reviewed by Csaba Osztrogonác.

No new tests.

Build fix for Qt tests broken in r95108.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):

  • bridge/qt/qt_runtime.h:
1:48 PM Changeset in webkit [95116] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix. Turn off tiered compilation.

  • wtf/Platform.h:
1:35 PM Changeset in webkit [95115] by fpizlo@apple.com
  • 14 edits
    2 adds in trunk/Source/JavaScriptCore

Prediction tracking is not precise enough
​https://bugs.webkit.org/show_bug.cgi?id=67993

Reviewed by Oliver Hunt.

Added a richer set of type predictions, including JSFinalObject, JSString,
object that is not a JSFinalObject or JSArray (ObjectOther), some object
but we don't or care know what kind (SomeObject), definitely an object,
cell that is not an object or JSString, an value that is none of the above
(so either Undefined or Null). Made the propagator and value profiler work
with the new types.

Performance is neutral, because the DFG JIT does not take advantage of this
new knowledge yet.

In the process of writing predictionToString() (which is now considerably
more complex) I decided to finally add a BoundsCheckedPointer, which
should come in handy in other places, like at least the OSR scratch buffer
and the CompactJITCodeMap. It's great for cases where you want to
do pointer arithmetic, you want to have assertions about the
pointer not going out of bounds, but you don't want to write those
assertions yourself.

This also required refactoring inherits(), since the ValueProfiler may
want to do the equivalent of inherits() but given two ClassInfo's.

(JSC::predictionToString):
(JSC::makePrediction):
(JSC::predictionFromValue):

  • bytecode/PredictedType.h:

(JSC::isCellPrediction):
(JSC::isObjectPrediction):
(JSC::isFinalObjectPrediction):
(JSC::isStringPrediction):
(JSC::mergePredictions):

  • bytecode/ValueProfile.h:

(JSC::ValueProfile::numberOfObjects):
(JSC::ValueProfile::numberOfFinalObjects):
(JSC::ValueProfile::numberOfStrings):
(JSC::ValueProfile::probabilityOfObject):
(JSC::ValueProfile::probabilityOfFinalObject):
(JSC::ValueProfile::probabilityOfString):
(JSC::ValueProfile::dump):
(JSC::ValueProfile::Statistics::Statistics):
(JSC::ValueProfile::computeStatistics):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::stronglyPredict):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGNode.h:

(JSC::DFG::Node::predict):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):

  • runtime/ClassInfo.h:

(JSC::ClassInfo::isSubClassOf):

  • runtime/JSObject.h:

(JSC::JSCell::inherits):

  • wtf/BoundsCheckedPointer.h: Added.

(WTF::BoundsCheckedPointer::BoundsCheckedPointer):
(WTF::BoundsCheckedPointer::operator=):
(WTF::BoundsCheckedPointer::operator+=):
(WTF::BoundsCheckedPointer::operator-=):
(WTF::BoundsCheckedPointer::operator+):
(WTF::BoundsCheckedPointer::operator-):
(WTF::BoundsCheckedPointer::operator++):
(WTF::BoundsCheckedPointer::operator--):
(WTF::BoundsCheckedPointer::operator<):
(WTF::BoundsCheckedPointer::operator<=):
(WTF::BoundsCheckedPointer::operator>):
(WTF::BoundsCheckedPointer::operator>=):
(WTF::BoundsCheckedPointer::operator==):
(WTF::BoundsCheckedPointer::operator!=):
(WTF::BoundsCheckedPointer::operator!):
(WTF::BoundsCheckedPointer::get):
(WTF::BoundsCheckedPointer::operator*):
(WTF::BoundsCheckedPointer::operator[]):
(WTF::BoundsCheckedPointer::strcat):
(WTF::BoundsCheckedPointer::validate):

  • wtf/CMakeLists.txt:
1:12 PM Changeset in webkit [95114] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[skia] fast/canvas/setWidthResetAfterForcedRender is flaky
​https://bugs.webkit.org/show_bug.cgi?id=67955

Reviewed by Stephen White.

When destroying an ImageBuffer due to a canvas resize, we weren't clearing the texture ID on the layer,
resulting in future compositor draw calls binding an invalid texture. This results in the test failing and
possibly drawing from a bad texture.

Covered by fast/canvas/setWidthResetAfterForcedRender.html in the GPU configuration.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::drawsContent)

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::~ImageBuffer):

1:05 PM Changeset in webkit [95113] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Web Process doesn't need a permission to look up WebProcess service any more
​https://bugs.webkit.org/show_bug.cgi?id=68101

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
1:02 PM Changeset in webkit [95112] by eric@webkit.org
  • 7 edits in trunk

Remove ENABLE_SVG_USE as <use> is required by HTML5
​https://bugs.webkit.org/show_bug.cgi?id=68019

Reviewed by Ryosuke Niwa.

I missed a couple uses of SVG_USE in my previous patch.

Source/WebCore:

  • dom/DOMImplementation.cpp:

(WebCore::isSVG10Feature):
(WebCore::isSVG11Feature):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):

  • svg/SVGUseElement.h:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
12:25 PM Changeset in webkit [95111] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

Update media-controls.js so it can find the timeline slider
​https://bugs.webkit.org/show_bug.cgi?id=68034

Don't assume that all elements in the media controller shadow DOM pseudo
elements are siblings.

Reviewed by Darin Adler.

  • media/media-controls.js:

(mediaConrolsElement):
(mediaControlsButtonCoordinates):

12:10 PM Changeset in webkit [95110] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

[Qt] Win32 builds with threads turned off
​https://bugs.webkit.org/show_bug.cgi?id=67864

Reviewed by Geoffrey Garen.

  • JavaScriptCore.pri: Link pthread library on Windows platform.
  • wtf/Platform.h: Enable multiple threads.
12:00 PM Changeset in webkit [95109] by jonlee@apple.com
  • 4 edits in trunk/Tools

Implement globalFlag for WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=68033
<rdar://problem/10119204>

Reviewed by Sam Weinig.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag

(WTR::LayoutTestController::globalFlag): simple getter
(WTR::LayoutTestController::setGlobalFlag): simple setter

11:55 AM Changeset in webkit [95108] by mhahnenberg@apple.com
  • 81 edits in trunk/Source

Unzip initialization lists and constructors in JSCell hierarchy (6/7)
​https://bugs.webkit.org/show_bug.cgi?id=67692

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::JSCallbackFunction):

  • API/JSCallbackFunction.h:

(JSC::JSCallbackFunction::create):

  • jsc.cpp:

(GlobalObject::create):
(GlobalObject::GlobalObject):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::ArrayConstructor):

  • runtime/ArrayConstructor.h:

(JSC::ArrayConstructor::create):

  • runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::BooleanConstructor):

  • runtime/BooleanConstructor.h:

(JSC::BooleanConstructor::create):

  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):

  • runtime/BooleanPrototype.h:

(JSC::BooleanPrototype::create):

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::DateConstructor):

  • runtime/DateConstructor.h:

(JSC::DateConstructor::create):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype):

  • runtime/DatePrototype.h:

(JSC::DatePrototype::create):

  • runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):

  • runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::ErrorConstructor):

  • runtime/ErrorConstructor.h:

(JSC::ErrorConstructor::create):

  • runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::FunctionConstructor):

  • runtime/FunctionConstructor.h:

(JSC::FunctionConstructor::create):

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):

  • runtime/FunctionPrototype.h:

(JSC::FunctionPrototype::create):

  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::create):

  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::finishCreation):

  • runtime/NativeErrorPrototype.h:

(JSC::NativeErrorPrototype::create):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::NumberConstructor):

  • runtime/NumberConstructor.h:

(JSC::NumberConstructor::create):

  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):

  • runtime/NumberPrototype.h:

(JSC::NumberPrototype::create):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::ObjectConstructor):

  • runtime/ObjectConstructor.h:

(JSC::ObjectConstructor::create):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):

  • runtime/RegExpConstructor.h:

(JSC::RegExpConstructor::create):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):

  • runtime/RegExpPrototype.h:

(JSC::RegExpPrototype::create):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

  • runtime/StringConstructor.h:

(JSC::StringConstructor::create):

  • runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::create):
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):

  • runtime/StringPrototype.h:

(JSC::StringPrototype::create):

Source/JavaScriptGlue:

Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • JSRun.cpp:

(JSGlueGlobalObject::JSGlueGlobalObject):

  • JSRun.h:

(JSGlueGlobalObject::create):

Source/WebCore:

No new tests.

Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • WebCore.exp.in:
  • bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
(WebCore::DOMConstructorWithDocument::finishCreation):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSWorkerContextBase.cpp:

(WebCore::JSWorkerContextBase::JSWorkerContextBase):
(WebCore::JSWorkerContextBase::finishCreation):

  • bindings/js/JSWorkerContextBase.h:
  • bindings/scripts/CodeGeneratorJS.pm:

Added a finishCreation declaration and Moved the finishCreation call into the
create method for all classes except for subclasses of JSWorkerContextBase and
JSDOMWindowBase because those classes are on the next level, and it's easier
to do all of these classes in one fell swoop rather than level by level.
(GenerateHeader):
Added the implementation of the finishCreation method for the classes described above.
(GenerateImplementation):
Also added the finishCreation calls to the autogenerated DOM constructor classes.
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
(WebCore::JSTestInterfaceConstructor::finishCreation):
(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterface::finishCreation):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::create):
(WebCore::JSTestInterfacePrototype::create):
(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListener::finishCreation):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::create):
(WebCore::JSTestMediaQueryListListenerPrototype::create):
(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::JSTestObjConstructor):
(WebCore::JSTestObjConstructor::finishCreation):
(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::finishCreation):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::create):
(WebCore::JSTestObjPrototype::create):
(WebCore::JSTestObjPrototype::JSTestObjPrototype):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::finishCreation):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::create):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::create):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):

  • bridge/c/CRuntimeObject.cpp:

(JSC::Bindings::CRuntimeObject::CRuntimeObject):

  • bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::create):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
(JSC::Bindings::CRuntimeMethod::finishCreation):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::JavaRuntimeMethod):
(JavaRuntimeMethod::finishCreation):

  • bridge/jni/jsc/JavaRuntimeObject.cpp:

(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):

  • bridge/jni/jsc/JavaRuntimeObject.h:

(JSC::Bindings::JavaRuntimeObject::create):

  • bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::create):

  • bridge/objc/ObjCRuntimeObject.mm:

(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):

  • bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::ObjCRuntimeMethod):
(ObjCRuntimeMethod::finishCreation):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::create):
(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntimeObject::create):
(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeMetaMethod::finishCreation):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::finishCreation):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMetaMethod::create):

  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::RuntimeMethod):

  • bridge/runtime_method.h:

(JSC::RuntimeMethod::create):

Source/WebKit/mac:

Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
(WebKit::ProxyRuntimeMethod::finishCreation):

Source/WebKit2:

Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::JSNPMethod):

  • WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):

11:49 AM Changeset in webkit [95107] by eric@webkit.org
  • 24 edits in trunk

Remove ENABLE_SVG_USE as <use> is required by HTML5
​https://bugs.webkit.org/show_bug.cgi?id=68019

Reviewed by Ryosuke Niwa.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • features.pri:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:
  • waf/build/settings.py:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
11:47 AM Changeset in webkit [95106] by caryclark@google.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)
Updated reference images (missed this one on the prior land)

  • platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added.
11:46 AM Changeset in webkit [95105] by caryclark@google.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)
Updated reference images.

  • platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Removed.
  • platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added.
11:41 AM Changeset in webkit [95104] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

MediaPlayerPrivateAVFoundationObjC's "periodic time observer" is unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=68056

MediaPlayerPrivateAVFoundationObjC creates a "periodic time observer" not because it wants
periodic callbacks, but because a time observer also fires whenever a seek completes. This is
no longer necessary because it now uses but AVPlayerItem's
-seekToTime:toleranceBefore:toleranceAfter:completionHandler to seek, so seek completions are
always notified.

Reviewed by Darin Adler.

No new tests, code removed is tested by existing tests.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):

11:35 AM Changeset in webkit [95103] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=68054
Return an image scale factor as well as an Image* from CachedImage::brokenImage()

Reviewed by Darin Adler.

CachedImage::brokenImage() now returns a pair<Image*, float> where the float
represents the image's scale factor. This is important because currently, the
broken image will either be only 1x or 2x, but a deviceScaleFactor could
theoretically be something different (1.5, 3, etc). So it is not safe to assume
that the image's scale factor is equivalent to the deviceScaleFactor, and
hardcoding 2 for now is lame.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::brokenImage):
(WebCore::CachedImage::image):

  • loader/cache/CachedImage.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageSizeForError):
(WebCore::RenderImage::paintReplaced):

11:27 AM Changeset in webkit [95102] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

video-error-abort.html shouldn't be in Mac skipped list
​https://bugs.webkit.org/show_bug.cgi?id=68053
<rdar://problem/6710625> Test media/video-error-abort.html doesn't work

Reviewed by Darin Adler.

  • platform/mac/Skipped: Remove http/tests/media/video-error-abort.html from the mac

skipped list.

11:05 AM Changeset in webkit [95101] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

Removing fast/canvas/setWidthResetAfterForcedRender.html from
test_expectations, since it has been passing on the Mesa bots
(last failure was at r94962).

11:02 AM Changeset in webkit [95100] by jamesr@google.com
  • 34 edits
    3 adds in trunk

[chromium] Move contents texture manager from LayerRendererChromium to CCLayerTreeHost
​https://bugs.webkit.org/show_bug.cgi?id=67440

Reviewed by Kenneth Russell.

This moves the contents TextureManager over to the CCLayerTreeHost, where it belongs, and adds in a commit path
to make sure that textures are deleted even if the page is not visible. This move also removed the need for
LayerRendererChromium's CCLayerTreeHost pointer, so I removed that as well. That meant moving the
layerTreeAsText() logic over to the CCLayerImpl side, which is where it really belonged anyway.

Covered by existing compositing/ tests and
platform/chromium/compositor/lost-compositor-context-with-rendersurface.html

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::setContentsTextureMemoryUseBytes):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):
(WebCore::TextureManager::lowLimitBytes):

  • platform/graphics/chromium/TextureManager.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTextures):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::contentsTextureManager):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setVisible):

  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:
10:58 AM Changeset in webkit [95099] by hyatt@apple.com
  • 4 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=68040

Make sure border image sub-properties can be specified in any order.

Reviewed by Beth Dakin.

Source/WebCore:

New tests in fast/borders.

  • css/CSSParser.cpp:

(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::canAdvance):
(WebCore::BorderImageParseContext::setCanAdvance):
(WebCore::BorderImageParseContext::allowCommit):
(WebCore::BorderImageParseContext::allowImage):
(WebCore::BorderImageParseContext::allowImageSlice):
(WebCore::BorderImageParseContext::allowSlash):
(WebCore::BorderImageParseContext::requireWidth):
(WebCore::BorderImageParseContext::requireOutset):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):

  • css/CSSParserValues.h:

(WebCore::CSSParserValueList::previous):

LayoutTests:

  • fast/borders/border-image-scrambled.html: Added.
  • platform/mac/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/mac/fast/borders/border-image-scrambled-expected.txt: Added.
10:16 AM Changeset in webkit [95098] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Remove Jan Erik Hanssen (added in my r95078) from the list for now
since I can't confirm acceptable his committership.

  • Scripts/webkitpy/common/config/committers.py:
10:04 AM Changeset in webkit [95097] by reed@google.com
  • 2 edits in trunk/Source/WebCore

query SystemParametersInfo for GDI font smoothing settings
​https://bugs.webkit.org/show_bug.cgi?id=68080

Reviewed by Stephen White.

No new tests. fixes antialiasing issues based on User settings

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::getDefaultGDITextFlags):
(WebCore::setupPaintForFont):

9:45 AM Changeset in webkit [95096] by hyatt@apple.com
  • 10 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=68050

Regressions in some layout tests from making border/mask/reflection nine-piece-image
parsing match the spec, which allows any of the pieces to be omitted and to also be
specifiable in any order.

When the higher level code suddenly allowed the image slices to be omitted, the fixup
for legacy compatibility for reflections and masks in the parseBorderImageSlice function
no longer happened because that function no longer got called.

The fix is to properly set the defaults to include the "fill" keyword, so the fixup is
applied to the NinePieceImages you create before you ever map anything in from the rules.

This also has the side effect of fixing -webkit-max-box-image-slice to actually dump as
"0 fill" instead of just "0", which is the correct initial value for this property.

Reviewed by Adam Roben.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseBorderImageSlice):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

  • rendering/style/StyleReflection.h:

(WebCore::StyleReflection::StyleReflection):

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
9:27 AM Changeset in webkit [95095] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. timeline-animation-frame.html was marked as TEXT.

  • platform/qt/test_expectations.txt:
8:54 AM Changeset in webkit [95094] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. timeline-animation-frame.html was marked as TIMEOUT.

  • platform/qt/test_expectations.txt:
8:09 AM Changeset in webkit [95093] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-09-13 Pavel Feldman <​pfeldman@google.com>

Web Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has been reset.
​https://bugs.webkit.org/show_bug.cgi?id=67997

We should not instrument frameDestroyed event from within Frame's destructor
since frame's m_page pointer is likely to be 0 by that time and appropriate
instrumenting agent won't be found. As a result, stale frame with its id
end up in the inspector.

This change wipes out frame binding from the inspector upon detach rather
than destroy.

Reviewed by Tony Gentilcore.

  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::frameDetachedImpl):
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::frameDetached):
  • inspector/InspectorPageAgent.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent):
  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::detachFromPage):
  • page/Frame.h:
7:59 AM Changeset in webkit [95092] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-09-14 Pavel Feldman <​pfeldman@google.com>

Not reviewed: rolling out r95089.

  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::frameDestroyedImpl): (WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::frameWindowDiscarded): (WebCore::InspectorInstrumentation::domContentLoadedEventFired): (WebCore::InspectorInstrumentation::loadEventFired): (WebCore::InspectorInstrumentation::didCommitLoad): (WebCore::InspectorInstrumentation::frameDestroyed):
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::frameDetached): (WebCore::InspectorPageAgent::frameDestroyed):
  • inspector/InspectorPageAgent.h:
  • page/Frame.cpp: (WebCore::Frame::~Frame):
7:56 AM WebKit Team edited by yoli@rim.com
Remove "WINCE port" from my name (diff)
7:34 AM Changeset in webkit [95091] by loislo@chromium.org
  • 17 edits
    3 adds in trunk

Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
​https://bugs.webkit.org/show_bug.cgi?id=67986

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-animation-frame.html

  • English.lproj/localizedStrings.js:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::callFunctionWithoutFrame):
(WebCore::V8Proxy::instrumentedCallFunction):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl):
(WebCore::InspectorInstrumentation::didFireAnimationFrameEventImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallback):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameCallback):
(WebCore::InspectorInstrumentation::willFireAnimationFrameEvent):
(WebCore::InspectorInstrumentation::didFireAnimationFrameEvent):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
(WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createAnimationFrameCallbackData):

  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

  • inspector/timeline/timeline-animation-frame-expected.txt: Added.
  • inspector/timeline/timeline-animation-frame.html: Added.
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • platform/chromium/inspector/timeline/timeline-enum-stability-expected.txt:
  • inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.performActions.step2):
(initialize_Timeline.InspectorTest.performActions):
(initialize_Timeline.InspectorTest.performActionsAndPrint):

7:20 AM Changeset in webkit [95090] by steveblock@google.com
  • 3 edits in trunk/Source/JavaScriptCore

HashTraits.h should include template specialization for WTF::String
​https://bugs.webkit.org/show_bug.cgi?id=67851

Ensure that the template specialization for HashTraits<String> is always
picked up. (Previously it was possible to include HashSet and String but
not the correct HashTraits, so you would get an inefficient template
instantiation.)

Patch by Iain Merrick <​husky@google.com> on 2011-09-14
Reviewed by Darin Adler.

  • wtf/HashTraits.h:
  • wtf/text/StringHash.h:
7:14 AM Changeset in webkit [95089] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has been reset.
​https://bugs.webkit.org/show_bug.cgi?id=67997

We should not instrument frameDestroyed event from within Frame's destructor
since frame's m_page pointer is likely to be 0 by that time and appropriate
instrumenting agent won't be found. As a result, stale frame with its id
end up in the inspector.

This change wipes out frame binding from the inspector upon detach rather
than destroy + adds an assertion into the inspector agents lookup with 0 page.

Reviewed by Tony Gentilcore.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::frameDetachedImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::frameWindowDiscarded):
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
(WebCore::InspectorInstrumentation::frameDetached):
(WebCore::InspectorInstrumentation::didCommitLoad):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::frameDetached):

  • inspector/InspectorPageAgent.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::detachFromParent):

  • page/Frame.cpp:

(WebCore::Frame::~Frame):
(WebCore::Frame::detachFromPage):
(WebCore::Frame::transferChildFrameToNewDocument):

  • page/Frame.h:
6:52 AM Changeset in webkit [95088] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Add NULL checks to ewk_window_features_new_from_core and ewk_view_window_create.
​https://bugs.webkit.org/show_bug.cgi?id=64932

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-09-14
Reviewed by Eric Seidel.

It prevents the crash while allocating memory for the new window.

  • ewk/ewk_view.cpp:

(ewk_view_window_create):

  • ewk/ewk_window_features.cpp:

(ewk_window_features_new_from_core):

6:41 AM Changeset in webkit [95087] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt: fix lint-test-files error
3:06 AM Changeset in webkit [95086] by haraken@google.com
  • 1 edit
    1 add in trunk/LayoutTests

page-transition-event-constructor-expected.txt is missing
​https://bugs.webkit.org/show_bug.cgi?id=68069

Reviewed by Hajime Morita.

  • fast/events/constructors/page-transition-event-constructor-expected.txt: Added.
2:48 AM Changeset in webkit [95085] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=68066

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
2:41 AM Changeset in webkit [95084] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r95080.
​http://trac.webkit.org/changeset/95080
​https://bugs.webkit.org/show_bug.cgi?id=68070

It caused some 2d.composite.uncovered tests fail (Requested by
rgabor on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-14

Source/WebCore:

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

LayoutTests:

  • fast/canvas/canvas-large-fills-expected.txt: Removed.
  • fast/canvas/canvas-large-fills.html: Removed.
2:29 AM Changeset in webkit [95083] by pfeldman@chromium.org
  • 4 edits
    3 adds in trunk

Web Inspector: [v8] building call frame info for location-less internal script function crashes.
​https://bugs.webkit.org/show_bug.cgi?id=67991

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/debugger-pause-in-internal.html

  • bindings/v8/DebuggerScript.js:

():

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::currentCallFrame):

LayoutTests:

  • inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
  • inspector/debugger/debugger-pause-in-internal.html: Added.
  • inspector/debugger/debugger-pause-on-exception-crash-expected.txt: Added.
  • platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
1:31 AM Changeset in webkit [95082] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expecations.

  • platform/chromium/test_expectations.txt:
1:25 AM Changeset in webkit [95081] by rgabor@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed, update test expectations for
svg/custom/dynamic-svg-document-creation.svg after r95030

  • platform/qt/svg/custom/dynamic-svg-document-creation-expected.png:
  • platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt:
1:10 AM Changeset in webkit [95080] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Large canvas fills should not crash or create unnecessarily large image buffers
​https://bugs.webkit.org/show_bug.cgi?id=67988

Source/WebCore:

When using source-in, destination-in, source-out, or destination-atop a temporary
buffer is created. This buffer only needs to be big enough to cover the intersection
of the path and the canvas.

This change also adds some null checks for failures to create contexts or buffers.

Patch by Ben Wells <​benwells@chromium.org> on 2011-09-14
Reviewed by Stephen White.

Test: fast/canvas/canvas-large-fills.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

LayoutTests:

Patch by Ben Wells <​benwells@chromium.org> on 2011-09-14
Reviewed by Stephen White.

  • fast/canvas/canvas-large-fills-expected.txt: Added.
  • fast/canvas/canvas-large-fills.html: Added.
12:40 AM Changeset in webkit [95079] by haraken@google.com
  • 9 edits
    1 add in trunk

Implement a PageTransitionEvent constructor for JSC
​https://bugs.webkit.org/show_bug.cgi?id=68048

Reviewed by Sam Weinig.

Source/WebCore:

The spec for the PageTransitionEvent constructor is here:
​http://www.whatwg.org/specs/web-apps/current-work/#pagetransitionevent

Test: fast/events/constructors/page-transition-event-constructor.html

  • bindings/generic/EventConstructors.h: Added a definition for the PageTransitionEvent constructor.
  • bindings/js/JSEventConstructors.cpp: Added #includes for PageTransitionEvent.
  • dom/PageTransitionEvent.cpp:

(WebCore::PageTransitionEventInit::PageTransitionEventInit):
(WebCore::PageTransitionEvent::PageTransitionEvent):
(WebCore::PageTransitionEvent::initPageTransitionEvent):

  • dom/PageTransitionEvent.h: Added a definition for PageTransitionEventInit.

(WebCore::PageTransitionEvent::create):
(WebCore::PageTransitionEvent::isPageTransitionEvent):
(WebCore::PageTransitionEvent::persisted):

  • dom/PageTransitionEvent.idl: Makes PageTransitionEvent constructible.

LayoutTests:

page-transition-event-constructor.html checks the behavior of the PageTransitionEvent constructor.

  • fast/dom/constructed-objects-prototypes-expected.txt: Added PageTransitionEvent.
  • fast/events/constructors/page-transition-event-constructor-expected.txt: Added.
  • fast/events/constructors/page-transition-event-constructor.html: Added.
  • platform/chromium/test_expectations.txt: Skipped page-transition-event-constructor.html, since V8 does not yet have the PageTransitionEvent constructor.

Sep 13, 2011:

11:58 PM Changeset in webkit [95078] by rniwa@webkit.org
  • 2 edits in trunk/Tools

committers.py is missing some contributors
​https://bugs.webkit.org/show_bug.cgi?id=68059

Reviewed by Adam Barth.

Add David Barr, Jan Erik Hanssen, and Kim Grönholm.

Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.

  • Scripts/webkitpy/common/config/committers.py:
11:46 PM Changeset in webkit [95077] by Csaba Osztrogonác
  • 4 edits
    3 deletes in trunk

Unreviewed, rolling out r95058.
​http://trac.webkit.org/changeset/95058
​https://bugs.webkit.org/show_bug.cgi?id=68058

It made css3/calc/regression-62276.html crash (Requested by
Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-13

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::allowBreak):
(WebCore::BorderImageParseContext::allowWidth):
(WebCore::BorderImageParseContext::allowOutset):
(WebCore::BorderImageParseContext::allowRepeat):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):

  • css/CSSParserValues.h:

LayoutTests:

  • fast/borders/border-image-scrambled.html: Removed.
  • platform/mac/fast/borders/border-image-scrambled-expected.png: Removed.
  • platform/mac/fast/borders/border-image-scrambled-expected.txt: Removed.
11:32 PM Changeset in webkit [95076] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Fix webkit python test after r95061.

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
9:37 PM Changeset in webkit [95075] by jnd@chromium.org
  • 2 edits in trunk/Tools

Add ​wangxianzhu@chromium.org as a contributor.

9:19 PM Changeset in webkit [95074] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in RenderScrollbarPart::imageChanged.
​https://bugs.webkit.org/show_bug.cgi?id=68009

Reviewed by Simon Fraser.

Source/WebCore:

When a custom scrollbar is removed from its FrameView, its destruction
can be delayed because of RefPtr maintained in EventHandler class
(m_lastScrollbarUnderMouse). Upon removal, we delete all the scrollbar
parts so that they don't link back to scrollbar. However, because of the
delay, we can have a call to updateScrollbarPart which recreates it.
When scrollbar is getting destroyed, we just check to see if there are
remaining scrollbar parts and if yes, we destroy them.

Test: scrollbars/scrollbar-part-created-with-no-parent-crash.html

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::~RenderScrollbar):

LayoutTests:

  • scrollbars/scrollbar-part-created-with-no-parent-crash-expected.txt: Added.
  • scrollbars/scrollbar-part-created-with-no-parent-crash.html: Added.
8:36 PM Changeset in webkit [95073] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt: failures on GPU starting from r95058
7:45 PM Changeset in webkit [95072] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt: failures starting from r95058
7:09 PM Changeset in webkit [95071] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized read
​https://bugs.webkit.org/show_bug.cgi?id=68021

Reviewed by Tony Chang.

Source/WebCore:

Reported by valgrind in ​http://crbug.com/60653.

Besides fixing the uninitialized read, add support for outputting the
list separator for counters() calls and the list-style name.

Test: fast/css/counters/counter-cssText.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText):

LayoutTests:

  • fast/css/counters/counter-cssText-expected.txt: Added.
  • fast/css/counters/counter-cssText.html: Added.
6:58 PM Changeset in webkit [95070] by bashi@chromium.org
  • 3 edits
    3 adds in trunk

WebFont followed tiny monospace text displays weird
​https://bugs.webkit.org/show_bug.cgi?id=67996

Reviewed by Darin Adler.

Source/WebCore:

Always call wkSetCGFontRenderingMode() in Font::drawGlyphs() so that the rendering mode is set correctly.

Test: platform/mac/fast/text/webfont-after-tiny-monospace-text.html

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

LayoutTests:

This test ensures that webfont followed tiny monospace text is displayed correctly.

  • platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.png: Added.
  • platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.txt: Added.
  • platform/mac/fast/text/webfont-after-tiny-monospace-text.html: Added.
6:24 PM Changeset in webkit [95069] by abarth@webkit.org
  • 6 edits in trunk/Tools

garden-o-matic has unfriendly error messages when the local server is not available
​https://bugs.webkit.org/show_bug.cgi?id=68042

Reviewed by Dimitri Glazkov.

This patch moves us from using alert to showing the error inline in the
progress dialog.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
6:23 PM Changeset in webkit [95068] by abarth@webkit.org
  • 5 edits in trunk/Tools

FailureGrid in garden-o-matic should link to the builder's waterfall page
​https://bugs.webkit.org/show_bug.cgi?id=68036

Reviewed by Dimitri Glazkov.

One of the users in the user study thought the configurations names in
the failure grid would link to the underlying bots. That makes sense,
so this patch adds the behavior.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
6:21 PM Changeset in webkit [95067] by abarth@webkit.org
  • 6 edits in trunk/Tools

garden-o-matic should be able to mark failures as expected
​https://bugs.webkit.org/show_bug.cgi?id=68027

Reviewed by Dimitri Glazkov.

All the back-end infrastructure exists for this operation. This patch
just adds some UI to the front-end and wires that UI up to the back
end. This exact UI will likely need some more polish, but this should
be a reasonable first cut.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
6:20 PM Changeset in webkit [95066] by abarth@webkit.org
  • 7 edits in trunk/Tools

garden-o-matic should tell you about the progress of your rebaseline
​https://bugs.webkit.org/show_bug.cgi?id=67967

Reviewed by Dimitri Glazkov.

This patch adds ui.MessageBox, which is a light wrapper around jQuery
UI's dialog widget. We then use ui.MessageBox to show status messages
about in-progress rebaselines. As each baseline is downloaded, the
MessageBox updates. This UI replaces our temporary "alert"-based UI.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
6:19 PM Changeset in webkit [95065] by commit-queue@webkit.org
  • 7 edits
    6 adds in trunk

Fix XSS auditor bypass when inline handlers contain comments.
​https://bugs.webkit.org/show_bug.cgi?id=27895

Patch by Tom Sepez <​tsepez@chromium.org> on 2011-09-13
Reviewed by Adam Barth.

Source/WebCore:

Tests: http/tests/security/xssAuditor/property-escape-comment.html

http/tests/security/xssAuditor/property-escape-entity.html
http/tests/security/xssAuditor/property-escape-quote.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::snippetForAttribute):

LayoutTests:

  • http/tests/security/xssAuditor/malformed-HTML-expected.txt:
  • http/tests/security/xssAuditor/open-attribute-body-expected.txt:
  • http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
  • http/tests/security/xssAuditor/property-escape-comment-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-comment.html: Added.
  • http/tests/security/xssAuditor/property-escape-entity-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-entity.html: Added.
  • http/tests/security/xssAuditor/property-escape-quote-expected.txt: Added.
  • http/tests/security/xssAuditor/property-escape-quote.html: Added.
  • http/tests/security/xssAuditor/resources/echo-property.pl:
6:13 PM Changeset in webkit [95064] by ukai@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Update chromium-mac test expectations
​https://bugs.webkit.org/show_bug.cgi?id=67917

Reviewed by Darin Adler.

  • platform/chromium-cg-mac-leopard/svg/custom/simple-text-double-shadow-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:05 PM Changeset in webkit [95063] by haraken@google.com
  • 5 edits in trunk

Implement a HashChangeEvent constructor for V8
​https://bugs.webkit.org/show_bug.cgi?id=67969

Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/events/constructors/hash-change-event-constructor.html

  • bindings/v8/custom/V8EventConstructors.cpp: Added the HashChangeEvent constructor.
  • dom/HashChangeEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled hash-change-event-constructor.html, since now V8 has a HashChangeEvent constructor.

  • platform/chromium/test_expectations.txt:
6:03 PM Changeset in webkit [95062] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
​https://bugs.webkit.org/show_bug.cgi?id=68024

Patch by Leandro Pereira <​leandro@profusion.mobi> on 2011-09-13
Reviewed by Gustavo Noronha Silva.

Using g_list_count() and g_list_nth_data() together on a loop is
inneficient since they're both O(n). Iterate over lists in a saner
way.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(dumpHistoryItem): Reduce the scope for the 'kids' variable, and
iterate on it using g_list_next(). Free the list after done with it.
(dumpBackForwardListForWebView): Instead of appending (which is
expensive in GLists) history items and then iterating from the tail
of the itemsToPrint list, prepend items and walk forwards as usual.
(dumpBackForwardListForAllWebViews): Walk the list in a saner way,
remove the (unneeded) viewList variable.

6:00 PM Changeset in webkit [95061] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Add Eric's IRC nick.

  • Scripts/webkitpy/common/config/committers.py:
5:37 PM Changeset in webkit [95060] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should
return false if either node can be double
​https://bugs.webkit.org/show_bug.cgi?id=67985

Reviewed by Geoffrey Garen.

This is a 17% speed-up on 3d-cube.

This required allowing us to check if a constant is double but not
integer, and making the shouldSpeculateInteger() check test for
any hints of doubly-ness in its operands. This also required
changing some terminology: previously "isDouble" often meant
"isDouble or isInt32". Now "isDouble" means exactly what the name
suggests, and "isNumber" means "isDouble or isInt32".

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::isJSFormat):
(JSC::DFG::isJSInteger):
(JSC::DFG::isJSDouble):
(JSC::DFG::isJSCell):
(JSC::DFG::isJSBoolean):
(JSC::DFG::GenerationInfo::isJSFormat):
(JSC::DFG::GenerationInfo::isJSInteger):
(JSC::DFG::GenerationInfo::isJSDouble):
(JSC::DFG::GenerationInfo::isJSCell):
(JSC::DFG::GenerationInfo::isJSBoolean):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::isNumberConstant):
(JSC::DFG::Graph::valueOfNumberConstant):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::isNumberConstant):
(JSC::DFG::JITCodeGenerator::valueOfNumberConstant):
(JSC::DFG::JITCodeGenerator::initConstantInfo):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillToJS):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::isNumberConstant):
(JSC::DFG::JITCompiler::valueOfNumberConstant):

  • dfg/DFGNode.h:

(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::valueOfNumberConstant):
(JSC::DFG::Node::hasNumberResult):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):
(JSC::DFG::SpeculativeJIT::shouldNotSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):

5:29 PM Changeset in webkit [95059] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Fix crash when an iframe element is removed during a transition to
fullscreen.
​https://bugs.webkit.org/show_bug.cgi?id=67960

Patch by Jeremy Apthorp <​jeremya@google.com> on 2011-09-13
Reviewed by Adam Barth.

Test: fullscreen/full-screen-remove-ancestor-during-transition.html

  • dom/Document.cpp:

(WebCore::Document::~Document):
Clear the list of elements to which we need to send a fullscreenchange
event.

LayoutTests: Removing an iframe from the document during a transition to fullscreen
should not crash.
​https://bugs.webkit.org/show_bug.cgi?id=67960

Patch by Jeremy Apthorp <​jeremya@google.com> on 2011-09-13
Reviewed by Adam Barth.

  • fullscreen/full-screen-remove-ancestor-during-transition-expected.txt: Added.
  • fullscreen/full-screen-remove-ancestor-during-transition.html: Added.
5:17 PM Changeset in webkit [95058] by hyatt@apple.com
  • 4 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=68040

Make sure border image sub-properties can be specified in any order.

Reviewed by Beth Dakin.

Source/WebCore:

New tests in fast/borders.

  • css/CSSParser.cpp:

(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::canAdvance):
(WebCore::BorderImageParseContext::setCanAdvance):
(WebCore::BorderImageParseContext::allowCommit):
(WebCore::BorderImageParseContext::allowImage):
(WebCore::BorderImageParseContext::allowImageSlice):
(WebCore::BorderImageParseContext::allowSlash):
(WebCore::BorderImageParseContext::requireWidth):
(WebCore::BorderImageParseContext::requireOutset):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):

  • css/CSSParserValues.h:

(WebCore::CSSParserValueList::previous):

LayoutTests:

  • fast/borders/border-image-scrambled.html: Added.
  • platform/mac/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/mac/fast/borders/border-image-scrambled-expected.txt: Added.
5:05 PM Changeset in webkit [95057] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

WebCore::Cursor::ensurePlatformCursor() should always set a valid platform cursor on Windows
​https://bugs.webkit.org/show_bug.cgi?id=68043

Make sure we set a valid platform cursor in the Cursor::NoDrop case, and add a default
clause that uses the arrow cursor in case another cursor type is added in the future
and we forget to update ensurePlatformCursor().

Reviewed by Anders Carlsson.

  • platform/win/CursorWin.cpp:

(WebCore::Cursor::ensurePlatformCursor): Always set a valid platform cursor.

4:32 PM Changeset in webkit [95056] by jhoneycutt@apple.com
  • 3 edits
    2 adds in trunk

MSAA: WebKit reports the document state as disabled
​https://bugs.webkit.org/show_bug.cgi?id=67974
<rdar://problem/10095898>

Reviewed by Brian Weinstein.

Source/WebCore:

Test: platform/win/accessibility/document-enabled-state.html

  • accessibility/AccessibilityScrollView.h:

(WebCore::AccessibilityScrollView::isEnabled):
This object backs the AccessibleDocument on Windows - always return
true for its enabled state.

LayoutTests:

  • platform/win/accessibility/document-enabled-state-expected.txt: Added.
  • platform/win/accessibility/document-enabled-state.html: Added.
4:10 PM Changeset in webkit [95055] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit/qt

[Qt] Fix state of stop/reload actions in QWebPage
​https://bugs.webkit.org/show_bug.cgi?id=65977

FrameLoader does ask its DocumentLoader to stop loading subresources before
setting the state to FrameStateCommittedPage. But it does
not check if the the DocumentLoader actually stopped loading before
it changes the state.
Therefore a subresourceLoader can still be active, when we receive the
call to dispatchDidFinishLoad(). This leads to an inconsistent behavior
of the stop/reload actions in QWebPage.
This changeset fixes the inconsistent state by updating the action states
also when frameLoadCompleted() is called.

Patch by Zeno Albisser <​zeno.albisser@nokia.com> on 2011-09-13
Reviewed by Chang Shu.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::frameLoadCompleted):

3:49 PM Changeset in webkit [95054] by cdn@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Fixes several bugs when adding CounterNodes to a tree which can cause asymetrical relationships.
​https://bugs.webkit.org/show_bug.cgi?id=65996

Reviewed by Eric Seidel.

Test: fast/css/counters/counter-reparent-table-children-crash.html

  • rendering/CounterNode.cpp:

(WebCore::CounterNode::insertAfter):

  • rendering/RenderCounter.cpp:

(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):

LayoutTests: Test for crash when reparenting table elements with associated counters outside the table.
​https://bugs.webkit.org/show_bug.cgi?id=65996

Reviewed by Eric Seidel.

  • fast/css/counters/counter-reparent-table-children-crash-expected.txt: Added.
  • fast/css/counters/counter-reparent-table-children-crash.html: Added.
3:41 PM Changeset in webkit [95053] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Adding a comment I forgot to add before.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageSizeForError):

3:38 PM Changeset in webkit [95052] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Move identifier filter from CSSStyleSelector to SelectorChecker
​https://bugs.webkit.org/show_bug.cgi?id=68025

Reviewed by Sam Weinig.

This is a more logical place for this code. It also makes CSSStyleSelector slightly less bloated.
It will make it possible to use fastRejectSelector for querySelectorAll in the future.

  • css/CSSStyleSelector.cpp:

(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::RuleData::RuleData):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):

  • css/SelectorChecker.cpp:

(WebCore::collectElementIdentifierHashes):
(WebCore::SelectorChecker::pushParentStackFrame):
(WebCore::SelectorChecker::popParentStackFrame):
(WebCore::SelectorChecker::pushParent):
(WebCore::SelectorChecker::popParent):
(WebCore::collectDescendantSelectorIdentifierHashes):
(WebCore::SelectorChecker::collectIdentifierHashes):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::parentStackIsConsistent):
(WebCore::SelectorChecker::ParentStackFrame::ParentStackFrame):
(WebCore::SelectorChecker::fastRejectSelector):

3:33 PM Changeset in webkit [95051] by Beth Dakin
  • 1 edit in trunk/Source/WebCore/ChangeLog

Restoring a ChangeLog entry that I accidentally trampled.

3:31 PM Changeset in webkit [95050] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

For compatibility, execCommand should support deprecated 'useCSS' alias for 'styleWithCSS'
​https://bugs.webkit.org/show_bug.cgi?id=36683

Patch by Kiyoto Tamura <​owenestea@gmail.com> on 2011-09-13
Reviewed by Ryosuke Niwa.

Source/WebCore:

In addition to supporting the deprecated 'useCSS', 'styleWithCSS' now accepts any argument other than
the boolean false or the case-insensitive string "false". This is per
​http://aryeh.name/spec/editing/editing.html#the-stylewithcss-command

Tests: editing/execCommand/style-with-css.html

editing/execCommand/use-css.html

  • editing/EditorCommand.cpp:

(WebCore::executeStyleWithCSS):
(WebCore::executeUseCSS):
(WebCore::createCommandMap):

LayoutTests:

Testing useCSS, the command previously unsupported by WebKit. Also, we are testing
styleWithCSS accepts anything that is not the boolean false or the string "false" as true.
Furthermore, we test that queryCommandValue/State('useCSS') return boolean false and
queryCommandValue/State('useStyleWithCSS') returns booleans (as opposed to 'true'/'false'
strings)

  • editing/execCommand/style-with-css-expected.txt: Added.
  • editing/execCommand/style-with-css.html: Added.
  • editing/execCommand/use-css-expected.txt: Added.
  • editing/execCommand/use-css.html: Added.
3:28 PM Changeset in webkit [95049] by andersca@apple.com
  • 16 edits in trunk

Disable C++ exceptions when building with clang
​https://bugs.webkit.org/show_bug.cgi?id=68031
<rdar://problem/9556880>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/JavaScriptGlue:

  • Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:

Tools:

  • MiniBrowser/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
3:17 PM Changeset in webkit [95048] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=67885
Outline for the high-resolution broken image icon draws at 2x
-and corresponding-
<rdar://problem/10104637>

Reviewed by Dan Bernstein.

Scaled the image size to account for the deviceScaleFactor.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageSizeForError):

2:54 PM Changeset in webkit [95047] by timothy_horton@apple.com
  • 4 edits
    3 adds in trunk

REGRESSION (64275): Shape pattern-image fill turns black
​https://bugs.webkit.org/show_bug.cgi?id=51061
<rdar://problem/8504705>

Reviewed by Simon Fraser.

Source/WebCore:

When destroying a resource, register clients who are losing their
resource as having pending resources, so they can be resolved in the case a
resource with that id is re-registered.

Test: svg/custom/pending-resource-after-removal.xhtml

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::resourceDestroyed):

  • svg/SVGStyledElement.h:

(WebCore::toSVGStyledElement): Added.

LayoutTests:

Add a test ensuring that replacing a SVG pattern without changing
the id causes the clients to be updated properly.

  • svg/custom/pending-resource-after-removal-expected.png: Added.
  • svg/custom/pending-resource-after-removal-expected.txt: Added.
  • svg/custom/pending-resource-after-removal.xhtml: Added.
2:50 PM Changeset in webkit [95046] by ojan@chromium.org
  • 3 edits in trunk/Tools

[chromium] fix flakiness dashboard for chromium interactive tests
​https://bugs.webkit.org/show_bug.cgi?id=68029

Reviewed by Tony Chang.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2:43 PM Changeset in webkit [95045] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] The checked state of WebPopupMenuItem isn't initialized
​https://bugs.webkit.org/show_bug.cgi?id=67889

Reviewed by Darin Fisher.

It seems we're failing to initialize the checked state of
WebPopupMenuItems, potentially because Android is the first platform to
use popup menus for <select> elements.

  • src/ExternalPopupMenu.cpp:

(WebKit::ExternalPopupMenu::getPopupMenuInfo):

2:29 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
2:08 PM Changeset in webkit [95044] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Add Alice and Aryeh to the list of contributors.

  • Scripts/webkitpy/common/config/committers.py:
1:59 PM Changeset in webkit [95043] by caryclark@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)
Updated reference images.

  • platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.png: Added.
1:51 PM Changeset in webkit [95042] by rniwa@webkit.org
  • 3 edits in trunk/Tools

sheriffbot whois should also tell us email addresses
​https://bugs.webkit.org/show_bug.cgi?id=67975

Reviewed by Eric Seidel and David Levin.

Taught sheriffbot how to tell us contributor's email addresses.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1:35 PM Changeset in webkit [95041] by caryclark@google.com
  • 1 edit
    7 adds
    1 delete in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac)
Updated reference images, text.

  • platform/chromium-mac/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Removed.
  • platform/chromium-mac/platform/chromium/fast/repaint: Added.
  • platform/chromium-mac/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
  • platform/chromium-mac/fast/lists/list-marker-before-content-table-expected.png: Added.
  • platform/chromium-mac/fast/runin/runin-generated-before-content-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
  • platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png: Added.
  • platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png: Added.
1:19 PM Changeset in webkit [95040] by eric@webkit.org
  • 38 edits in trunk

Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
​https://bugs.webkit.org/show_bug.cgi?id=68018

Reviewed by Ryosuke Niwa.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • dom/DOMImplementation.cpp:

(WebCore::isSVG10Feature):
(WebCore::isSVG11Feature):

  • dom/Text.cpp:

(WebCore::Text::createRenderer):

  • features.pri:
  • page/DOMWindow.idl:
  • rendering/svg/RenderSVGForeignObject.cpp:
  • rendering/svg/RenderSVGForeignObject.h:
  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::hasValidAttributeType):

  • svg/SVGForeignObjectElement.cpp:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGForeignObjectElement.idl:
  • svg/SVGLocatable.cpp:

(WebCore::isViewportElement):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::isOutermostSVG):

  • svg/SVGUseElement.cpp:

(WebCore::isDisallowedElement):
(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):

  • svg/svgtags.in:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:
  • waf/build/settings.py:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
12:26 PM Changeset in webkit [95039] by commit-queue@webkit.org
  • 21 edits
    1 copy
    1 add in trunk

[WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
​https://bugs.webkit.org/show_bug.cgi?id=57515

Source/WebKit2:

The code change in WebKit2 allows key events being sent to WebProcess from UIProcess synchronously.

Patch by Chang Shu <​cshu@webkit.org> on 2011-09-13
Reviewed by Darin Adler.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetShouldSendKeyboardEventSynchronously):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleKeyboardEvent):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setShouldSendKeyboardEventSynchronously):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::keyEventSyncForTesting):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
TestController synchronously. The latter then sends simulated event to WebKit2 module,
which is synchronous, too.

Patch by Chang Shu <​cshu@webkit.org> on 2011-09-13
Reviewed by Darin Adler.

  • WebKitTestRunner/EventSenderProxy.h: Added.

(WTR::EventSenderProxy::EventSenderProxy):

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::keyDown):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/PlatformWebView.h:

(WTR::PlatformWebView::platformWindow):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/mac/EventSenderProxy.mm: Added.

(WTR::buildModifierFlags):
(WTR::EventSenderProxy::keyDown):

LayoutTests:

Unskip passed tests for Mac.

Patch by Chang Shu <​cshu@webkit.org> on 2011-09-13
Reviewed by Darin Adler.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win-wk2/Skipped:
  • platform/wk2/Skipped:
12:24 PM Changeset in webkit [95038] by Joseph Pecoraro
  • 3 edits
    3 adds in trunk

<​http://webkit.org/b/67983> CRASH under WebCore::ArchiveResourceCollection::addAllResources loading WebArchive

Reviewed by Darin Adler.

Source/WebCore:

Null mimetypes are okay for subresources, but as previously discovered
in bug 41082 they were required for main resources. Here we ensure
that they are required for main resources, but we allow null mimetypes
for subresources.

To fix a crash for bad input we never add a null ArchiveResource to the
Archive's subresource collection. It is useless and causes crashes whenever
someone iterates the Archive's subresource collection.

Test: webarchive/loading/test-loading-archive-subresource-null-mimetype.html

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createResource):
Allow a null mimetype, just type check from the dictionary.

(WebCore::LegacyWebArchive::extract):
Require a mimetype for the main resource. Do not add null
subresources to the subresource list.

LayoutTests:

Test a WebArchive that has been constructed to have a null
mimetype for a subresource.

  • webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt: Added.
  • webarchive/loading/test-loading-archive-subresource-null-mimetype.html: Added.
  • webarchive/loading/resources/subresource-null-mimetype.webarchive: Added.
12:18 PM Changeset in webkit [95037] by simonjam@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-09-13 James Simonsen <​simonjam@chromium.org>

[Chromium] Ref protect element in FrameLoaderClientImpl::createPlugin
​https://bugs.webkit.org/show_bug.cgi?id=68014

Reviewed by Nate Chapin.

Test: plugins/destroy-during-npp-new.htm under valgrind

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
11:33 AM Changeset in webkit [95036] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-13

  • DEPS:
11:25 AM Changeset in webkit [95035] by mihaip@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove javascript_engine from WebCore.gyp
​https://bugs.webkit.org/show_bug.cgi?id=68001

Reviewed by Tony Chang.

Remove javascript_engine GYP variable (similar to the removal done on
the Chromium side with ​http://crrev.com/100692)

  • WebCore.gyp/WebCore.gyp:
10:58 AM Changeset in webkit [95034] by adamk@chromium.org
  • 1 edit in branches/chromium/874/Source/WebCore/platform/graphics/Gradient.cpp

Merge 95010 - Fix out-of-bounds access in Gradient::sortStopsIfNecessary
​https://bugs.webkit.org/show_bug.cgi?id=67958

Reviewed by Darin Adler.

Reported by Valgrind in ​http://crbug.com/77049.

The errant code was added as an optimization in r67804.
This patch reverts that one, as all parties agree that the optimization
doesn't seem worthwhile, and there clearly aren't any tests covering
the special case.

No new tests, as existing tests should cover the remaining call to
|std::stable_sort|.

  • platform/graphics/Gradient.cpp:

(WebCore::Gradient::sortStopsIfNecessary):

TBR=​adamk@chromium.org
Review URL: ​http://codereview.chromium.org/7891013

10:54 AM Changeset in webkit [95033] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Do not always return the cached frame name.
​https://bugs.webkit.org/show_bug.cgi?id=66856

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-09-13
Reviewed by Antonio Gomes.

When a frame has its parent changed (via adoptNode and appendChild,
for example), the frame name will change, so we need to account for
that case and change the cached name when needed.

This should make fast/frames/iframe-reparenting-unique-name.html pass.

  • ewk/ewk_frame.cpp:

(ewk_frame_name_get):

10:46 AM Changeset in webkit [95032] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Update chromium test expectation since fast/borders/border-image-omit-right-slice.html no longer hits an assertion.

  • platform/chromium/test_expectations.txt:
10:31 AM Changeset in webkit [95031] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS3 Backgrounds and Borders] Add unprefixed border-image shorthand.
​https://bugs.webkit.org/show_bug.cgi?id=67970

Reviewed by David Hyatt.

Also update CSSStyleSelector.cpp to support border-image to suppress assertion in
fast/borders/border-image-omit-right-slice.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):

9:44 AM Changeset in webkit [95030] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Patch by Xianzhu Wang <​wangxianzhu@chromium.org> on 2011-09-13
Reviewed by Darin Adler.

Source/WebCore:

Webkit wraps between hyphen-minus and numeric characters
​https://bugs.webkit.org/show_bug.cgi?id=20677

Disallow wrapping between a hyphen-minus and a digit if the hyphen-minus
is not directly after a digit or a letter.

Test: fast/text/line-breaks-after-hyphen-before-number.html

  • rendering/break_lines.cpp:

(WebCore::asciiLineBreakTable): Disabled line-breaking after '-' and before '.', '0'-'9'. Note: the change for '0'-'9' doesn't really matter because the case is handled hard-coded in shouldBreakAfter().
(WebCore::shouldBreakAfter): Changed line-breaking behavior after '-'.
(WebCore::nextBreakablePosition): Passes lastLastCh to shouldBreakAfter.

LayoutTests:

Webkit wraps between hyphen-minus and numeric characters
​https://bugs.webkit.org/show_bug.cgi?id=20677

Disallow wrapping between a hyphen-minus and a digit if the hyphen-minus
is not directly after a digit or a letter.

  • fast/text/line-breaks-after-hyphen-before-number-expected.txt: Added.
  • fast/text/line-breaks-after-hyphen-before-number.html: Added.
9:23 AM Changeset in webkit [95029] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

platform/graphics/gtk/FontGtk.cpp was renamed to platform/graphics/pango/FontPango.cpp . Reflect this change in WebCore.gypi to fix a Chromium build breakage.
​https://bugs.webkit.org/show_bug.cgi?id=68000

Patch by Erik Wright <​erikwright@chromium.org> on 2011-09-13
Reviewed by Tony Gentilcore.

No change in functionality, thus no new tests.

  • WebCore.gypi:
9:01 AM Changeset in webkit [95028] by weinig@apple.com
  • 3 edits
    3 adds in trunk

Object.getPrototypeOf should use JSValue::get()
​https://bugs.webkit.org/show_bug.cgi?id=67973

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):
Pipe through JSValue::get() to allow overrides.

LayoutTests:

  • http/tests/security/cross-frame-access-object-getPrototypeOf-expected.txt: Added.
  • http/tests/security/cross-frame-access-object-getPrototypeOf.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-object-getPrototypeOf-test.html: Added.
8:32 AM Changeset in webkit [95027] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Profiler: Fix overlapping data in function names column.
​https://bugs.webkit.org/show_bug.cgi?id=67896

Reviewed by Pavel Feldman.

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.createCell):

  • inspector/front-end/dataGrid.css:

(.data-grid table.data):
(.data-grid td):

8:20 AM Changeset in webkit [95026] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r95025.
​http://trac.webkit.org/changeset/95025
​https://bugs.webkit.org/show_bug.cgi?id=68005

Test failed on Snow Leopard bots. (Requested by yutak_home on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-09-13

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
6:53 AM QtWebKitFeatures22 edited by Ademar Reis
(diff)
6:52 AM QtWebKitFeatures22 edited by Ademar Reis
(diff)
6:52 AM QtWebKitFeatures22 edited by Ademar Reis
(diff)
6:25 AM Changeset in webkit [95025] by yutak@chromium.org
  • 3 edits in trunk/Source/WebCore

ThreadableWebSocketChannelClientWrapper shouldn't have a String in it.
​https://bugs.webkit.org/show_bug.cgi?id=67908

Reviewed by David Levin.

Replace a String member variable in ThreadableWebSocketChannelClientWrapper with Vector<UChar>.

No change in functionality, thus no new tests. WebSocket worker tests
(tests under http/tests/websocket/tests/{hixie76,hybi}/workers/) should keep passing.

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
Create a String from Vector<UChar>.
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
Copy the content of the given String into Vector.

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
6:00 AM Changeset in webkit [95024] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations

  • platform/chromium/test_expectations.txt: fast/borders/border-image-omit-right-slice.html fails on release
3:39 AM Changeset in webkit [95023] by ukai@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, build fix.

CSSPropertyBorderImage was added in r94989, but not yet added in
WebCore::CSSStyleSelector::applyProperty

CSSStyleSelector.cpp:2481: warning: enumeration value 'CSSPropertyBorderImage' not handled in switch

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

2:33 AM QtWebKitRelease22 edited by Csaba Osztrogonác
Add link to the waterfall of QtWebKit 2.2 buildbots (diff)
1:26 AM Changeset in webkit [95022] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

eventSender.keyDown is unimplemented (WKTR)
​https://bugs.webkit.org/show_bug.cgi?id=57515

Unreviewed gardening.

  • platform/qt-wk2/Skipped:
Note: See TracTimeline for information about the timeline view.