Timeline
Nov 1, 2011:
- 11:26 PM Changeset in webkit [99040] by
-
- 4 edits in trunk/Source/WebCore
Fix uses of LayoutUnit in Frame-, Scroll-, and RenderView
https://bugs.webkit.org/show_bug.cgi?id=71321
Reviewed by Darin Adler.
Updating the usage of LayoutUnits in the *View classes to mirror the proper use
as derived in the subpixellayout branch.
This entails scrolling only with integers (and rounding once we've made the switch)
and using integers for window coordinates, with LayoutUnits for content coordinates.
No new tests -- no change in behavior.
- page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::zoomAnimatorTransformChanged):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::scrollElementToRect):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::scrollTo):
(WebCore::FrameView::updateScrollCorner):
- page/FrameView.h:
(WebCore::FrameView::trackedRepaintRects):
- platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::layoutWidth):
(WebCore::ScrollView::layoutHeight):
(WebCore::ScrollView::fixedLayoutSize):
(WebCore::ScrollView::setFixedLayoutSize):
(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::setContentsSize):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::rectToCopyOnScroll):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::windowToContents):
(WebCore::ScrollView::screenToContents):
(WebCore::ScrollView::scrollbarAtPoint):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
(WebCore::ScrollView::visibleWidth):
(WebCore::ScrollView::visibleHeight):
(WebCore::ScrollView::contentsWidth):
(WebCore::ScrollView::contentsHeight):
(WebCore::ScrollView::adjustScrollPositionWithinRange):
- rendering/RenderView.cpp:
(WebCore::RenderView::paint):
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):
(WebCore::RenderView::documentRect):
- rendering/RenderView.h:
(WebCore::RenderView::printRect):
(WebCore::RenderView::setPrintRect):
- 10:48 PM Changeset in webkit [99039] by
-
- 2 edits in trunk/Source/WebCore
Small fixes for WebVTTParser.
https://bugs.webkit.org/show_bug.cgi?id=71334
Reviewed by Darin Adler.
No new tests. This is needed to enable other tests, coming soon.
- html/track/WebVTTParser.cpp:
(WebCore::hasLongWebVTTIdentifier): changed to return true when header is
exactly "WEBVTT"
(WebCore::WebVTTParser::collectTimingsAndSettings): fix typos, position should
only progress once when checking the character after a timestamp.
- 8:34 PM Changeset in webkit [99038] by
-
- 2 edits1 add1 delete in trunk/LayoutTests/platform
2011-11-01 Kenji Imasaki <imasaki@chromium.org>
[Chromium] Unreviewed. Did rebaselines of media/media-document-audio-repaint.html.
- platform/chromium-gpu-cg-mac/media/media-document-audio-repaint-expected.txt: Removed.
- platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Added.
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png:
- platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt:
- 8:20 PM Changeset in webkit [99037] by
-
- 2 edits in trunk/Tools
resolve-ChangeLogs --help should be faster.
Reviewed by Adam Roben.
- Scripts/resolve-ChangeLogs:
(usageAndExit):
Add a call to usageAndExit() before doing work to find unmerged changelogs
if --help or something illegal is provided on the command line.
- 7:52 PM Changeset in webkit [99036] by
-
- 3 edits in trunk/Source/JavaScriptCore
Cut down on malloc/free a bit in the parser arena
https://bugs.webkit.org/show_bug.cgi?id=71343
Reviewed by Oliver Hunt.
- parser/ParserArena.cpp:
(JSC::ParserArena::deallocateObjects): Call the destructors of
the deletable objects before freeing the pools. Don't call
fastFree on the deletable objects any more.
- parser/ParserArena.h:
(JSC::ParserArena::allocateDeletable): Use allocateFreeable
instead of fastMalloc here.
- 7:47 PM Changeset in webkit [99035] by
-
- 8 edits in trunk/Source
Change HTMLSelectElement::setSelectedIndex to use enums instead of bools
https://bugs.webkit.org/show_bug.cgi?id=70184
Reviewed by Kent Tamura.
Source/WebCore:
Refactoring that does not require new tests.
- bindings/objc/DOMHTML.mm:
(-[DOMHTMLSelectElement _activateItemAtIndex:]): Replaced setSelectedIndexByUser
call with a call to the renamed optionSelectedByUser, also removed one argument.
(-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]): Ditto.
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setSelected): Replaced setSelectedIndex call with a
call to the new optionSelectionStateChanged function.
(WebCore::HTMLOptionElement::insertedIntoTree): Ditto.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::HTMLSelectElement): Updated since m_userDrivenChange
was renamed to m_isProcessingUserDrivenChange.
(WebCore::HTMLSelectElement::optionSelectedByUser): Removed deselect argument,
which was always true for all callers. Updated comment.
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Updated comment.
(WebCore::HTMLSelectElement::setOption): Call the new optionSelectionStateChanged
function. The code used to explicitly ask the function it calls to deselect base
on the value of m_multiple, but that is no longer needed because the selectOption
function itself takes care of that check.
(WebCore::HTMLSelectElement::dispatchChangeEventForMenuList): Renamed this function.
Also updated for name change to m_isProcessingUserDrivenChange.
(WebCore::HTMLSelectElement::setSelectedIndex): Moved the formerly-inlined function
here from the header and changed it to call the renamed selectOption function.
(WebCore::HTMLSelectElement::optionSelectionStateChanged): Added this function.
It is used by callers that were previously using setSelectedIndex and passing
"false" for the deselect argument. It's better now that setSelectedIndex is now a
pure DOM setter function without the multiple purposes it had before. This function
now has the logic that handles the special handling when deselecting an option,
which used to be at the top of the next function.
(WebCore::HTMLSelectElement::selectOption): Renamed this from setSelectedIndex.
Replaced boolean arguments with flags. Removed code to handle the special case
when we deselect an option; that's now handled in the optionSelectionStateChanged
function. Added an assertion to replace a comment and updated for other renaming.
(WebCore::HTMLSelectElement::dispatchBlurEvent): Updated for name change.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Changed to call the
new selectOption function and also updated for other name changes.
(WebCore::HTMLSelectElement::typeAheadFind): Ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.
- html/HTMLSelectElement.h: Changed the setSelectedIndex to be a pure setter
function for the selectedIndex DOM property. Added a optionSelectedByUser function
for the other use of setSelectedIndex, but removed the always true "deselect"
argument from it. Added a optionSelectionStateChanged function for use in the
HTMLOptionElement implementation. Renamed menuListOnChange to
dispatchChangeEventForMenuList for clarity. Added a SelectOptionFlag and
SelectOptionFlags type for the arguments to the selectOption function, formerly
implemented as an overload of setSelectedIndex (and called setSelectedIndexInternal
before that). Renamed m_userDrivenChange to m_isProcessingUserDrivenChange.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::valueChanged): Replaced setSelectedIndexByUser
call with a call to the renamed optionSelectedByUser, also removed one argument.
Source/WebKit/chromium:
- tests/PopupMenuTest.cpp:
(WebKit::TestPopupMenuClient::valueChanged): Replaced setSelectedIndexByUser
call with a call to the renamed optionSelectedByUser, also removed one argument.
- 7:24 PM Changeset in webkit [99034] by
-
- 13 edits in trunk
Implement lookupGetter/lookupSetter in terms of getPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=71336
Reviewed by Darin Adler.
Source/JavaScriptCore:
- debugger/DebuggerActivation.cpp:
- debugger/DebuggerActivation.h:
Remove overrides of lookupGetter/lookupSetter, which are no longer needed
due to implementing getPropertyDescriptor.
- runtime/JSObject.cpp:
(JSC::JSObject::lookupGetter):
(JSC::JSObject::lookupSetter):
- runtime/JSObject.h:
De-virtualize lookupGetter/lookupSetter, and implement them in terms of
getPropertyDescriptor.
Source/WebCore:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSDOMWindowShell.h:
- page/DOMWindow.idl:
Remove overrides of lookupGetter/lookupSetter, which are no longer needed
due to implementing getPropertyDescriptor.
LayoutTests:
- fast/dom/getter-on-window-object2-expected.txt:
Update results now that lookupGetter/lookupSetter match getOwnPropertyDescriptor.
The failures are tracked by https://bugs.webkit.org/show_bug.cgi?id=71333.
- 7:18 PM Changeset in webkit [99033] by
-
- 12 edits in trunk/Source
[chromium] Move resource-releasing logic into CCProxy and cleanup setNeedsCommit
https://bugs.webkit.org/show_bug.cgi?id=71269
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
(WebCore::CCSingleThreadProxy::setVisible):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::CCSingleThreadProxy::setNeedsRedrawOnImplThread):
(WebCore::CCSingleThreadProxy::setNeedsCommitOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsAnimateOnImplThread):
(WebCore::CCThreadProxy::setVisible):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::composite):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
- tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(CCLayerTreeHostTest::dispatchSetNeedsCommit):
(CCLayerTreeHostTestShortlived2::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(CCLayerTreeHostTestScrollSimple::beginTest):
(CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(CCLayerTreeHostTestScrollMultipleRedraw::beginTest):
(CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
- 7:16 PM Changeset in webkit [99032] by
-
- 1 edit2 copies in branches/chromium/912
Merge 98935
BUG=101018
Review URL: http://codereview.chromium.org/8386021
- 7:08 PM Changeset in webkit [99031] by
-
- 4 edits in trunk
[Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
https://bugs.webkit.org/show_bug.cgi?id=71342
Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-11-01
Reviewed by Darin Adler.
Tools:
[NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
[NSString substringFromIndex:] with an index out of the string range.
The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
from the root of the disk.
The problem was hidden because the exception are catched when calling the delegate.
This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
in a subdirectory of the main frame.
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[NSURL _drt_descriptionSuitableForTestResult]):
LayoutTests:
Update the test results following the fix of _drt_descriptionSuitableForTestResult.
- webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt:
- 7:08 PM Changeset in webkit [99030] by
-
- 1 edit2 copies in branches/chromium/912
Merge 98763
BUG=99597
Review URL: http://codereview.chromium.org/8423033
- 7:05 PM Changeset in webkit [99029] by
-
- 1 edit2 copies in branches/chromium/912
Merge 98561
BUG=100526
Review URL: http://codereview.chromium.org/8399045
- 6:53 PM Changeset in webkit [99028] by
-
- 5 edits5 copies in branches/chromium/912
Merge 98033
BUG=99603
Review URL: http://codereview.chromium.org/8372052
- 6:52 PM Changeset in webkit [99027] by
-
- 18 edits2 adds in trunk
Makes [Reflect] work for constants.
This is needed to avoid platform-specific define conflicts, specifically
TextTrack::ERROR conflicts with a windows define.
https://bugs.webkit.org/show_bug.cgi?id=70951
Reviewed by Darin Adler.
Source/WebCore:
Test: media/track/track-constants.html
- bindings/scripts/CodeGenerator.pm:
(GenerateCompileTimeCheckForEnumsIfNeeded):
Check for [Reflect] and assign name accordingly.
- bindings/scripts/test/CPP/WebDOMTestObj.h: Update test file.
- bindings/scripts/test/JS/JSTestObj.cpp: Update test file.
(WebCore::jsTestObjCONST_JAVASCRIPT):
- bindings/scripts/test/JS/JSTestObj.h: Update test file.
- bindings/scripts/test/ObjC/DOMTestObj.h: Update test file.
- bindings/scripts/test/TestObj.idl: Update test file.
- bindings/scripts/test/V8/V8TestObj.cpp: Update test file.
- html/LoadableTextTrack.cpp: Use new DOM const name.
(WebCore::LoadableTextTrack::cueLoadingStarted):
(WebCore::LoadableTextTrack::cueLoadingCompleted):
- html/TextTrack.cpp: Use new DOM const name.
(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setMode):
- html/TextTrack.h: Use new DOM const name.
- html/TextTrack.idl: Use Reflect for ERROR, but leave other DOM const names.
LayoutTests:
- media/track/track-constants-expected.txt: Added.
- media/track/track-constants.html: Added.
- media/track/track-load-error-readyState.html: Updated with new const name.
- media/track/track-load-from-element-readyState.html: Updated with new const name.
- media/track/track-load-from-src-readyState.html: Updated with new const name.
VIDEO_TRACK is not enabled on these ports, so skipping this test:
- platform/mac/Skipped:
- platform/win/Skipped:
- 6:51 PM Changeset in webkit [99026] by
-
- 2 edits2 copies in branches/chromium/912
Merge 98010
BUG=100177
Review URL: http://codereview.chromium.org/8437038
- 6:42 PM Changeset in webkit [99025] by
-
- 1 edit2 copies in branches/chromium/912
Merge 98344
BUG=100863
Review URL: http://codereview.chromium.org/8440026
- 6:33 PM Changeset in webkit [99024] by
-
- 3 edits in trunk/Source/WebCore
Amend missing uses of LayoutUnit in RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=71254
Reviewed by Darin Adler.
Switching relevant uses of integers in RenderBlock to LayoutUnits.
No new tests -- no changes in behavior.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintContents):
(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::getClearDelta):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::baselinePosition):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::availableLogicalWidthForContent):
(WebCore::RenderBlock::FloatWithRect::FloatWithRect):
(WebCore::RenderBlock::MarginInfo::setPositiveMargin):
(WebCore::RenderBlock::MarginInfo::setNegativeMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setMargin):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):
- 6:32 PM Changeset in webkit [99023] by
-
- 1 edit in branches/chromium/912/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp
Merge 98796 - Potential crash in ReplaceNodeWithSpanCommand
https://bugs.webkit.org/show_bug.cgi?id=71145
Reviewed by Ojan Vafai.
Fix a potential crash without tests because we don't have a reduction.
- editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/8437036
- 6:23 PM Changeset in webkit [99022] by
-
- 19 edits2 adds in trunk
WIP: Add CSS property to control printing of backgrounds for individual elements.
https://bugs.webkit.org/show_bug.cgi?id=64583
Reviewed by Eric Seidel.
Added test LayoutTests/fast/css/webkit-color-adjust.html,
Updated tests under LayoutTests/fast/css/getComputedStyle
Updated test under LayoutTests/svg/css
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::initialForceBackgroundsToWhite):
- 6:20 PM Changeset in webkit [99021] by
-
- 9 edits in trunk
Remove initErrorEvent method
https://bugs.webkit.org/show_bug.cgi?id=71338
Reviewed by Ojan Vafai.
Source/WebCore:
- dom/ErrorEvent.cpp: Crush.
- dom/ErrorEvent.h: Kill.
- dom/ErrorEvent.idl: Destroy.
LayoutTests:
- http/tests/workers/worker-importScriptsOnError-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- 6:12 PM Changeset in webkit [99020] by
-
- 5 edits1 add in trunk/Source
Pack RenderTableCell bits
https://bugs.webkit.org/show_bug.cgi?id=71135
Reviewed by Darin Adler.
Source/WebCore:
Tested by RenderTableCellTest unit test.
(unfortunately Chromium specific...)
This saves another 8 bytes on RenderTableCell on x86-64.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
- rendering/RenderTableCell.h:
Changed the field order to use more strict packing.
(WebCore::RenderTableCell::setCol):
(WebCore::RenderTableCell::setRow):
Added overflow checks to the 2 previous methods. We
CRASH even in release to avoid potential badness
(the limit is currently above 2 billions rows or columns
which is high enough to prevent it being hit by accident)
Source/WebKit/chromium:
- WebKit.gypi:
- tests/RenderTableCellTest.cpp: Added.
Added some tests for the column/row index limit
that was implemented in RenderTableCell.
- 5:55 PM Changeset in webkit [99019] by
-
- 3 edits in trunk/Source/WebCore
Switch background/border image back to Int
https://bugs.webkit.org/show_bug.cgi?id=71240
Reviewed by Darin Adler.
Switch background- and border-image rendering back to int to align with
device pixels.
No new tests.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::calculateAdjustedInnerBorder):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize):
- 5:36 PM Changeset in webkit [99018] by
-
- 20 edits in trunk/Source
De-virtualize JSObject::defineSetter
https://bugs.webkit.org/show_bug.cgi?id=71303
Reviewed by Darin Adler.
Source/JavaScriptCore:
Added defineSetter to the MethodTable, changed all the virtual
implementations of defineSetter to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::defineSetter):
- debugger/DebuggerActivation.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/ClassInfo.h:
- runtime/JSCell.cpp:
(JSC::JSCell::defineSetter):
- runtime/JSCell.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::defineSetter):
- runtime/JSGlobalObject.h:
- runtime/JSObject.cpp:
(JSC::JSObject::defineSetter):
(JSC::putDescriptor):
- runtime/JSObject.h:
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineSetter):
Source/WebCore:
No new tests.
Added defineSetter to the MethodTable, changed all the virtual
implementations of defineSetter to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::defineSetter):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::defineSetter):
- bindings/js/JSDOMWindowShell.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- 5:34 PM Changeset in webkit [99017] by
-
- 2 edits in trunk/LayoutTests
SVG Filter on a group doesn't invalidate when children are moved
https://bugs.webkit.org/show_bug.cgi?id=70044
<rdar://problem/10281530>
Reviewed by Darin Adler.
Fix svg/filters/invalidate-on-child-layout.svg to not include nonexistent onload handler.
- svg/filters/invalidate-on-child-layout.svg:
- 5:15 PM Changeset in webkit [99016] by
-
- 9 edits in trunk/Source/WebCore
Switch PopupMenuClient to layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=71308
Reviewed by Darin Adler.
Switch PopupMenuClient and rendering classes implementing it to layout
type abstraction.
No new tests.
- platform/PopupMenuClient.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::listIndexAtOffset):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollToward):
(WebCore::RenderListBox::scrollSize):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::verticalScrollbarWidth):
Revert scroll positions and scroll offsets to ints to align with device
pixels.
- rendering/RenderListBox.h:
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::clientPaddingLeft):
(WebCore::RenderMenuList::clientPaddingRight):
- rendering/RenderMenuList.h:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hitInnerTextElement):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
- rendering/RenderTextControlSingleLine.h:
- 5:09 PM Changeset in webkit [99015] by
-
- 6 edits in trunk/Source
Source/WebCore: [chromium] As of r98380, ThreadableLoaderClients are having their
ResourceRequest::TargetType clobbered. They set their own
type, but CachedResourceRequest (through which they now flow)
sets a TargetType without bothering to see if one has already been set.
https://bugs.webkit.org/show_bug.cgi?id=70972
Reviewed by Darin Fisher.
No new tests, this is chromium-specific and only affects
behavior seen in full builds of chromium.
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::load):Don't setTargetType()
if the value is something other than the default already.
- platform/network/chromium/ResourceRequest.h: Change default
TargetType to TargetIsUnspecified.
Source/WebKit/chromium: Add 2 new TargetTypes (to match ResourceRequest::TargetType)
and ensure we don't pass chromium a TargetType it doesn't
yet understand.
https://bugs.webkit.org/show_bug.cgi?id=70972
Reviewed by Darin Fisher.
- public/WebURLRequest.h:
- src/WebURLRequest.cpp:
- 5:08 PM Changeset in webkit [99014] by
-
- 8 edits in trunk/Source/WebCore
Use IntPoint for screen coordinates in MouseEvent
https://bugs.webkit.org/show_bug.cgi?id=71327
Reviewed by Darin Adler.
Change mouse events to use int/IntPoint for screen/window coordinates and
LayoutUnit/LayoutPoint for coordinates adjusted for zooming.
No new tests.
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::computeRelativePosition):
- dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::screenLocation):
Revert screenLocation and windowLocation back to int.
- page/DragController.cpp:
(WebCore::elementUnderMouse):
Change elementUnderMouse to use a LayoutPoint for hit testing.
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::currentMousePosition):
(WebCore::documentPointForWindowPoint):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
- page/EventHandler.h:
Revert m_currentMousePosition to IntPoint as it represents a
screen coordinate.
- platform/PlatformMouseEvent.h:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(WebCore::PlatformMouseEvent::pos):
(WebCore::PlatformMouseEvent::x):
(WebCore::PlatformMouseEvent::y):
(WebCore::PlatformMouseEvent::globalX):
(WebCore::PlatformMouseEvent::globalY):
- platform/mac/PlatformMouseEventMac.mm:
(WebCore::globalPoint):
(WebCore::pointForEvent):
(WebCore::globalPointForEvent):
Revert PlatformMouseEvent to int/IntPoint as it represents a screen
coordinate.
- 4:58 PM Changeset in webkit [99013] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: -webkit-flex() should be an invalid value
https://bugs.webkit.org/show_bug.cgi?id=71320
Reviewed by Ojan Vafai.
This regressed in http://trac.webkit.org/changeset/98773 .
No new tests, covered by css3/flexbox/flex-parsing.html.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFlex):
- 4:53 PM Changeset in webkit [99012] by
-
- 1 edit1 add in trunk/LayoutTests
Rebaseline getter-on-window-object2.html after r99005.
- platform/chromium/fast/dom/getter-on-window-object2-expected.txt: Added.
- 4:33 PM Changeset in webkit [99011] by
-
- 4 edits in trunk/Source/WebCore
IndexedDB: get EventQueue from ScriptExecutionContext instead of Document
https://bugs.webkit.org/show_bug.cgi?id=71147
When IDB is used from a worker thread ScriptExecutionContext will
be a WorkerContext, not a Document. This was the impetus behind
moving EventQueue into ScriptExecutionContext in r98656.
Reviewed by Nate Chapin.
No new tests. No new functionality yet.
- storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::enqueueEvent):
- storage/IDBRequest.cpp:
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::enqueueEvent):
- storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::enqueueEvent):
- 4:31 PM Changeset in webkit [99010] by
-
- 5 edits in trunk/Source/WebCore
CSS: Remove unused virtual parseString() in style and keyframe rules.
https://bugs.webkit.org/show_bug.cgi?id=71300
Patch by Andreas Kling <kling@webkit.org> on 2011-11-01
Reviewed by Darin Adler.
- css/CSSStyleRule.cpp:
- css/CSSStyleRule.h:
- css/WebKitCSSKeyframeRule.cpp:
- css/WebKitCSSKeyframeRule.h:
- 4:13 PM Changeset in webkit [99009] by
-
- 9 edits3 adds in trunk
DFG inlining breaks function.arguments
https://bugs.webkit.org/show_bug.cgi?id=71329
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
The DFG was forgetting to store code origin mappings for inlined
call sites. Some of the fast-path optimizations for
CallFrame::trueCallerFrame() were wrong. An assertion in Arguments
was wrong.
I also took the opportunity to decrease code duplication between
DFG64 and DFG32_64, because I didn't feel like writing the same
code twice.
- bytecode/CodeBlock.h:
(JSC::ExecState::isInlineCallFrame):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler32_64.cpp:
- dfg/DFGNode.h:
- interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrame):
- interpreter/CallFrame.h:
- runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):
LayoutTests:
Reviewed by Oliver Hunt.
Test that using bar.arguments, where bar was inlined into baz,
works correctly.
- fast/js/dfg-inline-arguments-simple-expected.txt: Added.
- fast/js/dfg-inline-arguments-simple.html: Added.
- fast/js/script-tests/dfg-inline-arguments-simple.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
- 4:02 PM Changeset in webkit [99008] by
-
- 3 edits in trunk/Source/WebCore
Switch RenderObject to layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=71249
Switch RenderObject to LayoutRect/Size/Point abstraction.
Reviewed by Darin Adler.
No new tests.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::addPDFURLRect):
(WebCore::RenderObject::absoluteBoundingBoxRect):
(WebCore::RenderObject::absoluteFocusRingQuads):
(WebCore::RenderObject::addAbsoluteRectForLayer):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::viewRect):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localCaretRect):
(WebCore::RenderObject::addDashboardRegions):
(WebCore::RenderObject::maximalOutlineSize):
(WebCore::RenderObject::adjustRectForOutlineAndShadow):
- rendering/RenderObject.h:
(WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
(WebCore::RenderObject::absoluteClippedOverflowRect):
(WebCore::RenderObject::computeAbsoluteRepaintRect):
(WebCore::RenderObject::absoluteOutlineBounds):
(WebCore::RenderObject::outlineBoundsForRepaint):
(WebCore::adjustForAbsoluteZoom):
- 4:01 PM Changeset in webkit [99007] by
-
- 2 edits in trunk/LayoutTests
Update result to match mac repaint result. When we forced a layout on
the test (when landing the mac-sl results), it caused this result to
change slightly.
- platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:
- 3:53 PM Changeset in webkit [99006] by
-
- 2 edits in trunk/Tools
[chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=71318
Reviewed by James Robinson.
Fixed a typo for --enable-hardware-gpu flag.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 3:36 PM Changeset in webkit [99005] by
-
- 3 edits in trunk/LayoutTests
Expand fast/dom/getter-on-window-object2.html to test Object.getOwnPropertyDescriptor as well
https://bugs.webkit.org/show_bug.cgi?id=71332
Reviewed by Anders Carlsson.
- fast/dom/getter-on-window-object2-expected.txt:
- fast/dom/getter-on-window-object2.html:
Convert to shouldBe style tests and expand test to also test Object.getOwnPropertyDescriptor,
which currently fail for getters/setters defined over window properties.
- 3:32 PM Changeset in webkit [99004] by
-
- 5 edits2 copies in trunk/Source/WebKit/chromium
[chromium] Media Stream API: Adding supporting classes to WebPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=71008
Expanding WebMediaStreamDescriptor and adding WebMediaStreamSource
Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-01
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebMediaStreamDescriptor.h:
- public/WebMediaStreamSource.h: Copied from Source/WebKit/chromium/public/WebMediaStreamDescriptor.h.
(WebKit::WebMediaStreamSource::WebMediaStreamSource):
(WebKit::WebMediaStreamSource::~WebMediaStreamSource):
(WebKit::WebMediaStreamSource::isNull):
- src/AssertMatchingEnums.cpp:
- src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::operator=):
(WebKit::WebMediaStreamDescriptor::initialize):
- src/WebMediaStreamSource.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamDescriptor.cpp.
(WebKit::WebMediaStreamSource::WebMediaStreamSource):
(WebKit::WebMediaStreamSource::reset):
(WebKit::WebMediaStreamSource::operator PassRefPtr<MediaStreamSource>):
(WebKit::WebMediaStreamSource::operator MediaStreamSource*):
(WebKit::WebMediaStreamSource::initialize):
(WebKit::WebMediaStreamSource::id):
(WebKit::WebMediaStreamSource::type):
(WebKit::WebMediaStreamSource::name):
- 3:12 PM Changeset in webkit [99003] by
-
- 2 edits in trunk/LayoutTests
Suppress svg/filters/invalidate-on-child-layout.svg until the fix lands.
- platform/chromium/test_expectations.txt:
- 3:06 PM Changeset in webkit [99002] by
-
- 7 edits in trunk/Source/WebCore
Refactor: change Scrollable::m_scrollOrigin from protected to private.
https://bugs.webkit.org/show_bug.cgi?id=71236
Reviewed by Darin Adler.
Only refactor, no new tests needed.
- page/FrameView.cpp:
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
- platform/ScrollView.cpp:
(WebCore::ScrollView::maximumScrollPosition):
(WebCore::ScrollView::minimumScrollPosition):
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::setScrollOrigin):
(WebCore::ScrollableArea::setScrollOriginX):
(WebCore::ScrollableArea::setScrollOriginY):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::minimumScrollPosition):
(WebCore::RenderLayer::maximumScrollPosition):
(WebCore::RenderLayer::computeScrollDimensions):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::scrollXOffset):
(WebCore::RenderLayer::scrollYOffset):
- 2:54 PM Changeset in webkit [99001] by
-
- 5 edits in tags/Safari-535.7.1/Source
Versioning.
- 2:50 PM Changeset in webkit [99000] by
-
- 2 edits in tags/Safari-535.7.1/Source/WebCore
Merged r98824.
- 2:45 PM Changeset in webkit [98999] by
-
- 1 copy in tags/Safari-535.7.1
New Tag.
- 2:32 PM Changeset in webkit [98998] by
-
- 3 edits in trunk/LayoutTests
Expand prototype setting test to test Object.defineProperty
https://bugs.webkit.org/show_bug.cgi?id=71322
Reviewed by Anders Carlsson.
- fast/js/script-tests/prototypes.js:
Also test setting proto using Object.defineProperty.
- 1:55 PM Changeset in webkit [98997] by
-
- 3 edits2 adds in trunk
display: table-cell and box-sizing: border-box calculates content-box height
https://bugs.webkit.org/show_bug.cgi?id=69425
Reviewed by Dan Bernstein.
Source/WebCore:
Test: fast/box-sizing/table-cell.html
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
LayoutTests:
- fast/box-sizing/table-cell-expected.txt: Added.
- fast/box-sizing/table-cell.html: Added.
- 1:52 PM Changeset in webkit [98996] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed. Remove media/audio-repaint.html from test expectaion.
- platform/chromium/test_expectations.txt:
- 1:40 PM Changeset in webkit [98995] by
-
- 1 copy in tags/Safari-534.52.9
New tag.
- 1:13 PM Changeset in webkit [98994] by
-
- 2 edits in trunk/Source/WebKit/chromium
CCSchedulerTests fail on Chromium Windows (dbg) after r98915
https://bugs.webkit.org/show_bug.cgi?id=71294
Reviewed by James Robinson.
- tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):
- 12:52 PM Changeset in webkit [98993] by
-
- 3 edits in trunk/Source/JavaScriptCore
StringImpl::reallocate() should have a 8-bit version
https://bugs.webkit.org/show_bug.cgi?id=71210
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-11-01
Reviewed by Geoffrey Garen.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::reallocate):
- wtf/text/StringImpl.h:
- 12:28 PM Changeset in webkit [98992] by
-
- 2 edits in trunk/Tools
chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=71286
Patch by Elliot Poger <epoger@google.com> on 2011-11-01
Reviewed by Stephen White.
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- 12:24 PM Changeset in webkit [98991] by
-
- 1 edit35 adds in trunk/LayoutTests
[EFL] Unreviewed. Add remaining pixel baselines.
- platform/efl/http: Added.
- platform/efl/http/tests: Added.
- platform/efl/http/tests/local: Added.
- platform/efl/http/tests/local/file-url-sent-as-referer-expected.png: Added.
- platform/efl/http/tests/misc: Added.
- platform/efl/http/tests/misc/acid2-expected.png: Added.
- platform/efl/http/tests/misc/error404-expected.png: Added.
- platform/efl/http/tests/misc/favicon-as-image-expected.png: Added.
- platform/efl/http/tests/misc/frame-access-during-load-expected.png: Added.
- platform/efl/http/tests/misc/generated-content-inside-table-expected.png: Added.
- platform/efl/http/tests/misc/iframe404-expected.png: Added.
- platform/efl/http/tests/misc/location-replace-crossdomain-expected.png: Added.
- platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
- platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
- platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
- platform/efl/http/tests/navigation: Added.
- platform/efl/http/tests/navigation/error404-basic-expected.png: Added.
- platform/efl/http/tests/navigation/error404-goback-expected.png: Added.
- platform/efl/http/tests/navigation/error404-subframeload-expected.png: Added.
- platform/efl/http/tests/navigation/javascriptlink-frames-expected.png: Added.
- platform/efl/http/tests/navigation/postredirect-basic-expected.png: Added.
- platform/efl/http/tests/navigation/postredirect-goback1-expected.png: Added.
- platform/efl/http/tests/security: Added.
- platform/efl/http/tests/security/contentSecurityPolicy: Added.
- platform/efl/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
- platform/efl/http/tests/uri: Added.
- platform/efl/http/tests/uri/css-href-expected.png: Added.
- platform/efl/scrollbars/basic-scrollbar-expected.png: Added.
- platform/efl/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/efl/scrollbars/disabled-scrollbar-expected.png: Added.
- platform/efl/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
- platform/efl/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
- platform/efl/scrollbars/scrollbar-buttons-expected.png: Added.
- platform/efl/scrollbars/scrollbar-orientation-expected.png: Added.
- platform/efl/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
- 12:18 PM Changeset in webkit [98990] by
-
- 8 edits4 adds in trunk
[chromium] Add testing for --enable-accelerated-drawing
https://bugs.webkit.org/show_bug.cgi?id=70822
Reviewed by James Robinson.
Source/WebCore:
Test: platform/chromium/compositing/accelerated-drawing/alpha.html
- WebCore.exp.in:
- page/Settings.cpp:
- page/Settings.h:
(WebCore::Settings::setAcceleratedDrawingEnabled):
- testing/Internals.cpp:
(WebCore::Internals::setAcceleratedDrawingEnabled):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- platform/chromium/compositing/accelerated-drawing: Added.
- platform/chromium/compositing/accelerated-drawing/alpha-expected.png: Added.
- platform/chromium/compositing/accelerated-drawing/alpha-expected.txt: Added.
- platform/chromium/compositing/accelerated-drawing/alpha.html: Added.
- 12:13 PM Changeset in webkit [98989] by
-
- 4 edits3 adds in trunk
SVG Filter on a group doesn't invalidate when children are moved
https://bugs.webkit.org/show_bug.cgi?id=70044
<rdar://problem/10281530>
Reviewed by Nikolas Zimmermann.
Call SVGResourcesCache::clientLayoutChanged whenever the element or its children need layout. Previously,
invalidation was only performed if the element itself needed layout; now we also invalidate if any child
needs layout and there is a filter applied, as the cached filter result can depend on the layout of children.
Test: svg/filters/invalidate-on-child-layout.svg
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientLayoutChanged):
Add a test that ensures that changing the layout of a child of a filtered element invalidates the filter.
- platform/mac/svg/filters/invalidate-on-child-layout-expected.png: Added.
- platform/mac/svg/filters/invalidate-on-child-layout-expected.txt: Added.
- svg/filters/invalidate-on-child-layout.svg: Added.
- 12:05 PM Changeset in webkit [98988] by
-
- 4 edits in trunk
Four media tests failing on Lion due to incorrect cached times.
https://bugs.webkit.org/show_bug.cgi?id=69574
Reviewed by Eric Carlson.
Source/WebCore:
Do not invalidate the cached time when receiving a mediaPlayerRateChanged notification
while paused. AVFoundation in particular can return different results for currentTime()
when asked after being paused, breaking layout tests.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerRateChanged):
LayoutTests:
Some media engines will cause multiple timeupdate events after pausing; so deregister
the timeupdate event listener after receiving the first one.
- media/video-pause-immediately.html:
- 11:54 AM Changeset in webkit [98987] by
-
- 2 edits in trunk/Source/WebCore
properly end requests when a bad status code return happens
https://bugs.webkit.org/show_bug.cgi?id=71122
Calling error without ending the request set up the CachedResourceRequest so that it could
actually send out two notifyFinished() events. This probably was the root cause of
lots of crashing instability; I know from crbug.com/75604 that this bug was causing lots
of crashes in ScriptRunner/ScriptElement for instance.
The fix is easy: just properly end the request instead of just calling error, and we won't
re-notify.
Reviewed by Nate Chapin.
No new tests, as the problem wasn't very amenable to layout tests.
There is a chromium test going through code review at http://codereview.chromium.org/8404001/
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveData):
- 11:40 AM Changeset in webkit [98986] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Rebaseline after r98896.
- fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
- fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
- platform/chromium-win-vista/fast/forms: Removed.
- platform/chromium/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/win/test_expectations.txt:
- 11:39 AM Changeset in webkit [98985] by
-
- 2 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from CanvasRenderingContext2d
https://bugs.webkit.org/show_bug.cgi?id=64628
Reviewed by Adam Barth.
Covered by existing tests.
- html/canvas/CanvasRenderingContext2D.idl:
- 11:37 AM Changeset in webkit [98984] by
-
- 6 edits1 delete in trunk/LayoutTests
Rebaseline after r98979.
- fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
- fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
- platform/chromium-win-vista/fast/forms: Removed.
- platform/chromium/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/win/test_expectations.txt:
- 11:30 AM Changeset in webkit [98983] by
-
- 8 edits in trunk/Source/WebKit2
[Qt][WK2] Make API tests less noisy
https://bugs.webkit.org/show_bug.cgi?id=71295
Reviewed by Simon Hausmann.
Suppress superfluous debug messages of Qt5.
- UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
- UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(main):
- UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
- UIProcess/API/qt/tests/util.cpp:
(messageHandler):
- UIProcess/API/qt/tests/util.h:
- 11:30 AM Changeset in webkit [98982] by
-
- 1 edit401 adds in trunk/LayoutTests
[EFL] Unreviewed. Add some pixel baselines for tests in fast/.
- platform/efl/fast/table: [...]
- platform/efl/fast/text: [...]
- platform/efl/fast/tokenizer: [...]
- platform/efl/fast/transforms: [...]
- platform/efl/fast/writing-mode: [...]
- platform/efl/fast/xsl: [...]
- 11:07 AM Changeset in webkit [98981] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed. Did rebaselines of media/audio-repaint.html
- platform/chromium-gpu-linux/media/audio-repaint-expected.png:
- 11:02 AM Changeset in webkit [98980] by
-
- 3 edits4 adds in trunk
REGRESSION(98738): RenderTableSection::recalcCells does not properly shrink the RowStruct grid
https://bugs.webkit.org/show_bug.cgi?id=71246
Reviewed by Darin Adler.
Source/WebCore:
Tests: fast/table/crash-empty-section-calcBorder.html
fast/table/crash-empty-section-fixed-layout-calcArray.html
The refactoring in r98738 changed the way we handle the size to avoid throwing off
the memory. The new logic would end up never shrinking the grid's size (prior to that
we would grow to the appropriate size and throw the excess capacity with shrinkToFit).
Not shrinking would mean that we would potentially read RowStruct with the default values
(for instance no |rowRenderer|).
addCell will properly grow the grid as needed to accomodate the rows and the protruding
cells with a rowspan so we introduce a variable to keep track of the size needed. At the
end, we just shrink it to this size.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::recalcCells):
Introduce a variable to keep the grid size and shrink to that size to match the old code.
LayoutTests:
Those tests checks that an empty section would not lead to reading
RowStruct without a |rowRenderer| which would crash.
- fast/table/crash-empty-section-calcBorder-expected.txt: Added.
- fast/table/crash-empty-section-calcBorder.html: Added.
- fast/table/crash-empty-section-fixed-layout-calcArray-expected.txt: Added.
- fast/table/crash-empty-section-fixed-layout-calcArray.html: Added.
- 10:59 AM Changeset in webkit [98979] by
-
- 2 edits in trunk/LayoutTests
Unreviewed followup for the previous commit (removing another duplicate line).
- platform/chromium/test_expectations.txt:
- 10:57 AM Changeset in webkit [98978] by
-
- 4 edits in trunk
[Chromium] Some media/video-*.html layout tests occasionally crash on WIN GPU
https://bugs.webkit.org/show_bug.cgi?id=71277
Reviewed by Simon Fraser.
Source/WebCore:
Disabled assert() in hasVisibleDescendant() until callers are fixed.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::hasVisibleDescendant):
LayoutTests:
- platform/chromium/test_expectations.txt: revert tests marked as crash because of the assert().
- 10:35 AM Changeset in webkit [98977] by
-
- 7 edits in branches/safari-534.52-branch/Source
Merge r98936 and update Versioning.
- 10:31 AM Changeset in webkit [98976] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Unreviewed. Fix ChangeLog which broke in r98733.
- 10:19 AM Changeset in webkit [98975] by
-
- 6 edits in trunk
[Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
https://bugs.webkit.org/show_bug.cgi?id=71299
Reviewed by Andreas Kling.
Source/WebKit/qt:
Export an overload of QtDRT::injectInternalsObjects that is used by
the WK2 injected bundle.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::injectInternalsObject):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
build to enable WebCoreTestSupport::injectInternalsObject.
(WTR::InjectedBundlePage::didClearWindowForFrame):
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
- 10:11 AM Changeset in webkit [98974] by
-
- 1 edit635 adds in trunk/LayoutTests
[EFL] Unreviewed. Add some pixel baselines for tests in fast/.
- platform/efl/fast/media: [...]
- platform/efl/fast/multicol: [...]
- platform/efl/fast/overflow: [...]
- platform/efl/fast/parser: [...]
- platform/efl/fast/reflections: [...]
- platform/efl/fast/regions: [...]
- platform/efl/fast/repaint: [...]
- platform/efl/fast/replaced: [...]
- platform/efl/fast/ruby: [...]
- platform/efl/fast/runin: [...]
- platform/efl/fast/selectors: [...]
- 10:05 AM Changeset in webkit [98973] by
-
- 19 edits2 copies1 add in trunk
[Qt] Merge common desktop and touch view APIs under a base class.
https://bugs.webkit.org/show_bug.cgi?id=71280
Reviewed by Andreas Kling.
Source/WebKit2:
- Make QDesktopWebView and QTouchWebView inherit from QBaseWebView.
- Move methods from QTouchWebPage to QTouchWebView (through the base class).
We use the same convenience macros as Qt internally by hiding QObject::d_ptr
with QBaseWebView::d_ptr instead of inheriting QBaseWebViewPrivate from
QQuickItemPrivate.
Also, QBaseWebView currently inherits from QQuickPaintedItem since QDesktopWebView
needs it, but should be changed as soon as this is not required anymore.
- UIProcess/API/qt/qbasewebview.cpp: Added.
(QBaseWebViewPrivate::QBaseWebViewPrivate):
(QBaseWebViewPrivate::setPageProxy):
(QBaseWebView::QBaseWebView):
(QBaseWebView::~QBaseWebView):
(QBaseWebView::load):
(QBaseWebView::url):
(QBaseWebView::loadProgress):
(QBaseWebView::title):
(QBaseWebView::navigationController):
(QBaseWebView::preferences):
- UIProcess/API/qt/qbasewebview.h: Copied from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h.
- UIProcess/API/qt/qbasewebview_p.h: Copied from Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h.
(QBaseWebViewPrivate::~QBaseWebViewPrivate):
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(QDesktopWebViewPrivate::enableMouseEvents):
(QDesktopWebViewPrivate::disableMouseEvents):
(QDesktopWebViewPrivate::webView):
(QDesktopWebViewPrivate::setViewNeedsDisplay):
(QDesktopWebViewPrivate::drawingAreaSize):
(QDesktopWebViewPrivate::hasFocus):
(QDesktopWebViewPrivate::isVisible):
(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeUrl):
(QDesktopWebViewPrivate::didChangeTitle):
(QDesktopWebViewPrivate::didChangeStatusText):
(QDesktopWebViewPrivate::loadDidBegin):
(QDesktopWebViewPrivate::loadDidSucceed):
(QDesktopWebViewPrivate::loadDidFail):
(QDesktopWebViewPrivate::didChangeLoadProgress):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebViewPrivate::runJavaScriptAlert):
(QDesktopWebViewPrivate::runJavaScriptConfirm):
(QDesktopWebViewPrivate::runJavaScriptPrompt):
(QDesktopWebView::QDesktopWebView):
(QDesktopWebViewPrivate::init):
(QDesktopWebView::~QDesktopWebView):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::paint):
(QDesktopWebView::event):
(QDesktopWebView::pageRef):
(QDesktopWebViewPrivate::processDidCrash):
(QDesktopWebViewPrivate::didRelaunchProcess):
(QDesktopWebViewPrivate::engine):
(QDesktopWebViewPrivate::chooseFiles):
(QDesktopWebViewPrivate::_q_onOpenPanelFilesSelected):
(QDesktopWebViewPrivate::_q_onOpenPanelFinished):
(QDesktopWebViewPrivate::didMouseMoveOverElement):
(QDesktopWebViewPrivate::navigationPolicyForURL):
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qdesktopwebview_p.h:
- UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
(QTouchWebPagePrivate::setPageProxy):
(QTouchWebPagePrivate::paintToCurrentGLContext):
- UIProcess/API/qt/qtouchwebpage.h:
- UIProcess/API/qt/qtouchwebpage_p.h:
(QTouchWebPagePrivate::touchPageProxy):
- UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::init):
(QTouchWebViewPrivate::loadDidCommit):
(QTouchWebViewPrivate::_q_viewportUpdated):
(QTouchWebViewPrivate::_q_viewportTrajectoryVectorChanged):
(QTouchWebViewPrivate::updateViewportConstraints):
(QTouchWebView::QTouchWebView):
(QTouchWebView::~QTouchWebView):
(QTouchWebView::page):
(QTouchWebView::geometryChanged):
(QTouchWebView::onVisibleChanged):
- UIProcess/API/qt/qtouchwebview.h:
- UIProcess/API/qt/qtouchwebview_p.h:
(QTouchWebViewPrivate::touchPageProxy):
- UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
(tst_CommonViewTests::loadNonexistentFileUrl):
- UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::load):
(WebViewAbstraction::url):
(WebViewAbstraction::loadProgress):
(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):
- UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
- UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
(tst_QTouchWebView::navigationStatusAtStartup):
- UIProcess/qt/QtDesktopWebPageProxy.cpp:
(QtDesktopWebPageProxy::createPopupMenuProxy):
- UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::didChangeViewportProperties):
(WebKit::QtTouchViewInterface::didChangeUrl):
(WebKit::QtTouchViewInterface::didChangeTitle):
(WebKit::QtTouchViewInterface::loadDidBegin):
(WebKit::QtTouchViewInterface::loadDidCommit):
(WebKit::QtTouchViewInterface::loadDidSucceed):
(WebKit::QtTouchViewInterface::loadDidFail):
(WebKit::QtTouchViewInterface::didChangeLoadProgress):
- WebKit2API.pri:
Tools:
Remove unneded forwarding logic for TouchWebView since those properties are
now in the view just as the desktop web view.
- MiniBrowser/qt/qml/TouchView.qml:
- 9:51 AM Changeset in webkit [98972] by
-
- 3 edits in trunk/Source/WebKit2
PluginProxy shouldn't use window-relative coordinates
https://bugs.webkit.org/show_bug.cgi?id=71261
Reviewed by Adam Roben.
Change PluginProxy::wantsWindowRelativeCoordinates to return false and remove
m_frameRectInWindowCoordinates and m_clipRectInWindowCoordinates. This is yet another step
towards eliminating window-relative coordinates wherever possible.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
Since the dirty rect passed to paint is now in plug-in coordinates, there's no need to convert it
from window coordinates to plug-in coordinates before passing it to BackingStore::paint.
(WebKit::PluginProxy::deprecatedGeometryDidChange):
Assert that we're not calling this anymore.
(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
Return false.
- 9:45 AM Changeset in webkit [98971] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll chromium DEPS.
Unreviewed.
- DEPS:
- 9:28 AM Changeset in webkit [98970] by
-
- 2 edits in trunk/Source/WebKit/mac
Crash in PDF code when script has illegal UTF-8 or UTF-16 sequences
https://bugs.webkit.org/show_bug.cgi?id=71289
Reviewed by Dan Bernstein.
Just adding a null check. I don't have access to an actual PDF with
this problem but crashes from the field indicate they exist.
- WebView/WebPDFDocumentExtras.mm:
(allScriptsInPDFDocument): Skip the code to add the script text
to an array when the script is null.
- 8:59 AM Changeset in webkit [98969] by
-
- 2 edits in trunk/Source/WebCore
[skia] call readPixels on canvas instead of device (will be private on device soon) and check for error
https://bugs.webkit.org/show_bug.cgi?id=71284
Reviewed by Stephen White.
No new tests. This is preparing for an API change to Skia.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
- 8:56 AM Changeset in webkit [98968] by
-
- 1 edit161 adds in trunk/LayoutTests
[EFL] Unreviewed. Add some pixel baselines for tests in fast/.
- platform/efl/fast/html: [...]
- platform/efl/fast/images: [...]
- platform/efl/fast/inline-block: [...]
- platform/efl/fast/inline: [...]
- platform/efl/fast/innerHTML: [...]
- platform/efl/fast/inspector-support: [...]
- platform/efl/fast/invalid: [...]
- platform/efl/fast/layers: [...]
- platform/efl/fast/lists: [...]
- platform/efl/fast/loader: [...]
- 8:47 AM Changeset in webkit [98967] by
-
- 2 edits in trunk/Source/WebCore
CSSStyleSheet: Operate directly on the rule vector internally.
Rubber-stamped by Antti Koivisto.
There's no need to go through the public, range-checking item() method
working on m_children. Also changed length() -> m_children.size().
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::isLoading):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):
- 8:44 AM Changeset in webkit [98966] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Fixed conflicting entries in test expectations.
- platform/chromium/test_expectations.txt:
- 8:40 AM Changeset in webkit [98965] by
-
- 4 edits in trunk/Source/WebKit2
The QtViewportInteractionEngine should consider DPI adjustment
https://bugs.webkit.org/show_bug.cgi?id=71283
Reviewed by Simon Hausmann.
- UIProcess/API/qt/qtouchwebview.cpp:
Add some default values for now to make sure we are testing the
DPI adjustment / CSS-item space conversion.
(QTouchWebViewPrivate::updateViewportConstraints):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
Clean up the guard to be more understandable.
(WebKit::QtViewportInteractionEngine::cssScaleFromItem):
(WebKit::QtViewportInteractionEngine::itemScaleFromCSS):
Add methods for converting between CSS and item space.
(WebKit::QtViewportInteractionEngine::innerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::outerBoundedCSSScale):
Make it clean which methods uses which coord space.
(WebKit::QtViewportInteractionEngine::updateVisibleRect):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemScale):
Rename calculateBoundariesForScale and change its implementation to
be correct. The new name reflects the space in which the computation
takes place and reflects similar Qt API.
(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):
Make sure to consider the right coord space.
- UIProcess/qt/QtViewportInteractionEngine.h:
(WebKit::QtViewportInteractionEngine::Constraints::Constraints):
Add the devicePixelRatio.
- 8:32 AM Changeset in webkit [98964] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Marked inspector extensions tests as crash on win debug.
- platform/chromium/test_expectations.txt:
- 8:23 AM Changeset in webkit [98963] by
-
- 6 edits in trunk/Source/WebCore
CSSRule: Devirtualize addSubresourceStyleURLs()
https://bugs.webkit.org/show_bug.cgi?id=71285
Reviewed by Antti Koivisto.
Move addSubresourceStyleURLs() into the rules that actually implement it.
Add type checks and casts at the (only) call site.
- css/CSSFontFaceRule.h:
- css/CSSImportRule.h:
- css/CSSRule.h:
- css/CSSStyleRule.h:
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):
- 8:19 AM Changeset in webkit [98962] by
-
- 3 edits2 adds in trunk
AX: some popup buttons not announced by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=67743
Reviewed by Darin Adler.
Source/WebCore:
Test: platform/mac/accessibility/aria-popup-buttons-on-native-elements.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
LayoutTests:
- platform/mac/accessibility/aria-popup-buttons-on-native-elements-expected.txt: Added.
- platform/mac/accessibility/aria-popup-buttons-on-native-elements.html: Added.
- 8:16 AM Changeset in webkit [98961] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 8:02 AM Changeset in webkit [98960] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 7:41 AM Changeset in webkit [98959] by
-
- 2 edits in trunk/Source/WebKit2
Prospective clang build fix.
Reviewed by Andreas Kling.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Handle GestureSingleTap in the event type switch.
- 6:58 AM Changeset in webkit [98958] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-11-01 Pavel Feldman <pfeldman@google.com>
Not reviewed: fix chromium interactive tests.
- src/js/Tests.js: (.TestSuite.prototype.showPanel):
- 6:34 AM Changeset in webkit [98957] by
-
- 3 edits4 adds in trunk/Source/WebKit2
[Qt] Create infrastructure for Qt's builtin bundle in web process.
https://bugs.webkit.org/show_bug.cgi?id=71279
Reviewed by Simon Hausmann.
Create a builtin bundle for Qt port: an InjectedBundle which the code is together
with the Qt's web process instead of being in a different library. This gives us
access to many hooks at web process (using WKBundle* functions of C API) without
adding any maintenance burden to cross-port code.
Since we also use a InjectedBundle in the WebKitTestRunner, we only install our
builtin bundle if there's no other installed. This is fine because WTR won't use
the extra runtime features that we plan to provide with the builtin bundle.
- WebKit2.pro:
- WebProcess/qt/QtBuiltinBundle.cpp: Added.
(WebKit::QtBuiltinBundle::~QtBuiltinBundle):
(WebKit::QtBuiltinBundle::shared):
(WebKit::QtBuiltinBundle::initialize):
(WebKit::QtBuiltinBundle::didCreatePage):
(WebKit::QtBuiltinBundle::willDestroyPage):
(WebKit::QtBuiltinBundle::bundlePageForPageRef):
- WebProcess/qt/QtBuiltinBundle.h: Added.
(WebKit::QtBuiltinBundle::toRef):
Object that holds a WKBundleRef and keeps track of the pages in the current context.
- WebProcess/qt/QtBuiltinBundlePage.cpp: Added.
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
(WebKit::QtBuiltinBundlePage::~QtBuiltinBundlePage):
- WebProcess/qt/QtBuiltinBundlePage.h: Added.
(WebKit::QtBuiltinBundlePage::page):
Our representation for pages from the bundle perspective. This will be the right
place to registering page related clients.
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
If there's no bundle to be loaded, initialize Qt builtin bundle, which will register the
bundle client for this context.
- 6:32 AM Changeset in webkit [98956] by
-
- 5 edits in trunk
Web Inspector: [Styles] Style-based CSS properties are editable and toggleable
https://bugs.webkit.org/show_bug.cgi?id=71275
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):
LayoutTests:
- inspector/styles/styles-source-lines-expected.txt:
- inspector/styles/styles-update-from-js-expected.txt:
- 6:09 AM Changeset in webkit [98955] by
-
- 7 edits2 adds in trunk/LayoutTests
Web Inspector: make extension tests pass on chromium
https://bugs.webkit.org/show_bug.cgi?id=70334
Reviewed by Pavel Feldman.
- http/tests/inspector/extensions-headers.html:
- http/tests/inspector/resources/extension-main.js:
():
- inspector/extensions/extensions-audits.html:
- inspector/extensions/extensions-console.html:
- inspector/extensions/extensions-resources.html:
- platform/chromium/inspector/extensions/extensions-api-expected.txt: Added.
- platform/chromium/inspector/extensions/extensions-eval-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:59 AM Changeset in webkit [98954] by
-
- 2 edits in trunk/LayoutTests
2011-11-01 Pavel Feldman <pfeldman@google.com>
Not reviewed: fix extensions tests.
- http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.showPanel):
- 5:53 AM Changeset in webkit [98953] by
-
- 2 edits in trunk/LayoutTests
2011-11-01 Pavel Feldman <pfeldman@google.com>
Not reviewed: fix inspector extensions tests.
- inspector/extensions/extensions.html:
- 5:36 AM Changeset in webkit [98952] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: do not switch panels on Cmd + -> while in console.
https://bugs.webkit.org/show_bug.cgi?id=71281
Reviewed by Yury Semikhatsky.
- inspector/front-end/InspectorView.js:
(WebInspector.InspectorView.prototype._keyDown):
- 5:34 AM Changeset in webkit [98951] by
-
- 2 edits in trunk/Source/WebKit/qt
Unreviewed Qt documentation fix.
This signal is Qt 4.8 material.
- Api/qwebpage.cpp:
- 4:36 AM Changeset in webkit [98950] by
-
- 3 edits in trunk/Tools
check-webkit-style: Allow names starting with "_q_".
https://bugs.webkit.org/show_bug.cgi?id=70625
Reviewed by Tor Arne Vestbø.
Used by the Qt port as the standard prefix for private slots.
- Scripts/webkitpy/style/checkers/cpp.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- 3:35 AM Changeset in webkit [98949] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 3:29 AM Changeset in webkit [98948] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 3:17 AM Changeset in webkit [98947] by
-
- 2 edits in trunk/Source/WebCore
[Qt] bad codegen, pointer diff in JSC::JSCallbackConstructor::JSCallbackConstructor
https://bugs.webkit.org/show_bug.cgi?id=60951
Adjust symbols visibility for WebCore.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-11-01
Reviewed by Simon Hausmann.
- WebCore.pro:
- 3:14 AM Changeset in webkit [98946] by
-
- 2 edits in trunk/Source/WebCore
2011-11-01 Pavel Feldman <pfeldman@google.com>
Not reviewed: add InspectorView.js entry into WebKit.qrc
- inspector/front-end/WebKit.qrc:
- 3:05 AM Changeset in webkit [98945] by
-
- 29 edits1 add in trunk
Web Inspector: introduce PanelContainer class, start moving panel management from inspector.js to the new class.
https://bugs.webkit.org/show_bug.cgi?id=71272
Reviewed by Yury Semikhatsky.
Source/WebCore:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.sh:
- inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._statusBarDragging):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
(WebInspector.ElementsPanel.prototype.revealAndSelectNode):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.setVisible):
- inspector/front-end/InspectorView.js: Added.
(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype.addPanel):
(WebInspector.InspectorView.prototype.currentPanel):
(WebInspector.InspectorView.prototype._keyDown):
(WebInspector.InspectorView.prototype._canGoBackInHistory):
(WebInspector.InspectorView.prototype._goBackInHistory):
(WebInspector.InspectorView.prototype._canGoForwardInHistory):
(WebInspector.InspectorView.prototype._goForwardInHistory):
(WebInspector.InspectorView.prototype._pushToHistory):
- inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut.eventHasCtrlOrMeta):
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.show):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
- inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateCurrentMatchIndex):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._performSearch):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._createPanels):
(WebInspector._panelSelected):
(WebInspector.addPanel):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):
(WebInspector.documentCanCopy):
(WebInspector.documentCopy):
(WebInspector.showPanel):
(WebInspector.startUserInitiatedDebugging):
(WebInspector.inspect):
(WebInspector._showAnchorLocationInPanel):
(WebInspector._toolbarItemClicked):
- inspector/front-end/treeoutline.js:
(TreeElement.prototype.select):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.expandElementsTree):
- http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
- inspector/debugger/debugger-expand-scope.html:
- inspector/debugger/debugger-proto-property.html:
- inspector/debugger/dom-breakpoints.html:
- inspector/elements/elements-img-tooltip.html:
- inspector/elements/elements-panel-limited-children.html:
- inspector/storage-panel-dom-storage.html:
- inspector/styles/styles-new-API.html:
- inspector/view-css.html:
- inspector/view-events.html:
- 3:02 AM Changeset in webkit [98944] by
-
- 1 edit392 adds in trunk/LayoutTests
[EFL] Unreviewed. Add pixel baselines for fast/ tests.
- platform/efl/fast/doctypes: [...]
- platform/efl/fast/dom: [...]
- platform/efl/fast/dynamic: [...]
- platform/efl/fast/encoding: [...]
- platform/efl/fast/events: [...]
- platform/efl/fast/fast-mobile-scrolling: [...]
- platform/efl/fast/flexbox: [...]
- platform/efl/fast/forms: [...]
- platform/efl/fast/frames: [...]
- platform/efl/fast/gradients: [...]
- 2:54 AM Changeset in webkit [98943] by
-
- 7 edits in trunk/Source
[WK2] Add WebGestureEvents to the Qt build and enable PlatformGestureEvent::TapType
https://bugs.webkit.org/show_bug.cgi?id=71274
Reviewed by Kenneth Christiansen.
Source/WebCore:
- features.pri: Enable GESTURE_EVENTS.
Source/WebKit2:
- Shared/WebEvent.h: Add GestureSingleTap as gesture type.
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent): Support converting
WebEven::GestureSingleTap to PlatformGestureEvent::TapType.
- Shared/WebGestureEvent.cpp:
(WebKit::WebGestureEvent::isGestureEventType): GestureSingleTap is a valid gesture event type.
- WebKit2.pro: Add WebGestureEvent.cpp to the build.
- 2:54 AM Changeset in webkit [98942] by
-
- 2 edits in trunk/Tools
[Qt][WK2] Fix valgrind error about uninitialized variable
https://bugs.webkit.org/show_bug.cgi?id=71273
Reviewed by Kenneth Christiansen.
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify): Initialize isPrimary.
- 12:35 AM Changeset in webkit [98941] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening (fixed platform qualifiers for visibility-image-layers.html)
- platform/chromium/test_expectations.txt:
- 12:24 AM Changeset in webkit [98940] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r98847.
http://trac.webkit.org/changeset/98847
https://bugs.webkit.org/show_bug.cgi?id=71268
"Debugger test failures on multiple platforms" (Requested by
yurys on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-01
Source/WebCore:
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
- inspector/front-end/Script.js:
(WebInspector.Script.prototype.editSource):
LayoutTests:
- inspector/debugger/bind-script-to-resource-expected.txt: Removed.
- inspector/debugger/bind-script-to-resource.html: Removed.
- inspector/debugger/linkifier-expected.txt:
- inspector/debugger/linkifier.html:
- 12:11 AM Changeset in webkit [98939] by
-
- 2 edits in trunk/LayoutTests
2011-11-01 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rebaseline test started failing because syntax errors in inline handlers
are now reported to console.
window.onerror doesn't work with inline (attribute) scripts
https://bugs.webkit.org/show_bug.cgi?id=70991
- fast/js/invalid-syntax-for-function-expected.txt:
Oct 31, 2011:
- 11:52 PM Changeset in webkit [98938] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-cg-mac-leopard/fast/overflow/003-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 11:43 PM Changeset in webkit [98937] by
-
- 20 edits in trunk/Source
The GC should be parallel
https://bugs.webkit.org/show_bug.cgi?id=70995
Source/JavaScriptCore:
Reviewed by Geoff Garen.
Added parallel tracing to the GC. This works by having local mark
stacks per thread, and a global shared one. Threads sometimes
donate cells from the mark stack to the global one if the heuristics
tell them that it's affordable to do so. Threads that have depleted
their local mark stacks try to steal some from the shared one.
Marking is now done using an atomic weak relaxed CAS (compare-and-swap).
This is a 23% speed-up on V8-splay when I use 4 marking threads,
leading to a 3.5% speed-up on V8.
It also appears that this reduces GC pause times on real websites by
more than half.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::markRoots):
- heap/Heap.h:
- heap/MarkStack.cpp:
(JSC::MarkStackSegmentAllocator::MarkStackSegmentAllocator):
(JSC::MarkStackSegmentAllocator::~MarkStackSegmentAllocator):
(JSC::MarkStackSegmentAllocator::allocate):
(JSC::MarkStackSegmentAllocator::release):
(JSC::MarkStackSegmentAllocator::shrinkReserve):
(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::expand):
(JSC::MarkStackArray::refill):
(JSC::MarkStackArray::donateSomeCellsTo):
(JSC::MarkStackArray::stealSomeCellsFrom):
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::~MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::reset):
(JSC::SlotVisitor::donateSlow):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::MarkStack::mergeOpaqueRoots):
(JSC::SlotVisitor::harvestWeakReferences):
- heap/MarkStack.h:
(JSC::MarkStackSegment::data):
(JSC::MarkStackSegment::capacityFromSize):
(JSC::MarkStackSegment::sizeFromCapacity):
(JSC::MarkStackArray::postIncTop):
(JSC::MarkStackArray::preDecTop):
(JSC::MarkStackArray::setTopForFullSegment):
(JSC::MarkStackArray::setTopForEmptySegment):
(JSC::MarkStackArray::top):
(JSC::MarkStackArray::validatePrevious):
(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::mergeOpaqueRootsIfNecessary):
(JSC::MarkStack::mergeOpaqueRootsIfProfitable):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
(JSC::MarkStackArray::append):
(JSC::MarkStackArray::canRemoveLast):
(JSC::MarkStackArray::removeLast):
(JSC::MarkStackArray::isEmpty):
(JSC::MarkStackArray::canDonateSomeCells):
(JSC::MarkStackArray::size):
(JSC::ParallelModeEnabler::ParallelModeEnabler):
(JSC::ParallelModeEnabler::~ParallelModeEnabler):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::testAndSetMarked):
- heap/SlotVisitor.h:
(JSC::SlotVisitor::donate):
(JSC::SlotVisitor::donateAndDrain):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::SlotVisitor):
- heap/WeakReferenceHarvester.h:
- runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
- runtime/Heuristics.h:
- wtf/Atomics.h:
(WTF::weakCompareAndSwap):
- wtf/Bitmap.h:
(WTF::::Bitmap):
(WTF::::get):
(WTF::::set):
(WTF::::testAndSet):
(WTF::::testAndClear):
(WTF::::concurrentTestAndSet):
(WTF::::concurrentTestAndClear):
(WTF::::clear):
(WTF::::clearAll):
(WTF::::nextPossiblyUnset):
(WTF::::findRunOfZeros):
(WTF::::count):
(WTF::::isEmpty):
(WTF::::isFull):
- wtf/MainThread.h:
(WTF::isMainThreadOrGCThread):
- wtf/Platform.h:
- wtf/ThreadSpecific.h:
(WTF::::isSet):
- wtf/mac/MainThreadMac.mm:
(WTF::initializeGCThreads):
(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThreadPlatform):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):
Source/WebCore:
Reviewed by Geoff Garen.
Added parallel tracing to the GC. This required loosening some assertions,
since some code may now be called from outside the main thread.
No new tests, since no behavior was changed.
- platform/TreeShared.h:
(WebCore::TreeShared::parent):
- 10:43 PM Changeset in webkit [98936] by
-
- 2 edits in trunk/Source/WebCore
Document pointer not null-checked in FrameView::isOnActivePage()
https://bugs.webkit.org/show_bug.cgi?id=71265
<rdar://problem/10374427>
Reviewed by Dan Bernstein.
Return false in FrameView::isOnActivePage() if m_frame->document() is
null. Other calls to m_frame->document() in FrameView also have a null
check. The frame can have a null document if the FrameLoader is loading
the initial empty document.
No test possible without triggering assertions in debug builds. This is
tracked by <http://webkit.org/b/71264>.
- page/FrameView.cpp:
(WebCore::FrameView::isOnActivePage):
- 9:24 PM Changeset in webkit [98935] by
-
- 3 edits2 adds in trunk
Source/WebCore: Fix a crash relating to anonymous block merging in
RenderFullScreen::unwrapRenderer.
https://bugs.webkit.org/show_bug.cgi?id=70705
Patch by Jeremy Apthorp <jeremya@google.com> on 2011-10-31
Reviewed by Simon Fraser.
Test: fullscreen/anonymous-block-merge-crash.html
- rendering/RenderFullScreen.cpp:
(RenderFullScreen::unwrapRenderer):
LayoutTests: Test case for a crash relating to merging of anonymous blocks in
RenderFullScreen::unwrapRenderer.
https://bugs.webkit.org/show_bug.cgi?id=70705
Patch by Jeremy Apthorp <jeremya@google.com> on 2011-10-31
Reviewed by Simon Fraser.
- fullscreen/anonymous-block-merge-crash.html: Added.
- 8:37 PM Changeset in webkit [98934] by
-
- 2 edits2 adds in trunk
V8MessageEvent::dataAccessorGetter does not return a reference to its caller
https://bugs.webkit.org/show_bug.cgi?id=71229
Patch by Dave Michael <dmichael@chromium.org> on 2011-10-31
Reviewed by Adam Barth.
Test: fast/events/dispatch-message-string-data.html
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
- 6:47 PM Changeset in webkit [98933] by
-
- 3 edits in trunk/Source/WebCore
[Qt] Build fix after r98853.
Rubber-stamped by Andreas Kling.
- xml/XSLImportRule.cpp:
- xml/XSLImportRule.h:
(WebCore::XSLImportRule::parentStyleSheet):
- 6:15 PM Changeset in webkit [98932] by
-
- 18 edits in trunk/Source
De-virtualize JSObject::defaultValue
https://bugs.webkit.org/show_bug.cgi?id=71146
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Added defaultValue to the MethodTable. Replaced all virtual versions of
defaultValue with static versions. Replaced all call sites with lookups in the
MethodTable.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- runtime/ClassInfo.h:
- runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
- runtime/ExceptionHelpers.h:
- runtime/JSCell.cpp:
(JSC::JSCell::defaultValue):
- runtime/JSCell.h:
- runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::defaultValue):
- runtime/JSNotAnObject.h:
- runtime/JSObject.cpp:
(JSC::JSObject::getPrimitiveNumber):
(JSC::JSObject::defaultValue):
- runtime/JSObject.h:
(JSC::JSObject::toPrimitive):
Source/WebCore:
No new tests.
Added defaultValue to the MethodTable. Replaced all virtual versions of
defaultValue with static versions. Replaced all call sites with lookups in the
MethodTable.
- WebCore.exp.in:
- bridge/objc/objc_runtime.h:
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::defaultValue):
- bridge/runtime_object.h:
- 6:09 PM Changeset in webkit [98931] by
-
- 4 edits in trunk/Source/WebCore
Switch RoundedRect back to integers
https://bugs.webkit.org/show_bug.cgi?id=71238
Reviewed by Darin Adler.
Changing RoundedRect back to ints from LayoutUnits. As further testing has shown, this graphics-
focused class should maintain values aligned to pixel boundaries, and therefor kept as integers.
No new tests -- no change in behavior.
- platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::Radii::scale):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::inflateWithRadii):
(WebCore::RoundedRect::Radii::excludeLogicalEdges):
(WebCore::RoundedRect::RoundedRect):
- platform/graphics/RoundedRect.h:
(WebCore::RoundedRect::Radii::Radii):
(WebCore::RoundedRect::Radii::setTopLeft):
(WebCore::RoundedRect::Radii::setTopRight):
(WebCore::RoundedRect::Radii::setBottomLeft):
(WebCore::RoundedRect::Radii::setBottomRight):
(WebCore::RoundedRect::Radii::topLeft):
(WebCore::RoundedRect::Radii::topRight):
(WebCore::RoundedRect::Radii::bottomLeft):
(WebCore::RoundedRect::Radii::bottomRight):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::Radii::shrink):
(WebCore::RoundedRect::rect):
(WebCore::RoundedRect::setRect):
(WebCore::RoundedRect::move):
(WebCore::RoundedRect::inflate):
(WebCore::RoundedRect::expandRadii):
(WebCore::RoundedRect::shrinkRadii):
- rendering/svg/SVGRenderSupport.h: Adding missing LayoutTypes.h include
- 6:06 PM Changeset in webkit [98930] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=70666
BitmapImage::dataChanged() needs to clear all incomplete frames.
Patch by Peter Kasting <pkasting@google.com> on 2011-10-31
Reviewed by James Robinson.
No tests, as I don't know of a way to send an image to the renderer in
small pieces (with script run between pieces no less).
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::dataChanged):
- 6:01 PM Changeset in webkit [98929] by
-
- 7 edits in trunk/Source/WebCore
Amend missing uses of LayoutUnits in RenderApplet, Button, and DeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=71243
Reviewed by Eric Seidel.
Replacing remaining integer uses with LayoutUnits in the aforementioned classes.
No new tests -- no change in behavior.
- rendering/RenderApplet.cpp:
(WebCore::RenderApplet::intrinsicSize):
(WebCore::RenderApplet::createWidgetIfNecessary):
- rendering/RenderApplet.h:
- rendering/RenderButton.cpp:
(WebCore::RenderButton::controlClipRect):
- rendering/RenderButton.h:
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::marginWidthForChild):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
- rendering/RenderDeprecatedFlexibleBox.h:
- 5:59 PM Changeset in webkit [98928] by
-
- 4 edits in trunk/Source/WebKit2
PluginProxy::Update should pass the painted rect in plug-in coordinates
https://bugs.webkit.org/show_bug.cgi?id=71257
Reviewed by Adam Roben.
This is one step in the process of migrating away from window relative coordinates
and use plug-in relative coordinates instead, since window relative coordinates won't work
with transforms.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
Convert the dirty rect back to plug-in coordinates.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::update):
No need to convert the painted rect back to plug-in coordinates anymore.
- WebProcess/Plugins/PluginProxy.messages.in:
Document that the painted rect is in plug-in coordinates.
- 5:50 PM Changeset in webkit [98927] by
-
- 2 edits in trunk/Tools
Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
leaky builds
Reviewed by Anders Carlsson.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
total of N bytes!").
- 5:43 PM Changeset in webkit [98926] by
-
- 10 edits3 copies2 moves9 adds in trunk/Source
[Chromium] Media Stream API: add the Chromium WebKit interfaces
https://bugs.webkit.org/show_bug.cgi?id=58550
Source/WebCore:
Changes the PeerHandler platform interface so that embedders can more easily use it.
Patch by Tommy Widenflycht <tommyw@google.com> on 2011-10-31
Reviewed by Darin Fisher.
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::PeerConnection):
(WebCore::PeerConnection::didCompleteICEProcessing):
(WebCore::PeerConnection::didGenerateSDP):
(WebCore::PeerConnection::didReceiveDataStreamMessage):
(WebCore::PeerConnection::didAddRemoteStream):
(WebCore::PeerConnection::didRemoveRemoteStream):
- mediastream/PeerConnection.h:
- platform/mediastream/PeerConnectionHandlerClient.h: Copied from Source/WebCore/platform/mediastream/PeerHandler.cpp.
(WebCore::PeerConnectionHandlerClient::~PeerConnectionHandlerClient):
- platform/mediastream/chromium/PeerConnectionHandler.h: Copied from Source/WebCore/platform/mediastream/PeerHandler.h.
- platform/mediastream/gstreamer/PeerConnectionHandler.cpp: Copied from Source/WebCore/platform/mediastream/PeerHandler.cpp.
(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
(WebCore::PeerConnectionHandler::~PeerConnectionHandler):
(WebCore::PeerConnectionHandler::produceInitialOffer):
(WebCore::PeerConnectionHandler::handleInitialOffer):
(WebCore::PeerConnectionHandler::processSDP):
(WebCore::PeerConnectionHandler::processPendingStreams):
(WebCore::PeerConnectionHandler::sendDataStreamMessage):
(WebCore::PeerConnectionHandler::stop):
- platform/mediastream/gstreamer/PeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/PeerHandler.h.
Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
Source/WebKit/chromium:
Adds the bridging code + the minimum amount of Web* supporting code.
Patch by Tommy Widenflycht <tommyw@google.com> on 2011-10-31
Reviewed by Darin Fisher.
- WebKit.gyp:
- bridge/PeerConnectionHandler.cpp: Renamed from Source/WebCore/platform/mediastream/PeerHandler.cpp.
(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
(WebCore::PeerConnectionHandler::~PeerConnectionHandler):
(WebCore::PeerConnectionHandler::produceInitialOffer):
(WebCore::PeerConnectionHandler::handleInitialOffer):
(WebCore::PeerConnectionHandler::processSDP):
(WebCore::PeerConnectionHandler::processPendingStreams):
(WebCore::PeerConnectionHandler::sendDataStreamMessage):
(WebCore::PeerConnectionHandler::stop):
- bridge/PeerConnectionHandlerInternal.cpp: Added.
(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::~PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::PeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::PeerConnectionHandlerInternal::processSDP):
(WebCore::PeerConnectionHandlerInternal::processPendingStreams):
(WebCore::PeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::stop):
(WebCore::PeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::PeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::PeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::PeerConnectionHandlerInternal::didRemoveRemoteStream):
- bridge/PeerConnectionHandlerInternal.h: Added.
- public/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::createPeerConnectionHandler):
- public/WebMediaStreamDescriptor.h: Added.
(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::~WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::isNull):
- public/WebPeerConnectionHandler.h: Added.
(WebKit::WebPeerConnectionHandler::~WebPeerConnectionHandler):
- public/WebPeerConnectionHandlerClient.h: Added.
(WebKit::WebPeerConnectionHandlerClient::~WebPeerConnectionHandlerClient):
- src/WebMediaStreamDescriptor.cpp: Added.
(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::reset):
(WebKit::WebMediaStreamDescriptor::operator=):
(WebKit::WebMediaStreamDescriptor::operator WTF::PassRefPtr<WebCore::MediaStreamDescriptor>):
(WebKit::WebMediaStreamDescriptor::operator WebCore::MediaStreamDescriptor*):
Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
- 5:39 PM Changeset in webkit [98925] by
-
- 2 edits in trunk/Source/WebCore
Fix linker warnings on Windows
- WebCore.vcproj/WebCore.vcproj: Exclude SpellingCorrectionCommand.cpp and
JSRequestAnimationFrameCallback.cpp from all configurations. They are already getting
compiled via *AllInOne.cpp files.
- 5:29 PM Changeset in webkit [98924] by
-
- 7 edits2 deletes in trunk/Source/WebCore
[GStreamer] Don't use GOwnPtr for ref-counted objects
https://bugs.webkit.org/show_bug.cgi?id=71042
Patch by Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> on 2011-10-31
Reviewed by Martin Robinson.
- CMakeListsEfl.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Removed.
- platform/graphics/gstreamer/GOwnPtrGStreamer.h: Removed.
- platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
- 5:29 PM Changeset in webkit [98923] by
-
- 8 edits in trunk/Source/WebKit2
PluginControllerProxy should call Plugin::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71255
Reviewed by Sam Weinig.
Pass enough information over in the GeometryDidChange message sent from
PluginProxy to PluginControllerProxy so that PluginControllerProxy can call
Plugin::geometryDidChange.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
(WebKit::PluginControllerProxy::invalidate):
(WebKit::PluginControllerProxy::paintEntirePlugin):
Update for rename from m_frameRect to m_frameRectInWindowCoordinates.
(WebKit::PluginControllerProxy::geometryDidChange):
This now takes the plug-in size and the plug-in to root view transform as well.
- PluginProcess/PluginControllerProxy.h:
Store the plug-in size and rename m_frameRect to m_frameRectInWindowCoordinates.
- PluginProcess/PluginControllerProxy.messages.in:
Update message signature.
- PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::platformGeometryDidChange):
Use the plug-in size instead of the frame rect size.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- Shared/WebCoreArgumentCoders.h:
Add encoder/decoder for WebCore::AffineTransform.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Compute the frame rect in window coordinates and send it over.
(WebKit::PluginProxy::deprecatedGeometryDidChange):
Move call to geometryDidChange() from here to the new PluginProxy::geometryDidChange.
- 5:27 PM Changeset in webkit [98922] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening; bind-script-to-resource.html times out on chromium mac.
- platform/chromium/test_expectations.txt:
- 5:27 PM Changeset in webkit [98921] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Calling methods of WebFontImpl causes assertions
https://bugs.webkit.org/show_bug.cgi?id=71232
Added FontCachePurgePreventer in several methods.
Patch by Yuzhu Shen <yzshen@google.com> on 2011-10-31
Reviewed by James Robinson.
- src/WebFontImpl.cpp:
(WebKit::WebFontImpl::calculateWidth):
(WebKit::WebFontImpl::offsetForPosition):
(WebKit::WebFontImpl::selectionRectForText):
(WebKit::WebFontImpl::estimateTextBounds):
- 5:21 PM Changeset in webkit [98920] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed holiday gardening after r98852.
4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253
- platform/qt/Skipped: Skip failing tests.
- 5:18 PM Changeset in webkit [98919] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r98918.
http://trac.webkit.org/changeset/98918
https://bugs.webkit.org/show_bug.cgi?id=71256
Wrong commit (Requested by Ossy_weekend on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-31
- platform/qt/Skipped:
- 5:10 PM Changeset in webkit [98918] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed holiday gardening after r98852.
4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253
- platform/qt/Skipped: Skip failing tests.
- 5:01 PM Changeset in webkit [98917] by
-
- 1 edit10 adds in trunk/LayoutTests
[Qt] Unreviewed holiday gardening after r98673 and r98608.
- platform/qt/fast/css/child-style-can-override-visited-style-expected.png: Added.
- platform/qt/fast/css/child-style-can-override-visited-style-expected.txt: Added.
- platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
- platform/qt/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
- platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
- platform/qt/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
- platform/qt/fast/multicol/block-axis-vertical-lr-expected.png: Added.
- platform/qt/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
- platform/qt/fast/multicol/block-axis-vertical-rl-expected.png: Added.
- platform/qt/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
- 4:57 PM Changeset in webkit [98916] by
-
- 3 edits in trunk/Source/JavaScriptCore
Interpreter build fix
Unreviewed build fix
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- 4:56 PM Changeset in webkit [98915] by
-
- 26 edits in trunk/Source
[chromium] Connect CCThreadProxy to FrameRateController and SchedulerStateMachine via CCScheduler
https://bugs.webkit.org/show_bug.cgi?id=71100
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHostClient::didCommitAndDrawFrame):
(WebCore::CCLayerTreeHost::didCommitAndDrawFrame):
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCSchedulerFrameRateControllerClientAdapter::create):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::~CCSchedulerFrameRateControllerClientAdapter):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::beginFrame):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::CCSchedulerFrameRateControllerClientAdapter):
(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::~CCScheduler):
(WebCore::CCScheduler::setNeedsAnimate):
(WebCore::CCScheduler::setNeedsCommit):
(WebCore::CCScheduler::setNeedsRedraw):
(WebCore::CCScheduler::beginFrameComplete):
(WebCore::CCScheduler::didSwapBuffersComplete):
(WebCore::CCScheduler::didSwapBuffersAbort):
(WebCore::CCScheduler::onBeginFrame):
(WebCore::CCScheduler::processScheduledActions):
- platform/graphics/chromium/cc/CCScheduler.h:
(WebCore::CCScheduler::create):
(WebCore::CCScheduler::commitPending):
(WebCore::CCScheduler::redrawPending):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::beginUpdateMoreResourcesComplete):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(WebCore::CCSchedulerStateMachine::redrawPending):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::hasMoreUpdates):
- platform/graphics/chromium/cc/CCTextureUpdater.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::setNeedsAnimateOnImplThread):
(WebCore::CCThreadProxy::setNeedsCommitOnImplThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnImplThread):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::hasMoreResourceUpdates):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::scheduledActionCommit):
(WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread):
(WebCore::CCThreadProxy::didCommitAndDrawFrame):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- tests/CCSchedulerStateMachineTest.cpp:
(WebCore::StateMachine::setUpdateMoreResourcesPending):
(WebCore::StateMachine::updateMoreResourcesPending):
(WebCore::TEST):
- tests/CCSchedulerTest.cpp:
- 4:53 PM Changeset in webkit [98914] by
-
- 1 copy in tags/Safari-534.52.8
New tag.
- 4:52 PM Changeset in webkit [98913] by
-
- 11 edits44 adds in trunk/LayoutTests
[Qt] Unreviewed holiday gardening after r98852.
CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156
- platform/qt/css1/text_properties/vertical_align-expected.png:
- platform/qt/css1/text_properties/vertical_align-expected.txt:
- platform/qt/css2.1/20110323/background-intrinsic-001-expected.png: Added.
- platform/qt/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
- platform/qt/css2.1/20110323/background-intrinsic-002-expected.png: Added.
- platform/qt/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
- platform/qt/css2.1/20110323/background-intrinsic-003-expected.png: Added.
- platform/qt/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
- platform/qt/css2.1/20110323/background-intrinsic-004-expected.png: Added.
- platform/qt/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
- platform/qt/css2.1/20110323/background-intrinsic-005-expected.png: Added.
- platform/qt/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
- platform/qt/css2.1/20110323/background-intrinsic-006-expected.png: Added.
- platform/qt/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
- platform/qt/css2.1/20110323/background-intrinsic-007-expected.png: Added.
- platform/qt/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
- platform/qt/css2.1/20110323/background-intrinsic-008-expected.png: Added.
- platform/qt/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
- platform/qt/css2.1/20110323/background-intrinsic-009-expected.png: Added.
- platform/qt/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
- platform/qt/fast/block/float/015-expected.png:
- platform/qt/fast/block/float/015-expected.txt:
- platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt:
- platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
- platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
- platform/qt/svg/as-background-image/background-image-tiled-expected.png: Added.
- platform/qt/svg/as-background-image/background-image-tiled-expected.txt: Added.
- platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
- platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
- platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
- platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/qt/svg/as-image/same-image-two-instances-expected.png: Added.
- platform/qt/svg/as-image/same-image-two-instances-expected.txt: Added.
- platform/qt/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
- platform/qt/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
- platform/qt/svg/as-image/svg-image-change-content-size-expected.png: Added.
- platform/qt/svg/as-image/svg-image-change-content-size-expected.txt: Added.
- platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
- platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-foreignObject-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-as-image-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- 4:50 PM Changeset in webkit [98912] by
-
- 21 edits in trunk/Source/JavaScriptCore
DFG OSR exits should add to value profiles
https://bugs.webkit.org/show_bug.cgi?id=71202
Reviewed by Oliver Hunt.
Value profiles now have an extra special slot not used by the old JIT's
profiling, which is reserved for OSR exits.
The DFG's OSR exit code now knows which register, node index, and value
profiling site was responsible for the (possibly flawed) information that
led to the OSR failure. This is somewhat opportunistic and imperfect;
if there's a lot of control flow between the value profiling site and the
OSR failure point, then this mechanism simply gives up. It also gives up
if the OSR failure is caused by either known deficiencies in the DFG
(like that we always assume that the index in a strict charCodeAt access
is within bounds) or where the OSR failure would be catalogues and
profiled through other means (like slow case counters).
This patch also adds the notion of a JSValueRegs, which is either a
single register in JSVALUE64 or a pair in JSVALUE32_64. We should
probably move the 32_64 DFG towards using this, since it often makes it
easier to share code between 64 and 32_64.
Also fixed a number of pathologies that this uncovered. op_method_check
didn't have a value profiling site on the slow path. GetById should not
always force OSR exit if it never executed in the old JIT; we may be
able to infer its type if it's a array or string length get. Finally,
these changes benefit from a slight tweak to optimization delay
heuristics (profile fullness is now 0.35 instead of 0.25).
3.8% speed-up on Kraken, mostly due to ~35% on both stanford-crypto-aes
and imaging-darkroom.
- bytecode/ValueProfile.cpp:
(JSC::ValueProfile::computeStatistics):
(JSC::ValueProfile::computeUpdatedPrediction):
- bytecode/ValueProfile.h:
(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::specFailBucket):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::numberOfObjects):
(JSC::ValueProfile::numberOfFinalObjects):
(JSC::ValueProfile::numberOfStrings):
(JSC::ValueProfile::numberOfArrays):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGPRInfo.h:
(JSC::DFG::JSValueRegs::JSValueRegs):
(JSC::DFG::JSValueRegs::operator!):
(JSC::DFG::JSValueRegs::gpr):
(JSC::DFG::JSValueSource::JSValueSource):
(JSC::DFG::JSValueSource::unboxedCell):
(JSC::DFG::JSValueSource::operator!):
(JSC::DFG::JSValueSource::isAddress):
(JSC::DFG::JSValueSource::offset):
(JSC::DFG::JSValueSource::base):
(JSC::DFG::JSValueSource::gpr):
(JSC::DFG::JSValueSource::asAddress):
(JSC::DFG::JSValueSource::notAddress):
(JSC::DFG::JSValueRegs::tagGPR):
(JSC::DFG::JSValueRegs::payloadGPR):
(JSC::DFG::JSValueSource::tagGPR):
(JSC::DFG::JSValueSource::payloadGPR):
(JSC::DFG::JSValueSource::hasKnownTag):
(JSC::DFG::JSValueSource::tag):
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::jsValueRegs):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::valueProfileFor):
- dfg/DFGJITCodeGenerator.h:
(JSC::JSValueOperand::jsValueRegs):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::valueProfileFor):
- dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_method_check):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_method_check):
- runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
- runtime/JSValue.h:
- 4:49 PM Changeset in webkit [98911] by
-
- 9 edits in trunk/Source/WebCore
Rename the remaining uses of Cue in WebCore/loader/
to TextTrack.
https://bugs.webkit.org/show_bug.cgi?id=71231
Reviewed by Eric Carlson.
No new tests, strictly a renaming.
- loader/TextTrackLoader.cpp:
- loader/cache/CachedResource.cpp:
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedResourceRequest.cpp:
- loader/cache/CachedTextTrack.cpp:
- platform/network/chromium/ResourceRequest.h:
- 4:46 PM Changeset in webkit [98910] by
-
- 8 edits in trunk
[MutationObservers] Support characterDataOldValue for characterData mutations
https://bugs.webkit.org/show_bug.cgi?id=70862
Reviewed by Ojan Vafai.
Source/WebCore:
- dom/CharacterData.cpp:
(WebCore::hasOldValue):
(WebCore::isOldValueRequested):
(WebCore::CharacterData::dispatchModifiedEvent):
- dom/MutationRecord.cpp:
(WebCore::MutationRecord::createCharacterData):
- dom/MutationRecord.h:
LayoutTests:
Added oldValue test cases to existing characterData tests.
- fast/mutation/observe-characterdata-expected.txt:
- fast/mutation/observe-characterdata.html:
- 4:43 PM Changeset in webkit [98909] by
-
- 16 edits1 add in trunk/Source
Remove need for virtual JSObject::unwrappedObject
https://bugs.webkit.org/show_bug.cgi?id=71034
Reviewed by Geoffrey Garen.
- JavaScriptCore.exp:
Update exports.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
Add JSGlobalThis.cpp.
- runtime/JSGlobalThis.cpp: Added.
(JSC::JSGlobalThis::visitChildren):
(JSC::JSGlobalThis::unwrappedObject):
- runtime/JSGlobalThis.h:
(JSC::JSGlobalThis::createStructure):
Move underlying object from JSDOMWindowShell down to JSGlobalThis
and corresponding visitChildren method.
- runtime/JSObject.cpp:
(JSC::JSObject::unwrappedObject):
Change unwrappedObject from virtual, to just needing an if check.
- runtime/JSObject.h:
(JSC::JSObject::isGlobalThis):
- runtime/JSType.h:
Add isGlobalThis predicate and type.
../WebCore:
Move the member containing the global object from the JSDOMWindowShell
down to the JSGlobalThis class, and update JSDOMWindowShell to go through
an inline helper (which just casts) to get the window.
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::className):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putWithAttributes):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):
(WebCore::JSDOMWindowShell::getPropertyNames):
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
(WebCore::JSDOMWindowShell::defineGetter):
(WebCore::JSDOMWindowShell::defineSetter):
(WebCore::JSDOMWindowShell::lookupGetter):
(WebCore::JSDOMWindowShell::lookupSetter):
(WebCore::JSDOMWindowShell::impl):
- bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::createStructure):
- 4:40 PM Changeset in webkit [98908] by
-
- 5 edits in trunk
[EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
https://bugs.webkit.org/show_bug.cgi?id=71228
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-31
Reviewed by Antonio Gomes.
Source/WebKit/efl:
r93833 has introduced
ewk_view_setting_scripts_can_close_windows_{get,set}, but its
counterpart to allow scripts to open windows kept its weird name.
This makes the functions to allow windows to open and close windows to
have confusingly different name patterns.
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_open_windows_get):
(ewk_view_setting_scripts_can_open_windows_set):
- ewk/ewk_view.h:
Tools:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createNewWindow):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- 4:38 PM Changeset in webkit [98907] by
-
- 3 edits in trunk/Source/WebKit2
Remove some uses of m_frameRectInWindowCoordinates from PluginProxy
https://bugs.webkit.org/show_bug.cgi?id=71252
Reviewed by Darin Adler.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::updateBackingStore):
(WebKit::PluginProxy::pluginBounds):
- WebProcess/Plugins/PluginProxy.h:
- 4:34 PM Changeset in webkit [98906] by
-
- 5 edits in branches/safari-534.52-branch/Source
Versioning.
- 4:28 PM Changeset in webkit [98905] by
-
- 3 edits in trunk/Source/WebKit2
Implement PluginProxy::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71251
Reviewed by Sam Weinig.
Keep track of the plug-in size, the clip rect in plug-in coordinates and the
transformation matrix from the root view to the plug-in.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
- WebProcess/Plugins/PluginProxy.h:
- 4:19 PM Changeset in webkit [98904] by
-
- 2 edits in branches/safari-534.52-branch/Source/WebCore
Updated fix for r98470.
- 4:18 PM Changeset in webkit [98903] by
-
- 2 edits in trunk/Source/JavaScriptCore
WTF::StringImpl::create(const char*, unsigned) calls itself
https://bugs.webkit.org/show_bug.cgi?id=71206
The original implementation just calls itself, causing infinite recursion.
Cast the first parameter to const LChar* to fix that.
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-10-31
Reviewed by Ryosuke Niwa.
- wtf/text/StringImpl.h:
(WTF::StringImpl::create):
- 4:18 PM Changeset in webkit [98902] by
-
- 7 edits5 adds1 delete in trunk/LayoutTests
Chromium rebaselines, unreviewed.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/chromium-gpu-win/media/audio-repaint-expected.txt: Removed.
- platform/chromium-linux-x86/svg/zoom/page: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:12 PM Changeset in webkit [98901] by
-
- 2 edits in trunk/LayoutTests
Mac rebaseline after r98852.
- platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- 4:09 PM Changeset in webkit [98900] by
-
- 4 edits in trunk/Source/WebKit/chromium
IndexedDB: Remove null key support (part 2)
https://bugs.webkit.org/show_bug.cgi?id=71132
Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-31
Reviewed by Darin Fisher.
- public/WebIDBKey.h:
- src/AssertMatchingEnums.cpp:
- src/WebIDBKey.cpp:
- 4:09 PM Changeset in webkit [98899] by
-
- 14 edits4 adds in trunk
WebKit nests pre on copy and paste when the pre is the root editable element
https://bugs.webkit.org/show_bug.cgi?id=70800
Reviewed by Darin Adler.
Source/WebCore:
Fixed the bug by removing nested block elements in removeRedundantStylesAndKeepStyleSpanInline.
Tests: editing/pasteboard/contenteditable-pre-2.html
editing/pasteboard/contenteditable-pre.html
- editing/ApplyStyleCommand.cpp:
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Remove block
elements if it's identical to its parent and there are no contents between the two. Also remove
contenteditable attribute from an element if the parent is already richly editable.
(WebCore::ReplaceSelectionCommand::doApply): Remove redundant styles after removing the placeholder
br so that the above check doesn't get affected by the placeholder.
- editing/htmlediting.cpp:
(WebCore::areIdenticalElements): Moved from ApplyStyleCommand.
(WebCore::isNonTableCellHTMLBlockElement): Moved from markup.cpp.
- editing/htmlediting.h:
- editing/markup.cpp:
LayoutTests:
Added tests for copying and pasting contents inside pre. WebKit should not nest pre's.
- editing/execCommand/insert-list-with-noneditable-content-expected.txt: A redundant
contenteditable attribute is removed.
- editing/pasteboard/4930986-2-expected.txt: Trailing space in style attribute is removed.
- editing/pasteboard/contenteditable-pre-2-expected.txt: Added.
- editing/pasteboard/contenteditable-pre-2.html: Added.
- editing/pasteboard/contenteditable-pre-expected.txt: Added.
- editing/pasteboard/contenteditable-pre.html: Added.
- editing/pasteboard/copy-null-characters-expected.txt: A redundant contenteditable attribute
is removed.
- editing/pasteboard/paste-code-in-pre-expected.txt: Pre no longer nests itself erroneously.
- editing/pasteboard/paste-pre-001-expected.txt: Ditto.
- editing/pasteboard/paste-pre-002-expected.txt: Ditto.
- editing/selection/4895428-4-expected.txt: A redundant contenteditable attribute is removed.
- 4:08 PM Changeset in webkit [98898] by
-
- 2 edits in trunk/Source/WebKit2
Fix the X11 build.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
- 4:07 PM Changeset in webkit [98897] by
-
- 3 edits in trunk/Source/WebKit2
Factor code to resize the plug-in backing store out into a separate function
https://bugs.webkit.org/show_bug.cgi?id=71250
Reviewed by Adam Roben.
Add a PluginProxy::contentsScaleFactor helper function to get rid of a bunch of PLATFORM(MAC) #ifdefs,
and move the code to update the backing store out into a separate function.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::contentsScaleFactor):
(WebKit::PluginProxy::updateBackingStore):
(WebKit::PluginProxy::update):
- WebProcess/Plugins/PluginProxy.h:
- 4:02 PM Changeset in webkit [98896] by
-
- 15 edits5 adds in trunk
text/plain form encoding ignored and incorrectly specified in request header.
https://bugs.webkit.org/show_bug.cgi?id=20795
Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-10-31
Reviewed by Darin Adler.
Source/WebCore:
This patch fixes the behaviour of forms where enctype is set to
text/plain, encoding is also text/plain.
Tests: fast/forms/form-get-textplain.html
http/tests/misc/form-post-textplain.html
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- platform/network/FormData.cpp:
(WebCore::FormData::create):
(WebCore::FormData::appendKeyValuePairItems):
- platform/network/FormData.h:
(WebCore::FormData::parseEncodingType):
- platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::addKeyValuePairAsFormData): Modified encoding scheme for text/plain.
- platform/network/FormDataBuilder.h:
LayoutTests:
Added tests for GET and POST methods for text/plain enctype.
Forms submitted using GET with a content-type of text/plain actually,
send data in URL encoded in the URL.
Forms with POST method and content-type of text/plain actually send data in text/plain.
Modified expected results for mailto tests as per the new behavior.
- fast/forms/form-get-textplain-expected.txt: Added.
- fast/forms/form-get-textplain.html: Added.
- fast/forms/mailto/post-multiple-items-text-plain-expected.txt:
- fast/forms/mailto/post-text-plain-expected.txt:
- fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt:
- http/tests/misc/form-post-textplain-expected.txt: Added.
- http/tests/misc/form-post-textplain.html: Added.
- http/tests/misc/resources/form-post-textplain.php: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
- platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
- platform/qt/test_expectations.txt:
- platform/win/test_expectations.txt:
- 4:00 PM Changeset in webkit [98895] by
-
- 2 edits in trunk/Source/WebCore
RenderImage.cpp calls SVGImage even if it's not defined
https://bugs.webkit.org/show_bug.cgi?id=71247
This fixes a compile error when ENABLE_SVG=0.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::embeddedContentBox):
- 3:55 PM Changeset in webkit [98894] by
-
- 4 edits in trunk/Source/WebKit2
Add more APIs to WKUserContentURLPattern.h
https://bugs.webkit.org/show_bug.cgi?id=71245
Add additional WKUserContentURLPattern APIs to match what was provided by
the equivalent WebKit1 API.
Reviewed by Darin Adler.
- Shared/API/c/WKUserContentURLPattern.cpp:
(WKUserContentURLPatternCopyHost): Added.
(WKUserContentURLPatternCopyScheme): Added.
(WKUserContentURLPatternIsValid): Added.
(WKUserContentURLPatternMatchesSubdomains): Added.
- Shared/API/c/WKUserContentURLPattern.h: Added new APIs.
- Shared/WebUserContentURLPattern.h:
(WebKit::WebUserContentURLPattern::host): Added.
(WebKit::WebUserContentURLPattern::scheme): Added.
(WebKit::WebUserContentURLPattern::isValid): Added.
(WebKit::WebUserContentURLPattern::matchesSubdomains): Added.
- 3:52 PM Changeset in webkit [98893] by
-
- 2 edits in trunk/Source/WebCore
Update XMLHttpRequest.send idl declaration to match implementation.
https://bugs.webkit.org/show_bug.cgi?id=71121
Reviewed by Adam Barth.
- xml/XMLHttpRequest.idl:
- 3:51 PM Changeset in webkit [98892] by
-
- 6 edits in trunk/Source
More work on making plug-ins work better with transforms
https://bugs.webkit.org/show_bug.cgi?id=71241
Reviewed by Darin Adler.
Source/WebCore:
Export symbols used by WebKit2.
- WebCore.exp.in:
Source/WebKit2:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):
Implement NetscapePlugin::geometryDidChange and store the plug-in size,
the clip rect and the root view transform. Use the transform to compute the window
relative frame and clip rects.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add new member variables.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewGeometryDidChange):
Always call the new Plugin::geometryDidChange.
- 3:38 PM Changeset in webkit [98891] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix DFG JIT compilation on Linux targets.
https://bugs.webkit.org/show_bug.cgi?id=70904
Patch by Andy Wingo <wingo@igalia.com> on 2011-10-31
Reviewed by Darin Adler.
- jit/JITStubs.cpp (SYMBOL_STRING_RELOCATION): Simplify this
macro.
- dfg/DFGOperations.cpp (SYMBOL_STRING_RELOCATION): Copy the
simplified definition from jit/JITStubs.cpp.
(FUNCTION_WRAPPER_WITH_RETURN_ADDRESS, getHostCallReturnValue):
Use the macro to access trampoline targets through the PLT on PIC
systems, instead of introducing a text relocation. Otherwise, the
library fails to link.
- 3:31 PM Changeset in webkit [98890] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Make cache flush when max size of cache has been changed
https://bugs.webkit.org/show_bug.cgi?id=70805
Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-10-31
Reviewed by Ryosuke Niwa.
Calls the ewk_tile_unused_cache_auto_flush function after changing max
size of cache when ewk_tile_unused_cache_max_set is called. Without
this change when new value is lower than the old one the cache may use
more memory than max value set. This situation is not expected by the
user.
- ewk/ewk_tiled_model.cpp:
(ewk_tile_unused_cache_max_set):
- 3:24 PM Changeset in webkit [98889] by
-
- 23 edits in trunk/Source
De-virtualize JSObject::defineGetter
https://bugs.webkit.org/show_bug.cgi?id=71134
Reviewed by Darin Adler.
Source/JavaScriptCore:
Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter
with static versions. Replaced all call sites with lookups in the MethodTable.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::defineGetter):
- debugger/DebuggerActivation.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/ClassInfo.h:
- runtime/JSCell.cpp:
(JSC::JSCell::defineGetter):
- runtime/JSCell.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::defineGetter):
- runtime/JSGlobalObject.h:
- runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::putDescriptor):
- runtime/JSObject.h:
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineGetter):
Source/WebCore:
No new tests.
Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter
with static versions. Replaced all call sites with lookups in the MethodTable.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::defineGetter):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::defineGetter):
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::defineGetter):
(WebCore::JSLocationPrototype::defineGetter):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
Source/WebKit/qt:
Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter
with static versions. Replaced all call sites with lookups in the MethodTable.
- Api/qwebframe.cpp:
(QWebFramePrivate::addQtSenderToGlobalObject):
- 3:22 PM Changeset in webkit [98888] by
-
- 3 edits4 adds in trunk
Microdata: Support for itemid attribute.
https://bugs.webkit.org/show_bug.cgi?id=71007
Patch by Arko Saha <arko@motorola.com> on 2011-10-31
Reviewed by Ryosuke Niwa.
Source/WebCore:
itemid attribute: To give a global identifier for the Microdata items.
The itemid attribute, if specified, must have a value that is a valid URL potentially
surrounded by spaces.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html#attr-itemid
Tests: fast/dom/MicroData/itemid-attribute-test.html
fast/dom/MicroData/itemid-must-see-resolved-url.html
- html/HTMLElement.idl:
LayoutTests:
Added test-cases for itemid attribute.
- fast/dom/MicroData/itemid-attribute-test-expected.txt: Added.
- fast/dom/MicroData/itemid-attribute-test.html: Added.
- fast/dom/MicroData/itemid-must-see-resolved-url-expected.txt: Added.
- fast/dom/MicroData/itemid-must-see-resolved-url.html: Added.
- 3:13 PM Changeset in webkit [98887] by
-
- 24 edits1 add2 deletes in trunk/Source/JavaScriptCore
Towards 8-bit Strings: Move Lexer and Parser Objects out of JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=71138
Restructure and movement of Lexer and Parser code.
Moved Lexer and Parser objects out of JSGlobalData.
Added a new ParserTokens class and instance to JSGlobalData that
have JavaScript token related definitions.
Replaced JSGlobalData arguments to Node classes with lineNumber,
as that was the only use of the JSGlobalData.
Combined JSParser and Parser classes into one class,
eliminating JSParser.h and .cpp.
Various supporting #include changes.
These mostly mechanical changes are done in preparation to
making the Lexer and Parser template classes.
Reviewed by Darin Adler.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::createSourceElements):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArguments):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createElementList):
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createClause):
(JSC::ASTBuilder::createClauseList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::appendBinaryOperation):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
- parser/JSParser.cpp: Removed.
- parser/JSParser.h: Removed.
- parser/Lexer.cpp:
(JSC::Keywords::Keywords):
(JSC::Lexer::Lexer):
(JSC::Lexer::~Lexer):
(JSC::Lexer::setCode):
(JSC::Lexer::parseIdentifier):
- parser/Lexer.h:
(JSC::Keywords::isKeyword):
(JSC::Keywords::getKeyword):
(JSC::Keywords::~Keywords):
(JSC::Lexer::setIsReparsing):
(JSC::Lexer::isReparsing):
(JSC::Lexer::lineNumber):
(JSC::Lexer::setLastLineNumber):
(JSC::Lexer::lastLineNumber):
(JSC::Lexer::prevTerminator):
(JSC::Lexer::sawError):
(JSC::Lexer::getErrorMessage):
(JSC::Lexer::currentOffset):
(JSC::Lexer::setOffset):
(JSC::Lexer::setLineNumber):
(JSC::Lexer::sourceProvider):
(JSC::Lexer::isWhiteSpace):
(JSC::Lexer::isLineTerminator):
(JSC::Lexer::convertHex):
(JSC::Lexer::convertUnicode):
(JSC::Lexer::makeIdentifier):
(JSC::Lexer::lexExpectIdentifier):
- parser/NodeConstructors.h:
(JSC::ParserArenaFreeable::operator new):
(JSC::ParserArenaDeletable::operator new):
(JSC::ParserArenaRefCounted::ParserArenaRefCounted):
(JSC::Node::Node):
(JSC::ExpressionNode::ExpressionNode):
(JSC::StatementNode::StatementNode):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::RegExpNode::RegExpNode):
(JSC::ThisNode::ThisNode):
(JSC::ResolveNode::ResolveNode):
(JSC::ElementNode::ElementNode):
(JSC::ArrayNode::ArrayNode):
(JSC::PropertyNode::PropertyNode):
(JSC::PropertyListNode::PropertyListNode):
(JSC::ObjectLiteralNode::ObjectLiteralNode):
(JSC::BracketAccessorNode::BracketAccessorNode):
(JSC::DotAccessorNode::DotAccessorNode):
(JSC::ArgumentListNode::ArgumentListNode):
(JSC::ArgumentsNode::ArgumentsNode):
(JSC::NewExprNode::NewExprNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PrePostResolveNode::PrePostResolveNode):
(JSC::PostfixResolveNode::PostfixResolveNode):
(JSC::PostfixBracketNode::PostfixBracketNode):
(JSC::PostfixDotNode::PostfixDotNode):
(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::DeleteValueNode::DeleteValueNode):
(JSC::VoidNode::VoidNode):
(JSC::TypeOfResolveNode::TypeOfResolveNode):
(JSC::TypeOfValueNode::TypeOfValueNode):
(JSC::PrefixResolveNode::PrefixResolveNode):
(JSC::PrefixBracketNode::PrefixBracketNode):
(JSC::PrefixDotNode::PrefixDotNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::UnaryOpNode::UnaryOpNode):
(JSC::UnaryPlusNode::UnaryPlusNode):
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::LogicalNotNode::LogicalNotNode):
(JSC::BinaryOpNode::BinaryOpNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::AddNode::AddNode):
(JSC::SubNode::SubNode):
(JSC::LeftShiftNode::LeftShiftNode):
(JSC::RightShiftNode::RightShiftNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
(JSC::LessNode::LessNode):
(JSC::GreaterNode::GreaterNode):
(JSC::LessEqNode::LessEqNode):
(JSC::GreaterEqNode::GreaterEqNode):
(JSC::ThrowableBinaryOpNode::ThrowableBinaryOpNode):
(JSC::InstanceOfNode::InstanceOfNode):
(JSC::InNode::InNode):
(JSC::EqualNode::EqualNode):
(JSC::NotEqualNode::NotEqualNode):
(JSC::StrictEqualNode::StrictEqualNode):
(JSC::NotStrictEqualNode::NotStrictEqualNode):
(JSC::BitAndNode::BitAndNode):
(JSC::BitOrNode::BitOrNode):
(JSC::BitXOrNode::BitXOrNode):
(JSC::LogicalOpNode::LogicalOpNode):
(JSC::ConditionalNode::ConditionalNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::CommaNode::CommaNode):
(JSC::ConstStatementNode::ConstStatementNode):
(JSC::SourceElements::SourceElements):
(JSC::EmptyStatementNode::EmptyStatementNode):
(JSC::DebuggerStatementNode::DebuggerStatementNode):
(JSC::ExprStatementNode::ExprStatementNode):
(JSC::VarStatementNode::VarStatementNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):
(JSC::DoWhileNode::DoWhileNode):
(JSC::WhileNode::WhileNode):
(JSC::ForNode::ForNode):
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ReturnNode::ReturnNode):
(JSC::WithNode::WithNode):
(JSC::LabelNode::LabelNode):
(JSC::ThrowNode::ThrowNode):
(JSC::TryNode::TryNode):
(JSC::ParameterNode::ParameterNode):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
(JSC::CaseClauseNode::CaseClauseNode):
(JSC::ClauseListNode::ClauseListNode):
(JSC::CaseBlockNode::CaseBlockNode):
(JSC::SwitchNode::SwitchNode):
(JSC::ConstDeclNode::ConstDeclNode):
(JSC::BlockNode::BlockNode):
(JSC::ForInNode::ForInNode):
- parser/NodeInfo.h:
- parser/Nodes.cpp:
(JSC::StatementNode::setLoc):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
- parser/Nodes.h:
(JSC::Node::lineNo):
- parser/Parser.cpp:
(JSC::Parser::Parser):
(JSC::Parser::~Parser):
(JSC::Parser::parseInner):
(JSC::Parser::allowAutomaticSemicolon):
(JSC::Parser::parseSourceElements):
(JSC::Parser::parseVarDeclaration):
(JSC::Parser::parseConstDeclaration):
(JSC::Parser::parseDoWhileStatement):
(JSC::Parser::parseWhileStatement):
(JSC::Parser::parseVarDeclarationList):
(JSC::Parser::parseConstDeclarationList):
(JSC::Parser::parseForStatement):
(JSC::Parser::parseBreakStatement):
(JSC::Parser::parseContinueStatement):
(JSC::Parser::parseReturnStatement):
(JSC::Parser::parseThrowStatement):
(JSC::Parser::parseWithStatement):
(JSC::Parser::parseSwitchStatement):
(JSC::Parser::parseSwitchClauses):
(JSC::Parser::parseSwitchDefaultClause):
(JSC::Parser::parseTryStatement):
(JSC::Parser::parseDebuggerStatement):
(JSC::Parser::parseBlockStatement):
(JSC::Parser::parseStatement):
(JSC::Parser::parseFormalParameters):
(JSC::Parser::parseFunctionBody):
(JSC::Parser::parseFunctionInfo):
(JSC::Parser::parseFunctionDeclaration):
(JSC::LabelInfo::LabelInfo):
(JSC::Parser::parseExpressionOrLabelStatement):
(JSC::Parser::parseExpressionStatement):
(JSC::Parser::parseIfStatement):
(JSC::Parser::parseExpression):
(JSC::Parser::parseAssignmentExpression):
(JSC::Parser::parseConditionalExpression):
(JSC::isUnaryOp):
(JSC::Parser::isBinaryOperator):
(JSC::Parser::parseBinaryExpression):
(JSC::Parser::parseProperty):
(JSC::Parser::parseObjectLiteral):
(JSC::Parser::parseStrictObjectLiteral):
(JSC::Parser::parseArrayLiteral):
(JSC::Parser::parsePrimaryExpression):
(JSC::Parser::parseArguments):
(JSC::Parser::parseMemberExpression):
(JSC::Parser::parseUnaryExpression):
- parser/Parser.h:
(JSC::isEvalNode):
(JSC::EvalNode):
(JSC::DepthManager::DepthManager):
(JSC::DepthManager::~DepthManager):
(JSC::ScopeLabelInfo::ScopeLabelInfo):
(JSC::Scope::Scope):
(JSC::Scope::startSwitch):
(JSC::Scope::endSwitch):
(JSC::Scope::startLoop):
(JSC::Scope::endLoop):
(JSC::Scope::inLoop):
(JSC::Scope::breakIsValid):
(JSC::Scope::continueIsValid):
(JSC::Scope::pushLabel):
(JSC::Scope::popLabel):
(JSC::Scope::getLabel):
(JSC::Scope::setIsFunction):
(JSC::Scope::isFunction):
(JSC::Scope::isFunctionBoundary):
(JSC::Scope::declareVariable):
(JSC::Scope::declareWrite):
(JSC::Scope::preventNewDecls):
(JSC::Scope::allowsNewDecls):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):
(JSC::Scope::setNeedsFullActivation):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::getUncapturedWrittenVariables):
(JSC::Scope::getCapturedVariables):
(JSC::Scope::setStrictMode):
(JSC::Scope::strictMode):
(JSC::Scope::isValidStrictMode):
(JSC::Scope::shadowsArguments):
(JSC::Scope::copyCapturedVariablesToVector):
(JSC::Scope::saveFunctionInfo):
(JSC::Scope::restoreFunctionInfo):
(JSC::ScopeRef::ScopeRef):
(JSC::ScopeRef::operator->):
(JSC::ScopeRef::index):
(JSC::ScopeRef::hasContainingScope):
(JSC::ScopeRef::containingScope):
(JSC::Parser::AllowInOverride::AllowInOverride):
(JSC::Parser::AllowInOverride::~AllowInOverride):
(JSC::Parser::AutoPopScopeRef::AutoPopScopeRef):
(JSC::Parser::AutoPopScopeRef::~AutoPopScopeRef):
(JSC::Parser::AutoPopScopeRef::setPopped):
(JSC::Parser::currentScope):
(JSC::Parser::pushScope):
(JSC::Parser::popScopeInternal):
(JSC::Parser::popScope):
(JSC::Parser::declareVariable):
(JSC::Parser::declareWrite):
(JSC::Parser::findCachedFunctionInfo):
(JSC::Parser::isFunctionBodyNode):
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::nextTokenIsColon):
(JSC::Parser::consume):
(JSC::Parser::getToken):
(JSC::Parser::match):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenEnd):
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
(JSC::Parser::startLoop):
(JSC::Parser::endLoop):
(JSC::Parser::startSwitch):
(JSC::Parser::endSwitch):
(JSC::Parser::setStrictMode):
(JSC::Parser::strictMode):
(JSC::Parser::isValidStrictMode):
(JSC::Parser::declareParameter):
(JSC::Parser::breakIsValid):
(JSC::Parser::continueIsValid):
(JSC::Parser::pushLabel):
(JSC::Parser::popLabel):
(JSC::Parser::getLabel):
(JSC::Parser::autoSemiColon):
(JSC::Parser::canRecurse):
(JSC::Parser::lastTokenEnd):
(JSC::Parser::DepthManager::DepthManager):
(JSC::Parser::DepthManager::~DepthManager):
(JSC::Parser::parse):
(JSC::parse):
- parser/ParserTokens.h: Added.
(JSC::JSTokenInfo::JSTokenInfo):
- parser/SourceCode.h:
(JSC::SourceCode::subExpression):
- parser/SourceProviderCacheItem.h:
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::SyntaxChecker):
(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::createCommaExpr):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeTypeOfNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::makeNegateNode):
(JSC::SyntaxChecker::makeBitwiseNotNode):
(JSC::SyntaxChecker::createLogicalNot):
(JSC::SyntaxChecker::createUnaryPlus):
(JSC::SyntaxChecker::createVoid):
(JSC::SyntaxChecker::thisExpr):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createObjectLiteral):
(JSC::SyntaxChecker::createArray):
(JSC::SyntaxChecker::createNumberExpr):
(JSC::SyntaxChecker::createString):
(JSC::SyntaxChecker::createBoolean):
(JSC::SyntaxChecker::createNull):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createConditionalExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArguments):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
- runtime/JSGlobalData.h:
- runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):
- 3:07 PM Changeset in webkit [98886] by
-
- 2 edits1 add12 deletes in trunk/LayoutTests
The test input-paste-undo.html needs update to work properly
https://bugs.webkit.org/show_bug.cgi?id=71091
Reviewed by David Kilzer.
Update the test to select the text that needs to be copied
so that it effectively go in the pasteboard on execCommand.
The test now dumps result as text, testing if the height does not
change with the form edition.
- fast/forms/input-paste-undo-expected.txt: Added.
- fast/forms/input-paste-undo.html:
- platform/chromium-linux/fast/forms/input-paste-undo-expected.png: Removed.
- platform/chromium-mac-leopard/fast/forms/input-paste-undo-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-paste-undo-expected.png: Removed.
- platform/chromium-win/fast/forms/input-paste-undo-expected.png: Removed.
- platform/chromium-win/fast/forms/input-paste-undo-expected.txt: Removed.
- platform/efl/fast/forms/input-paste-undo-expected.txt: Removed.
- platform/gtk/fast/forms/input-paste-undo-expected.png: Removed.
- platform/gtk/fast/forms/input-paste-undo-expected.txt: Removed.
- platform/mac-leopard/fast/forms/input-paste-undo-expected.png: Removed.
- platform/mac/fast/forms/input-paste-undo-expected.png: Removed.
- platform/mac/fast/forms/input-paste-undo-expected.txt: Removed.
- platform/qt/fast/forms/input-paste-undo-expected.txt: Removed.
- 3:03 PM Changeset in webkit [98885] by
-
- 3 edits6 adds in trunk
window.onerror doesn't work with inline (attribute) scripts
https://bugs.webkit.org/show_bug.cgi?id=70991
Source/WebCore:
Uncaught syntax errors in inline event handlers are now reported to
window.onerror handler.
Reviewed by Geoffrey Garen.
Tests: fast/events/window-onerror-exception-in-attr.html
fast/events/window-onerror-syntax-error-in-attr.html
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction): report exception as usual
if it happens during event handler compilation.
LayoutTests:
Added a couple of window.onerror tests for the cases when uncaught exception
occurs in inline event handler. Test for non-syntax errors passed before this change
as well and just extends test coverage for window.onerror functionality.
Reviewed by Geoffrey Garen.
- fast/events/window-onerror-exception-in-attr-expected.txt: Added.
- fast/events/window-onerror-exception-in-attr.html: Added.
- fast/events/window-onerror-syntax-error-in-attr-expected.txt: Added.
- fast/events/window-onerror-syntax-error-in-attr.html: Added.
- platform/chromium/fast/events/window-onerror-exception-in-attr-expected.txt: Added.
- platform/chromium/fast/events/window-onerror-syntax-error-in-attr-expected.txt: Added.
- 2:34 PM Changeset in webkit [98884] by
-
- 6 edits31 adds12 deletes in trunk/LayoutTests
Unreviewed, more expectations changes for svg.
- platform/chromium-cg-mac-leopard/fast/overflow/003-expected.txt: Added.
- platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png:
- platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Removed.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/overflow: Added.
- platform/chromium-cg-mac-snowleopard/fast/overflow/003-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
- platform/chromium-cg-mac/fast/overflow: Removed.
- platform/chromium-cg-mac/fast/overflow/003-expected.png: Removed.
- platform/chromium-cg-mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Removed.
- platform/chromium-cg-mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page: Removed.
- platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.txt: Removed.
- platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.txt: Added.
- platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/overflow: Added.
- platform/chromium-mac-snowleopard/fast/overflow/003-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-4-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
- platform/chromium-mac/fast/overflow/003-expected.png: Removed.
- platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Removed.
- platform/chromium-mac/svg/as-background-image/svg-as-background-4-expected.png: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
- platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.txt: Added.
- platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.txt: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
- platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.txt: Added.
- platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt: Added.
- platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
- platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
- platform/chromium/svg/zoom: Added.
- platform/chromium/svg/zoom/page: Added.
- platform/chromium/svg/zoom/page/zoom-background-images-expected.txt: Added.
- platform/chromium/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
- 2:33 PM Changeset in webkit [98883] by
-
- 15 edits in trunk/Source/WebCore
Overridden LayoutRect method still uses IntRects
https://bugs.webkit.org/show_bug.cgi?id=71166
Reviewed by Eric Seidel.
Change all virtual controlClipRect, windowResizerRect, windowClipRect,
visibleContentRect, scrollCornerRect, outlineBoundsForRepaint and
localCaretRect functions to have the same signature.
- page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::windowClipRectForLayer):
(WebCore::FrameView::windowResizerRect):
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
- platform/ScrollableArea.h:
- rendering/RenderButton.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::visibleContentRect):
- rendering/RenderLayer.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::localCaretRect):
- rendering/RenderObject.h:
(WebCore::RenderObject::outlineBoundsForRepaint):
- rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::linesBoundingBox):
- rendering/RenderText.h:
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
- rendering/svg/RenderSVGInlineText.h:
- 2:31 PM Changeset in webkit [98882] by
-
- 1 copy in tags/Safari-534.52.7
New tag.
- 2:24 PM Changeset in webkit [98881] by
-
- 3 edits2 adds in trunk/LayoutTests
[Chromium] Did rebaselines of media/audio-repaint.html.
Unreviewed.
- platform/chromium-gpu-linux/media/audio-repaint-expected.png: Added.
- platform/chromium-gpu-win/media/audio-repaint-expected.txt: Added.
- platform/chromium-linux/media/audio-repaint-expected.png:
- platform/chromium-win/media/audio-repaint-expected.png:
- 2:23 PM Changeset in webkit [98880] by
-
- 5 edits in branches/safari-534.52-branch/Source
Versioning.
- 2:07 PM Changeset in webkit [98879] by
-
- 5 edits in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=70658
[JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage.
Transfer of MessagePorts implemented.
Reviewed by David Levin.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=70658
[JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage.
Some 'FAIL's remain in expected test results. These are due to the fact that
JSC bindings chose not to throw type error exception for non-serializable values -
non-serializable values are serialized as null.
Reviewed by David Levin.
- fast/dom/Window/window-postmessage-args-expected.txt:
- fast/events/message-port-multi-expected.txt:
- 2:03 PM Changeset in webkit [98878] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r97118): Reproducible crash in JSCell::toPrimitive when adding
https://bugs.webkit.org/show_bug.cgi?id=71227
Reviewed by Oliver Hunt.
No new tests, since while I can see exactly where the DFG went wrong on the
site in question from looking at the generated machine code, and while I can
certainly believe that such a scenario would happen, I cannot visualize how
to make it happen reproducibly. It requires an odd combination of double
values getting spilled and then refilled, but then reboxed at just the right
time so that the spilled value is an unboxed double while the in-register
value is a boxed double.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillGPR):
- 1:50 PM Changeset in webkit [98877] by
-
- 6 edits in trunk/Tools
webkitpy tests depend too much on the user's environment
https://bugs.webkit.org/show_bug.cgi?id=71234
Reviewed by Dirk Pranke.
This change just makes a bunch of our older tests use
more modern mocking to avoid trying to launch processes
or read from the user's filesystem during unittesting.
I found many of these by adding an assert in Executive.run_command
that we were not unittesting. I can't add that assert always
as there are some valid uses of Executive during unittesting.
Once I fix more of these, I may find a way to add such an assert conditionally.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
- Scripts/webkitpy/common/net/credentials_unittest.py:
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- 1:31 PM Changeset in webkit [98876] by
-
- 6 edits in branches/subpixellayout/Source
Change WebKit/WebKit2 to use explicit conversion between FixedRect/Point/Size and the int equivalents. Follow up to change 98869.
- 1:29 PM Changeset in webkit [98875] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, inspector/debugger/bind-script-to-resource.html fails after r98847
- platform/chromium/test_expectations.txt:
- 1:25 PM Changeset in webkit [98874] by
-
- 2 edits in branches/safari-534.52-branch/Source/WebCore
Merged r98389.
- 1:22 PM Changeset in webkit [98873] by
-
- 8 edits in trunk/Source/WebKit2
Rename a couple of NetscapePlugin and PluginProxy member variables
https://bugs.webkit.org/show_bug.cgi?id=71086
Reviewed by Sam Weinig.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::invalidate):
(WebKit::NetscapePlugin::callSetWindow):
(WebKit::NetscapePlugin::snapshot):
(WebKit::NetscapePlugin::deprecatedGeometryDidChange):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::deprecatedGeometryDidChange):
(WebKit::PluginProxy::update):
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewGeometryDidChange):
- 12:51 PM Changeset in webkit [98872] by
-
- 1208 edits351 copies91 deletes in branches/subpixellayout
Merging trunk changes up until 98861 into subpixel branch.
- 12:27 PM Changeset in webkit [98871] by
-
- 4 edits2 adds in trunk/LayoutTests
Did rebaselines for failing tests for fullscreen layout tests.
https://bugs.webkit.org/show_bug.cgi?id=70512
Reviewed by David Levin.
- platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-zIndex-after-expected.png: Added.
- platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png:
- platform/chromium-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png:
- platform/chromium-mac-leopard/fullscreen/full-screen-zIndex-after-expected.png:
- 12:09 PM Changeset in webkit [98870] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Fixed duplicate lines in test expectations.
- platform/chromium/test_expectations.txt:
- 12:06 PM Changeset in webkit [98869] by
-
- 10 edits in branches/subpixellayout/Source/WebCore
Adding explicit FixedRect constructors to IntRect. Previously, FixedRect->IntRect went through FloatRect, which lost precision and caused overflow in some cases. Fixing some scrollbar paint issues on Mac.
- 11:54 AM Changeset in webkit [98868] by
-
- 4 edits7 moves6 adds49 deletes in trunk/LayoutTests
Unreviewed. More rebaselines after r98852.
- platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-003-expected.png: Added.
- platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png:
- platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Added.
- platform/chromium-cg-mac-snowleopard/http/tests/misc/acid3-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.png.
- platform/chromium-cg-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-003-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.png.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
- platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
- platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
- platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png: Renamed from LayoutTests/platform/chromium-mac/http/tests/misc/acid3-expected.png.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
- platform/chromium-mac/fast/block/float/015-expected.png: Removed.
- platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
- platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
- platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/background-intrinsic-003-expected.png: Renamed from LayoutTests/platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.png.
- platform/chromium-win/css2.1/20110323/background-intrinsic-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.txt.
- platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Renamed from LayoutTests/platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png.
- platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt.
- platform/mac/svg/as-image/svg-as-relative-image-expected.txt: Removed.
- platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
- platform/qt/svg/as-image/svg-as-relative-image-expected.txt: Removed.
- platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Removed.
- 11:16 AM Changeset in webkit [98867] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed. Update Skipped list.
- platform/efl/Skipped: Reorder test groups so that they appear in a
more logical manner. Add some other tests that are failing since
recent updates.
- 10:54 AM Changeset in webkit [98866] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Marked tests as failing after r98852.
- platform/chromium/test_expectations.txt:
- 10:46 AM Changeset in webkit [98865] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed, expectations for fast/js tests.
- platform/chromium/fast/js/regexp-caching-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 10:43 AM Changeset in webkit [98864] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Install html and tmpl dirs in a $(DOC_MODULE) dir in tarball
https://bugs.webkit.org/show_bug.cgi?id=71224
Reviewed by Martin Robinson.
- GNUmakefile.gtk-doc.am: Copy html and tmpl dirs to
$(distdir)/$(DOC_MODULE).
- 10:38 AM Changeset in webkit [98863] by
-
- 23 edits1 copy9 moves157 adds in trunk/LayoutTests
Unreviewed tests rebaseline following r98852.
- fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt.
- platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-001-expected.png: Added.
- platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-002-expected.png: Added.
- platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
- platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
- platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-006-expected.png: Added.
- platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-007-expected.png: Added.
- platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-008-expected.png: Added.
- platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-009-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-cg-mac-leopard/fast/block/float/015-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-cg-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
- platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-tiled-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/chromium-cg-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/css1/text_properties/vertical_align-expected.png.
- platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-cg-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
- platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
- platform/chromium-linux/fast/block/float/015-expected.png:
- platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
- platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
- platform/chromium-linux/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
- platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png:
- platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
- platform/chromium-linux/svg/as-image/same-image-two-instances-expected.png: Added.
- platform/chromium-linux/svg/as-image/svg-as-relative-image-expected.png: Added.
- platform/chromium-linux/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
- platform/chromium-linux/svg/as-image/svg-image-change-content-size-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Renamed from LayoutTests/platform/chromium-mac/css1/text_properties/vertical_align-expected.png.
- platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/float/015-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-background-image/background-image-tiled-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/as-image/animated-svg-as-image-expected.png.
- platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-image/same-image-two-instances-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-image/svg-as-relative-image-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.png: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.png: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.png: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.png: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.png: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.png: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.png: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.png: Added.
- platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-foreignObject-expected.png: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/chromium-win/css1/text_properties/vertical_align-expected.txt:
- platform/chromium-win/css2.1/20110323/background-intrinsic-001-expected.png: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-002-expected.png: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.png: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.png: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-006-expected.png: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-007-expected.png: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-008-expected.png: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-009-expected.png: Added.
- platform/chromium-win/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
- platform/chromium-win/fast/block/float/015-expected.png:
- platform/chromium-win/fast/block/float/015-expected.txt:
- platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
- platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.txt:
- platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
- platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
- platform/chromium-win/svg/as-background-image/background-image-tiled-expected.png: Added.
- platform/chromium-win/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
- platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
- platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
- platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/chromium-win/svg/as-image/same-image-two-instances-expected.png: Added.
- platform/chromium-win/svg/as-image/same-image-two-instances-expected.txt: Added.
- platform/chromium-win/svg/as-image/svg-as-relative-image-expected.png: Added.
- platform/chromium-win/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
- platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png: Added.
- platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.txt: Added.
- platform/chromium-win/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
- platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Copied from LayoutTests/platform/chromium-win/svg/zoom/page/relative-sized-document-scrollbars-expected.png.
- platform/chromium-win/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/chromium/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Added.
- svg/as-background-image/svg-as-background-4-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.txt.
- svg/as-image/svg-as-relative-image-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-image/svg-as-relative-image-expected.txt.
- svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Renamed from LayoutTests/platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt.
- 10:30 AM Changeset in webkit [98862] by
-
- 1 edit876 adds in trunk/LayoutTests
[EFL] Unreviewed. Add pixel baselines for tests in fast/ directory.
- platform/efl/fast/backgrounds: [...]
- platform/efl/fast/block: [...]
- platform/efl/fast/body-propagation: [...]
- platform/efl/fast/borders: [...]
- platform/efl/fast/box-shadow: [...]
- platform/efl/fast/canvas: [...]
- platform/efl/fast/clip: [...]
- platform/efl/fast/compact: [...]
- platform/efl/fast/css-generated-content: [...]
- platform/efl/fast/css: [...]
- 10:02 AM Changeset in webkit [98861] by
-
- 5 edits in trunk/Source/WebCore
CSSRule: Devirtualize insertedIntoParent()
https://bugs.webkit.org/show_bug.cgi?id=71223
Reviewed by Antti Koivisto.
Moved insertedIntoParent() down into CSSImportRule and renamed it to
requestStyleSheet(). CSSImportRule is the only user of this function.
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::requestStyleSheet):
- css/CSSImportRule.h:
- css/CSSRule.h:
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::append):
(WebCore::CSSStyleSheet::insertRule):
- 9:35 AM Changeset in webkit [98860] by
-
- 9 edits6 adds in trunk
Implement load notification and events for <track>.
https://bugs.webkit.org/show_bug.cgi?id=71054
Reviewed by Eric Carlson.
Source/WebCore:
Tests: media/track/track-load-error-readyState.html
media/track/track-load-from-element-readyState.html
media/track/track-load-from-src-readyState.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::trackWasAdded):
(WebCore::HTMLMediaElement::trackWillBeRemoved):
(WebCore::HTMLMediaElement::trackSourceChanged):
- html/HTMLMediaElement.h:
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::parseMappedAttribute):
(WebCore::HTMLTrackElement::attributeChanged):
- html/HTMLTrackElement.h:
- html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::cueLoadingCompleted):
LayoutTests:
- media/track/track-load-error-readyState-expected.txt: Added.
- media/track/track-load-error-readyState.html: Added.
- media/track/track-load-from-element-readyState-expected.txt: Added.
- media/track/track-load-from-element-readyState.html: Added.
- media/track/track-load-from-src-readyState-expected.txt: Added.
- media/track/track-load-from-src-readyState.html: Added.
- platform/mac/Skipped:
- platform/win/Skipped:
- 9:04 AM clutter edited by
- My suggestions (diff)
- 8:53 AM Changeset in webkit [98859] by
-
- 23 edits in trunk/Source/WebCore
CSSRule: Devirtualize type() and isFooRule()
https://bugs.webkit.org/show_bug.cgi?id=71221
Reviewed by Antti Koivisto.
Store the rule type in a CSSRule member (packed with the parent-is-rule flag)
and let the isFooRule() functions return type() == FOO_TYPE.
CSSPageRule will no longer return true for isStyleRule(), tweaked call sites
accordingly.
- css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::CSSCharsetRule):
- css/CSSCharsetRule.h:
- css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::CSSFontFaceRule):
- css/CSSFontFaceRule.h:
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::CSSImportRule):
- css/CSSImportRule.h:
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule):
- css/CSSMediaRule.h:
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::CSSPageRule):
- css/CSSPageRule.h:
- css/CSSRegionStyleRule.cpp:
(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
- css/CSSRegionStyleRule.h:
- css/CSSRule.h:
(WebCore::CSSRule::type):
(WebCore::CSSRule::isCharsetRule):
(WebCore::CSSRule::isFontFaceRule):
(WebCore::CSSRule::isKeyframeRule):
(WebCore::CSSRule::isKeyframesRule):
(WebCore::CSSRule::isMediaRule):
(WebCore::CSSRule::isPageRule):
(WebCore::CSSRule::isStyleRule):
(WebCore::CSSRule::isRegionStyleRule):
(WebCore::CSSRule::isImportRule):
(WebCore::CSSRule::CSSRule):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::CSSStyleRule):
- css/CSSStyleRule.h:
- css/CSSStyleSelector.cpp:
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
- css/CSSUnknownRule.h:
(WebCore::CSSUnknownRule::CSSUnknownRule):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
- css/WebKitCSSKeyframeRule.h:
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
- css/WebKitCSSKeyframesRule.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::asCSSStyleRule):
- 8:49 AM Changeset in webkit [98858] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Fix qmltests after r98460 added widgets dependency.
Reviewed by Simon Hausmann.
Use QApplication and QtWidgets until we get rid of the widgets dependency of QScroller.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(main):
- 8:30 AM clutter edited by
- (diff)
- 8:29 AM Changeset in webkit [98857] by
-
- 2 edits in trunk/Source/WebCore
2011-10-31 Pavel Feldman <pfeldman@google.com>
Not reviewed: reorder inspector js files to fix remote mode.
- inspector/front-end/inspector.html:
- 8:09 AM Changeset in webkit [98856] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: [refactoring] TextPrompt: ensure encapsulation, extract history management
https://bugs.webkit.org/show_bug.cgi?id=70936
Reviewed by Pavel Feldman.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
- inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView):
(WebInspector.DatabaseQueryView.prototype._enterKeyPressed):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylePropertyTreeElement.prototype.selectElement):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.context):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.event):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.context.event):
():
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.get proxyElement):
(WebInspector.TextPrompt.prototype.attach):
(WebInspector.TextPrompt.prototype.attachAndStartEditing):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.detach):
(WebInspector.TextPrompt.prototype.get text):
(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeFromElement):
(WebInspector.TextPrompt.prototype._startEditing):
(WebInspector.TextPrompt.prototype._stopEditing):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype._onKeyDown):
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretInsidePrompt):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.isCaretOnFirstLine):
(WebInspector.TextPrompt.prototype.isCaretOnLastLine):
(WebInspector.TextPrompt.prototype.moveCaretToEndOfPrompt):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPromptConfig):
(WebInspector.TextPromptWithHistory):
(WebInspector.TextPromptWithHistory.prototype.get historyData):
(WebInspector.TextPromptWithHistory.prototype.setHistoryData):
(WebInspector.TextPromptWithHistory.prototype.pushHistoryItem):
(WebInspector.TextPromptWithHistory.prototype._pushCurrentText):
(WebInspector.TextPromptWithHistory.prototype._previous):
(WebInspector.TextPromptWithHistory.prototype._next):
(WebInspector.TextPromptWithHistory.prototype._currentHistoryItem):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):
- 7:32 AM Changeset in webkit [98855] by
-
- 19 edits in trunk/Source
Web Inspector: move localization support into UIUtil.js, reduce externs.
https://bugs.webkit.org/show_bug.cgi?id=71220
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/compile-front-end.sh:
- inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.focus):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.afterShow):
- inspector/front-end/Drawer.js:
- inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.prototype._hide):
- inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype.hide):
(WebInspector.HelpScreen.prototype._onBlur):
- inspector/front-end/InspectorFrontendHostStub.js:
- inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut._keyName):
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
- inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype._onSearchFieldManualFocus):
(WebInspector.SearchController.prototype._onKeyDown):
- inspector/front-end/Settings.js:
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.prototype._toolbarDragStart):
- inspector/front-end/UIUtils.js:
(WebInspector.startEditing.cleanUpAfterEditing):
(WebInspector.startEditing.var):
(WebInspector.startEditing):
(WebInspector.UIString):
(WebInspector.useLowerCaseMenuTitles):
(WebInspector.platform):
(WebInspector.isMac):
(WebInspector.platformFlavor):
(WebInspector.port):
(WebInspector.installPortStyles):
(WebInspector._windowFocused):
(WebInspector._windowBlurred):
(WebInspector.previousFocusElement):
(WebInspector.currentFocusElement):
(WebInspector._focusChanged):
(WebInspector.setCurrentFocusElement):
- inspector/front-end/externs.js:
(Event.prototype.initWebKitWheelEvent):
(window.getComputedStyle):
(InspectorBackend.runAfterPendingDispatches):
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
(WebInspector.addMainEventListeners):
Source/WebKit/chromium:
- src/js/DevTools.js:
- 7:15 AM Changeset in webkit [98854] by
-
- 2 edits in trunk/Tools
[Qt] MiniBrowser doesn't resize as the size is always overridden
https://bugs.webkit.org/show_bug.cgi?id=71212
Reviewed by Simon Hausmann.
Remove call overriden the size.
- MiniBrowser/qt/main.cpp:
(main):
- 7:13 AM Changeset in webkit [98853] by
-
- 30 edits2 deletes in trunk/Source/WebCore
Kill StyleBase.
https://bugs.webkit.org/show_bug.cgi?id=71218
Reviewed by Antti Koivisto.
Remove the StyleBase class and make all subclasses stand alone. CSSRule and StyleSheet
now inherit from RefCounted<T> instead, and XSLImportRule doesn't even need that,
so StyleBase is replaced by nothing.
- css/StyleBase.cpp:
- css/StyleBase.h:
Removed.
- css/CSSRule.cpp:
- css/CSSRule.h:
(WebCore::CSSRule::~CSSRule):
(WebCore::CSSRule::useStrictParsing):
(WebCore::CSSRule::setParentStyleSheet):
(WebCore::CSSRule::setParentRule):
(WebCore::CSSRule::parentStyleSheet):
(WebCore::CSSRule::parentRule):
(WebCore::CSSRule::baseURL):
(WebCore::CSSRule::CSSRule):
CSSRule now inherits directly from RefCounted, and has either a CSSRule or a
CSSStyleSheet as its parent. Made these getters/setters inline since they are
trivial now.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Purge StyleBase.* from the build systems.
- bindings/js/JSDOMBinding.h:
(WebCore::root):
New root() functions for CSSRule and StyleSheet.
- bindings/js/JSNodeCustom.h:
Remove StyleBase.h include.
- css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::parentStyleSheet):
Added CSS-specific parentStyleSheet() so we don't have to cast it to a
CSSStyleSheet* at the call sites.
- css/StyleSheet.cpp:
(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::parentStyleSheet):
(WebCore::StyleSheet::baseURL):
- css/StyleSheet.h:
(WebCore::StyleSheet::parentRule):
(WebCore::StyleSheet::setParentRule):
(WebCore::StyleSheet::isCSSStyleSheet):
(WebCore::StyleSheet::isXSLStyleSheet):
StyleSheet now inherits directly from RefCounted and always has a parent CSSRule
though it can be null. parentStyleSheet() returns that rule's parent style sheet.
Moved the relevant guts from StyleBase down here.
- loader/cache/CachedStyleSheetClient.h:
Remove unnecessary WTF_MAKE_FAST_ALLOCATED, we get it from CachedResourceClient.
- xml/XSLImportRule.cpp:
(WebCore::XSLImportRule::XSLImportRule):
(WebCore::XSLImportRule::~XSLImportRule):
(WebCore::XSLImportRule::parentStyleSheet):
(WebCore::XSLImportRule::setXSLStyleSheet):
(WebCore::XSLImportRule::loadSheet):
- xml/XSLImportRule.h:
(WebCore::XSLImportRule::create):
(WebCore::XSLImportRule::setParentStyleSheet):
Remove inheritance from StyleBase, and have create() return a PassOwnPtr instead.
This is fine, since XSLStyleSheet is the only object that ever manages these rules.
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedIntoDocument):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::ownerRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::checkLoaded):
(WebCore::CSSStyleSheet::document):
(WebCore::CSSStyleSheet::styleSheetChanged):
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::setCSSStyleSheet):
(WebCore::CSSImportRule::insertedIntoParent):
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::append):
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
- css/CSSRegionStyleRule.cpp:
(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::~CSSRegionStyleRule):
- css/CSSRuleList.cpp:
(WebCore::CSSRuleList::deleteRule):
- css/CSSStyleDeclaration.h:
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::append):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::parseStyleSheet):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::parentStyleSheet):
- xml/XSLStyleSheet.h:
- xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::~XSLStyleSheet):
(WebCore::XSLStyleSheet::checkLoaded):
(WebCore::XSLStyleSheet::loadChildSheet):
- xml/XSLStyleSheetQt.cpp:
(WebCore::XSLStyleSheet::~XSLStyleSheet):
Use the new, more explicit, parenting functions of StyleSheet.
- 7:07 AM Changeset in webkit [98852] by
-
- 54 edits100 adds2 deletes in trunk
2011-10-31 Nikolas Zimmermann <nzimmermann@rim.com>
CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156
Reviewed by Antti Koivisto.
Add all *intrinsic* tests from the CSS 2.1 Testsuite - we pass all of them now.
All tests regarding SVG are now imported in LayoutTests, none are failing anymore.
Add several new testcases covering the SVG Image size negotiation logic, as defined in CSS 2.1.
- css2.1/20110323/background-intrinsic-001.htm: Added.
- css2.1/20110323/background-intrinsic-002.htm: Added.
- css2.1/20110323/background-intrinsic-003.htm: Added.
- css2.1/20110323/background-intrinsic-004.htm: Added.
- css2.1/20110323/background-intrinsic-005.htm: Added.
- css2.1/20110323/background-intrinsic-006.htm: Added.
- css2.1/20110323/background-intrinsic-007.htm: Added.
- css2.1/20110323/background-intrinsic-008.htm: Added.
- css2.1/20110323/background-intrinsic-009.htm: Added.
- css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Added.
- css2.1/20110323/resources/green-intrinsic-height.svg: Added.
- css2.1/20110323/resources/green-intrinsic-none.svg: Added.
- css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Added.
- css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Added.
- css2.1/20110323/resources/green-intrinsic-width-height.svg: Added.
- css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Added.
- css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Added.
- css2.1/20110323/resources/green-intrinsic-width.svg: Added.
- css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Added.
- css2.1/20110323/resources/red-intrinsic-height.svg: Added.
- css2.1/20110323/resources/red-intrinsic-none.svg: Added.
- css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Added.
- css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Added.
- css2.1/20110323/resources/red-intrinsic-width-height.svg: Added.
- css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Added.
- css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Added.
- css2.1/20110323/resources/red-intrinsic-width.svg: Added.
- fast/backgrounds/size/contain-and-cover-zoomed.html: Added.
- fast/images/percent-height-image-expected.txt: Update results, testcase is fixed now.
- fast/images/percent-height-image.html: Make test async, to make it work cross-browser. With this patch we now pass this testcase.
- platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
- platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
- platform/mac/css1/text_properties/vertical_align-expected.txt: Update for rounding differences.
- platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Added.
- platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
- platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Added.
- platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
- platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Added.
- platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
- platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Added.
- platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
- platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Added.
- platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
- platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Added.
- platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
- platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Added.
- platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
- platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Added.
- platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
- platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Added.
- platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
- platform/mac/fast/backgrounds/size/contain-and-cover-expected.png: Updated for rounding differences.
- platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
- platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
- platform/mac/fast/block/float/015-expected.png: Slight changes, due 49x50 -> 50x50 size change.
- platform/mac/fast/block/float/015-expected.txt: Ditto.
- platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Slight changes due to rounding.
- platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Ditto.
- platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Ditto.
- platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Ditto.
- platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
- platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
- platform/mac/svg/as-background-image/background-image-tiled-expected.png: Added.
- platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Added.
- platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
- platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
- platform/mac/svg/as-background-image/svg-as-background-4-expected.png: Adapt to preserveAspectRatio changes in hearts.svg.
- platform/mac/svg/as-border-image/svg-as-border-image-expected.png: This needed a rebaseline, it was forgotten before.
- platform/mac/svg/as-image/animated-svg-as-image-expected.png: Progression, now both images share the same size & ratio, as desired.
- platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
- platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/mac/svg/as-image/same-image-two-instances-expected.png: Added.
- platform/mac/svg/as-image/same-image-two-instances-expected.txt: Added.
- platform/mac/svg/as-image/svg-as-relative-image-expected.png: Adapt to green-relative-size-rect.svg - a circle got added to make it easier to compare.
- platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
- platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
- platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Added.
- platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Added.
- platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
- platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Ditto.
- platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Ditto.
- platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-as-image-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
- platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
- svg/as-background-image/background-image-preserveaspectRatio-support.html: Added.
- svg/as-background-image/background-image-tiled.html: Added.
- svg/as-background-image/resources/construction-tape.svg: Added.
- svg/as-background-image/resources/hearts.svg: Fix testcase, by adding pAR="none", which is now respected. Now the image looks as desired across Opera/FF and us.
- svg/as-background-image/same-image-two-instances-background-image.html: Added.
- svg/as-image/img-preserveAspectRatio-support-1.html: Added.
- svg/as-image/resources/circle-default-meet.svg: Added.
- svg/as-image/resources/circle-default-none.svg: Added.
- svg/as-image/resources/circle-default-slice.svg: Added.
- svg/as-image/resources/circle-nosize.svg: Added.
- svg/as-image/resources/circle-viewbox-default.svg: Added.
- svg/as-image/resources/circle-viewbox-meet.svg: Added.
- svg/as-image/resources/circle-viewbox-none.svg: Added.
- svg/as-image/resources/circle-viewbox-slice.svg: Added.
- svg/as-image/resources/green-relative-size-rect.svg: Use relative units everywhere as intended. Add circle to make it easy to spot ratio changes.
- svg/as-image/same-image-two-instances.html: Added.
- svg/as-image/svg-as-relative-image-with-explicit-size.html: Added.
- svg/as-image/svg-image-change-content-size.xhtml: Added.
- svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Added.
- svg/zoom/page/zoom-background-image-tiled.html: Added.
- svg/zoom/page/zoom-background-images.html: Added.
- svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Added.
- svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Added.
- svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Added.
- svg/zoom/page/zoom-svg-as-image.html: Added.
- svg/zoom/page/zoom-svg-as-relative-image.html: Added.
2011-10-31 Nikolas Zimmermann <nzimmermann@rim.com>
CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156
SVGs do not work as tiled background images
https://bugs.webkit.org/show_bug.cgi?id=16281
Apply preserveAspectRatio and synthesize viewboxes in <img>
https://bugs.webkit.org/show_bug.cgi?id=34521
SVG background doesn't resize properly when dimensions are changed
https://bugs.webkit.org/show_bug.cgi?id=42944
Images with percent height inside a floated div should use intrinsic height.
https://bugs.webkit.org/show_bug.cgi?id=45439
SVG image in HTML changes size as the window is resized
https://bugs.webkit.org/show_bug.cgi?id=52045
Reviewed by Antti Koivisto.
Implement intrinsic sizing support for SVGImage (svg embedded through <html:img>/<svg:image>/background-image/border-image/...).
This is demanded by CSS 2.1, and covered by new layout tests in LayoutTests/css2.1 and several new custom testcases.
Tests: css2.1/20110323/background-intrinsic-001.htm
css2.1/20110323/background-intrinsic-002.htm
css2.1/20110323/background-intrinsic-003.htm
css2.1/20110323/background-intrinsic-004.htm
css2.1/20110323/background-intrinsic-005.htm
css2.1/20110323/background-intrinsic-006.htm
css2.1/20110323/background-intrinsic-007.htm
css2.1/20110323/background-intrinsic-008.htm
css2.1/20110323/background-intrinsic-009.htm
svg/as-background-image/background-image-preserveaspectRatio-support.html (adapted from testcase from bug 34521)
svg/as-background-image/background-image-tiled.html (reduction from bug 16281)
svg/as-background-image/same-image-two-instances-background-image.html
svg/as-image/img-preserveAspectRatio-support-1.html (reduction from bug 34521)
svg/as-image/same-image-two-instances.html
svg/as-image/svg-as-relative-image-with-explicit-size.html
svg/as-image/svg-image-change-content-size.xhtml (reduction from bug 42944)
svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
svg/zoom/page/zoom-svg-as-image.html
svg/zoom/page/zoom-svg-as-relative-image.html
- css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::addClient): Pass default zoom factor. (WebCore::CSSImageGeneratorValue::getImage): Ditto.
- loader/cache/CachedImage.cpp: Enable SVGImage <-> IntSize cache. (WebCore::CachedImage::lookupImageForSize): Use recently introduced ImageBySizeCache, to lookup an image for a certain size. (WebCore::CachedImage::lookupOrCreateImageForRenderer): Use recently introduced ImageBySizeCache, to dynamically create copies of m_image if needed. (WebCore::CachedImage::imageForRenderer): Lookup image by renderer, which first looks up a size for a renderer, then uses lookupImageForSize(). (WebCore::CachedImage::setContainerSizeForRenderer): For SVGImages, pass on container size handling to ImageBySizeCache. (WebCore::CachedImage::imageSizeForRenderer): Figure out the image size, respecting per-renderer overrides, for a certain renderer. (WebCore::CachedImage::computeIntrinsicDimensions): Remove unnecessary RenderObject parameter.
- loader/cache/CachedImage.h:
- page/ChromeClient.h: (WebCore::ChromeClient::isSVGImageChromeClient): Used to identify whether a RenderSVGRoot is embedded through a SVGImage. Returns false, by default.
- platform/graphics/Image.h: (WebCore::Image::setImageObserver): Add helper.
- rendering/ImageBySizeCache.cpp: Cleanup code. (WebCore::ImageBySizeCache::addClient): Assert the passed renderer is valid. (WebCore::ImageBySizeCache::removeClient): Ditto. Allow removeClient() to be called w/o prio addClient() usage. (WebCore::ImageBySizeCache::getImage): Add zoom parameter. (WebCore::ImageBySizeCache::getRequestedSizeAndZoom): Add way to get requested size from cache, instead of actual cached sizes. (WebCore::ImageBySizeCache::imageForSize): Respect empty sizes, just return 0, instead of asserting. (WebCore::ImageBySizeCache::imageForRenderer): Added a helper that retrieves an image for a renderer, by lookup up its size and using imageForSize().
- rendering/ImageBySizeCache.h: Cleaup code, introduce struct that replaces the std::pair<IntSize, int>. (WebCore::SizeZoomAndCount::SizeZoomAndCount):
- rendering/RenderBoxModelObject.cpp: Implement CSS 2.1 intrinsic size negotiation for images. (WebCore::resolveWidthForRatio): New inline helper function used by calculateImageIntrinsicDimensions. (WebCore::resolveHeightForRatio): Ditto. (WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio): Ditto. (WebCore::resolveAgainstIntrinsicRatio): Ditto. (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): New helper function, containing the main algorithm, which is a pure transcription of the spec. (WebCore::RenderBoxModelObject::calculateFillTileSize): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size. (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Propagate calculateFillTileSize() result to the image resource, via setContainerSizeForRenderer(). (WebCore::RenderBoxModelObject::paintNinePieceImage): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size.
- rendering/RenderBoxModelObject.h: Clarify some variable names, added calculateImageIntrinsicDimensions().
- rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): Use IntSize(), instead of IntSize(0, 0). (WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Refactored from imageDimensionsChanged(). (WebCore::RenderImage::imageDimensionsChanged): Use updateIntrinsicSizeIfNeeded(). (WebCore::RenderImage::computeReplacedLogicalWidth): Use RenderReplaced::computeReplacedLogicalWidth() exclusively. For this to work, the intrinsic size must be correct. (WebCore::RenderImage::computeIntrinsicRatioInformation): Default implementation for non-SVGImages. (WebCore::RenderImage::needsPreferredWidthsRecalculation): Return true, just like RenderPart, if embeddedContentBox is not null. (WebCore::RenderImage::embeddedContentBox): Returns the RenderSVGRoot* renderer of the embedded SVG, if possible.
- rendering/RenderImage.h: Remove isLogicalWidth/HeightSpecified() / computeReplacedLogicalHeight() / calcAspectRatioLogicalWidth/Height().
- rendering/RenderImageResource.cpp: (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass around new "float containerZoomFactor" parameter.
- rendering/RenderImageResourceStyleImage.cpp: (WebCore::RenderImageResourceStyleImage::image): embeddedContentBox() is now calling image() earlier than before. We now have to handle the case that the image is pending. (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Pass zoom factor.
- rendering/RenderImageResourceStyleImage.h:
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::computePreferredLogicalWidths): Pass effective zoom to setContainerSizeForRenderer().
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): Generalized this code, as RenderImage is using it as well now. Marginal changes needed. (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto. (WebCore::RenderReplaced::computeReplacedLogicalWidth): Ditto.
- rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::computeIntrinsicDimensions): Stop passing m_renderer to CachedImage, it's no longer needed. (WebCore::StyleCachedImage::setContainerSizeForRenderer): Add "float containerZoomFactor" parameter.
- rendering/style/StyleCachedImage.h: Add "float containerZoomFactor" parameter to setContainerSizeForRenderer.
- rendering/style/StyleGeneratedImage.h: (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Ditto.
- rendering/style/StyleImage.h: Ditto.
- rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
- rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): Always supply a container size when embedding SVGs in <svg:image>.
- rendering/svg/RenderSVGRoot.cpp: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs. (WebCore::RenderSVGRoot::isEmbeddedThroughImageElement): Add helper method to determine whether we're loaded through SVGImage. (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): If we have a valid container size, it has precendence (only supplied via external SVGImages). (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto. (WebCore::RenderSVGRoot::layout): Remove calcViewport() usage, no need to track/override the viewport size anymore, all done in coputeReplacedLogical* now. (WebCore::RenderSVGRoot::paint): Use borderBoxRect() which now always matches the previously computed m_viewportSize. (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto.
- rendering/svg/RenderSVGRoot.h: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs. (WebCore::RenderSVGRoot::containerSize): (WebCore::RenderSVGRoot::setContainerSize):
- svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport): Resolve lengths against override container size in documents embedded through SVGImage.
- svg/SVGSVGElement.cpp: Remove "override container size" handling from SVGSVGElement. (WebCore::SVGSVGElement::SVGSVGElement): Ditto. (WebCore::SVGSVGElement::currentViewBoxRect): Always synthesize a viewBox, if we're embedded through SVGImage, as demanded by SVG 1.1 2nd Edition.
- svg/SVGSVGElement.h:
- svg/graphics/SVGImage.cpp: (WebCore::SVGImageChromeClient::isSVGImageChromeClient): Return true, used to identify whether RenderSVGRoot is embedded through SVGImage. (WebCore::SVGImage::createWithDataAndSize): Add new helper function. (WebCore::SVGImage::setContainerZoom): Forwarded to Page::setPageZoomFactor. (WebCore::SVGImage::setContainerSize): Assert that container size is not empty. We should never receive an empty container size. (WebCore::SVGImage::usesContainerSize): Adapt to override container size changes, it now lives in RenderSVGRoot instead of SVGSVGElement. (WebCore::SVGImage::size): New algorithm to figure out the size of an embedded SVG, as demanded by the CSS/SVG specs. (WebCore::SVGImage::embeddedContentBox): Add helper which returns the RenderSVGRoot of the document. (WebCore::SVGImage::computeIntrinsicDimensions): Implement intrinsic ratio calculation. (WebCore::SVGImage::dataChanged): Force calling FrameView::setCanHaveScrollbars(false), as SVG images now always synthesize a viewBox, and thus never receive scrollbars.
- svg/graphics/SVGImage.h:
- 7:04 AM QtWebKitForQt5 edited by
- (diff)
- 6:51 AM Changeset in webkit [98851] by
-
- 6 edits in trunk/Source/WebKit2
[Qt] Make QWebPreferences hold a QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=71219
Reviewed by Andreas Kling.
Change QWebPreferences to keep a pointer to QtWebPageProxy. The reason is that
some features we want to control (like the messaging exchange between WebView and
the web process) are not available via WKPreferencesRef.
QtWebPageProxy now uses an OwnPtr to keep the QWebPreferences to clarify the
ownership relationship. Before this change the QWebPreferences created was leaking.
- UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::createPreferences):
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
(QWebPreferencesPrivate::preferencesRef):
- UIProcess/API/qt/qwebpreferences.h:
- UIProcess/API/qt/qwebpreferences_p.h:
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::preferences):
- UIProcess/qt/QtWebPageProxy.h:
- 5:45 AM Changeset in webkit [98850] by
-
- 2 edits in trunk/Source/WebCore
2011-10-31 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Add ResourcePreviewView.js to the list of inspector front-end
files on Qt.
- inspector/front-end/WebKit.qrc:
- 5:28 AM Changeset in webkit [98849] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatting-source.html on QT.
- platform/qt/Skipped:
- 5:00 AM Changeset in webkit [98848] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Marked animations/change-keyframes.html as failing on SNOWLEOPARD DEBUG.
- platform/chromium/test_expectations.txt:
- 4:55 AM Changeset in webkit [98847] by
-
- 7 edits2 adds in trunk
Web Inspector: do not map scripts generated with document.write to the document resources.
https://bugs.webkit.org/show_bug.cgi?id=71114
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/debugger/bind-script-to-resource.html
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
- inspector/front-end/Script.js:
LayoutTests:
- inspector/debugger/bind-script-to-resource-expected.txt: Added.
- inspector/debugger/bind-script-to-resource.html: Added.
- inspector/debugger/linkifier.html:
- 4:55 AM Changeset in webkit [98846] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add webkit_settings_new_with_settings() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71111
Reviewed by Martin Robinson.
Convenient method to create a WebKitSettings object with initial
settings.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_new_with_settings):
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettingsNewWithSettings):
(beforeAll):
- 4:45 AM Changeset in webkit [98845] by
-
- 7 edits1 add in trunk/Source/WebKit2
[GTK] Add methods to get/set the settings of a web view to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71109
Reviewed by Martin Robinson.
- GNUmakefile.am: Add WebKitSettingsPrivate.h.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webkitSettingsAttachSettingsToPage): Set the preferences of the
given WebKitSettings object to the page group of the given WKPage.
- UIProcess/API/gtk/WebKitSettingsPrivate.h: Added.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Create the default WebKitSettings for
the view.
(webkit_web_view_set_settings):
(webkit_web_view_get_settings):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSettings):
(beforeAll):
- 4:23 AM Changeset in webkit [98844] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=71012
Use StringHasher to generate the matched declaration cache hash
Reviewed by Sam Weinig.
Make sure the MatchedStyleDeclarations are fully zero-initialized as we calculate a hash over a raw memory array of these.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclaration):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
- css/CSSStyleSelector.h:
- 3:28 AM Changeset in webkit [98843] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed.
Removed Mac10.5 CG expectation for css2.1/20110323/block-non-replaced-width-008.htm, marked it as fail.
- platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 3:26 AM Changeset in webkit [98842] by
-
- 4 edits in trunk/Source
Unreviewed. Fix make distcheck build.
Source/WebCore:
- GNUmakefile.am: Add InFilesCompiler.pm to SCRIPTS_BINDINGS and
EXTRA_DIST. Also remove duplicated entries in EXTRA_DIST.
Source/WebKit2:
- GNUmakefile.am: Remove docs/GNUmakefile.in from EXTRA_DIST,
since its generation was removed from configure.ac in r98498.
- 2:35 AM Changeset in webkit [98841] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Mark fast/canvas/shadow-offset-3.html as PASS CRASH on GPU LINUX DEBUG.
- platform/chromium/test_expectations.txt:
- 2:18 AM Changeset in webkit [98840] by
-
- 15 edits1 add in trunk/Source/WebCore
Web Inspector: factor out ResourceUtils, clean up externs.
https://bugs.webkit.org/show_bug.cgi?id=71192
Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-31
Reviewed by Yury Semikhatsky.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.sh:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):
- inspector/front-end/DebuggerPresentationModel.js:
- inspector/front-end/ProfilesPanel.js:
- inspector/front-end/Resource.js:
(WebInspector.Resource.displayName):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._createResource):
- inspector/front-end/ResourceUtils.js: Added.
(WebInspector.resourceForURL):
(WebInspector.forAllResources):
(WebInspector.displayNameForURL):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.registerLinkifierPlugin):
(WebInspector.linkifyStringAsFragment):
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyURL):
(WebInspector.formatLinkText):
(WebInspector.linkifyResourceAsNode):
(WebInspector.resourceURLForRelatedNode.callback):
(WebInspector.resourceURLForRelatedNode):
(WebInspector.populateHrefContextMenu):
(WebInspector.completeURL):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.selectElement):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector.networkResourceById):
- inspector/front-end/utilities.js:
(setupPrototypeUtilities.Element.prototype.selectionLeftOffset):
- 1:37 AM Changeset in webkit [98839] by
-
- 5 edits in trunk
Web Inspector: Using keyboard to increment/decrement units is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=71119
Reviewed by Pavel Feldman.
Source/WebCore:
This change makes the behavior consistent with that described at http://trac.webkit.org/wiki/WebInspector
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.alteredFloatNumber):
(WebInspector.StylesSidebarPane.prototype._attributesModified):
LayoutTests:
- inspector/styles/up-down-numerics-and-colors-expected.txt:
- inspector/styles/up-down-numerics-and-colors.html:
- 1:28 AM Changeset in webkit [98838] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. compositing/visibility/visibility-image-layers.html fails on GPU.
- platform/chromium/test_expectations.txt:
- 12:48 AM Changeset in webkit [98837] by
-
- 15 edits in trunk/Source/WebKit/chromium
[Chromium] The Chromium port calls OwnPtr::get and RefPtr::get way more often than needed
https://bugs.webkit.org/show_bug.cgi?id=71205
Reviewed by Ryosuke Niwa.
WebKit style is to use the implicit Boolean conversions rather than
calling get() on these pointer types. This patch cleans up most (all?)
of these style issues in the Chromium port in the hopes that they'll be
copy/pasted less in the future.
- src/ApplicationCacheHostInternal.h:
(WebCore::ApplicationCacheHostInternal::toWebApplicationCacheHost):
- src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::start):
(WebCore::AudioDestinationChromium::stop):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::setMainDocumentError):
(WebKit::FrameLoaderClientImpl::committedLoad):
(WebKit::FrameLoaderClientImpl::finishedLoading):
(WebKit::FrameLoaderClientImpl::redirectDataToPlugin):
- src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::postMessageToRemote):
- src/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
- src/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::connect):
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
- src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::hitTest):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::findChildByExpression):
(WebKit::WebFrameImpl::loadHistoryItem):
(WebKit::WebFrameImpl::characterIndexForPoint):
(WebKit::WebFrameImpl::selectionAsText):
(WebKit::WebFrameImpl::selectionAsMarkup):
(WebKit::WebFrameImpl::getPrintPageShrink):
(WebKit::WebFrameImpl::printPage):
(WebKit::WebFrameImpl::printEnd):
(WebKit::WebFrameImpl::scopeStringMatches):
- src/WebIDBKey.cpp:
(WebKit::WebIDBKey::type):
- src/WebIDBKeyRange.cpp:
(WebKit::WebIDBKeyRange::lower):
(WebKit::WebIDBKeyRange::upper):
(WebKit::WebIDBKeyRange::lowerOpen):
(WebKit::WebIDBKeyRange::upperOpen):
- src/WebImageCG.cpp:
(WebKit::WebImage::WebImage):
(WebKit::WebImage::operator=):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::cancelLoad):
(WebKit::WebMediaPlayerClientImpl::play):
(WebKit::WebMediaPlayerClientImpl::pause):
(WebKit::WebMediaPlayerClientImpl::sourceAppend):
(WebKit::WebMediaPlayerClientImpl::sourceEndOfStream):
(WebKit::WebMediaPlayerClientImpl::naturalSize):
(WebKit::WebMediaPlayerClientImpl::hasVideo):
(WebKit::WebMediaPlayerClientImpl::hasAudio):
(WebKit::WebMediaPlayerClientImpl::setVisible):
(WebKit::WebMediaPlayerClientImpl::duration):
(WebKit::WebMediaPlayerClientImpl::currentTime):
(WebKit::WebMediaPlayerClientImpl::seek):
(WebKit::WebMediaPlayerClientImpl::seeking):
(WebKit::WebMediaPlayerClientImpl::setEndTime):
(WebKit::WebMediaPlayerClientImpl::setRate):
(WebKit::WebMediaPlayerClientImpl::paused):
(WebKit::WebMediaPlayerClientImpl::supportsFullscreen):
(WebKit::WebMediaPlayerClientImpl::supportsSave):
(WebKit::WebMediaPlayerClientImpl::setVolume):
(WebKit::WebMediaPlayerClientImpl::networkState):
(WebKit::WebMediaPlayerClientImpl::readyState):
(WebKit::WebMediaPlayerClientImpl::maxTimeSeekable):
(WebKit::WebMediaPlayerClientImpl::buffered):
(WebKit::WebMediaPlayerClientImpl::dataRate):
(WebKit::WebMediaPlayerClientImpl::totalBytesKnown):
(WebKit::WebMediaPlayerClientImpl::totalBytes):
(WebKit::WebMediaPlayerClientImpl::bytesLoaded):
(WebKit::WebMediaPlayerClientImpl::setSize):
(WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext):
(WebKit::WebMediaPlayerClientImpl::setPreload):
(WebKit::WebMediaPlayerClientImpl::hasSingleSecurityOrigin):
(WebKit::WebMediaPlayerClientImpl::movieLoadType):
(WebKit::WebMediaPlayerClientImpl::mediaTimeForTimeValue):
(WebKit::WebMediaPlayerClientImpl::decodedFrameCount):
(WebKit::WebMediaPlayerClientImpl::droppedFrameCount):
(WebKit::WebMediaPlayerClientImpl::audioDecodedByteCount):
(WebKit::WebMediaPlayerClientImpl::videoDecodedByteCount):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::startDelayedLoad):
- src/WebURLRequest.cpp:
(WebKit::WebURLRequest::extraData):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::theme):
(WebKit::WebViewImpl::mainFrameImpl):
(WebKit::WebViewImpl::tabKeyCyclesThroughElements):
(WebKit::WebViewImpl::hideSelectPopup):
(WebKit::WebViewImpl::popupClosed):
(WebKit::WebViewImpl::focusedWebCoreFrame):
(WebKit::WebViewImpl::close):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::handleInputEvent):
(WebKit::WebViewImpl::setFocus):
(WebKit::WebViewImpl::compositionRange):
(WebKit::WebViewImpl::caretOrSelectionRange):
(WebKit::WebViewImpl::settings):
(WebKit::WebViewImpl::pageEncoding):
(WebKit::WebViewImpl::setPageEncoding):
(WebKit::WebViewImpl::setInitialFocus):
(WebKit::WebViewImpl::clearFocusedNode):
(WebKit::WebViewImpl::copyImageAt):
(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragLeave):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):
(WebKit::WebViewImpl::inspectElementAt):
(WebKit::WebViewImpl::applyAutofillSuggestions):
- src/WebWorkerBase.cpp:
(WebKit::WebWorkerBase::postMessageTask):
- src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::waitForOperationToComplete):
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):
- 12:10 AM Changeset in webkit [98836] by
-
- 2 edits in trunk/Source/WebKit/chromium
Add missing declaration in WebSettings.h
https://bugs.webkit.org/show_bug.cgi?id=71165
Reviewed by Darin Fisher.
- public/WebSettings.h:
