Context Navigation

← Previous Period
Next Period →

Timeline

Feb 14, 2012:

11:03 PM Changeset in webkit [107784] by commit-queue@webkit.org

5 edits in trunk

Cleanup pending transaction queue in Database.
https://bugs.webkit.org/show_bug.cgi?id=75048

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-02-14
Reviewed by David Levin.

Source/WebCore:

Each SQLTransaction has 3 SQLCallbackWrappers, and each of them
holds a ref to WorkerContext. As a result, if the worker thread is
stopped before all SQLTransactions are finished, the ASSERT of
m_workerContext->hasOneRef() in WorkerThread::workerThread() would fail.

No new tests.
REGRESSION(r103429) fast/workers/storage/use-same-database-in-page-and-workers.html asserts

storage/Database.cpp:

(WebCore::Database::close): Cleanup pending transaction queue in close().

storage/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::clear):
(SafeReleaseTask): Make SafeReleaseTask a cleanup task, which is
necessary because at the time of SafeReleaseTask is performed,
WorkerRunLoop has been terminated and only runs cleanup tasks.
(WebCore::SQLCallbackWrapper::SafeReleaseTask::create):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):

LayoutTests:

As crash is fixed, trun BUGWK75048 into BUGWK75111, so that we can
close 75048 and fix the timeout in 75111 for both DEBUG and RELEASE.

REGRESSION(r103429) fast/workers/storage/use-same-database-in-page-and-workers.html asserts

platform/chromium/test_expectations.txt:

10:58 PM Changeset in webkit [107783] by Antti Koivisto

4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=78662
CSSStyleSelector should not rely on parent rule pointer in StylePropertySet

Reviewed by Andreas Kling.

Pass the rule pointer down to the style applying so we don't need to rely on
StylePropertySet having one.

To make this easier the patch also refactors the matched properties vector to
be part of MatchResult object instead of a member of CSSStyleSelector.

Rename Declaration -> Properties.

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::sweepMatchedPropertiesCache):
(WebCore::CSSStyleSelector::addMatchedProperties):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::matchAuthorRules):
(WebCore::CSSStyleSelector::matchUserRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore):
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::matchesRuleSet):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyProperties):
(WebCore::CSSStyleSelector::applyMatchedProperties):
(WebCore::CSSStyleSelector::computeMatchedPropertiesHash):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::CSSStyleSelector::findFromMatchedPropertiesCache):
(WebCore::CSSStyleSelector::addToMatchedPropertiesCache):
(WebCore::CSSStyleSelector::invalidateMatchedPropertiesCache):
(WebCore::isCacheableInMatchedPropertiesCache):
(WebCore::CSSStyleSelector::matchPageRules):

css/CSSStyleSelector.h:

(CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedRule):
(WebCore::CSSStyleSelector::MatchedProperties::MatchedProperties):
(MatchedProperties):
(MatchResult):
(MatchedPropertiesCacheItem):

10:56 PM Changeset in webkit [107782] by toyoshim@chromium.org

3 edits
1 add in trunk/Source/WebKit/chromium

Provide SocketStreamHandleInternal::toWebSocketStreamHandle(SocketStreamHandle*).
https://bugs.webkit.org/show_bug.cgi?id=78581

Reviewed by Kent Tamura.

Now, there is no way to convert SocketStreamHandle to
WebSocketStreamHandle. In subsequent changes, I'll use this function
in FrameLoaderClientImpl.

src/SocketStreamHandle.cpp: Remove SocketStreamHandleInternal class declaration.
src/SocketStreamHandleInternal.h: Move SocketStreamHandleInternal class declaration from SocketStreamHandle.cpp to expose, and add conversion function to WebSocketStreamHandle from SocketStreamHandle.

(WebKit):
(WebCore):
(SocketStreamHandleInternal):
(WebCore::SocketStreamHandleInternal::create):
(WebCore::SocketStreamHandleInternal::toWebSocketStreamHandle):

WebKit.gyp: Add SocketStreamHandleInternal.h entry.

10:56 PM Changeset in webkit [107781] by tkent@chromium.org

62 edits
64 deletes in trunk/LayoutTests

Stop using script-tests in LayoutTests/fast/forms
https://bugs.webkit.org/show_bug.cgi?id=78667

Reviewed by Kentaro Hara.

fast/forms/ValidityState-patternMismatch-unsupported.html:
fast/forms/ValidityState-rangeOverflow.html:
fast/forms/ValidityState-rangeUnderflow.html:
fast/forms/ValidityState-stepMismatch.html:
fast/forms/ValidityState-tooLong-input.html:
fast/forms/ValidityState-tooLong-textarea.html:
fast/forms/ValidityState-typeMismatch-date-expected.txt: Removed.
fast/forms/ValidityState-typeMismatch-url.html:
fast/forms/ValidityState-valueMissing-radio.html:
fast/forms/checkValidity-cancel.html:
fast/forms/checkValidity-handler-updates-dom.html:
fast/forms/form-attribute-elements-order.html:
fast/forms/form-attribute-elements-order2.html:
fast/forms/form-attribute-elements.html:
fast/forms/form-attribute.html:
fast/forms/form-collection-elements-order.html:
fast/forms/form-collection-elements.html:
fast/forms/formnovalidate-attribute.html:
fast/forms/incremental-dom-property.html:
fast/forms/input-maxlength-ime-completed.html:
fast/forms/input-maxlength-ime-preedit.html:
fast/forms/input-maxlength-unsupported.html:
fast/forms/input-minmax.html:
fast/forms/input-pattern.html:
fast/forms/input-step.html:
fast/forms/input-stepup-stepdown.html:
fast/forms/input-type-change3.html:
fast/forms/input-valueasnumber-unsupported.html:
fast/forms/labels-add-htmlFor-label.html:
fast/forms/labels-add-parent-label.html:
fast/forms/labels-change-htmlFor-attribute.html:
fast/forms/labels-item-index.html:
fast/forms/labels-remove-htmlFor-attribute.html:
fast/forms/labels-remove-htmlFor-label.html:
fast/forms/labels-remove-parent-label.html:
fast/forms/labels-set-htmlFor-attribute.html:
fast/forms/listbox-deselect-scroll.html:
fast/forms/listbox-selection-2.html:
fast/forms/listbox-selection.html:
fast/forms/menulist-disabled-selected-option.html:
fast/forms/menulist-submit-without-selection.html:
fast/forms/novalidate-attribute.html:
fast/forms/output-reset-assertion-failed.html:
fast/forms/placeholder-dom-property.html:
fast/forms/script-tests/TEMPLATE.html: Removed.
fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Removed.
fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed.
fast/forms/script-tests/ValidityState-rangeUnderflow.js: Removed.
fast/forms/script-tests/ValidityState-stepMismatch.js: Removed.
fast/forms/script-tests/ValidityState-tooLong-input.js: Removed.
fast/forms/script-tests/ValidityState-tooLong-textarea.js: Removed.
fast/forms/script-tests/ValidityState-typeMismatch-date.js: Removed.
fast/forms/script-tests/ValidityState-typeMismatch-url.js: Removed.
fast/forms/script-tests/ValidityState-valueMissing-radio.js: Removed.
fast/forms/script-tests/checkValidity-cancel.js: Removed.
fast/forms/script-tests/checkValidity-handler-updates-dom.js: Removed.
fast/forms/script-tests/form-attribute-elements-order.js: Removed.
fast/forms/script-tests/form-attribute-elements-order2.js: Removed.
fast/forms/script-tests/form-attribute-elements.js: Removed.
fast/forms/script-tests/form-attribute.js: Removed.
fast/forms/script-tests/form-collection-elements-order.js: Removed.
fast/forms/script-tests/form-collection-elements.js: Removed.
fast/forms/script-tests/formnovalidate-attribute.js: Removed.
fast/forms/script-tests/incremental-dom-property.js: Removed.
fast/forms/script-tests/input-maxlength-ime-completed.js: Removed.
fast/forms/script-tests/input-maxlength-ime-preedit.js: Removed.
fast/forms/script-tests/input-maxlength-unsupported.js: Removed.
fast/forms/script-tests/input-minmax.js: Removed.
fast/forms/script-tests/input-pattern.js: Removed.
fast/forms/script-tests/input-step.js: Removed.
fast/forms/script-tests/input-stepup-stepdown.js: Removed.
fast/forms/script-tests/input-type-change3.js: Removed.
fast/forms/script-tests/input-valueasnumber-unsupported.js: Removed.
fast/forms/script-tests/labels-add-htmlFor-label.js: Removed.
fast/forms/script-tests/labels-add-parent-label.js: Removed.
fast/forms/script-tests/labels-change-htmlFor-attribute.js: Removed.
fast/forms/script-tests/labels-item-index.js: Removed.
fast/forms/script-tests/labels-remove-htmlFor-attribute.js: Removed.
fast/forms/script-tests/labels-remove-htmlFor-label.js: Removed.
fast/forms/script-tests/labels-remove-parent-label.js: Removed.
fast/forms/script-tests/labels-set-htmlFor-attribute.js: Removed.
fast/forms/script-tests/listbox-deselect-scroll.js: Removed.
fast/forms/script-tests/listbox-selection-2.js: Removed.
fast/forms/script-tests/listbox-selection.js: Removed.
fast/forms/script-tests/menulist-disabled-selected-option.js: Removed.
fast/forms/script-tests/menulist-submit-without-selection.js: Removed.
fast/forms/script-tests/novalidate-attribute.js: Removed.
fast/forms/script-tests/output-reset-assertion-failed.js: Removed.
fast/forms/script-tests/placeholder-dom-property.js: Removed.
fast/forms/script-tests/search-cancel-button-events.js: Removed.
fast/forms/script-tests/select-set-length-optgroup.js: Removed.
fast/forms/script-tests/select-set-length-with-mutation-remove.js: Removed.
fast/forms/script-tests/select-set-length-with-mutation-reorder.js: Removed.
fast/forms/script-tests/select-set-length-with-mutation-reparent.js: Removed.
fast/forms/script-tests/select-set-length-with-mutation.js: Removed.
fast/forms/script-tests/select-set-length.js: Removed.
fast/forms/script-tests/setCustomValidity-existence.js: Removed.
fast/forms/script-tests/shadow-tree-exposure.js: Removed.
fast/forms/script-tests/submit-form-attributes.js: Removed.
fast/forms/script-tests/text-control-intrinsic-widths.js: Removed.
fast/forms/script-tests/textarea-maxlength.js: Removed.
fast/forms/script-tests/textarea-metrics.js: Removed.
fast/forms/script-tests/textarea-placeholder-dom-property.js: Removed.
fast/forms/script-tests/textarea-rows-cols.js: Removed.
fast/forms/script-tests/textarea-textlength.js: Removed.
fast/forms/script-tests/validationMessage.js: Removed.
fast/forms/script-tests/willvalidate.js: Removed.
fast/forms/search-cancel-button-events.html:
fast/forms/select-set-length-optgroup.html:
fast/forms/select-set-length-with-mutation-remove.html:
fast/forms/select-set-length-with-mutation-reorder.html:
fast/forms/select-set-length-with-mutation-reparent.html:
fast/forms/select-set-length-with-mutation.html:
fast/forms/select-set-length.html:
fast/forms/setCustomValidity-existence.html:
fast/forms/shadow-tree-exposure.html:
fast/forms/submit-form-attributes.html:
fast/forms/text-control-intrinsic-widths.html:
fast/forms/textarea-maxlength.html:
fast/forms/textarea-metrics.html:
fast/forms/textarea-placeholder-dom-property.html:
fast/forms/textarea-rows-cols.html:
fast/forms/textarea-textlength.html:
fast/forms/validationMessage.html:
fast/forms/willvalidate.html:

10:39 PM Changeset in webkit [107780] by toyoshim@chromium.org

5 edits in trunk/Source/WebCore

WebSocketChannel minor refactoring for code manageability
https://bugs.webkit.org/show_bug.cgi?id=78576

Reviewed by Kent Tamura.

Change the first argument type of WebSocketChannel
from ScriptExecutionContext to Document.
WebSocketChannel always assume this ScriptExecutionContext must
inherit Document. Then, it results in many static cast.
It isn't readable and dangerous against future code changes.

websockets/ThreadableWebSocketChannel.cpp: Pass the first argument for WebSocketChannel as Document.

(WebCore::ThreadableWebSocketChannel::create):

websockets/WebSocketChannel.cpp: Replace all ScriptExecutionContext* m_context descriptions to Document* m_document.

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):

websockets/WebSocketChannel.h: Change the first argument for construction to Document and hold it as Document m_document.

(WebCore):
(WebCore::WebSocketChannel::create):
(WebSocketChannel):

websockets/WorkerThreadableWebSocketChannel.cpp: Pass the first argument for WebSocketChannel as Document.

(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):

10:00 PM Changeset in webkit [107779] by noel.gordon@gmail.com

8 edits in trunk/Source/WebCore

Unreviewed, rolling out r107774.
http://trac.webkit.org/changeset/107774
https://bugs.webkit.org/show_bug.cgi?id=78661

Broke Chromium build

page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

platform/ScrollAnimator.cpp:

(WebCore):
(WebCore::ScrollAnimator::handleGestureEvent):

platform/ScrollAnimator.h:

(ScrollAnimator):

platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

platform/ScrollView.h:

(ScrollView):

platform/ScrollableArea.cpp:

(WebCore):
(WebCore::ScrollableArea::handleGestureEvent):

platform/ScrollableArea.h:

(ScrollableArea):

9:19 PM Changeset in webkit [107778] by bashi@chromium.org

7 edits
3 deletes in trunk/Source

Unreviewed, rolling out r107766.
http://trac.webkit.org/changeset/107766
https://bugs.webkit.org/show_bug.cgi?id=78665

Breaks Chromium Win build (Requested by bashi1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-14

Source/WebCore:

GNUmakefile.list.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
websockets/WebSocketDeflater.cpp: Removed.
websockets/WebSocketDeflater.h: Removed.

Source/WebKit/chromium:

WebKit.gypi:
tests/WebSocketDeflaterTest.cpp: Removed.

9:10 PM Changeset in webkit [107777] by noel.gordon@gmail.com

9 edits
2 adds
2 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #10 of N.

platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Removed.
platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Removed.
platform/chromium-win/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
platform/chromium/test_expectations.txt:

8:13 PM Changeset in webkit [107776] by weinig@apple.com

2 edits in trunk/Tools

Add #include of unistd.h on the mac for getcwd.

Reviewed by Anders Carlsson.

This is necessary when building with libc++.

WebKitTestRunner/TestInvocation.cpp:

8:10 PM Changeset in webkit [107775] by weinig@apple.com

3 edits in trunk/Tools

In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
https://bugs.webkit.org/show_bug.cgi?id=78663

Reviewed by Anders Carlsson.

DumpRenderTree/DumpRenderTreePrefix.h:
DumpRenderTree/cg/ImageDiffCG.cpp:

7:56 PM Changeset in webkit [107774] by andersca@apple.com

8 edits in trunk/Source/WebCore

Remove ScrollableArea::handleGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=78661

Reviewed by Sam Weinig.

ScrollableArea::handleGestureEvent ends up being a no-op so remove it and the related code.

page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

platform/ScrollAnimator.cpp:
platform/ScrollAnimator.h:

(ScrollAnimator):

platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

platform/ScrollView.h:

(ScrollView):

platform/ScrollableArea.cpp:
platform/ScrollableArea.h:

(ScrollableArea):

7:42 PM Changeset in webkit [107773] by eae@chromium.org

2758 edits
1243 copies
52 adds
402 deletes in branches/subpixellayout

Merging trunk changes up until 107734 into subpixel branch.

7:22 PM Changeset in webkit [107772] by haraken@chromium.org

9 edits
2 adds in trunk

[JSC] Cache the number of non-custom constructor arguments
https://bugs.webkit.org/show_bug.cgi?id=78195

Reviewed by Darin Adler.

Source/WebCore:

If [ConstructorParameters=] is specified, JSC caches the number of constructor
arguments for performance. However, at present, [ConstructorParameters=] is specified
on a small part of constructors (It appears that people have forgotten to
add [ConstructorParameters=]). Thus, for non-custom constructors, this patch modifies
CodeGeneratorJS.pm so that it caches the number of constructor arguments automatically
without [ConstructorParameters=] (CodeGeneratorJS.pm can know the number of arguments
by the [Constructor=...] signature).

Test: fast/js/constructor-length.html

bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

LayoutTests:

The added tests check the length property of constructors.
The test fails for "flag-disabled" constructors.

fast/js/constructor-length.html: Added.
platform/mac/fast/js/constructor-length-expected.txt: Added.

platform/chromium/test_expectations.txt:
platform/efl/Skipped:
platform/gtk/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wk2/Skipped:

7:04 PM Changeset in webkit [107771] by mrowe@apple.com

2 edits in trunk/Source/WebCore

<http://webkit.org/b/78658> platformUserPreferredLanguages is leaking all of the language codes

Reviewed by Darin Adler.

platform/mac/Language.mm:

(WebCore::httpStyleLanguageCode): Switch to using RetainPtr's for temporaries to make the ownership
more explicit. Switch to returning a WTF::String so that the caller doesn't have to worry about
ownership at all. Change the name to reflect the lack of transfer of ownership.
(WebCore::platformUserPreferredLanguages):

6:20 PM Changeset in webkit [107770] by haraken@chromium.org

2 edits in trunk/Source/WebCore

[Mac] PasteboardMac.mm build fails
https://bugs.webkit.org/show_bug.cgi?id=78655

Reviewed by Hajime Morita.

Although the bots have been working fine, PasteboardMac.mm build fails
in our local Mac environments due to an uninitialized variable:

/Users/haraken/WebKit/Source/WebCore/platform/mac/PasteboardMac.mm:322: warning: 'string' may be used uninitialized in this function

This patch initializes the 'string' to nil to fix the build failure.

No tests. No change in behavior.

platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::plainText):

6:11 PM Changeset in webkit [107769] by bashi@chromium.org

16 edits in trunk/Source

[WebSocket] Add extension attribute support
https://bugs.webkit.org/show_bug.cgi?id=78557

Source/WebCore:

Implement WebSocket "extensions" attribute that holds a list of
extension the server accepted. No change in behavior at this time
because we don't send any extension on handshake.

Reviewed by Kent Tamura.

No new tests. http/tests/websocket/tests/hybi/extensions.html checks the value of this attribute.

websockets/ThreadableWebSocketChannel.h: Add extensions().

(ThreadableWebSocketChannel):

websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::extensions): Added.
(WebCore):
(WebCore::ThreadableWebSocketChannelClientWrapper::setExtensions): Added.

websockets/ThreadableWebSocketChannelClientWrapper.h:

(ThreadableWebSocketChannelClientWrapper):

websockets/WebSocket.cpp: Added m_extensions member variable.

(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::extensions): Returns m_extensions.

websockets/WebSocket.h:
websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::extensions): Added.
(WebCore):

websockets/WebSocketChannel.h:

(WebSocketChannel):

websockets/WebSocketExtensionDispatcher.cpp:

(WebCore::WebSocketExtensionDispatcher::fail): Added.
(WebCore::WebSocketExtensionDispatcher::processHeaderValue): Stores accepted extensions.
(WebCore::WebSocketExtensionDispatcher::acceptedExtensions): Added.
(WebCore):
(WebCore::WebSocketExtensionDispatcher::acceptedExtensions): Added.

websockets/WebSocketExtensionDispatcher.h:

(WebSocketExtensionDispatcher):

websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::acceptedExtensions): Added.
(WebCore):

websockets/WebSocketHandshake.h:
websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::extensions): Added.
(WebCore):
(WebCore::workerContextDidConnect): Calls ThreadableWebSocketChannelClientWrapper::setExtensions().
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect): Passes extensions as an argument.

websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):

Source/WebKit/chromium:

Add WebSocketExtensionDispatcher::acceptedExtensions() checks.

Reviewed by Kent Tamura.

tests/WebSocketExtensionDispatcherTest.cpp:

(WebCore::TEST_F):

6:05 PM Changeset in webkit [107768] by haraken@chromium.org

33 edits in trunk/Source/WebCore

Rename [JSGenerateToJS] to [JSGenerateToJSObject]
https://bugs.webkit.org/show_bug.cgi?id=78490

Reviewed by Adam Barth.

This patch renames [JSGenerateToJS] to [JSGenerateToJSObject],
for naming consistency with [CustomToJSObject], [JSCustomToJSObject] and [V8CustomToJSObject].

No tests. No change in behavior.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

dom/WebKitNamedFlow.idl:
fileapi/DirectoryEntry.idl:
fileapi/DirectoryEntrySync.idl:
fileapi/File.idl:
fileapi/FileEntry.idl:
fileapi/FileEntrySync.idl:
html/DOMFormData.idl:
html/DOMSettableTokenList.idl:
html/DOMURL.idl:
html/MediaController.idl:
mediastream/LocalMediaStream.idl:
webaudio/AudioBufferCallback.idl:
webaudio/AudioBufferSourceNode.idl:
webaudio/AudioDestinationNode.idl:
webaudio/AudioGain.idl:
webaudio/AudioGainNode.idl:
webaudio/AudioPannerNode.idl:
webaudio/AudioProcessingEvent.idl:
webaudio/BiquadFilterNode.idl:
webaudio/ConvolverNode.idl:
webaudio/DelayNode.idl:
webaudio/DynamicsCompressorNode.idl:
webaudio/HighPass2FilterNode.idl:
webaudio/JavaScriptAudioNode.idl:
webaudio/LowPass2FilterNode.idl:
webaudio/MediaElementAudioSourceNode.idl:
webaudio/OfflineAudioCompletionEvent.idl:
webaudio/RealtimeAnalyserNode.idl:
webaudio/WaveShaperNode.idl:
workers/SharedWorker.idl:
workers/Worker.idl:

6:04 PM Changeset in webkit [107767] by noel.gordon@gmail.com

13 edits
1 move in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #9 of N.

platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Renamed from LayoutTests/platform/chromium/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt.
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
platform/chromium/test_expectations.txt:

6:02 PM Changeset in webkit [107766] by bashi@chromium.org

7 edits
3 adds in trunk/Source

Source/WebCore: [WebSocket] Add deflater/inflater classes
https://bugs.webkit.org/show_bug.cgi?id=78449

Add WebSocketDeflater/WebSocketInflater classes which wrap zlib
functions. These classes are not used yet, but will be used for
supporting WebSocket deflate-frame extension.

Reviewed by Kent Tamura.

No new tests except for chromium port. Behavior is unchanged.

GNUmakefile.list.am: Added.WebSocketDeflater.(cpp|h).
WebCore.gypi: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
websockets/WebSocketDeflater.cpp: Added.

(WebCore):
(WebCore::WebSocketDeflater::create):
(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::create):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):
(WebCore::WebSocketInflater::reset):

websockets/WebSocketDeflater.h: Added.

(WebCore):
(WebSocketDeflater):
(WebCore::WebSocketDeflater::data):
(WebCore::WebSocketDeflater::size):
(WebSocketInflater):
(WebCore::WebSocketInflater::data):
(WebCore::WebSocketInflater::size):

Source/WebKit/chromium: [WebSocket] Add deflater/inflater classes.
https://bugs.webkit.org/show_bug.cgi?id=78449

Add tests which ensure WebSocketDeflater/WebSocketInflater can
compress/decompress data correctly.

Reviewed by Kent Tamura.

WebKit.gypi:
tests/WebSocketDeflaterTest.cpp: Added.

(WebCore):
(WebCore::TEST):

5:50 PM Changeset in webkit [107765] by leviw@chromium.org

2 edits in branches/subpixellayout/Source/WebCore/rendering

Fixing up more border painting logic that should be integers instead of layout types.

5:47 PM Changeset in webkit [107764] by commit-queue@webkit.org

1 edit
3 adds in trunk/Source/WebKit

[BlackBerry] Upstreaming WebSettings code
https://bugs.webkit.org/show_bug.cgi?id=78633

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-14
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

blackberry/Api/WebSettings.cpp: Added.
blackberry/Api/WebSettings.h: Added.
blackberry/Api/WebSettings_p.h: Added.

5:34 PM Changeset in webkit [107763] by commit-queue@webkit.org

4 edits in trunk/Source

[chromium] Compare filters on impl thread when setting them, and test setting in unit tests
https://bugs.webkit.org/show_bug.cgi?id=78643

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-14
Reviewed by James Robinson.

Source/WebCore:

Add setFilters() coverage to CCLayerImplTest.cpp

platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setFilters):

Source/WebKit/chromium:

tests/CCLayerImplTest.cpp:

(WebCore::TEST):

5:34 PM Changeset in webkit [107762] by fischman@chromium.org

16 edits in trunk/LayoutTests

Convert a couple of media layouttests to mock scrollbars & rebaseline
https://bugs.webkit.org/show_bug.cgi?id=78634

Unreviewed layouttest rebaselining.

platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
platform/chromium-gpu-linux/media/video-zoom-expected.png:
platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
platform/chromium-gpu-mac/media/video-zoom-expected.png:
platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
platform/chromium-gpu-win/media/video-zoom-expected.png:
platform/chromium-linux/media/video-controls-rendering-expected.png:
platform/chromium-linux/media/video-zoom-expected.png:
platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
platform/chromium-mac-leopard/media/video-zoom-expected.png:
platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
platform/chromium-mac-snowleopard/media/video-zoom-expected.png:
platform/chromium-win/media/video-controls-rendering-expected.png:
platform/chromium-win/media/video-zoom-expected.png:
platform/chromium/test_expectations.txt:

5:23 PM Changeset in webkit [107761] by rniwa@webkit.org

3 edits
2 adds in trunk

Crash in deleteInsignificantText
https://bugs.webkit.org/show_bug.cgi?id=78567

Reviewed by Eric Seidel.

Source/WebCore:

Fix the crash. Also update layout at the beginning of each call to deleteInsignificantText
since the previous call may have mutated the DOM.

Test: editing/inserting/delete-insignificant-text-crash.html

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):

LayoutTests:

Add a regression test.

editing/inserting/delete-insignificant-text-crash.html: Added.
editing/inserting/delete-insignificant-text-crash.txt: Added.

5:20 PM Changeset in webkit [107760] by leviw@chromium.org

6 edits in trunk/Source/WebCore

Prepare RenderLayerBacking and RenderLayerCompositor for subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=78630

Reviewed by Simon Fraser.

In our transition to subpixel layout in the render tree, we continue to pass RenderLayerBacking
and RenderLayerCompositor integer (pixel) sizes and positions. This patch moves nearly all
methods and members on these two classes back to integers, and applies pixel snapping logic to
LayoutUnits pulled in.

No new tests. No change in behavior.

rendering/RenderBox.h:

(WebCore::RenderBox::pixelSnappedLayoutOverflowRect): Convenience function for getting pixel
snapped overflow bounds.

rendering/RenderLayerBacking.cpp:

(WebCore):
(WebCore::RenderLayerBacking::updateCompositedBounds): Switch to integers and pixel snapping the
clipping bounds.
(WebCore::clipBox): Returns a pixel snapped rect.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Using pixelSnappedLayerCoords. Removing
pixelSnappedIntRect calls to clipBox since this is now an IntRect.
(WebCore::RenderLayerBacking::computeTransformOrigin): Switching to operate on a pixel snapped rect.
(WebCore::RenderLayerBacking::computePerspectiveOrigin): Ditto.
(WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): Returns a size based on m_compositingBounds,
which is now an IntSize.
(WebCore::RenderLayerBacking::contentsBox): Switching to use pixel snapped values from the render tree.
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): This now takes in and outputs integers.
(WebCore::RenderLayerBacking::paintIntoLayer): Uses a pixel snapped rect for the dirty rect.
(WebCore::paintScrollbar): Scrollbars are Widgets & painted natively, so they should use integers.
(WebCore::RenderLayerBacking::paintContents): We now properly take in an integer clip rect, as it's
used for the scrollbars.
(WebCore::RenderLayerBacking::startAnimation): Using pixel snapped values for animations and transitions.
(WebCore::RenderLayerBacking::startTransition): Ditto.
(WebCore::RenderLayerBacking::compositedBounds): Composited bounds are now properly stored as integers.
(WebCore::RenderLayerBacking::setCompositedBounds): Ditto.

rendering/RenderLayerBacking.h:

(RenderLayerBacking):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds): Composited bounds are pixel snapped, but
we use LayoutUnits up until we snap and return.
(WebCore::RenderLayerCompositor::addToOverlapMap): Overlap mapping uses our integer positions. Switching
it back to operating on them.
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive): Ditto.
(WebCore::RenderLayerCompositor::overlapsCompositedLayers): Ditto.
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Using integers.
(WebCore::RenderLayerCompositor::frameViewDidChangeLocation): FrameViews are on integer bounds. We now
properly use these as integers.
(WebCore::RenderLayerCompositor::frameViewDidScroll): Ditto.
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): Switching to use integers and
pixelSnappedLayerCoords.
(WebCore::RenderLayerCompositor::repaintCompositedLayersAbsoluteRect): Ditto.
(WebCore::RenderLayerCompositor::updateRootLayerPosition): Using integer positions, which are what
the apis used already returned.
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin): Using pixel snapped values.
(WebCore::RenderLayerCompositor::requiresCompositingForFrame): Ditto.
(WebCore::paintScrollbar): Scrollbars should always use integers.
(WebCore::RenderLayerCompositor::paintContents): Switching to use an integer clip rect.
(WebCore::RenderLayerCompositor::ensureRootLayer): Using values from new pixelSnappedLayoutOverflowRect
method on RenderBox to ensure we're using values that are pixel snapped to the proper location.
(WebCore::RenderLayerCompositor::destroyRootLayer): Properly calling scrollbar invalidation methods
with integers.

rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

5:16 PM Changeset in webkit [107759] by noel.gordon@gmail.com

5 edits
3 adds
3 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #8 of N.

platform/chromium-mac-snowleopard/fast/writing-mode/background-horizontal-bt-expected.png: Added.
platform/chromium-mac-snowleopard/fast/writing-mode/background-vertical-lr-expected.png: Added.
platform/chromium-mac-snowleopard/fast/writing-mode/background-vertical-rl-expected.png: Added.
platform/chromium-mac/fast/writing-mode/background-horizontal-bt-expected.png: Removed.
platform/chromium-mac/fast/writing-mode/background-vertical-lr-expected.png: Removed.
platform/chromium-mac/fast/writing-mode/background-vertical-rl-expected.png: Removed.
platform/chromium-win/fast/writing-mode/background-horizontal-bt-expected.png:
platform/chromium-win/fast/writing-mode/background-vertical-lr-expected.png:
platform/chromium-win/fast/writing-mode/background-vertical-rl-expected.png:
platform/chromium/test_expectations.txt:

5:08 PM Changeset in webkit [107758] by andersca@apple.com

8 edits in trunk/Source

Swipe gestures don't work if main frame has a horizontal scrollbar
https://bugs.webkit.org/show_bug.cgi?id=78650
<rdar://problem/10864993>

Reviewed by Sam Weinig.

Source/WebCore:

Change ScrollingTree::tryToHandleWheelEvent so we can indicate that an event was
processed by the scrolling tree but that we should indicate back to WebKit that it wasn't handled.

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Initialize new member variables.

(WebCore::ScrollingTree::tryToHandleWheelEvent):
If the wheel event will start a swipe gesture, return DidNotHandleEvent.

(WebCore::ScrollingTree::updateBackForwardState):
This can now be called from any thread, so use a mutex.

(WebCore::ScrollingTree::setMainFramePinState):
New function that will set the current main frame pin state.

(WebCore::ScrollingTree::canGoBack):
(WebCore::ScrollingTree::canGoForward):
Put locks around these.

(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
Helper function that returns whether the given wheel event will start a swipe gesture
because the main frame is pinned to the left/right and we can go back/forward.

page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::update):
Call updateMainFramePinState if the frame geometry changes.

(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Call updateMainFramePinState.

(WebCore::ScrollingTreeNodeMac::updateMainFramePinState):
Compute the main frame pin state and set it on the scrolling tree.

Source/WebKit2:

WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):
ScrollingTree::tryToHandleWheelEvent now returns a tri-state enum so handle the extra case.

(WebKit::EventDispatcher::sendDidReceiveEvent):
Rename this now that it takes a parameter indicating whether the event was handled or not.

5:05 PM Changeset in webkit [107757] by bweinstein@apple.com

13 edits in trunk/Source

Source/WebCore: Web Inspector: Add the ability to show the resources panel on launch
https://bugs.webkit.org/show_bug.cgi?id=78641

Reviewed by Timothy Hatcher.

WebCore.exp.in: Add a new function to be exported.
inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::showResources): Call showResources on load.

inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal):

inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.showResources): Show the resources panel.

Source/WebKit2: Web Inspector: Add the ability to show the resources panel on launch
https://bugs.webkit.org/show_bug.cgi?id=78641

Add WebKit2 API for the ability to show the resources panel. This calls down
from the WK API all the way to InspectorFrontendClientLocal::showResources.

Reviewed by Timothy Hatcher.

UIProcess/API/C/WKInspector.cpp:

(WKInspectorShowResources): Call WebInspectorProxy::showResources.

UIProcess/API/C/WKInspector.h:
UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::showResources): Send a message to the web process.

UIProcess/WebInspectorProxy.h:
WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::showResources): Call InspectorFrontendClientLocal::showResources.

WebProcess/WebPage/WebInspector.h:
WebProcess/WebPage/WebInspector.messages.in: Add a ShowResources message.

5:00 PM Changeset in webkit [107756] by abarth@webkit.org

2 edits in trunk/Tools

Implement an adb-based driver for the ChromiumAndroidPort
https://bugs.webkit.org/show_bug.cgi?id=78627

Reviewed by Eric Seidel.

This driver mostly just wires up the ChromiumDriver through adb. In
some cases, it translates protocol elements, such as URIs, so that the
rest of webkitpy is insulated from the "remoteness" of the target device.

Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort._driver_class):
(ChromiumAndroidPort._update_version):
(ChromiumAndroidPort._get_stderr):
(ChromiumAndroidPort):
(ChromiumAndroidPort._get_last_stacktrace):
(ChromiumAndroidPort._teardown_performance):
(ChromiumAndroidDriver):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver.run_test):
(ChromiumAndroidDriver.stop):
(ChromiumAndroidDriver._test_shell_command):
(ChromiumAndroidDriver._write_command_and_read_line):
(ChromiumAndroidDriver._output_image):
(ChromiumAndroidDriver._has_crash_hint):

4:57 PM Changeset in webkit [107755] by dpranke@chromium.org

3 edits in trunk/Tools

webkitpy: the real_name() method in the Port class is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=78651

Reviewed by Eric Seidel.

The change in bug 78565 / r107718 made it no longer necessary
(we can use options.platform instead).

Scripts/webkitpy/layout_tests/port/base.py:

(Port.name):

Scripts/webkitpy/layout_tests/port/mock_drt.py:

(MockDRTPort.init):

4:36 PM Changeset in webkit [107754] by dpranke@chromium.org

5 edits in trunk/Tools

webkitpy: clean up options, port handling in manager_worker_broker
https://bugs.webkit.org/show_bug.cgi?id=78568

Reviewed by Tony Chang.

manager_worker_broker no longer needs options or port objects
directly, so we make them only be passed in start_worker().

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(_ManagerConnection.init):
(_ManagerConnection.start_worker):
(_InlineManager.init):
(_InlineManager.start_worker):
(_InlineManager.run_message_loop):
(_MultiProcessManager.init):
(_MultiProcessManager):
(_MultiProcessManager.start_worker):
(_InlineWorkerConnection.init):
(_InlineWorkerConnection.run):
(_Process.init):
(_MultiProcessWorkerConnection.init):

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(make_broker):
(_TestWorker.run):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
(_TestsMixin.test_unknown_message):
(MultiProcessBrokerTests.setUp):
(InterfaceTest.test_managerconnection_is_abstract):

Scripts/webkitpy/layout_tests/controllers/message_broker.py:

(Broker.init):

4:35 PM Changeset in webkit [107753] by enrica@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r107568-r107627): Crash when copying in WebCore::SharedBuffer::hasPlatformData().
https://bugs.webkit.org/show_bug.cgi?id=78577

Reviewed by Dan Bernstein.

platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::setBufferForType): Missing null check when
setting data to the NSPasteboard.

4:26 PM Changeset in webkit [107752] by oliver@apple.com

3 edits in trunk/Source/JavaScriptCore

Fix Interpreter.

4:11 PM Changeset in webkit [107751] by dpranke@chromium.org

1 edit
1 add in trunk/Tools

nrwt: add a unit test for regression introduced in bug 78565
https://bugs.webkit.org/show_bug.cgi?id=78646

Reviewed by Tony Chang.

Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.

(FakeConnection):
(FakeConnection.run_message_loop):
(FakeConnection.post_message):
(WorkerTest):
(WorkerTest.test_default_platform_in_worker):

4:11 PM Changeset in webkit [107750] by rwlbuis@webkit.org

1 edit
5 adds in trunk/Source/WebKit

[BlackBerry] Upstream remaining classes in Api
https://bugs.webkit.org/show_bug.cgi?id=78644

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

blackberry/Api/BlackBerryContext.h: Added.
blackberry/Api/BlackBerryGlobal.cpp: Added.
blackberry/Api/BlackBerryGlobal.h: Added.
blackberry/Api/Version.cpp: Added.
blackberry/Api/Version.h: Added.

3:54 PM Changeset in webkit [107749] by rniwa@webkit.org

3 edits
2 adds in trunk

Crash in WebCore::SVGElement::removedFromDocument
https://bugs.webkit.org/show_bug.cgi?id=77270

Reviewed by Adam Barth.

Source/WebCore:

Add a protector before calling NodeRemovalDispatcher::dispatch since
NodeRemovalDispatcher::dispatch may remove the last RefPtr to this node.

Test: fast/dom/Range/surround-contents-font-face-crash.svg

dom/ContainerNodeAlgorithms.h:

(WebCore::Private::addChildNodesToDeletionQueue):

LayoutTests:

Add a regression test for the crash.

fast/dom/Range/surround-contents-font-face-crash-expected.txt: Added.
fast/dom/Range/surround-contents-font-face-crash.svg: Added.

3:40 PM Changeset in webkit [107748] by mlilek@apple.com

8 edits in trunk/Source

Don't ENABLE_DASHBOARD_SUPPORT unconditionally on all Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=78629

Reviewed by David Kilzer.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

3:26 PM Changeset in webkit [107747] by kubo@profusion.mobi

6 edits
1 delete in trunk

[CMake] Merge WebKitEfl.cmake into FindEFL.cmake.
https://bugs.webkit.org/show_bug.cgi?id=78566

Reviewed by Daniel Bates.

Source/cmake/FindEFL.cmake: Move the code to find edje_cc here from

WebKitEfl.cmake.

Source/cmake/WebKitEfl.cmake: Removed.

Source/WebKit/efl:

CMakeListsEfl.txt: Do not include WebKitEfl.cmake.

Source/WebKit2:

PlatformEfl.cmake: Do not include WebKitEfl.cmake.

3:20 PM Changeset in webkit [107746] by dpranke@chromium.org

2 edits in trunk/Tools

NRWT is broken for the default port
https://bugs.webkit.org/show_bug.cgi?id=78640

Reviewed by Tony Chang.

The change in r107718 (bug 78565) broke NRWT if you didn't
specify any sort of --platform flag or equivalent. I didn't
catch this because it's a full integration test (which we don't
have an automated test for) and I missed this command line
variant when testing interactively.

Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.run):

3:16 PM Changeset in webkit [107745] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Avoid full style recalc when presentation attributes change.
<http://webkit.org/b/78636>

Patch by Andreas Kling <awesomekling@apple.com> on 2012-02-14
Reviewed by Antti Koivisto.

Use setNeedsStyleRecalc(InlineStyleChange) when a presentation attribute changes
to reduce the amount of work done in recalcStyle().

dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

3:11 PM Changeset in webkit [107744] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for non-DFG platforms.

assembler/MacroAssembler.h:

(MacroAssembler):

2:58 PM Changeset in webkit [107743] by commit-queue@webkit.org

1 edit
2 adds in trunk/Source/WebKit

[BlackBerry] Upstreaming DOMSupport files
https://bugs.webkit.org/show_bug.cgi?id=78607

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-14
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

blackberry/WebKitSupport/DOMSupport.cpp: Added.
blackberry/WebKitSupport/DOMSupport.h: Added.

2:56 PM Changeset in webkit [107742] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix build and configuration goof.

assembler/MacroAssembler.h:

(JSC::MacroAssembler::invert):

dfg/DFGCommon.h:

2:50 PM Changeset in webkit [107741] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

DFG should be able to emit code on control flow edges
https://bugs.webkit.org/show_bug.cgi?id=78515

Reviewed by Gavin Barraclough.

This gets us a few steps closer to being able to perform global register allocation,
by allowing us to have landing pads on control flow edges. This will let us reshuffle
registers if it happens to be necessary due to different reg alloc decisions in
differen blocks.

This also introduces the notion of a landing pad for OSR entry, which will allow us
to emit code that places data into registers when we're entering into the DFG from
the old JIT.

Finally, this patch introduces a verification mode that checks that the landing pads
are actually emitted and do actually work as advertised. When verification is disabled,
this has no effect on behavior.

assembler/MacroAssembler.h:

(MacroAssembler):
(JSC::MacroAssembler::invert):
(JSC::MacroAssembler::isInvertible):

dfg/DFGCommon.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(DFG):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):

dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::branchDouble):
(JSC::DFG::SpeculativeJIT::branchDoubleNonZero):
(JSC::DFG::SpeculativeJIT::branch32):
(JSC::DFG::SpeculativeJIT::branchTest32):
(JSC::DFG::SpeculativeJIT::branchPtr):
(JSC::DFG::SpeculativeJIT::branchTestPtr):
(JSC::DFG::SpeculativeJIT::branchTest8):
(JSC::DFG::SpeculativeJIT::jump):
(JSC::DFG::SpeculativeJIT::haveEdgeCodeToEmit):
(JSC::DFG::SpeculativeJIT::emitEdgeCode):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

2:47 PM Changeset in webkit [107740] by fischman@chromium.org

4 edits in trunk/LayoutTests

Convert a couple of media layouttests to mock scrollbars & rebaseline
https://bugs.webkit.org/show_bug.cgi?id=78634

Unreviewed test maintenance.

media/video-controls-rendering.html:
media/video-zoom.html:
platform/chromium/test_expectations.txt:

2:35 PM Changeset in webkit [107739] by commit-queue@webkit.org

7 edits in trunk

Last character display for passwords in Android.
https://bugs.webkit.org/show_bug.cgi?id=78532

Patch by Ramya Chandrasekaran <cramya@google.com> on 2012-02-14
Reviewed by Adam Barth.

Source/WebCore:

page/Settings.cpp:

(WebCore::Settings::Settings):

Source/WebKit/chromium:

public/WebSettings.h:
src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setPasswordEchoEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setPasswordEchoDurationInSeconds):

src/WebSettingsImpl.h:

(WebSettingsImpl):

Tools:

DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

2:31 PM Changeset in webkit [107738] by jsbell@chromium.org

7 edits in trunk

IndexedDB: Invalid dates should not be valid keys
https://bugs.webkit.org/show_bug.cgi?id=78622

Reviewed by Tony Chang.

Source/WebCore:

Tests: storage/indexeddb/invalid-keys.html

storage/indexeddb/factory-cmp.html

bindings/v8/IDBBindingUtilities.cpp: Special case for NaN Dates.

(WebCore::createIDBKeyFromValue):

LayoutTests:

storage/indexeddb/factory-cmp-expected.txt:
storage/indexeddb/factory-cmp.html:
storage/indexeddb/invalid-keys-expected.txt:
storage/indexeddb/invalid-keys.html:

2:30 PM Changeset in webkit [107737] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

[BlackBerry] Remove OpenVG references
https://bugs.webkit.org/show_bug.cgi?id=78623

Patch by Jeff Rogers <jrogers@rim.com> on 2012-02-14
Reviewed by Rob Buis.

Removed references to USE(OPENVG) and the related code.

blackberry/Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::createSurface):

blackberry/Api/BackingStore_p.h:

2:18 PM Changeset in webkit [107736] by commit-queue@webkit.org

4 edits
2 adds in trunk/Source/WebKit

Initial upstreaming for find-in-page for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=78615

Create a new class InPageSearchManager for find-in-page and
remove the functions in SelectionHandler

Patch by Andy Chen <andchen@rim.com> on 2012-02-14
Reviewed by Rob Buis.

blackberry/CMakeListsBlackBerry.txt:
blackberry/WebKitSupport/InPageSearchManager.cpp: Added.

(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
(BlackBerry::WebKit::InPageSearchManager::setMarkerActive):

blackberry/WebKitSupport/InPageSearchManager.h: Added.
blackberry/WebKitSupport/SelectionHandler.cpp:
blackberry/WebKitSupport/SelectionHandler.h:

2:12 PM Changeset in webkit [107735] by eae@chromium.org

5 edits
1 delete in branches/subpixellayout/Source

Cleaning up unused code/unnecessary conversions on branch.

2:09 PM Changeset in webkit [107734] by commit-queue@webkit.org

1 edit
2 adds in trunk/Source/WebKit

[BlackBerry] Upstream BlackBerry WebCoreSupport FrameLoaderClientBlackBerry class
https://bugs.webkit.org/show_bug.cgi?id=78275

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-14
Reviewed by Rob Buis.

Initial upstream, no new tests.

blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp: Added.
blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.h: Added.

2:02 PM Changeset in webkit [107733] by commit-queue@webkit.org

3 edits
2 adds in trunk

Crash from line break iterators in counter content
https://bugs.webkit.org/show_bug.cgi?id=72977

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-14
Reviewed by David Hyatt.

Source/WebCore:

Calculating the width of counter text can sometimes cause the
underlying text buffer to change. This patch causes the iterator
to reset appropriately when this happens.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

Test that causes asterisk counters to change during layout
and potentially confuse iterators.

fast/css/counters/asterisk-counter-update-after-layout-crash-expected.txt: Added
fast/css/counters/asterisk-counter-update-after-layout-crash.html: Added

1:26 PM Changeset in webkit [107732] by fpizlo@apple.com

4 edits
3 adds in trunk

Assertion failure under JSC::DFG::AbstractState::execute loading economist.com
https://bugs.webkit.org/show_bug.cgi?id=78153
<rdar://problem/10861712> <rdar://problem/10861947>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAdd):

LayoutTests:

fast/js/dfg-add-not-number-expected.txt: Added.
fast/js/dfg-add-not-number.html: Added.
fast/js/script-tests/dfg-add-not-number.js: Added.

(foo):

1:25 PM LayoutUnit edited by eae@chromium.org

(diff)

1:17 PM Changeset in webkit [107731] by leviw@chromium.org

4 edits in trunk/Source/WebCore

Update usage of LayoutUnits in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=78511

Reviewed by Simon Fraser.

Updating RenderLayer to properly use LayoutUnits. See descriptions below for the rationale behind all
the changes. Also adding a roundedIntSize method that takes a LayoutSize.

No new tests. No change in behavior.

rendering/LayoutTypes.h:

(WebCore::roundedIntSize): Inline method that currently does nothing, but will round a LayoutSize
to an IntSize.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions): Switching repaint and outline boxes to LayoutRects, as
it's important to keep the precision of these rects until handing off to the embedder (in FrameView).
(WebCore::RenderLayer::computeRepaintRects): Repaint rects should be preserved in subpixel units until
being passed to the embedding layer. This prevents needless repaints.
(WebCore::RenderLayer::convertToPixelSnappedLayerCoords): Convenience function to return pixel snapped rects
(WebCore):
(WebCore::RenderLayer::convertToLayerCoords): Fixing a style flaw.
(WebCore::RenderLayer::scrollRectToVisible): Pixel snapping the rect when handing off to the embedder.
(WebCore::RenderLayer::maximumScrollPosition): Scroll offsets are rounded.
(WebCore::RenderLayer::scrollCornerRect): Scrollbars are drawn natively and should be positioned on pixel
boundaries.
(WebCore::RenderLayer::scrollCornerAndResizerRect): Resize corner doesn't influence the size/position of
render objects. It is only painted and hit tested. Therefor it should use integers.
(WebCore::RenderLayer::offsetFromResizeCorner): Ditto.
(WebCore::RenderLayer::positionOverflowControls): Overflow controls are drawn natively and should be
positioned on integer boundaries.
(WebCore::RenderLayer::paintOverflowControls): Ditto.
(WebCore::RenderLayer::paintScrollCorner): Ditto.
(WebCore::RenderLayer::drawPlatformResizerImage): Ditto.
(WebCore::RenderLayer::paintResizer): Ditto.
(WebCore::RenderLayer::hitTestOverflowControls): Hit testing & overflow controls both use integers.
(WebCore::RenderLayer::clipToRect): Clipping to actual painted (pixel snapped) layer bounds in the
graphics context.
(WebCore::RenderLayer::paintLayerContents): Calling paintOverflowControls at pixel bounds.
(WebCore::RenderLayer::hitTest): Intersecting the hit test area with pixel snapped boundaries.
(WebCore::RenderLayer::setBackingNeedsRepaintInRect): Sending pixelSnapped rects to the backing
store, which only cares about pixels, and hence integers.

rendering/RenderLayer.h:

(WebCore::RenderLayer::scrolledContentOffset): RenderLayer's scroll offsets are used in platform
code, so we need to return them as integers. Rounding the scroll overflow before adding it to the
scroll offset, which was already stored in integers.
(RenderLayer):

1:16 PM Changeset in webkit [107730] by commit-queue@webkit.org

4 edits
2 adds in trunk/Source/WebKit

Separate mimetype and file extension mapping API from WebKit/blackberry/Api/WebKitTextCodec and complete it.
https://bugs.webkit.org/show_bug.cgi?id=78605

Patch by Lianghui Chen <liachen@rim.com> on 2012-02-14
Reviewed by Rob Buis.

Now the MIME type and file extension mapping API are in WebKitMIMETypeConverter.

blackberry/Api/WebKitMIMETypeConverter.cpp: Added.

(WebKit):
(BlackBerry::WebKit::getExtensionForMimeType):
(BlackBerry::WebKit::getMimeTypeForExtension):

blackberry/Api/WebKitMIMETypeConverter.h: Added.

(WebKit):

blackberry/Api/WebKitTextCodec.cpp:
blackberry/Api/WebKitTextCodec.h:
blackberry/CMakeListsBlackBerry.txt:

1:02 PM Changeset in webkit [107729] by inferno@chromium.org

3 edits
2 adds in trunk

Crash in NavigationScheduler::schedule.
https://bugs.webkit.org/show_bug.cgi?id=78297

Reviewed by Adam Barth.

Source/WebCore:

Protect frame pointer and navigation scheduler when we stop the
load (when redirect is scheduled during a load). Also, dont fire
the navigation scheduler timer when we know that frameloader is
going away.

Test: http/tests/navigation/navigation-redirect-schedule-crash.html

loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::schedule):

LayoutTests:

http/tests/navigation/navigation-redirect-schedule-crash-expected.txt: Added.
http/tests/navigation/navigation-redirect-schedule-crash.html: Added.

1:00 PM Changeset in webkit [107728] by alexis.menard@openbossa.org

3 edits
2 adds in trunk

font shorthand with inherit keyword incorrectly parsed and rendered
https://bugs.webkit.org/show_bug.cgi?id=20181

Reviewed by Tony Chang.

Source/WebCore:

As stated in http://www.w3.org/TR/CSS21/changes.html#q142
if the inherit (and also by extension initial) is encountered in the
middle of the shorthand then the property becomes invalid.

Test: fast/css/font-shorthand-mix-inherit.html

css/CSSParser.cpp:

(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):

LayoutTests:

fast/css/font-shorthand-mix-inherit-expected.txt: Added.
fast/css/font-shorthand-mix-inherit.html: Added.

12:47 PM Changeset in webkit [107727] by leviw@chromium.org

6 edits in branches/subpixellayout/Source/WebCore/rendering

Moving RenderLayerBacking and RenderLayerCompositor to integers, and ensuring pixel snapping occurs in all the right places.

12:45 PM Changeset in webkit [107726] by inferno@chromium.org

3 edits
2 adds in trunk

Crash due to incorrect firing of mutation event during class attribute parsing.
https://bugs.webkit.org/show_bug.cgi?id=78537

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/class-attr-change-double-mutation-fire.html

dom/StyledElement.cpp:

(WebCore::StyledElement::classAttributeChanged):

LayoutTests:

fast/dom/class-attr-change-double-mutation-fire-expected.txt: Added.
fast/dom/class-attr-change-double-mutation-fire.html: Added.

12:29 PM Changeset in webkit [107725] by abarth@webkit.org

2 edits in trunk/Tools

Finish implementing start_helper for ChromiumAndroidPort
https://bugs.webkit.org/show_bug.cgi?id=78582

Reviewed by Eric Seidel.

This patch contains the remaining odds and ends for the start_helper function.

Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort._synchronize_datetime):
(ChromiumAndroidPort):
(ChromiumAndroidPort._check_version):
(ChromiumAndroidPort._run_adb_command):
(ChromiumAndroidPort._copy_device_file):

12:22 PM Changeset in webkit [107724] by mikelawther@chromium.org

5 edits in trunk

CSS3 calc: add isZero implementations to catch divide by zero
https://bugs.webkit.org/show_bug.cgi?id=78603

Reviewed by Ojan Vafai.

Source/WebCore:

css/CSSCalculationValue.cpp:

(WebCore::CSSCalcPrimitiveValue::isZero):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcBinaryOperation::isZero):
(CSSCalcBinaryOperation):

css/CSSCalculationValue.h:

(CSSCalcExpressionNode):

LayoutTests:

css3/calc/calc-errors-expected.txt:

12:15 PM Changeset in webkit [107723] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, marking a perf test as slow in debug and two
gpu tests as failing in debug (different scrollbar rendering).

platform/chromium/test_expectations.txt:

12:13 PM Changeset in webkit [107722] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Expose perTilePainting setting through WebLayerTreeView::Settings interface.
https://bugs.webkit.org/show_bug.cgi?id=76937

Patch by David Reveman <reveman@chromium.org> on 2012-02-14
Reviewed by James Robinson.

Add perTilePainting to WebLayerTreeView::Settings.

public/platform/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

12:11 PM Changeset in webkit [107721] by fischman@chromium.org

3 edits in trunk/LayoutTests

[chromium] Layout Test media/media-document-audio-repaint.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=76580

Reviewed by James Robinson.

Make sure to call layoutTestController.display() at a stable point
(namely when the media element is paused) so that any subsequent GPU
disabling doesn't cause a complete redraw (and the test to be
flaky).

media/media-document-audio-repaint.html:
platform/chromium/test_expectations.txt:

11:42 AM Changeset in webkit [107720] by timothy@apple.com

1 edit
6 deletes in trunk/LayoutTests

Remove inspector/protocol/page-agent.html since it is inherently flaky.

Filed https://webkit.org/b/78621 about devising a non-flaky test.

Unreviewed.

inspector/protocol/page-agent-expected.txt: Removed.
inspector/protocol/page-agent.html: Removed.
inspector/protocol/resources/dummy-iframe.html: Removed.
inspector/protocol/resources/empty.png: Removed.
inspector/protocol/resources/font1.ttf: Removed.
inspector/protocol/resources/font2.ttf: Removed.

11:39 AM Changeset in webkit [107719] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

[BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
https://bugs.webkit.org/show_bug.cgi?id=78608

Ensure that when selection handles leave the content bounding box that
the handle not being dragged remains fixed. Do not applying padding to
a direction that would cause the selection to shrink when performing
the handle direction detection.

Patch by Ed Baker <edbaker@rim.com> on 2012-02-14
Reviewed by Rob Buis.

blackberry/WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::clipPointToFocusNode):
(BlackBerry::WebKit::SelectionHandler::setSelection):

blackberry/WebKitSupport/SelectionHandler.h:

11:25 AM Changeset in webkit [107718] by dpranke@chromium.org

4 edits in trunk/Tools

webkitpy: create ports in Workers, not in manager_worker_broker
https://bugs.webkit.org/show_bug.cgi?id=78565

Reviewed by Tony Chang.

We will now create the Port object (if necessary) in the Worker
directly, so that the manager_worker_broker module doesn't need
all of this layout_test-specific logic. Part of the fixes for
bug 78171.

These changes are all well-tested by the existing tests in
run_webkit_tests_integrationtest.py.

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_Process.run):

Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.init):
(Worker.safe_init):
(Worker.run):
(Worker.cleanup):

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):
(main): Fix a minor bug where running the 'mock-test' port didn't work right.

11:18 AM Changeset in webkit [107717] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, mark some form tests as flaky.

platform/chromium/test_expectations.txt:

11:13 AM Changeset in webkit [107716] by rwlbuis@webkit.org

1 edit
6 adds in trunk/Source/WebKit

[BlackBerry] Upstream backing store related classes
https://bugs.webkit.org/show_bug.cgi?id=78517

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

blackberry/WebKitSupport/BackingStoreClient.cpp: Added.
blackberry/WebKitSupport/BackingStoreClient.h: Added.
blackberry/WebKitSupport/BackingStoreCompositingSurface.cpp: Added.
blackberry/WebKitSupport/BackingStoreCompositingSurface.h: Added.
blackberry/WebKitSupport/BackingStoreTile.cpp: Added.
blackberry/WebKitSupport/BackingStoreTile.h: Added.

10:44 AM Changeset in webkit [107715] by timothy@apple.com

5 edits in trunk

Source/WebCore: Don't include CachedResources that haven't downloaded when populating the Web Inspector on load.

https://webkit.org/b/78447
rdar://problem/10843542

Reviewed by Brian Weinstein.

Test: inspector/protocol/page-agent.html

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourcesForFrame): Skip CachedFonts and CachedImages that
return true for stillNeedsLoad.

loader/cache/CachedFont.h:

(WebCore::CachedFont::stillNeedsLoad): Added.

LayoutTests: Updated test results to exclude CachedResources that haven't downloaded.

https://webkit.org/b/78447
rdar://problem/10843542

Reviewed by Brian Weinstein.

inspector/protocol/page-agent-expected.txt: Updated. There is now only one font list

in the resources, when there was incorrectly two being listed. Only the font being used
is the one that downloaded and is listed now.

10:44 AM Changeset in webkit [107714] by timothy@apple.com

5 edits
7 adds in trunk

Source/WebCore: Web Inspector: include failed and canceled in FrameResourceTree.

https://webkit.org/b/78445

Reviewed by Pavel Feldman.

Test: inspector/protocol/page-agent.html

WebCore.xcodeproj/project.pbxproj: Added Inspector.json, Inspector-0.1.json and Inspector-1.0.json

for quick access and easy editing.

inspector/Inspector.json: Added failed and canceled as optional properties to the object for resources in FrameResourceTree.
inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrameTree): Set those properties.

LayoutTests: Test for Web Inspector: include failed and canceled in FrameResourceTree.

https://webkit.org/b/78445

Reviewed by Pavel Feldman.

inspector/protocol/page-agent-expected.txt: Added.
inspector/protocol/page-agent.html: Added.
inspector/protocol/resources/dummy-iframe.html: Added.
inspector/protocol/resources/empty.png: Added.
inspector/protocol/resources/font1.ttf: Added.
inspector/protocol/resources/font2.ttf: Added.

9:39 AM Changeset in webkit [107713] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[GTK] fast/forms/implicit-submission.html fails
https://bugs.webkit.org/show_bug.cgi?id=76632

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-02-14
Reviewed by Martin Robinson.

[Gtk] Rebaseline implicit-submission test expectations after r105253.

platform/gtk/Skipped:
platform/gtk/fast/forms/implicit-submission-expected.txt:

9:36 AM WinCE edited by Patrick Gansterer

(diff)

9:29 AM WinCE edited by Patrick Gansterer

Fixed build exmple after r101052 (diff)

8:12 AM Changeset in webkit [107712] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r107688 and skipping some new
test failures.

platform/gtk/Skipped:
platform/gtk/css3/calc/getComputedStyle-margin-percentage-expected.txt:

7:42 AM Changeset in webkit [107711] by thakis@chromium.org

26 edits in branches/chromium/1025

Merge 107094 - Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
https://bugs.webkit.org/show_bug.cgi?id=78007

This got broken by: http://trac.webkit.org/changeset/105470
And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191

There is still three tests that fail from the set, but the cause for these is different,
which I'm still investigating.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebKit/chromium:

src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

LayoutTests:

platform/chromium/test_expectations.txt:

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9358057

6:28 AM Changeset in webkit [107710] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

Typo fix after r107707.

platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::updateBackingStore):

6:24 AM Changeset in webkit [107709] by caseq@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [refactoring] extract TimelineOverviewWindow from TimelineOverviewPanel
https://bugs.webkit.org/show_bug.cgi?id=78599

Reviewed by Pavel Feldman.

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype.scrollWindow):
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype.reset):
(WebInspector.TimelineOverviewWindow.prototype.scrollWindow):
(WebInspector.TimelineOverviewWindow.prototype._windowResizeDragging):
(WebInspector.TimelineOverviewWindow.prototype._dragWindow):
(WebInspector.TimelineOverviewWindow.prototype._windowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._windowDragging):
(WebInspector.TimelineOverviewWindow.prototype._resizeWindowRight):
(WebInspector.TimelineOverviewWindow.prototype._resizeWindowMaximum):
(WebInspector.TimelineOverviewWindow.prototype._setWindowPosition):
(WebInspector.TimelineOverviewWindow.prototype._endWindowDragging):
(WebInspector.TimelinePanel.WindowSelector):

5:34 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org

(diff)

5:33 AM SettingUpDevelopmentEnvironmentForN9 edited by vestbo@webkit.org

(diff)

4:55 AM Changeset in webkit [107708] by vsevik@chromium.org

16 edits
1 copy
3 adds in trunk

Web Inspector: Make ScriptsNavigator default file selector.
https://bugs.webkit.org/show_bug.cgi?id=78349

Reviewed by Pavel Feldman.

Source/WebCore:

Moved ScriptsNavigator out of experiments.
Introduced new setting "useScriptsNavigator" with true as default value.
Updated scripts panel tests related to file selector.

Tests: inspector/debugger/scripts-combobox-file-selector-history.html

inspector/debugger/scripts-file-selector.html

English.lproj/localizedStrings.js:
inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):

inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):

inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

Source/WebKit/chromium:

src/js/Tests.js:

(.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
(.TestSuite.prototype.uiSourceCodesToString_):
(.TestSuite.prototype.nonAnonymousUISourceCodes_):
(.TestSuite.prototype._scriptsAreParsed):
(.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
(.TestSuite.prototype._waitUntilScriptsAreParsed):

LayoutTests:

http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):
(initialize_DebuggerTest.):

inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Added.
inspector/debugger/scripts-combobox-file-selector-history.html: Added.
inspector/debugger/scripts-file-selector-expected.txt: Copied from LayoutTests/inspector/debugger/scripts-panel-expected.txt.
inspector/debugger/scripts-file-selector.html: Added.
inspector/debugger/scripts-panel-expected.txt:
inspector/debugger/scripts-panel.html:
inspector/debugger/scripts-sorting-expected.txt:
inspector/debugger/scripts-sorting.html:
inspector/debugger/source-frame-count.html:

4:53 AM Changeset in webkit [107707] by noam.rosenthal@nokia.com

17 edits
4 adds in trunk/Source

[Qt][Texmap] Refactor backing-store code in TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=78305

Source/WebCore:

Instead of dealing with tiling inside of TextureMapperNode, we now deal with that in a new
TextureMapperBackingStore class. Since the class is abstract, WebKit2 can overload it to
support remotely-managed tiles.
The backing-store for directly composited images is handled separately, in a new class
TextureMapperCompositedImage. The TextureMapper implementation decides the dimension of
the tiles, for example 2000 in the case of OpenGL.
Also, directly composited content is now handled correctly, by painting it after the regular
content and not as part of the same texture.

To make this work, the functions in TextureMapperPlatformLayers had to become non-const,
thus the changes to that file and GraphicsContext3DQt.

Reviewed by Kenneth Rohde Christiansen.

No new functionality, no new tests.

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
platform/graphics/opengl/TextureMapperGL.h:

(WebCore::TextureMapperGL::maxTextureDimension):

platform/graphics/qt/GraphicsContext3DQt.cpp:

(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::didSynchronize):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::addChildBelow):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::getContentsLayer):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):

platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::platformLayer):
(WebCore::GraphicsLayerTextureMapper::needsDisplay):
(WebCore::GraphicsLayerTextureMapper::needsDisplayRect):

platform/graphics/texmap/TextureMapper.cpp:
platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::maxTextureDimension):
(TextureMapper):

platform/graphics/texmap/TextureMapperBackingStore.cpp: Added.
platform/graphics/texmap/TextureMapperBackingStore.h: Added.
platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::backingStore):
(WebCore::TextureMapperNode::updateBackingStore):
(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::intermediateSurfaceRect):
(WebCore::TextureMapperNode::paintRecursive):
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::syncCompositingState):

platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperPaintOptions):
(WebCore::TextureMapperPaintOptions::TextureMapperPaintOptions):
(WebCore::TextureMapperNode::TextureMapperNode):
(TextureMapperNode):
(WebCore::TextureMapperNode::setBackingStore):
(WebCore::TextureMapperNode::texture):
(WebCore::TextureMapperNode::layerRect):
(WebCore::TextureMapperNode::createBackingStore):
(State):
(WebCore::TextureMapperNode::State::State):

platform/graphics/texmap/TextureMapperPlatformLayer.h:

(TextureMapperPlatformLayer):
(WebCore::TextureMapperPlatformLayer::swapBuffers):

Source/WebKit2:

Move the backing-store code to LayerTreeBackingStore, implementing the virtual functions
in TextureMapperBackingStore.
We save the double-buffered tile in the backing-store, and then convert them to regular
tiles in updateContents, based on the order of painting.
Use TextureMapperCompositedImage for images instead of saving our own composited image
registry.

Reviewed by Kenneth Rohde Christiansen.

Target.pri:
UIProcess/LayerTreeHostProxy.h:

(WebKit):
(LayerTreeHostProxy):

UIProcess/qt/LayerBackingStore.cpp: Added.
UIProcess/qt/LayerBackingStore.h: Added.
UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::createLayer):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::getBackingStore):
(WebKit::LayerTreeHostProxy::createTile):
(WebKit::LayerTreeHostProxy::removeTile):
(WebKit::LayerTreeHostProxy::updateTile):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::assignImageToLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):

WebProcess.pro:

4:48 AM Changeset in webkit [107706] by commit-queue@webkit.org

37 edits in trunk

Use youngestShadowRoot and oldestShadowRoot instead of Element::shadowRoot().
https://bugs.webkit.org/show_bug.cgi?id=78455

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-14
Reviewed by Hajime Morita.

Exports necessary symbols.

Source/autotools/symbols.filter:

Source/WebCore:

Element::shadowRoot() was used for these 3 purposes.

checks a shadow root exists.
gets author shadow root.
gets user agent shadow root.

We have to distinguish them when implementing multiple shadow subtrees.

Calling for (1), (2), and (3) are convered to hasShadowRoot(),
ShadowRootList()->youngestShadowRoot(), and ShadowRootList()->oldestShadowRoot() respectively.

No new tests, no change in behavior.

WebCore.exp.in:
dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):

dom/Element.cpp:

(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::insertedIntoTree):
(WebCore::Element::removedFromTree):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::childrenChanged):
(WebCore::Element::focus):

dom/Element.h:

(Element):

dom/EventDispatcher.cpp:

(WebCore::isShadowHost):

dom/Node.cpp:

(WebCore::shadowRoot):

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

dom/ShadowRootList.cpp:

(WebCore::ShadowRootList::insertedIntoDocument):
(WebCore):
(WebCore::ShadowRootList::removedFromDocument):
(WebCore::ShadowRootList::insertedIntoTree):
(WebCore::ShadowRootList::removedFromTree):
(WebCore::ShadowRootList::hostChildrenChanged):
(WebCore::ShadowRootList::attach):
(WebCore::ShadowRootList::detach):

dom/ShadowRootList.h:

(ShadowRootList):

dom/TreeScopeAdopter.cpp:

(WebCore::shadowRootFor):

html/FileInputType.cpp:

(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):

html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):
(WebCore::HTMLDetailsElement::findMainSummary):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::createShadowSubtree):

html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):
(WebCore::HTMLKeygenElement::shadowSelect):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):

html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):
(WebCore::HTMLTextAreaElement::innerTextElement):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):

html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):

html/ValidationMessage.cpp:

(WebCore::ValidationMessage::deleteBubbleTree):

html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderContainer::layout):
(WebCore::trackLimiterElementOf):

page/FocusController.cpp:

(WebCore::shadowRoot):

rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText):

testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::shadowRoot):
(WebCore):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit2:

Exports necesarry symbols.

win/WebKit2.def:
win/WebKit2CFLite.def:

4:45 AM Changeset in webkit [107705] by apavlov@chromium.org

8 edits in trunk

Elements panel needs to be able to preview images
https://bugs.webkit.org/show_bug.cgi?id=21570

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.willHide):
(WebInspector.ElementsPanel.prototype._getPopoverAnchor):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode.resolvedNode.dimensions):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode.resolvedNode):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode):
(WebInspector.ElementsPanel.prototype._showPopover.dimensionsCallback):
(WebInspector.ElementsPanel.prototype._showPopover.showPopover):
(WebInspector.ElementsPanel.prototype._showPopover.buildPopoverContents):
(WebInspector.ElementsPanel.prototype._showPopover):

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._onmousemove):

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle.get g):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle):

inspector/front-end/elementsPanel.css:

(.image-preview-container):
(.image-preview-container img):

LayoutTests:

inspector/elements/elements-img-tooltip-expected.txt:
inspector/elements/elements-img-tooltip.html:

4:36 AM Changeset in webkit [107704] by jochen@chromium.org

4 edits in trunk/Tools

[chromium] check that we're not running multiple modal dialogs at the same time
https://bugs.webkit.org/show_bug.cgi?id=78486

Reviewed by Kent Tamura.

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

DumpRenderTree/chromium/TestShell.h:

(TestShell::setIsDisplayingModalDialog):
(TestShell::isDisplayingModalDialog):
(TestShell):

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::runModal):

4:05 AM WebKitIDL edited by haraken@chromium.org

(diff)

4:01 AM Changeset in webkit [107703] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: List expansion arrows is pointing down even
when the list of eventListeners are hidden in the Elements tab
https://bugs.webkit.org/show_bug.cgi?id=78360

Reviewed by Timothy Hatcher.

inspector/front-end/elementsPanel.css:

(.section .event-bar .header):
(.section .event-bars .event-bar .header .title):
(.section .event-bar .header .subtitle):
(.section .event-bar .header::before):
(.section .event-bar.expanded .header::before):

3:42 AM Changeset in webkit [107702] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/Skipped: Typo fix, skip a new failing test.
platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Updated after r107688.

3:37 AM Changeset in webkit [107701] by noel.gordon@gmail.com

5 edits
3 adds
1 delete in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #7 of N.

platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
platform/chromium-mac-leopard/fast/replaced/width100percent-image-expected.png:
platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/compositing/img-layer-grow-expected.png: Added.
platform/chromium-mac/fast/replaced/width100percent-image-expected.png: Removed.
platform/chromium-win/fast/replaced/width100percent-image-expected.png:
platform/chromium-win/platform/chromium/compositing/img-layer-grow-expected.png: Added.
platform/chromium/test_expectations.txt:

3:32 AM Changeset in webkit [107700] by hayato@chromium.org

23 edits in trunk

Make ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
https://bugs.webkit.org/show_bug.cgi?id=77514

Reviewed by Dimitri Glazkov.

NodeType.SHADOW_ROOT_NODE type is finally gone.

Source/WebCore:

bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

bindings/objc/DOM.mm:

(kitClass):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

dom/ContainerNode.cpp:

(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):

dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):

dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):

dom/Node.h:
dom/Range.cpp:

(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):

dom/ShadowRoot.cpp:
dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::toShadowRoot):

editing/FrameSelection.cpp:

(WebCore::nodeIsDetachedFromDocument):
(WebCore):
(WebCore::FrameSelection::textWillBeReplaced):

editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):

html/parser/HTMLElementStack.h:

(WebCore::isInHTMLNamespace):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):

xml/XPathUtil.cpp:

(WebCore::XPath::isValidContextNode):

Source/WebKit/chromium:

src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::buildContentForNode):

LayoutTests:

fast/dom/shadow/nodetype-expected.txt:
fast/dom/shadow/nodetype.html:
resources/dump-as-markup.js:

(Markup._get):

3:01 AM Changeset in webkit [107699] by kling@webkit.org

2 edits in trunk/Source/WebCore

StylePropertySet: Try to find a CSSValuePool for identifier values.
<http://webkit.org/b/78590>

Reviewed by Antti Koivisto.

For StylePropertySets with a parent element (inline and attribute style),
grab at the parentElement()->document() to locate a CSSValuePool.
This code will change soon in the CSSOM refactoring and moreso once we
figure out how to have a global CSSValuePool, but I'm hoping it will buy
us some perf back in the meantime.

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setProperty):

2:54 AM Changeset in webkit [107698] by Nikolas Zimmermann

10 edits in trunk/LayoutTests

svg/hixie/perf has different repaint region in debug vs release
https://bugs.webkit.org/show_bug.cgi?id=78516

Reviewed by Hajime Morita.

Based on patch by Tony Chang <tony@chromium.org>.

The problem is the progress text in the lower right. It says,
"Test in progress... X of 10". Depending on how fast the test runs,
this text is never painted and the repaint region changes. Disable
painting of the intermediate text and only include the final text.

Extended Tonys original patch to cover all svg/hixie/perf tests that
suffered from this issue - also avoid using setTimeout between the
individual steps, as we're only interessted in the final repaint
region, not the intermediate ones.

platform/mac/svg/hixie/perf/001-expected.png:
platform/mac/svg/hixie/perf/002-expected.png:
platform/mac/svg/hixie/perf/003-expected.png:
svg/hixie/perf/001.xml:
svg/hixie/perf/002.xml:
svg/hixie/perf/003.xml:
svg/hixie/perf/004.xml:
svg/hixie/perf/005.xml:
svg/hixie/perf/006.xml:

2:41 AM Changeset in webkit [107697] by abarth@webkit.org

2 edits in trunk/Tools

Enable the GPU codepath in the chromium-android port
https://bugs.webkit.org/show_bug.cgi?id=78580

Reviewed by James Robinson.

Suprise! There is no ChromiumGpuAndroidPort! Instead, Chromium
Android always uses the GPU codepath, so we set the GPU flags on the
main chromium-android port instead.

Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):

2:38 AM Changeset in webkit [107696] by abarth@webkit.org

2 edits in trunk/Tools

NRWT should expose --adb-args flag for Android
https://bugs.webkit.org/show_bug.cgi?id=78579

Reviewed by Eric Seidel.

This flag is already wired up to the ChromiumAndroidPort.

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

2:35 AM Changeset in webkit [107695] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Inconsistent initialization of CCSettings in WebLayerTreeView.
https://bugs.webkit.org/show_bug.cgi?id=76927

Patch by David Reveman <reveman@chromium.org> on 2012-02-14
Reviewed by James Robinson.

Remove unnecessary initialization and include maxPartialTextureUpdates
in FIXME comment.

src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

2:29 AM WebKitIDL edited by haraken@chromium.org

(diff)

2:21 AM Changeset in webkit [107694] by Nikolas Zimmermann

1 edit
1 add in trunk/LayoutTests

2012-02-14 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add mixing Lion pixel test result for a svg/carto.net test.

platform/mac/svg/carto.net/scrollbar-expected.png: Added.

2:19 AM Changeset in webkit [107693] by Nikolas Zimmermann

5 edits in trunk/Source/WebCore

Convert svg/animations to use SMIL methods for driving the timeline
https://bugs.webkit.org/show_bug.cgi?id=78422

Reviewed by Hajime Morita.

Fix last-minute typo in clearTimesWithDynamicOrigins, leading to assertions browsing the W3C SVG animation tests.
Covered by existing tests in svg/animations.

svg/SVGAnimationElement.cpp: Remove unused endedActiveInterval.
svg/SVGAnimationElement.h: Ditto.
svg/animation/SVGSMILElement.cpp:

(WebCore::clearTimesWithDynamicOrigins): Fix order of walking the times list.
(WebCore::SVGSMILElement::reset): Move calls to clearTimesWithDynamicOrigins into endedActiveInterval.
(WebCore::SVGSMILElement::endedActiveInterval):

svg/animation/SVGSMILElement.h:

(SVGSMILElement): Devirtualize endedActiveInterval.

2:04 AM Changeset in webkit [107692] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests.

platform/qt/Skipped:

1:55 AM Changeset in webkit [107691] by commit-queue@webkit.org

23 edits in trunk

Unreviewed, rolling out r107661.
http://trac.webkit.org/changeset/107661
https://bugs.webkit.org/show_bug.cgi?id=78591

crash on lion/qt bots (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-14

Source/WebCore:

bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

bindings/objc/DOM.mm:

(kitClass):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

dom/ContainerNode.cpp:

(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):

dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):

dom/Node.cpp:

dom/Node.h:
dom/Range.cpp:

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::nodeType):
(WebCore):

dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::toShadowRoot):

editing/FrameSelection.cpp:

(WebCore::FrameSelection::textWillBeReplaced):

editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):

html/parser/HTMLElementStack.h:

(WebCore::isInHTMLNamespace):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):

xml/XPathUtil.cpp:

(WebCore::XPath::isValidContextNode):

Source/WebKit/chromium:

src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::buildContentForNode):

LayoutTests:

fast/dom/shadow/nodetype-expected.txt:
fast/dom/shadow/nodetype.html:
resources/dump-as-markup.js:

(Markup._get):

1:52 AM Changeset in webkit [107690] by hayato@chromium.org

6 edits in trunk/Source/WebCore

Fix typo. HTMLContentSeleciton -> HTMLContentSelection.
https://bugs.webkit.org/show_bug.cgi?id=78571

Reviewed by Hajime Morita.

No tests. No change in behavior.

dom/NodeRenderingContext.cpp:

(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertionPointFor):

html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::attach):

html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelection::append):
(WebCore::HTMLContentSelection::unlink):
(WebCore::HTMLContentSelectionList::find):
(WebCore::HTMLContentSelectionList::append):
(WebCore::HTMLContentSelector::select):
(WebCore::HTMLContentSelector::unselect):
(WebCore::HTMLContentSelector::findFor):

html/shadow/HTMLContentSelector.h:

(HTMLContentSelection):
(WebCore::HTMLContentSelection::next):
(WebCore::HTMLContentSelection::previous):
(WebCore::HTMLContentSelection::HTMLContentSelection):
(WebCore::HTMLContentSelection::create):
(WebCore::HTMLContentSelectionList::first):
(WebCore::HTMLContentSelectionList::last):
(HTMLContentSelectionList):
(WebCore::HTMLContentSelectionSet::add):
(WebCore::HTMLContentSelectionSet::remove):
(HTMLContentSelectionSet):
(WebCore::HTMLContentSelectionSet::Translator::equal):
(WebCore::HTMLContentSelectionSet::Hash::hash):
(WebCore::HTMLContentSelectionSet::Hash::equal):
(WebCore::HTMLContentSelectionSet::find):
(HTMLContentSelector):

1:50 AM Changeset in webkit [107689] by ap@apple.com

73 edits in trunk

[Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
https://bugs.webkit.org/show_bug.cgi?id=78541
<rdar://problem/10036695>

Reviewed by Kent Tamura.

Source/WebKit/mac:

WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default value of the

preference.

Source/WebKit/win:

WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default value of

the preference

Source/WebKit2:

Shared/WebPreferencesStore.h: (WebKit): Changed default value of the preference.

Tools:

DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

After each test, reset to using new protocol.

LayoutTests:

http/tests/websocket/tests/hixie76/alert-in-event-handler.html:
http/tests/websocket/tests/hixie76/bad-handshake-crash.html:
http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars.html:
http/tests/websocket/tests/hixie76/bad-sub-protocol-empty.html:
http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii.html:
http/tests/websocket/tests/hixie76/bufferedAmount-after-close.html:
http/tests/websocket/tests/hixie76/client-close.html:
http/tests/websocket/tests/hixie76/close-before-open.html:
http/tests/websocket/tests/hixie76/close-event.html:
http/tests/websocket/tests/hixie76/close-on-navigate-new-location.html:
http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html:
http/tests/websocket/tests/hixie76/close-on-unload-reference-in-parent.html:
http/tests/websocket/tests/hixie76/close-on-unload.html:
http/tests/websocket/tests/hixie76/close-unref-websocket.html:
http/tests/websocket/tests/hixie76/cross-origin.html:
http/tests/websocket/tests/hixie76/error-detect.html:
http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer.html:
http/tests/websocket/tests/hixie76/frame-length-overflow.html:
http/tests/websocket/tests/hixie76/frame-length-skip.html:
http/tests/websocket/tests/hixie76/frame-lengths.html:
http/tests/websocket/tests/hixie76/handshake-challenge-randomness.html:
http/tests/websocket/tests/hixie76/handshake-error.html:
http/tests/websocket/tests/hixie76/handshake-fail-by-cross-origin.html:
http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength.html:
http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header.html:
http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr.html:
http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header.html:
http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null.html:
http/tests/websocket/tests/hixie76/handshake-fail-by-sub-protocol-mismatch.html:
http/tests/websocket/tests/hixie76/long-invalid-header.html:
http/tests/websocket/tests/hixie76/multiple-connections.html:
http/tests/websocket/tests/hixie76/null-character.html:
http/tests/websocket/tests/hixie76/reload-crash.html:
http/tests/websocket/tests/hixie76/send-after-close-on-unload.html:
http/tests/websocket/tests/hixie76/send-empty.html:
http/tests/websocket/tests/hixie76/send-object.html:
http/tests/websocket/tests/hixie76/send-throw.html:
http/tests/websocket/tests/hixie76/send.html:
http/tests/websocket/tests/hixie76/server-close.html:
http/tests/websocket/tests/hixie76/simple-stress.html:
http/tests/websocket/tests/hixie76/simple.html:
http/tests/websocket/tests/hixie76/split-binary-frame-header.html:
http/tests/websocket/tests/hixie76/sub-protocol-with-space.html:
http/tests/websocket/tests/hixie76/sub-protocol.html:
http/tests/websocket/tests/hixie76/undefined-attributes.html:
http/tests/websocket/tests/hixie76/unicode.html:
http/tests/websocket/tests/hixie76/url-attribute.html:
http/tests/websocket/tests/hixie76/url-no-trailing-slash.html:
http/tests/websocket/tests/hixie76/url-parsing.html:
http/tests/websocket/tests/hixie76/url-with-credential.html:
http/tests/websocket/tests/hixie76/url-with-empty-query.html:
http/tests/websocket/tests/hixie76/url-with-query-for-no-query.html:
http/tests/websocket/tests/hixie76/url-with-query.html:
http/tests/websocket/tests/hixie76/websocket-event-target.html:
http/tests/websocket/tests/hixie76/websocket-pending-activity.html:
http/tests/websocket/tests/hixie76/websocket-protocol-ignored.html:
http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html:
http/tests/websocket/tests/hixie76/workers/close-in-shared-worker.html:
http/tests/websocket/tests/hixie76/workers/close-in-worker.html:
http/tests/websocket/tests/hixie76/workers/shared-worker-simple.html:
http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness.html:
http/tests/websocket/tests/hixie76/workers/worker-simple.html:

Added overridePreference calls, so that the tests don't depend on platform or DRT default.

1:46 AM Changeset in webkit [107688] by mikelawther@chromium.org

20 edits
3 moves in trunk

CSS3 calc: embed calc expressions in CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=78446

Source/WebCore:

Reviewed by Ojan Vafai.

Adds calc expressions to CSSPrimitiveValue. This enables simple (ie no mixing of
percents with numbers/lengths) expressions to be evaluated on most properties.

Tests: css3/calc/block-mask-overlay-image-outset-expected.html

css3/calc/css3-radial-gradients-expected.html
css3/calc/gradient-color-stops-expected.html

css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::computeLengthPx):
(WebCore):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):

css/CSSCalculationValue.h:

(CSSCalcExpressionNode):
(CSSCalcValue):

css/CSSParser.cpp:

(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):

css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::init):
(WebCore):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
(WebCore::CSSPrimitiveValue::getDoubleValue):
(WebCore::CSSPrimitiveValue::getDoubleValueInternal):
(WebCore::CSSPrimitiveValue::customCssText):

css/CSSPrimitiveValue.h:

(WebCore):
(WebCore::CSSPrimitiveValue::isLength):
(WebCore::CSSPrimitiveValue::isNumber):
(WebCore::CSSPrimitiveValue::isPercentage):
(WebCore::CSSPrimitiveValue::isPx):
(WebCore::CSSPrimitiveValue::isCalculated):
(WebCore::CSSPrimitiveValue::isCalculatedPercentageNumber):
(WebCore::CSSPrimitiveValue::isCalculatedPercentageLength):
(CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::getValue):
(WebCore::CSSPrimitiveValue::cssCalcValue):

css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyBorderRadius::applyValue):

LayoutTests:

Reviewed by Ojan Vafai.

css3/calc/block-mask-overlay-image-outset-expected.html: Renamed from LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html.
css3/calc/border-expected.txt:
css3/calc/calc-errors-expected.txt:
css3/calc/css3-radial-gradients-expected.html: Renamed from LayoutTests/css3/calc/css3-radial-gradients-expected-mismatch.html.
css3/calc/font-expected.txt:
css3/calc/font-monospace-expected.txt:
css3/calc/font-size-expected.txt:
css3/calc/font-size-fractional-expected.txt:
css3/calc/getComputedStyle-margin-percentage-expected.txt:
css3/calc/gradient-color-stops-expected.html: Renamed from LayoutTests/css3/calc/gradient-color-stops-expected-mismatch.html.
css3/calc/line-height-expected.txt:
css3/calc/margin-expected.txt:
css3/calc/padding-expected.txt:
css3/calc/simple-calcs-expected.txt:
css3/calc/table-border-spacing-expected.txt:

1:24 AM Changeset in webkit [107687] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Not reviewed: follow up to r107683: protect inspector sidebar from updating
while inserting new rule.

inspector/front-end/StylesSidebarPane.js:

(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

1:22 AM Changeset in webkit [107686] by Philippe Normand

5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r107662.

platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
platform/gtk/fast/js/global-constructors-expected.txt:

1:13 AM Changeset in webkit [107685] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Extend Chromium V8 tracing to cover more cases
https://bugs.webkit.org/show_bug.cgi?id=78507

Patch by Rick Byers <rbyers@.com> on 2012-02-14
Reviewed by Eric Seidel.

No tests modified because this affects only chrome tracing which we
currently don't try to validate with automated tests.

bindings/v8/V8EventListener.cpp:

(WebCore::V8EventListener::callListenerFunction):

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::instrumentedCallFunction):
(WebCore::V8Proxy::newInstance):

1:03 AM WebKitIDL edited by haraken@chromium.org

(diff)

12:55 AM Changeset in webkit [107684] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Pepper plugins don't receive mouse movement information in
non-mouse-lock mode.
https://bugs.webkit.org/show_bug.cgi?id=78014

This change makes WebMouseEventBuilder pass along mouse movement
information properly.

There isn't test for this change because:

the movement information added is only used by pepper, and there isn't any test for pepper at the WebKit side. (WebKit doesn't know about pepper.)
this change is trivial. It just copies two newly-added data fields from MouseEvent to WebMouseEventBuilder during conversion.

Patch by Yuzhu Shen <yzshen@chromium.com> on 2012-02-14
Reviewed by Tony Chang.

src/WebInputEventConversion.cpp:

(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):

12:50 AM Changeset in webkit [107683] by pfeldman@chromium.org

18 edits in trunk

Web Inspector: fire stylesheet changed event upon CSS modifications.
https://bugs.webkit.org/show_bug.cgi?id=78500

Patch by Pavel Feldman <pfeldman@google.com> on 2012-02-14
Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/Inspector.json:
inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::mergeId):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::merge):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::styleSheetChanged):
(WebCore):

inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):
(WebCore::InspectorStyleSheet::fireStyleSheetChanged):
(WebCore):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

inspector/InspectorStyleSheet.h:

(WebCore::InspectorStyleSheet::Listener::~Listener):
(Listener):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):

inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged):
(WebInspector.CSSStyleModel.prototype.setStyleSheetText):
(WebInspector.CSSStyleModel.prototype._undoRequested):
(WebInspector.CSSStyleModel.prototype._undoCompleted):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setText.callback):
(WebInspector.CSSProperty.prototype.setDisabled.callback):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.prototype.setText):
(WebInspector.CSSDispatcher.prototype.mediaQueryResultChanged):
(WebInspector.CSSDispatcher.prototype.styleSheetChanged):

inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged):
(WebInspector.DOMAgent.prototype.get undo):

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleShortcut):

LayoutTests:

http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.generateUndoTest):

inspector/elements/set-outer-html-test.js:

(initialize_SetOuterHTMLTest.InspectorTest.recordEvent):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo.bringBack):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo):

inspector/styles/styles-history.html:
inspector/styles/undo-add-new-rule.html:
inspector/styles/undo-add-property.html:
inspector/styles/undo-change-property.html:
inspector/styles/undo-property-toggle.html:
inspector/styles/undo-set-selector-text.html:

12:41 AM Changeset in webkit [107682] by Nikolas Zimmermann

260 edits
1 delete in trunk

Convert svg/animations to use SMIL methods for driving the timeline
https://bugs.webkit.org/show_bug.cgi?id=78422

Reviewed by Dirk Schulze.

Source/WebCore:

Switch the svg/animations tests to use SVGSVGElement.setCurrentTime to drive the animation timeline.
This should fix all flakiness we previously had with these tests - and as nice side-effect we're now
using the standard SVG methods to drive the timeline, and thus have more coverage for these methods.
It already exposed several SMIL bugs, that had to be fixed, before this worked:

beginElement()/endElement() modify the begin/end times of a SVGSMILElement. When beginElement() is called a new begin time is added to the list - and the same happens for endElement() with the end list. Unfortunately the begin/end times never get removed again, leading to incorrect instance time resolving when begin/endElement is called repeatedly, combined with moving the timeline through setCurrentTime.

SMIL3 specifically demands that all 'dynamic' times in the begin/endTimes list, such that got inserted
via beginElement/endElement - get removed if the begin/endTimes list is updated. Why?
When calling beginElement, then endElement, then beginElement again, the begin/endTimes lists should be
identical, w/o leftovers from any previous begin/endElement call.

To keep track of that introduce SMILTimeWithOrigin, which holds a SMILTime and an Origin enum,
which determines whether this SMILTime was created by the parser or dynamically created via
beginElement/endElement.

SMILTimeContainer::setElapsed() (called by SVGSVGElement::setCurrentTime) forgot to update the animation state, when it was not paused.

document.getElementsByTagName('animateMotion')[0], always returned 'object SVGElement', instead of SVGAnimateMotion element making it impossible to query the animation start time, as the interfaces from SVGAnimationElement were not available. Fix that by removing the last hacks from svgtags.in, now that all IDLs are available.

Now that we use SVGSVGElement::setCurrentTime to drive the animation testing, we can remove
the DRT specific sampleSVGAnimationAtTime functionality, and its code springled all over WebCore.

Covered by all existing tests in svg/animations.

WebCore.exp.in: Remove sampleAnimationAtTime() symbols.
WebCore.order: Ditto.
svg/SVGAnimationElement.cpp: Add a flag to begin/endElement, SMILTimeWithOrigin::ScriptOrigin, to indicate that these are dynamic SMILTimes, added by a script.

(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):

svg/SVGDocumentExtensions.cpp: Remove sampleAnimationAtTime.
svg/SVGDocumentExtensions.h: Ditto.
svg/animation/SMILTime.h: Add SMILTimeWithOrigin helper.

(SMILTimeWithOrigin): Needs a SMILTime and an Origin enum entry.
(WebCore::SMILTimeWithOrigin::SMILTimeWithOrigin):
(WebCore::SMILTimeWithOrigin::time): Returns the SMILTime.
(WebCore::SMILTimeWithOrigin::originIsScript): Determines if this SMILTime got added by a script.
(WebCore::operator<): Used by std::sort.

svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::setElapsed): Always call updateAnimations, even if the animation is not paused. Use the right elpased time value, to seek precisely to the desired position.
(WebCore::SMILTimeContainer::timerFired): Cleanup code, no need for a local variable 'elapsed'.
(WebCore::SMILTimeContainer::updateAnimations): Remove DRT specific sampling code, which is no longer needed.

svg/animation/SMILTimeContainer.h: Remove sampleAnimationAtTime.
svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::SVGSMILElement): Only call resolveFirstInterval, not reset, from the constructor - it wastes unnecessary time, as everything is already initialized.
(WebCore::clearTimesWithDynamicOrigins): Helper function to clear all SMILTimes from the begin/endTimes list, that are dynamic.
(WebCore::SVGSMILElement::reset): Clear begin/endTimes lists, on any reset() call (when driving the animation timeline through setElapsed).
(WebCore::SVGSMILElement::insertedIntoDocument): m_beginTimes now stores SMILTimeWithOrigins, adapt the code.
(WebCore::sortTimeList): Ditto.
(WebCore::SVGSMILElement::parseBeginOrEnd): Ditto.
(WebCore::SVGSMILElement::addBeginTime): Ditto.
(WebCore::SVGSMILElement::addEndTime): Ditto.
(WebCore::extractTimeFromVector): Ditto.
(WebCore::SVGSMILElement::findInstanceTime): Ditto.

svg/animation/SVGSMILElement.h:
svg/svgtags.in: Enable animateMotion/hkern/mpath JS interfaces, which were not enabled, despite their IDLs existed.

Source/WebKit/chromium:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

public/WebFrame.h:

(WebFrame):

src/WebFrameImpl.cpp:
src/WebFrameImpl.h:

(WebFrameImpl):

Source/WebKit/efl:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

WebKit.order:
WebView/WebFrame.mm:
WebView/WebFramePrivate.h:

Source/WebKit/qt:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

WebCoreSupport/DumpRenderTreeSupportQt.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

Interfaces/IWebFramePrivate.idl:
WebFrame.cpp:
WebFrame.h:

Tools:

Remove no longer needed SVG specific animation sampling functionality from DRT.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
DumpRenderTree/mac/LayoutTestControllerMac.mm:
DumpRenderTree/qt/LayoutTestControllerQt.cpp:
DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

DumpRenderTree/win/LayoutTestControllerWin.cpp:
DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

This also unifies & cleans up the tests, to use the same formatting and the same shouldBeCloseEnough helpers.

svg/animations/animVal-basics-expected.txt:
svg/animations/animVal-basics.html:
svg/animations/animate-calcMode-spline-by-expected.txt:
svg/animations/animate-calcMode-spline-by.html:
svg/animations/animate-calcMode-spline-from-by-expected.txt:
svg/animations/animate-calcMode-spline-from-by.html:
svg/animations/animate-calcMode-spline-from-to-expected.txt:
svg/animations/animate-calcMode-spline-from-to.html:
svg/animations/animate-calcMode-spline-to-expected.txt:
svg/animations/animate-calcMode-spline-to.html:
svg/animations/animate-calcMode-spline-values-expected.txt:
svg/animations/animate-calcMode-spline-values.html:
svg/animations/animate-color-calcMode-discrete.html:
svg/animations/animate-color-fill-currentColor.html:
svg/animations/animate-color-fill-from-by.html:
svg/animations/animate-color-rgba-calcMode-discrete.html:
svg/animations/animate-color-transparent.html:
svg/animations/animate-currentColor.html:
svg/animations/animate-dynamic-update-attributeName.html:
svg/animations/animate-end-attribute-expected.txt:
svg/animations/animate-end-attribute.html:
svg/animations/animate-endElement-beginElement.html:
svg/animations/animate-from-to-keyTimes.html:
svg/animations/animate-gradient-transform.html:
svg/animations/animate-inherit-css-property.html:
svg/animations/animate-insert-begin.html:
svg/animations/animate-insert-no-begin.html:
svg/animations/animate-keySplines.html:
svg/animations/animate-mpath-insert.html:
svg/animations/animate-number-calcMode-discrete-expected.txt:
svg/animations/animate-number-calcMode-discrete-keyTimes.html:
svg/animations/animate-number-calcMode-discrete.html:
svg/animations/animate-path-animation-Cc-Ss-expected.txt:
svg/animations/animate-path-animation-Cc-Ss.html:
svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt:
svg/animations/animate-path-animation-Ll-Vv-Hh.html:
svg/animations/animate-path-animation-Qq-Tt.html:
svg/animations/animate-path-animation-cC-sS-inverse-expected.txt:
svg/animations/animate-path-animation-cC-sS-inverse.html:
svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt:
svg/animations/animate-path-animation-lL-vV-hH-inverse.html:
svg/animations/animate-path-animation-qQ-tT-inverse.html:
svg/animations/animate-path-nested-transforms-expected.txt:
svg/animations/animate-path-nested-transforms.html:
svg/animations/animate-path-to-animation-expected.txt:
svg/animations/animate-path-to-animation.html:
svg/animations/animate-text-nested-transforms-expected.txt:
svg/animations/animate-text-nested-transforms.html:
svg/animations/animateTransform-pattern-transform.html:
svg/animations/resources/SVGAnimationTestCase.js:

(isCloseEnough):
(shouldBeCloseEnough):
(moveAnimationTimelineAndSample):
(sampleAnimation):
(runSMILTest):
(runAnimationTest):

svg/animations/script-tests/TEMPLATE.html: Removed.
svg/animations/script-tests/animVal-basics.js:

(sample3):
(executeTest):

svg/animations/script-tests/animate-calcMode-spline-by.js:

(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/animate-calcMode-spline-from-by.js:

(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/animate-calcMode-spline-from-to.js:

(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/animate-calcMode-spline-to.js:

(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/animate-calcMode-spline-values.js:

(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/animate-color-calcMode-discrete.js:

(executeTest):

svg/animations/script-tests/animate-color-fill-currentColor.js:

(executeTest):

svg/animations/script-tests/animate-color-fill-from-by.js:

(executeTest):

svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js:

(executeTest):

svg/animations/script-tests/animate-color-transparent.js:

(executeTest):

svg/animations/script-tests/animate-currentColor.js:

(executeTest):

svg/animations/script-tests/animate-dynamic-update-attributeName.js:

(executeTest):

svg/animations/script-tests/animate-end-attribute.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/animate-endElement-beginElement.js:

(executeTest):
(end):
(begin):

svg/animations/script-tests/animate-from-to-keyTimes.js:

(executeTest):

svg/animations/script-tests/animate-gradient-transform.js:

(executeTest):

svg/animations/script-tests/animate-inherit-css-property.js:

(executeTest):

svg/animations/script-tests/animate-insert-begin.js:

(executeTest):

svg/animations/script-tests/animate-insert-no-begin.js:

(executeTest):

svg/animations/script-tests/animate-keySplines.js:

(executeTest):

svg/animations/script-tests/animate-mpath-insert.js:

(executeTest):

svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js:

(executeTest):

svg/animations/script-tests/animate-number-calcMode-discrete.js:

(sample1):
(sample2):
(executeTest):

svg/animations/script-tests/animate-path-animation-Cc-Ss.js:

(sample4):
(executeTest):

svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js:

(sample4):
(executeTest):

svg/animations/script-tests/animate-path-animation-Qq-Tt.js:

(executeTest):

svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js:

(sample4):
(executeTest):

svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js:

(sample4):
(executeTest):

svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:

(executeTest):

svg/animations/script-tests/animate-path-nested-transforms.js:

(g.setAttribute.rect.createSVGElement.rect.setAttribute.rect.setAttribute.rect.setAttribute.rect.setAttribute.rect.setAttribute.g.appendChild.animateMotion.createSVGElement.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.g.appendChild.rootSVGElement.appendChild.startSample):
(endSample):
(executeTest):

svg/animations/script-tests/animate-path-to-animation.js:

(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/animate-text-nested-transforms.js:

(rootSVGElement.setAttribute.text.createSVGElement.text.setAttribute.text.textContent.string_appeared_here.text.setAttribute.animateMotion.createSVGElement.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.text.appendChild.rootSVGElement.appendChild.startSample):
(endSample):
(executeTest):

svg/animations/script-tests/animateTransform-pattern-transform.js:

(executeTest):

svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgangle-animation-deg-to-grad.js:

(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgangle-animation-deg-to-rad.js:

(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgangle-animation-grad-to-deg.js:

(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgangle-animation-grad-to-rad.js:

(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgangle-animation-rad-to-deg.js:

(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgangle-animation-rad-to-grad.js:

(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgboolean-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svginteger-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-LengthModeHeight.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-LengthModeOther.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-LengthModeWidth.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-invalid-value-1.js:

(executeTest):

svg/animations/script-tests/svglength-animation-invalid-value-2.js:

(executeTest):

svg/animations/script-tests/svglength-animation-invalid-value-3.js:

(executeTest):

svg/animations/script-tests/svglength-animation-number-to-number.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-px-to-cm.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-px-to-ems.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-px-to-exs.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-px-to-in.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-px-to-number.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-px-to-pc.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-px-to-percentage.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-px-to-pt.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-px-to-px.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglength-animation-unitType.js:

(executeTest):

svg/animations/script-tests/svglength-animation-values.js:

(sample5):
(executeTest):

svg/animations/script-tests/svglengthlist-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svglengthlist-animation-2.js:

(sample3):
(executeTest):

svg/animations/script-tests/svglengthlist-animation-3.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svglengthlist-animation-4.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svglengthlist-animation-5.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgnumber-animation-1.js:

(executeTest):

svg/animations/script-tests/svgnumber-animation-2.js:

(executeTest):

svg/animations/script-tests/svgnumber-animation-3.js:

(executeTest):

svg/animations/script-tests/svgnumberlist-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgnumberlist-animation-2.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgpath-animation-1.js:

(sample3):
(executeTest):

svg/animations/script-tests/svgpointlist-animation-1.js:

(sample3):
(executeTest):

svg/animations/script-tests/svgpointlist-animation-2.js:

(sample3):
(executeTest):

svg/animations/script-tests/svgrect-animation-1.js:

(sample3):
(executeTest):

svg/animations/script-tests/svgrect-animation-2.js:

(sample3):
(executeTest):

svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js:

(executeTest):

svg/animations/script-tests/svgtransform-animation-1.js:

(executeTest):

svg/animations/script-tests/svgtransform-animation-discrete.js:

(executeTest):

svg/animations/smil-element-not-removed-crash.html:
svg/animations/svgPreserveAspectRatio-animation-1.html:
svg/animations/svgangle-animation-deg-to-grad-expected.txt:
svg/animations/svgangle-animation-deg-to-grad.html:
svg/animations/svgangle-animation-deg-to-rad-expected.txt:
svg/animations/svgangle-animation-deg-to-rad.html:
svg/animations/svgangle-animation-grad-to-deg-expected.txt:
svg/animations/svgangle-animation-grad-to-deg.html:
svg/animations/svgangle-animation-grad-to-rad-expected.txt:
svg/animations/svgangle-animation-grad-to-rad.html:
svg/animations/svgangle-animation-rad-to-deg-expected.txt:
svg/animations/svgangle-animation-rad-to-deg.html:
svg/animations/svgangle-animation-rad-to-grad-expected.txt:
svg/animations/svgangle-animation-rad-to-grad.html:
svg/animations/svgboolean-animation-1.html:
svg/animations/svginteger-animation-1.html:
svg/animations/svglength-animation-LengthModeHeight-expected.txt:
svg/animations/svglength-animation-LengthModeHeight.html:
svg/animations/svglength-animation-LengthModeOther-expected.txt:
svg/animations/svglength-animation-LengthModeOther.html:
svg/animations/svglength-animation-LengthModeWidth-expected.txt:
svg/animations/svglength-animation-LengthModeWidth.html:
svg/animations/svglength-animation-invalid-value-1.html:
svg/animations/svglength-animation-invalid-value-2.html:
svg/animations/svglength-animation-invalid-value-3.html:
svg/animations/svglength-animation-number-to-number-expected.txt:
svg/animations/svglength-animation-number-to-number.html:
svg/animations/svglength-animation-px-to-cm-expected.txt:
svg/animations/svglength-animation-px-to-cm.html:
svg/animations/svglength-animation-px-to-ems-expected.txt:
svg/animations/svglength-animation-px-to-ems.html:
svg/animations/svglength-animation-px-to-exs-expected.txt:
svg/animations/svglength-animation-px-to-exs.html:
svg/animations/svglength-animation-px-to-in-expected.txt:
svg/animations/svglength-animation-px-to-in.html:
svg/animations/svglength-animation-px-to-number-expected.txt:
svg/animations/svglength-animation-px-to-number.html:
svg/animations/svglength-animation-px-to-pc-expected.txt:
svg/animations/svglength-animation-px-to-pc.html:
svg/animations/svglength-animation-px-to-percentage-expected.txt:
svg/animations/svglength-animation-px-to-percentage.html:
svg/animations/svglength-animation-px-to-pt-expected.txt:
svg/animations/svglength-animation-px-to-pt.html:
svg/animations/svglength-animation-px-to-px-expected.txt:
svg/animations/svglength-animation-px-to-px.html:
svg/animations/svglength-animation-unitType.html:
svg/animations/svglength-animation-values-expected.txt:
svg/animations/svglength-animation-values.html:
svg/animations/svglengthlist-animation-1.html:
svg/animations/svglengthlist-animation-2-expected.txt:
svg/animations/svglengthlist-animation-2.html:
svg/animations/svglengthlist-animation-3.html:
svg/animations/svglengthlist-animation-4.html:
svg/animations/svglengthlist-animation-5.html:
svg/animations/svgnumber-animation-1.html:
svg/animations/svgnumber-animation-2.html:
svg/animations/svgnumber-animation-3.html:
svg/animations/svgnumberlist-animation-1-expected.txt:
svg/animations/svgnumberlist-animation-1.html:
svg/animations/svgnumberlist-animation-2-expected.txt:
svg/animations/svgnumberlist-animation-2.html:
svg/animations/svgnumberoptionalnumber-animation-1.html:
svg/animations/svgnumberoptionalnumber-animation-2.html:
svg/animations/svgnumberoptionalnumber-animation-3.html:
svg/animations/svgnumberoptionalnumber-animation-4.html:
svg/animations/svgpath-animation-1-expected.txt:
svg/animations/svgpath-animation-1.html:
svg/animations/svgpointlist-animation-1-expected.txt:
svg/animations/svgpointlist-animation-1.html:
svg/animations/svgpointlist-animation-2-expected.txt:
svg/animations/svgpointlist-animation-2.html:
svg/animations/svgrect-animation-1-expected.txt:
svg/animations/svgrect-animation-1.html:
svg/animations/svgrect-animation-2-expected.txt:
svg/animations/svgrect-animation-2.html:
svg/animations/svgstring-animation-fallback-to-discrete-expected.txt:
svg/animations/svgstring-animation-fallback-to-discrete.html:
svg/animations/svgtransform-animation-1.html:
svg/animations/svgtransform-animation-discrete-expected.txt:
svg/animations/svgtransform-animation-discrete.html:

12:24 AM Changeset in webkit [107681] by pfeldman@chromium.org

3 edits
2 adds in trunk

Web Inspector: [REGRESSION] Copy Stack Trace is broken
https://bugs.webkit.org/show_bug.cgi?id=78583

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/copy-stack-trace.html

inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):

LayoutTests:

inspector/debugger/copy-stack-trace-expected.txt: Added.
inspector/debugger/copy-stack-trace.html: Added.

12:17 AM Changeset in webkit [107680] by noel.gordon@gmail.com

12 edits
1 move
4 adds
6 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #6 of N (visually re-inspecting as I go along, lest skia bite me).

fast/replaced/image-tag-expected.txt: Renamed from LayoutTests/platform/gtk/fast/replaced/image-tag-expected.txt.
platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-linux/fast/replaced/image-onload-expected.png:
platform/chromium-linux/fast/replaced/image-sizing-expected.png:
platform/chromium-mac-leopard/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac-leopard/fast/replaced/image-onload-expected.png:
platform/chromium-mac-leopard/fast/replaced/image-sizing-expected.png:
platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png: Added.
platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.png: Added.
platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.png: Added.
platform/chromium-mac-snowleopard/fast/replaced/image-tag-expected.png: Added.
platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png: Removed.
platform/chromium-mac/fast/replaced/image-onload-expected.png: Removed.
platform/chromium-mac/fast/replaced/image-sizing-expected.png: Removed.
platform/chromium-mac/fast/replaced/image-tag-expected.png: Removed.
platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-win/fast/replaced/image-onload-expected.png:
platform/chromium-win/fast/replaced/image-sizing-expected.png:
platform/chromium-win/fast/replaced/image-tag-expected.png:
platform/chromium/test_expectations.txt:
platform/mac/fast/replaced/image-tag-expected.txt: Removed.
platform/qt/fast/replaced/image-tag-expected.txt: Removed.

12:16 AM Changeset in webkit [107679] by eric@webkit.org

2 edits in trunk/Source/WebCore

Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder
https://bugs.webkit.org/show_bug.cgi?id=78540

Reviewed by Adam Barth.

platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::encodePixels):

12:05 AM Changeset in webkit [107678] by eric@webkit.org

2 edits in trunk/Source/JavaScriptCore

Upstream Android's additions to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=78536

Reviewed by Adam Barth.

wtf/Platform.h:

12:01 AM Applications using WebKit edited by wesley

(diff)

Feb 13, 2012:

11:54 PM Changeset in webkit [107677] by mihaip@chromium.org

3 edits
2 deletes in trunk/Source/WebKit/chromium

[Chromium] Remove BoundObject
https://bugs.webkit.org/show_bug.cgi?id=78531

Reviewed by Pavel Feldman.

Remove the BoundObject class, references to it were removed in r56999.

WebKit.gyp:
src/BoundObject.cpp: Removed.
src/BoundObject.h: Removed.
src/WebDevToolsFrontendImpl.cpp:

11:48 PM Changeset in webkit [107676] by pfeldman@chromium.org

5 edits in trunk

[Qt] inspector/styles/undo-add-new-rule.html crashes
https://bugs.webkit.org/show_bug.cgi?id=78502

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::deleteRule):

LayoutTests:

platform/chromium/test_expectations.txt:
platform/qt/Skipped:

11:38 PM Changeset in webkit [107675] by noel.gordon@gmail.com

6 edits
1 move
2 adds
2 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #5 of N

platform/chromium-linux/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
platform/chromium-mac-snowleopard/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
platform/chromium-mac-snowleopard/fast/images/image-css3-content-data-expected.png: Added.
platform/chromium-mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
platform/chromium-win/fast/images/image-css3-content-data-expected.png: Renamed from LayoutTests/platform/chromium/fast/images/image-css3-content-data-expected.png.
platform/chromium-win/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
platform/chromium/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Removed.
platform/chromium/test_expectations.txt:
platform/mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Removed.

11:31 PM Changeset in webkit [107674] by commit-queue@webkit.org

1 edit
2 adds in trunk/Source/WebKit

Initial upstreaming of selection handling code for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=78136

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-13
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

blackberry/WebKitSupport/SelectionHandler.cpp: Added.
blackberry/WebKitSupport/SelectionHandler.h: Added.

11:22 PM Changeset in webkit [107673] by noel.gordon@gmail.com

9 edits
1 add
1 delete in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #4 of N

platform/chromium-linux/fast/block/float/014-expected.png:
platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
platform/chromium-mac-leopard/fast/block/float/014-expected.png:
platform/chromium-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
platform/chromium-mac-snowleopard/fast/block/float/014-expected.png: Added.
platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
platform/chromium-mac/fast/block/float/014-expected.png: Removed.
platform/chromium-win/fast/block/float/014-expected.png:
platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
platform/chromium/test_expectations.txt:

10:45 PM Changeset in webkit [107672] by Nate Chapin

12 edits in trunk

Source/WebCore: Reuse CachedRawResources (e.g., XHRs) that are stored
in the MemoryCache when appropriate.
https://bugs.webkit.org/show_bug.cgi?id=76564

Reviewed by Antti Koivisto.

No new tests, expected behavior covered by existing tests.

html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL): Objects shouldn't remain in the

MemoryCache if revokeObjectURL is called on them.

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceContent): Add CachedRawResource support.

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setCacheDisabled): Immediately

evict resources, rather than waiting for navigation, since XHRs
should hit the cache if it has been disabled.

loader/cache/CachedRawResource.cpp:

(CachedRawResourceCallback): Encapsulates the async callback for

a cache hit for CachedRawResources.

(WebCore::CachedRawResource::sendCallbacks): Do the work defered in didAddClient.
(WebCore::CachedRawResource::didAddClient): Scheduled a CachedRawResourceCallback if

we already have a response, since async XHRs may not play nicely with receiving
their data synchronously.

(WebCore::CachedRawResource::removeClient): Ensure we cancel a callback to a client if

it removes itself.

(WebCore::CachedRawResource::canReuse): Provide some basic rules for when a

CachedRawResource can be reused.

loader/cache/CachedRawResource.h:
loader/cache/CachedResource.h:
loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy): Don't automatically reload

CachedRawResources, and add a check for whether this request has already been
made conditional.

xml/XMLHttpRequest.cpp:

LayoutTests: Test update for https://bugs.webkit.org/show_bug.cgi?id=76564.

Use sync XHRs instead of async in network-content-replacement-xhr.html,
since the inspector pulls async XHR data off of its CachedResource, instead
of a buffer it controls.

Reviewed by Antti Koivisto.

http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
http/tests/inspector/network/network-content-replacement-xhr.html:

10:41 PM Changeset in webkit [107671] by noel.gordon@gmail.com

4 edits
2 moves
2 adds
6 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #3 of N

fast/backgrounds/size/backgroundSize21-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize21-expected.txt.
fast/backgrounds/size/backgroundSize22-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize22-expected.txt.
platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png: Removed.
platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png: Removed.
platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
platform/chromium/test_expectations.txt:
platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Removed.
platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Removed.
platform/qt/fast/backgrounds/size/backgroundSize21-expected.txt: Removed.
platform/qt/fast/backgrounds/size/backgroundSize22-expected.txt: Removed.

10:30 PM WebKitIDL edited by haraken@chromium.org

(diff)

10:25 PM Changeset in webkit [107670] by noel.gordon@gmail.com

6 edits
4 moves
4 adds
12 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #2 of N

fast/backgrounds/size/backgroundSize17-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize17-expected.txt.
fast/backgrounds/size/backgroundSize18-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize18-expected.txt.
fast/backgrounds/size/backgroundSize19-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize19-expected.txt.
fast/backgrounds/size/backgroundSize20-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize20-expected.txt.
platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize17-expected.png: Added.
platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize18-expected.png: Added.
platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize19-expected.png: Added.
platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize20-expected.png: Added.
platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png: Removed.
platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png: Removed.
platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png: Removed.
platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png: Removed.
platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
platform/chromium/test_expectations.txt:
platform/mac/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
platform/mac/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
platform/mac/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Removed.
platform/qt/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
platform/qt/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
platform/qt/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
platform/qt/fast/backgrounds/size/backgroundSize20-expected.txt: Removed.

9:57 PM Changeset in webkit [107669] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[chromium] Set opaque flag on SkBitmap in per-tile layer updater
https://bugs.webkit.org/show_bug.cgi?id=78498

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-13
Reviewed by Stephen White.

No new tests.

platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):

platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:

(SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::layerIsOpaque):

9:28 PM Changeset in webkit [107668] by noel.gordon@gmail.com

5 edits
2 adds
2 deletes in trunk/LayoutTests

Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #1 of N

platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
platform/chromium-mac-snowleopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
platform/chromium-mac-snowleopard/compositing/geometry/vertical-scroll-composited-expected.png: Added.
platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.png:
platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
platform/chromium/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
platform/chromium/test_expectations.txt:

9:19 PM Changeset in webkit [107667] by commit-queue@webkit.org

3 edits in trunk/Tools

Add Linux ChromiumOS test results to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=78495

Patch by Rob Flack <flackr@chromium.org> on 2012-02-13
Reviewed by Ojan Vafai.

TestResultServer/static-dashboards/builders.js:
TestResultServer/static-dashboards/dashboard_base.js:

9:05 PM Changeset in webkit [107666] by noel.gordon@gmail.com

2 edits in trunk/LayoutTests

[chromium] Unreviewed, remove svg/custom/grayscale-gradient-mask.svg CRASH expectation
https://bugs.webkit.org/show_bug.cgi?id=78556

platform/chromium/test_expectations.txt:

8:41 PM Changeset in webkit [107665] by wjmaclean@chromium.org

18 edits in trunk/Source

[chromium] Remove obsolete zoom animation pathway.
https://bugs.webkit.org/show_bug.cgi?id=78359

Reviewed by James Robinson.

Source/WebCore:

Tests for existing pathways should not be broken. Tests for removed pathway removed previously.

This patch removes dead code from the previous incarnation of zoom animation for chromium.

page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

page/FrameView.cpp:
page/FrameView.h:

(FrameView):

platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):

platform/ScrollAnimator.h:

(ScrollAnimator):

platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::animationTimerFired):

platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

platform/ScrollableArea.cpp:
platform/ScrollableArea.h:
testing/InternalSettings.cpp:
testing/InternalSettings.h:

(InternalSettings):

testing/InternalSettings.idl:
testing/Internals.cpp:

Source/WebKit/chromium:

This patch removes dead code from the previous incarnation of zoom animation for chromium.

src/WebViewImpl.cpp:

Source/WebKit2:

This patch removes dead code from the previous incarnation of zoom animation for chromium.

WebProcess/Plugins/PDF/BuiltInPDFView.h:
(BuiltInPDFView):

8:38 PM Changeset in webkit [107664] by noel.gordon@gmail.com

2 edits in trunk/LayoutTests

fast/text/atsui-multiple-renderers.html and related report IMAGE failure on commit queue
https://bugs.webkit.org/show_bug.cgi?id=78544

Unreviewed. Test expectations update: PASS locally on linux but IMAGE on the queue.

platform/chromium/test_expectations.txt: fast/text/atsui-multiple-renderers.html fast/text/international/danda-space.html fast/text/international/thai-baht-space.html fast/text/international/thai-line-breaks.html platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html

8:19 PM Changeset in webkit [107663] by shinyak@chromium.org

2 edits in trunk/Source/WebCore

[Regression] r107650 broke the windows build.
https://bugs.webkit.org/show_bug.cgi?id=78569

Build fix, Unreviewed.

The variable defined in switch statement should not escape from the switch statement.

dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):

8:03 PM Changeset in webkit [107662] by commit-queue@webkit.org

6 edits in trunk

[GTK] Mutation Observers build is broken
https://bugs.webkit.org/show_bug.cgi?id=78433

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-13
Reviewed by Martin Robinson.

Source/WebCore:

Added some files missed.

No new tests since no new feature.

GNUmakefile.list.am:

Tools:

Enabled mutation observers as a default feature for GTK port, too.

Scripts/build-webkit:

LayoutTests:

Removed fast/mutation, but added following 3 tests which are needed more time to pass.

GTK port DRT doesn't support some APIs like scheduleAsynchronousKeyDown.
I opened a new bug to deal with it. http://webkit.org/b/78481
And also see http://webkit.org/b/78290
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html

Needed to enable FileSystem API at the same time.
fast/mutation/filesystem-callback-delivery.html

platform/gtk/Skipped:

7:49 PM WebKitIDL edited by haraken@chromium.org

(diff)

7:15 PM Changeset in webkit [107661] by hayato@chromium.org

23 edits in trunk

Make ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
https://bugs.webkit.org/show_bug.cgi?id=77514

Reviewed by Dimitri Glazkov.

NodeType.SHADOW_ROOT_NODE type is finally gone.

Source/WebCore:

bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

bindings/objc/DOM.mm:

(kitClass):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

dom/ContainerNode.cpp:

(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):

dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):

dom/Node.cpp:

dom/Node.h:
dom/Range.cpp:

dom/ShadowRoot.cpp:
dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::toShadowRoot):

editing/FrameSelection.cpp:

(WebCore::nodeIsDetachedFromDocument):
(WebCore):
(WebCore::FrameSelection::textWillBeReplaced):

editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):

html/parser/HTMLElementStack.h:

(WebCore::isInHTMLNamespace):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):

xml/XPathUtil.cpp:

(WebCore::XPath::isValidContextNode):

Source/WebKit/chromium:

src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::buildContentForNode):

LayoutTests:

fast/dom/shadow/nodetype-expected.txt:
fast/dom/shadow/nodetype.html:
resources/dump-as-markup.js:

(Markup._get):

6:50 PM Changeset in webkit [107660] by tony@chromium.org

2 edits
3 adds in trunk/LayoutTests

[chromium] Unreviewed gardening. Small cleanup after r107638.

platform/chromium-mac-leopard/css3/filters/crash-hw-sw-switch-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/filter-empty-element-crash-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Added.
platform/chromium/test_expectations.txt:

6:40 PM Changeset in webkit [107659] by ojan@chromium.org

5 edits
4 adds in trunk

Source/JavaScriptCore: Replace old strtod with new strtod
https://bugs.webkit.org/show_bug.cgi?id=68044

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2012-02-12
Reviewed by Geoffrey Garen.

parser/Lexer.cpp: Added template argument. This version allows junk after numbers.

(JSC::::lex):

runtime/JSGlobalObjectFunctions.cpp: Ditto.

(JSC::parseInt):
(JSC::jsStrDecimalLiteral):

runtime/LiteralParser.cpp: Ditto.

(JSC::::Lexer::lexNumber):

wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter.

It takes a template argument to allow clients to determine statically whether it should allow
junk after the numbers or not.
(WTF):
(WTF::strtod):

wtf/dtoa.h:

(WTF):

wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers.

(WTF::toDoubleType):

Source/WebCore: rtl + flex-direction:column is positioning elements incorrectly
https://bugs.webkit.org/show_bug.cgi?id=78555

Reviewed by Tony Chang.

Do the y-axis flipping after we have adjusted the y-position for
flex-align instead of before.

Tests: css3/flexbox/flex-align-baseline.html

css3/flexbox/flex-align-end.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren):
The amount we adjust by also needs to be flipped for rtl+column,
so the flipping needs to be done after we align the flex items.

LayoutTests: rtl + flex-direction:column is positioning elements incorrectly
https://bugs.webkit.org/show_bug.cgi?id=78555

Reviewed by Tony Chang.

css3/flexbox/flex-align-baseline-expected.txt: Added.
css3/flexbox/flex-align-baseline.html: Added.
css3/flexbox/flex-align-end-expected.txt: Added.
css3/flexbox/flex-align-end.html: Added.
css3/flexbox/true-centering-expected.txt:

6:39 PM Changeset in webkit [107658] by bashi@chromium.org

2 edits
14 adds in trunk/LayoutTests

Unreviewed test expectations update.
Rebaselining font-face-synthetic-bold-italic.html and font-face-weight-matching.html.

platform/chromium-linux/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
platform/chromium-linux/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
platform/chromium-linux/fast/css/font-face-weight-matching-expected.png: Added.
platform/chromium-linux/fast/css/font-face-weight-matching-expected.txt: Added.
platform/chromium-mac-leopard/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
platform/chromium-mac-leopard/fast/css/font-face-weight-matching-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/css/font-face-weight-matching-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/font-face-weight-matching-expected.txt: Added.
platform/chromium-win/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
platform/chromium-win/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
platform/chromium-win/fast/css/font-face-weight-matching-expected.png: Added.
platform/chromium-win/fast/css/font-face-weight-matching-expected.txt: Added.
platform/chromium/test_expectations.txt:

6:36 PM Changeset in webkit [107657] by andersca@apple.com

5 edits in trunk/Source/WebCore

The tile cache layer should have its background set to the page background
https://bugs.webkit.org/show_bug.cgi?id=78560
<rdar://problem/10857472>

Reviewed by Sam Weinig.

page/FrameView.cpp:

(WebCore::FrameView::recalculateScrollbarOverlayStyle):
Inform the RenderLayerCompositor that the background color has changed.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateLayerBackgroundColor):
For tile cache layers we don't need a separate contents layer for the background color so
just set the background color on the layer directly.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::documentBackgroundColorDidChange):
If the root render layer is using a tile cache layer, update its background color.

6:24 PM Changeset in webkit [107656] by commit-queue@webkit.org

3 edits in trunk/Tools

Allow to configure ENABLE_FTPDIR in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=65098

Patch by Loïc Yhuel <loic.yhuel_ext@softathome.com> on 2012-02-13
Reviewed by Eric Seidel.

Allow to disable ENABLE_FTPDIR by command line.
Remove ENABLE_FTPDIR from --minimal build

Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,

as, for Qt platform, build-webkit does not add on command line what it thinks to be default values

6:21 PM Changeset in webkit [107655] by shinyak@chromium.org

2 edits in trunk/Tools

Add shinyak as committer

6:17 PM Changeset in webkit [107654] by eae@chromium.org

6 edits in branches/subpixellayout/Source/WebCore

Remove explicit AppUnit::toFloat calls in places where it is not needed.

6:10 PM Changeset in webkit [107653] by abarth@webkit.org

4 edits in trunk/Tools

Implement start/stop_helper for ChromiumAndroidPort
https://bugs.webkit.org/show_bug.cgi?id=78558

Reviewed by Dirk Pranke.

These functions (and their dependencies) set up the Android device for
testing.

This patch also includes a few tweaks on the previous patch recommended
by dpranke.

Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort.stop_helper):
(ChromiumAndroidPort._shut_down_http_server):
(ChromiumAndroidPort):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):
(ChromiumAndroidPort._restore_system_font):
(ChromiumAndroidPort._push_test_resources):
(ChromiumAndroidPort._push_to_device):
(ChromiumAndroidPort._pull_from_device):
(ChromiumAndroidPort._kill_device_process):
(ChromiumAndroidPort._setup_performance):
(ChromiumAndroidPort._teardown_performance):

Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest):

Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase):
(PortTestCase.make_port):
(PortTestCase.test_default_worker_model):

5:40 PM Changeset in webkit [107652] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Implement Element.webkitRegionOverflow

[CSSRegions][CSSOM] Implement Element.regionOverflow
https://bugs.webkit.org/show_bug.cgi?id=77863

Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.

On each layout, compute the overflowState for each region belonging to the flow thread

Tests: fast/regions/element-region-overflow-state-vertical-rl.html

fast/regions/element-region-overflow-state.html

dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):
(WebCore):

dom/Element.h:
dom/Element.idl:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore):

rendering/RenderFlowThread.h:
rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

rendering/RenderRegion.h:

(RenderRegion):
(WebCore::RenderRegion::regionState):
(WebCore::RenderRegion::setRegionState):

5:37 PM Changeset in webkit [107651] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

More windows build fixing

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

5:34 PM Changeset in webkit [107650] by commit-queue@webkit.org

10 edits
4 adds in trunk

Implement Element.webkitRegionOverflow

[CSSRegions][CSSOM] Implement Element.regionOverflow
https://bugs.webkit.org/show_bug.cgi?id=77863

Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.

Source/WebCore:

On each layout, compute the overflowState for each region belonging to the flow thread

Tests: fast/regions/element-region-overflow-state-vertical-rl.html

fast/regions/element-region-overflow-state.html

dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):
(WebCore):

dom/Element.h:
dom/Element.idl:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore):

rendering/RenderFlowThread.h:
rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

rendering/RenderRegion.h:

(RenderRegion):
(WebCore::RenderRegion::regionState):
(WebCore::RenderRegion::setRegionState):

LayoutTests:

fast/regions/element-region-overflow-state-expected.txt: Added.
fast/regions/element-region-overflow-state-vertical-rl-expected.txt: Added.
fast/regions/element-region-overflow-state-vertical-rl.html: Added.
fast/regions/element-region-overflow-state.html: Added.

5:32 PM Changeset in webkit [107649] by ap@apple.com

2 edits in trunk/Source/WebCore

File API IDLs are incorrect in Xcode project
https://bugs.webkit.org/show_bug.cgi?id=78551

Rubber-stamped by Dan Bernstein.

WebCore.xcodeproj/project.pbxproj: Corrected paths, and added missing files.

5:27 PM Changeset in webkit [107648] by benjamin@webkit.org

4 edits in trunk/Source/WebCore

SharedBuffer::getSomeData() must support m_dataArray if NETWORK_CFDATA_ARRAY_CALLBACK is defined
https://bugs.webkit.org/show_bug.cgi?id=77718

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-13
Reviewed by David Kilzer.

Previously, the last part of SharedBuffer::getSomeData() was systematically accessing
the data from the segments. When NETWORK_CFDATA_ARRAY_CALLBACK is defined, there can
be data in m_dataArray past the segment.

The previous code was making invalid memory access pass the segment vector. This patch
adds support for getting the data out of m_dataArray to make SharedBuffer::getSomeData()
works with NETWORK_CFDATA_ARRAY_CALLBACK.

This is covered by existing tests when NETWORK_CFDATA_ARRAY_CALLBACK is defined.
The test 'fast/events/constructors/track-event-constructor.html' is a reliable test
for this.

platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::getSomeData):

platform/SharedBuffer.h:

(SharedBuffer):

platform/cf/SharedBufferCF.cpp:

(WebCore):
(WebCore::SharedBuffer::copySomeDataFromDataArray):

5:10 PM Changeset in webkit [107647] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Executing out of bounds in JSC::Yarr::YarrCodeBlock::execute / JSC::RegExp::match
https://bugs.webkit.org/show_bug.cgi?id=76315

Reviewed by Gavin Barraclough.

Perform a 3 byte compare using two comparisons, rather than trying to perform the
operation with a four byte load.

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):

5:07 PM Changeset in webkit [107646] by andersca@apple.com

5 edits in trunk/Source/WebCore

Force slow-scrolling mode when there are position:fixed elements on a page
https://bugs.webkit.org/show_bug.cgi?id=78553
<rdar://problem/10247934>

Reviewed by Dan Bernstein.

Eventually, the scrolling tree will know about fixed positioning layers so their position can be updated
when the scroll layer position is updated. For now we'll take the simple route however.

page/FrameView.cpp:

(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):
Inform the scrolling coordinator when the number of fixed objects changes between 0 and 1.

page/FrameView.h:

(WebCore::FrameView::hasFixedObjects):
Make this public.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
Call updateShouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingCoordinator::frameViewHasFixedObjectsDidChange):
Call updateShouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
Make sure to update compositing layers here. Normally, they will be updated by layout but doing a layout
here is too intrusive since it could potentially change the size of the page.

(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
If we have fixed objects or slow repaint objects we need to update the scroll layer position on the main thread.

5:07 PM Changeset in webkit [107645] by enne@google.com

5 edits in trunk/Source/WebCore

[chromium] Use HashMap<..., OwnPtr<Tile>> for compositor tilemap
https://bugs.webkit.org/show_bug.cgi?id=74154

Reviewed by James Robinson.

Covered by the compositing/ layout tests.

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::create):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::createTile):

platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::addTile):
(WebCore::CCLayerTilingData::takeTile):
(WebCore::CCLayerTilingData::tileAt):

platform/graphics/chromium/cc/CCLayerTilingData.h:
platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::DrawableTile::create):
(WebCore::DrawableTile::DrawableTile):
(WebCore::CCTiledLayerImpl::createTile):

4:59 PM Changeset in webkit [107644] by Lucas Forschler

5 edits in branches/safari-534.54-branch/Source

Versioning.

4:57 PM Changeset in webkit [107643] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, removing some tests that have been passing
as far back as the flakiness dashboard's history goes.

platform/chromium/test_expectations.txt:

4:56 PM Changeset in webkit [107642] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

Windows build fix

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

4:55 PM Changeset in webkit [107641] by Lucas Forschler

1 copy in tags/Safari-534.54.15

New tag.

4:53 PM Changeset in webkit [107640] by leviw@chromium.org

5 edits in branches/subpixellayout/Source/WebCore/rendering

Converting drawLineForBoxSide to operate on integers (which makes sense). This mostly entails fixing the callers to use pixel snapping.

4:53 PM Changeset in webkit [107639] by jsbell@chromium.org

3 edits
2 copies in branches/chromium/1025

Merge 107278 - [Chromium] IndexedDB: IDBVersionChangeRequest V8 wrapper not generated as ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=78167

Source/WebCore:

Add ActiveDOMObject annotation to IDBVersionChangeRequest.idl; it is not
automagically inherited from IDBRequest.idl.

Reviewed by Adam Barth.

Test: storage/indexeddb/versionchangerequest-activedomobject.html

storage/IDBVersionChangeRequest.idl:

LayoutTests:

Reviewed by Adam Barth.

storage/indexeddb/versionchangerequest-activedomobject-expected.txt: Added.
storage/indexeddb/versionchangerequest-activedomobject.html: Added.

TBR=jsbell@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9390031

4:48 PM Changeset in webkit [107638] by senorblanco@chromium.org

2 edits
154 adds
8 deletes in trunk/LayoutTests

[chromium] New baselines for css3/filters tests (unreviewed).

platform/chromium-linux/css3/filters: Added.
platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png: Added.
platform/chromium-linux/css3/filters/effect-blur-hw-expected.png: Added.
platform/chromium-linux/css3/filters/effect-brightness-expected.png: Added.
platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png: Added.
platform/chromium-linux/css3/filters/effect-combined-hw-expected.png: Added.
platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png: Added.
platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png: Added.
platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png: Added.
platform/chromium-linux/css3/filters/filter-empty-element-crash-expected.png: Added.
platform/chromium-linux/css3/filters/filter-with-transform-expected.png: Added.
platform/chromium-linux/css3/filters/nested-filter-expected.png: Added.
platform/chromium-mac-leopard/css3/filters: Added.
platform/chromium-mac-leopard/css3/filters/crash-filter-change-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-blur-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-blur-hw-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-brightness-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-brightness-hw-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-combined-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-combined-hw-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-contrast-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-contrast-hw-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-custom-combined-missing-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-custom-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-custom-parameters-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-grayscale-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-grayscale-hw-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-hw-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-invert-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-invert-hw-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-opacity-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-opacity-hw-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-saturate-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-saturate-hw-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-sepia-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/effect-sepia-hw-expected.png: Added.
platform/chromium-mac-leopard/css3/filters/regions-expanding-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters: Added.
platform/chromium-mac-snowleopard/css3/filters/add-filter-rendering-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/crash-filter-change-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-blur-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-blur-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-blur-hw-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-brightness-hw-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-combined-hw-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-contrast-hw-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-custom-combined-missing-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-hw-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-hw-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-invert-hw-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-opacity-hw-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-saturate-hw-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-sepia-hw-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/filter-repaint-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/filter-with-transform-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/filtered-compositing-descendant-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/filtered-inline-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/nested-filter-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/nested-filters-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/regions-expanding-expected.png: Added.
platform/chromium-mac-snowleopard/css3/filters/simple-filter-rendering-expected.png: Added.
platform/chromium-win/css3/filters: Added.
platform/chromium-win/css3/filters/add-filter-rendering-expected.png: Added.
platform/chromium-win/css3/filters/crash-filter-change-expected.png: Added.
platform/chromium-win/css3/filters/effect-blur-expected.png: Added.
platform/chromium-win/css3/filters/effect-blur-expected.txt: Added.
platform/chromium-win/css3/filters/effect-blur-hw-expected.png: Added.
platform/chromium-win/css3/filters/effect-blur-hw-expected.txt: Added.
platform/chromium-win/css3/filters/effect-brightness-expected.png: Added.
platform/chromium-win/css3/filters/effect-brightness-expected.txt: Added.
platform/chromium-win/css3/filters/effect-brightness-hw-expected.png: Added.
platform/chromium-win/css3/filters/effect-brightness-hw-expected.txt: Added.
platform/chromium-win/css3/filters/effect-combined-expected.png: Added.
platform/chromium-win/css3/filters/effect-combined-expected.txt: Added.
platform/chromium-win/css3/filters/effect-combined-hw-expected.png: Added.
platform/chromium-win/css3/filters/effect-combined-hw-expected.txt: Added.
platform/chromium-win/css3/filters/effect-contrast-expected.png: Added.
platform/chromium-win/css3/filters/effect-contrast-expected.txt: Added.
platform/chromium-win/css3/filters/effect-contrast-hw-expected.png: Added.
platform/chromium-win/css3/filters/effect-contrast-hw-expected.txt: Added.
platform/chromium-win/css3/filters/effect-custom-combined-missing-expected.png: Added.
platform/chromium-win/css3/filters/effect-custom-expected.png: Added.
platform/chromium-win/css3/filters/effect-custom-parameters-expected.png: Added.
platform/chromium-win/css3/filters/effect-drop-shadow-expected.png: Added.
platform/chromium-win/css3/filters/effect-drop-shadow-expected.txt: Added.
platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.png: Added.
platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.txt: Added.
platform/chromium-win/css3/filters/effect-grayscale-expected.png: Added.
platform/chromium-win/css3/filters/effect-grayscale-expected.txt: Added.
platform/chromium-win/css3/filters/effect-grayscale-hw-expected.png: Added.
platform/chromium-win/css3/filters/effect-grayscale-hw-expected.txt: Added.
platform/chromium-win/css3/filters/effect-hue-rotate-expected.png: Added.
platform/chromium-win/css3/filters/effect-hue-rotate-expected.txt: Added.
platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.png: Added.
platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.txt: Added.
platform/chromium-win/css3/filters/effect-invert-expected.png: Added.
platform/chromium-win/css3/filters/effect-invert-expected.txt: Added.
platform/chromium-win/css3/filters/effect-invert-hw-expected.png: Added.
platform/chromium-win/css3/filters/effect-invert-hw-expected.txt: Added.
platform/chromium-win/css3/filters/effect-opacity-expected.png: Added.
platform/chromium-win/css3/filters/effect-opacity-expected.txt: Added.
platform/chromium-win/css3/filters/effect-opacity-hw-expected.png: Added.
platform/chromium-win/css3/filters/effect-opacity-hw-expected.txt: Added.
platform/chromium-win/css3/filters/effect-saturate-expected.png: Added.
platform/chromium-win/css3/filters/effect-saturate-expected.txt: Added.
platform/chromium-win/css3/filters/effect-saturate-hw-expected.png: Added.
platform/chromium-win/css3/filters/effect-saturate-hw-expected.txt: Added.
platform/chromium-win/css3/filters/effect-sepia-expected.png: Added.
platform/chromium-win/css3/filters/effect-sepia-expected.txt: Added.
platform/chromium-win/css3/filters/effect-sepia-hw-expected.png: Added.
platform/chromium-win/css3/filters/effect-sepia-hw-expected.txt: Added.
platform/chromium-win/css3/filters/filter-region-expected.png: Added.
platform/chromium-win/css3/filters/filter-repaint-expected.png: Added.
platform/chromium-win/css3/filters/filter-with-transform-expected.png: Added.
platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.png: Added.
platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Added.
platform/chromium-win/css3/filters/filtered-inline-expected.png: Added.
platform/chromium-win/css3/filters/nested-filter-expected.png: Added.
platform/chromium-win/css3/filters/nested-filters-expected.png: Added.
platform/chromium-win/css3/filters/regions-expanding-expected.png: Added.
platform/chromium-win/css3/filters/regions-expanding-expected.txt: Added.
platform/chromium-win/css3/filters/simple-filter-rendering-expected.png: Added.
platform/chromium/css3/filters: Added.
platform/chromium/css3/filters/effect-custom-combined-missing-expected.txt: Added.
platform/chromium/css3/filters/effect-custom-disabled-expected.txt: Added.
platform/chromium/css3/filters/effect-custom-expected.txt: Added.
platform/chromium/css3/filters/effect-custom-parameters-expected.txt: Added.
platform/chromium/css3/filters/filter-property-computed-style-expected.txt: Added.
platform/chromium/css3/filters/filter-property-parsing-expected.txt: Added.
platform/chromium/css3/filters/filter-repaint-expected.txt: Added.
platform/chromium/test_expectations.txt:
platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
platform/qt/css3/filters/filter-region-expected.txt: Removed.
platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
platform/qt/css3/filters/nested-filter-expected.txt: Removed.
platform/qt/css3/filters/nested-filters-expected.txt: Removed.
platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.

4:48 PM Changeset in webkit [107637] by abarth@webkit.org

4 edits in trunk/Tools

Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
https://bugs.webkit.org/show_bug.cgi?id=78550

Reviewed by Eric Seidel.

Much of this code just forwards to the "host" port, which seems like a
reasonable thing to do.

Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.stop_helper):
(ChromiumAndroidPort):
(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_apache):
(ChromiumAndroidPort._path_to_apache_config_file):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_helper):
(ChromiumAndroidPort._path_to_image_diff):
(ChromiumAndroidPort._path_to_lighttpd):
(ChromiumAndroidPort._path_to_lighttpd_modules):
(ChromiumAndroidPort._path_to_lighttpd_php):
(ChromiumAndroidPort._path_to_wdiff):
(ChromiumAndroidPort._shut_down_http_server):

Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest):

Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase):
(PortTestCase.make_port):
(PortTestCase.test_default_worker_model):

4:42 PM Changeset in webkit [107636] by haraken@chromium.org

29 edits in trunk/Source/WebCore

Add [CustomToJSObject] to interfaces which have custom toJS() and toV8()
https://bugs.webkit.org/show_bug.cgi?id=78489

Reviewed by Adam Barth.

This is the final step to remove hard-coding from HasCustomToV8Implementation()
in CodeGeneratorV8.pm. This patch replaces [JSCustomToJS] with [CustomToJSObject]
for interfaces which have custom toJS() and custom toV8().

No tests. No change in behavior.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

bindings/scripts/test/TestTypedArray.idl:
css/CSSRule.idl:
css/CSSValue.idl:
css/StyleSheet.idl:
dom/Document.idl:
dom/Event.idl:
dom/Node.idl:
fileapi/Blob.idl:
fileapi/Entry.idl:
fileapi/EntrySync.idl:
html/HTMLCollection.idl:
html/ImageData.idl:
html/canvas/ArrayBufferView.idl:
html/canvas/DataView.idl:
html/canvas/Float32Array.idl:
html/canvas/Float64Array.idl:
html/canvas/Int16Array.idl:
html/canvas/Int32Array.idl:
html/canvas/Int8Array.idl:
html/canvas/Uint16Array.idl:
html/canvas/Uint32Array.idl:
html/canvas/Uint8Array.idl:
html/canvas/Uint8ClampedArray.idl:
storage/IDBAny.idl:
storage/IDBKey.idl:
svg/SVGPathSeg.idl:

4:27 PM Changeset in webkit [107635] by eae@chromium.org

7 edits in branches/subpixellayout/Source/WebCore

Changed ScrollView::contentsWidth/Height to int avoiding unnecessary type conversions.

4:16 PM Changeset in webkit [107634] by abarth@webkit.org

3 edits
1 add in trunk/Tools

chromium_android.py should implement "virtual" methods from ChromiumPort
https://bugs.webkit.org/show_bug.cgi?id=78545

Reviewed by Dirk Pranke.

This patch adds basic implementations that specialize a bunch of
functions from ChromiumPort.

Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort):
(ChromiumAndroidPort.init):
(ChromiumAndroidPort.default_child_processes):
(ChromiumAndroidPort.baseline_search_path):
(ChromiumAndroidPort.check_build):
(ChromiumAndroidPort.check_sys_deps):
(ChromiumAndroidPort.default_worker_model):
(ChromiumAndroidPort.test_expectations):
(ChromiumAndroidPort.start_http_server):
(ChromiumAndroidPort.stop_http_server):
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort.stop_helper):

4:09 PM Changeset in webkit [107633] by fischman@chromium.org

6 edits
1 delete in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaselining post skia change (from a long time ago).
http://code.google.com/p/chromium/issues/detail?id=105305

platform/chromium-gpu-linux/media/audio-repaint-expected.png: Removed.
platform/chromium-linux/media/audio-repaint-expected.png:
platform/chromium-mac-leopard/media/audio-repaint-expected.png:
platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
platform/chromium-win/media/audio-repaint-expected.png:
platform/chromium/test_expectations.txt:

4:06 PM Changeset in webkit [107632] by commit-queue@webkit.org

6 edits in trunk

Chrome crashes when attempting to add cue to track element
https://bugs.webkit.org/show_bug.cgi?id=77951

Patch by Arun Patole <bmf834@motorola.com> on 2012-02-13
Reviewed by Eric Carlson.

Source/WebCore:

Allocate text track's text track list of cues before using it.

html/TextTrack.cpp:

(WebCore::TextTrack::cues):
(WebCore::TextTrack::addCue):
(WebCore::TextTrack::removeCue): return if text track list of cues is not allocated.
(WebCore::TextTrack::ensureTextTrackCueList):Added.

html/TextTrack.h:

(TextTrack):

LayoutTests:

Updated add-remove-cue.html to handle adding a new cue to the text track created with addTextTrack.

media/track/track-add-remove-cue-expected.txt:
media/track/track-add-remove-cue.html:

3:57 PM Changeset in webkit [107631] by Lucas Forschler

2 edits in branches/safari-534.54-branch/Source/WebKit2

Rollout 105763.

3:55 PM Changeset in webkit [107630] by bashi@chromium.org

3 edits in trunk/LayoutTests

Fix font-face-weight-matching.html and font-face-synthetic-bold-italic.html
https://bugs.webkit.org/show_bug.cgi?id=78492

Fix the URL of Ahem.ttf.

Reviewed by Eric Seidel.

fast/css/font-face-synthetic-bold-italic.html:
fast/css/font-face-weight-matching.html:

3:54 PM Changeset in webkit [107629] by aestes@apple.com

2 edits in trunk/Source/WebCore

Fix the Windows build.

platform/PlatformPasteboard.h:

(PlatformPasteboard):

3:53 PM Changeset in webkit [107628] by Lucas Forschler

3 edits
3 copies in branches/safari-534.54-branch

Merged r107496.

3:46 PM Changeset in webkit [107627] by inferno@chromium.org

3 edits
2 adds in trunk

Crash with button in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78378

Reviewed by David Hyatt.

Source/WebCore:

Button creates an anonymous wrapper and expects that new children
be added to its m_inner anonymous block. However, splitBlock code
incorrectly creates column blocks directly under the button.

Test: fast/multicol/span/split-flow-anonymous-wrapper-crash.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containingColumnsBlock):
(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

fast/multicol/span/split-flow-anonymous-wrapper-crash-expected.txt: Added.
fast/multicol/span/split-flow-anonymous-wrapper-crash.html: Added.

3:39 PM Changeset in webkit [107626] by aestes@apple.com

3 edits in trunk/Source/WebKit/win

Fix the Windows build.

WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::createPasteboardStrategy):

WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

3:38 PM Changeset in webkit [107625] by mhahnenberg@apple.com

7 edits in trunk/Source/JavaScriptCore

Replace old strtod with new strtod
https://bugs.webkit.org/show_bug.cgi?id=68044

Reviewed by Geoffrey Garen.

parser/Lexer.cpp: Added template argument. This version allows junk after numbers.

(JSC::::lex):

runtime/JSGlobalObjectFunctions.cpp: Ditto.

(JSC::parseInt):
(JSC::jsStrDecimalLiteral):

runtime/LiteralParser.cpp: Ditto.

(JSC::::Lexer::lexNumber):

wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter.

It takes a template argument to allow clients to determine statically whether it should allow
junk after the numbers or not.
(WTF):
(WTF::strtod):

wtf/dtoa.h:

(WTF):

wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers.

(WTF::toDoubleType):

3:37 PM Changeset in webkit [107624] by ojan@chromium.org

7 edits
4 adds in trunk

nesting horizontal flexboxes is broken
https://bugs.webkit.org/show_bug.cgi?id=76867

Reviewed by David Hyatt.

Source/WebCore:

This is copied from RenderDeprecatedFlexibleBox and updated
for RenderFlexibleBox and to handle vertical writing mode.

Tests: css3/flexbox/preferred-widths-orthogonal.html

css3/flexbox/preferred-widths.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):

rendering/RenderFlexibleBox.cpp:

(WebCore::marginWidthForChild):
(WebCore):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):

rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

css3/flexbox/floated-flexbox-expected.txt:
css3/flexbox/line-wrapping.html:

The old results here were wrong because they wrapped the contents of each flex item.

css3/flexbox/preferred-widths-expected.txt: Added.
css3/flexbox/preferred-widths-orthogonal-expected.txt: Added.
css3/flexbox/preferred-widths-orthogonal.html: Added.
css3/flexbox/preferred-widths.html: Added.

3:35 PM Changeset in webkit [107623] by Lucas Forschler

4 edits in branches/safari-534.54-branch

Merge r106388.

3:28 PM Changeset in webkit [107622] by mihnea@adobe.com

7 edits
2 adds in trunk

Crash in RenderFlowThread::setRegionBoxesRegionStyle
https://bugs.webkit.org/show_bug.cgi?id=78298

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/set-box-style-in-region-crash.html

We have to make sure that anonymous block objects get their information in RenderFlowThread
removed properly.

dom/Node.cpp:

(WebCore::Node::diff):
Correct a comment.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseAnonymousBoxChild):
Remove the information for anonymous block from render flow thread.

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore):
(WebCore::RenderFlowThread::setRegionRangeForBox):
Do not set region range if the flow thread does not have regions.

rendering/RenderFlowThread.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):
Add an assert to make sure that after we remove an object, there is no remaining info
in any render flow thread.

LayoutTests:

fast/regions/set-box-style-in-region-crash-expected.txt: Added.
fast/regions/set-box-style-in-region-crash.html: Added.

3:22 PM Changeset in webkit [107621] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, skip http/tests/navigation/https-in-page-cache.html
because we don't enable the page cache in chromium.

platform/chromium/test_expectations.txt:

3:17 PM Changeset in webkit [107620] by abarth@webkit.org

4 edits
1 add in trunk/Tools

Add a skeleton ChromiumAndroid port to webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78543

Reviewed by Eric Seidel.

This patch just adds an empty ChromiumAndroid port object to webkitpy
and wires it up to the factory objects. An actual implementation will
follow.

Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):

Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.

(ChromiumAndroidPort):
(ChromiumAndroidPort.init):

Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory):

3:13 PM Changeset in webkit [107619] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, r107611 enabled layout tests in css3/filters,
but some are missing results.

platform/chromium/test_expectations.txt:

3:10 PM Changeset in webkit [107618] by thakis@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac.
https://bugs.webkit.org/show_bug.cgi?id=78246

This allows removing a bunch of code in chromium land (https://chromiumcodereview.appspot.com/9374020/),
and helps with the component build on mac (InitWebCoreSystemInterface is not an
exported function, and it shouldn't be).

Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm early-returns when it's
called twice, so it's safe to land this change, and remove the calls in client
code in a later CL.

Reviewed by Darin Fisher.

src/WebKit.cpp:

(WebKit::initializeWithoutV8):

3:07 PM Changeset in webkit [107617] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. We don't need to pass
platform/win/inverted-colors/non-composited.html.

platform/chromium/test_expectations.txt:

2:59 PM Changeset in webkit [107616] by fischman@chromium.org

17 edits
5 deletes in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaselining GPU results.

platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
platform/chromium-gpu-linux/media/controls-strict-expected.png:
platform/chromium-gpu-linux/media/controls-styling-expected.png:
platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png:
platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png:
platform/chromium-gpu-linux/media/video-transformed-expected.png:
platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
platform/chromium-gpu-linux/media/video-zoom-expected.png:
platform/chromium-gpu-mac/media/controls-after-reload-expected.txt: Removed.
platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
platform/chromium-gpu-mac/media/video-playing-and-pause-expected.txt: Removed.
platform/chromium-gpu-win/media/controls-strict-expected.txt: Removed.
platform/chromium-gpu-win/media/controls-styling-expected.txt: Removed.
platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Removed.
platform/chromium-gpu-win/media/video-controls-rendering-expected.png:

2:55 PM Changeset in webkit [107615] by tony@chromium.org

14 edits
4 deletes in trunk

Unreviewed, rolling out r107582.
http://trac.webkit.org/changeset/107582
https://bugs.webkit.org/show_bug.cgi?id=78349

Broke three inspector interactive_ui_tests

Source/WebCore:

English.lproj/localizedStrings.js:
inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):

inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._removeUISourceCode.get while):
(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):

inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

LayoutTests:

http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Removed.
inspector/debugger/scripts-combobox-file-selector-history.html: Removed.
inspector/debugger/scripts-file-selector-expected.txt: Removed.
inspector/debugger/scripts-file-selector.html: Removed.
inspector/debugger/scripts-panel-expected.txt:
inspector/debugger/scripts-panel.html:
inspector/debugger/scripts-sorting-expected.txt:
inspector/debugger/scripts-sorting.html:
inspector/debugger/source-frame-count.html:

2:39 PM Changeset in webkit [107614] by abarth@webkit.org

6 edits
1 add in trunk/Tools

NRWT's HTTP servers should support additional directories for resources
https://bugs.webkit.org/show_bug.cgi?id=78528

Reviewed by Eric Seidel.

This functionality will be used by the Chromium-Android port.

Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.start_http_server):

Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd.init):

Scripts/webkitpy/layout_tests/servers/http_server.py:

(Lighttpd.init):
(Lighttpd._prepare_config):

2:26 PM Changeset in webkit [107613] by inferno@chromium.org

4 edits
2 adds in trunk

Source/WebCore: Incorrect children placement in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78160

Reviewed by David Hyatt.

Test: fast/multicol/span/clone-before-after-content-crash.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone): no longer need to take care of making
children noninline (remove fix r105769) since moveChild functions take
care of adding the child properly if type of children differ. this
function just makes sure to set the right value of childrenInline property.
(WebCore::RenderBlock::splitBlocks): similar to moveChild functions below.
(WebCore::RenderBlock::moveChildTo): when child is fullRemoveInsert (across
different parents, e.g clones), we should use addChild function to make sure
it handles the case of different type of children between fromBlock and
toBlock correctly (specifically making children non-inline/wrapping inline
children under anonymous blocks.).
(WebCore::RenderBlock::moveChildrenTo):

rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::moveAllChildrenTo): Rename to->toBlock.
(WebCore::RenderBlock::moveChildrenTo): Rename to->toBlock.

LayoutTests: Incorrect children placement in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78160

Reviewed by David Hyatt.

fast/multicol/span/clone-before-after-content-crash-expected.txt: Added.
fast/multicol/span/clone-before-after-content-crash.html: Added.

2:25 PM Changeset in webkit [107612] by eae@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderInline.cpp

Fix rounding in RenderInline

2:22 PM Changeset in webkit [107611] by senorblanco@chromium.org

4 edits in trunk

Source/WebCore: [chromium] Implement Brightness and Contrast filters on composited
layers. Fix Saturation filter.
https://bugs.webkit.org/show_bug.cgi?id=78527

Reviewed by Kenneth Russell.

Will be covered by existing tests in css3/filters, when enabled.

platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):

LayoutTests: Unskip the css3/filters tests, so we can get some baselines off the
bots.
https://bugs.webkit.org/show_bug.cgi?id=78527

Reviewed by Kenneth Russell.

platform/chromium/test_expectations.txt:

2:21 PM Changeset in webkit [107610] by Lucas Forschler

4 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r107338.

2:17 PM Changeset in webkit [107609] by andersca@apple.com

2 edits in trunk/Source/WebCore

Turn off edge antialiasing for tile cache tile layers
https://bugs.webkit.org/show_bug.cgi?id=78533
<rdar://problem/10710798>

Reviewed by Sam Weinig.

platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::createTileLayer):

2:15 PM Changeset in webkit [107608] by enrica@apple.com

4 edits in trunk/Source

Build fix. Unreviewed.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj:

Source/WebKit/qt:

WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::createPasteboardStrategy):

2:12 PM Changeset in webkit [107607] by beidson@apple.com

3 edits
5 adds in trunk

<rdar://problem/7196487> and https://bugs.webkit.org/show_bug.cgi?id=26777 Add https pages to the page cache in some cases

Reviewed by Anders Carlsson.

Source/WebCore:

Test: http/tests/navigation/https-in-page-cache.html

history/PageCache.cpp:

(WebCore::PageCache::canCachePageContainingThisFrame): Allow HTTPS pages that do not specify cache-control: no-cache

or cache-control: no-store into the page cache. This will match Firefox's behavior for HTTPS in their bfcache.

LayoutTests:

http/tests/navigation/https-in-page-cache.html: Added.
http/tests/navigation/https-in-page-cache-expected.txt: Added.
http/tests/navigation/resources/https-in-page-cache-1.php: Added.
http/tests/navigation/resources/https-in-page-cache-2.php: Added.
http/tests/navigation/resources/https-in-page-cache-3.html: Added.

2:08 PM LayoutUnit edited by leviw@chromium.org

(diff)

2:04 PM Changeset in webkit [107606] by enrica@apple.com

17 edits
3 adds in trunk/Source

Source/WebCore: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
https://bugs.webkit.org/show_bug.cgi?id=78282

This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.

Reviewed by Anders Carlsson.

No new tests. No change in behavior, just code refactoring.

WebCore.exp.in: Added exported class PlatformPasteboard.
WebCore.xcodeproj/project.pbxproj: Added new files to the build.
editing/mac/EditorMac.mm:

(WebCore::Editor::writeSelectionToPasteboard): New method signature that doesn't use OBJ-C types.

platform/Pasteboard.h:

platform/PasteboardStrategy.h: Added PasteboardStrategy abstract class.
platform/PlatformPasteboard.h: Added. This class implements access to NSPasteboard.
platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::pasteboardStrategy): Added.

platform/mac/DragDataMac.mm:

(WebCore::DragData::canSmartReplace):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::asURL):

platform/mac/PasteboardMac.mm:

(WebCore::selectionPasteboardTypes): Changed to use Vector<String> instead of NSArray.
(WebCore::writableTypesForURL): Ditto.
(WebCore::createWritableTypesForImage): Ditto.
(WebCore::writableTypesForImage): Ditto.
(WebCore::Pasteboard::Pasteboard): Removed access to NSPasteboard.
(WebCore::Pasteboard::clear): Modified to use platformStrategies()->pasteboardStrategy().
(WebCore::Pasteboard::writeSelectionForTypes): Ditto.
(WebCore::Pasteboard::writePlainText): Ditto.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::writeURLForTypes): Ditto.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::writeFileWrapperAsRTFDAttachment): Ditto.
(WebCore::Pasteboard::writeImage): Ditto.
(WebCore::Pasteboard::writeClipboard): Ditto.
(WebCore::Pasteboard::canSmartReplace): Ditto.
(WebCore::Pasteboard::plainText): Ditto.
(WebCore::documentFragmentWithRTF): Ditto.
(WebCore::Pasteboard::documentFragment): Ditto.

platform/mac/PlatformPasteboardMac.mm: Added.

(WebCore::PlatformPasteboard::PlatformPasteboard):
(WebCore::PlatformPasteboard::getTypes):
(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::getPathnamesForType):
(WebCore::PlatformPasteboard::stringForType):
(WebCore::PlatformPasteboard::copy):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setBufferForType):
(WebCore::PlatformPasteboard::setPathnamesForType):
(WebCore::PlatformPasteboard::setStringForType):

Source/WebKit/mac: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.

https://bugs.webkit.org/show_bug.cgi?id=78282

This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.

Reviewed by Anders Carlsson.

WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface. (WebPlatformStrategies::createPasteboardStrategy): (WebPlatformStrategies::getTypes): (WebPlatformStrategies::bufferForType): (WebPlatformStrategies::getPathnamesForType): (WebPlatformStrategies::stringForType): (WebPlatformStrategies::copy): (WebPlatformStrategies::setTypes): (WebPlatformStrategies::setBufferForType): (WebPlatformStrategies::setPathnamesForType): (WebPlatformStrategies::setStringForType):

Source/WebKit/qt: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
https://bugs.webkit.org/show_bug.cgi?id=78282

Build fix. Unreviewed.

WebCoreSupport/PlatformStrategiesQt.cpp:

(WebPlatformStrategies::createPasteboardStrategy):

WebCoreSupport/PlatformStrategiesQt.h:

(PlatformStrategiesQt):

Source/WebKit2: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
https://bugs.webkit.org/show_bug.cgi?id=78282

Reviewed by Anders Carlsson.

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added implementation of PasteboardStrategy

interface.
(WebKit::WebPlatformStrategies::createPasteboardStrategy):
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):

WebProcess/WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.

2:02 PM Changeset in webkit [107605] by commit-queue@webkit.org

5 edits
2 adds in trunk

[CSS Regions] Inconsistent text selection behavior in regions
https://bugs.webkit.org/show_bug.cgi?id=76456

Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.

Source/WebCore:

Use the proper bounding rect when doing hit testing on flow threads.
Based on initial patch by Alexandru Chiculita.

Test: fast/regions/hit-test-region.html

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestRegion):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::nodeAtPoint):

LayoutTests:

fast/regions/hit-test-region-expected.txt: Added.
fast/regions/hit-test-region.html: Added.

2:01 PM Changeset in webkit [107604] by Lucas Forschler

13 edits in branches/safari-534.54-branch/Source/WebKit2

Rollout r104070 and r105100.

1:59 PM Changeset in webkit [107603] by aestes@apple.com

13 edits
9 adds in trunk

[Windows] Add API to enable inverted color drawing on a WebView
https://bugs.webkit.org/show_bug.cgi?id=77382

Reviewed by Adam Roben.

Source/WebCore:

Implement CACFLayerTreeHost::setShouldInvertColors(), which instructs
the layer tree host to render composited content with inverted colors.

Test: platform/win/inverted-colors/non-composited.html

platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::setShouldInvertColors):
(WebCore):

platform/graphics/ca/win/CACFLayerTreeHost.h:

(CACFLayerTreeHost):

platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Use

SOFT_LINK_OPTIONAL since WKCACFViewSetShouldInvertColors might not
exist in older versions of WebKitQuartzCoreAdditions.
(WebCore::WKCACFViewLayerTreeHost::setShouldInvertColors):
(WebCore):

platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:

(WKCACFViewLayerTreeHost):

Source/WebKit/win:

Add a new private WebPreference key called "WebKitShouldInvertColors"
and add private cover methods to get and set the preference. When this
preference changes on a WebPreference object, all WebViews listening to
that object will repaint to reflect the new value.

Interfaces/IWebPreferencesPrivate.idl: Add [setS|s]houldInvertColors()

cover methods for WebKitShouldInvertColorsPreferenceKey.

WebPreferenceKeysPrivate.h: Add WebKitShouldInvertColorsPreferenceKey.
WebPreferences.cpp:

(WebPreferences::shouldInvertColors):
(WebPreferences::setShouldInvertColors):

WebPreferences.h:

(WebPreferences):

WebView.cpp:

(WebView::setShouldInvertColors): If m_shouldInvertColors changes,
update the value on the WebView and in m_layerTreeHost, then repaint
the view.
(WebView::notifyPreferencesChanged):
(WebView::setAcceleratedCompositing): When creating a new layer tree
host, tell it whether it should be inverting colors.

WebView.h:

LayoutTests:

Add a test for non-composited inverted drawing. Testing the composited
path is blocked on <https://bugs.webkit.org/show_bug.cgi?id=78439>.

platform/win-wk2/platform/win/inverted-colors/non-composited-expected.png: Added.
platform/win-wk2/platform/win/inverted-colors/non-composited-expected.txt: Added.
platform/win/inverted-colors/non-composited-expected.png: Added.
platform/win/inverted-colors/non-composited-expected.txt: Added.
platform/win/inverted-colors/non-composited.html: Added.
platform/win/inverted-colors/resources/gradient.png: Added.

1:55 PM Changeset in webkit [107602] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Marking some debug tests as failing.

platform/chromium/test_expectations.txt:

1:45 PM Changeset in webkit [107601] by andersca@apple.com

12 edits in trunk/Source

The scrolling tree needs to know about the back forward state of the page
https://bugs.webkit.org/show_bug.cgi?id=78523
<rdar://problem/10756548>

Reviewed by Sam Weinig.

Source/WebCore:

In order to know if a page should rubber-band in the horizontal direction, the scrolling tree
needs to know about the back/forward state of the page.

WebCore.exp.in:

Export new symbols.

WebCore.xcodeproj/project.pbxproj:
page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Initialize m_canGoBack and m_canGoForward.

(WebCore::ScrollingTree::updateBackForwardState):
Update m_canGoBack and m_canGoForward.

page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::canGoBack):
(WebCore::ScrollingTree::canGoForward):
Add getters.

page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::shouldRubberBandInDirection):
Implement this, using canGoBack and canGoForward.

Source/WebKit2:

Pass the back/forward state in the WheelEvent message. This is pretty hacky but works well.

Platform/CoreIPC/HandleMessage.h:

(CoreIPC):
(CoreIPC::callMemberFunction):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::didReceiveEvent):

WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

WebProcess/WebPage/EventDispatcher.messages.in:

1:34 PM Changeset in webkit [107600] by fischman@chromium.org

5 edits
2 moves
1 add
1 delete in trunk/LayoutTests

chromium gpu draws scrollbars slightly differently in debug vs. release modes on
https://bugs.webkit.org/show_bug.cgi?id=58587

Unreviewed rebaseline (the scrollbar issue the bug is about was fixed previously).

platform/chromium-linux/media/video-controls-rendering-expected.png:
platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png: Added.
platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/video-controls-rendering-expected.txt.
platform/chromium-mac/media/video-controls-rendering-expected.png: Removed.
platform/chromium-win/media/video-controls-rendering-expected.png:
platform/chromium/test_expectations.txt:
platform/mac-future/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/mac/media/video-controls-rendering-expected.txt.

1:24 PM Changeset in webkit [107599] by mitz@apple.com

2 edits in trunk/Source/WebKit2

WebKit2 build emits a warning about not stripping code-signed PluginProcess.app when copying it into the framework
https://bugs.webkit.org/show_bug.cgi?id=78451

Reviewed by Sam Weinig.

Configurations/Base.xcconfig: Set COPY_PHASE_STRIP to NO.

1:17 PM Changeset in webkit [107598] by fischman@chromium.org

73 edits
3 copies
8 moves
7 adds
3 deletes in trunk/LayoutTests

Rebaseline media layouttests following keyframe addition to test.ogv
https://bugs.webkit.org/show_bug.cgi?id=78367

Unreviewed chromium rebaselining.

platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
platform/chromium-gpu-mac/media/controls-after-reload-expected.txt: Added.
platform/chromium-gpu-mac/media/controls-strict-expected.png:
platform/chromium-gpu-mac/media/controls-styling-expected.png:
platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png:
platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
platform/chromium-gpu-mac/media/video-layer-crash-expected.png:
platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png:
platform/chromium-gpu-mac/media/video-playing-and-pause-expected.txt: Added.
platform/chromium-gpu-mac/media/video-transformed-expected.png:
platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
platform/chromium-gpu-mac/media/video-zoom-expected.png:
platform/chromium-gpu-win/media/controls-after-reload-expected.png:
platform/chromium-gpu-win/media/controls-strict-expected.png:
platform/chromium-gpu-win/media/controls-strict-expected.txt: Copied from LayoutTests/platform/chromium/media/controls-strict-expected.txt.
platform/chromium-gpu-win/media/controls-styling-expected.png:
platform/chromium-gpu-win/media/controls-styling-expected.txt: Copied from LayoutTests/platform/chromium/media/controls-styling-expected.txt.
platform/chromium-gpu-win/media/controls-without-preload-expected.png:
platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Copied from LayoutTests/platform/chromium/media/controls-without-preload-expected.txt.
platform/chromium-gpu-win/media/video-aspect-ratio-expected.png:
platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
platform/chromium-gpu-win/media/video-display-toggle-expected.png:
platform/chromium-gpu-win/media/video-layer-crash-expected.png:
platform/chromium-gpu-win/media/video-playing-and-pause-expected.png:
platform/chromium-gpu-win/media/video-transformed-expected.png:
platform/chromium-gpu-win/media/video-volume-slider-expected.png:
platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
platform/chromium-gpu-win/media/video-zoom-expected.png:
platform/chromium-linux-x86/media/video-display-toggle-expected.png: Added.
platform/chromium-linux/media/controls-after-reload-expected.png:
platform/chromium-linux/media/controls-strict-expected.png:
platform/chromium-linux/media/controls-styling-expected.png:
platform/chromium-linux/media/controls-without-preload-expected.png:
platform/chromium-linux/media/video-aspect-ratio-expected.png:
platform/chromium-linux/media/video-display-toggle-expected.png:
platform/chromium-linux/media/video-layer-crash-expected.png:
platform/chromium-linux/media/video-playing-and-pause-expected.png:
platform/chromium-linux/media/video-transformed-expected.png:
platform/chromium-linux/media/video-volume-slider-expected.png:
platform/chromium-linux/media/video-zoom-controls-expected.png:
platform/chromium-linux/media/video-zoom-expected.png:
platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
platform/chromium-mac-leopard/media/controls-strict-expected.png:
platform/chromium-mac-leopard/media/controls-styling-expected.png:
platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
platform/chromium-mac-leopard/media/video-aspect-ratio-expected.png:
platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
platform/chromium-mac-leopard/media/video-layer-crash-expected.png:
platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
platform/chromium-mac-leopard/media/video-transformed-expected.png:
platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
platform/chromium-mac-leopard/media/video-zoom-expected.png:
platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
platform/chromium-mac-snowleopard/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-after-reload-expected.txt.
platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
platform/chromium-mac-snowleopard/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-strict-expected.txt.
platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
platform/chromium-mac-snowleopard/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-styling-expected.txt.
platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
platform/chromium-mac-snowleopard/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-without-preload-expected.txt.
platform/chromium-mac-snowleopard/media/video-aspect-ratio-expected.png: Added.
platform/chromium-mac-snowleopard/media/video-canvas-alpha-expected.png: Added.
platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
platform/chromium-mac-snowleopard/media/video-layer-crash-expected.png:
platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-playing-and-pause-expected.txt.
platform/chromium-mac-snowleopard/media/video-transformed-expected.png:
platform/chromium-mac-snowleopard/media/video-volume-slider-expected.png:
platform/chromium-mac-snowleopard/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-volume-slider-expected.txt.
platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.png:
platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-zoom-controls-expected.txt.
platform/chromium-mac-snowleopard/media/video-zoom-expected.png: Added.
platform/chromium-mac/media/video-aspect-ratio-expected.png: Removed.
platform/chromium-mac/media/video-canvas-alpha-expected.png: Removed.
platform/chromium-mac/media/video-zoom-expected.png: Removed.
platform/chromium-win/media/controls-after-reload-expected.png:
platform/chromium-win/media/controls-strict-expected.png:
platform/chromium-win/media/controls-styling-expected.png:
platform/chromium-win/media/controls-without-preload-expected.png:
platform/chromium-win/media/video-aspect-ratio-expected.png:
platform/chromium-win/media/video-canvas-alpha-expected.png:
platform/chromium-win/media/video-display-toggle-expected.png:
platform/chromium-win/media/video-layer-crash-expected.png:
platform/chromium-win/media/video-playing-and-pause-expected.png:
platform/chromium-win/media/video-transformed-expected.png:
platform/chromium-win/media/video-volume-slider-expected.png:
platform/chromium-win/media/video-zoom-controls-expected.png:
platform/chromium-win/media/video-zoom-expected.png:
platform/chromium/test_expectations.txt:
platform/mac-future/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/mac/media/controls-strict-expected.txt.

1:16 PM Changeset in webkit [107597] by leviw@chromium.org

4 edits in branches/subpixellayout/Source/WebCore

Renaming convertToRoundedLayerCoords to convertToPixelSnappedLayerCoords, which better describes what's being done. Also, adding const to AppUnit's abs, round, ceil, and floor methods.

1:07 PM Changeset in webkit [107596] by beidson@apple.com

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=78520 Cleanup PageCache::canCachePageContainingThisFrame readability

Reviewed by Anders Carlsson.

No new tests. (Code cleanup, no change in behavior)

history/PageCache.cpp:

(WebCore::PageCache::canCachePageContainingThisFrame): Store three commonly

getter-accessed variables in local variables for readability.

12:57 PM Changeset in webkit [107595] by weinig@apple.com

8 edits
1 add in trunk/Source/JavaScriptCore

Move JSC related assertions out of Assertions.h and into their own header
https://bugs.webkit.org/show_bug.cgi?id=78508

Reviewed by Gavin Barraclough.

GNUmakefile.list.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:

Add GCAssertions.h

heap/GCAssertions.h: Added.

Move assertions here.

runtime/WriteBarrier.h:

Add #include of GCAssertions.h

wtf/Assertions.h:

Remove JSC related assertions.

wtf/Compiler.h:

Add compiler check for has_trivial_destructor.

12:31 PM Changeset in webkit [107594] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Update MIPS patchOffsetGetByIdSlowCaseCall
https://bugs.webkit.org/show_bug.cgi?id=78392

Patch by Chao-ying Fu <fu@mips.com> on 2012-02-13
Reviewed by Gavin Barraclough.

jit/JIT.h:

(JIT):

12:14 PM Changeset in webkit [107593] by timothy@apple.com

3 edits in trunk/Source/WebCore

Don't include a separator before the "Inspect Element" context menu item when the context menu is empty.

https://webkit.org/b/78312

Reviewed by Brian Weinstein.

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::addInspectElementItem): Check itemCount before appending the separator.

platform/gtk/ContextMenuGtk.cpp:

(WebCore::ContextMenu::itemCount): Added. Implement so this builds on GTK.

11:54 AM Changeset in webkit [107592] by Patrick Gansterer

3 edits in trunk/Source/WebCore

[WIN] Define HWND_MESSAGE if not done already
https://bugs.webkit.org/show_bug.cgi?id=78341

Reviewed by Adam Roben.

HWND_MESSAGE is not defined on WinCE.
Set it to 0 when not defined to avoid #ifdefs.

platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::Pasteboard):

platform/win/WindowsExtras.h:

(WebCore):

11:39 AM Changeset in webkit [107591] by fischman@chromium.org

2 edits in trunk/Tools

Add fischman as committer.

Unreviewed

Scripts/webkitpy/common/config/committers.py:

11:32 AM Changeset in webkit [107590] by rniwa@webkit.org

2 edits in trunk

Yet another perf-o-matic build fix. It turns out that a task of the same name can't be
queued for days after the first task is completed. So don't use it. Updating persistent
caches more often than necessary is better than never updating them.

Websites/webkit-perf.appspot.com/controller.py:

(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):

11:30 AM Changeset in webkit [107589] by Chris Fleizach

5 edits
2 adds in trunk

AX: <mark> element should be exposed through attributes
https://bugs.webkit.org/show_bug.cgi?id=75727

Reviewed by Beth Dakin.

Source/WebCore:

Exposes an attribute indicating that an element has highlighting through attributedStringForRange.
Also allows the search mechanism to find elements with this style.

Test: platform/mac/accessibility/attributed-string-includes-highlighting.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::hasHighlighting):

accessibility/AccessibilityObject.h:
accessibility/mac/WebAccessibilityObjectWrapper.mm:

(createAccessibilitySearchKeyMap):
(AXAttributeStringSetStyle):

LayoutTests:

platform/mac/accessibility/attributed-string-includes-highlighting-expected.txt: Added.
platform/mac/accessibility/attributed-string-includes-highlighting.html: Added.

11:23 AM Changeset in webkit [107588] by Chris Fleizach

4 edits
2 adds in trunk

AX: the web area should report that focus can be set to itself
https://bugs.webkit.org/show_bug.cgi?id=78272

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/webarea-can-set-focus.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::canSetFocusAttribute):

accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable):

Fixed erroneous comment.

LayoutTests:

platform/mac/accessibility/webarea-can-set-focus-expected.txt: Added.
platform/mac/accessibility/webarea-can-set-focus.html: Added.

11:05 AM Changeset in webkit [107587] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Remove obsolete #if from ThreadSpecific.h
https://bugs.webkit.org/show_bug.cgi?id=78485

Reviewed by Adam Roben.

Since alle platform use either pthread or Win32 for threading,
we can remove all PLATFORM() preprocessor statements.

wtf/ThreadSpecific.h:

(ThreadSpecific):

10:54 AM Changeset in webkit [107586] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/InlineFlowBox.cpp

We don't actually need to snap the top of inline flow boxes to pixel boundaries. This issue was solved upstream.

10:39 AM LayoutUnit edited by leviw@chromium.org

(diff)

10:08 AM Changeset in webkit [107585] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Port RunLoop to WinCE
https://bugs.webkit.org/show_bug.cgi?id=76781

Reviewed by Adam Roben.

platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::registerRunLoopMessageWindowClass):

10:06 AM Changeset in webkit [107584] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, update mac-snowleopard result. This matches
the Apple Mac (Lion) result except for minor antialias differences.

platform/chromium-mac-snowleopard/svg/custom/foreignObject-crash-on-hover-expected.png:

9:51 AM Changeset in webkit [107583] by jberlin@webkit.org

2 edits in trunk/Source/JavaScriptCore

Fix the Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

9:50 AM Changeset in webkit [107582] by vsevik@chromium.org

14 edits
1 copy
3 adds in trunk

Web Inspector: Make ScriptsNavigator default file selector.
https://bugs.webkit.org/show_bug.cgi?id=78349

Reviewed by Pavel Feldman.

Source/WebCore:

Moved ScriptsNavigator out of experiments.
Introduced new setting "useScriptsNavigator" with true as default value.
Updated scripts panel tests related to file selector.

Tests: inspector/debugger/scripts-combobox-file-selector-history.html

inspector/debugger/scripts-file-selector.html

English.lproj/localizedStrings.js:
inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):

inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):

inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

LayoutTests:

http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):
(initialize_DebuggerTest.):

inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Added.
inspector/debugger/scripts-combobox-file-selector-history.html: Added.
inspector/debugger/scripts-file-selector-expected.txt: Copied from LayoutTests/inspector/debugger/scripts-panel-expected.txt.
inspector/debugger/scripts-file-selector.html: Added.
inspector/debugger/scripts-panel-expected.txt:
inspector/debugger/scripts-panel.html:
inspector/debugger/scripts-sorting-expected.txt:
inspector/debugger/scripts-sorting.html:
inspector/debugger/source-frame-count.html:

9:47 AM Changeset in webkit [107581] by weinig@apple.com

3 edits in trunk/Source/JavaScriptCore

Use C11's _Static_assert for COMPILE_ASSERT if it is available
https://bugs.webkit.org/show_bug.cgi?id=78506

Rubber-stamped by Antti Koivisto.

Use C11's _Static_assert for COMPILE_ASSERT if it is available to give slightly
better error messages.

wtf/Assertions.h:

Use _Static_assert if it is available.

wtf/Compiler.h:

Add COMPILER_SUPPORTS support for _Static_assert when using the LLVM Compiler.

9:44 AM Changeset in webkit [107580] by kling@webkit.org

3 edits in trunk/Source/WebCore

Make HTMLTableCaptionElement inherit from HTMLElement.
<http://webkit.org/b/78505>

Reviewed by Antti Koivisto.

HTMLTableCaptionElement was already bypassing its base class (HTMLTablePartElement)
and calling up to HTMLElement in all its overrides. Just make it an HTMLElement
instead since it doesn't use anything from HTMLTablePartElement.
Remove parseAttribute() overload since it's no longer needed.

html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::HTMLTableCaptionElement):
(WebCore::HTMLTableCaptionElement::isPresentationAttribute):
(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):

html/HTMLTableCaptionElement.h:

9:37 AM Changeset in webkit [107579] by kling@webkit.org

3 edits in trunk/Source/WebCore

HTMLMarqueeElement: Don't cache presence of truespeed attribute.
<http://webkit.org/b/78483>

Reviewed by Antti Koivisto.

Out-of-line minimumDelay() and look up the "truespeed" attribute there instead
of caching the minimum delay in parseAttribute().
Remove HTMLMarqueeElement::parseAttribute() as it's no longer needed.

html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
(WebCore::HTMLMarqueeElement::minimumDelay):

html/HTMLMarqueeElement.h:

(HTMLMarqueeElement):

9:21 AM Changeset in webkit [107578] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new failing test.

platform/qt/Skipped:

9:18 AM Changeset in webkit [107577] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Windows build fix.

UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):

9:11 AM Changeset in webkit [107576] by caseq@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: [refactoring] factor common timeline UI state into TimelinePresentationModel
https://bugs.webkit.org/show_bug.cgi?id=78501

Reviewed by Pavel Feldman.

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
(WebInspector.TimelineOverviewPane.prototype.scrollWindow):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createTopPane):
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._createTimelineCategoryStatusBarCheckbox):
(WebInspector.TimelinePanel.prototype._onCategoryCheckboxClicked):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._updateBoundaries):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.get categories):
(WebInspector.TimelinePresentationModel.prototype.addCategory):
(WebInspector.TimelinePresentationModel.prototype.setWindowPosition):
(WebInspector.TimelinePresentationModel.prototype.setCategoryVisibility):

8:39 AM Changeset in webkit [107575] by commit-queue@webkit.org

8 edits
1 add in trunk

Use requestAnimationFrame callbacks to pump CSS animations
https://bugs.webkit.org/show_bug.cgi?id=64591

Patch by Joel Webber <jgw@google.com> on 2012-02-13
Reviewed by James Robinson.

No new tests needed (covered by tests in animations/*).

page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::updateAnimationTimer):
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):
(WebCore::AnimationControllerPrivate::animationFrameCallbackFired):
(WebCore::AnimationController::updateAnimations):
(WebCore::AnimationController::serviceAnimations):

page/animation/AnimationController.h:
page/animation/AnimationControllerPrivate.h:

8:29 AM Changeset in webkit [107574] by Patrick Gansterer

3 edits
1 add in trunk/Source/WebCore

Add WindowsExtras.h
https://bugs.webkit.org/show_bug.cgi?id=78340

Reviewed by Adam Roben.

Add a new file to share common code for Win32/WinCE differences.

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::PopupMenuWndProc):

platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::RunLoopWndProc):

platform/win/WindowsExtras.h: Added.

(WebCore):
(WebCore::getWindowPointer):
(WebCore::setWindowPointer):

7:54 AM Changeset in webkit [107573] by kling@webkit.org

2 edits in trunk/Source/WebCore

Don't mark element for style recalc when modifying its attribute style.
<http://webkit.org/b/78497>

Reviewed by Antti Koivisto.

StylePropertySet::setNeedsStyleRecalc() shouldn't do anything for attribute styles.
Their invalidation is handled exclusively by StyledElement::attributeChanged().
Elements with presentation attributes were being marked for style recalc twice,
once when the attribute changed, and again during attribute style update, below the
call to collectStyleForAttribute().

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setNeedsStyleRecalc):

7:10 AM Changeset in webkit [107572] by podivilov@chromium.org

3 edits in trunk/LayoutTests

Unreviewed, add new chromium baselines for font-face-multiple-faces.html.

platform/chromium-mac-snowleopard/fast/css/font-face-multiple-faces-expected.png:
platform/chromium-win/fast/css/font-face-multiple-faces-expected.png:

7:05 AM Changeset in webkit [107571] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

Manage ShareableBitmap object lifecycle properly, when QImage is created
using the shared data.
https://bugs.webkit.org/show_bug.cgi?id=77546

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-02-13
Reviewed by Simon Hausmann.

Shared/ShareableBitmap.h:

(ShareableBitmap):

Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createQImage):
(WebKit):
(WebKit::ShareableBitmap::releaseSharedMemoryData):

7:02 AM Changeset in webkit [107570] by caio.oliveira@openbossa.org

13 edits in trunk/Source/WebCore

Move attribute storage from NamedNodeMap to ElementAttributeData
https://bugs.webkit.org/show_bug.cgi?id=77674

Reviewed by Andreas Kling.

Move m_attributes vector from NamedNodeMap to ElementAttributeData. Make the
remaining callsites interact with ElementAttributeData if possible. The parsing
code is still interacting with NamedNodeMap, so some functions remained as
wrappers there. A next change will it use ElementAttributeData instead.

The code for DOM exported functions remained in NamedNodeMap. This implementation
should move to Element in a next change, too.

dom/Attr.h:

(Attr):

dom/Element.cpp:

(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributeMap):
(WebCore::Element::removeAttribute):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):

dom/Element.h:

(Element):
(WebCore::Element::ensureUpdatedAttributes):
(WebCore::Element::ensureAttributeData):
(WebCore):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):
These *AttributeData functions are the correct correct way for callers to touch
the details of attribute storage. The "updated" variants will update invalid
attributes before return.

(WebCore::Element::setAttributesFromElement):

dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::~ElementAttributeData):
(WebCore):
(WebCore::ElementAttributeData::ensureInlineStyleDecl):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::detachAttributesFromElement):
(WebCore::ElementAttributeData::copyAttributesToVector):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::setAttributes): Make use of the assumption that
this will only be called with a valid Element, since the only call site is an
Element method.
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute): Make use of the assumption
this will only be called with a valid Element, since the only call site return
early if there's no Element.

dom/ElementAttributeData.h:

(ElementAttributeData):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):

dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::item):
(WebCore::NamedNodeMap::detachFromElement):

dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::length):
(WebCore::NamedNodeMap::isEmpty):
(WebCore::NamedNodeMap::attributeItem):
(WebCore::NamedNodeMap::getAttributeItem):
(WebCore::NamedNodeMap::getAttributeItemIndex):
(WebCore::NamedNodeMap::shrinkToLength):
(WebCore::NamedNodeMap::reserveInitialCapacity):
(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):
(NamedNodeMap):

dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

dom/StyledElement.h:

(WebCore::StyledElement::ensureInlineStyleDecl):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

svg/properties/SVGAnimatedPropertySynchronizer.h:
xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

6:50 AM Changeset in webkit [107569] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: wrong percent calculations for empty snapshot.
https://bugs.webkit.org/show_bug.cgi?id=78329

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-13
Reviewed by Yury Semikhatsky.

inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):

6:33 AM Changeset in webkit [107568] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Web Inspector: add class filter to heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=78362

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-13
Reviewed by Yury Semikhatsky.

inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype.insertChild):

inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._nameFilterChanged):
(WebInspector.DetailedHeapshotView.prototype._changeNameFilter):

inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .constructors-view-grid):
(.detailed-heapshot-view .constructors-view-toolbar):
(.detailed-heapshot-view .constructors-view-toolbar input.constructors-view-filter):

6:27 AM Changeset in webkit [107567] by vsevik@chromium.org

7 edits in trunk

Web Inspector: In Inspector.json PropertyDescriptor.writable should be declared optional
https://bugs.webkit.org/show_bug.cgi?id=77917

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-13
Reviewed by Pavel Feldman.

Source/WebCore:

Property descriptor is fixed in Inspector.json. Also retroactively in
0.1 and 1.0.
Injected script in instructed to never return null property values.

inspector/InjectedScriptSource.js:

(.):

inspector/Inspector-0.1.json:
inspector/Inspector-1.0.json:
inspector/Inspector.json:

LayoutTests:

"Undefined" getter and setter is now visible.

inspector/runtime/runtime-getProperties-expected.txt:

6:27 AM WebKitIDL edited by haraken@chromium.org

(diff)

6:24 AM WebKitIDL edited by haraken@chromium.org

(diff)

6:18 AM Changeset in webkit [107566] by mario@webkit.org

6 edits in trunk/Source

[GTK] Add GSList to the list of GObject types in GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=78487

Reviewed by Philippe Normand.

Source/JavaScriptCore:

Handle the GSList type in GOwnPtr, by calling g_slist_free in the
implementation of the freeOwnedGPtr template function.

wtf/gobject/GOwnPtr.cpp:

(WTF::GSList):
(WTF):

wtf/gobject/GOwnPtr.h:

(WTF):

wtf/gobject/GTypedefs.h:

Source/WebKit/gtk:

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::runOpenPanel): Use GOwnPtr<GSList> for the
list of filenames returned by gtk_file_chooser_get_filenames().

6:16 AM Changeset in webkit [107565] by commit-queue@webkit.org

5 edits in trunk

[GTK] Revise configuration for MHTML
https://bugs.webkit.org/show_bug.cgi?id=78364

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-13
Reviewed by Gustavo Noronha Silva.

Added some lines to show checking messages, whether mhtml is enabled or not
during configuration and the configuration result for mhtml.
MHTML is a web page archive format used to combine resources
that are typically represented by external links (such as images, Flash animations,
Java applets, audio files) together with HTML code into a single file.
http://en.wikipedia.org/wiki/MHTML

configure.ac:

Source/WebCore:

Added mhtml directory and removed target files duplicated to build when enabling mhtml.
Archive.cpp, ArchiveFactory.cpp & their headers are included at the above line.
This duplication has caused build-break if mhtml is enabled.

No new tests, since no new features.

GNUmakefile.am:
GNUmakefile.list.am:

6:15 AM WebKitIDL edited by haraken@chromium.org

(diff)

5:59 AM Changeset in webkit [107564] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/test_expectations.txt: Mark fast/js/dfg-inline-function-dot-caller.html as slow in debug mode.

5:42 AM Changeset in webkit [107563] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2012-02-13 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, add "IMAGE" to two svg/carto.net tests expectations.

platform/chromium/test_expectations.txt:

5:30 AM Changeset in webkit [107562] by kubo@profusion.mobi

22 edits in trunk

[EFL] Drop support for the Curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=77874

Reviewed by Eric Seidel.

Nobody seems to be maintaining the Curl backend in WebCore, the
EFL port developers all seem to be using the Soup backend and the
port itself has many features which are only implemented for the
latter.

Source/cmake/OptionsEfl.cmake: Remove network backend selection

checks and unconditionally require Glib and Libsoup, bump the
required LibSoup version to the same one the GTK+ port looks for,
since we share the same network backend.

Source/JavaScriptCore:

wtf/PlatformEfl.cmake: Always build the gobject-dependent source

files.

Source/WebCore:

No new tests, just some dependency plumbing.

PlatformEfl.cmake: Build the glib/soup source files

unconditionally.

platform/efl/FileSystemEfl.cpp: Remove ENABLE(GLIB_SUPPORT) check.

Source/WebKit/efl:

CMakeListsEfl.txt: Unconditionally build soup-dependent files

and always add the glib/soup include directories and libraries.

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
Remove USE(SOUP) checks.

ewk/ewk_auth.cpp:

(ewk_auth_show_dialog_callback_set): Ditto.
(ewk_auth_credentials_set): Ditto.

ewk/ewk_cookies.cpp:

(ewk_cookies_file_set): Ditto.
(ewk_cookies_clear): Ditto.
(ewk_cookies_get_all): Ditto.
(ewk_cookies_cookie_del): Ditto.
(ewk_cookies_cookie_free): Ditto.
(ewk_cookies_policy_set): Ditto.
(ewk_cookies_policy_get): Ditto.

ewk/ewk_frame.cpp:

(ewk_frame_certificate_status_get): Ditto.

ewk/ewk_main.cpp:

(_ewk_init_body): Ditto.

ewk/ewk_network.cpp:

(ewk_network_proxy_uri_set): Ditto.
(ewk_network_proxy_uri_get): Ditto.
(ewk_network_tls_certificate_check_get): Ditto.
(ewk_network_tls_certificate_check_set): Ditto.
(ewk_network_tls_ca_certificates_path_get): Ditto.
(ewk_network_tls_ca_certificates_path_set): Ditto.
(ewk_network_default_soup_session_get): Ditto.

ewk/ewk_network.h: Update apidox for

ewk_network_default_soup_session_get() now that libsoup is the
only available backend.

Source/WebKit2:

PlatformEfl.cmake: Unconditionally build the glib/soup source

files and unconditionally add the required include directories and
libraries.

WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl): Remove USE(SOUP) check.

Tools:

DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup

and always add the required include directories.

EWebLauncher/CMakeLists.txt: Add the required glib/libsoup

include directories and link to them.

5:12 AM Changeset in webkit [107561] by pfeldman@chromium.org

6 edits
4 adds in trunk

Web Inspector: wrap settings selector text and adding a rule with undoable actions.
https://bugs.webkit.org/show_bug.cgi?id=78482

Reviewed by Yury Semikhatsky.

Source/WebCore:

Tests: inspector/styles/undo-add-new-rule.html

inspector/styles/undo-set-selector-text.html

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(InspectorCSSAgent::SetRuleSelectorAction):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::SetRuleSelectorAction):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::perform):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::undo):
(WebCore):
(InspectorCSSAgent::AddRuleAction):
(WebCore::InspectorCSSAgent::AddRuleAction::AddRuleAction):
(WebCore::InspectorCSSAgent::AddRuleAction::perform):
(WebCore::InspectorCSSAgent::AddRuleAction::undo):
(WebCore::InspectorCSSAgent::AddRuleAction::newRuleId):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::styleSheetChanged):

inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ruleSelector):
(WebCore):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):
(WebCore::InspectorStyleSheet::fireStyleSheetChanged):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

inspector/InspectorStyleSheet.h:

(InspectorStyleSheet):
(WebCore::InspectorStyleSheet::styleId):
(InspectorStyleSheetForInlineStyle):

LayoutTests:

inspector/styles/undo-add-new-rule-expected.txt: Added.
inspector/styles/undo-add-new-rule.html: Added.
inspector/styles/undo-set-selector-text-expected.txt: Added.
inspector/styles/undo-set-selector-text.html: Added.

4:45 AM Changeset in webkit [107560] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

platform/qt/Skipped:

4:45 AM Changeset in webkit [107559] by bashi@chromium.org

2 edits in trunk/Tools

[WebSocket] Update pywebsocket to 0.7.1
https://bugs.webkit.org/show_bug.cgi?id=78484

pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.

Reviewed by Kent Tamura.

Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pywebsocket):

4:15 AM Changeset in webkit [107558] by hayato@chromium.org

14 edits
1 move
1 add
1 delete in trunk/Source/WebCore

Rename names defined in ContentInclutionSelector to more intuitive names.
https://bugs.webkit.org/show_bug.cgi?id=78333

Reviewed by Hajime Morita.

This is just refactoring, renaming non-intuitive names to more intuitive names
so that they match the terms in the spec.

No tests. No change in behavior.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::insertionPoint):

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertionPointFor):
(WebCore::ShadowRoot::isSelectorActive):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::selector):
(WebCore::ShadowRoot::ensureSelector):

dom/ShadowRoot.h:

(WebCore):
(ShadowRoot):

html/shadow/ContentInclusionSelector.h: Removed.
html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):

html/shadow/HTMLContentElement.h:

(WebCore):
(WebCore::HTMLContentElement::selections):
(WebCore::HTMLContentElement::hasSelection):
(HTMLContentElement):

html/shadow/HTMLContentSelector.cpp: Renamed from Source/WebCore/html/shadow/ContentInclusionSelector.cpp.

(WebCore):
(WebCore::HTMLContentSeleciton::append):
(WebCore::HTMLContentSeleciton::unlink):
(WebCore::HTMLContentSelectionList::HTMLContentSelectionList):
(WebCore::HTMLContentSelectionList::~HTMLContentSelectionList):
(WebCore::HTMLContentSelectionList::find):
(WebCore::HTMLContentSelectionList::clear):
(WebCore::HTMLContentSelectionList::append):
(WebCore::HTMLContentSelector::HTMLContentSelector):
(WebCore::HTMLContentSelector::~HTMLContentSelector):
(WebCore::HTMLContentSelector::select):
(WebCore::HTMLContentSelector::unselect):
(WebCore::HTMLContentSelector::findFor):
(WebCore::HTMLContentSelector::didSelect):
(WebCore::HTMLContentSelector::willSelectOver):

html/shadow/HTMLContentSelector.h: Added.

(WebCore):
(HTMLContentSeleciton):
(WebCore::HTMLContentSeleciton::insertionPoint):
(WebCore::HTMLContentSeleciton::node):
(WebCore::HTMLContentSeleciton::next):
(WebCore::HTMLContentSeleciton::previous):
(WebCore::HTMLContentSeleciton::HTMLContentSeleciton):
(WebCore::HTMLContentSeleciton::create):
(HTMLContentSelectionList):
(WebCore::HTMLContentSelectionList::first):
(WebCore::HTMLContentSelectionList::last):
(WebCore::HTMLContentSelectionList::isEmpty):
(HTMLContentSelectionSet):
(WebCore::HTMLContentSelectionSet::add):
(WebCore::HTMLContentSelectionSet::remove):
(WebCore::HTMLContentSelectionSet::isEmpty):
(Translator):
(WebCore::HTMLContentSelectionSet::Translator::hash):
(WebCore::HTMLContentSelectionSet::Translator::equal):
(WebCore::HTMLContentSelectionSet::Hash::hash):
(WebCore::HTMLContentSelectionSet::Hash::equal):
(Hash):
(WebCore::HTMLContentSelectionSet::find):
(HTMLContentSelector):
(WebCore::HTMLContentSelector::hasCandidates):

testing/Internals.cpp:

(WebCore::Internals::includerFor):

4:08 AM Changeset in webkit [107557] by pfeldman@chromium.org

6 edits in branches/chromium/1025

Merge 107242 - Web Inspector: fix setOuterHTML for the case that adds / removes duplicate.
https://bugs.webkit.org/show_bug.cgi?id=78235

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/DOMEditor.cpp:

(WebCore::DOMEditor::diff):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore):
(WebCore::nodeName):
(WebCore::DOMEditor::dumpMap):

inspector/DOMEditor.h:

(DOMEditor):

LayoutTests:

inspector/elements/set-outer-html-2-expected.txt:
inspector/elements/set-outer-html-2.html:
inspector/elements/set-outer-html-expected.txt:
inspector/elements/set-outer-html.html:

TBR=pfeldman@chromium.org
BUG=113388
Review URL: https://chromiumcodereview.appspot.com/9389003

4:02 AM WebKitIDL edited by haraken@chromium.org

(diff)

4:00 AM RegressionTestResearch edited by Csaba Osztrogonác

(diff)

4:00 AM WebKitIDL edited by haraken@chromium.org

(diff)

3:57 AM WebKitIDL edited by haraken@chromium.org

(diff)

3:57 AM Changeset in webkit [107556] by noam.rosenthal@nokia.com

2 edits in trunk/Source/WebCore

[Texmap] morphing-cubes animation appears too close when clicking the button
https://bugs.webkit.org/show_bug.cgi?id=78476

Fixed bug in TextureMapperAnimation that made transform animations that go to/from identity
to not work.

Reviewed by Simon Hausmann.

No behavior changes.

platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore::applyTransformAnimation):

3:43 AM RegressionTestResearch created by beszedes@inf.u-szeged.hu

Adding regression test improvement pages

3:40 AM Top100Invariant created by beszedes@inf.u-szeged.hu

Adding regression test improvement pages

3:39 AM SelectiveTestEWS created by beszedes@inf.u-szeged.hu

3:36 AM SelectiveTestBuildBot created by beszedes@inf.u-szeged.hu

Adding regression test improvement pages

3:30 AM Improving Regression Tests edited by beszedes@inf.u-szeged.hu

(diff)

3:27 AM Improving Regression Tests created by beszedes@inf.u-szeged.hu

Adding regression test improvement pages

3:22 AM WikiStart edited by beszedes@inf.u-szeged.hu

Adding regression test improvement pages (diff)

3:01 AM Changeset in webkit [107555] by commit-queue@webkit.org

28 edits in trunk/Source

[Forms] Use enum instead of bool for HTMLInputElement::setValue
https://bugs.webkit.org/show_bug.cgi?id=75217

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-02-13
Reviewed by Kent Tamura.

Source/WebCore:

Use TextFieldEventBehavior enum instead of sendChangeEvent bool
parameter for HTMLInputElement::setValue method. This new enum
parameter will be extended to dispatch input and change events
when user agent populates input field as specified in
"Common events behavior" of HTML5 standard.

This patch is required for fixing bug 75067 "[Forms] Spin buttons
of number input type should fire both input and change event."

No new tests. Existing tests cover this patch.

html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::setValue):

html/BaseButtonInputType.h:
html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::setValue):

html/BaseCheckableInputType.h:
html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::setValueAsNumber):

html/BaseDateAndTimeInputType.h:
html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::willDispatchClick):

html/ColorInputType.cpp:

(WebCore::ColorInputType::setValue):

html/ColorInputType.h:
html/FileInputType.cpp:

(WebCore::FileInputType::setValue):

html/FileInputType.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::applyStep):
(WebCore::HTMLInputElement::stepUp):
(WebCore::HTMLInputElement::stepDown):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::setValueForUser):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueInternal):
(WebCore::HTMLInputElement::setValueAsNumber):
(WebCore::HTMLInputElement::stepUpFromRenderer):

html/HTMLInputElement.h:
html/HTMLTextFormControlElement.h:
html/HiddenInputType.cpp:

(WebCore::HiddenInputType::setValue):

html/HiddenInputType.h:
html/InputType.cpp:

(WebCore::InputType::setValueAsNumber):
(WebCore::InputType::setValue):

html/InputType.h:
html/NumberInputType.cpp:

(WebCore::NumberInputType::setValueAsNumber):

html/NumberInputType.h:
html/RadioInputType.cpp:

(WebCore::RadioInputType::willDispatchClick):

html/RangeInputType.cpp:

(WebCore::RangeInputType::setValueAsNumber):
(WebCore::RangeInputType::handleKeydownEvent):
(WebCore::RangeInputType::setValue):

html/RangeInputType.h:
html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue):

html/TextFieldInputType.h:

Source/WebKit/chromium:

src/WebInputElement.cpp:

(WebKit::WebInputElement::setValue): Use enum for HTMLInputElement::setValue

2:36 AM Changeset in webkit [107554] by kling@webkit.org

67 edits in trunk/Source/WebCore

Move attribute style invalidation to attributeChanged().
<http://webkit.org/b/78461>

Reviewed by Antti Koivisto.

Moved attribute style invalidation out of the parseAttribute() overloads
and added an "isPresentationAttribute(Attribute*) virtual to StyledElement.
Returning true for a given Attribute will cause attribute style invalidation
when that attribute passes through attributeChanged().

Removed a couple of parseAttribute() overloads whose only remaining purpose
was invalidating attribute style.

For form elements that deliberately don't map the "align" attribute, added
short-circuits in isPresentationAttribute instead of falling back to the
respective base class (which may othweise then map "align")

dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

dom/StyledElement.h:

(WebCore::StyledElement::isPresentationAttribute):

html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::isPresentationAttribute):

html/HTMLBRElement.h:
html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::isPresentationAttribute):
(WebCore::HTMLBodyElement::collectStyleForAttribute):
(WebCore::HTMLBodyElement::parseAttribute):

html/HTMLBodyElement.h:
html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::isPresentationAttribute):
(WebCore::HTMLButtonElement::parseAttribute):

html/HTMLButtonElement.h:
html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::isPresentationAttribute):

html/HTMLDivElement.h:
html/HTMLElement.cpp:

(WebCore::HTMLElement::isPresentationAttribute):
(WebCore::HTMLElement::parseAttribute):

html/HTMLElement.h:
html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::isPresentationAttribute):
(WebCore::HTMLEmbedElement::parseAttribute):

html/HTMLEmbedElement.h:
html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::isPresentationAttribute):

html/HTMLFontElement.h:
html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::isPresentationAttribute):
(WebCore::HTMLFrameSetElement::parseAttribute):

html/HTMLFrameSetElement.h:
html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::isPresentationAttribute):
(WebCore::HTMLHRElement::collectStyleForAttribute):

html/HTMLHRElement.h:
html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::isPresentationAttribute):
(WebCore::HTMLIFrameElement::collectStyleForAttribute):
(WebCore::HTMLIFrameElement::parseAttribute):

html/HTMLIFrameElement.h:
html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::isPresentationAttribute):
(WebCore::HTMLImageElement::collectStyleForAttribute):
(WebCore::HTMLImageElement::parseAttribute):

html/HTMLImageElement.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isPresentationAttribute):
(WebCore::HTMLInputElement::collectStyleForAttribute):
(WebCore::HTMLInputElement::parseAttribute):

html/HTMLInputElement.h:
html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::isPresentationAttribute):
(WebCore::HTMLLIElement::parseAttribute):

html/HTMLLIElement.h:
html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::isPresentationAttribute):
(WebCore::HTMLMarqueeElement::collectStyleForAttribute):
(WebCore::HTMLMarqueeElement::parseAttribute):

html/HTMLMarqueeElement.h:
html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::isPresentationAttribute):
(WebCore::HTMLOListElement::parseAttribute):

html/HTMLOListElement.h:
html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::isPresentationAttribute):
(WebCore::HTMLObjectElement::parseAttribute):

html/HTMLObjectElement.h:
html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::isPresentationAttribute):

html/HTMLParagraphElement.h:
html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::isPresentationAttribute):
(WebCore::HTMLPlugInElement::collectStyleForAttribute):

html/HTMLPlugInElement.h:
html/HTMLPreElement.cpp:

(WebCore::HTMLPreElement::isPresentationAttribute):
(WebCore::HTMLPreElement::collectStyleForAttribute):

html/HTMLPreElement.h:
html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::isPresentationAttribute):
(WebCore::HTMLSelectElement::parseAttribute):

html/HTMLSelectElement.h:
html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::isPresentationAttribute):
(WebCore::HTMLTableCaptionElement::parseAttribute):

html/HTMLTableCaptionElement.h:
html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::isPresentationAttribute):
(WebCore::HTMLTableCellElement::collectStyleForAttribute):
(WebCore::HTMLTableCellElement::parseAttribute):

html/HTMLTableCellElement.h:
html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::isPresentationAttribute):
(WebCore::HTMLTableColElement::parseAttribute):

html/HTMLTableColElement.h:
html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::isPresentationAttribute):
(WebCore::HTMLTableElement::parseAttribute):

html/HTMLTableElement.h:
html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::isPresentationAttribute):
(WebCore::HTMLTablePartElement::collectStyleForAttribute):

html/HTMLTablePartElement.h:
html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::isPresentationAttribute):
(WebCore::HTMLTextAreaElement::parseAttribute):

html/HTMLTextAreaElement.h:
html/HTMLUListElement.cpp:

(WebCore::HTMLUListElement::isPresentationAttribute):
(WebCore::HTMLUListElement::collectStyleForAttribute):

html/HTMLUListElement.h:
html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::isPresentationAttribute):
(WebCore::HTMLVideoElement::parseAttribute):

html/HTMLVideoElement.h:
mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isPresentationAttribute):
(WebCore::MathMLElement::collectStyleForAttribute):

mathml/MathMLElement.h:
svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::isPresentationAttribute):
(WebCore::SVGImageElement::parseAttribute):

svg/SVGImageElement.h:
svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::isPresentationAttribute):
(WebCore::SVGStyledElement::parseAttribute):

svg/SVGStyledElement.h:
svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::isPresentationAttribute):
(WebCore::SVGTextContentElement::parseAttribute):

svg/SVGTextContentElement.h:

2:24 AM Changeset in webkit [107553] by haraken@chromium.org

5 edits in trunk/Source/WebCore

Add [JSCustomToJSObject] IDL attribute to interfaces that have
custom toJS() but do not have custom toV8()
https://bugs.webkit.org/show_bug.cgi?id=78466

Reviewed by Adam Barth.

This is the second step to remove hard-coding in HasCustomToV8Implementation()
in CodeGeneratorV8.pm. This patch replaces [JSCustomToJS] with [JSCustomToJSObject]
for interfaces which have custom toJS() but do not have custom toV8().

No tests. No change in behavior.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/CodeGeneratorV8.pm:

(HasCustomToV8Implementation): I found that AbstractWorker and CanvasRenderingContext
are the only IDL files to which I need to add [JSCustomToJSObject].
Other IDL files which had been listed here do not have [JSCustomToJS].

html/canvas/CanvasRenderingContext.idl:
workers/AbstractWorker.idl:

2:23 AM Changeset in webkit [107552] by Csaba Osztrogonác

4 edits in trunk/LayoutTests

Unreviewed gardening after r107544.

fast/dom/wrapper-classes-expected.txt:
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
platform/qt/fast/dom/prototype-inheritance-2-expected.txt:

2:09 AM Changeset in webkit [107551] by kling@webkit.org

2 edits in trunk/Source/WebCore

Avoid unnecessary work when evaluating style sharing candidates.
<http://webkit.org/b/78220>

Reviewed by Antti Koivisto.

Do the cheap checks (bitfields, pointers) before calling virtuals and doing hash lookups.
Remove comparison of attributes that are reflected in the attribute styles (cellpadding.)
Moved comparison of "type" and "readonly" attributes into the more specific
canShareStyleWithControl() since they are only relevant for input elements. Don't bother
calling isFormControlElement() on both elements as they already have the same tagQName().

Altogether this knocks off ~8ms worth of samples per cycle of the "Moz" page cycler test.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::isCommonAttributeSelectorAttribute):

2:08 AM Changeset in webkit [107550] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2012-02-13 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark dfg-put-by-id-prototype-check.html as failing in chromium (new test).

platform/chromium/test_expectations.txt:

2:08 AM Changeset in webkit [107549] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r107485.

bytecode/PolymorphicPutByIdList.cpp:

1:47 AM Changeset in webkit [107548] by commit-queue@webkit.org

5 edits
2 adds in trunk

<summary> is not keyboard accessible.
https://bugs.webkit.org/show_bug.cgi?id=75478

Patch by Arko Saha <arko@motorola.com> on 2012-02-13
Reviewed by Hajime Morita.

Source/WebCore:

Toggle the content of <details> element on pressing Enter or Spacebar
key on a focused <summary> element.

Test: fast/html/details-keyboard-show-hide.html

html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::supportsFocus):
(WebCore):
(WebCore::HTMLSummaryElement::defaultEventHandler):

html/HTMLSummaryElement.h:

(HTMLSummaryElement):

LayoutTests:

fast/html/details-keyboard-show-hide-expected.txt: Added.
fast/html/details-keyboard-show-hide.html: Added.
platform/chromium/test_expectations.txt: <summary> is now focusable and clicking

it draws a focus ring. So we need to rebase failed test cases.

1:37 AM Changeset in webkit [107547] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] REGRESSION(r107518): It broke many tests
https://bugs.webkit.org/show_bug.cgi?id=78471

platform/qt/Skipped: Unreviewed gardening, skip failing tests.

1:31 AM Changeset in webkit [107546] by podivilov@chromium.org

1 edit
1 add in trunk/LayoutTests

2012-02-13 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, add new baseline for font-face-default-font.html on linux.

platform/chromium-linux/fast/css/font-face-default-font-expected.txt: Added.

1:30 AM Changeset in webkit [107545] by noel.gordon@gmail.com

2 edits in trunk/LayoutTests

Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Preparation for a bunch of rebaselines.

platform/chromium/test_expectations.txt: unskip tests to allow bots to cycle and

produce the new JPEG image results.

1:28 AM Changeset in webkit [107544] by barraclough@apple.com

29 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=78434
Unreviewed - temporarily reverting r107498 will I fix a couple of testcases.

Source/JavaScriptCore:

parser/Parser.cpp:

(JSC::::parseFunctionInfo):

runtime/ClassInfo.h:

(MethodTable):
(JSC):

runtime/JSCell.cpp:

(JSC):

runtime/JSCell.h:

(JSCell):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

runtime/JSGlobalObjectFunctions.cpp:

(JSC):

runtime/JSGlobalObjectFunctions.h:

(JSC):

runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::defineOwnProperty):

runtime/JSObject.h:

(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSValue::get):

runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

runtime/JSValue.h:

(JSValue):

runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):

runtime/Structure.cpp:

(JSC::Structure::Structure):

runtime/Structure.h:

(JSC::Structure::setHasGetterSetterProperties):
(Structure):

Source/WebCore:

bindings/js/JSDOMWindowBase.cpp:

(WebCore):

bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

LayoutTests:

fast/js/Object-getOwnPropertyNames-expected.txt:
fast/js/cyclic-prototypes-expected.txt:
fast/js/parser-syntax-check-expected.txt:
fast/js/preventExtensions-expected.txt:
fast/js/prototypes-expected.txt:
fast/js/script-tests/Object-getOwnPropertyNames.js:
fast/js/script-tests/cyclic-prototypes.js:
fast/js/script-tests/parser-syntax-check.js:
fast/js/script-tests/preventExtensions.js:
fast/js/script-tests/prototypes.js:

1:22 AM WebKitIDL edited by haraken@chromium.org

(diff)

1:01 AM Changeset in webkit [107543] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2012-02-13 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, remove missing test from expectations.

platform/chromium/test_expectations.txt:

12:53 AM Changeset in webkit [107542] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: get rid of cycles in containment view of an object.
https://bugs.webkit.org/show_bug.cgi?id=78462

Reviewed by Yury Semikhatsky.

inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

12:48 AM WebKitIDL edited by haraken@chromium.org

(diff)

12:36 AM WebKitIDL edited by haraken@chromium.org

(diff)

12:18 AM Changeset in webkit [107541] by abarth@webkit.org

6 edits
3 adds in trunk/Source/WebCore

Remove ENABLE(MEDIA_STREAM) from Navigator.h
https://bugs.webkit.org/show_bug.cgi?id=78467

Reviewed by Kentaro Hara.

Navigator.webkitGetUser media doesn't really have anything to do with
Navigator.cpp. This patch moves it into the mediastream directory and
removes the ENABLE(MEDIA_STREAM) ifdefs in Navigator.h and
Navigator.cpp.

GNUmakefile.list.am:
WebCore.gypi:
mediastream/NavigatorMediaStream.cpp: Added.

(WebCore):
(WebCore::NavigatorMediaStream::NavigatorMediaStream):
(WebCore::NavigatorMediaStream::~NavigatorMediaStream):
(WebCore::NavigatorMediaStream::webkitGetUserMedia):

mediastream/NavigatorMediaStream.h: Added.

(WebCore):
(NavigatorMediaStream):

mediastream/NavigatorMediaStream.idl: Added.
page/Navigator.cpp:

(WebCore):

page/Navigator.h:

(WebCore):
(Navigator):

page/Navigator.idl:

12:17 AM Changeset in webkit [107540] by abarth@webkit.org

3 edits in trunk/LayoutTests

This test is testing the argument handling behavior of this API. Now
that we autogenerate this code, we now throw consistent exceptions with
the rest of the platform. There shouldn't be a compat issue here
because this API hasn't shipped in production releases yet.

fast/dom/MediaStream/argument-types-expected.txt:
fast/dom/MediaStream/script-tests/argument-types.js:

12:10 AM Changeset in webkit [107539] by commit-queue@webkit.org

2 edits
178 adds in trunk/LayoutTests

[EFL][DRT] Add new expected layout results come from bug 78091.
https://bugs.webkit.org/show_bug.cgi?id=78188

Patch by Kangil Han <kangil.han@samsung.com> on 2012-02-13
Reviewed by Ryosuke Niwa.

Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
This patch will activate around 1,900 test cases from skipped list in EFL port.

platform/efl/Skipped:
platform/efl/svg/css/composite-shadow-example-expected.txt: Added.
platform/efl/svg/css/composite-shadow-text-expected.txt: Added.
platform/efl/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/efl/svg/css/css-box-min-width-expected.txt: Added.
platform/efl/svg/css/group-with-shadow-expected.txt: Added.
platform/efl/svg/css/mask-with-shadow-expected.txt: Added.
platform/efl/svg/css/path-gradient-stroke-shadow-expected.txt: Added.
platform/efl/svg/css/path-with-shadow-expected.txt: Added.
platform/efl/svg/css/shadow-and-opacity-expected.txt: Added.
platform/efl/svg/css/shadow-changes-expected.txt: Added.
platform/efl/svg/css/shadow-with-large-radius-expected.txt: Added.
platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Added.
platform/efl/svg/css/stars-with-shadow-expected.txt: Added.
platform/efl/svg/css/text-gradient-shadow-expected.txt: Added.
platform/efl/svg/css/text-shadow-multiple-expected.txt: Added.
platform/efl/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
platform/efl/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Added.
platform/efl/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added.
platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added.
platform/efl/svg/foreignObject/svg-document-in-html-document-expected.txt: Added.
platform/efl/svg/hixie/cascade/001-broken-expected.txt: Added.
platform/efl/svg/hixie/cascade/002-expected.txt: Added.
platform/efl/svg/hixie/data-types/001-expected.txt: Added.
platform/efl/svg/hixie/data-types/002-expected.txt: Added.
platform/efl/svg/hixie/dynamic/002-expected.txt: Added.
platform/efl/svg/hixie/dynamic/003-expected.txt: Added.
platform/efl/svg/hixie/dynamic/004-expected.txt: Added.
platform/efl/svg/hixie/dynamic/005-expected.txt: Added.
platform/efl/svg/hixie/dynamic/006-expected.txt: Added.
platform/efl/svg/hixie/error/001-expected.txt: Added.
platform/efl/svg/hixie/error/002-expected.txt: Added.
platform/efl/svg/hixie/error/003-expected.txt: Added.
platform/efl/svg/hixie/error/006-expected.txt: Added.
platform/efl/svg/hixie/error/007-expected.txt: Added.
platform/efl/svg/hixie/error/008-expected.txt: Added.
platform/efl/svg/hixie/error/009-expected.txt: Added.
platform/efl/svg/hixie/error/010-expected.txt: Added.
platform/efl/svg/hixie/error/011-expected.txt: Added.
platform/efl/svg/hixie/error/012-expected.txt: Added.
platform/efl/svg/hixie/error/013-expected.txt: Added.
platform/efl/svg/hixie/error/014-expected.txt: Added.
platform/efl/svg/hixie/error/014-test-expected.txt: Added.
platform/efl/svg/hixie/error/015-expected.txt: Added.
platform/efl/svg/hixie/error/016-expected.txt: Added.
platform/efl/svg/hixie/error/017-expected.txt: Added.
platform/efl/svg/hixie/intrinsic/001-expected.txt: Added.
platform/efl/svg/hixie/intrinsic/002-expected.txt: Added.
platform/efl/svg/hixie/intrinsic/003-expected.txt: Added.
platform/efl/svg/hixie/links/002-expected.txt: Added.
platform/efl/svg/hixie/mixed/003-expected.txt: Added.
platform/efl/svg/hixie/mixed/004-expected.txt: Added.
platform/efl/svg/hixie/mixed/005-expected.txt: Added.
platform/efl/svg/hixie/mixed/006-expected.txt: Added.
platform/efl/svg/hixie/mixed/007-expected.txt: Added.
platform/efl/svg/hixie/mixed/008-expected.txt: Added.
platform/efl/svg/hixie/mixed/009-expected.txt: Added.
platform/efl/svg/hixie/mixed/010-expected.txt: Added.
platform/efl/svg/hixie/mixed/011-expected.txt: Added.
platform/efl/svg/hixie/painting/001-expected.txt: Added.
platform/efl/svg/hixie/perf/001-expected.txt: Added.
platform/efl/svg/hixie/perf/002-expected.txt: Added.
platform/efl/svg/hixie/perf/003-expected.txt: Added.
platform/efl/svg/hixie/perf/004-expected.txt: Added.
platform/efl/svg/hixie/perf/005-expected.txt: Added.
platform/efl/svg/hixie/perf/006-expected.txt: Added.
platform/efl/svg/hixie/perf/007-expected.txt: Added.
platform/efl/svg/hixie/processing-model/003-expected.txt: Added.
platform/efl/svg/hixie/processing-model/004-expected.txt: Added.
platform/efl/svg/hixie/processing-model/005-expected.txt: Added.
platform/efl/svg/hixie/rendering-model/001-expected.txt: Added.
platform/efl/svg/hixie/rendering-model/002-expected.txt: Added.
platform/efl/svg/hixie/rendering-model/003-expected.txt: Added.
platform/efl/svg/hixie/rendering-model/003a-expected.txt: Added.
platform/efl/svg/hixie/rendering-model/004-expected.txt: Added.
platform/efl/svg/hixie/shapes/path/001-expected.txt: Added.
platform/efl/svg/hixie/text/001-expected.txt: Added.
platform/efl/svg/hixie/text/002-expected.txt: Added.
platform/efl/svg/hixie/text/003-expected.txt: Added.
platform/efl/svg/hixie/text/003a-expected.txt: Added.
platform/efl/svg/hixie/text/003b-expected.txt: Added.
platform/efl/svg/hixie/transform/001-expected.txt: Added.
platform/efl/svg/hixie/use/001-expected.txt: Added.
platform/efl/svg/hixie/use/002-expected.txt: Added.
platform/efl/svg/hixie/use/002-test-expected.txt: Added.
platform/efl/svg/hixie/viewbox/001-expected.txt: Added.
platform/efl/svg/hixie/viewbox/004-expected.txt: Added.
platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
platform/efl/svg/in-html/by-reference-expected.txt: Added.
platform/efl/svg/in-html/circle-expected.txt: Added.
platform/efl/svg/overflow/overflow-on-foreignObject-expected.txt: Added.
platform/efl/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Added.
platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.txt: Added.
platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
platform/efl/svg/repaint/filter-child-repaint-expected.txt: Added.
platform/efl/svg/repaint/filter-repaint-expected.txt: Added.
platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.txt: Added.
platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
platform/efl/svg/transforms/svg-css-transforms-expected.txt: Added.
platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Added.
platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
platform/efl/svg/wicd/rightsizing-grid-expected.txt: Added.
platform/efl/svg/wicd/sizing-flakiness-expected.txt: Added.
platform/efl/svg/wicd/test-rightsizing-a-expected.txt: Added.
platform/efl/svg/wicd/test-rightsizing-b-expected.txt: Added.
platform/efl/svg/wicd/test-scalable-background-image1-expected.txt: Added.
platform/efl/svg/wicd/test-scalable-background-image2-expected.txt: Added.
platform/efl/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
platform/efl/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-background-images-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
platform/efl/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
platform/efl/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
platform/efl/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
platform/efl/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
platform/efl/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed