Timeline



Mar 9, 2012:

9:45 PM Changeset in webkit [110371] by commit-queue@webkit.org
  • 15 edits in trunk

Source/WebCore: Handle more Gesture* events by performing scrolls on the correct target ScrollableArea
​https://bugs.webkit.org/show_bug.cgi?id=80311

Implement GestureScroll* events via re-use of WheelEvent dispatch.

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-09
Reviewed by James Robinson.

Layout tests previously submited as ​https://bugs.webkit.org/show_bug.cgi?id=80201 and unit
test added as part of this patch.

  • page/EventHandler.cpp:

(WebCore::wheelGranularityToScrollGranularity): Refactoring.
(WebCore):
(WebCore::scrollNode):
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::handleGestureEvent): Added GestureScrollBegin & End.
(WebCore::EventHandler::handleGestureTap):
(WebCore::EventHandler::handleGestureScrollUpdate):
(WebCore::EventHandler::handleGestureScrollCore): Refactoring.

  • page/EventHandler.h:

(EventHandler):

  • platform/PlatformWheelEvent.h: Added additional scroll type.
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent): Forward additional scroll type.

  • platform/ScrollAnimator.h:

(WebCore):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone): Handle additional scroll type.
(WebCore::ScrollAnimatorNone::fireUpAnAnimation):
(WebCore):
(WebCore::ScrollAnimatorNone::scroll):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/ScrollTypes.h: Added an additional scroll type.
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scroll):

Source/WebKit/chromium: Handle more Gesture* events by performing scrolls on the correct target ScrollableArea
​https://bugs.webkit.org/show_bug.cgi?id=80311

Added a unit test for the changes to ScrollAnimatorNone to make sure that the two-call
transport of fling parameters is correctly delivered.

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-09
Reviewed by James Robinson.

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollAnimatorNone):
(MockScrollAnimatorNone::reset):
(MockScrollAnimatorNone::fireUpAnAnimation):
(TEST):

LayoutTests: Handle more Gesture* events by performing scrolls on the correct target ScrollableArea
​https://bugs.webkit.org/show_bug.cgi?id=80311

Rebaselined to reflect corrected behaviour of gesture events targeting a div removed
from the DOM during dispatch.

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-09
Reviewed by James Robinson.

  • fast/events/touch/gesture/touch-gesture-scroll-shy-target.html:
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt:
9:40 PM Changeset in webkit [110370] by mrowe@apple.com
  • 2 edits in tags/Safari-536.2.3/Source/WebKit2

Merge r110303.

9:04 PM Changeset in webkit [110369] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Fix a fixme in v8 bindings
​https://bugs.webkit.org/show_bug.cgi?id=80734

Reviewed by Kentaro Hara.

No new tests. Covered by existing tests.

  • bindings/v8/V8Binding.cpp:

(WebCore::toInt32):
(WebCore::toUInt32):

8:50 PM Changeset in webkit [110368] by ostapenko.viatcheslav@nokia.com
  • 4 edits in trunk/Source/WebKit2

[Qt] [WK2] Shouldn't use item for clipping rect calculation in paint node.
​https://bugs.webkit.org/show_bug.cgi?id=80714

Reviewed by Noam Rosenthal.

Replace item based clip-rect calculation with clipping-nodes based calculation.
This is required for threaded rendering, since we don't have access to the QSGItems
from the render thread.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::QQuickWebPage):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::render):
(PageProxyNode::clipRect):
(PageProxyNode):

  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::QQuickWebView):

8:35 PM Changeset in webkit [110367] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] WebCore/Target.pri contains obsolete FileStreamProxy.h reference.
​https://bugs.webkit.org/show_bug.cgi?id=80730

Patch by Lauro Neto <​lauro.neto@openbossa.org> on 2012-03-09
Reviewed by Tor Arne Vestbø.

Build fix. Target.pri was still including old FileStreamProxy.h.

  • Target.pri:
7:53 PM Changeset in webkit [110366] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Pan scroll icon is painted at incorrect coordinates in frames
​https://bugs.webkit.org/show_bug.cgi?id=79378

Convert client coordinates to parent ScrollView coordinates

Patch by Cem Kocagil <​cem.kocagil@gmail.com> on 2012-03-05
Reviewed by Antonio Gomes

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paintPanScrollIcon):

7:19 PM Changeset in webkit [110365] by ojan@chromium.org
  • 244 edits
    154 copies
    69 moves
    100 adds
    2 deletes in trunk/LayoutTests

Chromium-Lion rebaselines. Getting close to done. :(

7:11 PM Changeset in webkit [110364] by jamesr@google.com
  • 7 edits in trunk

[chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
​https://bugs.webkit.org/show_bug.cgi?id=80523

Reviewed by Darin Fisher.

Source/WebKit/chromium:

  • public/WebViewClient.h:

(WebViewClient):
(WebKit::WebViewClient::createGraphicsContext3D):

  • public/platform/WebKitPlatformSupport.h:

(WebKit):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createCompositorGraphicsContext3D):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createGraphicsContext3D):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

7:10 PM Changeset in webkit [110363] by jsbell@chromium.org
  • 6 edits
    1 add in trunk/Source

IndexedDB: Handle LevelDB database corruption
​https://bugs.webkit.org/show_bug.cgi?id=79413

Source/WebCore:

Add LevelDBDatabase::destroy() method so that clients can retry if open() fails.

Reviewed by Tony Chang.

Test: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.CorruptionTest'

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp: Implement open/destroy/open strategy.

(WebCore::IDBLevelDBBackingStore::open):

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::destroy):
(WebCore):

  • platform/leveldb/LevelDBDatabase.h:

(LevelDBDatabase):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/LevelDBTest.cpp: Added.

(WebCore):
(SimpleComparator):
(WebCore::SimpleComparator::compare):
(WebCore::SimpleComparator::name):
(WebCore::encodeString):
(WebCore::TEST):

6:58 PM Changeset in webkit [110362] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix one of the Windows build warnings.

  • html/track/TextTrackCueList.idl:

Add a newline to the end of the file.

6:55 PM Changeset in webkit [110361] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

BlackBerry PlayBook doesn't sniff mime types
​https://bugs.webkit.org/show_bug.cgi?id=73869

Patch by Tyler Abbott <​tabbott@rim.com> on 2012-03-09
Reviewed by Rob Buis.

Hook up MIMESniffing for BlackBerry. Override Content-Types will
not be overriden. File extensions will be trusted when content
is loaded from disk.

No tests, BlackBerry tests are not yet present in webkit.org codebase.

  • PlatformBlackBerry.cmake:
  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::handleNotifyDataReceived):
(WebCore::NetworkJob::sendResponseIfNeeded):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

6:53 PM Changeset in webkit [110360] by enrica@apple.com
  • 16 edits
    2 adds in trunk/Source

Move WebNSURLExtras code down to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=80611

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • WebCore.exp.in: Added new exported functions.
  • WebCore.xcodeproj/project.pbxproj: Added WebCoreNSURLExtras.*
  • platform/FileSystem.h: Added setMetadataURL.
  • platform/mac/FileSystemMac.mm:

(WebCore::setMetaData): Added.
(WebCore::setMetadataURL): Added.

  • platform/mac/WebCoreNSStringExtras.h:
  • platform/mac/WebCoreNSStringExtras.mm:

(hasCaseInsensitivePrefix): Added.

  • platform/mac/WebCoreNSURLExtras.h: Added.
  • platform/mac/WebCoreNSURLExtras.mm: Added.
  • platform/mac/WebCoreObjCExtras.h:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

Changed the implementation to use newly moved WebCore functions.

  • Misc/WebKitNSStringExtras.mm:

(-[NSString _webkit_hasCaseInsensitivePrefix:]):

  • Misc/WebNSURLExtras.mm:

(+[NSURL _web_URLWithUserTypedString:]):
(+[NSURL _web_URLWithDataAsString:relativeToURL:]):
(+[NSURL _web_URLWithData:]):
(+[NSURL _web_URLWithData:relativeToURL:]):
(-[NSURL _web_originalData]):
(-[NSURL _web_originalDataAsString]):
(-[NSURL _web_userVisibleString]):
(-[NSURL _web_isEmpty]):
(-[NSURL _web_URLCString]):
(-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]):
(-[NSURL _webkit_URLByRemovingFragment]):
(-[NSURL _webkit_URLByRemovingResourceSpecifier]):
(-[NSURL _web_URLByRemovingUserInfo]):
(-[NSURL _web_dataForURLComponentType:]):
(-[NSURL _web_schemeData]):
(-[NSURL _web_hostData]):
(-[NSString _web_isUserVisibleURL]):
(-[NSString _web_hostNameNeedsDecodingWithRange:]):
(-[NSString _web_hostNameNeedsEncodingWithRange:]):
(-[NSString _web_decodeHostNameWithRange:]):
(-[NSString _web_encodeHostNameWithRange:]):
(-[NSString _web_decodeHostName]):
(-[NSString _web_encodeHostName]):

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

6:40 PM Changeset in webkit [110359] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[chromium] Increase size of Combo Box Options for touch and high DPI devices
​https://bugs.webkit.org/show_bug.cgi?id=80027

Patch by Tim Dresser <​tdresser@chromium.org> on 2012-03-09
Reviewed by Darin Fisher.

Source/WebCore:

Scale Combo box popups by defaultDeviceScaleFactor, and add padding to
<option> elements when touch is enabled.

Manually tested with --default-device-scale-factor=1,2 and unset.
Each of these were tested with RuntimeEnabledFeatures::touchEnabled
set to true and false.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupListBox.h:

(PopupContainerSettings):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore):
(WebCore::PopupMenuChromium::show):

  • platform/chromium/PopupMenuChromium.h:

(WebCore::PopupMenuChromium::optionPaddingForTouch):
(WebCore::PopupMenuChromium::setOptionPaddingForTouch):
(PopupMenuChromium):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::applyAutofillSuggestions):

6:22 PM Changeset in webkit [110358] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

Improve ContainerNode collectNode() performance by reserving vector
capacity up front.
​https://bugs.webkit.org/show_bug.cgi?id=80706

Reviewed by Ryosuke Niwa.

Covered by existing tests. Performance will be evaluated based on
Chromium's page_cycler_bloat-http, page_cycler_intl1, and
dromaeo_domcore suites.

  • dom/ContainerNode.cpp:

(WebCore::collectNodes):

6:11 PM Changeset in webkit [110357] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium DEPS to r125600
​https://bugs.webkit.org/show_bug.cgi?id=80722

Unreviewed

Patch by James Robinson <​jamesr@chromium.org> on 2012-03-09

  • DEPS:
6:09 PM Changeset in webkit [110356] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/11018851> Crash in DisplayRefreshMonitor::notifyClients()
​https://bugs.webkit.org/show_bug.cgi?id=80740

Reviewed by Sam Weinig.

No test, since this race condition cannot be reproduced reliably.

  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor): Changed to stop the display link
first, then cancel any outstanding calls to refreshDisplayOnMainThread(). When doing things
the other way around, the display link can fire after outstanding calls have been canceled,
and enqueue new calls on the main thread, which will be dispatched after monitor destruction.

6:04 PM Changeset in webkit [110355] by jeffm@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WKPageEndPrinting() to balance WKPageBeginPrinting()
​https://bugs.webkit.org/show_bug.cgi?id=80739

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageEndPrinting): Added.

  • UIProcess/API/C/WKPagePrivate.h: Added WKPageEndPrinting().
6:02 PM Changeset in webkit [110354] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update baseline after ​http://trac.webkit.org/changeset/110352 to show
the new passing subtest.

  • platform/chromium/fast/js/array-prototype-properties-expected.txt:
5:24 PM Changeset in webkit [110353] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Clean up culling tests and templatize to test impl constructs
​https://bugs.webkit.org/show_bug.cgi?id=80613

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-09
Reviewed by Adrienne Walker.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestContentLayerChromium::TestContentLayerChromium):
(WebCore::TestContentLayerChromium::opaqueContentsRegion):
(WebCore::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(TestContentLayerImpl):
(WebCore::TestContentLayerImpl::TestContentLayerImpl):
(WebCore::TestContentLayerImpl::opaqueContentsRegion):
(WebCore::TestContentLayerImpl::setOpaqueContentsRect):
(WebCore):
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(CCOcclusionTrackerTestMainThreadTypes):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
(CCOcclusionTrackerTestImplThreadTypes):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
(CCOcclusionTrackerTest):
(WebCore::CCOcclusionTrackerTest::TearDown):
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createSurface):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingSurface):
(WebCore::CCOcclusionTrackerTest::calcDrawEtc):
(WebCore::CCOcclusionTrackerTest::setBaseProperties):
(WebCore::CCOcclusionTrackerTest::setProperties):
(CCOcclusionTrackerTestIdentityTransforms):
(WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(CCOcclusionTrackerTestRotatedChild):
(WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
(CCOcclusionTrackerTestTranslatedChild):
(WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(CCOcclusionTrackerTestChildInRotatedChild):
(WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(CCOcclusionTrackerTestVisitTargetTwoTimes):
(WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(CCOcclusionTrackerTestSurfaceRotatedOffAxis):
(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
(WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblings):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(CCOcclusionTrackerTestFilters):
(WebCore::CCOcclusionTrackerTestFilters::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOutsideChild):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestDamageRectOverNothing):
(WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
(WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):

5:20 PM Changeset in webkit [110352] by barraclough@apple.com
  • 5 edits in trunk

Array.prototype.toLocaleString visits elements in wrong order under certain conditions
​https://bugs.webkit.org/show_bug.cgi?id=80663

Reviewed by Michael Saboff.

The bug here is actually that we're continuing to process the array after an exception
has been thrown, and that the second value throw is overriding the first.

Source/JavaScriptCore:

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToLocaleString):

LayoutTests:

  • fast/js/array-prototype-properties-expected.txt:
  • fast/js/script-tests/array-prototype-properties.js:
5:03 PM Changeset in webkit [110351] by eric@webkit.org
  • 2 edits in trunk/Tools

build-webkit should build Source/WTF on Mac
​https://bugs.webkit.org/show_bug.cgi?id=80728

Reviewed by Adam Barth.

We'll add other ports to this list in future commits.

  • Scripts/build-webkit:
5:01 PM Changeset in webkit [110350] by ojan@chromium.org
  • 204 edits
    135 copies
    111 moves
    66 adds in trunk/LayoutTests

So many Chromium-Lion rebaselines. :(

4:44 PM Changeset in webkit [110349] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Assertion failure in ResourceHandle::setDefersLoading(): d->m_defersLoading != defers
​https://bugs.webkit.org/show_bug.cgi?id=80543

Reviewed by Geoffrey Garen.

Reset m_defersLoading flag to the value from Page::defersCallbacks() in
ResourceLoader::init(). This is because the resource could have been in the pending requests
queue in ResourceLoadScheduler and would have missed out on state changes to this flag
happening from DocumentLoader::setDefersCallbacks().

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):

4:36 PM Changeset in webkit [110348] by eae@chromium.org
  • 13 edits in trunk/Source

Add roundedPoint to HitTestResult and change platform code to use it
​https://bugs.webkit.org/show_bug.cgi?id=80715

Reviewed by James Robinson.

Change ports to use roundedPoint to avoid exposing subpixel types to
platform code.

Source/WebCore:

No new tests.

  • rendering/HitTestResult.h:

(WebCore::HitTestResult::roundedPoint):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::mouseDidMoveOverElement):

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

Source/WebKit/mac:

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::showContextMenu):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

Source/WebKit/win:

  • WebView.cpp:

(WebView::handleContextMenuEvent):

Source/WebKit2:

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

4:13 PM Changeset in webkit [110347] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8][Performance] Inline hot methods in V8Bindings.h
​https://bugs.webkit.org/show_bug.cgi?id=80685

Reviewed by Adam Barth.

This patch slightly improves DOM binding performance by inlining hot
methods in V8Binding.cpp, e.g. isUndefinedOrNull(), v8StringOrNull(), v8Boolean().
For example, this patch improves div.nodeName by 5.0%, and div.nodeValue by 4.1%.

Performance tests: ​https://bugs.webkit.org/attachment.cgi?id=131006

The performance test results in my Mac environment are as follows:

Chromium/V8 without this patch:
div.nodeName : 3417.4 ms
div.nodeValue : 2069.6 ms

Chromium/V8 with this patch:
div.nodeName : 3245.6 ms
div.nodeValue : 1983.1 ms

No tests. No change in behavior.

  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8Binding.h:

(WebCore::toWebCoreString):
(WebCore::isUndefinedOrNull):
(WebCore::isHostObject):
(WebCore::v8Boolean):
(WebCore::toWebCoreStringWithNullCheck):
(WebCore::toAtomicWebCoreStringWithNullCheck):
(WebCore::toWebCoreStringWithNullOrUndefinedCheck):
(WebCore::v8UndetectableString):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
(WebCore::v8StringOrFalse):
(WebCore::toWebCoreDate):
(WebCore::v8DateOrNull):

3:49 PM Changeset in webkit [110346] by ap@apple.com
  • 3 edits
    2 moves in trunk/Source/WebKit2

[Mac] Pass sandbox profiles through preprocessor
​https://bugs.webkit.org/show_bug.cgi?id=80651

Reviewed by Mark Rowe.

  • DerivedSources.make: Preprocess sandbox profiles.
  • PluginProcess/mac/com.apple.WebKit.PluginProcess.sb: Removed.
  • PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.in: Copied from Source/WebKit2/PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.
  • WebProcess/com.apple.WebProcess.sb: Removed.
  • WebProcess/com.apple.WebProcess.sb.in: Copied from Source/WebKit2/WebProcess/com.apple.WebProcess.sb. Renamed to avoid make finding the wrong original in default paths.
  • WebKit2.xcodeproj/project.pbxproj: Copy preprocessed files to Resources, not originals. Also, changed DerivedSources target to use BaseTarget.xcconfig to have correct include paths.
3:45 PM Changeset in webkit [110345] by arv@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Rebaseline inspector/debugger/debugger-scripts.html

[chromium] Unreviewed gardening.

  • platform/chromium-win/inspector/debugger/debugger-scripts-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger/debugger-scripts-expected.txt.
3:34 PM Changeset in webkit [110344] by wjmaclean@chromium.org
  • 4 edits
    12 adds in trunk/Source

[chromium] Implement scroll physics architecture for impl/main thread
​https://bugs.webkit.org/show_bug.cgi?id=79827

Reviewed by James Robinson.

Source/WebCore:

Unittests added, plus follow-on patch from rjkroege will add layout tests.

PlatformGestureCurve is a framework to separate the physical simulation from for gesture
animation from control concerns. This allows the physics to be reused in alternate places.
At present, the framework will be applied in ScrollAnimatorNone and the Chrome Compositor.

  • WebCore.gypi:
  • platform/ActivePlatformGestureAnimation.cpp: Added.

(WebCore):
(WebCore::ActivePlatformGestureAnimation::create):
(WebCore::ActivePlatformGestureAnimation::~ActivePlatformGestureAnimation):
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):
(WebCore::ActivePlatformGestureAnimation::animate):

  • platform/ActivePlatformGestureAnimation.h: Added.

(WebCore):
(ActivePlatformGestureAnimation):

  • platform/PlatformGestureCurve.h: Added.

(WebCore):
(PlatformGestureCurve):
(WebCore::PlatformGestureCurve::~PlatformGestureCurve):

  • platform/PlatformGestureCurveTarget.h: Added.

(WebCore):
(PlatformGestureCurveTarget):
(WebCore::PlatformGestureCurveTarget::~PlatformGestureCurveTarget):

  • platform/TouchFlingPlatformGestureCurve.cpp: Added.

(WebCore):
(WebCore::TouchFlingPlatformGestureCurve::create):
(WebCore::TouchFlingPlatformGestureCurve::TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::~TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::apply):

  • platform/TouchFlingPlatformGestureCurve.h: Added.

(WebCore):
(TouchFlingPlatformGestureCurve):

  • platform/WheelFlingPlatformGestureCurve.cpp: Added.

(WebCore):
(WebCore::WheelFlingPlatformGestureCurve::create):
(WebCore::WheelFlingPlatformGestureCurve::WheelFlingPlatformGestureCurve):
(WebCore::WheelFlingPlatformGestureCurve::~WheelFlingPlatformGestureCurve):
(WebCore::WheelFlingPlatformGestureCurve::apply):

  • platform/WheelFlingPlatformGestureCurve.h: Added.

(WebCore):
(WheelFlingPlatformGestureCurve):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp: Added.

(WebCore):
(WebCore::CCActiveGestureAnimation::create):
(WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):
(WebCore::CCActiveGestureAnimation::~CCActiveGestureAnimation):
(WebCore::CCActiveGestureAnimation::animate):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.h: Added.

(WebCore):
(CCActiveGestureAnimation):

  • platform/graphics/chromium/cc/CCGestureCurve.h: Added.

(WebCore):
(CCGestureCurveTarget):
(WebCore::CCGestureCurveTarget::~CCGestureCurveTarget):
(CCGestureCurve):
(WebCore::CCGestureCurve::~CCGestureCurve):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/PlatformGestureCurveTest.cpp: Added.
3:27 PM Changeset in webkit [110343] by ojan@chromium.org
  • 103 edits
    76 copies
    134 moves
    177 adds
    16 deletes in trunk/LayoutTests

More Chromium-Lion rebaselines.

3:25 PM Changeset in webkit [110342] by rniwa@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

WebKit compiled by gcc (Xcode 3.2.6) hangs while running DOM/Accessors.html
​https://bugs.webkit.org/show_bug.cgi?id=80080

Reviewed by Filip Pizlo.

  • bytecode/SamplingTool.cpp:

(JSC::SamplingRegion::Locker::Locker):
(JSC::SamplingRegion::Locker::~Locker):

  • bytecode/SamplingTool.h:

(JSC::SamplingRegion::exchangeCurrent):

  • wtf/Atomics.h:

(WTF):
(WTF::weakCompareAndSwap):
(WTF::weakCompareAndSwapUIntPtr):

3:25 PM Changeset in webkit [110341] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderListBox.cpp

Fixing a paint at a non-rounded LayoutPoint.

3:11 PM Changeset in webkit [110340] by alexis.menard@openbossa.org
  • 7 edits
    2 adds in trunk

Implement selectedOptions attribute of <select>.
​https://bugs.webkit.org/show_bug.cgi?id=80631

Reviewed by Benjamin Poulain.

Source/WebCore:

Add a new collection as a member of HTMLSelectElement which is
used to store the selected elements. Extend HTMLCollection to
support the new collection type needed by this feature.

Reference : ​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#dom-select-selectedoptions

Test: fast/dom/select-selectedOptions.html

  • html/CollectionType.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectedOptions):
(WebCore):

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLSelectElement.idl:

LayoutTests:

New tests to cover the feature.

  • fast/dom/select-selectedOptions-expected.txt: Added.
  • fast/dom/select-selectedOptions.html: Added.
3:06 PM Changeset in webkit [110339] by leviw@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore

Fixing integer truncation issue around contentWidth/Height, a duplicated FractionalLayoutSize.cpp reference in cmake, and unnecessary layout units in RenderEmbeddedObject.

3:04 PM Changeset in webkit [110338] by jamesr@google.com
  • 11 edits
    5 adds in trunk/Source

[chromium] ScrollbarLayerChromium/CCScrollbarLayerImpl for CC-side scrollbar painting
​https://bugs.webkit.org/show_bug.cgi?id=78872

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2012-03-09
Reviewed by James Robinson.

Source/WebCore:

New test ScrollbarLayerChromiumTest.resolveScrollLayerPointer

  • WebCore.gypi:
  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::scrollLayerForFrameView):
(WebCore::scrollbarLayerDidChange):
(WebCore):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::invalidateScrollbar):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore::GraphicsLayerChromium::hasContentsLayer):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(WebCore::LayerChromium::toScrollbarLayerChromium):
(LayerChromium):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp: Added.

(WebCore):
(WebCore::ScrollbarLayerChromium::createCCLayerImpl):
(WebCore::ScrollbarLayerChromium::create):
(WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/ScrollbarLayerChromium.h: Added.

(WebCore):
(ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::scrollLayerId):
(WebCore::ScrollbarLayerChromium::toScrollbarLayerChromium):

  • platform/graphics/chromium/TreeSynchronizer.cpp:

(WebCore::TreeSynchronizer::synchronizeTrees):
(WebCore::TreeSynchronizer::collectExistingCCLayerImplRecursive):
(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):
(WebCore::TreeSynchronizer::synchronizeTreeRecursive):
(WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):
(WebCore):

  • platform/graphics/chromium/TreeSynchronizer.h:

(TreeSynchronizer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp: Added.

(WebCore):
(WebCore::CCScrollbarLayerImpl::create):
(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::willDraw):
(WebCore::CCScrollbarLayerImpl::appendQuads):
(WebCore::CCScrollbarLayerImpl::didDraw):
(WebCore::CCScrollbarLayerImpl::paint):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::x):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::y):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::width):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::height):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::size):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::location):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::parent):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::root):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::setFrameRect):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::frameRect):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::invalidate):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::invalidateRect):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::scrollbarOverlayStyle):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::getTickmarks):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollableAreaActive):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollViewScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::convertFromContainingWindow):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isCustomScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::orientation):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::value):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::currentPos):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::visibleSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::totalSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::maximum):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::controlSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::lineStep):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::pageStep):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::pressedPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::hoveredPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::styleChanged):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::enabled):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::setEnabled):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h: Added.

(WebCore):
(CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::setScrollbarOverlayStyle):
(WebCore::CCScrollbarLayerImpl::setTickmarks):
(WebCore::CCScrollbarLayerImpl::setIsScrollableAreaActive):
(WebCore::CCScrollbarLayerImpl::setIsScrollViewScrollbar):
(WebCore::CCScrollbarLayerImpl::setOrientation):
(WebCore::CCScrollbarLayerImpl::setControlSize):
(WebCore::CCScrollbarLayerImpl::setPressedPart):
(WebCore::CCScrollbarLayerImpl::setHoveredPart):
(WebCore::CCScrollbarLayerImpl::setEnabled):
(WebCore::CCScrollbarLayerImpl::scrollLayer):
(WebCore::CCScrollbarLayerImpl::setScrollLayer):
(CCScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::CCScrollbar):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/ScrollbarLayerChromiumTest.cpp: Added.

(WebCore):
(MockScrollbar):
(WebCore::MockScrollbar::x):
(WebCore::MockScrollbar::y):
(WebCore::MockScrollbar::width):
(WebCore::MockScrollbar::height):
(WebCore::MockScrollbar::size):
(WebCore::MockScrollbar::location):
(WebCore::MockScrollbar::parent):
(WebCore::MockScrollbar::root):
(WebCore::MockScrollbar::setFrameRect):
(WebCore::MockScrollbar::frameRect):
(WebCore::MockScrollbar::invalidate):
(WebCore::MockScrollbar::invalidateRect):
(WebCore::MockScrollbar::scrollbarOverlayStyle):
(WebCore::MockScrollbar::getTickmarks):
(WebCore::MockScrollbar::isScrollableAreaActive):
(WebCore::MockScrollbar::isScrollViewScrollbar):
(WebCore::MockScrollbar::convertFromContainingWindow):
(WebCore::MockScrollbar::isCustomScrollbar):
(WebCore::MockScrollbar::orientation):
(WebCore::MockScrollbar::value):
(WebCore::MockScrollbar::currentPos):
(WebCore::MockScrollbar::visibleSize):
(WebCore::MockScrollbar::totalSize):
(WebCore::MockScrollbar::maximum):
(WebCore::MockScrollbar::controlSize):
(WebCore::MockScrollbar::lineStep):
(WebCore::MockScrollbar::pageStep):
(WebCore::MockScrollbar::pressedPart):
(WebCore::MockScrollbar::hoveredPart):
(WebCore::MockScrollbar::styleChanged):
(WebCore::MockScrollbar::enabled):
(WebCore::MockScrollbar::setEnabled):
(WebCore::MockScrollbar::MockScrollbar):
(WebCore::MockScrollbar::~MockScrollbar):
(WebCore::TEST):

3:03 PM Changeset in webkit [110337] by mrowe@apple.com
  • 4 edits in tags/Safari-536.2.3/Source

Versioning.

2:58 PM Changeset in webkit [110336] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Split the extra logical height distribution logic out of RenderTableSection::layoutRows
​https://bugs.webkit.org/show_bug.cgi?id=80671

Reviewed by Adrienne Walker.

Refactoring only, no change in behavior expected.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
Split the logic from here...

(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToAutoRows):
(WebCore::RenderTableSection::distributeRemainingExtraLogicalHeight):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows):
... to those functions. Cleaned up the variable naming while at it and
made them follow the same signature as this may be useful to fix another
bug I have.

  • rendering/RenderTableSection.h:

(RenderTableSection):
Added the previous 4 new functions.

2:53 PM Changeset in webkit [110335] by mrowe@apple.com
  • 1 copy in tags/Safari-536.2.3

New tag.

2:52 PM Changeset in webkit [110334] by rwlbuis@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebCore

Remove unused file FrameBlackBerry.cpp
​https://bugs.webkit.org/show_bug.cgi?id=80731

Reviewed by Antonio Gomes.

This is not needed anymore since there is an implementation elsewhere.

  • PlatformBlackBerry.cmake:
  • page/blackberry/FrameBlackBerry.cpp: Removed.
2:43 PM Changeset in webkit [110333] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r110309.
​http://trac.webkit.org/changeset/110309
​https://bugs.webkit.org/show_bug.cgi?id=80732

Seems to have caused a number of SVG crashes (thorton will
investigate further) (Requested by abarth|gardener on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-09

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::deferredRepaintTimerFired):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldRepaint):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

2:36 PM Changeset in webkit [110332] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Crash due to inserting letter into div with first-letter
​https://bugs.webkit.org/show_bug.cgi?id=78534

Patch by Ken Buchanan <​kenrb@chromium.org> on 2012-03-09
Reviewed by David Hyatt.

Source/WebCore:

This fixes an issue in RenderTextFragment with setTextInternal
getting called with different intents. While most calls to it
are intended to change the underlying DOM node string, it can
also be called as a result of styleDidChange just for transforms
on the substring text fragment. This adds a mechanism for internal
callers to specify if the internal text is being updated without
a DOM node text change.

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::styleDidChange)
(WebCore::RenderTextFragment::setTextInternal)

  • rendering/RenderTextFragment.h:

(WebCore::RenderTextFragment)

LayoutTests:

Test case to exercise the crashing condition in bug 78534. It inserts
a character in a first-letter div to induce an invalid RenderTextFragment
state.

  • editing/inserting/insert-character-in-first-letter-crash-expected.txt: Added
  • editing/inserting/insert-character-in-first-letter-crash.html: Added
2:31 PM Changeset in webkit [110331] by barraclough@apple.com
  • 5 edits in trunk

REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
​https://bugs.webkit.org/show_bug.cgi?id=49989

Reviewed by Oliver Hunt.

Patch originally by chris reiss <​christopher.reiss@nokia.com>,
allow the year to appear before the timezone in date strings.

Source/JavaScriptCore:

  • wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):

LayoutTests:

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:
2:24 PM Changeset in webkit [110330] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Fix uninitialized variable in DynamicsCompressor
​https://bugs.webkit.org/show_bug.cgi?id=80724

Reviewed by James Robinson.

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):

2:04 PM Changeset in webkit [110329] by ojan@chromium.org
  • 32 edits
    1 move
    31 deletes in trunk/LayoutTests

Move some results from mac-future to mac. mac-future should not exist.
See ​https://bugs.webkit.org/show_bug.cgi?id=80717 for how these got there
in the first place.

  • platform/mac-future/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-no-markup-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-direction-rtl-expected.png: Removed.
  • platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Removed.
  • platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Removed.
  • platform/mac-future/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Removed.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
1:50 PM Changeset in webkit [110328] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Undo text position adjustment for attribute event handlers
​https://bugs.webkit.org/show_bug.cgi?id=80725

Reviewed by Adam Barth.

No new tests. Needs rebaseline.

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

1:34 PM Changeset in webkit [110327] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Ensure that the WTF headers are copied at installhdrs time.

Reviewed by Dan Bernstein and Jessie Berlin.

  • Configurations/JavaScriptCore.xcconfig: Set INSTALLHDRS_SCRIPT_PHASE = YES

so that our script phases are invoked at installhdrs time. The only one that
does any useful work at that time is the one that installs WTF headers.

1:34 PM Changeset in webkit [110326] by tsepez@chromium.org
  • 3 edits
    3 adds in trunk

Hold cached images with a CachedResourceHandle rather than a raw pointer for CSSCrossfadeValue
​https://bugs.webkit.org/show_bug.cgi?id=80186

Reviewed by Simon Fraser.

Source/WebCore:

Test: http/tests/css/cross-fade-reload.html

  • css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

LayoutTests:

  • http/tests/css/cross-fade-reload-expected.txt: Added.
  • http/tests/css/cross-fade-reload.html: Added.
  • http/tests/css/resources/abe.png: Added.
1:32 PM Changeset in webkit [110325] by jamesr@google.com
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Expose the shared graphics context on WebView so callers can allocate resources on the main thread for the compositor to use
​https://bugs.webkit.org/show_bug.cgi?id=80670

Reviewed by Stephen White.

This exposes a context on WebView that is in the compositor's share group and can be used directly from the main
thread. This is useful for content that needs to allocate resources for the compositor to use, but cannot
directly use the compositor's context either because it cannot access the correct thread or because it needs to
initialize in situations where we cannot initialize a compositor (view) context - for instance before the native
window is created.

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::sharedGraphicsContext3D):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

1:14 PM Changeset in webkit [110324] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash when splitting an anonymous block in multi-column layout.
​https://bugs.webkit.org/show_bug.cgi?id=80432

Reviewed by David Hyatt.

Source/WebCore:

Calculating currChild->nextSibling() is risky after destroying :after content
because it can blow away currChild if it is a left over empty anonymous block.
We need to calculate next sibling upfront, using the same trick, we do in
RenderBlock::addChildIgnoringAnonymousColumnBlock to reset beforeChild (check
out the line before splitFlow call).

Test: fast/multicol/anonymous-block-split-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

  • fast/multicol/anonymous-block-split-crash-expected.txt: Added.
  • fast/multicol/anonymous-block-split-crash.html: Added.
1:12 PM Changeset in webkit [110323] by inferno@chromium.org
  • 10 edits
    2 adds in trunk

Crash due to accessing removed parent lineboxes when clearing selection.
​https://bugs.webkit.org/show_bug.cgi?id=79264

Reviewed by Dave Hyatt.

Source/WebCore:

Test: editing/selection/first-letter-selection-crash.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::setSelectionState):

  1. No need of checking if we are being set to same selection state.

Now tested by setSelectionStateIfNeeded. Rename 's' with 'state' and
'cb' with 'containingBlock'.

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::setSelectionState):

  1. Add check to canUpdateSelectionOnRootLineBoxes to make sure our

root line boxes are still valid before setting them.

  1. No need of calling setSelectionState on containing block since our base

class call to RenderBox::setSelectionState covers it. Added a comment to indicate that.

  1. Use m_inlineBoxWrapper variable directly to simplify the ifs.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::canUpdateSelectionOnRootLineBoxes):
(WebCore): helper function to tell if we can update selection information
on our root line boxes. This returns false if our containing block is pending layout.

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::setSelectionStateIfNeeded):
(WebCore): helper to set selection state only if it is different from our
current selection state.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::setSelectionState):

  1. Rename 's' to 'state', 'line' to 'root' and use m_inlineBoxWrapper directly

to simplify ifs.

  1. Add check to canUpdateSelectionOnRootLineBoxes to make sure our

root line boxes are still valid before setting them.

  • rendering/RenderText.cpp:

(WebCore::RenderText::setSelectionState):

  1. Add check to canUpdateSelectionOnRootLineBoxes to make sure our

root line boxes are still valid before setting them.

  1. Rename 'cb' to 'containingBlock', 'line' to 'root', move InlineTextBox

declaration to local.

  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Replace all calls to setSelectionState
with setSelectionStateIfNeeded.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setSelectionState):

  1. No need of checking if we are being set to same selection state.

Now tested by setSelectionStateIfNeeded.

LayoutTests:

  • editing/selection/first-letter-selection-crash-expected.txt: Added.
  • editing/selection/first-letter-selection-crash.html: Added.
1:04 PM Changeset in webkit [110322] by leviw@chromium.org
  • 9 edits in trunk/Source/WebCore

Move TransformationMatrix and TransformState to LayoutUnits.
​https://bugs.webkit.org/show_bug.cgi?id=80632

Reviewed by Simon Fraser.

When we move layout to sub-pixel precision, we want to preserve that precision through
transformations. This change readies TransformState and TransformationMatrix to make
use of this additional precision in accumulating transforms, and in returning rects that
preserve it.

No new tests. No change in behavior.

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::move): Changed to pass along LayoutUnits to the contained
TransformationMatrix. The values of the LayoutUnits will be implicitly converted to
floats to be applied.

  • platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::move): Ditto.
(TransformState):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::clampEdgeValue): Limiting edges to the maximum LayoutUnit value to prevent
overflow..
(WebCore::TransformationMatrix::clampedBoundsOfProjectedQuad): Same as above, but also
returning a LayoutRect which preserves additional precision than the previous IntRect.
(WebCore::TransformationMatrix::mapRect): Adding a version of this method that operates
specifically on FractionalLayoutRects.
(WebCore):

  • platform/graphics/transforms/TransformationMatrix.h:

(WebCore):
(TransformationMatrix):

  • rendering/LayoutTypes.h:

(WebCore::clampToLayoutUnit):
(WebCore):

12:53 PM Changeset in webkit [110321] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove a bogus assertion. This condition is no longer true for non-document tree scopes.

  • dom/TreeScope.cpp:

(WebCore::TreeScope::activeElement):

12:34 PM Changeset in webkit [110320] by rniwa@webkit.org
  • 12 edits in trunk/Source/WebCore

Cleanup incDOMTreeVersion callers
​https://bugs.webkit.org/show_bug.cgi?id=80452

Reviewed by Andreas Kling.

Unify various calls to incDOMTreeVersion and namely remove the call inside dispatchSubtreeModifiedEvent.
There should be no behavioral change and therefore there is no new test.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::childrenChanged):
(WebCore::notifyChildInserted):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::willModifyAttribute):

  • dom/Node.cpp:

(WebCore::Node::dispatchSubtreeModifiedEvent):

  • html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::childrenChanged):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::childrenChanged):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::childrenChanged):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::childrenChanged):

  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::childrenChanged):

  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::childrenChanged):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::childrenChanged):

12:29 PM Changeset in webkit [110319] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for !ENABLE(FILTERS) after r110285.

  • rendering/svg/SVGRenderingContext.h:

(WebCore::SVGRenderingContext::SVGRenderingContext):

12:27 PM Changeset in webkit [110318] by dbates@webkit.org
  • 26 edits in trunk

Bash scripts should support LF endings only
​https://bugs.webkit.org/show_bug.cgi?id=79509

Actually commit the changes that should have been landed in <​http://trac.webkit.org/changeset/110306>.
For some reason, webkit-patch land only committed the changes to the ChangeLog files.

12:22 PM Changeset in webkit [110317] by commit-queue@webkit.org
  • 15 edits in trunk/Source

[chromium] Use opaque paints in CCOcclusionTracker
​https://bugs.webkit.org/show_bug.cgi?id=80173

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-09
Reviewed by Adrienne Walker.

Source/WebCore:

Use tracked opaque paints in the tiles when tracking occlusion in
CCOcclusionTracker. Moves the Tile::m_opaqueRect up to the super-
class in CCLayerTilingData rather than having it declared in both
TiledLayerChromium and CCTiledLayerImpl. This lets the CCLayerTilingData
class compute the opaque region for its tiles, sharing code between the
two tiled layer implementations.

Use of this feature is guarded behind a runtime flag and turned off for
paint culling. We will enable it in the future once we're comfortable
with the paint culling.

Unit test: CCOcclusionTrackerTest.opaqueContentsRegionEmpty

CCOcclusionTrackerTest.opaqueContentsRegionNonEmpty
TiledLayerChromiumTest.opaqueContentsRegion

All existing CCOcclusionTrackerTest.* duplicated with opaque painted
rects.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::opaqueContentsRegion):
(LayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):
(WebCore::TiledLayerChromium::opaqueContentsRegion):
(WebCore):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::opaqueContentsRegion):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::opaqueRegionInLayerRect):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:

(WebCore):
(Tile):
(WebCore::CCLayerTilingData::Tile::opaqueRect):
(WebCore::CCLayerTilingData::Tile::setOpaqueRect):
(CCLayerTilingData):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::setUsePaintTracking):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(DrawableTile):
(WebCore::CCTiledLayerImpl::opaqueContentsRegion):
(WebCore):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::LayerChromiumWithForcedDrawsContent::opaqueContentsRegion):
(LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::setOpaquePaintRect):
(WebCore::setLayerPropertiesForTesting):
(WebCore):
(WebCore::layerAddedToOccludedRegion):
(WebCore::layerAddedToOccludedRegionWithRotation):
(WebCore::layerAddedToOccludedRegionWithTranslation):
(WebCore::layerAddedToOccludedRegionWithRotatedSurface):
(WebCore::layerAddedToOccludedRegionWithSurfaceAlreadyOnStack):
(WebCore::layerAddedToOccludedRegionWithRotatedOffAxisSurface):
(WebCore::layerAddedToOccludedRegionWithMultipleOpaqueLayers):
(WebCore::surfaceOcclusionWithOverlappingSiblingSurfaces):
(WebCore::surfaceOcclusionInScreenSpace):
(WebCore::surfaceOcclusionInScreenSpaceDifferentTransforms):
(WebCore::occlusionInteractionWithFilters):
(WebCore::layerScissorRectOverTile):
(WebCore::screenScissorRectOverTile):
(WebCore::layerScissorRectOverCulledTile):
(WebCore::screenScissorRectOverCulledTile):
(WebCore::layerScissorRectOverPartialTiles):
(WebCore::screenScissorRectOverPartialTiles):
(WebCore::layerScissorRectOverNoTiles):
(WebCore::screenScissorRectOverNoTiles):
(WebCore::layerScissorRectForLayerOffOrigin):
(WebCore::damageRectOverTile):
(WebCore::damageRectOverCulledTile):
(WebCore::damageRectOverPartialTiles):
(WebCore::damageRectOverNoTiles):
(WebCore::TEST):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

12:16 PM Changeset in webkit [110316] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Presentation attribute cache
​https://bugs.webkit.org/show_bug.cgi?id=80707

Reviewed by Andreas Kling.

It is common for the same presentation attribute values repeat. We should introduce a cache that uses
presentation attribute names and values as key. This will help to avoid repeated parsing of the
same attribute values, reduce memory consumption and speed up the style resolve.

This patch introduces a simple and small (128 entries) global cache. In general web browsing it seems
to give sharing rate of >75% (an average presentation attribute property set is shared between >4 elements).

  • dom/StyledElement.cpp:

(WebCore::PresentationAttributeCacheKey::PresentationAttributeCacheKey):
(PresentationAttributeCacheKey):
(WebCore):
(WebCore::operator!=):
(PresentationAttributeCacheEntry):
(WebCore::presentationAttributeCache):
(WebCore::attributeNameSort):
(WebCore::StyledElement::makePresentationAttributeCacheKey):
(WebCore::computePresentationAttributeCacheHash):
(WebCore::StyledElement::updateAttributeStyle):

  • dom/StyledElement.h:

(WebCore):
(StyledElement):

12:12 PM Changeset in webkit [110315] by arv@chromium.org
  • 7 edits
    6 adds in trunk

[V8] Fix object scope for inline event attribute handlers
​https://bugs.webkit.org/show_bug.cgi?id=80329

Reviewed by Ojan Vafai.

Source/WebCore:

We now create the funciton inside the with-statements with the current scope objects.
This is important for a few reasons:

  • We need to use the real objects and not just lookup the JS properties because these might have been overridden.
  • We need to use the node, form and document at the time of the preparation and not at the time of calling.
  • We need to ensure that event/evt is bound closer than a property with the same name in the object environment created by the with-statements.

Tests: fast/dom/inline-event-attributes-lookup-removed-form.html

fast/dom/inline-event-attributes-lookup-removed.html
fast/dom/inline-event-attributes-lookup.html

  • bindings/v8/ScriptEventListener.cpp:

(WebCore::eventParameterName):
(WebCore):
(WebCore::createAttributeEventListener):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):
(WebCore):
(WebCore::toObjectWrapper):
(WebCore::V8LazyEventListener::callListenerFunction):
(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8LazyEventListener.h:

(WebCore):
(WebCore::V8LazyEventListener::create):
(V8LazyEventListener):

LayoutTests:

  • fast/dom/inline-event-attributes-lookup-expected.txt: Added.
  • fast/dom/inline-event-attributes-lookup-removed-expected.txt: Added.
  • fast/dom/inline-event-attributes-lookup-removed-form-expected.txt: Added.
  • fast/dom/inline-event-attributes-lookup-removed-form.html: Added.
  • fast/dom/inline-event-attributes-lookup-removed.html: Added.
  • fast/dom/inline-event-attributes-lookup.html: Added.
  • fast/forms/lazy-event-listener-scope-chain-expected.txt:
  • fast/forms/lazy-event-listener-scope-chain.html:
12:07 PM Changeset in webkit [110314] by schenney@chromium.org
  • 3 edits in trunk/Source/WebCore

Crash in WebCore::SVGUseElement::instanceForShadowTreeElement
​https://bugs.webkit.org/show_bug.cgi?id=80406

Reviewed by Nikolas Zimmermann.

Code assumes that an object that is an SVG Element and in a shadow
tree must be in an SVG use shadow tree, and casts the shadow host with
a static_cast. It may be that an SVG element appears in a non-use
shadow tree, in which case bad things happen. While it appears that
the current code prevents such a situation from arising (checks are
made within the shadow tree code to prevent it) there are also
indications that the situation may change.

No new tests. I believe that the problem here cannot currently be
reproduced. That is, other code prevents SVG elements from appearing
in non-svg shadow trees.

  • dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingSVGTargetRules):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::title):

12:06 PM Changeset in webkit [110313] by ojan@chromium.org
  • 1647 edits in trunk/LayoutTests

2012-03-09 Ojan Vafai <​ojan@chromium.org (:ojan) (r)>

Add image/png svn:mime-type to all png images that currently lack
an svn:mime-type. Correctly this time.

12:00 PM Changeset in webkit [110312] by ojan@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Add image/png svn:mime-type to all png images that currently lack
and svn:mime-type.

11:41 AM Changeset in webkit [110311] by jonlee@apple.com
  • 25 edits in trunk

Add support for ENABLE(LEGACY_NOTIFICATIONS)
​https://bugs.webkit.org/show_bug.cgi?id=80497

Reviewed by Adam Barth.

.:

Prep for b80472: Update API for Web Notifications

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:

Source/WebKit/chromium:

Prep for b80472: Update API for Web Notifications

  • features.gypi:

Source/WebKit/mac:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/qt:

Prep for b80472: Update API for Web Notifications

  • examples/platformplugin/platformplugin.pro:

Source/WebKit2:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Tools:

Prep for b80472: Update API for Web Notifications

  • Scripts/build-webkit:
  • qmake/mkspecs/features/features.prf:

WebKitLibraries:

Prep for b80472: Update API for Web Notifications

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
11:38 AM Changeset in webkit [110310] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

ShadowRoot should implement activeElement.
​https://bugs.webkit.org/show_bug.cgi?id=79886

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-03-09
Reviewed by Ryosuke Niwa.

Source/WebCore:

Implement the activeElement attribute for ShadowRoot to return the
currently focused element in the shadow DOM subtree.

Test: fast/dom/shadow/shadow-root-activeElement.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::activeElement):
(WebCore):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/ShadowRoot.idl:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::adoptIfNeeded):
(WebCore):
(WebCore::focusedFrameOwnerElement):
(WebCore::TreeScope::activeElement):

  • dom/TreeScope.h:

(TreeScope):

  • html/HTMLDocument.cpp:

(WebCore):
(WebCore::HTMLDocument::activeElement):

LayoutTests:

Added test case for activeElement attribute of ShadowRoot.

  • fast/dom/shadow/shadow-root-activeElement-expected.txt: Added.
  • fast/dom/shadow/shadow-root-activeElement.html: Added.
  • platform/mac/Skipped: Added test case in Skipped as ShadowRoot is supported by Chromium only.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.
  • platform/wincairo/Skipped: ditto.
  • platform/wk2/Skipped: ditto.
11:21 AM Changeset in webkit [110309] by timothy_horton@apple.com
  • 8 edits in trunk/Source/WebCore

Infinite repaint loop with SVGImageCache and deferred repaint timers
​https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Reviewed by Nikolas Zimmermann.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.

No new tests, as the problem only occurs in a nonstandard configuration.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):

  • svg/graphics/SVGImage.h:

(WebCore):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

11:16 AM Changeset in webkit [110308] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

Source/WebCore: The method TextTrackCue::getCueAsHTML() should return different
fragments on different calls.

​https://bugs.webkit.org/show_bug.cgi?id=80701

Patch by Victor Carbune <​vcarbune@adobe.com> on 2012-03-09
Reviewed by Eric Carlson.

Test: media/track/track-cue-mutable-fragment.html

  • html/track/TextTrackCue.cpp: Removed setCueHTML(), since it is sufficient

to create apply the DOM rules only when the fragment is first requested.
(WebCore::TextTrackCue::getCueAsHTML): Changed the method such that a
a clone of the cached document fragment is returned.

  • html/track/TextTrackCue.h: Removed setCueHTML() as the document fragment

of the cue should be created only within the class, from the cue text.
(TextTrackCue):

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::createNewCue): removed usage of setCueHTML()

LayoutTests: Added relevant layout tests to verify that the fragment can be appended
multiple times to the DOM and modified correctly.

​https://bugs.webkit.org/show_bug.cgi?id=80701

Patch by Victor Carbune <​vcarbune@adobe.com> on 2012-03-09
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/captions-html.vtt: Added. This file could

be used later for more complex html / css rendering tests.

  • media/track/track-cue-mutable-fragment-expected.txt: Added.
  • media/track/track-cue-mutable-fragment.html: Added.
11:13 AM Changeset in webkit [110307] by timothy_horton@apple.com
  • 5 edits
    2 adds in trunk

Crash in SVGTextLayoutAttributesBuilder::fillCharacterDataMap
​https://bugs.webkit.org/show_bug.cgi?id=78949
<rdar://problem/10889440>

Reviewed by Nikolas Zimmermann.

Invalidate the text positioning cache when the children of an SVGAElement change,
so that we regenerate the list the next time it's needed instead of using stale values.

Test: svg/text/text-positioning-remove-child-crash.svg

  • rendering/svg/SVGAElement.cpp:

(WebCore::SVGAElement::childrenChanged):

Add a test ensuring that we don't crash when removing a child of <a> inside a <text> block.

  • svg/text/text-positioning-remove-child-crash-expected.txt: Added.
  • svg/text/text-positioning-remove-child-crash.svg: Added.
11:09 AM Changeset in webkit [110306] by dbates@webkit.org
  • 9 edits in trunk

Bash scripts should support LF endings only
​https://bugs.webkit.org/show_bug.cgi?id=79509

Patch by Ashod Nakashian <​ashodnakashian@yahoo.com> on 2012-03-09
Reviewed by David Kilzer.

Source/JavaScriptCore:

  • gyp/generate-derived-sources.sh: Added property svn:eol-style.
  • gyp/run-if-exists.sh: Added property svn:eol-style.
  • gyp/update-info-plist.sh: Added property svn:eol-style.

Source/ThirdParty:

  • gtest/xcode/Samples/FrameworkSample/runtests.sh: Added property svn:executable.
  • gtest/xcode/Scripts/runtests.sh: Added property svn:executable.

Source/ThirdParty/ANGLE:

  • src/compiler/generate_parser.sh: Added property svn:eol-style.

Source/WebCore:

  • WebCore.gyp/mac/adjust_visibility.sh: Added property svn:eol-style.
  • WebCore.vcproj/build-generated-files.sh: Added property svn:executable.
  • WebCore.vcproj/migrate-scripts.sh: Added property svn:executable.
  • gyp/copy-forwarding-and-icu-headers.sh: Added property svn:eol-style.
  • gyp/copy-inspector-resources.sh: Added property svn:eol-style.
  • gyp/generate-derived-sources.sh: Added property svn:eol-style.
  • gyp/generate-webcore-export-file-generator.sh: Added property svn:eol-style.
  • gyp/run-if-exists.sh: Added property svn:eol-style.
  • gyp/streamline-inspector-source.sh: Added property svn:eol-style.
  • gyp/update-info-plist.sh: Added property svn:eol-style.

Source/WebKit2:

  • win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.

Tools:

  • EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
  • EWSTools/start-queue.sh: Added property svn:eol-style.
  • Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
  • WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
  • iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
  • iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.

WebKitLibraries:

  • win/tools/scripts/feature-defines.sh: Modified property svn:eol-style.

Websites/bugs.webkit.org:

  • contrib/yp_nomail.sh: Added property svn:executable.

LayoutTests:

  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sh.sh: Added property svn:executable.
11:05 AM Changeset in webkit [110305] by kling@webkit.org
  • 9 edits in trunk/Source/WebCore

CSSParser: Use Vector for intermediate property storage.
<​http://webkit.org/b/80653>

Reviewed by Antti Koivisto.

Remove the custom memory management for intermediate CSSProperties in CSSParser
and replace it by a Vector<CSSProperty, 256>.
This avoids heap allocations and removes a bunch of unnecessary complexity.

Remove WTF_MAKE_FAST_ALLOCATED from CSSProperty since they are only created on
the stack now.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::rollbackLastProperties):
(WebCore::CSSParser::clearProperties):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createMarginAtRule):
(WebCore::CSSParser::startDeclarationsForMarginBox):
(WebCore::CSSParser::endDeclarationsForMarginBox):
(WebCore::CSSParser::deleteFontFaceOnlyValues):
(WebCore::CSSParser::createKeyframeRule):

  • css/CSSParser.h:

(WebCore::CSSParser::hasProperties):
(CSSParser):

  • css/CSSProperty.h:
  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::addParsedProperties):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::create):
(StylePropertySet):

10:02 AM Changeset in webkit [110304] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note that fast/events/input-image-scrolled-x-y.html is flaky.

  • platform/chromium/test_expectations.txt:
9:59 AM Changeset in webkit [110303] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r109022): Files dragged onto input controls cannot be read due to sandbox violation.
​https://bugs.webkit.org/show_bug.cgi?id=80203
<rdar://problem/10976643>

Reviewed by Alexey Proskuryakov.

This patch reverts a small part fo r109022, leaving access to
NSPasteboard in the WebProcess when retrieving pathnames for
files being dragged. This avoid the sandbox violation until we
implement a mechanism to provide a sandbox extension to the WebProcess.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPathnamesForType):

9:56 AM Changeset in webkit [110302] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Windows debug build fix.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlind):
Fix unreachable code warnings (which we treat as errors).

9:36 AM Changeset in webkit [110301] by Nate Chapin
  • 3 edits
    3 adds in trunk

2012-03-09 Nate Chapin <Nate Chapin>

CachedRawResource breaks when trying to load
a resource with an empty response body from cache.

Reviewed by Alexey Proskuryakov.

Test: http/tests/cache/zero-length-xhr.html

  • loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::didAddClient): Don't exit early

if m_data is empty, we may still need to notifyFinished().

9:30 AM Changeset in webkit [110300] by commit-queue@webkit.org
  • 1 edit
    5 adds in trunk/Source/WebCore

[BlackBerry] Upstream classes that handle layer tiling
​https://bugs.webkit.org/show_bug.cgi?id=79875

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2012-03-09
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

  • platform/graphics/blackberry/LayerTile.cpp: Added.

(WebCore):
(WebCore::LayerTile::LayerTile):
(WebCore::LayerTile::~LayerTile):
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::setContentsToColor):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::discardContents):
(WebCore::LayerTile::setVisible):
(WebCore::LayerTile::setTexture):

  • platform/graphics/blackberry/LayerTile.h: Added.

(WebCore):
(LayerTileData):
(WebCore::LayerTileData::LayerTileData):
(WebCore::LayerTileData::isVisible):
(LayerTile):
(WebCore::LayerTile::texture):
(WebCore::LayerTile::isVisible):
(WebCore::LayerTile::isDirty):
(WebCore::LayerTile::hasTexture):
(WebCore::LayerTile::setContentsDirty):

  • platform/graphics/blackberry/LayerTileIndex.h: Added.

(WebCore):
(TileIndex):
(WebCore::TileIndex::TileIndex):
(WebCore::TileIndex::~TileIndex):
(WebCore::TileIndex::i):
(WebCore::TileIndex::j):
(WebCore::TileIndex::setIndex):
(WebCore::operator==):
(WebCore::operator!=):
(WTF):

  • platform/graphics/blackberry/LayerTiler.cpp: Added.

(WebCore):
(WebCore::transformPoint):
(WebCore::defaultTileSize):
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::~LayerTiler):
(WebCore::LayerTiler::layerWebKitThreadDestroyed):
(WebCore::LayerTiler::layerCompositingThreadDestroyed):
(WebCore::LayerTiler::setNeedsDisplay):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::shouldPerformRenderJob):
(WebCore::LayerTiler::addTextureJob):
(WebCore::LayerTiler::clearTextureJobs):
(WebCore::LayerTiler::commitPendingTextureUploads):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::drawMissingTextures):
(WebCore::LayerTiler::drawTexturesInternal):
(WebCore::LayerTiler::addRenderJob):
(WebCore::LayerTiler::removeRenderJob):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::updateTileSize):
(WebCore::LayerTiler::disableTiling):
(WebCore::LayerTiler::shouldPrefillTile):
(WebCore::LayerTiler::indexOfTile):
(WebCore::LayerTiler::originOfTile):
(WebCore::LayerTiler::rectForTile):
(WebCore::LayerTiler::hasDirtyTiles):
(WebCore::LayerTiler::bindContentsTexture):

  • platform/graphics/blackberry/LayerTiler.h: Added.

(WebCore):
(LayerTiler):
(WebCore::LayerTiler::create):
(WebCore::LayerTiler::layer):
(WebCore::LayerTiler::hasMissingTextures):
(WebCore::LayerTiler::TextureJob::TextureJob):
(TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::setContentsToColor):
(WebCore::LayerTiler::TextureJob::updateContents):
(WebCore::LayerTiler::TextureJob::discardContents):
(WebCore::LayerTiler::TextureJob::resizeContents):
(WebCore::LayerTiler::TextureJob::dirtyContents):
(WebCore::LayerTiler::TextureJob::isNull):
(WebCore::LayerTiler::tileSize):
(WebCore::LayerTiler::removeUpdateContentsJobs):

8:49 AM Changeset in webkit [110299] by commit-queue@webkit.org
  • 23 edits in trunk/Source

[chromium] Ensure we use the correct time when notifying animation started
​https://bugs.webkit.org/show_bug.cgi?id=79537

Patch by Ian Vollick <​vollick@chromium.org> on 2012-03-09
Reviewed by James Robinson

Source/WebCore:

Tested in CCLayerTreeHostTestAddAnimation

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setAnimationEvent):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCAnimationEvents.cpp:

(WebCore::CCAnimationStartedEvent::create):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):

  • platform/graphics/chromium/cc/CCAnimationEvents.h:

(CCAnimationEvent):
(CCAnimationStartedEvent):

  • platform/graphics/chromium/cc/CCInputHandler.h:

(CCInputHandler):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:

(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::resolveConflicts):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:

(CCLayerAnimationControllerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::animateLayersRecursive):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCPageScaleAnimation.cpp:

(WebCore::CCPageScaleAnimation::create):
(WebCore::CCPageScaleAnimation::CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::zoomTo):
(WebCore::CCPageScaleAnimation::zoomWithAnchor):
(WebCore::CCPageScaleAnimation::scrollOffsetAtTime):
(WebCore::CCPageScaleAnimation::pageScaleAtTime):
(WebCore::CCPageScaleAnimation::isAnimationCompleteAtTime):
(WebCore::CCPageScaleAnimation::progressRatioForTime):

  • platform/graphics/chromium/cc/CCPageScaleAnimation.h:

(CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::startTime):
(WebCore::CCPageScaleAnimation::duration):
(WebCore::CCPageScaleAnimation::endTime):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::startPageScaleAnimation):
(WebCore::CCSingleThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::startPageScaleAnimation):
(WebCore::CCThreadProxy::requestStartPageScaleAnimationOnImplThread):
(WebCore::CCThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::setAnimationEvents):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::willDraw):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::postAnimationEventsToMainThreadOnImplThread):
(WebKit::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::animateLayers):
(WTF::TestHooks::updateAnimations):
(WTF::MockLayerTreeHostImpl::animateLayers):
(WTF::MockLayerTreeHostClient::updateAnimations):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationStarted):
(CCLayerTreeHostTestAddAnimation):

7:45 AM Changeset in webkit [110298] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
7:25 AM Changeset in webkit [110297] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip flaky svg tests.
7:22 AM Changeset in webkit [110296] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BUILD] use detected python to run generate-gtkdoc
​https://bugs.webkit.org/show_bug.cgi?id=80695

Patch by Ionut Biru <​ibiru@archlinux.org> on 2012-03-09
Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Use $(PYTHON) instead of plain python
7:13 AM Changeset in webkit [110295] by Csaba Osztrogonác
  • 46 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped:
  • platform/qt/editing/selection/3690703-2-expected.png:
  • platform/qt/editing/selection/3690703-2-expected.txt:
  • platform/qt/editing/selection/3690703-expected.png:
  • platform/qt/editing/selection/3690703-expected.txt:
  • platform/qt/editing/selection/3690719-expected.png:
  • platform/qt/editing/selection/3690719-expected.txt:
  • platform/qt/fast/css/text-overflow-input-expected.txt: Added.
  • platform/qt/fast/forms/basic-inputs-expected.png: Added.
  • platform/qt/fast/forms/basic-inputs-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.png:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.png:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.png:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/qt/tables/mozilla/dom/tableDom-expected.png:
  • platform/qt/tables/mozilla/dom/tableDom-expected.txt:
  • platform/qt/tables/mozilla/other/move_row-expected.png:
  • platform/qt/tables/mozilla/other/move_row-expected.txt:
  • platform/qt/test_expectations.txt:
7:08 AM Changeset in webkit [110294] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Layout test for window.devicePixelRatio
​https://bugs.webkit.org/show_bug.cgi?id=80292

Patch by Konrad Piascik <​kpiascik@rim.com> on 2012-03-09
Reviewed by Philippe Normand.

Update the skipped list for ports where fast/viewport/viewport-133.html is failing.

  • platform/efl/Skipped:
  • platform/gtk/Skipped:
7:08 AM WebKitGTK/1.8.x edited by kov@webkit.org
Adding "[BUILD] use detected python to run generate-gtkdoc" to on track (diff)
6:25 AM Changeset in webkit [110293] by Csaba Osztrogonác
  • 224 edits
    2 copies
    7 adds in trunk/LayoutTests

[Qt] Rebaseline some tests on qt platfrom

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.

  • platform/qt/ [...]: Update expected files.
  • platform/qt/test_expectations.txt: Unskip now passing tests.
5:59 AM Changeset in webkit [110292] by Nikolas Zimmermann
  • 296 edits
    35 adds in trunk/LayoutTests

2012-03-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Rebaseline some Mac results that needed rebaselining - using Lion, and a Generic RGB Color profile.
Had to manually switch to this, until this is done automatically, see bug 80571.

Re-add several results that got deleted or moved to mac-future. I guess this is garden-o-matic
misusage? Not sure, anyhow, there are clearly a dozen of missing SVG pixel tests before this patch.

Reviewed by NOBODY (OOPS!).

  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac/svg/batik/filters/feTile-expected.png:
  • platform/mac/svg/batik/filters/filterRegions-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.png: Added.
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
  • platform/mac/svg/carto.net/scrollbar-expected.png: Added.
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/path-gradient-stroke-shadow-expected.png:
  • platform/mac/svg/css/rect-gradient-stroke-shadow-expected.png:
  • platform/mac/svg/custom/convolution-crash-expected.png:
  • platform/mac/svg/custom/empty-merge-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.png:
  • platform/mac/svg/custom/recursive-filter-expected.png:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/mac/svg/custom/root-container-opacity-clip-viewBox-expected.png:
  • platform/mac/svg/custom/text-filter-expected.png:
  • platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
  • platform/mac/svg/custom/visibility-override-filter-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png:
  • platform/mac/svg/filters/big-sized-filter-2-expected.png:
  • platform/mac/svg/filters/big-sized-filter-expected.png:
  • platform/mac/svg/filters/feColorMatrix-default-type-expected.png:
  • platform/mac/svg/filters/feColorMatrix-offset-expected.png:
  • platform/mac/svg/filters/feColorMatrix-values-expected.png:
  • platform/mac/svg/filters/feComposite-expected.png:
  • platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png:
  • platform/mac/svg/filters/feDisplacementMap-expected.png:
  • platform/mac/svg/filters/feDropShadow-expected.png:
  • platform/mac/svg/filters/feGaussianBlur-expected.png:
  • platform/mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
  • platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/mac/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.png:
  • platform/mac/svg/filters/feImage-position-expected.png:
  • platform/mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/mac/svg/filters/feImage-subregions-expected.png:
  • platform/mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/mac/svg/filters/feImage-target-add-to-document-expected.png:
  • platform/mac/svg/filters/feImage-target-attribute-change-expected.png:
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
  • platform/mac/svg/filters/feImage-target-changes-id-expected.png:
  • platform/mac/svg/filters/feImage-target-id-change-expected.png:
  • platform/mac/svg/filters/feImage-target-inline-style-change-expected.png:
  • platform/mac/svg/filters/feImage-target-property-change-expected.png:
  • platform/mac/svg/filters/feImage-target-reappend-to-document-expected.png:
  • platform/mac/svg/filters/feImage-target-remove-from-document-expected.png:
  • platform/mac/svg/filters/feImage-target-style-change-expected.png:
  • platform/mac/svg/filters/feLighting-crash-expected.png:
  • platform/mac/svg/filters/feMerge-expected.png:
  • platform/mac/svg/filters/feOffset-expected.png:
  • platform/mac/svg/filters/feTile-expected.png:
  • platform/mac/svg/filters/filter-clip-expected.png:
  • platform/mac/svg/filters/filter-on-tspan-expected.png:
  • platform/mac/svg/filters/filter-placement-issue-expected.png:
  • platform/mac/svg/filters/filter-refresh-expected.png:
  • platform/mac/svg/filters/filter-rounding-issues-expected.png:
  • platform/mac/svg/filters/filter-source-position-expected.png:
  • platform/mac/svg/filters/filter-width-update-expected.png:
  • platform/mac/svg/filters/filterRes-expected.png:
  • platform/mac/svg/filters/filterRes1-expected.png:
  • platform/mac/svg/filters/filterRes2-expected.png:
  • platform/mac/svg/filters/filterRes3-expected.png:
  • platform/mac/svg/filters/filteredImage-expected.png:
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/mac/svg/filters/shadow-on-filter-expected.png:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/mac/svg/filters/subRegion-in-userSpace-expected.png:
  • platform/mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/svg/repaint/filter-child-repaint-expected.png:
  • platform/mac/svg/repaint/filter-repaint-expected.png:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
  • platform/mac/test_expectations.txt:
  • svg/filters/animate-fill-expected.png:
  • svg/filters/feColorMatrix-saturate-expected.png:
  • svg/filters/feImage-reference-invalidation-expected.png:
  • svg/filters/feImage-reference-svg-primitive-expected.png:
  • svg/foreignObject/filter-expected.png:
5:13 AM Changeset in webkit [110291] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Fix compilation without QtQuick1
​https://bugs.webkit.org/show_bug.cgi?id=80503

Qt 4.8 API test fix after r110050.

Reviewed by Zoltan Herczeg.

  • declarative/public.pri: Add load(features) to ensure HAVE_QQUICK1=1 is set.
5:11 AM Changeset in webkit [110290] by charles.wei@torchmobile.com.cn
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Web Notification not working after rebase
​https://bugs.webkit.org/show_bug.cgi?id=80690

Reviewed by George Staikos.

  1. NotificationPresenterImpl should be in namespace WebCore
  2. Need to connect NotificationPresenterImpl to webcore the new way: WebCore::provideNotification(Page*, NotificationPresenter*)
  3. Remove the old way of connecting the Notification: ChromeClientBlackBerry::notificationPresenter()
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

  • WebCoreSupport/NotificationPresenterImpl.cpp:
  • WebCoreSupport/NotificationPresenterImpl.h:
4:45 AM Changeset in webkit [110289] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Patch by Thouraya ANDOLSI <​thouraya.andolsi@st.com> on 2012-03-09
Reviewed by Zoltan Herczeg.

[Qt] Fix the SH4 build after r109834
​https://bugs.webkit.org/show_bug.cgi?id=80492

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchAdd32):
(JSC::MacroAssemblerSH4::branchSub32):

4:16 AM Changeset in webkit [110288] by Csaba Osztrogonác
  • 2 edits in trunk

[Qt] Disable WebGL performance tests temporarily.
​https://bugs.webkit.org/show_bug.cgi?id=80503

Rubber-stamped by Simon Hausmann.

  • Source/tests.pri:
4:06 AM Changeset in webkit [110287] by wingo@igalia.com
  • 11 edits in trunk/Source/JavaScriptCore

Refactor code feature analysis in the parser
​https://bugs.webkit.org/show_bug.cgi?id=79112

Reviewed by Geoffrey Garen.

This commit refactors the parser to more uniformly propagate flag
bits down and up the parse process, as the parser descends and
returns into nested blocks. Some flags get passed town to
subscopes, some apply to specific scopes only, and some get
unioned up after parsing subscopes.

The goal is to eventually be very precise with scoping
information, once we have block scopes: one block scope might use
`eval', which would require the emission of a symbol table within
that block and containing blocks, whereas another block in the
same function might not, allowing us to not emit a symbol table.

  • parser/Nodes.h:

(JSC::ScopeFlags): Rename from CodeFeatures.
(JSC::ScopeNode::addScopeFlags):
(JSC::ScopeNode::scopeFlags): New accessors for m_scopeFlags.
(JSC::ScopeNode::isStrictMode):
(JSC::ScopeNode::usesEval):
(JSC::ScopeNode::usesArguments):
(JSC::ScopeNode::setUsesArguments):
(JSC::ScopeNode::usesThis):
(JSC::ScopeNode::needsActivationForMoreThanVariables):
(JSC::ScopeNode::needsActivation): Refactor these accessors to
operate on the m_scopeFlags member.
(JSC::ScopeNode::source):
(JSC::ScopeNode::sourceURL):
(JSC::ScopeNode::sourceID): Shuffle these definitions around; no
semantic change.
(JSC::ScopeNode::ScopeNode)
(JSC::ProgramNode::ProgramNode)
(JSC::EvalNode::EvalNode)
(JSC::FunctionBodyNode::FunctionBodyNode): Have these constructors
take a ScopeFlags as an argument, instead of a bool inStrictContext.

  • parser/Nodes.cpp:

(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create): Adapt constructors to change.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::addVar):
(JSC::ASTBuilder::Scope::Scope):
(Scope):
(ASTBuilder):
(JSC::ASTBuilder::makeFunctionCallNode): Don't track scope
features here. Instead rely on the base Parser mechanism to track
features.

  • parser/NodeInfo.h (NodeInfo, NodeDeclarationInfo): "ScopeFlags".
  • parser/Parser.h:

(JSC::Scope::Scope): Manage scope through flags, not
bit-booleans. This lets us uniformly propagate them up and down.
(JSC::Scope::declareWrite):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::getCapturedVariables):
(JSC::Scope::saveFunctionInfo):
(JSC::Scope::restoreFunctionInfo):
(JSC::Parser::pushScope): Adapt to use scope flags and their
accessors instead of bit-booleans.

  • parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseInner):
(JSC::::didFinishParsing):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseWithStatement):
(JSC::::parseTryStatement):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parsePrimaryExpression): Hoist some of the flag handling
out of the "context" (ASTBuilder or SyntaxChecker) and to here.
Does not seem to have a performance impact.

  • parser/SourceProviderCacheItem.h (SourceProviderCacheItem):

Cache the scopeflags.

  • parser/SyntaxChecker.h: Remove evalCount() decl.
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):

  • runtime/Executable.h:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::isStrictMode):
(JSC::ScriptExecutable::recordParse):
(ScriptExecutable): ScopeFlags, not features.

4:03 AM Changeset in webkit [110286] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip new tests without expected files, need investigation.
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.png: Updated.
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt: Updated.
4:02 AM Changeset in webkit [110285] by zherczeg@webkit.org
  • 17 edits
    2 adds in trunk/Source/WebCore

Add SVGRenderingContext and move there the context related code from SVGRenderSupport
​https://bugs.webkit.org/show_bug.cgi?id=80413

Reviewed by Nikolas Zimmermann.

This is the first step of refactoring the rendering context for SVG. The
previous context was stateless before, which means the cleanup phase
needed to do a lot of checks to revert the initialization part and
was unaware of failed inititalization. Future code can also add
new local variables to the context.

This patch add a new SVGRenderingContext class, and moves there the context
initialization / cleanup code from SVGRenderSupport. All build systems were
updated.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/svg/RenderSVGAllInOne.cpp:
  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::paint):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::paint):

  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paint):

  • rendering/svg/SVGRenderSupport.cpp:
  • rendering/svg/SVGRenderSupport.h:
  • rendering/svg/SVGRenderingContext.cpp: Added.

(WebCore):
(WebCore::isRenderingMaskImage):
(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGRenderingContext.h: Added.

(WebCore):
(SVGRenderingContext):
(WebCore::SVGRenderingContext::SVGRenderingContext):
(WebCore::SVGRenderingContext::isRenderingPrepared):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint):

3:52 AM CommitterTips edited by Csaba Osztrogonác
Add some more tips for unreviewed buildfixes (diff)
3:45 AM Changeset in webkit [110284] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening, skip 3 failing tests.

Patch by Nándor Huszka <​huszka.nandor@stud.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
3:16 AM Changeset in webkit [110283] by Csaba Osztrogonác
  • 13 edits
    2 deletes in trunk

Unreviewed, rolling out r110191, r110202, and r110279.
​http://trac.webkit.org/changeset/110191
​http://trac.webkit.org/changeset/110202
​http://trac.webkit.org/changeset/110279
​https://bugs.webkit.org/show_bug.cgi?id=80694

They broke !ENABLE(INSPECTOR) builds (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-09

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • testing/Internals.cpp:
  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • inspector/elements/highlight-node-expected.txt: Removed.
  • inspector/elements/highlight-node.html: Removed.
3:13 AM Changeset in webkit [110282] by nduca@chromium.org
  • 3 edits in trunk/Tools

Make check-webkit-style complain about "no new tests" lines in changelogs
​https://bugs.webkit.org/show_bug.cgi?id=80582

Reviewed by David Levin.

  • Scripts/webkitpy/style/checkers/changelog.py:

(ChangeLogChecker.check_entry):

  • Scripts/webkitpy/style/checkers/changelog_unittest.py:

(ChangeLogCheckerTest.test_no_new_tests):

2:56 AM Changeset in webkit [110281] by hans@chromium.org
  • 4 edits
    6 copies
    2 adds in trunk

Speech JavaScript API: add SpeechGrammar and SpeechGrammarList
​https://bugs.webkit.org/show_bug.cgi?id=80417

Reviewed by Adam Barth.

Source/WebCore:

Implement SpeechGrammar and SpeechGrammarList.
(Spec: ​http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)

Test: fast/speech/scripted/speechgrammar-basics.html

  • Modules/speech/DOMWindowSpeech.idl:
  • Modules/speech/SpeechGrammar.cpp:

(WebCore):
(WebCore::SpeechGrammar::create):
(WebCore::SpeechGrammar::SpeechGrammar):

  • Modules/speech/SpeechGrammar.h:

(WebCore):
(SpeechGrammar):
(WebCore::SpeechGrammar::src):
(WebCore::SpeechGrammar::setSrc):
(WebCore::SpeechGrammar::weight):
(WebCore::SpeechGrammar::setWeight):

  • Modules/speech/SpeechGrammar.idl:
  • Modules/speech/SpeechGrammarList.cpp:

(WebCore):
(WebCore::SpeechGrammarList::create):
(WebCore::SpeechGrammarList::item):
(WebCore::SpeechGrammarList::addFromUri):
(WebCore::SpeechGrammarList::addFromString):
(WebCore::SpeechGrammarList::SpeechGrammarList):

  • Modules/speech/SpeechGrammarList.h:

(WebCore):
(SpeechGrammarList):
(WebCore::SpeechGrammarList::length):

  • Modules/speech/SpeechGrammarList.idl:
  • WebCore.gypi:

LayoutTests:

Add a test for SpeechGrammar and SpeechGrammarList.

  • fast/speech/scripted/speechgrammar-basics-expected.txt: Added.
  • fast/speech/scripted/speechgrammar-basics.html: Added.
2:39 AM Changeset in webkit [110280] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r110269.
​http://trac.webkit.org/changeset/110269
​https://bugs.webkit.org/show_bug.cgi?id=80688

It made inspector/elements/highlight-node.html fail everywhere
(Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-09

  • testing/Internals.idl:
1:55 AM Changeset in webkit [110279] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed, build fix after r110191

  • features.gypi:
1:51 AM Changeset in webkit [110278] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] Click in the first line of rule while editing property starts a new property
​https://bugs.webkit.org/show_bug.cgi?id=80507

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._checkWillCancelEditing):
(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertyTreeElement.prototype.onattach):
(WebInspector.StylePropertyTreeElement.prototype):

1:33 AM Changeset in webkit [110277] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/11012024> Fix the build by working around <rdar://problem/10710970>.

  • platform/mac/RunLoopMac.mm:

(WebCore::RunLoop::stop):

1:27 AM Changeset in webkit [110276] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening, skip two failing tests and a timeouting one.

Patch by Nándor Huszka <​huszka.nandor@stud.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
1:01 AM Changeset in webkit [110275] by commit-queue@webkit.org
  • 13 edits
    4 adds in trunk

FileInputType doesn't support (save|restore)FormControlState
​https://bugs.webkit.org/show_bug.cgi?id=80145

Patch by Marja Hölttä <​marja@google.com> on 2012-03-09
Reviewed by Kent Tamura.

Source/WebCore:

This enables saving and restoring the state of file upload elements in
unsubmitted forms.

Test: fast/forms/file/recover-file-input-in-unposted-form.html

  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::restoreFormControlState): non-const

  • html/BaseCheckableInputType.h:

(BaseCheckableInputType): restoreFormControlState non-const

  • html/FileInputType.cpp:

(WebCore::FileInputType::saveFormControlState): save chosen files
(WebCore):
(WebCore::FileInputType::restoreFormControlState): restore chosen files

  • html/FileInputType.h:

(FileInputType): overwrite (save|restore)FormControlState

  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::restoreFormControlState): non-const

  • html/HiddenInputType.h:

(HiddenInputType): restoreFormControlState non-const

  • html/InputType.cpp:

(WebCore::InputType::restoreFormControlState): non-const

  • html/InputType.h:

(InputType): restoreFormControlState non-const

  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::restoreFormControlState): non-const

  • html/PasswordInputType.h:

(PasswordInputType): restoreFormControlState non-const

LayoutTests:

Tests for saving and restoring the state of file upload elements in unsubmitted forms.

  • fast/forms/file/recover-file-input-in-unposted-form-expected.txt: Added.
  • fast/forms/file/recover-file-input-in-unposted-form.html: Added.
  • platform/wk2/Skipped: The added test needs eventSender.beginDragWithFiles.
12:48 AM Changeset in webkit [110274] by toyoshim@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

[WebSocket] Add a layout test where server force to disable all extensions
​https://bugs.webkit.org/show_bug.cgi?id=80650

Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/echo-with-no-extension-expected.txt: Added.
  • http/tests/websocket/tests/hybi/echo-with-no-extension.html: Check if extension property is always empty string.
  • http/tests/websocket/tests/hybi/echo-with-no-extension_wsh.py: Added a handler which disable all extensions.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/extensions-expected.txt: Updated.
  • http/tests/websocket/tests/hybi/extensions.html: Added the case after connection is established.
12:42 AM Changeset in webkit [110273] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

Unreviewed, rolling out r110250.
​http://trac.webkit.org/changeset/110250
​https://bugs.webkit.org/show_bug.cgi?id=80682

It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
qt-linux at all. (Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-09

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest.test_baseline_search_path):

Mar 8, 2012:

11:39 PM Changeset in webkit [110272] by vestbo@webkit.org
  • 35 edits
    1 add
    2 deletes in trunk

[Qt] Use Qt's module system for install rules and depending on QtWebKit

Instead of rolling our own install rules we now use the same approach as
every other Qt module, by loading qt_module.prf and qt_module_config.prf.

This ensures that we follow the same semantics as the rest of Qt on
what sort of config options are enabled by default (create_cmake eg.).
It also allows us to use QT += webkit instead of the workaround we had
with CONFIG += qtwebkit.

We do however force Qt to always treat our build as a non-developer build,
so the libraries will end up in the WebKit lib directory instead of the
qtbase directory (as with a normal developer-build). This allows us to
keep the webkit-build self-contained. If Qt is a developer build we still
copy the module file manually to Qt, so that you don't have to install
WebKit to make it available.

For non-developer builds of Qt, it is still possible to use the built
WebKit libraries without having to install them, by having the variable
QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.

​https://bugs.webkit.org/show_bug.cgi?id=80590

Reviewed by Simon Hausmann.

11:33 PM Changeset in webkit [110271] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Base the access to CSSStyleDeclaration on the CSSPropertyID instead of the PropertyName
​https://bugs.webkit.org/show_bug.cgi?id=80461

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-03-08
Reviewed by Geoffrey Garen.

Previously, the acces to CSS Style properties was done through a NamedGetter. This caused
the (slow) mapping between CSSPropertyName and CSSPropertyID to be done twice for every acess:
1) canGetItemsForName() prior to the definition of the slot.
2) nameGetter() called from the slot with CSSPropertyName to get the actual value.

This patch changes the access to be based on CSSPropertyID. The slot is defined with the
CSSPropertyID as the customIndex, and the value can be accessed directly when the slot is
called.

To handle the differences create by hadPixelOrPosPrefix, two nearly identical callback are defined,
one for hadPixelOrPosPrefix, the other for !hadPixelOrPosPrefix.

The performance gain is about 19% when accessing CSS properties.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::getPropertyValueFallback):
(WebCore::cssPropertyGetterPixelOrPosPrefix):
(WebCore):
(WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
(WebCore::cssPropertyGetter):
(WebCore::cssPropertyGetterCallback):
(WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
(WebCore::JSCSSStyleDeclaration::getOwnPropertyDescriptorDelegate):

  • css/CSSStyleDeclaration.idl:
11:33 PM Changeset in webkit [110270] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit/efl

[Texmap][EFL] Implementation of AcceleratedCompositingContext for EFL port
​https://bugs.webkit.org/show_bug.cgi?id=80266

Patch by Hyowon Kim <​hw1008.kim@samsung.com> on 2012-03-08
Reviewed by Noam Rosenthal.

This patch adds EFL's implementation of AcceleratedCompositingContext to WebCoreSupport.

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp: Added.

(WebCore):
(WebCore::AcceleratedCompositingContext::create):
(WebCore::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebCore::AcceleratedCompositingContext::~AcceleratedCompositingContext):
(WebCore::AcceleratedCompositingContext::initialize):
(WebCore::AcceleratedCompositingContext::syncLayersNow):
(WebCore::AcceleratedCompositingContext::renderLayers):
(WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebCore::AcceleratedCompositingContext::context):

  • WebCoreSupport/AcceleratedCompositingContextEfl.h: Added.

(WebCore):
(AcceleratedCompositingContext):

11:30 PM Changeset in webkit [110269] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix Qt minimal build

11:21 PM Changeset in webkit [110268] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for MSVC after r110266

Unreviewed. A #ifdef for MSVC was left over in r110266.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-03-08

  • runtime/RegExpObject.h:

(RegExpObject):

11:16 PM Changeset in webkit [110267] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebCore

[chromium] Remove dead CoreGraphics code from chromium compositor implementation
​https://bugs.webkit.org/show_bug.cgi?id=80470

Patch by James Robinson <​jamesr@chromium.org> on 2012-03-08
Reviewed by Adam Barth.

We haven't supported CoreGraphics as a raster backend in chromium for a few months and do not plan to do so, so
it's time to remove the USE(CG) #ifdefs from our compositor and just rely on USE(SKIA) being set. This also
slightly simplifies how PlatformCanvas works.

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PlatformCanvas.cpp:

(WebCore::PlatformCanvas::createBackingCanvas):
(WebCore::PlatformCanvas::AutoLocker::AutoLocker):
(WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
(WebCore):
(WebCore::PlatformCanvas::AutoLocker::pixels):
(WebCore::PlatformCanvas::Painter::Painter):

  • platform/graphics/chromium/PlatformCanvas.h:

(WebCore):
(AutoLocker):
(Painter):
(PlatformCanvas):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
10:49 PM Changeset in webkit [110266] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Allocate the RegExpObject's data with the Cell
​https://bugs.webkit.org/show_bug.cgi?id=80654

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-03-08
Reviewed by Gavin Barraclough.

This patch removes the creation of RegExpObject's data to avoid the overhead
create by the allocation and destruction.

We RegExp are created repeatedly, this provides some performance improvment.
The PeaceKeeper test stringDetectBrowser improves by 10%.

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::visitChildren):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::defineOwnProperty):
(JSC::RegExpObject::match):

  • runtime/RegExpObject.h:

(JSC::RegExpObject::setRegExp):
(JSC::RegExpObject::regExp):
(JSC::RegExpObject::setLastIndex):
(JSC::RegExpObject::getLastIndex):
(RegExpObject):

10:20 PM Changeset in webkit [110265] by igor.o@sisa.samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Update my email.

  • Scripts/webkitpy/common/config/committers.py:
10:19 PM Changeset in webkit [110264] by sfalken@apple.com
  • 10 edits
    11 copies
    1 move
    1 delete in trunk/Source

Source/JavaScriptCore: Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build
​https://bugs.webkit.org/show_bug.cgi?id=80657

Preparation for WTF separation from JavaScriptCore.
The "Generated" vcproj files on Windows are necessary so Visual Studio can calculate correct
dependencies for generated files.

This also removes the PGO build targets from the WTF code, since we can't build instrumentation/optimization
versions of the WTF code independent of the JavaScriptCore code.

Reviewed by Jessie Berlin.

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Add WTFGenerated, update dependent projects.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Removed WTF specific parts.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Removed WTF specific parts.
  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Removed WTF specific parts.
  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Removed WTF specific parts.
  • JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py: Removed.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Add WTFGenerated, update dependent projects.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Remove PGO targets from WTF.
  • JavaScriptCore.vcproj/WTF/WTFGenerated.make: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
  • JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedCommon.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedDebug.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebug.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedDebugAll.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugAll.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedDebugCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugCairoCFLite.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedProduction.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedRelease.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedRelease.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedReleaseCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleaseCairoCFLite.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops: Removed.
  • JavaScriptCore.vcproj/WTF/build-generated-files.sh: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh.
  • JavaScriptCore.vcproj/WTF/copy-files.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd.
  • JavaScriptCore.vcproj/WTF/work-around-vs-dependency-tracking-bugs.py: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py.

Source/WebKit/win: Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build
​https://bugs.webkit.org/show_bug.cgi?id=80657

Preparation for WTF separation from JavaScriptCore.
The "Generated" vcproj files on Windows are necessary so Visual Studio can calculate correct
dependencies for generated files.

Reviewed by Jessie Berlin.

  • WebKit.vcproj/WebKit.sln: Add WTFGenerated, update dependent projects.
10:08 PM Changeset in webkit [110263] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Get rid of itemTypeAttributeChanged
​https://bugs.webkit.org/show_bug.cgi?id=80666

Reviewed by Adam Barth.

This function is unnecessay as we can invalidate m_microDataItemListCaches
in invalidateCachesThatDependOnAttributes as done for other node lists.

  • dom/Node.cpp:

(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):

  • dom/Node.h:
  • dom/NodeRareData.h:

(NodeListsNodeData):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute):

9:55 PM Changeset in webkit [110262] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r108616.
​http://trac.webkit.org/changeset/108616
​https://bugs.webkit.org/show_bug.cgi?id=80676

breaks animation on Safari welcome page (Requested by smfr on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-08

  • page/animation/AnimationController.cpp:

(WebCore::AnimationController::updateAnimations):

  • page/animation/AnimationControllerPrivate.h:

(AnimationControllerPrivate):

9:52 PM Changeset in webkit [110261] by benjamin@webkit.org
  • 4 edits in trunk/Source

Fix the build of WebKit with WTFURL following the removal of ForwardingHeaders/wtf
​https://bugs.webkit.org/show_bug.cgi?id=80652

Reviewed by Eric Seidel.

Source/JavaScriptCore:

Fix the header, URLSegments.h is not part of the API.

  • wtf/url/api/ParsedURL.h:

Source/WebCore:

The fowarding headers have been removed, we must now use the full path to the header.

  • platform/KURLWTFURLImpl.h:
9:00 PM Changeset in webkit [110260] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Change calcRadiiFor to IntSize
​https://bugs.webkit.org/show_bug.cgi?id=80655

Reviewed by Simon Fraser.

Borders and RoundedRect are both represented with pixel precision. As
such it doesn't make sense for calcRadiiFor to use subpixel units, it
just adds unnecessary type conversions.

No new tests, no new functionality.

  • rendering/style/RenderStyle.cpp:

(WebCore::calcRadiiFor):

8:43 PM Changeset in webkit [110259] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Encapsulate mask layer settings in LayerChromium
​https://bugs.webkit.org/show_bug.cgi?id=80646

Reviewed by James Robinson.

If a WebLayer sets a mask layer, the setIsMask flag will not get set
properly and the mask layer will not turn off tiling. This was only
being set through GraphicsLayerChromium. Move this flag into
LayerChromium so that it always gets set.

Test: LayoutTests/compositing/

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setMaskLayer):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setMaskLayer):

8:28 PM Changeset in webkit [110258] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

Recent changes to chromium.py etc. broke chromium_android.py
​https://bugs.webkit.org/show_bug.cgi?id=80623

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._start):

8:27 PM Changeset in webkit [110257] by tony@chromium.org
  • 3 edits
    2 adds in trunk

margins on flex-align: baseline are double counted
​https://bugs.webkit.org/show_bug.cgi?id=80645

Reviewed by Ojan Vafai.

Source/WebCore:

Fix a bug where we're counting the margins on baseline aligned
children twice. Also add some test cases to make sure we handle
wrap-reverse baseline alignment properly.

Tests: css3/flexbox/multiline-reverse-wrap-baseline-expected.html

css3/flexbox/multiline-reverse-wrap-baseline.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):

LayoutTests:

  • css3/flexbox/multiline-reverse-wrap-baseline-expected.html: Added.
  • css3/flexbox/multiline-reverse-wrap-baseline.html: Added.
8:07 PM Changeset in webkit [110256] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Exception running reftest with --no-pixel-tests
​https://bugs.webkit.org/show_bug.cgi?id=80642

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.init):
(ChromiumDriver._wrapper_options):

7:52 PM Changeset in webkit [110255] by nduca@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Pass setVisibility to CCLayerTreeHostImpl regardless of LRC initialization status
​https://bugs.webkit.org/show_bug.cgi?id=80584

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

7:43 PM Changeset in webkit [110254] by noam.rosenthal@nokia.com
  • 6 edits in trunk/Source/WebKit2

[Qt][WK2] Allow transparent WebViews
​https://bugs.webkit.org/show_bug.cgi?id=80608

Reviewed by Tor Arne Vestbø.

Added support for transparentBackground in QQuickWebViewExperimental.
This uses the existing drawsTransparentBackground property in WebKit2.
Also, changed LayerTreeHostQt to set the contentsOpaque flag when the root layer changes,
otherwise the change doesn't take effect.

A new API test was added.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::setTransparentBackground):
(QQuickWebViewPrivate::transparentBackground):
(QQuickWebViewExperimental::transparentBackground):
(QQuickWebViewExperimental::setTransparentBackground):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::transparentWebViews):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):

7:35 PM Changeset in webkit [110253] by tony@chromium.org
  • 1 edit
    8 moves in trunk/LayoutTests

rename flexbox tests to describe what is actually being tested
​https://bugs.webkit.org/show_bug.cgi?id=80636

Reviewed by Ojan Vafai.

  • css3/flexbox/flex-algorithm-expected.txt: Renamed from LayoutTests/css3/flexbox/001-expected.txt.
  • css3/flexbox/flex-algorithm-min-max-expected.txt: Renamed from LayoutTests/css3/flexbox/003-expected.txt.
  • css3/flexbox/flex-algorithm-min-max.html: Renamed from LayoutTests/css3/flexbox/003.html.
  • css3/flexbox/flex-algorithm-with-margins-expected.txt: Renamed from LayoutTests/css3/flexbox/002-expected.txt.
  • css3/flexbox/flex-algorithm-with-margins.html: Renamed from LayoutTests/css3/flexbox/002.html.
  • css3/flexbox/flex-algorithm.html: Renamed from LayoutTests/css3/flexbox/001.html.
  • css3/flexbox/flex-pack-expected.txt: Renamed from LayoutTests/css3/flexbox/004-expected.txt.
  • css3/flexbox/flex-pack.html: Renamed from LayoutTests/css3/flexbox/004.html.
7:25 PM Changeset in webkit [110252] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Ensure that the cc thread animation framework continues to tick when the tab is backgrounded
​https://bugs.webkit.org/show_bug.cgi?id=77668

Patch by Ian Vollick <​vollick@chromium.org> on 2012-03-08
Reviewed by James Robinson.

Source/WebCore:

Tested in CCLayerTreeHostTestTickAnimationWhileBackgrounded

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(CCLayerTreeHostImplTimeSourceAdapter):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::create):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::~CCLayerTreeHostImplTimeSourceAdapter):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::onTimerTick):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::setActive):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::CCLayerTreeHostImplTimeSourceAdapter):
(WebCore):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.cpp:

(WebCore::CCProxy::currentThread):
(WebCore):
(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setCurrentThreadIsImplThread):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::postAddInstantAnimationToMainThread):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::beginTest):
(WTF):
(CCLayerTreeHostTestTickAnimationWhileBackgrounded):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::CCLayerTreeHostTestTickAnimationWhileBackgrounded):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::beginTest):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::afterTest):
(WTF::TEST_F):

7:21 PM Changeset in webkit [110251] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Only build NEON files if target_arch=="arm"
​https://bugs.webkit.org/show_bug.cgi?id=80626

Currently, webcore_arm_neon will compile a bunch of files
whose contents are completely ifdef'd away on non-arm, and
then bundle all the generated empty .o files into a useless
libwebcore_arm_neon.a. Don't do this.

Reviewed by Tony Chang.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
7:07 PM Changeset in webkit [110250] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[NRWT] Fix --platform=qt-5.0 --new-baseline combo
​https://bugs.webkit.org/show_bug.cgi?id=72489

Patch by Rafael Brandao <​rafael.lobo@openbossa.org> on 2012-03-08
Reviewed by Dirk Pranke.

NRWT: The default platform name for Qt combined with --webkit-test-runner is now
"qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
--platform will override the platform name and then we'll use it.

ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
override it in the end.

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest.test_baseline_search_path):

7:05 PM Changeset in webkit [110249] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fix warning in PlatformTouchEventBlackBerry.cpp
​https://bugs.webkit.org/show_bug.cgi?id=80621

Fixes a warning seen when control reaches the end of a
non-void function. Return TouchCancel in the 'default' case.

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-03-08
Reviewed by Rob Buis.

  • platform/blackberry/PlatformTouchEventBlackBerry.cpp:

(WebCore::touchEventType):

6:53 PM Changeset in webkit [110248] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit2

GTK+ build fix. Only try to get the backing from the layer in when
ACCELERATED_COMPOSITING is enabled.

Rubber-stamped by Ryosuke Niwa.

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::screenRectOfContents):

6:50 PM Changeset in webkit [110247] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Using wrong scissor rect for draw culling
​https://bugs.webkit.org/show_bug.cgi?id=80624

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-08
Reviewed by Adrienne Walker.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):

6:33 PM Changeset in webkit [110246] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
6:30 PM Changeset in webkit [110245] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Force the Canvas2D GPU texture cache to 0 bytes for backgrounded tabs.
​https://bugs.webkit.org/show_bug.cgi?id=79948

Patch by Jeff Timanus <​twiz@chromium.org> on 2012-03-08
Reviewed by Stephen White.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::setVisibilityCHROMIUM):

6:25 PM Changeset in webkit [110244] by ojan@chromium.org
  • 1 edit
    19 adds
    2 deletes in trunk/LayoutTests

Fix some Leopard tests that broke with r110229.

  • platform/chromium-mac-leopard/fast/table/cell-coalescing-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/floating-th-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/wbr-pre-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/001-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/019-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/023-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/028-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/029-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/pre-newline-box-test-expected.png: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/border-vertical-lr-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/xsl/xslt-enc-cyr-expected.png: Added.
  • platform/chromium-mac-leopard/fast/xsl/xslt-enc-expected.png: Added.
  • platform/chromium-mac-leopard/fast/xsl/xslt-enc16-expected.png: Added.
  • platform/chromium-mac-leopard/fast/xsl/xslt-enc16to16-expected.png: Added.
  • platform/chromium-mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.png: Added.
  • platform/chromium-mac-leopard/fast/xsl/xslt_unicode-expected.png: Added.
6:24 PM Changeset in webkit [110243] by aestes@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION (r105396): Dragging an iWork document into icloud.com opens it in the Mac app instead of uploading it to icloud.com
​https://bugs.webkit.org/show_bug.cgi?id=79443

Reviewed by Ryosuke Niwa.

Source/WebCore:

icloud.com registers a drop event handler that sets display:none on the
file input element receiving the drop. After dispatching the drop event,
DragController hit tests the position under the mouse to see if it is a
file input element in need of receiving files. Since the file input
element has lost its renderer, it cannot be found by hit testing, so
the dropped file is never attached to the file input element, no change
event fires, and no upload commences. We want these things to happen
even if the element is no longer visible.

Since we already keep track of the file input element under the mouse
via m_fileInputElementUnderMouse, this additional hit test is
unnecessary. Use m_fileInputElementUnderMouse in concludeEditDrag()
when dropping files.

Test: fast/events/file-input-hidden-in-ondrop.html

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag): Use
m_fileInputElementUnderMouse instead of the element returned by hit
testing. Assert that m_fileInputElementUnderMouse equals the hit tested
element unless m_fileInputElementUnderMouse doesn't have a renderer.

LayoutTests:

  • fast/events/file-input-hidden-in-ondrop-expected.txt: Added.
  • fast/events/file-input-hidden-in-ondrop.html: Added.
  • platform/wk2/Skipped: WebKitTestRunner doesn't support

EventSender.beginDragWithFiles().

6:19 PM Changeset in webkit [110242] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Replace completelyContains with Region::contains()
​https://bugs.webkit.org/show_bug.cgi?id=80617

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-08
Reviewed by James Robinson.

  • tests/CCLayerTestCommon.cpp:

(CCLayerTestCommon):
(CCLayerTestCommon::verifyQuadsExactlyCoverRect):

  • tests/CCLayerTestCommon.h:

(CCLayerTestCommon):

5:53 PM Changeset in webkit [110241] by ojan@chromium.org
  • 66 edits
    64 copies
    192 moves
    225 adds
    146 deletes in trunk/LayoutTests

Moar Chromium Lion rebaselines.

5:27 PM Changeset in webkit [110240] by commit-queue@webkit.org
  • 1 edit
    15 adds in trunk/LayoutTests

[chromium] more comprehensive tests for gesture scrolling
​https://bugs.webkit.org/show_bug.cgi?id=80201

Prior to landing some changes to EventHandler::handleGestureEvent, add
some tests to ensure that the behaviour of handleGestureEvent and
handleWheelEvent don't regress.

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-08
Reviewed by Dimitri Glazkov.

  • fast/events/touch/gesture/resources/gesture-helpers.js: Added: utility functions.

(recordWheel):
(recordScroll):
(exitIfNecessary):
(checkTestDependencies):
(checkScrollOffset):

  • fast/events/touch/gesture/resources/scroll-inside-iframe.html: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-div-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-div.html: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-iframe.html: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-page-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-page.html: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-shy-target.html: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-div-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-iframe-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-page-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt: Added.
5:22 PM Changeset in webkit [110239] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp

Fix alignment in RenderDeprecatedFlexibleBox on branch.

5:22 PM Changeset in webkit [110238] by rniwa@webkit.org
  • 11 edits in trunk/Source

Mac build fix for micro data API.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::removeCachedMicroDataItemList):

  • html/HTMLElement.idl:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
5:13 PM Changeset in webkit [110237] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
5:11 PM Changeset in webkit [110236] by senorblanco@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

[chromium] Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
5:07 PM Changeset in webkit [110235] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

Mark a bunch of tests as failing on Leopard.

  • platform/chromium/test_expectations.txt:
4:59 PM Changeset in webkit [110234] by eae@chromium.org
  • 13 edits in branches/subpixellayout/Source/WebCore

More int/layoutunit fixes for subpixel branch.

4:49 PM Changeset in webkit [110233] by barraclough@apple.com
  • 5 edits
    3 adds in trunk

String.prototype.match and replace do not clear global regexp lastIndex per ES5.1 15.5.4.10
​https://bugs.webkit.org/show_bug.cgi?id=26890

Reviewed by Oliver Hunt.

Per 15.10.6.2 step 9.a.1 called via the action of the last iteration of 15.5.4.10 8.f.i.

Source/JavaScriptCore:

  • runtime/StringPrototype.cpp:

(JSC::replaceUsingRegExpSearch):
(JSC::stringProtoFuncMatch):

  • added calls to setLastIndex.

LayoutTests:

  • fast/js/script-tests/string-match.js: Added.
  • fast/js/string-match-expected.txt: Added.
  • fast/js/string-match.html: Added.
    • Added test case for match.
  • fast/js/script-tests/string-replace-2.js:
  • fast/js/string-replace-2-expected.txt:
    • Added tests for update correct lastIndex handling.
4:46 PM Changeset in webkit [110232] by jonlee@apple.com
  • 9 edits in trunk/Source/WebCore

Support [Custom] for static functions
​https://bugs.webkit.org/show_bug.cgi?id=80573

Reviewed by Kentaro Hara.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): If the function is static, add static qualifier to cpp function.
(GenerateImplementation): Reorganize the function to split out based on the static
attribute, instead of checking for it at every line we output.

If the function is static and not custom, the listed code should be the code in

the rest of the function that did not have the static check. If it is custom, then
we check the number of arguments, and then call the static impl function directly.

If the function is not static, all of the "unless ($function->isStatic)" checks

are removed since it is not necessary.

  • bindings/scripts/test/TestObj.idl: Added new test case.
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjConstructorFunctionClassMethod2):

  • bindings/scripts/test/JS/JSTestObj.h:

(JSTestObj):
(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj classMethod2]):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

4:41 PM Changeset in webkit [110231] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
​https://bugs.webkit.org/show_bug.cgi?id=80592

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-03-08
Reviewed by Adam Barth.

In anticipation of moving FILE_SYSTEM-related code to Modules/, we
are collapsing combination BLOB/FILE_SYSTEM ifdefs to just
BLOB. In other words, it is assumed from now on that you can not
have FILE_SYSTEM support without BLOB support.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore):
(WebCore::ScriptExecutionContext::fileThread):

  • dom/ScriptExecutionContext.h:

(WebCore):
(ScriptExecutionContext):

  • fileapi/AsyncFileStream.cpp:
  • fileapi/AsyncFileStream.h:
  • fileapi/FileError.h:
  • fileapi/FileException.cpp:
  • fileapi/FileException.h:
  • fileapi/FileThread.cpp:
  • fileapi/FileThread.h:
  • fileapi/OperationNotAllowedException.cpp:
  • fileapi/OperationNotAllowedException.h:
  • platform/FileStream.cpp:
  • platform/FileStream.h:
  • platform/FileStreamClient.h:
  • platform/SchemeRegistry.cpp:

(WebCore::canDisplayOnlyIfCanRequestSchemes):
(WebCore::CORSEnabledSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsNotAllowingJavascriptURLs):

4:31 PM Changeset in webkit [110230] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Always use the current focused node when processing focus changes
​https://bugs.webkit.org/show_bug.cgi?id=80594

Patch by Mike Fenton <​mifenton@rim.com> on 2012-03-08
Reviewed by Antonio Gomes.

Guard against toRange or fromRange being null when called
as part of a clear event.

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):

4:19 PM Changeset in webkit [110229] by ojan@chromium.org
  • 249 edits
    259 copies
    48 moves
    246 adds
    42 deletes in trunk/LayoutTests

NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
​https://bugs.webkit.org/show_bug.cgi?id=80648

Patch by Andy Estes <​aestes@apple.com> on 2012-03-08
Reviewed by Simon Fraser.

  • fast/events/input-element-display-none-in-dragleave-crash-expected.txt: Added.
  • fast/events/input-element-display-none-in-dragleave-crash.html: Added.
  • platform/wk2/Skipped: WebKitTestRunner doesn't support

EventSender.beginDragWithFiles().

4:13 PM Changeset in webkit [110228] by jer.noble@apple.com
  • 4 edits in trunk/Source

Unreviewed Snow Leopard build fix.

On Leopard and Snow Leopard, provide an implementation for -[NSWindow convertRectToScreen:].

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(-[NSWindow convertRectToScreen:]):

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[NSWindow convertRectToScreen:]):

3:52 PM Changeset in webkit [110227] by jamesr@google.com
  • 9 edits in trunk/Source

Use an explicit attribute to signal that a context prefers to use a discrete GPU
​https://bugs.webkit.org/show_bug.cgi?id=80639

Reviewed by Stephen White.

Source/Platform:

Adds preferDiscreteGPU attribute to WebGraphicsContext3D::Attributes. Also remove the forUseOnAnotherThread
attribute, this has been dead code for a while now.

  • chromium/public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::Attributes::Attributes):
(Attributes):

Source/WebCore:

On platforms that support both integrated and discrete GPUs and can dynamically switch between the two, we
sometimes have a specific preference for a given context. Specifically, contexts used for WebGL and canvas 2d
acceleration should use the discrete GPU if available, but compositor contexts can run fine on an integrated
GPU. Instead of attempting to infer the intent from examining other context attributes, this adds an explicit
attribute to control this behavior.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::Attributes::Attributes):
(Attributes):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::get):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3D::create):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createCompositorGraphicsContext3D):

3:47 PM Changeset in webkit [110226] by aestes@apple.com
  • 4 edits
    2 adds in trunk

NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
​https://bugs.webkit.org/show_bug.cgi?id=80648

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/events/input-element-display-none-in-dragleave-crash.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setCanReceiveDroppedFiles): NULL-check renderer().

LayoutTests:

  • fast/events/input-element-display-none-in-dragleave-crash-expected.txt: Added.
  • fast/events/input-element-display-none-in-dragleave-crash.html: Added.
  • platform/wk2/Skipped: WebKitTestRunner doesn't support

EventSender.beginDragWithFiles().

3:46 PM Changeset in webkit [110225] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Yet another unreviewed build fix.

Remove an unneeded and Lion-defined window constant from WebCoreFullScreenWindow.

  • platform/mac/WebCoreFullScreenWindow.mm:

(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):

3:41 PM Changeset in webkit [110224] by leviw@chromium.org
  • 27 edits in trunk/Source/WebCore

Switch absoluteRects, culledInlineAbsoluteRects, absoluteBoundingBoxRect, and addFocusRingRects back to integers
​https://bugs.webkit.org/show_bug.cgi?id=80545

Reviewed by Simon Fraser.

Converting the above functions, all of which return rects that represent on-screen rects, to IntRects from
LayoutRects.

addFocusRingsRects generates a vector of rects that is handed off directly to the GraphicsContext to be
drawn. Snapping the rects before adding them to the vector saves an extra pass through the vector.

absoluteRects and culledInlineAbsoluteRects are only used by addFocusRingRects, hasNonEmptyBoundingBox (only
to check if they're empty), and absoluteBoundingBoxRect, which is exposed from WebCore and thus should be an
IntRect anyways.

No new tests. No change in behavior.

  • dom/Node.cpp:

(WebCore::Node::hasNonEmptyBoundingBox):

  • dom/Range.cpp:

(WebCore::Range::boundingBox):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::addFocusRingRects):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::culledInlineAbsoluteRects):
(WebCore::RenderInline::addFocusRingRects):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::addFocusRingRects):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintFocusRing):
(WebCore::RenderObject::absoluteBoundingBoxRect):
(WebCore::RenderObject::absoluteFocusRingQuads):

  • rendering/RenderObject.h:

(WebCore::RenderObject::absoluteRects):
(RenderObject):
(WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
(WebCore::RenderObject::addFocusRingRects):

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):

  • rendering/RenderText.h:

(RenderText):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::addFocusRingRects):

  • rendering/RenderTextControl.h:

(RenderTextControl):

  • rendering/RenderView.cpp:

(WebCore::RenderView::absoluteRects):

  • rendering/RenderView.h:

(RenderView):

  • rendering/svg/RenderSVGBlock.cpp:

(WebCore::RenderSVGBlock::absoluteRects):

  • rendering/svg/RenderSVGBlock.h:

(RenderSVGBlock):

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::addFocusRingRects):

  • rendering/svg/RenderSVGContainer.h:

(RenderSVGContainer):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::addFocusRingRects):

  • rendering/svg/RenderSVGImage.h:

(RenderSVGImage):

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::absoluteRects):

  • rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::addFocusRingRects):

  • rendering/svg/RenderSVGShape.h:

(RenderSVGShape):

3:38 PM Changeset in webkit [110223] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebKit2

Further unreviewed build fix.

Add in the WebCore namespace, so that IntRect is pulled in.

  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
  • UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
  • UIProcess/win/WebFullScreenManagerProxyWin.cpp:
3:35 PM Changeset in webkit [110222] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Use EventNames instead of strings
​https://bugs.webkit.org/show_bug.cgi?id=80649

Reviewed by Ojan Vafai.

No new tests. Covered by existing tests.

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):

3:32 PM Changeset in webkit [110221] by timothy_horton@apple.com
  • 4 edits
    1 add in trunk

No-op filter changes color output because of colorspace issues
​https://bugs.webkit.org/show_bug.cgi?id=72411
<rdar://problem/10588374>

Reviewed by Dean Jackson.

Redefine "linear RGB" color space on Mac to mean linearized sRGB, instead of linear
Generic RGB. This makes existing CG color matching equivalent to what other ports do via
ImageBuffer::transformColorSpace (which only adjusts gamma, as we will now). Previously,
we were also causing actual (non-gamma) color adjustments which were not reversible.

No new tests, covered by all existing SVG and CSS filter tests.

  • Resources/linearSRGB.icc: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::linearRGBColorSpaceRef):

3:28 PM Changeset in webkit [110220] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebKit2

Unreviewed build fix.

Add stub implementations of beganEnterFullScreen and beganExitFullScreen
to platform-specific WebFullScreenManagerProxy implementations.

  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:

(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

  • UIProcess/qt/WebFullScreenManagerProxyQt.cpp:

(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

  • UIProcess/win/WebFullScreenManagerProxyWin.cpp:

(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

3:24 PM Changeset in webkit [110219] by leviw@chromium.org
  • 13 edits in branches/subpixellayout/Source/WebCore

Fixing asoluteRectsForRange, a misspelling in MathML, and various other small changes.

3:24 PM Changeset in webkit [110218] by Beth Dakin
  • 5 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=80463
RenderImage is using the wrong origin when calling addRelevantRepaintedObject
-and corresponding-
<rdar://problem/10970221>

Reviewed by Dan Bernstein.

Source/WebCore:

Use the exact same rect that we paint with instead of the
visualOverflowRect() which does not always have a correct x and y.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::paintReplaced):

Tools:

New test!

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.

(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutForImagesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):

  • TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
3:20 PM Changeset in webkit [110217] by jonlee@apple.com
  • 4 edits in trunk/Source

Add support for ENABLE(LEGACY_NOTIFICATIONS)
​https://bugs.webkit.org/show_bug.cgi?id=80497

Reviewed by Adam Barth.

Source/JavaScriptCore:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:

Source/WebKit/mac:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:
3:15 PM Changeset in webkit [110216] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebKit/mac

Full Screen Refactor Part 4: Animate into Full Screen mode using new animation classes, WebKit edition.
​https://bugs.webkit.org/show_bug.cgi?id=78930

Reviewed by Anders Carlsson.

Revise WebFullScreenController to have the same general functionality and code path as WKFullScreenWindowController
in WebKit2. As such, the following functions are copies of their equivalents in WKFullScreenWindowController:

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController init]):
(-[WebFullScreenController dealloc]):
(-[WebFullScreenController windowDidLoad]):
(-[WebFullScreenController cancelOperation:]):
(-[WebFullScreenController applicationDidResignActive:]):
(-[WebFullScreenController applicationDidChangeScreenParameters:]):
(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController finishedExitFullScreenAnimation:]):
(-[WebFullScreenController close]):
(-[WebFullScreenController animationDidEnd:]):
(-[WebFullScreenController _updateMenuAndDockForFullScreen]):
(-[WebFullScreenController _swapView:with:]):
(createBackgroundFullscreenWindow):
(windowFrameFromApparentFrames):
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):

The following is a copy of the equivalent function in WebFullScreenManager:

  • WebView/WebFullScreenController.mm:

(screenRectOfContents):

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::fullScreenRendererChanged): No longer tell the WebView the renderer changed (as it doesn't care.)

  • WebView/WebFullScreenController.h:
  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController setElement:]): No need to add event listeners to the media element.
(-[WebFullScreenController enterFullScreen:]): Same as WKFullScreenWindowController, but not asynchronous.
(-[WebFullScreenController exitFullScreen]): Ditto.

  • WebView/WebView.mm:

(-[WebView _enterFullScreenForElement:WebCore::]): Fullscreen -> FullScreen.
(-[WebView _exitFullScreenForElement:WebCore::]): Ditto.

3:15 PM Changeset in webkit [110215] by jer.noble@apple.com
  • 13 edits
    2 copies in trunk/Source

Full Screen Refactor Part 3: Animate into Full Screen mode using new animation classes.
​https://bugs.webkit.org/show_bug.cgi?id=78928

Reviewed by Anders Carlsson.

Source/WebCore:

Move WKFullScreenWindow from WebKit2 into WebCore to be shared by WebKit2 and WebKit.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/WebCoreFullScreenWindow.h:
  • platform/mac/WebCoreFullScreenWindow.mm:

Add symbols for the following classes and functions to the export list:

WebCoreFullScreenWindow
WebWindowScaleAnimation
WebWindowFadeAnimation
ScrollView::contentsToScreen()
RenderObject::localToContainerQuad()
Document::setAnimatingFullScreen()

  • WebCore.exp.in:

Source/WebKit2:

Boilerplate changes to WebKit2 IPC messages and supporting functions.

  • UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::setAnimatingFullScreen): Added boilerplate.

  • UIProcess/WebFullScreenManagerProxy.h:
  • UIProcess/WebFullScreenManagerProxy.messages.in:
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:

(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen): Added boilerplate.
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen): Added boilerplate.

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::screenRectOfContents): Added. Calculates the screen rect of an element's contents.
(WebKit::WebFullScreenManager::enterFullScreenForElement): Use screenRectOfContents()
(WebKit::WebFullScreenManager::willEnterFullScreen): Ditto. Do not set the background color. Call new BeganEnterFullScreen

XPC message.

(WebKit::WebFullScreenManager::didEnterFullScreen): Do not set the background color.
(WebKit::WebFullScreenManager::willExitFullScreen): Use screenRectOfContents. Do not set the background color. Call new

BeganExitFullScreen XPC message.

(WebKit::WebFullScreenManager::didExitFullScreen): Do not set the background color.
(WebKit::WebFullScreenManager::setAnimatingFullScreen): Added boilerplate.

  • WebProcess/FullScreen/WebFullScreenManager.h:
  • WebProcess/FullScreen/WebFullScreenManager.messages.in:
  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController cancelOperation:]): Renamed from _requestExitWithAnimation:.
(-[WKFullScreenWindowController applicationDidResignActive:]): Call cancelOperation: instead

of _requestExitWithAnimation.

(-[WKFullScreenWindowController applicationDidChangeScreenParameters:]): Set the frame of

both the full screen window and the background window.

(-[WKFullScreenWindowController enterFullScreen:]): Save a rendered image of the current

page to use in the placeholder.

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Renamed from

beganEnterFullScreenAnimation.

(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): No need to swap

placeholder views here, as they were already swapped in beganEnter...:.

(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Renamed from

beganExitFullScreenAnimation.

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Swap web view back into place.
(-[WKFullScreenWindowController close]):
(-[WKFullScreenWindowController animationDidEnd:]): Added.
(createBackgroundFullscreenWindow): Added.
(windowFrameFromApparentFrames): Added.
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]): Added.
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]): Added.

3:14 PM Changeset in webkit [110214] by jer.noble@apple.com
  • 17 edits
    8 deletes in trunk/Source/WebKit2

Full Screen Refactor Part 2: Remove unnecessary WebKit2 APIs for Full Screen made
​https://bugs.webkit.org/show_bug.cgi?id=78926

Reviewed by John Sullivan.

The following functions (and also their Proxy versions) were removed completely:
WebFullScreenManager::enterAcceleratedCompositingMode(const LayerTreeContext&)
WebFullScreenManager::exitAcceleratedCompositingMode()
WebFullScreenManager::beganEnterFullScreenAnimation()
WebFullScreenManager::finishedEnterFullScreenAnimation(bool)
WebFullScreenManager::beganExitFullScreenAnimation()
WebFullScreenManager::finishedExitFullScreenAnimation(bool)
WebFullScreenManager::getFullScreenRect(WebCore::IntRect&)

  • UIProcess/WebFullScreenManagerProxy.cpp:
  • UIProcess/WebFullScreenManagerProxy.h:

(WebKit::WebFullScreenManagerProxy::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::beginExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::disposeOfLayerClient):
(WebFullScreenManagerProxy):

  • UIProcess/WebFullScreenManagerProxy.messages.in:
  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:
  • UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
  • UIProcess/win/WebFullScreenManagerProxyWin.cpp:

(WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::create):
(WebKit::WebFullScreenManager::~WebFullScreenManager):

  • WebProcess/FullScreen/WebFullScreenManager.h:

(WebFullScreenManager):

  • WebProcess/FullScreen/WebFullScreenManager.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exitFullScreenForElement):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

Additionally, the platform-specific WebFullScreenManager subclasses were removed, as no
platform-specific implementations remained after the above functions were removed:

  • GNUmakefile.am:
  • Target.pri:
  • win/WebKit2.vcproj:
  • WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.cpp: Removed.
  • WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.h: Removed.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Removed.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Removed.
  • WebProcess/FullScreen/qt/WebFullScreenManagerQt.cpp: Removed.
  • WebProcess/FullScreen/qt/WebFullScreenManagerQt.h: Removed.
  • WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp: Removed.
  • WebProcess/FullScreen/win/WebFullScreenManagerWin.h: Removed.
3:14 PM Changeset in webkit [110213] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

Full Screen Refactor Part 1: Remove special-case rendering code for Full Screen animation.
​https://bugs.webkit.org/show_bug.cgi?id=78925

Reviewed by John Sullivan.

No new tests; no net change in functionality so covered by existing tests.

The following functions had special case code for rendering full-screen elements removed:

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::setAnimatingFullScreen):

  • page/FrameView.cpp:

(WebCore):
(WebCore::FrameView::updateCompositingLayers):
(WebCore::FrameView::syncCompositingStateForThisFrame):

  • rendering/RenderLayerBacking.cpp:

(WebCore::layerOrAncestorIsTransformed):
(WebCore::RenderLayerBacking::updateCompositedBounds):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):

  • rendering/RenderLayerCompositor.h:
3:08 PM Changeset in webkit [110212] by mlilek@apple.com
  • 8 edits in trunk/Source

Don't enable VIDEO_TRACK on all OS X platforms
​https://bugs.webkit.org/show_bug.cgi?id=80635

Reviewed by Eric Carlson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
3:05 PM Changeset in webkit [110211] by ojan@chromium.org
  • 271 edits
    285 copies
    68 moves
    173 adds
    47 deletes in trunk/LayoutTests

Moar Chromium Lion rebaselines.

2:58 PM Changeset in webkit [110210] by rniwa@webkit.org
  • 5 edits in trunk

perf-o-matic should incrementally update JSON responses
​https://bugs.webkit.org/show_bug.cgi?id=79898

Reviewed by Eric Seidel.

Now that Runs object store test_runs and averages separately,
we can update JSON data incrementally without degrading values.

Also fixed the order of arguments passed to DashboardImage.needs_update
in schedule_runs_update. This bug had caused all chart images to be
updated on every new report.

  • Websites/webkit-perf.appspot.com/controller.py:

(schedule_runs_update):

  • Websites/webkit-perf.appspot.com/models.py:

(Runs.update_or_insert):
(Runs.update_incrementally):
(Runs):
(Runs.get_by_objects):

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(RunsTest._create_results):
(RunsTest.test_generate_runs):
(RunsTest.test_update_or_insert):
(RunsTest.test_update_incrementally):
(RunsTest.test_to_json_with_results):

  • Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post):

2:55 PM Changeset in webkit [110209] by tony@chromium.org
  • 10 edits in trunk

implement flexbox wrap-reverse
​https://bugs.webkit.org/show_bug.cgi?id=80552

Reviewed by Ojan Vafai.

Source/WebCore:

No new tests, but additional coverage in:

css3/flexbox/multiline-align.html
css3/flexbox/multiline-pack.html
css3/flexbox/multiline.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::WrapReverseContext::WrapReverseContext): Helper struct to hold information needed for reversing
the order of lines.
(RenderFlexibleBox::WrapReverseContext):
(WebCore::RenderFlexibleBox::WrapReverseContext::addCrossAxisOffset):
(WebCore::RenderFlexibleBox::WrapReverseContext::addNumberOfChildrenOnLine):
(WebCore::RenderFlexibleBox::WrapReverseContext::lineCrossAxisDelta): Computes the number of pixels to move a line.
(WebCore):
(WebCore::RenderFlexibleBox::layoutFlexItems): Call flipForWrapReverse if needed. This happens
before flipForRightToLeftColumn because otherwise the crossAxisOffsets will be wrong.
(WebCore::flexAlignForChild):
(WebCore::RenderFlexibleBox::alignChildren): Flip alignment in wrap-reverse because the cross directions are flipped.
(WebCore::RenderFlexibleBox::flipForWrapReverse): Flip each line.

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/multiline-align-expected.txt:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-expected.txt:
  • css3/flexbox/multiline-pack-expected.txt:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline.html:
2:53 PM Changeset in webkit [110208] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Build fix. That day is not today.

2:47 PM Changeset in webkit [110207] by adamk@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove InDocumentFlag manipulation methods from Node interface
​https://bugs.webkit.org/show_bug.cgi?id=80612

Reviewed by Ryosuke Niwa.

This is a first step towards tightening up Node::inDocument() to match
the actual in-document-tree state (see r108152 for the sort of bug
resulting from those not matching).

No new tests, refactoring only.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removedFromDocument): Remove duplicate call to clearInDocument:
the call to Node::removedFromDocument three lines above will clear the flag.

  • dom/Document.cpp:

(WebCore::Document::Document): Call ContainerNode constructor with InDocumentFlag always set
instead of calling setInDocument.

  • dom/Node.cpp:

(WebCore::Node::insertedIntoDocument): Inline setInDocument (now the only caller).
(WebCore::Node::removedFromDocument): Inline clearInDocument (now the only caller).

  • dom/Node.h: Remove setInDocument & clearInDocument, add new CreateDocument ConstructionType.
2:29 PM Changeset in webkit [110206] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Build fix. One of these days I'll manage to commit something that works everywhere.

2:28 PM LayoutUnit edited by leviw@chromium.org
(diff)
2:09 PM Changeset in webkit [110205] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Try to fix the Snow Leopard build

If the build is running under sh, echo -n does not empty the file.

2:03 PM Changeset in webkit [110204] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Update MIPS patchOffsetGetByIdSlowCaseCall
​https://bugs.webkit.org/show_bug.cgi?id=80302

Patch by Chao-ying Fu <​fu@mips.com> on 2012-03-08
Reviewed by Oliver Hunt.

  • jit/JIT.h:

(JIT):

2:01 PM Changeset in webkit [110203] by eae@chromium.org
  • 3628 edits
    2889 copies
    538 deletes in branches/subpixellayout

Merge baseline changes up until r110176 into subpixel branch.

2:00 PM Changeset in webkit [110202] by vestbo@webkit.org
  • 3 edits in trunk/Source/WebCore

Prospective build fix for Qt minimal after r110191

​https://bugs.webkit.org/show_bug.cgi?id=80338

  • testing/Internals.cpp:

(WebCore):

  • testing/Internals.h:

(Internals):

2:00 PM Changeset in webkit [110201] by ojan@chromium.org
  • 238 edits
    271 copies
    62 moves
    192 adds
    43 deletes in trunk/LayoutTests

More Chromium Lion rebaselines as well as some fixes for
Chromium Leopard/SnowLeopard from previous Lion rebaselines.

1:58 PM Changeset in webkit [110200] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Missing some places where we should be blinding 64bit values (and blinding something we shouldn't)
​https://bugs.webkit.org/show_bug.cgi?id=80633

Reviewed by Gavin Barraclough.

Add 64-bit trap for shouldBlindForSpecificArch, so that we always blind
if there isn't a machine specific implementation (otherwise the 64bit value
got truncated and 32bit checks were used -- leaving 32bits untested).
Also add a bit of logic to ensure that we don't try to blind a few common
constants that go through the ImmPtr paths -- encoded numeric JSValues and
unencoded doubles with common "safe" values.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::shouldBlindForSpecificArch):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlindDouble):
(MacroAssembler):
(JSC::MacroAssembler::shouldBlind):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::shouldBlindForSpecificArch):

1:49 PM Changeset in webkit [110199] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Prospective Windows build fix

Don't assume that windows-builds will always run inside a cmd.exe shell.

1:40 PM Changeset in webkit [110198] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Creating a selector for class names with trailing spaces results with two dots instead of one
​https://bugs.webkit.org/show_bug.cgi?id=80529

Trim the className before replacing the whitespaces with dot "."

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-03-08
Reviewed by Pavel Feldman.

No new tests.

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.appropriateSelectorFor):

1:23 PM Changeset in webkit [110197] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for window.devicePixelRatio
​https://bugs.webkit.org/show_bug.cgi?id=80292

Patch by Konrad Piascik <​kpiascik@rim.com> on 2012-03-08
Reviewed by Rob Buis.

  • fast/viewport/viewport-133-expected.txt: Added.
  • fast/viewport/viewport-133.html: Added.
1:20 PM Changeset in webkit [110196] by mitz@apple.com
  • 5 edits
    1 add in trunk

<rdar://problem/10981173> Dashboard regions should not be in device space

Reviewed by John Sullivan.

Source/WebCore:

Test: TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::addDashboardRegions): Stop applying the device scale factor to
Dashboard regions.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addDashboardRegions): Ditto.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.

(-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

1:03 PM Changeset in webkit [110195] by dpranke@chromium.org
  • 4 edits in trunk/Tools

webkit-patch works oddly on local Git branches
​https://bugs.webkit.org/show_bug.cgi?id=76958

Reviewed by Ojan Vafai.

This change makes the '-g' flag to webkit-patch behave a
little more consistently with git. The 'HEAD..' syntax
is changed to 'HEAD....' (four dots), so as to not
collide with the underlying git syntax. We also generalize
the syntax to support any refname, so 'foo....' means
diff against foo and include working copy changes.

This change also adds the 'UPSTREAM' shortcut to identify
whatever the current upstream/tracking branch is; this is
useful if you have multiple local branches stacked up.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git._branch_from_ref):
(Git):
(Git._current_branch):
(Git._upstream_branch):
(Git.merge_base):
(Git._commit_on_branch):

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(GitSVNTest._second_local_commit):
(GitSVNTest._two_local_commits):
(GitSVNTest.test_commit_with_message_git_commit_range):
(GitSVNTest.test_upstream_branch):
(GitSVNTest.test_create_patch_working_copy_only):
(GitSVNTest.test_changed_files_local_plus_working_copy):
(GitSVNTest.test_changed_files_working_copy_only):
(GitSVNTest.test_changed_files_upstream):

  • Scripts/webkitpy/tool/steps/options.py:

(Options):

12:49 PM Changeset in webkit [110194] by Lucas Forschler
  • 2 edits in tags/Safari-536.2.2/Source/JavaScriptCore

Merged r110193.

12:43 PM Changeset in webkit [110193] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<rdar://problem/11012572> Ensure that the staged frameworks path is in the search path for JavaScriptCore

Reviewed by Dan Bernstein.

  • Configurations/Base.xcconfig:
12:34 PM Changeset in webkit [110192] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Cannot insert right curly bracket on some keyboards
​https://bugs.webkit.org/show_bug.cgi?id=80474

Make sure other modifiers are not pressed

Patch by Cem Kocagil <​cem.kocagil@gmail.com> on 2012-03-08
Reviewed by Pavel Feldman

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

12:32 PM Changeset in webkit [110191] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Add a method to window.internals to enable testing of inspector highlight rects
​https://bugs.webkit.org/show_bug.cgi?id=80338

Patch by Max Vujovic <​mvujovic@adobe.com> on 2012-03-08
Reviewed by Pavel Feldman.

.:

  • Source/autotools/symbols.filter: Export symbols for GTK.

Source/WebCore:

Add window.internals.inspectorHighlightRects, a method which makes it possible to test the
positions and sizes of inspector highlight rects.

Test: inspector/elements/highlight-node.html

  • WebCore.exp.in: Export symbols.
  • testing/Internals.cpp:

(WebCore::Internals::inspectorHighlightRects): Call InspectorController::getHighlight and
return the highlight's quads as a ClientRectList.
(WebCore):

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Add inspectorHighlightRects to the window.internals interface.

Source/WebKit2:

  • win/WebKit2.def: Export symbols for win.
  • win/WebKit2CFLite.def: Same as above.

LayoutTests:

  • inspector/elements/highlight-node-expected.txt: Added.
  • inspector/elements/highlight-node.html: Added.
12:17 PM Changeset in webkit [110190] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit/qt

​https://bugs.webkit.org/show_bug.cgi?id=80370
Enable matched declaration caching for elements with a style attribute

Reviewed by Andreas Kling

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):
(QWebElement::setStyleProperty):

12:16 PM Changeset in webkit [110189] by ojan@chromium.org
  • 238 edits
    245 copies
    90 moves
    233 adds
    31 deletes in trunk/LayoutTests

More Chromium Lion rebaselines.

12:15 PM Changeset in webkit [110188] by Antti Koivisto
  • 19 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=80370
Enable matched declaration caching for elements with a style attribute

Reviewed by Andreas Kling

Make the property set for style attribute immutable as long as there is no CSSOM
wrapper for it. If the style attribute changes we create a new property set instead
of recycling the old one. This way the property sets can be made cacheable as long
as there is no CSSOM wrapper that would allow uncontrolled modifications. Constructing
the wrapper disables caching.

Made StyledElement::inlineStyle() and StyledElement::ensureInlineStyle() return a const
StylePropertySet so making accidental modifications difficult. Also dropped *Decl from
the names.

Fixed two unrelated bugs that this exposed.

  • css/CSSStyleSelector.cpp:


Don't allow caching of document element style if writingModeSetOnDocumentElement() bit is set.
Tested by fast/multicol/vertical-rl/break-properties.html.


(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/StylePropertySet.h:

(StylePropertySet):
(WebCore::StylePropertySet::hasCSSOMWrapper):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

Invalidate the matched properties cache if the document has rem units and the root font changes.
Tested by fast/css/rem-dynamic-scaling.html.


  • dom/ElementAttributeData.cpp:

(WebCore):
(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):
(WebCore::ElementAttributeData::destroyInlineStyle):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::inlineStyle):
(ElementAttributeData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::~StyledElement):
(WebCore):
(WebCore::StyledElement::style):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyle):
(WebCore::StyledElement::ensureInlineStyle):
(StyledElement):
(WebCore::StyledElement::destroyInlineStyle):

  • editing/ApplyStyleCommand.cpp:

(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeCSSStyle):
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
(WebCore::ApplyStyleCommand::addBlockStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

  • editing/EditingStyle.cpp:

(WebCore::HTMLElementEquivalent::propertyExistsInStyle):
(HTMLTextDecorationEquivalent):
(WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
(WebCore::EditingStyle::mergeInlineStyleOfElement):
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl):
(WebCore::EditingStyle::mergeStyle):

  • editing/EditingStyle.h:

(EditingStyle):

  • editing/RemoveCSSPropertyCommand.cpp:

(WebCore::RemoveCSSPropertyCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendElement):
(WebCore::styleFromMatchedRulesAndInlineDecl):

  • html/HTMLElement.cpp:

(WebCore::StyledElement::copyNonAttributeProperties):

  • html/canvas/CanvasStyle.cpp:

(WebCore::currentColor):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::retrieveResourcesForProperties):

  • page/PageSerializer.h:

(PageSerializer):

  • rendering/RenderTreeAsText.cpp:

(WebCore::isEmptyOrUnstyledAppleStyleSpan):

12:06 PM Changeset in webkit [110187] by senorblanco@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

[chromium] Unreviewed gardening.

Fallout from r110179.

  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt: Removed.
11:59 AM Changeset in webkit [110186] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Block file-to-file access by default
​https://bugs.webkit.org/show_bug.cgi?id=80605

Patch by Yong Li <​yoli@rim.com> on 2012-03-08
Reviewed by Rob Buis.

Turn off allowFileAccessFromFileURLs() by default.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

11:44 AM Common pixel differences between ports edited by ojan@chromium.org
(diff)
11:37 AM Changeset in webkit [110185] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Have ScrollAnimatorNone use requestAnimationFrame
​https://bugs.webkit.org/show_bug.cgi?id=78938

Patch by Scott Byer <​scottbyer@chromium.org> on 2012-03-08
Reviewed by James Robinson.

Source/WebCore:

No new tests. Passes Chromium webkit_unit_tests.

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::serviceScrollAnimations):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::cancelAnimations):
(WebCore):
(WebCore::ScrollAnimatorNone::serviceScrollAnimations):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::startNextTimer):
(WebCore::ScrollAnimatorNone::animationTimerActive):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::serviceScrollAnimations):
(WebCore):

  • platform/ScrollableArea.h:

(WebCore):
(ScrollableArea):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hostWindow):
(RenderLayer):

  • rendering/RenderListBox.h:

(WebCore::RenderListBox::hostWindow):
(RenderListBox):

Source/WebKit/chromium:

  • src/ScrollbarGroup.h:

(WebCore):
(WebKit::ScrollbarGroup::hostWindow):
(ScrollbarGroup):

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollableArea::hostWindow):

11:33 AM Changeset in webkit [110184] by Lucas Forschler
  • 2 edits in tags/Safari-536.2.2/Source/WebCore

Merged r109992.

11:33 AM Common pixel differences between ports edited by ojan@chromium.org
(diff)
11:31 AM Changeset in webkit [110183] by Lucas Forschler
  • 3 edits in tags/Safari-536.2.2/Source/WebCore

Merge 109986.

11:27 AM Changeset in webkit [110182] by Lucas Forschler
  • 4 edits in tags/Safari-536.2.2/Source

Versioning.

11:25 AM Changeset in webkit [110181] by Lucas Forschler
  • 1 copy in tags/Safari-536.2.2

New Tag.

11:18 AM Changeset in webkit [110180] by mitz@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r109964): Assertion failure (!isUndefined()) in Length::getIntValue() when a Dashboard region is specified without offsets
​https://bugs.webkit.org/show_bug.cgi?id=80614

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/css/dashboard-regions-undefined-length-assertion.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList): Reverted to setting zero lengths,
rather than Undefined ones, in the RenderStyle when offsets are not given.

LayoutTests:

  • fast/css/dashboard-regions-undefined-length-assertion-expected.txt: Added.
  • fast/css/dashboard-regions-undefined-length-assertion.html: Added.
11:18 AM Changeset in webkit [110179] by senorblanco@chromium.org
  • 198 edits
    193 adds
    43 deletes in trunk/LayoutTests

[chromium] Unreviewed gardening.

Rebaseline all TEXT results affected by r110072.

  • fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
  • fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
  • fast/block/float/in-margin-expected.txt: Added.
  • fast/clip/017-expected.txt: Added.
  • fast/dynamic/subtree-boundary-percent-height-expected.txt: Added.
  • fast/dynamic/subtree-no-common-root-static-y-expected.txt: Added.
  • fast/dynamic/subtree-table-cell-height-expected.txt: Added.
  • platform/chromium-linux-x86/compositing/overflow: Removed.
  • platform/chromium-linux-x86/fast/layers: Added.
  • platform/chromium-linux-x86/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-linux-x86/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-linux-x86/fast/overflow: Removed.
  • platform/chromium-linux-x86/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-linux-x86/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-linux-x86/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-linux-x86/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-linux-x86/fast/replaced: Removed.
  • platform/chromium-linux-x86/fast/text: Added.
  • platform/chromium-linux-x86/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs: Removed.
  • platform/chromium-linux/editing/selection/3690703-2-expected.txt:
  • platform/chromium-linux/editing/selection/3690703-expected.txt:
  • platform/chromium-linux/editing/selection/3690719-expected.txt:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-linux/fast/css/input-search-padding-expected.txt:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/input-value-expected.txt:
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-linux/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-linux/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-mac-leopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/expanding-selections-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/leave-requested-block-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/spelling/inline_spelling_markers-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/032-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/033-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/block-font-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/block-glyphs-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/font-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/glyphs-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/parsing-invalid-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-display-none-cancel-button-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/invalid: Added.
  • platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/layers-split-across-columns-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/004-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/line-clamp-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/overflow-focus-ring-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/layer-outline-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/layer-outline-horizontal-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/lines-with-layout-delta-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/opacity-change-on-overflow-float-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/003-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/029-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/overflowHidden-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.txt: Added.
  • platform/chromium-mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug154780-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-4-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug44505-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Added.
  • platform/chromium-mac/compositing/overflow/ancestor-overflow-expected.txt: Added.
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt: Added.
  • platform/chromium-mac/fast/block/float/033-expected.txt: Removed.
  • platform/chromium-mac/fast/clip/008-expected.txt: Added.
  • platform/chromium-mac/fast/clip/011-expected.txt: Added.
  • platform/chromium-mac/fast/clip/012-expected.txt: Added.
  • platform/chromium-mac/fast/css/input-search-padding-expected.txt: Added.
  • platform/chromium-mac/fast/css/invalidation-errors-2-expected.txt: Added.
  • platform/chromium-mac/fast/css/invalidation-errors-expected.txt: Added.
  • platform/chromium-mac/fast/css/line-height-expected.txt: Added.
  • platform/chromium-mac/fast/css/nested-layers-with-hover-expected.txt: Added.
  • platform/chromium-mac/fast/dom/isindex-001-expected.txt: Added.
  • platform/chromium-mac/fast/dom/isindex-002-expected.txt: Added.
  • platform/chromium-mac/fast/events/context-no-deselect-expected.txt: Added.
  • platform/chromium-mac/fast/forms/basic-inputs-expected.txt: Added.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.txt: Added.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Added.
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-win-vista/compositing/overflow: Removed.
  • platform/chromium-win-vista/fast/layers: Added.
  • platform/chromium-win-vista/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-win-vista/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-win-vista/fast/multicol: Removed.
  • platform/chromium-win-vista/fast/repaint: Added.
  • platform/chromium-win-vista/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-win-vista/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-win-vista/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-win-vista/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-win-vista/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-win-vista/http/tests/navigation: Removed.
  • platform/chromium-win-vista/tables/mozilla/bugs: Added.
  • platform/chromium-win-xp/compositing/overflow: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win-xp/fast/layers: Added.
  • platform/chromium-win-xp/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-win-xp/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-win-xp/fast/replaced: Removed.
  • platform/chromium-win-xp/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-win/compositing/overflow/ancestor-overflow-expected.txt:
  • platform/chromium-win/editing/inserting/before-after-input-element-expected.txt:
  • platform/chromium-win/editing/pasteboard/4806874-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.txt:
  • platform/chromium-win/editing/selection/3690703-2-expected.txt:
  • platform/chromium-win/editing/selection/3690703-expected.txt:
  • platform/chromium-win/editing/selection/3690719-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/drag-select-1-expected.txt:
  • platform/chromium-win/editing/selection/expanding-selections-expected.txt:
  • platform/chromium-win/editing/selection/leave-requested-block-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/editing/spelling/inline_spelling_markers-expected.txt:
  • platform/chromium-win/fast/block/float/032-expected.txt:
  • platform/chromium-win/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
  • platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-win/fast/css/input-search-padding-expected.txt:
  • platform/chromium-win/fast/css/invalidation-errors-2-expected.txt:
  • platform/chromium-win/fast/css/invalidation-errors-expected.txt:
  • platform/chromium-win/fast/css/line-height-expected.txt:
  • platform/chromium-win/fast/css/nested-layers-with-hover-expected.txt:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium-win/fast/css/text-overflow-input-expected.txt:
  • platform/chromium-win/fast/dom/isindex-001-expected.txt:
  • platform/chromium-win/fast/dom/isindex-002-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/encoding-test-expected.txt:
  • platform/chromium-win/fast/forms/fieldset-align-expected.txt:
  • platform/chromium-win/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-win/fast/forms/input-align-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-visibility-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-width-expected.txt:
  • platform/chromium-win/fast/forms/input-baseline-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-field-text-truncated-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-empty-expected.txt:
  • platform/chromium-win/fast/forms/input-spaces-expected.txt:
  • platform/chromium-win/fast/forms/input-table-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-outside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/input-value-expected.txt:
  • platform/chromium-win/fast/forms/input-width-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/text-style-color-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-win/fast/layers/remove-layer-with-nested-stacking-expected.txt:
  • platform/chromium-win/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-win/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/chromium-win/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/chromium-win/fast/overflow/004-expected.txt:
  • platform/chromium-win/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
  • platform/chromium-win/fast/overflow/line-clamp-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/chromium-win/fast/repaint/inline-relative-positioned-expected.txt:
  • platform/chromium-win/fast/repaint/layer-outline-expected.txt:
  • platform/chromium-win/fast/repaint/layer-outline-horizontal-expected.txt:
  • platform/chromium-win/fast/repaint/lines-with-layout-delta-expected.txt:
  • platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
  • platform/chromium-win/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/repaint/repaint-resized-overflow-expected.txt:
  • platform/chromium-win/fast/repaint/subtree-layoutstate-transform-expected.txt:
  • platform/chromium-win/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-win/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-win/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-win/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/chromium-win/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-textfield-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/chromium-win/fast/table/003-expected.txt:
  • platform/chromium-win/fast/table/029-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium-win/fast/table/overflowHidden-expected.txt:
  • platform/chromium-win/fast/table/spanOverlapRepaint-expected.txt:
  • platform/chromium-win/fast/table/text-field-baseline-expected.txt:
  • platform/chromium-win/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-win/fast/text/selection-rect-rounding-expected.txt:
  • platform/chromium-win/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/003-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/45621-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug154780-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-win/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/chromium/fast/block/float/033-expected.txt: Added.
  • platform/chromium/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/chromium/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/chromium/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
  • platform/chromium/fast/block/float/in-margin-expected.txt: Added.
  • platform/chromium/fast/clip: Added.
  • platform/chromium/fast/clip/017-expected.txt: Added.
  • platform/chromium/fast/dynamic: Added.
  • platform/chromium/fast/dynamic/subtree-boundary-percent-height-expected.txt: Added.
  • platform/chromium/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Added.
  • platform/chromium/fast/dynamic/subtree-table-cell-height-expected.txt: Added.
  • platform/chromium/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium/fast/speech: Removed.
  • platform/chromium/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
11:15 AM Changeset in webkit [110178] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

WebKitGtk+ fails to build on win32 against GTK3
​https://bugs.webkit.org/show_bug.cgi?id=63919

Patch by Mikkel Kruse Johnsen <​mikkel@linet.dk> on 2012-03-08
Reviewed by Gustavo Noronha Silva.

  • plugins/gtk/PluginViewGtk.cpp: Don't use gtk_socket_new with GTK3 on Win32

(WebCore::PluginView::platformStart):

11:13 AM Changeset in webkit [110177] by sfalken@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix line endings for copy-files.cmd.

If a cmd file doesn't have Windows line endings, it doesn't work properly.
In this case, the label :clean wasn't found, breaking the clean build.

Reviewed by Jessie Berlin.

11:01 AM Changeset in webkit [110176] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry]New feature: support about:cookie for internal build.
​https://bugs.webkit.org/show_bug.cgi?id=80367

Patch by Jason Liu <​jason.liu@torchmobile.com.cn> on 2012-03-08
Reviewed by Antonio Gomes.

No new tests.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore):

  • platform/blackberry/CookieManager.h:
  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleAbout):

10:21 AM Changeset in webkit [110175] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Always use the current focused node when processing focus changes
​https://bugs.webkit.org/show_bug.cgi?id=80594

Patch by Mike Fenton <​mifenton@rim.com> on 2012-03-08
Reviewed by Antonio Gomes.

Update InputHandler focused node handling to strictly use
the currently focused node. This prevents a handling loop
when JS is modifying the focus and we get a late notification
of a past change from ChromeClientBlackBerry with the previously
unfocused node.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::focusedNodeChanged):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
(WebCore::EditorClientBlackBerry::setInputMethodState):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):

  • WebKitSupport/InputHandler.h:
10:09 AM Changeset in webkit [110174] by jberlin@webkit.org
  • 2 edits in trunk/Source/ThirdParty

More Windows build fixing.

  • gtest/msvc/gtest-md.vcproj:
9:48 AM Changeset in webkit [110173] by sullivan@apple.com
  • 2 edits in trunk/Tools

Made extract-localizable-strings ignore NSLocalizedFileSizeDescription

Reviewed by Eric Carlson.

  • Scripts/extract-localizable-strings:

Added NSLocalizedFileSizeDescription to allowed list of tokens that start
with NSLocalized. Also improved an error message to include the troublesome token.

9:42 AM Changeset in webkit [110172] by caio.oliveira@openbossa.org
  • 14 edits in trunk/Source

Make elements with attributes smaller by eliminating the m_element back pointer in NamedNodeMap
​https://bugs.webkit.org/show_bug.cgi?id=75069

Reviewed by Ryosuke Niwa.

Source/WebCore:

NamedNodeMap is an exposed DOM representation of an element's attribute storage. As part of
its implementation it keeps a pointer to its associated Element plus all the attribute
storage.

This commit separate the two things: NamedNodeMap is now a wrapper to Element, containing
only the pointer, and the attribute storage is now owned by Element directly. Since usage
of NamedNodeMap is not very common, it can be stored in ElementRareData. As a result, most
elements with attributes now don't need to allocate memory for that extra pointer in
NamedNodeMap.

One consequence of this implementation is that now we explicitly don't support
DocumentType.notations and DocumentType.entities. They weren't supported before, a
NamedNodeMap was never created for those attributes -- and some NamedNodeMap functions
wouldn't work correctly without an associated Element.

NamedNodeMap itself was cleaned up, as well as unnecessary references to it removed in the
code and comments.

No new tests and should not change results for existing tests.

  • dom/Attribute.h:

(WebCore):

  • dom/DocumentType.h:

(DocumentType): Point out that we don't support does attributes yet.

  • dom/Element.cpp:

(WebCore::Element::~Element): Detaching the NamedNodeMap is no longer necessary because it
will be destroyed. We still detach the potential Attrs inside our Attributes by using
clearAttributes().
(WebCore::Element::attributes): Looks in ElementRareData now. Note we ensure the creation
of the attribute storage.
(WebCore):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasAttributes):
(WebCore::Element::createAttributeData):
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
(WebCore::Element::hasNamedNodeMap): Helper function for Node::dumpStatistics().

  • dom/Element.h:

(Element):
(WebCore::Element::attributeData):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore::Element::idForStyleResolution):
(WebCore::Element::attributeCount):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::create):
(ElementAttributeData):

  • dom/ElementRareData.h:

(ElementRareData):

  • dom/NamedNodeMap.cpp: Rewriting now that m_attributeData is not a member, using m_element

methods when possible.
(WebCore::NamedNodeMap::ref):
(WebCore::NamedNodeMap::deref):
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::getNamedItemNS):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::item):
(WebCore::NamedNodeMap::length):

  • dom/NamedNodeMap.h:

(WebCore):
(WebCore::NamedNodeMap::create):
(NamedNodeMap):
(WebCore::NamedNodeMap::NamedNodeMap): Instead of asserting m_element in every function, we
now assert only in the constructor.

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics): Add a counter for elements with rare data, this allows us
compare more clearly the impact of moving NamedNodeMap there.
(WebCore::Node::isEqualNode): Remove use of mapsEquivalent(). It was dead code, because
both entities and notations were always NULL.
(WebCore::Node::compareDocumentPosition):

  • inspector/DOMPatchSupport.h:

(WebCore):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged):

Source/WebKit/chromium:

  • src/WebElement.cpp: Include NamedNodeMap.h since Element.h doesn't include it anymore.
9:03 AM Moving to Git edited by rniwa@webkit.org
(diff)
8:53 AM Changeset in webkit [110171] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebCore

[BlackBerry] Upstream WebGL related files from platform/graphics
​https://bugs.webkit.org/show_bug.cgi?id=79876

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2012-03-08
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • platform/graphics/blackberry/DrawingBufferBlackBerry.cpp: Added.

(WebCore):
(DrawingBufferInternal):
(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::platformLayer):

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp: Added.

(WebCore):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::isGLES2NPOTStrict):
(WebCore::GraphicsContext3D::isErrorGeneratedOnOutOfBoundsAccesses):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::paintToCanvas):
(WebCore::GraphicsContext3D::setContextLostCallback):

  • platform/graphics/blackberry/WebGLLayerWebKitThread.cpp: Added.

(WebCore):
(WebCore::WebGLLayerWebKitThread::WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::~WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::setNeedsDisplay):
(WebCore::WebGLLayerWebKitThread::updateTextureContentsIfNeeded):

  • platform/graphics/blackberry/WebGLLayerWebKitThread.h: Added.

(WebCore):
(WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::create):
(WebCore::WebGLLayerWebKitThread::setWebGLContext):

8:43 AM WebKitGTK/1.8.x edited by plaes@plaes.org
Dropping the invalid changeset (diff)
8:42 AM Changeset in webkit [110170] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] LayerRender should turn off stencil/scissor after drawing layers
​https://bugs.webkit.org/show_bug.cgi?id=80598

Patch by Yong Li <​yoli@rim.com> on 2012-03-08
Reviewed by Rob Buis.

Turn off stencil/scissor after using them to avoid affecting later GL operation
accidentally.

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::drawLayers):

8:05 AM Changeset in webkit [110169] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt WK2] Remove duplicate code related to dialog handling in QQuickWebView
​https://bugs.webkit.org/show_bug.cgi?id=80557

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-03-08
Reviewed by Simon Hausmann.

Move common code related to running QtDialogRunner into a separate function

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewPrivate::handleAuthenticationRequiredRequest):
(QQuickWebViewPrivate::handleProxyAuthenticationRequiredRequest):
(QQuickWebViewPrivate::handleCertificateVerificationRequest):
(QQuickWebViewPrivate::execDialogRunner):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

7:50 AM Changeset in webkit [110168] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Fix flaky test by decreasing granularity of cues (cues cover longer time
intervals). The flakiness seems to appear because the video is paused
synchronously, while missed events events are dispatched asynchronously.

It can happen that multiple cues are actually missed cues, hence more exit
events are dispatched together, but the video was paused before the actual
dispatch.

​https://bugs.webkit.org/show_bug.cgi?id=80067

Patch by Victor Carbune <​vcarbune@adobe.com> on 2012-03-08
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/simple-captions.vtt:
  • media/track/track-cues-pause-on-exit-expected.txt:
  • media/track/track-cues-pause-on-exit.html:
7:28 AM Changeset in webkit [110167] by Csaba Osztrogonác
  • 36 edits in trunk/LayoutTests

[Qt] Rebaseline after r110072.

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-03-08
Reviewed by Csaba Osztrogonác.

  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/qt/fast/clip/008-expected.png:
  • platform/qt/fast/clip/008-expected.txt:
  • platform/qt/fast/clip/011-expected.png:
  • platform/qt/fast/clip/011-expected.txt:
  • platform/qt/fast/clip/012-expected.png:
  • platform/qt/fast/clip/012-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/qt/test_expectations.txt:
7:08 AM Changeset in webkit [110166] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Windows build fix.

Reviewed by Tor Arne Vestbø.

  • DerivedSources.pri: Replace commandline that is too long for Windows with

separate lines to be executed in the Makefile for the IDL preprocessing.

6:09 AM Changeset in webkit [110165] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

Mark compositing/reflections/nested-reflection-opacity.html as flaky.

  • platform/chromium/test_expectations.txt:
6:06 AM Changeset in webkit [110164] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: The function had to return a hash but it returned just address.
​https://bugs.webkit.org/show_bug.cgi?id=80591

Reviewed by Yury Semikhatsky.

  • bindings/v8/RetainedDOMInfo.cpp:

(WebCore::RetainedDOMInfo::GetHash):

5:24 AM Changeset in webkit [110163] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed single line fix. The function had to return a hash but it returned just address.

  • bindings/v8/V8GCController.cpp:

(WebCore::UnspecifiedGroup::GetHash):

4:41 AM Changeset in webkit [110162] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

Mark some tests failing on Leopard after the Lion rebaselines.

  • platform/chromium/test_expectations.txt:
3:25 AM Changeset in webkit [110161] by shinyak@chromium.org
  • 18 edits
    4 adds in trunk

<shadow> should be rendered correctly.
​https://bugs.webkit.org/show_bug.cgi?id=78596

Reviewed by Hajime Morita.

Source/WebCore:

This patch supports <shadow> element rendering.

When attaching <shadow> element, if it is in the oldest shadow tree, it runs a part of
distribution algorithm. If it is in non-oldest shadow tree, it runs tree a part of
tree composition algorithm to assign a older shadow root. In this patch, InsertionPonit
try to treat the distributed host children and the assigned shadow children similarly.

NodeRenderingContext supports rendering <shadow> element. Since the assigned shadow children
are treated like distributed host children, that change is to consider non-youngest shadow
tree basically also.

Tests: fast/dom/shadow/shadow-element-rendering-multiple.html

fast/dom/shadow/shadow-element-rendering-single.html

  • dom/NodeRenderingContext.cpp:

(WebCore):
(WebCore::NodeRenderingContext::NodeRenderingContext):

Does not ignore non-youngest shadow tree.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):

  • dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::ShadowRoot::assignedTo):
(WebCore):
(WebCore::ShadowRoot::setAssignedTo):
(WebCore::ShadowRoot::isUsedForRendering):

Returns true if ShadowRoot is youngest or assigned to some InsertionPoint.

(WebCore::toShadowRoot):

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::insertionPointFor):

Returns InsertionPoint to which node is distributed.

  • dom/ShadowTree.h:

(ShadowTree):

  • html/shadow/HTMLContentElement.h:

(WebCore::HTMLContentElement::doesSelectFromHostChildren):
(HTMLContentElement):

  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::HTMLShadowElement):
(WebCore::HTMLShadowElement::select):
(WebCore::HTMLShadowElement::doesSelectFromHostChildren):
(WebCore):

  • html/shadow/HTMLShadowElement.h:

(HTMLShadowElement):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::assignedFrom):
(WebCore):
(WebCore::InsertionPoint::assignShadowRoot):
(WebCore::InsertionPoint::clearAssignment):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):

LayoutTests:

Contains tests both in case <shadow> appears in the oldest shadow root and
non-olderst shadow tree.

  • fast/dom/shadow/shadow-element-rendering-multiple-expected.txt: Added.
  • fast/dom/shadow/shadow-element-rendering-multiple.html: Added.
  • fast/dom/shadow/shadow-element-rendering-single-expected.txt: Added.
  • fast/dom/shadow/shadow-element-rendering-single.html: Added.
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
3:22 AM Changeset in webkit [110160] by hans@chromium.org
  • 2 edits
    9 adds in trunk/Source/WebCore

Speech JavaScript API: SpeechRecognitionAlternative, Result and ResultList
​https://bugs.webkit.org/show_bug.cgi?id=80424

Reviewed by Adam Barth.

Implement the SpeechRecognitionAlternative,
SpeechRecognitionResult and SpeechRecognitionResultList.
(Spec: ​http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)

No new tests because these interfaces don't have constructors.
They will be tested as more of the API gets implemented.

  • Modules/speech/SpeechRecognitionAlternative.cpp: Added.

(WebCore):
(WebCore::SpeechRecognitionAlternative::create):
(WebCore::SpeechRecognitionAlternative::SpeechRecognitionAlternative):

  • Modules/speech/SpeechRecognitionAlternative.h: Added.

(WebCore):
(SpeechRecognitionAlternative):
(WebCore::SpeechRecognitionAlternative::transcript):
(WebCore::SpeechRecognitionAlternative::confidence):

  • Modules/speech/SpeechRecognitionAlternative.idl: Added.
  • Modules/speech/SpeechRecognitionResult.cpp: Added.

(WebCore):
(WebCore::SpeechRecognitionResult::create):
(WebCore::SpeechRecognitionResult::item):
(WebCore::SpeechRecognitionResult::SpeechRecognitionResult):

  • Modules/speech/SpeechRecognitionResult.h: Added.

(WebCore):
(SpeechRecognitionResult):
(WebCore::SpeechRecognitionResult::length):
(WebCore::SpeechRecognitionResult::final):

  • Modules/speech/SpeechRecognitionResult.idl: Added.
  • Modules/speech/SpeechRecognitionResultList.cpp: Added.

(WebCore):
(WebCore::SpeechRecognitionResultList::create):
(WebCore::SpeechRecognitionResultList::item):
(WebCore::SpeechRecognitionResultList::SpeechRecognitionResultList):

  • Modules/speech/SpeechRecognitionResultList.h: Added.

(WebCore):
(SpeechRecognitionResultList):
(WebCore::SpeechRecognitionResultList::length):

  • Modules/speech/SpeechRecognitionResultList.idl: Added.
  • WebCore.gypi:
2:01 AM Changeset in webkit [110159] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFA incorrectly handles ValueToInt32
​https://bugs.webkit.org/show_bug.cgi?id=80568

Reviewed by Gavin Barraclough.

Changed it match exactly the decision pattern used in
DFG::SpeculativeJIT::compileValueToInt32

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

1:57 AM Changeset in webkit [110158] by ostapenko.viatcheslav@nokia.com
  • 3 edits in trunk/Source/JavaScriptCore

[Qt] [WK2] Webkit fails to link when compiled with force_static_libs_as_shared
​https://bugs.webkit.org/show_bug.cgi?id=80524

Reviewed by Simon Hausmann.

Move IdentifierTable methods defintion to WTFThreadData.cpp to fix linking
of WTF library.

  • runtime/Identifier.cpp:
  • wtf/WTFThreadData.cpp:

(JSC):
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):

1:51 AM Changeset in webkit [110157] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r110115.
​http://trac.webkit.org/changeset/110115
​https://bugs.webkit.org/show_bug.cgi?id=80581

broke test-webkitpy (Requested by philn-tp on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-08

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):

1:45 AM Changeset in webkit [110156] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

[BlackBerry] Upstream GraphicsLayerBlackBerry.{h, cpp}
​https://bugs.webkit.org/show_bug.cgi?id=79867

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2012-03-08
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp: Added.

(WebCore):
(WebCore::setLayerBorderColor):
(WebCore::clearBorderColor):
(WebCore::setLayerBackgroundColor):
(WebCore::clearLayerBackgroundColor):
(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::~GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::setName):
(WebCore::GraphicsLayerBlackBerry::setChildren):
(WebCore::GraphicsLayerBlackBerry::addChild):
(WebCore::GraphicsLayerBlackBerry::addChildAtIndex):
(WebCore::GraphicsLayerBlackBerry::addChildBelow):
(WebCore::GraphicsLayerBlackBerry::addChildAbove):
(WebCore::GraphicsLayerBlackBerry::replaceChild):
(WebCore::GraphicsLayerBlackBerry::removeFromParent):
(WebCore::GraphicsLayerBlackBerry::setPosition):
(WebCore::GraphicsLayerBlackBerry::setAnchorPoint):
(WebCore::GraphicsLayerBlackBerry::setSize):
(WebCore::GraphicsLayerBlackBerry::setTransform):
(WebCore::GraphicsLayerBlackBerry::setChildrenTransform):
(WebCore::GraphicsLayerBlackBerry::setPreserves3D):
(WebCore::GraphicsLayerBlackBerry::setMasksToBounds):
(WebCore::GraphicsLayerBlackBerry::setDrawsContent):
(WebCore::GraphicsLayerBlackBerry::setContentsVisible):
(WebCore::GraphicsLayerBlackBerry::setMaskLayer):
(WebCore::GraphicsLayerBlackBerry::setReplicatedByLayer):
(WebCore::GraphicsLayerBlackBerry::setFixedPosition):
(WebCore::GraphicsLayerBlackBerry::setHasFixedContainer):
(WebCore::GraphicsLayerBlackBerry::setHasFixedAncestorInDOMTree):
(WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::clearBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setContentsOpaque):
(WebCore::GraphicsLayerBlackBerry::setBackfaceVisibility):
(WebCore::GraphicsLayerBlackBerry::setOpacity):
(WebCore::GraphicsLayerBlackBerry::setContentsNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
(WebCore::GraphicsLayerBlackBerry::setContentsRect):
(WebCore::removeAnimationByIdAndProperty):
(WebCore::removeAnimationByName):
(WebCore::GraphicsLayerBlackBerry::addAnimation):
(WebCore::GraphicsLayerBlackBerry::pauseAnimation):
(WebCore::GraphicsLayerBlackBerry::removeAnimation):
(WebCore::GraphicsLayerBlackBerry::suspendAnimations):
(WebCore::GraphicsLayerBlackBerry::resumeAnimations):
(WebCore::GraphicsLayerBlackBerry::setContentsToImage):
(WebCore::GraphicsLayerBlackBerry::updateContentsImage):
(WebCore::GraphicsLayerBlackBerry::setContentsToCanvas):
(WebCore::GraphicsLayerBlackBerry::setContentsToMedia):
(WebCore::GraphicsLayerBlackBerry::hostLayerForSublayers):
(WebCore::GraphicsLayerBlackBerry::layerForSuperlayer):
(WebCore::GraphicsLayerBlackBerry::platformLayer):
(WebCore::GraphicsLayerBlackBerry::setDebugBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setDebugBorder):
(WebCore::GraphicsLayerBlackBerry::updateSublayerList):
(WebCore::GraphicsLayerBlackBerry::updateLayerPosition):
(WebCore::GraphicsLayerBlackBerry::updateLayerSize):
(WebCore::GraphicsLayerBlackBerry::updateAnchorPoint):
(WebCore::GraphicsLayerBlackBerry::updateTransform):
(WebCore::GraphicsLayerBlackBerry::updateChildrenTransform):
(WebCore::GraphicsLayerBlackBerry::updateMasksToBounds):
(WebCore::GraphicsLayerBlackBerry::updateContentsOpaque):
(WebCore::GraphicsLayerBlackBerry::updateBackfaceVisibility):
(WebCore::GraphicsLayerBlackBerry::updateLayerPreserves3D):
(WebCore::GraphicsLayerBlackBerry::updateLayerIsDrawable):
(WebCore::GraphicsLayerBlackBerry::updateFixedPosition):
(WebCore::GraphicsLayerBlackBerry::updateHasFixedContainer):
(WebCore::GraphicsLayerBlackBerry::updateHasFixedAncestorInDOMTree):
(WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::updateAnimations):
(WebCore::GraphicsLayerBlackBerry::updateContentsVideo):
(WebCore::GraphicsLayerBlackBerry::updateContentsRect):
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):
(WebCore::GraphicsLayerBlackBerry::updateOpacityOnLayer):
(WebCore::GraphicsLayerBlackBerry::contentsVisible):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.h: Added.

(WebCore):
(GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::notifySyncRequired):
(WebCore::GraphicsLayerBlackBerry::notifyAnimationStarted):
(WebCore::GraphicsLayerBlackBerry::primaryLayer):
(WebCore::GraphicsLayerBlackBerry::contentsLayer):

1:31 AM Changeset in webkit [110155] by commit-queue@webkit.org
  • 1 edit
    18 moves
    1 add in trunk/LayoutTests

[Forms] Re-organize test files of label element
​https://bugs.webkit.org/show_bug.cgi?id=80575

There are 988 files under LayoutTests/fast/forms. It is hard to find
a file from UI. To improve discoverability of file, it is better to
organize files based on element as some test files did.

This patch moves test files of "label" element to fast/forms/label and
adjusts path of JavaScript files.

Patch by Yoshifumi Inoue <​yosin@chromium.org> on 2012-03-08
Reviewed by Kentaro Hara.

  • fast/forms/label/labels-add-htmlFor-label-expected.txt: Renamed from LayoutTests/fast/forms/labels-add-htmlFor-label-expected.txt.
  • fast/forms/label/labels-add-htmlFor-label.html: Renamed from LayoutTests/fast/forms/labels-add-htmlFor-label.html.
  • fast/forms/label/labels-add-parent-label-expected.txt: Renamed from LayoutTests/fast/forms/labels-add-parent-label-expected.txt.
  • fast/forms/label/labels-add-parent-label.html: Renamed from LayoutTests/fast/forms/labels-add-parent-label.html.
  • fast/forms/label/labels-change-htmlFor-attribute-expected.txt: Renamed from LayoutTests/fast/forms/labels-change-htmlFor-attribute-expected.txt.
  • fast/forms/label/labels-change-htmlFor-attribute.html: Renamed from LayoutTests/fast/forms/labels-change-htmlFor-attribute.html.
  • fast/forms/label/labels-custom-property-expected.txt: Renamed from LayoutTests/fast/forms/labels-custom-property-expected.txt.
  • fast/forms/label/labels-custom-property.html: Renamed from LayoutTests/fast/forms/labels-custom-property.html.
  • fast/forms/label/labels-item-index-expected.txt: Renamed from LayoutTests/fast/forms/labels-item-index-expected.txt.
  • fast/forms/label/labels-item-index.html: Renamed from LayoutTests/fast/forms/labels-item-index.html.
  • fast/forms/label/labels-remove-htmlFor-attribute-expected.txt: Renamed from LayoutTests/fast/forms/labels-remove-htmlFor-attribute-expected.txt.
  • fast/forms/label/labels-remove-htmlFor-attribute.html: Renamed from LayoutTests/fast/forms/labels-remove-htmlFor-attribute.html.
  • fast/forms/label/labels-remove-htmlFor-label-expected.txt: Renamed from LayoutTests/fast/forms/labels-remove-htmlFor-label-expected.txt.
  • fast/forms/label/labels-remove-htmlFor-label.html: Renamed from LayoutTests/fast/forms/labels-remove-htmlFor-label.html.
  • fast/forms/label/labels-remove-parent-label-expected.txt: Renamed from LayoutTests/fast/forms/labels-remove-parent-label-expected.txt.
  • fast/forms/label/labels-remove-parent-label.html: Renamed from LayoutTests/fast/forms/labels-remove-parent-label.html.
  • fast/forms/label/labels-set-htmlFor-attribute-expected.txt: Renamed from LayoutTests/fast/forms/labels-set-htmlFor-attribute-expected.txt.
  • fast/forms/label/labels-set-htmlFor-attribute.html: Renamed from LayoutTests/fast/forms/labels-set-htmlFor-attribute.html.
1:06 AM Changeset in webkit [110154] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG instruction count threshold should be lifted to 10000
​https://bugs.webkit.org/show_bug.cgi?id=80579

Reviewed by Gavin Barraclough.

  • runtime/Options.cpp:

(JSC::Options::initializeOptions):

1:02 AM Changeset in webkit [110153] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Incorrect tracking of abstract values of variables forced double
​https://bugs.webkit.org/show_bug.cgi?id=80566
<rdar://problem/11001442>

Reviewed by Gavin Barraclough.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::mergeStateAtTail):

12:35 AM Changeset in webkit [110152] by haraken@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Added myself to watchlist.

  • Scripts/webkitpy/common/config/watchlist:
12:22 AM Changeset in webkit [110151] by shinyak@chromium.org
  • 8 edits in trunk/Source/WebCore

Refactoring: Remove Node::isContentElement and Node::isShadowElement.
​https://bugs.webkit.org/show_bug.cgi?id=80501

Reviewed by Hajime Morita.

Removes Node::isContentElement and Node::isShadowElement. These methods are replaced
by hasTagName. However the tag name of HTMLContentElement was not consistent,
this patch make them consistent.

No new tests. Should be covered by existing tests.

  • dom/Node.h:
  • html/HTMLElement.h:

(WebCore::HTMLElement::isInsertionPoint):
(HTMLElement):

  • html/HTMLSummaryElement.cpp:

(WebCore::SummaryContentElement::SummaryContentElement):

It uses HTMLNames::divTag as tagname. It should use HTMLNames::webkitShadowTagName.

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):
(WebCore::InsertionPoint::isInsertionPoint):
(WebCore::isInsertionPoint):

  • testing/Internals.cpp:

(WebCore::Internals::isValidContentSelect):

  • testing/Internals.h:

(Internals):

Note: See TracTimeline for information about the timeline view.