Timeline



Mar 17, 2012:

10:24 PM WebKit Team edited by kubo@profusion.mobi
Update my affiliation (diff)
8:20 PM Changeset in webkit [111131] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] PlatformContextSkia::m_drawingToImageBuffer is not correctly set when using per-tile painting.
​https://bugs.webkit.org/show_bug.cgi?id=81463

Patch by David Reveman <​reveman@chromium.org> on 2012-03-17
Reviewed by James Robinson.

Call PlatformContextSkia::setDrawingToImageBuffer() from
SkPictureCanvasLayerTextureUpdater::prepareToUpdate so that sub-pixel
text rendering is not used incorrectly with per-tile painting.

No new tests.

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

6:57 PM Changeset in webkit [111130] by kubo@profusion.mobi
  • 3 edits in trunk/Tools

Unreviewed; switch to using my FreeBSD.org email address, the
other one is going to disappear soon.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
6:08 PM Changeset in webkit [111129] by barraclough@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Strength reduction, RegExp.exec -> RegExp.test
​https://bugs.webkit.org/show_bug.cgi?id=81459

Reviewed by Sam Weinig.

RegExp.prototype.exec & RegExp.prototype.test can both be used to test a regular
expression for a match against a string - however exec is more expensive, since
it allocates a matches array object. In cases where the result is consumed in a
boolean context the allocation of the matches array can be trivially elided.

For example:

function f()
{

for (i =0; i < 10000000; ++i)

if(!/a/.exec("a"))

err = true;

}

This is a 2.5x speedup on this example microbenchmark loop.

In a more advanced form of this optimization, we may be able to avoid allocating
the array where access to the array can be observed.

  • create_hash_table:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileRegExpExec):
(DFG):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jsc.cpp:

(GlobalObject::addConstructableFunction):

  • runtime/Intrinsic.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC):

  • runtime/JSFunction.h:

(JSFunction):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::exec):
(JSC::RegExpObject::match):

  • runtime/RegExpObject.h:

(RegExpObject):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):

4:57 PM Changeset in webkit [111128] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Make pixel-accurate wheel scrolling be unanimated
​https://bugs.webkit.org/show_bug.cgi?id=81457

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-17
Reviewed by James Robinson.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scroll):

3:56 PM Changeset in webkit [111127] by rwlbuis@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Implement openTemporaryFile in FileSystem
​https://bugs.webkit.org/show_bug.cgi?id=81373

Reviewed by George Staikos.

Move the Efl implementation to Posix, this way BlackBerry port can reuse it.

  • platform/blackberry/FileSystemBlackBerry.cpp:
  • platform/efl/FileSystemEfl.cpp:
  • platform/posix/FileSystemPOSIX.cpp:

(WebCore::openTemporaryFile):
(WebCore):

12:54 PM Changeset in webkit [111126] by commit-queue@webkit.org
  • 48 edits
    1 add in trunk/Source

move calc*Value functions out from Length (and platform)
​https://bugs.webkit.org/show_bug.cgi?id=80897

Moving the Length calc*Value functions out from Length structure and also from /WebCore/platform/ folder.
This helps to avoid the layering violation while length calculation. Otherwise layer violation can be avoided only by adding a virtual interface(bug 27160).

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-03-17
Reviewed by Antti Koivisto.

Source/WebCore:

  • GNUmakefile.list.am: Build system changes for adding new files.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(getAttributeSetForAccessibilityObject):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/LengthFunctions.h: Added. Moved calc*Value functions of Length.

(WebCore):
(WebCore::calculateMinimumValue):
(WebCore::calculateValue):
(WebCore::calculateFloatValue):

  • dom/Document.cpp:

(WebCore::Document::pageSizeAndMarginsInPixels):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::getRegion):

  • platform/CalculationValue.h:

(WebCore::CalcExpressionLength::evaluate):

  • platform/Length.h: Removed the calc*Value functions from Length structure.

(Length):
(WebCore::Length::getFloatValue):
(WebCore::Length::getIntValue):

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::setFilters):

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::getOutsets):

  • platform/graphics/transforms/PerspectiveTransformOperation.cpp:

(WebCore::PerspectiveTransformOperation::blend):

  • platform/graphics/transforms/PerspectiveTransformOperation.h:

(WebCore::PerspectiveTransformOperation::isIdentity):
(WebCore::PerspectiveTransformOperation::apply):

  • platform/graphics/transforms/TranslateTransformOperation.h:

(WebCore::TranslateTransformOperation::x):
(WebCore::TranslateTransformOperation::y):
(WebCore::TranslateTransformOperation::z):
(WebCore::TranslateTransformOperation::isIdentity):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::layout):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::layout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reflectionOffset):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::relativePositionOffsetY):
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layOutAxis):

  • rendering/RenderInline.cpp:

(WebCore::computeMargin):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::perspectiveTransform):
(WebCore::RenderLayer::perspectiveOrigin):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::computeTransformOrigin):
(WebCore::RenderLayerBacking::computePerspectiveOrigin):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::timerFired):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::logicalHeightForRowSizing):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

  • rendering/RenderText.h:

(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::applyTransform):
(WebCore::calcRadiiFor):

  • rendering/style/RenderStyle.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation):
(WebCore::resolveLengthAttributeForSVG):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::currentViewBoxRect):
(WebCore::SVGSVGElement::currentViewportSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::computeIntrinsicDimensions):

Source/WebKit2:

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

12:23 PM Changeset in webkit [111125] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/10263562> Crash in WebCore::Range::startPosition() when dismissing the Press and Hold panel by clicking in the menu bar
​https://bugs.webkit.org/show_bug.cgi?id=81454

Reviewed by Ada Chan.

When the Press and Hold panel is dismissed by clicking in the menu bar,
-insertText:replacementRange: is called with an NSRange whose location is NSNotFound - 1
(see <rdar://problem/11069374>). Trying to convert this bogus range to a WebCore Range
returns 0, which leads to the crash.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::insertText): Added a null check, to protect the code from bogus ranges.

11:53 AM Changeset in webkit [111124] by abarth@webkit.org
  • 1 edit in branches/chromium/1025/Source/WebCore/page/DOMWindow.cpp

Merge 106874 - postMessage leaks MemoryEvent object
​https://bugs.webkit.org/show_bug.cgi?id=77893

Patch by Greg Simon <​gregsimon@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

Changed from PassRefPtr().leakRef() to RefPtr.get() when
calling into FrameLoaderClient to stop +1 extra ref.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/9717030

11:19 AM Changeset in webkit [111123] by jamesr@google.com
  • 2 edits in branches/chromium/1025/Source/WebCore

Merge 110821 - Platforms without USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) don't need to query the page's displayID
​https://bugs.webkit.org/show_bug.cgi?id=81187

Reviewed by Simon Fraser.

  • dom/Document.cpp:

(WebCore::Document::webkitRequestAnimationFrame):

TBR=​jamesr@google.com
BUG=118331
Review URL: ​https://chromiumcodereview.appspot.com/9716016

11:12 AM Changeset in webkit [111122] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

Unreviewed; fix webkitpy unit test failures after r111116.

It turns out that cmd_line in the patch in bug 80025 had the right
signature when it was submitted, but r109242 added a few more
required parameters, and since the method (and EflDriver) did not
exist at the time we ended up committing a broken method.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflDriver.cmd_line): Add the pixel_tests' and per_test_args'
arguments.

8:45 AM Changeset in webkit [111121] by charles.wei@torchmobile.com.cn
  • 7 edits in trunk

[BlackBerry] Enable Web Timing for performance profiling and improvement.
​https://bugs.webkit.org/show_bug.cgi?id=81085

Reviewed by Rob Buis.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

Tools:

  • Scripts/build-webkit:
5:13 AM Changeset in webkit [111120] by Nikolas Zimmermann
  • 33 edits in trunk

Enable animVal support for SVGNumberOptionalNumber
​https://bugs.webkit.org/show_bug.cgi?id=81448

Reviewed by Antti Koivisto.

Source/WebCore:

Enable animVal support for SVGNumberOptionalNumber. Its a special case as two SVG DOM properties
eg. stdDeviationX/stdDeviationY are mapped to a single XML attribute: SVGNames::stdDeviationAttr.

When animating properties like this, both animVal wrappers need to reflect changes.
Generalize the current animVal code to support more than one SVGAnimatedProperty that gets
animated for a single attributeName. This allows us to remove SVGAnimatedType::variantValue/setVariantValue
which paves the way for removing SVGGenericAnimatedType from even more places.

Covered by existing tests.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::targetElementWillChange):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedLengthAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedLength.h:

(SVGAnimatedLengthAnimator):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedLengthList.h:

(SVGAnimatedLengthListAnimator):

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedNumberAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedNumber.h:

(SVGAnimatedNumberAnimator):

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedNumberList.h:

(SVGAnimatedNumberListAnimator):

  • svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedNumberOptionalNumber.h:

(WebCore):
(SVGAnimatedNumberOptionalNumberAnimator):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimatedTypeToBaseValue):
(WebCore):

  • svg/SVGAnimatedTransformList.h:

(SVGAnimatedTransformListAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal):

  • svg/SVGAnimatedType.h:

(SVGAnimatedType):

  • svg/SVGAnimatedTypeAnimator.h:

(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetAnimatedTypeToBaseValue):
(WebCore::SVGAnimatedTypeAnimator::currentBaseValueVariant):
(WebCore::SVGAnimatedTypeAnimator::constructFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetAnimatedTypeFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::constructFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetAnimatedTypeFromTwoBaseValues):

  • svg/SVGAnimationElement.cpp:

(WebCore::findMatchingAnimatedProperties):
(WebCore::SVGAnimationElement::applyAnimatedValue):
(WebCore::notifyAnimatedPropertyAboutAnimationBeginEnd):
(WebCore::SVGAnimationElement::animationStarted):
(WebCore::SVGAnimationElement::animationEnded):
(WebCore::SVGAnimationElement::animatedPropertiesForType):

  • svg/SVGAnimationElement.h:
  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(WebCore::SVGAnimatedListPropertyTearOff::currentBaseValueVariant):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):

  • svg/properties/SVGAnimatedProperty.h:

(SVGAnimatedProperty):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::currentBaseValueVariant):
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValueVariant):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationStarted):

LayoutTests:

Extend SVGNumberOptionalNumber tests to cover animVal/baseVal at the same time.

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/svgnumberoptionalnumber-animation-1-expected.txt:
  • svg/animations/svgnumberoptionalnumber-animation-2-expected.txt:
  • svg/animations/svgnumberoptionalnumber-animation-3-expected.txt:
  • svg/animations/svgnumberoptionalnumber-animation-4-expected.txt:
4:30 AM Changeset in webkit [111119] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

[GStreamer] run AudioFileReader in a nested loop
​https://bugs.webkit.org/show_bug.cgi?id=80823

Reviewed by Martin Robinson.

Use a separate main loop for the file reader, this approach is
much cleaner than polling the default GLib main context.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(AudioFileReader):
(WebCore::enteredMainLoopCallback):
(WebCore):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::handleMessage):
(WebCore::AudioFileReader::start):
(WebCore::AudioFileReader::createBus):

3:48 AM Changeset in webkit [111118] by robert@webkit.org
  • 4 edits
    6 adds in trunk

CSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015 fail
​https://bugs.webkit.org/show_bug.cgi?id=78027

Reviewed by Julien Chaffraix.

Source/WebCore:

Both of these test the (slightly implicit) rule that width set on column-groups cannot
affect the width of columns in a fixed layout table: ​http://www.w3.org/TR/CSS21/tables.html#fixed-table-layout
FF, Opera and IE all pass these two tests.

Tests: css2.1/20110323/fixed-table-layout-013.htm

css2.1/20110323/fixed-table-layout-015.htm
fast/table/fixed-table-layout-toggle-colwidth.html

  • rendering/FixedTableLayout.cpp:

(WebCore::nextCol): A helper function for finding the next column along.
(WebCore::FixedTableLayout::calcWidthArray): Ignore width specified by column groups.

  • rendering/RenderTableCol.h:

(WebCore::RenderTableCol::isTableColGroup): Convenience function for identifying column groups.

LayoutTests:

  • css2.1/20110323/fixed-table-layout-013-expected.html: Added.
  • css2.1/20110323/fixed-table-layout-013.htm: Added.
  • css2.1/20110323/fixed-table-layout-015-expected.html: Added.
  • css2.1/20110323/fixed-table-layout-015.htm: Added.
  • fast/table/fixed-table-layout-toggle-colwidth-expected.txt: Added.
  • fast/table/fixed-table-layout-toggle-colwidth.html: Added.
12:45 AM Changeset in webkit [111117] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

Add a dependencies installation step for EFL to buildbot master.cfg
​https://bugs.webkit.org/show_bug.cgi?id=81337

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(InstallEflDependencies):
(Factory.init):

12:33 AM Changeset in webkit [111116] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

[EFL] Prefixing run-webkit-tests with run-with-jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=80025

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflDriver):
(EflDriver.cmd_line):
(EflPort._driver_class):

12:30 AM Changeset in webkit [111115] by kubo@profusion.mobi
  • 2 edits
    6 adds in trunk/Tools

[EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
​https://bugs.webkit.org/show_bug.cgi?id=79904

build-webkit --efl will use jhbuild for fetching and building dependencies.

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

  • Scripts/update-webkitefl-libs: Added.
  • Scripts/webkitdirs.pm:

(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):

  • efl/common.py: Added.

(script_path):
(top_level_path):
(number_of_cpus):

  • efl/jhbuild.modules: Added.
  • efl/jhbuildrc: Added.
  • efl/run-with-jhbuild: Added.

Mar 16, 2012:

11:42 PM Changeset in webkit [111114] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add BlackBerry to NavigatorBase.cpp
​https://bugs.webkit.org/show_bug.cgi?id=81303

Reviewed by Rob Buis.

  • page/NavigatorBase.cpp:
11:39 PM Changeset in webkit [111113] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add typedef of DragDataRef for blackberry
​https://bugs.webkit.org/show_bug.cgi?id=81301

Reviewed by Rob Buis.

  • platform/DragData.h:
9:15 PM Changeset in webkit [111112] by commit-queue@webkit.org
  • 13 edits
    4 moves
    4 deletes in trunk/Source

[chromium] Unify the drawing logic for different layer types that output textures to the compositor
​https://bugs.webkit.org/show_bug.cgi?id=81286

Patch by James Robinson <​jamesr@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Currently canvas 2d, webgl, and plugin layers all export a texture to the compositor that then needs to be
drawn. There are a small set of operations that can be applied to the texture at draw time - do a Y flip,
stretch a subrect to the layer bounds, set the blend mode etc but they are fundamentally the same thing. This
collapses the nearly-redundant code into a single impl-side layer type for a texture-backed layer that can
handle the union of the bits needed for each layer type.

Canvas 2d, WebGL and plugin composited rendering are all covered by layout tests.

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawQuad):
(WebCore::TexStretchTextureProgramBinding::set):
(WebCore::TexTransformTextureProgramBinding::set):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::textureLayerProgramFlip):
(WebCore::LayerRendererChromium::textureLayerProgramStretch):
(WebCore::LayerRendererChromium::textureLayerProgramStretchFlip):
(WebCore::LayerRendererChromium::textureLayerTexRectProgram):
(WebCore::LayerRendererChromium::textureLayerTexRectProgramFlip):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::createCCLayerImpl):
(WebCore::PluginLayerChromium::setIOSurfaceProperties):
(WebCore::PluginLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/PluginLayerChromium.h:

(PluginLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/cc/CCCanvasDrawQuad.cpp: Removed.
  • platform/graphics/chromium/cc/CCCanvasDrawQuad.h: Removed.
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: Removed.
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h: Removed.
  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toTextureDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginDrawQuad.cpp.

(WebCore):
(WebCore::CCTextureDrawQuad::create):
(WebCore::CCTextureDrawQuad::CCTextureDrawQuad):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginDrawQuad.h.

(WebCore):
(CCTextureDrawQuad):
(WebCore::CCTextureDrawQuad::textureId):
(WebCore::CCTextureDrawQuad::hasAlpha):
(WebCore::CCTextureDrawQuad::premultipliedAlpha):
(WebCore::CCTextureDrawQuad::uvRect):
(WebCore::CCTextureDrawQuad::flipped):
(WebCore::CCTextureDrawQuad::ioSurfaceSize):
(WebCore::CCTextureDrawQuad::ioSurfaceTextureId):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.cpp.

(WebCore):
(WebCore::CCTextureLayerImpl::CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::~CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::willDraw):
(WebCore::CCTextureLayerImpl::appendQuads):
(WebCore::CCTextureLayerImpl::dumpLayerProperties):
(WebCore::CCTextureLayerImpl::didLoseContext):
(WebCore::CCTextureLayerImpl::setIOSurfaceProperties):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.

(WebCore):
(CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::create):
(WebCore::CCTextureLayerImpl::textureId):
(WebCore::CCTextureLayerImpl::setTextureId):
(WebCore::CCTextureLayerImpl::setHasAlpha):
(WebCore::CCTextureLayerImpl::setPremultipliedAlpha):
(WebCore::CCTextureLayerImpl::setFlipped):
(WebCore::CCTextureLayerImpl::setUVRect):
(WebCore::CCTextureLayerImpl::layerTypeAsString):

Source/WebKit/chromium:

  • tests/Canvas2DLayerChromiumTest.cpp:
8:00 PM Changeset in webkit [111111] by kubo@profusion.mobi
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening after r111110.

  • platform/efl/Skipped: Unskip fast/canvas/fillText-shadow.html

just like GTK+ did.

7:55 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
7:54 PM Changeset in webkit [111110] by Martin Robinson
  • 4 edits in trunk

[Cairo] Text extent of shadowed text is calculated incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=65035

Source/WebCore:

Reviewed by Martin Robinson.

No new tests. This is already covered by fast/canvas/fillText-shadow.html.

Correct determine the size of rendered text using x and y bearing from the font
extents.

  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::drawGlyphsShadow): Use the x and y bearing to calculate text extents.
This gives a more accurate sizing and avoids clipping the edges of the shadow.

LayoutTests:

Reviewed by Martin Robinson

  • platform/gtk/Skipped: Unskip a test that is now passing.
7:32 PM Changeset in webkit [111109] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium][Performance] Optimize innerText and outerText in Chromium/Mac
​https://bugs.webkit.org/show_bug.cgi?id=81192

Reviewed by Dimitri Glazkov.

This patch makes innerText and outerText 4 times faster on Chromium/Mac.
A similar performance improvement will be also observed in APIs that are using
TextIterator::plainText() (e.g. Editting, SpellChecker, Clipboard, Pasteboard etc).

Performance test: ​https://bugs.webkit.org/attachment.cgi?id=131989

  • AppleWebKit/JavaScriptCore/Mac:

div.innerText : 2978.4ms
div.outerText : 2944.4ms

  • Chromium/V8/Mac without the patch:

div.innerText : 10050.8ms
div.outerText : 10072.2ms

  • Chromium/V8/Mac with the patch:

div.innerText: 2536.4ms
div.outerText: 2714ms

This patch just changes the initial buffer size of a plain text buffer on Chromium/Mac.
As shown below, in my local Chromium/Mac environment the performance changes
dramatically between 1<<15 and 1<<16, and in my local Chromium/Linux environment
the performance changes between 1<<17 and 1<<18. I am not yet sure what determines
these figures, but it seems there exists a performance gap at some point
depending on a malloc mechanism.

  • div.innerText results on Chromium/V8/Mac:

WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 14 ==> 2465.6 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 15 ==> 2447.2 ms <--- after this patch
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 16 ==> 10250.8 ms <--- before this patch
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 17 ==> 10278.2 ms

  • div.innerText results on Chromium/V8/Linux:

WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 14 ==> 1569.8 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 15 ==> 1531.8 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 16 ==> 1543.2 ms <--- before/after this patch
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 17 ==> 1541.6 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 18 ==> 12540.8 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 19 ==> 12340.8 ms

  • editing/TextIterator.cpp:

(WebCore::plainTextToMallocAllocatedBuffer):

7:27 PM Changeset in webkit [111108] by dimich@chromium.org
  • 2 edits in trunk/Source/WebCore

HTMLFrameElementBase::m_remainsAliveOnRemovalFromTree can be cleared without unloading the frame.
​https://bugs.webkit.org/show_bug.cgi?id=80766

Reviewed by Adam Barth.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::insertedIntoDocument):
(WebCore::HTMLFrameElementBase::setRemainsAliveOnRemovalFromTree):
if adoptNode() is called on a detached iframe or with a detached document,
unload the iframe to avoid live iframe to hang around w/o being attached to
a document.

7:22 PM Changeset in webkit [111107] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Xcode project file is not sorted.
​https://bugs.webkit.org/show_bug.cgi?id=81439

Sorted the project file entries using sort-Xcode-project-file script.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-03-16
Reviewed by Eric Seidel.

  • WebCore.xcodeproj/project.pbxproj:
7:16 PM Changeset in webkit [111106] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r111075.
Correct the path of WebKitBlobBuilder.idl.

  • DerivedSources.pri:
7:01 PM Changeset in webkit [111105] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix for test runs for non-chromium platforms.

  • loader/cache/MemoryCache.cpp:

(WebCore::memoryCache):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationFailed):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::evict):

6:55 PM Changeset in webkit [111104] by commit-queue@webkit.org
  • 19 edits
    10 adds
    5 deletes in trunk/LayoutTests

Rebaselines for compositing tests with video
​https://bugs.webkit.org/show_bug.cgi?id=81430

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-03-16
Reviewed by James Robinson.

  • platform/chromium-linux/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-linux/compositing/visibility/visibility-simple-video-layer-expected.png:
  • platform/chromium-mac-leopard/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-mac-leopard/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium-mac-leopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-mac-leopard/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-mac-leopard/compositing/self-painting-layers-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-mac/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-mac/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-mac/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-mac/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/chromium-win/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.txt:
  • platform/chromium-win/compositing/self-painting-layers-expected.png:
  • platform/chromium-win/compositing/visibility/visibility-simple-video-layer-expected.png:
  • platform/chromium/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
  • platform/chromium/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
  • platform/chromium/compositing/self-painting-layers-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
6:29 PM Changeset in webkit [111103] by tony@chromium.org
  • 8 edits in trunk

Unreviewed, rolling out r111094.
​http://trac.webkit.org/changeset/111094
​https://bugs.webkit.org/show_bug.cgi?id=80882

broke test on chromium-win

Source/WebCore:

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/child-overflow-expected.html:
  • css3/flexbox/child-overflow.html:
  • css3/flexbox/flex-align-stretch-expected.txt:
  • css3/flexbox/flex-align-stretch.html:
6:21 PM Changeset in webkit [111102] by andersca@apple.com
  • 7 edits in trunk/Source/WebCore

REGRESSION (r110737): Height element changes on scrolled page causes failure
​https://bugs.webkit.org/show_bug.cgi?id=81381
<rdar://problem/11066006>

Reviewed by Sam Weinig.

Limit the fix made in r110737 to check if there's a rubber-band gesture in progress and only ignore the range if that is the case.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::isRubberBandInProgress):
(ScrollAnimator):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::isRubberBandInProgress):
(WebCore):

  • platform/mac/ScrollElasticityController.h:

(ScrollElasticityController):

  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::isRubberBandInProgress):
(WebCore):

5:52 PM Changeset in webkit [111101] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

GestureTapDown needs to pin in-progress flings
​https://bugs.webkit.org/show_bug.cgi?id=80875

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

  • page/EventHandler.cpp:

(WebCore):
(WebCore::EventHandler::handleGestureTapDown):

  • page/EventHandler.h:

(EventHandler):

5:49 PM Changeset in webkit [111100] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

Account for sample-rate in convolution normalization
​https://bugs.webkit.org/show_bug.cgi?id=81432

Reviewed by James Robinson.

  • platform/audio/Reverb.cpp:

(WebCore):
(WebCore::calculateNormalizationScale):

  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::setBuffer):

5:41 PM Changeset in webkit [111099] by commit-queue@webkit.org
  • 5 edits
    2 moves in trunk/Source/WebKit

[BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositorPrivate
​https://bugs.webkit.org/show_bug.cgi?id=81108
RIM PR: 136687

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This is done in anticipation of a new WebPageCompositor class in the
public API. The existing internal class will serve to d-pointerize the
new public API. In addition, it is and will be possible to create only
the private class, for cases where existing code paths require
OpenGL compositing (i.e. due to accelerated compositing layers being
added to the page).

Reviewed internally by Robin Cao.

  • Api/BackingStore.h:
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setIsAcceleratedCompositingActive):

  • Api/WebPageCompositor.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/WebPageCompositor.cpp.

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::hardwareCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
(BlackBerry::WebKit::WebPageCompositorPrivate::setBackingStoreUsesOpenGL):
(BlackBerry::WebKit::WebPageCompositorPrivate::commit):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationTimerFired):

  • Api/WebPageCompositor_p.h: Renamed from Source/WebKit/blackberry/WebKitSupport/WebPageCompositor.h.

(BlackBerry::WebKit::WebPageCompositorPrivate::layoutRectForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setLayoutRectForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::contentsSizeForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setContentsSizeForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::lastCompositingResults):
(BlackBerry::WebKit::WebPageCompositorPrivate::setLastCompositingResults):

  • Api/WebPage_p.h:
  • CMakeListsBlackBerry.txt:
5:31 PM Changeset in webkit [111098] by tsepez@chromium.org
  • 9 edits in trunk

Make V8 window.open.call(), window.open.showModalDialog() results more closely match JSC.
​https://bugs.webkit.org/show_bug.cgi?id=81260
​https://bugs.webkit.org/show_bug.cgi?id=39897

Reviewed by Adam Barth.

Source/WebCore:

Tested via http/tests/security/cross-frame-access-call.htm

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):

LayoutTests:

  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
5:29 PM Changeset in webkit [111097] by Stephanie Lewis
  • 11 edits in trunk

Source/WebKit2: ​https://bugs.webkit.org/show_bug.cgi?id=81065
<rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
Add some string function exports to Windows so the WebKitTestRunner can use them.

Reviewed by Geoff Garen.

  • win/WebKit2.def:

Tools: ​https://bugs.webkit.org/show_bug.cgi?id=81065
<rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
Fix crash preventing WebKitTestRunner from working in Release.
WebKitTestRunner used ostringstream to collect output from the test. ostringstream is incompatible with our
FastMalloc overrides. When copying strings out ostringstream a new string is allocated with FastMalloc because
the allocation is inlined. When that string is freed is uses the system malloc because that call is not inlined.

I removed ostringstream in favor of StringBuilder.

Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.

Reviewed by Geoff Garen.

Add DEBUG_DEFINES to set NDEBUG on release builds.

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Remove ostringstream member in favor of StringBuilder.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize):
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTF):
(WTR::InjectedBundle::stringBuilder):
(InjectedBundle):

Append output to StringBuilder.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::hasPrefix):
(WTR::dumpPath):
(WTR::rangeToStr):
(WTR::styleDecToStr):
(WTR::frameToStr):
(WTR::dumpFrameScrollPosition):
(WTR::dumpFrameText):
(WTR::dumpDescendantFramesText):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):
(WTR::lastFileURLPathComponent):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
(WTR::InjectedBundlePage::supportsFullScreen):
(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):
(WTR::dumpBackForwardListItem):
(WTR::InjectedBundlePage::dumpBackForwardList):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
(WTR::LayoutTestController::dumpConfigurationForViewport):

Convert between WTF::String and WKStringRef.

  • WebKitTestRunner/StringFunctions.h:

(WTR::toWTFString):
(WTR):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

5:27 PM Changeset in webkit [111096] by mlilek@apple.com
  • 2 edits in trunk/Source/WebCore

Use modern NSNumberFormatter API in LocalizedNumberMac.mm
​https://bugs.webkit.org/show_bug.cgi?id=81429

Reviewed by Dan Bernstein.

No new tests as no change in behavior.

  • platform/text/mac/LocalizedNumberMac.mm:

(WebCore::createFormatterForCurrentLocaleForDisplay):

5:19 PM Changeset in webkit [111095] by eric@webkit.org
  • 5 edits in trunk/Tools

Add a land-from-url command
​https://bugs.webkit.org/show_bug.cgi?id=81411

Reviewed by Adam Barth.

Very basic so far. The goal is to make it landing smarter
so that users don't have to bother to parse out the ids out of the urls.

  • Scripts/webkitpy/common/config/urls.py:

(parse_bug_id):
(parse_attachment_id):

  • Scripts/webkitpy/common/config/urls_unittest.py:

(URLsTest.test_parse_bug_id):
(URLsTest):
(URLsTest.test_parse_attachment_id):

  • Scripts/webkitpy/tool/commands/download.py:

(ProcessURLsMixin):
(ProcessURLsMixin._fetch_list_of_patches_to_process):
(LandFromURL):

  • Scripts/webkitpy/tool/commands/download_unittest.py:

(test_land_from_bug):
(test_land_from_url):

5:16 PM Changeset in webkit [111094] by tony@chromium.org
  • 8 edits in trunk

flex-item-align: stretch should only grow, never shrink
​https://bugs.webkit.org/show_bug.cgi?id=80882

Reviewed by Ojan Vafai.

Source/WebCore:

New test cases in css3/flexbox/flex-align-stretch.html.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren): Move stretch code into a separate function.
(WebCore::RenderFlexibleBox::alignChildStretch): Add an early return if our height is shrinking.
(WebCore):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/child-overflow-expected.html:
  • css3/flexbox/child-overflow.html: For cases that overflow the height, we now just overflow rather than reducing the height.
  • css3/flexbox/flex-align-stretch-expected.txt:
  • css3/flexbox/flex-align-stretch.html: New test cases.
5:13 PM Changeset in webkit [111093] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

build-webkit launcher instructions use wrong relative path for Qt
​https://bugs.webkit.org/show_bug.cgi?id=81357

Patch by Dave Tharp <​dtharp@codeaurora.org> on 2012-03-16
Reviewed by Eric Seidel.

Ensure we are at the proper directory before generating run-launcher
instructions.

  • Scripts/build-webkit:
5:10 PM Changeset in webkit [111092] by Lucas Forschler
  • 5 edits in branches/safari-534.56-branch/Source

Versioning.

5:10 PM Changeset in webkit [111091] by kubo@profusion.mobi
  • 2 edits in trunk/Source/WebCore

[EFL] Unreviewed, fix build after r111041.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::emitMediaButtonSignal): Rename
MediaFullscreenButton to MediaEnterFullscreenButton.
(WebCore::RenderThemeEfl::paintMediaFullscreenButton): Ditto.

4:49 PM Changeset in webkit [111090] by dcheng@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add layout tests that accidentally got left out of r111061

  • fast/events/clipboard-dataTransferItemList-expected.txt: Added.
  • fast/events/clipboard-dataTransferItemList.html: Added.
  • fast/events/drag-dataTransferItemList-expected.txt: Added.
  • fast/events/drag-dataTransferItemList.html: Added.
4:49 PM Changeset in webkit [111089] by dslomov@google.com
  • 4 edits in trunk/Source/WebCore

REGRESSION: DOMURL::revokeObjectURL accesses memoryCache on worker thread.
​https://bugs.webkit.org/show_bug.cgi?id=80889
On worker threads, post a task to main thread to evict from cache.
ASSERT that MemoryCache is only accessed from main thread.

Reviewed by David Levin.

  • html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL):

  • loader/cache/MemoryCache.cpp:

(WebCore::memoryCache):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationFailed):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::evict):
(WebCore):
(WebCore::MemoryCache::removeUrlFromCache):
(WebCore::MemoryCache::removeUrlFromCacheImpl):

  • loader/cache/MemoryCache.h:

(WebCore):
(MemoryCache):

4:47 PM Changeset in webkit [111088] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore

[BlackBerry] Upstream ScriptControllerBlackBerry.cpp
​https://bugs.webkit.org/show_bug.cgi?id=81397

Patch by Jacky Jiang <​zhajiang@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • bindings/js/ScriptControllerBlackBerry.cpp: Added.
4:46 PM Changeset in webkit [111087] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Syncing up left over bits in WebKitSupport from our local branch to upstream
​https://bugs.webkit.org/show_bug.cgi?id=81118

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This is a consolidation of various changes that are in our local dev branch
but do not appear in our upstreamed port.

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::isElementClickable):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spannableTextInRange):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::createBuffers):
(BlackBerry::WebKit::SurfacePool::releaseBuffers):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):

  • WebKitSupport/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):

  • WebKitSupport/WebPageCompositor.h:

(WebPageCompositor):

4:41 PM Changeset in webkit [111086] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

remove-body-during-body-replacement2.html is triggering crashes on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=81374

Reviewed by Eric Seidel.

When overriding disconnectFrame, we need to call the base class version
of the method so that it can clear the m_frame pointer.

Tests: This patch fixes a large number of crashes in tests.

  • notifications/DOMWindowNotifications.cpp:

(WebCore::DOMWindowNotifications::disconnectFrame):

4:27 PM Changeset in webkit [111085] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream the BlackBerry change to platform/Widget.h
​https://bugs.webkit.org/show_bug.cgi?id=81304

Reviewed by Rob Buis.

typedefs of PlatformWidget and PlatformPageClient for the BlackBerry.

  • platform/Widget.h:
4:22 PM Changeset in webkit [111084] by Lucas Forschler
  • 2 edits in branches/safari-534.56-branch/Source/JavaScriptCore

Merged r111081.

4:12 PM Changeset in webkit [111083] by commit-queue@webkit.org
  • 16 edits in trunk

MathML internals - factor code for almost anonymous blocks
​https://bugs.webkit.org/show_bug.cgi?id=81387

Patch by David Barton <Dave Barton> on 2012-03-16
Reviewed by Eric Seidel.

Source/WebCore:

MathML uses "almost anonymous" blocks to layout parts of mathematical expressions. These
will be converted to true anonymous blocks in a later patch. Here we factor out the code
to create them into RenderMathMLBlock::createAlmostAnonymousBlock().

No new tests. Some tree dump output is modified for existing tests. <munder>, <mover>,
and <munderover> renderers already used true anonymous blocks, so we change them to call
RenderBlock::createAnonymousBlock(). In the other direction, <mroot>'s almost anonymous
blocks are now made RenderMathMLBlock not just RenderBlock, in agreement with other
current MathML renderers.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::createAlmostAnonymousBlock):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):
(WebCore::RenderMathMLBlock::getBoxModelObjectWidth):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::addChild):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateFromElement):

  • improve some variable names

(WebCore::RenderMathMLFraction::addChild):
(WebCore::RenderMathMLFraction::layout):
(WebCore::RenderMathMLFraction::paint):
(WebCore::RenderMathMLFraction::baselinePosition):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::addChild):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::addChild):

  • rendering/mathml/RenderMathMLSubSup.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::addChild):

LayoutTests:

  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.txt:
4:05 PM Changeset in webkit [111082] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

Prepare RenderObject for FractionalLayoutUnits
​https://bugs.webkit.org/show_bug.cgi?id=81178

Reviewed by Eric Seidel.

This readies RenderObject to deal with FractionalLayoutUnits as a backend for the
LayoutUnit abstraction.

No new tests. No change in behavior.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::pixelSnappedAbsoluteClippedOverflowRect): Convenience method to be
used instead of absouluteClippedOverflowRect in platform code. Platform updates will come
in a separate patch.
(WebCore):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded): Borders remain ints when we move to
sub-pixel layout. This adjusts border variables for this, and adds compiler fixes when
using std::max and std::min with mixed int/LayoutUnits.
(WebCore::RenderObject::adjustRectForOutlineAndShadow): Outlines, like borders, remain
ints in the new sub-pixel world. Using variables that reflect that.

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::adjustForAbsoluteZoom): Handles FractionalLayoutUnit values. Flooring is what
JavaScript requires since this is used with values that must return ints.
(WebCore): Adding FractionalLayoutUnit.h to support the new adjusteForAbsoluteZoom method.

4:04 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
3:52 PM Changeset in webkit [111081] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Remove a bogus assert that was merged in from ToT. It is not needed on this branch.

Reviewed by Filip Pizlo.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addValueProfile):

3:29 PM Changeset in webkit [111080] by beidson@apple.com
  • 18 edits
    1 add in trunk

<rdar://problem/11027997> and ​https://bugs.webkit.org/show_bug.cgi?id=81412 REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted

Reviewed by Geoff Garen.

Source/WebCore:

WebKit API test WebViewCanPasteURL.mm added.

  • WebCore.exp.in:

Add a strategy method specifically for getting the URL:

  • platform/PasteboardStrategy.h:

Use that strategy method when creating the fragment for a URL:

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::documentFragment):

Add a platform pasteboard accessor to "do the right thing" for getting a URL:

  • platform/PlatformPasteboard.h:
  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::url):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::setInsertionPasteboard):

  • WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::url):

Source/WebKit2:

Add new message so the WebProcess can ask the UIProcesses pasteboard for the URL:

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::getPasteboardURL):

Use that new message to implement the pasteboard strategy:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::url):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
3:26 PM Changeset in webkit [111079] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/81380> clang warning unused variable when ENABLE(TEXT_CARET) is disabled

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-03-16
Reviewed by Dan Bernstein.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::recomputeCaretRect):
Put the variable inside of a guard because it is only
used inside of a guard.

3:23 PM Changeset in webkit [111078] by ojan@chromium.org
  • 9 edits
    1 add
    2 deletes in trunk/LayoutTests

Fix some tests that broke with r111042.

  • platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-linux/compositing/absolute-position-changed-with-composited-parent-layer-expected.png: Added.
  • platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
  • platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt:
3:19 PM Changeset in webkit [111077] by ojan@chromium.org
  • 3 edits in trunk/Tools

Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=81407

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.summarized_results):
(ResultSummaryTest.test_no_svn_revision):
(ResultSummaryTest.test_svn_revision):
(ResultSummaryTest):
(ResultSummaryTest.test_summarized_results_wontfix):

3:03 PM Changeset in webkit [111076] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

Shrink BorderValue.
<​http://webkit.org/b/69521>

Reviewed by Anders Carlsson.

Split BorderValue's Color member into RGBA32/bool buddies and stash the bool in
the BorderValue bitfield.

This shrinks BorderValue by 4 bytes, in turn shrinking BorderData by 16 bytes.
Altogether this yields ~800 kB in reduced memory consumption when viewing the full
HTML5 spec at <​http://whatwg.org/c>

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(BorderValue):
(WebCore::BorderValue::setColor):
(WebCore::BorderValue::color):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::operator==):

  • rendering/style/RenderStyle.cpp:

(SameSizeAsBorderValue):

  • rendering/style/RenderStyle.h:
3:00 PM Changeset in webkit [111075] by commit-queue@webkit.org
  • 10 edits
    64 moves in trunk/Source/WebCore

Moves remaining filesystem files to Modules/filesystem/
​https://bugs.webkit.org/show_bug.cgi?id=81353

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/filesystem/AsyncFileWriter.h: Copied from Source/WebCore/fileapi/AsyncFileWriter.h.
  • Modules/filesystem/AsyncFileWriterClient.h: Copied from Source/WebCore/fileapi/AsyncFileWriterClient.h.
  • Modules/filesystem/DOMFilePath.cpp: Copied from Source/WebCore/fileapi/DOMFilePath.cpp.
  • Modules/filesystem/DOMFilePath.h: Copied from Source/WebCore/fileapi/DOMFilePath.h.
  • Modules/filesystem/DOMFileSystem.cpp: Copied from Source/WebCore/fileapi/DOMFileSystem.cpp.
  • Modules/filesystem/DOMFileSystem.h: Copied from Source/WebCore/fileapi/DOMFileSystem.h.
  • Modules/filesystem/DOMFileSystem.idl: Copied from Source/WebCore/fileapi/DOMFileSystem.idl.
  • Modules/filesystem/DOMFileSystemBase.cpp: Copied from Source/WebCore/fileapi/DOMFileSystemBase.cpp.
  • Modules/filesystem/DOMFileSystemBase.h: Copied from Source/WebCore/fileapi/DOMFileSystemBase.h.
  • Modules/filesystem/DOMFileSystemSync.cpp: Copied from Source/WebCore/fileapi/DOMFileSystemSync.cpp.
  • Modules/filesystem/DOMFileSystemSync.h: Copied from Source/WebCore/fileapi/DOMFileSystemSync.h.
  • Modules/filesystem/DOMFileSystemSync.idl: Copied from Source/WebCore/fileapi/DOMFileSystemSync.idl.
  • Modules/filesystem/Entry.cpp: Copied from Source/WebCore/fileapi/Entry.cpp.
  • Modules/filesystem/Entry.h: Copied from Source/WebCore/fileapi/Entry.h.
  • Modules/filesystem/Entry.idl: Copied from Source/WebCore/fileapi/Entry.idl.
  • Modules/filesystem/EntryArray.cpp: Copied from Source/WebCore/fileapi/EntryArray.cpp.
  • Modules/filesystem/EntryArray.h: Copied from Source/WebCore/fileapi/EntryArray.h.
  • Modules/filesystem/EntryArray.idl: Copied from Source/WebCore/fileapi/EntryArray.idl.
  • Modules/filesystem/EntryArraySync.cpp: Copied from Source/WebCore/fileapi/EntryArraySync.cpp.
  • Modules/filesystem/EntryArraySync.h: Copied from Source/WebCore/fileapi/EntryArraySync.h.
  • Modules/filesystem/EntryArraySync.idl: Copied from Source/WebCore/fileapi/EntryArraySync.idl.
  • Modules/filesystem/EntryBase.cpp: Copied from Source/WebCore/fileapi/EntryBase.cpp.
  • Modules/filesystem/EntryBase.h: Copied from Source/WebCore/fileapi/EntryBase.h.
  • Modules/filesystem/EntryCallback.h: Copied from Source/WebCore/fileapi/EntryCallback.h.
  • Modules/filesystem/EntryCallback.idl: Copied from Source/WebCore/fileapi/EntryCallback.idl.
  • Modules/filesystem/EntrySync.cpp: Copied from Source/WebCore/fileapi/EntrySync.cpp.
  • Modules/filesystem/EntrySync.h: Copied from Source/WebCore/fileapi/EntrySync.h.
  • Modules/filesystem/EntrySync.idl: Copied from Source/WebCore/fileapi/EntrySync.idl.
  • Modules/filesystem/ErrorCallback.h: Copied from Source/WebCore/fileapi/ErrorCallback.h.
  • Modules/filesystem/ErrorCallback.idl: Copied from Source/WebCore/fileapi/ErrorCallback.idl.
  • Modules/filesystem/FileCallback.h: Copied from Source/WebCore/fileapi/FileCallback.h.
  • Modules/filesystem/FileCallback.idl: Copied from Source/WebCore/fileapi/FileCallback.idl.
  • Modules/filesystem/FileEntry.cpp: Copied from Source/WebCore/fileapi/FileEntry.cpp.
  • Modules/filesystem/FileEntry.h: Copied from Source/WebCore/fileapi/FileEntry.h.
  • Modules/filesystem/FileEntry.idl: Copied from Source/WebCore/fileapi/FileEntry.idl.
  • Modules/filesystem/FileEntrySync.cpp: Copied from Source/WebCore/fileapi/FileEntrySync.cpp.
  • Modules/filesystem/FileEntrySync.h: Copied from Source/WebCore/fileapi/FileEntrySync.h.
  • Modules/filesystem/FileEntrySync.idl: Copied from Source/WebCore/fileapi/FileEntrySync.idl.
  • Modules/filesystem/FileSystemCallback.h: Copied from Source/WebCore/fileapi/FileSystemCallback.h.
  • Modules/filesystem/FileSystemCallback.idl: Copied from Source/WebCore/fileapi/FileSystemCallback.idl.
  • Modules/filesystem/FileSystemCallbacks.cpp: Copied from Source/WebCore/fileapi/FileSystemCallbacks.cpp.
  • Modules/filesystem/FileSystemCallbacks.h: Copied from Source/WebCore/fileapi/FileSystemCallbacks.h.
  • Modules/filesystem/FileWriter.cpp: Copied from Source/WebCore/fileapi/FileWriter.cpp.
  • Modules/filesystem/FileWriter.h: Copied from Source/WebCore/fileapi/FileWriter.h.
  • Modules/filesystem/FileWriter.idl: Copied from Source/WebCore/fileapi/FileWriter.idl.
  • Modules/filesystem/FileWriterBase.cpp: Copied from Source/WebCore/fileapi/FileWriterBase.cpp.
  • Modules/filesystem/FileWriterBase.h: Copied from Source/WebCore/fileapi/FileWriterBase.h.
  • Modules/filesystem/FileWriterBaseCallback.h: Copied from Source/WebCore/fileapi/FileWriterBaseCallback.h.
  • Modules/filesystem/FileWriterCallback.h: Copied from Source/WebCore/fileapi/FileWriterCallback.h.
  • Modules/filesystem/FileWriterCallback.idl: Copied from Source/WebCore/fileapi/FileWriterCallback.idl.
  • Modules/filesystem/FileWriterSync.cpp: Copied from Source/WebCore/fileapi/FileWriterSync.cpp.
  • Modules/filesystem/FileWriterSync.h: Copied from Source/WebCore/fileapi/FileWriterSync.h.
  • Modules/filesystem/FileWriterSync.idl: Copied from Source/WebCore/fileapi/FileWriterSync.idl.
  • Modules/filesystem/LocalFileSystem.cpp: Copied from Source/WebCore/fileapi/LocalFileSystem.cpp.
  • Modules/filesystem/LocalFileSystem.h: Copied from Source/WebCore/fileapi/LocalFileSystem.h.
  • Modules/filesystem/Metadata.h: Copied from Source/WebCore/fileapi/Metadata.h.
  • Modules/filesystem/Metadata.idl: Copied from Source/WebCore/fileapi/Metadata.idl.
  • Modules/filesystem/MetadataCallback.h: Copied from Source/WebCore/fileapi/MetadataCallback.h.
  • Modules/filesystem/MetadataCallback.idl: Copied from Source/WebCore/fileapi/MetadataCallback.idl.
  • Modules/filesystem/SyncCallbackHelper.h: Copied from Source/WebCore/fileapi/SyncCallbackHelper.h.
  • Modules/filesystem/WebKitFlags.h: Copied from Source/WebCore/fileapi/WebKitFlags.h.
  • Modules/filesystem/WorkerContextFileSystem.cpp: Copied from Source/WebCore/fileapi/WorkerContextFileSystem.cpp.
  • Modules/filesystem/WorkerContextFileSystem.h: Copied from Source/WebCore/fileapi/WorkerContextFileSystem.h.
  • Modules/filesystem/WorkerContextFileSystem.idl: Copied from Source/WebCore/fileapi/WorkerContextFileSystem.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/AsyncFileWriter.h: Removed.
  • fileapi/AsyncFileWriterClient.h: Removed.
  • fileapi/DOMFilePath.cpp: Removed.
  • fileapi/DOMFilePath.h: Removed.
  • fileapi/DOMFileSystem.cpp: Removed.
  • fileapi/DOMFileSystem.h: Removed.
  • fileapi/DOMFileSystem.idl: Removed.
  • fileapi/DOMFileSystemBase.cpp: Removed.
  • fileapi/DOMFileSystemBase.h: Removed.
  • fileapi/DOMFileSystemSync.cpp: Removed.
  • fileapi/DOMFileSystemSync.h: Removed.
  • fileapi/DOMFileSystemSync.idl: Removed.
  • fileapi/Entry.cpp: Removed.
  • fileapi/Entry.h: Removed.
  • fileapi/Entry.idl: Removed.
  • fileapi/EntryArray.cpp: Removed.
  • fileapi/EntryArray.h: Removed.
  • fileapi/EntryArray.idl: Removed.
  • fileapi/EntryArraySync.cpp: Removed.
  • fileapi/EntryArraySync.h: Removed.
  • fileapi/EntryArraySync.idl: Removed.
  • fileapi/EntryBase.cpp: Removed.
  • fileapi/EntryBase.h: Removed.
  • fileapi/EntryCallback.h: Removed.
  • fileapi/EntryCallback.idl: Removed.
  • fileapi/EntrySync.cpp: Removed.
  • fileapi/EntrySync.h: Removed.
  • fileapi/EntrySync.idl: Removed.
  • fileapi/ErrorCallback.h: Removed.
  • fileapi/ErrorCallback.idl: Removed.
  • fileapi/FileCallback.h: Removed.
  • fileapi/FileCallback.idl: Removed.
  • fileapi/FileEntry.cpp: Removed.
  • fileapi/FileEntry.h: Removed.
  • fileapi/FileEntry.idl: Removed.
  • fileapi/FileEntrySync.cpp: Removed.
  • fileapi/FileEntrySync.h: Removed.
  • fileapi/FileEntrySync.idl: Removed.
  • fileapi/FileSystemCallback.h: Removed.
  • fileapi/FileSystemCallback.idl: Removed.
  • fileapi/FileSystemCallbacks.cpp: Removed.
  • fileapi/FileSystemCallbacks.h: Removed.
  • fileapi/FileWriter.cpp: Removed.
  • fileapi/FileWriter.h: Removed.
  • fileapi/FileWriter.idl: Removed.
  • fileapi/FileWriterBase.cpp: Removed.
  • fileapi/FileWriterBase.h: Removed.
  • fileapi/FileWriterBaseCallback.h: Removed.
  • fileapi/FileWriterCallback.h: Removed.
  • fileapi/FileWriterCallback.idl: Removed.
  • fileapi/FileWriterSync.cpp: Removed.
  • fileapi/FileWriterSync.h: Removed.
  • fileapi/FileWriterSync.idl: Removed.
  • fileapi/LocalFileSystem.cpp: Removed.
  • fileapi/LocalFileSystem.h: Removed.
  • fileapi/Metadata.h: Removed.
  • fileapi/Metadata.idl: Removed.
  • fileapi/MetadataCallback.h: Removed.
  • fileapi/MetadataCallback.idl: Removed.
  • fileapi/SyncCallbackHelper.h: Removed.
  • fileapi/WebKitFlags.h: Removed.
  • fileapi/WorkerContextFileSystem.cpp: Removed.
  • fileapi/WorkerContextFileSystem.h: Removed.
  • fileapi/WorkerContextFileSystem.idl: Removed.
2:54 PM Changeset in webkit [111074] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB) in OperationNotAllowedException.idl
​https://bugs.webkit.org/show_bug.cgi?id=81391

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • fileapi/OperationNotAllowedException.idl:
2:49 PM Changeset in webkit [111073] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

scrollbars/scrollbar-middleclick-nopaste.html times out on mac WK1
​https://bugs.webkit.org/show_bug.cgi?id=81410

Skip scrollbars/scrollbar-middleclick-nopaste.html on Mac.

  • platform/mac/Skipped:
2:47 PM Changeset in webkit [111072] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

plugins/netscape-plugin-setwindow-size-2.html and plugins/resize-from-plugin.html failing on Lion Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81405

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Added.
  • platform/mac-wk2/plugins/resize-from-plugin-expected.txt: Added.
2:47 PM Changeset in webkit [111071] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

plugins/npruntime/browser-object-identity.html failing on Lion Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81403

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/plugins/npruntime/browser-object-identity-expected.txt: Added.
2:47 PM Changeset in webkit [111070] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

plugins/refcount-leaks.html failing on Lion Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81400

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/plugins/refcount-leaks-expected.txt: Added.
2:47 PM Changeset in webkit [111069] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

plugins/crash-restoring-plugin-page-from-page-cache.html and
plugins/netscape-plugin-page-cache-works.html timing out on Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81392

Skip these tests for WK2.

  • platform/wk2/Skipped:
2:40 PM Changeset in webkit [111068] by Lucas Forschler
  • 2 edits in branches/safari-534.56-branch/Source/WebCore

Merged r107102.

2:37 PM Changeset in webkit [111067] by Lucas Forschler
  • 17 edits in branches/safari-534.56-branch/Source

Merge 106977.

2:30 PM Changeset in webkit [111066] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix rounding and usage of LayoutUnits in RenderBoxModelObject
​https://bugs.webkit.org/show_bug.cgi?id=81057

Reviewed by Julien Chaffraix.

No new tests.

(WebCore):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):
Fix implementation of pixelSnappedOffsetWidth/Height. The location
parameter will be ignored until we enable subpixel support.

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use ints for border widths.

(WebCore::resolveWidthForRatio):
(WebCore::resolveHeightForRatio):
(WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio):
(WebCore::resolveAgainstIntrinsicRatio):
Change resolve*Ratio methods to operate on IntSizes as none of the
callers need subpixel precision.

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
Pixel snap paintRect when computing image geometry.

2:19 PM Changeset in webkit [111065] by timothy_horton@apple.com
  • 1 edit
    22 adds in trunk/LayoutTests

Unreviewed new mac baselines after ​http://trac.webkit.org/changeset/108185

  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
2:15 PM Changeset in webkit [111064] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk

100% height elements to not respond to vertical browser rescaling
​https://bugs.webkit.org/show_bug.cgi?id=43022

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-03-16
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/replaced/vertical-resize-100percent-element.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

For the case where a replaced element has a percentage height,
we update the entries in RenderBlock::gPercentHeightDescendantsMap
corresponding to all ancestors of the replaced element.

LayoutTests:

  • fast/replaced/resources/vertical-resize-100percent-contents.html: Added.
  • fast/replaced/vertical-resize-100percent-element-expected.txt: Added.
  • fast/replaced/vertical-resize-100percent-element.html: Added.

Layout test to ensure that an image with 100% height is resized when
its containing iframe is vertically resized to be larger or smaller.

  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

Rebaseline for chromium. This patch causes a progression in this layout test. In the
diff, note that the viewport has height 585, which is 600 minus 15 pixels to account for
the horizontal scrollbar. In the old expected output the first image to be displayed
has height 600, which is incorrect because it should be 100% of the viewport height.
The new expected output shows the first image with the correct height of 585.

  • platform/chromium/test_expectations.txt:

WIN will need a regenerated image, and MAC will need a regenerated image+text.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

Skip the rebaselined test on all other platforms.

2:08 PM Changeset in webkit [111063] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking media/track/track-active-cues.html as flaky timeout on windows.

  • platform/chromium/test_expectations.txt:
1:53 PM Changeset in webkit [111062] by Lucas Forschler
  • 2 edits in branches/safari-534.56-branch/Source/WebKit2

Merged r103880.

1:53 PM Changeset in webkit [111061] by dcheng@chromium.org
  • 19 edits in trunk

[chromium] Refactor ClipboardChromium and DataTransferItemList/DataTransferItem to support HTML spec
​https://bugs.webkit.org/show_bug.cgi?id=76598

Reviewed by Tony Chang.

Source/WebCore:

We no longer store drag/clipboard data in named fields. We used to maintain the data store
list separately, which resulted in a lot of complicated code to try to make sure that
ChromiumDataObject and this list stayed in sync. We now just store what is essentially a
list MIME type/data pairs directly in ChromiumDataObject. This has the benefit of letting us
easily add write support during dragstart/copy operations using DataTransferItemList.

Tests: fast/events/clipboard-dataTransferItemList.html

fast/events/drag-dataTransferItemList.html

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::findItem):
(WebCore::ChromiumDataObject::createFromPasteboard):
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::copy):
(WebCore::ChromiumDataObject::items):
(WebCore::ChromiumDataObject::clearData):
(WebCore::ChromiumDataObject::clearAll):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::setData):
(WebCore::ChromiumDataObject::urlAndTitle):
(WebCore::ChromiumDataObject::setURLAndTitle):
(WebCore::ChromiumDataObject::htmlAndBaseURL):
(WebCore::ChromiumDataObject::setHTMLAndBaseURL):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore):
(WebCore::ChromiumDataObject::filenames):
(WebCore::ChromiumDataObject::addFilename):
(WebCore::ChromiumDataObject::addSharedBuffer):
(WebCore::ChromiumDataObject::ChromiumDataObject):

  • platform/chromium/ChromiumDataObject.h:

(WebCore):
(ChromiumDataObject):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::normalizeType):
(WebCore::ClipboardChromium::ClipboardChromium):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::clearAllData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::files):
(WebCore::writeImageToDataObject):
(WebCore::ClipboardChromium::declareAndWriteDragImage):
(WebCore::ClipboardChromium::writeURL):
(WebCore::ClipboardChromium::writeRange):
(WebCore::ClipboardChromium::writePlainText):
(WebCore::ClipboardChromium::hasData):
(WebCore::ClipboardChromium::items):

  • platform/chromium/ClipboardChromium.h:

(WebCore):
(ClipboardChromium):
(WebCore::ClipboardChromium::frame):

  • platform/chromium/ClipboardUtilitiesChromium.cpp:

(WebCore::convertURIListToURL):
(WebCore):

  • platform/chromium/ClipboardUtilitiesChromium.h:

(WebCore):

  • platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::createFromString):
(WebCore::DataTransferItemChromium::createFromFile):
(WebCore::DataTransferItemChromium::createFromURL):
(WebCore::DataTransferItemChromium::createFromHTML):
(WebCore):
(WebCore::DataTransferItemChromium::createFromSharedBuffer):
(WebCore::DataTransferItemChromium::createFromPasteboard):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
(WebCore::DataTransferItemChromium::internalGetAsString):
(WebCore::DataTransferItemChromium::isFilename):

  • platform/chromium/DataTransferItemChromium.h:

(WebCore):
(DataTransferItemChromium):
(WebCore::DataTransferItemChromium::kind):
(WebCore::DataTransferItemChromium::type):
(WebCore::DataTransferItemChromium::sharedBuffer):
(WebCore::DataTransferItemChromium::title):
(WebCore::DataTransferItemChromium::baseURL):

  • platform/chromium/DataTransferItemListChromium.cpp:

(WebCore::DataTransferItemListChromium::create):
(WebCore::DataTransferItemListChromium::createFromPasteboard):
(WebCore):
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
(WebCore::DataTransferItemListChromium::length):
(WebCore::DataTransferItemListChromium::item):
(WebCore::DataTransferItemListChromium::deleteItem):
(WebCore::DataTransferItemListChromium::clear):
(WebCore::DataTransferItemListChromium::add):
(WebCore::DataTransferItemListChromium::internalAddStringItem):
(WebCore::DataTransferItemListChromium::internalAddFileItem):

  • platform/chromium/DataTransferItemListChromium.h:

(WebCore):
(DataTransferItemListChromium):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asFragment):

Source/WebKit/chromium:

  • src/WebDragData.cpp:

(WebKit::WebDragData::items):
(WebKit::WebDragData::addItem):
(WebKit::WebDragData::assign):

LayoutTests:

  • fast/events/clipboard-dataTransferItemList-expected.txt: Added.
  • fast/events/clipboard-dataTransferItemList.html: Added.
  • fast/events/drag-dataTransferItemList-expected.txt: Added.
  • fast/events/drag-dataTransferItemList.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
1:49 PM Changeset in webkit [111060] by Lucas Forschler
  • 2 edits in branches/safari-534.56-branch/Source/WebKit2

Merged r103843.

1:49 PM Changeset in webkit [111059] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

ASSERTION FAILED: m_loadState == LoadStateCommitted in WebFrameProxy::didFinishLoad causing
"crashes" on Lion Intel Debug WebKit2 Tests
​https://bugs.webkit.org/show_bug.cgi?id=81184
<rdar://problem/11052462>

Rubber-stamped by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::finishedLoading): Don't leave a lingering m_pluginView after load is finished. When plug-in data was empty, we would create the plug-in here, but failed to finalize the load.
1:48 PM Changeset in webkit [111058] by mlilek@apple.com
  • 2 edits in trunk/Source/WebCore

Don't install libWebCoreTestSupport on OS X production builds
​https://bugs.webkit.org/show_bug.cgi?id=81087

Reviewed by Mark Rowe.

  • Configurations/WebCoreTestSupport.xcconfig:
1:41 PM Changeset in webkit [111057] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

Skip move-by-word-visually-wrong-left-right.html added in r110965 in wk2 since SetEditingBehavior is not supported.

  • platform/wk2/Skipped:
1:32 PM Changeset in webkit [111056] by eae@chromium.org
  • 989 edits
    159 copies
    18 deletes in branches/subpixellayout

Merge trunk changes up until r111035 into subpixel branch.

1:27 PM Changeset in webkit [111055] by arv@chromium.org
  • 3 edits in trunk/LayoutTests

Fix layout test to output the same result for V8 and JSC
​https://bugs.webkit.org/show_bug.cgi?id=81395

Reviewed by Nate Chapin.

  • fast/dom/inline-event-attributes-crash-expected.txt:
  • fast/dom/inline-event-attributes-crash.html:
1:25 PM Changeset in webkit [111054] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/rendering/RenderingAllInOne.cpp

Add RenderMultiColumnBlock.cpp to RenderingAllInOne.cpp for Windows build.

1:16 PM Changeset in webkit [111053] by tony@chromium.org
  • 5 edits in trunk

incorrectly removing scrollbar height for auto height flexbox children
​https://bugs.webkit.org/show_bug.cgi?id=81388

Reviewed by Ojan Vafai.

Source/WebCore:

In a column flexbox, when computing the preferred height of an auto
height child, we were subtracting out the horizontal scrollbar height.

New test case in css3/flexbox/columns-auto-size.html.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):

LayoutTests:

  • css3/flexbox/columns-auto-size-expected.txt:
  • css3/flexbox/columns-auto-size.html:
1:15 PM Changeset in webkit [111052] by Lucas Forschler
  • 1 move in branches/safari-534.56-branch

Branch name update.

1:08 PM Changeset in webkit [111051] by adamk@chromium.org
  • 9 edits
    2 adds in trunk

Out-of-document radio buttons should be grouped when associated with a form
​https://bugs.webkit.org/show_bug.cgi?id=81268

Reviewed by Kent Tamura.

Source/WebCore:

Per the HTML spec, and the behavior of Firefox and IE 8/9, radio buttons
with a form owner should be grouped, even if that form is not in the document.

r104668 added many inDocument() tests to radio button grouping code.
While those are necessary to avoid unattached <input type=radio>
elements being grouped together, it also kept them from being grouped
when associated with a form outside the document.

This patch changes the HTMLInputElement::checkedRadioButtons() method
to return either a pointer to the proper CheckedRadioButtons instance
(either the document's or a form's), but will return null if the
element should not be associated with any radio button group.

The main fallout of this was that the callers of checkedRadioButtons()
now have to check for null, resulting in the creation of a few helper
methods in HTMLInputElement to wrap the null checks.

This refactoring has the pleasant side-effect of exposing a cleaner API between
HTMLInputElement and RadioInputType, and making a clearer contract
between HTMLInputElement and CheckedRadioButtons (e.g., all
CheckedRadioButtons methods that take an element can now assume that
it is a radio button, where previously some checked for that and
others asserted it).

Test: fast/forms/radio/radio-group-in-detached-form.html

  • dom/CheckedRadioButtons.cpp:

(WebCore): Removed shouldMakeRadioGroup() helper function.
(WebCore::CheckedRadioButtons::addButton): Replace call to shouldMakeRadioGroup
with appropriate assert and name check.
(WebCore::CheckedRadioButtons::updateCheckedState): ditto.
(WebCore::CheckedRadioButtons::requiredAttributeChanged): ditto.
(WebCore::CheckedRadioButtons::isRequiredGroup): Renamed from isInRequiredGroup,
changed to take only a group name, not an element.
(WebCore::CheckedRadioButtons::removeButton): Replace call to shouldMakeRadioGroup.
with appropriate assert and name check.

  • dom/CheckedRadioButtons.h:

(CheckedRadioButtons):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::~HTMLInputElement): Added isRadioButton check
now that it's asserted in CheckedRadioButtons.
(WebCore::HTMLInputElement::updateType): Call helper method instead of
calling directly into CheckedRadioButtons.
(WebCore::HTMLInputElement::parseAttribute): ditto.
(WebCore::HTMLInputElement::setChecked): ditto.
(WebCore::HTMLInputElement::willChangeForm): ditto.
(WebCore::HTMLInputElement::didChangeForm): ditto.
(WebCore::HTMLInputElement::insertedIntoDocument): ditto.
(WebCore::HTMLInputElement::removedFromDocument): ditto.
(WebCore::HTMLInputElement::didMoveToNewDocument): Added isRadioButton check.
(WebCore::HTMLInputElement::requiredAttributeChanged): Check for membership in a group
before calling into CheckedRadioButtons.
(WebCore::HTMLInputElement::isInRequiredRadioButtonGroup): Added helper method for use by RadioInputType.
(WebCore):
(WebCore::HTMLInputElement::checkedRadioButtonForGroup): ditto.
(WebCore::HTMLInputElement::checkedRadioButtons): Changed to return a
pointer, only return non-null if actually a member of a group.
(WebCore::HTMLInputElement::addToRadioButtonGroup): Helper method for
use in HTMLInputElement.
(WebCore::HTMLInputElement::removeFromRadioButtonGroup): ditto.

  • html/HTMLInputElement.h:

(HTMLInputElement): Added/removed methods, removed outdated comment about visibility.

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::valueMissing): Call new HTMLInputElement methods instead
of interacting directly with CheckedRadioButtons.
(WebCore::RadioInputType::isKeyboardFocusable): ditto.
(WebCore::RadioInputType::willDispatchClick): ditto.

LayoutTests:

  • fast/forms/radio/radio-group-expected.txt:
  • fast/forms/radio/radio-group-in-detached-form-expected.txt: Added.
  • fast/forms/radio/radio-group-in-detached-form.html: Added.
  • fast/forms/radio/radio-group.html: Updated to match new behavior.
1:00 PM Changeset in webkit [111050] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Syncing up left over bits in WebCoreSupport from our local branch to upstream
​https://bugs.webkit.org/show_bug.cgi?id=81120

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This is a consolidation of various changes that are in our local dev branch
but do not appear in our upstreamed port.

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/AboutDataHaveFeatures.in:
  • WebCoreSupport/AboutDataUseFeatures.in:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::hasOpenedPopup):
(WebCore):
(WebCore::ChromeClientBlackBerry::screenToRootView):
(WebCore::ChromeClientBlackBerry::rootViewToScreen):
(WebCore::ChromeClientBlackBerry::invalidateRootView):
(WebCore::ChromeClientBlackBerry::invalidateContentsAndRootView):
(WebCore::ChromeClientBlackBerry::invalidateContentsForSlowScroll):
(WebCore::ChromeClientBlackBerry::scrollableAreasDidChange):
(WebCore::ChromeClientBlackBerry::createColorChooser):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):
(WebCore::ChromeClientBlackBerry::numTouchEventHandlersChanged):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::registerUndoStep):
(WebCore::EditorClientBlackBerry::registerRedoStep):
(WebCore::EditorClientBlackBerry::undo):
(WebCore::EditorClientBlackBerry::redo):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

  • WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::requestPermission):
(GeolocationControllerClientBlackBerry::cancelPermissionRequest):

  • WebCoreSupport/GeolocationControllerClientBlackBerry.h:
  • WebCoreSupport/InspectorClientBlackBerry.cpp:

(WebCore::InspectorClientBlackBerry::closeInspectorFrontend):
(WebCore):
(WebCore::InspectorClientBlackBerry::bringFrontendToFront):

  • WebCoreSupport/InspectorClientBlackBerry.h:

(InspectorClientBlackBerry):

  • WebCoreSupport/NotificationPresenterImpl.cpp:

(WebCore::NotificationPresenterImpl::show):

12:57 PM Changeset in webkit [111049] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/Target.pri

Missed adding new files to Targets.pri

12:55 PM Changeset in webkit [111048] by hyatt@apple.com
  • 14 edits
    2 adds in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=81366

Add RenderMultiColumnBlock subclass of RenderBlock. This new class will hold all of the multi-column
logic (as well as painting/hit testing). That way the column code can be kept out of the base class
and be more cleanly factored.

Patch Node::diff so that we detach and re-attach the renderer if column counts or widths change
from auto to non-auto (and vice versa) to ensure the right renderer gets made.

Patch RenderObject::createObject to make a RenderMultiColumnBlock if either the column count or
column width is non-auto.

Patch RenderBlock::calcColumnWidth to "turn off" the old implementation of columns if the pref to use
the new column implementation is set. This single chokepoint should be sufficient for disabling the old
columns in favor of the new.

Reviewed by Dan Bernstein.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::regionBasedColumnsEnabled):
(WebCore):
(WebCore::Document::recalcStyle):

  • dom/Document.h:

(Document):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • dom/Node.cpp:

(WebCore::Node::diff):

  • dom/Node.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::updateFirstLetterStyle):

  • rendering/RenderMultiColumnBlock.cpp: Added.

(WebCore):
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::renderName):

  • rendering/RenderMultiColumnBlock.h: Added.

(WebCore):
(RenderMultiColumnBlock):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

12:45 PM Changeset in webkit [111047] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Improve CSS3 filter blur performance.
​https://bugs.webkit.org/show_bug.cgi?id=81360

This change improves blur performance by 2-2.5X on blurred CSS
3D transforms and accelerated canvas demos by skipping an unnecessary
texture allocation and bitmap draw.

Reviewed by James Robinson.

Covered by existing layout tests in css3/filters.

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):
Call SkCanvas::drawSprite() directly instead of using
saveLayer()/restore().

12:43 PM Changeset in webkit [111046] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline GTK expected results after r111041.

  • platform/gtk/accessibility/media-element-expected.txt:
12:41 PM Changeset in webkit [111045] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

plugins/keyboard-events.html, mouse-events-fixedpos.html, and mouse-events.html failing on Lion
Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81386

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/plugins/keyboard-events-expected.txt: Added.
  • platform/mac-wk2/plugins/mouse-events-expected.txt: Added.
  • platform/mac-wk2/plugins/mouse-events-fixedpos-expected.txt: Added.
12:26 PM Changeset in webkit [111044] by jsbell@chromium.org
  • 9 edits
    2 adds in trunk

[Chromium] IndexedDB: Assertion failure when storing File objects
​https://bugs.webkit.org/show_bug.cgi?id=76746

Source/WebCore:

The blob data in Blob/File/FileList objects is serialized "by reference" (the
internal URL) rather than "by value" (the actual data); this is sufficient for
postMessage() but not for IndexedDB since the referenced data is not retained
Expose a mechanism to enumerate the URLs so that SSVs can be rejected by IDB
until blob data serialization can is implemented (outside the SSV mechanism, and
potentially asynchronously).

Also, correct issue in V8DOMWrapper::instantiateV8Object where context is assumed
to be a Worker context if it's not a Window, which is incorrect for the
Chromium utility process; this is hit if Blobs are not blocked.

Reviewed by Tony Chang.

Test: storage/indexeddb/noblobs.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update): Reject SSVs that contain blob references.

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::add): Reject SSVs that contain blob references.
(WebCore::IDBObjectStore::put): Reject SSVs that contain blob references.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):
(CloneSerializer):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):

  • bindings/js/SerializedScriptValue.h: New API to enable the clients to be picky.
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::SerializedScriptValue):

  • bindings/v8/SerializedScriptValue.h: New API to enable the clients to be picky.

(WebCore::SerializedScriptValue::blobURLs):
(SerializedScriptValue):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object): Ensure context is a worker context before treating it as such.

LayoutTests:

Ensure that Blob/File/FileList types are rejected in IDB values, to detect regressions.

Reviewed by Tony Chang.

  • storage/indexeddb/noblobs-expected.txt: Added.
  • storage/indexeddb/noblobs.html: Added.
12:23 PM Changeset in webkit [111043] by arv@chromium.org
  • 3 edits
    2 adds in trunk

[V8] Ensure that invalid syntax in inline event handlers does not cause a crash
​https://bugs.webkit.org/show_bug.cgi?id=81385

Reviewed by Nate Chapin.

Source/WebCore:

The way that V8 does its inline event handler involves concatting strings and
if the attribute value is crafted in a special way this could cause a crash.

Test: fast/dom/inline-event-attributes-crash.html

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

  • fast/dom/inline-event-attributes-crash-expected.txt: Added.
  • fast/dom/inline-event-attributes-crash.html: Added.
12:22 PM Changeset in webkit [111042] by ojan@chromium.org
  • 11 edits
    1 copy
    18 adds
    1 delete in trunk/LayoutTests

Chromium rebaselines for expected failures on garden-o-matic.

  • platform/chromium-linux-x86/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-linux/compositing/color-matching/pdf-image-match-expected.png: Added.
  • platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/cross-fade-border-image-source-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.txt: Added.
  • platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-win-vista/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Removed.
  • platform/chromium-win-xp/compositing/reflections/animation-inside-reflection-expected.txt: Added.
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Copied from LayoutTests/platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt.
  • platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png:
  • platform/chromium-win/compositing/color-matching/pdf-image-match-expected.png: Added.
  • platform/chromium-win/compositing/color-matching/pdf-image-match-expected.txt: Added.
  • platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt:
  • platform/chromium/test_expectations.txt:
12:21 PM Changeset in webkit [111041] by jer.noble@apple.com
  • 28 edits in trunk

Wrong icon to restore to windowed mode in full screen video panel
​https://bugs.webkit.org/show_bug.cgi?id=70437

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Updated platform/mac/accessibility/media-element-expected.txt.

Renamed MediaFullscreenButton to MediaEnterFullscreenButton and added MediaExitFullscreenButton:

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::controlTypeName):
(WebCore::AccessibilityMediaControl::roleValue):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • platform/ThemeTypes.h:

Added setIsFullscreen which controls the display of the enter/exit fullscreen button:

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::setIsFullscreen): Added.

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::exitedFullscreen):

Paint the enter/exit fullscreen button accordingly:

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::paintMediaFullscreenButton):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaFullscreenButton):

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::paintMediaControlsPart):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMediaFullscreenButton):

Update the localized strings for the exit and enter fullscreen buttons:

  • English.lproj/Localizable.strings:
  • platform/LocalizedStrings.cpp:

(WebCore::localizedMediaControlElementString):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

  • platform/qt/LocalizedStringsQt.cpp:

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

WebKitLibraries:

  • WebKitSystemInterface.h: Added WKMediaUIPartExitFullscreenButton.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:

LayoutTests:

  • platform/mac/accessibility/media-element-expected.txt:
12:07 PM Changeset in webkit [111040] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Update LayoutUnit usage in RenderListBox
​https://bugs.webkit.org/show_bug.cgi?id=81038

Reviewed by Julien Chaffraix.

Bringing RenderListBox in line with the rules listed in
​https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintScrollbar): Pixel snapping before handing off scrollbar
painting to the platform.
(WebCore::RenderListBox::paintItemForeground): Rounding the offset for text painting.
(WebCore::RenderListBox::paintItemBackground): Pixel snapping the background rect.
(WebCore::RenderListBox::panScroll): EventHandler::currentMousePosition is an IntPoint,
so it doesn't require additional rounding in RenderListBox.

12:02 PM Changeset in webkit [111039] by ojan@chromium.org
  • 5 edits in trunk/Tools

Have webkit-patch rebaseline-test update test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=81054

Recommit ​http://trac.webkit.org/changeset/110783 now that
​http://trac.webkit.org/changeset/111034 has landed.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.remove_configuration_from_test):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(RemoveConfigurationsTest):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._update_expectations_file):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest):
(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):

11:57 AM Changeset in webkit [111038] by jer.noble@apple.com
  • 3 edits in trunk/LayoutTests

Rebaseline window-properties-expected on GTK; add two new tests
to the GTK Skipped list associated with existing bug:
​https://bugs.webkit.org/show_bug.cgi?id=61118

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
11:39 AM Changeset in webkit [111037] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Input fields with id of e-mail and url should be styled as such.
​https://bugs.webkit.org/show_bug.cgi?id=81364

Patch by Mike Fenton <​mifenton@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Treat fields that have name/id's that match url or
email as url or email fields providing the appropriate
keyboard.

PR 137259.

Reviewed Internally by Gen Mak and Nima Ghanavatian.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::matchesReservedStringEmail):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesEmail):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesUrl):
(BlackBerry::WebKit::DOMSupport::matchesReservedStringPreventingAutocomplete):

  • WebKitSupport/DOMSupport.h:

(WebCore):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertInputType):
(BlackBerry::WebKit::inputStyle):

11:33 AM Changeset in webkit [111036] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Mark form-associated-element-crash3.html as flakily timing out, since it often passes.

  • platform/chromium/test_expectations.txt:
11:33 AM Changeset in webkit [111035] by pkasting@chromium.org
  • 3 edits
    3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r111020.
​http://trac.webkit.org/changeset/111020
​https://bugs.webkit.org/show_bug.cgi?id=81377

Broke Chromium Win compile (Requested by pkasting on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-16

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • platform/mediastream/PeerConnection00Handler.cpp: Removed.
  • platform/mediastream/PeerConnection00Handler.h: Removed.
  • platform/mediastream/PeerConnection00HandlerClient.h: Removed.
11:31 AM Changeset in webkit [111034] by ojan@chromium.org
  • 6 edits in trunk/Tools

Specifier collapsing when writing test expectations lines gets a number of cases wrong
​https://bugs.webkit.org/show_bug.cgi?id=81309

Reviewed by Dimitri Glazkov.

I've run this over all the lines in the current Chromium test_expectations.txt file,
so I'm relatively confident we now cover all the cases.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.init):
(TestConfigurationConverter.collapse_macros):
(TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
(TestConfigurationConverter):
(TestConfigurationConverter.intersect_combination):
(TestConfigurationConverter.symmetric_difference):
(TestConfigurationConverter.to_specifiers_list):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:

(make_mock_all_test_configurations_set):
(TestConfigurationConverterTest.test_symmetric_difference):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_converter_macro_collapsing):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
The android port uses "arm" as it's architecture, which is technically correct,
but considerably complicates making collapsing work. We probably should kill
the concept of architecture entirely. The benefits are not worth the code
complexity.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):

11:27 AM Changeset in webkit [111033] by jberlin@webkit.org
  • 1 edit
    16 adds in trunk/LayoutTests

6 platform/mac/editing/spelling autocorrect-related tests failing on Lion Intel Debug WebKit2
testers
​https://bugs.webkit.org/show_bug.cgi?id=81375

Add expected failing results to get the bots green.

  • platform/mac-wk2/platform/mac/editing/spelling/autocorrection-contraction-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/autocorrection-contraction-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.
11:27 AM Changeset in webkit [111032] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

platform/mac/editing/spelling/editing-word-with-marker-1.html failing on Lion Intel Debug
testers
​https://bugs.webkit.org/show_bug.cgi?id=81372

Add expected failing results to get the bots green.

  • platform/mac/editing/spelling/editing-word-with-marker-1-expected.txt:
11:27 AM Changeset in webkit [111031] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

platform/mac/editing/spelling/autocorrection-contraction.html fails on Lion Intel Debug testers.
​https://bugs.webkit.org/show_bug.cgi?id=81369

Add expected failing results to get the bots green.

  • platform/mac/editing/spelling/autocorrection-contraction-expected.png:
  • platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
11:23 AM Changeset in webkit [111030] by dmazzoni@google.com
  • 3 edits
    2 adds in trunk

File input control accessibility can cause a crash
​https://bugs.webkit.org/show_bug.cgi?id=80896

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/input-file-causes-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

LayoutTests:

  • accessibility/input-file-causes-crash-expected.txt: Added.
  • accessibility/input-file-causes-crash.html: Added.
11:21 AM Changeset in webkit [111029] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] compositing tests with videos fail in chromium DumpRenderTree, seeking doesn't appear to work
​https://bugs.webkit.org/show_bug.cgi?id=76511

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-03-16
Reviewed by Eric Carlson.

  • compositing/resources/media-testing.js:

(ensureFrameVisible.playingHandler):
(ensureFrameVisible.seekedHandler):
(ensureFrameVisible):

11:12 AM Changeset in webkit [111028] by jer.noble@apple.com
  • 18 edits
    6 adds in trunk

Support W3C Full Screen API proposal
​https://bugs.webkit.org/show_bug.cgi?id=80660

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: fullscreen/full-screen-element-stack.html

fullscreen/full-screen-enabled.html
fullscreen/full-screen-restrictions.html

The W3C proposal for taking arbitrary elements into full-screen mode is significantly
different than the Mozilla proposal. For example, the W3C has proposed a lower-case "s"
in "Fullscreen", which means the W3C and Mozilla "requestFullscreen" APIs differ only by
in that lower-case "s". Annoying as this is, it does allow us to retain the semantics for
the Mozilla case (har!).

A significant difficulty is obeying the new W3C spec rules is that we would like to apply the
fullscreen CSS rules while exiting fullscreen mode, though the W3C spec insists that the
webkitFullscreenElement returns the new value immediately. As such, we retain the m_fullScreenElement
variable (distinct from the top of the m_fullScreenElements stack) which is controlled by the
webkit{Will,Did}{Enter,Exit}FullScreen functions.

New APIs for the W3C Fullscreen spec:

  • dom/Document.h:

(WebCore::Document::webkitFullscreenElement):
(WebCore::Document::webkitFullscreenEnabled):

  • dom/Document.idl:
  • dom/Element.cpp:

(WebCore::Element::webkitRequestFullscreen):

  • dom/Element.h:
  • dom/Element.idl:
  • dom/Document.cpp:

(WebCore::Document::removedLastRef): Clear m_fullScreenElementStack.
(WebCore::Document::requestFullScreenForElement): Implement the W3C requirements.
(WebCore::Document::webkitExitFullscreen): Ditto.
(WebCore::Document::webkitCancelFullScreen): Implement in terms of webkitCancelFullscreen.
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired): Protect against items being

added to the event and error queue by swapping out empty queues before starting.

(WebCore::Document::clearFullscreenElementStack): Simple accessor.
(WebCore::Document::popFullscreenElementStack): Ditto.
(WebCore::Document::pushFullscreenElementStack): Ditto.

  • dom/Element.cpp:

(WebCore::Element::webkitRequestFullScreen):

Add new RuntimeEnabledFeatures functions for the added Document and Element functions.

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenEnabledEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitExitFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullscreenEnabled):

Source/WebKit/mac:

Allow full screen elements to access the keyboard.

  • WebView/WebView.mm:

(-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):

Source/WebKit2:

Allow full screen elements to access the keyboard.

  • UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::supportsFullScreen):

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::exitFullScreenForElement):

LayoutTests:

  • fullscreen/full-screen-element-stack-expected.txt: Added.
  • fullscreen/full-screen-element-stack.html: Added.
  • fullscreen/full-screen-enabled-expected.txt: Added.
  • fullscreen/full-screen-enabled.html: Added.
  • fullscreen/full-screen-request-rejected.html:
  • fullscreen/full-screen-request-removed.html:
  • fullscreen/full-screen-restrictions-expected.txt: Added.
  • fullscreen/full-screen-restrictions.html: Added.
  • fullscreen/full-screen-test.js:
11:00 AM Changeset in webkit [111027] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] WebKitWebResource::load-failed uses the wrong marshaller
​https://bugs.webkit.org/show_bug.cgi?id=81229

Patch by Victor Lucero <​victor.lucero@ipartner.cl> on 2012-03-16
Reviewed by Philippe Normand.

  • webkit/webkitwebresource.cpp:

(webkit_web_resource_class_init): load-failed signal in WebkitWebResource was using the wrong marshaller

10:58 AM Changeset in webkit [111026] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

Make HTMLInputElement::isRadioButton non-virtual and remove unused HTMLFormControlElement::isRadioButton method
​https://bugs.webkit.org/show_bug.cgi?id=81255

Reviewed by Kent Tamura.

No new tests, no change in behavior.

  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.h:

(HTMLInputElement):

10:43 AM Changeset in webkit [111025] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Update NetworkJob to accept batched headers
​https://bugs.webkit.org/show_bug.cgi?id=81273

Batch up the headers into a vector before they come into
webkit to increase performance, and simplify the API.

Patch by Tay Grigg <​tgrigg@rim.com> on 2012-03-16
Reviewed by George Staikos.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyHeadersReceived):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

10:17 AM Changeset in webkit [111024] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
​https://bugs.webkit.org/show_bug.cgi?id=81105

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This patches fixes up a previous sync done in this directory and adds some new bits
as well. This is accurate as of ddea1528b37b29925638fe1183318b3c3994f1f8 in our
local repo.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::webContext):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

10:14 AM Changeset in webkit [111023] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Add overdraw metrics for texture uploads
​https://bugs.webkit.org/show_bug.cgi?id=81175

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Record texture upload metrics during paint. To properly record
the amount of pixels culled, we must compute the amount of pixels we
would have uploaded for a tile. This requires knowing the dirty rect of
the tile, but the dirty rect can be changed by WebKit during a paint, so
we always store the dirtyRect in the tile's updateRect. We add an
m_updateCulled bool to the UpdatableTile structure, to identify tiles
that were not updated, and know a tile was updated if updateRect is not
empty and updateCulled is false.

Tested by all TiledLayerChromiumTests that use occlusion tracker.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

10:07 AM Changeset in webkit [111022] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

Allow AudioContext::create() to emit an ExceptionCode.
​https://bugs.webkit.org/show_bug.cgi?id=81049

Reviewed by Kentaro Hara.

No new tests; no change in functionality.

Pass through an ExceptionCode parameter to AudioContext::create(). It is currently
never modified, but exceptions will be added in the future.

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • webaudio/AudioContext.h:
9:59 AM Changeset in webkit [111021] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Remove surface damage client from occlusion tracker
​https://bugs.webkit.org/show_bug.cgi?id=81242

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Code was not used yet, so no new tests. Removing tests instead!

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):
(WebCore::::layerScissorRectInTargetSurface):
(WebCore):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(WebCore):
(CCOcclusionTrackerBase):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):

9:56 AM Changeset in webkit [111020] by tommyw@google.com
  • 3 edits
    3 adds in trunk/Source/WebCore

MediaStream API (JSEP): Introducing PeerConnection00Handler
​https://bugs.webkit.org/show_bug.cgi?id=81333

Reviewed by Adam Barth.

In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.

Not possible to test until the entire JSEP feature is commited.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • platform/mediastream/PeerConnection00Handler.cpp: Added.

(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):

  • platform/mediastream/PeerConnection00Handler.h: Added.

(WebCore):
(PeerConnection00Handler):

  • platform/mediastream/PeerConnection00HandlerClient.h: Added.

(WebCore):
(PeerConnection00HandlerClient):
(WebCore::PeerConnection00HandlerClient::~PeerConnection00HandlerClient):

9:56 AM Changeset in webkit [111019] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Input processing mode should be cancelled when processing hot keys
​https://bugs.webkit.org/show_bug.cgi?id=81348

Patch by Mike Fenton <​mifenton@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Don't suppress IMF notifications if we are handling
the event as a hotkey.

Reviewed Internally by Nima Ghanavatian.

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::handleKeyboardEvent):

9:49 AM Changeset in webkit [111018] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix exception when hovering over bound function in heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=81362

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):

9:49 AM Changeset in webkit [111017] by sfalken@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/testRegExp/testRegExpReleasePGO.vsprops

Windows build fix.

9:49 AM Changeset in webkit [111016] by xji@chromium.org
  • 3 edits in trunk/LayoutTests

Skip visual word movement tests in gtk and qt after r110965 since isWordTextBreak is not implemented.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
9:43 AM Changeset in webkit [111015] by abecsi@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Fix bounce-back behaviour for panning
​https://bugs.webkit.org/show_bug.cgi?id=81144

Reviewed by Kenneth Rohde Christiansen.

If the pan gesture recognizer receives a touch begin event
during an ongoing kinetic scroll animation of a previous
pan gesture, the animation is stopped and the content is
immediately positioned back to valid boundaries.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
(WebKit):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

9:40 AM Changeset in webkit [111014] by Martin Robinson
  • 2 edits in trunk/Source/WebKit/gtk

WebKit/gtk/resources/error.html font-size error
​https://bugs.webkit.org/show_bug.cgi?id=39232

Patch by Landry Breuil <​landry@openbsd.org> on 2012-03-14
Reviewed by Martin Robinson.

Fix font-size in the 404 error page. Apparently the % is filtered out,
so 120% becomes 120 and the error message is huge. Experienced in epiphany.

  • resources/error.html: Double the % so it doesn't get filtered
9:26 AM Changeset in webkit [111013] by msaboff@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Improve diagnostic benefit of JSGlobalData::m_isInitializingObject
​https://bugs.webkit.org/show_bug.cgi?id=81244

Rubber stamped by Filip Pizlo.

Changed type and name of JSGlobalData::m_isInitializingObject to
ClassInfo* and m_initializingObjectClass.
Changed JSGlobalData::setInitializingObject to
JSGlobalData::setInitializingObjectClass. This pointer can be used within
the debugger to determine what type of object is being initialized.

  • runtime/JSCell.h:

(JSC::JSCell::finishCreation):
(JSC::allocateCell):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):
(JSC::JSGlobalData::isInitializingObject):
(JSC::JSGlobalData::setInitializingObjectClass):

  • runtime/Structure.h:

(JSC::JSCell::finishCreation):

9:16 AM Changeset in webkit [111012] by commit-queue@webkit.org
  • 10 edits
    6 adds in trunk

[Qt][Wk2] Assertion Failure and crash on file upload
​https://bugs.webkit.org/show_bug.cgi?id=80854

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-03-16
Reviewed by Simon Hausmann.

Source/WebKit2:

Crash resulted from attempting to create QFileDialog, a QtWidget based dialog from a
QGuiApplication. Replace QFileDialog with a QML implementable component.
Added a new property 'filePicker' to WebView experimental to set the QML component for
file upload triggered by an input file element.

Co-authored with Kasthuri Nallappasoundararajan <​kasthuri.n-s@nokia.com>

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::chooseFiles):
(QQuickWebViewExperimental::filePicker):
(QQuickWebViewExperimental::setFilePicker):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_singleFileUpload.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/singlefileupload.html: Added.
  • UIProcess/qt/QtDialogRunner.cpp:

(FilePickerContextObject):
(FilePickerContextObject::FilePickerContextObject):
(FilePickerContextObject::fileList):
(FilePickerContextObject::reject):
(FilePickerContextObject::accept):
(QtDialogRunner::initForFilePicker):

  • UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner):
(QtDialogRunner::filePaths):
(QtDialogRunner::onFileSelected):

Tools:

Added filePicker to WebView using experimental API.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/icons/folder.png: Added.
  • MiniBrowser/qt/icons/titlebar.png: Added.
  • MiniBrowser/qt/icons/up.png: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/FilePicker.qml: Added.
9:04 AM Changeset in webkit [111011] by mahesh.kulkarni@nokia.com
  • 2 edits in trunk/Tools

Updating email for committer.py script.

  • Scripts/webkitpy/common/config/committers.py:
8:51 AM Changeset in webkit [111010] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[Qt][WK2] Build failure when using --no-touch-events
​https://bugs.webkit.org/show_bug.cgi?id=81241

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-03-16
Reviewed by Simon Hausmann.

Fixed inconsistency in the use of ENABLE_TOUCH_EVENTS flag that caused build
failure when using --no-touch-events option

  • UIProcess/qt/QtPageClient.h:

(QtPageClient):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handlePotentialSingleTapEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
8:01 AM Changeset in webkit [111009] by commit-queue@webkit.org
  • 13 edits in trunk

[Forms] The "progress" element should not be a form-associated element.
​https://bugs.webkit.org/show_bug.cgi?id=80240

Patch by Yoshifumi Inoue <​yosin@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes base class of HTMLProgressElement to LabelableElement from
HTMLFormControlElement for saving memory space and iteration time of
extra "progress" elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.

Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
​https://bugs.webkit.org/show_bug.cgi?id=80381

No new tests. Update existing tests to cover this change.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement): Moved the "progress" element support code from canShareStyleWithControl.
(WebCore::CSSStyleSelector::canShareStyleWithControl):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Remove isFormControlElement check for PseudoIndeterminate.

  • editing/TextIterator.cpp:

(WebCore::TextIterator::advance): Check HTMLProgressElement in addition to isFormControlElement. This change is for text dump in LayoutTests implemented by document.innerText attribute.

  • html/HTMLProgressElement.cpp: Remove unused include file.

(WebCore::HTMLProgressElement::HTMLProgressElement): Changed base class to LabelableElement.
(WebCore::HTMLProgressElement::create): Remove form paraprogress.
(WebCore::HTMLProgressElement::parseAttribute): Replace HTMLFormControlElement to LabelableElement.
(WebCore::HTMLProgressElement::attach): Replace HTMLFormControlElement to LabelableElement.

  • html/HTMLProgressElement.h:

(HTMLProgressElement):

  • html/HTMLProgressElement.idl: Remove the "form" attribute which isn't listed in the HTML5 specification.
  • html/HTMLTagNames.in: Remove "constructorNeedsFormElement" for not passing "form" parameter in HTMLElementFactory.

LayoutTests:

This patch changes tests for non-existent "form" attribute of the
"progress" element. The "form" attribute is available only for
form-associate elements. However, the "progress" element isn't.

  • fast/dom/HTMLProgressElement/progress-element-form-expected.txt: Update expectation for test output changes.
  • fast/dom/HTMLProgressElement/progress-element-form.html: Changed for the "progress" element doesn't have IDL attribute "form".
  • fast/forms/form-attribute-expected.txt: Update expectation for test output changes.
  • fast/forms/form-attribute.html: Removed lines for the "progress" element.
7:54 AM Changeset in webkit [111008] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Heap Snapshot: Unreviewed single line fix for isWindow getter.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isWindow):

7:53 AM Changeset in webkit [111007] by tommyw@google.com
  • 4 edits in trunk/Source/WebCore

MediaStream API (JSEP): Fixing a few nits
​https://bugs.webkit.org/show_bug.cgi?id=81322

Reviewed by Adam Barth.

Addressing the nits from bugs 81206 and 81207.

Nothing to test.

  • Modules/mediastream/SessionDescription.idl:
  • platform/mediastream/IceOptions.h:

(WebCore::IceOptions::IceOptions):

  • platform/mediastream/SessionDescriptionDescriptor.h:

(SessionDescriptionDescriptor):

7:48 AM Changeset in webkit [111006] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[chromium] DRT: Add support for sending gesture scrolls without a begin
​https://bugs.webkit.org/show_bug.cgi?id=81292

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureScrollFirstPoint):

  • DumpRenderTree/chromium/EventSender.h:

(EventSender):

7:44 AM Companies and Organizations that have contributed to WebKit edited by lfelipe@profusion.mobi
Adding ProFUSION to the list of companies that have contributed to WebKit (diff)
7:43 AM Changeset in webkit [111005] by yurys@chromium.org
  • 12 edits in trunk/Source/WebCore

Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
​https://bugs.webkit.org/show_bug.cgi?id=80789

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-03-16
Reviewed by Yury Semikhatsky.

OptOutput class is added for optional return parameters.

Strict mode added to Generator that makes all parameter types strict
and drop pre-set default values for return parameters.

Debugger and Page domain is switched to strict mode.

  • inspector/CodeGeneratorInspector.py:

(CommandReturnPassModel.OptOutput):
(CommandReturnPassModel.OptOutput.init):
(CommandReturnPassModel.OptOutput.get_return_var_type):
(CommandReturnPassModel.OptOutput.get_output_argument_prefix):
(CommandReturnPassModel.OptOutput.get_output_to_raw_expression):
(CommandReturnPassModel.OptOutput.get_output_parameter_type):
(CommandReturnPassModel):
(CommandReturnPassModel.OptOutput.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(OptOutput):
(Generator.process_event):
(Generator.process_command):

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:

(ContentSearchUtils):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

7:01 AM Changeset in webkit [111004] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

The IDL parser should support sequence<T> type
​https://bugs.webkit.org/show_bug.cgi?id=81345

Reviewed by Adam Barth.

This patch makes the IDL parser support sequence<T> type.
This patch just makes sequence<T> parseable, and the generated code
for sequence<T> is wrong. This issue will be soon fixed in bug 80696.
This is a preparing patch for bug 80696.

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/test/TestObj.idl: Added tests for sequence<T>.
  • bindings/scripts/IDLStructure.pm: Updated the regular expressions to support sequence<T>.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.

(WebDOMTestObj::sequenceAttr):
(WebDOMTestObj::setSequenceAttr):
(WebDOMTestObj::methodWithSequenceArg):
(WebDOMTestObj::methodReturningSequence):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_with_sequence_arg):
(webkit_dom_test_obj_method_returning_sequence):
(webkit_dom_test_obj_get_sequence_attr):
(webkit_dom_test_obj_set_sequence_attr):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjSequenceAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj sequenceAttr]):
(-[DOMTestObj setSequenceAttr:]):
(-[DOMTestObj methodWithSequenceArg:]):
(-[DOMTestObj methodReturningSequence:]):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::sequenceAttrAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::sequenceAttrAttrSetter):
(WebCore::TestObjInternal::methodWithSequenceArgCallback):
(WebCore::TestObjInternal::methodReturningSequenceCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

6:50 AM Changeset in webkit [111003] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: HeapSnapshot: merge two long operations into one.
​https://bugs.webkit.org/show_bug.cgi?id=81347

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.aggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates.forDominatedNodes):

6:45 AM Changeset in webkit [111002] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] QtWebKit documentation missing a few since 4.6 information
​https://bugs.webkit.org/show_bug.cgi?id=81328

Patch by Teemu Katajisto <​teemu.katajisto@digia.com> on 2012-03-16
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:
  • Api/qwebsettings.cpp:
6:42 AM Changeset in webkit [111001] by kenneth@webkit.org
  • 13 edits in trunk/Source/WebKit2

Merge setVisibleContentsForScaling with setVisibleContentsRectForPanning
​https://bugs.webkit.org/show_bug.cgi?id=81346

Reviewed by Simon Hausmann.

This cleans up the code path and is one step on the way to avoid
calling both methods in succession, for instance after ending pinch
zoom.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_commitScaleChange):
(QQuickWebViewPrivate::_q_commitPositionChange):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::setVisibleContentsRect):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):

  • UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::setVisibleContentsRect):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::setVisibleContentsRect):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentsRect):

  • WebProcess/WebPage/LayerTreeHost.messages.in:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::setVisibleContentsRect):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

6:35 AM Changeset in webkit [111000] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Can not open certain links from bridge applications
​https://bugs.webkit.org/show_bug.cgi?id=81197

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2012-03-16
Reviewed by Rob Buis.

Currently, the engine asks the client to handle some type of requests externally.
But WebPageClient::handleStringPattern is not yet implemented and exposed to
the client. Before that, we still need to give the client a chance to decide
how to handle requests such as 'mailto:'.

To address this problem, r108763 introduced a change that ask the client to
decide how to handle the navigation in dispatchDecidePolicyForNewWindowAction().
This is not intuitive and will bring troubles, because this navigation will
happen in the new page. So the new page client is to decide how to handle
the navigation, not the old one.

This patch reverts r108763 and skips calling WebPageClient::handleStringPattern
since it's not implemented.

This way the new window action will continue, and the logic in
dispatchDecidePolicyForNavigationAction() will handle the navigation correctly.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

6:34 AM Changeset in webkit [110999] by sergio@webkit.org
  • 17 edits
    4 adds in trunk

[GTK] WebKitIconDatabase doesn't keep icons cached
​https://bugs.webkit.org/show_bug.cgi?id=56200

Reviewed by Martin Robinson.

Source/WebKit/gtk:

  • GNUmakefile.am: Added new files to compilation.
  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::registerForIconNotification): instruct
the WebView to listen to IconDatabase's notifications.
(WebKit::FrameLoaderClient::dispatchDidReceiveIcon): ask both
WebView and IconDatabase to issue notifications for a new icon.

  • docs/webkitgtk-docs.sgml: updated docs.
  • docs/webkitgtk-sections.txt: ditto.
  • docs/webkitgtk.types: ditto.
  • tests/testicondatabase.c: Added.

(server_callback):
(deleteDatabaseFileIfExists):
(testWebkitIconDatabaseSetPath):
(iconDatabaseGetIconValidCallback):
(iconDatabaseGetIconInvalidCallback):
(iconDatabaseGetIconCancelledCallback):
(mainLoopQuitIfLoadCompleted):
(idleQuitLoopCallback):
(webkitWebViewIconLoaded):
(loadURI):
(faviconDatabaseGetFaviconValidIdle):
(faviconDatabaseGetFaviconInvalidIdle):
(faviconDatabaseGetFaviconCancelledIdle):
(testWebKitFaviconDatabaseGetFavicon):
(testWebKitFaviconDatabaseGetFaviconURI):
(testWebKitFaviconDatabaseRemoveAll):
(testWebKitFaviconDatabaseCloseDatabase):
(main):

  • webkit/webkit.h: added new API.
  • webkit/webkitdefines.h: added WebKitFaviconDatabase.
  • webkit/webkitfavicondatabase.cpp:

(IconDatabaseClientGtk): IconDatabaseClient implementation.
(IconDatabaseClientGtk::performImport):
(IconDatabaseClientGtk::didRemoveAllIcons):
(IconDatabaseClientGtk::didImportIconURLForPageURL):
(IconDatabaseClientGtk::didImportIconDataForPageURL):
(IconDatabaseClientGtk::didChangeIconForPageURL):
(IconDatabaseClientGtk::didFinishURLImport):
(PendingIconRequest): machinery for asynchronous calls.
(PendingIconRequest::PendingIconRequest):
(PendingIconRequest::~PendingIconRequest):
(PendingIconRequest::pageURI):
(PendingIconRequest::asyncResult):
(PendingIconRequest::asyncResultCancel):
(PendingIconRequest::asyncResultCompleteInIdle):
(PendingIconRequest::asyncResultComplete):
(_WebKitIconDatabasePrivate):
(webkit_favicon_database_dispose): GObject stuff.
(webkit_favicon_database_set_property): ditto.
(webkit_favicon_database_get_property): ditto.
(webkit_favicon_database_class_init): ditto.
(webkit_favicon_database_init): ditto.
(webkitFaviconDatabaseNotifyAndUpdateExpiration): notify about new
icons and update expiration times.
(webkitFaviconDatabaseDispatchDidReceiveIcon): "protected" method
called by the FrameLoaderClient to inform about new icons.
(webkit_favicon_database_get_path): retrieves database path.
(selectQueryCallback): releases expired icons to let IconDatabase
prune them.
(webkitFaviconDatabasePruneExpiredIcons): selects the icons to be
pruned by the IconDatabase.
(webkitFaviconDatabaseClose): close the database.
(createExpirationTimesDatabaseTableIfNotExists): creates the
database used to control expiration times.
(webkit_favicon_database_set_path): opens the database delaying the
cleanup of icons until the import is complete.
(webkit_favicon_database_get_favicon_uri): returns the uri of the
favicon.
(getIconPixbufSynchronously): helper function to call
IconDatabase::synchronousIconURLForPageURL().
(webkit_favicon_database_try_get_favicon_pixbuf): returns the
favicon if exists and is loaded from disk.
(webkitFaviconDatabaseGetOrCreateRequests): helper function to get
the vector of pending requests for the given uri.
(webkitfavicondatabaseDeleteRequests): helper function to remove the
vector of pending requests for the given uri.
(getIconPixbufCancelled):
(webkitFaviconDatabaseGetIconPixbufCancelled):
(webkit_favicon_database_get_favicon_pixbuf): asynchronously
retrieve icons from the database.
(webkit_favicon_database_get_favicon_pixbuf_finish): finishes an
operation started with webkit_icon_database_get_icon_pixbuf().
(webkitFaviconDatabaseProcessPendingIconsForURI): process pending
requests once the import is finished.
(webkitFaviconDatabaseImportFinished): check pending requests and
delete those that ask for icons that do not exist in the database.
(webkit_favicon_database_clear): clears the database.

  • webkit/webkitfavicondatabase.h: added.

(_WebKitFaviconDatabase):
(_WebKitFaviconDatabaseClass):

  • webkit/webkitfavicondatabaseprivate.h: Added.
  • webkit/webkitglobals.cpp:

(webkit_get_favicon_database): retrieves the new
WebKitFaviconDatabase.
(webkitExit): unref icon database on exit.

  • webkit/webkitglobals.h: added new API.
  • webkit/webkiticondatabase.cpp: added deprecation documentation.

(webkit_icon_database_class_init):

  • webkit/webkitwebview.cpp:

(webkit_web_view_try_get_icon_pixbuf): new API that uses the new
WebKitFaviconDatabase API.
(webkitWebViewIconLoaded): dispatch the icon-loaded signal when
requested by the FrameLoaderClient.
(webkitWebViewRegisterForIconNotification): starts/stops listening
to icon database notifications.

  • webkit/webkitwebview.h: added new API.
  • webkit/webkitwebviewprivate.h: added some protected methods.

Tools:

Add support for favicons in GtkLauncher.

  • GtkLauncher/main.c:

(activateUriEntryCb):
(iconLoadedCb):
(createBrowser):

6:25 AM Changeset in webkit [110998] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

Add asserts and improve logging in PageCache.
​https://bugs.webkit.org/show_bug.cgi?id=81179

Reviewed by Brady Eidson.

The early exits from logCanCacheFrameDecision had the potential to skew histogram data. Moving
the DocumentLoader check to the top, but eliminating the early exits is a compromise that keeps
the logged data mostly accurate.

  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):

6:13 AM Changeset in webkit [110997] by abarth@webkit.org
  • 7 edits in trunk/Tools

Remove sheriff-bot's last-green-revision command
​https://bugs.webkit.org/show_bug.cgi?id=81314

Reviewed by Eric Seidel.

This command is a cruel joke. WebKit doesn't really ever have a
last-green-revision.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot._find_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:

(MockBuildBot.builder_statuses):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_find_green_revision):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(IRCCommand.execute):

  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

(SheriffIRCBotTest.test_help):

  • Scripts/webkitpy/tool/commands/queries.py:

(PatchesToReview.execute):

6:05 AM Changeset in webkit [110996] by commit-queue@webkit.org
  • 10 edits in trunk

[Forms] label.form attribute doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=80499

Patch by Yoshifumi Inoue <​yosin@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes implementation of label.form of IDL attribute to
compute it to the form element specified by the "form" HTML attribute
or form ancestor when the "form" HTML attribute isn't in HTML.

This patch introduces new function FormAssociatedElement::findAssociatedForm
for sharing code among FormAssociateElement::insertedIntoTree, resetFormOwner
and HTMLLabelElement::form.

No new tests. Update existing tests.

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::findAssociatedForm): Added.
(WebCore):
(WebCore::FormAssociatedElement::insertedIntoTree):
(WebCore::FormAssociatedElement::resetFormOwner):

  • html/FormAssociatedElement.h:

(FormAssociatedElement):

  • html/HTMLLabelElement.cpp: Remove unused include files

(WebCore::HTMLLabelElement::form): Added.

LayoutTests:

This patch updates test cases and expectation for functional
"form" attribute of the "label" element.

  • fast/forms/form-attribute-expected.txt:
  • fast/forms/form-attribute-nonexistence-form-id-expected.txt:
  • fast/forms/form-attribute-nonexistence-form-id.html:
  • fast/forms/form-attribute.html:
6:00 AM Changeset in webkit [110995] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebCore

Use the normalize method of FloatPoint instead of normalizing manually
​https://bugs.webkit.org/show_bug.cgi?id=81343

Reviewed by Simon Hausmann.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::coverWithTilesIfNeeded):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):

5:54 AM UsingGitHub edited by jarred@sencha.com
(diff)
5:51 AM UsingGitHub edited by jarred@sencha.com
(diff)
5:50 AM Changeset in webkit [110994] by haraken@chromium.org
  • 13 edits
    3 adds in trunk/Source/WebCore

Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl
​https://bugs.webkit.org/show_bug.cgi?id=79636

Reviewed by Adam Barth.

For WebKit modularization, this patch moves Notifications-related APIs
from DOMWindow.idl to DOMWindowNotifications.idl.

Tests: fast/notifications/* (No change in test results)

  • CMakeLists.txt: Added DOMWindowNotifications.{h,cpp,idl}.
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.exp.in: Added mangled signatures of webkitNotifications().
  • notifications/DOMWindowNotifications.cpp: Added.

(WebCore):
(WebCore::DOMWindowNotifications::DOMWindowNotifications):
(WebCore::DOMWindowNotifications::~DOMWindowNotifications):
(WebCore::DOMWindowNotifications::from):
(WebCore::DOMWindowNotifications::webkitNotifications):
(WebCore::DOMWindowNotifications::ensureWebkitNotifications):
(WebCore::DOMWindowNotifications::disconnectFrame):

  • notifications/DOMWindowNotifications.h: Added.

(WebCore):
(DOMWindowNotifications):

  • notifications/DOMWindowNotifications.idl: Added.
  • page/DOMWindow.cpp: Removed ENABLE(NOTIFICATIONS).

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::clear):

  • page/DOMWindow.h: Ditto.

(WebCore):
(DOMWindow):

  • page/DOMWindow.idl: Ditto.
  • page/Frame.cpp: Ditto.

(WebCore::Frame::willDetachPage):
(WebCore::Frame::transferChildFrameToNewDocument):

5:49 AM UsingGitHub edited by jarred@sencha.com
(diff)
5:46 AM Changeset in webkit [110993] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Make gccdepends test aware of broken icecream deps generation

Icecream seems to build the files without passing -o to gcc with
the original destination path, which means the target name in the
dependency file is wrong.

Also, echo something to the final file instead of just touching it,
so it's not deleted on every build.

Reviewed by Simon Hausmann.

5:31 AM Changeset in webkit [110992] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[Performance] Optimize innerHTML and outerHTML
​https://bugs.webkit.org/show_bug.cgi?id=81214

Reviewed by Adam Barth.

This patch makes innerHTML and outerHTML 2.4 times faster.

Performance test: ​https://bugs.webkit.org/attachment.cgi?id=132034
The performance test measures body.innerHTML for 3000 lines of HTML,
which is copied from the HTML spec.

  • Chromium/Mac without the patch

div.innerHTML: 1658.6 ms
div.outerHTML: 4859.6 ms
body.innerHTML: 640.2 ms
body.outerHTML: 641.8 ms

  • Chromium/Mac with the patch

div.innerHTML: 751.0 ms
div.outerHTML: 2096.0 ms
body.innerHTML: 271.2 ms
body.outerHTML: 271.2 ms

  • Chromium/Linux without the patch

div.innerHTML: 950.4 ms
div.outerHTML: 2257.8 ms
body.innerHTML: 452.8 ms
body.outerHTML: 457.6 ms

  • Chromium/Linux with the patch

div.innerHTML: 582.4 ms
div.outerHTML: 1283.0 ms
body.innerHTML: 233.0 ms
body.outerHTML: 233.4 ms

  • AppleWebKit/Mac without the patch

div.innerHTML: 900.6 ms
div.outerHTML: 2245.2 ms
body.innerHTML: 462.6 ms
body.outerHTML: 468.0 ms

  • AppleWebKit/Mac with the patch

div.innerHTML: 529.8 ms
div.outerHTML: 1090.2 ms
body.innerHTML: 239.2 ms
body.outerHTML: 239.2 ms

This patch applies the following two optimizations:

(a) Remove redundant copies between Vector<String> and StringBuilders
in MarkupAccumulator::serializeNodes(), MarkupAccumulator::appendStartTag(),
and MarkupAccumulator::appendEndTag().

(Previous behavior)

  • Create a StringBuilder for each tag.
  • Append a created string in each StringBuilder to Vector<String>, parsing the DOM tree.
  • After the parsing, allocate a StringBuilder whose size is the sum of all Strings in Vector<String>.
  • Append all Strings in Vector<String> to the StringBuilder. (New behavior)
  • Allocate a StringBuilder with a default buffer size.
  • Append created strings to the StringBuilder, incrementally parsing the DOM tree.

(b) Optimize stringBuilder.append().

(b-1) Replace stringBuilder.append("A") with stringBuilder.append('A').

stringBuilder.append("A") requires to cast the characters to LChar*,
and then call strlen("A"). stringBuilder.append('A') is faster.

(b-2) Replace stringBuilder.append("AB") with stringBuilder.append('A')

and stringBuilder.append('B'). In my experiment, appending characters
one by one is faster than appending the characters at a breath if the
number of characters is less than 3.

(b-3) Hard-code a string length; i.e. replace stringBuilder.append("ABCDE")

with stringBuilder.append("ABCDE", 5). While the former requires to call
strlen("ABCDE"), the latter does not.

(a) improves performance by 170% ~ 200%. (b) improves performance by 30 ~ 40%.

Tests: fast/dom/Range/range-extract-contents.html

fast/dom/serialize-nodes.xhtml
fast/dom/XMLSerializer.html
and all other tests that use innerHTML or outerHTML.
No change in the test results.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::serializeNodes):
(WebCore::MarkupAccumulator::appendString):
(WebCore::MarkupAccumulator::appendStartTag):
(WebCore::MarkupAccumulator::appendEndTag):
(WebCore::MarkupAccumulator::concatenateMarkup):
(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendDocumentType):
(WebCore::MarkupAccumulator::appendProcessingInstruction):
(WebCore::MarkupAccumulator::appendOpenTag):
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::appendCDATASection):

  • editing/MarkupAccumulator.h:

(MarkupAccumulator):

5:23 AM Changeset in webkit [110991] by commit-queue@webkit.org
  • 23 edits
    39 adds in trunk

.: Support for Battery Status API.
​https://bugs.webkit.org/show_bug.cgi?id=62698

Enable BATTERY_STATUS for WebKit-Efl.
​http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore: Support for Battery Status API
​https://bugs.webkit.org/show_bug.cgi?id=62698

Battery Status API is implemented under the Navigator class.
Battery Status API has four types of events, and all events are operated based on a callback mechanism.

: onchargingchange, onchargingtimechange, ondischargingtimechange, onlevelchange.

The battery status can be accessed using BatteryManager(navigator.webkitBattery), and battery status is controlled by BatteryController which manages instances of BatteryManager.
When battery status event is raised, BatteryController calls all registered BatteryManager's event dispatcher.
​http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

Tests: batterystatus/add-listener-from-callback.html

batterystatus/basic-all-types-of-events.html
batterystatus/basic-operation.html
batterystatus/event-after-navigation.html
batterystatus/multiple-frames.html
batterystatus/updates.html
batterystatus/window-property.html

  • CMakeLists.txt:
  • Modules/battery/BatteryClient.h: Added.

(WebCore):
(BatteryClient):
(WebCore::BatteryClient::~BatteryClient):

  • Modules/battery/BatteryController.cpp: Added.

(WebCore):
(WebCore::BatteryController::BatteryController):
(WebCore::BatteryController::~BatteryController):
(WebCore::BatteryController::create):
(WebCore::BatteryController::addListener):
(WebCore::BatteryController::removeListener):
(WebCore::BatteryController::didChangeBatteryStatus):
(WebCore::BatteryController::supplementName):
(WebCore::BatteryController::isActive):
(WebCore::provideBatteryTo):

  • Modules/battery/BatteryController.h: Added.

(WebCore):
(BatteryController):
(WebCore::BatteryController::client):
(WebCore::BatteryController::from):

  • Modules/battery/BatteryManager.cpp: Added.

(WebCore):
(WebCore::BatteryManager::create):
(WebCore::BatteryManager::~BatteryManager):
(WebCore::BatteryManager::BatteryManager):
(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):
(WebCore::BatteryManager::didChangeBatteryStatus):
(WebCore::BatteryManager::suspend):
(WebCore::BatteryManager::resume):
(WebCore::BatteryManager::stop):

  • Modules/battery/BatteryManager.h: Added.

(WebCore):
(BatteryManager):
(WebCore::BatteryManager::interfaceName):
(WebCore::BatteryManager::scriptExecutionContext):
(WebCore::BatteryManager::batteryControllerDestroyed):
(WebCore::BatteryManager::canSuspend):
(WebCore::BatteryManager::eventTargetData):
(WebCore::BatteryManager::ensureEventTargetData):
(WebCore::BatteryManager::refEventTarget):
(WebCore::BatteryManager::derefEventTarget):

  • Modules/battery/BatteryManager.idl: Added.
  • Modules/battery/BatteryStatus.cpp: Added.

(WebCore):
(WebCore::BatteryStatus::create):
(WebCore::BatteryStatus::BatteryStatus):

  • Modules/battery/BatteryStatus.h: Added.

(WebCore):
(BatteryStatus):
(WebCore::BatteryStatus::charging):
(WebCore::BatteryStatus::chargingTime):
(WebCore::BatteryStatus::dischargingTime):
(WebCore::BatteryStatus::level):

  • Modules/battery/NavigatorBattery.cpp: Added.

(WebCore):
(WebCore::NavigatorBattery::NavigatorBattery):
(WebCore::NavigatorBattery::~NavigatorBattery):
(WebCore::NavigatorBattery::webkitBattery):
(WebCore::NavigatorBattery::from):
(WebCore::NavigatorBattery::batteryManager):

  • Modules/battery/NavigatorBattery.h: Added.

(WebCore):
(NavigatorBattery):

  • Modules/battery/NavigatorBattery.idl: Added.
  • dom/EventNames.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • testing/Internals.cpp:

(WebCore::Internals::setBatteryStatus):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit: Support for Battery Status API
​https://bugs.webkit.org/show_bug.cgi?id=62698

Add include directory and file.
​http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • PlatformEfl.cmake:

Source/WebKit/efl: Support for Battery Status API
​https://bugs.webkit.org/show_bug.cgi?id=62698

Add BatteryClientEfl class implementation for the layout tests now.
BatteryClientEfl class is not fully implemented in this patch.
(It will be completed by other patch as necessary in the Efl port.)
​http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • WebCoreSupport/BatteryClientEfl.cpp: Added.

(WebCore):
(WebCore::BatteryClientEfl::BatteryClientEfl):
(WebCore::BatteryClientEfl::setController):
(WebCore::BatteryClientEfl::startUpdating):
(WebCore::BatteryClientEfl::stopUpdating):
(WebCore::BatteryClientEfl::batteryControllerDestroyed):
(WebCore::BatteryClientEfl::setBatteryStatus):

  • WebCoreSupport/BatteryClientEfl.h: Added.

(WebCore):
(BatteryClientEfl):
(WebCore::BatteryClientEfl::~BatteryClientEfl):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Tools: Support for Battery Status API
​https://bugs.webkit.org/show_bug.cgi?id=62698

Add include directory and file.
​http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • Scripts/build-webkit:

LayoutTests: Support for Battery Status API.
​https://bugs.webkit.org/show_bug.cgi?id=62698

Add new test cases for Battery Status API.
​http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • batterystatus/add-listener-from-callback-expected.txt: Added.
  • batterystatus/add-listener-from-callback.html: Added.
  • batterystatus/basic-all-types-of-events-expected.txt: Added.
  • batterystatus/basic-all-types-of-events.html: Added.
  • batterystatus/basic-operation-expected.txt: Added.
  • batterystatus/basic-operation.html: Added.
  • batterystatus/event-after-navigation-expected.txt: Added.
  • batterystatus/event-after-navigation.html: Added.
  • batterystatus/multiple-frames-expected.txt: Added.
  • batterystatus/multiple-frames.html: Added.
  • batterystatus/resources/event-after-navigation-new.html: Added.
  • batterystatus/script-tests/add-listener-from-callback.js: Added.

(checkBatteryStatus):
(firstListener):
(secondListener):
(maybeFinishTest):

  • batterystatus/script-tests/basic-all-types-of-events.js: Added.

(checkBatteryStatus):
(battery):

  • batterystatus/script-tests/basic-operation.js: Added.
  • batterystatus/script-tests/event-after-navigation.js: Added.
  • batterystatus/script-tests/multiple-frames.js: Added.

(checkBatteryStatus):
(checkChildBatteryStatus):
(mainFrameListener):
(childFrameListener):
(maybeFinishTest):

  • batterystatus/script-tests/updates.js: Added.

(checkBatteryStatus):
(setBatteryStatus):
(firstListener):
(updateListener):

  • batterystatus/script-tests/window-property.js: Added.

(hasOnBatteryProperty):

  • batterystatus/updates-expected.txt: Added.
  • batterystatus/updates.html: Added.
  • batterystatus/window-property-expected.txt: Added.
  • batterystatus/window-property.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
5:14 AM Changeset in webkit [110990] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=81007

Patch by Kishore Bolisetty <​kbolisetty@innominds.com> on 2012-03-16
Reviewed by Adam Barth.

A dedidcated build slave is available for efl on build.webkit.org.
This change add's an entry for the elf port in list of available port builders.
This is required because test_expectations.py when triggered, looks for a valid port object for the specified port.

  • Scripts/webkitpy/layout_tests/port/builders.py:
4:55 AM Changeset in webkit [110989] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: HeapSnapshot: speedup buildReverseIndex.
​https://bugs.webkit.org/show_bug.cgi?id=81327

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
(WebInspector.HeapSnapshot.prototype._findNearestNodeIndex):
(WebInspector.HeapSnapshot.prototype._getRetainerIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype):

4:41 AM Changeset in webkit [110988] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add ProcessLauncherEfl.cpp
​https://bugs.webkit.org/show_bug.cgi?id=75464

Patch by YoungTaeck Song <​youngtaeck.song@samsung.com> on 2012-03-16
Reviewed by Hajime Morita.

Add first version of ProcessLauncherEfl.cpp including launchProcess() and terminateProcess().

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp: Added.

(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::terminateProcess):
(WebKit::ProcessLauncher::platformInvalidate):

4:37 AM Changeset in webkit [110987] by abarth@webkit.org
  • 2 edits in trunk/Tools

[webkitpy] StatusServer.next_work_item has an incorrectly named local variable
​https://bugs.webkit.org/show_bug.cgi?id=81302

Reviewed by Eric Seidel.

This is a trivial patch, but the variable name turned up in a grep of
webkitpy and looks like copy pasta.

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer.next_work_item):

4:29 AM Changeset in webkit [110986] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r110976.
​http://trac.webkit.org/changeset/110976
​https://bugs.webkit.org/show_bug.cgi?id=81330

webkit_unit_tests crashes. (Requested by morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-16

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::error):
(WebCore):

  • loader/cache/CachedCSSStyleSheet.h:

(CachedCSSStyleSheet):

  • loader/cache/CachedFont.cpp:

(WebCore):
(WebCore::CachedFont::error):

  • loader/cache/CachedFont.h:

(CachedFont):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::error):

  • loader/cache/CachedResource.h:

(CachedResource):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::error):
(WebCore):

  • loader/cache/CachedScript.h:

(CachedScript):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::error):
(WebCore):

  • loader/cache/CachedXSLStyleSheet.h:

(CachedXSLStyleSheet):

4:25 AM Changeset in webkit [110985] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement cast between CSSPrimitiveValue and LineClampValue.
​https://bugs.webkit.org/show_bug.cgi?id=76806

Reviewed by Andreas Kling.

Covered by many existing LayoutTests.

This simplifies code in CSSStyleSelector and future mapping to CSSStyleApplyProperty.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineClampValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

4:03 AM Changeset in webkit [110984] by nduca@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Bump textureUpdatesPerFrame to 32 to favor updating the screen over jank prevention
​https://bugs.webkit.org/show_bug.cgi?id=81298

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WTF):

3:52 AM Changeset in webkit [110983] by leviw@chromium.org
  • 6 edits in trunk/Source/WebCore

Update usage of LayoutUnits in RenderBlock*
​https://bugs.webkit.org/show_bug.cgi?id=80437

Reviewed by Julien Chaffraix.

Updating LayoutUnit usage in RenderBlock and RenderBlockLineLayout. This better readies trunk for
the transition to subpixel layout.

See ​https://trac.webkit.org/wiki/LayoutUnit for more details.

No new tests. No changed behavior.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Adding the paint offset rounding previously in RenderBlock::paint.

  • rendering/LayoutTypes.h:

(WebCore::floorToInt): Will floor a LayoutUnit to an integer once we switch to
FractionalLayoutUnits.
(WebCore::boundedMultiply): Method that will return the multiplied result of two LayoutUnits
or the max/min LayoutUnit if the result overflows. Only does a regular multiply while
LayoutUnits are integers instead of FractionalLayoutUnits.
(WebCore):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContents): Rounding the paintOffset here didn't work for all
inline blocks. This rounding is actually only needed for InlineTextBoxes, so the logic has
been moved there.
(WebCore::RenderBlock::newLine): Use a LayoutUnit for the y position.
(WebCore::RenderBlock::isPointInOverflowControl): Points for hit testing need to be rounded.
(WebCore::RenderBlock::layoutColumns): Using boundedMultiply for a calculation prone to overflow.
(WebCore::updatePreferredWidth): Reverting back to using ceilf. ceiledLayoutUnit was to be ultimately
converted to just a straight LayoutUnit constructor to preserve precision. This precision doesn't work
for us here as we still paint Boxes/Blocks on pixel boundaries, so we need to expand to a pixel size
that encloses the contained text.
(WebCore::RenderBlock::setPageLogicalOffset): LogicalOffset should be a LayoutUnit.
(WebCore::RenderBlock::marginValuesForChild): Margins should have subpixel resolution.
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject): Intervals for floating objects
need to use pixel snapped values to give the proper results.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine): Only moved.
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine): While we can round the left offset,
columns add an extra offset at paint that can't currently be planned for at line-layout time. To
avoid laying out lines that run off the end of columns, we floor the right offset. The resulting
lines will be up to 1 pixel shorter than they potentially could be.
(RenderBlock):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX): Using corresponding pixelSnappedX value from
LayoutRects.
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedY): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight): Ditto.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): LogicalHeight is a LayoutUnit. Also
flooring textIndentOffset to an integer to match old behavior.
(WebCore::LineWidth::fitBelowFloats): Using LayoutUnits for float logical top and bottoms.
(WebCore::LineLayoutState::endLineLogicalTop): Changing to a LayoutUnit.
(WebCore::LineLayoutState::setEndLineLogicalTop): Ditto.
(LineLayoutState): Ditto.
(WebCore::RenderBlock::linkToEndLineIfNeeded): Calculating overflow with LayoutUnits.
(WebCore::RenderBlock::layoutInlineChildren): LowestAllowedPosition should be subpixel.
(WebCore::RenderBlock::checkLinesForTextOverflow): Reverting ellipsis width calculation to integers
as this value can be seen as representing pixels on screen.

3:39 AM Changeset in webkit [110982] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash when going back from an xhtml document containing <img>
​https://bugs.webkit.org/show_bug.cgi?id=81297

Reviewed by Rob Buis.

This is manually reverting the offending internal commit which checked-in before upstreaming.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::canCachePage):

3:34 AM Changeset in webkit [110981] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebCore

Follow up to: window.innerWidth/Height should not include page scale ​https://bugs.webkit.org/show_bug.cgi?id=76555

Reviewed by Simon Hausmann.

Introduce mapping methods for converting between CSS and layout units.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):

  • page/FrameView.h:

(FrameView):
(WebCore::FrameView::mapFromLayoutToCSSUnits):
(WebCore):
(WebCore::FrameView::mapFromCSSToLayoutUnits):

3:29 AM Changeset in webkit [110980] by commit-queue@webkit.org
  • 17 edits in trunk/Source

[chromium] Threaded opacity animation jump to opacity of 0
​https://bugs.webkit.org/show_bug.cgi?id=80744

Patch by Ian Vollick <​vollick@chromium.org> on 2012-03-16
Reviewed by James Robinson.

Source/WebCore:

Tested in CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::opacityIsAnimating):
(WebCore):
(WebCore::LayerChromium::transformIsAnimating):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::drawOpacityIsAnimating):
(WebCore::LayerChromium::setDrawOpacityIsAnimating):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::drawOpacityIsAnimating):
(WebCore::RenderSurfaceChromium::setDrawOpacityIsAnimating):
(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::isAnimatingProperty):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationController):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:

(WebCore::CCLayerAnimationControllerImpl::isAnimatingProperty):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:

(CCLayerAnimationControllerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::opacityIsAnimating):
(WebCore):
(WebCore::CCLayerImpl::transformIsAnimating):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::drawOpacityIsAnimating):
(WebCore::CCLayerImpl::setDrawOpacityIsAnimating):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerShouldBeSkipped):
(WebCore::subtreeShouldBeSkipped):
(WebCore):
(WebCore::LayerChromium):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::drawOpacityIsAnimating):
(WebCore::CCRenderSurface::setDrawOpacityIsAnimating):
(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::beginTest):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::animateLayers):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::afterTest):
(WTF::TEST_F):

3:21 AM Changeset in webkit [110979] by jocelyn.turcotte@nokia.com
  • 5 edits in trunk/Source/WebCore

[TexMap] Reuse textures following the same rules as they do internally.
​https://bugs.webkit.org/show_bug.cgi?id=80843

Reviewed by Noam Rosenthal.

BitmapTextures were recently changed to be the same size as their contents.
This would obsolete the logic in acquireTextureFromPool which would
assume that a BitmapTexture has good chances of being reused if its
size is bigger or equal to the new size.

This asks the texture instead if it can be reused which now simply
check for an exact size match.

  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore::TextureMapper::acquireTextureFromPool):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::canReuseWith):
(WebCore::BitmapTexture::reset):
(WebCore::BitmapTexture::didReset):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::canReuseWith):
(WebCore):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

3:20 AM Changeset in webkit [110978] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Connect up fling event delivery to gesture curve animation framework
​https://bugs.webkit.org/show_bug.cgi?id=80858

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::fireUpAnAnimation):

3:11 AM FeatureFlags edited by tkent@chromium.org
Add a comment on Hixie76 flag of WebSocket (diff)
2:48 AM Changeset in webkit [110977] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, marking a failing test.

  • platform/chromium/test_expectations.txt:
2:40 AM Changeset in webkit [110976] by Nate Chapin
  • 11 edits in trunk/Source/WebCore

Remove duplicate error() impls in CachedResource subclasses
​https://bugs.webkit.org/show_bug.cgi?id=81161

Reviewed by Alexey Proskuryakov.

No new tests, refactor only.

  • loader/cache/CachedCSSStyleSheet.cpp:
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedResource.h: Make checkNotify()

virtual, so the right checkNotify() gets called in error().

  • loader/cache/CachedScript.cpp:
  • loader/cache/CachedScript.h:
  • loader/cache/CachedXSLStyleSheet.cpp:
  • loader/cache/CachedXSLStyleSheet.h:
2:28 AM Changeset in webkit [110975] by Philippe Normand
  • 1 edit
    17 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new tests.

  • platform/gtk/compositing/overflow/ancestor-overflow-expected.txt: Added.
  • platform/gtk/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
  • platform/gtk/fast/line-grid/line-align-left-edges-expected.txt: Added.
  • platform/gtk/fast/line-grid/line-align-right-edges-expected.txt: Added.
  • platform/gtk/fast/repaint/transform-rotate-and-remove-expected.txt: Added.
  • platform/gtk/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/gtk/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/gtk/fast/speech/speech-bidi-rendering-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
  • platform/gtk/svg/custom/use-extern-href-expected.txt: Added.
  • platform/gtk/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.
2:20 AM Changeset in webkit [110974] by Philippe Normand
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/Skipped: Skip a new failing editing test
  • platform/gtk/fast/events/resize-events-expected.txt: Added.
  • platform/gtk/test_expectations.txt: Mark

inspector/styles/svg-style.xhtml as flaky.

2:20 AM Changeset in webkit [110973] by commit-queue@webkit.org
  • 13 edits in trunk/Source

[chromium] Changes to overdraw metrics to allow upload tracking
​https://bugs.webkit.org/show_bug.cgi?id=81222

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Stick CCOverdrawMetrics into CCOcclusionTracker, so that it is available
everywhere that culling/drawing/painting is going on. Then we can stop
plumbing a metrics object through CCQuadCuller.

Rename the CCOverdrawMetrics "painting" stuff to "uploading" as this will
measure texture uploads rather than pixels painted in main memory.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::overdrawMetrics):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::didCull):
(WebCore):
(WebCore::CCOverdrawMetrics::didDraw):
(WebCore::CCOverdrawMetrics::recordMetrics):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.h:

(WebCore):
(WebCore::CCOverdrawMetrics::create):
(CCOverdrawMetrics):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCRenderPass):

Source/WebKit/chromium:

  • tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

  • tests/MockCCQuadCuller.h:

(WebCore::MockCCQuadCuller::MockCCQuadCuller):

1:56 AM Changeset in webkit [110972] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

Add TransferList IDL modifier, with support in V8 code gen.
​https://bugs.webkit.org/show_bug.cgi?id=81127

Patch by Greg Billock <​gbillock@google.com> on 2012-03-16
Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):
(GetIndexOf):
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateFunctionCallString):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::acceptTransferList):

  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_accept_transfer_list):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::getOwnPropertyDescriptor):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(JSTestSerializedScriptValueInterfacePrototype):
(WebCore):

  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:

(-[DOMTestSerializedScriptValueInterface acceptTransferList:transferList:]):

  • bindings/scripts/test/TestSerializedScriptValueInterface.idl:
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceInternal::acceptTransferListCallback):
(TestSerializedScriptValueInterfaceInternal):
(WebCore):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

1:43 AM Changeset in webkit [110971] by mrowe@apple.com
  • 4 edits in tags/Safari-536.3.1/Source

Merge r110969.

1:43 AM Changeset in webkit [110970] by mrowe@apple.com
  • 4 edits in tags/Safari-536.3.1/Source

Versioning.

1:41 AM Changeset in webkit [110969] by mrowe@apple.com
  • 4 edits in trunk/Source

Build fix. Do not preserve owner and group information when installing the WTF headers.

Source/JavaScriptCore:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
1:39 AM Changeset in webkit [110968] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Quads that become fully opaque after culling should not use blending
​https://bugs.webkit.org/show_bug.cgi?id=81235

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::needsBlending):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::BlendStateCheckLayer::appendQuads):
(WebKit::BlendStateCheckLayer::setQuadRect):
(WebKit::BlendStateCheckLayer::setQuadVisibleRect):
(WebKit::BlendStateCheckLayer::setOpaqueContents):
(WebKit::BlendStateCheckLayer::setOpaqueContentRect):
(WebKit::BlendStateCheckLayer::BlendStateCheckLayer):
(BlendStateCheckLayer):
(WebKit::TEST_F):

1:36 AM Changeset in webkit [110967] by mrowe@apple.com
  • 1 copy in tags/Safari-536.3.1

New tag.

1:33 AM Changeset in webkit [110966] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] viewportRect has changed to viewportSize
​https://bugs.webkit.org/show_bug.cgi?id=81262

Patch by Genevieve Mak <​gmak@rim.com> on 2012-03-16
Reviewed by Antonio Gomes.

Set size instead of rect in constructor.

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

1:27 AM Changeset in webkit [110965] by xji@chromium.org
  • 17 edits
    2 adds in trunk

Using ICU break iterator to simplify visual word movement implementation.
​https://bugs.webkit.org/show_bug.cgi?id=78856

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch relies on ICU word break iterator and cursor visual movement by character to get the word break
position in visual order. It reduces the complexity of old implementation.

Test: editing/selection/move-by-word-visually-wrong-left-right.html

  • editing/FrameSelection.cpp: Exclude WinCE from visual word movement since isWordTextBreak is not implemented.

(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingLeft):

  • editing/visible_units.cpp:

(WebCore):
(WebCore::previousLeafWithSameEditability): Just moving to the top without functionality change.
(WebCore::enclosingNodeWithNonInlineRenderer): ditto.
(WebCore::nextLeafWithSameEditability): ditto.
(WebCore::previousRootInlineBox): return previous RootInlineBox which is in different renderer.
(WebCore::nextRootInlineBox): return next RootInlineBox which is in different renderer.
(WebCore::boxIndexInVector):
(WebCore::previousBoxInLine): returns logically previous box in one line.
(WebCore::logicallyPreviousBox): returns logically previous box.
(WebCore::nextBoxInLine): returns logically next box in one line.
(WebCore::logicallyNextBox): returns logically next box.
(WebCore::wordBreakIteratorForMinOffsetBoundary): create word break iterator for position that is a box's min offset.
(WebCore::wordBreakIteratorForMaxOffsetBoundary): create word break iterator for position that is a box's max offset.
(WebCore::isLogicalStartOfWord): return whether a position is logically start of word.
(WebCore::islogicalEndOfWord): return whether a position is logically end of word.
(WebCore::visualWordPosition): returns the visual left or right word position.
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

  • platform/text/TextBreakIterator.h: Add isWordTextBreak().

(WebCore):

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::isWordTextBreak):
(WebCore):

  • platform/text/gtk/TextBreakIteratorGtk.cpp:

(WebCore::isWordTextBreak):
(WebCore):

  • platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::isWordTextBreak):
(WebCore):

  • platform/text/wince/TextBreakIteratorWinCE.cpp:

(WebCore::isWordTextBreak):
(WebCore):

LayoutTests:

  • editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt:
  • editing/selection/move-by-word-visually-inline-block-positioned-element.html: The word break stops at the beginning of fixed positioned element, which is correct and consistent behavior.
  • editing/selection/move-by-word-visually-multi-line-expected.txt:
  • editing/selection/move-by-word-visually-multi-line.html: The word break does not stop at the end of a text if there is next line of text available under the same editable root, which is a consistent behavior cross the board. Add more test cases, including one with non InlineTextBox.
  • editing/selection/move-by-word-visually-single-space-inline-element-expected.txt: Fixing of previously missing or extra word break positions.
  • editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
  • editing/selection/move-by-word-visually-single-space-one-element.html: Add a test case including bidi control character which renders wrong result since right-arrow could not reach a position which is the word break position. Add another test case containing non InlineTextBox.
  • editing/selection/move-by-word-visually-wrong-left-right-expected.txt: Added.
  • editing/selection/move-by-word-visually-wrong-left-right.html: Added. Add a test case which renders wrong result due to left/right-arrow returns wrong result.
  • editing/selection/resources/move-by-word-visually.js:

(moveByWordOnEveryChar): Handle a special case when left/right arrow missing certain position.

1:20 AM Changeset in webkit [110964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Don't create a quad for video layers without a frame (avoid use of uninitialized m_format)
​https://bugs.webkit.org/show_bug.cgi?id=81250

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-16
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

1:19 AM Changeset in webkit [110963] by commit-queue@webkit.org
  • 5 edits in trunk

[BlackBerry] Enable PAGE_VISIBILITY_API
​https://bugs.webkit.org/show_bug.cgi?id=81257

Source/WebKit/blackberry:

Set Page visibility state for BlackBerry port.

Patch by Andrew Lo <​anlo@rim.com> on 2012-03-16
Reviewed by Rob Buis.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
(BlackBerry::WebKit::WebPagePrivate::setVisible):
(BlackBerry::WebKit::WebPage::setVisible):
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPage::notifyAppActivationStateChange):

  • Api/WebPage_p.h:

(WebPagePrivate):

Tools:

Enable Page Visibility API for BlackBerry.

Patch by Andrew Lo <​anlo@rim.com> on 2012-03-16
Reviewed by Rob Buis.

  • Scripts/build-webkit:
1:12 AM Changeset in webkit [110962] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix Chromium windows build.

  • Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

1:11 AM Changeset in webkit [110961] by reed@google.com
  • 2 edits in trunk/LayoutTests

make test for rebaselining after skia 3398 lands
​https://bugs.webkit.org/show_bug.cgi?id=81246

Unreviewed. expectations only

  • platform/chromium/test_expectations.txt:
1:00 AM Changeset in webkit [110960] by commit-queue@webkit.org
  • 7 edits
    3 deletes in trunk

[Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
​https://bugs.webkit.org/show_bug.cgi?id=81232

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2012-03-16
Reviewed by Philippe Normand.

Source/WebKit/gtk:

Add computedStyleIncludingVisitedInfo helper method to
DumpRenderTreeSupportGtk.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::computedStyleIncludingVisitedInfo):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Use the newly-added helper method in DumpRenderTreeSupportGtk.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):

LayoutTests:

Unskip now-passing tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/history/nested-visited-test-expected.txt: Removed.
  • platform/gtk/fast/history/self-is-visited-expected.txt: Removed.
  • platform/gtk/fast/history/sibling-visited-test-expected.txt: Removed.
12:57 AM Changeset in webkit [110959] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

[Gtk] Properly set forms tests-specific settings
​https://bugs.webkit.org/show_bug.cgi?id=81237

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2012-03-16
Reviewed by Philippe Normand.

Source/WebKit/gtk:

Call Settings::setInteractiveFormValidationEnabled and
Settings::setValidationMessageTimerMagnification with
proper values when in testing mode.

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

LayoutTests:

Unskip newly-passing tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/validation-message-appearance-expected.txt: Added.
12:44 AM Changeset in webkit [110958] by morrita@google.com
  • 1 edit
    7 adds in trunk/LayoutTests

Unreviewed expectations update.

  • platform/chromium-linux/fast/events/resize-events-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/resize-events-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/events/resize-events-expected.png: Added.
  • platform/chromium-mac/fast/events/resize-events-expected.png: Added.
  • platform/chromium-mac/fast/events/resize-events-expected.txt: Added.
  • platform/chromium-win/fast/events/resize-events-expected.png: Added.
  • platform/chromium-win/fast/events/resize-events-expected.txt: Added.
12:44 AM Changeset in webkit [110957] by commit-queue@webkit.org
  • 12 edits
    3 moves in trunk/Source/WebCore

Move DOMWindowFileSystem to Modules/filesystem/
​https://bugs.webkit.org/show_bug.cgi?id=81030

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/filesystem/DOMWindowFileSystem.cpp: Copied from Source/WebCore/fileapi/DOMWindowFileSystem.cpp.
  • Modules/filesystem/DOMWindowFileSystem.h: Copied from Source/WebCore/fileapi/DOMWindowFileSystem.h.
  • Modules/filesystem/DOMWindowFileSystem.idl: Copied from Source/WebCore/fileapi/DOMWindowFileSystem.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • fileapi/DOMWindowFileSystem.cpp: Removed.
  • fileapi/DOMWindowFileSystem.h: Removed.
  • fileapi/DOMWindowFileSystem.idl: Removed.
12:34 AM Changeset in webkit [110956] by commit-queue@webkit.org
  • 8 edits in trunk

Unreviewed, rolling out r110951.
​http://trac.webkit.org/changeset/110951
​https://bugs.webkit.org/show_bug.cgi?id=81316

Does not build on apple-mac (Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-16

Source/WebCore:

  • platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):

  • webaudio/DynamicsCompressorNode.h:

(DynamicsCompressorNode):

  • webaudio/DynamicsCompressorNode.idl:

LayoutTests:

  • webaudio/dynamicscompressor-basic-expected.txt:
  • webaudio/dynamicscompressor-basic.html:
12:31 AM Changeset in webkit [110955] by reed@google.com
  • 2 edits in trunk/LayoutTests

to be rebaselined after hairline clipping fix in skia lands
​https://bugs.webkit.org/show_bug.cgi?id=81233

Unreviewed. expectations change only

  • platform/chromium/test_expectations.txt:
12:23 AM Changeset in webkit [110954] by eae@chromium.org
  • 2926 edits
    1466 copies
    439 deletes in branches/subpixellayout

Merge trunk changes up until r110884 into subpixel branch.

12:17 AM Changeset in webkit [110953] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Cleanup empty attribute list in IDLs
​https://bugs.webkit.org/show_bug.cgi?id=81228

Patch by Seo Sanghyeon <​sh4.seo@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

No tests. No change in behavior.

  • css/WebKitCSSRegionRule.idl:
12:05 AM Changeset in webkit [110952] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

onorientationchange event should have JSWindowEventListener attribute
​https://bugs.webkit.org/show_bug.cgi?id=79513

Reviewed by Kentaro Hara.

  • html/HTMLFrameSetElement.idl:
Note: See TracTimeline for information about the timeline view.