Context Navigation

← Previous Period
Next Period →

Timeline

Mar 28, 2012:

11:52 PM Changeset in webkit [112504] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG object equality speculations should be simplified
https://bugs.webkit.org/show_bug.cgi?id=82557

Reviewed by Gavin Barraclough.

dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateFinalObject):
(JSC::DFG::Node::shouldSpeculateArray):

11:00 PM Changeset in webkit [112503] by tkent@chromium.org

4 edits in trunk/Source/WebCore

Add TextFieldDecorationElement::decorate()
https://bugs.webkit.org/show_bug.cgi?id=82572

Reviewed by Hajime Morita.

This change will be needed for Bug 82143.
No new tests because of no behavior changes yet. This code change
doesn't affect non-Chromium ports for now.

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):
Remove unnecessary assertion. We should allow multiple UA shadow roots.

html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::decorate):
Added.
This function adds another ShadowRoot, and it contains one flexible box container.
The container contains existin ShadowRoot content and the decoration element.

html/shadow/TextFieldDecorationElement.h:

(TextFieldDecorationElement): Add the declaration of decorate().

10:47 PM Changeset in webkit [112502] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Consider removal of removes jsNull()/v8::Null() from JSInternalsCustom.cpp/V8InternalsCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=82442

Patch by Vineet Chaudhary <Vineet> on 2012-03-28
Reviewed by Kentaro Hara.

No new tests. LayoutTests/fast/harness/user-preferred-language.html should pass
even after these changes.

testing/js/JSInternalsCustom.cpp: Remove jsNull() if Vector is empty.

(WebCore::JSInternals::userPreferredLanguages):

testing/v8/V8InternalsCustom.cpp: Remove v8::Null() if Vector is empty.

(WebCore::V8Internals::userPreferredLanguagesAccessorGetter):

10:29 PM Changeset in webkit [112501] by abarth@webkit.org

3 edits
12 copies
12 adds in trunk/Source

[Chromium] Move APIs related to ResourceHandle into Platform
https://bugs.webkit.org/show_bug.cgi?id=82553

Reviewed by James Robinson.

Source/Platform:

This patch is the first patch in this series:
https://github.com/abarth/webkit/compare/master...webcore-platform

The goal of these patches is to move WebCore::ResourceHandle out of
Chromium's WebKit layer and into WebCore/platform, where it belongs.

This patch moves the Chromium-WebKit APIs used by ResourceHandle out of
the WebKit layer and into the Plaform layer. These are APIs that WebKit
uses to call "down" to manipulate the underlying platform (rather than
"up" to the client to make decisions). The long-term plan is to move
all of the headers in WebKit/chromium/public/platform into
Platform/chromium/public (although we'll likely need to clean up some
layering violations as we go).

Platform.gypi:
chromium/public/WebData.h: Added.

(WebKit):
(WebData):
(WebKit::WebData::~WebData):
(WebKit::WebData::WebData):
(WebKit::WebData::operator=):
(WebKit::WebData::isEmpty):
(WebKit::WebData::isNull):

chromium/public/WebHTTPBody.h: Added.

(WebKit):
(WebHTTPBody):
(WebKit::WebHTTPBody::~WebHTTPBody):
(WebKit::WebHTTPBody::WebHTTPBody):
(WebKit::WebHTTPBody::operator=):
(WebKit::WebHTTPBody::isNull):

chromium/public/WebHTTPHeaderVisitor.h: Added.

(WebKit):
(WebHTTPHeaderVisitor):
(WebKit::WebHTTPHeaderVisitor::~WebHTTPHeaderVisitor):

chromium/public/WebHTTPLoadInfo.h: Added.

(WebCore):
(WebKit):
(WebHTTPLoadInfo):
(WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo):
(WebKit::WebHTTPLoadInfo::~WebHTTPLoadInfo):
(WebKit::WebHTTPLoadInfo::operator =):

chromium/public/WebPrivateOwnPtr.h: Added.

(WebKit):
(WebPrivateOwnPtr):
(WebKit::WebPrivateOwnPtr::WebPrivateOwnPtr):
(WebKit::WebPrivateOwnPtr::~WebPrivateOwnPtr):
(WebKit::WebPrivateOwnPtr::reset):
(WebKit::WebPrivateOwnPtr::get):
(WebKit::WebPrivateOwnPtr::operator->):

chromium/public/WebURL.h: Added.

(WebKit):
(WebURL):
(WebKit::WebURL::~WebURL):
(WebKit::WebURL::WebURL):
(WebKit::WebURL::operator=):
(WebKit::WebURL::assign):
(WebKit::WebURL::spec):
(WebKit::WebURL::parsed):
(WebKit::WebURL::isValid):
(WebKit::WebURL::isEmpty):
(WebKit::WebURL::isNull):
(WebKit::WebURL::operator GURL):
(WebKit::operator<):
(WebKit::operator==):
(WebKit::operator!=):

chromium/public/WebURLError.h: Added.

(WebKit):
(WebURLError):
(WebKit::WebURLError::WebURLError):

chromium/public/WebURLLoadTiming.h: Added.

(WebKit):
(WebURLLoadTiming):
(WebKit::WebURLLoadTiming::~WebURLLoadTiming):
(WebKit::WebURLLoadTiming::WebURLLoadTiming):
(WebKit::WebURLLoadTiming::operator=):
(WebKit::WebURLLoadTiming::isNull):

chromium/public/WebURLLoader.h: Added.

(WebKit):
(WebURLLoader):
(WebKit::WebURLLoader::~WebURLLoader):

chromium/public/WebURLLoaderClient.h: Added.

(WebKit):
(WebURLLoaderClient):
(WebKit::WebURLLoaderClient::willSendRequest):
(WebKit::WebURLLoaderClient::didSendData):
(WebKit::WebURLLoaderClient::didReceiveResponse):
(WebKit::WebURLLoaderClient::didDownloadData):
(WebKit::WebURLLoaderClient::didReceiveData):
(WebKit::WebURLLoaderClient::didReceiveCachedMetadata):
(WebKit::WebURLLoaderClient::didFinishLoading):
(WebKit::WebURLLoaderClient::didFail):
(WebKit::WebURLLoaderClient::~WebURLLoaderClient):

chromium/public/WebURLRequest.h: Added.

(WebKit):
(WebURLRequest):
(ExtraData):
(WebKit::WebURLRequest::ExtraData::~ExtraData):
(WebKit::WebURLRequest::~WebURLRequest):
(WebKit::WebURLRequest::WebURLRequest):
(WebKit::WebURLRequest::operator=):

chromium/public/WebURLResponse.h: Added.

(WebKit):
(WebURLResponse):
(ExtraData):
(WebKit::WebURLResponse::ExtraData::~ExtraData):
(WebKit::WebURLResponse::~WebURLResponse):
(WebKit::WebURLResponse::WebURLResponse):
(WebKit::WebURLResponse::operator=):

Source/WebKit/chromium:

These headers are now just forwarding headers to the new location of
these headers. These forwarding headers exist to avoid breaking
existing users of the API. They will likely be removed (or changed)
in the future once we've updated all folks using them.

public/platform/WebData.h:
public/platform/WebHTTPBody.h:
public/platform/WebHTTPHeaderVisitor.h:
public/platform/WebHTTPLoadInfo.h:
public/platform/WebPrivateOwnPtr.h:
public/platform/WebURL.h:
public/platform/WebURLError.h:
public/platform/WebURLLoadTiming.h:
public/platform/WebURLLoader.h:
public/platform/WebURLLoaderClient.h:
public/platform/WebURLRequest.h:
public/platform/WebURLResponse.h:

9:59 PM Changeset in webkit [112500] by hayato@chromium.org

8 edits
2 adds
2 deletes in trunk

Source/WebCore: Let focus navigation be compliant with Shadow DOM spec.
https://bugs.webkit.org/show_bug.cgi?id=78588

Reviewed by Dimitri Glazkov.

Sequential focus navigation now behaves exactly as specified in the Shadow DOM spec.

According to the Shadow DOM spec:
The shadow DOM navigation order sequence is inserted into the document navigation order:

immediately after the shadow host, if the shadow host is focusable; or
in place of the shadow host as if the shadow host were assigned the value of auto for determining its position.

Prior to this patch, sequential focus navigation goes into Shadow DOM, but it is incomplete
since insertion points, such as <content> elements or <shadow> elements, are not resolved at all.
Now focus navigation can traverse shadow DOM subtrees in 'reified tree order', resolving lower boundaries transparently.

Implementation notes:
Prior to this patch, sequential focus navigation does not go into Shadow DOM if a shadow host is non-focusable.
Now focus navigation must go into Shadow DOM subtrees even if a show host is not focusable as described in 2).
To support this behavior, this patch introduced adjustedTabIndex() locally in FocusController so that
it does not skip a non-focusable shadow host in current focus scope.
After finding a *pseudo* focusable element in current focus scope, it tries to resolve a focused element recursively,
considering a nested focus scope inside of a shadow host or iframe.
To traverse Shadow DOM subtrees, a FocusController makes use of ReifiedTreeTraversal APIs, which was introduced in r112055.

This change does not affect an existing behavior if a shadow dom is not involved.

Test: fast/dom/shadow/focus-navigation.html

dom/Element.cpp:

(WebCore::Element::focus):

page/FocusController.cpp:

(WebCore::isShadowHost):
(WebCore):
(WebCore::FocusScope::FocusScope):
(WebCore::FocusScope::rootNode):
(WebCore::FocusScope::owner):
(WebCore::FocusScope::focusScopeOf):
(WebCore::FocusScope::focusScopeOwnedByShadowHost):
(WebCore::FocusScope::focusScopeOwnedByIFrame):
(WebCore::hasCustomFocusLogic):
(WebCore::isNonFocusableShadowHost):
(WebCore::isFocusableShadowHost):
(WebCore::adjustedTabIndex):
(WebCore::shouldVisit):
(WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableNodeAcrossFocusScope):
(WebCore::FocusController::findFocusableNodeRecursively):
(WebCore::FocusController::findFocusableNode):
(WebCore::FocusController::findNodeWithExactTabIndex):
(WebCore::nextNodeWithGreaterTabIndex):
(WebCore::previousNodeWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

page/FocusController.h:

(WebCore):
(FocusScope):
(FocusController):

LayoutTests: Make focus navigation be compliant with Shadow DOM spec.
https://bugs.webkit.org/show_bug.cgi?id=78588

Reviewed by Dimitri Glazkov.

fast/dom/shadow/focus-navigation-expected.txt: Added.
fast/dom/shadow/focus-navigation.html: Added.
fast/dom/shadow/resources/shadow-dom.js:

(isShadowHost):
(isIframeElement):
(getNodeInShadowTreeStack):
(dumpNode):
(innermostActiveElement):
(isInnermostActiveElement):
(shouldNavigateFocus):
(navigateFocusForward):
(navigateFocusBackward):
(testFocusNavigationFowrad):
(testFocusNavigationBackward):

fast/dom/shadow/shadow-host-transfer-focus-expected.txt: Removed.
fast/dom/shadow/shadow-host-transfer-focus.html: Removed.
fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt:
fast/dom/shadow/tab-order-iframe-and-shadow.html:

9:22 PM Changeset in webkit [112499] by commit-queue@webkit.org

5 edits
3 adds in trunk

[WebSocket]Browser must fail connection if Sec-WebSocket-Protocol mismatched.
https://bugs.webkit.org/show_bug.cgi?id=82307

Patch by Li Yin <li.yin@intel.com> on 2012-03-28
Reviewed by Kent Tamura.

Source/WebCore:

From RFC6455: http://tools.ietf.org/html/rfc6455#section-4.1
If the WebSocket openhanding respond included the mismatched
Sec-WebSocket-Protocol header field, the client must fail the WebSocket Connection.

Test: http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header.html

Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::checkResponseHeaders):

LayoutTests:

From RFC6455: http://tools.ietf.org/html/rfc6455#section-4.1
If the response includes a |Sec-WebSocket-Protocol| header field
and this header field indicates the use of a subprotocol that was
not present in the client's handshake (the server has indicated a
subprotocol not requested by the client), the client MUST _Fail
the WebSocket Connection_.

http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header-expected.txt: Added.
http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header.html: Added.
http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

9:08 PM Changeset in webkit [112498] by jberlin@webkit.org

2 edits in trunk/Source/WebCore

Fix Windows build after r112482.

platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::formOpen):
Do not attempt to use an OS X error code on Windows. Use the POSIX errno instead.

8:42 PM Changeset in webkit [112497] by Alexandru Chiculita

3 edits in trunk/Source/WebCore

[CSS Filters] Avoid rebuilding FEFilters when RenderLayer is destroyed
https://bugs.webkit.org/show_bug.cgi?id=82524

Reviewed by Dean Jackson.

RenderLayer::~RenderLayer is calling clearBacking which updated the m_filter with new filters,
even though they were to be deleted a couple of lines below. This change avoids updating the filters,
if we are in the "destroyed" state.

No new tests. This change has no visible results to HTML or JavaScript, so it cannot be tested without a debugger.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::clearBacking):

rendering/RenderLayer.h:

(RenderLayer):

8:00 PM Changeset in webkit [112496] by ddkilzer@apple.com

3 edits in trunk/Source/JavaScriptCore

minidom configurations should be based on ToolExecutable.xcconfig
<http://webkit.org/b/82513>

Reviewed by Mark Rowe.

Note that this patch changes minidom from being installed in
/usr/local/bin to JavaScriptCore.framework/Resources.

Configurations/ToolExecutable.xcconfig: Add semi-colon.
JavaScriptCore.xcodeproj/project.pbxproj: Base minidom

configurations on ToolExecutable.xcconfig. Remove redundant
PRODUCT_NAME and SKIP_INSTALL variables.

7:57 PM Changeset in webkit [112495] by gyuyoung.kim@samsung.com

6 edits in trunk/Source/WebCore

Remove ScriptExecutionContext from NavigatorBattery.idl
https://bugs.webkit.org/show_bug.cgi?id=82556

Reviewed by Adam Barth.

As Bug 73528 comment #71, NavigatorBattery.idl doesn't need to have ScriptExecutionContext.
Document can be used instead of ScriptExecutionContext.

Tests: batterystatus/add-listener-from-callback.html

batterystatus/basic-all-types-of-events.html
batterystatus/basic-operation.html
batterystatus/event-after-navigation.html
batterystatus/multiple-frames.html
batterystatus/updates.html
batterystatus/window-property.html

Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::create):
(WebCore::BatteryManager::BatteryManager):

Modules/battery/BatteryManager.h:

(BatteryManager):

Modules/battery/NavigatorBattery.cpp:

(WebCore::NavigatorBattery::webkitBattery):

Modules/battery/NavigatorBattery.h:

(NavigatorBattery):

Modules/battery/NavigatorBattery.idl:

7:32 PM Changeset in webkit [112494] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry]Missing cookies from HTTP response header in Network tab of Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=82041

We shouldn't overwrite cookies of response if there are more than one
header of Set-Cookie.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-28
Reviewed by Rob Buis.

Test: http/tests/cookies/resources/setArraycookies.php

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyHeaderReceived):

7:18 PM Changeset in webkit [112493] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

JPEGImageDecoder: Set frame alpha state before marking a frame complete
https://bugs.webkit.org/show_bug.cgi?id=82428

Reviewed by Kenneth Russell.

r109779 changed JPEG alpha channel handling by marking a JPEG image frame
as having no alpha _after_ setting the image status frame-complete, which
prevents the application of image color profiles in some WebGL cases.

No new tests. The application of the color profile is not guaranteed for
images used as textures in WebGL. Refer to http://wkb.ug/76498.

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::jpegComplete): Set the image frame alpha state
before marking the image frame status as frame-complete.

7:11 PM Changeset in webkit [112492] by eae@chromium.org

2 edits in trunk/Source/WebCore

Fix rounding in RenderInline::paintOutlineForLine
https://bugs.webkit.org/show_bug.cgi?id=82540

Reviewed by Eric Seidel.

No new tests, no change in functionality.

rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):
Change paintOutlineForLine to pixel snap the left and right edges of the
lines instead of adding the offset to an already rounded number.

7:00 PM passwords.json attached to BuildBot by rniwa@webkit.org

passwords.json

6:50 PM Changeset in webkit [112491] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix a crash and an assertion when recovering from a web process crash
https://bugs.webkit.org/show_bug.cgi?id=82559
<rdar://problem/10902574>

Reviewed by Mark Rowe.

UIProcess/API/mac/WKView.mm:

(-[WKView _processDidCrash]):
If we're currently in accelerated compositing mode, exit.

(-[WKView updateLayer]):
Guard against a null drawing area.

6:46 PM Changeset in webkit [112490] by dgrogan@chromium.org

146 edits
3 adds
1 delete in trunk

IndexedDB: don't expose IDBDatabaseError to script
https://bugs.webkit.org/show_bug.cgi?id=82280

Source/WebCore:

It's not used anywhere and firefox doesn't expose it.

Reviewed by Tony Chang.

Test: storage/indexeddb/removed.html

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Modules/indexeddb/DOMWindowIndexedDatabase.idl:
Modules/indexeddb/IDBDatabaseError.idl: Removed.
Modules/indexeddb/WorkerContextIndexedDatabase.idl:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Add layout test that ensures IDBDatabaseError is gone.

Also change shouldBeTrue to shouldBeTrueQuiet in the boilerplate idb
layout test preamble to remove a bunch of clutter from the
-expected.txt files.

Reviewed by Tony Chang.

storage/indexeddb/basics-expected.txt:
storage/indexeddb/basics-shared-workers-expected.txt:
storage/indexeddb/basics-workers-expected.txt:

... every indexeddb -expected.txt:
Remove output from check for IDBDatabaseError.

storage/indexeddb/removed-expected.txt: Added.
storage/indexeddb/removed.html: Added.
storage/indexeddb/request-event-propagation-expected.txt:
storage/indexeddb/resources/removed.js: Added.

(test):

storage/indexeddb/resources/shared.js:

(removeVendorPrefixes): Stop checking for existence of
window.IDBDatabaseError.

6:41 PM Changeset in webkit [112489] by bashi@chromium.org

3 edits in trunk

Respects font fallback list during webfonts are loading
https://bugs.webkit.org/show_bug.cgi?id=76684

Reviewed by Dimitri Glazkov.

Source/WebCore:

For layout, use the rest of the fallback list while webfonts are loading.
If the webfont is loading, it will be given an invalid Unicode Range so that
font selection mechansim doesn't use the webfont for layout.

Test: http/tests/webfont/fallback-font-while-loading.html

css/CSSSegmentedFontFace.cpp:

(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading): Added.
(WebCore):
(WebCore::CSSSegmentedFontFace::getFontData):

LayoutTests:

Add a test that checks fallback fonts are used for layout while
webfonts are loading.

http/tests/webfont/fallback-font-while-loading-expected.txt: Added.
http/tests/webfont/fallback-font-while-loading.html: Added.
http/tests/webfont/getahem.cgi: Added.
http/tests/webfont/resources/Ahem.ttf: Added.

6:32 PM Changeset in webkit [112488] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

[WebSocket]Reserved bits test case should cover both extension and no-extension scenarios
https://bugs.webkit.org/show_bug.cgi?id=82100

Patch by Li Yin <li.yin@intel.com> on 2012-03-28
Reviewed by Kent Tamura.

The current reserved bits test case only support extension case,
Improve test case to cover both no-extension and extension scenarios.

http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
http/tests/websocket/tests/hybi/reserved-bits.html:
http/tests/websocket/tests/hybi/reserved-bits_wsh.py:

(web_socket_do_extra_handshake):

6:29 PM Changeset in webkit [112487] by mrowe@apple.com

2 edits in trunk/Source/WebCore

Update Localizable.strings.

English.lproj/Localizable.strings:

6:29 PM Changeset in webkit [112486] by mrowe@apple.com

2 edits in trunk/Tools

Fix --no-saved-state.

Ignore the flag before Lion, rather than making it specific to Lion.

Rubber-stamped by Dan Bernstein.

Scripts/webkitdirs.pm:

(argumentsForRunAndDebugMacWebKitApp):

6:14 PM Changeset in webkit [112485] by bbudge@chromium.org

3 edits in trunk/Source/WebKit/chromium

AssociatedURLLoader does not support Cross Origin Redirects when using
Access Control.
https://bugs.webkit.org/show_bug.cgi?id=82354

AssociatedURLLoader's internal adapter now overrides didFailRedirectCheck,
which cancels the load, causing didFail to notify the client that the
load failed. AssociatedURLLoaderTest adds test cases for CORS requests
that receive redirects and pass or fail the redirect access check.

Reviewed by Adam Barth.

src/AssociatedURLLoader.cpp:

(AssociatedURLLoader::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didFailRedirectCheck):
(WebKit):

tests/AssociatedURLLoaderTest.cpp:

(WebKit):
(WebKit::TEST_F):

6:07 PM Changeset in webkit [112484] by commit-queue@webkit.org

8 edits
2 adds in trunk

Source/WebCore: Removed particular rendering for the volume slider and used
css positioning instead (simpler and less prone to errors when
changes occur).
https://bugs.webkit.org/show_bug.cgi?id=82150

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-28
Reviewed by Eric Carlson.

Test: media/video-controls-rendering-toggle-display-none.html

css/mediaControls.css: Updated css to correctly render controls.

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

css/mediaControlsChromium.css: Updated css to correctly render controls.

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):

html/shadow/MediaControlElements.cpp: Removed particular renderer.

(WebCore):

html/shadow/MediaControlElements.h: Removed particular renderer.

(MediaControlVolumeSliderContainerElement):

html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::create): Added an anonymous div container
for the mute button and volume slider (to be displayed on top of each other)

LayoutTests: Added relevant test to support video controls display:none toggling.
https://bugs.webkit.org/show_bug.cgi?id=82150

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-28
Reviewed by Eric Carlson.

media/video-controls-rendering-toggle-display-none.html: Added.
platform/chromium-linux/media/video-controls-rendering-toggle-display-none-expected.png: Added.
platform/chromium-linux/media/video-controls-rendering-toggle-display-none-expected.txt: Added.
platform/chromium/test_expectations.txt: Updated expectations, more rebaselining is needed.

6:02 PM Changeset in webkit [112483] by Stephanie Lewis

4 edits in trunk

Unreviewed, rolling out r110064.
http://trac.webkit.org/changeset/110064
https://bugs.webkit.org/show_bug.cgi?id=82537

The patch leaks the DOM when audio elements are used
(Requested by sundiamonde on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-28

Source/WebCore:

bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

LayoutTests:

platform/gtk/test_expectations.txt:

5:58 PM Changeset in webkit [112482] by ap@apple.com

8 edits in trunk/Source/WebCore

[Win] Some Blob tests crash in CFNetwork in advanceCurrentStream(FormStreamFields*)
https://bugs.webkit.org/show_bug.cgi?id=82386
<rdar://problem/11121501>

Reviewed by Brady Eidson.

Covered by existing tests.

platform/network/cf/FormDataStreamCFNet.cpp:
platform/network/cf/FormDataStreamCFNet.h:

Moved low level implementation from FormDataStreamMac, and exposed an additional function
to implement Foundation-based API on top of this.

platform/network/mac/FormDataStreamMac.h:
platform/network/mac/FormDataStreamMac.mm:

Rely on toll-free bridging and implementation details to make this work without duplicating
code.
Note that httpBodyFromStream is confusing - I don't see how it can work when sending serialized
requests across process boundary. We probably only get away with this because we don't attempt
to send requests to UI process once they already have streams associated with them.

WebCore.vcproj/WebCore.vcproj: Added missing platform/cf files.

platform/cf/FileSystemCF.cpp: Fixed include style.

platform/win/FileSystemWin.cpp: (WebCore::fileSystemRepresentation): Ifdef out a broken

implementation.

5:56 PM Changeset in webkit [112481] by enne@google.com

12 edits in trunk/Source

[chromium] Fix tiled layer assert for huge layers
https://bugs.webkit.org/show_bug.cgi?id=82486

Reviewed by James Robinson.

Source/WebCore:

Test: TiledLayerChromiumTest.hugeLayerUpdateCrash

TilingData::numTiles() is calculated as the product of two ints and so
can potentially overflow, causing numTiles() to be incorrect. To avoid
calling code accidentally falling into this trap, remove this function
and all code that uses tile index from TilingData. This requires
fixing up a bunch of callers of TilingData and CCLayerTilingData.

Additionally, TilingData::numTiles() has long been a confusing
function name in some contexts, so rename to bool hasEmptyBounds().

Also, remove TilingData::intersectDrawQuad because there are no
clients of that function.

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::reserveTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::tileRect):

platform/graphics/chromium/cc/CCLayerTilingData.h:

(WebCore::CCLayerTilingData::hasEmptyBounds):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::isEmpty):

platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::appendQuads):

platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::create):
(WebCore::Texture::updateSubRect):

platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::tileBounds):
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::tileBoundsNormalized):

platform/graphics/gpu/TilingData.h:

(WebCore::TilingData::hasEmptyBounds):
(TilingData):
(WebCore::TilingData::assertTile):

Source/WebKit/chromium:

Add test for updating a huge layer that would assert prior to this
code. Fix up TilingData tests to use a testing class that provides a
safe version of numTiles().

tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

tests/TilingDataTest.cpp:

(TestTiling):
(WebCore::TestTiling::TestTiling):
(WebCore::TestTiling::numTiles):
(WebCore):
(WebCore::TEST):

5:54 PM Changeset in webkit [112480] by enrica@apple.com

2 edits in trunk/LayoutTests

editing/spelling/spellcheck-async-mutation.html is flakey.
https://bugs.webkit.org/show_bug.cgi?id=82555

Mark this test as flakey in test_expectations.

platform/mac/test_expectations.txt:

5:36 PM Changeset in webkit [112479] by enrica@apple.com

2 edits in trunk/LayoutTests

Removed editing/pasteboard/drop-text-without-selection.html from test_expectations
since it now passes consistently.

platform/mac/test_expectations.txt:

5:31 PM Changeset in webkit [112478] by enrica@apple.com

2 edits in trunk/LayoutTests

Added compositing/rtl/rtl-fixed-overflow-scrolled.html to the Mac skipped list, because of
<https://bugs.webkit.org/show_bug.cgi?id=82554> compositing/rtl/rtl-fixed-overflow-scrolled.html fails on
Lion and SnowLeopard.

platform/mac/Skipped:

5:29 PM Changeset in webkit [112477] by commit-queue@webkit.org

2 edits in trunk/Tools

Add dtharp to contributors list
https://bugs.webkit.org/show_bug.cgi?id=82545

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-28
Reviewed by Adam Barth.

Adding dtharp as Contributor.

Scripts/webkitpy/common/config/committers.py:

5:24 PM Changeset in webkit [112476] by Simon Fraser

2 edits in trunk/LayoutTests

Rebaseline this test after the nodes were removed in r112299.

platform/mac/fast/dom/Window/window-properties-expected.txt:

4:57 PM Changeset in webkit [112475] by eae@chromium.org

6 edits in trunk/Source/WebCore

Change FilterOperations::getOutsets to use integers
https://bugs.webkit.org/show_bug.cgi?id=82535

Reviewed by Eric Seidel.

FilterOperations::getOutsets calculates the outsets using integers and
the values are guranteed to be set to full-pixel values. By changing the
function signature we communicate this fact better and avoid unnecessary
type conversions in some cases.

No new tests.

platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::getOutsets):

platform/graphics/filters/FilterOperations.h:

(FilterOperations):

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::addVisualEffectOverflow):

rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):

rendering/style/RenderStyle.h:

4:55 PM Changeset in webkit [112474] by Nate Chapin

34 edits in trunk/Source

Remove dispatchDidLoadMainResource callback, since no
port implements it.
https://bugs.webkit.org/show_bug.cgi?id=82539

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests, just deleting dead code.

loader/EmptyClients.h:

(EmptyFrameLoaderClient):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::finishedLoading):
(WebCore::FrameLoader::mainReceivedCompleteError):

loader/FrameLoaderClient.h:

(FrameLoaderClient):

loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::didCancel):

Source/WebKit/blackberry:

WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

Source/WebKit/chromium:

src/FrameLoaderClientImpl.cpp:

(WebKit):

src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

Source/WebKit/efl:

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore):

WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

Source/WebKit/gtk:

WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit):

WebCoreSupport/FrameLoaderClientGtk.h:

(FrameLoaderClient):

Source/WebKit/mac:

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:
WebKit.order:

Source/WebKit/qt:

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore):

WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

Source/WebKit/win:

WebCoreSupport/WebFrameLoaderClient.cpp:
WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

Source/WebKit/wince:

WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit):

WebCoreSupport/FrameLoaderClientWinCE.h:

(FrameLoaderClientWinCE):

Source/WebKit/wx:

WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore):

WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

4:43 PM Changeset in webkit [112473] by enrica@apple.com

3 edits in trunk/Source/WebCore

REGRESSION: editing/pasteboard/dataTransfer-setData-getData.html fails on Mac platforms.
https://bugs.webkit.org/show_bug.cgi?id=82497
<rdar://problem/11140334>

Reviewed by Brady Eidson.

The revision causing this regression fixed the way data is written to the pasteboard for NSURLPboardType.
This change fixes the way data is read from the pasteboard for the same pasteboard type.

No new tests. Fixes the existing one that fails.

platform/mac/ClipboardMac.mm:

(WebCore::absoluteURLsFromPasteboard):

platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::stringForType):

4:41 PM Changeset in webkit [112472] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

SL bot is hitting SHOULD NEVER BE REACHED in WebCore::valueForLength() on many tests
https://bugs.webkit.org/show_bug.cgi?id=82390

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-28
Reviewed by Simon Fraser.

This is an attempt to fix the MAC SL/Lion Bot issue as this issue is not reproducible locally.
The assertion happened when length type is Undefined in valueForLength() function but the assertion for Undefined length type
in RenderBox::computeLogicalWidthInRegionUsing which calls the above said function did not get hit.

This patch passes Length structure as const reference to Length calculation functions which avoids the call to the copy-constructor.
And it ensures that the Length structure is not getting modified during copy-construction.

css/LengthFunctions.cpp:

(WebCore::minimumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):

css/LengthFunctions.h:

(WebCore):

4:29 PM Changeset in webkit [112471] by eae@chromium.org

4 edits in branches/subpixellayout/Source

Add Node::pixelSnappedRenderRect on subpixel branch.

4:26 PM Changeset in webkit [112470] by commit-queue@webkit.org

2 edits in trunk/Tools

build-webkit : the word "pass" is spelled incorrectly as "passs"
https://bugs.webkit.org/show_bug.cgi?id=82532

Patch by Stuart Eichert <stuart.eichert@palm.com> on 2012-03-28
Reviewed by Julien Chaffraix.

Corrected spelling of the word "pass" in build-webkit.

Scripts/build-webkit:

4:17 PM Changeset in webkit [112469] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Lion tweaks.

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

4:08 PM Changeset in webkit [112468] by Simon Fraser

2 edits in trunk/LayoutTests

compositing/tiling/crash-reparent-tiled-layer.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=82546

Mark this test as flakey in test_expectations

platform/mac/test_expectations.txt:

4:06 PM Changeset in webkit [112467] by dpranke@chromium.org

2 edits in trunk/Source/WebKit/chromium

Roll chromium from 129300 to 129509.

Unreviewed, DEPS change.

DEPS:

4:05 PM Changeset in webkit [112466] by ojan@chromium.org

17 edits
4 moves
49 adds
7 deletes in trunk/LayoutTests

More Chromium rebaselines from the expected failures tab in garden-o-matic.
They all looked like straightforward text-rendering, form-control rendering or anti-aliasing issues,
except for some where the new results were clearly just more correct.

4:00 PM Changeset in webkit [112465] by cevans@google.com

1 edit
2 copies in branches/chromium/1025

Merge 111263
BUG=117698
Review URL: https://chromiumcodereview.appspot.com/9887002

3:56 PM Changeset in webkit [112464] by Simon Fraser

2 edits in trunk/LayoutTests

Remove some more tests from test_expectations.txt, since the pixel test pass.

platform/mac/test_expectations.txt:

3:54 PM Changeset in webkit [112463] by cevans@google.com

1 edit
3 copies in branches/chromium/1025

Merge 111714
BUG=116806
Review URL: https://chromiumcodereview.appspot.com/9896001

3:48 PM Changeset in webkit [112462] by Simon Fraser

2 edits in trunk/LayoutTests

Remove some tests that now pass pixel tests from the list of failures.

platform/mac/test_expectations.txt:

3:43 PM Changeset in webkit [112461] by cevans@google.com

7 edits in branches/chromium/1025

Merge 111098
BUG=118467
Review URL: https://chromiumcodereview.appspot.com/9895001

3:43 PM Changeset in webkit [112460] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Build fix - some compiles generating NORETURN related warnings.

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::setSubpatternStart):
(JSC::Yarr::YarrGenerator::setSubpatternEnd):
(JSC::Yarr::YarrGenerator::clearSubpatternStart):

3:34 PM Changeset in webkit [112459] by cevans@google.com

2 edits in branches/chromium/1025/Source/WebCore

Merge 111775
BUG=117400
Review URL: https://chromiumcodereview.appspot.com/9892004

3:33 PM Changeset in webkit [112458] by dpranke@chromium.org

2 edits in trunk/Tools

new-run-webkit-tests doesn't log correctly after retrying failures
https://bugs.webkit.org/show_bug.cgi?id=82541

Unreviewed, build fix.

r112189 introduced a regression where we would accidentally
delete the log handler after we retried any failing tests - that
meant that any log messages around uploading the results got
dropped.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

3:32 PM Changeset in webkit [112457] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Massive lag opening a link in a new background tab
https://bugs.webkit.org/show_bug.cgi?id=82542
<rdar://problem/11004502>

Reviewed by Sam Weinig.

Defer waiting for the web process to update the page size until we're actually going to display the layer.
This matches what we do in the non-tiled code path.

UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):
(-[WKView updateLayer]):

UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::waitForPossibleGeometryUpdate):

UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

(TiledCoreAnimationDrawingAreaProxy):

UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange):
(WebKit):
(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate):

3:24 PM Changeset in webkit [112456] by kevino@webkit.org

6 edits in trunk

[wx] Unreviewed. Build fix, move WTF back into JSCore target
until issues with JSCore not linking in all WTF symbols are resolved.

3:20 PM Changeset in webkit [112455] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Yarr: if we're not using the output array, don't populate it!
https://bugs.webkit.org/show_bug.cgi?id=82519

Reviewed by Sam Weinig.

runtime/RegExp.cpp:

(JSC):

Missed review comment! - didn't fully remove RegExpRepresentation.

3:18 PM Changeset in webkit [112454] by barraclough@apple.com

14 edits
3 adds in trunk/Source

Yarr: if we're not using the output array, don't populate it!
https://bugs.webkit.org/show_bug.cgi?id=82519

Reviewed by Sam Weinig.

../JavaScriptCore:

Add a new variant of the match method to RegExp that returns a MatchResult,
and modify YarrJIT to be able to compile code that doesn't use an output vector.

This is a 3% progression on v8-regexp.

JavaScriptCore.xcodeproj/project.pbxproj:
- Moved MatchResult into its own header.
assembler/AbstractMacroAssembler.h:
- Added missing include.
runtime/MatchResult.h: Added.

(MatchResult::MatchResult):
(MatchResult):
(MatchResult::failed):
(MatchResult::operator bool):
(MatchResult::empty):

Moved MatchResult into its own header.

runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::compileIfNecessary):
(JSC::RegExp::match):

Changed due to execute & representation changes.

(JSC::RegExp::compileMatchOnly):
(JSC::RegExp::compileIfNecessaryMatchOnly):

Added helper to compile MatchOnly code.

(JSC::RegExp::invalidateCode):
(JSC::RegExp::matchCompareWithInterpreter):
(JSC::RegExp::printTraceData):

Changed due representation changes.

runtime/RegExp.h:

(RegExp):
(JSC::RegExp::hasCode):

Made YarrCodeBlock a member.

runtime/RegExpConstructor.h:

(RegExpConstructor):
(JSC::RegExpConstructor::performMatch):

Added no-ovector form.

runtime/RegExpMatchesArray.cpp:

(JSC::RegExpMatchesArray::reifyAllProperties):

Match now takes a reference to ovector, not a pointer.

runtime/RegExpObject.h:

(JSC):

Moved MatchResult into its own header.

runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

Match now takes a reference to ovector, not a pointer.

testRegExp.cpp:

(testOneRegExp):

Match now takes a reference to ovector, not a pointer.

yarr/YarrJIT.cpp:

(Yarr):
(YarrGenerator):
(JSC::Yarr::YarrGenerator::initCallFrame):
(JSC::Yarr::YarrGenerator::removeCallFrame):
(JSC::Yarr::YarrGenerator::setSubpatternStart):
(JSC::Yarr::YarrGenerator::setSubpatternEnd):
(JSC::Yarr::YarrGenerator::clearSubpatternStart):
(JSC::Yarr::YarrGenerator::setMatchStart):
(JSC::Yarr::YarrGenerator::getMatchStart):

Added helper functions to intermediate access to output.

(JSC::Yarr::YarrGenerator::generateDotStarEnclosure):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::compile):

Changed to use the new helpers, only generate subpatterns if IncludeSubpatterns.

(JSC::Yarr::jitCompile):

Needs to template of MatchOnly or IncludeSubpatterns.

yarr/YarrJIT.h:

(YarrCodeBlock):
(JSC::Yarr::YarrCodeBlock::set8BitCode):
(JSC::Yarr::YarrCodeBlock::set16BitCode):
(JSC::Yarr::YarrCodeBlock::has8BitCodeMatchOnly):
(JSC::Yarr::YarrCodeBlock::has16BitCodeMatchOnly):
(JSC::Yarr::YarrCodeBlock::set8BitCodeMatchOnly):
(JSC::Yarr::YarrCodeBlock::set16BitCodeMatchOnly):
(JSC::Yarr::YarrCodeBlock::execute):
(JSC::Yarr::YarrCodeBlock::clear):

Added a second set of CodeRefs, so that we can compile RexExps with/without subpattern matching.

../WebCore:

ForwardingHeaders/runtime/MatchResult.h: Added.
ForwardingHeaders/yarr/YarrJIT.h: Added.
- Added forwarding headers.

3:15 PM Changeset in webkit [112453] by hyatt@apple.com

71 edits
4 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=81685

[New Multicolumn] Add RenderMultiColumnFlowThread to hold the flow thread contents of a multi-column block.
It derives from RenderFlowThread.

Refactor RenderFlowThread to split out the stuff related to explicit naming into a subclass, RenderNamedFlowThread.
This allows RenderFlowThread to be a simple base class that involves maintaining the regions themselves.

Reviewed by Julien Chaffraix.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:
dom/NodeRenderingContext.cpp:
dom/NodeRenderingContext.h:

(WebCore):
(WebCore::NodeRenderingContext::parentFlowRenderer):

dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::WebKitNamedFlow):

dom/WebKitNamedFlow.h:

(WebCore):
(WebCore::WebKitNamedFlow::create):
(WebKitNamedFlow):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseAnonymousBoxChild):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):

rendering/RenderFlowThread.h:

(WebCore):

rendering/RenderMultiColumnFlowThread.cpp: Added.

(WebCore):
(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
(WebCore::RenderMultiColumnFlowThread::renderName):

rendering/RenderMultiColumnFlowThread.h: Added.

(WebCore):
(RenderMultiColumnFlowThread):

rendering/RenderNamedFlowThread.cpp: Added.

(WebCore):
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::renderName):
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::addFlowChild):
(WebCore::RenderNamedFlowThread::removeFlowChild):
(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::compareRenderRegions):
(WebCore::RenderNamedFlowThread::addRegionToThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):
(WebCore::RenderNamedFlowThread::addDependencyOnFlowThread):
(WebCore::RenderNamedFlowThread::removeDependencyOnFlowThread):
(WebCore::RenderNamedFlowThread::pushDependencies):
(WebCore::RenderNamedFlowThread::ensureNamedFlow):

rendering/RenderNamedFlowThread.h: Added.

(WebCore):
(RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::name):
(WebCore::RenderNamedFlowThread::hasChildren):
(WebCore::RenderNamedFlowThread::hasChild):
(WebCore::RenderNamedFlowThread::isRenderNamedFlowThread):
(WebCore::toRenderNamedFlowThread):

rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

rendering/RenderObject.h:

(WebCore::RenderObject::isRenderNamedFlowThread):

rendering/RenderObjectChildList.cpp:

(WebCore::renderNamedFlowThreadContainer):
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::attachRegion):

rendering/RenderRegion.h:

(WebCore):
(WebCore::RenderRegion::parentNamedFlowThread):
(RenderRegion):

rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderNamedFlowThreads):
(WebCore::writeLayers):

rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::styleDidChange):
(WebCore::RenderView::ensureRenderFlowThreadWithName):
(WebCore::RenderView::layoutRenderNamedFlowThreads):

rendering/RenderView.h:

(WebCore):
(RenderView):
(WebCore::RenderView::hasRenderNamedFlowThreads):
(WebCore::RenderView::isRenderNamedFlowThreadOrderDirty):
(WebCore::RenderView::setIsRenderNamedFlowThreadOrderDirty):
(WebCore::RenderView::renderNamedFlowThreadList):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=81685

[New Multicolumn] Add RenderMultiColumnFlowThread to hold the flow thread contents of a multi-column block.
It derives from RenderFlowThread.

Change layout test results to reflect the name change from RenderFlowThread to
RenderNamedFlowThread. Other platforms should update results accordingly.

Reviewed by Julien Chaffraix.

fast/repaint/inline-relative-positioned-expected.txt:
fast/repaint/overflow-clip-subtree-layout-expected.txt:
fast/repaint/subtree-root-clip-2-expected.txt:
fast/repaint/subtree-root-clip-3-expected.txt:
fast/repaint/subtree-root-clip-expected.txt:
platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
platform/mac/fast/regions/flow-content-basic-expected.txt:
platform/mac/fast/regions/flow-content-basic-vertical-expected.txt:
platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt:
platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt:
platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt:
platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt:
platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.txt:
platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt:
platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt:
platform/mac/fast/regions/region-overflow-break-expected.txt:
platform/mac/fast/regions/region-style-block-background-color-expected.txt:
platform/mac/fast/regions/region-style-block-background-color2-expected.txt:
platform/mac/fast/regions/region-style-image-background-color-expected.txt:
platform/mac/fast/regions/region-style-inline-background-color-expected.txt:
platform/mac/fast/regions/render-region-custom-style-mark-expected.txt:
platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt:
platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt:
platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
platform/mac/fast/repaint/region-painting-invalidation-expected.txt:
platform/mac/fast/repaint/region-painting-via-layout-expected.txt:
platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
platform/qt/fast/repaint/region-painting-invalidation-expected.txt:
platform/qt/fast/repaint/region-painting-via-layout-expected.txt:
platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:

3:12 PM Changeset in webkit [112452] by eae@chromium.org

2 edits in branches/subpixellayout/Source/WebCore

Cleanup RenderLayer and mac dom bindings on subpixel branch

3:11 PM Changeset in webkit [112451] by cevans@google.com

1 edit in branches/chromium/1025/Source/WebCore/dom/ContainerNode.cpp

Merge 110150
BUG=117400
Review URL: https://chromiumcodereview.appspot.com/9854037

3:09 PM Changeset in webkit [112450] by eae@chromium.org

2 edits in trunk/Source/WebCore

Remove unnecessary rounding in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=82529

Reviewed by Eric Seidel.

Remove rounding that is no longer required now that borderBoxRect returns
an IntRect.

No new tests.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

3:07 PM Changeset in webkit [112449] by enne@google.com

12 edits in trunk/Source

Unreviewed, rolling out r112432.
http://trac.webkit.org/changeset/112432
https://bugs.webkit.org/show_bug.cgi?id=82536

Causes ccs3 layout test asserts (Requested by enne on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-28

Source/WebCore:

platform/graphics/chromium/TiledLayerChromium.cpp:

platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::tileRect):

platform/graphics/chromium/cc/CCLayerTilingData.h:

(WebCore::CCLayerTilingData::numTiles):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::isEmpty):

platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::appendQuads):

platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::platformApplySoftware):

platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::create):
(WebCore::Texture::updateSubRect):

platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::tileBounds):
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::tileBoundsNormalized):
(WebCore::TilingData::intersectDrawQuad):
(WebCore):

platform/graphics/gpu/TilingData.h:

(WebCore::TilingData::numTiles):
(WebCore::TilingData::tileIndex):
(WebCore::TilingData::tileXIndex):
(WebCore::TilingData::tileYIndex):
(TilingData):
(WebCore::TilingData::assertTile):

Source/WebKit/chromium:

tests/TiledLayerChromiumTest.cpp:
tests/TilingDataTest.cpp:

(WebCore::TEST):

3:03 PM Changeset in webkit [112448] by dcheng@chromium.org

7 edits
2 moves
2 deletes in trunk/Source

[chromium] Merge ChromiumDataObject and DataTransferItemListChromium.
https://bugs.webkit.org/show_bug.cgi?id=82407

Reviewed by Tony Chang.

Source/WebCore:

Since ChromiumDataObject is just a very thin wrapper for DataTransferItemListChromium now,
combine the two and remove a layer of indirection.

No functionality change, should be covered by existing tests.

WebCore.gypi:
platform/chromium/ChromiumDataObject.cpp: Replacing DataTransferItemListChromium.

(WebCore::ChromiumDataObject::createFromPasteboard):
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::length):
(WebCore):
(WebCore::ChromiumDataObject::item):
(WebCore::ChromiumDataObject::deleteItem):
(WebCore::ChromiumDataObject::clearAll):
(WebCore::ChromiumDataObject::add):
(WebCore::ChromiumDataObject::clearData):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::setData):
(WebCore::ChromiumDataObject::urlAndTitle):
(WebCore::ChromiumDataObject::setURLAndTitle):
(WebCore::ChromiumDataObject::htmlAndBaseURL):
(WebCore::ChromiumDataObject::setHTMLAndBaseURL):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore::ChromiumDataObject::filenames):
(WebCore::ChromiumDataObject::addFilename):
(WebCore::ChromiumDataObject::addSharedBuffer):
(WebCore::ChromiumDataObject::ChromiumDataObject):
(WebCore::ChromiumDataObject::findStringItem):
(WebCore::ChromiumDataObject::internalAddStringItem):
(WebCore::ChromiumDataObject::internalAddFileItem):

platform/chromium/ChromiumDataObject.h:

(WebCore):
(ChromiumDataObject):

platform/chromium/ChromiumDataObjectItem.cpp: Renamed from Source/WebCore/platform/chromium/DataTransferItemChromium.cpp.

(WebCore):
(WebCore::ChromiumDataObjectItem::createFromString):
(WebCore::ChromiumDataObjectItem::createFromFile):
(WebCore::ChromiumDataObjectItem::createFromURL):
(WebCore::ChromiumDataObjectItem::createFromHTML):
(WebCore::ChromiumDataObjectItem::createFromSharedBuffer):
(WebCore::ChromiumDataObjectItem::createFromPasteboard):
(WebCore::ChromiumDataObjectItem::ChromiumDataObjectItem):
(WebCore::ChromiumDataObjectItem::getAsString):
(WebCore::ChromiumDataObjectItem::getAsFile):
(WebCore::ChromiumDataObjectItem::internalGetAsString):
(WebCore::ChromiumDataObjectItem::isFilename):

platform/chromium/ChromiumDataObjectItem.h: Renamed from Source/WebCore/platform/chromium/DataTransferItemChromium.h.

(WebCore):
(ChromiumDataObjectItem):
(WebCore::ChromiumDataObjectItem::kind):
(WebCore::ChromiumDataObjectItem::type):
(WebCore::ChromiumDataObjectItem::sharedBuffer):
(WebCore::ChromiumDataObjectItem::title):
(WebCore::ChromiumDataObjectItem::baseURL):

platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::files):
(WebCore::ClipboardChromium::hasData):
(WebCore::ClipboardChromium::items):

platform/chromium/DataTransferItemListChromium.cpp: Removed.
platform/chromium/DataTransferItemListChromium.h: Removed.

Source/WebKit/chromium:

src/WebDragData.cpp:

(WebKit::WebDragData::items):

3:00 PM Changeset in webkit [112447] by jam@chromium.org

1 edit in trunk/LayoutTests/platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt

Unreviewed rebaseline

2:45 PM Changeset in webkit [112446] by nduca@chromium.org

11 edits in trunk/Source

[chromium] Scheduler should not tell FrameRateController to begin a frame when we dont swap
https://bugs.webkit.org/show_bug.cgi?id=82516

Reviewed by James Robinson.

Source/WebCore:

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::swapBuffers):

platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::swapBuffers):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::processScheduledActions):

platform/graphics/chromium/cc/CCScheduler.h:

(WebCore::CCScheduledActionDrawAndSwapResult::CCScheduledActionDrawAndSwapResult):
(CCScheduledActionDrawAndSwapResult):
(WebCore):
(CCSchedulerClient):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapIfPossible):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapForced):

platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

tests/CCSchedulerTest.cpp:

(WebKitTests::FakeCCSchedulerClient::reset):
(WebKitTests::FakeCCSchedulerClient::hasAction):
(FakeCCSchedulerClient):
(WebKitTests::FakeCCSchedulerClient::scheduledActionDrawAndSwapIfPossible):
(WebKitTests::FakeCCSchedulerClient::scheduledActionDrawAndSwapForced):
(WebKitTests::FakeCCSchedulerClient::setDrawWillHappen):
(WebKitTests::FakeCCSchedulerClient::setSwapWillHappenIfDrawHappens):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionDrawAndSwapIfPossible):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionDrawAndSwapForced):
(SchedulerClientThatSetNeedsDrawInsideDraw):
(WebKitTests::TEST):
(WebKitTests::SchedulerClientThatSetNeedsCommitInsideDraw::scheduledActionDrawAndSwapIfPossible):
(WebKitTests::SchedulerClientThatSetNeedsCommitInsideDraw::scheduledActionDrawAndSwapForced):
(SchedulerClientThatSetNeedsCommitInsideDraw):
(WebKitTests):

2:43 PM Changeset in webkit [112445] by ericu@chromium.org

3 edits in trunk/Source/WebCore

FileWriter has two race conditions
https://bugs.webkit.org/show_bug.cgi?id=81861

Reviewed by David Levin.

Should make current tests less flaky.

Modules/filesystem/FileWriter.h:
Modules/filesystem/FileWriter.cpp:

Track the in-flight operation, whether it be an abort/write/truncate.
Whether an abort comes back as didWrite, didTruncate, or didFail, handle
it appropriately. Before this fix, the Chromium implementation would
assert in two cases:

If the user calls abort, then write, then abort before the backend
catches up, we'd send both aborts to the backend, even though it hadn't
received the write yet. Chromium's backend asserts if there's an abort
with no write in progress. We now record that we've sent an abort and
are waiting for the response.

If the user calls abort while a write/truncate is just finishing, on the
Chromium worker implementation, the completion message could be
thread-hopping back to WebCore at the
WorkerAsyncFileWriterCallbacksBridge while the abort is thread-hopping
in the other direction. Again, this leads to an abort call to the
backend with no write in progress, and an assert. We're now robust to
completions coming back when we're expecting an abort, and
https://chromiumcodereview.appspot.com/9764018/ will make the backend
robust to extra abort calls.

2:41 PM Changeset in webkit [112444] by rniwa@webkit.org

14 edits
2 moves
2 deletes in trunk

Deleting a paragraph of text should not add elements for typing style
https://bugs.webkit.org/show_bug.cgi?id=82401

Reviewed by Enrica Casucci.

Source/WebCore:

This behavior was explicitly supported by DeleteSelectionCommand but it doesn't match TextEdit or Firefox.
We're changing our behavior to match TextEdit and Firefox in this patch.

The behavior is tested by an existing test, which was renamed to deleting-text-rests-typing-style.html in this patch.

Test: editing/execCommand/deleting-text-rests-typing-style.html

editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):

LayoutTests:

Rebaselined the tests per behavior changes. Also renamed 19653-3.html to deleting-text-rests-typing-style.html
which tests this behavioral change.

editing/deleting/delete-and-cleanup-expected.txt:
editing/deleting/delete-and-cleanup.html: Elements added for typing styles have been removed.
editing/deleting/delete-br-012-expected.txt: Ditto.
editing/deleting/delete-select-all-001-expected.txt: Ditto.
editing/execCommand/19653-3-expected.txt: Removed.
editing/execCommand/19653-3.html: Removed.
editing/execCommand/apply-style-text-decoration-crash-expected.txt:
editing/execCommand/delete-image-in-anchor-expected.txt: Ditto.
editing/execCommand/deleting-text-rests-typing-style-expected.txt: Copied from LayoutTests/editing/execCommand/19653-3-expected.txt.
editing/execCommand/deleting-text-rests-typing-style.html: Copied from LayoutTests/editing/execCommand/19653-3.html.
editing/inserting/5994480-2-expected.txt:
editing/inserting/5994480-2.html: Ditto; converted this test to a dump-as-markup test for clarity.
editing/pasteboard/paste-text-with-style-2-expected.txt: Elements added for typing styles have been removed.
editing/style/block-style-005-expected.txt: Ditto.
editing/pasteboard/select-element-1-expected.txt: Editing delegate dump changed but the final result remains intact.

2:33 PM Changeset in webkit [112443] by Simon Fraser

3 edits in trunk/Tools

download-built-product build step should detect 404 errors
https://bugs.webkit.org/show_bug.cgi?id=82491

Reviewed by Ryosuke Niwa.

Pass --fail to curl so that it reports 404 errors.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(DownloadBuiltProduct): Pass --fail to curl so that it reports errors.

BuildSlaveSupport/built-product-archive:

(extractBuiltProduct): Remove trailing whitespace.

2:29 PM Changeset in webkit [112442] by dpranke@chromium.org

2 edits in trunk/Tools

flakiness dashboard should only keep the last 500 runs
https://bugs.webkit.org/show_bug.cgi?id=82530

Reviewed by Ojan Vafai.

If a bot has an overly large amount of failing tests, then
storing 750 runs' worth takes a lot of memory and CPU time to
process and we end up getting killed by AppEngine; this cases
data corruption and confusion down the road when we have to
retry the upload of the data and the tests show up as multiple
runs.

TestResultServer/model/jsonresults.py:

(JsonResults.update_file):

2:26 PM Changeset in webkit [112441] by ojan@chromium.org

15 edits
2 copies
4 moves
28 adds in trunk/LayoutTests

More Chromium rebaselines from the expected failures tab in garden-o-matic.
They all looked like straightforward text-rendering or anti-aliasing issues,
except for some where the new results were clearly just more correct.

fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Copied from LayoutTests/platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png.
platform/chromium-linux/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
platform/chromium-linux/fast/dynamic/containing-block-change-expected.png: Added.
platform/chromium-linux/fast/dynamic/first-letter-display-change-expected.png: Added.
platform/chromium-linux/fast/dynamic/window-resize-scrollbars-test-expected.png:
platform/chromium-linux/fast/events/updateLayoutForHitTest-expected.png: Renamed from LayoutTests/platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png.
platform/chromium-linux/fast/events/updateLayoutForHitTest-expected.txt: Added.
platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
platform/chromium-mac-leopard/fast/dom/getElementsByClassName/011-expected.txt: Added.
platform/chromium-mac-leopard/fast/dynamic/containing-block-change-expected.png: Added.
platform/chromium-mac-leopard/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
platform/chromium-mac-leopard/fast/events/updateLayoutForHitTest-expected.png: Added.
platform/chromium-mac-snowleopard/fast/dom/52776-expected.png:
platform/chromium-mac-snowleopard/fast/dom/52776-expected.txt:
platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
platform/chromium-mac-snowleopard/fast/dynamic/containing-block-change-expected.png: Added.
platform/chromium-mac-snowleopard/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png:
platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png:
platform/chromium-mac-snowleopard/fast/events/reveal-link-when-focused-expected.png:
platform/chromium-mac-snowleopard/fast/events/updateLayoutForHitTest-expected.png: Added.
platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
platform/chromium-mac/fast/dynamic/containing-block-change-expected.png: Added.
platform/chromium-mac/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
platform/chromium-mac/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png: Added.
platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.txt: Added.
platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png: Added.
platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.txt: Added.
platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Added.
platform/chromium-mac/fast/events/updateLayoutForHitTest-expected.png: Added.
platform/chromium-mac/fast/events/updateLayoutForHitTest-expected.txt: Added.
platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
platform/chromium-win/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Renamed from LayoutTests/platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png.
platform/chromium-win/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
platform/chromium-win/fast/dynamic/containing-block-change-expected.png: Added.
platform/chromium-win/fast/dynamic/containing-block-change-expected.txt: Added.
platform/chromium-win/fast/dynamic/first-letter-display-change-expected.png: Added.
platform/chromium-win/fast/dynamic/window-resize-scrollbars-test-expected.png:
platform/chromium-win/fast/dynamic/window-resize-scrollbars-test-expected.txt:
platform/chromium/fast/dom/Window/get-set-properties-expected.txt:
platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Copied from LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt.
platform/chromium/fast/dom/Window/window-property-shadowing-expected.txt:
platform/chromium/test_expectations.txt:
platform/efl/fast/dom/Window/window-property-descriptors-expected.txt: Renamed from LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt.
platform/mac/fast/dynamic/first-letter-display-change-expected.txt: Renamed from LayoutTests/fast/dynamic/first-letter-display-change-expected.txt.

2:21 PM Changeset in webkit [112440] by rniwa@webkit.org

2 edits in trunk/Tools

extract-built-product build step should fail if unzipping fails
https://bugs.webkit.org/show_bug.cgi?id=82493

Reviewed by Simon Fraser.

Forward non-zero exit code from subprocesses so that the master can detect any failures
and bail out early.

BuildSlaveSupport/built-product-archive:

(main):

2:18 PM Changeset in webkit [112439] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] Add tracing events around CCLayerTreeHostImpl visibility.
https://bugs.webkit.org/show_bug.cgi?id=82501

Patch by Michal Mocny <mmocny@google.com> on 2012-03-28
Reviewed by James Robinson.

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):

2:00 PM Changeset in webkit [112438] by commit-queue@webkit.org

3 edits
2 adds in trunk

Incorrect foreignObject hit test results when overlapping other SVG elements
https://bugs.webkit.org/show_bug.cgi?id=82059

Patch by Florin Malita <fmalita@google.com> on 2012-03-28
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/hittest/foreign-object-background.svg

Foreign content needs to be hit-tested atomically due to the (pseudo)
stacking context established by FOs.

rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
Hit test all phases on FO HitTestForeground.

LayoutTests:

svg/hittest/foreign-object-background-expected.txt: Added.
svg/hittest/foreign-object-background.svg: Added.

1:59 PM Changeset in webkit [112437] by dpranke@chromium.org

5 edits in trunk/Tools

test-webkitpy should support files, directories, and packages as command line args
https://bugs.webkit.org/show_bug.cgi?id=76765

Reviewed by Adam Barth.

This patch adds support for specifying files, directories, and
packages to test-webkitpy along with the already existing
support for modules, test classes, and individual test names.

Also, fix a bug in filesystem_mock where we wouldn't normalize a
path containing a reference to the current directory properly,
for example, '/foo/./bar.py'.

Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.normpath):

Scripts/webkitpy/test/main.py:

(Tester._configure_logging):
(Tester._run_tests):

Scripts/webkitpy/test/test_finder.py:

(TestDirectoryTree.find_modules):
(TestDirectoryTree.subpath):
(TestFinder.is_dotted_name):
(TestFinder.find_names):
(TestFinder):
(TestFinder._find_names_for_arg):
(TestFinder._find_in_trees):
(TestFinder._default_names):

Scripts/webkitpy/test/test_finder_unittest.py:

(TestFinderTest.setUp):
(TestFinderTest.tearDown):
(TestFinderTest.check_names):
(TestFinderTest.test_default_names):
(TestFinderTest):
(TestFinderTest.test_paths):

1:42 PM Changeset in webkit [112436] by shawnsingh@chromium.org

11 edits in trunk

[chromium] layer->clipRect() is not initialized for layers that create a renderSurface.
https://bugs.webkit.org/show_bug.cgi?id=74147

Reviewed by Adrienne Walker.

Source/WebCore:

Added 3 additional unit tests; Modified existing unit tests and layout tests.

The layer's clipRect and usesLayerClipping information was not
being initialized for layers that created a renderSurface. (It
was, however, being initialized for the renderSurface itself.)
This patch adds a unit test that reproduces that this is an error,
other unit tests to tightly test the value of clipRect being
initialized, and adds the logic to properly initialize the
clipRect.

Before this patch, this bug was causing flashing on tab-switch on
the apple iphone page. Even worse, with partial swap enabled, the
layers would simply disappear, because the first frame the
clipRect is uninitialized and the layer is not drawn, and the
second frame onwards, the damage tracker correctly things nothing
is damaged, so it doesn't draw that layer again until other damage
causes it to be redrawn.

platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

Added 3 more unit tests. One reproduces the clipRect problem in an
integrated manner, the other two directly test that clipRects are
properly initialized.

tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):
(WebCore):

tests/CCLayerTreeTestCommon.h:

(WebKitTests):

LayoutTests:

platform/chromium/test_expectations.txt: marked test as needing rebaselining

1:41 PM Changeset in webkit [112435] by Simon Fraser

3 edits in trunk/Tools

Fix inspector tests when running in internal builds.

<rdar://problem/11050694>

Reviewed by Tim Hatcher.

DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

1:36 PM Changeset in webkit [112434] by andersca@apple.com

5 edits in trunk/Source/WebCore

"Sticky" or slow scrolling on some sites
https://bugs.webkit.org/show_bug.cgi?id=82512
<rdar://problem/11000372>

Reviewed by Andreas Kling.

When we're in the slow mode and have to update the scroll layer position on the main thread,
get it from the scrolling thread so we'll be in sync with the scrolling tree when the main thread is busy.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):

page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::mainFrameScrollPosition):
(WebCore):
(WebCore::ScrollingTree::updateMainFrameScrollPositionAndScrollLayerPosition):

page/scrolling/ScrollingTree.h:

1:29 PM Changeset in webkit [112433] by jam@chromium.org

2 edits in trunk/LayoutTests

[chromium] Update worker-multi-port-expected.txt.

https://bugs.webkit.org/show_bug.cgi?id=82499

Reviewed by James Robinson.

platform/chromium-win/fast/workers/worker-multi-port-expected.txt:

1:20 PM Changeset in webkit [112432] by enne@google.com

12 edits in trunk/Source

[chromium] Fix tiled layer assert for huge layers
https://bugs.webkit.org/show_bug.cgi?id=82486

Reviewed by James Robinson.

Source/WebCore:

Test: TiledLayerChromiumTest.hugeLayerUpdateCrash

Additionally, TilingData::numTiles() has long been a confusing
function name in some contexts, so rename to bool hasEmptyBounds().

Also, remove TilingData::intersectDrawQuad because there are no
clients of that function.

platform/graphics/chromium/TiledLayerChromium.cpp:

platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::tileRect):

platform/graphics/chromium/cc/CCLayerTilingData.h:

(WebCore::CCLayerTilingData::hasEmptyBounds):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::isEmpty):

platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::appendQuads):

platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::create):
(WebCore::Texture::updateSubRect):

platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::tileBounds):
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::tileBoundsNormalized):

platform/graphics/gpu/TilingData.h:

(WebCore::TilingData::hasEmptyBounds):
(TilingData):
(WebCore::TilingData::assertTile):

Source/WebKit/chromium:

Add test for updating a huge layer that would assert prior to this
code. Fix up TilingData tests to use a testing class that provides a
safe version of numTiles().

tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

tests/TilingDataTest.cpp:

(TestTiling):
(WebCore::TestTiling::TestTiling):
(WebCore::TestTiling::numTiles):
(WebCore):
(WebCore::TEST):

1:13 PM Changeset in webkit [112431] by ddkilzer@apple.com

4 edits in trunk/Tools

Use xcrun to find nm and ranlib on OS X builds
<http://webkit.org/b/82466>

Reviewed by Dan Bernstein.

Scripts/build-webkit: Use xcrun to find ranlib.
Scripts/webkitdirs.pm:

(determineNmPath): Added. Use xcrun to find nm on OS X.
(nmPath): Added.

Scripts/webkitperl/features.pm:

(libraryContainsSymbol): Use nmPath().

12:58 PM Changeset in webkit [112430] by kerz@chromium.org

1 copy in branches/chromium/1084/codereview.settings

Codereview settings for the branch.

12:56 PM Changeset in webkit [112429] by dpranke@chromium.org

2 edits in trunk/LayoutTests

More flaky tests.

Unreviewed, expectations update.

platform/chromium/test_expectations.txt:

12:44 PM Changeset in webkit [112428] by vsevik@chromium.org

18 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: switch Runtime, Network and DOM domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=81558

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-28
Reviewed by Pavel Feldman.

Client code is switched to typed API (all InspectorObject and InspectorArray types are
replaced with generated types from TypeBuilder according to Inspector.json).

Missing array of int specialization is added. Code generator now has a check against
misspelled (non-existing) domain names.

inspector/CodeGeneratorInspector.py:

(Generator.go): check against misspelled domain names added.

inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapNode):
(WebCore::InjectedScript::wrapSerializedObject):
(WebCore::InjectedScript::makeEvalCall):

inspector/InjectedScript.h:

(InjectedScript):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
(WebCore::InspectorDOMAgent::loadEventFired):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::styleAttributeInvalidated):
(WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):

inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::resourceTypeJson):
(WebCore::InspectorPageAgent::cachedResourceTypeJson):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

inspector/InspectorPageAgent.h:
inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForResourceRequest):
(WebCore::buildObjectForResourceResponse):
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::buildInitiatorObject):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):

inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):

inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

inspector/InspectorValues.h:

(InspectorArray):
(WebCore::InspectorArray::pushInt):
(WebCore):

inspector/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::buildInspectorObject):

inspector/ScriptCallFrame.h:

(ScriptCallFrame):

inspector/ScriptCallStack.cpp:

(WebCore::ScriptCallStack::buildInspectorArray):

inspector/ScriptCallStack.h:

(ScriptCallStack):

12:30 PM Changeset in webkit [112427] by jamesr@google.com

11 edits in branches/chromium/1084/Source/WebCore

Revert 112163 - Use PassRefPtr in V8DOMWrapper interface to avoid explicit ref() calls
https://bugs.webkit.org/show_bug.cgi?id=82238

Reviewed by Adam Barth.

The setJSWrapper* methods previously featured a comment that asked
callers to ref the objects before passing them in. This change makes
that contract explicit (and allows the removal of the comment).

In addition, for ConstructorCallbacks, this change slightly reduces
refcount churn by passing on the initial ref via RefPtr::release().

No new tests, no change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref() call.
(GenerateNamedConstructorCallback): ditto.

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow): Cast to a PassRefPtr and remove explicit ref call.

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Pass leaked refs into the DOMNodeMaps.

bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper): Make the setJSWrapperFor* methods take PassRefPtr<T>.
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Pass leaked ref into the DOMObjectMap.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): Pass leaked ref into the ActiveDOMObjectMap.

bindings/v8/V8Proxy.h:

(WebCore::toV8): Remove explicit ref.

bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Cast to a PassRefPTr and remove explicit ref call.

bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref.

bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback): ditto.

bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback): ditto.

bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback): ditto.

TBR=adamk@chromium.org

12:29 PM April 2012 Meeting edited by rniwa@webkit.org

Add more topics (diff)

12:28 PM Changeset in webkit [112426] by jamesr@google.com

14 edits in branches/chromium/1084/Source/WebCore

Revert http://trac.webkit.org/changeset/112318

12:25 PM Changeset in webkit [112425] by eric@webkit.org

22 edits in trunk/Source/WebCore

setNeedsLayout(true, false) is super confusing to read and should use an enum instead
https://bugs.webkit.org/show_bug.cgi?id=82369

Reviewed by Julien Chaffraix.

I replaced all uses of the markParents bool with a MarkingBehavior
enum (which has two values: MarkContainingBlockChain and MarkOnlyThis).
I'm not sure the naming is perfect (as it's not clear to me if markParents is
used to mean the same thing in these 3 functions), but hopefully this code is more
clear. I welcome further suggested adjustment from layout experts.

page/FrameView.cpp:

(WebCore::FrameView::scheduleRelayout):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::removePositionedObjects):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::adjustBlockChildForPagination):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::positionNewFloatOnLine):

rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox):

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):

rendering/RenderMedia.cpp:

(WebCore::RenderMedia::layout):

rendering/RenderObject.cpp:

(WebCore::RenderObject::setPreferredLogicalWidthsDirty):

rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):

rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layoutSpecialExcludedChild):

rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::layoutSpecialExcludedChild):

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):

rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::layout):

rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::layout):

rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::layoutChildren):

12:22 PM Changeset in webkit [112424] by commit-queue@webkit.org

9 edits in trunk/Source

<http://webkit.org/b/82419> Web Inspector: Create -[DOMNode inspect] from IDL

Source/WebCore:

Instead of manually creating the method in DOM.mm we can specify it in
Node.idl and autogenerate part of the interface.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-03-28
Reviewed by Timothy Hatcher.

bindings/objc/DOM.mm:
bindings/objc/DOMPrivate.h:

Move the call to InspectorController::inspect from here ...

dom/Node.h:
dom/Node.idl: IDL only in an ObjC block.
dom/Node.cpp:

(WebCore::Node::inspect):
... to here.

WebCore.xcodeproj/project.pbxproj:

Add the new generated file so we can Copy it in the build phase.

Source/WebKit/mac:

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-03-28
Reviewed by Timothy Hatcher.

MigrateHeaders.make: Copy DOMNodePrivate.h to PrivateHeaders.

12:19 PM Changeset in webkit [112423] by ojan@chromium.org

5 edits in trunk/Tools

Add history navigation to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=82495

Reviewed by Dimitri Glazkov.

Also, maintain scroll offsets when returning to a tab. This makes addressing
expected failures considerably easier when dealing with below-the-fold tests.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:

-Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
switching.
-Modify window.location with the tabName in the hash. Can't use pushState because this is served
from a file URL and Chrome puts each different file URL in it's own origin.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

Remove the href so that clicking on the accordion item does not modify window.location.hash.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

11:49 AM Changeset in webkit [112422] by kerz@chromium.org

1 copy in branches/chromium/1084

Branching for 1084

11:44 AM Changeset in webkit [112421] by tommyw@google.com

7 edits
1 copy
4 adds in trunk/Source

[chromium] MediaStream API (JSEP): Introducing WebPeerConnection00Handler
https://bugs.webkit.org/show_bug.cgi?id=82450

Reviewed by Adam Barth.

Source/WebCore:

This change removes the default PeerConnection00Handler.cpp from the Chromium build.

A major overhaul of the existing layout tests is forthcoming.

WebCore.gypi:
platform/mediastream/PeerConnection00Handler.h:

(WebCore):
(PeerConnection00Handler):

Source/WebKit/chromium:

Last patch to enable the PeerConnection00 functionality in Chromium introduces
WebPeerConnection00Handler and WebPeerConnection00HandlerClient, together with the necessary plumbing.

WebKit.gyp:
bridge/PeerConnection00Handler.cpp: Added.

(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):

bridge/PeerConnection00HandlerInternal.cpp: Added.

(WebCore):
(WebCore::PeerConnection00HandlerInternal::PeerConnection00HandlerInternal):
(WebCore::PeerConnection00HandlerInternal::~PeerConnection00HandlerInternal):
(WebCore::PeerConnection00HandlerInternal::createOffer):
(WebCore::PeerConnection00HandlerInternal::createAnswer):
(WebCore::PeerConnection00HandlerInternal::setLocalDescription):
(WebCore::PeerConnection00HandlerInternal::setRemoteDescription):
(WebCore::PeerConnection00HandlerInternal::localDescription):
(WebCore::PeerConnection00HandlerInternal::remoteDescription):
(WebCore::PeerConnection00HandlerInternal::startIce):
(WebCore::PeerConnection00HandlerInternal::processIceMessage):
(WebCore::PeerConnection00HandlerInternal::addStream):
(WebCore::PeerConnection00HandlerInternal::removeStream):
(WebCore::PeerConnection00HandlerInternal::stop):
(WebCore::PeerConnection00HandlerInternal::didGenerateICECandidate):
(WebCore::PeerConnection00HandlerInternal::didChangeReadyState):
(WebCore::PeerConnection00HandlerInternal::didChangeICEState):
(WebCore::PeerConnection00HandlerInternal::didAddRemoteStream):
(WebCore::PeerConnection00HandlerInternal::didRemoveRemoteStream):

bridge/PeerConnection00HandlerInternal.h: Copied from Source/WebCore/platform/mediastream/PeerConnection00Handler.h.

(WebKit):
(WebCore):
(PeerConnection00HandlerInternal):

public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::createPeerConnection00Handler):

public/platform/WebPeerConnection00Handler.h: Added.

(WebKit):
(WebPeerConnection00Handler):
(WebKit::WebPeerConnection00Handler::~WebPeerConnection00Handler):

public/platform/WebPeerConnection00HandlerClient.h: Added.

(WebKit):
(WebPeerConnection00HandlerClient):
(WebKit::WebPeerConnection00HandlerClient::~WebPeerConnection00HandlerClient):

src/AssertMatchingEnums.cpp:

11:37 AM Changeset in webkit [112420] by eae@chromium.org

4 edits in branches/subpixellayout/Source

Build fixes for chromium linux

11:32 AM Changeset in webkit [112419] by robert@webkit.org

2 edits in trunk/Source/WebCore

[REGRESSION] Web Inspector: column caption delimiters are misaligned in DataGrid
https://bugs.webkit.org/show_bug.cgi?id=82193

Reviewed by Yury Semikhatsky.

Since r111742 column width in fixed layout tables is set to the width of the cell plus its left padding plus its right padding
plus half its left border plus half its right border in the collapsing border model. The layout of the panel
headers in the inspector depended on pre-r111742 behaviour, so ended up misaligned with the content below. To cater for the
new method of calculating column width enforce a fixed width for the corner column by removing padding and borders (except collapsed
borders from adjacent cells) and specify the expected width (15px) minus the expected width of the collapsed borders (1px).

inspector/front-end/dataGrid.css:

(.data-grid th.corner):

11:29 AM Changeset in webkit [112418] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebCore

Increase code sharing between CSSProperty and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=82479

Reviewed by Antti Koivisto.

Use longhands declarations from CSSPropertyLonghand in CSSProperty to avoid
code duplication.

No new tests : refactoring only, we shouldn't have any behavior difference.

css/CSSProperty.cpp:

(WebCore::resolveToPhysicalProperty):
(WebCore::borderDirections):
(WebCore):
(WebCore::CSSProperty::resolveDirectionAwareProperty):

11:24 AM Changeset in webkit [112417] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Compositor visibility setting must be updated even if not actively compositing
https://bugs.webkit.org/show_bug.cgi?id=82406

Patch by James Robinson <jamesr@chromium.org> on 2012-03-28
Reviewed by Adrienne Walker.

Propagate the visibility bit to the WebLayerTreeView even when compositing is inactive.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setVisibilityState):

11:23 AM Changeset in webkit [112416] by vsevik@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: Implement snippets renaming in scripts navigator.
https://bugs.webkit.org/show_bug.cgi?id=82477

Reviewed by Pavel Feldman.

Snippets renaming is implemented as editing of snippet name in scripts navigator.

inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._handleRenameSnippet):
(WebInspector.ScriptsNavigator.prototype._fileRenamed):
(WebInspector.ScriptsNavigator.prototype.rename.commitHandler):
(WebInspector.ScriptsNavigator.prototype.rename.cancelHandler):
(WebInspector.ScriptsNavigator.prototype.rename.afterEditing):
(WebInspector.BaseNavigatorTreeElement.prototype.set titleText):

inspector/front-end/scriptsPanel.css:

(#scripts-navigator-tabbed-pane .navigator .base-navigator-tree-element-title.editing):

11:20 AM Changeset in webkit [112415] by andersca@apple.com

3 edits in trunk/Source/WebKit2

REGRESSION (r109826): Can't type into Flash text fields
https://bugs.webkit.org/show_bug.cgi?id=82488
<rdar://problem/11022004>

Reviewed by Sam Weinig.

This was caused by the fix in r109826. Revert that change and fix the original bug by notifying the UI process
that the plug-in lost focus when it's destroyed. This will correctly reset the text input state (merely setting
the text input state to PluginComplexTextInputDisabled doesn't reset the state correctly).

UIProcess/API/mac/WKView.mm:

(-[WKView _setPluginComplexTextInputState:]):
(-[WKView _handlePluginComplexTextInputKeyDown:]):

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::~PluginView):

11:13 AM Changeset in webkit [112414] by vsevik@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: Add context menu for snippets control.
https://bugs.webkit.org/show_bug.cgi?id=82475

Reviewed by Pavel Feldman.

This is a preliminary implementation of snippets control using context menu.
We might want to add a more discoverable one before taking snippets out of experiments.

English.lproj/localizedStrings.js:
inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype._createSnippetsTree):
(WebInspector.ScriptsNavigator.prototype._handleSnippetContextMenuEvent):
(WebInspector.ScriptsNavigator.prototype._showSnippetContextMenu):
(WebInspector.ScriptsNavigator.prototype._handleEvaluateSnippet):
(WebInspector.ScriptsNavigator.prototype._handleRenameSnippet):
(WebInspector.ScriptsNavigator.prototype._handleRemoveSnippet):
(WebInspector.ScriptsNavigator.prototype._handleCreateSnippet):
(WebInspector.NavigatorScriptTreeElement.prototype.get navigator):
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):
(WebInspector.NavigatorScriptTreeElement.prototype._handleContextMenuEvent):

11:08 AM Changeset in webkit [112413] by vsevik@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: ScriptsNavigator should save scroll position when switching tabs.
https://bugs.webkit.org/show_bug.cgi?id=82472

Reviewed by Pavel Feldman.

WebInspector.View provides save/restore scroll position capabilities.
This patch makes them used in ScriptsNavigator.

inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._createSnippetsTree):

inspector/front-end/scriptsPanel.css:

(#scripts-navigator-tabbed-pane .tabbed-pane-content):
(#scripts-navigator-tabbed-pane .navigator-container):

11:00 AM Changeset in webkit [112412] by sergio@webkit.org

2 edits in trunk/LayoutTests

Unreviewed, skipping 3 tests timing out after the libsoup upgrade
to 2.37.92.

platform/gtk/Skipped:

10:55 AM Changeset in webkit [112411] by fsamuel@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Enable Viewport define by default
https://bugs.webkit.org/show_bug.cgi?id=79514

Reviewed by Darin Fisher.

features.gypi:

10:50 AM Changeset in webkit [112410] by eae@chromium.org

6 edits in branches/subpixellayout/Source/WebCore

qt build fixes for branch.

10:17 AM Changeset in webkit [112409] by caseq@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: only update Timeline overview when really needed
https://bugs.webkit.org/show_bug.cgi?id=81909

Reviewed by Pavel Feldman.

Switch timeline overview to using raw records, thus removing dependency on instance members of
TimelinePresentationModel. This requires moving record styles/categories to static getters.

inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel):
(WebInspector.TimelineModel.startTime):
(WebInspector.TimelineModel.endTime):
(WebInspector.TimelineModel.duration):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype.reset):
(WebInspector.TimelineModel.prototype.minimumRecordTime):
(WebInspector.TimelineModel.prototype.maximumRecordTime):
(WebInspector.TimelineModel.prototype._updateBoundaries):

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setVerticalOverview):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips.markPercentagesForRecord):
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips):
(WebInspector.TimelineOverviewPane.prototype.windowStartTime):
(WebInspector.TimelineOverviewPane.prototype.windowEndTime):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineOverviewPane.prototype.setShowShortEvents):
(WebInspector.TimelineOverviewPane.prototype._scheduleRefresh):
(WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineOverviewCalculator.prototype.setWindow):
(WebInspector.TimelineOverviewCalculator.prototype.reset):
(WebInspector.HeapGraph):
(WebInspector.HeapGraph.prototype.update):
(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype.reset):
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype.wasShown):
(WebInspector.TimelineVerticalOverview.prototype.willHide):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrameStatistics):
(WebInspector.TimelineVerticalOverview.prototype._aggregateRecords):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):
(WebInspector.TimelineVerticalOverview.prototype._onRecordAdded):
(WebInspector.TimelineAggregatedRecord):
(WebInspector.TimelineAggregatedRecord.prototype._aggregateStatistics):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.formatTime):

inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.recordStyle):
(WebInspector.TimelinePresentationModel.categoryForRecord):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.addRecord):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):

9:33 AM Changeset in webkit [112408] by Philippe Normand

3 edits in trunk/Tools

[GTK] generate-gtk-doc doesn't cope with custom build directory
https://bugs.webkit.org/show_bug.cgi?id=82448

Reviewed by Martin Robinson.

Pass the product directory in generate-gtkdoc arguments from
build-webkit.

Scripts/webkitdirs.pm:

(buildAutotoolsProject):

gtk/common.py:

(get_build_path):

9:03 AM Changeset in webkit [112407] by commit-queue@webkit.org

10 edits in trunk/Source/WebCore

[BlackBerry] Plumb through GraphicsLayer::contentsOpaque() to LayerTiler
https://bugs.webkit.org/show_bug.cgi?id=82457

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-28
Reviewed by Rob Buis.

The LayerTiler already knows not to turn on GL_BLEND for opaque layers.
However, it only ever sets the opaque flag for image layers and color
layers, never for content layers.

This was no big deal, because contentsOpaque() is currently false for
all layers except the root layer, which we always drew using the
BlackBerry::WebKit::BackingStore anyway.

When we start using RenderLayerBacking::m_usingTiledCacheLayer=true on
the root layer in situations where the BackingStore is unavailable, we
can speed up rendering of the root layer by honouring the opaque flag.

Fixed by plumbing through the GraphicsLayer::contentsOpaque() flag all
the way to LayerTiler and on to Texture.

platform/graphics/blackberry/LayerData.h:

(WebCore::LayerData::LayerData):
(WebCore::LayerData::isOpaque):
(LayerData):

platform/graphics/blackberry/LayerTile.cpp:

(WebCore::LayerTile::updateContents):

platform/graphics/blackberry/LayerTile.h:

(LayerTile):

platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::performTileJob):

platform/graphics/blackberry/LayerTiler.h:

(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::updateContents):

platform/graphics/blackberry/LayerWebKitThread.h:

(WebCore::LayerWebKitThread::setOpaque):

platform/graphics/blackberry/Texture.h:

(Texture):

platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::updateContents):

platform/graphics/blackberry/TextureCacheCompositingThread.h:

(TextureCacheCompositingThread):

8:53 AM Changeset in webkit [112406] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=82341

Reviewed by Martin Robinson.

Add --skipped=skip|ignore|only command line option.

Scripts/run-gtk-tests:

(TestRunner._test_cases_to_skip): Return the list of test cases
to skip for the given test depending on the skipped action.
(TestRunner._should_run_test): Decide whether to run the test or
not depending on the skipped action.
(TestRunner.run_tests): Only show the list of skipped tests when
skipped action is 'skip'.

8:49 AM Changeset in webkit [112405] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

Not reviewed: updated chromium test expectations.

platform/chromium/test_expectations.txt:

8:47 AM Changeset in webkit [112404] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
https://bugs.webkit.org/show_bug.cgi?id=82333

Reviewed by Martin Robinson.

Scripts/run-gtk-tests:

(TestRunner.SkippedTest): Add SkippedTest class to store more
information about skipped tests.
(TestRunner._setup_testing_environment): Use SkippedTest to add
TestWebKitAccessibility to the skipped list.
(TestRunner._find_skipped_test): Return the SkippedTest object for
a given test path.
(TestRunner._test_cases_to_skip): Returns the list of test cases
that should be skipped for a given test path.
(TestRunner._should_run_test): Helper funtion to decide whether
the given test path should be run or not. Tests in the skipped
list that don't have a list of failing test cases are not run at
all. Tests in the skipped list that contain a list of test cases
are run with gtester -s to skip the individual test cases.
(TestRunner._run_test): Helper funtion to run a given test.
(TestRunner.run_tests): Build the list of tests to run based on
_should_run_test() and use helper function _run_test() to run
every test.

8:36 AM Changeset in webkit [112403] by caseq@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: nuke HeapGraph.setSize(), do it automagically on update
https://bugs.webkit.org/show_bug.cgi?id=82471

Reviewed by Yury Semikhatsky.

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.HeapGraph.prototype.update):

8:33 AM WebKitGTK/1.8.x edited by sergio@webkit.org

(diff)

8:20 AM Changeset in webkit [112402] by podivilov@chromium.org

7 edits in trunk

Web Inspector: dispatch console-message-added and console-messages-cleared events on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82463

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Those events are related to specific UISourceCode. See bug 82224 for more details.

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.UISourceCodeImpl):
(WebInspector.UISourceCodeImpl.prototype.consoleMessages):
(WebInspector.UISourceCodeImpl.prototype.consoleMessageAdded):
(WebInspector.UISourceCodeImpl.prototype.consoleMessagesCleared):

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessagesCleared):
(WebInspector.JavaScriptSourceFrame.prototype._onTextViewerContentLoaded):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):

inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.breakpoints):
(WebInspector.UISourceCode.prototype.consoleMessages):

LayoutTests:

inspector/debugger/scripts-panel.html:

8:13 AM Changeset in webkit [112401] by Carlos Garcia Campos

7 edits
2 adds
1 delete in trunk/Source

[GTK] Implement PlatformStrategies
https://bugs.webkit.org/show_bug.cgi?id=82454

Reviewed by Xan Lopez.

Source/WebCore:

GNUmakefile.list.am: Remove PluginDataGtk.cpp. The same

functionality is now implemented using platform strategies.

plugins/gtk/PluginDataGtk.cpp: Removed.

Source/WebKit/gtk:

GNUmakefile.am: Add new files to compilation.
WebCoreSupport/PlatformStrategiesGtk.cpp: Added.

(PlatformStrategiesGtk::initialize): Initialize platform
strategies.
(PlatformStrategiesGtk::PlatformStrategiesGtk):
(PlatformStrategiesGtk::createCookiesStrategy): Return this.
(PlatformStrategiesGtk::createPluginStrategy): Ditto.
(PlatformStrategiesGtk::createVisitedLinkStrategy): Ditto.
(PlatformStrategiesGtk::createPasteboardStrategy): Return 0, since
PasteboardStrategy is only used by mac code for now.
(PlatformStrategiesGtk::notifyCookiesChanged):
(PlatformStrategiesGtk::refreshPlugins): Refresh the plugin
database.
(PlatformStrategiesGtk::getPluginInfo): Initialize plugins and
populate the given vector with plugins information.
(PlatformStrategiesGtk::isLinkVisited): Return whether the given
hash is a visited link of the page group.
(PlatformStrategiesGtk::addVisitedLink): Add the given hash to the
page group visited links.

WebCoreSupport/PlatformStrategiesGtk.h: Added.
webkit/webkitglobals.cpp:

(webkitInit): Initialize PlatformStrategiesGtk.

Source/WTF:

wtf/Platform.h: Define WTF_USE_PLATFORM_STRATEGIES for GTK+

platform too.

8:07 AM Changeset in webkit [112400] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: [Regression] TabIndex is not correctly restored after editing.
https://bugs.webkit.org/show_bug.cgi?id=82464

Reviewed by Pavel Feldman.

This fixes incorrect usage of isNaN that returns false for null value.
Drive-by javascript compilation fix.

inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.addScript): compilation fix.

inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged): compilation fix.

inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript): compilation fix.

inspector/front-end/UIUtils.js:

(WebInspector.startEditing.cleanUpAfterEditing): incorrect usage of isNaN fix.

8:00 AM Changeset in webkit [112399] by yi.4.shen@nokia.com

3 edits
2 adds in trunk

An extra line break is inserted when pasting into a font element.
https://bugs.webkit.org/show_bug.cgi?id=71207

Reviewed by Ryosuke Niwa.

Fix an editing bug where inserting text into a font element would
create an extra div element in the dom tree. The
WebCore::positionAvoidingPrecedingNodes() tries to set the correct
destination position by checking the next visible position, however,
it causes the position moves into the child element in somecase.
Instead, we should only check the position in parent after node.

Source/WebCore:

Test: editing/inserting/insert-text-into-font.html

editing/ReplaceSelectionCommand.cpp:

(WebCore::positionAvoidingPrecedingNodes):

LayoutTests:

editing/inserting/insert-text-into-font-expected.txt: Added.
editing/inserting/insert-text-into-font.html: Added.

7:57 AM WebKitGTK/1.8.x edited by sergio@webkit.org

(diff)

7:56 AM Changeset in webkit [112398] by commit-queue@webkit.org

8 edits
8 adds in trunk/LayoutTests

[CSS Regions] Add region styling tests for interaction between region styling and scoped styles
https://bugs.webkit.org/show_bug.cgi?id=82340

Patch by Mihai Balan <mibalan@adobe.com> on 2012-03-28
Reviewed by Antti Koivisto.

Adding tests for style interaction between region styling snd scoped style elements. Currently skipped,
since scoped style elements are not enabled by default.

fast/regions/style-scoped-in-flow-expected.html: Added.
fast/regions/style-scoped-in-flow-override-container-style-expected.html: Added.
fast/regions/style-scoped-in-flow-override-container-style.html: Added.
fast/regions/style-scoped-in-flow-override-region-styling-expected.html: Added.
fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html: Added.
fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html: Added.
fast/regions/style-scoped-in-flow-override-region-styling.html: Added.
fast/regions/style-scoped-in-flow.html: Added.
platform/efl/Skipped:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:

7:54 AM Changeset in webkit [112397] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

Reviewed by Simon Hausmann.

Use SSE2 floating point math on 32 bit instead of the default
387 to make layout test result same on 32 and on 64 bit builds.

qmake/mkspecs/features/unix/default_post.prf:

7:45 AM Changeset in webkit [112396] by sergio@webkit.org

13 edits
1 copy
1 add in trunk

[Soup] DNS prefetching spams resolver, shoots self in the foot
https://bugs.webkit.org/show_bug.cgi?id=41630

Reviewed by Martin Robinson.

Bump libsoup and glib dependencies.

Source/cmake/OptionsEfl.cmake:
configure.ac:

Source/WebCore:

Added generic DNSResolveQueue class to throttle DNS
prefetches. It's an abstract refactoring of CFNET's
DNSResolveQueue. Platform specific methods implemented for soup
and CFNET backends.

No new tests required as we're just refactoring existing code to
be used by two different ports.

CMakeLists.txt: added new file.
GNUmakefile.list.am: ditto.
WebCore.vcproj/WebCore.vcproj: ditto.
WebCore.xcodeproj/project.pbxproj: ditto.
platform/network/DNSResolveQueue.cpp: Added.

(WebCore):
(WebCore::DNSResolveQueue::add): adds a new host to be prefetched.
(WebCore::DNSResolveQueue::fired): by using a delay we coalesce
several prefetch requests and try to resolve them all here.

platform/network/DNSResolveQueue.h: Added.

(WebCore):
(DNSResolveQueue): class that implements DNS prefetch
throttling using a template pattern.
(WebCore::DNSResolveQueue::shared):
(WebCore::DNSResolveQueue::decrementRequestCount):

platform/network/cf/DNSCFNet.cpp:

(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):

platform/network/soup/DNSSoup.cpp:

(WebCore):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::resolvedCallback):
(WebCore::DNSResolveQueue::platformResolve):
(WebCore::prefetchDNS):

Tools:

Bump libsoup and glib dependencies.

efl/jhbuild.modules:
gtk/jhbuild.modules:

7:37 AM Changeset in webkit [112395] by commit-queue@webkit.org

3 edits
2 adds in trunk

window.scrollBy() scrolls incorrectly when zoomed in/out
https://bugs.webkit.org/show_bug.cgi?id=45228

Patch by Eugene Girard <girard@chromium.org> on 2012-03-28
Reviewed by Simon Fraser.

scrollBy now uses layout (not CSS) units. (As scrollTo does.)

Source/WebCore:

Test: fast/dom/zoom-scroll-page-test.html

page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollBy):

LayoutTests:

fast/dom/zoom-scroll-page-test-expected.txt: Added.
fast/dom/zoom-scroll-page-test.html: Added.

7:33 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu

(diff)

7:28 AM Changeset in webkit [112394] by schenney@chromium.org

3 edits
2 adds in trunk

Null dereference in SVGTextElement::animatedLocalTransform()
https://bugs.webkit.org/show_bug.cgi?id=82375

Reviewed by Nikolas Zimmermann.

Source/WebCore:

A poorly structured SVG file with a text element inside an
animatedTransform element leaves the text element placed outside of
the SVG root and it has no renderer(). Later attempts to use the
renderer in animatedLocalTransform fail.

Test: svg/custom/get-text-element-transform-crash.html

svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::animatedLocalTransform): Added a check for null renderer, and do not check
for style transform if there is no renderer.

LayoutTests:

svg/custom/get-text-element-transform-crash-expected.txt: Added.
svg/custom/get-text-element-transform-crash.html: Added.

7:19 AM Changeset in webkit [112393] by xan@webkit.org

2 edits in trunk

[GTK] Respect NOCONFIGURE option in autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=82447

Reviewed by Philippe Normand.

Make autogen.sh follow the new build-api for GNOME, see
http://people.gnome.org/~walters/docs/build-api.txt

autogen.sh: respect the NOCONFIGURE environment flag, per the

new GNOME build-api.

7:11 AM Changeset in webkit [112392] by kov@webkit.org

3 edits in trunk/Tools

[GTK] Disable introspection for jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=82395

Reviewed by Philippe Normand.

efl/jhbuild.modules: add --disable-introspection to all modules

that support it

gtk/jhbuild.modules: ditto.

6:14 AM Changeset in webkit [112391] by Nikolas Zimmermann

15 edits in trunk

Enable animVal support for SVGAnimatedPreserveAspectRatio
https://bugs.webkit.org/show_bug.cgi?id=82326

Reviewed by Zoltan Herczeg.

Source/WebCore:

Enable animVal support for SVGAnimatedPreserveAspectRatio. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedPreserveAspectRatioAnimator.

Modernize SVGPreserveAspectRatio, align parsing this object from String, with the other SVG DOM primitives,
who supply a "void parse(const String&)" method, for this task.

Extended existing tests to cover this.

svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::constructFromString):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::animValWillChange):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::animValDidChange):

svg/SVGAnimatedPreserveAspectRatio.h:

(SVGAnimatedPreserveAspectRatioAnimator):

svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):

svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::parseAttribute):

svg/SVGFitToViewBox.cpp:

(WebCore::SVGFitToViewBox::parseAttribute):

svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::parseAttribute):

svg/SVGPreserveAspectRatio.cpp:

(WebCore::SVGPreserveAspectRatio::parse):
(WebCore):

svg/SVGPreserveAspectRatio.h:

(SVGPreserveAspectRatio):

svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::setPreserveAspectRatioString):
(WebCore::SVGViewSpec::parseViewSpec):

LayoutTests:

Extend SVGAnimatedPreserveAspectRatio tests to cover animVal support.

svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:

(sample1):
(sample2):
(sample3):

svg/animations/svgPreserveAspectRatio-animation-1-expected.txt:
svg/dom/preserve-aspect-ratio-parser-expected.txt:
svg/dom/preserve-aspect-ratio-parser.html: Parsing errors now yield to 'unknown' pAR values, as desired.

6:05 AM Changeset in webkit [112390] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [v8] inspection of CanvasPixelArray is slow.
https://bugs.webkit.org/show_bug.cgi?id=82455

Reviewed by Vsevolod Vlasov.

Added CanvasPixelArray to the list of classes that we consider
arrays.

bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::typeCallback):

6:02 AM Changeset in webkit [112389] by leandrogracia@chromium.org

6 edits
2 adds in trunk/Source/WebCore

Selectively retrieve text content around a given position.
https://bugs.webkit.org/show_bug.cgi?id=78361

Reviewed by Ryosuke Niwa.

Tests: a new layout test will be introduced once the required WebKit API code is ready.

Introduce the DOMTextContentWalker class to selectively retrieve content
around a given VisiblePosition into a string in such a way that a text
Range can be extracted later from a pair of the string's positions.

A new boolean called m_shouldStop is also introduced in the TextIterator to force
it advancing under certain conditions. Although this is usually done by setting
m_positionNode to zero, it can't be applied in this case since by doing so the
iterator's range is lost.

WebCore.gypi:
editing/SurroundingText.cpp: Added.

(WebCore):
(WebCore::SurroundingText::SurroundingText):
(WebCore::SurroundingText::rangeFromContentOffsets):
(WebCore::SurroundingText::content):
(WebCore::SurroundingText::positionOffsetInContent):

editing/SurroundingText.h: Added.

(WebCore):
(SurroundingText):

editing/TextIterator.cpp:

(WebCore::TextIterator::TextIterator):
(WebCore::TextIterator::advance):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::advance):

editing/TextIterator.h:

(WebCore::TextIterator::atEnd):
(TextIterator):
(WebCore::SimplifiedBackwardsTextIterator::atEnd):
(SimplifiedBackwardsTextIterator):

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::enclosingFormControlElement):
(WebCore):

html/HTMLFormControlElement.h:

(HTMLFormControlElement):

6:02 AM Changeset in webkit [112388] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt] Unreviewed, fix API tests after adding full platforms. (r111658)

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(BuildAndTestFactory.init):

5:42 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu

(diff)

5:40 AM Changeset in webkit [112387] by alexis.menard@openbossa.org

10 edits in trunk

Speed up updates of existing CSS properties from JS.
https://bugs.webkit.org/show_bug.cgi?id=82235

Reviewed by Andreas Kling.

Source/WebCore:

Improve the way we handle updating an existing CSS property by replacing its value
by the new one rather than removing the old value and then adding the new one. This
speed up by 35% PerformanceTests/CSS/CSSPropertyUpdateValue.html.

No new tests : Updating existing tests that were relying on the order of the properties
after modification. Each updated property is not appended to the list of properties of the
style therefore the cssText value is slightly different. It matches Firefox behavior but not
Opera.

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::addParsedProperty):

LayoutTests:

Updated expectations after behavior change on how we handle updates of
CSS properties from JS. We match now Firefox where the cssText keeps the
order of the properties (but modify its value) whereas before we were appending
the new value at the end of the list of properties.

editing/pasteboard/data-transfer-items-expected.txt:
editing/pasteboard/onpaste-text-html-expected.txt:
fast/dom/css-set-property-exception-expected.txt:
fast/events/ondrop-text-html-expected.txt:
fast/mutation/observe-attributes-expected.txt:
fast/mutation/observe-attributes.html:
inspector/styles/styles-new-API-expected.txt:

5:39 AM Changeset in webkit [112386] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt] Unreviewed typo fix after r112383.

Scripts/run-qtwebkit-tests:

(Main.check_crash_occurences):

5:31 AM Changeset in webkit [112385] by leo.yang@torchmobile.com.cn

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of WebCore::PlatformMouseEvent::globalPos() in WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=82420

Reviewed by Rob Buis.

In PlatformMouseEvent.h the blackberry porting added globalPos() (but not upstreamed yet)
for PlatformMouseEvent, but this method is same as globalPosition() that is available for
every porting. We should use globalPosition().

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateCursor):

5:26 AM Changeset in webkit [112384] by leo.yang@torchmobile.com.cn

2 edits in trunk/Source/WebCore

[BlackBerry] Remove PlatformMouseEvent::setClickCount for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=82422

Reviewed by Rob Buis.

PlatformMouseEvent::setClickCount() is never used by BlackBerry.
The declaration was added in PlatformMouseEvent.h internally for
BlackBerry porting, but it has not been upstreamed yet.

platform/blackberry/PlatformMouseEventBlackBerry.cpp:

5:11 AM Changeset in webkit [112383] by Csaba Osztrogonác

4 edits in trunk/Tools

[Qt] run-qtwebkit-tests should report crashes
https://bugs.webkit.org/show_bug.cgi?id=76905

Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
Made unit test for this modification by János Badics <János Badics>.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-28
Reviewed by Csaba Osztrogonác.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunQtAPITests.commandComplete):
(RunQtAPITests.evaluateCommand):

BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunQtAPITestsTest):
(test_failure):
(test_crash):

Scripts/run-qtwebkit-tests:

(Main.announce_results_html):
(Main):
(Main.check_crash_occurences):
(Main.convert_to_stdout):
(Main.convert_to_html):

3:41 AM Changeset in webkit [112382] by Antti Koivisto

4 edits in trunk/Source/WebCore

Separate @import rules from other rules in CSSStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=82384

Reviewed by Andreas Kling.

Import rules always come before all other rules (except @charset). They currently live
in the generic child rule vector. They can be moved to a vector of their own for stronger
typing and more focused traversal. This will also make future refactoring easier.

@import rules go to m_importRules
the rest go to m_childRules

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::parserAppendRule):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::clearRules):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::isLoading):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):

css/CSSStyleSheet.h:

(WebCore):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::childRules):
(WebCore::CSSStyleSheet::importRules):

3:10 AM Changeset in webkit [112381] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION: Stack overflow on the page with > 100kloc
https://bugs.webkit.org/show_bug.cgi?id=82436

Reviewed by Yury Semikhatsky.

This change migrates to manual splice implementation that uses additional
information about the range being inserted to make it work faster / allocate
less memory.

inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

3:09 AM Changeset in webkit [112380] by commit-queue@webkit.org

2 edits
1 add in trunk/Tools

Add support for Intel compiler on Linux QT port.
https://bugs.webkit.org/show_bug.cgi?id=81077

Patch by Kwonjin Jeong <gram@company100.net> on 2012-03-28
Reviewed by Tor Arne Vestbø.

qmake/mkspecs/features/default_post.prf:

Don't hide symbols when building with Intel compiler.
The symbols are needed when building QtWebKit tests.

qmake/mkspecs/features/unix/icc.prf:

Added to ignore icc-specific warnings.
This feature is used with command-line arguments for build-webkit script.

2:58 AM Changeset in webkit [112379] by podivilov@chromium.org

5 edits in trunk

Web Inspector: breakpoints are not shown in sidebar pane after reload.
https://bugs.webkit.org/show_bug.cgi?id=82351

Reviewed by Pavel Feldman.

Source/WebCore:

When UISourceCode is added to ScriptsPanel, it could already have breakpoints.
We should iterate over existing breakpoints and add them to sidebar pane.

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):

LayoutTests:

inspector/debugger/set-breakpoint-expected.txt:
inspector/debugger/set-breakpoint.html:

2:56 AM Changeset in webkit [112378] by kkristof@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] REGRESSION(r111480): It made svg/as-image tests assert
https://bugs.webkit.org/show_bug.cgi?id=82052

It also made svg/as-object tests assert

Reviewed by Csaba Osztrogonác.

platform/qt/Skipped: Skip failing tests.

2:12 AM Changeset in webkit [112377] by commit-queue@webkit.org

3 edits
3 adds in trunk

[WebSocket]The Sec-WebSocket-Protocol must not appear more than once in an HTTP response
https://bugs.webkit.org/show_bug.cgi?id=82432

Patch by Li Yin <li.yin@intel.com> on 2012-03-28
Reviewed by Kent Tamura.

Source/WebCore:

From RFC6455: http://tools.ietf.org/html/rfc6455#section-11.3.4
The |Sec-WebSocket-Protocol| header field must not appear
more than once in an HTTP response.

Test: http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header.html

Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readHTTPHeaders):

LayoutTests:

From RFC6455: http://tools.ietf.org/html/rfc6455#section-11.3.4
The |Sec-WebSocket-Protocol| header field must not appear
more than once in an HTTP response.

http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header-expected.txt: Added.
http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header.html: Added.
http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

1:59 AM Changeset in webkit [112376] by kbalazs@webkit.org

2 edits in trunk/Source/WebKit2

Fix QWARN in test_loadIgnoreEmptyUrl API test.

Rubber-stamped by Csaba Osztrogonác.

UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml:

There is no load() API of the view, we have to use the url property.

1:54 AM Changeset in webkit [112375] by Philippe Normand

2 edits in trunk/Tools

Unreviewed, trivial update-webkit-libs-jhbuild system call fix.

Scripts/update-webkitgtk-libs: This script is written in

Perl. Not Python. So use perl vocabulary to refer to command line arguments.

1:40 AM Changeset in webkit [112374] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r112254.

platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:

1:26 AM Changeset in webkit [112373] by rniwa@webkit.org

2 edits in trunk/Tools

kill-old-processes doesn't do anything on linux
https://bugs.webkit.org/show_bug.cgi?id=82388

Reviewed by Tony Chang.

Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
This should help stabilizing Chromium linux bots.

BuildSlaveSupport/kill-old-processes:

1:22 AM Changeset in webkit [112372] by Philippe Normand

2 edits in trunk/Tools

[GTK] jhbuild wrongly tricked into clean-up
https://bugs.webkit.org/show_bug.cgi?id=82216

Reviewed by Gustavo Noronha Silva.

Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
build tree. Also when checking if the jhbuild configuration
changed use absolute md5sum paths.

Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):
(jhbuildConfigurationChanged):
(buildAutotoolsProject):

1:16 AM Changeset in webkit [112371] by Csaba Osztrogonác

2 edits in trunk/Tools

kill-old-processes doesn't do anything on linux
https://bugs.webkit.org/show_bug.cgi?id=82388

One more attempt to disable kill-old-processes on the Qt bots not to kill each others.

The platform in Factory comes from config.json, accordingly platform is fullplatform,
for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.

Reviewed by Ryosuke Niwa.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(Factory.init):

12:36 AM Changeset in webkit [112370] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] REGRESSION(r111480): It made svg/as-image tests assert
https://bugs.webkit.org/show_bug.cgi?id=82052

platform/qt/Skipped: Skip failing tests.

12:25 AM Changeset in webkit [112369] by Csaba Osztrogonác

1 edit
2 moves
1 add in trunk/LayoutTests

[Qt] One more unreviewed gardening after r112301.

platform/qt-5.0/fast/dom/Window/window-properties-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/fast/dom/Window/window-properties-expected.png.
platform/qt-5.0/fast/dom/Window/window-properties-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk1/fast/dom/Window/window-properties-expected.txt.

12:05 AM Changeset in webkit [112368] by commit-queue@webkit.org

2 edits in trunk/Tools

Make Chromium port for Android use hardware gpu path default.
https://bugs.webkit.org/show_bug.cgi?id=82033

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-03-28
Reviewed by Dirk Pranke.

Skip canvas tests, which are run in virtual gpu test suites.

Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.skipped_tests):

Mar 27, 2012:

11:43 PM Changeset in webkit [112367] by Csaba Osztrogonác

2 edits in trunk/Tools

kill-old-processes doesn't do anything on linux
https://bugs.webkit.org/show_bug.cgi?id=82388

Disable kill-old-processes on the Qt bots not to kill each others.

Reviewed by Ryosuke Niwa.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(Factory.init):

11:40 PM Changeset in webkit [112366] by Csaba Osztrogonác

5 edits
1 move
4 adds
1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening after r112301.

platform/qt-4.8/fast/dom/Window/window-properties-expected.png:
platform/qt-4.8/fast/dom/Window/window-properties-expected.txt:
platform/qt-5.0-wk1/fast/dom/Window/window-properties-expected.png: Added.
platform/qt-5.0-wk1/fast/dom/Window/window-properties-expected.txt: Renamed from LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt.
platform/qt-5.0-wk2/Skipped:
platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-properties-expected.png: Removed.

11:12 PM Changeset in webkit [112365] by pfeldman@chromium.org

2 edits
1 add in trunk/LayoutTests

Not reviewed: rebaselined chromium expectations.

platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.png:
platform/chromium-mac-leopard/fast/text/unicode-variation-selector-expected.txt: Added.

11:08 PM Changeset in webkit [112364] by commit-queue@webkit.org

13 edits
1 copy in trunk/Source

[chromium] Transfer wheel fling via WebCompositorInputHandlerClient
https://bugs.webkit.org/show_bug.cgi?id=81740

Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

Source/WebCore:

Adds the ability to construct an in-progress PlatformGestureAnimation.

platform/ActivePlatformGestureAnimation.cpp:

(WebCore::ActivePlatformGestureAnimation::create):
(WebCore):
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):

platform/ActivePlatformGestureAnimation.h:

(ActivePlatformGestureAnimation):

platform/TouchpadFlingPlatformGestureCurve.cpp:

(WebCore::TouchpadFlingPlatformGestureCurve::create):
(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):

platform/TouchpadFlingPlatformGestureCurve.h:

(TouchpadFlingPlatformGestureCurve):

Source/WebKit/chromium:

Adds a path for transfering an active wheel fling animation out to the embedder from the compositor and back in
to a WebViewImpl via the embedder. This is used when we start a wheel fling animation on the compositor thread
but then hit a condition that we can't handle from the compositor, such as registered wheel event listeners or a
scrollable area we can't handle.

New tests added to WebCompositorInputHandlerTest for the transfering logic.

public/WebActiveWheelFlingParameters.h: Copied from Source/WebKit/chromium/public/WebCompositorInputHandlerClient.h.

(WebKit):
(WebActiveWheelFlingParameters):
(WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters):

public/WebCompositorInputHandlerClient.h:

(WebKit):
(WebCompositorInputHandlerClient):
(WebKit::WebCompositorInputHandlerClient::transferActiveWheelFlingAnimation):

public/WebView.h:

(WebKit):
(WebView):

src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):

src/WebCompositorInputHandlerImpl.h:

(WebCore):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
(WebKit):

src/WebViewImpl.h:

(WebViewImpl):

tests/WebCompositorInputHandlerImplTest.cpp:

(WebKit::MockWebCompositorInputHandlerClient::MockWebCompositorInputHandlerClient):
(MockWebCompositorInputHandlerClient):
(WebKit::TEST):
(WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
(WebKit::WebCompositorInputHandlerImplTest::~WebCompositorInputHandlerImplTest):
(WebCompositorInputHandlerImplTest):
(WebKit::TEST_F):
(WebKit):

9:27 PM Changeset in webkit [112363] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Send wheel events to main thread even if we think nothing is scrollable
https://bugs.webkit.org/show_bug.cgi?id=82408

Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):

9:19 PM Changeset in webkit [112362] by rniwa@webkit.org

3 edits in trunk

Perf-o-matic build fix.

Websites/webkit-perf.appspot.com/controller.py:

(RunsChartHandler.post):

Websites/webkit-perf.appspot.com/models.py:

(Runs.chart_params):

8:47 PM Changeset in webkit [112361] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Text selection - selection gets broken in test.com/individuals.htm
https://bugs.webkit.org/show_bug.cgi?id=82292

Change to check and avoid text selection across frames.

Internal reviewed by Mike Fenton

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-03-27
Reviewed by Rob Buis.

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

support selection across frames, so check if the *framePoint* is in
the *frame*.

(BlackBerry::WebKit::SelectionHandler::setSelection):

function returns a null VisablePosition, it stands for a invalid position
or a position in the different frames, therefor we don't execute setting
handle's position.

8:15 PM Changeset in webkit [112360] by nduca@chromium.org

14 edits in trunk/Source

[chromium] Route monotonic clock up from compositor
https://bugs.webkit.org/show_bug.cgi?id=82154

Reviewed by James Robinson.

Source/Platform:

chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):

Source/WebCore:

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateAnimations):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):

platform/graphics/chromium/cc/CCThreadProxy.h:

(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):

Source/WebKit/chromium:

public/WebWidget.h:

(WebKit::WebWidget::animate):

src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::updateAnimations):

src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::updateAnimations):

src/WebViewImpl.h:

(WebViewImpl):

tests/FakeCCLayerTreeHostClient.h:

(WebCore::FakeCCLayerTreeHostClient::updateAnimations):

8:05 PM Changeset in webkit [112359] by commit-queue@webkit.org

3 edits in trunk/Tools

Handle DRT crash caused by Android OOM.
https://bugs.webkit.org/show_bug.cgi?id=82310

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-03-27
Reviewed by Tony Chang.

When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
is stopped silently and regarded as crashed. Re-run the test for
such crash.

Add some debug log to NRWT.

Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.run_test):

Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.get_last_stacktrace):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver.run_test):
(ChromiumAndroidDriver._get_drt_return_value):

7:56 PM Changeset in webkit [112358] by commit-queue@webkit.org

1 edit
2 adds in trunk/Source/WebCore

[BlackBerry] Upstream LayerAnimation.{cpp, h}
https://bugs.webkit.org/show_bug.cgi?id=80123

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-27
Reviewed by Rob Buis.

Initial upstream, no new tests.

platform/graphics/blackberry/LayerAnimation.cpp: Added.

(WebCore):
(WebCore::solveEpsilon):
(WebCore::solveCubicBezierFunction):
(WebCore::solveStepsFunction):
(WebCore::timingFunctionForAnimationValue):
(WebCore::progress):
(WebCore::fetchIntervalEndpoints):
(WebCore::LayerAnimation::apply):
(WebCore::LayerAnimation::blendTransform):
(WebCore::LayerAnimation::blendOpacity):
(WebCore::LayerAnimation::validateTransformLists):

platform/graphics/blackberry/LayerAnimation.h: Added.

(WebCore):
(LayerAnimation):
(WebCore::LayerAnimation::create):
(WebCore::LayerAnimation::clone):
(WebCore::LayerAnimation::~LayerAnimation):
(WebCore::LayerAnimation::name):
(WebCore::LayerAnimation::setStartTime):
(WebCore::LayerAnimation::idFromAnimation):
(WebCore::LayerAnimation::isEqualToAnimation):
(WebCore::LayerAnimation::id):
(WebCore::LayerAnimation::property):
(WebCore::LayerAnimation::boxSize):
(WebCore::LayerAnimation::timeOffset):
(WebCore::LayerAnimation::startTime):
(WebCore::LayerAnimation::valueCount):
(WebCore::LayerAnimation::timingFunction):
(WebCore::LayerAnimation::duration):
(WebCore::LayerAnimation::iterationCount):
(WebCore::LayerAnimation::direction):
(WebCore::LayerAnimation::valueAt):
(WebCore::LayerAnimation::LayerAnimation):

7:42 PM Changeset in webkit [112357] by bashi@chromium.org

2 edits in trunk/Source/WebCore

[Chromium] Uninitialized access in SimpleFontDataSkia::platformInit
https://bugs.webkit.org/show_bug.cgi?id=82411

Reviewed by Kent Tamura.

SimpleFontDataSkia::platformInit() could call widthForGlyph(), which
accesses m_zeroWidthSpaceGlyph. This causes a valgrind memcheck error
because m_zeroWidthSpaceGlyph isn't initialized at this point.
Initialize m_zeroWidthSpaceGlyph with zero so that widthForGlyph() can
return appropriate value(The value zero here means "unknown glyph").

No new tests. I manually confirmed this change fixes the valgrind
memcheck error.

platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformInit):

7:29 PM Changeset in webkit [112356] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

webkit_unit_tests crashing on chromium lion in CCLayerTreeHostTestCompositeAndReadbackWhileInvisible
https://bugs.webkit.org/show_bug.cgi?id=82382

Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

Use UnsignedWithZeroKeyHashTraits trait for the HashSet<WebGLId> m_usedTextures in
CompositorFakeWebGraphicsContext3DWithTextureTracking. This set is used to track all textures that are bound in
a given context during a test. During ..CompositeAndReadback.. we bind texture id 0. By default, HashSet<T>
where T is an unsigned does not allow 0 as a value. WebGLId is typedef'd to unsigned.

tests/CCLayerTreeHostTest.cpp:

(CompositorFakeWebGraphicsContext3DWithTextureTracking):

7:08 PM Changeset in webkit [112355] by ojan@chromium.org

2 edits in trunk/Tools

Fix expected results for some unittest failures.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:

7:06 PM Changeset in webkit [112354] by enne@google.com

4 edits in trunk/Tools

[chromium] Fix --enabled-threaded-compositing flag in DRT
https://bugs.webkit.org/show_bug.cgi?id=82405

Reviewed by James Robinson.

--enable-threaded-compositing wasn't working because there was no way
to set the value before it was used in the TestShell constructor.

To avoid adding yet another boolean parameter to TestShell's
constructor, add an explicit initialize function that can operate on
any boolean settings that are set post-constructor.

DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::initialize):

DumpRenderTree/chromium/TestShell.h:

(TestShell):
(TestShell::setTestShellMode):

7:02 PM Changeset in webkit [112353] by commit-queue@webkit.org

9 edits
1 add in trunk/Source

[EFL][WK2] Add RunLoopEfl and WorkQueueEfl
https://bugs.webkit.org/show_bug.cgi?id=62777

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-03-27
Reviewed by Hajime Morita.

Source/WebCore:

Add initial version RunLoopEfl for WebKit2 Efl.

platform/RunLoop.h:

(TimerBase):
(RunLoop):

platform/efl/RunLoopEfl.cpp:

(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore):
(WebCore::RunLoop::run):
(WebCore::RunLoop::stop):
(WebCore::RunLoop::wakeUpEvent):
(WebCore::RunLoop::wakeUp):
(WebCore::RunLoop::TimerBase::TimerBase):
(WebCore::RunLoop::TimerBase::~TimerBase):
(WebCore::RunLoop::TimerBase::timerFired):
(WebCore::RunLoop::TimerBase::start):
(WebCore::RunLoop::TimerBase::stop):
(WebCore::RunLoop::TimerBase::isActive):

Source/WebKit2:

Add initial version WorkQueueEfl for WebKit2 Efl.

Platform/CoreIPC/Connection.h:
Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::open):

Platform/PlatformProcessIdentifier.h:

(WebKit):

Platform/WorkQueue.h:

(WorkQueue):

Platform/efl/WorkQueueEfl.cpp: Added.

(TimerWorkItem):
(TimerWorkItem::TimerWorkItem):
(TimerWorkItem::~TimerWorkItem):
(TimerWorkItem::function):
(TimerWorkItem::queue):
(TimerWorkItem::timerID):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::performWork):
(WorkQueue::performFdWork):
(WorkQueue::sendMessageToThread):
(WorkQueue::workQueueThread):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatch):
(WorkQueue::timerFired):
(WorkQueue::dispatchAfterDelay):

PlatformEfl.cmake:

6:58 PM Changeset in webkit [112352] by dpranke@chromium.org

2 edits in trunk/LayoutTests

More flaky tests!

Unreviewed, expectations changes.

platform/chromium/test_expectations.txt:

6:56 PM Changeset in webkit [112351] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

webkit_unit_tests crashing on chromium lion in ScrollbarLayerChromiumTest.resolveScrollLayerPointer
https://bugs.webkit.org/show_bug.cgi?id=82381

Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

Use the mock scrollbar theme for this unit test. The real ScrollbarThemeMac isn't compatible with the mocks this
test uses and the test isn't designed to cover the theming code, only code inside the compositor.

tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::TEST):

6:16 PM Changeset in webkit [112350] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Restore a couple of leopard/snowleopard expectations I overzealously deleted.

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

6:10 PM Changeset in webkit [112349] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Remove move tests passing on win and linux.

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

6:01 PM Changeset in webkit [112348] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Remove more tests passing on lion

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

5:58 PM Changeset in webkit [112347] by benjamin@webkit.org

3 edits in trunk/Source/WebCore

Reinforce Geolocation to prevent accidental leak of the user position
https://bugs.webkit.org/show_bug.cgi?id=82396

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-27
Reviewed by Adam Barth.

It is very important not to provide the position of the user to a page
unless the user authorize it.

The code used to make it easy to cause such problems, because any part
of the Geolocation object could invoke the success callback directly.

This patch add encapsulation for all the attributes of GeoNotifier,
and add extra guards for the two callbacks.

In the case of the success callback, we do one extra check before sending
the value to the bindings.

Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::GeoNotifier::runSuccessCallback):
(WebCore::Geolocation::GeoNotifier::runErrorCallback):
(WebCore):
(WebCore::Geolocation::GeoNotifier::stopTimer):
(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::sendError):
(WebCore::Geolocation::sendPosition):
(WebCore::Geolocation::stopTimer):
(WebCore::Geolocation::extractNotifiersWithCachedPosition):
(WebCore::Geolocation::startUpdating):

Modules/geolocation/Geolocation.h:

(WebCore::Geolocation::isAllowed):
(Geolocation):
(GeoNotifier):
(WebCore::Geolocation::GeoNotifier::options):
(WebCore::Geolocation::GeoNotifier::useCachedPosition):

5:52 PM Changeset in webkit [112346] by dpranke@chromium.org

3 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r112339.
http://trac.webkit.org/changeset/112339
https://bugs.webkit.org/show_bug.cgi?id=82354

webkit_unit_tests crashing on chromium mac bots

src/AssociatedURLLoader.cpp:

(AssociatedURLLoader::ClientAdapter):

tests/AssociatedURLLoaderTest.cpp:

(WebKit::AssociatedURLLoaderTest::TearDown):
(WebKit):
(WebKit::TEST_F):

5:49 PM Changeset in webkit [112345] by Lucas Forschler

5 edits in branches/safari-534.56-branch/Source

Versioning.

5:47 PM Changeset in webkit [112344] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Add suppression for flaky plugins/netscape-dom-access-and-reload.html on mac and linux.

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

5:37 PM Changeset in webkit [112343] by commit-queue@webkit.org

11 edits in trunk/Source

[Coverity] Address some uninitialized constructor values.
https://bugs.webkit.org/show_bug.cgi?id=82376

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-03-27
Reviewed by James Robinson.

Source/WebCore:

New tests are not required since I did not modify any code behavior.

html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):

inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):

platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):

platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::DataTransferItemChromium):

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):

storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):

Source/WebKit/chromium:

New tests are not required since I did not modify any code behavior. I just initialized the class member variables in the constructor.

src/WebCompositorInputHandlerImpl.cpp:

(WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):

5:28 PM Changeset in webkit [112342] by dpranke@chromium.org

2 edits in trunk/Source/WebKit/chromium

Roll chromium DEPS to r129300.

Unreviewed, deps change.

DEPS:

5:27 PM Changeset in webkit [112341] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebCore

Simplify CSSPropertyBorderSpacing parsing.
https://bugs.webkit.org/show_bug.cgi?id=82397

Reviewed by Benjamin Poulain.

Remove the local array of longhand properties as it doesn't really
bring much in this simple parsing algorithm.

No new tests, no functionality change intended.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

5:21 PM Changeset in webkit [112340] by andersca@apple.com

2 edits in trunk/Source/WebCore

Fix race condition when initializing the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=82398
<rdar://problem/11002166>

Reviewed by Sam Weinig.

Lock m_initializeRunLoopConditionMutex when assigning m_threadIdentifier since we're
asserting that it's not null in the scrolling thread.

page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::createThreadIfNeeded):

5:19 PM Changeset in webkit [112339] by bbudge@chromium.org

3 edits in trunk/Source/WebKit/chromium

AssociatedURLLoader does not support Cross Origin Redirects when using
Access Control.
https://bugs.webkit.org/show_bug.cgi?id=82354

Reviewed by Adam Barth.

src/AssociatedURLLoader.cpp:

(AssociatedURLLoader::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didFailRedirectCheck):
(WebKit):

tests/AssociatedURLLoaderTest.cpp:

(WebKit::TEST_F):

5:16 PM Changeset in webkit [112338] by andersca@apple.com

23 edits in trunk/Source/WebKit2

Plug-ins using the Core Animation drawing model should work when hosting the layer tree in the window server
https://bugs.webkit.org/show_bug.cgi?id=82387
<rdar://problem/11031942>

Reviewed by Sam Weinig.

PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::initialize):
Remove m_pluginCreationParameters; it was used by the old NPRuntime short-circuit code.
Make platformInitialize take creation parameters.

PluginProcess/PluginControllerProxy.messages.in:

Add SetLayerHostingMode message.

PluginProcess/gtk/PluginControllerProxyGtk.cpp:

(WebKit::PluginControllerProxy::platformInitialize):
Make platformInitialize take creation parameters.

PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::platformInitialize):
Call updateLayerHostingContext.

(WebKit::PluginControllerProxy::setLayerHostingMode):
Call updateLayerHostingContext and send back the new context ID.

(WebKit::PluginControllerProxy::updateLayerHostingContext):
Create a new LayerHostingContext given the layer hosting mode.

PluginProcess/qt/PluginControllerProxyQt.cpp:

(WebKit::PluginControllerProxy::platformInitialize):
Make platformInitialize take creation parameters.

WebProcess/Plugins/Netscape/NetscapePlugin.h:
WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::setLayerHostingMode):
Add stub.

WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::makeRenderLayer):
Add helper function for creating a new render layer.

(WebKit::PluginProxy::pluginLayer):
Call makeRenderLayer.

(WebKit::PluginProxy::setLayerHostingMode):
Send a message to the plug-in process.

(WebKit::PluginProxy::setLayerHostingContextID):
Update the context ID and make a new render layer.

WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::setLayerHostingMode):
Add stub.

WebProcess/Plugins/PDF/BuiltInPDFView.h:

WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):

WebProcess/Plugins/Plugin.h:

Add the layer hosting mode as a parameter. Add a new setLayerHostingMode pure virtual member function.

WebProcess/Plugins/PluginProxy.messages.in:

Add a SetLayerHostingContextID message.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setLayerHostingMode):
Call down to the plug-in.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Set the layer hosting mode of the page.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Initialize m_layerHostingMode to false.

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::layerHostingMode):
Add m_layerHostingMode and a getter.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setLayerHostingMode):
Call WebPage::setLayerHostingMode.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::setLayerHostingMode):
Tell all plug-ins that the layer hosting mode changed.

5:12 PM Changeset in webkit [112337] by dpranke@chromium.org

2 edits in trunk/Tools

new-run-webkit-tests: suppress debug output from run-safari on results file
https://bugs.webkit.org/show_bug.cgi?id=82400

Reviewed by Ryosuke Niwa.

Send the run-safari output to /dev/null rather than the console.

Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.show_results_html_file):

5:12 PM Changeset in webkit [112336] by macpherson@chromium.org

3 edits in trunk/Source/WebCore

Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging.
https://bugs.webkit.org/show_bug.cgi?id=82393

Reviewed by Eric Seidel.

No new tests / adding assetions only.

css/LengthFunctions.cpp:

(WebCore::valueForLength):

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegionUsing):

5:05 PM Changeset in webkit [112335] by eae@chromium.org

676 edits
45 copies
8 deletes in branches/subpixellayout

Merge trunk changes up until 112329 into subpixel branch.

5:02 PM Changeset in webkit [112334] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Remove more passing tests, tighten overly broad expectations.

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

4:56 PM Changeset in webkit [112333] by tony@chromium.org

5 edits in trunk

use the correct size when computing flex-pack space
https://bugs.webkit.org/show_bug.cgi?id=82378

Reviewed by Ojan Vafai.

Source/WebCore:

Fix 2 bugs:

We weren't properly updating available space before computing packing space. If a min/max is not hit, we still need to adjust the available free space.
For flex-pack:end, we need to put the overflow in the start edge.

New test cases in css3/flexbox/flex-pack.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
(WebCore::initialPackingOffset):

LayoutTests:

css3/flexbox/flex-pack-expected.txt:
css3/flexbox/flex-pack.html:

4:49 PM Changeset in webkit [112332] by commit-queue@webkit.org

4 edits in trunk/Source

[chromium] Unknown transforms should be treated as non-axis aligned on main thread
https://bugs.webkit.org/show_bug.cgi?id=82370

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

Source/WebCore:

On main thread, animating transforms have "unknown" values as they are changing
out of sync on the impl thread. So treat them as non-axis-aligned since they
may be, when deciding to create a render surface.

In addition, since surfaces are cheap on main thread, create one for all layers
with animating transforms and a drawing descendant, as this allows paint culling
within the layer's subtree (the animated transform won't affect drawTransforms
inside the subtree).

Also renamed the layerIsInAnimatingSubtreeFor* to animatingTransformTo*.
The old name made me pause and think what it meant and I'm the one who
created it. Hopefully this is more clear.

Unit test: CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy

platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::transformToParentIsKnown):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):

4:39 PM Changeset in webkit [112331] by Lucas Forschler

1 copy in tags/Safari-534.56.3

New tag.

4:25 PM Changeset in webkit [112330] by eae@chromium.org

1 delete in branches/subpixellayout/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp

Update SVGImageBufferTools on branch to match trunk.

4:21 PM Changeset in webkit [112329] by dpranke@chromium.org

3 edits in trunk/Source/WebCore

Re-land r112277; reverting it doesn't seem to have fixed anything.

Unreviewed, build fix.

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::finishParsingChildren):

xml/XMLErrors.cpp:

(WebCore::XMLErrors::insertErrorMessageBlock):

4:21 PM April 2012 Meeting edited by eae@chromium.org

(diff)

4:12 PM Changeset in webkit [112328] by eae@chromium.org

3884 edits
6304 copies
880 deletes in branches/subpixellayout

Merge trunk changes up until 112277 into subpixel branch.

4:07 PM WebKitIDL edited by abarth@webkit.org

(diff)

3:46 PM Changeset in webkit [112327] by commit-queue@webkit.org

12 edits in trunk/Source

[chromium] Rename opaqueContentsRegion() to visibleContentOpaqueRegion()
https://bugs.webkit.org/show_bug.cgi?id=81689

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

Source/WebCore:

The return value from this function is a region of opaque pixels in the
layer's content space that intersect with its visible rect. Rather than
adding a comment to this effect, renaming the method to make it clear.

platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::visibleContentOpaqueRegion):

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):

platform/graphics/chromium/TiledLayerChromium.h:
platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::visibleContentOpaqueRegion):

platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeOcclusionBehindLayer):

platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):

platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(WTF::TestLayerChromium::opaqueVisibleContents):

tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestContentLayerChromium::opaqueVisibleContents):
(WebCore::TestContentLayerImpl::opaqueVisibleContents):

tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

3:29 PM Changeset in webkit [112326] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] A unit test to verify clipping is honored when moving occlusion to parent surface
https://bugs.webkit.org/show_bug.cgi?id=81783

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

tests/CCOcclusionTrackerTest.cpp:

(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebCore):
(CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping):
(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):

3:24 PM Changeset in webkit [112325] by commit-queue@webkit.org

10 edits in trunk/Source

Scrollable plugins not registered properly in ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=82163

Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Anders Carlsson.

Source/WebCore:

Whenever a ScrollableArea is added or removed from a FrameView's ScrollableAreaSet, we have to recalculate the
nonFastScrollableRegion. This can happen for certain types of plugins that are scrollable.

This also reverts 112142 which was a not quite right way to handle these plugins.

page/FrameView.cpp:

(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
(WebCore):

page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

plugins/PluginViewBase.h:

Source/WebKit/chromium:

Since ScrollbarGroups are ScrollableAreas, they need to be able to report their bounds for the
ScrollingCoordinator's calculateNonFastScrollableRegion. This also changes ScrollbarGroups to only be registered
as ScrollableAreas on the FrameView's set when they actually have Scrollbars.

src/ScrollbarGroup.cpp:

(WebKit::ScrollbarGroup::ScrollbarGroup):
(WebKit::ScrollbarGroup::~ScrollbarGroup):
(WebKit::ScrollbarGroup::scrollbarCreated):
(WebKit::ScrollbarGroup::scrollbarDestroyed):
(WebKit::ScrollbarGroup::setFrameRect):
(WebKit):
(WebKit::ScrollbarGroup::scrollableAreaBoundingBox):

src/ScrollbarGroup.h:

(ScrollbarGroup):

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::reportGeometry):
(WebKit):
(WebKit::WebPluginContainerImpl::scrollbarGroup):

src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

3:21 PM Changeset in webkit [112324] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Remove a bunch of lines that are no longer failing.

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

3:13 PM Changeset in webkit [112323] by adamk@chromium.org

3 edits
2 adds in trunk

Hold a reference to refChild in insertBefore before calling collectChildrenAndRemoveFromOldParent
https://bugs.webkit.org/show_bug.cgi?id=82377

Reviewed by Ryosuke Niwa.

Source/WebCore:

This fixes a regression from r111925.

Test: fast/dom/insertBefore-refChild-crash.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore): Move the 'next' RefPtr above the call to
collectChildrenAndRemoveFromOldParent and rename refChildPreviousSibling
to 'prev' (matching appendChild and replaceChild).

LayoutTests:

fast/dom/insertBefore-refChild-crash-expected.txt: Added.
fast/dom/insertBefore-refChild-crash.html: Added.

3:07 PM Changeset in webkit [112322] by Simon Fraser

2 edits in trunk/Tools

Improve error reporting in run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=82379

Reviewed by Jessie Berlin.

When the script dies, have it print out the reason for dying.

Scripts/run-javascriptcore-tests:

3:01 PM Changeset in webkit [112321] by rniwa@webkit.org

5 edits in trunk

cssText should not generate literal 'initial' in shorthand properties
https://bugs.webkit.org/show_bug.cgi?id=82364

Reviewed by Antti Koivisto.

Source/WebCore:

Fixed the bug by treating initial value as if the value is not set.
While this is incorrect for properties that inherits by default,
it's strictly better than generating unparsable value as we do today.

The proper fix is for CSSInitialValue::cssText to fetch the respective
default value from what's currently in CSSStyleSelector code but that requires
a considerable amount of refactoring and work.

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):

LayoutTests:

fast/css/cssText-shorthand-expected.txt: Rebaselined.
fast/css/cssText-shorthand.html:

2:54 PM Changeset in webkit [112320] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG OSR exit should not generate an exit for variables of inlinees if the
inlinees are not in scope
https://bugs.webkit.org/show_bug.cgi?id=82312

Reviewed by Oliver Hunt.

bytecode/CodeBlock.h:

(JSC::baselineCodeBlockForInlineCallFrame):
(JSC):
(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):

dfg/DFGOSRExit.cpp:

(JSC::DFG::computeNumVariablesForCodeOrigin):
(DFG):
(JSC::DFG::OSRExit::OSRExit):

2:39 PM Changeset in webkit [112319] by eric@webkit.org

2 edits in trunk/Tools

Add Dave Barton to the Contributors list so I can more easily CC him on bugs
https://bugs.webkit.org/show_bug.cgi?id=82373

Reviewed by Ryosuke Niwa.

Dave's committer-status in in-progress, so until then
list him as a Contributor so at least I can more easily CC him on bugs.

Scripts/webkitpy/common/config/committers.py:

2:38 PM Changeset in webkit [112318] by adamk@chromium.org

14 edits in trunk/Source/WebCore

Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
https://bugs.webkit.org/show_bug.cgi?id=82256

Reviewed by Adam Barth.

This moves leakRef() calls out of generated code, centralizing them in
V8DOMWrapper implementation. Ideally, WeakReferenceMap::set would take
PassRefPtrs, but that's tricky given that some WeakReferenceMap's KeyType is 'void'
(which clearly can't be wrapped in a PassRefPtr).

Updated binding tests to reflect changes in CodeGeneratorV8.pm, no change in behavior.

Relanding r112207 with setJSWrapperForDOMSVGElementInstance defined
out-of-line to avoid SVG header dependencies.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback): Use GetDomMapFunction instead of custom logic.
(GenerateNamedConstructorCallback): ditto.
(GenerateToV8Converters): Call V8DOMWrapper::setJSWrapper* method
instead of directly accessing the wrapper maps and calling set.
(GetDomMapFunction): Refactored to call new GetDomWrapperMapName function.
(GetDomWrapperMapName): Helper pulled out of GetDomMapFunction.

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::wrapSlow):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/v8/V8DOMWrapper.cpp: Moved setJSWrapperForDOMNode method to header to inline it.

(WebCore::V8DOMWrapper::setJSWrapperForDOMSVGElementInstance): New helper method for SVGElementInstances.
Not inline to avoid header dependency on SVGElementInstance.h.

bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Made inline.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): ditto.
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Refactored into two methods;
this one handles non-active Nodes.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): Pulled out of previouse
DOMNode method, now handles only active Nodes.

2:34 PM Changeset in webkit [112317] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/chromium

[chromium] Make use of common animation unit test methods
https://bugs.webkit.org/show_bug.cgi?id=82357

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

tests/CCAnimationTestCommon.cpp:

(WebKitTests::addAnimatedTransformToController):
(WebKitTests):

tests/CCAnimationTestCommon.h:

(WebKitTests):

tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):

tests/CCOcclusionTrackerTest.cpp:

(WebKitTests):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):

2:34 PM Changeset in webkit [112316] by leviw@chromium.org

3 edits in trunk/Source/WebCore

Correct LayoutUnit usage in virtual function layoutBlock in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=82344

Reviewed by Eric Seidel.

Correcting the signature of RenderFlexibleBox::layoutBlock to use a LayoutUnit
for the page height, and avoiding assigning the renderer's size to an IntSize.

No new tests. No change in behavior.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

2:29 PM Changeset in webkit [112315] by timothy@apple.com

1 edit in trunk/Source/WebCore/platform/mac/SoftLinking.h

Fix a missing block call that was found post review.

2:29 PM Changeset in webkit [112314] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Change media/track/track-delete-during-startup bug #

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

2:15 PM Changeset in webkit [112313] by mlilek@apple.com

2 edits in trunk/Source/JavaScriptCore

Stop compiling Interpreter.cpp with -fno-var-tracking
https://bugs.webkit.org/show_bug.cgi?id=82299

Reviewed by Anders Carlsson.

JavaScriptCore.xcodeproj/project.pbxproj:

2:01 PM Writing Layout Tests for DumpRenderTree edited by tomz@codeaurora.org

(diff)

1:44 PM Changeset in webkit [112312] by timothy@apple.com

7 edits in trunk/Source

Make WebKit properly load a staged framework when soft linking.

https://webkit.org/b/82371
rdar://problem/11125989

Reviewed by Dan Bernstein.

Source/WebCore:

platform/mac/SoftLinking.h: Replaced SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL with

SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL and made it use the StagedFrameworks path
if the first dlopen failed.

Source/WebKit/mac:

WebCoreSupport/WebInspectorClient.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly

load the WebInspector framework.

Source/WebKit2:

UIProcess/mac/WebInspectorProxyMac.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly

load the WebInspector framework.

WebProcess/WebPage/mac/WebInspectorMac.mm: Ditto.

1:33 PM Changeset in webkit [112311] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Mark media/track/track-delete-during-startup as crashing in debug.

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

1:33 PM Changeset in webkit [112310] by krit@webkit.org

10 edits
1 add in trunk/Source/WebCore

Use enumeration for CSS parser mode
https://bugs.webkit.org/show_bug.cgi?id=82056

Reviewed by Antti Koivisto.

Introduce a new CSSParserMode enum to differ between strict / quirks and SVG presentation
attribute parsing modes.
The followup patch will make use of the enum in all other classes.
After that it will be easier possible to reuse the CSS parser in SVG as much as possible and
introduce SVG specific functionality.

No new tests. No change on functionality yet. This is just a refactoring to use the enumeration.

GNUmakefile.list.am: Added new file CSSParserMode.h with the new enum, which can be used by any caller of CSSParser, CSSStyleSheet and others.
Target.pri: Ditto.
WebCore.gypi: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
css/CSSGrammar.y: Make use of the new enumeration.
css/CSSParser.cpp: Replaced boolean by enumeration. No change of functionality at this point of time.

(WebCore::CSSParser::inStrictMode): Helper function.
(WebCore):
(WebCore::CSSParser::inQuirksMode): Helper function.
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::checkForOrphanedUnits):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseAnimationDelay):
(WebCore::CSSParser::parseAnimationDuration):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseWrapShapeRect):
(WebCore::CSSParser::parseWrapShapeCircle):
(WebCore::CSSParser::parseWrapShapeEllipse):
(WebCore::CSSParser::parseWrapShapePolygon):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontWeight):
(WebCore::CSSParser::parseColorParameters):
(WebCore::CSSParser::parseHSLParameters):
(WebCore::CSSParser::parseColorFromValue):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseFlex):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseAspectRatio):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseGradientColorStops):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseBuiltinFilterArguments):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):

css/CSSParser.h:

(CSSParser):

css/CSSParserMode.h: Added. New enumeration CSSParserMode.
css/SVGCSSParser.cpp: Use new SVGAttributeMode CSS parsing mode.

(WebCore::CSSParser::parseSVGValue):
(WebCore::CSSParser::parseSVGStrokeDasharray):

1:33 PM Changeset in webkit [112309] by kubo@profusion.mobi

3 edits in trunk/Tools

[jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
https://bugs.webkit.org/show_bug.cgi?id=82252

Reviewed by Gustavo Noronha Silva.

Appending the directory containing common.py may be problematic if
another path in sys.path also contains either a common.py or a
common/ module, so prepend to select our version instead. This is
the case with fail2ban, which has a common/ directory which may
end up being in Python's default path.

efl/jhbuildrc:
gtk/jhbuildrc:

1:30 PM Changeset in webkit [112308] by Nate Chapin

5 edits in trunk/Source/WebCore

2012-03-27 Nate Chapin <Nate Chapin>

Don't manually set an identifier for main resource
loads in FrameLoader. ResourceLoader::willSendRequest()
will set an identifier for the request if one isn't found,
so this code appears to be unnecessary duplication.
https://bugs.webkit.org/show_bug.cgi?id=82248

Reviewed by Adam Barth.

No new tests, no functionality change intended.

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::startLoadingMainResource): Mark navigation start

here, since it's conceptually part of starting the main resource load.

loader/DocumentLoader.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Remove duplicate identifier

logic, and move navigation timing call to startLoadingMainResource, since
it fits better logically there.

loader/ResourceLoader.h: No callers of setIdentifier() remain, so delete it.

1:20 PM Changeset in webkit [112307] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, expectations change.

Mark css3/filters/custom/effect-custom-parameters.html as an image failure on linux debug, 32-bit

platform/chromium/test_expectations.txt:

1:18 PM Changeset in webkit [112306] by dpranke@chromium.org

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r112277.
http://trac.webkit.org/changeset/112277
https://bugs.webkit.org/show_bug.cgi?id=81985

possibly causing crashes?

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::finishParsingChildren):

xml/XMLErrors.cpp:

(WebCore::XMLErrors::insertErrorMessageBlock):

1:08 PM Changeset in webkit [112305] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

<http://webkit.org/b/82362> Web Inspector: Provide private -[DOMNode inspect]

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-03-27
Reviewed by Timothy Hatcher.

No new tests, this is only an ObjC SPI.

bindings/objc/DOM.mm:
bindings/objc/DOMPrivate.h:

(-[DOMNode inspect]):
Call through to InspectorController inspect for the node.

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::inspect):
Whenever we inspect an element, clear the node search.
The frontend already takes this approach.

1:06 PM Changeset in webkit [112304] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[BlackBerry] fix confusing destruction sequence in LayerCompositingThread
https://bugs.webkit.org/show_bug.cgi?id=81706

Patch by Joe Mason <jmason@rim.com> on 2012-03-27
Reviewed by Rob Buis.

LayerCompositingThread has a destructor that does a synchronous
dispatch to the compositing thread and then does the actual cleanup
from a helper function. This is confusing.It should be the
opposite: the helper function dispatches to the compositing thread,
which calls delete.

No new tests since the existing animation tests will exercise this
code.

platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::destroyOnCompositingThread):
(WebCore):
(WebCore::LayerCompositingThread::~LayerCompositingThread):

platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):
(WTF):
(WTF::::deref):

12:36 PM Changeset in webkit [112303] by commit-queue@webkit.org

4 edits in trunk

Show image diffs for gpu_tests on flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=81848

Patch by Dave Tu <dtu@chromium.org> on 2012-03-27
Reviewed by Ojan Vafai.

Add a new results layout for gpu_tests that pulls the image diffs in
addition to the text output. Also add new gpu_tests builders.

Tools/TestResultServer/static-dashboards/builders.js: Update

gpu_tests builders.

Tools/TestResultServer/static-dashboards/dashboard_base.js: Add a

function to check for GPU test type.

Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:

Add new GPU results layout.

12:32 PM Changeset in webkit [112302] by ap@apple.com

2 edits in trunk/Source/WebCore

[Mac] Stop using NSMapTable in FormDataStreamMac.mm
https://bugs.webkit.org/show_bug.cgi?id=82358

Reviewed by Darin Adler.

platform/network/mac/FormDataStreamMac.mm: Use WTF::HashMap, as we always do. All accesses are protected with a mutex anyway.

12:19 PM Changeset in webkit [112301] by commit-queue@webkit.org

44 edits
14 adds in trunk

Implement vw/vh/vmin (viewport sizes) from CSS3 Values and Units
https://bugs.webkit.org/show_bug.cgi?id=27160

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-27
Reviewed by Antti Koivisto.

vw/vh/vmin are implemented as primitive length units. Added the parsing logic for these new units.
New Length types such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin are added for these length units
and included the support for fetching the value of these relative units based on the current viewport size.

The specification related to this implementation is http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths.

Source/WebCore:

Tests: css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html

css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html

accessibility/gtk/WebKitAccessibleInterfaceText.cpp: Modified to support viewport relative Length types.

(getAttributeSetForAccessibilityObject):

css/CSSComputedStyleDeclaration.cpp: Ditto.

(WebCore::getPositionOffsetValue):
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::lineHeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSGrammar.y: Added vw/vh/vmin support.
css/CSSParser.cpp: Parsing of relative units and creation of CSSPrimitiveValue.

(WebCore::CSSParser::validUnit): Added vw/vh/vmin to the valid units.
(WebCore::CSSParser::createPrimitiveNumericValue): Added vw/vh/vmin as valid primitive units.
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive): Creation of CSSPrimitiveValue for vw/vh/vmin.
(WebCore::CSSParser::detectNumberToken): Parsing the vw/vh/vmin tokens.

css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion): Added support for vw/vh/vmin.
(WebCore::unitCategory): Ditto.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): Added support for vw/vh/vmin.
(WebCore::CSSPrimitiveValue::customCssText): Ditto.
(WebCore::CSSPrimitiveValue::viewportRelativeLength): Function to create the Length structure for the viewport-relative unit types.
(WebCore):

css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isViewportRelativeLength): Checks whether the primitive value is ViewportRelative Lengths.
(CSSPrimitiveValue):

css/CSSPrimitiveValue.idl: Added support for vw/vh/vmin.
css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength): Ditto.

css/CSSStyleApplyProperty.cpp: Applying relative viewport length units to the specific CSS property.

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):

css/CSSStyleSelector.cpp: Added support for viewport relative units.
css/LengthFunctions.cpp: Calcuation of length value based on the current viewport size.

(WebCore::miminumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):

css/LengthFunctions.h: Added new RenderView argument.

(WebCore):

dom/Document.cpp:

(WebCore::Document::pageSizeAndMarginsInPixels): Modified to support viewport relative Length types.
(WebCore::Document::viewportSize): New function to fetch the current viewport size.
(WebCore):

dom/Document.h: Ditto.

(Document):

html/HTMLAreaElement.cpp: Modified to support viewport relative Length types.

(WebCore::HTMLAreaElement::getRegion):

platform/Length.h:

(WebCore::Length::isViewportRelative): To check the Length is of type ViewportRelative.
(WebCore::Length::viewportRelativeLength): To get the relative value.

rendering/RenderBR.cpp: Modified to support viewport relative Length types.

(WebCore::RenderBR::lineHeight):

rendering/RenderBlock.cpp: Ditto.

(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::lineHeight):

rendering/RenderBox.cpp: Ditto.

(WebCore::RenderBox::reflectionOffset):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeContentLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

rendering/RenderBoxModelObject.cpp: Ditto.

(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::relativePositionOffsetY):
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::paintBoxShadow):

rendering/RenderFlexibleBox.cpp: Ditto.

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):

rendering/RenderInline.cpp: Ditto.

(WebCore::computeMargin):
(WebCore::RenderInline::lineHeight):

rendering/RenderMenuList.cpp: Ditto.

(WebCore::RenderMenuList::updateOptionsWidth):

rendering/RenderObject.cpp: Ditto.

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

rendering/RenderReplaced.cpp: Ditto.

(WebCore::RenderReplaced::paint):

rendering/RenderScrollbarPart.cpp: Ditto.

(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):

rendering/RenderTable.cpp: Ditto.

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):

rendering/RenderTableCell.cpp: Ditto.

(WebCore::RenderTableCell::logicalHeightForRowSizing):

rendering/RenderTableSection.cpp: Ditto.

(WebCore::RenderTableSection::calcRowLogicalHeight):

rendering/RenderText.h: Ditto.

(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):

rendering/RenderThemeMac.mm: Ditto.

(WebCore::RenderThemeMac::paintMenuListButtonGradients):

rendering/RenderView.h:

(WebCore::RenderView::viewportSize):

rendering/RenderWidget.cpp: Ditto.

(WebCore::RenderWidget::paint):

rendering/RootInlineBox.cpp: Ditto.

(WebCore::RootInlineBox::verticalPositionForBox):

rendering/style/RenderStyle.cpp: Ditto.

(WebCore::calcRadiiFor):
(WebCore::RenderStyle::getRoundedBorderFor):

rendering/style/RenderStyle.h: Ditto.
rendering/svg/RenderSVGRoot.cpp: Ditto.

(WebCore::resolveLengthAttributeForSVG):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Added.
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Added.
fast/dom/Window/window-properties-expected.txt:
platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/mac/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/win/fast/dom/Window/window-properties-expected.txt:

12:19 PM Changeset in webkit [112300] by dino@apple.com

60 edits
2 moves
21 adds in trunk/Source/ThirdParty/ANGLE

Update ANGLE in WebKit https://bugs.webkit.org/show_bug.cgi?id=81717

Reviewed by Kenneth Russell.

Update angleproject to r1009. Synced the source directory
between the angle repository and WebKit. Ran the OS X Lion
version of Bison over the glslang.l input which generates
a slightly different output than angle provided.

Converted tabs to spaces in preprocessor/new files.

include/EGL/eglext.h:
include/GLES2/gl2ext.h:
include/GLSLANG/ShaderLang.h:
src/common/RefCountObject.cpp: Renamed from Source/ThirdParty/ANGLE/src/libGLESv2/RefCountObject.cpp.

(RefCountObject::RefCountObject):
(RefCountObject::~RefCountObject):
(RefCountObject::addRef):
(RefCountObject::release):
(RefCountObjectBindingPointer::set):

src/common/RefCountObject.h: Renamed from Source/ThirdParty/ANGLE/src/libGLESv2/RefCountObject.h.

(RefCountObject):
(RefCountObject::id):
(RefCountObjectBindingPointer):
(RefCountObjectBindingPointer::RefCountObjectBindingPointer):
(RefCountObjectBindingPointer::~RefCountObjectBindingPointer):
(RefCountObjectBindingPointer::get):
(RefCountObjectBindingPointer::id):
(RefCountObjectBindingPointer::operator ! ):
(BindingPointer):
(BindingPointer::set):
(BindingPointer::get):
(BindingPointer::operator -> ):

src/common/debug.cpp:

(gl::output):

src/common/version.h:
src/compiler/BaseTypes.h:
src/compiler/Compiler.cpp:

(TCompiler::TCompiler):
(TCompiler::~TCompiler):
(TCompiler::mapLongVariableNames):

src/compiler/ConstantUnion.h:

(ConstantUnion::ConstantUnion):
(ConstantUnion::operator==):
(ConstantUnion::operator>):
(ConstantUnion::operator<):

src/compiler/Intermediate.cpp:

(TIntermConstantUnion::fold):

src/compiler/MapLongVariableNames.cpp:

(LongNameMap::LongNameMap):
(LongNameMap::~LongNameMap):
(LongNameMap::GetInstance):
(LongNameMap::Release):
(LongNameMap::Find):
(LongNameMap::Insert):
(LongNameMap::Size):
(MapLongVariableNames::MapLongVariableNames):
(MapLongVariableNames::visitSymbol):
(MapLongVariableNames::mapGlobalLongName):

src/compiler/MapLongVariableNames.h:

(LongNameMap):
(MapLongVariableNames):

src/compiler/OutputHLSL.cpp:

(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitSymbol):
(sh::OutputHLSL::visitUnary):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::typeString):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::decorateUniform):

src/compiler/OutputHLSL.h:

(OutputHLSL):

src/compiler/PoolAlloc.cpp:

(TAllocation::checkGuardBlock):

src/compiler/ShHandle.h:

(TCompiler):

src/compiler/SymbolTable.cpp:
src/compiler/SymbolTable.h:

(TSymbolTable):
(TSymbolTable::getOuterLevel):

src/compiler/VariableInfo.cpp:

(getVariableDataType):

src/compiler/glslang.l:
src/compiler/glslang.y:
src/compiler/glslang_lex.cpp:

(yy_buffer_state):
(yyguts_t):
(input):
(yyensure_buffer_stack):
(yy_scan_bytes):
(yyget_leng):

src/compiler/glslang_tab.cpp:
src/compiler/osinclude.h:
src/compiler/preprocessor/cpp.c:
src/compiler/preprocessor/memory.c:
src/compiler/preprocessor/new/Context.cpp: Added.

(isMacroNameReserved):
(pp):
(pp::Context::Context):
(pp::Context::~Context):
(pp::Context::init):
(pp::Context::process):
(pp::Context::defineMacro):
(pp::Context::undefineMacro):
(pp::Context::isMacroDefined):
(pp::Context::reset):
(pp::Context::defineBuiltInMacro):

src/compiler/preprocessor/new/Context.h: Added.

(pp):
(Context):
(pp::Context::lexer):
(pp::Context::output):

src/compiler/preprocessor/new/Input.cpp: Added.

(pp):
(pp::Input::Input):
(pp::Input::eof):
(pp::Input::read):
(pp::Input::getChar):
(pp::Input::peekChar):
(pp::Input::switchToNextString):
(pp::Input::isStringEmpty):
(pp::Input::stringLength):

src/compiler/preprocessor/new/Input.h: Added.

(pp):
(Input):
(pp::Input::error):
(pp::Input::stringIndex):

src/compiler/preprocessor/new/Macro.cpp: Added.

(pp):
(pp::Macro::Macro):
(pp::Macro::~Macro):

src/compiler/preprocessor/new/Macro.h: Added.

(pp):
(Macro):
(pp::Macro::type):
(pp::Macro::identifier):
(pp::Macro::parameters):
(pp::Macro::replacements):

src/compiler/preprocessor/new/Preprocessor.cpp: Added.

(pp):
(pp::Preprocessor::Preprocessor):
(pp::Preprocessor::~Preprocessor):
(pp::Preprocessor::init):
(pp::Preprocessor::process):
(pp::Preprocessor::reset):

src/compiler/preprocessor/new/Preprocessor.h: Added.

(pp):
(Preprocessor):
(pp::Preprocessor::begin):
(pp::Preprocessor::end):

src/compiler/preprocessor/new/Token.cpp: Added.

(pp):
(pp::Token::encodeLocation):
(pp::Token::decodeLocation):
(pp::Token::Token):
(pp::Token::~Token):
(pp::operator<<):

src/compiler/preprocessor/new/Token.h: Added.

(pp):
(Token):
(pp::Token::location):
(pp::Token::type):
(pp::Token::value):

src/compiler/preprocessor/new/generate_parser.sh: Added.
src/compiler/preprocessor/new/pp.l: Added.
src/compiler/preprocessor/new/pp.y: Added.
src/compiler/preprocessor/new/pp_lex.cpp: Added.

(yy_buffer_state):
(yy_trans_info):
(yyguts_t):
(yy_get_previous_state):
(yy_try_NUL_trans):
(input):
(pprestart):
(pp_switch_to_buffer):
(pp_load_buffer_state):
(pp_create_buffer):
(pp_delete_buffer):
(pp_init_buffer):
(pp_flush_buffer):
(pppush_buffer_state):
(pppop_buffer_state):
(ppensure_buffer_stack):
(pp_scan_buffer):
(pp_scan_string):
(pp_scan_bytes):
(yy_push_state):
(yy_pop_state):
(yy_top_state):
(yy_fatal_error):
(ppget_extra):
(ppget_lineno):
(ppget_column):
(ppget_in):
(ppget_out):
(ppget_leng):
(ppget_text):
(ppset_extra):
(ppset_lineno):
(ppset_column):
(ppset_in):
(ppset_out):
(ppget_debug):
(ppset_debug):
(ppget_lval):
(ppset_lval):
(ppget_lloc):
(ppset_lloc):
(pplex_init):
(pplex_init_extra):
(yy_init_globals):
(pplex_destroy):
(yy_flex_strncpy):
(yy_flex_strlen):
(ppalloc):
(pprealloc):
(ppfree):
(extractMacroName):
(pp):
(pp::Context::readInput):
(pp::Context::initLexer):
(pp::Context::destroyLexer):

src/compiler/preprocessor/new/pp_tab.cpp: Added.

(YYLTYPE):
(yysyntax_error):
(yyerror):
(pushConditionalBlock):
(popConditionalBlock):
(pp::Context::parse):

src/compiler/preprocessor/new/pp_tab.h: Added.

(YYLTYPE):

src/compiler/preprocessor/new/stl_utils.h: Added.

(pp):
(Delete):
(pp::Delete::operator()):
(DeleteSecond):
(pp::DeleteSecond::operator()):

src/compiler/preprocessor/new/token_type.h: Added.
src/compiler/preprocessor/scanner.c:

(yylex_CPP):

src/compiler/preprocessor/symbols.c:
src/compiler/preprocessor/tokens.c:
src/libEGL/Config.cpp:

(egl::ConfigSet::getConfigs):

src/libEGL/Display.cpp:

(egl::Display::initialize):
(egl::Display::terminate):
(egl::Display::restoreLostDevice):
(egl::Display::sync):
(egl):
(egl::Display::allocateEventQuery):
(egl::Display::freeEventQuery):
(egl::Display::getFloat32TextureSupport):
(egl::Display::getFloat16TextureSupport):
(egl::Display::getEventQuerySupport):
(egl::Display::initExtensionString):
(egl::Display::shareHandleSupported):
(egl::Display::getOcclusionQuerySupport):
(egl::Display::getInstancingSupport):

src/libEGL/Display.h:

(Display):
(egl::Display::isD3d9ExDevice):

src/libEGL/Surface.cpp:

(egl::Surface::resetSwapChain):

src/libEGL/libEGL.cpp:
src/libEGL/libEGL.vcproj:
src/libGLESv2/Blit.cpp:

(gl::Blit::setCommonBlitState):

src/libGLESv2/Buffer.h:

(Buffer):

src/libGLESv2/Context.cpp:

(gl::Context::Context):
(gl::Context::~Context):
(gl::Context::makeCurrent):
(gl::Context::getActiveQuery):
(gl):
(gl::Context::createFence):
(gl::Context::createQuery):
(gl::Context::deleteQuery):
(gl::Context::beginQuery):
(gl::Context::endQuery):
(gl::Context::getQuery):
(gl::Context::applyVertexBuffer):
(gl::Context::applyIndexBuffer):
(gl::Context::readPixels):
(gl::Context::clear):
(gl::Context::drawArrays):
(gl::Context::drawElements):
(gl::Context::sync):
(gl::Context::drawLineLoop):
(gl::Context::supportsOcclusionQueries):
(gl::Context::supportsInstancing):
(gl::Context::setVertexAttribDivisor):
(gl::Context::initExtensionString):
(gl::VertexDeclarationCache::applyDeclaration):
(gl::VertexDeclarationCache::markStateDirty):

src/libGLESv2/Context.h:

(gl):
(gl::VertexAttribute::VertexAttribute):
(State):
(VertexDeclarationCache):
(Context):

src/libGLESv2/Fence.cpp:

(gl::Fence::Fence):
(gl::Fence::~Fence):
(gl::Fence::setFence):

src/libGLESv2/Fence.h:

(egl):
(Fence):

src/libGLESv2/Framebuffer.cpp:

(gl::Framebuffer::lookupRenderbuffer):
(gl::Framebuffer::detachTexture):
(gl::Framebuffer::completeness):

src/libGLESv2/Framebuffer.h:
src/libGLESv2/IndexDataManager.cpp:

(gl::IndexDataManager::IndexDataManager):
(gl::IndexDataManager::~IndexDataManager):
(gl::computeRange):
(gl::IndexDataManager::prepareIndexData):
(gl::IndexDataManager::getCountingIndices):
(gl):

src/libGLESv2/IndexDataManager.h:

(IndexDataManager):

src/libGLESv2/Program.cpp:

(gl::Program::getUniformLocation):
(gl::Program::setUniform1fv):
(gl::Program::setUniform2fv):
(gl::Program::setUniform3fv):
(gl::Program::setUniform4fv):
(gl::Program::setUniform1iv):
(gl::Program::setUniform2iv):
(gl::Program::setUniform3iv):
(gl::Program::setUniform4iv):
(gl::Program::packVaryings):
(gl::Program::linkVaryings):
(gl::Program::defineUniform):
(gl::Program::createUniform):
(gl::Program::applyUniformnbv):
(gl::Program::applyUniform1iv):
(gl::Program::applyUniform2iv):
(gl::Program::applyUniform3iv):
(gl::Program::applyUniform4iv):
(gl::Program::getInfoLog):

src/libGLESv2/Program.h:

(Program):

src/libGLESv2/Query.cpp: Added.

(gl):
(gl::Query::Query):
(gl::Query::~Query):
(gl::Query::begin):
(gl::Query::end):
(gl::Query::getResult):
(gl::Query::isResultAvailable):
(gl::Query::getType):
(gl::Query::testQuery):

src/libGLESv2/Query.h: Added.

(gl):
(Query):

src/libGLESv2/Renderbuffer.cpp:

(gl):
(gl::RenderbufferInterface::addProxyRef):
(gl::RenderbufferInterface::releaseProxy):
(gl::RenderbufferTexture::RenderbufferTexture):
(gl::RenderbufferTexture::~RenderbufferTexture):
(gl::RenderbufferTexture::addProxyRef):
(gl::RenderbufferTexture::releaseProxy):
(gl::Renderbuffer::addRef):
(gl::Renderbuffer::release):

src/libGLESv2/Renderbuffer.h:

(gl):
(RenderbufferInterface):
(RenderbufferTexture):
(Renderbuffer):

src/libGLESv2/Shader.cpp:

(gl::Shader::Shader):
(gl::Shader::getInfoLog):
(gl::Shader::getSourceImpl):
(gl):
(gl::Shader::initializeCompiler):
(gl::Shader::parseVaryings):
(gl::Shader::uncompile):
(gl::Shader::compileToHLSL):
(gl::VertexShader::uncompile):
(gl::VertexShader::compile):
(gl::VertexShader::parseAttributes):
(gl::FragmentShader::compile):

src/libGLESv2/Shader.h:

(Shader):
(VertexShader):

src/libGLESv2/Texture.cpp:

(gl::Texture2D::Texture2D):
(gl::Texture2D::~Texture2D):
(gl):
(gl::Texture2D::addProxyRef):
(gl::Texture2D::releaseProxy):
(gl::Texture2D::getRenderbuffer):
(gl::TextureCubeMap::TextureCubeMap):
(gl::TextureCubeMap::~TextureCubeMap):
(gl::TextureCubeMap::addProxyRef):
(gl::TextureCubeMap::releaseProxy):
(gl::TextureCubeMap::isSamplerComplete):
(gl::TextureCubeMap::convertToRenderTarget):
(gl::TextureCubeMap::getRenderbuffer):

src/libGLESv2/Texture.h:

(Texture):
(Texture2D):
(TextureCubeMap):

src/libGLESv2/VertexDataManager.cpp:

(gl::VertexDataManager::writeAttributeData):
(gl::VertexDataManager::prepareVertexData):
(gl::VertexDataManager::spaceRequired):
(gl):

src/libGLESv2/VertexDataManager.h:

(TranslatedAttribute):
(VertexDataManager):

src/libGLESv2/libGLESv2.cpp:
src/libGLESv2/libGLESv2.def:
src/libGLESv2/libGLESv2.vcproj:
src/libGLESv2/utilities.cpp:

(gl::IsInternalTextureTarget):

src/libGLESv2/utilities.h:

(gl):

12:16 PM Changeset in webkit [112299] by commit-queue@webkit.org

14 edits
6 deletes in trunk/Source/WebCore

Remove deprecated LowPass2FilterNode and HighPass2FilterNode
https://bugs.webkit.org/show_bug.cgi?id=82296

Patch by Gao Chun <chun.gao@intel.com> on 2012-03-27
Reviewed by Chris Rogers.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Modules/webaudio/AudioContext.cpp:
Modules/webaudio/AudioContext.h:

(WebCore):
(AudioContext):

Modules/webaudio/AudioContext.idl:
Modules/webaudio/AudioNode.h:
Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::BiquadFilterNode):

Modules/webaudio/BiquadProcessor.cpp:
Modules/webaudio/BiquadProcessor.h:
Modules/webaudio/HighPass2FilterNode.cpp: Removed.
Modules/webaudio/HighPass2FilterNode.h: Removed.
Modules/webaudio/HighPass2FilterNode.idl: Removed.
Modules/webaudio/LowPass2FilterNode.cpp: Removed.
Modules/webaudio/LowPass2FilterNode.h: Removed.
Modules/webaudio/LowPass2FilterNode.idl: Removed.
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:

12:15 PM Changeset in webkit [112298] by dpranke@chromium.org

2 edits
2 adds in trunk/Tools

test-webkitpy: prepare for better test run output
https://bugs.webkit.org/show_bug.cgi?id=82290

Reviewed by Adam Barth.

This code basically re-implements the output of the TextTestRunner default
runner code from unittest, although the implementation is quite
different, in preparation for changing the test output to be
metered and possibly running in parallel.

The output is almost identical to before, except that instead of
logging "test_regular (webkitpy.main.RunnerTest) passed" we log
"webkitpy.main.RunnerTest.test_regular passed". It has always
annoyed me that they invert the names to be harder to read and
so that you can't copy & paste back to the input for
test-webkitpy.

This patch is provided to add a skeleton for unit tests and for
comparison to an upcoming patch that will actually add new
functionality.

Scripts/webkitpy/test/main.py:

(Tester.init):
(Tester._configure_logging):
(Tester._run_tests):

Scripts/webkitpy/test/runner.py: Added.

(TestRunner):
(TestRunner.init):
(TestRunner.test_name):
(TestRunner.all_test_names):
(TestRunner.run):
(TestRunner.write_result):
(TestRunner.write_summary):

Scripts/webkitpy/test/runner_unittest.py: Added.

(FakeModuleSuite):
(FakeModuleSuite.init):
(FakeModuleSuite.str):
(FakeModuleSuite.run):
(FakeTopSuite):
(FakeTopSuite.init):
(FakeLoader):
(FakeLoader.init):
(FakeLoader.top_suite):
(FakeLoader.loadTestsFromName):
(RunnerTest):
(RunnerTest.test_regular):
(RunnerTest.test_verbose):

12:08 PM Changeset in webkit [112297] by Martin Robinson

1 copy in releases/WebKitGTK/webkit-1.7.92

Tagging the WebKitGTK+ 1.7.92 release

12:07 PM Changeset in webkit [112296] by Martin Robinson

1 delete in releases/WebKitGTK/webkit-1.8.0/webkit-1.8

Removing improperly tagged WebKitGTK+ release

11:59 AM Changeset in webkit [112295] by Martin Robinson

1 copy in releases/WebKitGTK/webkit-1.7.91

Tagging the WebKitGTK+ 1.7.91 release

11:58 AM Changeset in webkit [112294] by kov@webkit.org

2 edits in trunk/Tools

[GTK] Build gnutls without p11-kit support
https://bugs.webkit.org/show_bug.cgi?id=82212

Reviewed by Martin Robinson.

gtk/jhbuild.modules: pass --without-p11-kit to gnutls'

configure, to avoid requiring that dependency, which is not used
by libsoup and WebKit anyway

11:56 AM Changeset in webkit [112293] by Martin Robinson

1 copy in releases/WebKitGTK/webkit-1.8.0/webkit-1.8

Tagging the 1.8.0 release

11:54 AM Changeset in webkit [112292] by Martin Robinson

1 copy in releases/WebKitGTK/webkit-1.8.0

Tagging the 1.8.0 release

11:49 AM Changeset in webkit [112291] by Lucas Forschler

3 edits
2 copies in tags/Safari-536.4.1/Source

Merge 111898.

11:45 AM Changeset in webkit [112290] by Lucas Forschler

4 edits in tags/Safari-536.4.1/Source

Versioning.

11:42 AM Changeset in webkit [112289] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Don't update the layer hosting state unless the WKView is added to a window
https://bugs.webkit.org/show_bug.cgi?id=82359

Reviewed by Sam Weinig.

This avoids thrashing the layer hosting state when switching tabs.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

11:41 AM Changeset in webkit [112288] by Lucas Forschler

1 copy in tags/Safari-536.4.1

New Tag.

11:39 AM Changeset in webkit [112287] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Switch WebPageCompositor to use AnimationFrameRateController instead of timer
https://bugs.webkit.org/show_bug.cgi?id=82350

Switch timer in WebPageCompositor to use AnimationFrameRateController.

Patch by Andrew Lo <anlo@rim.com> on 2012-03-27
Reviewed by Rob Buis.

Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):

Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

11:18 AM Changeset in webkit [112286] by commit-queue@webkit.org

16 edits
3 adds in trunk/Source

[chromium] Add TextureCopier for copying texture contents
https://bugs.webkit.org/show_bug.cgi?id=80870

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-27
Reviewed by Stephen White.

Source/WebCore:

This patch introduces a TextureCopier class whose job is to copy the
contents from one GL texture to another using the most efficient means
for the current GPU. This version uses render-to-texture to do the copy,
but a path based on EXT_framebuffer_blit can be added later.

The class is intended to replace the use of image path operations such
as glCopyTex{Sub}Image2D for duplicating texture contents. The reason is
that such functions may not be very well optimized in some -- mainly
mobile -- GPU drivers.

With this patch the new copier is used just for Canvas2D layer
presentation, but another potential use is for WebGL layer presentation.

Test: webkit_unit_tests: TextureCopierTest

WebCore.gypi:
platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):

platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initializeSharedObjects):

platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(WebCore::LayerRendererChromium::textureCopier):
(LayerRendererChromium):

platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexIdentity::getShaderString):
(WebCore):
(WebCore::FragmentShaderRGBATexCopy::getShaderString):

platform/graphics/chromium/ShaderChromium.h:

(VertexShaderPosTexIdentity):
(WebCore::VertexShaderPosTexIdentity::init):
(WebCore):
(FragmentShaderRGBATexCopy):

platform/graphics/chromium/TextureCopier.cpp: Added.

(WebCore):
(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::~AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):

platform/graphics/chromium/TextureCopier.h: Added.

(WebCore):
(TextureCopier):
(WebCore::TextureCopier::~TextureCopier):
(AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::create):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):

platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::CCTextureUpdater):

platform/graphics/chromium/cc/CCTextureUpdater.h:

(WebCore):
(CCTextureUpdater):
(WebCore::CCTextureUpdater::copier):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

Source/WebKit/chromium:

Add new test for TextureCopier.

WebKit.gypi:
tests/Canvas2DLayerChromiumTest.cpp:
tests/TextureCopierTest.cpp: Added.
tests/TiledLayerChromiumTest.cpp:

(FakeTextureCopier):
(WTF::FakeTextureCopier::copyTexture):
(WTF):
(WTF::TEST):

11:06 AM Changeset in webkit [112285] by psolanki@apple.com

2 edits in trunk/Source/JavaScriptCore

Compiler warning when JIT is not enabled
https://bugs.webkit.org/show_bug.cgi?id=82352

Reviewed by Filip Pizlo.

runtime/JSFunction.cpp:

(JSC::JSFunction::create):

11:03 AM Changeset in webkit [112284] by leviw@chromium.org

3 edits in trunk/Source/WebCore

Correct SVG paint functions that are still using IntPoints
https://bugs.webkit.org/show_bug.cgi?id=82343

Reviewed by Eric Seidel.

Two small corrections to SVG paint functions that should use LayoutPoint instead
of IntPoint.

No new tests. No change in behavior.

rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::paint):

rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::paint):

11:00 AM Changeset in webkit [112283] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Frame flattening: childframe in FrameView::layout() needs protector.
https://bugs.webkit.org/show_bug.cgi?id=82345

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-27
Reviewed by Kenneth Rohde Christiansen.

RefPtr<FrameView> protector(this) is supposed to protect the current frameview in
FrameView::layout() from being destroyed by recalcStyle().
However, when frame flattening is on and a child frame is re-starting layout from
the topmost parent, the protection is missing and parent's recalcStyle()
can destroy the child frame.
Moving the protector before the layout re-starting is initiated makes the child frame
safe.

No new tests. Unable to create a test case, where this scenario is reproducible.

page/FrameView.cpp:

(WebCore::FrameView::layout):

10:47 AM Changeset in webkit [112282] by Csaba Osztrogonác

3 edits in trunk/Tools

[Qt] Make debug build work on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=82331

Use --no-keep-memory option of ld not to cache the symbol tables of input files in
memory to avoid memory exhaustion during the linking phase for x86-debug builds.

Reviewed by Tor Arne Vestbø.

qmake/mkspecs/features/unix/default_post.prf:
qmake/mkspecs/features/unix/default_pre.prf:

10:46 AM Changeset in webkit [112281] by Antti Koivisto

8 edits in trunk/Source/WebCore

Construct CSSCharsetRule on CSSOM API access only
https://bugs.webkit.org/show_bug.cgi?id=82332

Reviewed by Andreas Kling.

Charset is just a string. There is usually no need to construct CSSCharsetRule at all.

Make CSS parser to return encoding string instead of CSSCharsetRule object. This string is used for constructing CSSCharsetRule if it is needed (and nothing else, @charset has no effect after string decoding).
Remove internal interface for adding and removing rules. It has no clients.

css/CSSGrammar.y:
css/CSSParser.cpp:

(WebCore):

css/CSSParser.h:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::parserAppendRule):
(WebCore::CSSStyleSheet::ensureCharsetRule):
(WebCore):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::clearCharsetRule):
(WebCore::CSSStyleSheet::clearRules):
(WebCore::CSSStyleSheet::parserSetEncodingFromCharsetRule):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::deleteRule):

css/CSSStyleSheet.h:

(WebCore):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::ruleVector):
(WebCore::CSSStyleSheet::hasCharsetRule):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::reparseStyleSheet):

10:44 AM Changeset in webkit [112280] by kling@webkit.org

2 edits in trunk/LayoutTests

Unreviewed, skip fast/events/dropzone-005.html on mac-wk1.

It has been failing since its introduction and is skipped for every
port but chromium.

platform/mac/Skipped:

10:41 AM April 2012 Meeting edited by jacobg@adobe.com

(diff)

10:38 AM Changeset in webkit [112279] by Martin Robinson

4 edits in releases/WebKitGTK/webkit-1.8

Update the NEWS and version for the impending 1.8.0 release.

Reviewed by Gustavo Noronha Silva.

configure.ac: Update the version.

Source/WebKit/gtk:

NEWS: Update the news.

10:06 AM LayoutUnit edited by leviw@chromium.org

(diff)

10:02 AM Changeset in webkit [112278] by senorblanco@chromium.org

6 edits in trunk/Source

Source/WebCore: [chromium] Fix filter context creation to be more conservative.
https://bugs.webkit.org/show_bug.cgi?id=82349

Reviewed by James Robinson.

Covered by webkit_unit_tests, and css3/filters layout tests.

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setFilters):
Only request a filter context if the filter lists is non-empty.

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::setNeedsFilterContext):
Add a bool param, so tests can cancel a request for filter contexts.

Source/WebKit/chromium: [chromium] Fix filter context usage in webkit_unit_tests.
https://bugs.webkit.org/show_bug.cgi?id=82349

Reviewed by James Robinson.

tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
Cancel request for filter context after test run.
(WTF::TEST_F):

tests/CCOcclusionTrackerTest.cpp:

Re-enable CCLayerTreeHostTestSetSingleLostContext.runMultiThread.
(WebCore::CCOcclusionTrackerTest::TearDown):
Cancel request for filter context after test run.

9:12 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org

(diff)

8:58 AM Changeset in webkit [112277] by schenney@chromium.org

3 edits in trunk/Source/WebCore

Reviewed by Adam Barth.

The SVGUseElement was creating its shadow tree immediately upon
demand. This resulted in nodes being created that were not marked as
"createdByParser", even during parsing. As it happens, there is
already code in there to track "createdByParser" in the SVGUseElement,
it was just being ignored all the time. This may even have been
inefficient. Now we delay creating the shadow dom tree until children
are finished, which is the standard time to handle the createdByParser
flag.

I also verified that other SVG classes that derived from core DOM
classes that use the createdByParser flag do correctly pass this flag
on.

No new tests as this is covered by existing tests and does not have new behavior.

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::finishParsingChildren):

xml/XMLErrors.cpp:

(WebCore::XMLErrors::insertErrorMessageBlock):

8:56 AM Changeset in webkit [112276] by leviw@chromium.org

7 edits in branches/subpixellayout/Source/WebCore

Shrinking our patch by moving PaintRect::infiniteRect to LayoutRect::infiniteRect, and cleaning up SubframeLoader.

8:44 AM Changeset in webkit [112275] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Disable DisallowCType.h usage
https://bugs.webkit.org/show_bug.cgi?id=82211

Patch by Ming Xie <mxie@rim.com> on 2012-03-27
Reviewed by Rob Buis.

Build fix: QNX port does use ctype.h, so we should not
include <wtf/DisallowCType.h> in WebCore/config.h

No new tests - Build Fix

config.h:

8:41 AM Changeset in webkit [112274] by podivilov@chromium.org

3 edits in trunk/LayoutTests

Web Inspector: testSourceMapCouldNotBeLoaded logs different error messages on different platforms.
https://bugs.webkit.org/show_bug.cgi?id=82314

Reviewed by Vsevolod Vlasov.

http/tests/inspector/compiler-script-mapping.html:
platform/gtk/Skipped:

8:22 AM Changeset in webkit [112273] by Carlos Garcia Campos

2 edits
1 copy
1 move
1 add in trunk/Source/WebKit2

Implement WebFrameNetworkingContext for soup in WebKit2

[SOUP] Implement WebFrameNetworkingContext for soup in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=82081

Reviewed by Martin Robinson.

GNUmakefile.am: Add new files to compilation
WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h.

(WebKit::WebFrameNetworkingContext::soupSession): Return the
default SoupSession.

WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h.

(WebKit):
(WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::create): Create a new
WebFrameNetworkingContext().
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):

8:17 AM Changeset in webkit [112272] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Change default position attribute of media control panel to relative for Android.
https://bugs.webkit.org/show_bug.cgi?id=82303

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-03-27
Reviewed by Eric Carlson.

Follow up https://bugs.webkit.org/show_bug.cgi?id=79746 .

css/mediaControlsChromiumAndroid.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

8:15 AM Changeset in webkit [112271] by yurys@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Speed up snapshot parsing.
https://bugs.webkit.org/show_bug.cgi?id=82325

Replacing the iterators with raw nodes/edges access speeds up
some phases phasses up to 10 times, taking down the whole init
time to less than 6 sec.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-03-27
Reviewed by Yury Semikhatsky.

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

8:03 AM Changeset in webkit [112270] by kkristof@inf.u-szeged.hu

4 edits
2 adds in trunk/Tools

Add png checking to check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=75824

Reviewed by NOBODY Tony Chang.

Scripts/webkitpy/style/checker.py:

(_all_categories):
(FileType):
(CheckerDispatcher._should_skip_file_path):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):

Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherDispatchTest.test_none_paths):

Scripts/webkitpy/style/checkers/png.py: Added.

(PNGChecker):
(PNGChecker.init):
(PNGChecker.check):
(PNGChecker._config_file_path):

Scripts/webkitpy/style/checkers/png_unittest.py: Added.

(MockSCMDetector):
(MockSCMDetector.init):
(MockSCMDetector.display_name):
(MockSCMDetector.propget):
(PNGCheckerTest):
(PNGCheckerTest.test_init):
(PNGCheckerTest.test_init.mock_handle_style_error):
(PNGCheckerTest.test_check):
(PNGCheckerTest.test_check.mock_handle_style_error):

Scripts/webkitpy/style/patchreader.py:

(PatchReader.check):

8:01 AM Changeset in webkit [112269] by Antti Koivisto

2 edits in trunk/Source/WebCore

Assertion failure in acid2.

Rubber-stamped by Andreas Kling.

Remove assert added in http://trac.webkit.org/changeset/112258. It seems insertedInto/removedFromDocument
don't always pair.

svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):

7:55 AM Changeset in webkit [112268] by yurys@chromium.org

4 edits in trunk

Web Inspector: simplify heap profiler front-end
https://bugs.webkit.org/show_bug.cgi?id=82338

Source/WebCore:

Simplify constructors of WebInspector.HeapSnapshotArraySlice and
WebInspector.HeapSnapshotEdgesProvider.

Reviewed by Pavel Feldman.

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotArraySlice):
(WebInspector.HeapSnapshotArraySlice.prototype.item):
(WebInspector.HeapSnapshotArraySlice.prototype.slice):
(WebInspector.HeapSnapshotNode.prototype.get rawEdges):
(WebInspector.HeapSnapshot.prototype._retainersForNode):
(WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotEdgesProvider):

LayoutTests:

Reviewed by Pavel Feldman.

inspector/profiler/heap-snapshot.html:

7:51 AM Changeset in webkit [112267] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Tabbed pane should set focus on its contents on tab click.
https://bugs.webkit.org/show_bug.cgi?id=82323

Reviewed by Pavel Feldman.

Otherwise selected tab does not have focus.
Also added tabIndex on tabElements to prevent pasting on closing middle click.

inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.focus):
(WebInspector.TabbedPane.prototype.selectTab):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):

7:43 AM Changeset in webkit [112266] by podivilov@chromium.org

7 edits in trunk

Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82318

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Breakpoint-added and breakpoint-removed events are always related to specific UISourceCode.
See bug 82224 for more details.

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.UISourceCodeImpl.prototype.breakpointAdded):
(WebInspector.UISourceCodeImpl.prototype.breakpointRemoved):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._addBreakpointListeners):
(WebInspector.ScriptsPanel.prototype._removeBreakpointListeners):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):

inspector/front-end/UISourceCode.js:

LayoutTests:

inspector/debugger/breakpoint-manager.html:

7:42 AM Changeset in webkit [112265] by yael.aharon@nokia.com

6 edits in trunk/Source/WebKit2

[Qt][WK2] Merge setVisibleContentsRect with setFixedVisibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=82289

Reviewed by Kenneth Rohde Christiansen.

As we scroll, we constantly send 2 messages. Those 2 messages can be merged into one.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):

UIProcess/WebPageProxy.cpp:

(WebKit):

UIProcess/WebPageProxy.h:

(WebPageProxy):

WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::setVisibleContentsRect):

7:32 AM Changeset in webkit [112264] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry]Cleanup WTF string in platform/network/blackberry
https://bugs.webkit.org/show_bug.cgi?id=82005

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-27
Reviewed by Rob Buis.

No new tests. Just replace WTF::String with String.

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyDataReceived):

7:30 AM Changeset in webkit [112263] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Enable "number" parameters in the web inspector protocol methods
https://bugs.webkit.org/show_bug.cgi?id=82334

The generated protocol dispatcher does not understand protocol method parameters of type "number"
(mapped to "double" in the native code.)

Reviewed by Vsevolod Vlasov.

inspector/CodeGeneratorInspector.py:

(RawTypes.Number.get_getter_name):
(RawTypes.Number.get_c_initializer):
(RawTypes.Number.get_js_bind_type):
(RawTypes.Number.get_validate_method_params.ValidateMethodParams):
(RawTypes.Number.get_validate_method_params):

7:23 AM Changeset in webkit [112262] by yurys@chromium.org

6 edits in trunk

Web Inspector: Fix missing objects in the dominators view.
https://bugs.webkit.org/show_bug.cgi?id=82194

Due to the nature of dominators tree it is not possible to hide internal
objects there because they may happen to contain user objects that can't
be hidden.
Besides that it fixes a small bug in HeapSnapshotArraySlice.slice
function.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-03-27
Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotArraySlice.prototype.slice):

LayoutTests:

inspector/profiler/heap-snapshot-expected.txt:
inspector/profiler/heap-snapshot.html:

6:37 AM Changeset in webkit [112261] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Skip GTK+ unit tests that fail in the bots

Scripts/run-gtk-tests:

(TestRunner): Add failing tests to the skipped list.

6:22 AM Changeset in webkit [112260] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/loader/SubframeLoader.cpp

Plugins are always positioned at integer boundaries, so the size can be rounded. Correcting unnecessary pixel snapping in SubframeLoader.

5:45 AM Changeset in webkit [112259] by Antti Koivisto

1 edit in trunk/Source/WebCore/ChangeLog

Fix Kling's name.

5:40 AM Changeset in webkit [112258] by Antti Koivisto

9 edits in trunk/Source/WebCore

Remove Document::mappedElementSheet()
https://bugs.webkit.org/show_bug.cgi?id=82242

Reviewed by Anreas Kling and Nikolas Zimmermann.

The only thing this is used for anymore is SVGFontFaceElement. That can be handled without
the confusing extra stylesheet.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

css/CSSStyleSelector.h:

(CSSStyleSelector):

Add font face rules from registered SVGFontFaceElements.
Simplify the constructor signature. Stylesheets are part of the document.

dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::createStyleSelector):
(WebCore):
(WebCore::Document::updateBaseURL):

dom/Document.h:

(WebCore):
(WebCore::Document::documentUserSheets):
(Document):

Remove mappedElementSheet
Adapt to the CSSStyleSelector constructor signature changes.

svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::svgFontFaceElements):
(WebCore):
(WebCore::SVGDocumentExtensions::registerSVGFontFaceElement):
(WebCore::SVGDocumentExtensions::unregisterSVGFontFaceElement):

svg/SVGDocumentExtensions.h:

(WebCore):
(SVGDocumentExtensions):

Add map for SVGFontFaceElements

svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removedFromDocument):
(WebCore):

svg/SVGFontFaceElement.h:

(SVGFontFaceElement):
(WebCore::SVGFontFaceElement::fontFaceRule):

Switch to updating svgFontFaceElements map.
Use elementSheet as the parent sheet (nothing is ever added to the elementSheet, it is used for resolving relative URLs only).

5:32 AM Changeset in webkit [112257] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: startEditing should remove tabIndex attribute from the element if it was not set before.
https://bugs.webkit.org/show_bug.cgi?id=82322

Reviewed by Pavel Feldman.

This patch removes tabIndex attribute from the element after editing if it was not present before.
Otherwise tabIndex becomes set unexpectedly after exiting edit mode.

inspector/front-end/UIUtils.js:

(WebInspector.startEditing.cleanUpAfterEditing):

5:22 AM Changeset in webkit [112256] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Tree outline should not start search on key press if it is being edited.
https://bugs.webkit.org/show_bug.cgi?id=82327

Reviewed by Pavel Feldman.

This is needed for snippet renaming support.

inspector/front-end/treeoutline.js:

(TreeOutline):
(TreeOutline.prototype._treeKeyPress):

5:13 AM Changeset in webkit [112255] by leviw@chromium.org

3 edits in trunk/Source/WebCore

Revert RenderApplet::intrinsicSize to integers
https://bugs.webkit.org/show_bug.cgi?id=82206

Reviewed by Eric Seidel.

Intrinsic sizes originate either outside of WebCore, or from their initial values,
which are always integers. Reverting RenderApplet::intrinsicSize to integers, the
last spot improperly using LayoutUnits

No new tests. No change in behavior.

rendering/RenderApplet.cpp:

(WebCore::RenderApplet::intrinsicSize):

rendering/RenderApplet.h:

(RenderApplet):

5:00 AM Changeset in webkit [112254] by alexis.menard@openbossa.org

7 edits in trunk

Increase code sharing between CSSComputedStyleDeclaration and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=82261

Reviewed by Ryosuke Niwa.

Source/WebCore:

Use longhands declaration from CSSPropertyLonghand in CSSComputedStyleDeclaration to avoid
code duplication.

No new tests : refactoring only, we shouldn't have any behavior difference.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):

css/CSSComputedStyleDeclaration.h:

(WebCore):
(CSSComputedStyleDeclaration):

css/CSSPropertyLonghand.cpp:

(WebCore::outlineLonghand):
Re-order to match the spec default order and also remove outline-offset as it is not part
of the shorthand (http://www.w3.org/TR/css3-ui/#outline). Luckily this was cover by a layout test.

LayoutTests:

Update expectation as it was relying on inaccurate order. All other outline related tests
are expecting the same order (e.g. fast/getComputedStyle/getComputedStyle-outline-shorthand) as well
as Opera.

fast/css/cssText-shorthand-expected.txt:
fast/css/cssText-shorthand.html:

4:57 AM Changeset in webkit [112253] by alexis.menard@openbossa.org

1 edit
1 add in trunk/PerformanceTests

Add a perf test which updates the value of an already declared CSS property.
https://bugs.webkit.org/show_bug.cgi?id=82321

Reviewed by Andreas Kling.

This benchmark update CSS existing properties of the style from JS.

CSS/CSSPropertyUpdateValue.html: Added.

4:53 AM Changeset in webkit [112252] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

A page containing multiparts with "multipart/x-mixed-replace" should not be cached.
https://bugs.webkit.org/show_bug.cgi?id=82291

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-03-27
Reviewed by Rob Buis.

If we have a multiPart reponse with multipart/x-mixed-replace,
the current page should not be cached. I use isMultipartPayload()
API which was supposed to be set in NetworkJob to decide to
cache page or not.

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::canCachePage):

4:40 AM Changeset in webkit [112251] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Editable TextViewer should show cursor when it is focused.
https://bugs.webkit.org/show_bug.cgi?id=82320

Reviewed by Pavel Feldman.

TextViewer now focuses editable inner container unless read-only flag is set.

inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype.focus):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._handleElementFocus):
(WebInspector.TextEditorMainPanel.prototype.focus):

4:08 AM Changeset in webkit [112250] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Unskip all GTK+ unit test.

Currently, skipped tests contains the list of unit tests that have
failed in one or more bots. In this moment it's not possible to
skip just the test cases that fail, so the complete unit test is
skipped when a single test case fails. For that reason, we don't
know which test cases are actually failing for every skipped
test. We are planning to land a patch to allow skipping individual
test cases, but first we need to know which test cases are
currently failing in the bots to skip them. So, this patch simply
unskips all unit tests in order to watch the bots and get the list
of test cases failing. Failing tests will be skipped again as soon
as we have the new list of failing test cases.

Scripts/run-gtk-tests:

(TestRunner): Reset the list of skipped tests.

4:03 AM Changeset in webkit [112249] by leviw@chromium.org

1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed. Removing change markers from ChangeLog.

3:52 AM Changeset in webkit [112248] by leviw@chromium.org

2 edits in trunk/Source/WebCore

Convert RenderSelectionInfo::rect to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=82213

Reviewed by Eric Seidel.

RenderSelectionInfoBase stores a cached repaint rect in local coordinates. Coordinates local to
renderers should be stored in LayoutUnits.

No new tests. No change in behavior.

rendering/RenderSelectionInfo.h:

(WebCore::RenderSelectionInfo::rect):
(RenderSelectionInfo):

3:47 AM Changeset in webkit [112247] by Nikolas Zimmermann

9 edits in trunk

Enable animVal support for SVGAnimatedRect
https://bugs.webkit.org/show_bug.cgi?id=82317

Reviewed by Zoltan Herczeg.

Source/WebCore:

Enable animVal support for SVGAnimatedRect. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedRectAnimator.

Extended existing tests to cover this.

svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedRectAnimator::animValWillChange):
(WebCore::SVGAnimatedRectAnimator::animValDidChange):

svg/SVGAnimatedRect.h:

(SVGAnimatedRectAnimator):

svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal):

LayoutTests:

Extend SVGAnimatedRect tests to cover animVal support.

svg/animations/script-tests/svgrect-animation-1.js:

(sample1):
(sample2):
(sample3):

svg/animations/script-tests/svgrect-animation-2.js:

(sample1):
(sample2):
(sample3):

svg/animations/svgrect-animation-1-expected.txt:
svg/animations/svgrect-animation-2-expected.txt:

3:44 AM Changeset in webkit [112246] by Nikolas Zimmermann

7 edits in trunk/LayoutTests

2012-03-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Use shouldBe() instead of shouldBeCloseEnough() when testing the baseVal in the SVGAngle tests.
It doesn't get animated, and thus isn't timing dependant. All other tests are correct.

svg/animations/script-tests/svgangle-animation-deg-to-grad.js: (sample1): (sample2): (sample3):
svg/animations/script-tests/svgangle-animation-deg-to-rad.js: (sample1): (sample2): (sample3):
svg/animations/script-tests/svgangle-animation-grad-to-deg.js: (sample1): (sample2): (sample3):
svg/animations/script-tests/svgangle-animation-grad-to-rad.js: (sample1): (sample2): (sample3):
svg/animations/script-tests/svgangle-animation-rad-to-deg.js: (sample1): (sample2): (sample3):
svg/animations/script-tests/svgangle-animation-rad-to-grad.js: (sample1): (sample2): (sample3):

3:43 AM Changeset in webkit [112245] by commit-queue@webkit.org

11 edits in trunk/Source/WebCore

Unreviewed, rolling out r112201.
http://trac.webkit.org/changeset/112201
https://bugs.webkit.org/show_bug.cgi?id=82302

Breaks chromium's WebPageSerializerTest.HTMLNodes test
(Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-27

loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::error):
(WebCore):

loader/cache/CachedCSSStyleSheet.h:

(CachedCSSStyleSheet):

loader/cache/CachedFont.cpp:

(WebCore):
(WebCore::CachedFont::error):

loader/cache/CachedFont.h:

(CachedFont):

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::error):

loader/cache/CachedResource.h:

(CachedResource):

loader/cache/CachedScript.cpp:

(WebCore::CachedScript::error):
(WebCore):

loader/cache/CachedScript.h:

(CachedScript):

loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::error):
(WebCore):

loader/cache/CachedXSLStyleSheet.h:

(CachedXSLStyleSheet):

3:40 AM Changeset in webkit [112244] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip accidentally unskipped tests again.

platform/qt/Skipped:

3:35 AM Changeset in webkit [112243] by leviw@chromium.org

3 edits in trunk/Source/WebCore

LayoutRepainter: Remove unused constructor parameter and update to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=82185

Reviewed by Eric Seidel.

Removing an optional parameter for old bounds in LayoutRepainter's constructor that
is no longer used. The old bounds are instead always gleaned from the renderer's
clippedOverflowRectForRepaint.

The renderer's bounds and outline rect also are stored in LayoutUnits to properly
detect sub-pixel changes during layout. Eventually, we'll pixel snap these values
when telling the embedder to invalidate. Adding a comment to that effect.

No new tests. No change in behavior.

rendering/LayoutRepainter.cpp:

(WebCore::LayoutRepainter::LayoutRepainter):

rendering/LayoutRepainter.h:

(LayoutRepainter):

3:29 AM Changeset in webkit [112242] by pfeldman@chromium.org

1 edit
1 delete in trunk/LayoutTests

Not reviewed: chromium baselines updated.

platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Removed.

3:23 AM Changeset in webkit [112241] by Csaba Osztrogonác

5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r112229.

platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt:
platform/qt/fast/table/quote-text-around-iframe-expected.png:
platform/qt/fast/table/quote-text-around-iframe-expected.txt:

3:22 AM Changeset in webkit [112240] by Nikolas Zimmermann

5 edits
3 adds in trunk

Enable animVal support for SVGAnimatedString
https://bugs.webkit.org/show_bug.cgi?id=82316

Reviewed by Zoltan Herczeg.

Source/WebCore:

Enable animVal support for SVGAnimatedString. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedStringAnimator.

Test: svg/animations/svgstring-animation-1.html

svg/SVGAnimatedString.cpp:

(WebCore::SVGAnimatedStringAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedStringAnimator::animValWillChange):
(WebCore::SVGAnimatedStringAnimator::animValDidChange):

svg/SVGAnimatedString.h:

(SVGAnimatedStringAnimator):

svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal):

LayoutTests:

Add new test covering animVal+SVGAnimatedString.

svg/animations/script-tests/svgstring-animation-1.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/svgstring-animation-1-expected.txt: Added.
svg/animations/svgstring-animation-1.html: Added.

3:18 AM Changeset in webkit [112239] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r112229.

platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt:
platform/gtk/fast/table/quote-text-around-iframe-expected.txt:

3:08 AM Changeset in webkit [112238] by leviw@chromium.org

3 edits in trunk/Source/WebCore

Update usage of LayoutUnits in RenderListMarker
https://bugs.webkit.org/show_bug.cgi?id=81921

Reviewed by Eric Seidel.

Implementing proper pixel snapping in list marker painting, and correcting usage of integers
for local coordinates/margins that should be sub-pixel.

No new tests. No change in behavior.

rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::localSelectionRect): Changed to LayoutUnits since this represents
a rect in local coordinates.
(WebCore::RenderListMarker::paint): Doing proper pixel snapping, and using integers for
results from text measurement.
(WebCore::RenderListMarker::computePreferredLogicalWidths): Using integers for results
from text measurement.
(WebCore::RenderListMarker::updateMargins): Fixing to be LayoutUnits.

rendering/RenderListMarker.h:

(RenderListMarker):

3:06 AM Changeset in webkit [112237] by leviw@chromium.org

7 edits in trunk/Source/WebCore

Revert linesBoundingBox to integers
https://bugs.webkit.org/show_bug.cgi?id=82182

Reviewed by Eric Seidel.

LayoutRects are intended to be pixel snapped to determine the ultimate screen
coordinates, but the Inline Box tree is laid out using floats, and pixel snapping
the resulting box from linesBoundingBox would produce a potentially incorrect
rectangle. Keeping this using enclosingIntRect retains the previous accuracy and
prevents misuse.

No new tests. No change in behavior.

rendering/RenderInline.cpp:

(WebCore::RenderInline::linesBoundingBox):

rendering/RenderInline.h:

(RenderInline):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):

rendering/RenderText.cpp:

(WebCore::RenderText::linesBoundingBox):

rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::linesBoundingBox):

rendering/svg/RenderSVGInlineText.h:

(RenderSVGInlineText):

2:59 AM April 2012 Meeting edited by leviw@chromium.org

(diff)

2:55 AM Changeset in webkit [112236] by podivilov@chromium.org

10 edits in trunk

Web Inspector: store UIBreakpoints on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82214

Source/WebCore:

This change will allow us to make breakpoint-added and breakpoint-removed events a part of UISourceCode interface.
See bug 82224 for more details.

Reviewed by Vsevolod Vlasov.

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.uiSourceCodeRemoved):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):
(WebInspector.BreakpointManager.prototype.debuggerReset):

inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.addScript):

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.UISourceCodeImpl):
(WebInspector.UISourceCodeImpl.prototype.breakpoints):
(WebInspector.UISourceCodeImpl.prototype.breakpointAdded):
(WebInspector.UISourceCodeImpl.prototype.breakpointRemoved):

inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createUISourceCode):

inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):

inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.get domain):
(WebInspector.UISourceCode.prototype.get folderName):
(WebInspector.UISourceCode.prototype.get fileName):
(WebInspector.UISourceCode.prototype.get displayName):
(WebInspector.UISourceCode.prototype._parseURL):
(WebInspector.UISourceCode.prototype._didRequestContent):
(WebInspector.UISourceCode.prototype.breakpoints):

inspector/front-end/inspector.html:

LayoutTests:

Reviewed by Vsevolod Vlasov.

inspector/debugger/breakpoint-manager.html:

2:48 AM Changeset in webkit [112235] by nduca@chromium.org

3 edits in trunk/Source/WebCore

[chromium] Fix crash with fling with tracing enabled
https://bugs.webkit.org/show_bug.cgi?id=82306

The TRACE_EVENT_START instrumentation was deferencing a PassOwnPtr
after it had been passed into another OwnPtr. This caused frequent
crashes when tracing was enabled.

Reviewed by Adam Barth.

platform/ActivePlatformGestureAnimation.cpp:

(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):

platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:

(WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):

2:42 AM Changeset in webkit [112234] by Carlos Garcia Campos

10 edits in trunk/Source

[SOUP] Implement missing methods in CookieJarSoup
https://bugs.webkit.org/show_bug.cgi?id=82082

Reviewed by Martin Robinson.

Source/WebCore:

platform/network/soup/CookieJarSoup.cpp:

(WebCore::defaultCookieJar): Return a global GRefPtr to store the
default cookie jar.
(WebCore::soupCookieJar): Return the current cookie jar or create
a new one.
(WebCore::setSoupCookieJar): Set the current cookie jar.
(WebCore::setCookies): Fix coding style.
(WebCore::cookiesForDocument): Helper function to get the list of
cookies as a string.
(WebCore::cookies): Use cookiesForDocument().
(WebCore::cookieRequestHeaderFieldValue): Ditto.
(WebCore::getRawCookies): Get the list of cookies for the given
document and url.
(WebCore::deleteCookie): Delete the given cookie.
(WebCore::getHostnamesWithCookies): Use GOwnPtr.
(WebCore::deleteCookiesForHostname): Use GOwnPtr and
soup_cookie_domain_matches() instead of comparing the domain
directly with the given hostname.
(WebCore::deleteAllCookies): Use GOwnPtr.

platform/network/soup/CookieJarSoup.h:
platform/network/soup/GOwnPtrSoup.cpp:

(WTF::SoupCookie): Add GOwnPtr template for SoupCookie.

platform/network/soup/GOwnPtrSoup.h:
platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ensureSessionIsInitialized): Use soupCookieJar() instead
of defaultCookieJar().

Source/WebKit/efl:

ewk/ewk_cookies.cpp:

(ewk_cookies_clear): Use soupCookieJar() instead of
defaultCookieJar().
(ewk_cookies_get_all): Ditto.
(ewk_cookies_cookie_del): Ditto.
(ewk_cookies_policy_set): Ditto.
(ewk_cookies_policy_get): Ditto.

Source/WebKit2:

WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): Use
soupCookieJar() instead of defaultCookieJar().
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): Ditto.

2:34 AM Changeset in webkit [112233] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unskipped 5 passing tests.

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-03-27
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped:

2:32 AM Changeset in webkit [112232] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a failing test.

platform/qt-5.0-wk2/Skipped:

2:29 AM Changeset in webkit [112231] by Nikolas Zimmermann

7 edits in trunk

Enable animVal support for SVGAnimatedBoolean
https://bugs.webkit.org/show_bug.cgi?id=82311

Reviewed by Antti Koivisto.

Source/WebCore:

Enable animVal support for SVGAnimatedBoolean. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedBooleanAnimator.

Extended existing tests to cover this.

svg/SVGAnimatedBoolean.cpp:

(WebCore::SVGAnimatedBooleanAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedBooleanAnimator::animValWillChange):
(WebCore::SVGAnimatedBooleanAnimator::animValDidChange):

svg/SVGAnimatedBoolean.h:

(SVGAnimatedBooleanAnimator):

svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):

LayoutTests:

Extend SVGAnimatedBoolean tests to cover animVal support.

svg/animations/script-tests/svgboolean-animation-1.js:

(sample1):
(sample2):
(sample3):

svg/animations/svgboolean-animation-1-expected.txt:

2:27 AM Changeset in webkit [112230] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, skip an inspector test failing on 64-bit Debug GTK bot.

platform/gtk/Skipped:

2:24 AM Changeset in webkit [112229] by Nikolas Zimmermann

16 edits
5 adds in trunk

<img style='width: 100%' src='foo.svg'> gets pixellated when stretched
https://bugs.webkit.org/show_bug.cgi?id=81631

Reviewed by Antti Koivisto.

Source/WebCore:

Final cleanup of RenderReplaced after the intrinsic size negotiation patch series from some weeks/months ago.
Stop tracking whether a RenderReplaced has an intrinsic size or not with an extra-bool, instead assume each
RenderReplaced derived class has an intrinsic size. If not, the class should override
computeIntrinsicRatioInformation() for any custom logic - currently only done by RenderImage.

Remove all logic depending on m_hasIntrinsicSize from computeReplacedLogicalWidth/Height, which was used
to support different sizing models depending on if the replaced element is a RenderImage or a RenderPart.
Unify all of this in computeIntrinsicRatioInformation right in RenderReplaced. This allows to remove
a hack from RenderImage::computeReplacedLogicalWidth(), which forced the synchroniziation of the intrinsicSize()
before calling the base classes RenderReplaced::computeReplacedLogicalWidth().
Now RenderImage just overrides the layout() method, calls RenderReplaced::layout() and then sets the container
size of the image resources to [contentWidth(), contentHeight()] - reflecting the actual result of the layout.
Furthermore this now allows us to unify CachedImage::imageSizeForRenderer() again for both SVG and non-SVG images.

Propagating the right container size to the image resource fixes the actual bug, that the SVGImage got pixellated.
Adding new tests covering percentage width or height set on an <img> embedding an external SVG, no more pixelation.

Tests: svg/as-image/img-relative-height-expected.html

svg/as-image/img-relative-height.html
svg/as-image/img-relative-width-expected.html
svg/as-image/img-relative-width.html

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):

rendering/RenderImage.cpp:

(WebCore::RenderImage::layout):
(WebCore::RenderImage::computeIntrinsicRatioInformation):

rendering/RenderImage.h:

(RenderImage):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::RenderReplaced):
(WebCore::rendererHasAspectRatio):
(WebCore):
(WebCore::RenderReplaced::computeIntrinsicRatioInformationForRenderBox):
(WebCore::RenderReplaced::computeIntrinsicRatioInformation):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

rendering/RenderReplaced.h:

(WebCore::RenderReplaced::intrinsicSize):
(RenderReplaced):
(WebCore::RenderReplaced::setIntrinsicSize):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::setContainerSize):

svg/graphics/SVGImage.h:

(WebCore::SVGImage::usesContainerSize):

LayoutTests:

Add new tests covering setting only one of width/height to a percentage when embedding SVGs into <img>s.

platform/chromium/test_expectations.txt: Update expectations.
platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Update changed result - slight rounding difference.
platform/mac/fast/table/quote-text-around-iframe-expected.png: Update changed result, now the default intrinsic size respects scaling.
platform/mac/fast/table/quote-text-around-iframe-expected.txt: Ditto.
svg/as-image/img-relative-height-expected.html: Added.
svg/as-image/img-relative-height.html: Added.
svg/as-image/img-relative-width-expected.html: Added.
svg/as-image/img-relative-width.html: Added.
svg/as-image/resources/island.svg: Added.
svg/as-image/svg-non-integer-scaled-image-expected.png:
svg/as-image/svg-non-integer-scaled-image-expected.txt:

1:58 AM Changeset in webkit [112228] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, skip two new xmlhttprequest failures on GTK.

platform/gtk/Skipped:

1:56 AM Changeset in webkit [112227] by Carlos Garcia Campos

7 edits in trunk/Source/WebKit2

[GTK] Add method webkit_web_resource_get_data() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=79667

Reviewed by Gustavo Noronha Silva.

UIProcess/API/gtk/WebKitWebResource.cpp:

(webkitWebResourceCreate): Add isMainResource parameter indication
whether the resource is the main one of the frame.
(resourceDataCallback): C API callback called when resource data
is available.
(webkit_web_resource_get_data): Asynchronously get the raw data of
the resource.
(webkit_web_resource_get_data_finish): Finish asynchronous
operation started by webkit_web_resource_get_data().

UIProcess/API/gtk/WebKitWebResource.h:
UIProcess/API/gtk/WebKitWebResourcePrivate.h:
UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewResourceLoadStarted): Pass isMainResource parameter
to webkitWebResourceCreate().

UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
UIProcess/API/gtk/tests/TestResources.cpp:

(testWebResourceGetData):
(serverCallback):
(beforeAll):

1:56 AM Changeset in webkit [112226] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a new asserting test.

platform/qt/Skipped:

1:34 AM Changeset in webkit [112225] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: HeapSnapshot: speed-up distanceToWindow calculation.
https://bugs.webkit.org/show_bug.cgi?id=82305

Reviewed by Yury Semikhatsky.

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._bfs):

1:30 AM Changeset in webkit [112224] by Nikolas Zimmermann

28 edits
2 copies
3 adds in trunk

SVGAnimatedType should support SVGAnimatedIntegerOptionalInteger animation
https://bugs.webkit.org/show_bug.cgi?id=67563

Reviewed by Dirk Schulze.

Source/WebCore:

Add SVGAnimatedIntegerOptionalInteger type handling animation of pair<int, int> objects
as used for the SVG properties 'filterRes' and 'order'. They're currently animated as
SVGAnimatedNumberOptionalNumber - but that won't work for animVal support. Fix that
and enable animVal support for SVGAnimatedInteger(OptionalInteger).

Use 'int' as datatype for SVGAnimatedInteger instead of 'long' for consistency, and
move SVGAnimatedEnumeration from 'int' to 'unsigned short', to make them distinguishable.

Test: svg/animations/svginteger-animation-2.html

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
svg/SVGAllInOne.cpp:
svg/SVGAnimatedEnumeration.h:

(WebCore):

svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::startAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerAnimator::animValDidChange):
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedInteger):
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):

svg/SVGAnimatedInteger.h:

(WebCore):
(SVGAnimatedIntegerAnimator):

svg/SVGAnimatedIntegerOptionalInteger.cpp: Added.

(WebCore):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::SVGAnimatedIntegerOptionalIntegerAnimator):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::constructFromString):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValDidChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateDistance):

svg/SVGAnimatedIntegerOptionalInteger.h: Copied from Source/WebCore/svg/SVGAnimatedInteger.h.

(WebCore):
(SVGAnimatedIntegerOptionalIntegerAnimator):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::~SVGAnimatedIntegerOptionalIntegerAnimator):

svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):

svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createIntegerOptionalInteger):
(WebCore):
(WebCore::SVGAnimatedType::integerOptionalInteger):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):

svg/SVGAnimatedType.h:

(SVGAnimatedType):

svg/SVGAnimatorFactory.h:

(WebCore::SVGAnimatorFactory::create):

svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::setFilterRes):

svg/SVGFilterElement.h:

(SVGFilterElement):

svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::getPathSegAtLength):

svg/SVGPathElement.h:

(SVGPathElement):

svg/SVGPathParserFactory.cpp:

(WebCore::SVGPathParserFactory::getSVGPathSegAtLengthFromSVGPathByteStream):

svg/SVGPathParserFactory.h:

(SVGPathParserFactory):

svg/SVGPathTraversalStateBuilder.cpp:

(WebCore::SVGPathTraversalStateBuilder::pathSegmentIndex):

svg/SVGPathTraversalStateBuilder.h:

(SVGPathTraversalStateBuilder):

svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:

(WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::SVGAnimatedEnumerationPropertyTearOff):

svg/properties/SVGPropertyInfo.h:
svg/properties/SVGPropertyTraits.h:

LayoutTests:

Extend SVGAnimatedInteger tests to cover animVal support.

svg/animations/script-tests/svginteger-animation-1.js:

(sample1):
(sample2):
(sample3):

svg/animations/script-tests/svginteger-animation-2.js: Copied from LayoutTests/svg/animations/script-tests/svginteger-animation-1.js.

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/svginteger-animation-1-expected.txt:
svg/animations/svginteger-animation-2-expected.txt: Added.
svg/animations/svginteger-animation-2.html: Added.

1:22 AM Changeset in webkit [112223] by Nikolas Zimmermann

17 edits in trunk

Enable animVal support for SVGAngle
https://bugs.webkit.org/show_bug.cgi?id=82144

Reviewed by Rob Buis.

Source/WebCore:

Enable animVal support for SVGAnimatedAngle. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedAngleAnimator.

Extended existing tests to cover this.

svg/SVGAnimatedAngle.cpp:

(WebCore::sharedSVGAngle):
(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedAngleAnimator::animValWillChange):
(WebCore::SVGAnimatedAngleAnimator::animValDidChange):
(WebCore::SVGAnimatedAngleAnimator::calculateDistance):

svg/SVGAnimatedAngle.h:

(SVGAnimatedAngleAnimator):

svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal):

LayoutTests:

Update tests after enabling animVal support for SVGAnimatedAngle.

svg/animations/script-tests/svgangle-animation-deg-to-grad.js:

(sample2):
(sample3):

svg/animations/script-tests/svgangle-animation-deg-to-rad.js:

(sample2):
(sample3):

svg/animations/script-tests/svgangle-animation-grad-to-deg.js:

(sample2):
(sample3):

svg/animations/script-tests/svgangle-animation-grad-to-rad.js:

(sample2):
(sample3):

svg/animations/script-tests/svgangle-animation-rad-to-deg.js:

(sample2):
(sample3):

svg/animations/script-tests/svgangle-animation-rad-to-grad.js:

(sample2):
(sample3):

svg/animations/svgangle-animation-deg-to-grad-expected.txt:
svg/animations/svgangle-animation-deg-to-rad-expected.txt:
svg/animations/svgangle-animation-grad-to-deg-expected.txt:
svg/animations/svgangle-animation-grad-to-rad-expected.txt:
svg/animations/svgangle-animation-rad-to-deg-expected.txt:
svg/animations/svgangle-animation-rad-to-grad-expected.txt:

1:18 AM Changeset in webkit [112222] by yurys@chromium.org

6 edits in trunk

Web Inspector: remove remains of path finder in heap profiler front-end
https://bugs.webkit.org/show_bug.cgi?id=82304

Removed remainders of heap path finder as this code is not used anymore.

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/HeapSnapshot.js:
inspector/front-end/HeapSnapshotProxy.js:

LayoutTests:

inspector/profiler/heap-snapshot-expected.txt:
inspector/profiler/heap-snapshot.html:

12:59 AM Changeset in webkit [112221] by Carlos Garcia Campos

13 edits
6 adds in trunk/Source/WebKit2

[GTK] Add resources API to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=79477

Reviewed by Gustavo Noronha Silva.

GNUmakefile.am: Add new files to compilation.
UIProcess/API/gtk/WebKitResourceLoadClient.cpp: Added.

(didInitiateLoadForResource): Call
webkitWebViewResourceLoadStarted() so that view will create the
resource and emit WebKitWebView::resource-load-started.
(didSendRequestForResource): Call webkitWebResourceSentRequest()
with the given request and response.
(didReceiveResponseForResource): Call
webkitWebResourceSetResponse() with the given response.
(didReceiveContentLengthForResource): Call
webkitWebResourceNotifyProgress().
(didFinishLoadForResource): Call webkitWebResourceFinished().
(didFailLoadForResource): Create a GError for the given WKError
and call webkitWebResourceFailed().
(attachResourceLoadClientToView): Add callbacks for the
WKPageResourceLoadClient.

UIProcess/API/gtk/WebKitResourceLoadClient.h: Added.
UIProcess/API/gtk/WebKitWebResource.cpp: Added.

(webkitWebResourceGetProperty):
(webkit_web_resource_init):
(webkit_web_resource_class_init):
(webkitWebResourceUpdateURI): Update the active URI every time a
new request is sent to the server.
(webkitWebResourceCreate): Create a WebResource for the given
frame.
(webkitWebResourceSentRequest): Update uri and emit
WebKitWebResource::sent-request.
(webkitWebResourceSetResponse): Set the response property.
(webkitWebResourceNotifyProgress): Emit
WebKitWebResource::received-data.
(webkitWebResourceFinished): Emit WebKitWebResource::finished.
(webkitWebResourceFailed): Emit WebKitWebResource::failed and then
WebKitWebResource::finished.
(webkit_web_resource_get_uri): Return the currentr active URI.
(webkit_web_resource_get_response): Return the response received
from the server.

UIProcess/API/gtk/WebKitWebResource.h: Added.
UIProcess/API/gtk/WebKitWebResourcePrivate.h: Added.
UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Attach the resource load client to the
view.
(webkit_web_view_class_init): Add
WebKitWebView::resource-load-started signal.
(webkitWebViewLoadChanged): Clear loading resources map when a new
load starts and loaded resources map when the new load has been
committed.
(webkitWebViewResourceLoadStarted): Create a resource for the
given identifier, add it to the loading resources map and emit
WebKitWebView::resource-load-started signal.
(webkitWebViewGetLoadingWebResource): Return the resource that is
being loaded corresponding to the given identifier.
(webkitWebViewRemoveLoadingWebResource): Remove the resouurce
corresponfing to the given identifier from the loading resources
map.
(webkitWebViewResourceLoadFinished): Move the resource from the
loading resources map to the loaded resources map.
(webkit_web_view_get_main_resource): Return the main resource.
(webkit_web_view_get_subresources): Return the list of
subresources.

UIProcess/API/gtk/WebKitWebView.h:
UIProcess/API/gtk/WebKitWebViewPrivate.h:
UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for

WebKitWebResource.

UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
UIProcess/API/gtk/docs/webkit2gtk.types: Add

webkit_web_resource_get_type.

UIProcess/API/gtk/tests/GNUmakefile.am: Add new test for resources.
UIProcess/API/gtk/tests/TestDownloads.cpp:

(testDownloadLocalFile): Use getWebKit1TestResoucesDir() from Test.
(testDownloadLocalFileError): Ditto.
(serverCallback): Ditto.

UIProcess/API/gtk/tests/TestMain.h:

(Test::getWebKit1TestResoucesDir): Moed from TestDownloads so that
it can be used by other tests.
(Test): Add information about leaked objects.

UIProcess/API/gtk/tests/TestResources.cpp: Added.

(testWebViewResources):
(testWebResourceLoading):
(testWebResourceResponse):
(testWebResourceActiveURI):
(addCacheHTTPHeadersToResponse):
(serverCallback):
(beforeAll):
(afterAll):

UIProcess/API/gtk/webkit2.h: Include WebKitWebResource.h
UIProcess/API/gtk/webkit2marshal.list:

12:57 AM Changeset in webkit [112220] by mitz@apple.com

2 edits in trunk/Source/WebCore

Reverted r112214, since it was not the right fix for the build.

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::asText):

12:54 AM Changeset in webkit [112219] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

platform/gtk/editing/inserting/before-after-input-element-expected.txt:
platform/gtk/editing/spelling/inline_spelling_markers-expected.txt:

12:48 AM Changeset in webkit [112218] by haraken@chromium.org

5 edits in trunk/Source/WebCore

[V8][Performance] Optimize createTextNode(), createElement(), cloneNode(), etc
https://bugs.webkit.org/show_bug.cgi?id=82201

Reviewed by Adam Barth.

This patch improves performance of createTextNode() by 13%, createElement() by 14%,
and cloneNode() by 16%. Similar performance improvement will be observed in
DOM methods that create a new object every time.

Performance test: https://bugs.webkit.org/attachment.cgi?id=133799

The performance test results are as follows. Since the performance of V8's GC is
really unstable, the average of measured times makes no sense in Chromium.
Instead, let us focus on the median. I believe that this performance
improvement has impact on Dromaeo, but we cannot observe the improvement
due to the unsteadiness of V8's GC, as shown below.

Chromium/V8/Linux (without the patch):
createTextNode : median=277ms (mean=460.88ms, min=270ms, max=3381ms)
createElement : median=379ms (mean=637.52ms, min=372ms, max=3022ms)
cloneNode : median=369ms (mean=581.72ms, min=363ms, max=3050ms)
Dromaeo/dom-modify/createElement: 439.17runs/s +-31.60% (<--- pretty noisy)
Dromaeo/dom-modify/createTextNode: 287.71runs/s +-28.39% (<--- pretty noisy)
Dromaeo/dom-modify/cloneNode: 174.62runs/s +-25.68% (<--- pretty noisy)

Chromium/V8/Linux (with the patch):
createTextNode : median=240ms (mean=411.12ms, min=237ms, max=2965ms)
createElement : median=325ms (mean=585.30ms, min=317ms, max=2984ms)
cloneNode : median=310ms (mean=522.48ms, min=302ms, max=2988ms)
Dromaeo/dom-modify/createElement: 507.15runs/s +-36.00% (<--- pretty noisy)
Dromaeo/dom-modify/createTextNode: 251.01runs/s +-6.57%
Dromaeo/dom-modify/cloneNode: 177.85runs/s +-28.74% (<--- pretty noisy)

Chromium/V8/Mac (without the patch):
createTextNode : median=317ms (mean=439.08ms, min=303ms, max=3126ms)
createElement : median=403ms (mean=695.70ms, min=398ms, max=5615ms)
cloneNode : median=384ms (mean=577.96ms, min=372ms, max=5313ms)
Dromaeo/dom-modify/createElement: 493.89runs/s +-28.32% (<--- pretty noisy)
Dromaeo/dom-modify/createTextNode: 279.66runs/s +-1.91%
Dromaeo/dom-modify/cloneNode: 173.06runs/s +-24.41% (<--- pretty noisy)

Chromium/V8/Mac (with the patch):
createTextNode : median=277ms (mean=460.88ms, min=270ms, max=3381ms)
createElement : median=379ms (mean=637.52ms, min=372ms, max=3022ms)
cloneNode : median=369ms (mean=581.72ms, min=363ms, max=3050ms)
Dromaeo/dom-modify/createElement: 510.47runs/s +-28.13% (<--- pretty noisy)
Dromaeo/dom-modify/createTextNode: 215.80runs/s +-20.99% (<--- pretty noisy)
Dromaeo/dom-modify/cloneNode: 174.41runs/s +-24.85% (<--- pretty noisy)

Safari/JavaScriptCore/Mac:
createTextNode : median=142ms (mean=141.04ms, min=110ms, max=168ms)
createElement : median=234ms (mean=245.74ms, min=219ms, max=305ms)
cloneNode : median=210ms (mean=213.36ms, min=204ms, max=284ms)
Dromaeo/dom-modify/createElement: 822.49runs/s +-1.69%
Dromaeo/dom-modify/createTextNode: 735.57runs/s +-0.91%
Dromaeo/dom-modify/cloneNode: 135.20runs/s +-4.13%

This patch makes the following two optimizations:

[1] If the currently running context is equal to the context that we are about to enter,
we do not call context->Enter().
[2] We do not create a Local handle of the context until we really need to enter the context.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::persistentContext):
(WebCore):

bindings/v8/V8Proxy.h:

(V8Proxy):

WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Updated run-bindings-tests results.

12:38 AM Changeset in webkit [112217] by bbudge@chromium.org

6 edits
3 adds
2 deletes in trunk

cross-origin XMLHttpRequest doesn't work with redirect
https://bugs.webkit.org/show_bug.cgi?id=57600

Reviewed by Adam Barth.

Source/WebCore:

Changes DocumentThreadableLoader to follow the CORS redirect steps when
asynchronously loading a cross origin request with access control. Synchronous
loads should not be affected. Also adds methods to ResourceRequestBase to
clear special request headers that aren't allowed when using access control.
Follows the CORS spec as described in the Latest Editor Draft at:
http://www.w3.org/TR/cors/

Test: http/tests/xmlhttprequest/access-control-and-redirects-async.html

loader/DocumentThreadableLoader.cpp:
loader/DocumentThreadableLoader.h:
platform/network/ResourceRequestBase.cpp:
platform/network/ResourceRequestBase.h:

LayoutTests:

Adds tests to verify that an asynchronous XHR load that receives a redirect
response follows the CORS redirect steps.
Follows the CORS spec as described in the Latest Editor Draft at:
http://www.w3.org/TR/cors/

http/tests/security/resources/cors-redirect.php: Removed.
http/tests/security/xhr-cors-redirect.html: Removed.
http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt: Added.
http/tests/xmlhttprequest/access-control-and-redirects-async.html: Added.
http/tests/xmlhttprequest/resources/redirect-cors.php: Added.

12:35 AM Changeset in webkit [112216] by Philippe Normand

1 edit
1 add in trunk/LayoutTests

Unreviewed, GTK gardening after r112112.

platform/gtk/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.

12:21 AM Changeset in webkit [112215] by abarth@webkit.org

8 edits in trunk/Source/WebCore

ImageLoader::m_firedLoadEvent is a confusing name
https://bugs.webkit.org/show_bug.cgi?id=82283

Reviewed by Kentaro Hara.

This patch renames m_firedLoadEvent (and friends) to
m_hasPendingLoadEvent (and negates the value). That name more
accurately reflects the semantics of this piece of state. For example,
we now initialize m_hasPendingLoadEvent to false, which makes sense as
there is no pending load event, whereas before we initialized
m_firedLoadEvent to true, which made less sense since we hadn't yet
actually fired the load event.

bindings/v8/V8GCController.cpp:

(WebCore::calculateGroupId):

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::attach):

html/HTMLImageElement.h:

(HTMLImageElement):
(WebCore::HTMLImageElement::hasPendingLoadEvent):
(WebCore::HTMLImageElement::hasPendingActivity):

html/ImageInputType.cpp:

(WebCore::ImageInputType::attach):

loader/ImageLoader.cpp:

(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvent):

loader/ImageLoader.h:

(WebCore::ImageLoader::hasPendingBeforeLoadEvent):
(WebCore::ImageLoader::hasPendingLoadEvent):
(ImageLoader):

svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::haveLoadedRequiredResources):

12:17 AM Changeset in webkit [112214] by mitz@apple.com

2 edits in trunk/Source/WebCore

Tried to fix 32-bit builds.

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::asText):

12:05 AM Changeset in webkit [112213] by pfeldman@chromium.org

1 edit
1 add
1 delete in trunk/LayoutTests

Not reviewed: fixing Emil's rebaselined of of textfield-overflow for chromium.

platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Added.
platform/chromium-mac/fast/forms/textfield-overflow-expected.txt: Removed.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed