⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 7, 2012:

8:45 PM Changeset in webkit [113550] by scherkus@chromium.org
  • 2 edits
    19 adds in trunk/LayoutTests

2012-04-07 Andrew Scherkus <​scherkus@chromium.org>

[Chromium] Unreviewed, checking in baselines for video-frame-size-change.html.

  • platform/chromium-linux/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-linux/platform/chromium/media/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac-leopard/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac-leopard/platform/chromium/media/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/media/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/media/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac/platform/chromium/media/video-frame-size-change-expected.txt: Added.
  • platform/chromium-win/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/video-frame-size-change-expected.txt: Added.
  • platform/chromium-win/platform/chromium/media/video-frame-size-change-expected.png: Added.
  • platform/chromium-win/platform/chromium/media/video-frame-size-change-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:47 AM Changeset in webkit [113549] by jonlee@apple.com
  • 2 edits in trunk/LayoutTests

Added fast/canvas/webgl/array-message-passing.html to skipped tests on mac.
Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=83427

  • platform/mac/Skipped:
10:14 AM Changeset in webkit [113548] by Patrick Gansterer
  • 9 edits in trunk

[CMake] Cleanup WTF include directories
​https://bugs.webkit.org/show_bug.cgi?id=82716

Reviewed by Eric Seidel.

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit:

  • CMakeLists.txt:

Source/WebKit2:

  • CMakeLists.txt:

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
  • WinCELauncher/CMakeLists.txt:
8:48 AM PrefixedAPIs edited by Simon Fraser
(diff)
8:48 AM PrefixedAPIs edited by Simon Fraser
(diff)
8:30 AM Changeset in webkit [113547] by rwlbuis@webkit.org
  • 8 edits
    2 adds in trunk

[BlackBerry] Add Battery Status API support
​https://bugs.webkit.org/show_bug.cgi?id=82615

Reviewed by George Staikos.

.:

Enable BATTERY_STATUS.

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit:

Add BatteryClientBlackBerry.cpp to the build.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Add client implementation for Battery API.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init): initialize BatteryClient.

  • WebCoreSupport/BatteryClientBlackBerry.cpp: Added.

(WebCore):
(WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
(WebCore::BatteryClientBlackBerry::setController):
(WebCore::BatteryClientBlackBerry::startUpdating):
(WebCore::BatteryClientBlackBerry::stopUpdating):
(WebCore::BatteryClientBlackBerry::batteryControllerDestroyed):
(WebCore::BatteryClientBlackBerry::onLevelChange):
(WebCore::BatteryClientBlackBerry::onChargingChange):
(WebCore::BatteryClientBlackBerry::onChargingTimeChange):
(WebCore::BatteryClientBlackBerry::onDischargingTimeChange):

  • WebCoreSupport/BatteryClientBlackBerry.h: Added.

(WebCore):
(BatteryClientBlackBerry):
(WebCore::BatteryClientBlackBerry::~BatteryClientBlackBerry):

Tools:

Enable BATTERY_STATUS.

  • Scripts/build-webkit:
7:31 AM Changeset in webkit [113546] by rwlbuis@webkit.org
  • 3 edits
    3 adds in trunk

Remove dead code in SVGCSSParser
​https://bugs.webkit.org/show_bug.cgi?id=83404

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Remove code that was there to create a SVGColor representation for color, but was never reached. Since
SVGColor is deprecated now (also see bug 15012), this code has lost any potential. Should SVGColor come
back in SVG2 we can revisit this.

Add a test to confirm for SVG we follow the CSS3 handling of color="currentColor". This is something the
removed code never dealt with, but the existing code in CSSParser.cpp handles, make sure we stick to this
behaviour in the future using this test.

Test: svg/custom/currentColor-on-color.html

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

LayoutTests:

Test that we support color="currentColor" in SVG. This follows from the CSS3 spec, see
​http://www.w3.org/TR/css3-color/#currentcolor. This matches FF behaviour.

  • svg/custom/currentColor-on-color-expected.txt: Added.
  • svg/custom/currentColor-on-color.html: Added.
  • svg/custom/script-tests/currentColor-on-color.js: Added.
6:13 AM Changeset in webkit [113545] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed Easter gardening, skip new failing tests to paint the bots green.

  • platform/qt/Skipped:
1:21 AM Changeset in webkit [113544] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2012-04-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline three results on Lion, so my baseline passes with tolerance 0 again.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Images have wrong colorspace in those results.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Ditto.
  • platform/mac/svg/carto.net/selectionlist-expected.png: Ditto.
1:09 AM Changeset in webkit [113543] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2012-04-07 Nikolas Zimmermann <​nzimmermann@rim.com>

FrameData constructor zeroes all fields, causing ImageOrientation to be 0
​https://bugs.webkit.org/show_bug.cgi?id=83416

Inofficially rubber-stamped by Tim Horton.

Lots of svg/as-image/ crash on debug builds. FrameData is used in a Vector and currently
special VectorTraits force it to be initialized with memset(), nulling all members, instead
of properly initializing them causing the ImageOrientation bug. To be able to remove the
SimpleClassVectorTraits specialization, we have to allow FrameData to be copied.

  • platform/graphics/BitmapImage.h:
12:38 AM Changeset in webkit [113542] by Nikolas Zimmermann
  • 19 edits in trunk

2012-04-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests
​https://bugs.webkit.org/show_bug.cgi?id=82577

Reviewed by Filip Pizlo.

Unskip several tests on Lion, now that the libxml2 bug doesn't affect us anymore.

  • platform/mac-lion/Skipped:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
  • platform/mac/svg/custom/viewbox-syntax-expected.png:
  • platform/mac/svg/custom/viewbox-syntax-expected.txt:
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:

2012-04-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests
​https://bugs.webkit.org/show_bug.cgi?id=82577

Reviewed by Filip Pizlo.

Work-around entity expansion bug that affects several SVG tests on Lion.

Sample test document which is currently broken:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-W3CDTD SVG 1.1 BasicEN" "​http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-basic.dtd" [
<!ENTITY Smile "<rect x='.5' y='.5' width='29' height='39' fill='black' stroke='red'/>">
]>

<svg xmlns="​http://www.w3.org/2000/svg">&Smile;</svg>

The expanded rect carries no namespace, thus an Element will be created for it, instead of a SVGRectElement.
libxml2 2.7.4 fixed this bug (​https://bugzilla.gnome.org/show_bug.cgi?id=502960) in 2009 already, but Lion
still ships with 2.7.3, so we need to find a work-around for the problem. It works like this:

  • When an entity is requested (getEntityHandler) determine whether the entity is being declared (while the <!ENTITY.. parses) or wheter its references (when the &Smile; is parsed). If its referenced, record the current depth of the libxml2 parser.
  • When startElementNs is called while we're expanding entities, be sure to transfer the namespace of the parent node to the new node, but only do this if the current depth() is greater than the depth() at the time where entity expansion started. This way we only apply our workaround for elements inside entities, that get expanded at the insertion point.
  • When endElementNs is called, and our current depth() is less than our equal to the depth() where entity expansion started, clear the recorded detph(), and stop executing the workaround.

It requires storing an extra integer & boolean in XMLDocumentParser, which is only used for this work-around.

  • xml/parser/XMLDocumentParser.h: (XMLDocumentParser): (WebCore::XMLDocumentParser::isParsingEntityDeclaration): (WebCore::XMLDocumentParser::setIsParsingEntityDeclaration): (WebCore::XMLDocumentParser::depthTriggeringEntityExpansion): (WebCore::XMLDocumentParser::setDepthTriggeringEntityExpansion):
  • xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::hackAroundLibXMLEntityParsingBug): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::entityDeclarationHandler): (WebCore::getEntityHandler): (WebCore::XMLDocumentParser::initializeParserContext):

Apr 6, 2012:

10:47 PM Changeset in webkit [113541] by mrowe@apple.com
  • 4 edits in trunk/Source

Versioning.

10:38 PM Changeset in webkit [113540] by mrowe@apple.com
  • 1 copy in tags/Safari-536.6

New tag.

8:28 PM Changeset in webkit [113539] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r113526.
​http://trac.webkit.org/changeset/113526
​https://bugs.webkit.org/show_bug.cgi?id=83417

speculative rollout for broken chrome browser_test (Requested
by simonjam on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-06

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore):
(WebCore::DocumentLoader::setParsedArchiveData):
(WebCore::DocumentLoader::scheduleArchiveLoad):
(WebCore::DocumentLoader::documentURL):

  • loader/DocumentLoader.h:

(DocumentLoader):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::loadArchive):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::finishedLoadingDocument):
(WebCore):

  • loader/FrameLoader.h:

(FrameLoader):
(WebCore::FrameLoader::archive):

7:13 PM Changeset in webkit [113538] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Avoid deleting impl tree when becoming invisible
​https://bugs.webkit.org/show_bug.cgi?id=83396

Patch by James Robinson <​jamesr@chromium.org> on 2012-04-06
Reviewed by Adrienne Walker.

This bit of code in CCLayerTreeHost::didBecomeInvisible..() was an attempt to drop resources when becoming
invisible. However, it's fairly confused - we drop textures via TextureManagers when going invisible and
CCLayerImpl destructors can't delete non-managed resources since they do not have access to a context - so this
code was never actually freeing up GPU resources. Having a sometimes-null CCLayerImpl tree when we still have a
valid LayerChromium tree has lead to various tricky bugs.

No new tests since this code wasn't doing anything useful in the first place.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

7:06 PM Changeset in webkit [113537] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

LocalFileSystem::initializeLocalFileSystem should be static
​https://bugs.webkit.org/show_bug.cgi?id=83356

Reviewed by Rob Buis.

LocalFileSystem::initializeLocalFileSystem should be static because
static LocalFileSystem::localFileSystem() requires initializeLocalFileSystem()
is called before it gets called.

No functionalities changed, no new tests.

  • Modules/filesystem/LocalFileSystem.h:

(LocalFileSystem):

7:04 PM Changeset in webkit [113536] by scherkus@chromium.org
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

2012-04-06 Andrew Scherkus <​scherkus@chromium.org>

[chromium] Add layout tests that exercise rendering path for videos that have changing resolutions.
​https://bugs.webkit.org/show_bug.cgi?id=83383

Reviewed by James Robinson.

  • platform/chromium/compositing/video-frame-size-change.html: Added.
  • platform/chromium/media/video-frame-size-change.html: Changed from dumpAsText() to pixel test
7:02 PM Changeset in webkit [113535] by dpranke@chromium.org
  • 1 edit
    51 deletes in trunk/LayoutTests

clone baselines from platform/win to platform/chromium-win
​https://bugs.webkit.org/show_bug.cgi?id=83394

Unreviewed, baselines update.

Removes a bunch of "generic" baselines that were mistakenly
cloned in r113509. I forgot to filter out the baselines that
were for win-specific tests, as opposed to win-specific
baselines for generic tests.

  • platform/chromium-win/accessibility/detached-object-notification-crash-expected.txt: Removed.
  • platform/chromium-win/accessibility/document-enabled-state-expected.txt: Removed.
  • platform/chromium-win/accessibility/document-role-expected.txt: Removed.
  • platform/chromium-win/accessibility/focus-events-expected.txt: Removed.
  • platform/chromium-win/accessibility/heading-elements-expected.txt: Removed.
  • platform/chromium-win/accessibility/img-alt-attribute-expected.txt: Removed.
  • platform/chromium-win/accessibility/linked-elements-expected.txt: Removed.
  • platform/chromium-win/accessibility/list-item-role-expected.txt: Removed.
  • platform/chromium-win/accessibility/list-marker-role-expected.txt: Removed.
  • platform/chromium-win/accessibility/list-role-expected.txt: Removed.
  • platform/chromium-win/accessibility/multiple-select-element-role-expected.txt: Removed.
  • platform/chromium-win/accessibility/option-element-position-and-size-expected.txt: Removed.
  • platform/chromium-win/accessibility/option-element-selection-and-focus-events-expected.txt: Removed.
  • platform/chromium-win/accessibility/parent-element-expected.txt: Removed.
  • platform/chromium-win/accessibility/scroll-to-anchor-expected.txt: Removed.
  • platform/chromium-win/accessibility/select-element-role-expected.txt: Removed.
  • platform/chromium-win/accessibility/select-element-valuechange-event-expected.txt: Removed.
  • platform/chromium-win/accessibility/selection-and-focus-expected.txt: Removed.
  • platform/chromium-win/accessibility/single-select-children-changed-expected.txt: Removed.
  • platform/chromium-win/accessibility/single-select-children-expected.txt: Removed.
  • platform/chromium-win/accessibility/text-role-expected.txt: Removed.
  • platform/chromium-win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Removed.
  • platform/chromium-win/editing/selection/shift-page-up-down-expected.txt: Removed.
  • platform/chromium-win/fast/events/alt-numpad-expected.txt: Removed.
  • platform/chromium-win/fast/events/alt-space-scroll-expected.txt: Removed.
  • platform/chromium-win/fast/events/context-click-events-expected.txt: Removed.
  • platform/chromium-win/fast/events/double-dead-char-expected.txt: Removed.
  • platform/chromium-win/fast/events/keyLocation-numpad-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-correct-direction-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-event-fired-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-image-no-scroll-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-nested-divs-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-no-iframe-jump-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-preventDefault-expected.txt: Removed.
  • platform/chromium-win/fast/text/uniscribe-item-boundary-crash-expected.txt: Removed.
  • platform/chromium-win/fast/text/uniscribe-missing-glyph-expected.txt: Removed.
  • platform/chromium-win/inverted-colors/non-composited-expected.png: Removed.
  • platform/chromium-win/inverted-colors/non-composited-expected.txt: Removed.
  • platform/chromium-win/platform/win/plugins/draws-gradient-expected.png: Removed.
  • platform/chromium-win/platform/win/plugins/draws-gradient-expected.txt: Removed.
  • platform/chromium-win/plugins/call-javascript-that-destroys-plugin-expected.txt: Removed.
  • platform/chromium-win/plugins/get-value-netscape-window-expected.txt: Removed.
  • platform/chromium-win/plugins/iframe-inside-overflow-expected.txt: Removed.
  • platform/chromium-win/plugins/npn-invalidate-rect-invalidates-window-expected.txt: Removed.
  • platform/chromium-win/plugins/visibility-hidden-expected.png: Removed.
  • platform/chromium-win/plugins/visibility-hidden-expected.txt: Removed.
  • platform/chromium-win/plugins/window-geometry-initialized-before-set-window-expected.txt: Removed.
  • platform/chromium-win/plugins/window-region-is-set-to-clip-rect-expected.txt: Removed.
  • platform/chromium-win/plugins/windowless-paint-rect-coordinates-expected.txt: Removed.
6:59 PM PrefixedAPIs edited by dcheng@chromium.org
(diff)
6:54 PM Changeset in webkit [113534] by simonjam@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
6:25 PM Changeset in webkit [113533] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[GTK] Accelerated compositing is broken after recent TextureMapper reorganizations
​https://bugs.webkit.org/show_bug.cgi?id=83393

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-04-06
Reviewed by Noam Rosenthal.

Source/WebCore:

No new tests. This will be covered by existing accelerated compositing tests
once the implementation is complete.

The GTK+ implementation doesn't clip currently, so hold off enabling the
scissor test until necessary.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::beginPainting): Do not enable the scissor test.
(WebCore::TextureMapperGL::beginScissorClip): Enable the scissor test once
we know for sure we will be using scissored clipping.

Source/WebKit/gtk:

Ensure that the layer tree is synced when the root layer is resized.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::resizeRootLayer): Ensure that the layer
tree is synced when the root layer resizes and remove a call to recomposite
the tree, as it happens anyway.

6:18 PM PrefixedAPIs edited by jamesr@google.com
(diff)
6:17 PM Changeset in webkit [113532] by keishi@webkit.org
  • 22 edits
    14 deletes in trunk

Remove obsolete parts of <datalist> support code
​https://bugs.webkit.org/show_bug.cgi?id=83117

Source/WebCore:

Removing HTMLInputElement::selectedOption because it was removed from the specification.
Removing -webkit-appearance:list-button and -webkit-input-list-button pseudo selector
related code because we decided not to use it.

Reviewed by Kent Tamura.

  • WebCore.order:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):

  • css/CSSSelector.h:
  • css/CSSValueKeywords.in:
  • css/html.css:

(datalist):

  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLInputElement.idl:
  • inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer):

  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/StylesSidebarPane.js:
  • platform/ThemeTypes.h:
  • platform/chromium/ThemeChromiumMac.mm:

(WebCore::setupButtonCell):
(WebCore::paintButton):
(WebCore::ThemeChromiumMac::controlSize):
(WebCore::ThemeChromiumMac::minimumControlSize):
(WebCore::ThemeChromiumMac::controlBorder):
(WebCore::ThemeChromiumMac::paint):

  • platform/mac/ThemeMac.mm:

(WebCore::setUpButtonCell):
(WebCore::paintButton):
(WebCore::ThemeMac::controlSize):
(WebCore::ThemeMac::minimumControlSize):
(WebCore::ThemeMac::controlBorder):
(WebCore::ThemeMac::paint):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustRepaintRect):

LayoutTests:

Removed tests for HTMLInputElement.selectedOption and -webkit-appearance:list-button.

Reviewed by Kent Tamura.

  • fast/forms/datalist/input-selectedoption-expected.txt: Removed.
  • fast/forms/datalist/input-selectedoption.html: Removed.
  • platform/chromium-linux/fast/forms/datalist/input-selectedoption-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/datalist/input-selectedoption-expected.png: Removed.
  • platform/chromium-mac/fast/forms/datalist/input-selectedoption-expected.png: Removed.
  • platform/chromium-mac/fast/forms/datalist/input-selectedoption-expected.txt: Removed.
  • platform/chromium-win/fast/forms/datalist/input-selectedoption-expected.png: Removed.
  • platform/chromium-win/fast/forms/datalist/input-selectedoption-expected.txt: Removed.
  • platform/chromium-win/platform/mac/fast/forms/input-list-button-size-expected.png: Removed.
  • platform/gtk/fast/forms/input-selectedoption-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/input-list-button-size-expected.png: Removed.
  • platform/mac/Skipped:
  • platform/mac/fast/forms/input-list-button-size-expected.png: Removed.
  • platform/mac/fast/forms/input-list-button-size-expected.txt: Removed.
  • platform/mac/fast/forms/input-list-button-size.html: Removed.
6:16 PM PrefixedAPIs edited by rniwa@webkit.org
Add specifications for mutation observers API and drag & drop API (diff)
6:12 PM Changeset in webkit [113531] by fischman@chromium.org
  • 3 edits in trunk/Tools

Subscribe ​feature-media-reviews@c.o to Media-related changes.
​https://bugs.webkit.org/show_bug.cgi?id=83397

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
6:12 PM Changeset in webkit [113530] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Do not abuse ArrayStorage's m_length for testing array consistency
​https://bugs.webkit.org/show_bug.cgi?id=83403

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-04-06
Reviewed by Geoffrey Garen.

Array creation from a list of values is a 3 steps process:
-JSArray::tryCreateUninitialized()
-JSArray::initializeIndex() for each values
-JSArray::completeInitialization()

Previously, the attribute m_length was not set to the final size
JSArray::tryCreateUninitialized() because it was used to test the array
consistency JSArray::initializeIndex().

This caused the initialization loop using JSArray::initializeIndex() maintain
two counters:
-index of the loop
-storage->m_length++

This patch fixes this by using the index of the initialization loop for the indinces of
JSArray::initializeIndex(). For testing consistency, the variable m_initializationIndex
is introduced if CHECK_ARRAY_CONSISTENCY is defined.

The patch also fixes minor unrelated build issue when CHECK_ARRAY_CONSISTENCY is defined.

This improves the performance of JSArray creation from literals by 8%.

  • runtime/JSArray.cpp:

(JSC::JSArray::tryFinishCreationUninitialized):
(JSC::JSArray::checkConsistency):

  • runtime/JSArray.h:

(ArrayStorage):
(JSC::JSArray::initializeIndex):
(JSC::JSArray::completeInitialization):

6:09 PM Changeset in webkit [113529] by enne@google.com
  • 2 edits in trunk/Tools

[chromium] Add virtual test suite for threaded compositing
​https://bugs.webkit.org/show_bug.cgi?id=82263

Reviewed by James Robinson.

Add compositing/visibility as a virtual test suites to test threaded
compositing with. This is a reasonable smoke test of 9 tests, none of
which have any expectations in the non-threaded case.

To fix many of the remaining tests in this virtual test suite, there
will need to be some serious refactoring to merge the conflict between
the way CCScheduler wants to draw frames and the way DRT also wants to
control things. So, in the short term, enable a few simple tests that
are known to be passing.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.virtual_test_suites):

6:03 PM Changeset in webkit [113528] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

Accessing the returnValue of a modal dialog should be performed directly on the global object.
​https://bugs.webkit.org/show_bug.cgi?id=83414

Reviewed by Gavin Barraclough.

Presumably during the mass-devirtualising of JSObject, this deliberate use of
the GlobalObject's property lookup logic directly was replaced with a dynamic
call. That results in the DOMWindow filtering out the lookup. This regression
was masked by r93567.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::DialogHandler::returnValue):

5:58 PM PrefixedAPIs edited by abarth@webkit.org
(diff)
5:57 PM Changeset in webkit [113527] by jonlee@apple.com
  • 4 edits in trunk/Source

Build fix for Windows bots.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: export missing symbol.

Source/WebKit2:

  • win/WebKit2.def: Add missing export symbol.
5:53 PM PrefixedAPIs edited by abarth@webkit.org
(diff)
5:49 PM PrefixedAPIs edited by abarth@webkit.org
(diff)
5:43 PM Changeset in webkit [113526] by Nate Chapin
  • 5 edits in trunk/Source/WebCore

Move Archive processing to DocumentLoader, instead of FrameLoader.
​https://bugs.webkit.org/show_bug.cgi?id=83055

Reviewed by Adam Barth.

No new tests, no functionality change intended.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::maybeCreateArchive): Renamed from

FrameLoader::finishedLoadingDocument(). Returns true if an archive
was created.

(WebCore::DocumentLoader::setArchive):
(WebCore::DocumentLoader::scheduleArchiveLoad):
(WebCore::DocumentLoader::documentURL): Add a check for whether an archive url

should be returned, so that we don't need special handling in Document and
FrameLoader for overriding the document url later.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData): Remove archive special cases, since

DocumentLoader::documentURL() will return the right thing for legacy archives
and maybeCreateArchive() will override the base url for mhtml.

(WebCore::FrameLoader::loadArchive):

  • loader/FrameLoader.h:
5:41 PM PrefixedAPIs edited by abarth@webkit.org
(diff)
5:37 PM PrefixedAPIs edited by abarth@webkit.org
(diff)
5:36 PM PrefixedAPIs edited by abarth@webkit.org
(diff)
5:34 PM PrefixedAPIs edited by abarth@webkit.org
(diff)
5:33 PM Changeset in webkit [113525] by charles.wei@torchmobile.com.cn
  • 4 edits in trunk/Source

[BlackBerry] Build fix to match the latest WebCore change
​https://bugs.webkit.org/show_bug.cgi?id=83358

Reviewed by Rob Buis.

Source/WebCore:

Update the BlackBerry cmake file to reflect the fact that:
1.VDMXParser.cpp moved from graphics/skia to graphics/chromium.
2.geolocation moved to Modules/geolocation
3.websockets moved to Modules/websockets

  • PlatformBlackBerry.cmake:

Source/WebKit:

  • PlatformBlackBerry.cmake:
5:32 PM PrefixedAPIs edited by abarth@webkit.org
(diff)
5:30 PM PrefixedAPIs edited by abarth@webkit.org
(diff)
5:30 PM Changeset in webkit [113524] by charles.wei@torchmobile.com.cn
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Restore some code which was deleted by accident.
​https://bugs.webkit.org/show_bug.cgi?id=83357

Reviewed by Rob Buis.

No new tests, just BlackBerry build fix.

  • platform/network/blackberry/ResourceRequest.h:

(ResourceRequest):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore):
(WebCore::mimeTypeRequestTypeMap):
(WebCore::ResourceRequest::targetTypeFromMimeType):

5:29 PM PrefixedAPIs edited by abarth@webkit.org
(diff)
5:24 PM PrefixedAPIs created by abarth@webkit.org
5:14 PM Changeset in webkit [113523] by hbono@chromium.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION: Cannot write a word with Korean double consonant
​https://bugs.webkit.org/show_bug.cgi?id=81186

Reviewed by Dan Bernstein.

WebKit change r103859 posts fake mouse-move events when the keyboard status is
changed. Unfortunately, these mouse events go to input methods and confuse a
Korean input method. This change directly calls handleMouseEvent() instead of
-mouseMoved: to prevent sending these fake events to input methods.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _postFakeMouseMovedEventForFlagsChangedEvent:]):

5:13 PM Changeset in webkit [113522] by simonjam@chromium.org
  • 4 edits
    1 move
    1 add
    2 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/fast/text/atsui-partial-selection-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/text/atsui-partial-selection-expected.png.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Removed.
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/svg/custom/shape-rendering-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:06 PM Changeset in webkit [113521] by jamesr@google.com
  • 5 edits in trunk/LayoutTests

Unreviewed gardening.

Explicitly position canvases for these tests to avoid cross-platform differences.

  • fast/canvas/webgl/webgl-composite-modes-expected.png:
  • fast/canvas/webgl/webgl-composite-modes-repaint-expected.png:
  • fast/canvas/webgl/webgl-composite-modes-repaint.html:
  • fast/canvas/webgl/webgl-composite-modes.html:
5:03 PM Changeset in webkit [113520] by commit-queue@webkit.org
  • 5 edits in trunk

Fix bug in ContainerNode::getRect with scale transforms
​https://bugs.webkit.org/show_bug.cgi?id=83385

Patch by Alexandre Elias <​aelias@google.com> on 2012-04-06
Reviewed by Simon Fraser.

The bottom-right corner calculation for non-inline and replaced
elements in ContainerNode::getRect was incorrect in the presence of
scaling, because the untransformed element size was added after the
transformation is applied. The rest of the calculations are careful
to always apply the transformation as the last step, but this had been
forgotten in this codepath. The fix is just to make sure the size is
included in the localToAbsolute call.

One bug caused by this was that a scaled element would be cut off
when scrollIntoView(false) is called to scroll its parent container
to make it bottom-visible.

New layout test case in fast/transforms/scrollIntoView-transformed.html

Source/WebCore:

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getLowerRightCorner):

LayoutTests:

  • fast/transforms/scrollIntoView-transformed-expected.txt:
  • fast/transforms/scrollIntoView-transformed.html:
4:41 PM Changeset in webkit [113519] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

m_shouldRespectImageOrientation is used uninitialized
​https://bugs.webkit.org/show_bug.cgi?id=83410

Reviewed by Simon Fraser.

Initialize Settings's m_shouldRespectImageOrientation to false.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

4:26 PM Changeset in webkit [113518] by ap@apple.com
  • 4 edits in trunk/Source

[Mac] Adopt a different method of telling AppKit when inline input isn't supported
​https://bugs.webkit.org/show_bug.cgi?id=83408
<rdar://problem/9205734>

Reviewed by Adele Peterson.

4:09 PM Changeset in webkit [113517] by jamesr@google.com
  • 6 edits in trunk

[chromium] Clear values in combinedClear path not respected in WebGLRenderingContext::clearIfComposited()
​https://bugs.webkit.org/show_bug.cgi?id=83407

Source/WebCore:

Reviewed by Kenneth Russell.

When doing a combined clear in the drawing buffer path, we have to use the user specified values for the clear
color / mask / depth and not all 0s.

Covered by slight modification to fast/canvas/webgl/canvas-test.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::clearIfComposited):

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::clearFramebuffers):
(WebCore::DrawingBuffer::reset):

  • platform/graphics/gpu/DrawingBuffer.h:

LayoutTests:

Force a composite on each tick to more closely match the test's behavior in an actual browser.

  • fast/canvas/webgl/canvas-test.html:
4:02 PM Changeset in webkit [113516] by tony@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[chromium] Unreviewed gardening.

This test is passing on Chromium Linux, but we have a different expectation
checked in for Chromium Win which uses lighttpd.

  • platform/chromium-linux/http/tests/xmlhttprequest/cache-override-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:57 PM Changeset in webkit [113515] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] merge redundant conditions in WebCore.gyp
​https://bugs.webkit.org/show_bug.cgi?id=83319

Reviewed by Adam Barth.

There were duplicate conditions in some of the targets (e.g., 2
OS=="win" sections) so I merged them and if possible, used an else
block of an existing condition.

No new tests, just refactoring the build file.

  • WebCore.gyp/WebCore.gyp:
3:55 PM Changeset in webkit [113514] by Simon Fraser
  • 7 edits in trunk/Source/WebCore

Rename paintingGoesToWindow() to paintsIntoWindow()
​https://bugs.webkit.org/show_bug.cgi?id=83406

Reviewed by Dirk Schulze.

Rename paintingGoesToWindow() to paintsIntoWindow() to be consistent
with some future refactoring.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintsWithTransform):
(WebCore::RenderLayer::setBackingNeedsRepaint):
(WebCore::RenderLayer::setBackingNeedsRepaintInRect):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::paintsIntoWindow):
(WebCore::RenderLayerBacking::paintIntoLayer):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):

  • rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

3:53 PM Changeset in webkit [113513] by simonjam@chromium.org
  • 2 edits in trunk/Source/WebCore

Roll out change to HTMLParserIdioms.cpp from 82857
​https://bugs.webkit.org/show_bug.cgi?id=83402

Change 82857 causes a DCHECK on fast/forms/number/ValidityState-typeMismatch-number.html

Darin suggested we roll out this file here: ​https://bugs.webkit.org/show_bug.cgi?id=82857#c20

Unreviewed, rolling out change that broke tests.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseToDoubleForNumberType):

3:49 PM Changeset in webkit [113512] by fischman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS
​https://bugs.webkit.org/show_bug.cgi?id=83389

Unreviewed, just a DEPS roll (130110:131183)

  • DEPS:
3:48 PM Changeset in webkit [113511] by isherman@chromium.org
  • 5 edits in trunk

Allow site authors to override autofilled fields' colors.
​https://bugs.webkit.org/show_bug.cgi?id=66032
​http://code.google.com/p/chromium/issues/detail?id=46543

Reviewed by Simon Fraser.

Source/WebCore:

  • css/html.css:

(input:-webkit-autofill): Remove !important declarations.

LayoutTests:

  • fast/forms/input-autofilled-expected.txt:
  • fast/forms/input-autofilled.html:
3:44 PM Changeset in webkit [113510] by enrica@apple.com
  • 9 edits
    2 adds in trunk

Provide Obj-C private API to simplify markup.
​https://bugs.webkit.org/show_bug.cgi?id=83334
<rdar://problem/11033861>

Reviewed by Sam Weinig.

Source/WebCore:

Added test in TestWebKitAPI

  • WebCore.exp.in:
  • editing/Editor.cpp:

(WebCore::Editor::simplifyMarkup): Exposing the new command through the editor.

  • editing/Editor.h:

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _simplifyMarkup:endNode:]): Added.

  • WebView/WebViewPrivate.h:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.

(-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):

  • TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
3:43 PM Changeset in webkit [113509] by dpranke@chromium.org
  • 1 edit
    115 adds in trunk/LayoutTests

clone baselines from platform/win to platform/chromium-win
​https://bugs.webkit.org/show_bug.cgi?83394

Unreviewed, expectations change.

Copies the win baselines that chromium depends on into a
chromium dir, so that we can remove the dependency on win down
the road.

  • platform/chromium-win/accessibility/aria-fallback-roles-expected.txt: Added.
  • platform/chromium-win/accessibility/detached-object-notification-crash-expected.txt: Added.
  • platform/chromium-win/accessibility/document-enabled-state-expected.txt: Added.
  • platform/chromium-win/accessibility/document-role-expected.txt: Added.
  • platform/chromium-win/accessibility/focus-events-expected.txt: Added.
  • platform/chromium-win/accessibility/heading-elements-expected.txt: Added.
  • platform/chromium-win/accessibility/img-alt-attribute-expected.txt: Added.
  • platform/chromium-win/accessibility/linked-elements-expected.txt: Added.
  • platform/chromium-win/accessibility/list-item-role-expected.txt: Added.
  • platform/chromium-win/accessibility/list-marker-role-expected.txt: Added.
  • platform/chromium-win/accessibility/list-role-expected.txt: Added.
  • platform/chromium-win/accessibility/multiple-select-element-role-expected.txt: Added.
  • platform/chromium-win/accessibility/option-element-position-and-size-expected.txt: Added.
  • platform/chromium-win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
  • platform/chromium-win/accessibility/parent-element-expected.txt: Added.
  • platform/chromium-win/accessibility/scroll-to-anchor-expected.txt: Added.
  • platform/chromium-win/accessibility/select-element-role-expected.txt: Added.
  • platform/chromium-win/accessibility/select-element-valuechange-event-expected.txt: Added.
  • platform/chromium-win/accessibility/selection-and-focus-expected.txt: Added.
  • platform/chromium-win/accessibility/single-select-children-changed-expected.txt: Added.
  • platform/chromium-win/accessibility/single-select-children-expected.txt: Added.
  • platform/chromium-win/accessibility/text-role-expected.txt: Added.
  • platform/chromium-win/compositing/plugins/composited-plugin-expected.txt: Added.
  • platform/chromium-win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Added.
  • platform/chromium-win/editing/selection/anchor-focus2-expected.txt: Added.
  • platform/chromium-win/editing/selection/anchor-focus3-expected.txt: Added.
  • platform/chromium-win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
  • platform/chromium-win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
  • platform/chromium-win/editing/selection/drag-text-delay-expected.txt: Added.
  • platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: Added.
  • platform/chromium-win/editing/selection/mixed-editability-10-expected.txt: Added.
  • platform/chromium-win/editing/selection/shift-page-up-down-expected.txt: Added.
  • platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt: Added.
  • platform/chromium-win/fast/css/zoom-body-scroll-expected.txt: Added.
  • platform/chromium-win/fast/dom/Element/id-in-deletebutton-expected.txt: Added.
  • platform/chromium-win/fast/dom/Window/window-properties-expected.txt: Added.
  • platform/chromium-win/fast/dom/prototype-inheritance-2-expected.txt: Added.
  • platform/chromium-win/fast/events/alt-numpad-expected.txt: Added.
  • platform/chromium-win/fast/events/alt-space-scroll-expected.txt: Added.
  • platform/chromium-win/fast/events/context-click-events-expected.txt: Added.
  • platform/chromium-win/fast/events/double-dead-char-expected.txt: Added.
  • platform/chromium-win/fast/events/keyLocation-numpad-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-correct-direction-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-event-fired-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-image-no-scroll-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-nested-divs-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-no-iframe-jump-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-preventDefault-expected.txt: Added.
  • platform/chromium-win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
  • platform/chromium-win/fast/forms/select-popup-pagekeys-expected.txt: Added.
  • platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt: Added.
  • platform/chromium-win/fast/js/global-constructors-expected.txt: Added.
  • platform/chromium-win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Added.
  • platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/chromium-win/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
  • platform/chromium-win/fast/text/capitalize-boundaries-expected.txt: Added.
  • platform/chromium-win/fast/text/emphasis-combined-text-expected.txt: Added.
  • platform/chromium-win/fast/text/emphasis-expected.png: Added.
  • platform/chromium-win/fast/text/emphasis-expected.txt: Added.
  • platform/chromium-win/fast/text/emphasis-vertical-expected.png: Added.
  • platform/chromium-win/fast/text/emphasis-vertical-expected.txt: Added.
  • platform/chromium-win/fast/text/fallback-traits-fixup-expected.txt: Added.
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt: Added.
  • platform/chromium-win/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/chromium-win/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/chromium-win/fast/text/international/vertical-text-glyph-test-expected.png: Added.
  • platform/chromium-win/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/chromium-win/fast/text/international/vertical-text-metrics-test-expected.txt: Added.
  • platform/chromium-win/fast/text/justify-ideograph-complex-expected.txt: Added.
  • platform/chromium-win/fast/text/justify-ideograph-simple-expected.txt: Added.
  • platform/chromium-win/fast/text/justify-ideograph-vertical-expected.txt: Added.
  • platform/chromium-win/fast/text/uniscribe-item-boundary-crash-expected.txt: Added.
  • platform/chromium-win/fast/text/uniscribe-missing-glyph-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/text-orientation-basic-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/text-orientation-basic-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.txt: Added.
  • platform/chromium-win/inverted-colors/non-composited-expected.png: Added.
  • platform/chromium-win/inverted-colors/non-composited-expected.txt: Added.
  • platform/chromium-win/platform/win/plugins/draws-gradient-expected.png: Added.
  • platform/chromium-win/platform/win/plugins/draws-gradient-expected.txt: Added.
  • platform/chromium-win/plugins/call-javascript-that-destroys-plugin-expected.txt: Added.
  • platform/chromium-win/plugins/get-value-netscape-window-expected.txt: Added.
  • platform/chromium-win/plugins/iframe-inside-overflow-expected.txt: Added.
  • platform/chromium-win/plugins/npn-invalidate-rect-invalidates-window-expected.txt: Added.
  • platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt: Added.
  • platform/chromium-win/plugins/plugin-javascript-access-expected.txt: Added.
  • platform/chromium-win/plugins/resize-from-plugin-expected.txt: Added.
  • platform/chromium-win/plugins/visibility-hidden-expected.png: Added.
  • platform/chromium-win/plugins/visibility-hidden-expected.txt: Added.
  • platform/chromium-win/plugins/window-geometry-initialized-before-set-window-expected.txt: Added.
  • platform/chromium-win/plugins/window-region-is-set-to-clip-rect-expected.txt: Added.
  • platform/chromium-win/plugins/windowless-paint-rect-coordinates-expected.txt: Added.
  • platform/chromium-win/printing/page-rule-in-media-query-expected.txt: Added.
  • platform/chromium-win/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent/S11.5.3_A4_T6-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
3:35 PM Changeset in webkit [113508] by ggaren@apple.com
  • 19 edits
    4 moves in trunk/Source/JavaScriptCore

Renamed

WeakHeap => WeakSet
HandleHeap => HandleSet

Reviewed by Sam Weinig.

These sets do have internal allocators, but it's confusing to call them
heaps because they're sub-objects of an object called "heap".

  • heap/HandleHeap.cpp: Removed.
  • heap/HandleHeap.h: Removed.
  • heap/HandleSet.cpp: Copied from JavaScriptCore/heap/HandleHeap.cpp.
  • heap/WeakHeap.cpp: Removed.
  • heap/WeakHeap.h: Removed.
  • heap/WeakSet.cpp: Copied from JavaScriptCore/heap/WeakHeap.cpp.
  • heap/WeakSet.h: Copied from JavaScriptCore/heap/WeakHeap.h.

Plus global rename using grep.

3:30 PM Changeset in webkit [113507] by dpranke@chromium.org
  • 3 edits in trunk/Tools

new-run-webkit-tests: fix bugs in 'mock' drt implementation
​https://bugs.webkit.org/show_bug.cgi?id=83341

Reviewed by Eric Seidel.

The current implementation crashed in some circumstances for
reference tests and files that were missing expected results.
This patch fixes those cases and adds more unit tests; it is a
precursor to adding unit tests each port that actually uses this
code, in order to get better coverage of the port/*
implementations.

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:

(parse_options):
(MockDRT.input_from_line):
(MockDRT.output_for_test):
(MockDRT.run_one_test):
(MockChromiumDRT.input_from_line):
(MockChromiumDRT.output_for_test):
(MockChromiumDRT.run_one_test):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTTest.make_input_output):
(MockDRTTest.expected_output):
(MockDRTTest):
(MockDRTTest.assertTest):
(MockDRTTest.test_missing_image):
(MockDRTTest.test_missing_text):
(MockDRTTest.test_reftest_match):
(MockDRTTest.test_reftest_mismatch):
(MockChromiumDRTTest.expected_output):

3:24 PM Changeset in webkit [113506] by tony@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

[chromium] Unreviewed gardening. This test is passing on chromium win and linux.

  • platform/chromium-linux-x86/fast/text/atsui-partial-selection-expected.png: Added.
  • platform/chromium-win/fast/text/atsui-partial-selection-expected.png:
  • platform/chromium/test_expectations.txt:
3:23 PM Changeset in webkit [113505] by benjamin@webkit.org
  • 7 edits in trunk/Source

Get rid of the useless flag PREEMPT_GEOLOCATION_PERMISSION
​https://bugs.webkit.org/show_bug.cgi?id=83325

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-04-06
Reviewed by Ryosuke Niwa.

Source/WebCore:

The flag WTF_USE_PREEMPT_GEOLOCATION_PERMISSION was added in r63742 but
was never disabled by anyone. Supporting this feature added complexity by
introducing two authorization scheme.

This patch removes WTF_USE_PREEMPT_GEOLOCATION_PERMISSION and the code supporting
granting the authorization after startUpdating().

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::GeoNotifier::runSuccessCallback): With the simplified
authorization code, we ensure stronger constraint on GeoNotifier::runSuccessCallback().
(WebCore::Geolocation::stop):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::positionChanged): The case (!isAllowed()) was there
to support granting the authorization for WTF_USE_PREEMPT_GEOLOCATION_PERMISSION.
(WebCore::Geolocation::handlePendingPermissionNotifiers):

  • Modules/geolocation/Geolocation.h:

(Geolocation):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataUseFeatures.in:

Source/WTF:

  • wtf/Platform.h: Remove the flag.
3:16 PM Changeset in webkit [113504] by tony@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

[chromium] Unreviewed, rebaseline a test on Vista/Win7.

  • platform/chromium-linux/fast/encoding/invalid-UTF-8-expected.txt: Removed.
  • platform/chromium-win/fast/encoding/invalid-UTF-8-expected.png:
  • platform/chromium-win/fast/encoding/invalid-UTF-8-expected.txt:
  • platform/chromium/test_expectations.txt:
3:15 PM Changeset in webkit [113503] by tsepez@chromium.org
  • 13 edits
    3 adds in trunk

Block cross-origin iframe scroll to fragment.
​https://bugs.webkit.org/show_bug.cgi?id=73083

Reviewed by Adam Barth.

Add a restriction similar to what FF has done for all iframes for over a
year now. Our change is less disruptive in that it only does this in the
cross-orgin case, which is where the fragment scrolling is problematic.

Source/WebCore:

Test: http/tests/navigation/anchor-frames-cross-origin.html

  • dom/Document.cpp:

(WebCore::Document::canBeAccessedByEveryAncestorFrame):
(WebCore):

  • dom/Document.h:

(Document):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::shouldPerformFragmentNavigation):
(WebCore::FrameLoader::scrollToFragmentIfAllowed):
(WebCore):

  • loader/FrameLoader.h:

(FrameLoader):

LayoutTests:

  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/navigation/anchor-frames-cross-origin-expected.txt: Added.
  • http/tests/navigation/anchor-frames-cross-origin.html: Added.
  • http/tests/navigation/resources/frame-with-anchor-cross-origin.html: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
  • http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
2:49 PM Changeset in webkit [113502] by jsbell@chromium.org
  • 2 edits
    3 copies in branches/chromium/1084

Merge 112740 - IndexedDB: Race condition causes version change transaction to commit after onblocked
​https://bugs.webkit.org/show_bug.cgi?id=82678

Source/WebCore:

For a version change event, the blocked and success events could both be queued
before either is dispatched. The transaction would erroneously be allowed to commit
after the blocked event was dispatched; it should not be, as the request was not
finished.

Reviewed by Tony Chang.

Test: storage/indexeddb/dont-commit-on-blocked.html

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

LayoutTests:

Landing test marked PASS FAIL as WK82776 prevents it from running in DRT; will
run it as a Chromium browser test for now.

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/dont-commit-on-blocked.html: Added.
  • storage/indexeddb/resources/dont-commit-on-blocked-worker.js: Added.

(request.onsuccess):
(onSetVersionBlocked):
(onSetVersionSuccess):
(onTransactionComplete):

TBR=​jsbell@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10007047

2:49 PM Changeset in webkit [113501] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebKit2

WebFullScreenManagerProxy::isFullScreen() will create an empty full screen window; steal focus.
​https://bugs.webkit.org/show_bug.cgi?id=83388

Reviewed by Geoffrey Garen.

Calling WebFullScreenManagerProxy::isFullScreen() will create a WKFullScreenWindowController if
one does not already exist, since the -[WKView fullScreenWindowController] method will create-on-access.
Add a new call, -[WKView hasFullScreenWindowController], which does not auto-create the controller
and add that check to WebFullScreenManagerProxy::isFullScreen().

  • UIProcess/API/mac/WKView.mm:

(-[WKView hasFullScreenWindowController]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:

(WebKit::WebFullScreenManagerProxy::isFullScreen):

2:48 PM Changeset in webkit [113500] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, remove a passing test.
tables/mozilla/bugs/bug9024.html is passing on Leopard.

  • platform/chromium/test_expectations.txt:
2:45 PM Changeset in webkit [113499] by jamesr@google.com
  • 14 edits
    1 copy
    1 add in trunk/Tools

Enable webkit_unit_tests for commit queue and EWS while tracking failures
​https://bugs.webkit.org/show_bug.cgi?id=83329

Reviewed by Adam Barth.

This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
the commit queue and EWS can reject patches that cause regressions.

  • Scripts/webkitpy/common/config/ports.py:

(ChromiumPort.run_webkit_unit_tests_command):

  • Scripts/webkitpy/common/config/ports_mock.py:

(MockPort.unit_tests_results_path):

  • Scripts/webkitpy/common/net/layouttestresults.py:

(LayoutTestResults.init):
(LayoutTestResults.failing_tests):
(LayoutTestResults):
(LayoutTestResults.add_unit_test_failures):

  • Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.

(UnitTestResults):
(UnitTestResults.results_from_string):

  • Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.

(UnitTestResultsTest):
(UnitTestResultsTest.test_nostring):
(UnitTestResultsTest.test_emptystring):
(UnitTestResultsTest.test_nofailures):
(test_onefailure):
(test_multiple_failures_per_test):

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(MockCommitQueue.test_results):
(MockCommitQueue.archive_last_test_results):
(FailingTestCommitQueue.test_results):
(test_flaky_test_failure):
(test_failed_archive):

  • Scripts/webkitpy/tool/bot/layouttestresultsreader.py:

(LayoutTestResultsReader._create_unit_test_results):
(LayoutTestResultsReader.results):

  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:

(LayoutTestResultsReaderTest.test_missing_layout_test_results):

  • Scripts/webkitpy/tool/bot/patchanalysistask.py:

(PatchAnalysisTaskDelegate.test_results):
(PatchAnalysisTaskDelegate.archive_last_test_results):
(PatchAnalysisTask._test):
(PatchAnalysisTask._build_and_test_without_patch):
(PatchAnalysisTask._test_patch):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.test_results):
(AbstractEarlyWarningSystem.archive_last_test_results):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSytemTest._test_testing_ews):

  • Scripts/webkitpy/tool/commands/queues.py:

(CommitQueue.test_results):
(CommitQueue.archive_last_test_results):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(CommitQueueTest.test_commit_queue):
(test_rollout):
(test_manual_reject_during_processing):

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_webkit_run_unit_tests):

2:38 PM Changeset in webkit [113498] by jer.noble@apple.com
  • 5 edits in trunk

Foreground of apple.com/iphone video page visible during full screen animation.
​https://bugs.webkit.org/show_bug.cgi?id=83080

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; updated fullscreen/full-screen-stacking-context.html

The apple.com/iphone video page uses a -webkit-mask: CSS style, which creates a stacking
context and causes the page to pop in front of the full screen renderer. Add all the
styles suggested by the W3C full screen spec to the -webkit-full-screen-ancestor rule
to keep these stacking contexts from being created.

  • css/fullscreen.css:

(:-webkit-full-screen-ancestor:not(iframe)):

LayoutTests:

  • fullscreen/full-screen-stacking-context.html:
  • platform/mac/fullscreen/full-screen-stacking-context-expected.png:
2:32 PM Changeset in webkit [113497] by inferno@chromium.org
  • 9 edits in trunk/Source/WebCore

Virtualize createAnonymousBoxWithSameTypeAs.
​https://bugs.webkit.org/show_bug.cgi?id=83229

Reviewed by Julien Chaffraix.

This helps to use the same function to create anonymous
table parts and in the future extend to more classes
derived from RenderBox.

The current switch case situation was going to be messy as
we will need to mix cases that were very dependent on the
class, so it made sense to add a virtual function.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitAnonymousBlocksAroundChild):
(WebCore::RenderBlock::createAnonymousBoxWithSameTypeAs):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.h:

(WebCore::RenderBox::createAnonymousBoxWithSameTypeAs):
(RenderBox):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::splitFlow):

  • rendering/RenderTable.h:

(WebCore::RenderTable::createAnonymousBoxWithSameTypeAs):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::createAnonymousBoxWithSameTypeAs):

  • rendering/RenderTableRow.h:

(WebCore::RenderTableRow::createAnonymousBoxWithSameTypeAs):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::createAnonymousBoxWithSameTypeAs):

2:31 PM Changeset in webkit [113496] by timothy_horton@apple.com
  • 6 edits in trunk

[cg] REGRESSION (r101517): Animating the transform of a <rect> with shape-rendering: crispEdges leaves behind garbage
​https://bugs.webkit.org/show_bug.cgi?id=82963
<rdar://problem/11170476>

Reviewed by Simon Fraser.

CoreGraphics can inflate the stroke by 1px when drawing a rectangle
with antialiasing disabled at non-integer coordinates, we need to
compensate by inflating the RenderSVGRect repaint bounds by 1px.

No new tests, as this is not reproducible in DRT or WKTR.

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::createShape):
(WebCore::RenderSVGRect::strokeBoundingBox):

  • rendering/svg/RenderSVGRect.h:

(RenderSVGRect):

New Mac baselines for two tests which have SVG <rect>s with shape-rendering: crispEdges.

  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/mac/svg/custom/shape-rendering-expected.txt:
2:19 PM Changeset in webkit [113495] by commit-queue@webkit.org
  • 9 edits in trunk

Tools: Enable MediaSource feature for DumpRenderTree so
MediaSource LayoutTests will pass for Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=83053

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-04-06
Reviewed by Dimitri Glazkov.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests: Fix MediaSource LayoutTests to work with the new XHR behavior
that requires asynchronous requests for the 'arraybuffer'
responseType.
​https://bugs.webkit.org/show_bug.cgi?id=83053

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-04-06
Reviewed by Dimitri Glazkov.

  • http/tests/media/media-source/webm/video-media-source-errors.html:
  • http/tests/media/media-source/webm/video-media-source-play.html:
  • http/tests/media/media-source/webm/video-media-source-seek.html:
  • http/tests/media/media-source/webm/video-media-source-state-changes.html:
  • http/tests/media/media-source/webm/webm-media-source.js:

(getData.request.onload):
(createClusterGetFunction.return.if):
(createClusterGetFunction):
(loadWebMData):
(getCluster):
(appendCluster):
(getReadyStateName):
(expectSourceState):
(expectReadyState):

  • platform/chromium/test_expectations.txt:
2:17 PM Changeset in webkit [113494] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Avoid trying to set filters on transform layers
​https://bugs.webkit.org/show_bug.cgi?id=83344

Reviewed by Dean Jackson.

Return early from GraphicsLayerCA::setFilters() when the filters
haven't changed. This avoids trying to clear filters on CALayers
which never had them, which should both help performance, and avoids
console spew related to setting shadow properties on transform layers.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setFilters):

2:15 PM Changeset in webkit [113493] by jamesr@google.com
  • 17 edits
    6 adds in trunk

WebGL content swapped at wrong time in threaded compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=82275

Reviewed by Kenneth Russell.

Source/WebCore:

When using threaded compositing, we need to defer touching the texture ID being used by the compositor until the
appropriate point in the synchronization routine and not before. Specifically, there is no time at which it is
safe to manipulate the texture the compositor may be using from the main thread. This breaks up the presentation
path into a few pieces (depending on the context attributes) in order to maintain these invariants.

Depending on the context attributes and if we're in threaded mode, there are a few different possible back/front
buffer combinations:

  • When the context is antialiased, we have a multisampled renderbuffer and associated framebuffer.
  • In all cases, we have a color texture back buffer.
  • When preserveDrawingBuffer is set or threaded compositing is enabled, we have a separate color texture as a

front buffer.

The resource update is in two phases. First, on the main thread, we prepare the back buffer. This resolves from
the multisampled FBO into the back color buffer if multisampled and swaps the front / back color buffer textures
if preserveDrawingBuffer is false and we're using separate front / back color buffers. Second, on the compositor
thread, we do a texture copy from the back to the front color buffer if preserveDrawingBuffer is true. After
these steps are complete the main thread is free to manipulate the back buffer color texture without affecting
any resources the compositor is using.

One incidental cleanup this patch also does is remove all state queries from DrawingBuffer::clearFramebuffer().

Tests: fast/canvas/webgl/webgl-composite-modes-repaint.html

fast/canvas/webgl/webgl-composite-modes.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::restoreStateAfterClear):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

  • platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):

  • platform/graphics/cairo/DrawingBufferCairo.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::initialize):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):
(WebCore::DrawingBuffer::platformLayer):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::paintContentsIfDirty):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::setNeedsDisplayRect):
(WebCore::WebGLLayerChromium::setDrawingBuffer):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/clutter/DrawingBufferClutter.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::initializeContext):

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::clearFramebuffer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::discardResources):

  • platform/graphics/gpu/DrawingBuffer.h:

(DrawingBuffer):

  • platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):

  • platform/graphics/gpu/qt/DrawingBufferQt.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::platformLayer):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore):
(WebCore::DrawingBuffer::frontColorBuffer):

Source/WebKit/chromium:

  • tests/WebGLLayerChromiumTest.cpp:

(WebKit::TEST):

LayoutTests:

Adds some pixel tests for compositing all different combinations of alpha/antialias/preserveDrawingBuffer on
WebGL content.

  • fast/canvas/webgl/webgl-composite-modes-expected.png: Added.
  • fast/canvas/webgl/webgl-composite-modes-expected.txt: Added.
  • fast/canvas/webgl/webgl-composite-modes-repaint-expected.png: Added.
  • fast/canvas/webgl/webgl-composite-modes-repaint-expected.txt: Added.
  • fast/canvas/webgl/webgl-composite-modes-repaint.html: Added.
  • fast/canvas/webgl/webgl-composite-modes.html: Added.
2:10 PM Changeset in webkit [113492] by tony@chromium.org
  • 29 edits
    6 adds in trunk/LayoutTests

[chromium] Unreviewed, land some mac/win baselines for table tests after r111742.

  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2123-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2509-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug34176-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2123-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2509-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug34176-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/chromium-mac/fast/repaint/scroll-inside-table-cell-expected.png:
  • platform/chromium-mac/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/chromium-mac/fast/table/cell-pref-width-invalidation-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2123-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2123-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2509-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2509-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug34176-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug34176-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug59252-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7243-expected.txt: Added.
  • platform/chromium-win/fast/repaint/scroll-inside-table-cell-expected.png:
  • platform/chromium-win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium/test_expectations.txt:
1:41 PM Changeset in webkit [113491] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix after r113486 and r113487.

  • rendering/RenderObject.cpp:

Added missing #include.

  • rendering/RenderView.h:

Removed bad OVERRIDE.

1:20 PM Changeset in webkit [113490] by Beth Dakin
  • 7 edits
    9 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=81939
-webkit-image-set should update dynamically when the device scale factor
changes
-and corresponding-
<rdar://problem/11101108>

Reviewed by Darin Adler.

Source/WebCore:

New member variable to keep track of the scale factor.

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::CSSImageSetValue):
(WebCore::CSSImageSetValue::bestImageForScaleFactor):

Merge the two cachedImageSet functions. There was no need for two functions here.

(WebCore::CSSImageSetValue::cachedImageSet):

cachedOrPendingImageSet() now takes a Document as a parameter so that it can
access the deviceScaleFactor. If there is a cached image already and the
Document's deviceScaleFactor doesn't match m_scaleFactor, then m_imageSet is set
to a pending image so that the best fit image will be reassessed and then
loaded.
(WebCore::CSSImageSetValue::cachedOrPendingImageSet):

  • css/CSSImageSetValue.h:

(WebCore):
(CSSImageSetValue):

cachedOrPendingImageSet() now takes a Document.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

StyleCachedImageSet should inherit from CachedImageClient just like
StyleCachedImage. It should add and remove itself as a client upon creation
and destruction, respectively.

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::StyleCachedImageSet):
(WebCore):
(WebCore::StyleCachedImageSet::~StyleCachedImageSet):

  • rendering/style/StyleCachedImageSet.h:

(StyleCachedImageSet):

LayoutTests:

  • fast/hidpi/image-set-background-dynamic.html: Added.
  • fast/hidpi/image-set-border-image-dynamic.html: Added.
  • fast/hidpi/image-set-in-content-dynamic.html: Added.
  • platform/mac/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/mac/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
  • platform/mac/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/mac/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
  • platform/mac/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/mac/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
1:12 PM Changeset in webkit [113489] by staikos@webkit.org
  • 2 edits in trunk/Tools

Turn on vibration support for BlackBerry.

Reviewed by Rob Buis.

  • Scripts/build-webkit:
1:07 PM Changeset in webkit [113488] by schenney@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Chromium} Rebaseline some failing Leopard tests
​https://bugs.webkit.org/show_bug.cgi?id=83387

Unreviewed chromium test expectations update.

  • platform/chromium-mac-leopard/fast/text/atsui-multiple-renderers-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/find-kana-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:04 PM Changeset in webkit [113487] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

Update LayoutUnit usage in RenderView
​https://bugs.webkit.org/show_bug.cgi?id=83147

Reviewed by Julien Chaffraix.

Updating the usage of LayoutUnits in RenderView in preparation for sub-pixel layout. This mostly
affects paint and repaint functions, which take LayoutRects up to the RenderView level. This is
necessary as we continue to accumulate sub-pixel offsets up to this level.

No new tests. No change in behavior.

  • rendering/RenderView.cpp:

(WebCore::RenderView::paint): Adding an assert that we're being called to paint on pixel
boundaries. We don't currently ever position RenderViews at sub-pixel offsets.
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle): Switching to a LayoutRect and cleaning up a fixme
that used decomposed offsets. Pixel snapping is applied before handing the rect up to the
FrameView.
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers): Pixel snapping before handing
the rect up to the Compositor.
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):

  • rendering/RenderView.h:

(RenderView):

1:02 PM Changeset in webkit [113486] by timothy_horton@apple.com
  • 59 edits
    17 adds in trunk

Add autodetection of image orientation from EXIF information
​https://bugs.webkit.org/show_bug.cgi?id=19688
<rdar://problem/4126979> and <rdar://problem/11091578>

Original patch by David Carson and Eric Seidel.

Reviewed by Simon Fraser.

Add support for respecting EXIF image orientation, enabled by default for ImageDocuments.
The setting shouldRespectImageOrientation causes orientation to take effect for any image included via <img>.

Test: fast/images/exif-orientation.html, fast/images/exif-orientation-css.html

File list truncated because it's very long.

12:58 PM Changeset in webkit [113485] by jsbell@chromium.org
  • 3 edits in trunk/LayoutTests

IndexedDB: Race condition in layout test logging from window and worker
​https://bugs.webkit.org/show_bug.cgi?id=83378

The sequencing of logging directly from window vs. logging via posted events
from a worker is racy, making this test flake when run under Chromium. Removed
the sensitive logging on the window side; the test logic is unaffected as the
blocked/success event sequence would not be present if the window handler was
not run.

Reviewed by Tony Chang.

  • storage/indexeddb/dont-commit-on-blocked-expected.txt:
  • storage/indexeddb/dont-commit-on-blocked.html:
12:54 PM Changeset in webkit [113484] by leviw@chromium.org
  • 4 edits in trunk/Source

Correct LayoutUnit usgae in RenderThemeQt and RenderThemeQStyle
​https://bugs.webkit.org/show_bug.cgi?id=83376

Reviewed by Eric Seidel.

Source/WebCore:

Correcting LayoutUnit usage in QT RenderTheme code.

No new tests. No change in behavior.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::convertToPaintingRect): Rounding the ancestor offset before
applying it to the pixel snapped partRect.
(WebCore::RenderThemeQt::paintSearchFieldCancelButton): Also rounding the ancestor
offset, and also pixel snapping the content rect before painting.

Source/WebKit/qt:

Calculating the progress animation using the pixel-snapped RenderProgress size instead
of the internal sub-pixel version.

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::animationDurationForProgressBar):

12:47 PM Changeset in webkit [113483] by commit-queue@webkit.org
  • 8 edits
    6 moves
    13 adds
    12 deletes in trunk/LayoutTests

[chromium] Rebaseline svg/clip-path/deep-nested-clip-in-mask* expectations
​https://bugs.webkit.org/show_bug.cgi?id=83368

Unreviewed Chromium expectations rebaseline.

Patch by Florin Malita <​fmalita@google.com> on 2012-04-06

  • platform/chromium-mac-leopard/svg/clip-path/clip-path-pixelation-expected.png:
  • platform/chromium-mac-leopard/svg/clip-path/deep-nested-clip-in-mask-expected.png:
  • platform/chromium-mac-leopard/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png:
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-in-mask-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-pixelation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/deep-nested-clip-in-mask-expected.png:
  • platform/chromium-mac-snowleopard/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png:
  • platform/chromium-mac-snowleopard/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-in-mask-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/clip-path-pixelation-expected.png:
  • platform/chromium-mac/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-expected.png: Added.
  • platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
  • platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/clip-path/deep-nested-clip-in-mask-expected.txt.
  • platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Added.
  • platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt.
  • platform/chromium-win/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
  • platform/chromium-win/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
  • platform/chromium-win/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/clip-path/clip-in-mask-expected.txt: Removed.
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-in-mask-expected.txt: Removed.
  • platform/qt/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
  • platform/qt/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
  • platform/qt/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
  • svg/clip-path/clip-in-mask-expected.txt: Renamed from LayoutTests/platform/gtk/svg/clip-path/clip-in-mask-expected.txt.
  • svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Renamed from LayoutTests/platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt.
  • svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Renamed from LayoutTests/platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt.
  • svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Renamed from LayoutTests/platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt.
12:43 PM Changeset in webkit [113482] by schenney@chromium.org
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

Font-related tests are flaky on Chromium (sometimes glyphs don't draw)
​https://bugs.webkit.org/show_bug.cgi?id=66908

Unreviewed chromium test expectations update.

  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-fallback-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt:
  • platform/chromium-mac/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:43 PM Changeset in webkit [113481] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

context-lost.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=81325

Reviewed by James Robinson.

Ensure that the DrawingBuffer does not attempt to restore the
TEXTURE_2D binding to an already-deleted texture.

Tested with layout test fast/canvas/webgl/context-lost.html as
well as WebGL conformance tests.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::loseContextImpl):

12:37 PM Changeset in webkit [113480] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r113267.
​http://trac.webkit.org/changeset/113267
​https://bugs.webkit.org/show_bug.cgi?id=83384

causes dhtml perf regression (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-06

Source/WebCore:

  • dom/ChildListMutationScope.cpp:

(ChildListMutationScope::MutationAccumulator):
(WebCore::ChildListMutationScope::MutationAccumulator::isAddedNodeInOrder):
(WebCore::ChildListMutationScope::MutationAccumulator::childAdded):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::childAdded):

  • dom/ChildListMutationScope.h:

(WebCore::ChildListMutationScope::childAdded):
(MutationAccumulationRouter):

  • dom/ContainerNode.cpp:

(WebCore):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::dispatchChildInsertionEvents):
(WebCore::updateTreeAfterInsertion):

LayoutTests:

  • fast/events/domnodeinserted-entire-fragment-expected.txt: Removed.
  • fast/events/domnodeinserted-entire-fragment.html: Removed.
12:28 PM Changeset in webkit [113479] by schenney@chromium.org
  • 2 edits
    4 deletes in trunk/LayoutTests

6 layout tests known to fail on Mac10.6 with CPU-Skia graphics
​https://bugs.webkit.org/show_bug.cgi?id=68436

Unreviewed Chromium test expectations update.

One of the files marked in this bug is a minor rebaselining. Done.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
12:19 PM Changeset in webkit [113478] by schenney@chromium.org
  • 12 edits
    1 add in trunk/LayoutTests

Rebaseline after Skia 2527 landed
​https://bugs.webkit.org/show_bug.cgi?id=83375

Unreviewed update of Chromium test expectations.

Patch by Philip Rogers <​pdr@google.com> on 2012-04-06

  • platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png: Added.
  • platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium/test_expectations.txt:
12:16 PM Changeset in webkit [113477] by schenney@chromium.org
  • 7 edits
    1 add
    1 delete in trunk/LayoutTests

Rebaseline after r109097
​https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed update of test expectations.

Patch by Philip Rogers <​pdr@google.com> on 2012-04-06

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/chromium/test_expectations.txt:
12:14 PM Changeset in webkit [113476] by schenney@chromium.org
  • 16 edits
    14 adds
    1 delete in trunk/LayoutTests

Rebaseline tests for wk62974
​https://bugs.webkit.org/show_bug.cgi?id=62974

Unreviewed test expectations update for Chromium.

Patch by Philip Rogers <​pdr@google.com> on 2012-04-06

  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-04-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.png:
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-altglyph-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/text-text-04-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/text-text-06-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-04-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-06-t-expected.png: Added.
  • platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd: Removed.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/wicd: Added.
  • platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • platform/chromium-win/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-04-t-expected.png:
  • platform/chromium-win/svg/text/text-text-06-t-expected.png:
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/chromium/test_expectations.txt:
12:10 PM Changeset in webkit [113475] by schenney@chromium.org
  • 5 edits
    1 add
    2 deletes in trunk/LayoutTests

[Chromium] Layout Test svg/custom/oversized-pattern-scale.svg and svg/custom/transformed-pattern-clamp-svg-root.svg are flaky
​https://bugs.webkit.org/show_bug.cgi?id=68982

Unreviewed Chromium expectations update.

These tests now passing without issue.

  • platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png: Removed.
  • platform/chromium-mac/svg/custom/oversized-pattern-scale-expected.png: Added.
  • platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png:
  • platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png:
  • platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png:
  • platform/chromium/svg/custom/oversized-pattern-scale-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
12:07 PM Changeset in webkit [113474] by Martin Robinson
  • 2 edits
    1 add in trunk/LayoutTests

Unskip some tests that appear to be passing on GTK+ and add a
new baseline to deal with whitespace issues.

  • platform/gtk/Skipped: Unskip some tests passing locally.
  • platform/gtk/plugins/document-open-expected.txt: Added.
12:06 PM Changeset in webkit [113473] by jsbell@chromium.org
  • 8 edits
    1 add in trunk/Source

IndexedDB: ObjectStore/Index shouldn't hold reference to backing store
​https://bugs.webkit.org/show_bug.cgi?id=83074

Source/WebCore:

We should be able to collect and close the leveldb backing store as soon as the database
connection is closed, but the IDBObjectStoreBackendImpl and IDBIndexBackendImpl were
holding RefPtrs, and those objects are kept alive by script references.

Replaced RefPtrs to the IDBBackingStore with pointers to the IDBDatabase. On the back end,
IDBDatabaseBackendImpl maintains a RefPtr to the IDBObjectStoreBackendImpl object, so
a raw pointer back is safe. On the front end, the IDBObjectStore maintains a RefPtr to
the IDBDatabase so script can navigate upwards. Ditto on both ends for the ObjectStore/Index
relationship. The frontend objects maintain RefPtrs to the backend objects, so the backend
objects and their owners are maintained as long as there's a script reference.

Also made IDBDatabaseBackendImpl handle a null IDBFactoryBackendImpl pointer, for testing.

Reviewed by Tony Chang.

Tests: webkit_unit_tests --gtest_filter="IDBDatabaseBackendTest.*"

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::backingStore):
(WebCore::IDBIndexBackendImpl::databaseId):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::create):
(IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::backingStore):
(WebCore::IDBObjectStoreBackendImpl::databaseId):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/IDBDatabaseBackendTest.cpp: Added.

(WebCore):
(MockIDBBackingStore):
(WebCore::TEST):

11:56 AM Changeset in webkit [113472] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build warning on const long long to int implicit conversion.

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):

11:55 AM Changeset in webkit [113471] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix LayoutUnit usage and rounding in RenderBlock and RenderEmbeddedObject
​https://bugs.webkit.org/show_bug.cgi?id=83343

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and rounding/pixel snapping in RenderBlock and
RenderEmbeddedObject in preparation for turing on subpixel support.

No new tests, no change in functionality.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::baselinePosition):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::nodeAtPoint):

11:55 AM Changeset in webkit [113470] by schenney@chromium.org
  • 6 edits
    2 adds
    3 deletes in trunk/LayoutTests

Zooming in SVGs in <object> is flakey
​https://bugs.webkit.org/show_bug.cgi?id=71673

Unreviewed Chromium test expectations update.

  • platform/chromium-linux-x86/svg/zoom/page: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium/test_expectations.txt:
11:50 AM Changeset in webkit [113469] by Martin Robinson
  • 3 edits in trunk/LayoutTests

[GTK] crash in editing/selection/editable-html-element.html
​https://bugs.webkit.org/show_bug.cgi?id=64530

Unskip and rebaseline a test.

  • platform/gtk/Skipped: Unskip this test, because it's passing locally.
  • platform/gtk/editing/selection/editable-html-element-expected.txt:
11:46 AM Changeset in webkit [113468] by Martin Robinson
  • 5 edits
    1 add in trunk/LayoutTests

REGRESSION(r65062): out of bound access in TextIterator (5 editing tests) on GTK
​https://bugs.webkit.org/show_bug.cgi?id=63611

Unskip tests that are now passing and rebaseline ones which
have changed results.

  • platform/gtk/Skipped:
  • platform/gtk/editing/deleting/smart-delete-003-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-004-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
11:41 AM Changeset in webkit [113467] by mitz@apple.com
  • 12 edits in trunk

<rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.

Tools:

  • Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops: Added ENABLE_HIGH_DPI_CANVAS.
11:34 AM Changeset in webkit [113466] by leviw@chromium.org
  • 6 edits in trunk/Source/WebCore

Update LayoutUnit usage in Editor and Frame
​https://bugs.webkit.org/show_bug.cgi?id=83278

Reviewed by Eric Seidel.

Frame and Editor both take input from the embedder, which passes along coordinates in screen
coordinates, which aren't fractional. Updating a few remaining functions to show this, and correcting
some inconsistencies in LayoutUnit usage.

No new tests. No change in behavior.

  • editing/Editor.cpp:

(WebCore::Editor::rangeForPoint): windowToContents returns an IntPoint.
(WebCore::Editor::countMatchesForText): Using enclosingIntRect since we're (fake) repainting the entire
view rect.

  • editing/Editor.h:

(Editor): Correcting mismatched function signature.

  • page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint): Frame takes points in screen coordinates, usually from the
embedder. Changing these functions to be in IntPoints.
(WebCore::Frame::documentAtPoint): Ditto.
(WebCore::Frame::rangeForPoint): Ditto.

  • page/Frame.h:

(Frame):

  • platform/graphics/IntRect.h:

(enclosingIntRect): Adding an inline no-op copy of the FractionalLayoutRect method enclosingIntRect.

11:34 AM Changeset in webkit [113465] by schenney@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

Layout Test svg/text/non-bmp-positioning-lists.svg is failing
​https://bugs.webkit.org/show_bug.cgi?id=73494

Unreviewed Chromium test expectations.

The font is not right, but that's not what the test is testing.

  • platform/chromium-linux/svg/text/non-bmp-positioning-lists-expected.png: Added.
  • platform/chromium-linux/svg/text/non-bmp-positioning-lists-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Added.
  • platform/chromium-mac/svg/text/non-bmp-positioning-lists-expected.png: Added.
  • platform/chromium-win/svg/text/non-bmp-positioning-lists-expected.png: Added.
  • platform/chromium-win/svg/text/non-bmp-positioning-lists-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:30 AM Changeset in webkit [113464] by Martin Robinson
  • 2 edits in trunk

Fix the GTK+ debug build.

  • Source/autotools/symbols.filter: Add a missing symbol to the symbols.list file.
11:25 AM Changeset in webkit [113463] by schenney@chromium.org
  • 5 edits
    3 adds
    4 deletes in trunk/LayoutTests

SVG filters incorrectly move elements
​https://bugs.webkit.org/show_bug.cgi?id=73643

Unreviewed Chromium test expectations update.

  • platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
  • platform/chromium-linux/svg/filters/filter-placement-issue-expected.png: Removed.
  • platform/chromium-linux/svg/filters/filterRes2-expected.png: Removed.
  • platform/chromium-mac/svg/filters/filter-placement-issue-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes2-expected.png: Modified property svn:mime-type.
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-win/svg/filters/filter-placement-issue-expected.png: Added.
  • platform/chromium-win/svg/filters/filterRes2-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
  • svg/as-background-image/svg-as-background-2-expected.txt: Added.
11:23 AM Changeset in webkit [113462] by tommyw@google.com
  • 12 edits
    3 copies
    1 move
    1 delete in trunk/Source/WebCore

MediaStream API: Deleting the chromium bridge class MediaStreamCenterInternal
​https://bugs.webkit.org/show_bug.cgi?id=83167

Reviewed by Adam Barth.

The situation before this patch is that we had a MediaStreamCenter.h with #ifdefs for the chromium specific
private class MediaStreamCenterInternal. This bridge class only shuffled calls between MediaStreamCenter and
WebMediaStreamCenter and was needed before the introduction of Platform.
To get rid of this now unnecessary class I had two alternatives:
1) Sprinkle platform/MediaStreamCenter.h with more #ifdefs, including around the class declaration.
2) Create an abstract base class that the chromium and gstreamer implementations overrides.
My personal preference is 2) since I strongly dislike #ifdefs. The drawback is that MediaStreamCenter now
has a vtable. However since all methods in this class are extremely low-usage it doesn't affect anything
in practice.

No code behaviour changes.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::setEnabled):

  • Modules/mediastream/UserMediaRequest.cpp:
  • Modules/mediastream/UserMediaRequest.h:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/support/WebMediaStreamSourcesRequest.cpp:
  • platform/mediastream/MediaStreamCenter.cpp:

(WebCore::MediaStreamCenter::MediaStreamCenter):
(WebCore):
(WebCore::MediaStreamCenter::~MediaStreamCenter):

  • platform/mediastream/MediaStreamCenter.h:

(WebCore):
(MediaStreamCenter):

  • platform/mediastream/MediaStreamSourcesQueryClient.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.h.

(WebCore):
(MediaStreamSourcesQueryClient):
(WebCore::MediaStreamSourcesQueryClient::~MediaStreamSourcesQueryClient):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenter::instance):
(WebCore::MediaStreamCenterChromium::MediaStreamCenterChromium):
(WebCore::MediaStreamCenterChromium::~MediaStreamCenterChromium):
(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenterChromium::didStopLocalMediaStream):
(WebCore::MediaStreamCenterChromium::didConstructMediaStream):
(WebCore::MediaStreamCenterChromium::constructSDP):
(WebCore):
(WebCore::MediaStreamCenterChromium::stopLocalMediaStream):

  • platform/mediastream/chromium/MediaStreamCenterChromium.h: Renamed from Source/WebCore/platform/mediastream/chromium/MediaStreamCenterInternal.h.

(WebKit):
(WebCore):
(MediaStreamCenterChromium):

  • platform/mediastream/chromium/MediaStreamCenterInternal.cpp: Removed.
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(WebCore::MediaStreamCenter::instance):
(WebCore::MediaStreamCenterGStreamer::MediaStreamCenterGStreamer):
(WebCore::MediaStreamCenterGStreamer::~MediaStreamCenterGStreamer):
(WebCore::MediaStreamCenterGStreamer::queryMediaStreamSources):
(WebCore::MediaStreamCenterGStreamer::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenterGStreamer::didStopLocalMediaStream):
(WebCore::MediaStreamCenterGStreamer::didConstructMediaStream):
(WebCore::MediaStreamCenterGStreamer::constructSDP):

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.h.

(WebCore):
(MediaStreamCenterGStreamer):

11:17 AM Changeset in webkit [113461] by Simon Fraser
  • 3 edits
    2 adds in trunk

Should disable preserves3D() for things that enforce flattening, like overflow and filters
​https://bugs.webkit.org/show_bug.cgi?id=83337

Source/WebCore:

Reviewed by Dean Jackson.

The CSS3 Transforms spec says that some properties should cause flattening
of things with transform-style: preserve-3d. We currently do this as a side
effect of the GraphicsLayer structure, but we should really do it at the
RenderStyle level, as we do for other things like stacking context creation.

Test: compositing/overflow-trumps-transform-style.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

Reviewed by Dean Jackson.

Test for computed style and layer structure combining transform-style
with overflow.

  • compositing/overflow-trumps-transform-style-expected.txt: Added.
  • compositing/overflow-trumps-transform-style.html: Added.
11:07 AM Changeset in webkit [113460] by tommyw@google.com
  • 6 edits in trunk/Source/WebCore

MediaStream API: MediaStreams stops proper cleanup to take place during a page reload.
​https://bugs.webkit.org/show_bug.cgi?id=83143

Reviewed by Adam Barth.

To fix this I have converted MediaStream and LocalMediaStream to be ActiveDOMObjects.

Have no idea how to write a test that succesfully verifies this. I have done manual testing
to verify that proper tear-down now takes place.

  • Modules/mediastream/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::create):
(WebCore::LocalMediaStream::stopFunction):
(WebCore):

  • Modules/mediastream/LocalMediaStream.h:

(LocalMediaStream):

  • Modules/mediastream/LocalMediaStream.idl:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::scriptExecutionContext):

  • Modules/mediastream/MediaStream.h:

(MediaStream):

11:06 AM Changeset in webkit [113459] by schenney@chromium.org
  • 4 edits in trunk/LayoutTests

[chromium] Rounding issue on some RenderSVGPath values
​https://bugs.webkit.org/show_bug.cgi?id=75367

Unreviewed Chromium expectations update.

These tests have been stable for a long time, and consistent across
all platforms. Whatever was causing previous flakiness is apparently
no longer happening.

  • platform/chromium/svg/css/composite-shadow-example-expected.txt:
  • platform/chromium/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/chromium/test_expectations.txt:
10:53 AM Changeset in webkit [113458] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] svg/text/text-style-recalc-crash.html times out
​https://bugs.webkit.org/show_bug.cgi?id=75696

Unreviewed Chromium test_expectations cleanup.

The test referenced by this bug has not failed in the current history of the flakiness board.

  • platform/chromium/test_expectations.txt:
10:48 AM Changeset in webkit [113457] by mitz@apple.com
  • 12 edits in trunk/Source/WebCore

<rdar://problem/10912476> Pixel access canvas APIs do not work transparently with high-DPI backing store
​https://bugs.webkit.org/show_bug.cgi?id=83072

Reviewed by Simon Fraser.

Made getImageData, putImageData, and toDataURL downsample/upsample when pixels in the canvas
backing store are not in a 1:1 ratio to CSS pixels. This makes clients of these APIs
indifferent to the backing store resolution, up to sampling artifacts.

In order for this to work, ImageBuffer has to know and respect the resolutionScale
parameter. This change makes the Core Graphics-based implementation of ImageBuffer do this,
but on other platforms, resolutionScale values other than 1 will not work. Such platforms
should not enable the HIGH_DPI_CANVAS feature.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement): Updated a comment.
(WebCore::HTMLCanvasElement::createImageBuffer): Changed to create an ImageBuffer with
the desired resolution instead of 1.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage): Removed code that scaled the source rect,
since this is now handled at the ImageBuffer level.
(WebCore::CanvasRenderingContext2D::createImageData): Now returns ImageData of the requested
size regardless of the backing store resolution.
(WebCore::CanvasRenderingContext2D::getImageData): Ditto.

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create): Removed some code that tried to apply the resolution scale
to the buffer after creating it, and changed to pass the resolution scale down to the
(platform-specific) constructor, which can apply it correctly.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer): Added a resolutionScale parameter, which is used to
compute the backing buffer size, and to apply a device scale factor to the context.
(WebCore::ImageBuffer::copyImage): Changed to return an image scaled down to the logical
size of the buffer.
(WebCore::ImageBuffer::getUnmultipliedImageData): Changed to pass the resolution scale to
ImageData::getData().
(WebCore::ImageBuffer::getPremultipliedImageData): Ditto.
(WebCore::ImageBuffer::putByteArray): Changed to pass the resolution scale to
ImageData::putData(). When drawing the byte array as an image, changed to preserve the base
CTM in the destination context (thus mapping from image data pixels to backing store pixels).
(WebCore::ImageBuffer::toDataURL): Fixed a CGColorSpace leak. Made the returned image have
the buffer’s logical size instead of the backing buffer’s size.
(WebCore::ImageDataToDataURL): Fixed a CGColorSpace leak.

  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData): Added a resolutionScale parameter. The source
coordinates are scaled by the value of that parameter, and a reverse scaling transform
is applied when copying from the backing store into the destination (either explicitly
using Accelerate or implicitly by drawing as an image). Since after scaling,
unpremultiplication and component permutation are done in-place, made the
non-Accelerate code that does these things safe in this case.
(WebCore::ImageBufferData::putData): Added a resolutionScale parameter. The destination
coordinates are scaled by the value of that parameter, and a scaling transform is applied
when copying from the source into the backing store (either explicitly using Accelerate or
implicitly by drawing as an image). Since after scaling, premultiplication and component
permutation are done in-place, made the non-Accelerate code that does these things safe in
this case.

  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::ImageBuffer):

10:37 AM Changeset in webkit [113456] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Draw debug borders for tiles on layers with skipsDraw
​https://bugs.webkit.org/show_bug.cgi?id=83352

Patch by Dana Jansens <​danakj@chromium.org> on 2012-04-06
Reviewed by Adrienne Walker.

The tiles are given the same color as other missing tiles.

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

10:35 AM Changeset in webkit [113455] by rwlbuis@webkit.org
  • 10 edits in trunk/Source

Fix cast-align warnings in JSC
​https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by George Staikos.

Source/JavaScriptCore:

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::link):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::linkCode):

  • heap/MarkStack.cpp:

(JSC::SlotVisitor::copyAndAppend):

  • runtime/JSArray.cpp:

(JSC::JSArray::visitChildren):

  • wtf/RefCountedArray.h:

(WTF::RefCountedArray::Header::payload):

Source/WebCore:

  • platform/graphics/WOFFFileFormat.cpp:

(WebCore::readUInt32):
(WebCore::readUInt16):

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::preMultipliedBGRAtoRGB):

  • platform/network/MIMESniffing.cpp:
10:31 AM Changeset in webkit [113454] by Darin Adler
  • 17 edits in trunk/Source

Streamline strtod and fix some related problems
​https://bugs.webkit.org/show_bug.cgi?id=82857

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::Lexer<>::lex): Use parseDouble. Since we have already scanned the number
and we know it has only correct characters, leading spaces, trailing junk, and
trailing spaces are not a possibility. No need to add a trailing null character.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseInt): Changed overflow based 10 case to use parseDouble. No need
to allow trailing junk since the code above already allows only numeric digits
in the string. This code path is used only in unusual cases, so it's not
optimized for 8-bit strings, but easily could be.
(JSC::jsStrDecimalLiteral): Removed the allow trailing junk argument to this
function template because all the callers are OK with trailing junk. Use the
parseDouble function. No need to copy the data into a byte buffer, because
parseDouble handles that.
(JSC::toDouble): Got rid of the DisallowTrailingJunk argument to the
jsStrDecimalLiteral function template. That's OK because this function
already checks for trailing junk and handles it appropriately. The old code
path was doing it twice.
(JSC::parseFloat): Got rid of the AllowTrailingJunk argument to the
jsStrDecimalLiteral function template; the template allows junk unconditionally.

  • runtime/LiteralParser.cpp:

(JSC::::Lexer::lexNumber): Use parseDouble. Since we have already scanned the number
and we know it has only correct characters, leading spaces, trailing junk, and
trailing spaces are not a possibility. No need to add a trailing null character.
No need to copy the data into a byte buffer, because parseDouble handles that.
We could optimize the UChar case even more because we know all the characters
are ASCII, but not doing that at this time.

Source/WebCore:

Refactoring of code covered by existing tests.

  • dom/ViewportArguments.cpp:

(WebCore::numericPrefix): Removed a confusing comment that just said
"we tolerate extra characters" in a roundabout way. Made the "ok"
argument optional. Changed to call the new version of charactersToFloat
that returns the number of characters parsed rather than using the
charactersToFloatIgnoringJunk/didReadNumber solution from before.
(WebCore::findSizeValue): Since numericPrefix is guaranteed to return 0
when it can't parse, removed the "ok" code. Also changed the unusual
syntax "float(1.0)" to just "1", which works just as well.
(WebCore::findScaleValue): Ditto.
(WebCore::findUserScalableValue): Ditto.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseToDoubleForNumberType): Removed an unneeded code path
and replaced it with an assertion; toDouble no longer will return infinity
or not-a-number values.

Source/WTF:

Replaced the strtod function template with a parseDouble function, eliminating
the following unneeded features:

  • need for a trailing null character and a call to strlen
  • needless conversion of string lengths from size_t to int and back that created the possibility of incorrect truncation
  • one level of function call; use inlining instead
  • construction of the StringToDoubleConverter object; it was used to pass arguments that are known at compile time
  • most of the StringToDoubleConverter::StringToDouble function's body; it was code we did not need
  • parsing of Infinity and NaN at the strtod level; added recently when we moved from the old strtod to the new one, and not needed or helpful at this level
  • multiple copies of code to narrow to single byte strings; in many cases this was done even when starting with an LChar string that is already single-byte, now we handle this with an overload of parseDouble
  • wtf/dtoa.cpp:

Removed a long comment about the original strtod function that no longer
applies since we deleted that function long ago. Removed a lot of includes.
Removed the strtod function templates and its instantiations, since they
are now replaced by the parseDouble function.
(WTF::Internal::parseDoubleFromLongString): Added.

  • wtf/dtoa.h:

Added an include of ASCIICType.h so we can use isASCII in a function in this
header. Left the heretofore unneeded include of double-conversion.h, since we
now want to use it in a function in this header. Removed the AllowTrailingJunkTag
and AllowTrailingSpacesTag enumerations and the strtod function template. Added
new parseDouble function, and inline implementation of it.

  • wtf/dtoa/double-conversion.cc: Removed quite a bit of unused code, hardcoding

all the StringToDouble function arguments that come from data members so it can
be a much smaller static member function. Also changed the types of arguments
from int to size_t.

  • wtf/dtoa/double-conversion.h: Removed most of the StringToDoubleConverter

class, leaving only the conversion function as a static member function.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::toDouble): Got rid of didReadNumber.
(WTF::StringImpl::toFloat): Ditto.

  • wtf/text/StringImpl.h: Ditto.
  • wtf/text/WTFString.cpp:

(WTF::String::toDouble): Got rid of didReadNumber.
(WTF::String::toFloat): Ditto.
(WTF::toDoubleType): Rewrote this function to use parseDouble. Moved the code
to skip leading spaces here, because other callers of parseDouble don't want
to do that. Repurposed the check for an empty string so it's now the same
code shared by all the "parsed nothing" cases. Removed the code to convert
the buffer to ASCII for two reasons: (1) We don't need that code at all when
CharType is LChar, and (2) We now handle this through the two overloads for
the parseDouble function. Disallowing trailing junk is now handled here,
rather than inside parseDouble.
(WTF::charactersToDouble): Updated for changes to toDoubleType. Removed the
didReadNumber argument.
(WTF::charactersToFloat): Ditto. Also added overloads that return the parsed
length. These are a slightly more powerful way to do what didReadNumber was
used for before.

  • wtf/text/WTFString.h: Added comments, eliminated didReadNumber, and added

overloads of charactersToFloat that replace charactersToFloatIgnoringJunk.

10:29 AM Changeset in webkit [113453] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[chromium] Surface replica should have a separate quad in the render pass
​https://bugs.webkit.org/show_bug.cgi?id=83287

Patch by Dana Jansens <​danakj@chromium.org> on 2012-04-06
Reviewed by Adrienne Walker.

Generate separate quads for a RenderSurface and its replica. The replica
quad is drawn independently of the surface itself. This allows us to
cull each one independently.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::setScissorRect):
(WebCore):
(WebCore::CCRenderSurface::drawContents):
(WebCore::CCRenderSurface::drawReplica):
(WebCore::CCRenderSurface::hasReplica):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp:

(WebCore::CCRenderSurfaceDrawQuad::create):
(WebCore::CCRenderSurfaceDrawQuad::CCRenderSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h:

(CCRenderSurfaceDrawQuad):
(WebCore::CCRenderSurfaceDrawQuad::isReplica):

10:22 AM Changeset in webkit [113452] by schenney@chromium.org
  • 5 edits
    4 deletes in trunk/LayoutTests

RenderSVGRoot should inherit from RenderReplaced
​https://bugs.webkit.org/show_bug.cgi?id=76446

Unreviewed Chromium expectations update.

Second attempt, after the rebaseline tool put expectations in chromium-linux-x86 instead of chormium-linux.

  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Removed.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
10:10 AM Changeset in webkit [113451] by Patrick Gansterer
  • 3 edits in trunk/Source/JavaScriptCore

Remove JSC dependency from GregorianDateTime
​https://bugs.webkit.org/show_bug.cgi?id=83290

Reviewed by Geoffrey Garen.

This allows us to move it to WTF later.

  • runtime/DateConstructor.cpp:

(JSC::callDate):

  • runtime/JSDateMath.h:
10:10 AM Changeset in webkit [113450] by Martin Robinson
  • 35 edits in trunk/Source/WebCore

[GObject bindings] Fix the coding style issues in the generated bindings
​https://bugs.webkit.org/show_bug.cgi?id=82080

Reviewed by Kentaro Hara.

No new tests. This is covered by the binding tests.

  • bindings/scripts/CodeGeneratorGObject.pm: Fix most style errors in the generated GObject code.
  • bindings/scripts/test/GObject: Updated the expected results.
10:03 AM Changeset in webkit [113449] by adamk@chromium.org
  • 5 edits in trunk

Remove bogus assert from ChildListMutationScope
​https://bugs.webkit.org/show_bug.cgi?id=83336

Reviewed by Ryosuke Niwa.

Source/WebCore:

This assert can trivially be triggered from script, but luckily the
code already behaves correctly without it.

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationScope::MutationAccumulator::enqueueMutationRecord):

LayoutTests:

Added a test that would trigger the assert.

  • fast/mutation/observe-childList-expected.txt:
  • fast/mutation/observe-childList.html:
9:39 AM Changeset in webkit [113448] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk/Source/WebCore

Unreviewed, rolling out r113442.
​http://trac.webkit.org/changeset/113442
​https://bugs.webkit.org/show_bug.cgi?id=83373

for breaking JSC bindings compilation (Requested by pfeldman
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-06

  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSMutationCallbackCustom.cpp: Added.

(WebCore):
(WebCore::JSMutationCallback::handleEvent):

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForTypeInImpl):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackHeader):
(GenerateCallbackImplementation):

  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::callbackWithBoolean):

  • bindings/scripts/test/JS/JSTestCallback.h:

(JSTestCallback):

  • bindings/scripts/test/TestCallback.idl:
  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithBoolean):

  • bindings/scripts/test/V8/V8TestCallback.h:

(V8TestCallback):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp: Added.

(WebCore):
(WebCore::V8MutationCallback::handleEvent):

  • dom/MutationCallback.idl:
9:26 AM Changeset in webkit [113447] by leviw@chromium.org
  • 4 edits in branches/subpixellayout/Source

Add transitional abs method to LayoutTypes and remove remaining unnecessary expandedIntSize calls.

9:13 AM Changeset in webkit [113446] by commit-queue@webkit.org
  • 5 edits in trunk

[Gtk] Unskip the video track tests
​https://bugs.webkit.org/show_bug.cgi?id=82590

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2012-04-06
Reviewed by Martin Robinson.

Source/WebCore:

Enable the video track runtime feature for the Gtk port as well.

No new tests - existing ones will be unskipped.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

LayoutTests:

Unskip passing video track tests and update expectations
where necessary.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
9:09 AM Changeset in webkit [113445] by msaboff@apple.com
  • 8 edits in trunk/Source

Call Heap::discardAllCompiledCode() in low memory situations
​https://bugs.webkit.org/show_bug.cgi?id=83335

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Restructured Heap::discardAllCompiledCode() to do the "Is JavaScriptRunning?"
check inline so that it can be called directly without this check.

  • heap/Heap.cpp:

(JSC::Heap::discardAllCompiledCode):
(JSC::Heap::collectAllGarbage):

  • heap/Heap.h: Added JS_EXPORT_PRIVATE to discardAllCompiledCode() so it can be

called from WebCore.
(Heap):

  • runtime/JSGlobalData.h: Removed unused " void discardAllCompiledCode()" declaration.

(JSGlobalData):

Source/WebCore:

Added call to discardAllCompiledCode() when under memory pressure.
We can re-JIT as needed. This is similar to what we used to do when we did
a full GC which also cleaned up JIT code. Doing a full GC typically didn't
help our memory situation, in fact it made things worse in the really low
memory situation as it caused more paging.

Added pass through discardAllCompiledCode() method to GCController.

  • bindings/js/GCController.cpp:

(WebCore::GCController::discardAllCompiledCode):
(WebCore):

  • bindings/js/GCController.h:

(GCController):

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::releaseMemory):

9:05 AM Changeset in webkit [113444] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp

Using pixel snapping instead of flooring for Floating object reporting.

9:04 AM Changeset in webkit [113443] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: on a single click in Timeline overview, make a minimal selection centered around cursor
​https://bugs.webkit.org/show_bug.cgi?id=82616

Reviewed by Pavel Feldman.

  • center minimal selection on mouse cursor if the mouse hasn't moved (i.e. we had a click, not drag)
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):

8:45 AM Changeset in webkit [113442] by haraken@chromium.org
  • 17 edits
    2 deletes in trunk/Source/WebCore

Add CodeGenerator support for sequence<> in callbacks.
​https://bugs.webkit.org/show_bug.cgi?id=83233

Patch by Vineet Chaudhary <Vineet> on 2012-04-06
Reviewed by Kentaro Hara.

Tests: TestCallback.idl and fast/mutation/callback-arguments.html should pass even after
the changes.

  • GNUmakefile.list.am: Removed unsued custom files V8MutationCallbackCustom.cpp and JSMutationCallbackCustom.cpp from builds.
  • Target.pri: Ditto.
  • UseJSC.cmake: Ditto.
  • UseV8.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSMutationCallbackCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForTypeInImpl): Add proper header type.
(GenerateCallbackHeader): Generate declaration for the callback with sequence<T> argument.
(GenerateCallbackImplementation): Generate implementation for the callback with sequence<T> argument.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackHeader): Generate declaration for the callback with sequence<T> argument.
(GenerateCallbackImplementation): Generate implementation for the callback with sequence<T> argument.

  • bindings/scripts/test/JS/JSTestCallback.cpp: Modified test results of run-bindings-tests.

(WebCore):
(WebCore::JSTestCallback::handleEvent):

  • bindings/scripts/test/JS/JSTestCallback.h: Modified test results of run-bindings-tests.

(JSTestCallback):

  • bindings/scripts/test/TestCallback.idl: Added test callback with sequence<> argument.
  • bindings/scripts/test/V8/V8TestCallback.cpp: Modified test results of run-bindings-tests.

(WebCore):
(WebCore::V8TestCallback::handleEvent):

  • bindings/scripts/test/V8/V8TestCallback.h: Modified test results of run-bindings-tests.

(V8TestCallback):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp: Removed.
  • dom/MutationCallback.idl: Removed custom bindings using sequence<T>.
8:33 AM Changeset in webkit [113441] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r113431.
​http://trac.webkit.org/changeset/113431
​https://bugs.webkit.org/show_bug.cgi?id=83372

for breaking at least Chromium compilation (Requested by
pfeldman on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-06

  • rendering/RenderView.cpp:

(WebCore::RenderView::paint):
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):

  • rendering/RenderView.h:

(RenderView):

8:30 AM Changeset in webkit [113440] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: completely switch all domains to 'strict' mode
​https://bugs.webkit.org/show_bug.cgi?id=83332

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-04-06
Reviewed by Pavel Feldman.

Hardcoded list of domains is removed from generator. Partial domain sorting is dropped as unneeded.
Types with open propery list are introduced: validator allows undocumented properties for them.

Timeline domain code is patched to do runtimeCast in the last moment because true switching to
type-safe interfaces should take significant time and should be done separately.

  • inspector/CodeGeneratorInspector.py:

(Generator.go):
(Generator.process_event):
(Generator.process_command):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):

8:29 AM Changeset in webkit [113439] by schenney@chromium.org
  • 11 edits
    8 adds in trunk/LayoutTests

RenderSVGRoot should inherit from RenderReplaced
​https://bugs.webkit.org/show_bug.cgi?id=76446

Unreviewed Chromium test expectations update.

  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.txt:
  • platform/chromium/test_expectations.txt:
8:23 AM Changeset in webkit [113438] by pfeldman@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: stop accepting raw InspectorObject in generated setters
​https://bugs.webkit.org/show_bug.cgi?id=83327

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-04-06
Reviewed by Pavel Feldman.

Generator fixed to have strict types in generated setter methods.

Client code is switched from InspectorObject's and String's to generated types where
needed.

  • inspector/CodeGeneratorInspector.py:

(AdHocTypeContext):
(format_setter_value_expression):

  • inspector/ConsoleMessage.cpp:

(WebCore::messageSourceValue):
(WebCore::messageTypeValue):
(WebCore::messageLevelValue):
(WebCore::ConsoleMessage::addToFrontend):

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):

  • inspector/InspectorApplicationCacheAgent.h:

(InspectorApplicationCacheAgent):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForTiming):
(WebCore::buildObjectForCachedResource):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

  • inspector/InspectorStyleSheet.h:

(InspectorCSSId):
(WebCore::InspectorCSSId::asProtocolValue): method is made template as now it returns 2 formally different types.
(InspectorStyleSheet):
(WebCore::InspectorStyleSheet::canBind):
(InspectorStyleSheetForInlineStyle):

8:17 AM Changeset in webkit [113437] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: highlight diff in the gutter, not in the line content.
​https://bugs.webkit.org/show_bug.cgi?id=83371

Reviewed by Yury Semikhatsky.

Now that the editing mode is enabled by default, diff highlighting gets annoying.
I am moving it to the gutter (same decoration as before, but now coloring gutter only).

  • inspector/front-end/TextViewer.js:

(WebInspector.TextEditorGutterPanel.prototype.textChanged):

  • inspector/front-end/textViewer.css:

(.diff-container .webkit-added-line.webkit-line-number):
(.diff-container .webkit-removed-line.webkit-line-number):
(.diff-container .webkit-changed-line.webkit-line-number):

8:08 AM Changeset in webkit [113436] by schenney@chromium.org
  • 10 edits
    12 adds in trunk/LayoutTests

Differentiate between SVG/CSS width/height attributes/properties
​https://bugs.webkit.org/show_bug.cgi?id=76447

Unreviewed Chromium expectations update.

  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
  • platform/chromium/test_expectations.txt:
8:04 AM Changeset in webkit [113435] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: remove url from the saved urls map before the save action.
​https://bugs.webkit.org/show_bug.cgi?id=83364

Reviewed by Yury Semikhatsky.

URL gets added back upon successful save anyways, but if user chooses cancel saving,
we stop bugging him with the save-as dialog.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportResource):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.doSave):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.doSave):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewer.prototype._commitEditing):

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype.saveToFile):

  • inspector/front-end/inspector.js:
7:43 AM Changeset in webkit [113434] by caseq@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: display frame details in popover on frame strip in Timeline panel
​https://bugs.webkit.org/show_bug.cgi?id=83365

Reviewed by Pavel Feldman.

  • added popovers for frame strips;
  • factored out generateAggregatedInfo for reuse in the above;
  • made frame event dividers thinner, darker and greyer.
  • English.lproj/localizedStrings.js: Added "FPS" and "Frame"
  • inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController.prototype._flushFrame): added startTimeOffset.
(WebInspector.TimelineFrameController.prototype._createSyntheticFrame): ditto.

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype._updateBoundaries):
(WebInspector.TimelineModel.prototype.recordOffsetInSeconds):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateFrames): added link to frame to strip div.
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._getPopoverAnchor): handle frame anchors separately.
(WebInspector.TimelinePanel.prototype._mouseMove): ditto.
(WebInspector.TimelinePanel.prototype._showPopover):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
(WebInspector.TimelinePresentationModel._generateAggregatedInfo): factored out for reuse.
(WebInspector.TimelinePresentationModel.generatePopupContentForFrame):

  • inspector/front-end/inspectorCommon.css:

(.resources-dividers-label-bar):

  • inspector/front-end/timelinePanel.css:

(.timeline .resources-event-divider.timeline-frame-divider): made divider thin and grey.
(.timeline-frame-strip): bumped z-index, added pointer-events: auto.

7:27 AM Changeset in webkit [113433] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: show "dirty" flag for CSS files edited in the resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=83363

Reviewed by Yury Semikhatsky.

Added TextEdited notification into the editable source frame, listening to it
in the resources panel.

  • inspector/front-end/ResourceView.js:

(WebInspector.EditableResourceSourceFrame.prototype._contentChanged):
(WebInspector.EditableResourceSourceFrame.prototype.isDirty):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendRevision):
(WebInspector.FrameResourceTreeElement.prototype.sourceView):
(WebInspector.FrameResourceTreeElement.prototype._sourceViewTextEdited):

7:24 AM Changeset in webkit [113432] by pfeldman@chromium.org
  • 3 edits in branches/chromium/1084

Merge 112841 - Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-print mode.
​https://bugs.webkit.org/show_bug.cgi?id=82768

Reviewed by Yury Semikhatsky.

Source/WebCore:

When UISourceCode is replaced with another in ScriptsPanel, newly added
UISourceCode could already have breakpoints. We should iterate over existing
breakpoints and add them to sidebar pane.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):

LayoutTests:

  • inspector/debugger/script-formatter-breakpoints-expected.txt:
  • inspector/debugger/script-formatter-breakpoints.html:

TBR=​podivilov@chromium.org
BUG=122184
Review URL: ​https://chromiumcodereview.appspot.com/10005037

7:10 AM Changeset in webkit [113431] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

Update LayoutUnit usage in RenderView
​https://bugs.webkit.org/show_bug.cgi?id=83147

Reviewed by Julien Chaffraix.

Updating the usage of LayoutUnits in RenderView in preparation for sub-pixel layout. This mostly
affects paint and repaint functions, which take LayoutRects up to the RenderView level. This is
necessary as we continue to accumulate sub-pixel offsets up to this level.

No new tests. No change in behavior.

  • rendering/RenderView.cpp:

(WebCore::RenderView::paint): Adding an assert that we're being called to paint on pixel
boundaries. We don't currently ever position RenderViews at sub-pixel offsets.
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle): Switching to a LayoutRect and cleaning up a fixme
that used decomposed offsets. Pixel snapping is applied before handing the rect up to the
FrameView.
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers): Pixel snapping before handing
the rect up to the Compositor.
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):

  • rendering/RenderView.h:

(RenderView):

6:50 AM Changeset in webkit [113430] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/platform/win

Cleaning up unneeded FractionalLayoutUnit leakage into Win PopupMenu code.

5:53 AM Changeset in webkit [113429] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Text selection - Can't select texts
​https://bugs.webkit.org/show_bug.cgi?id=83355

Fix the problem of not sending out the result of the function
SelectionHandler::regionForTextQuads(). This regression issue
is introduced by the git commit f9446b7d671d48a833ab0acf12b1e20637e0a910.

Patch by Sean Wang <​Xuewen.Wang@torchmobile.com.cn> on 2012-04-06
Reviewed by George Staikos.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):

Add code to return the function result.

5:49 AM Changeset in webkit [113428] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: hide popover on mouseout from anchor
​https://bugs.webkit.org/show_bug.cgi?id=83362

Reviewed by Pavel Feldman.

  • start hide popover timer when mouse moves out of popover anchor, as we won't receive mousemove events any more;
  • factored out starting of popover kill timer to a method.
  • inspector/front-end/Popover.js:

(WebInspector.PopoverHelper):
(WebInspector.PopoverHelper.prototype._mouseMove): Factored out StartHidePopoverTimer()
(WebInspector.PopoverHelper.prototype._mouseOut): Just call StartHidePopoverTimer() when mouse moves out of anchor.
(WebInspector.PopoverHelper.prototype._startHidePopoverTimer.doHide):
(WebInspector.PopoverHelper.prototype._startHidePopoverTimer):
(WebInspector.PopoverHelper.prototype._hidePopover): Reset hoverElement (aka anchor) when hiding popover.

5:08 AM Changeset in webkit [113427] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unskipped some tests that now pass.

Patch by János Badics <János Badics> on 2012-04-06
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
5:07 AM Changeset in webkit [113426] by caseq@chromium.org
  • 5 edits in trunk

[Chromium] Web Inspector: getEventListeners(window) crashes on NTP
​https://bugs.webkit.org/show_bug.cgi?id=83353

Reviewed by Pavel Feldman.

Source/WebCore:

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::getEventListenersCallback):

LayoutTests:

  • inspector/console/command-line-api-getEventListeners-expected.txt:
  • inspector/console/command-line-api-getEventListeners.html:
3:37 AM Changeset in webkit [113425] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Touch ChromeClient.h to fix Chromium build.
​https://bugs.webkit.org/show_bug.cgi?id=83258

  • page/ChromeClient.h:
3:26 AM Changeset in webkit [113424] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Skip new failing tests to paing the bot green.

  • platform/qt-mac/Skipped:
3:04 AM Changeset in webkit [113423] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/qt-arm/Skipped: Skip new failing tests.
3:01 AM Changeset in webkit [113422] by tkent@chromium.org
  • 6 edits
    3 adds in trunk

Initial LocalizedDateICU.cpp implementation
​https://bugs.webkit.org/show_bug.cgi?id=60868

Reviewed by Hajime Morita.

Source/WebCore:

Add LocalizedDateICU.cpp, which supports only Date type. It uses a
short format because a date field is keyboard-editable.
e.g. 5/15/11 in US locale.

  • WebCore.gyp/WebCore.gyp: Exclude LocalizedDateNone.cpp.
  • WebCore.gypi: Add LocalizedDateICU.cpp.
  • platform/text/LocalizedDateICU.cpp: Added.

(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):

LayoutTests:

  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium/fast/forms/date/date-input-visible-strings-expected.txt: Added.
2:02 AM Changeset in webkit [113421] by Csaba Osztrogonác
  • 6 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update platform specific expected results.

  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
  • platform/qt/svg/as-object/object-box-sizing-no-width-height-expected.txt:
  • platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
1:39 AM Changeset in webkit [113420] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/inspector/front-end/inspector.js

Merge 113336 - Web Inspector: CSS file revisions are not restored upon front-end reopen.
​https://bugs.webkit.org/show_bug.cgi?id=83292

Reviewed by Yury Semikhatsky.

Populating suggestions before the panel creation now.

  • inspector/front-end/inspector.js:

(WebInspector._doLoadedDoneWithCapabilities.get if):

TBR=​pfeldman@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10009039

1:29 AM Changeset in webkit [113419] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Unskip tests after r113323.
12:58 AM Changeset in webkit [113418] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

[REGRESSION] Refreshed autofill popup renders garbage
​https://bugs.webkit.org/show_bug.cgi?id=83255
​http://code.google.com/p/chromium/issues/detail?id=118374

The code used to update only the PopupContainer coordinates as if they were the coordinates relative
to the root view. Instead, a WebWidget positioned relative to the screen origin holds the PopupContainer,
so it is the WebWidget that should be positioned in PopupContainer::refresh(), and the PopupContainer's
location should be (0, 0) (and their sizes should always be equal).

Reviewed by Kent Tamura.

No new tests, as the popup appearance is not testable in WebKit.

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::layoutAndCalculateWidgetRect): Variable renamed.
(WebCore::PopupContainer::showPopup): Use m_originalFrameRect rather than frameRect()
for passing into chromeClient.
(WebCore::PopupContainer::showInRect): Set up the correct frameRect() for the container.
(WebCore::PopupContainer::refresh): Resize the container and position the WebWidget correctly.

  • platform/chromium/PopupContainer.h:

(PopupContainer):

12:54 AM Changeset in webkit [113417] by zherczeg@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r113378. ENABLE(MUTATION_OBSERVERS) is disabled so
fast/mutation/clear-transient-without-delivery.html and
fast/mutation/transient-gc-crash.html have been skipped.

Patch by János Badics <János Badics> on 2012-04-06
Reviewed by Zoltan Herczeg.

  • platform/qt/Skipped:
12:45 AM Changeset in webkit [113416] by tkent@chromium.org
  • 11 edits in trunk/Source

Calendar Picker: Add code to open/close the calendar picker
​https://bugs.webkit.org/show_bug.cgi?id=83258

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. This code is not used because of no ENABLE_INPUT_TYPE_DATE.

  • WebCore.gypi: Add existing header files.
  • html/DateInputType.cpp:

(WebCore::DateInputType::DateInputType):
Moved from DateInputType.h because the constructor depends on
CalendarPickerElement.
(WebCore::DateInputType::createShadowSubtree):
Store a CalendarPickerElement object.
(WebCore::DateInputType::destroyShadowSubtree):
Release the CalendarPickerElement object.
(WebCore::DateInputType::handleBlurEvent):
Close the calendar picker when the input loses focus.

  • html/DateInputType.h:

(DateInputType):

  • Move the constructor definition to DateInputType.cpp
  • Add function declarations
  • Add m_pickerElement data member.
  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::hostInput): A helper to get the host <input>.
(WebCore::CalendarPickerElement::defaultEventHandler):
If the element is clicked, open a calendar picker.
(WebCore::CalendarPickerElement::openPopup):
Opens a calendar picker by ChromeClient::openPagePopup().
(WebCore::CalendarPickerElement::closePopup):
Closes a calendar picker by ChromeClient::closePagePopup().
(WebCore::CalendarPickerElement::detach):
Closes a calendar picker when the element loses a renderer.

(WebCore::CalendarPickerElement::contentSize):
Provides the initial size of a popup.
(WebCore::addString): A helper for writeDocument().
(WebCore::addJavaScriptString): ditto.
(WebCore::addProperty): ditto.
(WebCore::CalendarPickerElement::writeDocument):
Provides the source of a popup. The function creates a complete HTML with:

  • WebCore/Resources/calendarPicker.css
  • WebCore/Resources/calendarPicker.js
  • An object to pass localization strings and <input> state

(WebCore::CalendarPickerElement::setValueAndClosePopup):
Sets the value from a calendar picker to the <input>.
(WebCore::CalendarPickerElement::didClosePopup):
Clear the popup object.

  • html/shadow/CalendarPickerElement.h:

(CalendarPickerElement): Add declarations.

  • platform/text/LocalizedCalendarICU.cpp:

(WebCore::getFirstDayOfWeek): Make sure this is 0-base. UCAL_SUNDAY is 1.

Source/WebKit/chromium:

  • features.gypi: Enable ENABLE_PAGE_POPUP for non-Android

platforms. This is needed because ENABLE_CALENDAR_PICKER now depends on
ENABLE_PAGE_POPUP.

  • src/ChroemClientImpl.cpp: Add stubs.

(WebKit::ChromeClientImpl::openPagePopup):
(WebKit::ChromeClientImpl::closePagePopup):

  • src/ChromeClientImpl.h: Add declarations of openPagePopup() and closePagePopup().
Note: See TracTimeline for information about the timeline view.