Timeline
Apr 9, 2012:
- 11:33 PM Changeset in webkit [113691] by
-
- 2 edits in trunk/Tools
Unreviewed: adding myself to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 11:24 PM Changeset in webkit [113690] by
-
- 2 edits in trunk/Source/WebCore
combine two arrays in XPathException into one
https://bugs.webkit.org/show_bug.cgi?id=83442
Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.
No new tests required.
- xml/XPathException.cpp:
(XPathExceptionNameDescription):
(WebCore):
(WebCore::XPathException::initializeDescription):
- 11:18 PM Changeset in webkit [113689] by
-
- 2 edits in trunk/Source/WebCore
combine exceptionNames and exceptionDescriptions in IDBDatabaseException.cpp into one array
https://bugs.webkit.org/show_bug.cgi?id=83433
Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.
No new tests required.
- Modules/indexeddb/IDBDatabaseException.cpp:
(IDBDatabaseExceptionNameDescription):
(WebCore):
(WebCore::IDBDatabaseException::initializeDescription):
- 11:07 PM Changeset in webkit [113688] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Remove unused variable, WebViewImpl::m_lastMousePosition.
https://bugs.webkit.org/show_bug.cgi?id=83550
Reviewed by Kentaro Hara.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::mouseMove):
- src/WebViewImpl.h:
- 10:54 PM Changeset in webkit [113687] by
-
- 2 edits in trunk/Source/WebCore
combine two arrays in SQLException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83452
Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.
No new tests required.
- Modules/webdatabase/SQLException.cpp:
(SQLExceptionNameDescription):
(WebCore):
(WebCore::SQLException::initializeDescription):
- 10:51 PM Changeset in webkit [113686] by
-
- 2 edits in trunk/Source/WebCore
combine two arrays in EventException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83451
Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.
No new tests required.
- dom/EventException.cpp:
(EventExceptionNameDescription):
(WebCore):
(WebCore::EventException::initializeDescription):
- 10:50 PM Changeset in webkit [113685] by
-
- 2 edits in trunk/Source/WebCore
combine two arrays in RangeException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83450
Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.
No new tests required.
- dom/RangeException.cpp:
(RangeExceptionNameDescription):
(WebCore):
(WebCore::RangeException::initializeDescription):
- 10:47 PM Changeset in webkit [113684] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Improve TextureMapperGL readability
https://bugs.webkit.org/show_bug.cgi?id=83477
Change the debugging macros for TextureMapperGL, so that the GL_CMD call can include a semicolon.
Modify some if blocks to have an early return.
Reviewed by Martin Robinson.
No new functionality.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::scissorClip):
(WebCore::TextureMapperGLData::SharedGLData::applyCurrentClip):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
(WebCore::TextureMapperGLData::initializeStencil):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::bind):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::beginClip):
- 10:45 PM Changeset in webkit [113683] by
-
- 2 edits in trunk/Source/WebCore
combine two arrays in FileException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83449
Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.
No new tests required.
- fileapi/FileException.cpp:
(FileExceptionNameDescription):
(WebCore):
(WebCore::FileException::initializeDescription):
- 10:43 PM Changeset in webkit [113682] by
-
- 2 edits in trunk/Source/WebCore
combine two arrays in OperationNotAllowedException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83445
Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.
No new tests required.
- fileapi/OperationNotAllowedException.cpp:
(OperationNotAllowedExceptionNameDescription):
(WebCore):
(WebCore::OperationNotAllowedException::initializeDescription):
- 10:39 PM Changeset in webkit [113681] by
-
- 11 edits5 adds in trunk
Assert triggers VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries.
https://bugs.webkit.org/show_bug.cgi?id=83118
Reviewed by Hajime Morita.
Source/WebCore:
VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries did not work correctly.
There was a case that selection crosses shadow boundaries.
This patch introduces a class TreeScopeAdjuster, which enables us to adjust Node or Position
into a specified tree scope.
Test: fast/dom/shadow/selections-in-shadow.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.ext.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/TreeScope.h:
(TreeScope):
- dom/TreeScopeAdjuster.cpp: Added.
(WebCore):
(WebCore::TreeScopeAdjuster::TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::ancestorInThisScope):
Returns the node itself if it's in the same tree scope.
Otherwise, this method checks the shadow ancestor of the node recursively.
If no corresponding node is found, 0 will be returned.
(WebCore::TreeScopeAdjuster::adjustPositionBefore):
(WebCore::TreeScopeAdjuster::adjustPositionAfter):
- dom/TreeScopeAdjuster.h: Added.
(WebCore):
(TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::treeScope):
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
LayoutTests:
This tests checks all the combination of element not in a shadow tree, element in a shadow tree,
element in a nested shadow tree, element in a non-youngest shadow tree, element in a nested shadow tree
in non-youngest shadow treee.
- fast/dom/resources/event-sender-util.js: Added.
(mouseMoveToElem):
- fast/dom/shadow/selections-in-shadow-expected.txt: Added.
- fast/dom/shadow/selections-in-shadow.html: Added.
- 10:36 PM Changeset in webkit [113680] by
-
- 2 edits in trunk/Source/WebCore
combine two arrays in SVGException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83444
Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.
No new tests required.
- svg/SVGException.cpp:
(SVGExceptionNameDescription):
(WebCore):
(WebCore::SVGException::initializeDescription):
- 10:30 PM Changeset in webkit [113679] by
-
- 2 edits in trunk/Source/WebCore
combine two arrays in XMLHttpRequestException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83443
Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.
No new tests requied.
- xml/XMLHttpRequestException.cpp:
(XMLHttpRequestExceptionNameDescription):
(WebCore):
(WebCore::XMLHttpRequestException::initializeDescription):
- 9:57 PM Changeset in webkit [113678] by
-
- 24 edits2 adds in trunk/Source
[WK2] Enable using a single ShareableBitmap for multiple updates
https://bugs.webkit.org/show_bug.cgi?id=83424
Source/WebCore:
Modify BitmapTexture::updateContents to include a source offset.
This allows us to update a texture from a sub-image.
Reviewed by Kenneth Rohde Christiansen.
Tested by existing API tests.
- platform/graphics/texmap/TextureMapper.h:
(BitmapTexture):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::didReset):
(WebCore::driverSupportsBGRASwizzling):
(WebCore::BitmapTextureGL::updateContents):
- platform/graphics/texmap/TextureMapperGL.h:
(WebCore::BitmapTextureGL::textureTarget):
(BitmapTextureGL):
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::updateContents):
- platform/graphics/texmap/TextureMapperImageBuffer.h:
(BitmapTextureImageBuffer):
Source/WebKit2:
Reviewed by Kenneth Rohde Christiansen.
Enabled creating a GraphicsContext that references a rect inside ShareableBitmap.
Added bitmapOffset to UpdateInfo, to allow updates to reference an offset inside the bitmap.
Added UpdateAtlas, a class that manages available rects in a larger ShareableBitmap.
In this iteration, UpdateAtlas has a simple behavior where a rect inside the bitmap is
either available or used. When the buffers are swapped, all used buffers become available
again. A future enhancement might allow triple-buffering, where available rects can be
updated while other rects from the same atlas are in use.
Added the necessary plumbing to allow Qt's UI-side compositing to take advantage of
UpdateAtlas. LayerTreeHostQt creates an atlas per type of bitmap (i.e. one opaque and one
alpha-enabled atlas). When a tile wants to update and there's no available scratch-buffer,
the update would be postponed to the next frame, creating a tiling-artifact in low memory
situations.
- Shared/UpdateInfo.cpp:
(WebKit::UpdateInfo::encode):
(WebKit::UpdateInfo::decode):
- Shared/UpdateInfo.h:
(UpdateInfo):
- Target.pri:
- UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::updateTileForLayer):
- UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::updateTile):
(WebKit::WebLayerTreeRenderer::createImage):
- UIProcess/WebLayerTreeRenderer.h:
(TileUpdate):
(WebKit::WebLayerTreeRenderer::TileUpdate::TileUpdate):
(WebLayerTreeRenderer):
- UIProcess/qt/LayerBackingStore.cpp:
(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit::LayerBackingStore::createTile):
- UIProcess/qt/LayerBackingStore.h:
(LayerBackingStoreTile):
(LayerBackingStore):
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::beginContentUpdate):
(WebCore):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayerClient):
(WebGraphicsLayer):
- WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
- WebProcess/WebPage/TiledBackingStoreRemoteTile.h:
(TiledBackingStoreRemoteTileClient):
- WebProcess/WebPage/UpdateAtlas.cpp: Added.
(WebKit):
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::nextPowerOfTwo):
(WebKit::UpdateAtlas::buildLayoutIfNeeded):
(WebKit::UpdateAtlas::findAvailableIndex):
(WebKit::UpdateAtlas::didSwapBuffers):
(WebKit::UpdateAtlas::acquireScratchBuffer):
(WebKit::UpdateAtlas::offsetForIndex):
- WebProcess/WebPage/UpdateAtlas.h: Added.
(WebCore):
(WebKit):
(UpdateAtlas):
(WebKit::UpdateAtlas::bitmap):
(WebKit::UpdateAtlas::size):
(WebKit::UpdateAtlas::flags):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::adoptImageBackingStore):
(WebKit::LayerTreeHostQt::renderNextFrame):
(WebKit::LayerTreeHostQt::purgeBackingStores):
(WebKit):
(WebKit::LayerTreeHostQt::getAtlas):
(WebKit::LayerTreeHostQt::beginContentUpdate):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
- 9:54 PM Changeset in webkit [113677] by
-
- 28 edits in trunk/Source
[chromium] Viewport is not filled when out of texture memory on mac
https://bugs.webkit.org/show_bug.cgi?id=83351
Reviewed by Adrienne Walker.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebCore:
Currently we add gutter quads on the NonCompositedContentHost layer,
which lies above another visible layer - the rubberband layer on mac.
For this reason, on mac, gutter quads were disabled, as well as forcing
the NCCH layer to draw, in order to make the rubberband layer appear.
We move the logic for adding gutter quads into CCRenderPass, and add
gutter quads for all pixels that are visible through the viewport.
This allows us to stop special-casing the NCCH layer, and allows us
to skip drawing the layer equally with other layers. We remove the
backgroundCoversViewport() flag entirely.
In order to do this, we fix a bug in the occlusion tracker, that
allowed opaque() layers with skipsDraw to occlude, by making
the visibleContentOpaqueRegion() method on the layer classes
also return the opaque region for non-tiled layers, always use
its value in the occlusion tracker.
Unit test: CCLayerTreeHostImplTest.viewportCovered
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::visibleContentOpaqueRegion):
(WebCore):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::visibleContentOpaqueRegion):
(WebCore):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::appendQuads):
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setBackgroundColor):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::backgroundColor):
(WebCore::CCLayerTreeHostImpl::setBackgroundColor):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::computeVisibleRegionInScreen):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsToFillScreen):
(WebCore):
- platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
(CCRenderPass):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore::CCTiledLayerImpl::skipsDraw):
(CCTiledLayerImpl):
Source/WebKit/chromium:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setBackgroundColor):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setBackgroundColor):
(WebKit):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setBackgroundColor):
(WebKit):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
(WebCore):
(WebViewImpl):
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::BlendStateCheckLayer::appendQuads):
(WebKitTests::TEST_F):
(WebKitTests):
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::beginTest):
(WTF::CCLayerTreeHostTestCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommit::afterTest):
(WTF::TEST_F):
(TestLayerChromium):
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::TestContentLayerChromium::TestContentLayerChromium):
(WebKitTests::TestContentLayerChromium::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(WebKitTests::TestContentLayerImpl::TestContentLayerImpl):
(TestContentLayerImpl):
(WebKitTests::TestContentLayerImpl::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerImpl::setOpaqueContentsRect):
- tests/CCTiledLayerImplTest.cpp:
- tests/LayerChromiumTest.cpp:
- 9:47 PM Changeset in webkit [113676] by
-
- 2 edits in trunk/Source/WebCore
Don't let CSSPropertyWebkitPerspective dereference primitiveValue without null check.
https://bugs.webkit.org/show_bug.cgi?id=83538
Reviewed by Daniel Bates.
No new tests / code cleanup only.
Coverity pointed out that we potentially dereference primitiveValue here without checking for null.
I've added an early out for that case to make sure it can't ever happen. I don't know if it's actually
possible to exercise that code path or not - probably the parser prevents it from being hit in practice.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 9:42 PM Changeset in webkit [113675] by
-
- 2 edits in trunk/Source/WebCore
<http://webkit.org/b/83539> Web Inspector: ASSERT attempting to unbind null contentDocument
Avoid calling unbind with a null object. The HTMLFrameOwnerElement's
contentDocument can be null.
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-04-09
Reviewed by Timothy Hatcher.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::unbind):
- 9:27 PM Changeset in webkit [113674] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Parsed Cookie's m_isMaxAgeSet is not needed.
https://bugs.webkit.org/show_bug.cgi?id=83457
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-09
Reviewed by Rob Buis.
When m_expiry is not -1, it must be set by setExpiry or setMaxAge. setExpiry will return when m_expiry
has been set. This ensures Max-Age's precedence.
And m_isMaxAgeSet is always false when the cookie is from database. This is not right.
So we use m_expiry instead of m_isMaxAgeSet.
No new tests. Refactor.
- platform/blackberry/ParsedCookie.cpp:
(WebCore::ParsedCookie::ParsedCookie):
(WebCore::ParsedCookie::setExpiry):
(WebCore::ParsedCookie::setMaxAge):
- platform/blackberry/ParsedCookie.h:
(ParsedCookie):
- 9:05 PM Changeset in webkit [113673] by
-
- 2 edits in trunk/Source/WebCore
Fixed ordering of deleting CCInputHandler and CCLayerTreeHostImpl in layerTreeHostClosedOnImplThread
https://bugs.webkit.org/show_bug.cgi?id=83488
Patch by Min Qin <qinmin@google.com> on 2012-04-09
Reviewed by James Robinson.
CCInputHandler(WebCompositorInputHandlerImpl) has a pointer to CCLayerTreeHostImpl.
So we should delete CCInputHandler earlier as otherwise that pointer could get misused after LayerTreeHostImpl is deleted.
Just fixing a potential NPE error, no behavior change.
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):
- 8:59 PM Changeset in webkit [113672] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Update about:config page
https://bugs.webkit.org/show_bug.cgi?id=83515
Reviewed by Rob Buis.
- WebCoreSupport/AboutData.cpp:
(WebCore::configPage):
- WebCoreSupport/AboutDataEnableFeatures.in:
- WebCoreSupport/AboutDataHaveFeatures.in:
- WebCoreSupport/AboutDataUseFeatures.in:
- 8:46 PM Changeset in webkit [113671] by
-
- 12 edits2 deletes in trunk
Unreviewed, rolling out r113656.
http://trac.webkit.org/changeset/113656
https://bugs.webkit.org/show_bug.cgi?id=83542
test is broken on chromium-win (Requested by simonjam on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-09
Source/WebCore:
- Modules/intents/Intent.cpp:
(WebCore::Intent::Intent):
- Modules/intents/Intent.h:
(Intent):
- Modules/intents/Intent.idl:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
Source/WebKit/chromium:
- public/WebIntent.h:
(WebIntent):
- src/WebIntent.cpp:
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::dispatchIntent):
LayoutTests:
- webintents/web-intents-invoke-port-expected.txt: Removed.
- webintents/web-intents-invoke-port.html: Removed.
- 8:41 PM Changeset in webkit [113670] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: !attached() in Node::attach.
https://bugs.webkit.org/show_bug.cgi?id=80726
Reviewed by Adam Barth.
Source/WebCore:
While parsing XML document, prevent attaching the leaf text node
back to document, if its parent is not attached.
Test: fast/dom/text-node-attach-crash.xhtml
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::exitText):
LayoutTests:
- fast/dom/text-node-attach-crash-expected.txt: Added.
- fast/dom/text-node-attach-crash.xhtml: Added.
- 8:39 PM Changeset in webkit [113669] by
-
- 2 edits1 add in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Added.
- platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
- 8:11 PM Changeset in webkit [113668] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Replica layers are not drawn, so should not be painted
https://bugs.webkit.org/show_bug.cgi?id=83504
Reviewed by James Robinson.
We attempt to paint replica layers when we are painting the mask layers
in CCLayerTreeHost.cpp.
This is useless code, replica layers have drawsContent() == false, and
have an empty visibleLayerRect, so the paint functions end up early-
outting. But it is a waste of time to try, and confusing to have
this attempted in the code at all, since the replica layers are never
drawn. They exist only for their transforms.
Also the dimensions used for the replica mask are different from the
surface mask, which is confusing and unnecessary as well. The mask is
applied to the same surface contents as the surface mask would be, so
only the surface's contentBounds need to be painted in the replica
mask.
Covered by existing tests.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- 8:05 PM Changeset in webkit [113667] by
-
- 5 edits1 add in trunk
ShadowRoot should have selection attribute.
https://bugs.webkit.org/show_bug.cgi?id=82429
Reviewed by Hajime Morita.
Source/WebCore:
This patch makes ShadowRoot have selection attribute. Currently the selection returns
the same object as what window.getSelection() returns.
We will extend DOMSelection to have TreeScope. It will adjust Node into TreeScope.
This will be tracked in Bug 82698.
Test: fast/dom/shadow/selection-in-shadow.html
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::selection):
(WebCore):
- dom/ShadowRoot.h:
(WebCore):
(ShadowRoot):
- dom/ShadowRoot.idl:
LayoutTests:
Checks ShadowRoot.selection returns the same selection as what window.getSelection() returns.
- fast/dom/shadow/selection-in-shadow.html: Added.
- 8:02 PM Changeset in webkit [113666] by
-
- 55 edits in trunk/LayoutTests
[EFL] Gardening in fast/text/whitespace.
The last commit to these baselines had some weird fonts for some
reason, fix the expected sizes.
- platform/efl/fast/text/whitespace/002-expected.png:
- platform/efl/fast/text/whitespace/002-expected.txt:
- platform/efl/fast/text/whitespace/003-expected.png:
- platform/efl/fast/text/whitespace/003-expected.txt:
- platform/efl/fast/text/whitespace/004-expected.png:
- platform/efl/fast/text/whitespace/004-expected.txt:
- platform/efl/fast/text/whitespace/005-expected.png:
- platform/efl/fast/text/whitespace/005-expected.txt:
- platform/efl/fast/text/whitespace/006-expected.png:
- platform/efl/fast/text/whitespace/006-expected.txt:
- platform/efl/fast/text/whitespace/007-expected.png:
- platform/efl/fast/text/whitespace/007-expected.txt:
- platform/efl/fast/text/whitespace/008-expected.png:
- platform/efl/fast/text/whitespace/008-expected.txt:
- platform/efl/fast/text/whitespace/009-expected.png:
- platform/efl/fast/text/whitespace/009-expected.txt:
- platform/efl/fast/text/whitespace/010-expected.png:
- platform/efl/fast/text/whitespace/010-expected.txt:
- platform/efl/fast/text/whitespace/011-expected.png:
- platform/efl/fast/text/whitespace/011-expected.txt:
- platform/efl/fast/text/whitespace/012-expected.png:
- platform/efl/fast/text/whitespace/012-expected.txt:
- platform/efl/fast/text/whitespace/013-expected.png:
- platform/efl/fast/text/whitespace/013-expected.txt:
- platform/efl/fast/text/whitespace/014-expected.png:
- platform/efl/fast/text/whitespace/014-expected.txt:
- platform/efl/fast/text/whitespace/015-expected.png:
- platform/efl/fast/text/whitespace/015-expected.txt:
- platform/efl/fast/text/whitespace/016-expected.png:
- platform/efl/fast/text/whitespace/016-expected.txt:
- platform/efl/fast/text/whitespace/018-expected.png:
- platform/efl/fast/text/whitespace/018-expected.txt:
- platform/efl/fast/text/whitespace/020-expected.png:
- platform/efl/fast/text/whitespace/020-expected.txt:
- platform/efl/fast/text/whitespace/021-expected.png:
- platform/efl/fast/text/whitespace/021-expected.txt:
- platform/efl/fast/text/whitespace/025-expected.png:
- platform/efl/fast/text/whitespace/025-expected.txt:
- platform/efl/fast/text/whitespace/027-expected.png:
- platform/efl/fast/text/whitespace/027-expected.txt:
- platform/efl/fast/text/whitespace/030-expected.png:
- platform/efl/fast/text/whitespace/030-expected.txt:
- platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
- platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
- platform/efl/fast/text/whitespace/pre-break-word-expected.png:
- platform/efl/fast/text/whitespace/pre-break-word-expected.txt:
- platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.png:
- platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.txt:
- platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.png:
- platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.txt:
- platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
- platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
- platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
- platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
- 7:54 PM Changeset in webkit [113665] by
-
- 26 edits in trunk/Source/WebCore
Replace numeric_limits<LayoutUnit>::min/max with constants
https://bugs.webkit.org/show_bug.cgi?id=83497
Reviewed by Eric Seidel.
Replace all uses of numeric_limits<LayoutUnit>::min/max with
MIN_LAYOUT_UNIT and MAX_LAYOUT_UNIT respectively in preparation for the
switch to subpixel layout.
Also rename zeroLayoutUnit to ZERO_LAYOUT_UNIT to be consistent and
change it to be a define as to avoid global initializer warnings once we
change the definition of LayoutUnit from int to FractionalLayoutUnit.
No new tests, no change in functionality.
- dom/ElementRareData.h:
(WebCore::defaultMinimumSizeForResizing):
- editing/FrameSelection.cpp:
(WebCore::NoXPosForVerticalArrowNavigation):
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::clampedBoundsOfProjectedQuad):
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
- rendering/LayoutTypes.h:
(WebCore):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::computeInitialRegionRangeForBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::markLinesDirtyInBlockRange):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::borderFitAdjust):
(WebCore::RenderBlock::adjustForUnsplittableChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageLogicalOffset):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::positionForPoint):
- rendering/RenderBox.h:
(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(RenderBox):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
(WebCore::RenderFieldset::paintMask):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::lineBreakLength):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::updateMargins):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computePreferredLogicalWidths):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):
- rendering/RenderTable.h:
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):
- rendering/RenderText.cpp:
(WebCore::RenderText::linesVisualOverflowBoundingBox):
- 7:50 PM Changeset in webkit [113664] by
-
- 6 edits in trunk/LayoutTests
[EFL] Gardening in transforms/2d.
Mostly account for the changes caused by the jhbuild and font
commits.
- platform/efl/transforms/2d/compound-transforms-vs-containers-expected.png:
- platform/efl/transforms/2d/hindi-rotated-expected.png:
- platform/efl/transforms/2d/transform-borderbox-expected.png:
- platform/efl/transforms/2d/transform-fixed-container-expected.png:
- platform/efl/transforms/2d/transform-origin-borderbox-expected.png:
- 7:32 PM Changeset in webkit [113663] by
-
- 2 edits in trunk/Source/WebCore
Clean up LayoutUnit usage in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=83507
Reviewed by Eric Seidel.
Ensuring DOMNodeHighlighter uses pixel snapping that matches that done in the RenderTree. Changes include:
- Reverting drawSubstring to use an IntPoint with pixel snapped values instead of a LayoutPoint.
- Reverting borderBox to an IntRect since it's in absolute coordinates. See https://trac.webkit.org/wiki/LayoutUnit.
- Frames are still laid out with integers. Cleaning up mainFrameOffset to reflect that.
No new tests. No change in behavior.
- inspector/DOMNodeHighlighter.cpp:
- 7:26 PM Changeset in webkit [113662] by
-
- 3 edits in trunk/Source/WebCore
Add missing IndexedDB files to CMake build
https://bugs.webkit.org/show_bug.cgi?id=83495
Patch by Jeff Rogers <jrogers@rim.com> on 2012-04-09
Reviewed by Rob Buis.
- CMakeLists.txt:
- UseJSC.cmake:
- 7:13 PM Changeset in webkit [113661] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=83411
All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests
This is a speculative fix.
- platform/mac/Skipped:
- 7:12 PM Changeset in webkit [113660] by
-
- 4 edits in trunk/Source/JavaScriptCore
If a callback constructor returns a C++ null, throw a type error.
https://bugs.webkit.org/show_bug.cgi?id=83537
Rubber Stamped by Geoff Garen.
- API/JSCallbackConstructor.cpp:
(JSC::constructJSCallback):
- If a callback constructor returns a C++ null, throw a type error.
- API/tests/testapi.c:
(Base_returnHardNull):
- API/tests/testapi.js:
- Add a test case for callback constructors that return a C++ null.
- 7:06 PM Changeset in webkit [113659] by
-
- 2 edits in trunk/Source/WebCore
[Mac] WebProcess dies due to m_process->checkURLReceivedFromWebProcess(url) dropping a file URL
https://bugs.webkit.org/show_bug.cgi?id=83506
<rdar://problem/11171264>
Reviewed by Darin Adler.
Cannot test, because dragging within a single window never initiates a navigation, and dragging
across windows is too much for DRT and WTR.
- platform/mac/DragDataMac.mm: (WebCore::DragData::asURL): Add the same checks that we had
for NSURLPboardType to NSStringPboardType case, preventing dropping of non-HTTP URLs.
String types cannot be sanitized when they are modified by JavaScript, and are thus less trusted.
String checks should be at least as restrictive as URL ones.
- 7:05 PM Changeset in webkit [113658] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] More unreviewed OwnPtr<>::operator= related clang build fixes in unit tests.
- tests/Canvas2DLayerChromiumTest.cpp:
- tests/LayerChromiumTest.cpp:
- 6:53 PM Changeset in webkit [113657] by
-
- 4 edits in trunk/Source/WTF
Port BinarySemaphoreWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=83502
Reviewed by Daniel Bates.
Replace WaitForSingleObjectEx with WaitForSingleObject since
the additonal parameter supported by the extended function
is not used anyway and the function does not exist on WinCE.
- wtf/CMakeLists.txt:
- wtf/PlatformWinCE.cmake:
- wtf/threads/win/BinarySemaphoreWin.cpp:
(WTF::BinarySemaphore::wait):
- 6:46 PM Changeset in webkit [113656] by
-
- 9 edits2 adds in trunk
Add transfer map argument to Intent constructor
http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
This adds the ability to pass transferables (i.e. MessagePorts)
through web intents, and puts the calling convention in line
with the Web Messaging spec:
http://dev.w3.org/html5/postmsg/
Implementation in chromium API follows the port-passing method
of PlatformMessagePortChannel.
https://bugs.webkit.org/show_bug.cgi?id=80200
Patch by Greg Billock <gbillock@google.com> on 2012-04-09
Reviewed by Adam Barth.
- Modules/intents/Intent.cpp:
(WebCore::Intent::create):
- Modules/intents/Intent.idl:
- WebCore.gypi:
- bindings/v8/custom/V8IntentCustom.cpp: Added.
(WebCore):
(WebCore::V8Intent::constructorCallback):
- 6:44 PM Changeset in webkit [113655] by
-
- 2 edits in trunk/Tools
Update pywebsocket to 0.7.4.
https://bugs.webkit.org/show_bug.cgi?id=83461
Reviewed by Kent Tamura.
This version supports TLS by using ssl in addition to pyOpenSSL.
Other functional difrerences from 0.7.2 are:
- strict Sec-WebSocket-Key validation conforming RFC 4648
- compression ratio logging in debug
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook._install_pywebsocket):
- 6:41 PM Changeset in webkit [113654] by
-
- 4 edits in trunk/Source/JavaScriptCore
If a callback function returns a C++ null, convert to undefined.
https://bugs.webkit.org/show_bug.cgi?id=83534
Reviewed by Geoff Garen.
- API/JSCallbackFunction.cpp:
- If a callback function returns a C++ null, convert to undefined.
(JSC::JSCallbackFunction::call):
- API/tests/testapi.c:
(Base_returnHardNull):
- API/tests/testapi.js:
- Add a test case for callback functions that return a C++ null.
- 6:30 PM Changeset in webkit [113653] by
-
- 10 edits1 copy2 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium-linux/media/media-document-audio-repaint-expected.png:
- platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Added.
- platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png:
- platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png:
- platform/chromium-mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png:
- platform/chromium-mac/fast/forms/basic-textareas-expected.png:
- platform/chromium-mac/fast/overflow/hidden-scrollbar-resize-expected.txt: Added.
- platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png:
- platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Copied from LayoutTests/platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt.
- platform/chromium-win/fast/overflow/hidden-scrollbar-resize-expected.txt:
- platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png:
- platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt:
- 6:23 PM Changeset in webkit [113652] by
-
- 10 edits in trunk/Source
[chromium] Cull occluded surface quads
https://bugs.webkit.org/show_bug.cgi?id=81227
Reviewed by Adrienne Walker.
Source/WebCore:
Cull render surface and replica quads during draw based on occlusion.
In order to compute occlusion for the surface or replica, it must not
consider occlusion found in the surface's own subtree. To do this, we
reorder the calls to the occlusion tracker, and add the surface and
replica quads before we "leaveToTargetRenderSurface" which merges
occlusion from the surface's subtree up into its parent.
Unit test: CCOcclusionTrackerTestReplicaOccluded
CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded
CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently
CCOcclusionTrackerTestSurfaceChildOfSurface
CCOcclusionTrackerTestSurfaceChildOfClippingSurface
And added some sanity checks to other CCOcclusionTracker tests that have
render surfaces.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::leaveToTargetRenderSurface):
(WebCore::::unoccludedContributingSurfaceContentRect):
(WebCore):
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::appendQuadInternal):
(WebCore::CCQuadCuller::append):
(WebCore):
(WebCore::CCQuadCuller::appendSurface):
(WebCore::CCQuadCuller::appendReplica):
- platform/graphics/chromium/cc/CCQuadCuller.h:
(CCQuadCuller):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTest::TearDown):
(WebKitTests::CCOcclusionTrackerTest::createReplicaLayer):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::setReplica):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestReplicaOccluded):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(CCOcclusionTrackerTestSurfaceChildOfSurface):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
- 6:19 PM Changeset in webkit [113651] by
-
- 3 edits in trunk
Update perf-o-matic config.js per upstream change.
- Websites/webkit-perf.appspot.com/js/config.js:
(var):
- 6:10 PM Changeset in webkit [113650] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Unreviewed build fix. OwnPtr<>::operator = breaks the build on clang, but not gcc :(
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::create):
- tests/Canvas2DLayerChromiumTest.cpp:
- tests/LayerChromiumTest.cpp:
- 6:02 PM Changeset in webkit [113649] by
-
- 4 edits in trunk/WebKitLibraries
<rdar://problem/11214796>
New WKSI will hopefully fix a common crash seen by the bots in libRIP.A.dylib:
symmetric_convolve
Reviewed by Simon Fraser.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 6:00 PM Changeset in webkit [113648] by
-
- 2 edits in trunk/Source/JavaScriptCore
Classic interpreter's GC hooks shouldn't attempt to scan instructions for code blocks that
are currently being generated
https://bugs.webkit.org/show_bug.cgi?id=83531
<rdar://problem/11215200>
Reviewed by Gavin Barraclough.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
- 5:44 PM Changeset in webkit [113647] by
-
- 16 edits in trunk/Source/WebCore
Make CSSValuePool share values globally.
<http://webkit.org/b/77700>
Reviewed by Antti Koivisto.
Remove the per-Document CSSValuePool and have everyone use a global pool
accessed via "CSSValuePool& cssValuePool()".
This reduces memory usage by sharing cached CSSValues between all documents,
and relaxes heap churn since the common, persistenly cached values are held
by CSSValuePool forever.
No behavior change thanks to r113588 which introduced a mechanism that makes
sure we never expose internal CSSValue objects to bindings, but read-only
clones of those values.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
(WebCore::zoomAdjustedNumberValue):
(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::valueForReflection):
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::valueForCustomFilterNumberParameter):
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
(WebCore::valueForGridTrackBreadth):
(WebCore::valueForGridTrackList):
(WebCore::valueForGridPosition):
(WebCore::getDelayValue):
(WebCore::getDurationValue):
(WebCore::createLineBoxContainValue):
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::valueForFamily):
(WebCore::renderUnicodeBidiFlagsToCSSValue):
(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::fillSizeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::counterToCSSValue):
(WebCore::fontFamilyFromStyle):
(WebCore::lineHeightFromStyle):
(WebCore::fontSizeFromStyle):
(WebCore::fontStyleFromStyle):
(WebCore::fontVariantFromStyle):
(WebCore::fontWeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSComputedStyleDeclaration.h:
(WebCore):
- css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::createPrimitiveStringValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::parseBackgroundClip):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationDirection):
(WebCore::CSSParser::parseAnimationFillMode):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationPlayState):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseClipShape):
(WebCore::CSSParser::parseExclusionShape):
(WebCore::CSSParser::parseFont):
(WebCore::FontFamilyValueBuilder::FontFamilyValueBuilder):
(WebCore::FontFamilyValueBuilder::commit):
(FontFamilyValueBuilder):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseFontWeight):
(WebCore::ShadowParseContext::commitStyle):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseFlex):
(WebCore::BorderImageParseContext::commitBorderImageProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseAspectRatio):
(WebCore::CSSParser::parseCounter):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseBuiltinFilterArguments):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::parseTextEmphasisStyle):
(WebCore::CSSParser::parseFontFeatureSettings):
(WebCore::CSSParser::parseFontVariantLigatures):
- css/CSSParser.h:
(WebCore):
(CSSParser):
- css/CSSValuePool.cpp:
(WebCore::cssValuePool):
(WebCore):
- css/CSSValuePool.h:
(CSSValuePool):
(WebCore):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::setProperty):
- css/StylePropertySet.h:
(StylePropertySet):
- dom/Document.cpp:
- dom/Document.h:
(WebCore):
(Document):
- dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addPropertyToAttributeStyle):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::addHTMLColorToStyle):
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForAttribute):
- html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectStyleForAttribute):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::createSharedCellStyle):
- 5:20 PM Changeset in webkit [113646] by
-
- 34 edits4 copies1 delete in trunk/LayoutTests
[Chromium] Unreviewed, roll out rebaselines for feature that was rolled out.
- platform/chromium-linux-x86/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
- platform/chromium-linux/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Removed.
- platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-mac/media/video-empty-source-expected.txt.
- platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
- platform/chromium-mac/fast/layers/video-layer-expected.txt:
- platform/chromium-mac/media/audio-controls-rendering-expected.txt:
- platform/chromium-mac/media/audio-repaint-expected.txt:
- platform/chromium-mac/media/controls-after-reload-expected.txt:
- platform/chromium-mac/media/controls-strict-expected.txt:
- platform/chromium-mac/media/controls-styling-expected.txt:
- platform/chromium-mac/media/controls-without-preload-expected.txt:
- platform/chromium-mac/media/media-controls-clone-expected.txt:
- platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
- platform/chromium-mac/media/video-controls-rendering-expected.txt:
- platform/chromium-mac/media/video-display-toggle-expected.txt:
- platform/chromium-mac/media/video-empty-source-expected.txt:
- platform/chromium-mac/media/video-no-audio-expected.txt:
- platform/chromium-mac/media/video-playing-and-pause-expected.txt:
- platform/chromium-mac/media/video-volume-slider-expected.txt:
- platform/chromium-mac/media/video-zoom-controls-expected.txt:
- platform/chromium-win-vista/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
- platform/chromium-win/fast/layers/video-layer-expected.txt:
- platform/chromium-win/media/audio-controls-rendering-expected.txt:
- platform/chromium-win/media/audio-repaint-expected.txt:
- platform/chromium-win/media/controls-after-reload-expected.txt:
- platform/chromium-win/media/controls-strict-expected.txt:
- platform/chromium-win/media/controls-styling-expected.txt:
- platform/chromium-win/media/controls-without-preload-expected.txt:
- platform/chromium-win/media/media-controls-clone-expected.txt:
- platform/chromium-win/media/media-document-audio-repaint-expected.txt:
- platform/chromium-win/media/video-controls-rendering-expected.txt:
- platform/chromium-win/media/video-display-toggle-expected.txt:
- platform/chromium-win/media/video-empty-source-expected.txt:
- platform/chromium-win/media/video-no-audio-expected.txt:
- platform/chromium-win/media/video-playing-and-pause-expected.txt:
- platform/chromium-win/media/video-volume-slider-expected.txt:
- platform/chromium-win/media/video-zoom-controls-expected.txt:
- 5:03 PM Changeset in webkit [113645] by
-
- 4 edits in trunk/Source/WebCore
Prepare html classes for sub-pixel LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=83491
Reviewed by Eric Seidel.
This patch brings the entire HTML folder up to the current state of the subpixellayout branch. Adding
an intValue flavor of Length that maps to the current value function was also necessary to get us
there. See https://trac.webkit.org/wiki/LayoutUnit and the descriptions below for details.
No new tests. No change in behavior.
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::scrollAmount): Fixes a compiler error when length returns a float, as
we intend it to do when switching to sub-pixel layout.
- html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::finish): imageSize is always integral.
- platform/Length.h:
(WebCore::Length::Length): Added a constructor that takes a FractionalLayoutUnit.
(Length):
(WebCore::Length::intValue): Currently maps directly to Length::value, but the current logic of value
will be migrated here when value is changed to return a float.
(WebCore::Length::setValue): Added a variant that takes a FractionalLayoutUnit.
- 5:01 PM Changeset in webkit [113644] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] requestAnimationFrame performance choppy & inconsistent
https://bugs.webkit.org/show_bug.cgi?id=83499
Patch by Andrew Lo <anlo@rim.com> on 2012-04-09
Reviewed by Rob Buis.
Respect m_scheduled & m_previousFrameDone flags like the Mac port of
DisplayRefreshMonitor does.
Internal PR: 147826
requestAnimationFrame already covered by tests in LayoutTests/fast/animation.
- platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
(WebCore::DisplayRefreshMonitor::displayLinkFired):
- 4:58 PM Changeset in webkit [113643] by
-
- 2 edits in trunk/Source/WebCore
Make CSSValueID's into an enum instead of a collection of integers.
https://bugs.webkit.org/show_bug.cgi?id=83246
Reviewed by Simon Fraser.
This patch simply converts the list of integers into an enum.
Follow-up patches will then convert existing code that uses integers to use the new enum.
No new tests / no functionality changed.
- css/makevalues.pl:
- 4:54 PM Changeset in webkit [113642] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, modernize and clean up uses of ARM assembly mnemonics in inline asm blocks.
- dfg/DFGOperations.cpp:
(JSC):
- offlineasm/armv7.rb:
- 4:49 PM Changeset in webkit [113641] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r113609.
http://trac.webkit.org/changeset/113609
https://bugs.webkit.org/show_bug.cgi?id=83522
it broke tests (Requested by dethbakin on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-09
Source/WebCore:
- css/mediaControlsChromium.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
- css/mediaControlsQuickTime.css:
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
- html/shadow/MediaControlElements.cpp:
(RenderMediaVolumeSliderContainer):
(WebCore):
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer):
- html/shadow/MediaControlElements.h:
(MediaControlVolumeSliderContainerElement):
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::create):
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::create):
LayoutTests:
- media/video-controls-rendering-toggle-display-none-expected.txt: Removed.
- media/video-controls-rendering-toggle-display-none.html: Removed.
- 4:45 PM Changeset in webkit [113640] by
-
- 12 edits in trunk/Source/WebKit2
[Qt][WK2] Sync the layer's state and the layer's children separately
https://bugs.webkit.org/show_bug.cgi?id=82534
Reviewed by Kenneth Rohde Christiansen.
Switched the WebLayerInfo struct, which includes a single layer's state,
to use only POD types that can be serialized via SimpleArgumentCoder.
To allow POD-serialization, we serialize the children IDs in a seperate
message (SetLayerChildren), and only when the tree layout has actually
been modified.
- Shared/WebLayerTreeInfo.cpp:
(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):
- Shared/WebLayerTreeInfo.h:
(WebKit::WebLayerInfo::WebLayerInfo):
- UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::setCompositingLayerState):
(WebKit):
(WebKit::LayerTreeHostProxy::setCompositingLayerChildren):
- UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
- UIProcess/LayerTreeHostProxy.messages.in:
- UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::setLayerChildren):
(WebKit):
(WebKit::WebLayerTreeRenderer::setLayerState):
- UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::didChangeLayerState):
(WebCore):
(WebCore::WebGraphicsLayer::didChangeChildren):
(WebCore::WebGraphicsLayer::didChangeGeometry):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setDrawsContent):
(WebCore::WebGraphicsLayer::setContentsOpaque):
(WebCore::WebGraphicsLayer::setBackfaceVisibility):
(WebCore::WebGraphicsLayer::setOpacity):
(WebCore::WebGraphicsLayer::setContentsRect):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::setReplicatedByLayer):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::id):
(WebCore::WebGraphicsLayer::syncChildren):
(WebCore::WebGraphicsLayer::syncLayerState):
(WebCore::WebGraphicsLayer::syncImageBackingStore):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setRootLayer):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayerClient):
(WebGraphicsLayer):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::syncLayerState):
(WebKit):
(WebKit::LayerTreeHostQt::syncLayerChildren):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
- 4:28 PM Changeset in webkit [113639] by
-
- 4 edits in trunk/Tools
add a webkit-patch print-baselines command
https://bugs.webkit.org/show_bug.cgi?id=83348
Reviewed by Adam Barth.
This adds a simple 'print-baselines' command to webkit-patch
that can be used in one of two forms: to print where the
baselines for a given test (or set of tests) on a single port
will be found, or to generate a report for multiple ports.
Example of the former:
$ webkit-patch print-baselines fast/html/keygen.html
For mac-snowleopard
platform/mac/fast/html/keygen-expected.txt
platform/mac/fast/html/keygen-expected.png
$
The latter is most useful for finding out which fallback dirs are
used by which ports for which tests, for example,
'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
No example output is given because the reports are pretty wordy :).
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.baseline_extensions): Added.
(Port.expected_baseline_dict): Added.
- Scripts/webkitpy/tool/commands/queries.py:
(PrintBaselines):
(PrintBaselines.init):
(PrintBaselines.execute):
(PrintBaselines._print_baselines):
(PrintBaselines._platform_for_path):
- 4:20 PM Changeset in webkit [113638] by
-
- 2 edits in trunk/Tools
Unreviewed: adding myself to committers.py.
Patch by Florin Malita <fmalita@chromium.org> on 2012-04-09
- Scripts/webkitpy/common/config/committers.py:
- 3:52 PM Changeset in webkit [113637] by
-
- 6 edits in trunk/Source
[chromium] Make culling work with clipped rects
https://bugs.webkit.org/show_bug.cgi?id=83494
Reviewed by Adrienne Walker.
Source/WebCore:
Use new CCMathUtil transformation methods to deal with rects that clip
the camera plane. This fixes three things:
- A layer completely behind the camera is not visible and should not
occlude.
- A layer that is clipped by the camera is treated like a
non-axis-aligned transform, as the result of a mapClippedRect() is a
bounding box and may contain pixels not in the original rect. This guards
our use of mapRect() when transforming occluded regions.
- A layer's occlusion must be clipped by its scissor rect. This scissor
rect exists in its target space, so occlusion in screen space is only
possible if its target also is axis aligned in the screen, such that
the layer's scissor rect remains a rect in screen space.
Unit tests: CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude
CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect
- platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::CCMathUtil::mapQuad):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
- tests/CCQuadCullerTest.cpp:
(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
(WebCore::makeLayer):
(WebCore::TEST):
- 3:49 PM Changeset in webkit [113636] by
-
- 8 edits10 deletes in trunk
Remove unworkable video-buffering-repaints-controls test.
https://bugs.webkit.org/show_bug.cgi?id=83097
.:
Replaces the automated test for progress bar repaints during buffering
with a manual test entry.
Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-04-09
Reviewed by Eric Carlson.
- ManualTests/media-controls.html:
LayoutTests:
Test has been broken in one way or another for some time now. I've
approached multiple people about possible solutions, but nothing ends
up being stable.
After discussion with fischman and trying a couple more solutions
today, we decided the best course of action is to remove the test.
Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-04-09
Reviewed by Eric Carlson.
- http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
- http/tests/media/video-buffering-repaints-controls.html: Removed.
- platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
- platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
- platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
- platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
- platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
- platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
- platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
- platform/mac/Skipped:
- platform/mac/test_expectations.txt:
- 3:44 PM Changeset in webkit [113635] by
-
- 16 edits4 deletes in trunk
Unreviewed, rolling out r113613.
http://trac.webkit.org/changeset/113613
https://bugs.webkit.org/show_bug.cgi?id=83509
crashing most chromium bots (Requested by simonjam on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-09
Source/WebCore:
- Modules/battery/BatteryController.cpp:
- Modules/battery/BatteryController.h:
(BatteryController):
- Modules/battery/BatteryManager.cpp:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
Source/WebKit/chromium:
- WebKit.gyp:
- features.gypi:
- public/WebBatteryStatus.h: Removed.
- public/WebBatteryStatusClient.h: Removed.
- public/WebView.h:
(WebKit):
(WebView):
- public/WebViewClient.h:
(WebKit):
- src/BatteryClientImpl.cpp: Removed.
- src/BatteryClientImpl.h: Removed.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
(WebKit):
(WebViewImpl):
LayoutTests:
- platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
- platform/chromium/test_expectations.txt:
- 3:40 PM Changeset in webkit [113634] by
-
- 5 edits in trunk
bindAttribLocation should check webgl reserved prefix
https://bugs.webkit.org/show_bug.cgi?id=83409
Reviewed by Kenneth Russell.
Source/WebCore:
- html/canvas/WebGLRenderingContext.cpp: Check for invalid parameters for a few functions.
(WebCore):
(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::getAttribLocation):
(WebCore::WebGLRenderingContext::getUniformLocation):
LayoutTests:
- fast/canvas/webgl/webgl-specific-expected.txt: Added webgl prefix test case for bindAttribLocation.
- fast/canvas/webgl/webgl-specific.html:
- 3:40 PM Changeset in webkit [113633] by
-
- 4 edits in trunk
[BlackBerry] Allow simulator to use GLES2 acceleration
https://bugs.webkit.org/show_bug.cgi?id=81672
Patch by Ming Xie <mxie@rim.com> on 2012-04-09
Reviewed by Rob Buis.
.:
- Source/cmake/OptionsBlackBerry.cmake:
Tools:
- Scripts/webkitdirs.pm:
(blackberryCMakeArguments):
- 3:17 PM Changeset in webkit [113632] by
-
- 1 edit4 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening fix.
- platform/chromium/virtual/threaded/compositing/visibility/README.txt: Added.
- 3:14 PM Changeset in webkit [113631] by
-
- 2 edits in trunk/Source/WebCore
Fix the assertion in PageScriptDebugServer::didPause.
Reviewed by Simon Fraser.
- bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::PageScriptDebugServer): Initialize m_pausedPage
to zero so the assert in didPause will not randomly fire the first time.
- 3:06 PM PrefixedAPIs edited by
- (diff)
- 3:05 PM Changeset in webkit [113630] by
-
- 4 edits in tags/Safari-536.6.1/Source/WebKit2
Merged r113501.
- 3:00 PM Changeset in webkit [113629] by
-
- 2 edits in tags/Safari-536.6.1/Source/WebKit2
Merged r113523.
- 2:59 PM Changeset in webkit [113628] by
-
- 6 edits in trunk/Source/WebKit2
[Qt][WK2] Accelerated and non-accelerated animations need to be synchronized
https://bugs.webkit.org/show_bug.cgi?id=75780
Reviewed by Kenneth Rohde Christiansen.
Remove the ui-side animation code, and return false from addAnimation so that web-side
animations kick in.
- Shared/WebLayerTreeInfo.cpp:
(WebKit):
- Shared/WebLayerTreeInfo.h:
(WebLayerInfo):
- UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::setLayerState):
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::didChangeGeometry):
(WebCore::WebGraphicsLayer::syncLayerState):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):
- 2:58 PM Changeset in webkit [113627] by
-
- 4 edits in tags/Safari-536.6.1/Source
Versioning.
- 2:58 PM Changeset in webkit [113626] by
-
- 40 edits1 copy4 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium-linux-x86/media/video-empty-source-expected.txt: Removed.
- platform/chromium-linux/media/media-document-audio-repaint-expected.png:
- platform/chromium-linux/media/video-empty-source-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.txt.
- platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
- platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Removed.
- platform/chromium-mac/fast/forms/basic-textareas-expected.png:
- platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
- platform/chromium-mac/fast/layers/video-layer-expected.txt:
- platform/chromium-mac/media/audio-controls-rendering-expected.txt:
- platform/chromium-mac/media/audio-repaint-expected.txt:
- platform/chromium-mac/media/controls-after-reload-expected.txt:
- platform/chromium-mac/media/controls-strict-expected.txt:
- platform/chromium-mac/media/controls-styling-expected.txt:
- platform/chromium-mac/media/controls-without-preload-expected.txt:
- platform/chromium-mac/media/media-controls-clone-expected.txt:
- platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
- platform/chromium-mac/media/video-controls-rendering-expected.txt:
- platform/chromium-mac/media/video-display-toggle-expected.txt:
- platform/chromium-mac/media/video-empty-source-expected.txt:
- platform/chromium-mac/media/video-no-audio-expected.txt:
- platform/chromium-mac/media/video-playing-and-pause-expected.txt:
- platform/chromium-mac/media/video-volume-slider-expected.txt:
- platform/chromium-mac/media/video-zoom-controls-expected.txt:
- platform/chromium-win-vista/media/video-empty-source-expected.txt: Removed.
- platform/chromium-win/fast/layers/video-layer-expected.txt:
- platform/chromium-win/media/audio-controls-rendering-expected.txt:
- platform/chromium-win/media/audio-repaint-expected.txt:
- platform/chromium-win/media/controls-after-reload-expected.txt:
- platform/chromium-win/media/controls-strict-expected.txt:
- platform/chromium-win/media/controls-styling-expected.txt:
- platform/chromium-win/media/controls-without-preload-expected.txt:
- platform/chromium-win/media/media-controls-clone-expected.txt:
- platform/chromium-win/media/media-document-audio-repaint-expected.txt:
- platform/chromium-win/media/video-controls-rendering-expected.txt:
- platform/chromium-win/media/video-display-toggle-expected.txt:
- platform/chromium-win/media/video-empty-source-expected.txt:
- platform/chromium-win/media/video-no-audio-expected.txt:
- platform/chromium-win/media/video-playing-and-pause-expected.txt:
- platform/chromium-win/media/video-volume-slider-expected.txt:
- platform/chromium-win/media/video-zoom-controls-expected.txt:
- platform/chromium/test_expectations.txt:
- 2:58 PM Changeset in webkit [113625] by
-
- 2 edits in trunk/Tools
Mark myself as a committer
https://bugs.webkit.org/show_bug.cgi?id=83510
Reviewed by Adrienne Walker.
- Scripts/webkitpy/common/config/committers.py:
- 2:46 PM Changeset in webkit [113624] by
-
- 2 edits in trunk/Source/WebCore
FrameData constructor zeroes all fields, causing ImageOrientation to be 0
https://bugs.webkit.org/show_bug.cgi?id=83416
Reviewed by Geoff Garen.
Reinstate SimpleClassVectorTraits on FrameData (which were removed by http://trac.webkit.org/changeset/113543)
with canInitializeWithMemset disabled, since two of the FrameData fields cannot be initialized to zero.
No new tests.
- platform/graphics/BitmapImage.h:
- 2:40 PM Changeset in webkit [113623] by
-
- 15 edits in trunk/Source
[chromium] CCLayerTreeHost / WebLayerTreeView should be single ownership, not RefCounted
https://bugs.webkit.org/show_bug.cgi?id=83413
Patch by James Robinson <jamesr@chromium.org> on 2012-04-09
Reviewed by Adrienne Walker.
Source/Platform:
This makes WebLayerTreeView noncopyable to better match the underlying semantics. There is no code currently
that attempts to copy WebLayerTreeView instances.
- chromium/public/WebLayerTreeView.h:
(WebKit):
(WebLayerTreeView):
Source/WebCore:
CCLayerTreeHost always has a single logical owner, typically a WebLayerTreeView via either WebViewImpl or the
public API. It is currently refcounted for historical reasons but this isn't necessary and adds confusion.
CCLayerTreeHost instances and pointers are carefully managed currently to avoid leaks. In particular, while
LayerChromium instances hold RefPtr<CCLayerTreeHost>s, whenever we want to destroy a CCLayerTreeHost we
proactively clear out these references inside setRootLayer() to break the cycle.
Refactor covered by existing unit and layout tests.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setReplicaLayer):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::layerTreeHost):
(LayerChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::create):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
Source/WebKit/chromium:
Updates tests and implementation for RefPtr->OwnPtr switch. One nice benefit is that since WebLayerTreeView is
explicitly owned by the user of the API we can safely rely on them managing the lifetime of the client and thus
don't have to null check the client all the time.
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::reset):
(WebKit::WebLayerTreeView::isNull):
(WebKit::WebLayerTreeView::initialize):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::willBeginFrame):
(WebKit::WebLayerTreeViewImpl::updateAnimations):
(WebKit::WebLayerTreeViewImpl::layout):
(WebKit::WebLayerTreeViewImpl::applyScrollAndScale):
(WebKit::WebLayerTreeViewImpl::createContext):
(WebKit::WebLayerTreeViewImpl::didRecreateContext):
(WebKit::WebLayerTreeViewImpl::didCommit):
(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):
(WebKit::WebLayerTreeViewImpl::scheduleComposite):
- src/WebLayerTreeViewImpl.h:
(WebLayerTreeViewImpl):
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::create):
(CCLayerTreeHostTest):
- tests/Canvas2DLayerChromiumTest.cpp:
- tests/LayerChromiumTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
- 2:37 PM Changeset in webkit [113622] by
-
- 8 edits1 delete in trunk/Source
Unreviewed, rolling out r113473.
http://trac.webkit.org/changeset/113473
https://bugs.webkit.org/show_bug.cgi?id=83074
Change does not handle cursor retention of LevelDB iterators
Source/WebCore:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):
- Modules/indexeddb/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::create):
(IDBIndexBackendImpl):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::create):
(WebCore::IDBObjectStoreBackendImpl::databaseId):
(IDBObjectStoreBackendImpl):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/IDBDatabaseBackendTest.cpp: Removed.
- 2:32 PM Changeset in webkit [113621] by
-
- 2 edits in branches/subpixellayout/Source/WebCore
Cleaning up LayoutUnit usage in DOMNodeHighlighter and removing unnecessary static_casts in ValidationMessage.
- 2:30 PM Changeset in webkit [113620] by
-
- 1 copy in tags/Safari-536.6.1
New Tag.
- 2:26 PM Changeset in webkit [113619] by
-
- 1 edit1 add11 deletes in trunk/LayoutTests
[CSS Regions] Convert a fast/regions pixel test to a ref test
https://bugs.webkit.org/show_bug.cgi?id=83398
Patch by David Alcala <dalcala@adobe.com> on 2012-04-09
Reviewed by Dirk Schulze.
- fast/regions/position-writing-modes-in-variable-width-regions-expected.html: Added.
- platform/chromium-linux/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
- platform/chromium-mac-leopard/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
- platform/chromium-mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
- platform/chromium-mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
- platform/chromium-win/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
- platform/chromium-win/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
- platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
- platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
- 2:24 PM Changeset in webkit [113618] by
-
- 8 edits in trunk/Source
[chromium] Texture copies should happen after incremental updates to preserve commit atomicity
https://bugs.webkit.org/show_bug.cgi?id=83392
Reviewed by Adrienne Walker.
Source/WebCore:
This enqueues texture copy operations in the CCTextureUpdater's list instead of evaluating them immediately so
if the update is spread over multiple frames we can properly defer the texture copy until the end. Otherwise,
the texture copy for WebGL / Canvas 2D content happens before the commit completes and the compositor might pick
up a frame for the canvas that's "ahead" of the content around it.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
- platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::appendUpdate):
(WebCore::CCTextureUpdater::appendPartialUpdate):
(WebCore):
(WebCore::CCTextureUpdater::appendCopy):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):
- platform/graphics/chromium/cc/CCTextureUpdater.h:
(CCTextureUpdater):
(UpdateEntry):
(CopyEntry):
Source/WebKit/chromium:
- tests/Canvas2DLayerChromiumTest.cpp:
- 2:07 PM Changeset in webkit [113617] by
-
- 2 edits in trunk/Tools
nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230
Unreviewed, build fix.
It looks like the change in r113399 to use the per-request
timeout variable didn't actually work, so I am removing the
timeout code altogether and counting on the idea that upload
just isn't likely to take that long and the timeouts and
retransmits are largely unused and largely unnecessary. We'll
see if this breaks anywhere else.
- Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.init):
(FileUploader._upload_data.callback):
(FileUploader):
- 1:59 PM Changeset in webkit [113616] by
-
- 2 edits in trunk/Tools
[BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=83469
Reviewed by Dirk Schulze.
Remove WTF:: prefixes and fix a warning with the length variable.
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(jsStringRefToWebCoreString):
(LayoutTestController::execCommand):
(LayoutTestController::isCommandEnabled):
(LayoutTestController::setUserStyleSheetLocation):
(LayoutTestController::counterValueForElementById):
(LayoutTestController::overridePreference):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::findString):
- 1:57 PM Changeset in webkit [113615] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][WK2] Don't synchronize WebGraphicsLayers to the UI process if the actual layer information wasn't changed
https://bugs.webkit.org/show_bug.cgi?id=82522
Reviewed by Kenneth Rohde Christiansen.
Currently we set the m_modified flags for all of the descendants of a layer
that has changed its geometry. This causes unnecessary layer sync messages.
Instead, we only sync when the actual layer has changed, and add a flag
called m_shouldUpdateVisibleRect that applies to descendants of a layer
that has a modified geometry.
- Shared/WebLayerTreeInfo.h:
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::didChangeChildren):
(WebCore):
(WebCore::WebGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::WebGraphicsLayer::didChangeGeometry):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setPosition):
(WebCore::WebGraphicsLayer::setAnchorPoint):
(WebCore::WebGraphicsLayer::setSize):
(WebCore::WebGraphicsLayer::setTransform):
(WebCore::WebGraphicsLayer::setChildrenTransform):
(WebCore::WebGraphicsLayer::setPreserves3D):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncImageBackingStore):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::effectiveContentsScale):
(WebCore::WebGraphicsLayer::adjustContentsScale):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):
- 1:50 PM Changeset in webkit [113614] by
-
- 26 edits in branches/subpixellayout/Source/WebCore
Replace numeric_limits<LayoutUnit>::min/max with constants on branch.
- 1:43 PM Changeset in webkit [113613] by
-
- 16 edits4 adds in trunk
[chromium] Add Battery Status API support.
Source/WebCore:
Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-09
Reviewed by Adam Barth.
This change is covered by tests in batterystatus/.
- Modules/battery/BatteryController.cpp:
(WebCore::BatteryController::updateBatteryStatus):
(WebCore):
- Modules/battery/BatteryController.h:
(BatteryController):
- Modules/battery/BatteryManager.cpp:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
Source/WebKit/chromium:
The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at http://www.w3.org/TR/2011/WD-battery-status-20111129/.
https://bugs.webkit.org/show_bug.cgi?id=83284
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-09
Reviewed by Adam Barth.
- WebKit.gyp:
- features.gypi:
- public/WebBatteryStatus.h: Added.
(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):
- public/WebBatteryStatusClient.h: Added.
(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):
- public/WebView.h:
(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):
- public/WebViewClient.h:
(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):
- src/BatteryClientImpl.cpp: Added.
(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):
- src/BatteryClientImpl.h: Added.
(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):
- src/WebViewImpl.h:
(WebKit):
(WebViewImpl):
LayoutTests:
Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-09
Reviewed by Adam Barth.
- platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:31 PM Changeset in webkit [113612] by
-
- 2 edits in branches/subpixellayout/Source/WebCore
Adding more missing double overloads to avoid unnecessary static_casting.
- 1:31 PM Changeset in webkit [113611] by
-
- 9 edits2 adds in trunk
Unnecessary scroll bar after changing the dimensions of a DIV
https://bugs.webkit.org/show_bug.cgi?id=71541
Patch by SravanKumar Sandela <ssandela@innominds.com> on 2012-04-09
Reviewed by Julien Chaffraix.
Source/WebCore:
overflow: auto was being determined based on clientWidth and clientHeight, which during style change
scenarii will blindly exclude previous scrollbars while computing overflow. This is valid only for
overflow: scroll, but for other cases it wrongly reduces available area. Now it is taken care by
determining the overflow based on pixelSnappedPaddingBoxWidth/Height() which are newly added in RenderBox.
Tests: fast/overflow/overflow-auto-destroy-scroll-after-resizing-expected.html
fast/overflow/overflow-auto-destroy-scroll-after-resizing.html
- rendering/RenderBox.h:
(WebCore::RenderBox::paddingBoxWidth):
(WebCore::RenderBox::paddingBoxHeight):
(WebCore::RenderBox::pixelSnappedPaddingBoxWidth):
(WebCore::RenderBox::pixelSnappedPaddingBoxHeight):
(RenderBox):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hasHorizontalOverflow):
(WebCore::RenderLayer::hasVerticalOverflow):
LayoutTests:
Ref tests to check scrollbar behaviour in overflow: auto, on resizing.
- fast/overflow/overflow-auto-destroy-scroll-after-resizing-expected.html: Added.
- fast/overflow/overflow-auto-destroy-scroll-after-resizing.html: Added.
scrollbars-on-positioned-content.html and hidden-scrollbar-resize.html needs to be rebaselined
as their expected values were buggy because of redundant scrollbars.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 1:26 PM Changeset in webkit [113610] by
-
- 5 edits in trunk/Source/WebKit2
[Qt][WK2] Remove all USE(TILED_BACKING_STORE) defines from code that contains UI_SIDE_COMPOSITING
https://bugs.webkit.org/show_bug.cgi?id=82533
Reviewed by Kenneth Rohde Christiansen.
No change in behavior, removing some #defines.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::WebGraphicsLayer::adjustContentsScale):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):
- WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::detachLayer):
- 1:10 PM Changeset in webkit [113609] by
-
- 9 edits2 adds in trunk
Source/WebCore: Simplified volume slider rendering.
https://bugs.webkit.org/show_bug.cgi?id=82150
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-09
Reviewed by Eric Carlson.
Test: media/video-controls-rendering-toggle-display-none.html
- css/mediaControlsChromium.css: Update controls css for Chromium.
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
- css/mediaControlsQuickTime.css: Update controls css for Safari.
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
- html/shadow/MediaControlElements.cpp: Removed particular renderer.
(WebCore):
- html/shadow/MediaControlElements.h:
(MediaControlVolumeSliderContainerElement): Removed particular renderer.
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::create): Added a div element as a container. Removed extra
unused mute button.
- html/shadow/MediaControlRootElementChromium.cpp: Added an extra div element as a container for
the mute button and the volume slider to easily position them relative to each other.
(WebCore::MediaControlRootElementChromium::create):
LayoutTests: Simplified volume rendering.
https://bugs.webkit.org/show_bug.cgi?id=82150
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-09
Reviewed by Eric Carlson.
- media/video-controls-rendering-toggle-display-none-expected.txt: Added.
- media/video-controls-rendering-toggle-display-none.html: Added.
- platform/chromium/test_expectations.txt: Marked tests for rebaseline.
- 1:01 PM Changeset in webkit [113608] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Disable the content-scaling and visible contents rect when the layer's transform is not affine
https://bugs.webkit.org/show_bug.cgi?id=82523
Reviewed by Kenneth Rohde Christiansen.
Always use contentsScale of 1 and a full visibleContentsRect when
the layer's transform is not affine. That's because layer's with
complex transform would not gain from the benefit of contents scaling,
and might also create unexpected layer content sizes.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::createBackingStore):
(WebCore):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateContentBuffers):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):
- 12:46 PM Changeset in webkit [113607] by
-
- 3 edits in trunk/Source/WebCore
Correct some LayoutUnit misuse in FilterEffectRenderer, and RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=83366
Reviewed by Eric Seidel.
Some more preparation of Render classes for FractionalLayoutUnits. See below for details
of each change.
No new tests. No change in behavior.
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRendererHelper::applyFilterEffect): Pixel snapping image rect before
drawing it.
- rendering/RenderBlock.cpp:
(WebCore::::string): Pixel snapping outputted values for debug.
- 12:31 PM Changeset in webkit [113606] by
-
- 6 edits in trunk/Source
[chromium] Fix layer sorting perspective w if w becomes negative
https://bugs.webkit.org/show_bug.cgi?id=82997
Reviewed by Adrienne Walker.
Source/WebCore:
Unit test added to CCLayerSorterTest.cpp.
This is a follow-up patch after r113364. That other patch
implemented proper clipping so that perspective transforms do not
accidentally make geometry disappear. This patch fixes a similar
problem in the layer sorter code so that layers do not
accidentally get sorted incorrectly.
- platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::LayerShape::LayerShape):
- platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::computeEnclosingRect):
(WebCore::addVertexToClippedQuad):
(WebCore::CCMathUtil::mapClippedQuad):
(WebCore):
(WebCore::CCMathUtil::computeEnclosingRectOfVertices):
- platform/graphics/chromium/cc/CCMathUtil.h:
(WebCore):
(CCMathUtil):
Source/WebKit/chromium:
- tests/CCLayerSorterTest.cpp:
(WebCore::TEST):
(WebCore):
- 12:31 PM Changeset in webkit [113605] by
-
- 3 edits1 add in trunk
[Qt][WK2] Fail to activate links after double tap gesture.
https://bugs.webkit.org/show_bug.cgi?id=83468
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-09
Reviewed by Kenneth Rohde Christiansen.
.:
- ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.
Source/WebKit2:
After a recognized double tap gesture, QtTapGestureRecognizer
gets stuck in the double-tap state. Only tapping outside of
the double tap radius cancels it.
Call reset() to set the default state back.
- UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::recognize):
ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.
- 12:28 PM Changeset in webkit [113604] by
-
- 4 edits2 adds in trunk
[soup] Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Philippe Normand.
.:
- configure.ac: Bumped the libsoup dependency to 2.37.90.
Source/WebCore:
Test: http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html
When running synchronous XMLHttpRequests, push a new inner thread default
context, so that other sources from timers and network activity do not run.
This will make synchronous requests truly synchronous with the rest of
WebCore.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCoreSynchronousLoader): Clean up the method definitions a bit by writing them inline.
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Push a new thread default
context to prevent other sources from running.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Pop the inner thread default context.
(WebCore::closeCallback): If the client is synchronous call didFinishLoading now.
(WebCore::readCallback): Only call didFinishLoading if the client isn't synchronous.
(WebCore::ResourceHandle::defaultSession): Activate use-thread-context so that the soup session
respects the inner thread context.
LayoutTests:
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added.
- 12:17 PM WebKitGTK/1.8.x edited by
- (diff)
- 12:06 PM Changeset in webkit [113603] by
-
- 2 edits in branches/subpixellayout/Source/WebCore
Using FractionalLayoutUnit instead of LayoutUnit for overloaded functions in Length, and using static_cast's in html/ValidationMessage.cpp so the changes can be landed in trunk.
- 11:58 AM Changeset in webkit [113602] by
-
- 5 edits in trunk/Source
[chromium] Flip transition painting delayed with threaded animations
https://bugs.webkit.org/show_bug.cgi?id=82571
Patch by Dana Jansens <danakj@chromium.org> on 2012-04-09
Reviewed by Adrienne Walker.
Source/WebCore:
This allows for prepainting to see and paint layers that are not facing
the camera but have animating transforms. This is needed to prepaint
animations that "flip" layers around to make the front visible.
The changes are to add a backFaceIsVisible() helper function in
CCLTHCommon. This is used like before to cull non-double sided
layers, but culling is prevented on main thread when the screen
space transform is unknown due to animation. We add new
helper methods transformToScreenIsKnown() to identify this.
However the layer is not actually visible, so we set the
visibleLayerRect to be empty in this case.
The calculateVisibleLayerRect needs to use the backFaceIsVisible()
helper, so we move it into the .cpp file where it belongs, and make
it static to the file since it is not used outide of CCLTHCommon.cpp
at all.
Unit test: CCLayerTreeHostCommonTest.verifyBackFaceCulling
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore):
(WebCore::backFaceIsVisible):
(WebCore::calculateVisibleLayerRect):
(WebCore::layerOpacityIsOpaque):
(WebCore::transformToParentIsKnown):
(WebCore::transformToScreenIsKnown):
(WebCore::layerShouldBeSkipped):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::walkLayersAndCalculateVisibleLayerRects):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(WebCore):
Source/WebKit/chromium:
- tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):
(WebKitTests):
- 11:56 AM Changeset in webkit [113601] by
-
- 3 edits3 adds in trunk
[GTK] Toggle buttons do not size appropriately in some themes
https://bugs.webkit.org/show_bug.cgi?id=82833
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Test: platform/gtk/fast/forms/large-toggle-elements.html
Instead of drawing a toggle button across the entire rectangle of
the WebCore control, draw a default-sized one cenetered in the rectangle.
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::paintToggle): Draw default-sized toggles.
LayoutTests:
Add a test for this issue.
- platform/gtk/fast/forms/large-toggle-elements-expected.png: Added.
- platform/gtk/fast/forms/large-toggle-elements-expected.txt: Added.
- platform/gtk/fast/forms/large-toggle-elements.html: Added.
- 11:50 AM PrefixedAPIs edited by
- Added links about postMessage prefixing and Transferables (diff)
- 11:49 AM Changeset in webkit [113600] by
-
- 6 edits in trunk/Source/WebCore
When create JavaScriptNode, do not ignore NumberOfOutputChannels parameter.
https://bugs.webkit.org/show_bug.cgi?id=83250
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-09
Reviewed by Chris Rogers.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createJavaScriptNode):
(WebCore):
- Modules/webaudio/AudioContext.h:
(AudioContext):
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/JavaScriptAudioNode.cpp:
(WebCore::JavaScriptAudioNode::create):
(WebCore):
(WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
(WebCore::JavaScriptAudioNode::initialize):
(WebCore::JavaScriptAudioNode::process):
- Modules/webaudio/JavaScriptAudioNode.h:
(JavaScriptAudioNode):
- 11:34 AM Changeset in webkit [113599] by
-
- 4 edits in branches/subpixellayout/Source/WebCore
Remove size_t versions of methods and numeric_limits from FractionalLayoutUnit on branch.
- 11:29 AM Changeset in webkit [113598] by
-
- 2 edits in trunk/LayoutTests
Skip fast/css/align-positioned-object-on-resize.html on Mac platforms.
window.resizeTo() doesn't behave as expected in Mac DRT.
Unreviewed.
- platform/mac/Skipped:
- 11:21 AM Changeset in webkit [113597] by
-
- 3 edits1 add in trunk
Crash due to floats not cleared before starting SVG <text> layout.
https://bugs.webkit.org/show_bug.cgi?id=83021
Reviewed by Dirk Schulze.
.:
- ManualTests/svg-text-float-not-removed-crash.html: Added.
Source/WebCore:
Manual Test - ManualTests/svg-text-float-not-removed-crash.html.
Can't reproduce the failure in DRT.
forceLayoutInlineChildren is used in SVG <text> layout and overrides
RenderBlock::layoutBlock. However, it missed the 'clearFloats' step,
which will cause a crash when trying to access removed renderers.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::forceLayoutInlineChildren):
- 11:19 AM Changeset in webkit [113596] by
-
- 6 edits3 adds in trunk
Filter files from dataTransfer.getData on Mac
https://bugs.webkit.org/show_bug.cgi?id=38876
Reviewed by Enrica Casucci.
Source/WebCore:
The ClipboardMac class now keeps track of whether it was created for copy and paste, dragging and dropping
files or dragging and dropping generic data. This enables the class to block calls to set-/getData when the
clipboard is not operating on generic data, and vice-versa.
Test: fast/events/drop-with-file-paths.html
- editing/mac/EditorMac.mm:
(WebCore::Editor::newGeneralClipboard):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::createDraggingClipboard):
- platform/mac/ClipboardMac.h:
(WebCore::ClipboardMac::create):
(ClipboardMac):
- platform/mac/ClipboardMac.mm:
(WebCore::Clipboard::create):
(WebCore::ClipboardMac::ClipboardMac):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::files):
LayoutTests:
- fast/events/drop-with-file-paths-expected.txt: Added.
- fast/events/drop-with-file-paths.html: Added.
- fast/events/resources/file-for-drop-with-file-paths.html: Added.
- 11:13 AM Changeset in webkit [113595] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r113561.
http://trac.webkit.org/changeset/113561
https://bugs.webkit.org/show_bug.cgi?id=83487
broke webkit_unit_tests (Requested by simonjam on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-09
Source/WebCore:
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests):
- tests/CCQuadCullerTest.cpp:
(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
- 11:09 AM Changeset in webkit [113594] by
-
- 2 edits in trunk/Source/WebCore
Correct LayoutUnit usage in style functions getRoundedBorderFor
https://bugs.webkit.org/show_bug.cgi?id=83154
Reviewed by Julien Chaffraix.
Correcting LayoutUnit usage in getRoundedBorderFor and the calcRadiiFor helper function.
No new tests. No change in behavior.
- rendering/style/RenderStyle.cpp:
(WebCore::calcRadiiFor): This is a static internal function that returns the radii based on a size.
It's only called from getRoundedBorderFor, so we're now pixel snapping the size before handing it
to this function.
(WebCore::RenderStyle::getRoundedBorderFor): Takes a LayoutRect and returns the pixel-snapped
resulting RoundedRect. Using a local IntRect to avoid snapping twice.
- 11:03 AM WebKitGTK/1.8.x edited by
- (diff)
- 11:00 AM Changeset in webkit [113593] by
-
- 10 edits in releases/WebKitGTK/webkit-1.8
Merging 113019
- 10:37 AM Changeset in webkit [113592] by
-
- 3 edits in trunk/LayoutTests
Fix layout test for r113584 on Qt and Mac
Unreviewed.
- fast/css/align-positioned-object-on-resize.html: Use layoutTestController.display() so that window.resizeTo() is honoured on all DRTs.
- platform/qt/Skipped: Unskip the above test.
- 10:36 AM Changeset in webkit [113591] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: zoom on vertical mousewheel in Timeline overview
https://bugs.webkit.org/show_bug.cgi?id=83379
Reviewed by Pavel Feldman.
- added support for zooming around mouse cursor upon mousewheel event;
- handle mousewheel event by _onMouseWheel, not scrollWindow, so we only zoom on events internal to overview.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):
(WebInspector.TimelineOverviewWindow.prototype._zoom):
- 10:26 AM Changeset in webkit [113590] by
-
- 3 edits in branches/subpixellayout/Source/WebCore
Fix a bug in calculating pixelSnappedClientWidth/Height (thanks Julien), and cleaning up some style errors in LayoutTypes and Length.
- 10:17 AM Changeset in webkit [113589] by
-
- 10 edits in trunk
Cross-origin preflight request should not include credentials.
https://bugs.webkit.org/show_bug.cgi?id=37676
Source/WebCore:
Modifies createAccessControlPreflightRequest so it never allows credentials.
Reviewed by Adam Barth.
http/tests/xmlhttprequest/access-control-preflight-credential-sync.html
http/tests/xmlhttprequest/access-control-preflight-credential-async.html
- loader/CrossOriginAccessControl.cpp:
(WebCore::createAccessControlPreflightRequest):
- loader/CrossOriginAccessControl.h:
(WebCore):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
LayoutTests:
Modifies preflight credential tests to make sure that cookies aren't sent along with the
CORS prefetch request.
Reviewed by Adam Barth.
- http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt:
- http/tests/xmlhttprequest/access-control-preflight-credential-async.html:
- http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt:
- http/tests/xmlhttprequest/access-control-preflight-credential-sync.html:
- http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php:
- 10:01 AM Changeset in webkit [113588] by
-
- 25 edits in trunk/Source/WebCore
Don't expose internal CSSValues in API
https://bugs.webkit.org/show_bug.cgi?id=83426
Reviewed by Andreas Kling.
The CSSValues returned from functions like CSSStyleDeclaration.getPropertyCSSValue() are currently
the same instances we use internally. This creates various problems. The values can't be shared between
documents as the wrappers would be shared too. Having to maintain per-document CSSValuePools complicate
the architecture and increase memory usage. This also blocks sharing style sheet data structures
between documents.
This patch adds a concept of CSSOM-safe CSSValue. Only the safe values can be wrapped for JS access.
Values are unsafe by default. The CSSOM functions that return CSSValues create safe instances by
cloning the internal values.
The use of APIs that return CSSValues is very rare (the currect CSSOM draft deprecates them) and
cloning is cheap in any case. Future patches will eliminate the per-document value pool in favor
of a global one for a memory win.
In the future we want to replace internally used CSSValues with true internal types (StyleValues) and
use CSSValues exclusively as wrappers (similar to how CSSStyleRule wraps internal StyleRule).
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValueInternal):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::CSSImageSetValue):
(WebCore):
(WebCore::CSSImageSetValue::cloneForCSSOM):
- css/CSSImageSetValue.h:
(CSSImageSetValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cleanup):
Opportunistically fix a string leak for CSS_COUNTER_NAME values.
Add all cases, remove default.
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore):
- css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::setCSSOMSafe):
- css/CSSValue.cpp:
(WebCore):
(TextCloneCSSValue):
(WebCore::TextCloneCSSValue::create):
(WebCore::TextCloneCSSValue::cssText):
(WebCore::TextCloneCSSValue::TextCloneCSSValue):
Most non-primitive value types are not exposed in CSSOM. For those we create a dummy value
that contains only the data that is accessible though the base CSSValue interface.
(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
- css/CSSValue.h:
(WebCore):
(CSSValue):
(WebCore::CSSValue::isCSSOMSafe):
(WebCore::CSSValue::isSubtypeExposedToCSSOM):
(WebCore::CSSValue::CSSValue):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList):
(WebCore):
(WebCore::CSSValueList::cloneForCSSOM):
- css/CSSValueList.h:
(CSSValueList):
- css/Counter.h:
(Counter):
(WebCore::Counter::cloneForCSSOM):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(WebCore):
(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):
Maintain a map of safe CSSValues so we can maintain object identity.
- css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(PropertySetCSSStyleDeclaration):
- css/RGBColor.cpp:
(WebCore::RGBColor::red):
(WebCore::RGBColor::green):
(WebCore::RGBColor::blue):
(WebCore::RGBColor::alpha):
- css/Rect.h:
(WebCore::RectBase::RectBase):
(RectBase):
(Rect):
(WebCore::Rect::cloneForCSSOM):
(WebCore::Rect::Rect):
(Quad):
(WebCore::Quad::cloneForCSSOM):
(WebCore::Quad::Quad):
- css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
(WebCore):
(WebCore::WebKitCSSFilterValue::cloneForCSSOM):
- css/WebKitCSSFilterValue.h:
(WebKitCSSFilterValue):
- css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):
(WebCore):
(WebCore::WebKitCSSTransformValue::cloneForCSSOM):
- css/WebKitCSSTransformValue.h:
(WebKitCSSTransformValue):
- svg/SVGColor.cpp:
(WebCore::SVGColor::SVGColor):
(WebCore):
(WebCore::SVGColor::cloneForCSSOM):
- svg/SVGColor.h:
(SVGColor):
- svg/SVGPaint.cpp:
(WebCore::SVGPaint::SVGPaint):
(WebCore):
(WebCore::SVGPaint::cloneForCSSOM):
- svg/SVGPaint.h:
(SVGPaint):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
- 9:44 AM Changeset in webkit [113587] by
-
- 34 edits1 add1 delete in trunk
Web Inspector: get rid of WebInspector.Resource.category, use WebInspector.Resource.type instead.
https://bugs.webkit.org/show_bug.cgi?id=83467
Reviewed by Yury Semikhatsky.
Source/WebCore:
WebInspector.Resource.category is derived from the WebInspector.Resource.type and there is no real need it maintaining both.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype._onResourceStarted):
(WebInspector.AuditLauncherView.prototype._onResourceFinished):
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CombineJsResourcesRule):
(WebInspector.AuditRules.CombineCssResourcesRule):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.CacheControlRule.prototype.isCompressible):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModelResourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerStyleSheetChanged):
- inspector/front-end/ContentProviders.js:
(WebInspector.ResourceContentProvider):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModelResourceBinding):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._getPopoverAnchor):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._makeResource):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems):
(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):
- inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.registerDomainModelBinding):
(WebInspector.Resource.prototype.set type):
(WebInspector.Resource.prototype.isEditable):
(WebInspector.Resource.prototype.setContent):
(WebInspector.Resource.prototype.requestContent):
- inspector/front-end/ResourceCategory.js: Removed.
- inspector/front-end/ResourcePreviewView.js:
(WebInspector.ResourcePreviewView.prototype._createPreviewView):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
- inspector/front-end/ResourceType.js: Added.
(WebInspector.ResourceType):
(WebInspector.ResourceType.prototype.name):
(WebInspector.ResourceType.prototype.title):
(WebInspector.ResourceType.prototype.categoryTitle):
(WebInspector.ResourceType.prototype.color):
(WebInspector.ResourceType.prototype.isTextType):
(WebInspector.ResourceType.prototype.toString):
- inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.hasTextContent):
(WebInspector.ResourceView.nonSourceViewForResource):
(WebInspector.EditableResourceSourceFrame.prototype.canEditSource):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.appendResource):
(WebInspector.FrameResourceTreeElement):
(WebInspector.FrameResourceTreeElement.prototype.onattach):
(WebInspector.ResourceRevisionTreeElement):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
- http/tests/inspector/network/async-xhr-json-mime-type-expected.txt:
- http/tests/inspector/network/network-iframe-load-and-delete-expected.txt:
- http/tests/inspector/network/network-xhr-async-expected.txt:
- http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
- http/tests/inspector/network/network-xhr-sync-expected.txt:
- http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html:
- http/tests/inspector/resource-tree/resource-tree-mimetype.html:
- http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourceTreeEverything):
(initialize_ResourceTreeTest):
- inspector/debugger/raw-source-code.html:
- 9:37 AM Changeset in webkit [113586] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, adding a missing header for the Qt port.
- Target.pri:
- 9:35 AM Changeset in webkit [113585] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [network panel] type column shows "undefined" instead of "(Pending)" upon load.
https://bugs.webkit.org/show_bug.cgi?id=83470
Reviewed by Yury Semikhatsky.
isPingRequest is tested for as a field, not a function return value.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
- 9:34 AM Changeset in webkit [113584] by
-
- 4 edits2 adds in trunk
REGRESSION (r94492): Incorrect initial layout of absolutely positioned <input> inside centering div
https://bugs.webkit.org/show_bug.cgi?id=77754
Reviewed by David Hyatt.
Source/WebCore:
The correct static position of an center-aligned, inline, absolutely positioned object with a block child can't be known
until the width of the child has been computed. This means that setStaticPositions() in RenderBlockLineLayout is setting
the position too early, before the width of the child has been finalised. To fix, adjust the static position of the inline
positioned object once its child's width has been calculated.
Test: fast/css/align-positioned-object-on-resize.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutPositionedObjects):
LayoutTests:
- fast/css/align-positioned-object-on-resize-expected.txt: Added.
- fast/css/align-positioned-object-on-resize.html: Added.
- platform/qt/Skipped: Skipped on Qt as window.resizeTo() does not work properly in Qt DRT.
- 9:12 AM Changeset in webkit [113583] by
-
- 3 edits3 adds in trunk
WebVTT parser unnecessarily limits the value of a timestamp
https://bugs.webkit.org/show_bug.cgi?id=83422
Reviewed by Dan Bernstein.
Source/WebCore:
Test: media/track/track-large-timestamp.html
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::collectTimeStamp): Make all constants double instead of int so
the maximum number of hours is increased and so we don't need any casts.
LayoutTests:
- media/track/captions-webvtt/large-timestamp.vtt: Added.
- media/track/track-large-timestamp-expected.txt: Added.
- media/track/track-large-timestamp.html: Added.
- 9:05 AM Changeset in webkit [113582] by
-
- 1340 edits267 copies76 deletes in branches/subpixellayout
Merge trunk changes up until 113577 into subpixel branch.
- 9:03 AM Changeset in webkit [113581] by
-
- 15 edits12 adds in trunk
Incorrect placement of new child to table when before child parent is not |this|.
https://bugs.webkit.org/show_bug.cgi?id=82630
Reviewed by Julien Chaffraix.
Source/WebCore:
Tests: fast/table/table-row-split2.html
fast/table/table-section-split2.html
fast/table/table-split.html
fast/table/table-split2.html
and tested by layouttests in commits r97180, r108127, and a few others.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks): function rename, block->box.
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks): ditto.
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): ditto.
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::moveChildTo): move these functions from RenderBlock, needs to be
used in RenderBox::splitAnonymousBoxesAroundChild.
(WebCore):
(WebCore::RenderBox::moveChildrenTo): ditto.
(WebCore::markBoxForRelayoutAfterSplit): helper to mark a block or table part for complete relayout
after anonymous boxes are split around child.
(WebCore::RenderBox::splitAnonymousBoxesAroundChild): moved from RenderBlock to be able
to work with table parts.
- rendering/RenderBox.h:
(RenderBox):
(WebCore::RenderBox::moveChildTo):
(WebCore::RenderBox::moveAllChildrenTo):
(WebCore::RenderBox::moveChildrenTo):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild): no longer need the hack added in r95461.
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveChildren): function rename, block->box.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild): Use splitAnonymousBoxesAroundChild function when |beforeChild| != |this|.
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild): ditto.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild): ditto.
LayoutTests:
- fast/table/cell-in-row-before-misnested-text-crash-css-expected.txt: rebaseline, corrects layout.
- fast/table/cell-in-row-before-misnested-text-crash-expected.txt: rebaseline, corrects layout.
- fast/table/row-in-tbody-before-misnested-text-crash-css-expected.txt: rebaseline, corrects layout.
- fast/table/row-in-tbody-before-misnested-text-crash-expected.txt: rebaseline, corrects layout.
- fast/table/table-row-split2-expected.png: Added.
- fast/table/table-row-split2-expected.txt: Added.
- fast/table/table-row-split2.html: Added.
- fast/table/table-section-split2-expected.png: Added.
- fast/table/table-section-split2-expected.txt: Added.
- fast/table/table-section-split2.html: Added.
- fast/table/table-split-expected.png: Added.
- fast/table/table-split-expected.txt: Added.
- fast/table/table-split.html: Added.
- fast/table/table-split2-expected.png: Added.
- fast/table/table-split2-expected.txt: Added.
- fast/table/table-split2.html: Added.
- 8:52 AM PrefixedAPIs edited by
- (diff)
- 8:51 AM PrefixedAPIs edited by
- Added IndexedDB links (diff)
- 8:31 AM Changeset in webkit [113580] by
-
- 2 edits in trunk/Source/WebCore
WebSocketServer: Honour WebSocketFrame::masked in makeFrameData
https://bugs.webkit.org/show_bug.cgi?id=83042
Reviewed by Kent Tamura.
Frames from the server should not be masked.
Currently, the flag is set to false, but the frames were masked anyway.
This causes clients with recent builds of WebKit to abort the connection to the
inspector server, refusing masked frames from the server as per the spec.
This doesn't change the behavior of WebSocket clients, which set the masked flag to true.
- Modules/websockets/WebSocketFrame.cpp:
(WebCore::appendFramePayload):
(WebCore::WebSocketFrame::makeFrameData):
- 8:29 AM Changeset in webkit [113579] by
-
- 2 edits in trunk/LayoutTests
Layout Test in svg are failing
https://bugs.webkit.org/show_bug.cgi?id=82232
Unreviewed Chromium expectations update.
All the tests covered by this bug ran without crashes over a five day
period. Given the previous crash rates, this suggests we've fixed the
problem.
- platform/chromium/test_expectations.txt:
- 7:59 AM Changeset in webkit [113578] by
-
- 2 edits in branches/subpixellayout/Source/WebCore/rendering
Revert abs changes from 113447 on branch as it broke linux builds.
- 6:43 AM Changeset in webkit [113577] by
-
- 10 edits in trunk/Source/WebCore
[Part 5] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83466
Reviewed by Kentaro Hara.
CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers, this patch should adress the last remaining occurences of ints rather than CSSPropertyIDs.
No new tests : There should be no behavior change in this patch.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::removePropertiesInSet):
- page/animation/AnimationBase.cpp:
(WebCore::gatherEnclosingShorthandProperties):
(WebCore::AnimationBase::animatableShorthandsAffectingProperty):
- page/animation/AnimationBase.h:
(AnimationBase):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::pauseTransitionAtTime):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::getAnimatedStyle):
(WebCore::KeyframeAnimation::overrideAnimations):
(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
(WebCore::KeyframeAnimation::timeToNextService):
- rendering/style/KeyframeList.cpp:
(WebCore::KeyframeList::insert):
- rendering/style/KeyframeList.h:
(WebCore::KeyframeValue::addProperty):
(WebCore::KeyframeValue::containsProperty):
(WebCore::KeyframeValue::properties):
(KeyframeValue):
(WebCore::KeyframeList::addProperty):
(WebCore::KeyframeList::containsProperty):
(WebCore::KeyframeList::beginProperties):
(WebCore::KeyframeList::endProperties):
(KeyframeList):
- 6:34 AM Changeset in webkit [113576] by
-
- 11 edits in trunk/Source/WebCore
Unreviewed, rebaselined run-bindings-tests results.
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertyDescriptor):
(WebCore::jsFloat64ArrayConstructor):
(WebCore::JSFloat64Array::getConstructor):
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
(WebCore::toFloat64Array):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::getOwnPropertySlot):
(WebCore::JSTestActiveDOMObjectConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
(WebCore::JSTestActiveDOMObject::getConstructor):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
(WebCore::JSTestActiveDOMObjectOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestActiveDOMObjectOwner::finalize):
(WebCore::toTestActiveDOMObject):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetter::getConstructor):
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
(WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomNamedGetterOwner::finalize):
(WebCore::toTestCustomNamedGetter):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorConstructor):
(WebCore::JSTestEventConstructor::getConstructor):
(WebCore::JSTestEventConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventConstructorOwner::finalize):
(WebCore::toTestEventConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::getOwnPropertySlot):
(WebCore::JSTestEventTargetConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestEventTargetConstructor):
(WebCore::JSTestEventTarget::getConstructor):
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
(WebCore::JSTestEventTarget::indexGetter):
(WebCore::JSTestEventTargetOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventTargetOwner::finalize):
(WebCore::toTestEventTarget):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::jsTestInterfaceSupplementalNode):
(WebCore::jsTestInterfaceConstructor):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalNode):
(WebCore::JSTestInterface::getConstructor):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod1):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod3):
(WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestInterfaceOwner::finalize):
(WebCore::toTestInterface):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListener::getConstructor):
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
(WebCore::JSTestMediaQueryListListenerOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):
(WebCore::toTestMediaQueryListListener):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
(WebCore::jsTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructor::getConstructor):
(WebCore::JSTestNamedConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestNamedConstructorOwner::finalize):
(WebCore::toTestNamedConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::getOwnPropertySlot):
(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestObjConstructor::constructJSTestObj):
(WebCore::jsTestObjReadOnlyIntAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjShortAttr):
(WebCore::jsTestObjUnsignedShortAttr):
(WebCore::jsTestObjIntAttr):
(WebCore::jsTestObjLongLongAttr):
(WebCore::jsTestObjUnsignedLongLongAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::jsTestObjSequenceAttr):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::jsTestObjCreate):
(WebCore::jsTestObjReflectedStringAttr):
(WebCore::jsTestObjReflectedIntegralAttr):
(WebCore::jsTestObjReflectedUnsignedIntegralAttr):
(WebCore::jsTestObjReflectedBooleanAttr):
(WebCore::jsTestObjReflectedURLAttr):
(WebCore::jsTestObjReflectedCustomIntegralAttr):
(WebCore::jsTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjReflectedCustomURLAttr):
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjAttrWithSetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithSetterException):
(WebCore::jsTestObjCustomAttr):
(WebCore::jsTestObjWithScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjMutablePoint):
(WebCore::jsTestObjImmutablePoint):
(WebCore::jsTestObjStrawberry):
(WebCore::jsTestObjStrictFloat):
(WebCore::jsTestObjDescription):
(WebCore::jsTestObjId):
(WebCore::jsTestObjHash):
(WebCore::jsTestObjConstructor):
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjIntAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjCustomAttr):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjStrictFloat):
(WebCore::setJSTestObjId):
(WebCore::JSTestObj::getConstructor):
(WebCore::jsTestObjPrototypeFunctionVoidMethod):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethod):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethod):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithException):
(WebCore::jsTestObjPrototypeFunctionCustomMethod):
(WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefined):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod1):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod2):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongArray):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionMutablePointFunction):
(WebCore::jsTestObjPrototypeFunctionImmutablePointFunction):
(WebCore::jsTestObjPrototypeFunctionOrange):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
(WebCore::JSTestObjOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestObjOwner::finalize):
(WebCore::toTestObj):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfaceValue):
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceConstructor):
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):
(WebCore::JSTestSerializedScriptValueInterface::getConstructor):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
(WebCore::toTestSerializedScriptValueInterface):
- 6:24 AM Changeset in webkit [113575] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Upstream BlackBerry change to WebCore::TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=83454
Reviewed by Rob Buis.
BlackBerry-port enhances the TouchEvent by adding member variables
to indicate if the event is double-tap or touch-hold.
- dom/TouchEvent.cpp:
(WebCore::TouchEvent::TouchEvent):
(WebCore::TouchEvent::initTouchEvent):
- dom/TouchEvent.h:
(TouchEvent):
(WebCore::TouchEvent::setDoubleTap):
(WebCore::TouchEvent::isDoubleTap):
(WebCore::TouchEvent::setTouchHold):
(WebCore::TouchEvent::isTouchHold):
- 6:20 AM PrefixedAPIs edited by
- CSS Properties added sourced from CSSProperty::isInheritedProperty (diff)
- 5:35 AM Changeset in webkit [113574] by
-
- 4 edits in trunk
[CMake] Build fix for USE_SYSTEM_MALLOC after r113570.
.:
- Source/cmakeconfig.h.cmake:
Source/WTF:
- wtf/CMakeLists.txt:
- 4:42 AM Changeset in webkit [113573] by
-
- 10 edits3 deletes in trunk
Remove partially implemented per-Element visibility checks from requestAnimationFrame logic
https://bugs.webkit.org/show_bug.cgi?id=74232
Patch by James Robinson <jamesr@chromium.org> on 2012-04-09
Reviewed by Dean Jackson.
Source/WebCore:
The initial requestAnimationFrame implementation had an Element parameter as the second argument to the
function. This element was intended to convey the element associated with the animation so that when the element
was not visible the animation callback would not be run. The checked in implementation does a very limited check
- testing for display:none and being detached from the tree - but does it in a way that does not work correctly
if an element's visibility is manipulated by a callback running from a different document. It also adds
significant complexity to the code, making it less hackable and easy to introduce subtle security bugs or
infinite loops.
This patch removes the parameter. Since it has always been marked optional, there is no web compat risk.
If this functionality is added back in the future it needs to be implemented in a way that considers all
callbacks within a Page and not only those within a single Document.
- dom/Document.cpp:
(WebCore::Document::webkitRequestAnimationFrame):
- dom/Document.h:
- dom/RequestAnimationFrameCallback.h:
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
- dom/ScriptedAnimationController.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitRequestAnimationFrame):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
Remove tests for removed functionality.
- fast/animation/request-animation-frame-display-expected.txt: Removed.
- fast/animation/request-animation-frame-display.html: Removed.
- fast/animation/script-tests/request-animation-frame-display.js: Removed.
- 3:58 AM Changeset in webkit [113572] by
-
- 2 edits in trunk/Tools
Build fix for WinCE after r113570.
- Scripts/build-webkit: Do not use FastMalloc for WinCE.
- 3:49 AM Changeset in webkit [113571] by
-
- 8 edits in trunk/Source
Remove HAVE_STDINT_H
https://bugs.webkit.org/show_bug.cgi?id=83434
Reviewed by Kentaro Hara.
HAVE_STDINT_H is defined with 1 all the time and we us stdint.h without HAVE(STDINT_H) already.
Source/JavaScriptCore:
- config.h:
Source/WTF:
- config.h:
- wtf/FastMalloc.cpp:
- wtf/TCPageMap.h:
- wtf/TCSpinLock.h:
- wtf/TCSystemAlloc.cpp:
- 3:45 AM Changeset in webkit [113570] by
-
- 7 edits in trunk
[CMake] Share build system options across ports
https://bugs.webkit.org/show_bug.cgi?id=72815
Reviewed by Daniel Bates.
Don't define the generic features for every port again.
Add a few macros for reusing the central defined options.
- CMakeLists.txt:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
- Source/cmake/WebKitFeatures.cmake:
- 3:33 AM Changeset in webkit [113569] by
-
- 2 edits in trunk/Source/WebCore
[Blackberry] m_isRequestedByPlugin should be copied in ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=83447
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-04-09
Reviewed by George Staikos.
It is an obvious error, We should copy m_isRequestedByPlugin in ResourceReuest.
No new tests, because those existing plugin test cases are enough.
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):
- 3:19 AM Changeset in webkit [113568] by
-
- 2 edits in trunk/Tools
Subscribe eric.carlson@apple.com to Media-related changes
https://bugs.webkit.org/show_bug.cgi?id=83421
Reviewed by Dan Bernstein.
- Scripts/webkitpy/common/config/watchlist:
- 3:02 AM Changeset in webkit [113567] by
-
- 2 edits in trunk/LayoutTests
Layout Test http/tests/media/media-document.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=83391
[Chromium] Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 2:50 AM Changeset in webkit [113566] by
-
- 2 edits in trunk/LayoutTests
several http tests are flaky and crashing on win, debug
https://bugs.webkit.org/show_bug.cgi?id=82505
Remove the expectations of a crash now that the fix (http://crrev.com/131170)
has rolled into webkit in http://trac.webkit.org/changeset/113512
Reviewed by Tony Chang.
- platform/chromium/test_expectations.txt:
- 2:48 AM Changeset in webkit [113565] by
-
- 3 edits in trunk/Tools
check-webkit-style should ignore NULL usage in gtk_style_context_get_style
https://bugs.webkit.org/show_bug.cgi?id=83412
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by David Levin.
Accept NULL as an argument for gtk_style_context_get_style, because it's
used as a sentinel in a variable argument list.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_for_null): Add an exception.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_null_false_zero): Add a test for the exception.
- 2:42 AM Changeset in webkit [113564] by
-
- 3 edits in trunk/Source/WebCore
Not reviewed: fixing inspector front-end compilation that has been broken by the
recent SaveAs and DOMStorage changes.
- inspector/front-end/DOMStorage.js:
- inspector/front-end/externs.js:
(WebInspector.isURLSaved):
- 2:39 AM Changeset in webkit [113563] by
-
- 15 edits2 deletes in trunk
Web Inspector: remove ComboBoxFileSelector and SingleFileEditorContainer.
https://bugs.webkit.org/show_bug.cgi?id=83460
Reviewed by Yury Semikhatsky.
Source/WebCore:
We are now using scripts navigator and tabbed editor container, removing the old components.
This change removes the corresponding classes and the abstractions used during the
transition period.
- English.lproj/localizedStrings.js:
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._scriptSelected):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.get this):
(WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
(WebInspector.ScriptsPanel.prototype._hidePinnedNavigator):
(WebInspector.ScriptsPanel.prototype.set _pinNavigator):
- inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainerDelegate):
(WebInspector.TabbedEditorContainerDelegate.prototype.viewForFile):
(get WebInspector):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
- inspector/front-end/scriptsPanel.css:
LayoutTests:
- inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Removed.
- inspector/debugger/scripts-combobox-file-selector-history.html: Removed.
- inspector/debugger/scripts-file-selector-expected.txt:
- inspector/debugger/scripts-file-selector.html:
- inspector/debugger/scripts-panel-expected.txt:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- inspector/debugger/source-frame-count.html:
- 2:22 AM Changeset in webkit [113562] by
-
- 2 edits in trunk/Tools
webkitpy: use the filesystem object properly in fileuploader
https://bugs.webkit.org/show_bug.cgi?id=83326
Reviewed by Adam Barth.
We should be using the filesystem object rather than the codecs
object.
- Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.upload_as_multipart_form_data):
- 2:05 AM Changeset in webkit [113561] by
-
- 5 edits in trunk/Source
[chromium] Make culling work with clipped rects
https://bugs.webkit.org/show_bug.cgi?id=83217
Patch by Dana Jansens <danakj@chromium.org> on 2012-04-09
Reviewed by Adrienne Walker.
Source/WebCore:
Use new CCMathUtil transformation methods to deal with rects that clip
the camera plane. This fixes three things:
- A layer completely behind the camera is not visible and should not
occlude.
- A layer that is clipped by the camera is treated like a
non-axis-aligned transform, as the result of a mapClippedRect() is a
bounding box and may contain pixels not in the original rect. This guards
our use of mapRect() when transforming occluded regions.
- A layer's occlusion must be clipped by its scissor rect. This scissor
rect exists in its target space, so occlusion in screen space is only
possible if its target also is axis aligned in the screen, such that
the layer's scissor rect remains a rect in screen space.
Unit tests: CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude
CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
- tests/CCQuadCullerTest.cpp:
(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
- 1:49 AM Changeset in webkit [113560] by
-
- 2 edits in trunk/Source/WebCore
[Gtk] Web Inspector noinst_DATA images are copied into innacurately named directory
https://bugs.webkit.org/show_bug.cgi?id=83423
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-09
Reviewed by Martin Robinson.
Copy Web Inspector images that are a part of the data not meant
for installation into a directory named 'Images' rather than
a lower-case version of that. This is required as until now,
when using these inspector resources (for example during layout
tests or manually pointing WEBKIT_INSPECTOR_PATH env to that
location), the images were not displayed as they were not loadable.
No new tests - no new functionality.
- GNUmakefile.am:
- 12:55 AM Changeset in webkit [113559] by
-
- 3 edits in trunk/Tools
Enable webkit_unit_tests for commit queue and EWS while tracking failures
https://bugs.webkit.org/show_bug.cgi?id=83329
Unreviewed. Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
line 62, in _create_unit_test_results
return UnitTestResults.results_from_string(results_xml)
NameError: global name 'UnitTestResults' is not defined
- Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
- Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_create_unit_test_results):
- 12:50 AM Changeset in webkit [113558] by
-
- 7 edits in trunk
Web Inspector: move breakpoints active state from scripts panel to debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=83374
Reviewed by Yury Semikhatsky.
Source/WebCore:
Just moves the state and adds event to propagate it. This is needed to abstract
JavaScriptSourceFrame from the ScriptsPanel.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointsActive):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsActive):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
(WebInspector.ScriptsPanel.prototype._breakpointsActiveStateChanged):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
LayoutTests:
- http/tests/inspector/debugger-test.js:
- inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
- 12:48 AM Changeset in webkit [113557] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG should not load the property storage if it is inline.
https://bugs.webkit.org/show_bug.cgi?id=83455
Reviewed by Gavin Barraclough.
We had previously decided to have all property storage accesses go through
the property storage pointer even if they don't "really" have to, because
we were thinking this would help GC barriers somehow. Well, we never ended
up doing anything with that. Hence, doing these wasted loads of the
property storage pointer when the storage is inline is just a waste of CPU
cycles.
This change makes the DFG's inline property accesses (GetByOffset and
PutByOffset) go directly to the inline property storage if the structure(s)
tell us that it's OK.
This looks like an across-the-board 1% win.
- bytecode/StructureSet.h:
(JSC):
(JSC::StructureSet::allAreUsingInlinePropertyStorage):
(StructureSet):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillStorage):
Apr 8, 2012:
- 10:25 PM Changeset in webkit [113556] by
-
- 2 edits in trunk/Source/WebKit/mac
[mac] REGRESSION (r113467): Some canvas tests are failing in WebKit1 when run after compositing/tiled-layers-hidpi.html
https://bugs.webkit.org/show_bug.cgi?id=83453
Reviewed by Sam Weinig.
- WebView/WebView.mm:
(-[WebView _setCustomBackingScaleFactor:]): When the scale factor parameter was 0, meaning
no custom scale factor, this method was setting the Page scale factor to 0, and that value
was used by canvas. Changed it to correctly set the Page scale factor back to the device
scale factor.
- 9:59 PM Changeset in webkit [113555] by
-
- 4 edits in trunk
<content> in <meter> is not rendered correctly.
https://bugs.webkit.org/show_bug.cgi?id=81311
This code changes a code location where MeterValueElement's value
attribute is initialized. In the old code, HTMLMeterElement's attach
did. It is better to initialize the attribute just after creating
meter's shadow subtree.
Patch by Takashi Sakamoto <tasak@google.com> on 2012-04-08
Reviewed by Hajime Morita.
No new tests, because an existing test,
content-element-in-meter-element.html covers.
However test_expectations.txt is changed. Now the test passes.
- html/HTMLMeterElement.cpp:
- html/HTMLMeterElement.h:
(HTMLMeterElement):
(HTMLMeterElement::attach):
Removed attach method, because attach method is just calling
LabelableElement::attach after removing didElementStateChange.
(HTMLMeterElement::createShadowSubTree):
Added setWidthPercentage to initialize MeterValueElement's value
attribute.
- LayoutTests/platform/chromium/test_expectations.txt:
Removed BUGWK81311 fast/dom/shadow/content-element-in-meter.html,
because now contentElementInMeterElement passes.
- 9:04 PM Changeset in webkit [113554] by
-
- 2 edits in trunk/Tools
The port object is missing unit_tests_results_path
https://bugs.webkit.org/show_bug.cgi?id=83448
Unreviewed.
This is causing the cr-linux-ews to throw an exception.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.unit_tests_results_path):
- 1:50 PM Changeset in webkit [113553] by
-
- 2 edits in trunk/Source/JavaScriptCore
Command-line jsc's exception handling should be rationalized
https://bugs.webkit.org/show_bug.cgi?id=83437
Reviewed by Dan Bernstein.
- If an exception is thrown during run() execution, it is now propagated, so that it will terminate program execution unless it is caught.
- If program execution terminates with an exception, the exception is now always printed.
- When printing the exception, the backtrace is now also printed if one is available. It will only not be available if you use something akin to my favorite line of code, 'throw "error"', since primitives don't have properties and hence we cannot attach a "stack" property to them.
- jsc.cpp:
(functionRun):
(runWithScripts):
- 1:46 PM Changeset in webkit [113552] by
-
- 14 edits in trunk/Source/JavaScriptCore
Forced OSR exits should lead to recompilation based on count, not rate
https://bugs.webkit.org/show_bug.cgi?id=83247
<rdar://problem/10720925>
Reviewed by Geoff Garen.
Track which OSR exits happen because of inadequate coverage. Count them
separately. If the count reaches a threshold, immediately trigger
reoptimization.
This is in contrast to the recompilation trigger for all other OSR exits.
Normally recomp is triggered when the exit rate exceeds a certain ratio.
Looks like a slight V8 speedup (sub 1%).
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::forcedOSRExitCounter):
(JSC::CodeBlock::addressOfForcedOSRExitCounter):
(JSC::CodeBlock::offsetOfForcedOSRExitCounter):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):
(CodeBlock):
- bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
- dfg/DFGOSRExitCompiler.cpp:
(JSC::DFG::OSRExitCompiler::handleExitCounts):
(DFG):
- dfg/DFGOSRExitCompiler.h:
(OSRExitCompiler):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
- runtime/Options.h:
(Options):
- 1:38 PM PrefixedAPIs edited by
- (diff)
- 11:35 AM Changeset in webkit [113551] by
-
- 2 edits in trunk/Source/WebCore
Build fix for !ENABLE(CSS_FILTERS) && ASSERT_DISABLED after r109953.
- platform/graphics/ca/GraphicsLayerCA.cpp:
