Timeline
Apr 26, 2012:
- 11:45 PM Changeset in webkit [115409] by
-
- 3 edits2 adds in trunk
REGRESSION (r94497): Pressing Command+A when inline (Marked Text) is not empty will clean whole content
https://bugs.webkit.org/show_bug.cgi?id=84501
Reviewed by Alexey Proskuryakov.
Source/WebCore:
The bug was caused by setComposition, which is called by cancelComposition, deleting the contents when
the passed text is empty. Fixed it by not deleting text when canceling compositions. This is okay because
as the comment above the line suggests, this particular call to TypingCommand::deleteSelection is only useful
when the confirmed text is empty and the composition text had previously been non-empty.
Test: editing/input/select-all-clear-input-method.html
- editing/Editor.cpp:
(WebCore::Editor::setComposition):
LayoutTests:
Add a regression test for selecting all when there is a composition text.
- editing/input/select-all-clear-input-method-expected.txt: Added.
- editing/input/select-all-clear-input-method.html: Added.
- 11:11 PM Changeset in webkit [115408] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed morning gardening, skip a new failing test.
- platform/qt/Skipped:
- 9:04 PM Changeset in webkit [115407] by
-
- 4 edits2 adds in trunk
datalist: Form control in a <datalist> should be barred from constraint validation
https://bugs.webkit.org/show_bug.cgi?id=84359
Source/WebCore:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-datalist-element
According to this, if an element has a datalist element ancestor, it is barred from constraint validation.
Reviewed by Kent Tamura.
Test: fast/forms/datalist/datalist-child-validation.html
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::updateAncestors): Updates the ancestor information.
(WebCore::HTMLFormControlElement::insertedInto): Invalidates the ancestor information and calls setNeedsWillValidateCheck
(WebCore::HTMLFormControlElement::removedFrom): Invalidates the ancestor information and calls setNeedsWillValidateCheck
(WebCore::HTMLFormControlElement::disabled):
(WebCore::HTMLFormControlElement::recalcWillValidate): Returns false if element has a datalist ancestor.
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): Check if ancestor information is valid too.
- html/HTMLFormControlElement.h:
(HTMLFormControlElement):
LayoutTests:
Reviewed by Kent Tamura.
- fast/forms/datalist/datalist-child-validation-expected.txt: Added.
- fast/forms/datalist/datalist-child-validation.html: Added. Tests that willValidate changes from false to true when we move the element out of the datalist.
- 8:51 PM Changeset in webkit [115406] by
-
- 2 edits in trunk/Source/WTF
Don't define WTF_COMPILER_SUPPORTS_CXX_NULLPTR twice when building with clang on windows.
https://bugs.webkit.org/show_bug.cgi?id=85018
Reviewed by Anders Carlsson.
Clang sets _MSC_VER when compiling for a -pc-win32 target (just like it sets GNUC on unix).
As a result, WTF_COMPILER_SUPPORTS_CXX_NULLPTR gets currently set twice, once for clang and
once for _MSC_VER. Guard the second instance with !COMPILER(CLANG). This matches the gcc code
for WTF_COMPILER_SUPPORTS_CXX_NULLPTR in the same file.
- wtf/Compiler.h:
- 8:35 PM Changeset in webkit [115405] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Remove unused CCLayerImpl::debugID()
https://bugs.webkit.org/show_bug.cgi?id=85019
Reviewed by James Robinson.
CCLayerSorter used debugID() but it was never set anywhere. Change
the CCLayerSorter LOG messages to use id(), which does get set.
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::createGraphNodes):
(WebCore::CCLayerSorter::createGraphEdges):
(WebCore::CCLayerSorter::sort):
- 8:32 PM Changeset in webkit [115404] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fix C++ language use.
https://bugs.webkit.org/show_bug.cgi?id=85015
Reviewed by James Robinson.
Even though MSVC allows it, a sizeof followed by a non-parenthesized
typename is not valid C++.
No functionality change.
- rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::getNonClientMetrics):
- 8:22 PM Changeset in webkit [115403] by
-
- 18 edits in trunk/Source
[chromium] Move ProgramBinding definitions to LayerRendererChromium and normalize naming
https://bugs.webkit.org/show_bug.cgi?id=84808
Reviewed by Adrienne Walker.
Source/WebCore:
The GL programs used are logically part of LayerRendererChromium and not something specific to a layer type,
since a different renderer would want to use a different thing to render the same layer types. This moves all of
the ProgramBinding definitions into LayerRendererChromium and gives them consistent names. With the exception of
CCRenderSurface (noted by an inline comment), these programs are private to LRC.
This patch also deduplicates programs a bit:
1.) Video's NativeTexture and RGBA programs were the same thing, folded.
2.) The TexStretch and TexTransform shaders are basically the same thing, folded together.
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::drawNativeTexture2D):
(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tileCheckerboardProgram):
(WebCore::LayerRendererChromium::solidColorProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgramAA):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgramAA):
(WebCore::LayerRendererChromium::tileProgram):
(WebCore::LayerRendererChromium::tileProgramOpaque):
(WebCore::LayerRendererChromium::tileProgramAA):
(WebCore::LayerRendererChromium::tileProgramSwizzle):
(WebCore::LayerRendererChromium::tileProgramSwizzleOpaque):
(WebCore::LayerRendererChromium::tileProgramSwizzleAA):
(WebCore::LayerRendererChromium::textureProgramFlip):
(WebCore::LayerRendererChromium::textureTexRectProgram):
(WebCore::LayerRendererChromium::textureTexRectProgramFlip):
(WebCore::LayerRendererChromium::videoRGBAProgram):
(WebCore::LayerRendererChromium::videoYUVProgram):
(WebCore::LayerRendererChromium::videoStreamTextureProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
(LayerRendererChromium):
- platform/graphics/chromium/ShaderChromium.cpp:
- platform/graphics/chromium/ShaderChromium.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(CCHeadsUpDisplay):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::copyTextureToFramebuffer):
(WebCore::CCRenderSurface::drawLayer):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
- platform/graphics/chromium/cc/CCTextureLayerImpl.h:
(CCTextureLayerImpl):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebCore):
(CCVideoLayerImpl):
Source/WebKit/chromium:
Add some includes needed by this test that were previously picked up by upstream headers.
- tests/CCLayerTreeHostImplTest.cpp:
- 8:16 PM Changeset in webkit [115402] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][WK2] A GraphicsSurface instance is created with every update
https://bugs.webkit.org/show_bug.cgi?id=85014
Reviewed by Kenneth Rohde Christiansen.
Keep a copy of the GraphicsSurface in the UI process, and reuse it for
subsequent updates. This ensure that the texture and other data associated
with the GraphicsSurface does not need to be reconstructed.
- Shared/ShareableSurface.h:
(Handle):
(WebKit::ShareableSurface::Handle::graphicsSurfaceToken):
- UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::updateTileForLayer):
- UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
- 8:08 PM Changeset in webkit [115401] by
-
- 1 edit in trunk/Source/WebCore/platform/ScrollView.cpp
Unreviewed amend to bug 84873 (r115345).
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollSize):
- 7:44 PM Changeset in webkit [115400] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Security: Autofill info can be captured by innocuous social engineering
Prevent users from interacting with invisible popups rendered outside the main frame's contents view.
https://bugs.webkit.org/show_bug.cgi?id=84420
https://code.google.com/p/chromium/issues/detail?id=122925
Reviewed by Kent Tamura.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::popupOpened): Hide popups rendered outside the main frame's contents view.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::applyAutofillSuggestions): Fix up order of operations to support immediately hiding a popup if it would not be visible
- 7:38 PM Changeset in webkit [115399] by
-
- 8 edits in branches/chromium/1084
Source/WebCore: Merge r115227, r115244, and r115302.
REGRESSION(r112177): listStyleType CSS property gets converted into listStyle
https://bugs.webkit.org/show_bug.cgi?id=83026
Reviewed by Darin Adler.
Fixed the bug by not using shorthand notations when some values are missing.
However, we still want to return a value when shorthand border property is explicitly
requested so extract borderPropertyValue with a flag to support both behaviors.
- css/StylePropertySet.cpp:
(WebCore::borderPropertyValue): Extracted from getPropertyValue.
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::get4Values): Don't return values when priority don't match.
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue): Don't return null string for initial values
to disambiguate missing values and "initial" in getPropertyValue. Also check propriety.
(WebCore::StylePropertySet::asText): Support emitting border-width, border-style, and
border-color when border doesn't work but the former properties do.
LayoutTests: REGRESSION(r112177): listStyleType CSS property gets converted into listStyle
https://bugs.webkit.org/show_bug.cgi?id=83026
Reviewed by Darin Adler.
Added test cases to cssText-shorthand.html and rebaselined some tests.
- fast/css/cssText-shorthand-expected.txt:
- fast/css/cssText-shorthand.html: Added more test cases.
- fast/css/remove-shorthand-expected.txt: Correctly adds both border-width and border-style
when border-color is missing.
- printing/page-rule-css-text-expected.txt: Correctly uses border-width instead of border.
- 7:35 PM Changeset in webkit [115398] by
-
- 3 edits2 adds in trunk
Invalid cast in WebCore::HTMLCollection::isAcceptableElement
https://bugs.webkit.org/show_bug.cgi?id=84626
Reviewed by Darin Adler.
Source/WebCore:
Check if the object is an HTMLElement before casting.
Test: fast/dom/htmlcollection-non-html.html
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::isAcceptableElement):
LayoutTests:
Add tests to make sure only HTML elements are present in most HTMLCollection objects.
- fast/dom/htmlcollection-non-html-option-expected.txt: Added.
- fast/dom/htmlcollection-non-html.html: Added.
- 7:17 PM Changeset in webkit [115397] by
-
- 5 edits in trunk/Source
[chromium] Some background filters require inflating damage on the surface behind them
https://bugs.webkit.org/show_bug.cgi?id=84479
Reviewed by Adrienne Walker.
Source/WebCore:
A layer with a background blur will expand the damage from pixels in the
surface below it. We extend the damage tracker to expand damage in a
surface below such layers.
Unit test: CCDamageTrackerTest.verifyDamageForBackgroundBlurredChild
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::expandPixelOutsetsWithFilters):
(WebCore):
(WebCore::expandDamageRectInsideRectWithFilters):
(WebCore::expandDamageRectWithFilters):
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::trackDamageFromActiveLayers):
- platform/graphics/chromium/cc/CCDamageTracker.h:
(CCDamageTracker):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
- 6:40 PM Changeset in webkit [115396] by
-
- 3 edits in trunk/Source/WebCore
Improve compositing logging output
https://bugs.webkit.org/show_bug.cgi?id=85010
Reviewed by Dean Jackson.
In the compositing log channel output, indent the layers
based on z-order tree depth. Tabulate the summary, and
show obligate and secondary backing store area separately.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateClipRects):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::reasonForCompositing):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 6:38 PM Changeset in webkit [115395] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r115163): Unable to scroll article body with trackpad on altdevblogaday.com blog post
https://bugs.webkit.org/show_bug.cgi?id=85024
<rdar://problem/11330758>
Reviewed by Sam Weinig.
Fix broken logic in canHaveScrollbars.
- page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::canHaveScrollbars):
- 6:24 PM Changeset in webkit [115394] by
-
- 9 edits2 copies in trunk/Source/WebCore
[chromium] Use different CCDrawQuad types for textures vs IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=84811
Reviewed by Adrienne Walker.
IOSurface and texture backed layers share few properties (only the flipped bool), so it doesn't make a lot of
sense for them to use the same CCDrawQuad type for both. This splits IOSurfaces out to a dedicated quad type to
make it easier to understand which bits of state apply to each.
The logical next step after this is to split the layer type as well, but that will be awkward until bug 84808 is
resolved.
- WebCore.gypi:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore):
(WebCore::LayerRendererChromium::drawIOSurfaceQuad):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::toIOSurfaceDrawQuad):
(WebCore):
- platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore):
(CCDrawQuad):
- platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureDrawQuad.cpp.
(WebCore):
(WebCore::CCIOSurfaceDrawQuad::create):
(WebCore::CCIOSurfaceDrawQuad::CCIOSurfaceDrawQuad):
- platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureDrawQuad.h.
(WebCore):
(CCIOSurfaceDrawQuad):
(WebCore::CCIOSurfaceDrawQuad::flipped):
(WebCore::CCIOSurfaceDrawQuad::ioSurfaceSize):
(WebCore::CCIOSurfaceDrawQuad::ioSurfaceTextureId):
- platform/graphics/chromium/cc/CCTextureDrawQuad.cpp:
(WebCore::CCTextureDrawQuad::create):
(WebCore::CCTextureDrawQuad::CCTextureDrawQuad):
- platform/graphics/chromium/cc/CCTextureDrawQuad.h:
(CCTextureDrawQuad):
- platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
(WebCore::CCTextureLayerImpl::appendQuads):
- 6:06 PM Changeset in webkit [115393] by
-
- 2 edits in trunk/Source/WebKit/chromium
Cleanup WebMediaPlayer enum values that didn't match Chromium style guidelines
https://bugs.webkit.org/show_bug.cgi?id=84998
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-26
Reviewed by Darin Fisher.
- public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::generateKeyRequest):
(WebKit::WebMediaPlayer::addKey):
(WebKit::WebMediaPlayer::cancelKeyRequest):
- 6:03 PM Changeset in webkit [115392] by
-
- 3 edits in trunk/Source/WebCore
Use WebKit types for the cache of ObjcClass::methodsNamed()
https://bugs.webkit.org/show_bug.cgi?id=85012
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-26
Reviewed by Geoffrey Garen.
This patch redefines the method cache ObjcClass to avoid memory allocations in the case of positive match.
Instead of using the converted name as the key, the original identifier string is used. This shortcuts
all the other operations when there is a match.
A side effect is a method can appear multiple times in the cache if it is invoked with different names using
the escape character "$". An attaquer could bloat the cache with a few hundreds strings.
In the common case, having each name mapped is an improvment.
- bridge/objc/objc_class.h:
(ObjcClass):
- bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::ObjcClass):
(JSC::Bindings::ObjcClass::methodsNamed):
- 5:51 PM Changeset in webkit [115391] by
-
- 2 edits in trunk/Source/JavaScriptCore
Allocating WeakImpl should not trigger GC, as that makes the world very tricksy.
https://bugs.webkit.org/show_bug.cgi?id=85020
Reviewed by Gavin Barraclough.
Now in the event that we are unable to find an allocator for a new handle, just
add a new allocator rather than trying to recover "dead" handles through a GC.
Find allocator is now much simpler, and addAllocator directly reports the
increased memory usage to the heap without causing any GC to happen immediately.
- heap/WeakSet.cpp:
(JSC::WeakSet::findAllocator):
(JSC::WeakSet::addAllocator):
- 5:49 PM Changeset in webkit [115390] by
-
- 2 edits in trunk/LayoutTests
Skip the new ObjC tests for WebKit2
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-26
Reviewed by Andreas Kling.
WebKitTestRunner doesn't have objCController, the new tests for
the Objective-C bindings should be skipped on WebKit2.
- platform/wk2/Skipped:
- 5:48 PM Changeset in webkit [115389] by
-
- 3 edits in trunk/Source/WebCore
Delete dead code in Arena.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=84997
Reviewed by Eric Seidel.
Also cleaned up some style issues. Renamed some single-letter variable names.
Avoided anything other than totally trivial style changes to be 100% sure
that there is no change in behavior.
No new tests. There's no non-style code changes except inlining CLEAR_UNUSED
and CLEAR_ARENA.
- platform/Arena.cpp:
(WebCore):
(WebCore::CeilingLog2):
(WebCore::InitArenaPool):
(WebCore::ArenaAllocate):
(WebCore::FreeArenaList):
(WebCore::FinishArenaPool):
- platform/Arena.h:
(WebCore):
- 5:07 PM Changeset in webkit [115388] by
-
- 16 edits in trunk
Remove RegisterFile::end()/m_end
https://bugs.webkit.org/show_bug.cgi?id=85011
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Get rid of end() and m_end from RegisterFile. From now on
we only care about the end of the committed region when calling
code. When re-entering the VM we now plant the new CallFrame
immediately after whatever the current topCallFrame is. This
required adding a routine to CallFrame to determine exactly what
we should be doing (in the absence of an existing CallFrame, we
can't reason about the frameExtent() so we check for that).
This also now means that the GC only marks the portion of the
RegisterFile that is actually in use, and that VM re-entry doesn't
exhaust the RegisterFile as rapidly.
- dfg/DFGOperations.cpp:
- heap/Heap.cpp:
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
- interpreter/CallFrame.h:
(JSC::ExecState::init):
(JSC::ExecState::startOfReusableRegisterFile):
(ExecState):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):
- interpreter/Interpreter.h:
(JSC::Interpreter::execute):
- interpreter/RegisterFile.cpp:
(JSC::RegisterFile::growSlowCase):
(JSC::RegisterFile::gatherConservativeRoots):
- interpreter/RegisterFile.h:
(JSC::RegisterFile::commitEnd):
(JSC::RegisterFile::addressOfEnd):
(RegisterFile):
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::shrink):
(JSC::RegisterFile::grow):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::handleHostCall):
- llint/LowLevelInterpreter.asm:
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
LayoutTests:
Now that we recurse on the top of the used portion of the stack we
can provide an error message even when the stack is completely full.
Also made sure we were consistent in which callframe we used when
creating stack overflow errors.
- fast/js/global-recursion-on-full-stack-expected.txt:
- fast/js/stack-trace-expected.txt:
- 5:00 PM Changeset in webkit [115387] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.h
Removing bounds checking in float case of roundForImpreciseConversion (numeric_limits<float>::min() is positive, and bounds checking isn't meaningful here).
- 5:00 PM Changeset in webkit [115386] by
-
- 6 edits1 add in trunk/Source
Source/WebCore: Re-implement backFaceVisibility to avoid dealing with perspective w < 0 problem
https://bugs.webkit.org/show_bug.cgi?id=84059
Reviewed by Adrienne Walker.
Unit tests added to CCMathUtilTest.cpp.
This patch changes the implementation of backFaceIsVisible so that
it doesn't need to deal with the w < 0 problem from of perspective
projections. Instead, it is equally correct to simply use the
inverse-transpose of the matrix, and quickly check the third row,
third column element. Additionally, it was appropriate to move
this function into TransformationMatrix itself.
Making this change fixes some issues related to disappearing
layers in Chromium (where the compositor incorrectly thought that
the back face was visible, and skipped the layer).
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateVisibleLayerRect):
(WebCore::layerShouldBeSkipped):
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::isBackFaceVisible):
(WebCore):
- platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):
Source/WebKit/chromium: [chromium] re-implement backFaceVisibility to avoid dealing with perspective w<0 problem
https://bugs.webkit.org/show_bug.cgi?id=84059
Reviewed by Adrienne Walker.
- WebKit.gypi:
- tests/CCMathUtilTest.cpp: Added.
(WebCore):
(WebCore::TEST):
- 4:03 PM Changeset in webkit [115385] by
-
- 17 edits1 copy2 adds in trunk/Source
[Cairo] Wrap cairo surfaces in a class when storing native images
https://bugs.webkit.org/show_bug.cgi?id=83611
Reviewed by Alejandro G. Castro.
Source/WebCore:
No new tests. This is just a refactoring. This shouldn't change
functionality.
Added class that wraps Cairo images surfaces to serve as the "native image"
type for the Cairo platform. This will allow the addition of caching resampled
images as well as versions of the image for non-image Cairo backends. Also
split out BitmapImageCairo.cpp from ImageCairo.cpp since these classes are
defined in two headers.
- GNUmakefile.list.am: Added new files.
- platform/graphics/BitmapImage.h: Added a factory method that takes an image surface to
reduce code churn.
- platform/graphics/ImageSource.h: NativeImagePtr is now NativeImageCairo*.
(WebCore):
- platform/graphics/cairo/BitmapImageCairo.cpp: Copied from Source/WebCore/platform/graphics/cairo/ImageCairo.cpp.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp: Updated to reflect use of NativeImageCairo.
- platform/graphics/cairo/ImageCairo.cpp: Ditto.
- platform/graphics/cairo/NativeImageCairo.cpp: Added.
- platform/graphics/cairo/NativeImageCairo.h: Added.
- platform/graphics/cairo/PatternCairo.cpp: Updated to reflect use of NativeImageCairo.
- platform/graphics/gtk/ImageGtk.cpp: Ditto.
- platform/image-decoders/cairo/ImageDecoderCairo.cpp: Ditto.
Source/WebKit/efl:
- ewk/ewk_history.cpp: Updated to reflect addition of NativeImageCario.
- ewk/ewk_settings.cpp: Ditto.
Source/WebKit2:
- Shared/gtk/ArgumentCodersGtk.cpp: Updated to reflect the addition of NativeImageCairo.
- 3:57 PM Changeset in webkit [115384] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.h
Fixing roundForImpreciseConversion for the float case with template specialization.
- 3:53 PM Changeset in webkit [115383] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Massive media tests failures since r115288
https://bugs.webkit.org/show_bug.cgi?id=84950
Reviewed by Filip Pizlo.
No new tests.
Since the "cross-platform" WebCore timer is at too high of a level in terms of the layers
of WebKit for JSC to use, we are not currently able to use it in JSC, thus only those
platforms that support CoreFoundation can currently take advantage of the new and improved
GC activity timer. We've restored the old code paths for those platforms that don't have
CF so that they will at least have the same behavior as before when calling garbageCollectSoon.
- bindings/js/GCController.cpp: Added back the old WebCore timer along with some
if-defs that do away with the WebCore timer on platforms that support CoreFoundation.
(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):
(WebCore):
(WebCore::GCController::gcTimerFired):
- bindings/js/GCController.h: Ditto.
(GCController):
- 3:42 PM Changeset in webkit [115382] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening
- platform/qt/test_expectations.txt:
- 3:36 PM Changeset in webkit [115381] by
-
- 2 edits in trunk/Source/WebCore
Don't include V8Proxy.h in ScriptValue.h when V8GCController is all that's required
https://bugs.webkit.org/show_bug.cgi?id=84986
Reviewed by Kentaro Hara.
This makes it easier to include ScriptValue.h since it greatly reduces
that header's dependencies.
- bindings/v8/ScriptValue.h: Changed to include just V8GCController.h and
removed comment which is redundant with explicit V8GCController references nearby.
- 3:34 PM Changeset in webkit [115380] by
-
- 5 edits in trunk
Source/WebCore: Fix missing sourceState change on MEDIA_ERR_SOURCE_NOT_SUPPORTED error.
https://bugs.webkit.org/show_bug.cgi?id=84996
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-26
Reviewed by Eric Carlson.
No new tests. http/tests/media/media-source/webm/video-media-source-errors.html was updated to verify that webkitSourceState is always SOURCE_CLOSED when the onerror event fires.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::noneSupported):
LayoutTests: Updating MediaSource layout test to verify that webkitSourceState is always
SOURCE_CLOSED when an error occurs.
Minor style fixes and informative console messages were also added.
https://bugs.webkit.org/show_bug.cgi?id=84996
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-26
Reviewed by Eric Carlson.
- http/tests/media/media-source/webm/video-media-source-errors-expected.txt:
- http/tests/media/media-source/webm/video-media-source-errors.html:
- 3:26 PM Changeset in webkit [115379] by
-
- 10 edits in trunk/Source/WebCore
Cache parsed stylesheets
https://bugs.webkit.org/show_bug.cgi?id=85004
Reviewed by Andreas Kling.
CSS parsing is 1-2% of WebKit CPU usage on average pages, more on sites with large stylesheets.
We currently reparse all stylesheets from source text when they are encountered again. In many
browsing scenarios we can eliminate lot of this by caching the parsed stylesheets. For example
it is very common for subpages of a site to share the stylesheets.
This patch enables memory caching for stylesheet loaded using the <link> element. Only stylesheets
that have no import rules are cacheable for now.
Cached stylesheets are copied on restore so there is no sharing (and no memory wins) yet.
In the future we will also be able to share the actual data structures between pages for
significant memory savings.
After browsing around for a while <5% of the memory cache data was in parsed stylesheets so this
does not bloat the cache significantly.
- css/CSSStyleSheet.cpp:
(WebCore):
(WebCore::StyleSheetInternal::estimatedSizeInBytes):
Estimate stylesheet size so we can handle decoded data pruning correctly.
- css/CSSStyleSheet.h:
(StyleSheetInternal):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::averageSizeInBytes):
(WebCore):
- css/StylePropertySet.h:
(StylePropertySet):
- css/StyleRule.cpp:
(WebCore::StyleRule::averageSizeInBytes):
(WebCore):
- css/StyleRule.h:
(StyleRule):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
Save and restore parsed stylesheet. The current CSS parse context must be identical to the cached
stylesheets. This ensures that the parsing results would be identical.
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):
(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):
- loader/cache/CachedCSSStyleSheet.h:
The parsed stylesheet cache is considered decoded data, similar to the image bitmaps. It uses the
same mechanism for pruning.
(WebCore):
(CachedCSSStyleSheet):
- 3:25 PM Changeset in webkit [115378] by
-
- 4 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
[Gtk] WebKitGTK+ 1.8.1 fails to build when disabling HTML Video feature
https://bugs.webkit.org/show_bug.cgi?id=84838
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-26
Reviewed by Martin Robinson.
Wrap WebCore objects and functions in GObject property setters and getters
with conditional guards (if present) to avoid compilation errors.
No new tests - changes covered by existing bindings tests.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperty):
(GenerateProperties):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Rebaseline.
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: Ditto.
(webkit_dom_test_serialized_script_value_interface_get_property):
- 3:10 PM Changeset in webkit [115377] by
-
- 7 edits in trunk/Tools
nrwt: clean up server process, webkit driver so chromium can use it
https://bugs.webkit.org/show_bug.cgi?id=84910
Reviewed by Ojan Vafai.
This change moves the "sample a process" logic out of
server_process.py and into a port-specific class (where really
only the mac has an implementation), and also preemptively kills
DRT when a test times out in WebKitDriver (rather than waiting through the
additional delays caused by calling stop() when we would want to
restart the driver generically in worker.py).
These changes will make it possible for the chromium port to
switch over to the stock WebKitDriver implementation, at least
on mac and linux.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.sample_process):
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.sample_process):
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_helper_fails_to_stop):
(test_sample_process):
(test_sample_process.logging_run_command):
(test_sample_process_throws_exception):
(test_sample_process_throws_exception.throwing_run_command):
- Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._log):
(ServerProcess._handle_timeout):
(ServerProcess.stop):
(ServerProcess):
(ServerProcess.kill): Here we add a method to immediately stop
the process rather than trying to shut it down cleanly.
- Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TestServerProcess.test_broken_pipe):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.run_test): Fix an issue where we weren't passing
along any per-test args (only needed for Chromium, but still).
Also, kill the driver immediately if we time out a test.
- 3:03 PM Changeset in webkit [115376] by
-
- 4 edits in trunk/Source/WebCore
A TileCache should never outlive its WebTileCacheLayer
https://bugs.webkit.org/show_bug.cgi?id=85008
<rdar://problem/11141172>
Reviewed by Andreas Kling.
Since WebTileCacheLayer objects can be destroyed on the scrolling thread, make sure to delete the TileCache layer
when the PlatformCALayer is destroyed. This fixes a crash when the tile revalidation timer fires after the WebTileCacheLayer has
been destroyed, but before the TileCache itself has been destroyed.
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::~PlatformCALayer):
- platform/graphics/ca/mac/WebTileCacheLayer.h:
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer dealloc]):
(-[WebTileCacheLayer invalidate]):
- 2:56 PM Changeset in webkit [115375] by
-
- 2 edits in trunk/Source/WebCore
Use String instead of RefPtr<StringImpl> for the cache of ObjcClass
https://bugs.webkit.org/show_bug.cgi?id=84932
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-26
Reviewed by Andreas Kling.
The cache with RefPtr<StringImpl*> was added with r115007.
This patch aims at making the code a little easier to read. By using String,
one would not need to know the Traits for StringImpl.
- bridge/objc/objc_class.h:
(ObjcClass):
- 2:53 PM Changeset in webkit [115374] by
-
- 2 edits in trunk/Source/WebCore
[V8] Pass Isolate to wrap() in SerializedScriptValue.cpp
https://bugs.webkit.org/show_bug.cgi?id=84923
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
In this bug we pass Isolate to wrap() in SerializedScriptValue.cpp.
No tests. No change in behavior.
- bindings/v8/SerializedScriptValue.cpp:
- 2:51 PM Changeset in webkit [115373] by
-
- 5 edits in trunk/Source/WebCore
[chromium] Complex text support for Android.
https://bugs.webkit.org/show_bug.cgi?id=84431
Complex text support is different on Android from other platforms.
There are 2 kinds of font on Android: system fonts and fallback fonts.
System fonts have a name, and are accessible in FontPlatformData.
Fallback fonts do not have specific names, so they are not accessible
from WebKit directly. There is one font for each script support.
To feed Harfbuzz, use a trick to get correct SkTypeface based on script.
Patch by Hao Zheng <zhenghao@chromium.org> on 2012-04-26
Reviewed by Tony Chang.
No new tests. Current tests are runnable on Android.
- platform/graphics/FontCache.h:
(FontCache): Make ComplexTextController friend of FontCache on Android.
- platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
(WebCore::ComplexTextController::getComplexFontPlatformData):
(WebCore):
(WebCore::ComplexTextController::setupFontForScriptRun):
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h:
- 2:40 PM Changeset in webkit [115372] by
-
- 9 edits in trunk/Source/WebCore
[V8] Pass Isolate to wrap() (Part2)
https://bugs.webkit.org/show_bug.cgi?id=84922
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to wrap() in custom bindings.
No tests. No change in behavior.
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint16ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint8ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
(WebCore::toV8):
- 2:37 PM Changeset in webkit [115371] by
-
- 2 edits in trunk/LayoutTests
Remove Chromium test expectation after r115244.
- platform/chromium/test_expectations.txt:
- 2:36 PM Changeset in webkit [115370] by
-
- 2 edits3 copies in branches/chromium/1084
Merge 113818 - Notify observers of WorkerRunLoop stopping before the V8 isolate dies.
https://bugs.webkit.org/show_bug.cgi?id=83104
Source/WebCore:
PlatformSupport::didStopWorkerRunLoop ultimately causes
~V8AbstractEventListener to call
v8::Local<v8::Object>::New(m_listener) after the V8 isolate has been
disposed, which manifests as a crash in V8.
The current code in trunk runs this at shutdown:
1) removeAllDOMObjects()
2) dispose of V8
3) didStopWorkerRunLoop() <-- problem
This patch changes the order to be:
1) removeAllDOMObjects()
2) didStopWorkerRunLoop()
3) dispose of V8
We put didStopWorkerRunLoop after removeAllDOMObjects because we don't
want chromium code that runs on a webcore worker to run after it
receives the didStopWorkerRunLoop signal. The destructors of some IDB
objects are run by removeAllDOMObjects, so putting
didStopWorkerRunLoop before removeAllDOMObjects would violate that
constraint.
It's possible that there's a lower layer fix available in V8 or the
bindings.
Reviewed by David Levin.
Test: storage/indexeddb/pending-version-change-on-exit.html
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
New location of didStopWorkerRunLoop. removeAllDOMObjects and V8
disposal are called here, to run something between them it also has
to go here.
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread): Old location of
didStopWorkerRunLoop.
LayoutTests:
Reviewed by David Levin.
- storage/indexeddb/pending-version-change-on-exit-expected.txt: Added.
- storage/indexeddb/pending-version-change-on-exit.html: Added.
- storage/indexeddb/resources/pending-version-change-on-exit.js: Added.
(test.request.onsuccess.request.onblocked):
(test.request.onsuccess):
(test):
TBR=dgrogan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10232019
- 2:35 PM Changeset in webkit [115369] by
-
- 9 edits in trunk/Source
[WK2] AlternativeTextClient leaks when the page is destroyed
https://bugs.webkit.org/show_bug.cgi?id=84307
<rdar://problem/11328431>
Reviewed by Enrica Casucci.
Source/WebCore:
- page/AlternativeTextClient.h: Add pageDestroyed() call, as in EditorClient.
(AlternativeTextClient):
- page/Page.cpp:
(WebCore::Page::~Page): When the page is destroyed, notify the client if it exists.
Source/WebKit/mac:
- WebCoreSupport/WebAlternativeTextClient.h: Implement pageDestroyed(), as in EditorClient.
(WebAlternativeTextClient):
- WebCoreSupport/WebAlternativeTextClient.mm:
(WebAlternativeTextClient::pageDestroyed): Deletes itself.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebAlternativeTextClient.h: Implement pageDestroyed(), as in EditorClient.
(WebAlternativeTextClient):
- WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp:
(WebKit::WebAlternativeTextClient::pageDestroyed): Deletes itself.
- 2:29 PM Changeset in webkit [115368] by
-
- 4 edits in trunk/Source
Full Screen mode does not preserve CALayer ordering after exiting.
https://bugs.webkit.org/show_bug.cgi?id=83931
Reviewed by Eric Carlson.
Further corrections to r114567. When swapping view for otherView, give the correct
relative view to -[NSView addSubview:positioned:relativeTo:].
Source/WebKit/mac:
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController _swapView:with:]):
Source/WebKit2:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _swapView:with:]):
- 2:27 PM Changeset in webkit [115367] by
-
- 6 edits43 adds in trunk/LayoutTests
Integrate IETC CSS : multicolumn tests
https://bugs.webkit.org/show_bug.cgi?id=84784
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-26
Reviewed by Beth Dakin.
Adding IETC CSS Multicolumn tests along with corresponding reference tests.
Failures are noted in port-specific test_expectations.txt.
- ietestcenter/css3/multicolumn/column-block-formatting-context-001-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-block-formatting-context-001.htm: Added.
- ietestcenter/css3/multicolumn/column-containing-block-001-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-containing-block-001.htm: Added.
- ietestcenter/css3/multicolumn/column-containing-block-002-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-containing-block-002.htm: Added.
- ietestcenter/css3/multicolumn/column-containing-block-003-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-containing-block-003.htm: Added.
- ietestcenter/css3/multicolumn/column-filling-001-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-filling-001.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-001-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-001.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-002-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-002.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-003-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-003.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-004-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-004.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-005-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-005.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-006-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-006.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-007-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-007.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-008-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-008.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-009-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-009.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-010-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-010.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-012-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-012.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-013-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-013.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-014-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-014.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-015-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-applies-to-015.htm: Added.
- ietestcenter/css3/multicolumn/column-width-negative-001-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-negative-001.htm: Added.
- ietestcenter/css3/multicolumn/column-width-percentage-001-expected.htm: Added.
- ietestcenter/css3/multicolumn/column-width-percentage-001.htm: Added.
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- 2:25 PM Changeset in webkit [115366] by
-
- 16 edits in trunk/Source/WebCore
[V8] Pass Isolate to wrap() (Part1)
https://bugs.webkit.org/show_bug.cgi?id=84921
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to wrap() in custom bindings.
No tests. No change in behavior.
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Float32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Float64ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int16ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int8ArrayCustom.cpp:
(WebCore::toV8):
- 2:24 PM Changeset in webkit [115365] by
-
- 3 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Update expectations in security/ after r115294.
- platform/efl/security/block-test-expected.txt:
- platform/efl/security/block-test-no-port-expected.txt:
- 2:24 PM Changeset in webkit [115364] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.cpp
Continuing to use roundForImpreciseConversion when subpixel-layout is disabled, but Lengths are still treated as floats.
- 2:21 PM Changeset in webkit [115363] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG ARMv7 backend should optimize Float32 arrays
https://bugs.webkit.org/show_bug.cgi?id=85000
<rdar://problem/10652827>
Reviewed by Gavin Barraclough.
- assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::flds):
(JSC::ARMv7Assembler::fsts):
(JSC::ARMv7Assembler::vcvtds):
(JSC::ARMv7Assembler::vcvtsd):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::loadFloat):
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):
- bytecode/PredictedType.h:
(JSC::isActionableFloatMutableArrayPrediction):
- dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateFloat32Array):
- 2:15 PM Changeset in webkit [115362] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Remove expectation of failure for a fixed test.
- platform/chromium/test_expectations.txt: Now passing.
- 2:12 PM Changeset in webkit [115361] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, remove tests that now pass from test_expectations.txt
- platform/mac/test_expectations.txt:
- 2:10 PM Changeset in webkit [115360] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test for crash in DOMSelection::deleteFromDocument
https://bugs.webkit.org/show_bug.cgi?id=84991
Reviewed by Alexey Proskuryakov.
Add a test for the bug 44153 (fixed in r65587).
- editing/selection/deleteFromDocument-after-document-open-crash-expected.txt: Added.
- editing/selection/deleteFromDocument-after-document-open-crash.html: Added.
- 2:08 PM Changeset in webkit [115359] by
-
- 4 edits in trunk/Source
Versioning.
- 2:07 PM Changeset in webkit [115358] by
-
- 5 edits4 adds in trunk
ObjcClass::methodsNamed() can leak if buffer is dynamically allocated
https://bugs.webkit.org/show_bug.cgi?id=84668
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-26
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Change ObjcClass::methodsNamed() to be based on a vector instead of managing
the memory manually.
Tests: platform/mac/plugins/bindings-objc-long-method-name.html
platform/mac/plugins/bindings-objc-method-name-conversion.html
- bridge/objc/objc_class.mm:
(Bindings):
(JSC::Bindings::convertJSMethodNameToObjc):
(JSC::Bindings::ObjcClass::methodsNamed):
Tools:
Extend ObjCPlugin to support the new layout tests of the Objective-C bridge.
- DumpRenderTree/mac/ObjCPlugin.m:
(+[ObjCPlugin isSelectorExcludedFromWebScript:]):
(+[ObjCPlugin webScriptNameForSelector:]):
(-[ObjCPlugin methodMappedToLongName]):
(-[ObjCPlugin testConversionColon:]):
(-[ObjCPlugin _:]):
LayoutTests:
Extend the test coverage to accessor with very long name. Add coverage for the
JavaScript to Objective-C method name conversion.
- platform/mac/plugins/bindings-objc-long-method-name-expected.txt: Added.
- platform/mac/plugins/bindings-objc-long-method-name.html: Added.
- platform/mac/plugins/bindings-objc-method-name-conversion-expected.txt: Added.
- platform/mac/plugins/bindings-objc-method-name-conversion.html: Added.
- 2:05 PM Changeset in webkit [115357] by
-
- 1 copy in tags/Safari-536.9
New Tag.
- 2:01 PM Changeset in webkit [115356] by
-
- 2 edits in trunk/LayoutTests
[Chromium] media/video-currentTime-set.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=85003
- platform/chromium/test_expectations.txt: Added expectation of flakiness.
- 1:58 PM Changeset in webkit [115355] by
-
- 18 edits in trunk/Source
[Chromium] Single buffered canvas layers with the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=80540
Patch by Justin Novosad <junov@chromium.org> on 2012-04-26
Reviewed by James Robinson.
Source/WebCore:
Tests:
CCLayerTreeHostTestWriteLayersRedraw
CCLayerTreeHostTestWriteLayersAfterVisible
Canvas2DLayerChromiumTest.testFullLifecycleSingleThreadDeferred
Canvas2DLayerChromiumTest.testFullLifecycleThreadDeferred
CCSchedulerTest.VisibilitySwitchWithTextureAcquisition
CCSchedulerTest.TextureAcquisitionCollision
Disable double buffering and rate limiting on accelerated canvas
when the threaded compositor and deferred canvas are enabled.
Concurrent access to the layer texture by the main renderer thread and
the compositor thread is avoided by enforcing a lock. The state of the
lock is maintained by CCSchedulerStateMachine. Write access by the main
thread is acquired through a signal round trip to the compositor thread,
which may block the main thread in the event that one or more committed
layers need to be protected until the compositor completes the requested
draw. Draws on the impl thread are cancelled if the main thread has
obtained write access to the texture. The write access is relinquished
by the main thread upon commit completion. The scheduler state machine
is responsible for preventing the texture lock from causing deadlocks by
detecting and resolving problematic states.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::drawingIntoImplThreadTexture):
(WebCore):
(WebCore::Canvas2DLayerChromium::setTextureId):
(WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):
(WebCore::Canvas2DLayerChromium::update):
(WebCore::Canvas2DLayerChromium::layerWillDraw):
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::acquireLayerTextures):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setMainThreadNeedsLayerTextures):
(WebCore):
(WebCore::CCScheduler::processScheduledActions):
- platform/graphics/chromium/cc/CCScheduler.h:
(CCSchedulerClient):
(CCScheduler):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::drawSuspendedUntilCommit):
(WebCore):
(WebCore::CCSchedulerStateMachine::scheduledToDraw):
(WebCore::CCSchedulerStateMachine::shouldDraw):
(WebCore::CCSchedulerStateMachine::shouldAcquireLayerTexturesForMainThread):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setMainThreadNeedsLayerTextures):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(CCSchedulerStateMachine):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore):
(WebCore::CCThreadProxy::acquireLayerTextures):
(WebCore::CCThreadProxy::acquireLayerTexturesForMainThreadOnImplThread):
(WebCore::CCThreadProxy::scheduledActionAcquireLayerTexturesForMainThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore):
(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(AcceleratedDeviceContext):
(WebCore::createAcceleratedCanvas):
(WebCore::ImageBuffer::context):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::AcquireLayerTextures):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::dispatchAcquireLayerTextures):
(WTF::TEST_F):
(WTF):
(CCLayerTreeHostTestWriteLayersRedraw):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::CCLayerTreeHostTestWriteLayersRedraw):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::beginTest):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::afterTest):
(CCLayerTreeHostTestWriteLayersAfterVisible):
(WTF::CCLayerTreeHostTestWriteLayersAfterVisible::CCLayerTreeHostTestWriteLayersAfterVisible):
(WTF::CCLayerTreeHostTestWriteLayersAfterVisible::beginTest):
(WTF::CCLayerTreeHostTestWriteLayersAfterVisible::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestWriteLayersAfterVisible::afterTest):
- tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):
- tests/Canvas2DLayerChromiumTest.cpp:
(Canvas2DLayerChromiumTest::fullLifecycleTest):
- 1:53 PM Changeset in webkit [115354] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r115342.
http://trac.webkit.org/changeset/115342
r115340 was rolled out
- platform/qt/test_expectations.txt:
- 1:50 PM Changeset in webkit [115353] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r115349.
http://trac.webkit.org/changeset/115349
Patch that required this change was reverted.
- platform/chromium/test_expectations.txt:
- 1:47 PM Changeset in webkit [115352] by
-
- 8 edits130 adds10 deletes in trunk
Unreviewed, rolling out r115340.
http://trac.webkit.org/changeset/115340
https://bugs.webkit.org/show_bug.cgi?id=83048
Does not work with Windows.
Tools:
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._run_reftest):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(copy_file):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port._parse_reftest_list):
(Port.reference_files):
(Port._real_tests):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_reference_files):
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_write_command_and_read_line):
LayoutTests:
- css2.1/20110323/abspos-containing-block-initial-004-ref-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-004-ref-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-004a-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-004a-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-004b-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-004b-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-004c-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-004c-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-004d-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-004d-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-004e-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-004e-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-004f-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-004f-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-005-ref-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-005-ref-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-005a-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-005a-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-005b-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-005b-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-005c-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-005c-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-005d-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-005d-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-009-ref-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-009-ref-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-009a-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-009a-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-009b-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-009b-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-009e-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-009e-expected.txt: Added.
- css2.1/20110323/abspos-containing-block-initial-009f-expected.png: Added.
- css2.1/20110323/abspos-containing-block-initial-009f-expected.txt: Added.
- css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
- css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
- css2.1/20110323/background-016.htm: Removed.
- css2.1/20110323/block-replaced-width-001.htm: Added.
- css2.1/20110323/empty-inline-001.htm:
- css2.1/20110323/reftest.list: Removed.
- css2.1/reference/ref-filled-green-100px-square.htm: Removed.
- css2.1/reference/ref-filled-green-100px-square.xht: Removed.
- css2.1/reference/ref-if-there-is-no-red.htm: Removed.
- css2.1/reference/ref-if-there-is-no-red.xht: Removed.
- css2.1/reference/ref-nothing-below.htm: Removed.
- css2.1/reference/ref-nothing-below.xht: Removed.
- css2.1/reference/ref-this-text-should-be-green.htm: Removed.
- css2.1/reference/ref-this-text-should-be-green.xht: Removed.
- platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/empty-inline-001-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/block-replaced-width-001-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/block-replaced-width-001-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/empty-inline-001-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/block-replaced-width-001-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/empty-inline-001-expected.png: Added.
- platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
- platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
- platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
- platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
- platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
- platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
- platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
- platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
- platform/chromium-win/css2.1/20110323/empty-inline-001-expected.png: Added.
- platform/chromium-win/css2.1/20110323/empty-inline-001-expected.txt: Added.
- platform/chromium/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
- platform/chromium/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
- platform/efl/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
- platform/efl/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
- platform/efl/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
- platform/efl/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
- platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
- platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
- platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
- platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Added.
- platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
- platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
- platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
- platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Added.
- platform/efl/css2.1/20110323/block-replaced-width-001-expected.png: Added.
- platform/efl/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
- platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
- platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
- platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
- platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
- platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
- platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
- platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Added.
- platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
- platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
- platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
- platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Added.
- platform/gtk/css2.1/20110323/block-replaced-width-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
- platform/mac-snowleopard/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
- platform/mac/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
- platform/mac/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
- platform/mac/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
- platform/mac/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
- platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
- platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
- platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
- platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Added.
- platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
- platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
- platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
- platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Added.
- platform/mac/css2.1/20110323/block-replaced-width-001-expected.png: Added.
- platform/mac/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
- platform/mac/css2.1/20110323/empty-inline-001-expected.png: Added.
- platform/mac/css2.1/20110323/empty-inline-001-expected.txt: Added.
- platform/qt/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
- platform/qt/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
- platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
- platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
- platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Added.
- platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
- platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
- platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Added.
- platform/qt/css2.1/20110323/block-replaced-width-001-expected.png: Added.
- platform/qt/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
- platform/qt/css2.1/20110323/empty-inline-001-expected.txt: Added.
- 1:41 PM Changeset in webkit [115351] by
-
- 2 edits in trunk/Source/WebCore
[V8] Pass Isolate to toV8() in SerializedScriptValue.cpp
https://bugs.webkit.org/show_bug.cgi?id=84918
Reviewed by Nate Chapin.
This is the last step to pass Isolate around in
SerializedScriptValue.cpp. This patch passes Isolate
to toV8().
No tests. No change in behavior.
- bindings/v8/SerializedScriptValue.cpp:
- 1:34 PM Changeset in webkit [115350] by
-
- 24 edits in trunk/Source/WebCore
[V8] Pass Isolate to wrapSlow()
https://bugs.webkit.org/show_bug.cgi?id=84919
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
In this bug, we pass Isolate to wrapSlow().
Test: bindings/scripts/test/TestObj.idl etc
- bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateHeader):
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8Float64Array.cpp: Updated run-bindings-tests.
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::V8TestNode::wrap):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
- 1:17 PM Changeset in webkit [115349] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Remove expectation of a test failure after the test itself was removed in r115340.
- platform/chromium/test_expectations.txt: Removed failure expectation.
- 1:15 PM Changeset in webkit [115348] by
-
- 8 edits in trunk
[BlackBerry] properly disable DRAG_SUPPORT
https://bugs.webkit.org/show_bug.cgi?id=84952
Reviewed by Daniel Bates.
Patch by Antonio Gomes <agomes@rim.com>
.:
Add CMake build options to toggle DRAG_SUPPORT on/off,
and set its value for BlackBerry port.
- Source/cmake/OptionsBlackBerry.cmake: Set it OFF by default.
- Source/cmake/OptionsEFL.cmake: Set it ON by default.
- Source/cmake/OptionsWinCE.cmake: Set it OFF by default.
- Source/cmake/OptionsWindows.cmake: Set it ON by default.
- Source/cmakeconfig.h.cmake:
Source/WTF:
- wtf/Platform.h: Remove the line that disables drag support from here.
- 1:15 PM Changeset in webkit [115347] by
-
- 4 edits2 adds in trunk/Source/WebCore
Add ScrollAnimatorBlackBerry as an extension to ScrollAnimatorNone
https://bugs.webkit.org/show_bug.cgi?id=84625
Reviewed by Anders Carlsson.
Patch by Antonio Gomes <agomes@rim.com>
Patch adds ScrollAnimatorBlackBerry class as an extension to of
ScrollAnimatorNone. The main goal here is extending the later to allow
overscrolling while the animation runs.
Once the animation finishes, the flag gets reseted and
ScrollableArea::constrainsScrollingtoContentEdge is set back to the value
it had before, so this method has to be explicitly called anytime it is wanted.
- CMakeLists.txt:
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::animationWillStart):
(WebCore::ScrollAnimator::animationDidFinish):
(ScrollAnimator):
- platform/ScrollAnimatorNone.cpp:
(WebCore):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):
- platform/blackberry/ScrollAnimatorBlackBerry.cpp: Added.
(WebCore):
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorBlackBerry::ScrollAnimatorBlackBerry):
(WebCore::ScrollAnimatorBlackBerry::animationWillStart):
(WebCore::ScrollAnimatorBlackBerry::animationDidFinish):
(WebCore::ScrollAnimatorBlackBerry::setDisableConstrainsScrollingToContentEdgeWhileAnimating):
- platform/blackberry/ScrollAnimatorBlackBerry.h: Added.
(WebCore):
(ScrollAnimatorBlackBerry):
- 1:14 PM Changeset in webkit [115346] by
-
- 5 edits in trunk
[BlackBerry] Add smooth_scrolling options to CMAKE and enable it for Blackberry
https://bugs.webkit.org/show_bug.cgi?id=84954
Reviewed by Daniel Bates.
Patch by Antonio Gomes <agomes@rim.com>
.:
- Source/cmakeconfig.h.cmake: Make it possible for CMake builds to toggle SMOOTH_SCROLLING on/off
- Source/cmake/OptionsBlackBerry.cmake: ... and set it to ON by defualt for the Blackberry port.
Source/WebCore:
Add the default scroll animator to the build system (ScrollAnimatorNone.cpp)
- CMakeLists.txt:
- 1:14 PM Changeset in webkit [115345] by
-
- 2 edits in trunk/Source/WebCore
Make ScrollView::scrollSize scrollbar-independent
https://bugs.webkit.org/show_bug.cgi?id=84873
Reviewed by Anders Carlsson.
Patch by Antonio Gomes <agomes@rim.com>
For ports that disable scrollbars creation at FrameView creation time
ScrollView::scrollSize should still return the scrollable ammount of
content (if any) if scrolling is not prohibted.
No new test, but it makes ScrollAnimator work for the BlackBerry port.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollSize):
- 1:01 PM Changeset in webkit [115344] by
-
- 6 edits in trunk/Source/WebCore
The tile cache should know if a frame view can ever have scrollbars
https://bugs.webkit.org/show_bug.cgi?id=84888
Reviewed by Andreas Kling.
If a frame view has overflow: hidden on its body element we know that the document will most
likely never be scrolled. The tile cache should know about this so we can optimize.
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
- platform/graphics/TiledBacking.h:
(TiledBacking):
- platform/graphics/ca/mac/TileCache.h:
(TileCache):
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache):
(WebCore::TileCache::setCanHaveScrollbars):
(WebCore):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
- 12:59 PM Changeset in webkit [115343] by
-
- 5 edits2 adds in trunk
Crash from removal of line break object after layout
https://bugs.webkit.org/show_bug.cgi?id=75461
Source/WebCore:
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-26
Reviewed by David Hyatt.
There is a condition where objects can get removed from underneath
inlines while they represent a line break object in a RootInlineBox
of an ancestor block. If an intermediary inline has already been
marked as needing layout, then the line box will not get dirtied
because dirtyLineFromChangedChild thinks it already has been.
This patch introduces a new set in RenderObject to indicate whether
an ancestral line box corresponding to the current line has been
marked dirty or not. dirtyLinesFromChangedChild() can use this set
rather than m_selfNeedsLayout, so it will not be confused if a
container was dirtied for some other reason that did not affect the
line box.
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild): Use the new
set rather than m_selfNeedsLayout in the container to determine
whether to continue propagating upward.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::s_ancestorLineboxDirtySet): Instantiate the
static member.
(WebCore::RenderObject::willBeDestroyed): Clears the object from the
linebox set when it is being destroyed.
- rendering/RenderObject.h:
(WebCore::RenderObject::s_ancestorLineboxDirtySet): Added static
member set.
(WebCore::RenderObject::setNeedsLayout): Clears the
object from the linebox set when layout bits are getting cleared.
(WebCore::RenderObject::ancestorLineBoxDirty): Added.
(WebCore::RenderObject::setAncestorLineBoxDirty): Added.
LayoutTests:
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-25
Reviewed by David Hyatt.
Test exercising crashing condition in bug 75461.
- fast/block/line-layout/line-break-obj-removal-crash-expected.txt: Added
- fast/block/line-layout/line-break-obj-removal-crash.html: Added
- 12:54 PM Changeset in webkit [115342] by
-
- 2 edits in trunk/LayoutTests
Update Qt expectations after r115340
css2.1/20110323/abspos-replaced-width-margin-000.htm fails the reftest due to
scrollbar artefacts.
Unreviewed.
- platform/qt/test_expectations.txt:
- 12:48 PM Changeset in webkit [115341] by
-
- 16 edits in trunk
[EFL] Enable VIDEO_TRACK feature
https://bugs.webkit.org/show_bug.cgi?id=84830
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-26
Reviewed by Gustavo Noronha Silva.
.:
Enable VIDEO_TRACK feature by default on EFL port.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
Enable support for VIDEO_TRACK feature by default for EFL port.
- UseJSC.cmake:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
Source/WebKit:
Enable VIDEO_TRACK feature by default for EFL port.
- PlatformEfl.cmake:
Source/WebKit/efl:
Add functions on the ewk_view to toggle runtime support for text
tracks in HTML5 video.
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_should_display_subtitles_get):
(ewk_view_setting_should_display_subtitles_set):
(ewk_view_setting_should_display_captions_get):
(ewk_view_setting_should_display_captions_set):
(ewk_view_setting_should_display_text_descriptions_get):
(ewk_view_setting_should_display_text_descriptions_set):
- ewk/ewk_view.h:
Tools:
Enable VIDEO_TRACK by default on EFL port whenever build-webkit is
used.
- Scripts/build-webkit:
LayoutTests:
Unskip test cases which requires the VIDEO_TRACK feature now that it
is enabled by default for EFL port.
- platform/efl/Skipped:
- 12:21 PM Changeset in webkit [115340] by
-
- 8 edits11 adds130 deletes in trunk
new-webkit-run-tests: handle ref tests from the CSS test suite
https://bugs.webkit.org/show_bug.cgi?id=83048
Reviewed by Ryosuke Niwa.
Tools:
This allows new-run-webkit-tests to run reference tests created for the CSS test suite. It removes a big swathe
of pixel and text results that are no longer required now that the reference results are used and adds in the support
files from the CSS test suite that allow the ref tests to run.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._run_reftest): Assert that the reference result exists. Previously the test would
run without it and report a pass!
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(copy_file): ensure the output directory exists, it may not if the reference test is
contained in a folder that contains nothing but reference tests.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.available_reference_files): Add as a helper. Handle embedded relative paths, e.g: some/../path
(Port.reference_files): Only return reference results in the reftest list that actually exist on
disk. Also, don't ignore potential reference results on disk that are not in the reftest list, and
don't ignore them just because we have a reftest list for the test's directory.
(Port._real_tests): ignore anything that looks like a test in a 'support' directory, this semantic
is used by the CSS 2.1 test suite.
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_reference_files_when_reftestlist_and_reference_file_present): Ensure that a test with a reference result
on disk but no reference result listed in the directory's reftest list picks up its reference result.
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_strip_uri): Test that some/test.html and some/other/../test.html are treated
as the same file.
LayoutTests:
Add some of the reference infrastructure from the CSS 2.1 test suite.
- css2.1/20110323/abspos-containing-block-initial-004-ref-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-004-ref-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-004a-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-004a-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-004b-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-004b-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-004c-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-004c-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-004d-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-004d-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-004e-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-004e-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-004f-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-004f-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-005-ref-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-005-ref-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-005a-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-005a-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-005b-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-005b-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-005c-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-005c-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-005d-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-005d-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-009-ref-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-009-ref-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-009a-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-009a-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-009b-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-009b-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-009e-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-009e-expected.txt: Removed.
- css2.1/20110323/abspos-containing-block-initial-009f-expected.png: Removed.
- css2.1/20110323/abspos-containing-block-initial-009f-expected.txt: Removed.
- css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Removed.
- css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Removed. These results are superseded by the reference results.
- css2.1/20110323/background-016.htm: Added to prove the CSS test suite reference results work.
- css2.1/20110323/block-replaced-width-001.htm: Removed. This test does not pass its reference result. It regressed at some point.
- css2.1/20110323/empty-inline-001.htm: The test has been updated from the CSS test suite.
- css2.1/20110323/reftest.list: Added.
- css2.1/reference/ref-filled-green-100px-square.htm: Added.
- css2.1/reference/ref-filled-green-100px-square.xht: Added.
- css2.1/reference/ref-if-there-is-no-red.htm: Added.
- css2.1/reference/ref-if-there-is-no-red.xht: Added.
- css2.1/reference/ref-nothing-below.htm: Added.
- css2.1/reference/ref-nothing-below.xht: Added.
- css2.1/reference/ref-this-text-should-be-green.htm: Added.
- css2.1/reference/ref-this-text-should-be-green.xht: Added.
Ref test infrastructure from the CSS test suite.
- platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/empty-inline-001-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/empty-inline-001-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/empty-inline-001-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/empty-inline-001-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/empty-inline-001-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/empty-inline-001-expected.txt: Removed.
- platform/chromium/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Removed.
- platform/chromium/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Removed.
- platform/efl/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
- platform/efl/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
- platform/efl/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Removed.
- platform/efl/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Removed.
- platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
- platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Removed.
- platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
- platform/efl/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Removed.
- platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
- platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Removed.
- platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
- platform/efl/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Removed.
- platform/efl/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
- platform/efl/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
- platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
- platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Removed.
- platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
- platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
- platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Removed.
- platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
- platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
- platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Removed.
- platform/gtk/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
- platform/gtk/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
- platform/gtk/css2.1/20110323/empty-inline-001-expected.txt: Removed.
- platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Removed.
- platform/mac-snowleopard/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
- platform/mac/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
- platform/mac/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Removed.
- platform/mac/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
- platform/mac/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Removed.
- platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
- platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Removed.
- platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
- platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Removed.
- platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
- platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Removed.
- platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
- platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Removed.
- platform/mac/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
- platform/mac/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
- platform/mac/css2.1/20110323/empty-inline-001-expected.png: Removed.
- platform/mac/css2.1/20110323/empty-inline-001-expected.txt: Removed.
- platform/qt/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
- platform/qt/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Removed.
- platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
- platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
- platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Removed.
- platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
- platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
- platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Removed.
- platform/qt/css2.1/20110323/block-replaced-width-001-expected.png: Removed.
- platform/qt/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
- platform/qt/css2.1/20110323/empty-inline-001-expected.txt: Removed.
These results are superseded by the reference results.
- 12:19 PM Changeset in webkit [115339] by
-
- 14 edits in trunk/Source/WebKit/chromium
[Chromium] IndexedDB: Use WebIDBKeyPath type for key paths in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=84631
Reviewed by James Robinson.
WebIDBKeyPath was previously a utility class for parsing key paths into components,
but the API exposed key paths only as nullable strings. To support array-type keypaths,
WebIDBKeyPath becomes a value class with type flags. For landing, several legacy methods
are retained but will be cleaned up after all callers have been updated, tracked as
the bug: http://webkit.org/b/84207
- public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch.
- public/WebIDBIndex.h:
(WebKit::WebIDBIndex::keyPath): Calls keyPathString if not overridden.
(WebKit::WebIDBIndex::keyPathString): Comment change.
- public/WebIDBKeyPath.h:
(WebKit::WebIDBKeyPath::create): Overload added for creating array-type key paths.
(WebKit::WebIDBKeyPath::array): Accessor for array-type key paths.
(WebKit::WebIDBKeyPath::operator const WebString ): Temporary, for compatibility.
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::keyPath): Calls keyPathString if not overridden.
(WebKit::WebIDBObjectStore::keyPathString): Comment change.
(WebKit::WebIDBObjectStore::createIndex): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch.
- public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport): WebIDBKeyPath overloads for these methods added, delegate to WebString version until implementers are updated.
(WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):
- src/IDBIndexBackendProxy.cpp:
(WebKit::IDBIndexBackendProxy::keyPath): Returns the string version until WebCore is updated.
- src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::keyPath): Returns the string version until WebCore is updated.
- src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl): Add createObjectStore overload for WebIDBKeyPath type, delegates to WebString version until callers are updated.
- src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::keyPath): Implements the new WebIDBKeyPath return type.
(WebKit):
- src/WebIDBIndexImpl.h:
(WebIDBIndexImpl): Implements the new WebIDBKeyPath return type.
- src/WebIDBKeyPath.cpp:
(WebKit::WebIDBKeyPath::create): Support null key path types.
(WebKit::WebIDBKeyPath::createNull): New API.
(WebKit):
(WebKit::WebIDBKeyPath::isValid): New API.
(WebKit::WebIDBKeyPath::type): New API.
(WebKit::WebIDBKeyPath::string): New API (value accessor).
(WebKit::WebIDBKeyPath::WebIDBKeyPath):
(WebKit::WebIDBKeyPath::assign): This API will be removed.
(WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&): Ensure it is non-null - only used in copy constructor which guards against this.
- src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::keyPath): Implement the new WebIDBKeyPath return type.
(WebKit):
- src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl): Add createIndex overload for WebIDBKeyPath type, delegates to WebString version until callers are updated.
- 12:01 PM Changeset in webkit [115338] by
-
- 3 edits in trunk/Tools
Unreviewed. Fix GTK+ build after r115314.
For some reason it fails while bulding GtkVersioning for WTR, but
it didn't fail neither in EWS nor in my laptop. We don't really
need GtkVersioning in WTR since it already depends on GTK+3
unconditionally.
- WebKitTestRunner/GNUmakefile.am: Remove GtkVersioning.c from
compilation.
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::createMouseButtonEvent): Use GTK+ 3 API
directly instead of getDefaultGDKPointerDevice() helper.
(WTR::EventSenderProxy::keyDown): Ditto.
(WTR::EventSenderProxy::mouseMoveTo): Ditto.
- 11:47 AM Changeset in webkit [115337] by
-
- 8 edits in trunk/Tools
Show flakiness dashboard data in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=83716
Reviewed by Dimitri Glazkov.
Put an iframe below the expected/actual results in the Results view.
Size the iframe to it's height.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
- 11:44 AM Changeset in webkit [115336] by
-
- 6 edits in trunk/Source/WebCore
Implement StyleSheetInternal copying
https://bugs.webkit.org/show_bug.cgi?id=84969
Reviewed by Andreas Kling.
We need to be able to copy stylesheets to cache them. Copying is already implement for
most of the stylesheet data types but StyleSheetInternal::copy() is still missing.
Preparation for stylesheet caching. The copying code is not used yet.
- css/CSSNamespace.h:
Instead of making it copyable, remove CSSNamespace class.
- css/CSSParser.cpp:
(WebCore::operator==):
(WebCore):
(WebCore::CSSParser::addNamespace):
Avoid ping-ponging to StyleSheetInternal and back to set the default namespace.
- css/CSSParserMode.h:
(WebCore):
(WebCore::operator!=):
Add equality comparison operator to CSSParseMode. This will be needed to determine
if a cached copy can be used.
- css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore::StyleSheetInternal::parserAddNamespace):
(WebCore::StyleSheetInternal::determineNamespace):
Use HashMap instead of iterating a linked list of CSSNamespaces.
(WebCore::StyleSheetInternal::styleSheetChanged):
Add mutation bit.
- css/CSSStyleSheet.h:
(WebCore):
(StyleSheetInternal):
(WebCore::StyleSheetInternal::copy):
Copy constructor. It only usable for cacheable stylesheets.
- 11:24 AM Changeset in webkit [115335] by
-
- 3 edits2 adds in trunk
Fix Skia's SkPathContainsPoint to work with sub-pixel accuracy
https://bugs.webkit.org/show_bug.cgi?id=84117
Reviewed by Eric Seidel.
Source/WebCore:
Because we do hit testing in object-space (i.e., we may see a 0.1px*0.1px path) we
need to support sub-pixel hit testing in Skia. Skia does not provide analytical
path hit testing, so hit tests are done by rasterizing a path and checking if a
specific pixel is drawn. SkPathContainsPoint did not work with sub-pixel values
because this rasterization was sometimes very small which did not give enough
resolution to check if the hit test pixel was drawn.
This patch scales the path to a very large size during hit testing so that Skia's
raster-based hit testing will work properly. Because Skia avoids unnecessary
path rasterization, this is actually inexpensive.
Below is a summary of a performance test on simple and complex paths:
(before patch, after patch)
Skia/Chrome 10,000 hit tests on a simple path: (229ms, 238ms)
Skia/Chrome 10,000 hit tests on a complex path: (701ms, 704ms)
For comparison, CG/Safari takes 236ms on the simple path and 466ms on the complex path.
Therefore, this patch introduces small but measurable regression in hit testing
performance due to scaling the path.
Test: svg/hittest/svg-small-path.xhtml
- platform/graphics/skia/SkiaUtils.cpp:
(WebCore::SkPathContainsPoint):
LayoutTests:
- svg/hittest/svg-small-path-expected.txt: Added.
- svg/hittest/svg-small-path.xhtml: Added.
- 11:20 AM Changeset in webkit [115334] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r115323.
http://trac.webkit.org/changeset/115323
https://bugs.webkit.org/show_bug.cgi?id=84975
Bad test, breaks all builds (Requested by apavlov1 on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-26
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
- inspector/InspectorPageAgent.h:
- inspector/front-end/Settings.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
- inspector/front-end/inspector.js:
LayoutTests:
- inspector/debugger/disable-script-expected.txt: Removed.
- inspector/debugger/disable-script.html: Removed.
- 11:12 AM Changeset in webkit [115333] by
-
- 5 edits3 adds in trunk
IndexedDB: cursor does not correctly iterate over keys added and removed during iteration
https://bugs.webkit.org/show_bug.cgi?id=84467
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-04-26
Reviewed by Ojan Vafai.
Source/WebCore:
Ensure that the iterator over the tree of cached adds/removes always points at
the current key, or if the db iterator is current, the next key:
- When refreshing the tree iterator after a mutation, always seek unless the
tree iterator is current.
- When handing conflicts and delete markers, only advance the tree iterator as
far as the db iterator.
Remove the expensive (and now redundant) logic that issued a get() to check
whether an item had been deleted.
Test: storage/indexeddb/cursor-added-bug.html
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):
- platform/leveldb/LevelDBTransaction.cpp:
(WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
(WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):
LayoutTests:
New test for keys added in reverse order during cursor iteration.
- storage/indexeddb/cursor-added-bug-expected.txt: Added.
- storage/indexeddb/cursor-added-bug.html: Added.
- storage/indexeddb/resources/cursor-added-bug.js: Added.
(test):
(openSuccess):
(setVersionSuccess):
(openCursor):
(cursorSuccess):
- 11:09 AM Changeset in webkit [115332] by
-
- 8 edits in trunk
[EFL] [DRT] LayoutTestController needs implementation of setJavaScriptProfilingEnabled
https://bugs.webkit.org/show_bug.cgi?id=84576
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-26
Reviewed by Martin Robinson.
Source/WebKit/efl:
Add missing implementation setJavaScriptProfilingEnabled to EFL's
DumpRenderTreeSupport. This setting allows layout tests to start
JavaScript profiling.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setJavaScriptProfilingEnabled):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Add missing implementation setJavaScriptProfilingEnabled to EFL's
LayoutTestController in order to unskip tests rely on this setting.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setJavaScriptProfilingEnabled):
LayoutTests:
Unskip test cases which rely on LayoutTestController's
setJavaScriptProfilingEnabled implementation.
- platform/efl/Skipped:
- 11:07 AM Changeset in webkit [115331] by
-
- 2 edits in tags/Safari-536.8.2/Source/JavaScriptCore
Merged r115253.
- 11:05 AM Changeset in webkit [115330] by
-
- 2 edits in tags/Safari-536.8.2/Source/JavaScriptCore
Merged r115252.
- 11:02 AM Changeset in webkit [115329] by
-
- 4 edits3 copies in tags/Safari-536.8.2
Merged r115096.
- 10:52 AM Changeset in webkit [115328] by
-
- 2 edits in trunk/Tools
Add Jing Zhao, Min Qin, Tien-Ren Chen and Hao Zheng into contributors list.
Not reviewed.
- Scripts/webkitpy/common/config/committers.py:
- 10:27 AM Changeset in webkit [115327] by
-
- 4 edits in tags/Safari-536.8.2/Source
Versioning.
- 10:25 AM Changeset in webkit [115326] by
-
- 1 copy in tags/Safari-536.8.2
New Tag.
- 10:22 AM HackingWebInspector edited by
- (diff)
- 10:01 AM Changeset in webkit [115325] by
-
- 2 edits in trunk/LayoutTests
[Chromium] webaudio/audioparam-exponentialRampToValueAtTime.html is occasionally crashing
https://bugs.webkit.org/show_bug.cgi?id=84972
- platform/chromium/test_expectations.txt: Marked as flaky.
- 9:52 AM Changeset in webkit [115324] by
-
- 4 edits in trunk/Source
Placeholder view is immediately removed from hosting window upon entering full screen.
https://bugs.webkit.org/show_bug.cgi?id=84916
Reviewed by Darin Adler.
Correct a mistake added in r114567. When swapping view for otherView, add otherView and
remove view (rather than adding otherView and removing otherView).
Source/WebKit/mac:
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController _swapView:with:]):
Source/WebKit2:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _swapView:with:]):
- 9:44 AM Changeset in webkit [115323] by
-
- 8 edits2 adds in trunk
Web Inspector: Implement the "Disable JavaScript" option in the settings dialog
https://bugs.webkit.org/show_bug.cgi?id=84946
Source/WebCore:
Based on user actions in the Inspector frontend, InspectorPageAgent invokes Settings::setScriptEnabled()
for the associated page to switch the script execution therein.
Reviewed by Yury Semikhatsky.
Test: inspector/debugger/disable-script.html
- inspector/Inspector.json:
- inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::getScriptExecutionStatus):
(WebCore):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
- inspector/InspectorPageAgent.h:
- inspector/front-end/Settings.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype.get _updateScriptDisabledCheckbox):
(WebInspector.SettingsScreen.prototype._javaScriptDisabledChanged):
- inspector/front-end/inspector.js:
LayoutTests:
Reviewed by Yury Semikhatsky.
- inspector/debugger/disable-script-expected.txt: Added.
- inspector/debugger/disable-script.html: Added.
- 9:19 AM Changeset in webkit [115322] by
-
- 3 edits in trunk/Tools
[GTK] Test TestWebKitAPI/WebKit2/TestNewFirstVisuallyNonEmptyLayout times out
https://bugs.webkit.org/show_bug.cgi?id=84957
Reviewed by Martin Robinson.
- Scripts/run-gtk-tests:
(TestRunner): Unskip TestNewFirstVisuallyNonEmptyLayout and
TestNewFirstVisuallyNonEmptyLayoutForImages.
- TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView): Show the
toplevel window containing the web view to make sure events are
received.
- 9:13 AM Changeset in webkit [115321] by
-
- 5 edits2 adds in trunk
[cairo] CairoGraphicsContext fillRect (with Color) overrides composite operator
https://bugs.webkit.org/show_bug.cgi?id=84848
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-26
Reviewed by Martin Robinson.
Source/WebCore:
FillRectWithColor used to be called fillRectSourceOver before r89314
where this operator still made sense. The way this function is used
these days doesn't expect the composite operator to be overridden anymore.
No new tests, covered by existing tests, e.g.
svg/filters/feDropShadow.svg
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::fillRectWithColor):
LayoutTests:
Unskipping and baselining feDropShadow test,
now works because of composite operator fix.
Fixed png baseline result for drop shadow test on GTK.
- platform/efl/svg/filters/feDropShadow-expected.png: Added.
- platform/efl/svg/filters/feDropShadow-expected.txt: Added.
- platform/efl/test_expectations.txt:
- platform/gtk/svg/filters/feDropShadow-expected.png:
- 8:51 AM Changeset in webkit [115320] by
-
- 9 edits46 adds in trunk
Fix additive by animations for most SMIL list types
https://bugs.webkit.org/show_bug.cgi?id=84968
Reviewed by Antti Koivisto.
Source/WebCore:
Unify SMIL list animation code, to correctly respect the underlying from value for by-animations.
Add lots of new tests covering by-animations for all primitives (except AnimatedPath/TransformList).
AnimatedTransformList is not working correctly yet, and will be covered in a follow-up patch.
AnimatdPath by-animations are complex, and thus also handled in another follow-up patch.
Tests: svg/animations/additive-type-by-animation.html
svg/animations/length-list-animation-expected.svg
svg/animations/length-list-animation.svg
svg/animations/svglength-additive-by-1.html
svg/animations/svglength-additive-by-2.html
svg/animations/svglength-additive-by-3.html
svg/animations/svglength-additive-by-4.html
svg/animations/svglength-additive-by-5.html
svg/animations/svglength-additive-by-6.html
svg/animations/svglength-additive-from-by-1.html
svg/animations/svglength-additive-from-by-2.html
svg/animations/svglength-additive-from-by-3.html
svg/animations/svglength-additive-from-by-4.html
- svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
- svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
- svg/SVGAnimatedPointList.cpp:
(WebCore::SVGAnimatedPointListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):
- svg/SVGAnimationElement.h:
(WebCore::SVGAnimationElement::adjustFromToListValues):
LayoutTests:
Add lots of new tests covering SMIL by-animations on all primitives.
- svg/animations/additive-type-by-animation-expected.txt: Added.
- svg/animations/additive-type-by-animation.html: Added.
- svg/animations/length-list-animation-expected.svg: Added.
- svg/animations/length-list-animation.svg: Added.
- svg/animations/non-additive-type-by-animation-expected.txt:
- svg/animations/resources/additive-type-by-animation.svg: Added.
- svg/animations/resources/non-additive-type-by-animation.svg:
- svg/animations/resources/svglength-additive-by-1.svg: Added.
- svg/animations/resources/svglength-additive-by-2.svg: Added.
- svg/animations/resources/svglength-additive-by-3.svg: Added.
- svg/animations/resources/svglength-additive-by-4.svg: Added.
- svg/animations/resources/svglength-additive-by-5.svg: Added.
- svg/animations/resources/svglength-additive-by-6.svg: Added.
- svg/animations/resources/svglength-additive-from-by-1.svg: Added.
- svg/animations/resources/svglength-additive-from-by-2.svg: Added.
- svg/animations/resources/svglength-additive-from-by-3.svg: Added.
- svg/animations/resources/svglength-additive-from-by-4.svg: Added.
- svg/animations/script-tests/additive-type-by-animation.js: Added.
(checkBaseVal):
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/non-additive-type-by-animation.js:
(sample):
- svg/animations/script-tests/svglength-additive-by-1.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
- svg/animations/script-tests/svglength-additive-by-2.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
- svg/animations/script-tests/svglength-additive-by-3.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
- svg/animations/script-tests/svglength-additive-by-4.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
- svg/animations/script-tests/svglength-additive-by-5.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
- svg/animations/script-tests/svglength-additive-by-6.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
- svg/animations/script-tests/svglength-additive-from-by-1.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
- svg/animations/script-tests/svglength-additive-from-by-2.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
- svg/animations/script-tests/svglength-additive-from-by-3.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
- svg/animations/script-tests/svglength-additive-from-by-4.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
- svg/animations/svglength-additive-by-1-expected.txt: Added.
- svg/animations/svglength-additive-by-1.html: Added.
- svg/animations/svglength-additive-by-2-expected.txt: Added.
- svg/animations/svglength-additive-by-2.html: Added.
- svg/animations/svglength-additive-by-3-expected.txt: Added.
- svg/animations/svglength-additive-by-3.html: Added.
- svg/animations/svglength-additive-by-4-expected.txt: Added.
- svg/animations/svglength-additive-by-4.html: Added.
- svg/animations/svglength-additive-by-5-expected.txt: Added.
- svg/animations/svglength-additive-by-5.html: Added.
- svg/animations/svglength-additive-by-6-expected.txt: Added.
- svg/animations/svglength-additive-by-6.html: Added.
- svg/animations/svglength-additive-from-by-1-expected.txt: Added.
- svg/animations/svglength-additive-from-by-1.html: Added.
- svg/animations/svglength-additive-from-by-2-expected.txt: Added.
- svg/animations/svglength-additive-from-by-2.html: Added.
- svg/animations/svglength-additive-from-by-3-expected.txt: Added.
- svg/animations/svglength-additive-from-by-3.html: Added.
- svg/animations/svglength-additive-from-by-4-expected.txt: Added.
- svg/animations/svglength-additive-from-by-4.html: Added.
- 8:43 AM Changeset in webkit [115319] by
-
- 4 edits in trunk/Source/WebCore
Add copy constructor to CSSSelector
https://bugs.webkit.org/show_bug.cgi?id=84956
Reviewed by Anders Carlsson.
To copy CSSSelectorLists correctly CSSSelector needs a copy constructor.
This will be needed to implement stylesheet caching. The code is not used yet.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::createRareData):
- css/CSSSelector.h:
(CSSSelector):
(WebCore::CSSSelector::RareData::create):
(RareData):
Refcount RareData to make copying easier. This has no significant memory impact, rare data is rare.
(WebCore::CSSSelector::CSSSelector):
(WebCore):
(WebCore::CSSSelector::~CSSSelector):
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::CSSSelectorList):
Use copy constructor instead of memcpy (which doesn't work).
- 8:28 AM WebKitGTK/1.8.x edited by
- Reflect the correct versions, added a section for 1.8.2 (diff)
- 8:15 AM Changeset in webkit [115318] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Fix the build with DRAG_SUPPORT disabled.
https://bugs.webkit.org/show_bug.cgi?id=84963
Reviewed by Antonio Gomes.
No new tests, build system-related change.
EventHandlerEfl.cpp always assumed DRAG_SUPPORT was enabled and lacked
the proper #if ENABLED() checks for some member variables and methods
conditionally defined in EventHandler.h.
- page/efl/EventHandlerEfl.cpp:
(WebCore):
- 8:14 AM Changeset in webkit [115317] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: remove stackTrace property from requestWillBeSent - it is already a part of the initiator.
https://bugs.webkit.org/show_bug.cgi?id=84964
Reviewed by Yury Semikhatsky.
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):
- 8:06 AM Changeset in webkit [115316] by
-
- 19 edits16 adds in trunk
SVG FEConvolveMatrix does not check for invalid property values
https://bugs.webkit.org/show_bug.cgi?id=84363
Reviewed by Dirk Schulze.
Source/WebCore:
Adding code to check for valid input values on SVG feConvolveMatrix properties.
And adding some of the first effective error reporting for SVG elements.
Tests: svg/filters/feConvolveMatrix-invalid-targetX-expected.svg
svg/filters/feConvolveMatrix-invalid-targetX.svg
svg/filters/feConvolveMatrix-invalid-targetY-expected.svg
svg/filters/feConvolveMatrix-invalid-targetY.svg
svg/filters/feConvolveMatrix-negative-kernelUnitLengthX-expected.svg
svg/filters/feConvolveMatrix-negative-kernelUnitLengthX.svg
svg/filters/feConvolveMatrix-negative-kernelUnitLengthY-expected.svg
svg/filters/feConvolveMatrix-negative-kernelUnitLengthY.svg
svg/filters/feConvolveMatrix-negative-orderX-expected.svg
svg/filters/feConvolveMatrix-negative-orderX.svg
svg/filters/feConvolveMatrix-negative-orderY-expected.svg
svg/filters/feConvolveMatrix-negative-orderY.svg
svg/filters/feConvolveMatrix-non-integral-order-expected.svg
svg/filters/feConvolveMatrix-non-integral-order.svg
svg/filters/feConvolveMatrix-zero-divisor-expected.svg
svg/filters/feConvolveMatrix-zero-divisor.svg
- platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::FEConvolveMatrix):
(WebCore::FEConvolveMatrix::setKernelSize):
(WebCore::FEConvolveMatrix::setDivisor):
(WebCore::FEConvolveMatrix::setKernelUnitLength):
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::parseAttribute):
(WebCore::SVGFEConvolveMatrixElement::build):
LayoutTests:
Adding code to check for valid input values on SVG feConvolveMatrix properties.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/chromium-win-xp/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/efl/svg/filters/feConvolveFilter-y-bounds-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/gtk/svg/custom/convolution-crash-expected.txt:
- platform/gtk/svg/filters/feConvolveFilter-y-bounds-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/mac/svg/custom/convolution-crash-expected.txt:
- platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/qt/svg/custom/convolution-crash-expected.txt:
- platform/qt/svg/filters/feConvolveFilter-y-bounds-expected.txt:
- svg/filters/feConvolveMatrix-invalid-targetX-expected.svg: Added.
- svg/filters/feConvolveMatrix-invalid-targetX.svg: Added.
- svg/filters/feConvolveMatrix-invalid-targetY-expected.svg: Added.
- svg/filters/feConvolveMatrix-invalid-targetY.svg: Added.
- svg/filters/feConvolveMatrix-negative-kernelUnitLengthX-expected.svg: Added.
- svg/filters/feConvolveMatrix-negative-kernelUnitLengthX.svg: Added.
- svg/filters/feConvolveMatrix-negative-kernelUnitLengthY-expected.svg: Added.
- svg/filters/feConvolveMatrix-negative-kernelUnitLengthY.svg: Added.
- svg/filters/feConvolveMatrix-negative-orderX-expected.svg: Added.
- svg/filters/feConvolveMatrix-negative-orderX.svg: Added.
- svg/filters/feConvolveMatrix-negative-orderY-expected.svg: Added.
- svg/filters/feConvolveMatrix-negative-orderY.svg: Added.
- svg/filters/feConvolveMatrix-non-integral-order-expected.svg: Added.
- svg/filters/feConvolveMatrix-non-integral-order.svg: Added.
- svg/filters/feConvolveMatrix-zero-divisor-expected.svg: Added.
- svg/filters/feConvolveMatrix-zero-divisor.svg: Added.
- 8:01 AM Changeset in webkit [115315] by
-
- 2 edits in trunk/Tools
Unreviewed. Add bug numbers to skipped tests.
- Scripts/run-gtk-tests:
(TestRunner):
- 7:47 AM Changeset in webkit [115314] by
-
- 12 edits2 copies3 adds in trunk
[GTK] Build and run TestWebKitAPI WebKit2 unit tests
https://bugs.webkit.org/show_bug.cgi?id=84446
Reviewed by Philippe Normand.
Source/ThirdParty:
- gtest/GNUmakefile.am: Do not build libgtestmain anymmore since
all tests use now a custom main to make sure WTF threads are
initialized.
Source/WebKit2:
- UIProcess/API/C/WKNativeEvent.h: Define WKNativeEventPtr as
GdkEvent for the GTK+ port.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Add TestWebKitAPI/WebKit2 to the list of directories
containing tests. Unskip FunctionalTest.RefCountedStorage, since
we are now using a custom main that initializes WTF threading.
(TestRunner._setup_testing_environment): Set environment variables
required to run WebKit2 tests.
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/JavaScriptTest.cpp: Use
JavaScriptCore/JSContextRef.h instead of
JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
unconditionally.
- TestWebKitAPI/PlatformWebView.h: Define PlatformWKView and
PlatformWindow for GTK.
- TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Remove
unneded header that breaks the build of GTK port.
- TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Use
JavaScriptCore/JSContextRef.h instead of
JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
unconditionally.
- TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
(TestWebKitAPI::TEST): Add expected values for GTK+ port.
- TestWebKitAPI/gtk/InjectedBundleControllerGtk.cpp:
(TestWebKitAPI):
(TestWebKitAPI::InjectedBundleController::platformInitialize):
- TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp: Added.
(TestWebKitAPI::Util::checkTestFinished):
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::getFilenameFromEnvironmentVariableAsUTF8):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::URLForNonExistentResource):
(TestWebKitAPI::Util::isKeyDown):
- TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Added.
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::doKeyStroke):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
(TestWebKitAPI::doMouseButtonEvent):
(TestWebKitAPI::PlatformWebView::simulateRightClick):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
- TestWebKitAPI/gtk/main.cpp:
(main):
- 7:45 AM Changeset in webkit [115313] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests: Use a timeout per test instead of a global timeout
https://bugs.webkit.org/show_bug.cgi?id=84695
Reviewed by Philippe Normand.
It also adds a command line option to be able to pass a custom
timeout value, instead of hard-coding it. The default timeout is 10
seconds if no other value is passed to the script.
- Scripts/run-gtk-tests:
(TestTimeout): Exception raised when a test times out.
(TestRunner._get_child_pid_from_test_output): Helper function to
get the pid of the running test from gtester output.
(TestRunner._kill_process): Helper funtion ot kill a process
ignoring exceptions if the process is already died.
(TestRunner._run_test_command): Run the test command raising
TestTimeout exception if the test doesn't finish before the given
timeout in seconds.
(TestRunner._run_test_command.alarm_handler): Alarm handler that
raises TestTimeout exception.
(TestRunner._run_test_glib): Use _run_test_command() to run the test.
(TestRunner._run_test_google): Ditto.
(TestRunner.run_tests): Add current test to the list of timed out
test if TestTimeout exception is raised. Show the list of timed
out test at the end.
- 7:30 AM Changeset in webkit [115312] by
-
- 8 edits2 deletes in trunk/Source
Move WebKit1 specific conversion of touch-events to WebKit1.
https://bugs.webkit.org/show_bug.cgi?id=84951
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-26
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
No change in functionality. No new tests.
- Target.pri:
- platform/PlatformTouchEvent.h:
(PlatformTouchEvent):
- platform/PlatformTouchPoint.h:
(PlatformTouchPoint):
- platform/qt/PlatformTouchEventQt.cpp: Removed.
- platform/qt/PlatformTouchPointQt.cpp: Removed.
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::touchEvent):
- WebCoreSupport/WebEventConversion.cpp:
(WebKitPlatformTouchEvent):
(WebKitPlatformTouchPoint):
(WebCore::WebKitPlatformTouchEvent::WebKitPlatformTouchEvent):
(WebCore::WebKitPlatformTouchPoint::WebKitPlatformTouchPoint):
(WebCore::convertTouchEvent):
- WebCoreSupport/WebEventConversion.h:
- 7:11 AM Changeset in webkit [115311] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][WK2] Tap highlight should have a delay not to interfere with panning
https://bugs.webkit.org/show_bug.cgi?id=84948
Reviewed by Kenneth Rohde Christiansen.
Start the tap highlight animation after a slight delay so that pan
gestures do not result in flashing highlight rects which slow down
flicking, especially during continuous pan gestures.
- UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::update):
(WebKit::QtTapGestureRecognizer::highlightTimeout):
(WebKit):
(WebKit::QtTapGestureRecognizer::reset):
(WebKit::QtTapGestureRecognizer::timerEvent):
- UIProcess/qt/QtTapGestureRecognizer.h:
(QtTapGestureRecognizer):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):
- 7:08 AM April 2012 Keeping the bots green edited by
- Fix indentation, add real headings (diff)
- 7:06 AM Changeset in webkit [115310] by
-
- 10 edits in trunk/Source/WebKit2
Make it possible to use accelerated compositing for page overlay fading
https://bugs.webkit.org/show_bug.cgi?id=82336
Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2012-04-26
Reviewed by Noam Rosenthal.
Page overlay fading will use AC where possible. Otherwise, it will
fall back to the previous method of redrawing each frame in the animation.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setPageOverlayOpacity):
(DrawingArea):
(WebKit::DrawingArea::pageOverlayShouldApplyFadeWhenPainting):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setPageOverlayOpacity):
(WebKit):
(WebKit::DrawingAreaImpl::pageOverlayShouldApplyFadeWhenPainting):
- WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
- WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::setPageOverlayOpacity):
(WebKit::LayerTreeHost::pageOverlayShouldApplyFadeWhenPainting):
- WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::PageOverlay):
(WebKit::PageOverlay::setPage):
(WebKit::PageOverlay::fadeAnimationTimerFired):
- WebProcess/WebPage/PageOverlay.h:
- WebProcess/WebPage/TapHighlightController.cpp:
(WebKit::TapHighlightController::drawRect):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setPageOverlayOpacity):
(WebKit):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
(WebKit::LayerTreeHostQt::pageOverlayShouldApplyFadeWhenPainting):
- 7:05 AM Changeset in webkit [115309] by
-
- 2 edits in trunk/LayoutTests
[EFL][DRT] Unskip media tests that were already fixed in r113178
https://bugs.webkit.org/show_bug.cgi?id=84947
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-26
- platform/efl/Skipped: Removed a group of media tests.
- 6:55 AM Changeset in webkit [115308] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] A quick fix to the previous patch r115245.
https://bugs.webkit.org/show_bug.cgi?id=84862
Patch by Yong Li <yoli@rim.com> on 2012-04-26
Reviewed by Antonio Gomes.
Fix an obvious bug in previous patch: DeferredTaskLoadManualScript
was using a wrong flag.
- Api/WebPage.cpp:
- Api/WebPage_p.h:
(WebPagePrivate):
- 6:43 AM Changeset in webkit [115307] by
-
- 5 edits in trunk
[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=83880
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-26
Reviewed by Antonio Gomes.
Tools:
Add missing implementation addOriginAccessWhitelistEntry and
removeOriginAccessWhitelistEntry to EFL's LayoutTestController
in order to unskip tests which rely on this.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):
LayoutTests:
Unskip test cases which rely on LayoutTestController's addOriginAccessWhitelistEntry
and removeOriginAccessWhitelistEntry implementation.
- platform/efl/Skipped:
- 6:34 AM Changeset in webkit [115306] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] WebGL support ewk_view setting
https://bugs.webkit.org/show_bug.cgi?id=84534
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-04-26
Reviewed by Antonio Gomes.
Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support.
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_webgl_get):
(ewk_view_setting_enable_webgl_set):
- ewk/ewk_view.h:
- 6:14 AM Changeset in webkit [115305] by
-
- 14 edits in trunk/Source/WebCore
Share code used to animate numbers types between all animators
https://bugs.webkit.org/show_bug.cgi?id=84945
Reviewed by Antti Koivisto.
Refactor animateAdditiveNumber() from SVGAnimatedNumberAnimator into SVGAnimationElement,
to reuse it for all primitives. Converted most primitives to use the new code. Lists, paths,
colors are still todo.
Doesn't affect any tests.
- svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
- svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedInteger):
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):
- svg/SVGAnimatedInteger.h:
(SVGAnimatedIntegerAnimator):
- svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateAnimatedValue):
- svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
- svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
- svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue):
- svg/SVGAnimatedNumber.h:
- svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
- svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):
- svg/SVGAnimatedNumberOptionalNumber.h:
- svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue):
- svg/SVGAnimationElement.h:
(WebCore::SVGAnimationElement::animateAdditiveNumber):
(SVGAnimationElement):
- 5:08 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 4:59 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 4:52 AM Changeset in webkit [115304] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] r115300 broke the Qt build on Mac OS X.
This patch adds guards around the createPluginContainer and
windowedPluginGeometryDidChange member functions in WebPageProxy.
Unreviewed build fix.
- UIProcess/qt/WebPageProxyQt.cpp:
(WebKit):
- 4:51 AM Changeset in webkit [115303] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: [CRASH] WebViewImpl::setZoomLevel when emulating device metrics
https://bugs.webkit.org/show_bug.cgi?id=84938
Check for the presence of a live Frame/FrameView before invoking methods that depend on them.
Reviewed by Yury Semikhatsky.
- src/WebDevToolsAgentImpl.cpp:
(WebKit::DeviceMetricsSupport::restore):
- 4:45 AM Changeset in webkit [115302] by
-
- 2 edits in trunk/Source/WebCore
Forgotten build fix after r115227.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::get4Values):
- 4:42 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 4:01 AM Changeset in webkit [115301] by
-
- 3 edits2 adds in trunk/Tools
[GTK] Add downloads support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=73662
Reviewed by Philippe Normand.
- MiniBrowser/gtk/BrowserDownloadsBar.c: Added.
(browserDownloadsBarChildRemoved): Close the downloads bar if
there aren't active downloads.
(browserDownloadsBarResponse): Destroy the downloads bar when
closed.
(browser_downloads_bar_init):
(browser_downloads_bar_class_init):
(browser_downloads_bar_new): Create a new downloads bar.
(actionButtonClicked): Cancel the download if cancel button was
clicked, or open the downloaded file if the download finished.
(browserDownloadFinalize):
(browser_download_init):
(browser_download_class_init):
(downloadReceivedResponse): Update download message using the
response URI.
(remainingTime): Helper function to get human readable remaining
time.
(downloadProgress): Update downloads progress.
(downloadReceivedData):
(downloadFinished): Update download message and turn download
button into open.
(downloadFailed): Show error message or destroy the download UI if
it was cancelled.
(browserDownloadNew): Create a new download widget for the given
WebKitDownload.
(browser_downloads_bar_add_download): Add download widget to the
downloads bar.
- MiniBrowser/gtk/BrowserDownloadsBar.h: Added.
- MiniBrowser/gtk/BrowserWindow.c:
(downloadStarted): Create a download widget and add it to the
downloads bar when a new download is started.
(browserWindowConstructed): Connect to
WebKitWebContext::download-started signal.
- MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
- 3:58 AM Changeset in webkit [115300] by
-
- 18 edits in trunk/Source/WebKit2
[GTK][WebKit2] Initial windowed plugins implementation
https://bugs.webkit.org/show_bug.cgi?id=61065
Reviewed by Philippe Normand.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::createPluginContainer):
(WebKit::PluginControllerProxy::windowedPluginGeometryDidChange):
- PluginProcess/PluginControllerProxy.h:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseContainerAdd): Implement GtkContainer::add().
(webkitWebViewBaseContainerRemove): Implement GtkContainer::remove().
(webkitWebViewBaseContainerForall): Implement GtkContainer::forall().
(webkitWebViewBaseChildMoveResize): Set a new geometry for a child widget.
(webkitWebViewBaseChildAllocate): Allocate a child widget.
(resizeWebKitWebViewBaseFromAllocation): Allocate child widgets.
(webkit_web_view_base_class_init):
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Add webkitWebViewBaseSizeAllocate().
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Add createPluginContainer
and windowedPluginGeometryDidChange messages.
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::pluginWindowMap):
(WebKit::pluginContainerPlugRemoved): Remove the socket from the
hash map when its plug is removed.
(WebKit::WebPageProxy::createPluginContainer): Create a GtkSocket
as container widget for windowed plugins.
(WebKit::WebPageProxy::windowedPluginGeometryDidChange): Call
webkitWebViewBaseSizeAllocate() to update the plugin widget
geometry.
- UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::createPluginContainer):
(WebKit::WebPageProxy::windowedPluginGeometryDidChange):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::socketPlugRemovedCallback): Return TRUE to avoid the
socket to be destroyed, since we need to reuse it.
(WebKit::NetscapePlugin::platformPostInitializeWindowed): Ask the
ui process to create a plugin container.
(WebKit::NetscapePlugin::platformPostInitializeWindowless):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformGeometryDidChange): For windowed
plugins notify the ui process that the plugin geometry has
changed.
(WebKit::NetscapePlugin::platformPaint): Do nothing for windowed
plugins, the caller already calls callSetWindow().
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::createPluginContainer):
(WebKit::PluginProxy::windowedPluginGeometryDidChange):
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginProxy.messages.in:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::createPluginContainer):
(WebKit::PluginView::windowedPluginGeometryDidChange):
- WebProcess/Plugins/PluginView.h:
- 3:27 AM Changeset in webkit [115299] by
-
- 2 edits2 deletes in trunk/LayoutTests
http/tests/security/cross-frame-access-put.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82751
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-26
Reviewed by Kentaro Hara.
- http/tests/security/cross-frame-access-put-expected.txt: Correct
expected value for window.frameElement. It is now 'null' instead of
'undefined' when shouldAllowAccessToNode() check fails, since bug
80205 fix.
- platform/gtk/http/tests/security/cross-frame-access-put-expected.txt: Removed.
It is now identifical to the global expectation.
- platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Removed. Ditto.
- 2:35 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 2:33 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 1:32 AM Changeset in webkit [115298] by
-
- 2 edits in trunk/Tools
Unreviewed. Skip unit test failing in debug bot.
- Scripts/run-gtk-tests:
(TestRunner):
- 12:59 AM Changeset in webkit [115297] by
-
- 5 edits2 adds in trunk
Crash when collecting svg symbol element in named flow.
https://bugs.webkit.org/show_bug.cgi?id=84493
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/regions/symbol-in-named-flow-crash.svg
- dom/Element.cpp:
(WebCore::Element::~Element):
Add an assert that an element that was collected into a named flow was already removed at this point
(when the document is not in the process of destruction)
(WebCore::Element::unregisterNamedFlowContentNode):
Created a new function for unregistering a content node. In the future, this function may be used for
content nodes from shadow dom.
(WebCore::Element::detach):
- dom/Element.h:
(Element):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
Prevent elements that are part of shadow dom to be collected into a named flow.
LayoutTests:
- fast/regions/symbol-in-named-flow-crash-expected.txt: Added.
- fast/regions/symbol-in-named-flow-crash.svg: Added.
- 12:52 AM Changeset in webkit [115296] by
-
- 11 edits4 adds in trunk
Share code used to animate discrete types between all animators
https://bugs.webkit.org/show_bug.cgi?id=84853
Reviewed by Andreas Kling.
Source/WebCore:
Share by-animation handling for non-additive types in a central method in SVGAnimatedTypeAnimator,
to be reusable by SVGAnimatedBoolean/Enumeration/PreserveAspectRatio/String. Add a new test covering
these animations have no effect.
Test: svg/animations/non-additive-type-by-animation.html
- svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::isAdditive):
- svg/SVGAnimateElement.h:
(SVGAnimateElement):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::calculateFromAndByValues):
- svg/SVGAnimatedBoolean.cpp:
(WebCore::isTrueString):
(WebCore::SVGAnimatedBooleanAnimator::constructFromString):
(WebCore::SVGAnimatedBooleanAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue):
- svg/SVGAnimatedEnumeration.cpp:
(WebCore::SVGAnimatedEnumerationAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):
- svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue):
- svg/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedStringAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::startedActiveInterval):
- svg/SVGAnimationElement.h:
(SVGAnimationElement):
(WebCore::SVGAnimationElement::animateDiscreteType):
LayoutTests:
Add tests covering by-animation on non-additive types, which should have no effect.
- svg/animations/non-additive-type-by-animation-expected.txt: Added.
- svg/animations/non-additive-type-by-animation.html: Added.
- svg/animations/resources/non-additive-type-by-animation.svg: Added.
- svg/animations/script-tests/non-additive-type-by-animation.js: Added.
(sample):
(executeTest):
- 12:37 AM Changeset in webkit [115295] by
-
- 4 edits in trunk/Source
CrashTracer: [USER] 157 crashes in WebProcess at com.apple.WebCore: WebCore::AccessibilityRenderObject::isAttachment const + 29
https://bugs.webkit.org/show_bug.cgi?id=84463
Reviewed by Darin Adler.
Source/WebCore:
Accessibility was not being enabled when WK2 was asking only for the focused UI element.
No layout test could be written because the WKTestRunner mechanism works differently when asking for this.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::rootObject):
(WebCore::AXObjectCache::rootObjectForFrame):
Source/WebKit2:
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(WebKit):
- 12:09 AM Changeset in webkit [115294] by
-
- 8 edits in trunk
[EFL][DRT] "resource,request,willsend" signal needs to provide more information
https://bugs.webkit.org/show_bug.cgi?id=84670
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-26
Reviewed by Andreas Kling.
Source/WebKit/efl:
The "resource,request,willsend" signal now provides more information
about the network request as well as information about the possible
redirect response. This extra information will be needed to support
LayoutTestController's dumpResourceLoadCallbacks() in EFL's
DumpRenderTree.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
- ewk/ewk_frame.cpp:
(ewk_frame_request_will_send):
- ewk/ewk_frame.h:
- ewk/ewk_private.h:
- ewk/ewk_view.h:
Tools:
Handle in EFL's DumpRenderTree the new Ewk_Frame_Resource_Messages now
passed with the "resource,request,willsend" signal and dump
information about the network request and the possible network
response if LayoutTestController's dumpResourceLoadCallbacks() returns
true.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(pathSuitableForTestResult):
(urlSuitableForTestResult):
(descriptionSuitableForTestResult):
(DumpRenderTreeChrome::onWillSendRequest):
- 12:02 AM Changeset in webkit [115293] by
-
- 8 edits in trunk
[Qt][WK2] Unreviewed, rolling out r113703 because of crashing tests.
http://trac.webkit.org/changeset/113703
https://bugs.webkit.org/show_bug.cgi?id=83024
Tools:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- Tools.pro:
- qmake/mkspecs/features/features.prf:
- qmake/mkspecs/features/functions.prf:
LayoutTests:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
Apr 25, 2012:
- 11:27 PM Changeset in webkit [115292] by
-
- 2 edits in trunk/Tools
Teach LayoutTestHelper to correctly restore the color profile when it's a factory profile
https://bugs.webkit.org/show_bug.cgi?id=84931
Reviewed by Filip Pizlo.
- DumpRenderTree/mac/LayoutTestHelper.m:
(installLayoutTestColorProfile): Account for the possibility of the default
profile being a factory profile.
- 11:19 PM Styling Form Controls edited by
- autofill (diff)
- 10:44 PM Changeset in webkit [115291] by
-
- 7 edits1 delete in trunk/Source
[chromium] Remove guarded virtual methods from WebFilterOperation API
https://bugs.webkit.org/show_bug.cgi?id=84926
Reviewed by James Robinson.
Source/Platform:
We remove the virtual methods from the WebFilterOperation class,
and use an enum in the base class to distinguish which subclass
the object is. Then WebFilterOperations can access the correct
subclass to get the filter operation's data and construct a
WebCore::FilterOperation to store internally.
- chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::WebFilterOperation):
(WebKit::WebBasicColorMatrixFilterOperation::WebBasicColorMatrixFilterOperation):
(WebBasicColorMatrixFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::WebBasicComponentTransferFilterOperation):
(WebBasicComponentTransferFilterOperation):
(WebKit::WebBlurFilterOperation::WebBlurFilterOperation):
(WebKit::WebDropShadowFilterOperation::WebDropShadowFilterOperation):
Source/WebCore:
- WebCore.gypi:
- platform/chromium/support/WebFilterOperation.cpp: Removed.
- platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebFilterOperations::append):
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
- 10:27 PM Changeset in webkit [115290] by
-
- 13 edits in trunk/Source
Add a version of StringImpl::find() without offset
https://bugs.webkit.org/show_bug.cgi?id=83968
Source/JavaScriptCore:
Reviewed by Sam Weinig.
Add support for the new StringImpl::find() to UString.
Change stringProtoFuncIndexOf() to specifically take advatage of the feature.
This gives a 12% gains on a distribution of strings between 30 and 100 characters.
- runtime/StringPrototype.cpp:
(JSC::substituteBackreferences):
(JSC::stringProtoFuncIndexOf):
- runtime/UString.h:
(UString):
(JSC::UString::find):
Source/WebCore:
Reviewed by Sam Weinig.
Remove the zero offset of the find() functions on strings.
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
- platform/network/ResourceResponseBase.cpp:
(WebCore::trimToNextSeparator):
(WebCore::parseCacheHeader):
Source/WebKit2:
Update the symbols files.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
Source/WTF:
Reviewed by Sam Weinig.
This patch add a version of StringImpl::find() without offset, Instead of using the default
value for the index.
By not having the index, we can skip a couple of branches and a few instructions. This gives
significant gains when the strings are short-ish.
The case of empty string is moved below (matchLength == 1) since it is a less common operation.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::find):
(WTF):
- wtf/text/StringImpl.h:
(StringImpl):
- wtf/text/WTFString.h:
(String):
(WTF::String::find):
- 10:17 PM Changeset in webkit [115289] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[Blackberry] add a new function in BackingStore
https://bugs.webkit.org/show_bug.cgi?id=84818
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-04-25
Reviewed by Antonio Gomes.
Adding two functions in BackingStorePrivate and
BackingStore, which could render out webpage contents
into BlackBerry::Platform::Graphics::Drawable.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(WebKit):
(BlackBerry::WebKit::BackingStore::drawContents):
- Api/BackingStore.h:
- Api/BackingStore_p.h:
(BackingStorePrivate):
- 10:08 PM Changeset in webkit [115288] by
-
- 10 edits in trunk/Source
WebCore shouldn't call collectAllGarbage directly
https://bugs.webkit.org/show_bug.cgi?id=84897
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Exported symbol
for reportAbanondedObjectGraph so WebCore can use it.
- heap/Heap.h: Ditto.
Source/WebCore:
No new tests.
Currently, GCController calls Heap::collectAllGarbage directly, which leads
to an overload of collections as the timer in GCController and the timer in
GCActivityCallback compete for collection time and fire independently. As a
result, we end up doing almost 600 full collections during an in-browser run
of SunSpider, or 20 full collections on a single load of TechCrunch.
We can do better by preventing WebCore from calling collectAllGarbage directly
and instead going through Heap::reportAbandonedObjectGraph, since that is what
WebCore is trying to do--notify the Heap that a lot of garbage may have just
been generated when we left a page.
- WebCore.exp.in:
- bindings/js/GCController.cpp: Removed all timer stuff.
(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon): Changed to call Heap::reportAbandonedObjectGraph.
(WebCore::GCController::garbageCollectNow): Changed to still directly call collectAllGarbage.
We will deprecate this function soon hopefully.
- bindings/js/GCController.h: Removed timer stuff.
(GCController):
- bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectGarbage): Changed to call garbageCollectSoon.
Source/WebKit2:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose): Changed to call garbageCollectSoon. This is the
function that causes us to do so much collection on page navigation.
- 10:07 PM Changeset in webkit [115287] by
-
- 2 edits in trunk/LayoutTests
fast/js/random-array-gc-stress times out in debug mode
https://bugs.webkit.org/show_bug.cgi?id=84821
Reviewed by Geoffrey Garen.
- fast/js/script-tests/random-array-gc-stress.js: Trying a lower number of iterations
to make the slow bots happy.
- 9:57 PM Changeset in webkit [115286] by
-
- 3 edits1 delete in trunk/Tools
Unreviewed, rolling out r115240.
http://trac.webkit.org/changeset/115240
https://bugs.webkit.org/show_bug.cgi?id=84928
It broke everything (Requested by Ossy_HOME on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-25
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver):
(GtkDriver._start):
(GtkDriver._start.x_filter):
(GtkDriver.stop):
(GtkPort._driver_class):
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._build_driver):
- Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Removed.
- 9:50 PM Changeset in webkit [115285] by
-
- 5 edits in trunk/Source
[chromium] REGRESSION(112286) Compositor initialization blocks for program compilation / linking
https://bugs.webkit.org/show_bug.cgi?id=84822
Patch by James Robinson <jamesr@chromium.org> on 2012-04-25
Reviewed by Adrienne Walker.
Source/WebCore:
r112286 introduced a subtle regression in the chromium compositor startup sequence - by querying the texture
copy program's uniform location at the end of LayerRendererChromium::initialize(), the compositor's thread was
blocked until the service side compiled _all_ eagerly initialized shaders. The intent of the way the compositor
programs are created is that a set of commonly-used programs are sent to the service side, but no blocking calls
are made until after we go through the first paint (with the hope that the service side will complete the
compilation by then).
Fixed by moving program initialization (which also grabs uniform locations) until the first actual use of the
copier. It may be worth deferring the program initialization completely if it's not used very often.
Added unit test in LayerRendererChromiumTests to make sure LRC initialization does not make any
synchronous calls (like getUniformLocation()).
- platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):
Source/WebKit/chromium:
Add a test that makes sure we don't make blocking calls during LayerRendererChromium initialization.
- tests/LayerRendererChromiumTest.cpp:
(ForbidSynchronousCallContext):
(ForbidSynchronousCallContext::ForbidSynchronousCallContext):
(ForbidSynchronousCallContext::finish):
(ForbidSynchronousCallContext::getActiveAttrib):
(ForbidSynchronousCallContext::getActiveUniform):
(ForbidSynchronousCallContext::getAttachedShaders):
(ForbidSynchronousCallContext::getAttribLocation):
(ForbidSynchronousCallContext::getBooleanv):
(ForbidSynchronousCallContext::getBufferParameteriv):
(ForbidSynchronousCallContext::getContextAttributes):
(ForbidSynchronousCallContext::getError):
(ForbidSynchronousCallContext::getFloatv):
(ForbidSynchronousCallContext::getFramebufferAttachmentParameteriv):
(TEST):
- 9:03 PM Changeset in webkit [115284] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Authenticated proxy isn't working.
https://bugs.webkit.org/show_bug.cgi?id=84579
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-25
Reviewed by Antonio Gomes.
We should try to get username and password from WiFi advanced configuration first
when 407 is received.
No new tests. This is covered by existing http tests when proxy's username and password
are configured for WiFi.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
- 7:26 PM Changeset in webkit [115283] by
-
- 10 edits in trunk/LayoutTests
Rebaseline *.png pixel test files after bug 84649 fix
https://bugs.webkit.org/show_bug.cgi?id=84905
Patch by David Barton <Dave Barton> on 2012-04-25
Reviewed by Beth Dakin.
- platform/mac/mathml/presentation/fenced-expected.png:
- platform/mac/mathml/presentation/fenced-mi-expected.png:
- platform/mac/mathml/presentation/mo-expected.png:
- platform/mac/mathml/presentation/mo-stretch-expected.png:
- platform/mac/mathml/presentation/over-expected.png:
- platform/mac/mathml/presentation/row-alignment-expected.png:
- platform/mac/mathml/presentation/row-expected.png:
- platform/mac/mathml/presentation/sub-expected.png:
- platform/mac/mathml/presentation/subsup-expected.png:
- 7:23 PM Changeset in webkit [115282] by
-
- 14 edits3 adds in trunk
IndexedDB: implement cursor.advance()
https://bugs.webkit.org/show_bug.cgi?id=84174
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-25
Reviewed by Ojan Vafai.
Source/WebCore:
Implement IDBCursor.advance() to spec.
Test: storage/indexeddb/cursor-advance.html
- Modules/indexeddb/IDBBackingStore.h:
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance):
(WebCore):
- Modules/indexeddb/IDBCursor.h:
(IDBCursor):
- Modules/indexeddb/IDBCursor.idl:
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::advance):
(WebCore):
(WebCore::IDBCursorBackendImpl::advanceInternal):
- Modules/indexeddb/IDBCursorBackendImpl.h:
(IDBCursorBackendImpl):
- Modules/indexeddb/IDBCursorBackendInterface.h:
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):
Source/WebKit/chromium:
Hook up chromium IPC to IDBCursor.advance().
- src/IDBCursorBackendProxy.cpp:
(WebKit::IDBCursorBackendProxy::advance):
(WebKit):
- src/IDBCursorBackendProxy.h:
(IDBCursorBackendProxy):
- src/WebIDBCursorImpl.cpp:
(WebKit::WebIDBCursorImpl::advance):
LayoutTests:
Tests for cursor.advance().
- storage/indexeddb/cursor-advance-expected.txt: Added.
- storage/indexeddb/cursor-advance.html: Added.
- storage/indexeddb/resources/cursor-advance.js: Added.
(test):
(openSuccess):
(createAndPopulateObjectStore):
(makeAdvanceTest.continueToTest):
(makeAdvanceTest.request.onerror):
(makeAdvanceTest):
(mkCursor):
(runTest):
(testAll):
(testSimple):
(testContinueThenAdvance):
(testAdvanceMultiple):
(testAdvanceToEnd):
- 7:06 PM Changeset in webkit [115281] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Hold video provider lock from willDraw to didDraw
https://bugs.webkit.org/show_bug.cgi?id=84805
Reviewed by James Robinson.
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
- 7:02 PM Changeset in webkit [115280] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Input Range element expects mouse events
https://bugs.webkit.org/show_bug.cgi?id=84571
Reviewed by Antonio Gomes.
This just cleans up the code a bit to make it less code and more readable.
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::shouldConvertTouchToMouse):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::spellCheck):
- 6:56 PM Changeset in webkit [115279] by
-
- 14 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r115262.
http://trac.webkit.org/changeset/115262
https://bugs.webkit.org/show_bug.cgi?id=84631
r115262 is causing link error in WebKit Win Builder (dbg)
- public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore):
- public/WebIDBIndex.h:
(WebKit::WebIDBIndex::keyPath):
(WebKit::WebIDBIndex::keyPathString):
- public/WebIDBKeyPath.h:
(WebKit):
(WebIDBKeyPath):
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::keyPath):
(WebKit::WebIDBObjectStore::keyPathString):
(WebKit::WebIDBObjectStore::createIndex):
- public/platform/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):
- src/IDBIndexBackendProxy.cpp:
(WebKit::IDBIndexBackendProxy::keyPath):
- src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::keyPath):
- src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
- src/WebIDBIndexImpl.cpp:
- src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
- src/WebIDBKeyPath.cpp:
(WebKit::WebIDBKeyPath::create):
(WebKit::WebIDBKeyPath::assign):
(WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&):
- src/WebIDBObjectStoreImpl.cpp:
- src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
(WebKit::WebIDBObjectStoreImpl::createIndex):
- 6:48 PM Changeset in webkit [115278] by
-
- 12 edits in trunk/Source
[chromium] Prevent CCLayerImpl::willDraw/didDraw mismatches
https://bugs.webkit.org/show_bug.cgi?id=84812
Reviewed by James Robinson.
Source/WebCore:
Because some layers lock/unlock resources, it needs to be guaranteed
that if willDraw is called on a layer then didDraw will also be called
on that layer before another willDraw or before layer destruction. Add
asserts to make sure that this is the case.
willDraw is called via CCLayerTreeHostImpl::prepareToDraw ->
calculateRenderPasses. didDraw was previously called in
CCLayerTreeHostImpl::drawLayers. Sometimes drawLayers was being
skipped by the caller of these functions based on what prepareToDraw
returned (causing didDraw to not be called). Fix this by having an
explicit step to call didDraw on all layers. This new didDrawAllLayers
function must be called if and only if prepareToDraw is called.
Tested by existing tests via new asserts in CCLayerImpl.
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
(WebCore::CCLayerImpl::willDraw):
(WebCore):
(WebCore::CCLayerImpl::didDraw):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::willDraw):
(WebCore::CCScrollbarLayerImpl::didDraw):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
(WebCore::CCTextureLayerImpl::willDraw):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::didDraw):
Source/WebKit/chromium:
Update all tests to call CCLayerTreeHostImpl::didDrawAllLayers if they
call CCLayerTreeHostImpl::prepareToDraw.
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::initializeLayerRendererAndDrawFrame):
(WebKitTests::TEST_F):
- 6:26 PM Changeset in webkit [115277] by
-
- 2 edits in branches/chromium/1084/Source/WebCore/css
Merge 114699 - REGRESSION(r112177): Numbered list item rendered bulleted
https://bugs.webkit.org/show_bug.cgi?id=84216
NOTE: CSSParser.cpp:3663 modified as this patch depends on another one that
was not merged to this branch.
Patch by David Barr <davidbarr@chromium.org> on 2012-04-19
Reviewed by Ryosuke Niwa.
Shorthands that imply omitted values cannot be derived from
an incomplete set of longhand rules.
No new tests; updated existing tests that should have caught this.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTransformOriginShorthand):
Set implicit initial for Z when omitted.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10225019
- 6:26 PM Changeset in webkit [115276] by
-
- 7 edits in trunk
Calendar Picker: Resize to minimal size to fit the content
https://bugs.webkit.org/show_bug.cgi?id=84826
Reviewed by Hajime Morita.
.:
- ManualTests/forms/calendar-picker.html:
Sync with the size specified in CalendarPickerElement.cpp.
Source/WebCore:
Using fixed-size popup isn't nice. The calender picker popup size should
be minimal.
The minimal size depends on font settings, localized labels, and
localized formats. So we put visible objects on a transparent element,
calculate minimal size, resize the popup, then show the objects.
- Resources/calendarPicker.css:
(body): Don't use purple. It was for debugging purpose.
The body is visible for a short period becuse we use transparent element.
(#main):
- Add nowrap to avoid text wrapping.
- Add wider width to avoid wrapping.
- Add opacity to hide incomplete layout.
(.year-month-upper): Don't set flexible box yet.
(.month-selector-box): Fix incorrect display value.
(.days-area):
Don't set table-layout:fixed and width:100% in order that it has the
minimal width.
- Resources/calendarPicker.js:
(initialize): Make a new functio to resize.
(fixWindowSize):
Compute the required width from the right edge of the next year button,
the maximum cell width, and so on. Then, set CSS properties to have
correct layout.
(YearMonthController.prototype.attachTo):
Set min-width property for a long year-month string.
(YearMonthController.prototype._showPopup):
Center the _monthPopup vertically.
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::contentSize):
Specify small size for the initial size. It's better than showing a
large window then shrink the size.
- page/PagePopupClient.h:
(PagePopupClient): Remove a false comment. We should support resize*().
- 6:18 PM Changeset in webkit [115275] by
-
- 5 edits3 deletes in trunk
Unreviewed, rolling out r115260.
http://trac.webkit.org/changeset/115260
https://bugs.webkit.org/show_bug.cgi?id=84467
r115260 is crashing a list of IndexDB tests, revert.
Source/WebCore:
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):
- platform/leveldb/LevelDBTransaction.cpp:
(WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
(WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):
- platform/leveldb/LevelDBTransaction.h:
(TransactionIterator):
LayoutTests:
- storage/indexeddb/cursor-added-bug-expected.txt: Removed.
- storage/indexeddb/cursor-added-bug.html: Removed.
- storage/indexeddb/resources/cursor-added-bug.js: Removed.
- 6:17 PM Changeset in webkit [115274] by
-
- 11 edits6 copies in trunk/Source/WebCore
[Web Timing] Add a vendor-prefixed Performance Timeline API
https://bugs.webkit.org/show_bug.cgi?id=80350
As described here: http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html
The API is there and should be correct, but it isn't particularly useful,
because nothing is populated. Upcoming changes will add Navigation Timing
and Resource Timing.
Reviewed by Tony Gentilcore.
No new tests. Functionality is disabled on all platforms.
- CMakeLists.txt: Added PerformanceEntry* files.
- DerivedSources.pri: Ditto.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- page/Performance.cpp:
(WebCore::Performance::webkitGetEntries): Added.
(WebCore::Performance::webkitGetEntriesByType): Added.
(WebCore::Performance::webkitGetEntriesByName): Added.
- page/Performance.h:
(Performance):
- page/Performance.idl:
- page/PerformanceEntry.cpp: Added.
(WebCore):
(WebCore::PerformanceEntry::PerformanceEntry):
(WebCore::PerformanceEntry::name):
(WebCore::PerformanceEntry::entryType):
(WebCore::PerformanceEntry::startTime):
(WebCore::PerformanceEntry::duration):
- page/PerformanceEntry.h: Added.
(WebCore):
(PerformanceEntry):
- page/PerformanceEntry.idl: Added.
- page/PerformanceEntryList.cpp: Added.
(WebCore):
(WebCore::PerformanceEntryList::PerformanceEntryList):
(WebCore::PerformanceEntryList::~PerformanceEntryList):
(WebCore::PerformanceEntryList::length):
(WebCore::PerformanceEntryList::item):
(WebCore::PerformanceEntryList::append):
- page/PerformanceEntryList.h: Added.
(WebCore):
(PerformanceEntryList):
(WebCore::PerformanceEntryList::create):
- page/PerformanceEntryList.idl: Added.
- 6:16 PM Changeset in webkit [115273] by
-
- 5 edits in trunk/LayoutTests
Remove unnecessary timeouts (and closures) from content-element-in-* tests.
https://bugs.webkit.org/show_bug.cgi?id=84896
These tests don't need any of them. Not sure how they got there in the first place. Oh wait. I reviewed this code. /me hands head in shame.
Reviewed by Ojan Vafai.
- fast/dom/shadow/content-element-in-media-element.html: Removed the timeout and extra closures.
- fast/dom/shadow/content-element-in-meter-element.html: Ditto.
- fast/dom/shadow/content-element-in-progress-element.html: Ditto.
- fast/dom/shadow/content-element-in-select-element.html: Ditto.
- 6:13 PM Changeset in webkit [115272] by
-
- 2 edits in trunk/Source/WTF
Iterating a HashMap<String, X> involves a string equality comparison to check for the empty value
https://bugs.webkit.org/show_bug.cgi?id=84524
Reviewed by Antti Koivisto.
- wtf/HashMap.h: Added a struct template, HashMapValueTraits, that derives from
PairHashTraits, adds an isEmptyValue function that looks only at the key, not
the mapped value, in the hash table value, and uses the isHashTraitsEmptyValue
function template to check if the key is empty.
- 6:11 PM Changeset in webkit [115271] by
-
- 2 edits in trunk/Source/WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=84913
WebKit 1: Initialize deviceScaleFactor on creation of the WebView
-and corresponding-
<rdar://problem/11322716>
Reviewed by Darin Adler.
Before this patch, we weren't setting the deviceScaleFactor until
viewDidMoveToWindow which is quite late for background tabs. setHostWindow will
happen early on though. For applications that don't use host windows, also set it
from _initWithFrame.
- WebView/WebView.mm:
(-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
(-[WebView setHostWindow:]):
(-[WebView _deviceScaleFactor]):
- 6:07 PM Changeset in webkit [115270] by
-
- 4 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=84909
Background tabs are fuzzy until repaint when deviceScaleFactor > 1
-and corresponding-
<rdar://problem/11312064>
Rubber-stamped by Darin Adler.
Re-order the parameters of paintBitmapContext to match paintImage.
- Platform/cg/CGUtilities.cpp:
(WebKit::paintBitmapContext):
- Platform/cg/CGUtilities.h:
(WebKit):
- UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::resetScrolledRect):
(WebKit::BackingStore::paint):
(WebKit::BackingStore::backingStoreContext):
- 6:06 PM Changeset in webkit [115269] by
-
- 4 edits in trunk/Source/WebCore
Move convertJSMethodNameToObjc() to be a utility function of ObjcClass
https://bugs.webkit.org/show_bug.cgi?id=84915
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-25
Reviewed by Darin Adler.
The function convertJSMethodNameToObjc() is only useful for ObjcClass::methodsNamed().
This patch moves the function from objc_utility.mm to be a static function in objc_class.mm.
It aims at simplifying the code for future changes of ObjcClass.
- bridge/objc/objc_class.mm:
(Bindings):
(JSC::Bindings::convertJSMethodNameToObjc):
- bridge/objc/objc_utility.h:
- bridge/objc/objc_utility.mm:
(Bindings):
- 6:03 PM Changeset in webkit [115268] by
-
- 4 edits in trunk/Tools
[chromium] change DRT's "DRT" output to match the other ports
https://bugs.webkit.org/show_bug.cgi?id=84904
Reviewed by Kent Tamura.
Since we run Chromium's DRT in --test-shell mode, the
non-test-shell output has never been really beaten on to make
sure it's right. This fixes a few issues and will be tested
with upcoming NRWT changes that'll land in a separate patch.
In particular we should never output framing text like "\n"
or "#EOF" outside of something outside of TestEventPrinter,
and we weren't handling audio output properly at all.
- DumpRenderTree/chromium/TestEventPrinter.cpp:
(DRTPrinter):
(TestShellPrinter):
(DRTPrinter::handleTextFooter):
(DRTPrinter::handleAudioFooter):
(DRTPrinter::handleTestFooter):
(TestShellPrinter::handleAudioFooter):
- DumpRenderTree/chromium/TestEventPrinter.h:
(TestEventPrinter):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::dump):
- 6:03 PM Changeset in webkit [115267] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Sort Xcode project file.
- WebCore.xcodeproj/project.pbxproj:
- 5:46 PM Changeset in webkit [115266] by
-
- 4 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=84909
Background tabs are fuzzy until repaint when deviceScaleFactor > 1
-and corresponding-
<rdar://problem/11312064>
Reviewed by Darin Adler.
BackingStoreMac paints into a Bitmap instead of a CGLayer when there is no
containing window. That bitmap is used for the initial paint when a background tab
first comes to he foreground, so it needs to be HiDPI-aware.
paintBitmapContext() now takes a scale factor that it passes along to paintImage
rather than hardcoding a scale factor of 1 for paintImage.
- Platform/cg/CGUtilities.cpp:
(WebKit::paintBitmapContext):
- Platform/cg/CGUtilities.h:
(WebKit):
When these functions fall into the bitmap case, they need to adopt the device
scale factor, which means they need to scale in size by the scale factor, and also
scale their context.
- UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::resetScrolledRect):
(WebKit::BackingStore::paint):
(WebKit::BackingStore::backingStoreContext):
- 5:29 PM Changeset in webkit [115265] by
-
- 9 edits1 delete in trunk/LayoutTests
[Chromium] Layout Test css3/filters/custom/custom-filter-property-computed-style.html is failing
https://bugs.webkit.org/show_bug.cgi?id=84067
Reviewed by Ryosuke Niwa.
All the CSS filters/shaders script tests expected to have a document.styleSheets.item(0) that they could change.
The script-tests add a <link> that references a CSS file from a different parent folder, so the script
has no access to the actual rules anymore. Updated all the tests to use createElement("style")
and get the styleSheet by using el.sheet instead of assuming that there's one style already created.
- css3/filters/script-tests/custom-filter-property-computed-style.js:
- css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
(testInvalidFilterRule):
- css3/filters/script-tests/effect-custom-disabled.js:
(testInvalidFilterRule):
- css3/filters/script-tests/filter-property-computed-style.js:
(testComputedFilterRule):
- css3/filters/script-tests/filter-property-parsing-invalid.js:
(testInvalidFilterRule):
- css3/filters/script-tests/filter-property-parsing.js:
(testFilterRule):
- css3/filters/script-tests/filter-property.js:
- platform/chromium/test_expectations.txt: Removed reference to this bug.
- platform/mac/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Removed. This is not necessary anymore.
- 5:28 PM Changeset in webkit [115264] by
-
- 14 edits3 adds in trunk
Implement object-literal constructor for the Intent object.
https://bugs.webkit.org/show_bug.cgi?id=84220
Patch by Greg Billock <gbillock@google.com> on 2012-04-25
Reviewed by Kentaro Hara.
The use of the custom constructor will hopefully be temporary, as we plan
to convert to just using the object literal constructor, which can then use codegen.
See spec: http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
Added support for the service and extras parameters in the Intent
object to support the speced members in the object literal constructor.
Added supporting accessor to Dictionary to retrieve a sub-Dictionary,
and a utility to ScriptValue to serialize with ports.
Test: webintents/web-intent-obj-constructor.html
(WebCore):
- Modules/intents/Intent.cpp:
(WebCore::Intent::create):
(WebCore::Intent::Intent):
(WebCore::Intent::service):
(WebCore):
(WebCore::Intent::extras):
- Modules/intents/Intent.h:
(WebCore):
(Intent):
- Modules/intents/Intent.idl:
- WebCore.gypi:
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
(WebCore):
- bindings/v8/Dictionary.h:
(Dictionary):
- bindings/v8/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore):
- bindings/v8/ScriptValue.h:
(WTF):
(WebCore):
(ScriptValue):
- bindings/v8/custom/V8IntentConstructor.cpp: Added.
(WebCore):
(WebCore::V8Intent::constructorCallback):
- 5:26 PM Changeset in webkit [115263] by
-
- 6 edits in trunk
CSS Shaders: Use u_texture instead of s_texture. It was updated in the spec
https://bugs.webkit.org/show_bug.cgi?id=82618
Source/WebCore:
Reviewed by Dean Jackson.
Changed the uniform name passed to the CSS Shaders from s_texture to u_texture.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html
No new tests, just updating existing ones.
- platform/graphics/filters/CustomFilterShader.cpp:
(WebCore::CustomFilterShader::defaultFragmentShaderString):
(WebCore::CustomFilterShader::initializeParameterLocations):
LayoutTests:
Reviewed by Dean Jackson.
Changed the uniform name passed to the CSS Shaders from s_texture to u_texture.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html
- css3/filters/resources/color-add.fs:
- css3/filters/resources/color-offset-parameters.fs:
- css3/filters/resources/color-offset.fs:
- 5:07 PM Changeset in webkit [115262] by
-
- 14 edits in trunk/Source/WebKit/chromium
[Chromium] IndexedDB: Use WebIDBKeyPath type for key paths in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=84631
Reviewed by James Robinson.
WebIDBKeyPath was previously a utility class for parsing key paths into components,
but the API exposed key paths only as nullable strings. To support array-type keypaths,
WebIDBKeyPath becomes a value class with type flags. For landing, several legacy methods
are retained but will be cleaned up after all callers have been updated, tracked as
the bug: http://webkit.org/b/84207
- public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch.
- public/WebIDBIndex.h:
(WebKit::WebIDBIndex::keyPath): Calls keyPathString if not overridden.
(WebKit::WebIDBIndex::keyPathString): Comment change.
- public/WebIDBKeyPath.h:
(WebKit::WebIDBKeyPath::create): Overload added for creating array-type key paths.
(WebKit::WebIDBKeyPath::array): Accessor for array-type key paths.
(WebKit::WebIDBKeyPath::operator const WebString ): Temporary, for compatibility.
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::keyPath): Calls keyPathString if not overridden.
(WebKit::WebIDBObjectStore::keyPathString): Comment change.
(WebKit::WebIDBObjectStore::createIndex): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch.
- public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport): WebIDBKeyPath overloads for these methods added, delegate to WebString version until implementers are updated.
(WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):
- src/IDBIndexBackendProxy.cpp:
(WebKit::IDBIndexBackendProxy::keyPath): Returns the string version until WebCore is updated.
- src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::keyPath): Returns the string version until WebCore is updated.
- src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl): Add createObjectStore overload for WebIDBKeyPath type, delegates to WebString version until callers are updated.
- src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::keyPath): Implements the new WebIDBKeyPath return type.
(WebKit):
- src/WebIDBIndexImpl.h:
(WebIDBIndexImpl): Implements the new WebIDBKeyPath return type.
- src/WebIDBKeyPath.cpp:
(WebKit::WebIDBKeyPath::create): Support null key path types.
(WebKit::WebIDBKeyPath::createNull): New API.
(WebKit):
(WebKit::WebIDBKeyPath::isValid): New API.
(WebKit::WebIDBKeyPath::type): New API.
(WebKit::WebIDBKeyPath::string): New API (value accessor).
(WebKit::WebIDBKeyPath::WebIDBKeyPath):
(WebKit::WebIDBKeyPath::assign): This API will be removed.
(WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&): Ensure it is non-null - only used in copy constructor which guards against this.
- src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::keyPath): Implement the new WebIDBKeyPath return type.
(WebKit):
- src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl): Add createIndex overload for WebIDBKeyPath type, delegates to WebString version until callers are updated.
- 5:00 PM Changeset in webkit [115261] by
-
- 2 edits in branches/subpixellayout/LayoutTests/css2.1
Adding a tiny fraction to the css values of these tests to make up for lost Float precision when calculating margins when Lengths are floats.
- 4:52 PM Changeset in webkit [115260] by
-
- 5 edits3 adds in trunk
IndexedDB: cursor does not correctly iterate over keys added and removed during iteration
https://bugs.webkit.org/show_bug.cgi?id=84467
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-04-25
Reviewed by Ojan Vafai.
Source/WebCore:
Ensure that the iterator over the tree of cached adds/removes always points at
the current key, or if the db iterator is current, the next key:
- When refreshing the tree iterator after a mutation, always seek unless the
tree iterator is current.
- When handing conflicts and delete markers, only advance the tree iterator as
far as the db iterator.
Remove the expensive (and now redundant) logic that issued a get() to check
whether an item had been deleted.
Test: storage/indexeddb/cursor-added-bug.html
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):
- platform/leveldb/LevelDBTransaction.cpp:
(WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
(WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):
LayoutTests:
New test for keys added in reverse order during cursor iteration.
- storage/indexeddb/cursor-added-bug-expected.txt: Added.
- storage/indexeddb/cursor-added-bug.html: Added.
- storage/indexeddb/resources/cursor-added-bug.js: Added.
(test):
(openSuccess):
(setVersionSuccess):
(openCursor):
(cursorSuccess):
- 4:51 PM Changeset in webkit [115259] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/platform/graphics/FractionalLayoutRect.cpp
Fix enclosingFractionalLayoutRect for 1/1 on branch.
- 4:39 PM Changeset in webkit [115258] by
-
- 2 edits in trunk/Tools
Unreviewed: Adding Alec Flett as a contributor (non-committer).
- Scripts/webkitpy/common/config/committers.py:
- 4:30 PM Changeset in webkit [115257] by
-
- 2 edits in trunk/Tools
Mark myself as a reviewer.
https://bugs.webkit.org/show_bug.cgi?id=84902
Reviewed by Dimitri Glazkov.
- Scripts/webkitpy/common/config/committers.py:
- 4:18 PM WebKit Team edited by
- (diff)
- 4:09 PM April 2012 HTML5 Media Element & WebAudio edited by
- (diff)
- 4:07 PM Changeset in webkit [115256] by
-
- 2 edits in trunk/Source/WebCore
Try to fix build with STYLE_SCOPED enabled.
Not reviewed.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::determineScope):
- 4:05 PM Changeset in webkit [115255] by
-
- 13 edits3 adds in trunk
IndexedDB: support openCursor(IDBKey)
https://bugs.webkit.org/show_bug.cgi?id=84652
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-25
Reviewed by Ojan Vafai.
Source/WebCore:
Add signatures for openCursor/openKeyCursor(IDBKey).
Test: storage/indexeddb/opencursor-key.html
- Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore):
(WebCore::IDBIndex::openKeyCursor):
- Modules/indexeddb/IDBIndex.h:
(WebCore::IDBIndex::openCursor):
(IDBIndex):
(WebCore::IDBIndex::openKeyCursor):
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::openCursor):
(WebCore):
- Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
- Modules/indexeddb/IDBObjectStore.idl:
LayoutTests:
Augment existing tests, and add new tests to support
IDBKey parameter to openCursor/openKeyCursor. Note that this removes
a test that was previously using dictionary-style parameters,
which have been temporarily broken due to IDL limitations.
- storage/indexeddb/cursor-delete-expected.txt:
- storage/indexeddb/open-cursor-expected.txt:
- storage/indexeddb/opencursor-key-expected.txt: Added.
- storage/indexeddb/opencursor-key.html: Added.
- storage/indexeddb/resources/cursor-delete.js:
(openCursor):
- storage/indexeddb/resources/open-cursor.js:
(emptyCursorWithKeySuccess):
(openEmptyCursorWithKey):
(cursorWithKeySuccess):
(openCursorWithKey):
(emptyCursorSuccess):
(openEmptyCursor):
(cursorSuccess):
- storage/indexeddb/resources/opencursor-key.js: Added.
(test):
(openSuccess):
(createAndPopulateObjectStore):
(createIndexes):
(testAll):
(testObjectStore.request.onsuccess):
(testObjectStore):
(testIndex.request.onsuccess):
(testIndex):
(testIndexWithKey.request.onsuccess):
(testIndexWithKey):
- 4:02 PM Changeset in webkit [115254] by
-
- 2 edits in trunk/Source/WTF
Include <sys/param.h>, needed for sysctl() on OpenBSD/NetBSD
https://bugs.webkit.org/show_bug.cgi?id=82585
Patch by Landry Breuil <landry@openbsd.org> on 2012-04-25
Reviewed by Zoltan Herczeg.
- wtf/NumberOfCores.cpp: include <sys/param.h> on the BSDs
- 4:01 PM Changeset in webkit [115253] by
-
- 2 edits in trunk/Source/JavaScriptCore
Biolab disaster crashes on ToT
https://bugs.webkit.org/show_bug.cgi?id=84898
Reviewed by Filip Pizlo.
Whoops, committed without saving reviewer requested change.
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- 3:58 PM Changeset in webkit [115252] by
-
- 2 edits in trunk/Source/JavaScriptCore
Biolab disaster crashes on ToT
https://bugs.webkit.org/show_bug.cgi?id=84898
Reviewed by Filip Pizlo.
I recently added an assertion to the Interpreter to catch incorrect
updates of topCallFrame. This caused a bunch of sites (including biolab
disaster) to crash as we were not correctly handling callee registers
of inlined functions, leading to a mismatch.
I could not actually make this trigger directly, although it does trigger
already on some of the GTK and QT bots.
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- 3:52 PM Changeset in webkit [115251] by
-
- 2 edits in trunk/LayoutTests
[Chromium[ Remove a flaky expectation for a test that's been consistently passing.
- platform/chromium/test_expectations.txt: Removed.
- 3:42 PM Changeset in webkit [115250] by
-
- 19 edits in trunk/Source/WebCore
Remove owner node pointer from StyleSheetInternal
https://bugs.webkit.org/show_bug.cgi?id=84882
Reviewed by Andread Kling.
To make sharing between multiple nodes possible StyleSheetInternal should not have a Node pointer.
- Make StyleSheetInternal constructor take CSSParserContext instead of Node*
- Move owner node pointer to CSSStyleSheet. CSSStyleSheet now acts as a client for StyleSheetInternal.
This gets us closer to being able to cache stylesheet data structures.
- css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):
Setup CSSParserContext.
Remove FIXME about updateBaseURL(). It is no longer possible to change URL of StyleSheetInternal.
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::setSelectorText):
- css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
- css/CSSParserMode.h:
(CSSParserContext):
Expand CSSParserContext constructors.
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleResolver.h:
(StyleResolver):
- css/CSSStyleSheet.cpp:
User stylesheets went back to being CSSStyleSheets. Adapt to that.
(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore):
(WebCore::StyleSheetInternal::checkLoaded):
(WebCore::StyleSheetInternal::startLoadingDynamicSheet):
(WebCore::StyleSheetInternal::rootStyleSheet):
(WebCore::StyleSheetInternal::singleOwnerNode):
(WebCore::StyleSheetInternal::singleOwnerDocument):
(WebCore::StyleSheetInternal::styleSheetChanged):
The owner node is now located through CSSStyleSheet. Only one client is supported atm.
(WebCore::StyleSheetInternal::registerClient):
(WebCore::StyleSheetInternal::unregisterClient):
Register CSSStyleSheets.
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::ownerDocument):
- css/CSSStyleSheet.h:
(WebCore::StyleSheetInternal::create):
(WebCore::StyleSheetInternal::createInline):
(StyleSheetInternal):
(WebCore::CSSStyleSheet::create):
(CSSStyleSheet):
Moved m_ownerNode.
Changed constructors
Removed setFinalURL().
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):
- dom/Document.cpp:
(WebCore::Document::updateBaseURL):
Instead of setFinalURL, construct a new StyleSheetInternal if the base url ever changes.
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::elementSheet):
- dom/Document.h:
(Document):
(WebCore::Document::documentUserSheets):
Adapt to the new interface.
Turned user stylesheets CSSStyleSheets so they can find the owner node.
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::setCSSStyleSheet):
- dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
- inspector/InspectorCSSAgent.cpp:
(WebCore::SelectorProfile::startSelector):
(WebCore::InspectorCSSAgent::bindStyleSheet):
- inspector/InspectorStyleSheet.cpp:
(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::ownerDocument):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeCSSStyleSheet):
- 3:33 PM Changeset in webkit [115249] by
-
- 2 edits in trunk/Source/WebCore
Fix uninitialized variable warnings in PasteboardMac.mm after 115145
https://bugs.webkit.org/show_bug.cgi?id=84879
Reviewed by Enrica Casucci.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getDataSelection): Initialize attributedString to nil.
(WebCore::Pasteboard::writeSelectionForTypes): ditto.
- 3:12 PM Changeset in webkit [115248] by
-
- 52 edits9 deletes in trunk/Source
Delete CanvasPixelArray, ByteArray, JSByteArray and JSC code once unreferenced
https://bugs.webkit.org/show_bug.cgi?id=83655
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.order:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionToAbbreviatedString):
(JSC::predictionFromClassInfo):
- bytecode/PredictedType.h:
(JSC):
(JSC::isActionableIntMutableArrayPrediction):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
(JSC::DFG::putByVal):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::getByVal):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/JSByteArray.cpp: Removed.
- runtime/JSByteArray.h: Removed.
- runtime/JSGlobalData.cpp:
Source/WebCore:
Removed last few references to ByteArray, replacing with
Uint8ClampedArray as necessary, and deleted now-obsolete
CanvasPixelArray, ByteArray and JSByteArray. Removed code from
JavaScriptCore special-casing ByteArray.
No new tests. Did full layout test run on Mac OS; no regressions
seen from this change.
- CMakeLists.txt:
- DerivedSources.pri:
- ForwardingHeaders/runtime/JSByteArray.h: Removed.
- GNUmakefile.list.am:
- PlatformBlackBerry.cmake:
- Target.pri:
- UseV8.cmake:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/SerializedScriptValue.cpp:
- bindings/v8/V8Binding.h:
(WebCore::isHostObject):
- bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::typeCallback):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::isJSUint8ClampedArray):
(Bindings):
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
- html/canvas/CanvasPixelArray.cpp: Removed.
- html/canvas/CanvasPixelArray.h: Removed.
- html/canvas/CanvasPixelArray.idl: Removed.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
- platform/graphics/filters/FEConvolveMatrix.h:
- rendering/svg/RenderSVGResourceMasker.cpp:
Source/WTF:
- GNUmakefile.list.am:
- WTF.gypi:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/ByteArray.cpp: Removed.
- wtf/ByteArray.h: Removed.
- wtf/CMakeLists.txt:
- 2:58 PM QtWebKitContrib edited by
- (diff)
- 2:36 PM Changeset in webkit [115247] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84890
Rebaseline chromium-mac test expectation for media/audio-repaint.html after r115235.
- platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
- 2:30 PM Changeset in webkit [115246] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
Build fix for compilation failure due to r115243.
- platform/graphics/chromium/LayerChromium.h:
(WebCore):
- 2:22 PM Changeset in webkit [115245] by
-
- 8 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Possible JS re-entrancy caused by UI events.
https://bugs.webkit.org/show_bug.cgi?id=84862
Patch by Yong Li <yoli@rim.com> on 2012-04-25
Reviewed by Antonio Gomes.
- block UI events when running in nested event loop
- defer some tasks we still want to perform when it is safe to do, with cached data.
- deferred task can be cancelled by clearing the flag. duplicate tasks is not a problem because they share same flag and data.
- move deferred manual script from FrameLoaderClientBlackBerry to WebPagePrivate and make it a deferred task
- Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPagePrivate::stopCurrentLoad):
(BlackBerry::WebKit::WebPagePrivate::willDeferLoading):
(BlackBerry::WebKit::WebPagePrivate::didResumeLoading):
(BlackBerry::WebKit::WebPagePrivate::deferredTasksTimerFired):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
(BlackBerry::WebKit::WebPage::setInputSelection):
(BlackBerry::WebKit::WebPage::popupListClosed):
(BlackBerry::WebKit::WebPage::setDateTimeInput):
(BlackBerry::WebKit::WebPage::setColorInput):
(BlackBerry::WebKit::WebPage::mouseEvent):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
(BlackBerry::WebKit::WebPage::touchEventCancel):
(BlackBerry::WebKit::WebPage::touchEventCancelAndClearFocusedNode):
(BlackBerry::WebKit::WebPage::keyEvent):
(BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
(BlackBerry::WebKit::WebPage::setComposingText):
(BlackBerry::WebKit::WebPage::commitText):
(BlackBerry::WebKit::WebPage::selectionCancelled):
(BlackBerry::WebKit::WebPage::cutSelectedText):
(BlackBerry::WebKit::WebPage::insertText):
(BlackBerry::WebKit::WebPage::clearCurrentInputField):
(BlackBerry::WebKit::WebPage::cut):
(BlackBerry::WebKit::WebPage::paste):
(BlackBerry::WebKit::WebPage::setSelection):
(BlackBerry::WebKit::WebPage::setCaretPosition):
(BlackBerry::WebKit::WebPage::selectAtPoint):
(BlackBerry::WebKit::WebPage::setFocused):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
(DeferredTaskBase):
(BlackBerry::WebKit::WebPagePrivate::DeferredTaskBase::perform):
(BlackBerry::WebKit::WebPagePrivate::DeferredTaskBase::DeferredTaskBase):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::~FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::willDeferLoading):
(WebCore::FrameLoaderClientBlackBerry::didResumeLoading):
- WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 2:19 PM Apple_Bot_Watchers edited by
- Fixing the links. (diff)
- 2:15 PM Changeset in webkit [115244] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r115227. Return null string when the string builder is empty
to match the old behavior.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::borderPropertyValue):
- 2:13 PM Changeset in webkit [115243] by
-
- 13 edits in trunk/Source
[chromium] Add support for animation finished events.
https://bugs.webkit.org/show_bug.cgi?id=84454
Patch by Ian Vollick <vollick@chromium.org> on 2012-04-25
Reviewed by James Robinson.
Source/WebCore:
Tested in CCLayerTreeHostTestAnimationFinishedEvents
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::notifyAnimationFinished):
(WebCore):
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::notifyAnimationStarted):
(WebCore::LayerChromium::notifyAnimationFinished):
(WebCore):
- platform/graphics/chromium/LayerChromium.h:
(WebCore):
(LayerChromium):
- platform/graphics/chromium/cc/CCAnimationEvents.h:
(WebCore::CCAnimationEvent::CCAnimationEvent):
(CCAnimationEvent):
(WebCore):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::animate):
(WebCore::CCLayerAnimationController::notifyAnimationStarted):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationController::purgeFinishedAnimations):
- platform/graphics/chromium/cc/CCLayerAnimationController.h:
(CCLayerAnimationController):
- platform/graphics/chromium/cc/CCLayerAnimationDelegate.h:
(CCLayerAnimationDelegate):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):
Source/WebKit/chromium:
- tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
- tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::notifyAnimationFinished):
(WTF::TEST_F):
(WTF):
(CCLayerTreeHostTestAnimationFinishedEvents):
(WTF::CCLayerTreeHostTestAnimationFinishedEvents::CCLayerTreeHostTestAnimationFinishedEvents):
(WTF::CCLayerTreeHostTestAnimationFinishedEvents::beginTest):
(WTF::CCLayerTreeHostTestAnimationFinishedEvents::notifyAnimationFinished):
(WTF::CCLayerTreeHostTestAnimationFinishedEvents::afterTest):
- 1:59 PM Changeset in webkit [115242] by
-
- 4 edits in trunk/Source
Source/WebCore: REGRESSION (r110494): Dragging images from Safari to Finder results in .webloc rather than image file
https://bugs.webkit.org/show_bug.cgi?id=84878
<rdar://problem/11155407>
In WebKit2, it could happen to try to start the drag twice, given the asynchronous nature
of the communication between the UI process and the WebProcess.
We need to guarantee that we don't do that, otherwise on OS X the pasteboard ownership
gets changed which affects the promised file types.
Reviewed by Alexey Proskuryakov.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag): Reset m_mouseDownMayStartDrag to false to
avoid attempting to start another drag.
Source/WebKit2: REGRESSION (r110494): Dragging images from Safari to Finder results in .webloc rather than image file
https://bugs.webkit.org/show_bug.cgi?id=84878
<rdar://problem/11155407>
In WebKit2, it could happen to try to start the drag twice, given the asynchronous nature
of the communication between the UI process and the WebProcess.
We need to guarantee that we don't do that, otherwise on OS X the pasteboard ownership
gets changed which affects the promised file types.
The fix for the problem is in WebCore and we can now remove the guard on _setDragImage.
Reviewed by Alexey Proskuryakov.
- UIProcess/API/mac/WKView.mm:
(-[WKView mouseDown:]):
(-[WKView _setDragImage:at:linkDrag:]):
- 1:58 PM Apple_Bot_Watchers created by
- 1:40 PM Changeset in webkit [115241] by
-
- 2 edits in trunk/Source/WebCore
Remove unused Attribute constructor.
Semi-knowingly rubber-stamped by Antti Koivisto.
- dom/Attribute.h:
- 1:34 PM Changeset in webkit [115240] by
-
- 3 edits1 add in trunk/Tools
[Qt][NRWT] Run each DRT in it's own xvfb
https://bugs.webkit.org/show_bug.cgi?id=77335
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._driver_class):
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._driver_class):
- Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
(XvfbDriver):
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):
- 1:04 PM Changeset in webkit [115239] by
-
- 17 edits8 adds3 deletes in trunk/LayoutTests
Rebaseline chromium test results after bug 72796 is fixed
https://bugs.webkit.org/show_bug.cgi?id=84731
Unreviewed Chromikum expectations update.
Text baselines changed now that this bug has been fixed.
- platform/chromium-linux-x86/svg/custom/use-clipped-hit-expected.txt: Added.
- platform/chromium-linux-x86/svg/custom/use-modify-target-symbol-expected.txt: Added.
- platform/chromium-linux-x86/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/chromium-linux/svg/custom/use-clipped-hit-expected.txt: Added.
- platform/chromium-linux/svg/custom/use-modify-target-symbol-expected.txt: Added.
- platform/chromium-linux/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
- platform/chromium-mac-leopard/svg/custom/use-on-disallowed-foreign-object-5-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-5-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-5-expected.txt: Removed.
- platform/chromium-mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/chromium-win-vista/svg/custom/use-clipped-hit-expected.txt: Added.
- platform/chromium-win-vista/svg/custom/use-modify-target-symbol-expected.txt: Added.
- platform/chromium-win-xp/svg/custom/use-clipped-hit-expected.txt: Added.
- platform/chromium-win-xp/svg/custom/use-modify-target-symbol-expected.txt: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
- platform/chromium-win/svg/carto.net/button-expected.txt:
- platform/chromium-win/svg/carto.net/colourpicker-expected.txt:
- platform/chromium-win/svg/carto.net/slider-expected.txt:
- platform/chromium-win/svg/custom/use-clipped-hit-expected.txt:
- platform/chromium-win/svg/custom/use-modify-target-symbol-expected.txt:
- platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/chromium-win/svg/custom/use-on-g-containing-symbol-expected.txt:
- platform/chromium-win/svg/custom/use-on-symbol-expected.txt:
- platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
- platform/chromium/test_expectations.txt:
- 12:55 PM Changeset in webkit [115238] by
-
- 1 edit2 moves in trunk/LayoutTests
Use the same results for fast/html/details-marker-style.html on all mac bots.
- platform/mac/fast/html/details-marker-style-expected.png: Renamed from LayoutTests/platform/mac-snowleopard/fast/html/details-marker-style-expected.png.
- platform/mac/fast/html/details-marker-style-expected.txt: Renamed from LayoutTests/platform/mac-snowleopard/fast/html/details-marker-style-expected.txt.
- 12:53 PM Changeset in webkit [115237] by
-
- 4 edits3 adds in trunk
http://bellard.org/jslinux/ triggers an assertion failure in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=84815
<rdar://problem/11319514>
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
LayoutTests:
Rubber stamped by Gavin Barraclough.
- fast/js/dfg-uint32-to-number-on-captured-variable-expected.txt: Added.
- fast/js/dfg-uint32-to-number-on-captured-variable.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-uint32-to-number-on-captured-variable.js: Added.
(foo):
- 12:31 PM Changeset in webkit [115236] by
-
- 3 edits2 adds in trunk
Source/WebCore: Crash in CachedRawResource::didAddClient() due to missing protector.
https://bugs.webkit.org/show_bug.cgi?id=83632
Reviewed by Eric Seidel.
Test: http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::didAddClient):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=83632.
Reviewed by Eric Seidel.
- http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html: Added.
- 12:26 PM Changeset in webkit [115235] by
-
- 41 edits1 move1 delete in trunk/LayoutTests
2012-04-25 Andrew Scherkus <scherkus@chromium.org>
Rebaseline Chromium media layout tests due to r114957.
- platform/chromium-linux-x86/media/video-empty-source-expected.txt:
- platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Removed.
- platform/chromium-linux/media/video-empty-source-expected.txt:
- platform/chromium-mac-leopard/media/video-empty-source-expected.txt:
- platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
- platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt:
- platform/chromium-mac/fast/layers/video-layer-expected.txt:
- platform/chromium-mac/media/audio-controls-rendering-expected.txt:
- platform/chromium-mac/media/audio-repaint-expected.txt:
- platform/chromium-mac/media/controls-after-reload-expected.txt:
- platform/chromium-mac/media/controls-strict-expected.txt:
- platform/chromium-mac/media/controls-styling-expected.txt:
- platform/chromium-mac/media/controls-without-preload-expected.txt:
- platform/chromium-mac/media/media-controls-clone-expected.txt:
- platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
- platform/chromium-mac/media/video-controls-rendering-expected.txt:
- platform/chromium-mac/media/video-display-toggle-expected.txt:
- platform/chromium-mac/media/video-empty-source-expected.txt:
- platform/chromium-mac/media/video-no-audio-expected.txt:
- platform/chromium-mac/media/video-playing-and-pause-expected.txt:
- platform/chromium-mac/media/video-volume-slider-expected.txt:
- platform/chromium-mac/media/video-zoom-controls-expected.txt:
- platform/chromium-win-vista/media/video-empty-source-expected.txt:
- platform/chromium-win-xp/media/video-empty-source-expected.txt:
- platform/chromium-win/fast/layers/video-layer-expected.txt:
- platform/chromium-win/media/audio-controls-rendering-expected.txt:
- platform/chromium-win/media/audio-repaint-expected.txt:
- platform/chromium-win/media/controls-after-reload-expected.txt:
- platform/chromium-win/media/controls-strict-expected.txt:
- platform/chromium-win/media/controls-styling-expected.txt:
- platform/chromium-win/media/controls-without-preload-expected.txt:
- platform/chromium-win/media/media-controls-clone-expected.txt:
- platform/chromium-win/media/media-document-audio-repaint-expected.txt:
- platform/chromium-win/media/video-controls-rendering-expected.txt:
- platform/chromium-win/media/video-display-toggle-expected.txt:
- platform/chromium-win/media/video-empty-source-expected.txt:
- platform/chromium-win/media/video-no-audio-expected.txt:
- platform/chromium-win/media/video-playing-and-pause-expected.txt:
- platform/chromium-win/media/video-volume-slider-expected.txt:
- platform/chromium-win/media/video-zoom-controls-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/qt/media/audio-repaint-expected.txt: Renamed from LayoutTests/media/audio-repaint-expected.txt.
- 11:57 AM Changeset in webkit [115234] by
-
- 5 edits in trunk/Source/WebCore
[V8] Pass Isolate to SerializedScriptValue::deserialize()
https://bugs.webkit.org/show_bug.cgi?id=84758
Reviewed by Nate Chapin.
The objective is to pass Isolate around. This patch passes
Isolate to SerializedScriptValue::deserialize().
No tests. No change in behavior.
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
- 11:38 AM Changeset in webkit [115233] by
-
- 6 edits in trunk/Source/WebCore
[V8] Pass Isolate to SerializedScriptValue::create() in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=84757
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to SerializedScriptValue::create()
in custom bindings.
No tests. No change in behavior.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
- 11:21 AM Changeset in webkit [115232] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84877
Mark a failing test after changes in r115227.
- platform/chromium/test_expectations.txt:
- 11:14 AM Changeset in webkit [115231] by
-
- 4 edits in trunk/Source/WebCore
[V8] Pass Isolate to SerializedScriptValue::create() in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=84753
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to SerializedScriptValue::create()
in CodeGeneratorV8.pm.
Tests: bindings/scripts/test/TestObj.idl
bindings/scripts/test/TestSerializedScriptValueInterface.idl
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):
(GenerateParametersCheck):
(JSValueToNative):
- bindings/scripts/test/V8/V8TestObj.cpp: Updated run-bindings-tests results.
(WebCore::TestObjV8Internal::intSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::shortSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::longSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::longLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedIntSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedShortSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedLongLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::floatSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::doubleSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::booleanSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::voidSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::dateSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::serializedValueCallback):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
- 11:12 AM Changeset in webkit [115230] by
-
- 4 edits in trunk
Unreviewed, rolling out r115222.
http://trac.webkit.org/changeset/115222
https://bugs.webkit.org/show_bug.cgi?id=84874
Caused test regressions on the EFL build (Requested by rakuco
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-25
Tools:
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):
LayoutTests:
- platform/efl/Skipped:
- 11:09 AM Scrolling Session Meeting 2012 edited by
- Added line breaks for better formatting, also fixed my name (diff)
- 11:07 AM Changeset in webkit [115229] by
-
- 3 edits in trunk/Source/WebCore
[V8] Add m_isolate to SerializedScriptValue::Writer
and SerializedScriptValue::Reader
https://bugs.webkit.org/show_bug.cgi?id=84739
Reviewed by Nate Chapin.
This is the second step to pass Isolate around
in SerializedScriptValue. This patch adds m_isolate to
SerializedScriptValue::Writer and SerializedScriptValue::Reader,
so that they can use the isolate around. The fix is safe since
Writer and Reader are guaranteed to be used by one Isolate.
No tests. No change in behavior.
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):
- bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
- 10:58 AM Changeset in webkit [115228] by
-
- 2 edits in trunk/Source/WebCore
[V8] Make the Isolate* parameter non-optional in setDOMException()
https://bugs.webkit.org/show_bug.cgi?id=84736
Reviewed by Nate Chapin.
Now all setDOMException() callers pass Isolate* to setDOMException().
This patch makes the Isolate* parameter non-optional.
No tests. No change in behavior.
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 10:44 AM Changeset in webkit [115227] by
-
- 8 edits in trunk
REGRESSION(r112177): listStyleType CSS property gets converted into listStyle
https://bugs.webkit.org/show_bug.cgi?id=83026
Reviewed by Darin Adler.
Source/WebCore:
Fixed the bug by not using shorthand notations when some values are missing.
However, we still want to return a value when shorthand border property is explicitly
requested so extract borderPropertyValue with a flag to support both behaviors.
- css/StylePropertySet.cpp:
(WebCore::borderPropertyValue): Extracted from getPropertyValue.
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::get4Values): Don't return values when priority don't match.
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue): Don't return null string for initial values
to disambiguate missing values and "initial" in getPropertyValue. Also check propriety.
(WebCore::StylePropertySet::asText): Support emitting border-width, border-style, and
border-color when border doesn't work but the former properties do.
LayoutTests:
Added test cases to cssText-shorthand.html and rebaselined some tests.
- fast/css/cssText-shorthand-expected.txt:
- fast/css/cssText-shorthand.html: Added more test cases.
- fast/css/remove-shorthand-expected.txt: Correctly adds both border-width and border-style
when border-color is missing.
- printing/page-rule-css-text-expected.txt: Correctly uses border-width instead of border.
- 10:32 AM Changeset in webkit [115226] by
-
- 5 edits in trunk/Source
[chromium] Do not clobber synchronized start times.
https://bugs.webkit.org/show_bug.cgi?id=84605
Patch by Ian Vollick <vollick@chromium.org> on 2012-04-25
Reviewed by James Robinson.
Source/WebCore:
Tested in CCLayerAnimationControllerTest.doNotClobberStartTimes
(WebCore):
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(CCActiveAnimation):
(WebCore::CCActiveAnimation::hasSetStartTime):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):
Source/WebKit/chromium:
- tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests):
(WebKitTests::TEST):
- 10:16 AM Changeset in webkit [115225] by
-
- 4 edits in tags/Safari-536.8.1/Source
Versioning.
- 10:13 AM Changeset in webkit [115224] by
-
- 1 copy in tags/Safari-536.8.1
New Tag.
- 10:12 AM Changeset in webkit [115223] by
-
- 4 edits2 adds in trunk
Source/WebCore: REGRESSION (r100311): YummySoup app crashes when trying to print
https://bugs.webkit.org/show_bug.cgi?id=83918
Reviewed by Alexey Proskuryakov.
Test: http/tests/xmlhttprequest/cancel-during-failure-crash.html
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didFail): Set m_calledDidFinishLoad when calling
didFailToLoad() to prevent it from getting called twice if we cancel
re-entrantly.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=83918.
Reviewed by Alexey Proskuryakov.
- http/tests/cache/cancel-during-failure-crash-expected.txt: Added.
- http/tests/cache/cancel-during-failure-crash.html: Added.
- 10:09 AM Deprecating features and vendor prefixes edited by
- Added a link to the new deprecating features page (diff)
- 10:07 AM DeprecatingFeatures created by
- Dumping a first draft of the proposal using the talk's notes
- 10:04 AM Changeset in webkit [115222] by
-
- 4 edits in trunk
[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=83880
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-25
Reviewed by Antonio Gomes.
Tools:
Add missing implementation addOriginAccessWhitelistEntry and
removeOriginAccessWhitelistEntry to EFL's LayoutTestController
in order to unskip tests which rely on this.
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):
LayoutTests:
Unskip test cases which rely on LayoutTestController's addOriginAccessWhitelistEntry
and removeOriginAccessWhitelistEntry implementation.
- platform/efl/Skipped:
- 9:48 AM WikiStart edited by
- Adding a new page about "deprecating features" (diff)
- 9:46 AM Changeset in webkit [115221] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed, fix Windows build after r115215.
- css/CSSAllInOne.cpp:
- 9:28 AM Changeset in webkit [115220] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed, attempt to fix Windows build after r115215.
- css/CSSAllInOne.cpp: Don't try to include CSSStyleSelector.cpp.
- 9:16 AM Changeset in webkit [115219] by
-
- 9 edits in trunk/Source
[Chromium] Call actualMemoryUsageMB directly
https://bugs.webkit.org/show_bug.cgi?id=84837
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportFatalErrorInV8):
- bindings/v8/V8GCController.cpp:
(WebCore):
- platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::actualMemoryUsageMB):
(WebCore):
- platform/MemoryUsageSupport.h:
(MemoryUsageSupport):
- platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::MemoryUsageSupport::actualMemoryUsageMB):
(WebCore):
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 9:12 AM Changeset in webkit [115218] by
-
- 2 edits in trunk/Tools
[EFL] [DRT] Reset text zoom factor before running a test
https://bugs.webkit.org/show_bug.cgi?id=84861
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-25
Reviewed by Antonio Gomes.
This fix eliminates most of the current flakiness on EFL build
bots, although some CSS tests will now need rebasiling.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- 9:11 AM Changeset in webkit [115217] by
-
- 4 edits in trunk/Source/JavaScriptCore
Closure in try {} with catch captures all locals from the enclosing function
https://bugs.webkit.org/show_bug.cgi?id=84804
Reviewed by Oliver Hunt.
Changed the capturing of local variables from capturing when eval is used,
within a "with" or within a "catch" to be just when an eval is used.
Renamed the function returning that we should capture from
getCapturedVariables() to usesEval(), since that what it noew returns.
Needed to fix the "with" code to only range check when the activation
has actually been torn off. Added m_isTornOff to JSActivation to
track this.
- parser/Parser.h:
(JSC::Scope::usesEval):
(JSC::Scope::getCapturedVariables):
- runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
- runtime/JSActivation.h:
(JSActivation):
(JSC::JSActivation::tearOff):
- 8:51 AM Changeset in webkit [115216] by
-
- 1 edit418 deletes in trunk/LayoutTests
[EFL] Remove duplicated test expectations
https://bugs.webkit.org/show_bug.cgi?id=84717
Unreviewed gardening.
These expected results are the same as the global ones.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-25
- platform/efl/compositing/geometry/tall-page-composited-expected.txt: Removed.
- platform/efl/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Removed.
- platform/efl/fast/block/float/in-margin-expected.txt: Removed.
- platform/efl/fast/block/positioning/028-expected.txt: Removed.
- platform/efl/fast/block/positioning/031-expected.txt: Removed.
- platform/efl/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
- platform/efl/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Removed.
- platform/efl/fast/borders/border-radius-different-width-001-expected.txt: Removed.
- platform/efl/fast/borders/borderRadiusDashed01-expected.txt: Removed.
- platform/efl/fast/borders/borderRadiusDashed06-expected.txt: Removed.
- platform/efl/fast/borders/borderRadiusDotted02-expected.txt: Removed.
- platform/efl/fast/borders/borderRadiusDotted03-expected.txt: Removed.
- platform/efl/fast/borders/inline-mask-overlay-image-outset-expected.txt: Removed.
- platform/efl/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Removed.
- platform/efl/fast/borders/only-one-border-with-width-expected.txt: Removed.
- platform/efl/fast/clip/017-expected.txt: Removed.
- platform/efl/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Removed.
- platform/efl/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Removed.
- platform/efl/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
- platform/efl/fast/dom/Window/webkitConvertPoint-expected.txt: Removed.
- platform/efl/fast/dynamic/subtree-boundary-percent-height-expected.txt: Removed.
- platform/efl/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Removed.
- platform/efl/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
- platform/efl/fast/files/url-required-arguments-expected.txt: Removed.
- platform/efl/fast/gradients/border-image-gradient-expected.txt: Removed.
- platform/efl/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
- platform/efl/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
- platform/efl/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Removed.
- platform/efl/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/efl/fast/parser/comment-in-script-expected.txt: Removed.
- platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
- platform/efl/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/efl/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
- platform/efl/fast/repaint/subtree-root-clip-expected.txt: Removed.
- platform/efl/fast/replaced/image-tag-expected.txt: Removed.
- platform/efl/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Removed.
- platform/efl/svg/as-background-image/background-image-tiled-expected.txt: Removed.
- platform/efl/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Removed.
- platform/efl/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-in-mask-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-css-transform-1-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-css-transform-2-expected.txt: Removed.
- platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
- platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
- platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
- platform/efl/svg/css/mask-with-shadow-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVG-dynamic-css-transform-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.txt: Removed.
- platform/efl/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-svg-as-image-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
- platform/efl/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Removed.
- platform/efl/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Removed.
- platform/efl/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug120107-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug1271-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug13169-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug196870-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/efl/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- 8:49 AM Changeset in webkit [115215] by
-
- 71 edits2 moves in trunk/Source
Rename CSSStyleSelector files to StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=84814
Reviewed by Antti Koivisto.
Rename CSSStyleSelector files to match the new class name StyleResolver.
Update the includes all over the code base to the new name.
Source/WebCore:
No new tests : renaming files, no behavior changes expected.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/CSSCalculationValue.cpp:
- css/CSSFontSelector.cpp:
- css/CSSGradientValue.cpp:
- css/MediaQueryEvaluator.cpp:
- css/MediaQueryMatcher.cpp:
- css/SVGCSSStyleSelector.cpp:
- css/StyleBuilder.cpp:
- css/StyleMedia.cpp:
- css/StyleResolver.cpp: Renamed from Source/WebCore/css/CSSStyleSelector.cpp.
(WebCore):
(RuleData):
(WebCore::RuleData::position):
(WebCore::RuleData::rule):
(WebCore::RuleData::selector):
(WebCore::RuleData::hasFastCheckableSelector):
(WebCore::RuleData::hasMultipartSelector):
(WebCore::RuleData::hasRightmostSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleData::containsUncommonAttributeSelector):
(WebCore::RuleData::specificity):
(WebCore::RuleData::linkMatchType):
(WebCore::RuleData::hasDocumentSecurityOrigin):
(WebCore::RuleData::isInRegionRule):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(SameSizeAsRuleData):
(RuleSet):
(WebCore::RuleSet::create):
(WebCore::RuleSet::disableAutoShrinkToFit):
(WebCore::RuleSet::features):
(WebCore::RuleSet::idRules):
(WebCore::RuleSet::classRules):
(WebCore::RuleSet::tagRules):
(WebCore::RuleSet::shadowPseudoElementRules):
(WebCore::RuleSet::linkPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):
(WebCore::RuleSet::pageRules):
(WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
(RuleSetSelectorPair):
(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::screenEval):
(WebCore::printEval):
(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::makeRuleSet):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::determineScope):
(WebCore::StyleResolver::ruleSetForScope):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::setupScopeStack):
(WebCore::StyleResolver::pushScope):
(WebCore::StyleResolver::popScope):
(WebCore::StyleResolver::pushParentElement):
(WebCore::StyleResolver::popParentElement):
(WebCore::StyleResolver::pushParentShadowRoot):
(WebCore::StyleResolver::popParentShadowRoot):
(WebCore::StyleResolver::addKeyframeStyle):
(WebCore::StyleResolver::~StyleResolver):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::Features::Features):
(WebCore::StyleResolver::Features::~Features):
(WebCore::StyleResolver::Features::add):
(WebCore::StyleResolver::Features::clear):
(WebCore::parseUASheet):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::ensureDefaultStyleSheetsForElement):
(WebCore::StyleResolver::addMatchedProperties):
(WebCore::StyleResolver::addElementStyleProperties):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(MatchingUARulesScope):
(WebCore::MatchingUARulesScope::MatchingUARulesScope):
(WebCore::MatchingUARulesScope::~MatchingUARulesScope):
(WebCore::MatchingUARulesScope::isMatchingUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleResolver.h: Renamed from Source/WebCore/css/CSSStyleSelector.h.
(WebCore):
(MediaQueryResult):
(WebCore::MediaQueryResult::MediaQueryResult):
(StyleResolver):
(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::document):
(WebCore::StyleResolver::fontDescription):
(WebCore::StyleResolver::parentFontDescription):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::hasParentNode):
(WebCore::StyleResolver::pushScope):
(WebCore::StyleResolver::popScope):
(WebCore::StyleResolver::setStyle):
(WebCore::StyleResolver::fontSelector):
(WebCore::StyleResolver::allVisitedStateChanged):
(WebCore::StyleResolver::visitedStateChanged):
(WebCore::StyleResolver::usesSiblingRules):
(WebCore::StyleResolver::usesFirstLineRules):
(WebCore::StyleResolver::usesBeforeAfterRules):
(WebCore::StyleResolver::usesLinkRules):
(WebCore::StyleResolver::RuleFeature::RuleFeature):
(RuleFeature):
(Features):
(WebCore::StyleResolver::addMatchedRule):
(WebCore::StyleResolver::MatchRanges::MatchRanges):
(MatchRanges):
(WebCore::StyleResolver::MatchedProperties::MatchedProperties):
(MatchedProperties):
(WebCore::StyleResolver::MatchResult::MatchResult):
(MatchResult):
(WebCore::StyleResolver::MatchOptions::MatchOptions):
(MatchOptions):
(WebCore::StyleResolver::isRightPage):
(WebCore::StyleResolver::styleNotYetAvailable):
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
(MatchedPropertiesCacheItem):
(WebCore::StyleResolver::scopeStackIsConsistent):
(WebCore::StyleResolver::ScopeStackFrame::ScopeStackFrame):
(ScopeStackFrame):
- css/WebKitCSSMatrix.cpp:
- dom/Document.cpp:
- dom/Element.cpp:
- dom/Node.cpp:
- dom/ShadowRoot.cpp:
- dom/ShadowTree.cpp:
- dom/StyledElement.cpp:
- editing/ApplyStyleCommand.cpp:
- editing/EditingStyle.cpp:
- editing/Editor.cpp:
- editing/markup.cpp:
- history/CachedPage.cpp:
- html/HTMLDocument.cpp:
- html/HTMLLinkElement.cpp:
- html/HTMLOptGroupElement.cpp:
- html/HTMLOptionElement.cpp:
- html/ValidationMessage.cpp:
- html/canvas/CanvasRenderingContext2D.cpp:
- html/shadow/MediaControlElements.cpp:
- inspector/InspectorCSSAgent.cpp:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorStyleSheet.cpp:
- loader/LinkLoader.cpp:
- page/DOMWindow.cpp:
- page/FrameView.cpp:
- page/Page.cpp:
- page/animation/KeyframeAnimation.cpp:
- platform/qt/RenderThemeQt.cpp:
- platform/qt/RenderThemeQtMobile.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderLayerBacking.cpp:
- rendering/RenderListBox.cpp:
- rendering/RenderMenuList.cpp:
- rendering/RenderObject.cpp:
- rendering/RenderRegion.cpp:
- rendering/RenderSlider.cpp:
- rendering/RenderTextControlSingleLine.cpp:
- rendering/RenderThemeMac.mm:
- rendering/RenderThemeSafari.cpp:
- rendering/style/RenderStyle.cpp:
- rendering/style/StyleGeneratedImage.cpp:
- rendering/style/StyleRareNonInheritedData.cpp:
- rendering/svg/RenderSVGInlineText.cpp:
- svg/SVGClipPathElement.cpp:
- svg/SVGElement.cpp:
- svg/SVGFontFaceElement.cpp:
- svg/SVGGradientElement.cpp:
- svg/SVGMaskElement.cpp:
- svg/SVGUseElement.cpp:
Source/WebKit/chromium:
- src/AutofillPopupMenuClient.cpp:
- src/WebViewImpl.cpp:
Source/WebKit/qt:
- Api/qwebelement.cpp:
- WebCoreSupport/RenderThemeQStyle.cpp:
- 8:37 AM Changeset in webkit [115214] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=84427
Unmark platform/chromium/editing/spelling/delete-misspelled-word.html as flaky.
The test has been fixed in r114866.
- platform/chromium/test_expectations.txt:
- 8:36 AM Changeset in webkit [115213] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip a flaky test.
https://bugs.webkit.org/show_bug.cgi?id=84866
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-25
- platform/qt/Skipped:
- 8:29 AM Changeset in webkit [115212] by
-
- 2 edits in trunk/Source/WebCore
make-css-file-arrays.pl now only take css files, make it also take js files,
as for html popups we also need load js files.
Reviewed by Antonio Gomes.
- css/make-css-file-arrays.pl:
Patch by Crystal Zhang <haizhang@rim.com> on 2012-04-25
- 8:24 AM Changeset in webkit [115211] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=82300
Unmark compositing/images/direct-pdf-image.html as failing on Mac 10.6
- platform/chromium/test_expectations.txt:
- 8:22 AM Changeset in webkit [115210] by
-
- 8 edits8 adds in trunk
[Qt] add LayoutTestController::setPrinting support to Qt unit tests
https://bugs.webkit.org/show_bug.cgi?id=84246
Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-04-25
Reviewed by Simon Hausmann.
Source/WebKit/qt:
- Api/qwebframe.cpp:
(QWebFrame::paintPagesWithBoundaries):
- Api/qwebframe.h:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::paintPagesWithBoundaries):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::dump):
LayoutTests:
- platform/qt/printing/compositing-layer-printing-expected.png: Added.
- platform/qt/printing/compositing-layer-printing-expected.txt: Added.
- platform/qt/printing/media-queries-print-expected.png: Added.
- platform/qt/printing/media-queries-print-expected.txt: Added.
- platform/qt/printing/page-rule-in-media-query-expected.png: Added.
- platform/qt/printing/page-rule-in-media-query-expected.txt: Renamed from LayoutTests/platform/qt/printing/page-rule-in-media-query-expected.txt.
- platform/qt/printing/simultaneous-position-float-change-expected.png: Added.
- platform/qt/printing/simultaneous-position-float-change-expected.txt: Added.
- platform/qt/printing/width-overflow-expected.png: Added.
- platform/qt/printing/width-overflow-expected.txt: Added.
- platform/qt/Skipped:
- platform/qt/printing/page-rule-in-media-query-expected.png: Removed.
- 8:16 AM Changeset in webkit [115209] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=74055
Unmark fast/canvas/canvas-largedraws.html as failing on Mac 10.5
- platform/chromium/test_expectations.txt:
- 8:10 AM Changeset in webkit [115208] by
-
- 2 edits in trunk/LayoutTests
fast/js/random-array-gc-stress times out in debug mode
https://bugs.webkit.org/show_bug.cgi?id=84821
Reviewed by Darin Adler.
- fast/js/script-tests/random-array-gc-stress.js: Reduce number of iterations so
that the test can complete without timing out. Also remove the gc() function because
a gc() function is already provided in resources/js-test-pre.js.
- 7:52 AM Changeset in webkit [115207] by
-
- 2 edits in trunk/Source/WebCore
[chromium][workers] setTargetType(ResourceRequest::TargetIsWorker) is repeatedly called in chromium
https://bugs.webkit.org/show_bug.cgi?id=84542
Patch by Li Yin <li.yin@intel.com> on 2012-04-25
Reviewed by David Levin.
In chromium platform, the default value of m_targetType is ResourceRequest::TargetIsWorker
it isn't necessary to call
worker->m_scriptLoader->setTargetType(ResourceRequest::TargetIsWorker) again in Worker.cpp
In chromium platform, the m_targettype value determines the priority of resource loaded.
No new tests because this patch just deletes a repeated code, it can reduce code workload and can't impact any feature.
If the target type isn't set correctly, the following test maybe fail because of timeout in the chromium.
fast/workers/storage/multiple-transactions-on-different-handles.html
fast/workers/storage/multiple-transactions-on-different-handles-sync.html
fast/workers/storage/interrupt-database.html
- workers/Worker.cpp:
(WebCore::Worker::create):
- 7:42 AM Changeset in webkit [115206] by
-
- 6 edits in trunk/Source
[Chromium] Fix some conditional compilation logic in Platform
https://bugs.webkit.org/show_bug.cgi?id=83798
Reviewed by Darin Fisher.
Source/Platform:
- chromium/public/WebURLError.h:
(WebURLError):
- chromium/public/WebURLRequest.h:
(WebURLRequest):
- chromium/public/WebURLResponse.h:
(WebURLResponse):
Source/WebKit/chromium:
- tests/WebFrameTest.cpp:
(WebKit::TestReloadDoesntRedirectWebFrameClient::cancelledError):
- 7:39 AM Changeset in webkit [115205] by
-
- 10 edits1 add in trunk/Source
Web Inspector: move HeapSnapshotLoader into a separate file
https://bugs.webkit.org/show_bug.cgi?id=84860
Extracted HeapSnapshotLoader into its own file.
Reviewed by Pavel Feldman.
Source/WebCore:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/HeapSnapshot.js:
- inspector/front-end/HeapSnapshotLoader.js: Added.
(WebInspector.HeapSnapshotLoader):
(WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
(WebInspector.HeapSnapshotLoader.prototype.finishLoading):
(WebInspector.HeapSnapshotLoader.prototype._parseUintArray):
(WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
Source/WebKit/chromium:
- WebKit.gyp:
- 7:35 AM Changeset in webkit [115204] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaseline after r115187.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-25
- platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
- 7:28 AM Changeset in webkit [115203] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: inspector frontend tests fix.
- inspector/front-end/ScriptsSearchScope.js:
- 7:16 AM Changeset in webkit [115202] by
-
- 4 edits in trunk/Source
[chromium] Animations waiting for a synchronized start time should never be marked finished.
https://bugs.webkit.org/show_bug.cgi?id=84519
Patch by Ian Vollick <vollick@chromium.org> on 2012-04-25
Reviewed by James Robinson.
Source/WebCore:
Tested in CCLayerAnimationControllerTest.AnimationsWaitingForStartTimeDoNotFinishIfTheyWaitLongerToStartThanTheirDuration
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::tickAnimations):
Source/WebKit/chromium:
- tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):
- 7:04 AM Changeset in webkit [115201] by
-
- 9 edits in trunk
[SVG] Nothing should be stroked when the stroke-width is 0
https://bugs.webkit.org/show_bug.cgi?id=83568
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The spec states that "A zero value causes no stroke to be painted".
We should avoid calling functions that could incorrectly paint something
in that case.
Test: svg/custom/path-zero-strokewidth.svg
- rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::hasVisibleStroke):
- rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::strokeShape): Check if the stroke should be visible before painting.
- rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::strokeShape): Ditto.
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::strokeShape): Ditto.
(WebCore::RenderSVGShape::strokePath): Ditto.
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paint): Dont call paintText for zero-width stroke.
(WebCore::SVGInlineTextBox::paintDecoration): Ditto.
LayoutTests:
- platform/chromium/test_expectations.txt: mark affected tests for rebaseline.
- platform/qt/Skipped: Unskip svg/custom/path-zero-strokewidth.svg
- 7:02 AM Changeset in webkit [115200] by
-
- 9 edits2 copies in trunk/Source
Move WebReferrerPolicy.h from WebKit to Platform
https://bugs.webkit.org/show_bug.cgi?id=84539
Reviewed by Adam Barth.
Source/Platform:
- Platform.gypi:
- chromium/public/WebReferrerPolicy.h: Copied from Source/WebKit/chromium/public/WebReferrerPolicy.h.
(WebKit):
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebContextMenuData.h:
- public/WebFrame.h:
- public/WebReferrerPolicy.h:
- public/WebSecurityPolicy.h:
- public/platform/WebReferrerPolicy.h: Copied from Source/WebKit/chromium/public/WebReferrerPolicy.h.
- src/AssertMatchingEnums.cpp:
- 6:59 AM Changeset in webkit [115199] by
-
- 1 edit2 copies in trunk/Source/WebCore
Unfortunately http://trac.webkit.org/changeset/115055 was landed using webkit-patch
land-from bug but didn't do the right thing, we lost the history.
This commit is merging back CSSStyleApplyProperty.* and their history, rename the files
to StyleBuilder and re-apply the two patches on trunk that were apply after the rename.
Rename CSSStyleSelector class to StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=84734
The name CSSStyleSelector is confusing as it conflicts a bit with
the CSS concept of selectors. One could think it's an encapsulation
of the CSS selectors but it's not, in fact this class is responsible
of finding the RenderStyle for a given element. This is the first patch
as I will later rename the files, and then rename the local variables.
Replace occurences of style selector from variables and methods names by style resolver.
https://bugs.webkit.org/show_bug.cgi?id=84765
Rename methods and variables to follow the new name StyleResolver. It requires to update the
local variables, methods parameters, and function names to match the new name and to remove
the concept of "selector" to avoid clashing with the CSS concept. The next and last patch
will be to rename CSSStyleSelector file and update the includes.
Source/WebCore:
- css/StyleBuilder.cpp: Replaced with Source/WebCore/css/CSSStyleApplyProperty.cpp. (WebCore::ApplyPropertyExpanding::applyInheritValue): (WebCore::ApplyPropertyExpanding::applyInitialValue): (WebCore::ApplyPropertyExpanding::applyValue): (WebCore::ApplyPropertyDefaultBase::applyInheritValue): (WebCore::ApplyPropertyDefaultBase::applyInitialValue): (WebCore::ApplyPropertyDefaultBase::applyValue): (WebCore::ApplyPropertyDefault::applyValue): (WebCore::ApplyPropertyNumber::applyValue): (WebCore::ApplyPropertyStyleImage::applyValue): (WebCore::ApplyPropertyAuto::applyInheritValue): (WebCore::ApplyPropertyAuto::applyInitialValue): (WebCore::ApplyPropertyAuto::applyValue): (WebCore::ApplyPropertyClip::convertToLength): (WebCore::ApplyPropertyClip::applyInheritValue): (WebCore::ApplyPropertyClip::applyInitialValue): (WebCore::ApplyPropertyClip::applyValue): (WebCore::ApplyPropertyColor::applyInheritValue): (WebCore::ApplyPropertyColor::applyInitialValue): (WebCore::ApplyPropertyColor::applyValue): (WebCore::ApplyPropertyColor::applyColorValue): (WebCore::ApplyPropertyDirection::applyValue): (WebCore::ApplyPropertyLength::applyValue): (WebCore::ApplyPropertyString::applyValue): (WebCore::ApplyPropertyBorderRadius::applyValue): (WebCore::ApplyPropertyFillLayer::applyInheritValue): (WebCore::ApplyPropertyFillLayer::applyInitialValue): (WebCore::ApplyPropertyFillLayer::applyValue): (WebCore::ApplyPropertyComputeLength::applyValue): (WebCore::ApplyPropertyFont::applyInheritValue): (WebCore::ApplyPropertyFont::applyInitialValue): (WebCore::ApplyPropertyFont::applyValue): (WebCore::ApplyPropertyFontSize::applyInheritValue): (WebCore::ApplyPropertyFontSize::applyInitialValue): (WebCore::ApplyPropertyFontSize::applyValue): (WebCore::ApplyPropertyFontWeight::applyValue): (WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue): (WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue): (WebCore::ApplyPropertyFontVariantLigatures::applyValue): (WebCore::ApplyPropertyBorderImage::applyValue): (WebCore::ApplyPropertyBorderImageModifier::applyInheritValue): (WebCore::ApplyPropertyBorderImageModifier::applyInitialValue): (WebCore::ApplyPropertyBorderImageModifier::applyValue): (WebCore::ApplyPropertyBorderImageSource::applyValue): (WebCore::ApplyPropertyCounter::emptyFunction): (WebCore::ApplyPropertyCounter::applyInheritValue): (WebCore::ApplyPropertyCounter::applyValue): (WebCore::ApplyPropertyCursor::applyInheritValue): (WebCore::ApplyPropertyCursor::applyInitialValue): (WebCore::ApplyPropertyCursor::applyValue): (WebCore::ApplyPropertyTextAlign::applyValue): (WebCore::ApplyPropertyTextDecoration::applyValue): (WebCore::ApplyPropertyUnicodeBidi::applyValue): (WebCore::ApplyPropertyLineHeight::applyValue): (WebCore::ApplyPropertyPageSize::applyInheritValue): (WebCore::ApplyPropertyPageSize::applyInitialValue): (WebCore::ApplyPropertyPageSize::applyValue): (WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue): (WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue): (WebCore::ApplyPropertyTextEmphasisStyle::applyValue): (WebCore): (WebCore::ApplyPropertyAnimation::map): (WebCore::ApplyPropertyAnimation::applyInheritValue): (WebCore::ApplyPropertyAnimation::applyInitialValue): (WebCore::ApplyPropertyAnimation::applyValue): (WebCore::ApplyPropertyOutlineStyle::applyInheritValue): (WebCore::ApplyPropertyOutlineStyle::applyInitialValue): (WebCore::ApplyPropertyOutlineStyle::applyValue): (WebCore::ApplyPropertyResize::applyValue): (WebCore::ApplyPropertyVerticalAlign::applyValue): (WebCore::ApplyPropertyAspectRatio::applyInheritValue): (WebCore::ApplyPropertyAspectRatio::applyInitialValue): (WebCore::ApplyPropertyAspectRatio::applyValue): (WebCore::ApplyPropertyZoom::resetEffectiveZoom): (WebCore::ApplyPropertyZoom::applyInheritValue): (WebCore::ApplyPropertyZoom::applyInitialValue): (WebCore::ApplyPropertyZoom::applyValue): (WebCore::ApplyPropertyDisplay::isValidDisplayValue): (WebCore::ApplyPropertyDisplay::applyInheritValue): (WebCore::ApplyPropertyDisplay::applyInitialValue): (WebCore::ApplyPropertyDisplay::applyValue): (WebCore::ApplyPropertyFlex::applyInheritValue): (WebCore::ApplyPropertyFlex::applyInitialValue): (WebCore::ApplyPropertyFlex::applyValue): (WebCore::StyleBuilder::StyleBuilder):
- css/StyleBuilder.h: Replaced with Source/WebCore/css/CSSStyleApplyProperty.h. (WebCore): (PropertyHandler): (WebCore::PropertyHandler::applyInheritValue): (WebCore::PropertyHandler::applyInitialValue): (WebCore::PropertyHandler::applyValue):
- 6:57 AM Changeset in webkit [115198] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed, fix Windows build after r115165.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers): Initialize logging variable.
- 6:48 AM Changeset in webkit [115197] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
Rebaseline after r115187.
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
Rebaseline after r115091.
- platform/gtk/test_expectations.txt:
- 6:45 AM Changeset in webkit [115196] by
-
- 3 edits in trunk/Source/WebCore
[Coverity] Uninitialized fields in RenderSVGShape constructors
https://bugs.webkit.org/show_bug.cgi?id=84749
Reviewed by Darin Adler.
Removing unused RenderSVGShape constructor and field.
No new tests - no behavior change.
- rendering/svg/RenderSVGShape.cpp:
- rendering/svg/RenderSVGShape.h:
(RenderSVGShape):
- 6:36 AM Changeset in webkit [115195] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: follow up to r115194, removed debug output.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
- 6:34 AM Changeset in webkit [115194] by
-
- 18 edits1 add in trunk
Source/WebCore: Web Inspector: extract Linkifier from DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=84855
Reviewed by Yury Semikhatsky.
There is nothing Linkifier needs from the model, extracting as a top-level class.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/ConsoleMessage.js:
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
- inspector/front-end/DebuggerPresentationModel.js:
- inspector/front-end/EventListenersSidebarPane.js:
- inspector/front-end/Linkifier.js: Added.
(WebInspector.LinkifierFormatter):
(WebInspector.LinkifierFormatter.prototype.formatLiveAnchor):
(WebInspector.Linkifier):
(WebInspector.Linkifier.prototype.linkifyLocation):
(WebInspector.Linkifier.prototype.linkifyRawLocation):
(WebInspector.Linkifier.prototype.reset):
(WebInspector.Linkifier.prototype._updateAnchor):
(WebInspector.Linkifier.DefaultFormatter):
(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):
- inspector/front-end/NetworkPanel.js:
- inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
- inspector/front-end/ProfileView.js:
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
Source/WebKit2: [Qt] Make the web view's url property follow the active url
https://bugs.webkit.org/show_bug.cgi?id=77554
The url property of the webview now reflects the 'active' url of the
page, which maps to either the currently loading url, in the case of
an ongoing load, or the result of a load, even when the load failed.
In practice this means that setting the url though QML, or navigating
to a new url in the page by e.g clicking, will both instantly change
the url-property of the webview to the target url. This differs from
earlier behavior, where we would update the url when the load
committed.
An optional argument is added to loadHtml(), to allow setting
the unreachable url when providing replacement content for failed
loads.
A slight change in the activeUrl() implementation is also done,
where we now favour the url of an pending API request, even when
we don't have a mainframe yet.
Finally, the location bar in the minibrowser is updated to behave
a bit more like normal browsers in terms of when the url will change
and how active focus is handled.
Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebView::reload):
(QQuickWebView::url):
(QQuickWebView::setUrl):
(QQuickWebView::loadHtml):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
- UIProcess/API/qt/tests/qmltests/WebView.pro:
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml:
- UIProcess/API/qt/tests/qmltests/common/link.html: Added.
- UIProcess/API/qt/tests/qmltests/common/redirect.html: Added.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activeURL):
- UIProcess/qt/QtWebPageLoadClient.cpp:
(QtWebPageLoadClient::QtWebPageLoadClient):
(QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(QtWebPageLoadClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::dispatchLoadFailed):
(QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame):
(QtWebPageLoadClient::didFailLoadWithErrorForFrame):
- UIProcess/qt/QtWebPageLoadClient.h:
(QtWebPageLoadClient):
LayoutTests: Web Inspector: extract Linkifier from DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=84855
Reviewed by Yury Semikhatsky.
- inspector/debugger/linkifier.html:
- 6:32 AM Changeset in webkit [115193] by
-
- 3 edits1 add in trunk
[Qt] Zoom back can overscroll document edges.
https://bugs.webkit.org/show_bug.cgi?id=84851
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-25
Reviewed by Kenneth Rohde Christiansen.
.:
Manual test for overscroll on zoom-back. Needs to be manual since we do not yet
have automatic testing for this type of UI-side behaviour.
- ManualTests/qt/double-tap-overscroll.html: Added.
Source/WebKit2:
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
- 6:31 AM Changeset in webkit [115192] by
-
- 20 edits in trunk
Web Inspector: move sourcemap-agnostic part of the debugger presentation model into the raw debugger.
https://bugs.webkit.org/show_bug.cgi?id=84852
Reviewed by Yury Semikhatsky.
Source/WebCore:
There is no need to keep that much debugging functionality in the debugger presentation model.
It all perfectly applies to the raw script debugger. Methods for selecting call frames, activating breakpoints
and paused details were moved to the WebInspector.DebuggerModel.
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):
- inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.setSelectedCallFrame):
(WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
(WebInspector.CallStackSidebarPane.prototype._placardSelected):
(WebInspector.CallStackSidebarPane.Placard):
(WebInspector.CallStackSidebarPane.Placard.prototype._update):
- inspector/front-end/ConsoleView.js:
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._globalObjectCleared):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
(WebInspector.DebuggerModel.prototype._setDebuggerPausedDetails):
(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerModel.prototype._resumedScript):
(WebInspector.DebuggerModel.prototype.isPaused):
(WebInspector.DebuggerModel.prototype.setSelectedCallFrame.updateExecutionLine):
(WebInspector.DebuggerModel.prototype.setSelectedCallFrame):
(WebInspector.DebuggerModel.prototype.selectedCallFrame):
(WebInspector.DebuggerModel.prototype.evaluateOnSelectedCallFrame):
(WebInspector.DebuggerModel.prototype.getSelectedCallFrameVariables.propertiesCollected):
(WebInspector.DebuggerModel.prototype.getSelectedCallFrameVariables):
(WebInspector.DebuggerModel.prototype.setBreakpointsActive):
(WebInspector.DebuggerModel.prototype.breakpointsActive):
(WebInspector.DebuggerModel.CallFrame):
(WebInspector.DebuggerModel.CallFrame.prototype.get script):
(WebInspector.DebuggerModel.CallFrame.prototype.get type):
(WebInspector.DebuggerModel.CallFrame.prototype.get scopeChain):
(WebInspector.DebuggerModel.CallFrame.prototype.get this):
(WebInspector.DebuggerModel.CallFrame.prototype.get functionName):
(WebInspector.DebuggerModel.CallFrame.prototype.get location):
(WebInspector.DebuggerModel.CallFrame.prototype.evaluate):
(WebInspector.DebuggerModel.CallFrame.prototype.createLiveLocation):
(WebInspector.DebuggerModel.CallFrame.prototype.dispose):
(WebInspector.DebuggerPausedDetails):
(WebInspector.DebuggerPausedDetails.prototype.dispose):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.createLiveLocation):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._callFrameSelected):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.setBreakpoint):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
- inspector/front-end/Script.js:
(WebInspector.Script.prototype.setSourceMapping):
(WebInspector.Script.prototype.createLiveLocation):
(WebInspector.Script.Location.prototype.update):
- inspector/front-end/ScriptMapping.js:
(WebInspector.LiveLocation):
(WebInspector.LiveLocation.prototype.update):
(WebInspector.LiveLocation.prototype.dispose):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._consoleCommandEvaluatedInSelectedCallFrame):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
- inspector/front-end/UISourceCode.js:
LayoutTests:
- http/tests/inspector/debugger-test.js:
- inspector/debugger/callstack-placards-discarded.html:
- inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
- inspector/debugger/live-edit-expected.txt:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/selected-call-frame-after-formatting-source.html:
- inspector/debugger/set-breakpoint.html:
- 6:29 AM Changeset in webkit [115191] by
-
- 14 edits2 adds in trunk
[Qt] Make the web view's url property follow the active url
https://bugs.webkit.org/show_bug.cgi?id=77554
The url property of the webview now reflects the 'active' url of the
page, which maps to either the currently loading url, in the case of
an ongoing load, or the result of a load, even when the load failed.
In practice this means that setting the url though QML, or navigating
to a new url in the page by e.g clicking, will both instantly change
the url-property of the webview to the target url. This differs from
earlier behavior, where we would update the url when the load
committed.
An optional argument is added to loadHtml(), to allow setting
the unreachable url when providing replacement content for failed
loads.
A slight change in the activeUrl() implementation is also done,
where we now favour the url of an pending API request, even when
we don't have a mainframe yet.
Finally, the location bar in the minibrowser is updated to behave
a bit more like normal browsers in terms of when the url will change
and how active focus is handled.
Reviewed by Simon Hausmann.
- 6:15 AM Changeset in webkit [115190] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=84854
Mark the following tests as flaky on Linux 32-bit:
svg/batik/text/textOnPath.svg
svg/batik/text/verticalTextOnPath.svg
- platform/chromium/test_expectations.txt:
- 5:32 AM Changeset in webkit [115189] by
-
- 8 edits in trunk
Web Inspector: use composite node provider for diff nodes in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=84849
Inroduced HeapSnapshotDiffNodesProvider which is basically a composite provider
combining providers for added and deleted nodes. This allowed to remove custom
implementation of HeapSnapshotGridNode.prototype.populateChildren.
Source/WebCore:
Reviewed by Pavel Feldman.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNodesProvider.prototype.sort.sortByNodeField): moved index assignment to sortByComparator
so that it is done only once.
(WebInspector.HeapSnapshotNodesProvider.prototype.sort.sortByComparator):
(WebInspector.HeapSnapshotNodesProvider.prototype.sort):
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotDiffNodesProvider):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.dispose):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.isEmpty):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeNextItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeNextItems.didReceiveDeletedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeNextItems.didReceiveAddedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.sortAndRewind.afterSort):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.sortAndRewind):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode._createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
LayoutTests:
Reviewed by Pavel Feldman.
- inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html:
- inspector/profiler/heap-snapshot-comparison-show-all.html:
- inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html:
- 5:25 AM Changeset in webkit [115188] by
-
- 3 edits in trunk/LayoutTests
[Qt] Gardening. Skipped a failing test.
https://bugs.webkit.org/show_bug.cgi?id=84566
Removed a test from test_expectations after r115171.
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-04-25
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- platform/qt/test_expectations.txt:
- 4:57 AM Changeset in webkit [115187] by
-
- 27 edits in trunk
Refactor to/from/animatedType creation, to share more code between animators
https://bugs.webkit.org/show_bug.cgi?id=84846
Reviewed by Antti Koivisto.
Source/WebCore:
Share more code bewteen animators, doesn't change functionality yet, except for one bug in SVGAnimatedString.
SVGAnimatedString used to mutate the from/to values during animation, leading to problems in animate-element-31-t.svg.
It now needs a rebaseline, now that this bug is fixed as side-effect.
- svg/SVGAnimateColorElement.cpp:
(WebCore::attributeValueIsCurrentColor):
(WebCore::SVGAnimateColorElement::determinePropertyValueTypes):
(WebCore):
- svg/SVGAnimateColorElement.h:
(SVGAnimateColorElement):
- svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::SVGAnimateElement):
- svg/SVGAnimateElement.h:
(SVGAnimateElement):
- svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
- svg/SVGAnimatedBoolean.cpp:
(WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue):
- svg/SVGAnimatedColor.cpp:
(WebCore::adjustForCurrentColor):
(WebCore):
(WebCore::parseColorFromString):
(WebCore::SVGAnimatedColorAnimator::calculateAnimatedValue):
- svg/SVGAnimatedEnumeration.cpp:
(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):
- svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedInteger):
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):
- svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateAnimatedValue):
- svg/SVGAnimatedLength.cpp:
(WebCore::parseLengthFromString):
(WebCore):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
- svg/SVGAnimatedLengthList.cpp:
(WebCore::parseLengthListFromString):
(WebCore):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
- svg/SVGAnimatedNumber.cpp:
(WebCore::parseNumberFromString):
(WebCore):
(WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue):
- svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
- svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):
- svg/SVGAnimatedPointList.cpp:
(WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):
- svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue):
- svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue):
- svg/SVGAnimatedString.cpp:
(WebCore::parseStringFromString):
(WebCore):
(WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue):
- svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::SVGAnimationElement):
(WebCore::SVGAnimationElement::adjustForInheritance):
(WebCore):
(WebCore::inheritsFromProperty):
(WebCore::SVGAnimationElement::determinePropertyValueTypes):
- svg/SVGAnimationElement.h:
(WebCore::SVGAnimationElement::fromPropertyValueType):
(WebCore::SVGAnimationElement::toPropertyValueType):
(SVGAnimationElement):
(WebCore::SVGAnimationElement::adjustForInheritance):
(WebCore::SVGAnimationElement::adjustFromToValues):
(WebCore::SVGAnimationElement::adjustFromToListValues):
LayoutTests:
Rebaseline one test result, which shows a progression.
(At the initial time when we capture the result, only two circles should be visible.)
- platform/chromium/test_expectations.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
- 4:54 AM Changeset in webkit [115186] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=84847
Mark inspector/timeline/timeline-start-time.html as flaky on Windows.
- platform/chromium/test_expectations.txt:
- 4:46 AM Changeset in webkit [115185] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
Unmark the following CSS pseudo-class tests:
fast/css/empty-pseudo-class.html
fast/css/first-child-pseudo-class.html
fast/css/first-of-type-pseudo-class.html
fast/css/last-child-pseudo-class.html
fast/css/last-of-type-pseudo-class.html
fast/css/only-child-pseudo-class.html
fast/css/only-of-type-pseudo-class.html
- platform/chromium/test_expectations.txt:
- 4:42 AM WebKit Team edited by
- (diff)
- 4:36 AM Changeset in webkit [115184] by
-
- 4 edits in trunk
Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
https://bugs.webkit.org/show_bug.cgi?id=81913
Patch by Philippe Normand <pnormand@igalia.com> on 2012-04-25
Reviewed by Tor Arne Vestbø.
Source/WTF:
- WTF.pri: GStreamer build support implies GLib support, as it's
done in WebCore.pri.
Tools:
- qmake/mkspecs/features/features.prf: Check for gstreamer-0.10
and gstreamer-plugins-base >= 0.10.30 just like the GTK port
does. 0.10.27 is unfortunately not recent enough to get the media
player working reliably.
- 4:17 AM Changeset in webkit [115183] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
Remove expectation for a passing test:
fast/dom/error-to-string-stack-overflow.html
Add an expectation for a passing test:
fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html
- platform/chromium/test_expectations.txt:
- 4:01 AM Changeset in webkit [115182] by
-
- 2 edits in trunk/Tools
[BlackBerry] Run tests in '/http/tests/local' with local URI
https://bugs.webkit.org/show_bug.cgi?id=84820
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-04-25
Reviewed by Nikolas Zimmermann.
Currently we run all tests under folder "/http/tests/" as HTTP
tests (http://...). However in WebKit ORWT and NRWT scripts, tests in
'http/tests/local' are run with local path (like '/developer/LayoutTests
/http/tests/local/absolute-url-strip-whitespace.html').
With this patch we can keep the same behaviour as other portings.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::isHTTPTest):
- 3:44 AM Changeset in webkit [115181] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
Unmark these tests as failing on Windows:
fast/repaint/moving-shadow-on-container.html
fast/repaint/moving-shadow-on-path.html
- platform/chromium/test_expectations.txt:
- 3:40 AM Changeset in webkit [115180] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=84813
Mark these tests as failing only on Mac and Windows:
css3/filters/custom/custom-filter-shader-cache.html
css3/filters/custom/effect-custom-combined-missing.html
css3/filters/custom/effect-custom.html
- platform/chromium/test_expectations.txt:
- 3:34 AM Changeset in webkit [115179] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
Unmark html5lib/runner.html -- changes that broke it were reverted in r115149.
- platform/chromium/test_expectations.txt:
- 3:05 AM Changeset in webkit [115178] by
-
- 37 edits in trunk/Source/WebCore
Share single calculateFromToValues/calculateFromByValues between all SVGAnimatedTypeAnimators
https://bugs.webkit.org/show_bug.cgi?id=84832
Reviewed by Antti Koivisto.
calculateFromAndToValues / calculateFromAndByValues don't need to be spread across all SVGAnimatedTypeAnimators.
Centralize these new implementations in SVGAnimatedTypeAnimator.h. Refactored addAnimatedTypes() from constructFromAndByValues.
calculateFromAndToValues:
from = constructFromString(fromString)
to = constructFromString(toString)
calculateFromAndByValues:
from = constructFromString(fromString)
to = constructFromString(byString)
addAnimatedTypes(from, to)
Doesn't affect any tests, just refactors code.
- svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
- svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::addAnimatedTypes):
- svg/SVGAnimatedAngle.h:
(SVGAnimatedAngleAnimator):
- svg/SVGAnimatedBoolean.cpp:
(WebCore::SVGAnimatedBooleanAnimator::addAnimatedTypes):
- svg/SVGAnimatedBoolean.h:
(SVGAnimatedBooleanAnimator):
- svg/SVGAnimatedColor.cpp:
(WebCore::SVGAnimatedColorAnimator::addAnimatedTypes):
- svg/SVGAnimatedColor.h:
(SVGAnimatedColorAnimator):
- svg/SVGAnimatedEnumeration.cpp:
(WebCore::SVGAnimatedEnumerationAnimator::addAnimatedTypes):
- svg/SVGAnimatedEnumeration.h:
(SVGAnimatedEnumerationAnimator):
- svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::addAnimatedTypes):
- svg/SVGAnimatedInteger.h:
(SVGAnimatedIntegerAnimator):
- svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::addAnimatedTypes):
- svg/SVGAnimatedIntegerOptionalInteger.h:
(SVGAnimatedIntegerOptionalIntegerAnimator):
- svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
- svg/SVGAnimatedLength.h:
(SVGAnimatedLengthAnimator):
- svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
- svg/SVGAnimatedLengthList.h:
(SVGAnimatedLengthListAnimator):
- svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::addAnimatedTypes):
- svg/SVGAnimatedNumber.h:
(SVGAnimatedNumberAnimator):
- svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::addAnimatedTypes):
- svg/SVGAnimatedNumberList.h:
(SVGAnimatedNumberListAnimator):
- svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::addAnimatedTypes):
- svg/SVGAnimatedNumberOptionalNumber.h:
(SVGAnimatedNumberOptionalNumberAnimator):
- svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::constructFromString):
(WebCore::SVGAnimatedPathAnimator::addAnimatedTypes):
- svg/SVGAnimatedPath.h:
(SVGAnimatedPathAnimator):
- svg/SVGAnimatedPointList.cpp:
(WebCore::SVGAnimatedPointListAnimator::addAnimatedTypes):
- svg/SVGAnimatedPointList.h:
(SVGAnimatedPointListAnimator):
- svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::addAnimatedTypes):
- svg/SVGAnimatedPreserveAspectRatio.h:
(SVGAnimatedPreserveAspectRatioAnimator):
- svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::addAnimatedTypes):
- svg/SVGAnimatedRect.h:
(SVGAnimatedRectAnimator):
- svg/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedStringAnimator::addAnimatedTypes):
- svg/SVGAnimatedString.h:
(SVGAnimatedStringAnimator):
- svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::SVGAnimatedTransformListAnimator):
(WebCore::SVGAnimatedTransformListAnimator::constructFromString):
(WebCore::SVGAnimatedTransformListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedTransformListAnimator::calculateDistance):
- svg/SVGAnimatedTransformList.h:
(SVGAnimatedTransformListAnimator):
- svg/SVGAnimatedTypeAnimator.h:
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedTypeAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedTypeAnimator::setContextElement):
- 1:18 AM Changeset in webkit [115177] by
-
- 3 edits in trunk/Source/WebCore
Shrink RenderText by 8 bytes on 64-bit.
<http://webkit.org/b/84828>
Reviewed by Maciej Stachowiak.
Reorder the members so that the bits in RenderText falls into the padding at
the end of RenderObject on 64-bit. Updated the compile-time size assertion to
account for the new object structure.
This shrinks RenderText from 104 to 96 bytes on 64-bit release builds.
- rendering/RenderText.cpp:
(SameSizeAsRenderText):
(WebCore::RenderText::RenderText):
- rendering/RenderText.h:
(RenderText):
- 1:09 AM Changeset in webkit [115176] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Unskipped 28 http tests passing on all the GTK+ bots.
- platform/gtk/test_expectations.txt:
- 12:56 AM Changeset in webkit [115175] by
-
- 33 edits in trunk/LayoutTests
2012-04-25 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update pixel test baseline on Lion. All color space changes when painting images.
I noticed that svg/custom/focus-ring.svg is flakey, the result may be off by two 1px changes.
- platform/mac/svg/as-background-image/svg-as-background-4-expected.png:
- platform/mac/svg/as-border-image/svg-as-border-image-2-expected.png:
- platform/mac/svg/carto.net/window-expected.png:
- platform/mac/svg/custom/createImageElement-expected.png:
- platform/mac/svg/custom/createImageElement2-expected.png:
- platform/mac/svg/custom/deep-dynamic-updates-expected.png:
- platform/mac/svg/custom/focus-ring-expected.png:
- platform/mac/svg/custom/image-parent-translation-expected.png:
- platform/mac/svg/custom/image-small-width-height-expected.png:
- platform/mac/svg/custom/image-with-prefix-in-webarchive-expected.png:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/mac/svg/custom/js-update-image-and-display-expected.png:
- platform/mac/svg/custom/js-update-image-and-display2-expected.png:
- platform/mac/svg/custom/js-update-image-and-display3-expected.png:
- platform/mac/svg/custom/js-update-image-expected.png:
- platform/mac/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/mac/svg/custom/pointer-events-image-expected.png:
- platform/mac/svg/custom/text-image-opacity-expected.png:
- platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/mac/svg/wicd/test-rightsizing-b-expected.png:
- platform/mac/svg/zoom/page/zoom-background-images-expected.png:
- 12:55 AM Changeset in webkit [115174] by
-
- 2 edits in trunk/Source/WebCore
No audio from MediaElementAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=84669
MediaElementAudioSourceNode needs custom propagatesSilence() to
return false to indicate the node never propagates silence.
Patch by Raymond Toy <Raymond Toy> on 2012-04-25
Reviewed by Chris Rogers.
- Modules/webaudio/MediaElementAudioSourceNode.h:
(MediaElementAudioSourceNode): Add propagatesSilence().
- 12:39 AM Changeset in webkit [115173] by
-
- 2 edits in trunk/Tools
[EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
https://bugs.webkit.org/show_bug.cgi?id=84709
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-04-25
Reviewed by Eric Seidel.
Not all the settings that can be changed by layout testcases through a JS API were
reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(defaultEditingBehavior): returns editing behavior depending on current platform.
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): reset some missed DRT settings
- 12:11 AM Changeset in webkit [115172] by
-
- 8 edits2 adds in trunk
Source/WebCore: Web Inspector: Incorrect highlight position of inspected element in a scrolled page
https://bugs.webkit.org/show_bug.cgi?id=84755
Reviewed by Pavel Feldman.
Test: inspector/elements/highlight-node-scroll.html
- inspector/DOMNodeHighlighter.cpp: Ensures the highlight position is in page coordinates.
LayoutTests: Web Inspector: REGRESSION: Incorrect highlight position of inspected element in scrolled page
https://bugs.webkit.org/show_bug.cgi?id=84755
Reviewed by Pavel Feldman.
- http/tests/inspector/elements-test.js: Extracted common function dumpInspectorHighlightRects() into here with a small bug fixed (x and y inversed).
- inspector/elements/highlight-node-scaled-expected.txt: Corrected the wrong inversed x and y.
- inspector/elements/highlight-node-scaled.html: Extracted out dumpInspectorHighlightRects().
- inspector/elements/highlight-node-scroll-expected.txt: Added. Expectation of the new test case.
- inspector/elements/highlight-node-scroll.html: Added. The new test case.
- inspector/elements/highlight-node.html: Extracted out dumpInspectorHighlightRects(). Expectation not changed because the x and y happened to be the same in the original expectation.
- inspector/elements/highlight-svg-root.html: Ditto.
- 12:08 AM Changeset in webkit [115171] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed morning gardening after r115091.
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- 12:02 AM Changeset in webkit [115170] by
-
- 11 edits in trunk/LayoutTests
[Qt] Unreviewed morning gardening after r115085.
- platform/qt/Skipped: Unskip a non-existing test.
- platform/qt/svg/custom/embedding-external-svgs-expected.txt:
- platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
- platform/qt/svg/custom/use-clipped-hit-expected.txt:
- platform/qt/svg/custom/use-modify-target-symbol-expected.txt:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/qt/svg/custom/use-setAttribute-crash-expected.txt:
- platform/qt/svg/custom/use-symbol-overflow-expected.txt:
- platform/wk2/Skipped: Unskip a non-existing test.
- 12:00 AM Changeset in webkit [115169] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Skip inspector/profiler/heap-snapshot-comparison-dom-groups-change.html
on Win and Win Cairo in addition to Mac and Qt(JSC doesn't support heap profiling and
the test doesn't make sense there).
- platform/win/Skipped:
- platform/wincairo/Skipped:
