Timeline
May 10, 2012:
- 11:56 PM Changeset in webkit [116732] by
-
- 9 edits3 adds in trunk/Tools
Add a perf tab to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=86169
Reviewed by Dimitri Glazkov.
This is a first stab at making it easier to view the Chromium WebKit canary
perf graphs. For now, it's just a couple select elements and an iframe.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
- 11:33 PM Changeset in webkit [116731] by
-
- 10 edits in trunk/Source
[Chromium] Move instantiation of texture uploader to LayerRendererChromium.
https://bugs.webkit.org/show_bug.cgi?id=85893
Patch by David Reveman <reveman@chromium.org> on 2012-05-10
Reviewed by Adrienne Walker.
Source/WebCore:
Move instantiation of texture uploader to LayerRendererChromium and
allow CCProxy to decide between a throttled or unthrottled uploader
using a flag passed to the LayerRendererChromium constructor.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initializeSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):
- tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):
- 10:35 PM Changeset in webkit [116730] by
-
- 48 edits in trunk
ElementShadow should minimize the usage of "ShadowRoot" name
https://bugs.webkit.org/show_bug.cgi?id=85970
Reviewed by Dimitri Glazkov.
.:
Removed symbols which no longer exists
- Source/autotools/symbols.filter:
Source/WebCore:
This change cleans two out dated assumptions which brought in at
early stage of Shadow DOM implementation.
- Removed Element::hasShadowRoot(): shadow existence can be checked by Element::shadow().
- Made ElementShadow::removeAllShadowRoots() private: we no longer allow ShadowRoot removal. It can only happens at the ElementShadow destruction.
Most of changes in element implementations are basically simple
replacement from hasShadowRoot() to shadow().
No new tests. Covered by existing tests.
- WebCore.exp.in:
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::collectDescendant):
- dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseChild):
- dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
- dom/Element.cpp:
(WebCore::Element::recalcStyle):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::childrenChanged):
- dom/Element.h:
(Element):
(WebCore::isShadowHost):
(WebCore):
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::~ElementShadow):
(WebCore::ElementShadow::removeAllShadowRoots):
- dom/ElementShadow.h:
(ElementShadow):
(WebCore::ElementShadow::host):
- dom/EventDispatcher.cpp:
- dom/Node.cpp:
(WebCore::oldestShadowRootFor):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
- html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::createShadowSubtree):
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
(WebCore::HTMLKeygenElement::shadowSelect):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasMediaControls):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
- html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
- html/shadow/SliderThumbElement.cpp:
(WebCore::trackLimiterElementOf):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::buildObjectForNode):
- page/FocusController.cpp:
(WebCore):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::uploadButton):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::updateReferencedText):
(WebCore::SVGTRefElement::detachTarget):
- testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
Removed symbols which no longer exists
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
Removed tests cases which exercise shadow root removals.
Such functionality was only available from Internals object
and it made little sense to test it.
- fast/dom/shadow/content-element-move-expected.txt:
- fast/dom/shadow/content-element-move.html:
- fast/dom/shadow/dynamically-created-shadow-root-expected.html:
- fast/dom/shadow/dynamically-created-shadow-root.html:
- fast/dom/shadow/layout-tests-can-access-shadow-expected.txt:
- fast/dom/shadow/layout-tests-can-access-shadow.html:
- fast/dom/shadow/multiple-shadowroot-expected.txt:
- fast/dom/shadow/multiple-shadowroot.html:
- 10:31 PM Changeset in webkit [116729] by
-
- 46 edits in trunk
Move resumeAnimations to use Internals interface
https://bugs.webkit.org/show_bug.cgi?id=86063
Reviewed by Alexey Proskuryakov.
.:
- Source/autotools/symbols.filter: Add a symbol filter for resumeAnimations.
Source/WebCore:
Add resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
No new tests, since we are improving here the infra-structure for testing
a specific method.
- testing/Internals.cpp:
(WebCore::Internals::resumeAnimations):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/efl:
Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- WebKit.order:
- WebView/WebFrame.mm:
- WebView/WebFramePrivate.h:
Source/WebKit/qt:
Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp:
- WebFrame.h:
Source/WebKit2:
- win/WebKit2.def: Add a symbol filter for resumeAnimations.
Tools:
Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
LayoutTests:
Call resumeAnimations functions from internals, because it is able to work in the
cross-port way through the Internals interface.
- animations/play-state-suspend.html:
- animations/stop-animation-on-suspend.html:
- animations/suspend-resume-animation-events.html:
- animations/suspend-resume-animation.html:
- 9:51 PM Changeset in webkit [116728] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update
- platform/chromium/test_expectations.txt:
- 9:27 PM Changeset in webkit [116727] by
-
- 9 edits in trunk/Source
split MediaPlayer::enterFullscreen into 2 seperate functions
https://bugs.webkit.org/show_bug.cgi?id=86052
Patch by Min Qin <qinmin@google.com> on 2012-05-10
Reviewed by Benjamin Poulain.
Source/WebCore:
It is confusing that enterFullscreen returns a boolean while exitFullscreen does
not do the same. And ios does not need the return value.
So remove the return value on enterFullscreen and make a seperate canEnterFullscreen()
function for android.
No tests as there are no behavior change, just refactoring.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::enterFullscreen):
(WebCore):
(WebCore::MediaPlayer::canEnterFullscreen):
- platform/graphics/MediaPlayer.h:
(MediaPlayer):
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::enterFullscreen):
(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::canEnterFullscreen):
Source/WebKit/chromium:
It is confusing that enterFullscreen returns a boolean while exitFullscreen does
not do the same. And ios does not need the return value.
So remove the return value on enterFullscreen and make a seperate canEnterFullscreen()
function for android.
No behavior change, just refactoring.
- public/WebMediaPlayer.h:
(WebMediaPlayer):
(WebKit::WebMediaPlayer::enterFullscreen):
(WebKit::WebMediaPlayer::canEnterFullscreen):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::exitFullscreen):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enterFullScreenForElement):
- 9:16 PM Changeset in webkit [116726] by
-
- 4 edits in trunk
[EFL][DRT] Editor doesn't cancel composition as change of value
https://bugs.webkit.org/show_bug.cgi?id=85122
Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-10
Reviewed by Martin Robinson.
IME composition should be cancelled when the value of input element is changed programmatically.
However, EFL port doesn't cancel as change of value.
Therefore, this patch will fix the bug.
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):
LayoutTests:
- platform/efl/Skipped:
- 9:14 PM Changeset in webkit [116725] by
-
- 3 edits7 adds in trunk/LayoutTests
[chromium] Rebaseline compositing/geometry/horizontal-scroll-composited.html after r107389
Unreviewed test expectations update.
- platform/chromium-linux-x86/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/chromium-linux/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/chromium-mac-leopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/chromium-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-win-xp/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 9:00 PM Changeset in webkit [116724] by
-
- 10 edits in trunk/Source/WebCore
Unreviewed, rolling out r116715.
http://trac.webkit.org/changeset/116715
https://bugs.webkit.org/show_bug.cgi?id=86172
Broke http/tests/security/cross-frame-access-selection.html
(Requested by tkent on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-10
- dom/Document.cpp:
(WebCore):
(WebCore::Document::getSelection):
- dom/Document.h:
(Document):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::selection):
- dom/TreeScope.cpp:
(WebCore::TreeScope::~TreeScope):
- dom/TreeScope.h:
(WebCore):
(TreeScope):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::DOMSelection):
- page/DOMSelection.h:
(WebCore):
(WebCore::DOMSelection::create):
(DOMSelection):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore::DOMWindow::getSelection):
- page/DOMWindow.h:
(DOMWindow):
- 8:28 PM Changeset in webkit [116723] by
-
- 32 edits2 adds in trunk
WebKit should support tab-size.
https://bugs.webkit.org/show_bug.cgi?id=52994
Source/WebCore:
- Added boilerplate for "tab-size" CSS property.
- Added RenderStye::tabSize() as a RareInheritedData.
- Replaced TextRun::m_allowTabs into TextRun::m_tabSize.
Reviewed by Simon Fraser.
Tests: fast/css/tab-size-expected.html
fast/css/tab-size.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::paintRow):
- platform/graphics/Font.h:
(WebCore::Font::tabWidth):
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
(WebCore::TextRun::allowTabs):
(WebCore::TextRun::tabSize):
(WebCore::TextRun::setTabSize):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::paint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::constructTextRun):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRun):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::textWidth):
(WebCore::tryHyphenating):
- rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::width):
- rendering/RenderText.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::tabSize):
(WebCore::RenderStyleBitfields::collapsedTabSize):
(WebCore::RenderStyleBitfields::setTabSize):
(WebCore::RenderStyleBitfields::initialTabSize):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun):
- rendering/svg/SVGTextMetrics.cpp:
(WebCore::constructTextRun):
Source/WebKit/chromium:
Reviewed by Simon Fraser.
- src/WebTextRun.cpp:
(WebKit::WebTextRun::operator WebCore::TextRun):
LayoutTests:
Reviewed by Simon Fraser.
- fast/css/tab-size-expected.html: Added.
- fast/css/tab-size.html: Added.
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 8:07 PM Changeset in webkit [116722] by
-
- 5 edits1 add in trunk/Source
Sync with impl thread when removing references to external textures
https://bugs.webkit.org/show_bug.cgi?id=86054
We want to ensure the client side is safe to release textures, so we
sync with the impl thread when:
- we change the texture (and we had one)
- the layer is removed from the tree (and we had a texture)
- the layer is destroyed (and we had a texture)
Reviewed by James Robinson.
Test: TextureLayerChromiumTest.
- platform/graphics/chromium/TextureLayerChromium.cpp:
(WebCore::TextureLayerChromium::~TextureLayerChromium):
(WebCore::TextureLayerChromium::setTextureId):
(WebCore::TextureLayerChromium::setLayerTreeHost):
(WebCore):
- platform/graphics/chromium/TextureLayerChromium.h:
(TextureLayerChromium):
- 7:47 PM Changeset in webkit [116721] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] attempt to build fix for Chromium-mac.
r116697 introduced an override of a system function. It's intentional
and WebCoreTextFieldCell should be in the whitelist.
- WebCore.gyp/WebCore.gyp:
- 7:34 PM Changeset in webkit [116720] by
-
- 20 edits in trunk/Source
PDF files won't scroll in Safari when using Adobe plug-in
https://bugs.webkit.org/show_bug.cgi?id=86167
<rdar://problem/11389719>
Reviewed by Sam Weinig.
Source/WebCore:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
Loop over the frame view children looking for plug-in views that want wheel events
and add them to the non-fast scrollable region. Ideally, the plug-ins should be added
to the set of scrollable areas, but PluginView in WebKit2 is not a ScrollableArea yet.
- plugins/PluginViewBase.h:
(PluginViewBase):
(WebCore::PluginViewBase::wantsWheelEvents):
Source/WebKit2:
Add a way to whitelist plug-ins that we know will process wheel events correctly. Add the new
Adobe Reader plug-in to this whitelist. Only send wheel events to plug-ins that are in the whitelist.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::wantsWheelEvents):
(WebKit):
- PluginProcess/PluginControllerProxy.h:
(PluginControllerProxy):
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPlugin):
- PluginProcess/WebProcessConnection.h:
(WebProcessConnection):
- PluginProcess/WebProcessConnection.messages.in:
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::determineQuirks):
- Shared/Plugins/PluginQuirks.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::wantsWheelEvents):
(WebKit):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
(NetscapePlugin):
- WebProcess/Plugins/PDF/BuiltInPDFView.h:
(BuiltInPDFView):
- WebProcess/Plugins/PDF/BuiltInPDFView.mm:
(WebKit::BuiltInPDFView::wantsWheelEvents):
(WebKit):
- WebProcess/Plugins/Plugin.h:
(Plugin):
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::PluginProxy):
(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::wantsWheelEvents):
(WebKit):
- WebProcess/Plugins/PluginProxy.h:
(PluginProxy):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::wantsWheelEvents):
(WebKit):
(WebKit::PluginView::handleEvent):
- WebProcess/Plugins/PluginView.h:
(PluginView):
- 7:31 PM Changeset in webkit [116719] by
-
- 13 edits2 adds in trunk
Crash in 3rd party WebKit apps that disable cache at a wrong time
https://bugs.webkit.org/show_bug.cgi?id=86027
<rdar://problem/10615880>
Reviewed by Antti Koivisto.
Source/WebCore:
Added an API test.
The fix is to use CachedResourceHandle throughout MemoryCache, which will certainly
keep the resource alive. Also removed earlier fixes.
- css/CSSImageSetValue.cpp: (WebCore::CSSImageSetValue::cachedImageSet):
- css/CSSImageValue.cpp: (WebCore::CSSImageValue::cachedImage):
- css/WebKitCSSShaderValue.cpp: (WebCore::WebKitCSSShaderValue::cachedShader):
- history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow):
- loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
- loader/TextTrackLoader.cpp: (WebCore::TextTrackLoader::load):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestShader):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::requestPreload):
- loader/cache/CachedResourceLoader.h: (CachedResourceLoader):
- loader/cache/MemoryCache.h: (WebCore::MemoryCache::setPruneEnabled):
- loader/cache/CachedResourceHandle.h:
(WebCore::CachedResourceHandle::CachedResourceHandle):
(WebCore::CachedResourceHandle::operator=):
Teach CachedResourceHandle how to make CachedResourceHandle<CachedResource> from
a handle to subclass.
Tools:
Added a test that's very similar to MemoryCachePruneWithinResourceLoadDelegate,
but for disabling the cache instead of triggering a prune.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.html: Added.
- TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm: Added.
(-[MemoryCacheDisableTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
(-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
(-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
(TestWebKitAPI::TEST):
- 7:21 PM Acronyms edited by
- Add link to EWS queue status page (diff)
- 7:08 PM Changeset in webkit [116718] by
-
- 3 edits in trunk/Source/WebCore
Eliminate duplicated code for culled line box in RenderInline
https://bugs.webkit.org/show_bug.cgi?id=85725
This patch extracts the common part of culledInlineBoundingBox() /
culledInlineAbsoluteRects() / culledInlineAbsoluteQuads() to become a
template function generateCulledLineBoxRects(). The template function
accepts a new parameter, GeneratorContext functor, which will be
invoked everytime a new line box rect has been generated. The generated
rect will be in local coordinate. The functor will be responsible for
appropriate transformation, then appending to vector or union with
existing bounding box.
Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-05-10
Reviewed by Eric Seidel.
No new tests. No change in behavior.
- rendering/RenderInline.cpp:
(WebCore):
(WebCore::RenderInline::generateLineBoxRects):
(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
- rendering/RenderInline.h:
(RenderInline):
- 7:06 PM Changeset in webkit [116717] by
-
- 2 edits in trunk/Source/WebCore
Crash in swapInNodePreservingAttributesAndChildren.
https://bugs.webkit.org/show_bug.cgi?id=85197
Reviewed by Ryosuke Niwa.
Keep the children in a ref vector before adding them to newNode.
They can get destroyed due to mutation events.
No new tests because we don't have a reduction.
- editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
- 6:49 PM Changeset in webkit [116716] by
-
- 25 edits in trunk
WebKit2: Add a way to blacklist specific plug-ins/plug-in versions
https://bugs.webkit.org/show_bug.cgi?id=86164
<rdar://problem/9551196>
Reviewed by Sam Weinig.
Source/WebKit2:
- Shared/API/c/WKError.h:
Add kWKErrorCodeInsecurePlugInVersion error code.
- Shared/APIClientTraits.cpp:
Update now that didFailToInitializePlugin is deprecated.
- UIProcess/API/C/WKPage.h:
Deprecate didFailToInitializePlugin and replace it with the more generic pluginDidFail.
Also, deprecate missingPluginButtonClicked and replace it with unavailablePluginButtonClicked.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::shouldBlockPlugin):
Non-Mac version, always return false.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldBlockPlugin):
Call WKShouldBlockPlugin.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::getPluginPath):
Check if the plug-in should be blocked.
- UIProcess/WebContext.messages.in:
GetPluginPath now takes an additional out parameter, a boolean that determines whether the plug-in
should be blocked from loading or not.
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFailToInitializePlugin):
Call m_client.pluginDidFail.
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
Ditto.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Call the loader client.
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Ditto.
- UIProcess/WebPageProxy.messages.in:
Rename MissingPluginButtonClicked to UnavailablePluginButtonClicked and add a new DidBlockInsecurePluginVersion message.
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::unavailablePluginButtonClicked):
Call missingPluginButtonClicked and unavailablePluginButtonClicked.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
Handle RenderEmbeddedObject::InsecurePluginVersion.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
WebPage::createPlugin now takes the plug-in element.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
If the plug-in is blocked, set the appropriate unavailability reason.
- WebProcess/WebProcess.cpp:
(WebKit::canPluginHandleResponse):
Update now that GetPluginPath returns a blocked parameter as well.
Tools:
Update for WK2 API changes.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
- 6:45 PM Changeset in webkit [116715] by
-
- 10 edits in trunk/Source/WebCore
[Refactoring] Move Selection from DOMWindow to TreeScope.
https://bugs.webkit.org/show_bug.cgi?id=82699
Reviewed by Ryosuke Niwa.
Since ShadowRoot will also manage its own version of DOMSelection, we would like to
share the code among Document and DOMSelection. This patch moves DOMSelection from DOMWindow to TreeScope
so that ShadowRoot can also use it.
No new tests, should covered by existing tests.
- dom/Document.cpp:
(WebCore::Document::updateFocusAppearanceTimerFired):
- dom/Document.h:
(Document):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::selection):
- do/mTreeScope.cpp:
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::getSelection):
(WebCore):
- dom/TreeScope.h:
(WebCore):
(TreeScope):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::DOMSelection):
(WebCore::DOMSelection::clearTreeScope):
(WebCore):
- page/DOMSelection.h:
(WebCore):
(WebCore::DOMSelection::create):
(DOMSelection):
(WebCore::DOMSelection::frame):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore::DOMWindow::getSelection):
- page/DOMWindow.h:
(DOMWindow):
- 6:20 PM Changeset in webkit [116714] by
-
- 12 edits in trunk/Source
Unreviewed, rolling out r116594.
http://trac.webkit.org/changeset/116594
https://bugs.webkit.org/show_bug.cgi?id=86013
r116594 might have made some composition tests flaky.
Source/WebCore:
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::addAnimation):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
(WTF):
(WTF::TEST_F):
- 6:08 PM Changeset in webkit [116713] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Fix chromium build break.
- src/LocalizedStrings.cpp:
(WebCore::insecurePluginVersionText):
- 5:42 PM Changeset in webkit [116712] by
-
- 15 edits3 deletes in trunk/Source
Source/WebCore: [chromium] DomStorage events handling needs TLC (2)
https://bugs.webkit.org/show_bug.cgi?id=85221
Alter the StorageArea virtual interface such that the mutators no longer
return old values. This is to allow implementations of the interface to operate
more asynchronously.
Reviewed by Adam Barth.
No new tests. Existing tests cover this.
- storage/StorageArea.h: Alter the interface so the mutators no longer return previous values
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame): removed an unneeded PLATFORM(CHROMIUM) guard
(WebCore::StorageAreaImpl::setItem): no longer return the old value
(WebCore::StorageAreaImpl::removeItem): no longer return the old value
(WebCore::StorageAreaImpl::clear): no longer return whether something was cleared
- storage/StorageAreaImpl.h: match StorageArea's virtual interface
Source/WebKit/chromium: [chromium] DomStorage events handling needs TLC (2)
https://bugs.webkit.org/show_bug.cgi?id=85221
Alter the WebStorageArea virtual interface such that the mutators no longer
return old values. This is to allow implementations of the interface to operate
more asynchronously.
Also clean up from the last patch, remove support for the DEPRECATED event
dispatching API.
Reviewed by Adam Barth.
- WebKit.gyp: delete three files indicated below
- public/WebStorageArea.h:
(WebKit::WebStorageArea::setItem): no longer returns the old value
(WebKit::WebStorageArea::removeItem): no longer returns the old value
(WebKit::WebStorageArea::clear): no longer returns a bool indicated if something was cleared
- public/WebStorageEventDispatcher.h: removed the DEPRECATED instance methods
- public/WebStorageNamespace.h: removed the DEPRECATED close() method
- public/platform/WebKitPlatformSupport.h: removed the DEPRECATED dispatchStorageEvent() method
- src/StorageAreaProxy.cpp: removed the DEPREACTED storageEvent() method
(WebCore::StorageAreaProxy::setItem): no return value
(WebCore::StorageAreaProxy::removeItem): no return value
(WebCore::StorageAreaProxy::clear): no return value
(WebCore::StorageAreaProxy::dispatchLocalStorageEvent): remove an early return thats no longer needed
(WebCore::findPageWithSessionStorageNamespace): switched to passing pageGroup by ptr value instead of by name
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent): remove an early return thats no longer needed
- src/StorageAreaProxy.h:
(WebCore):
(StorageAreaProxy):
- src/StorageEventDispatcherImpl.cpp: Deleted the file.
- src/StorageEventDispatcherImpl.h: Deleted the file.
- src/WebStorageEventDispatcherImpl.cpp: Deleted the DEPRECATED instance methods.
(WebKit::WebStorageEventDispatcher::dispatchLocalStorageEvent): use WebViewImpl::defaultPageGroup
(WebKit::WebStorageEventDispatcher::dispatchSessionStorageEvent): use WebViewImpl::defaultPageGroup
- src/WebStorageEventDispatcherImpl.h: Deleted the file.
- src/WebViewImpl.cpp: added a static method to retrieve a ptr to the default page group,
(WebKit::WebViewImpl::defaultPageGroup):
- src/WebViewImpl.h:
- 5:31 PM Changeset in webkit [116711] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=86158
Overlay scrollbars without layers never paint in overflow regions in
tiled drawing mode
-and corresponding-
<rdar://problem/11289546>
Reviewed by Darin Adler.
RenderLayers paint scrollbars that do not have their own layers by
running a second pass through the layer tree after the layer tree has
painted. This ensures that the scrollbars always paint on top of
content. However, this mechanism was relying on
FrameView::paintContents() as a choke-point for all painting to
trigger the second painting pass. That is not a reasonable choke-point
in tiled drawing, so this patch adds similar code to
RenderLayerBacking.
Only opt into the second painting pass for scrollbars that do not have
their own layers.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintOverflowControls):
A layer that paints into its backing cannot return early here if it
has overlay scrollbars to paint.
(WebCore::RenderLayer::paintLayer):
This replicates code in FrameView::paintContents(). After painting the
owning layer, do a second pass if there are overlay scrollbars to
paint.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
- 5:19 PM Changeset in webkit [116710] by
-
- 2 edits in trunk/Source/WebCore
Well, at least fixing the GTK+ build is something!
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::insecurePluginVersionText):
(WebCore):
- 5:07 PM Changeset in webkit [116709] by
-
- 2 edits in trunk/Source/WebKit/chromium
Add insecurePluginVersionText stub here too.
- src/LocalizedStrings.cpp:
- 5:06 PM Changeset in webkit [116708] by
-
- 4 edits in trunk/Source/WebCore
Add insecurePluginVersionText stubs.
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::insecurePluginVersionText):
(WebCore):
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::insecurePluginVersionText):
(WebCore):
- platform/qt/LocalizedStringsQt.cpp:
(WebCore::insecurePluginVersionText):
(WebCore):
- 5:06 PM Changeset in webkit [116707] by
-
- 2 edits in trunk/Tools
nrwt: [chromium] fix path to asan symbolize script
https://bugs.webkit.org/show_bug.cgi?id=86161
Reviewed by Abhishek Arya.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._get_crash_log):
- 5:03 PM Changeset in webkit [116706] by
-
- 2 edits in branches/chromium/1132/Source
Merge 116333 - IndexedDB: LevelDB coding for bools is broken
https://bugs.webkit.org/show_bug.cgi?id=85810
Reviewed by Tony Chang.
Source/WebCore:
Code was appending to a pre-sized Vector, rather than using an
index setter. This caused uninitialized data to be written out.
Issue was detected on the Chromium side in http://crbug.com/126388
Tests: webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*codeBool'
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeBool):
Source/WebKit/chromium:
Added tests for encodeBool/decodeBool.
- tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):
(IDBLevelDBCoding):
TBR=jsbell@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10377101
- 5:02 PM Changeset in webkit [116705] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r116677.
http://trac.webkit.org/changeset/116677
https://bugs.webkit.org/show_bug.cgi?id=86159
This patch causes linker error to some mac bots (Requested by
jianli_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-10
- WebCore.exp.in:
- dom/ContainerNode.h:
- dom/Node.cpp:
(WebCore::Node::traverseNextNode):
(WebCore::Node::traverseNextSibling):
- dom/Node.h:
(Node):
- 4:53 PM Changeset in webkit [116704] by
-
- 1 copy in tags/Safari-536.11
New Tag.
- 4:48 PM Changeset in webkit [116703] by
-
- 2 edits in trunk/Tools
[chromium] Set Valgrind environment variables for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=86156
Patch by Lei Zhang <thestig@chromium.org> on 2012-05-10
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.setup_environ_for_server):
- 4:38 PM Changeset in webkit [116702] by
-
- 1 copy in branches/chromium/1132/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket
Add new pywebsocket files.
- 4:35 PM Changeset in webkit [116701] by
-
- 4 edits in branches/chromium/1132/Tools
Merge 116668 - don't use autoinstall to import pywebsocket but check it in WebKit directly.
https://bugs.webkit.org/show_bug.cgi?id=86107
Reviewed by Adam Barth.
This change removes pywebsocket from webkitpy's autoinstall list and
imports pywebsocket 0.7.4 directly into webkitpy/thirparty.
- Scripts/webkitpy/layout_tests/servers/websocket_server.py:
(PyWebSocket._prepare_config):
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_irc):
- Scripts/webkitpy/thirdparty/init_unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.init):
(ThirdpartyTest.test_import_hook.MockImportHook._install_eliza):
(ThirdpartyTest):
(ThirdpartyTest.test_import_hook):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Added.
- Scripts/webkitpy/thirdparty/mod_pywebsocket/init.py: Added.
- Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Added.
(ConnectionTerminatedException):
(InvalidFrameException):
(BadOperationException):
(UnsupportedFrameException):
(InvalidUTF8Exception):
(StreamBase):
(StreamBase.init):
(StreamBase._read):
(StreamBase._write):
(StreamBase.receive_bytes):
(StreamBase._read_until):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Added.
(for):
(StreamHixie75):
(StreamHixie75.for):
(StreamHixie75.init):
(StreamHixie75.send_message):
(StreamHixie75._read_payload_length_hixie75):
(StreamHixie75.receive_message):
(StreamHixie75._send_closing_handshake):
(StreamHixie75.close_connection):
(StreamHixie75.send_ping):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Added.
(Frame):
(Frame.init):
(create_length_header):
(create_header):
(_build_frame):
(_filter_and_format_frame_object):
(create_binary_frame):
(create_text_frame):
(FragmentedFrameBuilder):
(FragmentedFrameBuilder.to):
(FragmentedFrameBuilder.init):
(FragmentedFrameBuilder.build):
(_create_control_frame):
(create_ping_frame):
(create_pong_frame):
(create_close_frame):
(StreamOptions):
(StreamOptions.init):
(Stream):
(Stream.for):
(Stream.init):
(Stream._receive_frame):
(Stream._receive_frame_as_frame_object):
(Stream.send_message):
(Stream.receive_message):
(Stream._send_closing_handshake):
(Stream.close_connection):
(Stream.send_ping):
(Stream._send_pong):
(Stream._drain_received_data):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Added.
(is_control_opcode):
(ExtensionParameter):
(ExtensionParameter.init):
(ExtensionParameter.name):
(ExtensionParameter.add_parameter):
(ExtensionParameter.get_parameters):
(ExtensionParameter.get_parameter_names):
(ExtensionParameter.has_parameter):
(ExtensionParameter.get_parameter_value):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Added.
(DispatchException):
(DispatchException.init):
(_default_passive_closing_handshake_handler):
(_normalize_path):
(_create_path_to_resource_converter):
(_create_path_to_resource_converter.converter):
(_enumerate_handler_file_paths):
(_HandlerSuite):
(_HandlerSuite.init):
(_source_handler_file):
(_extract_handler):
(Dispatcher):
(Dispatcher.maintains):
(Dispatcher.init):
(Dispatcher.add_resource_path_alias):
(Dispatcher.source_warnings):
(Dispatcher.do_extra_handshake):
(Dispatcher.transfer_data):
(Dispatcher.passive_closing_handshake):
(Dispatcher.get_handler_suite):
(Dispatcher._source_handler_files_in_dir):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Added.
(ExtensionProcessorInterface):
(ExtensionProcessorInterface.get_extension_response):
(ExtensionProcessorInterface.setup_stream_options):
(DeflateStreamExtensionProcessor):
(DeflateStreamExtensionProcessor.init):
(DeflateStreamExtensionProcessor.get_extension_response):
(DeflateStreamExtensionProcessor.setup_stream_options):
(DeflateFrameExtensionProcessor):
(DeflateFrameExtensionProcessor.init):
(DeflateFrameExtensionProcessor.get_extension_response):
(DeflateFrameExtensionProcessor.setup_stream_options):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.init):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.filter):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.init):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.filter):
(DeflateFrameExtensionProcessor.set_response_window_bits):
(DeflateFrameExtensionProcessor.set_response_no_context_takeover):
(DeflateFrameExtensionProcessor.enable_outgoing_compression):
(DeflateFrameExtensionProcessor.disable_outgoing_compression):
(DeflateFrameExtensionProcessor._outgoing_filter):
(DeflateFrameExtensionProcessor._incoming_filter):
(get_extension_processor):
(get_extension_processor.is):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/init.py: Added.
(try):
(do_handshake):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Added.
(AbortedByUserException):
(HandshakeException):
(HandshakeException.init):
(VersionException):
(VersionException.init):
(get_default_port):
(validate_subprotocol):
(parse_host_header):
(format_header):
(build_location):
(get_mandatory_header):
(validate_mandatory_header):
(check_request_line):
(check_header_lines):
(parse_token_list):
(_parse_extension_param):
(_parse_extension):
(parse_extensions):
(format_extensions):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/draft75.py: Added.
(Handshaker):
(Handshaker.performs):
(Handshaker.init):
(Handshaker.do_handshake):
(Handshaker._set_resource):
(Handshaker._set_origin):
(Handshaker._set_location):
(Handshaker._set_subprotocol):
(Handshaker._set_protocol_version):
(Handshaker._sendall):
(Handshaker._send_handshake):
(Handshaker._check_header_lines):
(Handshaker._check_first_lines):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Added.
(compute_accept):
(Handshaker):
(Handshaker.init):
(Handshaker._validate_connection_header):
(Handshaker.do_handshake):
(Handshaker._get_origin):
(Handshaker._check_version):
(Handshaker._set_protocol):
(Handshaker._parse_extensions):
(Handshaker._validate_key):
(Handshaker._get_key):
(Handshaker._send_handshake):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Added.
(Handshaker):
(Handshaker.init):
(Handshaker.do_handshake):
(Handshaker._set_resource):
(Handshaker._set_subprotocol):
(Handshaker._set_location):
(Handshaker._set_origin):
(Handshaker._set_protocol_version):
(Handshaker._set_challenge_response):
(Handshaker._get_key_value):
(Handshaker._get_challenge):
(Handshaker._send_handshake):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Added.
(ApacheLogHandler):
(ApacheLogHandler.init):
(ApacheLogHandler.emit):
(_configure_logging):
(_parse_option):
(_create_dispatcher):
(headerparserhandler):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Added.
(_is_char):
(_is_ctl):
(ParsingState):
(ParsingState.init):
(peek):
(consume):
(consume_string):
(consume_lws):
(consume_lwses):
(consume_token):
(consume_token_or_quoted_string):
(quote_if_necessary):
(parse_uri):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Added.
(MemorizingFile):
(MemorizingFile.init):
(MemorizingFile.getattribute):
(MemorizingFile.readline):
(MemorizingFile.get_memorized_lines):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Added.
(close_connection):
(send_message):
(receive_message):
(send_ping):
(MessageReceiver):
(MessageReceiver.receives):
(MessageReceiver.provides):
(MessageReceiver.should):
(MessageReceiver.init):
(MessageReceiver.run):
(MessageReceiver.receive):
(MessageReceiver.receive_nowait):
(MessageReceiver.stop):
(MessageSender):
(MessageSender.sends):
(MessageSender.provides):
(MessageSender.should):
(MessageSender.init):
(MessageSender.run):
(MessageSender.send):
(MessageSender.send_nowait):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Added.
(_StandaloneConnection):
(_StandaloneConnection.init):
(_StandaloneConnection.get_local_addr):
(_StandaloneConnection.get_remote_addr):
(_StandaloneConnection.write):
(_StandaloneConnection.read):
(_StandaloneConnection.get_memorized_lines):
(_StandaloneRequest):
(_StandaloneRequest.init):
(_StandaloneRequest.get_uri):
(_StandaloneRequest.get_method):
(_StandaloneRequest.is_https):
(_StandaloneRequest._drain_received_data):
(_StandaloneSSLConnection):
(_StandaloneSSLConnection.for):
(_StandaloneSSLConnection.init):
(_StandaloneSSLConnection.getattribute):
(_StandaloneSSLConnection.setattr):
(_StandaloneSSLConnection.makefile):
(WebSocketServer):
(WebSocketServer.init):
(WebSocketServer._create_sockets):
(WebSocketServer.server_bind):
(WebSocketServer.server_activate):
(WebSocketServer.server_close):
(WebSocketServer.fileno):
(WebSocketServer.handle_error):
(WebSocketServer.get_request):
(WebSocketServer.serve_forever):
(WebSocketServer.shutdown):
(WebSocketRequestHandler):
(WebSocketRequestHandler.setup):
(WebSocketRequestHandler.setup.SocketServer):
(WebSocketRequestHandler.init):
(WebSocketRequestHandler.parse_request):
(WebSocketRequestHandler.log_request):
(WebSocketRequestHandler.log_error):
(WebSocketRequestHandler.is_cgi):
(_configure_logging):
(_alias_handlers):
(_build_option_parser):
(ThreadMonitor):
(ThreadMonitor.init):
(ThreadMonitor.run):
(_parse_args_and_config):
(_main):
(_main.if):
(_main.if.check_script):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Copied from Tools/Scripts/webkitpy/thirdparty/init_unittest.py.
- Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Added.
(get_stack_trace):
(prepend_message_to_exception):
(translate_interp):
(get_script_interp):
(wrap_popen3_for_win):
(wrap_popen3_for_win.wrap_popen3):
(hexify):
(get_class_logger):
(NoopMasker):
(NoopMasker.init):
(NoopMasker.mask):
(RepeatedXorMasker):
(RepeatedXorMasker.init):
(RepeatedXorMasker.mask):
(DeflateRequest):
(DeflateRequest.for):
(DeflateRequest.init):
(DeflateRequest.getattribute):
(DeflateRequest.setattr):
(_Deflater):
(_Deflater.init):
(_Deflater.compress_and_flush):
(_Inflater):
(_Inflater.init):
(_Inflater.decompress):
(_Inflater.append):
(_Inflater.reset):
(_RFC1979Deflater):
(_RFC1979Deflater.that):
(_RFC1979Deflater.init):
(_RFC1979Deflater.filter):
(_RFC1979Inflater):
(_RFC1979Inflater.for):
(_RFC1979Inflater.init):
(_RFC1979Inflater.filter):
(DeflateSocket):
(DeflateSocket.for):
(DeflateSocket.init):
(DeflateSocket.recv):
(DeflateSocket.sendall):
(DeflateSocket.send):
(DeflateConnection):
(DeflateConnection.for):
(DeflateConnection.init):
(DeflateConnection.get_remote_addr):
(DeflateConnection.put_bytes):
(DeflateConnection.read):
(DeflateConnection.write):
(_is_ewouldblock_errno):
(drain_received_data):
- 4:11 PM Changeset in webkit [116700] by
-
- 4 edits in tags/Safari-536.10.3/Source
Versioning.
- 4:10 PM Changeset in webkit [116699] by
-
- 24 edits4 copies in tags/Safari-536.10.3
Merged r116595.
- 4:02 PM Changeset in webkit [116698] by
-
- 3 edits2 adds in trunk
Crash in FontCache::releaseFontData due to infinite float size.
https://bugs.webkit.org/show_bug.cgi?id=86110
Reviewed by Andreas Kling.
Source/WebCore:
New callers always forget to clamp the font size, which overflows
to infinity on multiplication. It is best to clamp it at the end
to avoid getting greater than std::numeric_limits<float>::max().
Test: fast/css/large-font-size-crash.html
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::setComputedSize):
(WebCore::FontDescription::setSpecifiedSize):
LayoutTests:
- fast/css/large-font-size-crash-expected.txt: Added.
- fast/css/large-font-size-crash.html: Added.
- 3:58 PM Changeset in webkit [116697] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=82131
[Mac] REGRESSION (r110480): Text field that specifies background-color
(or is auto-filled) gets un-themed border
-and corresponding-
<rdar://problem/11115221>
Reviewed by Maciej Stachowiak.
This change rolls out r110480 which is what caused styled text fields
to get the un-themed border, and it does a bunch of work to make sure
we get the pretty, new version of the NSTextField art whenever
possible. We do this differently for post-Lion OS's since there is now
a way to opt into it all the time. Lion and SnowLeopard can only use
the new art in HiDPI mode when the background color of the text field
is just white.
RenderThemeMac::textField() takes a boolean paramter used to determine
if the new gradient will be used.
- rendering/RenderThemeMac.h:
(RenderThemeMac):
This is the post-Lion workaround. This code has no effect on Lion and
SnowLeopard. This allows up to opt into a version of [NSTextField drawWithFrame:] that will only draw the frame of the text field; without this, it will draw the frame and the background, which creates a number of problems with styled text fields and text fields in HiDPI. There is a less comprehesive workaround for Lion and SnowLeopard in place in RenderThemeMac::textField().
- rendering/RenderThemeMac.mm:
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
This is the roll-out of r110480.
(WebCore::RenderThemeMac::isControlStyled):
See the comments for a full explanation, but this is mostly code for
Lion and SnowLeopard to determine if we can opt into the new artwork.
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::textField):
- 3:55 PM Changeset in webkit [116696] by
-
- 1 copy in tags/Safari-536.10.3
new Tag.
- 3:45 PM Changeset in webkit [116695] by
-
- 16 edits in trunk
WebKit1: Add a way to blacklist specific plug-ins/plug-in versions
https://bugs.webkit.org/show_bug.cgi?id=86150
<rdar://problem/9551196>
Reviewed by Sam Weinig.
Source/WebCore:
- English.lproj/Localizable.strings:
Update.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin):
It is possible that the client has already set the unavailability reason so don't try to set it twice.
- platform/LocalizedStrings.cpp:
(WebCore::insecurePluginVersionText):
- platform/LocalizedStrings.h:
Add insecure plug-in version text.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::unavailablePluginReplacementText):
- rendering/RenderEmbeddedObject.h:
Add InsecurePluginVersion unavailability reason.
Source/WebKit/mac:
- Misc/WebKitErrors.h:
Add WebKitErrorInsecurePlugInVersion enum.
- Plugins/WebBasePluginPackage.h:
- Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage bundleIdentifier]):
(-[WebBasePluginPackage bundleVersion]):
Add bundleIdentifier and bundleVersion getters.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
Check if the plug-in is blocked. If it is, set the unavailability reason and the error code.
WebKitLibraries:
Add WKShouldBlockPlugin.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 3:11 PM Changeset in webkit [116694] by
-
- 7 edits2 adds in trunk
Make IFRAME_SEAMLESS child documents inherit styles from their parent iframe element
https://bugs.webkit.org/show_bug.cgi?id=85940
Reviewed by Ojan Vafai.
Source/WebCore:
The HTML5 <iframe seamless> spec says:
In a CSS-supporting user agent: the user agent must, for the purpose of CSS property
inheritance only, treat the root element of the active document of the iframe
element's nested browsing context as being a child of the iframe element.
(Thus inherited properties on the root element of the document in the
iframe will inherit the computed values of those properties on the iframe
element instead of taking their initial values.)
Initially I implemented this support to the letter of the spec. However, doing so I learned
that WebKit has a RenderStyle for the Document Node, not just the root element of the document.
In this RenderStyle on the Document, we add a bunch of per-document styles from settings
including designMode.
This change makes StyleResolver::styleForDocument inherit style from the parent iframe's
style, before applying any of these per-document styles. This may or may not be correct
depending on what behavior we want for rtl-ordering, page-zoom, locale, design mode, etc.
For now, we continue to treat the iframe's document as independent in these regards, and
the settings on that document override those inherited from the iframe.
Also, intially when making this work, I added redirects in recalcStyle and scheduleStyleRecalc
from the child document to the parent document in the case of seamless (since the parent
document effectively manages the style resolve and layout of the child in seamless mode).
However, I was not able to find a test which depended on this code change, so in this final patch
I have removed both of these modifications and replaced them with FIXMEs. Based on discussions
with Ojan and James Robinson, I believe both of those changes may eventually be wanted.
This change basically does 3 things:
- Makes StyleResolver::styleForDocument inherit from the parent iframe.
- Makes any recalcStyle calls on the iframe propogate down into the child document (HTMLIFrameElement::didRecalcStyle).
- Makes Document::recalcStyle aware of the fact that the Document's style *can* change
for reasons other than recalcStyle(Force).
I'm open to more testing suggestions, if reviewers have settings on the Document's style
that you want to make sure we inherit from the parent iframe, or don't inherit, etc.
I view this as a complete solution to this aspect of the current <iframe seamless> spec,
but likely not the last code we will write for this aspect of the seamless feature. :)
Tested by fast/frames/seamlesss/seamless-css-cascade.html and seamless-designMode.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- dom/Document.cpp:
(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::recalcStyle):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::HTMLIFrameElement):
(WebCore::HTMLIFrameElement::didRecalcStyle):
(WebCore):
- html/HTMLIFrameElement.h:
(HTMLIFrameElement):
LayoutTests:
This single pass is deceptive. seamless-designMode exists
to make sure that we do not regress application of Document-level
styles in the child document.
- fast/frames/seamless/seamless-css-cascade-expected.txt:
- 3:08 PM Changeset in webkit [116693] by
-
- 3 edits4 adds in trunk
Crash in computedCSSPadding* functions due to RenderImage::imageDimensionsChanged called during attachment
https://bugs.webkit.org/show_bug.cgi?id=85912
Reviewed by Eric Seidel.
Source/WebCore:
Tests: fast/images/link-body-content-imageDimensionChanged-crash.html
fast/images/script-counter-imageDimensionChanged-crash.html
The bug comes from CSS generated images that could end up calling imageDimensionsChanged during attachment. As the
rest of the code (e.g. computedCSSPadding*) would assumes that we are already inserted in the tree, we would crash.
The solution is to bail out in this case as newly inserted RenderObject will trigger layout later on and properly
handle what we would be doing as part of imageDimensionChanged (the only exception being updating our intrinsic
size which should be done as part of imageDimensionsChanged).
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
LayoutTests:
- fast/images/link-body-content-imageDimensionChanged-crash-expected.txt: Added.
- fast/images/link-body-content-imageDimensionChanged-crash.html: Added.
- fast/images/script-counter-imageDimensionChanged-crash-expected.txt: Added.
- fast/images/script-counter-imageDimensionChanged-crash.html: Added.
- 3:00 PM Changeset in webkit [116692] by
-
- 3 edits in trunk/Tools
[webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
https://bugs.webkit.org/show_bug.cgi?id=86145
Reviewed by Dirk Pranke.
The GTK+ and EFL ports use jhbuild to build a few base libraries
which are then used when building the port itself. Programs such
as DRT and ImageDiff are then supposed to be run with the
`run-with-jhbuild' wrapper so that the libraries are properly
found and loaded.
This was already the case for DumpRenderTree (EflPort defines the
'wrapper' option for that), but it was not possible to do the same
with ImageDiff so far.
The code which created the ImageDiff command-line call has been
moved to a separate method, _image_diff_command, which is then
overridden by EflPort to add the jhbuild wrapper.
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.init):
(EflPort._image_diff_command):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort):
(WebKitPort._image_diff_command):
(WebKitPort._start_image_diff_process):
- 2:53 PM Changeset in webkit [116691] by
-
- 2 edits in trunk/Source/WebCore
ASSERT in BidiResolver<Iterator, Run>::commitExplicitEmbedding makes running debug builds annoying
https://bugs.webkit.org/show_bug.cgi?id=86140
Reviewed by Eric Seidel.
The correct fix here is to resolve
https://bugs.webkit.org/show_bug.cgi?id=76574, but in the mean time,
this ASSERT is annoying.
- platform/text/BidiResolver.h:
(WebCore::::commitExplicitEmbedding):
- 2:52 PM Changeset in webkit [116690] by
-
- 11 edits3 adds in trunk/Source
[Chromium] Call addTraceEvent and getTraceCategoryEnabledFlag directly
https://bugs.webkit.org/show_bug.cgi?id=85399
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/EventTracer.cpp: Added.
(WebCore):
(WebCore::EventTracer::getTraceCategoryEnabledFlag):
(WebCore::EventTracer::addTraceEvent):
- platform/EventTracer.h: Added.
(WebCore):
(EventTracer):
- platform/chromium/EventTracerChromium.cpp: Added.
(WebCore):
(WebCore::EventTracer::getTraceCategoryEnabledFlag):
(WebCore::EventTracer::addTraceEvent):
- platform/chromium/PlatformSupport.h:
- platform/chromium/TraceEvent.h:
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 2:44 PM Changeset in webkit [116689] by
-
- 16 edits in trunk/Source
[Chromium] Remove WEBKIT_USING_SKIA ifdefs that are always true
https://bugs.webkit.org/show_bug.cgi?id=86121
Reviewed by Adam Barth.
Chromium always uses Skia now, so this just removes the barriers
around code that was previously #if'd.
Source/Platform:
- chromium/public/WebCanvas.h:
(WebKit):
- chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):
- chromium/public/WebImage.h:
(WebImage):
Source/WebKit/chromium:
- README:
- src/DragClientImpl.cpp:
(WebKit::DragClientImpl::startDrag):
- src/PageOverlay.cpp:
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::clipboardWriteImage):
(WebCore::PlatformSupport::paintScrollbarThumb):
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::paintContents):
- src/WebFontImpl.cpp:
(WebKit::WebFontImpl::drawText):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::printPage):
(WebKit::WebFrameImpl::printPagesWithBoundaries):
- src/WebGraphicsContext3D.cpp:
(WebKit::WebGraphicsContext3D::createGrGLInterface):
- src/WebImageDecoder.cpp:
(WebKit::WebImageDecoder::getFrameAtIndex):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::paint):
(WebKit::WebPluginContainerImpl::printPage):
- src/painting/GraphicsContextBuilder.h:
(WebKit):
- 2:37 PM Changeset in webkit [116688] by
-
- 2 edits in trunk/Source/WebCore
ScrollView::fixedVisibleContentRect should be public
https://bugs.webkit.org/show_bug.cgi?id=86147
Reviewed by Eric Seidel.
Some code in the WebKit layer of OS(ANDROID) uses this function. That
could will be upstreamed in a later patch. For now, this patch just
makes this function public so that we remove the diff to this file.
- platform/ScrollView.h:
(WebCore::ScrollView::fixedVisibleContentRect):
(WebCore::ScrollView::delegatesScrollingDidChange):
- 2:21 PM Changeset in webkit [116687] by
-
- 22 edits in trunk/Source
Rename the missing plug-in indicator to the unavailable plug-in indicator
https://bugs.webkit.org/show_bug.cgi?id=86136
Reviewed by Sam Weinig.
Source/WebCore:
Since the indicator is shown for more than just missing plug-ins, generalize it and use a plug-in unavailability
reason enum to make it easier to extend. Also, pass the unavailability reason to the ChromeClient member functions.
- WebCore.exp.in:
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin):
- page/ChromeClient.h:
(WebCore::ChromeClient::shouldUnavailablePluginMessageBeButton):
(WebCore::ChromeClient::unavailablePluginButtonClicked):
- page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::showsUnavailablePluginIndicator):
(WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsPressed):
(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::paintReplaced):
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
(WebCore::RenderEmbeddedObject::unavailablePluginReplacementText):
(WebCore):
(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
(WebCore::shouldUnavailablePluginMessageBeButton):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
(WebCore::RenderEmbeddedObject::getCursor):
- rendering/RenderEmbeddedObject.h:
(RenderEmbeddedObject):
Source/WebKit/mac:
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView pluginHostDied]):
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
Source/WebKit2:
Update for WebCore changes.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginProcessCrashed):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- 2:14 PM Changeset in webkit [116686] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] WebFrameTest.ChromePageNoJavascript isn't catching regressions
https://bugs.webkit.org/show_bug.cgi?id=86046
Reviewed by Adam Barth.
Test both cases for registerURLSchemeAsNotAllowingJavascriptURLs. Also add
a call to layout() to ensure the javascript result is seen.
- tests/WebFrameTest.cpp:
(WebKit::TEST_F):
(WebKit):
- 2:09 PM Changeset in webkit [116685] by
-
- 8 edits2 adds in trunk
<rdar://problem/10972577> and https://bugs.webkit.org/show_bug.cgi?id=80170
Contents of noscript elements turned into strings in WebArchives
Source/WebCore:
Reviewed by Andy Estes.
There's a much deeper question about how innerHTML of <noscript> is expected to work in
both a scripting and non-scripting environment that we should pursue separately.
But for webarchives, we can solve this by filtering out the <noscript> elements completely
if scripting is enabled.
Test: webarchive/ignore-noscript-if-scripting-enabled.html
- WebCore.exp.in:
Add arguments to createMarkup and MarkupAccumulator methods to pass a Vector of QualifiedNames
that should be filtered from the resulting markup:
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::serializeNodes):
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):
- editing/MarkupAccumulator.h:
- editing/markup.cpp:
(WebCore::createMarkup):
- editing/markup.h:
If scripting is enabled, add the noscriptTag to the tag names to filter:
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
LayoutTests:
Reviewed by Andy Estes.
- webarchive/ignore-noscript-if-scripting-enabled-expected.txt: Added.
- webarchive/ignore-noscript-if-scripting-enabled.html: Added.
- 2:01 PM Changeset in webkit [116684] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Caret node boundary should be adjusted to account for the visible region.
https://bugs.webkit.org/show_bug.cgi?id=86116
Reviewed by Antonio Gomes.
PR 138988.
Update the node bounding box to be clipped and adjusted
for the visible region of the frame.
Reviewed Internally by Gen Mak.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- 1:50 PM Changeset in webkit [116683] by
-
- 4 edits2 adds in trunk
Crash due to floats not removed from first-letter element.
https://bugs.webkit.org/show_bug.cgi?id=86019
Reviewed by Julien Chaffraix.
Source/WebCore:
Move clearing logic of a floating/positioned object from removeChild
to removeChildNode. There are lot of places which use removeChildNode
directly and hence the object is not removed from the floating or
positioned objects list.
Test: fast/block/float/float-not-removed-from-first-letter.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::removeChild):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
LayoutTests:
- fast/block/float/float-not-removed-from-first-letter-expected.txt: Added.
- fast/block/float/float-not-removed-from-first-letter.html: Added.
- 1:43 PM Changeset in webkit [116682] by
-
- 3 edits in trunk/Source/WebCore
Remove empty ElementAttributeData destructor.
<http://webkit.org/b/86126>
Reviewed by Antti Koivisto.
- dom/ElementAttributeData.cpp:
- dom/ElementAttributeData.h:
- 1:24 PM Changeset in webkit [116681] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: heap snapshot comparison view is broken
https://bugs.webkit.org/show_bug.cgi?id=86102
Reviewed by Pavel Feldman.
Pass HeapSnapshotProxy instead of undefined to the profile load callback. Added
compiler annotations to avoid such errors in the future.
- inspector/front-end/HeapSnapshotView.js:
- 1:24 PM Changeset in webkit [116680] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening. Updated failed tests.
- platform/chromium/test_expectations.txt:
- 1:10 PM Changeset in webkit [116679] by
-
- 8 edits in trunk
[GTK] ENABLE_IFRAME_SEAMLESS support
https://bugs.webkit.org/show_bug.cgi?id=85843
Reviewed by Eric Seidel.
.:
Add a configuration option for enabling the iframe seamless
attribute support, enabling it by default.
- configure.ac:
Source/WebCore:
Export the ENABLE_IFRAME_SEAMLESS feature define when the feature is
enabled.
No new tests - all the related tests should now be passing.
- GNUmakefile.am:
Tools:
Add the iframe-seamless option to the options list. This makes it
possible to enable the iframe seamless support through build-webkit
script. Enabled by default for all the ports.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Remove test expectations for the iframe seamless tests. All these
tests should be passing now as the feature is enabled.
- platform/gtk/test_expectations.txt:
- 12:57 PM Changeset in webkit [116678] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Qt gardening.
- platform/qt/Skipped:
Skipped the test as it fails only on Qt (double-checked locally on Mac),
the difference is very small and likely minor.
- 12:52 PM Changeset in webkit [116677] by
-
- 5 edits in trunk/Source/WebCore
Inline Node::traverseNextNode
https://bugs.webkit.org/show_bug.cgi?id=85844
Reviewed by Ryosuke Niwa.
Inline traverseNextNode and traverseNextSibling to reduce entry/exit overhead and allow better code generation
for many hot loops.
In this version only the firstChild()/nextSibling() tests are inlined and the ancestor traversal is not.
Performance bots will tell if this was worthwhile.
- dom/ContainerNode.h:
(WebCore::Node::traverseNextNode):
(WebCore):
(WebCore::Node::traverseNextSibling):
- dom/Node.cpp:
(WebCore::Node::traverseNextAncestorSibling):
- dom/Node.h:
(Node):
- 12:50 PM BuildingGtk edited by
- (diff)
- 12:28 PM Changeset in webkit [116676] by
-
- 3 edits in trunk/Tools
[EFL][webkitpy] Do not redefine check_build() in EflPort.
https://bugs.webkit.org/show_bug.cgi?id=86124
Reviewed by Dirk Pranke.
Remove an old FIXME and do not redefine check_build in EflPort;
once build-dumprendertree recognizes --efl, we can use the
check_build implementation in WebKitPort.
- Scripts/build-dumprendertree:
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.check_build):
- 12:17 PM Changeset in webkit [116675] by
-
- 2 edits in trunk/Source/WebCore
MediaStream API: Fix MediaHints parsing
https://bugs.webkit.org/show_bug.cgi?id=86098
Reviewed by Adam Barth.
Not currently testable. Working on a series of patches that will fix that.
- Modules/mediastream/PeerConnection00.cpp:
(WebCore::PeerConnection00::createMediaHints):
- 12:11 PM Changeset in webkit [116674] by
-
- 4 edits in trunk
[chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=86087
Reviewed by Adam Barth.
Source/WebCore:
Not easy to test but I have added code that excercises this to WebUserMediaClientMock (in DumpRenderTree).
- platform/chromium/support/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::setExtraData):
Tools:
- DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(MockExtraData):
(WebKit):
(WebKit::WebUserMediaClientMock::requestUserMedia):
- 12:01 PM Changeset in webkit [116673] by
-
- 12 edits in trunk/Source/JavaScriptCore
Remove op_get_callee
Rubber stamped by Geoff Garen.
This is now redundant.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC):
- jit/JITOpcodes32_64.cpp:
(JSC):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 11:47 AM Changeset in webkit [116672] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: search title is shown beside the search field (not under) in the vertical mode.
https://bugs.webkit.org/show_bug.cgi?id=86120
Reviewed by Yury Semikhatsky.
This change makes search title render as placeholder at all times.
It also adjusts the size of the search field when navigation arrows appear.
- inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._createSearchNavigationButton):
- inspector/front-end/inspector.css:
(#toolbar-search-item):
(.with-navigation-buttons #search):
(.toolbar-search-navigation-label):
(.with-navigation-buttons .toolbar-search-navigation-label):
- inspector/front-end/inspector.html:
- 11:42 AM Changeset in webkit [116671] by
-
- 10 edits2 adds in trunk
[chromium] Trigger context menu for long press gesture
https://bugs.webkit.org/show_bug.cgi?id=85919
Patch by Varun Jain <varunjain@google.com> on 2012-05-10
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/touch/gesture/context-menu-on-long-press.html
- page/EventHandler.cpp:
(WebCore):
(WebCore::EventHandler::sendContextMenuEventForGesture):
- page/EventHandler.h:
(EventHandler):
Source/WebKit/chromium:
- src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::handleInputEvent):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
Tools:
- DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::gestureLongPress):
(EventSender::gestureEvent):
- DumpRenderTree/chromium/EventSender.h:
(EventSender):
LayoutTests:
- fast/events/touch/gesture/context-menu-on-long-press.html: Added.
- platform/chromium/fast/events/touch/gesture/context-menu-on-long-press-expected.txt: Added.
- 11:40 AM Changeset in webkit [116670] by
-
- 21 edits in trunk/Source/JavaScriptCore
Cache inheritorID on JSFunction
https://bugs.webkit.org/show_bug.cgi?id=85853
Reviewed by Geoff Garen & Filip Pizlo.
An object's prototype is indicated via its structure. To create an otherwise
empty object with object A as its prototype, we require a structure with its
prototype set to point to A. We wish to use this same structure for all empty
objects created with a prototype of A, so we presently store this structure as
a property of A, known as the inheritorID.
When a function F is invoked as a constructor, where F has a property 'prototype'
set to point to A, in order to create the 'this' value for the constructor to
use the following steps are taken:
- the 'prototype' proptery of F is read, via a regular Get access.
- the inheritorID internal property of the prototype is read.
- a new, empty object is constructed with its structure set to point to inheritorID.
There are two drawbacks to the current approach:
- it requires that every object has an inheritorID field.
- it requires a Get access on every constructor call to access the 'prototype' property.
Instead, switch to caching a copy of the inheritorID on the function. Constructor
calls now only need read the internal property from the callee, saving a Get.
This also means that JSObject::m_inheritorID is no longer commonly read, and in a
future patch we can move to storing this in a more memory efficient fashion.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateJSFunction):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::cacheInheritorID):
(JSC):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):
- runtime/JSFunction.h:
(JSC::JSFunction::cachedInheritorID):
(JSFunction):
(JSC::JSFunction::offsetOfCachedInheritorID):
- 11:39 AM Changeset in webkit [116669] by
-
- 3 edits2 adds in trunk
Crash in ApplyStyleCommand::joinChildTextNodes.
https://bugs.webkit.org/show_bug.cgi?id=85939
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: editing/style/apply-style-join-child-text-nodes-crash.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): add conditions
to bail out if our start and end position nodes are removed due to
mutation events in joinChildTextNodes.
(WebCore::ApplyStyleCommand::applyInlineStyle): this executes after
applyRelativeFontStyleChange in ApplyStyleCommand::doApply. So, need
to bail out if our start and end position nodes are removed due to
mutation events.
(WebCore::ApplyStyleCommand::joinChildTextNodes): hold all the children
in a ref vector to prevent them from getting destroyed due to mutation events.
LayoutTests:
- editing/style/apply-style-join-child-text-nodes-crash-expected.txt: Added.
- editing/style/apply-style-join-child-text-nodes-crash.html: Added.
- 11:38 AM Changeset in webkit [116668] by
-
- 4 edits1 copy21 adds in trunk/Tools
don't use autoinstall to import pywebsocket but check it in WebKit directly.
https://bugs.webkit.org/show_bug.cgi?id=86107
Reviewed by Adam Barth.
This change removes pywebsocket from webkitpy's autoinstall list and
imports pywebsocket 0.7.4 directly into webkitpy/thirparty.
- Scripts/webkitpy/layout_tests/servers/websocket_server.py:
(PyWebSocket._prepare_config):
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_irc):
- Scripts/webkitpy/thirdparty/init_unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.init):
(ThirdpartyTest.test_import_hook.MockImportHook._install_eliza):
(ThirdpartyTest):
(ThirdpartyTest.test_import_hook):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Added.
- Scripts/webkitpy/thirdparty/mod_pywebsocket/init.py: Added.
- Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Added.
(ConnectionTerminatedException):
(InvalidFrameException):
(BadOperationException):
(UnsupportedFrameException):
(InvalidUTF8Exception):
(StreamBase):
(StreamBase.init):
(StreamBase._read):
(StreamBase._write):
(StreamBase.receive_bytes):
(StreamBase._read_until):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Added.
(for):
(StreamHixie75):
(StreamHixie75.for):
(StreamHixie75.init):
(StreamHixie75.send_message):
(StreamHixie75._read_payload_length_hixie75):
(StreamHixie75.receive_message):
(StreamHixie75._send_closing_handshake):
(StreamHixie75.close_connection):
(StreamHixie75.send_ping):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Added.
(Frame):
(Frame.init):
(create_length_header):
(create_header):
(_build_frame):
(_filter_and_format_frame_object):
(create_binary_frame):
(create_text_frame):
(FragmentedFrameBuilder):
(FragmentedFrameBuilder.to):
(FragmentedFrameBuilder.init):
(FragmentedFrameBuilder.build):
(_create_control_frame):
(create_ping_frame):
(create_pong_frame):
(create_close_frame):
(StreamOptions):
(StreamOptions.init):
(Stream):
(Stream.for):
(Stream.init):
(Stream._receive_frame):
(Stream._receive_frame_as_frame_object):
(Stream.send_message):
(Stream.receive_message):
(Stream._send_closing_handshake):
(Stream.close_connection):
(Stream.send_ping):
(Stream._send_pong):
(Stream._drain_received_data):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Added.
(is_control_opcode):
(ExtensionParameter):
(ExtensionParameter.init):
(ExtensionParameter.name):
(ExtensionParameter.add_parameter):
(ExtensionParameter.get_parameters):
(ExtensionParameter.get_parameter_names):
(ExtensionParameter.has_parameter):
(ExtensionParameter.get_parameter_value):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Added.
(DispatchException):
(DispatchException.init):
(_default_passive_closing_handshake_handler):
(_normalize_path):
(_create_path_to_resource_converter):
(_create_path_to_resource_converter.converter):
(_enumerate_handler_file_paths):
(_HandlerSuite):
(_HandlerSuite.init):
(_source_handler_file):
(_extract_handler):
(Dispatcher):
(Dispatcher.maintains):
(Dispatcher.init):
(Dispatcher.add_resource_path_alias):
(Dispatcher.source_warnings):
(Dispatcher.do_extra_handshake):
(Dispatcher.transfer_data):
(Dispatcher.passive_closing_handshake):
(Dispatcher.get_handler_suite):
(Dispatcher._source_handler_files_in_dir):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Added.
(ExtensionProcessorInterface):
(ExtensionProcessorInterface.get_extension_response):
(ExtensionProcessorInterface.setup_stream_options):
(DeflateStreamExtensionProcessor):
(DeflateStreamExtensionProcessor.init):
(DeflateStreamExtensionProcessor.get_extension_response):
(DeflateStreamExtensionProcessor.setup_stream_options):
(DeflateFrameExtensionProcessor):
(DeflateFrameExtensionProcessor.init):
(DeflateFrameExtensionProcessor.get_extension_response):
(DeflateFrameExtensionProcessor.setup_stream_options):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.init):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.filter):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.init):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.filter):
(DeflateFrameExtensionProcessor.set_response_window_bits):
(DeflateFrameExtensionProcessor.set_response_no_context_takeover):
(DeflateFrameExtensionProcessor.enable_outgoing_compression):
(DeflateFrameExtensionProcessor.disable_outgoing_compression):
(DeflateFrameExtensionProcessor._outgoing_filter):
(DeflateFrameExtensionProcessor._incoming_filter):
(get_extension_processor):
(get_extension_processor.is):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/init.py: Added.
(try):
(do_handshake):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Added.
(AbortedByUserException):
(HandshakeException):
(HandshakeException.init):
(VersionException):
(VersionException.init):
(get_default_port):
(validate_subprotocol):
(parse_host_header):
(format_header):
(build_location):
(get_mandatory_header):
(validate_mandatory_header):
(check_request_line):
(check_header_lines):
(parse_token_list):
(_parse_extension_param):
(_parse_extension):
(parse_extensions):
(format_extensions):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/draft75.py: Added.
(Handshaker):
(Handshaker.performs):
(Handshaker.init):
(Handshaker.do_handshake):
(Handshaker._set_resource):
(Handshaker._set_origin):
(Handshaker._set_location):
(Handshaker._set_subprotocol):
(Handshaker._set_protocol_version):
(Handshaker._sendall):
(Handshaker._send_handshake):
(Handshaker._check_header_lines):
(Handshaker._check_first_lines):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Added.
(compute_accept):
(Handshaker):
(Handshaker.init):
(Handshaker._validate_connection_header):
(Handshaker.do_handshake):
(Handshaker._get_origin):
(Handshaker._check_version):
(Handshaker._set_protocol):
(Handshaker._parse_extensions):
(Handshaker._validate_key):
(Handshaker._get_key):
(Handshaker._send_handshake):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Added.
(Handshaker):
(Handshaker.init):
(Handshaker.do_handshake):
(Handshaker._set_resource):
(Handshaker._set_subprotocol):
(Handshaker._set_location):
(Handshaker._set_origin):
(Handshaker._set_protocol_version):
(Handshaker._set_challenge_response):
(Handshaker._get_key_value):
(Handshaker._get_challenge):
(Handshaker._send_handshake):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Added.
(ApacheLogHandler):
(ApacheLogHandler.init):
(ApacheLogHandler.emit):
(_configure_logging):
(_parse_option):
(_create_dispatcher):
(headerparserhandler):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Added.
(_is_char):
(_is_ctl):
(ParsingState):
(ParsingState.init):
(peek):
(consume):
(consume_string):
(consume_lws):
(consume_lwses):
(consume_token):
(consume_token_or_quoted_string):
(quote_if_necessary):
(parse_uri):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Added.
(MemorizingFile):
(MemorizingFile.init):
(MemorizingFile.getattribute):
(MemorizingFile.readline):
(MemorizingFile.get_memorized_lines):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Added.
(close_connection):
(send_message):
(receive_message):
(send_ping):
(MessageReceiver):
(MessageReceiver.receives):
(MessageReceiver.provides):
(MessageReceiver.should):
(MessageReceiver.init):
(MessageReceiver.run):
(MessageReceiver.receive):
(MessageReceiver.receive_nowait):
(MessageReceiver.stop):
(MessageSender):
(MessageSender.sends):
(MessageSender.provides):
(MessageSender.should):
(MessageSender.init):
(MessageSender.run):
(MessageSender.send):
(MessageSender.send_nowait):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Added.
(_StandaloneConnection):
(_StandaloneConnection.init):
(_StandaloneConnection.get_local_addr):
(_StandaloneConnection.get_remote_addr):
(_StandaloneConnection.write):
(_StandaloneConnection.read):
(_StandaloneConnection.get_memorized_lines):
(_StandaloneRequest):
(_StandaloneRequest.init):
(_StandaloneRequest.get_uri):
(_StandaloneRequest.get_method):
(_StandaloneRequest.is_https):
(_StandaloneRequest._drain_received_data):
(_StandaloneSSLConnection):
(_StandaloneSSLConnection.for):
(_StandaloneSSLConnection.init):
(_StandaloneSSLConnection.getattribute):
(_StandaloneSSLConnection.setattr):
(_StandaloneSSLConnection.makefile):
(WebSocketServer):
(WebSocketServer.init):
(WebSocketServer._create_sockets):
(WebSocketServer.server_bind):
(WebSocketServer.server_activate):
(WebSocketServer.server_close):
(WebSocketServer.fileno):
(WebSocketServer.handle_error):
(WebSocketServer.get_request):
(WebSocketServer.serve_forever):
(WebSocketServer.shutdown):
(WebSocketRequestHandler):
(WebSocketRequestHandler.setup):
(WebSocketRequestHandler.setup.SocketServer):
(WebSocketRequestHandler.init):
(WebSocketRequestHandler.parse_request):
(WebSocketRequestHandler.log_request):
(WebSocketRequestHandler.log_error):
(WebSocketRequestHandler.is_cgi):
(_configure_logging):
(_alias_handlers):
(_build_option_parser):
(ThreadMonitor):
(ThreadMonitor.init):
(ThreadMonitor.run):
(_parse_args_and_config):
(_main):
(_main.if):
(_main.if.check_script):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Copied from Tools/Scripts/webkitpy/thirdparty/init_unittest.py.
- Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Added.
(get_stack_trace):
(prepend_message_to_exception):
(translate_interp):
(get_script_interp):
(wrap_popen3_for_win):
(wrap_popen3_for_win.wrap_popen3):
(hexify):
(get_class_logger):
(NoopMasker):
(NoopMasker.init):
(NoopMasker.mask):
(RepeatedXorMasker):
(RepeatedXorMasker.init):
(RepeatedXorMasker.mask):
(DeflateRequest):
(DeflateRequest.for):
(DeflateRequest.init):
(DeflateRequest.getattribute):
(DeflateRequest.setattr):
(_Deflater):
(_Deflater.init):
(_Deflater.compress_and_flush):
(_Inflater):
(_Inflater.init):
(_Inflater.decompress):
(_Inflater.append):
(_Inflater.reset):
(_RFC1979Deflater):
(_RFC1979Deflater.that):
(_RFC1979Deflater.init):
(_RFC1979Deflater.filter):
(_RFC1979Inflater):
(_RFC1979Inflater.for):
(_RFC1979Inflater.init):
(_RFC1979Inflater.filter):
(DeflateSocket):
(DeflateSocket.for):
(DeflateSocket.init):
(DeflateSocket.recv):
(DeflateSocket.sendall):
(DeflateSocket.send):
(DeflateConnection):
(DeflateConnection.for):
(DeflateConnection.init):
(DeflateConnection.get_remote_addr):
(DeflateConnection.put_bytes):
(DeflateConnection.read):
(DeflateConnection.write):
(_is_ewouldblock_errno):
(drain_received_data):
- 11:34 AM Changeset in webkit [116667] by
-
- 2 edits in branches/chromium/1132/Source/WebCore
Merge 116316 - [chromium] setContentsMemoryAllocationLimitBytes needs to setNeedsCommit.
https://bugs.webkit.org/show_bug.cgi?id=85801
Patch by Michal Mocny <mmocny@google.com> on 2012-05-07
Reviewed by Adrienne Walker.
CCLayerTreeHost::setContentsMemoryAllocationLimitBytes needs to call setNeedsCommit after adjusting memory
limits, so that we push a new frame. In particular, when returning from non visibile state, we adjust
memory allocation from 0 to non 0, and we need to push a non blank frame.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::setContentsMemoryAllocationLimitBytes):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10332095
- 11:25 AM Changeset in webkit [116666] by
-
- 11 edits in trunk/Source
[Chromium] Remove dead code behind unused WEBKIT_USING_CG
https://bugs.webkit.org/show_bug.cgi?id=86018
Reviewed by Adam Barth.
We never use CoreGraphics as the backend for GraphicsContext in
Chromium, so this is all dead code.
Source/Platform:
- chromium/public/WebCanvas.h:
(WebKit):
- chromium/public/WebImage.h:
(WebImage):
Source/WebKit/chromium:
- README:
- src/PageOverlay.cpp:
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::paintContents):
- src/WebFontImpl.cpp:
(WebKit::WebFontImpl::drawText):
- src/WebImageDecoder.cpp:
(WebKit::WebImageDecoder::getFrameAtIndex):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::paint):
(WebKit::WebPluginContainerImpl::printPage):
- src/painting/GraphicsContextBuilder.h:
(WebKit):
- 11:23 AM Changeset in webkit [116665] by
-
- 1 edit2 moves in trunk/LayoutTests
Unreviewed. Correct spelling in test name.
- editing/inserting/insert-paragraph-separator-crash-expected.txt: Renamed from LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt.
- editing/inserting/insert-paragraph-separator-crash.html: Renamed from LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html.
- 11:22 AM Changeset in webkit [116664] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rebaselined run-bindings-tests results.
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::wrapSlow):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::wrap):
- 11:15 AM Changeset in webkit [116663] by
-
- 5 edits1 add1 delete in trunk/LayoutTests
Test from bug 34875 does not work on chromium/mac
https://bugs.webkit.org/show_bug.cgi?id=85913
Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-10
Reviewed by Julien Chaffraix.
- fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html: Added.
- fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt: Removed.
- fast/block/positioning/offsetLeft-offsetTop-multicolumn.html:
Turned the test back into a ref-test as keeping the test cross-platform and
dumpAsText is proving cumbersome. Apart from that, it also make the test work
cross-browser.
- platform/chromium/test_expectations.txt:
- platform/mac/Skipped:
- platform/qt-mac/Skipped:
Re-enabled the test.
- 11:15 AM Changeset in webkit [116662] by
-
- 2 edits in trunk/Tools
[EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
https://bugs.webkit.org/show_bug.cgi?id=86117
Reviewed by Adam Barth.
Simplify the code used to wrap driver calls with jhbuild: we can
just define the 'wrapper' option instead of having to create a
Driver class just for that.
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.init):
(EflPort._port_flag_for_scripts):
- 11:09 AM Changeset in webkit [116661] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening away IETC crash for now
https://bugs.webkit.org/show_bug.cgi?id=86115
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-10
- platform/efl/test_expectations.txt:
- 11:05 AM Changeset in webkit [116660] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening. Marked tests as failure.
- platform/chromium/test_expectations.txt:
- 10:32 AM Changeset in webkit [116659] by
-
- 5 edits in trunk/Source/JavaScriptCore
Enh: Hash Const JSString in Backing Stores to Save Memory
https://bugs.webkit.org/show_bug.cgi?id=86024
Reviewed by Filip Pizlo.
During garbage collection, each marking thread keeps a HashMap of
strings. While visiting via MarkStack::copyAndAppend(), we check to
see if the string we are visiting is already in the HashMap. If not
we add it. If so, we change the reference to the current string we're
visiting to the prior string.
To somewhat reduce the performance impact of this change, if a string
is unique at the end of a marking it will not be checked during further
GC phases. In some cases this won't catch all duplicates, but we are
trying to catch the growth of duplicate strings.
- heap/Heap.cpp:
(JSC::Heap::markRoots):
- heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::resetChildren): New method called by the
main thread to reset the slave threads. This is primarily done to
clear the m_uniqueStrings HashMap.
(JSC):
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::reset): Added call to clear m_uniqueStrings.
(JSC::MarkStack::internalAppend): New method that performs the hash consting.
(JSC::SlotVisitor::copyAndAppend): Changed to call the new hash consting
internalAppend()
- heap/MarkStack.h:
(MarkStackThreadSharedData):
(MarkStack):
(JSC::MarkStack::sharedData):
- runtime/JSString.h:
(JSString): Added m_isHashConstSingleton flag, accessors for the flag and
code to initialize the flag.
(JSC::JSString::finishCreation):
(JSC::JSString::isHashConstSingleton):
(JSC::JSString::clearHashConstSingleton):
(JSC::JSString::setHashConstSingleton):
(JSC::JSRopeString::finishCreation):
- 10:26 AM Changeset in webkit [116658] by
-
- 6 edits7 adds in trunk/LayoutTests
Integrate IETC CSS : values and units tests
https://bugs.webkit.org/show_bug.cgi?id=85307
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-05-10
Reviewed by Adam Barth.
Added the IETC values and unit tests and associated reference tests.
Also removed two "file not found" test entries in the mac test_expectations.txt
file that were causing a style check failure.
- ietestcenter/css3/valuesandunits/units-000-expected.htm: Added.
- ietestcenter/css3/valuesandunits/units-000.htm: Added.
- ietestcenter/css3/valuesandunits/units-010-expected.htm: Added.
- ietestcenter/css3/valuesandunits/units-010.htm: Added.
- ietestcenter/css3/valuesandunits/units-020-expected.htm: Added.
- ietestcenter/css3/valuesandunits/units-020.htm: Added.
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- 10:15 AM Changeset in webkit [116657] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Assertions and assumptions in BackingStoreClient around m_frame and m_frame->view() are invalid
https://bugs.webkit.org/show_bug.cgi?id=86096
Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
A Frame's FrameView has always to be checked since it is
a volatile object, and gets created and destroyed all the time.
We have been facing a particular issue, where during our automated
interaction tests, the main frame object was being pinch zoomed in
the middle of it creation, and WebKit thread was blocked by a mutex.
In practice, it is a case that would not be possible in a real
world scenario, but shows that the ASSERTs are bogus regardless.
- WebKitSupport/BackingStoreClient.cpp:
(BlackBerry::WebKit::BackingStoreClient::scrollPosition):
(BlackBerry::WebKit::BackingStoreClient::setScrollPosition):
(BlackBerry::WebKit::BackingStoreClient::maximumScrollPosition):
(BlackBerry::WebKit::BackingStoreClient::viewportSize):
(BlackBerry::WebKit::BackingStoreClient::transformedViewportSize):
(BlackBerry::WebKit::BackingStoreClient::visibleContentsRect):
(BlackBerry::WebKit::BackingStoreClient::contentsSize):
- 9:54 AM Changeset in webkit [116656] by
-
- 4 edits in trunk
[EFL][DRT] ewk_view_paint_contents may trigger assertion failure
https://bugs.webkit.org/show_bug.cgi?id=85058
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.
Source/WebKit/efl:
Fixing assertion failure triggered in media/media-fragment cases.
The assertion is hit because of a race between scheduleRelayout() and
the EWK's idle tiling painting. This is exposed by test cases
that rapidly insert child nodes to the document which lead to
scheduleRelayout() calls. Using the general purpose defensive
layout function, not causing any extra relayout work if there's
nothing to be done, but still avoiding the assertion failure if
layout is needed.
- ewk/ewk_view.cpp:
(ewk_view_paint):
(ewk_view_paint_contents):
LayoutTests:
Unskipping media-fragments that pass after the assertion failure was fixed.
- platform/efl/Skipped:
- 9:47 AM Changeset in webkit [116655] by
-
- 2 edits2 adds in trunk/LayoutTests
Add test that makes sure wrappers are setup using the correct window scope
https://bugs.webkit.org/show_bug.cgi?id=85526
Reviewed by Ojan Vafai.
This tests the same thing as the recently removed fast/dom/prototype-inheritance.html test.
- fast/dom/wrapper-scope-expected.txt: Added.
- fast/dom/wrapper-scope.html: Added.
- platform/chromium/test_expectations.txt:
- 9:45 AM Changeset in webkit [116654] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Test /webkit2/WebKitWebView/resources times out
https://bugs.webkit.org/show_bug.cgi?id=86088
Reviewed by Martin Robinson.
- UIProcess/API/gtk/tests/TestResources.cpp:
(testWebViewResources): Use webkit_web_view_reload_bypass_cache()
instead of webkit_web_view_reload() to make sure resources are not
read from the cache.
- 9:44 AM Changeset in webkit [116653] by
-
- 7 edits2 adds in trunk
Crash in InsertParagraphSeparatorCommand::doApply.
https://bugs.webkit.org/show_bug.cgi?id=84995
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: editing/inserting/insert-paragraph-seperator-crash.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs): no need of static cast, since
type of enclosingBlock returned is already Element*.
- editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::tryIndentingAsListItem): no need of static cast, since
type of enclosingBlock returned is already Element*.
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): RefPtr startBlock to guard against
mutation events.
- editing/htmlediting.cpp:
(WebCore::enclosingBlock): make sure type of enclosingNode is an element before doing
the static cast. This was already failing in a couple of layout tests. Also, isBlock
check already exists in the function call to enclosingNodeOfType, so don't need it
again on enclosingNode's renderer.
- editing/htmlediting.h:
(WebCore):
LayoutTests:
- editing/inserting/insert-paragraph-seperator-crash-expected.txt: Added.
- editing/inserting/insert-paragraph-seperator-crash.html: Added.
- 9:38 AM Changeset in webkit [116652] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] WK2 misses WebKitSettings for media playback requiring user gestures and inline playback
https://bugs.webkit.org/show_bug.cgi?id=85999
Patch by Simon Pena <Simon Pena> on 2012-05-10
Reviewed by Martin Robinson.
Expose WebKitSettings for media playback requiring user gesture and
media playback allows inline to GTK side.
This adds two properties (mediaPlaybackRequiresUserGesture and
mediaPlaybackAllowsInline), with their setters and getters, to
WebKitSettings. It also updates the WebKitSettings tests so these
two properties are checked, and includes the new methods in the
documentation.
- UIProcess/API/gtk/WebKitSettings.cpp: added the new properties and
their accessors
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_media_playback_requires_user_gesture):
(webkit_settings_get_media_playback_requires_user_gesture):
(webkit_settings_set_media_playback_allows_inline):
(webkit_settings_get_media_playback_allows_inline):
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: included the new
methods in the documentation
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp: tested the newly
added methods
(testWebKitSettings):
- 9:33 AM Changeset in webkit [116651] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Missing field initializers for WKPageLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=86005
Patch by Simon Pena <Simon Pena> on 2012-05-10
Reviewed by Martin Robinson.
Initialize willGoToBackForwardListItem and
interactionOccurredWhileProcessUnresponsive fields of
WKPageLoaderClient.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(attachLoaderClientToView):
- 9:17 AM Changeset in webkit [116650] by
-
- 4 edits in trunk/Source/WebCore
TouchAdjustment doesn't correct for scroll-offsets.
https://bugs.webkit.org/show_bug.cgi?id=86083
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-10
Reviewed by Kenneth Rohde Christiansen.
Already tested by: touchadjustment/scroll-delegation
- page/EventHandler.cpp:
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):
- testing/Internals.cpp:
(WebCore::Internals::bestZoomableAreaForTouchPoint):
- 8:59 AM Changeset in webkit [116649] by
-
- 2 edits in trunk/Source/WebCore
Fix typo in filename
https://bugs.webkit.org/show_bug.cgi?id=86095
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-05-10
Reviewed by Andreas Kling.
- UseJSC.cmake:
- 8:35 AM Changeset in webkit [116648] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Double tap to zoom is considered a user interaction
https://bugs.webkit.org/show_bug.cgi?id=86094
Reviewed by Simon Hausmann.
This makes it so that the content size change doesn't change scale
after a double tap to zoom.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
- 8:22 AM Changeset in webkit [116647] by
-
- 5 edits1 add in trunk
SVG Filters allow invalid elements as children
https://bugs.webkit.org/show_bug.cgi?id=83979
Reviewed by Nikolas Zimmermann.
.:
This test will crash upon load in Chromium, unless the associated fix is in.
- ManualTests/bugzilla-83979.svg: Added.
Source/WebCore:
According to the SVG spec, there are numerous restrictions on the
content of nodes (that is, their children). Specific to this problem,
SVGFilter elements may only contain SVGFilterPrimitive elements, and
those may only contain animation related elements. This patch enforces
the restriction on filters in the render tree, thus preventing us from
having (for instance) content that is inside a filter yet filtered by
the filter.
Manual test: ManualTests/bugzilla-83979.svg
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::childShouldCreateRenderer): Added to only allow renderers for fe* children
(WebCore):
- svg/SVGFilterElement.h:
(SVGFilterElement):
- svg/SVGFilterPrimitiveStandardAttributes.h: Do not allow any children at all for fe* elements.
(SVGFilterPrimitiveStandardAttributes):
- 8:12 AM Changeset in webkit [116646] by
-
- 11 edits in trunk/Source/WebKit2
[Qt] Rename QDeclarative* to QQml*
https://bugs.webkit.org/show_bug.cgi?id=86089
Reviewed by Simon Hausmann.
The QtDeclarative module was deprecated in favor of QtQml.
- Target.pri:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::_q_onReceivedResponseFromDownload):
(QQuickWebViewExperimental::alertDialog):
(QQuickWebViewExperimental::setAlertDialog):
(QQuickWebViewExperimental::confirmDialog):
(QQuickWebViewExperimental::setConfirmDialog):
(QQuickWebViewExperimental::promptDialog):
(QQuickWebViewExperimental::setPromptDialog):
(QQuickWebViewExperimental::authenticationDialog):
(QQuickWebViewExperimental::setAuthenticationDialog):
(QQuickWebViewExperimental::proxyAuthenticationDialog):
(QQuickWebViewExperimental::setProxyAuthenticationDialog):
(QQuickWebViewExperimental::certificateVerificationDialog):
(QQuickWebViewExperimental::setCertificateVerificationDialog):
(QQuickWebViewExperimental::itemSelector):
(QQuickWebViewExperimental::setItemSelector):
(QQuickWebViewExperimental::filePicker):
(QQuickWebViewExperimental::setFilePicker):
(QQuickWebViewExperimental::databaseQuotaDialog):
(QQuickWebViewExperimental::setDatabaseQuotaDialog):
(QQuickWebViewExperimental::schemeDelegates_At):
(QQuickWebViewExperimental::schemeDelegates_Append):
(QQuickWebViewExperimental::schemeDelegates_Count):
(QQuickWebViewExperimental::schemeDelegates_Clear):
(QQuickWebViewExperimental::schemeDelegates):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- UIProcess/API/qt/qwebiconimageprovider.cpp:
(QWebIconImageProvider::QWebIconImageProvider):
- UIProcess/API/qt/qwebiconimageprovider_p.h:
- UIProcess/API/qt/qwebviewportinfo_p.h:
- UIProcess/API/qt/tests/tests.pri:
- UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner):
- UIProcess/qt/WebPopupMenuProxyQt.h:
(WebPopupMenuProxyQt):
- 8:10 AM Changeset in webkit [116645] by
-
- 13 edits4 adds in trunk
[CSS3 Backgrounds and Borders] Add background-size to the background shorthand
https://bugs.webkit.org/show_bug.cgi?id=27577
Patch by Joe Thomas <joethomas@motorola.com> on 2012-05-10
Reviewed by Alexis Menard.
Added CSSPropertyBackgroundSize to the background shorthand propery. Added the logic for parsing background-size.
bakground-size appears after background-position followed by a '/'.
The specification related to this change is http://www.w3.org/TR/css3-background/#the-background
Source/WebCore:
Tests: fast/backgrounds/background-shorthand-with-backgroundSize-style.html
fast/backgrounds/size/backgroundSize-in-background-shorthand.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getBackgroundShorthandValue):
(WebCore):
- css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StylePropertyShorthand.cpp:
(WebCore):
(WebCore::backgroundShorthand):
LayoutTests:
- fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt: Added.
- fast/backgrounds/background-shorthand-with-backgroundSize-style.html: Added.
- fast/backgrounds/size/backgroundSize-in-background-shorthand-expected.html: Added.
- fast/backgrounds/size/backgroundSize-in-background-shorthand.html: Added.
- fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-background-shorthand.html:
- fast/inspector-support/style-expected.txt:
- inspector/styles/lazy-computed-style-expected.txt:
- inspector/styles/styles-computed-trace-expected.txt:
- inspector/styles/styles-new-API-expected.txt:
- 7:43 AM Changeset in webkit [116644] by
-
- 4 edits in trunk/Source/WebCore
Node::InDetachFlag could be removed.
https://bugs.webkit.org/show_bug.cgi?id=85963
Reviewed by Antti Koivisto.
Removed Node::inDetach() since it can never true
on the only call site setFocusedNode().
No new test. Covered by existing tests.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- dom/Node.cpp:
(WebCore::Node::detach):
- dom/Node.h:
(WebCore):
(Node):
- 7:32 AM FeatureFlags edited by
- Add MEDIA_CAPTURE (diff)
- 7:23 AM Changeset in webkit [116643] by
-
- 16 edits in branches/chromium/1132/Source
Merge 116319 - Unreviewed, rolling out r115525.
http://trac.webkit.org/changeset/115525
https://bugs.webkit.org/show_bug.cgi?id=66683
Too many pages rely on DOMTimeStamp as first argument.
Reverting while we consider next steps.
Source/WebCore:
- WebCore.exp.in:
- bindings/js/JSRequestAnimationFrameCallbackCustom.cpp:
(WebCore::JSRequestAnimationFrameCallback::handleEvent):
- dom/Document.cpp:
(WebCore::Document::serviceScriptedAnimations):
- dom/Document.h:
(Document):
- dom/RequestAnimationFrameCallback.h:
(RequestAnimationFrameCallback):
- dom/RequestAnimationFrameCallback.idl:
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::animationTimerFired):
- dom/ScriptedAnimationController.h:
(ScriptedAnimationController):
(WebCore::ScriptedAnimationController::displayRefreshFired):
- page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
- page/FrameView.h:
(FrameView):
- platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::notifyClients):
- platform/graphics/DisplayRefreshMonitor.h:
(DisplayRefreshMonitor):
- platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
(WebCore::DisplayRefreshMonitor::displayLinkFired):
- platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
(WebCore):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):
Source/WebKit/chromium:
- src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::animate):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateAnimations):
TBR=nduca@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10391049
- 7:11 AM Changeset in webkit [116642] by
-
- 3 edits in trunk/Source/WebCore
Crash in HTMLFormControlElement::m_fieldSetAncestor
https://bugs.webkit.org/show_bug.cgi?id=86070
Reviewed by Kent Tamura.
No new tests.
The previous patch r115990 didn't completely resolve the crash (Bug 85453)
We don't have a reproducible test case, so we are reverting to the old code for setting m_fieldSetAncestor.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::updateFieldSetAndLegendAncestor):
(WebCore::HTMLFormControlElement::insertedInto): Set m_dataListAncestorState to Unknown because ancestor has changed. Call setNeedsWillValidateCheck because style might need to be updated.
(WebCore::HTMLFormControlElement::removedFrom):
(WebCore::HTMLFormControlElement::disabled):
(WebCore::HTMLFormControlElement::recalcWillValidate):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
- html/HTMLFormControlElement.h:
(HTMLFormControlElement): Added m_dataListAncestorState.
- 7:05 AM Changeset in webkit [116641] by
-
- 15 edits1 move in trunk/Source
Web Inspector: rename InspectorBackendStub.js to InspectorBackendCommands.js
https://bugs.webkit.org/show_bug.cgi?id=72306
Source/WebCore:
Changed name for InspectorBackendStub.js to
InspectorBackendCommands.js
Patch by Sam D <dsam2912@gmail.com> on 2012-05-10
Reviewed by Yury Semikhatsky.
No new tests required. File name is changed.
- DerivedSources.pri:
- GNUmakefile.am:
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.vcproj/copyWebCoreResourceFiles.cmd:
- WebCore.xcodeproj/project.pbxproj:
- gyp/copy-inspector-resources.sh:
- inspector/CodeGeneratorInspector.py:
- inspector/front-end/InspectorBackendCommands.qrc: Added.
- inspector/front-end/InspectorBackendStub.qrc: Removed.
- inspector/front-end/inspector.html:
Source/WebKit:
Changed name for InspectorBackendStub.js to
InspectorBackendCommands.js
Patch by Sam D <dsam2912@gmail.com> on 2012-05-10
Reviewed by Yury Semikhatsky.
- PlatformBlackBerry.cmake:
Source/WebKit/chromium:
Changed name for InspectorBackendStub.js to InspectorBackendCommands.js
Patch by Sam D <dsam2912@gmail.com> on 2012-05-10
Reviewed by Yury Semikhatsky.
- WebKit.gyp:
- 7:04 AM Changeset in webkit [116640] by
-
- 3 edits in trunk/Source/WTF
[EFL] Add OwnPtr specialization for Eina_Hash.
https://bugs.webkit.org/show_bug.cgi?id=85046
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-05-10
Reviewed by Andreas Kling.
Add an override for Eina_Hash for EFL port.
- wtf/OwnPtrCommon.h:
(WTF):
- wtf/efl/OwnPtrEfl.cpp:
(WTF::deleteOwnedPtr):
(WTF):
- 6:48 AM Changeset in webkit [116639] by
-
- 9 edits in trunk
Unreviewed, rolling out r116633.
http://trac.webkit.org/changeset/116633
https://bugs.webkit.org/show_bug.cgi?id=86093
Breaks EFL tests (Requested by kov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-10
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/EventSender.cpp:
(keyDownCallback):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setTabKeyCyclesThroughElements):
LayoutTests:
- platform/efl/Skipped:
- 6:42 AM Changeset in webkit [116638] by
-
- 3 edits in trunk/Tools
[EFL] Memory leaks found in EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=85889
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.
Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
created with JSStringCreateWithUTF8CString.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWindowObjectCleared):
- DumpRenderTree/efl/EventSender.cpp:
(modifiersFromJSValue):
- 6:19 AM Changeset in webkit [116637] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Avoid string conversions to construct a QUrl when using Qt5.
https://bugs.webkit.org/show_bug.cgi?id=86006
Reviewed by Kenneth Rohde Christiansen.
In Qt5, the QUrl constructor can handle the string directly, even in UTF-16 because the
constructor QUrl(QString) has been fixed. Unfortunately we still need to use the old
code path when building with Qt4.
No new tests : it's a performance improvement which should be covered by tests.
- platform/qt/KURLQt.cpp:
(WebCore::KURL::operator QUrl):
- 6:15 AM Changeset in webkit [116636] by
-
- 4 edits in trunk
Source/WebCore: [chromium] REGRESSION(r107389) Visible line artifacts on some JPEG images
https://bugs.webkit.org/show_bug.cgi?id=85772
Reviewed by Kent Tamura.
On some JPEG images, vertical and horizontal lines artifacts might appear in image
regions with very high frequency color variation when using DCT_IFAST decodes. Use
DCT_IFAST on small screen devices only (Chromium Android).
No new tests. Covered by existing tests.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(dctMethod): Permit DCT_IFAST decoding for Chromium Android only.
LayoutTests: [chromium] REGRESSION(r107389) Visible line artifacts on JPEG images
https://bugs.webkit.org/show_bug.cgi?id=85772
Reviewed by Kent Tamura.
- platform/chromium/test_expectations.txt: Add IMAGE expectations.
- 5:55 AM Changeset in webkit [116635] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening of flaky tests
https://bugs.webkit.org/show_bug.cgi?id=86069
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-10
- platform/efl/test_expectations.txt:
- 5:39 AM QtWebKitBuildBots edited by
- Add gardening timetable and list of gardeners. Feel free to join us ;-) (diff)
- 5:38 AM Changeset in webkit [116634] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix sites with a viewport meta tag when devicePixelRatio isn't explicitely set on the WebView
https://bugs.webkit.org/show_bug.cgi?id=86002
Reviewed by Kenneth Rohde Christiansen.
The preference was recently changed to a double ratio, but was still left under
FOR_EACH_WEBKIT_UINT32_PREFERENCE and was initialized to inf instead of 1.0.
This would cause the viewport constraints to apply a multi-millionaire device
pixel ratio and make the contents invisible.
This moves it with other double preferences under FOR_EACH_WEBKIT_DOUBLE_PREFERENCE.
- Shared/WebPreferencesStore.h:
(WebKit):
- 5:28 AM Changeset in webkit [116633] by
-
- 9 edits in trunk
[EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
https://bugs.webkit.org/show_bug.cgi?id=82864
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.
Source/WebKit/efl:
Add missing implementation for setTabKeyCyclesThroughElements to EFL's
DumpRenderTreeSupport.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Add missing implementation for setTabKeyCyclesThroughElements to EFL's LayoutTestController
in order to unskip fast/events/keypress-insert-tab.html
- DumpRenderTree/efl/EventSender.cpp:
(keyDownCallback):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setTabKeyCyclesThroughElements):
LayoutTests:
Unskip fast/events/keypress-insert-tab.html
- platform/efl/Skipped:
- 5:20 AM Changeset in webkit [116632] by
-
- 7 edits in trunk/Source
[Qt] Implement fit-to-width behaviour
https://bugs.webkit.org/show_bug.cgi?id=86085
Reviewed by Simon Hausmann.
Source/WebCore:
Add a method to get the minimum scale factor that contains the content
without showing any chrome background.
- dom/ViewportArguments.cpp:
(WebCore::computeMinimumScaleFactorForContentContained):
(WebCore):
- dom/ViewportArguments.h:
(WebCore):
Source/WebKit2:
We don't restrict the minimum scale to the layout viewport anymore,
but instead update the minimum scale when the content size changes.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
- UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
- 5:09 AM Changeset in webkit [116631] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix \sa usage in documentation
Ensure comma between elements (6 missing).
Patch by Marius Storm-Olsen <marius.storm-olsen@nokia.com> on 2012-05-10
Reviewed by Tor Arne Vestbø.
- 4:56 AM Changeset in webkit [116630] by
-
- 4 edits in trunk
[EFL][DRT] EventSender - set delayed event information if it was not set before
https://bugs.webkit.org/show_bug.cgi?id=85972
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.
Tools:
Reset delayed event information if it is missing.
- DumpRenderTree/efl/EventSender.cpp:
(feedOrQueueMouseEvent):
LayoutTests:
Unskipping layout tests that were skipped because of the bug.
- platform/efl/Skipped:
- 4:37 AM Changeset in webkit [116629] by
-
- 24 edits in trunk/Source/WebCore
Remove support for Node::willRemove()
https://bugs.webkit.org/show_bug.cgi?id=55209
Reviewed by Ryosuke Niwa.
This change de-virtualizes Node::willRemove(), gains
5% speedup on Dromaeo dom-modify.
Originally there were 5 willRemove() overrides:
- Element
- HTMLStyleElement
- HTMLSourceElement
- HTMLTrackElement
- HTMLFrameOwnerElement
For first 4 items, this change moves their implementations to
Node::removedFrom() overrides.
Then HTMLFrameOwnerElement is the only class which needs the
notification. Because it emits the "unload" event, it needs some
notification _before_ its removal. To handle that, this change
introduces ChildFrameDisconnector which collects
corresponding decendant elements and disconnect their content frame.
Even though this approach doesn't kill pre-removal tree traversal
completely, it's a bit more efficient due to the de-virtualization.
No new tests. Covered by existing test.
- dom/ContainerNode.cpp:
(WebCore::willRemoveChild): Replaced willRemove() call with ChildFrameDisconnector.
(WebCore::willRemoveChildren): Ditto.
(WebCore::ContainerNode::disconnectDescendantFrames): Added. Used from FrameLoader to replace Document::willRemove() call.
(WebCore):
- dom/ContainerNode.h:
(ContainerNode):
- dom/ContainerNodeAlgorithms.cpp:
(WebCore::ChildFrameDisconnector::collectDescendant):
(WebCore):
(WebCore::ChildFrameDisconnector::Target::disconnect):
- dom/ContainerNodeAlgorithms.h:
(ChildFrameDisconnector):
(Target):
(WebCore::ChildFrameDisconnector::Target::Target):
(WebCore::ChildFrameDisconnector::Target::isValid):
(WebCore):
(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::collectDescendant):
(WebCore::ChildFrameDisconnector::disconnect):
- dom/Element.cpp:
(WebCore::Element::removedFrom):
- dom/Element.h:
- dom/ElementShadow.cpp:
- dom/ElementShadow.h:
(ElementShadow):
- dom/Node.cpp:
- dom/Node.h: Added IsFrameOwnerElement flag to de-virtualize IsFrameOwnerElement().
(WebCore::Node::isFrameOwnerElement): De-virtualized.
(Node):
- html/HTMLElement.h:
(HTMLElement):
(WebCore::HTMLElement::HTMLElement):
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame): Extracted from original willRemove().
- html/HTMLFrameOwnerElement.h:
(HTMLFrameOwnerElement):
(WebCore::toFrameOwnerElement):
(WebCore):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::sourceWasRemoved): Renamed from sourceWillBeRemoved(), dealing with the timing change.
- html/HTMLMediaElement.h:
(HTMLMediaElement):
(WebCore::isMediaElement):
(WebCore):
(WebCore::toMediaElement):
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::removedFrom): Moved some code from willRemove().
- html/HTMLSourceElement.h:
(HTMLSourceElement):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::removedFrom):
(WebCore):
- html/HTMLStyleElement.h:
(HTMLStyleElement):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::removedFrom): Moved some code from willRemove().
- html/HTMLTrackElement.h:
(HTMLTrackElement):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):
- 4:25 AM Changeset in webkit [116628] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] REGRESSION(r116560): It made 7 compositing tests fail
https://bugs.webkit.org/show_bug.cgi?id=86086
Unreviewed gardening, skip new failing tests.
- platform/qt-5.0-wk2/Skipped:
- 4:21 AM Changeset in webkit [116627] by
-
- 2 edits in trunk/LayoutTests
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591
Unreviewed, unskipping another batch of tests that are passing but have
test expectations present that indicate a failure is expected. Their
bug entries will be properly updated after they either remain stable and
passing or they backfire.
- platform/gtk/test_expectations.txt:
- 4:12 AM Changeset in webkit [116626] by
-
- 4 edits in trunk
WebPageProxy::activeURL() should return the pending API request, even when there's no main frame
https://bugs.webkit.org/show_bug.cgi?id=85806
The m_pendingAPIRequestURL member is used (presumably) to mask over the async
nature of WebKit2, so that starting a load of a URL will reflect that URL
immedeatly from activeURL, even if the request has not been passed over to
the web process yet and reflected there.
This works well, except in the case of the initial request, where the main
frame creation happens on the web process side and is notified back to the
UI process. Until we've recived the notification we don't know about the main
frame, and this race condition will potentially give us an empty url instead
of the pending request.
To solve this we always return the pending API request if it's set, even
when there's no mainframe yet (that we known about).
Reviewed by Simon Hausmann.
- 3:56 AM Changeset in webkit [116625] by
-
- 7 edits in trunk
[EFL][DRT] Clear added user style sheets before a new testcase execution.
https://bugs.webkit.org/show_bug.cgi?id=84792
Source/WebKit/efl:
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.
Add a helper function for clearing of the added user style sheets.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::clearUserStyleSheets):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Reviewed Gustavo Noronha Silva.
The added user style sheets from the previous testcases are cleared in order to avoid
flaky results.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-10
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
LayoutTests:
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-10
Reviewed by Gustavo Noronha Silva.
Unskip userscripts/user-style-top-frame-only.html
- platform/efl/Skipped:
- 3:06 AM Changeset in webkit [116624] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL][DRT] fast/events/js-keyboard-event-creation.html needs rebaselining
https://bugs.webkit.org/show_bug.cgi?id=85485
Unreviewed, fast/events/js-keyboard-event-creation.html is rebased.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-10
- platform/efl/Skipped: removed fast/events/js-keyboard-event-creation.html
- platform/efl/fast/events/js-keyboard-event-creation-expected.txt: Added (Taken from GTK port).
- 2:59 AM Changeset in webkit [116623] by
-
- 3 edits in trunk/Source/WebCore
Change the return type of Entry.toURL() back to String from KURL
https://bugs.webkit.org/show_bug.cgi?id=85858
Reviewed by Ryosuke Niwa.
I once changed it from String to KURL in r116273 but it turned out that
it involves implicit conversion and may incur extra overhead.
This partly reverts r116273 while keeping some internal functions
returning KURL as it's what we initially create as and is more
convenient to operate on.
No new tests; no functional or visible changes.
- Modules/filesystem/EntryBase.cpp:
(WebCore::EntryBase::toURL):
- Modules/filesystem/EntryBase.h:
(EntryBase):
- 2:23 AM Changeset in webkit [116622] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip news failing and crashing tests to paint the bot green.
- platform/qt-mac/Skipped:
- 1:26 AM Changeset in webkit [116621] by
-
- 2 edits in trunk/LayoutTests
[Qt] new test http/tests/cookies/single-quoted-value.html is failing
https://bugs.webkit.org/show_bug.cgi?id=86066
Unreviewed gardening after r116601
- platform/qt/Skipped:
- 1:00 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 12:53 AM Changeset in webkit [116620] by
-
- 2 edits in branches/dfgopt/Source/JavaScriptCore
DFG should allow inlining in case of certain arity mismatches
https://bugs.webkit.org/show_bug.cgi?id=86059
Reviewed by Geoff Garen.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
- 12:48 AM Changeset in webkit [116619] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Autocomplete for CSS property values in the Styles pane behaving incorrectly
https://bugs.webkit.org/show_bug.cgi?id=85784
Reviewed by Vsevolod Vlasov.
Before executing the number increment/decrement within CSS property value, the current word is checked
for being a valid suggestion for the current property, and if it is, the numeric change is skipped
in favor of the suggested property value switch by a suggest box.
- inspector/front-end/StylesSidebarPane.js:
- 12:42 AM Changeset in webkit [116618] by
-
- 4 edits in trunk
Make DOMCharacterDataModified a scoped event (similar to r73690).
https://bugs.webkit.org/show_bug.cgi?id=85920
Reviewed by Ryosuke Niwa.
Source/WebCore:
DOMCharacterDataModified was missing in the list of already scoped
DOM mutation events like DOMSubtreeModified, DOMNodeInserted, etc.
It helps to delay event dispatches until the completion of each call
of EditCommand::doApply. This has been useful in the past and helped to
prevent unexpected DOM tree mutations while the editing command is executing.
- dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):
LayoutTests:
- fast/events/scoped/editing-commands.html: test modified to check DOMCharacterDataModified event.
- 12:38 AM Changeset in webkit [116617] by
-
- 3 edits in trunk/Source/WebCore
Default to null value for HistoryItem::m_pageScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=84385
Patch by Alexandre Elias <aelias@google.com> on 2012-05-10
Reviewed by Adam Barth.
Previously, HistoryItem::m_pageScaleFactor defaulted to a value
of 1, making it impossible to determine whether this value was never
set, or intentionally set to 1. This patch introduces a default value
of 0 and makes restoreScrollPositionAndViewState not touch the page
scale factor if this value is still present at time of reload.
This is a no-op change for common navigation scenarios. The
motivation for this change is the corner case of syncing history items
from a desktop browser to a mobile device. In that case, we need a
way to specify that the history item does not contain a
pageScaleFactor so that the mobile device does not display the page
overly zoomed in.
No new tests.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
- 12:34 AM Changeset in webkit [116616] by
-
- 2 edits in trunk/Source/WebCore
Use suitable viewport values when a Mobile DTD is used.
https://bugs.webkit.org/show_bug.cgi?id=85425
Unreviewed debug buildfix after r116571.
- dom/Document.cpp:
(WebCore::Document::setDocType):
- 12:22 AM Changeset in webkit [116615] by
-
- 5 edits in trunk/Source/WebCore
[Forms] Move step related methods to InputType class from HTMLInputElement class
https://bugs.webkit.org/show_bug.cgi?id=85978
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-05-10
Reviewed by Kent Tamura.
This patch is part of re-factoring of HTMLInputElement.cpp for numeric input type.
In this patch, we move implementation of getAllowedValueStep and stepUp/stepUpFromRenderer
to InputType class because of these are for DateTime/Number/Range.
Following patches will change implementation of getAllowedValueStep to use StepRange and
remove step related methods, defaultStep, stepScaleFactor, and so on.
No new tests. This patch should not change behavior.
- html/HTMLInputElement.cpp:
(WebCore):
(WebCore::HTMLInputElement::getAllowedValueStep):
(WebCore::HTMLInputElement::stepUp):
(WebCore::HTMLInputElement::stepDown):
(WebCore::HTMLInputElement::stepUpFromRenderer):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
(WebCore::InputType::applyStep):
(WebCore):
(WebCore::InputType::alignValueForStep):
(WebCore::InputType::getAllowedValueStep):
(WebCore::InputType::getAllowedValueStepWithDecimalPlaces):
(WebCore::InputType::stepUp):
(WebCore::InputType::stepUpFromRenderer):
- html/InputType.h:
(InputType):
- 12:19 AM WebInspector edited by
- add info about the weinre experiment (diff)
- 12:10 AM Changeset in webkit [116614] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/test_expectations.txt:
- 12:00 AM Changeset in webkit [116613] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Mark CCLayerTreeHostTestSetNeedsCommit2.runMultiThread and
CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity.runMultiThread flaky.
- tests/CCLayerTreeHostTest.cpp:
May 9, 2012:
- 11:42 PM Changeset in webkit [116612] by
-
- 4 edits1 add in trunk/Source/WebKit/chromium
[chromium] Add ability to override user agent string per-WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=83959
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-05-09
Reviewed by Adam Barth.
Adds a method that can be used to override the normal user agent in
chromium. Also adds a unit test to check if the override is taking effect.
- WebKit.gypi:
- public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::userAgent):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::userAgent):
- tests/FrameLoaderClientImplTest.cpp: Added.
(WebKit):
(TestWebFrameClient):
(WebKit::TestWebFrameClient::setUserAgentOverride):
(FrameLoaderClientImplTest):
(WebKit::FrameLoaderClientImplTest::SetUp):
(WebKit::FrameLoaderClientImplTest::TearDown):
(WebKit::FrameLoaderClientImplTest::setUserAgentOverride):
(WebKit::FrameLoaderClientImplTest::userAgent):
(WebKit::TEST_F):
- 11:13 PM Changeset in webkit [116611] by
-
- 4 edits1 add in trunk
Calendar Picker: Fix a crash by changing input type.
https://bugs.webkit.org/show_bug.cgi?id=86007
Reviewed by Hajime Morita.
.:
- ManualTests/forms/calendar-picker-crash-by-type-change.html: Added.
Source/WebCore:
Manual test: forms/calendar-picker-crash-by-type-change.html
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::~CalendarPickerElement):
Added. Make sure the popup is closed.
- html/shadow/CalendarPickerElement.h:
(CalendarPickerElement): Add declaration of the destructor.
- 11:11 PM Changeset in webkit [116610] by
-
- 45 edits in trunk
Move suspendAnimations to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=85986
Reviewed by Ryosuke Niwa.
.:
- Source/autotools/symbols.filter: Add a symbol filter for suspendAnimations.
Source/WebCore:
Add suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
No new tests, since we are improving here the infra-structure for testing
a specific method.
- testing/Internals.cpp:
(WebCore::Internals::suspendAnimations):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/efl:
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- WebKit.order:
- WebView/WebFrame.mm:
- WebView/WebFramePrivate.h:
Source/WebKit/qt:
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp:
- WebFrame.h:
Source/WebKit2:
- win/WebKit2.def: Add a symbol filter for suspendAnimations.
Tools:
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
LayoutTests:
Call suspendAnimations functions from internals, because it is able to work in the
cross-port way through the Internals interface.
- animations/play-state-suspend.html:
- animations/stop-animation-on-suspend.html:
- animations/suspend-resume-animation-events.html:
- animations/suspend-resume-animation.html:
- animations/suspend-transform-animation.html:
- transitions/suspend-transform-transition.html:
- 10:47 PM Changeset in webkit [116609] by
-
- 2 edits in trunk/Tools
[Chromium] Attempt to fix an Android build error.
https://bugs.webkit.org/show_bug.cgi?id=86045
- DumpRenderTree/DumpRenderTree.gypi:
- 10:31 PM Changeset in webkit [116608] by
-
- 9 edits1 add in trunk/Source
Source/WebCore: Add dispatchMessageEventWithOriginCheck to DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=85815
Reviewed by Adam Barth.
Useful for ports that support cross-process postMessage.
No new tests, since covered by existing postMessage tests.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessageTimerFired):
(WebCore):
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
- page/DOMWindow.h:
(WebCore):
(DOMWindow):
Source/WebKit/chromium: Add dispatchMessageEventWithOriginCheck to WebFrame
https://bugs.webkit.org/show_bug.cgi?id=85815
Reviewed by Adam Barth.
Tested by WebFrameTest.DispatchMessageEventWithOriginCheck.
Also fixes source frame bug in willCheckAndDispatchMessageEvent.
- public/WebFrame.h:
(WebFrame):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::checkAndDispatchMessageEvent):
(WebKit):
- src/WebFrameImpl.h:
(WebFrameImpl):
- 10:08 PM Changeset in webkit [116607] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix a crash in ContextMenuClientImpl::getCustomMenuFromDefaultItems
https://bugs.webkit.org/show_bug.cgi?id=85866
Reviewed by Ryosuke Niwa.
DocumentMarkerController::markersInRange crashes if the input range is NULL.
This change adds a NULL check before getCustomMenuFromDefaultItems() calls this
function to avoid this crash.
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Added a NULL check.
- 9:34 PM Changeset in webkit [116606] by
-
- 4 edits in trunk/Tools
Don't show partytime if there are non-layout test failures.
https://bugs.webkit.org/show_bug.cgi?id=86056
Reviewed by Dimitri Glazkov.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- 9:14 PM Changeset in webkit [116605] by
-
- 4 edits1 delete in trunk/Source/WebKit/chromium
Unreviewed, rolling out r116602.
http://trac.webkit.org/changeset/116602
https://bugs.webkit.org/show_bug.cgi?id=86057
Build error on Windows (Requested by tkent on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-09
- WebKit.gypi:
- public/WebFrameClient.h:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::userAgent):
- tests/FrameLoaderClientImplTest.cpp: Removed.
- 9:03 PM Changeset in webkit [116604] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Fix compilation warning on Android.
https://bugs.webkit.org/show_bug.cgi?id=85958
- features.gypi: Move ENABLE_MEDIA_CAPTURE=0 to non-Android block.
- 8:58 PM Changeset in webkit [116603] by
-
- 8 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Autofill feature implementation for BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=85577
Patch by Jonathan Dong <Jonathan Dong> on 2012-05-09
Reviewed by Rob Buis.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::autofillTextField): Added this interface
function to auto fill the inputting text field when user selects
a autofill candidate value from autofill context dialog.
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::notifyPopupAutofillDialog): Added
this interface function to notify WebPageClient to pop up the autofill
context dialog with the suggested input items.
(BlackBerry::WebKit::WebPage::clearAutofillData):
- Api/WebPage.h:
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
- WebCoreSupport/AutofillManager.cpp:
(WebCore::AutofillManager::didChangeInTextField):
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::textDidChangeInTextField): Implemented
this function to listen to the notification of text field change, and
notify AutofillManager to handle the autofill.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
Save the name and value pair of every autofillable input text field when
user submitting a form.
- 8:44 PM Changeset in webkit [116602] by
-
- 4 edits1 add in trunk/Source/WebKit/chromium
[chromium] Add ability to override user agent string per-WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=83959
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-05-09
Reviewed by Adam Barth.
Adds a method that can be used to override the normal user agent in
chromium. Also adds a unit test to check if the override is taking effect.
- WebKit.gypi:
- public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::userAgent):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::userAgent):
- tests/FrameLoaderClientImplTest.cpp: Added.
(WebKit):
(TestWebFrameClient):
(WebKit::TestWebFrameClient::setUserAgentOverride):
(FrameLoaderClientImplTest):
(WebKit::FrameLoaderClientImplTest::SetUp):
(WebKit::FrameLoaderClientImplTest::TearDown):
(WebKit::FrameLoaderClientImplTest::setUserAgentOverride):
(WebKit::FrameLoaderClientImplTest::userAgent):
(WebKit::TEST_F):
- 8:30 PM Changeset in webkit [116601] by
-
- 3 edits3 adds in trunk
[BlackBerry] Cookie parsing issue. If the cookie value provided was (") then the browser creates a session cookie instead.
https://bugs.webkit.org/show_bug.cgi?id=85775
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-09
Reviewed by Rob Buis.
Source/WebCore:
Make CookieParser::parseOneCookie handle (cookiename="cookievalue;expires=xxxx) correctly.
This cookie's value is "cookievalue not "cookievalue;expires=xxxx.
Test: http/tests/cookies/single-quoted-value.html
- platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):
LayoutTests:
- http/tests/cookies/script-tests/single-quoted-value.js: Added.
- http/tests/cookies/single-quoted-value-expected.txt: Added.
- http/tests/cookies/single-quoted-value.html: Added.
- 8:24 PM Changeset in webkit [116600] by
-
- 2 edits in trunk/Tools
Improve a warning message for a reftest having an unused expectation file.
https://bugs.webkit.org/show_bug.cgi?id=85975
Reviewed by Adam Barth.
The current warning message is not intuitive. It might be better to update the message
so that it encourage users to remove unused expectation files.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.init):
- 8:08 PM Changeset in webkit [116599] by
-
- 12 edits in trunk/Tools
Change "losing test coverage" to cover all non-layout test problems in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=86043
Reviewed by Adam Barth.
-Get rid of the gtest iframe.
-Cover all non-layout test problems. Before we wouldn't catch compile failures
or gtest failures since they were not on the webkit testing bots.
-Include the list of failing steps next to the builder name. This is a lot less
cluttered than you'd expect and already helped me find a compile failure early.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
Delete unused map.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- 7:49 PM WebKit Team edited by
- Adding Charles Reis as committer. (diff)
- 7:48 PM Changeset in webkit [116598] by
-
- 1 edit4 deletes in trunk/LayoutTests
Remove unused test expectation files.
https://bugs.webkit.org/show_bug.cgi?id=85973
Reviewed by Ojan Vafai.
Since cell-shrinkback.html is a reftest, these txt and png
expectations files are not used by test runner and cause warning messages when running tests.
- platform/chromium-linux/fast/multicol/cell-shrinkback-expected.png: Removed.
- platform/chromium-win/fast/multicol/cell-shrinkback-expected.png: Removed.
- platform/qt/fast/multicol/cell-shrinkback-expected.png: Removed.
- platform/qt/fast/multicol/cell-shrinkback-expected.txt: Removed.
- 7:45 PM Changeset in webkit [116597] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Added myself as a committer.
- 7:32 PM Changeset in webkit [116596] by
-
- 3 edits in trunk/Source/WebCore
Add multi-channels support for CopyWithGainFrom in AudioBus
https://bugs.webkit.org/show_bug.cgi?id=80675
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-05-09
Reviewed by Chris Rogers.
- platform/audio/AudioBus.cpp:
(WebCore):
(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::copyWithGainFrom):
- platform/audio/AudioBus.h:
(AudioBus):
- 7:00 PM Changeset in webkit [116595] by
-
- 24 edits1 copy3 adds in trunk
Crash using the new WKBundleDOMWindowExtensions APIs.
https://bugs.webkit.org/show_bug.cgi?id=85888
Reviewed by Brady Eidson.
Source/WebCore:
WKBundlePageWillDestroyGlobalObjectForDOMWindowExtensionCallback was only being invoked when
the WKPage was destroyed, and then only for the child frames. In addition, the
DOMWindowExtension was holding onto a destroyed DOMWindow and attempting to unregister from
when the WK2 wrapper object was attempting to destroy the DOMWindowExtension.
The underlying issue here was that the DOMWindowProperties were getting disconnectFrame
and willDetachPage called on them at the wrong times.
Rename DOMWindowProperty::disconnectFrame and reconnectFrame to disconnectFrameForPageCache
and reconnectFrameFromPageCache for clarity.
Only invoke DOMWindowProperty::disconnectFrameForPageCache when the frame is going into the
page cache.
In the cases where the DOMWindow is getting destroyed, the frame is being destroyed, or the
DOMWindow is getting cleared because the frame is being navigated, invoke
DOMWindowProperty::willDestroyGlobalObjectInFrame instead of disconnectFrame.
Invoke DOMWindowProperty::willDetachGlobalObjectFromFrame when a document is being detached
because the frame has been detached (e.g. fast/storage/storage-detached-iframe.html) and
won't be immediately destroyed.
Invoke DOMWindowProperty::willDestroyGlobalObjectInCachedFrame when a cached frame is
being destroyed.
New WK2 API Test: DOMWindowExtensionNoCache.
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::disconnectFrameForPageCache):
Updated for disconnectFrame rename.
(WebCore::DOMWindowIndexedDatabase::reconnectFrameFromPageCache):
Updated for reconnectFrame rename.
(WebCore::DOMWindowIndexedDatabase::willDestroyGlobalObjectInCachedFrame):
Get rid of the suspended IDBFactory.
(WebCore::DOMWindowIndexedDatabase::willDestroyGlobalObjectInFrame):
Get rid of the IDBFactory.
(WebCore::DOMWindowIndexedDatabase::willDetachGlobalObjectFromFrame):
Ditto.
- Modules/indexeddb/DOMWindowIndexedDatabase.h:
- dom/Document.cpp:
(WebCore::Document::prepareForDestruction):
Tell the DOMWindow before detaching the Document.
- dom/Document.h:
- history/CachedFrame.cpp:
(WebCore::CachedFrame::destroy):
Tell the DOMWindow.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):
Use Document::prepareForDestruction so that the DOMWindow is told about the main frame
navigation before detaching the Document.
- loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::disconnectFrameForPageCache):
Updated for the disconnectFrame rename.
(WebCore::DOMApplicationCache::reconnectFrameFromPageCache):
Updated for the reconnectFrame rename.
(WebCore::DOMApplicationCache::willDestroyGlobalObjectInFrame):
Cover the cases formerly covered by disconnectFrame (which was sometimes being called when
called when the frame was destroyed).
- loader/appcache/DOMApplicationCache.h:
- notifications/DOMWindowNotifications.cpp:
(WebCore::DOMWindowNotifications::disconnectFrameForPageCache):
Updated for the disconnectFrame rename.
(WebCore::DOMWindowNotifications::reconnectFrameFromPageCache):
Updated for the reconnectFrame rename.
(WebCore::DOMWindowNotifications::willDestroyGlobalObjectInCachedFrame):
Get rid of the suspended notification center.
(WebCore::DOMWindowNotifications::willDestroyGlobalObjectInFrame):
Get rid of the notification center.
(WebCore::DOMWindowNotifications::willDetachGlobalObjectFromFrame):
Do not allow use of the notification center by detached frames.
- notifications/DOMWindowNotifications.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::clearDOMWindowProperties):
Do not call disconnectDOMWindowProperties. It is now the responsibility of the callers to
tell the DOMWindowProperties the correct cause of being cleared.
(WebCore::DOMWindow::~DOMWindow):
Make sure the DOMWindowProperties still know that the DOMWindow is going away.
(WebCore::DOMWindow::frameDestroyed):
Invoke willDestroyGlobalObjectInFrame on the DOMWindowProperties.
(WebCore::DOMWindow::willDetachPage):
It is no longer necessary to tell the DOMWindowProperties anything here.
(WebCore::DOMWindow::willDestroyCachedFrame):
Tell the DOMWindowProperties.
(WebCore::DOMWindow::willDestroyDocumentInFrame):
Ditto.
(WebCore::DOMWindow::willDetachDocumentFromFrame):
Ditto.
(WebCore::DOMWindow::clear):
Ditto.
(WebCore::DOMWindow::disconnectDOMWindowProperties):
Updated for the disconnectFrame rename.
(WebCore::DOMWindow::reconnectDOMWindowProperties):
Ditto.
- page/DOMWindow.h:
- page/DOMWindowExtension.cpp:
(WebCore::DOMWindowExtension::DOMWindowExtension):
Move the responsibility for tracking the disconnected DOMWindow to DOMWindowProperty, since
DOMWindowProperty will need it to unregister the property when a cached frame is destroyed.
(WebCore::DOMWindowExtension::disconnectFrameForPageCache):
Remove the code to check for disconnectFrame being called twice - it is now only called when
a frame goes into the page cache.
Let the DOMWindowProperty keep track of the disconnected DOMWindow.
(WebCore::DOMWindowExtension::reconnectFrameFromPageCache):
Let the DOMWindowProperty keep track of the disconnected DOMWindow.
(WebCore::DOMWindowExtension::willDestroyGlobalObjectInCachedFrame):
Dispatch the willDestroyGlobalObjectForDOMWindowExtension callback.
(WebCore::DOMWindowExtension::willDestroyGlobalObjectInFrame):
Ditto, but only if the callback hasn't already been sent because the frame has been detached.
(WebCore::DOMWindowExtension::willDetachGlobalObjectFromFrame):
Send the callback because nothing interesting can be done in the frame once it has been
detached.
- page/DOMWindowExtension.h:
- page/DOMWindowProperty.cpp:
(WebCore::DOMWindowProperty::DOMWindowProperty):
Keep track of the disconnected DOMWindow so it can be used to unregister the property when a
cached frame is destroyed.
(WebCore::DOMWindowProperty::~DOMWindowProperty):
Also unregister the property when a DOMWindowProperty for a cached frame is destroyed.
(WebCore::DOMWindowProperty::disconnectFrameForPageCache):
Keep track of the disconnected DOMWindow.
(WebCore::DOMWindowProperty::reconnectFrameFromPageCache):
Ditto.
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInCachedFrame):
Unregister the property from the disconnected DOMWindow.
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInFrame):
Unregister the property from the DOMWindow and stop keeping track of the frame.
(WebCore::DOMWindowProperty::willDetachGlobalObjectFromFrame):
Do not set m_frame to 0 because detached frames still have access to the DOMWindow, even if
they can't do anything meaningful with it.
- page/DOMWindowProperty.h:
- page/Frame.cpp:
(WebCore::Frame::setView):
Tell the DOMWindow that the Document is being detached so it can tell the
DOMWindowProperties.
- page/PointerLock.cpp:
(WebCore::PointerLock::disconnectFrameForPageCache):
Updated for disconnectFrame rename.
(WebCore::PointerLock::willDestroyGlobalObjectInFrame):
Cover the cases formerly covered by disconnectFrame (which was sometimes being called when
called when the frame was destroyed).
- page/PointerLock.h:
Tools:
Cached frames can live slightly longer than the page, but most clients unregister themselves
and do other cleanup in the willDestroyPage callback, making them miss the
willDestroyGlobalObjectForDOMWindowExtension callbacks.
The calls to willDestroyGlobalObjectForDOMWindowExtension in the DOMWindowExtensionBasic
test were all being invoked underneath WebPage::close. This is unrealistic. Update that test
to destroy the BundleDOMWindowExtensions in response to the willDestroyPage callback.
Add a test to verify that willDestroyGlobalObjectForDOMWindowExtension is being called for
pages that don't go into the page cache.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add DOMWindowExtensionNoCache.cpp, DOMWindowExtensionNoCache_Bundle.cpp, simple-unload.html
and simple-iframe-unload.html
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
(TestWebKitAPI):
Remove the expected messages for willDestroyGlobalObjectForDOMWindowExtension.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Do not bother to keep track of the live extension count - all of them are expected to be
live until the test completes.
(TestWebKitAPI::TEST):
Fix the calls to EXPECT to pass the expected value first, and use EXPECT_WK_STREQ so that
message failures will be clearer.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
Clean up the BundleDOMWindowExtensions.
(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
Add an ASSERT_NOT_REACHED.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Keep track of the messages received so they can be checked at the end of the test.
(TestWebKitAPI::TEST):
Navigate to uncacheable pages and back.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp.
(DOMWindowExtensionNoCache):
(TestWebKitAPI::DOMWindowExtensionNoCache::DOMWindowExtensionNoCache):
Set up all the states for each BundleDOMWindowExtension.
(TestWebKitAPI::DOMWindowExtensionNoCache::frameLoadFinished):
Tell the UI Process about the states of the BundleDOMWindowExtensions.
(TestWebKitAPI::DOMWindowExtensionNoCache::sendExtensionStateMessage):
(TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
(TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
Remvoe the remaining BundleDOMWindowExtensions, send the updated state, and finish the test.
(TestWebKitAPI::DOMWindowExtensionNoCache::updateExtensionStateRecord):
(TestWebKitAPI::DOMWindowExtensionNoCache::sendBundleMessage):
(TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
(TestWebKitAPI::DOMWindowExtensionNoCache::willDisconnectDOMWindowExtensionFromGlobalObject):
ASSERT that these pages not going into the page cache are not getting disconnected to go into
the page cache.
(TestWebKitAPI::DOMWindowExtensionNoCache::didReconnectDOMWindowExtensionToGlobalObject):
Ditto about getting reconnected when coming out of the page cache.
(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyGlobalObjectForDOMWindowExtension):
Tell the UI Process, update the state, and get rid of the BundleDOMWindowExtension.
(TestWebKitAPI::didFinishLoadForFrameCallback):
(TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
(TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
(TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
(TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
- TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Added.
- TestWebKitAPI/Tests/WebKit2/simple-unload.html: Added.
- 6:52 PM Changeset in webkit [116594] by
-
- 12 edits in trunk/Source
[chromium] Ensure animations get ticked at least once when added.
https://bugs.webkit.org/show_bug.cgi?id=86013
Patch by Ian Vollick <vollick@chromium.org> on 2012-05-09
Reviewed by James Robinson.
Source/WebCore:
Tested in
CCLayerTreeHostTestTickAnimationWhileBackgrounded.runSingleThreaded
CCLayerTreeHostTestAddAnimationWithTimingFunction.runSingleThreaded
CCLayerTreeHostTestSynchronizeAnimationStartTimes.runSingleThreaded
CCLayerTreeHostTestAnimationFinishedEvents.runSingleThreaded
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::addAnimation):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didAddAnimation):
(WebCore):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(CCSingleThreadProxyAnimationTimer):
(WebCore::CCSingleThreadProxyAnimationTimer::create):
(WebCore::CCSingleThreadProxyAnimationTimer::CCSingleThreadProxyAnimationTimer):
(WebCore):
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::didAddAnimation):
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
(WTF):
- 6:31 PM Changeset in webkit [116593] by
-
- 2 edits in trunk/Source/JavaScriptCore
JIT memory allocator is not returning memory to the OS on Darwin
https://bugs.webkit.org/show_bug.cgi?id=86047
<rdar://problem/11414948>
Reviewed by Geoff Garen.
Work around the problem by using a different madvise() flag, but only for the JIT memory
allocator. Also put in ASSERTs that the call is actually working.
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::notifyNeedPage):
(JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):
- 6:21 PM Changeset in webkit [116592] by
-
- 18 edits2 adds in trunk
Implement HTML Media Capture
https://bugs.webkit.org/show_bug.cgi?id=85958
Reviewed by Eric Seidel.
Source/WebCore:
This patch begins the implementation of
http://www.w3.org/TR/html-media-capture/ by adding the capture
attribute to HTMLInputElement.
Test: fast/forms/file/file-input-capture.html
- html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent):
- html/HTMLAttributeNames.in:
- html/HTMLInputElement.cpp:
(WebCore):
(WebCore::HTMLInputElement::capture):
(WebCore::HTMLInputElement::setCapture):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLInputElement.idl:
- platform/FileChooser.h:
(FileChooserSettings):
Source/WebKit/chromium:
- features.gypi:
- public/WebFileChooserParams.h:
(WebFileChooserParams):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::runOpenPanel):
LayoutTests:
- fast/forms/file/file-input-capture-expected.txt: Added.
- fast/forms/file/file-input-capture.html: Added.
- Test that the capture attribute works properly.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/gtk/test_expectations.txt:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- Skip the test on all platforms. The feature is enabled only on Android, which isn't yet able to run LayoutTests upstream.
- 6:13 PM Changeset in webkit [116591] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Refactor data scheme support
https://bugs.webkit.org/show_bug.cgi?id=85938
Reviewed by Rob Buis.
We will create a DataStream in our platform repository,
so that can be wrapped up by NetworkJob for webkit rendering,
and by DownloadStream for downloading.
Refactor, no new tests.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::cancelJob):
(WebCore::NetworkJob::sendResponseIfNeeded):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- 6:01 PM Changeset in webkit [116590] by
-
- 2 edits in trunk/Tools
[Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
https://bugs.webkit.org/show_bug.cgi?id=86045
Reviewed by Eric Seidel.
- DumpRenderTree/DumpRenderTree.gypi:
- 5:56 PM Changeset in webkit [116589] by
-
- 2 edits in trunk/Tools
[Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
https://bugs.webkit.org/show_bug.cgi?id=86041
Reviewed by Eric Seidel.
- DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
- 5:51 PM Changeset in webkit [116588] by
-
- 2 edits in trunk/Tools
[Chromium] Android needs to swizzle pixel dumps in order to get the same hash as other platforms
https://bugs.webkit.org/show_bug.cgi?id=86040
Reviewed by Kent Tamura.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dumpImage):
- 5:41 PM Changeset in webkit [116587] by
-
- 7 edits in trunk/Source
[chromium] Don't draw when canDraw() is false
https://bugs.webkit.org/show_bug.cgi?id=85829
Reviewed by Adrienne Walker.
Source/WebCore:
This is based on the work of Daniel Sievers in bug
https://bugs.webkit.org/show_bug.cgi?id=82680. When canDraw() is false,
we should not call drawLayers() or prepareToDraw() in both Single- and
Multi-Threaded mode.
drawLayers() is crashing in single threaded mode, and this attempts to
prevent it from being called with invalid state. While making it behave
properly in single-threaded mode, it seems appropriate to unrevert the
parts of 82680 that made threaded mode behave similarly appropriately.
A single-threaded test is not included since LTHTests is unable to run
in single-threaded mode at this time (pending work from Ian Vollick). So
we test in threaded mode only with a note to include a single thread
version.
Tests: CCLayerTreeHostTestCanDrawBlocksDrawing.runMultiThread
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestCanDrawBlocksDrawing):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::CCLayerTreeHostTestCanDrawBlocksDrawing):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::beginTest):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::afterTest):
(WTF::TEST_F):
- 5:35 PM Changeset in webkit [116586] by
-
- 2 edits in trunk/Tools
[EFL] Build fix after r116464.
`ulong' is a type defined by glibc, so it is not very
portable. Use `unsigned long' instead.
- DumpRenderTree/efl/EventSender.cpp:
(DelayedEvent::DelayedEvent):
(DelayedEvent):
(leapForwardCallback):
- 5:34 PM Changeset in webkit [116585] by
-
- 3 edits in trunk/Source/WebCore
[Cairo] GLContextGLX releases the context with an uninitialized display
https://bugs.webkit.org/show_bug.cgi?id=86039
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-09
Reviewed by Philippe Normand.
No new tests. This does not change behavior on most machines, but has
the potential to prevent a pretty nasty crash on others.
Use the shared display to release GLX contexts instead of the uninitialized
m_display member.
- platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::~GLContextGLX): Release the display with the shared
display.
- platform/graphics/glx/GLContextGLX.h:
(GLContextGLX): Remove the m_display member.
- 5:32 PM Changeset in webkit [116584] by
-
- 3 edits6 adds in trunk
Subresources loaded after a reload completes shouldn't be revalidated.
https://bugs.webkit.org/show_bug.cgi?id=84614
Source/WebCore:
Based on patch by Darin Fisher.
Reviewed by Darin Fisher.
Tests: http/tests/cache/loaded-from-cache-after-reload-within-iframe.html
http/tests/cache/loaded-from-cache-after-reload.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Reset m_loadType after the load completes.
LayoutTests:
Tests by Darin Fisher.
Reviewed by Darin Fisher.
- http/tests/cache/loaded-from-cache-after-reload-expected.txt: Added.
- http/tests/cache/loaded-from-cache-after-reload-within-iframe-expected.txt: Added.
- http/tests/cache/loaded-from-cache-after-reload-within-iframe.html: Added.
- http/tests/cache/loaded-from-cache-after-reload.html: Added.
- http/tests/cache/resources/loaded-from-cache-after-reload-within-iframe-subframe.html: Added.
- http/tests/cache/resources/random-cached.cgi: Added.
- 5:19 PM Changeset in webkit [116583] by
-
- 4 edits in trunk/Source
It should be possible to get useful debug logging from the JIT memory allocator
https://bugs.webkit.org/show_bug.cgi?id=86042
Reviewed by Geoff Garen.
Source/JavaScriptCore:
- jit/ExecutableAllocator.h:
Source/WTF:
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::findAndRemoveFreeSpace):
(WTF::MetaAllocator::addFreeSpace):
(WTF::MetaAllocator::dumpProfile):
- 5:18 PM Changeset in webkit [116582] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r116573.
http://trac.webkit.org/changeset/116573
https://bugs.webkit.org/show_bug.cgi?id=86038
Broke the Chromium Mac compile (Requested by ojan_gardening on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-09
- public/WebPlugin.h:
(WebPlugin):
- 5:15 PM Changeset in webkit [116581] by
-
- 4 edits in trunk/Tools
[Chromium] LayoutTestController should use ENABLE guards for some features
https://bugs.webkit.org/show_bug.cgi?id=86030
Reviewed by Eric Seidel.
These features are disabled on OS(ANDROID) and so shouldn't be compiled
when the feature is off.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- 5:14 PM Changeset in webkit [116580] by
-
- 2 edits in trunk/Source/WebCore
[V8] Fix issue where V8BindingPerContextData could keep the context object alive
https://bugs.webkit.org/show_bug.cgi?id=86036
Reviewed by Kentaro Hara.
This is a partial revert of http://trac.webkit.org/changeset/114320/. This keeps
the layout tests that were introduced since it turns out that
http://trac.webkit.org/changeset/114989 fixes the tests too.
Covered by: http/tests/security/isolatedWorld/context-destroy.html
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::destroy):
- 5:12 PM Changeset in webkit [116579] by
-
- 2 edits in trunk/Source/WebCore
Speed up some parts of TileCache drawing
https://bugs.webkit.org/show_bug.cgi?id=86033
<rdar://problem/10919373>
Reviewed by Sam Weinig.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::tileCoverageRect):
If we can't have scrollbars, there's not much need to extend the tile coverage rect outside of the visible rect, since it's
unlikely that we'll do any form of scrolling here.
(WebCore::TileCache::revalidateTiles):
Don't update the tile layer frame if it's big enough to contain the tile size. Also, if there are no new tiles created,
don't call platformCALayerDidCreateTiles since that will trigger an extra layer flush.
- 5:11 PM WebKitGTK/1.8.x edited by
- (diff)
- 5:04 PM Changeset in webkit [116578] by
-
- 2 edits in trunk/Source/JavaScriptCore
GC race condition in OpaqueJSClass::prototype
https://bugs.webkit.org/show_bug.cgi?id=86034
Build fix.
- API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
- Eeeep, landed bad version of patch!
- 5:01 PM Changeset in webkit [116577] by
-
- 1 edit in branches/chromium/1132/Source/WebCore/rendering/RenderObject.cpp
Merge 116339 - Fix containerForRepaint() assumption about non-null enclosingLayer()
https://bugs.webkit.org/show_bug.cgi?id=85807
Reviewed by Simon Fraser.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint):
TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/10378082
- 4:57 PM Changeset in webkit [116576] by
-
- 1 edit2 deletes in branches/chromium/1132
Revert 114320 - [V8] Don't delete the per context data until the V8IsolatedContext is deleted
https://bugs.webkit.org/show_bug.cgi?id=83831
Reviewed by Nate Chapin.
Source/WebCore:
Test: http/tests/security/isolatedWorld/context-destroy.html
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::destroy):
LayoutTests:
- http/tests/security/isolatedWorld/context-destroy-expected.txt: Added.
- http/tests/security/isolatedWorld/context-destroy.html: Added.
TBR=arv@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10386064
- 4:56 PM Changeset in webkit [116575] by
-
- 2 edits in trunk/Source/JavaScriptCore
GC race condition in OpaqueJSClass::prototype
https://bugs.webkit.org/show_bug.cgi?id=86034
Reviewed by Filip Pizlo.
The bug here is basically:
if (weakref) weakref->method()
where a GC may occur between the if & the method call.
- API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
- 4:44 PM Changeset in webkit [116574] by
-
- 4 edits in trunk
setPageScaleFactor should setScrollPosition if scale is unchanged
https://bugs.webkit.org/show_bug.cgi?id=84400
Patch by Alexandre Elias <aelias@google.com> on 2012-05-09
Reviewed by Adam Barth.
Previously, setPageScaleFactor forgot about its "origin" argument if
the page scale factor is unchanged. This has proven undesirable in
practice because, for example, a single pinch gesture may zoom in and
back out to the original page scale factor, but at a different scroll
offset.
New test case added to scale-and-scroll-body-expected.txt
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
- 4:33 PM Changeset in webkit [116573] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Expose WebPluginContainer of WebPlugin to embedder
https://bugs.webkit.org/show_bug.cgi?id=85916
Reviewed by Darin Fisher.
The browser plugin needs to access its current guest's WebPluginContainer
so that it can replace the guest with another guest WebPlugin when navigating
across processes.
- public/WebPlugin.h:
(WebPlugin):
(WebKit::WebPlugin::container):
- 4:22 PM Changeset in webkit [116572] by
-
- 7 edits in trunk/Tools
Fix overzealous re-opened since blocked by... message
https://bugs.webkit.org/show_bug.cgi?id=86020
Reviewed by Adam Barth.
Changed CreateBug behavior to only re-open a blocked bug if it
was RESOLVED. Also had to update the test infrastructure slightly
to allow for distinct mock commit revisions, so one could point
to a RESOLVED bug for testing while another pointed to an OPEN bug.
Also moved default created mock bug to be 60001 instead of 50004
which already exists as a reference mock bug.
- Scripts/webkitpy/common/checkout/checkout_mock.py:
(MockCheckout.init):
(MockCheckout.commit_info_for_revision):
- Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzilla.create_bug):
- Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
- Scripts/webkitpy/tool/commands/download_unittest.py:
(test_create_rollout_resolved):
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(FailureReasonTest.test_blame_line_for_revision):
- Scripts/webkitpy/tool/steps/createbug.py:
(CreateBug.run):
- 4:10 PM Changeset in webkit [116571] by
-
- 10 edits6 adds in trunk
Use suitable viewport values on XHTML-MP pages.
https://bugs.webkit.org/show_bug.cgi?id=85425
Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.
.:
Add LEGACY_VIEWPORT_ADAPTION use feature to cmake build system,
this feature will enable the use of a suitable viewport size
on legacy XHTML-MP pages.
- Source/cmake/WebKitFeatures.cmake:
Source/WebCore:
Tests: fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html
fast/viewport/viewport-legacy-xhtmlmp-ordering.html
fast/viewport/viewport-legacy-xhtmlmp.html
Use device-width and device-height as viewport size on
XHTML-MP pages if the use feature LEGACY_VIEWPORT_ADAPTION
is set according as the non normative section of
http://www.w3.org/TR/css-device-adapt/
- dom/Document.cpp:
(WebCore::Document::setDocType):
Tools:
Enable LEGACY_VIEWPORT_ADAPTION on Qt port.
- qmake/mkspecs/features/features.prf:
LayoutTests:
Add tests for legacy viewport adaption and skip them
on all ports but the Qt one.
- fast/viewport/viewport-legacy-xhtmlmp-expected.txt: Added.
- fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype-expected.txt: Added.
- fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html: Added.
- fast/viewport/viewport-legacy-xhtmlmp-ordering-expected.txt: Added.
- fast/viewport/viewport-legacy-xhtmlmp-ordering.html: Added.
- fast/viewport/viewport-legacy-xhtmlmp.html: Added.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/gtk/test_expectations.txt:
- 4:06 PM Changeset in webkit [116570] by
-
- 10 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=86025
RTL and vertical text documents do no scroll properly with the new
tiled scrolling model
-and corresponding-
<rdar://problem/11077589>
Reviewed by Dan Bernstein.
Most of the fix here is just to teach the scrolling tree about the
scroll origin.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::setScrollParameters):
- page/scrolling/ScrollingCoordinator.h:
(ScrollParameters):
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::update):
- page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::scrollOrigin):
(ScrollingTreeNode):
- page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::setScrollOrigin):
(WebCore):
- page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::scrollOrigin):
(ScrollingTreeState):
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
(WebCore::ScrollingTreeNodeMac::minimumScrollPosition):
(WebCore::ScrollingTreeNodeMac::maximumScrollPosition):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
Teaching the scrolling tree about the scroll origin revealed this pre-
existing bug. layoutOverflowRect() is not the right rect to use since
it is not writing-mode savvy. unscaledDocumentRect() is the right rect
for the view's bounds.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
- 3:53 PM Changeset in webkit [116569] by
-
- 2 edits in trunk/Source/WebCore
Cleanup SVGElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=86004
Reviewed by Eric Seidel.
Remove unneeded includes. We do not need to check attr in SVGElement::attributeChanged,
lower layers assume it is non-null and we do not call attributeChanged in SVG.
- svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged):
(WebCore::SVGElement::isAnimatableAttribute):
- 3:52 PM Changeset in webkit [116568] by
-
- 1 add in branches/chromium/1132/codereview.settings
adding for easy drovering
- 3:51 PM Changeset in webkit [116567] by
-
- 1 copy in branches/chromium/1132
chromium branch for M20
- 3:50 PM Changeset in webkit [116566] by
-
- 18 edits3 copies in trunk/Source
[Chromium] Move clipboard to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85758
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/Platform:
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::clipboard):
- chromium/public/WebClipboard.h: Added.
(WebKit):
(WebClipboard):
(WebKit::WebClipboard::sequenceNumber):
(WebKit::WebClipboard::isFormatAvailable):
(WebKit::WebClipboard::readAvailableTypes):
(WebKit::WebClipboard::readPlainText):
(WebKit::WebClipboard::readHTML):
(WebKit::WebClipboard::readImage):
(WebKit::WebClipboard::readCustomData):
(WebKit::WebClipboard::writePlainText):
(WebKit::WebClipboard::writeHTML):
(WebKit::WebClipboard::writeURL):
(WebKit::WebClipboard::writeImage):
(WebKit::WebClipboard::writeDataObject):
(WebKit::WebClipboard::~WebClipboard):
- chromium/public/WebDragData.h: Added.
(WebKit):
(WebDragData):
(WebKit::WebDragData::~WebDragData):
(WebKit::WebDragData::WebDragData):
(WebKit::WebDragData::operator=):
(WebKit::WebDragData::isNull):
- chromium/public/WebImage.h: Added.
(WebKit):
(WebImage):
(WebKit::WebImage::~WebImage):
(WebKit::WebImage::WebImage):
(WebKit::WebImage::operator=):
(WebKit::WebImage::getSkBitmap):
(WebKit::WebImage::init):
(WebKit::WebImage::getCGImageRef):
Source/WebKit/chromium:
- WebKit.gyp:
- public/platform/WebClipboard.h:
- public/platform/WebDragData.h:
- public/platform/WebImage.h:
- public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
- src/AssertMatchingEnums.cpp:
- src/DragClientImpl.cpp:
- src/PlatformSupport.cpp:
- src/WebDragData.cpp:
- src/WebImageCG.cpp:
- src/WebImageDecoder.cpp:
- src/WebImageSkia.cpp:
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::copy):
- src/WebViewImpl.cpp:
- 3:50 PM Changeset in webkit [116565] by
-
- 2 edits in trunk/Source/JavaScriptCore
CopiedSpace does not add pinned blocks back to the to-space filter
https://bugs.webkit.org/show_bug.cgi?id=86011
Reviewed by Geoffrey Garen.
After a collection has finished, we go through the blocks in from-space
and move any of them that are pinned into to-space. At the beginning of
collection, we reset the to-space block filter that is used during
conservative scanning and add back the blocks that are filled during the
collection. However, we neglect to add back those blocks that are moved
from from-space to to-space, which can cause the conservative scan to
think that some pinned items are not actually in CopiedSpace.
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::doneCopying): Add the pinned blocks back to the
to-space filter. Also added a comment and assert for future readers that
indicates that it's okay that we don't also add the block to the
to-space block set since it was never removed.
- 3:45 PM Changeset in webkit [116564] by
-
- 1 edit4 adds in trunk/PerformanceTests
add some basic perf-o-matic tests for flexbox
https://bugs.webkit.org/show_bug.cgi?id=86017
Reviewed by Ryosuke Niwa.
Each of these tests take < 3s on my machine.
- Layout/flexbox-column-nowrap.html: Added.
- Layout/flexbox-column-wrap.html: Added.
- Layout/flexbox-row-nowrap.html: Added.
- Layout/flexbox-row-wrap.html: Added.
- 3:13 PM Changeset in webkit [116563] by
-
- 12 edits4 adds in trunk
When creating a new page during a navigation, prime the initial document with the correct referrer policy
https://bugs.webkit.org/show_bug.cgi?id=86001
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/referrer-policy-redirect-link.html
- dom/Document.h:
(WebCore::Document::setReferrerPolicy):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
Tools:
Store the referrer policy in the request, so the network stack can comply with it.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willSendRequest):
LayoutTests:
Skip the test on all but chromium, see https://bugs.webkit.org/show_bug.cgi?id=86000
- http/tests/security/referrer-policy-redirect-link-expected.txt: Added.
- http/tests/security/referrer-policy-redirect-link.html: Added.
- http/tests/security/resources/referrer-policy-postmessage.php: Added.
- http/tests/security/resources/referrer-policy-redirect-link.html: Added.
- platform/efl/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 3:09 PM Changeset in webkit [116562] by
-
- 5 edits in trunk/Source/WebCore
IndexedDB: call abort handler when there are problems committing
https://bugs.webkit.org/show_bug.cgi?id=85841
Patch by Alec Flett <alecflett@chromium.org> on 2012-05-09
Reviewed by Ojan Vafai.
No new tests. Every existing test that calls commit() is testing
the success side of this, and this only throws when there are
LevelDB errors, which is exactly what we're trying to diagnose
with this patch.
- Modules/indexeddb/IDBBackingStore.h:
(Transaction):
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):
- Modules/indexeddb/IDBLevelDBBackingStore.h:
(Transaction):
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::commit):
- 3:06 PM Changeset in webkit [116561] by
-
- 7 edits1 delete in trunk/Source
[Chromium] Remove PlatformSupport::loadPlatformImageResource, call loadResource directly
https://bugs.webkit.org/show_bug.cgi?id=84417
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/graphics/chromium/ImageChromium.cpp:
(WebCore::Image::loadPlatformResource):
- platform/graphics/chromium/ImageChromiumMac.mm: Removed.
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 3:01 PM Changeset in webkit [116560] by
-
- 25 edits in trunk/LayoutTests
Update compositing/RTL tests to fail if the root layer is shifted incorrectly
https://bugs.webkit.org/show_bug.cgi?id=85820
Reviewed by James Robinson.
For the Chromium port, if the root layer was shifted incorrectly, the
non-composited red indicator layers would get drawn outside the root
layers bounds, making it impossible to see if the test was failing.
Also turn off overflow:hidden because compositing/ tests have mock
scrollbars. This makes it much easier to debug these tests locally.
- compositing/rtl/rtl-absolute-expected.png:
- compositing/rtl/rtl-absolute-overflow-expected.png:
- compositing/rtl/rtl-absolute-overflow-expected.txt:
- compositing/rtl/rtl-absolute-overflow-scrolled-expected.png:
- compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-absolute-overflow-scrolled.html:
- compositing/rtl/rtl-absolute-overflow.html:
- compositing/rtl/rtl-absolute.html:
- compositing/rtl/rtl-fixed-expected.png:
- compositing/rtl/rtl-fixed-overflow-expected.png:
- compositing/rtl/rtl-fixed-overflow-expected.txt:
- compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
- compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-fixed-overflow-scrolled.html:
- compositing/rtl/rtl-fixed-overflow.html:
- compositing/rtl/rtl-fixed.html:
- compositing/rtl/rtl-iframe-absolute-overflow-expected.png:
- compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png:
- compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-expected.png:
- compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png:
- compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
- 2:56 PM Changeset in webkit [116559] by
-
- 2 edits in trunk/Tools
Remove CYGWIN=tty from environment variable as its no longer supported
https://bugs.webkit.org/show_bug.cgi?id=85791
The CYGWIN=tty environment variable is no longer supported from Cygwin
version 1.7.10. This fix avoids addition of this environment variable
for Cygwin versions greater than 1.7.9. For supporting older versions
i.e. 1.7.9 or older, the script takes care of retaining the environment
variable.
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-09
Reviewed by Adam Roben.
- Scripts/webkitdirs.pm:
(setupAppleWinEnv):
- 2:27 PM Changeset in webkit [116558] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] remove the obsolete WebFrame::referrerPolicy method
https://bugs.webkit.org/show_bug.cgi?id=86003
Reviewed by Adam Barth.
- public/WebFrame.h:
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
(WebFrameImpl):
- 2:20 PM Changeset in webkit [116557] by
-
- 5 edits in trunk/Source/WebCore
Remove some isSVGFoo methods
https://bugs.webkit.org/show_bug.cgi?id=86009
Patch by Rob Buis <rbuis@rim.com> on 2012-05-09
Reviewed by Eric Seidel.
These are not used at the moment and were probably just copy and pasted from
isSVGFoo methods in RenderObject.h.
- rendering/RenderObject.h:
- rendering/svg/RenderSVGEllipse.h:
(RenderSVGEllipse):
- rendering/svg/RenderSVGRect.h:
(RenderSVGRect):
- rendering/svg/RenderSVGShape.h:
- 2:17 PM Changeset in webkit [116556] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Check whether an active document loader exists before accessing it
https://bugs.webkit.org/show_bug.cgi?id=85892
Reviewed by Eric Seidel.
Although FrameLoader::loadInSameDocument which invokes this
method does not have a provisional document loader, we're seeing crashes
where the FrameLoader is in provisional state, and thus
activeDocumentLoader returns 0. Lacking any understanding of how this
can happen, we do this check here to avoid crashing.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
- 2:06 PM Changeset in webkit [116555] by
-
- 15 edits in branches/dfgopt/Source/JavaScriptCore
DFG variable capture analysis should work even if the variables arose through inlining
https://bugs.webkit.org/show_bug.cgi?id=85945
Reviewed by Oliver Hunt.
This just changes how the DFG queries whether a variable is captured. It does not
change any user-visible behavior.
As part of this change, I further solidified the policy that the CFA behaves in an
undefined way for captured locals and queries about their values will not yield
reliable results. This will likely be changed in the future, but for now it makes
sense.
One fun part about this change is that it recognizes that the same variable may
be both captured and not, at the same time, because their live interval spans
inlining boundaries. This only happens in the case of arguments to functions that
capture their arguments, and this change treats them with just the right touch of
conservatism: they will be treated as if captured by the caller as well as the
callee.
Finally, this also adds captured variable reasoning to the InlineCallFrame, which
I thought might be useful for later tooling.
This is perf-neutral, since it does it does not make the DFG take advantage of this
new functionality in any way. In particular, it is still the case that the DFG will
not inline functions that use arguments reflectively or that create activations.
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::needsActivation):
(JSC::CodeBlock::argumentIsCaptured):
(JSC::CodeBlock::localIsCaptured):
(JSC::CodeBlock::isCaptured):
- bytecode/CodeOrigin.h:
(InlineCallFrame):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::merge):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::newVariableAccessData):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::fixVariableAccessPredictions):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGCFGSimplificationPhase.cpp:
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
- dfg/DFGCommon.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::nameOfVariableAccessData):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::needsActivation):
(JSC::DFG::Graph::usesArguments):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsCaptured):
(VariableAccessData):
(JSC::DFG::VariableAccessData::isCaptured):
- 1:27 PM Changeset in webkit [116554] by
-
- 7 edits in trunk/Source
[chromium] Add impl-thread support for fill-mode and direction css animation properties
https://bugs.webkit.org/show_bug.cgi?id=77662
Patch by Ian Vollick <vollick@chromium.org> on 2012-05-09
Reviewed by James Robinson.
Source/WebCore:
Adds support for accelerating css animations with -webkit-animation-fill-mode,
and -webkit-animation-direction properties.
Tested in:
CCActiveAnimationTest.TrimTimeAlternating
CCLayerAnimationControllerTest.createReversedAnimation
CCLayerAnimationControllerTest.createAlternatingAnimation
CCLayerAnimationControllerTest.createReversedAlternatingAnimation
- platform/graphics/chromium/cc/CCActiveAnimation.cpp:
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::trimTimeToCurrentIteration):
(WebCore::CCActiveAnimation::cloneForImplThread):
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(CCActiveAnimation):
(WebCore::CCActiveAnimation::alternatesDirection):
(WebCore::CCActiveAnimation::setAlternatesDirection):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
Source/WebKit/chromium:
- tests/CCActiveAnimationTest.cpp:
(WebCore::TEST):
(WebCore):
- tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):
- 1:25 PM Changeset in webkit [116553] by
-
- 2 edits in trunk/LayoutTests
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591
Reviewed by Philippe Normand.
Remove all the test expectations for tests that seem to consistently
pass on the Gtk bots but are expected to crash. Any tests that backfire
will have their bug entries updated or closed otherwise.
- platform/gtk/test_expectations.txt:
- 12:59 PM Changeset in webkit [116552] by
-
- 4 edits in trunk/Tools
nrwt: --skip-failing-tests should also skip flaky tests
https://bugs.webkit.org/show_bug.cgi?id=85941
Reviewed by Ojan Vafai.
This changes --skip-failing-tests so that we skip tests that
are believed to pass sometimes as well as tests that are
believed to always fail.
In addition, in testing this I discovered that we had lousy
test coverage of the details of retrying test failures and
--clobber-old-results, so I wrote some more tests.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.prepare_lists_and_print_output):
- Scripts/webkitpy/layout_tests/port/test.py:
(unit_test_list):
(TestPort.init):
(TestDriver.run_test):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_skip_failing_tests):
(MainTest.test_retrying_and_flaky_tests):
- 12:48 PM Changeset in webkit [116551] by
-
- 3 edits2 adds in trunk
Crash from removal of a line break object
https://bugs.webkit.org/show_bug.cgi?id=85997
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-05-09
Reviewed by David Hyatt.
Source/WebCore:
Regression from r115343. That replaced a call to setNeedsLayout()
with a separate call that used a different bit during linebox
invalidation after renderer child removal. There are special cases
where layout isn't marked on parent nodes just from the removal, so
line dirtying needs to explicitly mark ancestors for layout.
- rendering/RenderObject.h:
(WebCore::RenderObject::setAncestorLineBoxDirty):
LayoutTests:
Test case to exercise crashing condition in bug 85997.
- fast/block/line-layout/line-break-removal-near-textarea-crash-expected.txt: Added
- fast/block/line-layout/line-break-removal-near-textarea-crash.html: Added
- 12:37 PM Changeset in webkit [116550] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] REGRESSION(r113678):After this change fast/text/text-stroke-width-cairo-dos.html makes the next test crash
https://bugs.webkit.org/show_bug.cgi?id=83582
Unreviewed gardening : I don't observe crashes anymore.
- platform/qt-5.0-wk2/Skipped:
- 12:36 PM Changeset in webkit [116549] by
-
- 13 edits1 delete in trunk/Source/WebCore
Fix performance regression for floats caused by LayoutUnit change
https://bugs.webkit.org/show_bug.cgi?id=85834
Reviewed by Ojan Vafai.
Refactoring FractionalLayout types to alleviate performance issues. Explicitly
inlining constructor and operator functions in FractionalLayoutUnit, as well as
pixelSnappedIntSize and pixelSnappedIntRect (particularly hot code paths). Also
further simplifying round and ceil functions when sub-pixel layout is not enabled.
pixelSnappedIntSize was the only function defined in FractionalLayoutSize.cpp,
so it is removed.
No new tests. No change in functionality.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::toInt):
(WebCore::FractionalLayoutUnit::toFloat):
(WebCore::FractionalLayoutUnit::toDouble):
(WebCore::FractionalLayoutUnit::toUnsigned):
(WebCore::FractionalLayoutUnit::operator int):
(WebCore::FractionalLayoutUnit::operator unsigned):
(WebCore::FractionalLayoutUnit::operator float):
(WebCore::FractionalLayoutUnit::operator double):
(WebCore::FractionalLayoutUnit::operator bool):
(WebCore::FractionalLayoutUnit::ceil):
(WebCore::FractionalLayoutUnit::round):
- platform/graphics/FractionalLayoutRect.cpp:
(WebCore):
- platform/graphics/FractionalLayoutRect.h:
(WebCore::FractionalLayoutRect::pixelSnappedSize):
(WebCore::pixelSnappedIntRect):
(WebCore):
- platform/graphics/FractionalLayoutSize.cpp: Removed.
- platform/graphics/FractionalLayoutSize.h:
(WebCore):
- rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntSize):
(WebCore):
- 12:01 PM Changeset in webkit [116548] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 11:41 AM BuildingGtk edited by
- (diff)
- 11:40 AM Changeset in webkit [116547] by
-
- 10 edits in trunk
[EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()
https://bugs.webkit.org/show_bug.cgi?id=84435
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-09
Reviewed by Antonio Gomes.
Source/WebKit/efl:
Emit a "icon,changed" signal on the frame when its favion changed.
Clarify that the "icon,loaded" signal is only emitted for the main
frame.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveIcon):
(WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):
- ewk/ewk_frame.cpp:
(ewk_frame_icon_changed):
- ewk/ewk_frame.h:
- ewk/ewk_private.h:
Tools:
Catch the "icon,changed" signal on the frames in EFL's DumpRenderTree
to support LayoutTestController's dumpIconChanges().
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameIconChanged):
(DumpRenderTreeChrome::onFrameCreated):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
LayoutTests:
Unskip the test checking for DumpRenderTree's support for
LayoutTestController's dumpIconChanges() in EFL port.
- platform/efl/Skipped:
- 11:30 AM Changeset in webkit [116546] by
-
- 2 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0/fast/text/international/text-spliced-font-expected.png: Added.
- platform/qt-5.0/fast/text/international/text-spliced-font-expected.txt: Added.
- platform/qt/Skipped:
- 11:28 AM Changeset in webkit [116545] by
-
- 3 edits2 adds in trunk
Crash in ReplaceSelectionCommand::performTrivialReplace
https://bugs.webkit.org/show_bug.cgi?id=85943
Reviewed by Ryosuke Niwa.
Source/WebCore:
RefPtr nodeAfterInsertionPos to guard against mutation events.
Test: editing/inserting/insert-html-crash.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::performTrivialReplace):
LayoutTests:
- editing/inserting/insert-html-crash-expected.txt: Added.
- editing/inserting/insert-html-crash.html: Added.
- 10:58 AM Changeset in webkit [116544] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Exposes OrientationChangeEvent.
https://bugs.webkit.org/show_bug.cgi?id=85976
Reviewed by Adam Barth.
This is used by the android port, we need to expose the existing
WebCore API.
- public/WebFrame.h:
(WebFrame):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::sendOrientationChangeEvent):
(WebKit):
- src/WebFrameImpl.h:
(WebFrameImpl):
- 10:57 AM Changeset in webkit [116543] by
-
- 3 edits4 adds in trunk
Hit testing is incorrect in some cases with perspective transforms
https://bugs.webkit.org/show_bug.cgi?id=79136
Reviewed by Simon Fraser.
Source/WebCore:
Tests: transforms/3d/hit-testing/coplanar-with-camera.html
transforms/3d/hit-testing/perspective-clipped.html
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::projectPoint): Fix a
divide-by-zero error so that values do not become Inf or Nan. Also
fix an overflow error by using a large, but not-too-large constant
to represent infinity.
(WebCore::TransformationMatrix::projectQuad): Fix an error where
incorrect quads were being returned. Incorrect quads can occur
when projectPoint clamped==true after returning.
LayoutTests:
- transforms/3d/hit-testing/coplanar-with-camera-expected.txt: Added.
- transforms/3d/hit-testing/coplanar-with-camera.html: Added.
- transforms/3d/hit-testing/perspective-clipped-expected.txt: Added.
- transforms/3d/hit-testing/perspective-clipped.html: Added.
- 10:47 AM Changeset in webkit [116542] by
-
- 3 edits in trunk/LayoutTests
Textarea-placeholder-wrapping.html may fail because of scrollbars
https://bugs.webkit.org/show_bug.cgi?id=85989
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09
Reviewed by Ryosuke Niwa.
Increasing rows to avoid scrollbar single pixel differences
to cause failures of this test.
- fast/forms/textarea-placeholder-wrapping-expected.html:
- fast/forms/textarea-placeholder-wrapping.html:
- 10:23 AM Changeset in webkit [116541] by
-
- 4 edits in trunk/Source/WebKit/gtk
[GTK] Missing WebPreferences for media playback requiring user gestures and inline playback
https://bugs.webkit.org/show_bug.cgi?id=85194
Patch by Simon Pena <Simon Pena> on 2012-05-09
Reviewed by Martin Robinson.
Expose WebPreferences for media playback requires user gesture and
media playback allows inline to GTK side.
This adds two properties (mediaPlaybackRequiresUserGesture and
mediaPlaybackAllowsInline) to GTK WebKit WebSettings, and connects
them to the WebKit WebView, so clients can programmatically modify
them.
- webkit/webkitwebsettings.cpp: install new properties and update
setter and getter
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h: add media playback related
properties
- webkit/webkitwebview.cpp: connect newly added properties
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
- 10:06 AM Changeset in webkit [116540] by
-
- 2 edits in trunk/Source/WebCore
Simplify CSSParser::parseSimpleLengthValue()
https://bugs.webkit.org/show_bug.cgi?id=85910
Reviewed by Alexis Menard.
Various small improvements to this function, mainly:
- Move the check if the property ID accepts a simple length as early as possible;
- Remove the check for the characters{8,16} pointers since they'll be valid (we ASSERT that);
- Use a template to avoid duplicate code for 8 and 16 bit characters.
- css/CSSParser.cpp:
(WebCore):
(WebCore::parseSimpleLength):
(WebCore::parseSimpleLengthValue):
- 10:02 AM Changeset in webkit [116539] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Support multiple buffered time ranges
https://bugs.webkit.org/show_bug.cgi?id=85926
Reviewed by Eric Carlson.
Preserve existing rendering of a single rect even in the presence of multiple buffered regions.
No new tests as this change has no functional effects.
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaSlider):
- 10:01 AM Changeset in webkit [116538] by
-
- 5 edits in trunk/Source
Early-out and avoid any copying when possible for Region operations
https://bugs.webkit.org/show_bug.cgi?id=85260
Reviewed by Anders Carlsson.
Source/WebCore:
For an empty region, any intersection or subtraction will not modify
the region, so we can simply return instead of creating a new Shape
and replacing the current empty Shape.
When a region is united with a region it contains, the orignal
containing region is the result. So, if A.unite(B) and A.contains(B)
then A does not need to change at all and we can return without making
a copy of A's shape. When A is a rect, we can do this test even more
simply.
We also remove redundant checks from trySimpleOperation() methods, where
the test is already done in the Region calling site.
This change improves the performance of the Region overlap testing for
composited layers, and allows us to avoid unnecessary copies of the
Region during unite. With a layout test (attached to bug #81087), that
creates a Region from the union of 225 composited layers, as well as
600 overlapping layers above them, this change decreases the running
time of the test by 3.2% by avoiding a copy of the entire Region for
each insertion that does not change the resulting Region.
Unit tests: RegionTest.unite
- platform/graphics/Region.cpp:
(WebCore::Region::Shape::UnionOperation::trySimpleOperation):
(WebCore::Region::Shape::IntersectOperation::trySimpleOperation):
(WebCore::Region::Shape::SubtractOperation::trySimpleOperation):
(WebCore::Region::intersect):
(WebCore::Region::unite):
(WebCore::Region::subtract):
- platform/graphics/Region.h:
(WebCore::Region::isRect):
(WebCore::Region::Shape::isRect):
Source/WebKit/chromium:
- tests/RegionTest.cpp:
(WebCore::TEST):
(WebCore):
- 9:32 AM Changeset in webkit [116537] by
-
- 2 edits in trunk/Tools
webkit-patch upload Fails Behind Load-balancing Proxies
https://bugs.webkit.org/show_bug.cgi?id=85980
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09
Reviewed by Adam Barth.
Unchecking the login restriction to IP to allow the tool
to function behind load-balancing proxies that use multiple
outgoing IPs.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.authenticate):
- 9:31 AM Changeset in webkit [116536] by
-
- 9 edits in trunk
[BlackBerry] Enable PAGE_POPUP in make file, and implement required methods
https://bugs.webkit.org/show_bug.cgi?id=85907
.:
Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-09
Reviewed by Rob Buis.
Enable PAGE_POPUP option in make files.
Internal reviewed by Yong Li.
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebKit/blackberry:
Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-09
Reviewed by Rob Buis.
Internal reviewed by Yong Li.
Enable PAGE_POPUP so we can use WebCore::PagePopup and WebCore::PagePopupClient interface.
Implement virtual methods in WebCore::ChromeClientBlackBerry that required for the
implementation and add methods in WebKit::WebPage that needed for PagePopupClient.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::initPopupWebView):
(WebKit):
(BlackBerry::WebKit::WebPage::popupOpened):
(BlackBerry::WebKit::WebPage::popupClosed):
(BlackBerry::WebKit::WebPage::hasOpenedPopup):
(BlackBerry::WebKit::WebPage::popup):
(BlackBerry::WebKit::WebPagePrivate::setParentPopup):
- Api/WebPage.h:
(WebCore):
- Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::hasOpenedPopup):
(WebCore::ChromeClientBlackBerry::openPagePopup):
(WebCore):
(WebCore::ChromeClientBlackBerry::closePagePopup):
- WebCoreSupport/ChromeClientBlackBerry.h:
(WebCore):
(ChromeClientBlackBerry):
- 9:21 AM Changeset in webkit [116535] by
-
- 2 edits in trunk/LayoutTests
[EFL] shared-stylesheet-mutation tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=85901
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-09
Reviewed by Antti Koivisto.
This test is flaky on EFL because the timeout for applying
the style is too short for a Debug build.
- http/tests/css/resources/shared-stylesheet-mutation.js:
(executeTests):
- 9:08 AM Changeset in webkit [116534] by
-
- 4 edits1 copy in trunk
[GTK] Split WebKit2 Makefile moving source code listings to GNUmakefile.list.am
https://bugs.webkit.org/show_bug.cgi?id=85985
Reviewed by Gustavo Noronha Silva.
.:
- GNUmakefile.am:
Source/WebKit2:
- GNUmakefile.am:
- GNUmakefile.list.am: Copied from Source/WebKit2/GNUmakefile.am.
- 9:05 AM Changeset in webkit [116533] by
-
- 6 edits in trunk
[GTK] Use independent version numbers for public libraries
https://bugs.webkit.org/show_bug.cgi?id=85984
Reviewed by Gustavo Noronha Silva.
.:
- configure.ac: Define LIBJAVASCRIPTCOREGTK_VERSION and
LIBWEBKIT2GTK_VERSION using the same version as
LIBWEBKITGTK_VERSION for backwards compatibility.
Source/JavaScriptCore:
- GNUmakefile.am: Use LIBJAVASCRIPTCOREGTK_VERSION for library
version.
Source/WebKit2:
- GNUmakefile.am: Use LIBWEBKIT2GTK_VERSION for library version.
- 9:02 AM Changeset in webkit [116532] by
-
- 2 edits in trunk/Source/JavaScriptCore
[GTK] Do not install JavaScriptCore platform-specific headers
https://bugs.webkit.org/show_bug.cgi?id=85983
Reviewed by Gustavo Noronha Silva.
JavaScriptCore.h includes JSStringRefCF.h unconditionally. It was
renamed to JavaScript.h in r29234 and it still exists for
compatibility with mac and windows users.
- GNUmakefile.list.am: Remove JavaScriptCore.h, JSStringRefCF.h
and JSStringRefBSTR.h from the sources and headers list.
- 8:57 AM Changeset in webkit [116531] by
-
- 2 edits in trunk/LayoutTests
[EFL][DRT] Gardening failures and crashes
https://bugs.webkit.org/show_bug.cgi?id=85996
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09
- platform/efl/test_expectations.txt:
- 8:55 AM Changeset in webkit [116530] by
-
- 5 edits2 adds in trunk
MediaStream API: SessionDescription::addCandidate should not crash for malformed input
https://bugs.webkit.org/show_bug.cgi?id=85988
Reviewed by Adam Barth.
Source/WebCore:
Sending null would crash the browser. Added safeguards in both the bindings and the native code.
Test: fast/mediastream/SessionDescription.html
- Modules/mediastream/SessionDescription.cpp:
(WebCore::SessionDescription::addCandidate):
- Modules/mediastream/SessionDescription.h:
(SessionDescription):
- Modules/mediastream/SessionDescription.idl:
LayoutTests:
- fast/mediastream/SessionDescription-expected.txt: Added.
- fast/mediastream/SessionDescription.html: Added.
- 8:49 AM Changeset in webkit [116529] by
-
- 5 edits in trunk/Source
MediaStream API: Adding the possibility of port specific information in MediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=85794
Reviewed by Adam Barth.
To facilitate for ports I have added an ExtraData field that can be used for whatever purpose is needed.
Source/Platform:
- chromium/public/WebMediaStreamDescriptor.h:
(ExtraData):
(WebKit::WebMediaStreamDescriptor::ExtraData::~ExtraData):
(WebMediaStreamDescriptor):
Source/WebCore:
No behavioral changes.
- platform/chromium/support/WebMediaStreamDescriptor.cpp:
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit):
(WebKit::WebMediaStreamDescriptor::extraData):
(WebKit::WebMediaStreamDescriptor::setExtraData):
- platform/mediastream/MediaStreamDescriptor.h:
(ExtraData):
(WebCore::MediaStreamDescriptor::ExtraData::~ExtraData):
(MediaStreamDescriptor):
(WebCore::MediaStreamDescriptor::extraData):
(WebCore::MediaStreamDescriptor::setExtraData):
- 8:45 AM Changeset in webkit [116528] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] MediaStream API: Fixing a memory leak in WebUserMediaRequest
https://bugs.webkit.org/show_bug.cgi?id=85992
Reviewed by Adam Barth.
- src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::assign):
- 8:37 AM Changeset in webkit [116527] by
-
- 4 edits2 adds in trunk
Crash in WebCore::RenderBoxModelObject::paddingLeft
https://bugs.webkit.org/show_bug.cgi?id=83889
Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-09
Reviewed by Abhishek Arya.
Source/WebCore:
RenderScrollbar creates RenderScrollbarPart without any parent
renderers. However, if the scrollbar has percent padding styles,
non-null parent renderer is required. So after creating/destroying
RenderScrollbarPart instances, set owningRenderer(creating)/0
(destroying) as its parent renderer.
Test: scrollbars/scrollbar-percent-padding-crash.html
scrollbars/scrollbar-percent-padding-crash-expected.txt
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarPart):
Added setParent after creating/destroying RenderScrollbarPart.
- rendering/RenderScrollbarPart.cpp:
Made RenderScollbar friend, because setParent is protected and
RenderScrollbar is not inherited from class RenderObject.
LayoutTests:
As just invoking layoutTestController.display() invokes scrollbar's
WebCore::RenderScrollbarPart::paintIntoRect(), adding display() after
invoking layoutTestController.dumpAsText().
- scrollbars/scrollbar-percent-padding-crash.html: Added.
- scrollbars/scrollbar-percent-padding-crash-expected.txt: Added.
- 8:28 AM Changeset in webkit [116526] by
-
- 3 edits in trunk/Tools
[Chromium-android] Add unit test for Android layout test script (chromium_android.py)
https://bugs.webkit.org/show_bug.cgi?id=80852
Patch by Hao Zheng <zhenghao@chromium.org> on 2012-05-09
Reviewed by Adam Barth.
Add some tests to ensure that chromium android port works to some
extent. Some methods is hard to test, as they rely on the actual
behavior on device, e.g. pushing files to device.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.get_last_stacktrace): Check if dir exists.
- Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest):
(ChromiumAndroidPortTest.test_attributes):
(ChromiumAndroidPortTest.test_get_last_stacktrace):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_dir):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_file):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_non_empty):
(ChromiumAndroidDriverTest):
(ChromiumAndroidDriverTest.setUp):
(ChromiumAndroidDriverTest.test_get_drt_return_value):
(ChromiumAndroidDriverTest.test_has_crash_hint):
(ChromiumAndroidDriverTest.test_read_prompt):
(ChromiumAndroidDriverTest.test_test_shell_command):
(ChromiumAndroidDriverTest.test_write_command_and_read_line):
- 8:23 AM Changeset in webkit [116525] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] don't use soup_session_pause_message in webkitdownload
https://bugs.webkit.org/show_bug.cgi?id=85931
Reviewed by Martin Robinson.
- webkit/webkitdownload.cpp:
(webkit_download_new_with_handle):
(webkit_download_start):
- 8:14 AM Changeset in webkit [116524] by
-
- 2 edits in trunk/LayoutTests
Skip failing test http/tests/loading/post-in-iframe-with-back-navigation.html.
Not reviewed.
- platform/mac/Skipped:
- 7:40 AM Changeset in webkit [116523] by
-
- 2 edits in trunk/LayoutTests
Test from bug 34875 should specify font-size
https://bugs.webkit.org/show_bug.cgi?id=85913
Not reviewed.
Skip fast/block/positioning/offsetLeft-offsetTop-multicolumn.html
- platform/mac/Skipped:
- 6:19 AM Changeset in webkit [116522] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening a timeout failure
https://bugs.webkit.org/show_bug.cgi?id=85979
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09
- platform/efl/test_expectations.txt: Adding font-face-download-error.html.
- 5:53 AM Changeset in webkit [116521] by
-
- 8 edits2 adds in trunk
ShadowRoot needs applyAuthorStyles
https://bugs.webkit.org/show_bug.cgi?id=78472
Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-09
Reviewed by Hajime Morita.
Source/WebCore:
Implemented applyAuthorStyles attribute defined in the following spec:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-root-attributes
Since applyAuthorSheets attribute has been already implemented,
renamed all applyAuthorSheets to applyAuthorStyles and
added applyAuthorStyles to ShadowRoot.idl.
Currently, changing dynamically applyAuthorStyles doesn't work. I will fix this isse in bugs:84215: https://bugs.webkit.org/show_bug.cgi?id=84251
Test: fast/dom/shadow/shadow-root-applyAuthorStyles.html
fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::applyAuthorStyles):
(WebCore::ShadowRoot::setApplyAuthorStyles):
- dom/ShadowRoot.h:
- dom/TreeScope.cpp:
(WebCore::TreeScope::applyAuthorStyles):
- dom/TreeScope.h:
(TreeScope):
Changed all applyAuthorSheets to applyAuthorSytles.
(ShadowRoot):
- dom/ShadowRoot.idl:
Added a new attribute, boolean applyAuthorStyles.
LayoutTests:
- fast/dom/shadow/shadow-root-applyAuthorStyles.html:
- fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html:
Tested four cases:
case 1: applyAuthorStyles is false,
case 2: applyAuthorStyles is true with <script>..</script>,
case 3: applyAuthorStyles is true with inline script declaration, and
case 4: applyAuthorStyles is true with important UA property.
The case 1, 2 and 3 specify "span { ... }" with author styles and
verify rendering results.
The case 4 specifies '<input type="file" />' with an author style,
text-align: end, and verify rendering result.
- 5:39 AM Changeset in webkit [116520] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Tap-to-zoom zooms to wrong area.
https://bugs.webkit.org/show_bug.cgi?id=85982
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.
Fix computation and take more care when to use CSS scale and when to use Item scale.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
- 5:34 AM Changeset in webkit [116519] by
-
- 2 edits in trunk/LayoutTests
[EFL] fast/overflow/scroll-div-hide-show.html testcase does not pass
https://bugs.webkit.org/show_bug.cgi?id=85960
Unreviewed. Gardening.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-09
- platform/efl/Skipped: Skipping fast/overflow/scroll-div-hide-show.html.
- 5:22 AM Changeset in webkit [116518] by
-
- 2 edits in trunk/Tools
[Qt] ORWT fails with Qt 5 and WK2.
https://bugs.webkit.org/show_bug.cgi?id=85968
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-09
Reviewed by Csaba Osztrogonác.
The Qt5 binary does not have a -style argument, so avoid using it.
- Scripts/old-run-webkit-tests:
- 5:19 AM Changeset in webkit [116517] by
-
- 1 edit44 adds in trunk/LayoutTests
[EFL][DRT] Add baselines for new CSS cases after r116438
https://bugs.webkit.org/show_bug.cgi?id=85967
Unreviewed, add EFL baselines for new tests after r116438.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-09
- platform/efl/css2.1/20110323/first-letter-000-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-000-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-001-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-001-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-001-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-002-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-003-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-004-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-005-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-006-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-007-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-quote-001-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-quote-002-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-quote-003-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-quote-004-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-quote-005-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-quote-006-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
- platform/efl/fast/css/first-letter-nested-positioned-expected.png: Added.
- platform/efl/fast/css/first-letter-nested-positioned-expected.txt: Added.
- platform/efl/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
- platform/efl/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
- 5:11 AM Changeset in webkit [116516] by
-
- 7 edits in trunk/Source/WebKit2
[Qt][WK2] Define clear split between QtWebPageLoadClient and QQuickWebViewPrivate for loading tasks.
https://bugs.webkit.org/show_bug.cgi?id=84527#c3
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-09
Reviewed by Simon Hausmann.
Moving loading related code and signal emission from QtWebPageLoadClient to QQuickWebViewPrivate.
It puts the loading code that implements an API right where the API is defined, including
signal emission as well as translation of WebPageProxy internals to public Qt API with correct types.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::provisionalLoadDidStart):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didSameDocumentNavigation):
(QQuickWebViewPrivate::titleDidChange):
(QQuickWebViewPrivate::loadProgressDidChange):
(QQuickWebViewPrivate::backForwardListDidChange):
(QQuickWebViewPrivate::loadDidFail):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebView::loadProgress):
- UIProcess/API/qt/qquickwebview_p_p.h:
(WebKit):
(QQuickWebViewPrivate):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::loadProgress):
(QQuickWebViewFlickablePrivate):
- UIProcess/qt/QtWebError.cpp:
(WebKit::QtWebError::isCancellation):
(WebKit):
- UIProcess/qt/QtWebError.h:
- UIProcess/qt/QtWebPageLoadClient.cpp:
(WebKit::QtWebPageLoadClient::QtWebPageLoadClient):
(WebKit):
(WebKit::QtWebPageLoadClient::didStartProvisionalLoad):
(WebKit::QtWebPageLoadClient::didCommitLoad):
(WebKit::QtWebPageLoadClient::didSameDocumentNavigation):
(WebKit::QtWebPageLoadClient::didReceiveTitle):
(WebKit::QtWebPageLoadClient::didChangeProgress):
(WebKit::QtWebPageLoadClient::didChangeBackForwardList):
(WebKit::QtWebPageLoadClient::dispatchLoadFailed):
(WebKit::QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::QtWebPageLoadClient::didFailLoadWithErrorForFrame):
(WebKit::QtWebPageLoadClient::didStartProgress):
(WebKit::QtWebPageLoadClient::didFinishProgress):
- UIProcess/qt/QtWebPageLoadClient.h:
(WebKit):
(QtWebPageLoadClient):
- 4:38 AM Changeset in webkit [116515] by
-
- 1 edit56 adds in trunk/LayoutTests
[Qt] Unreviewed gardening, add platform specific expected files for new tests.
- platform/qt/css2.1/20110323/first-letter-000-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-000-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-001-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-001-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-001-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-002-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-003-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-004-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-005-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-006-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-007-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-quote-001-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-quote-002-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-quote-003-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-quote-004-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-quote-005-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-quote-006-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
- platform/qt/fast/block/float/avoiding-float-centered-expected.png: Added.
- platform/qt/fast/block/float/avoiding-float-centered-expected.txt: Added.
- platform/qt/fast/css/first-letter-nested-positioned-expected.png: Added.
- platform/qt/fast/css/first-letter-nested-positioned-expected.txt: Added.
- platform/qt/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
- platform/qt/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
- platform/qt/fast/html/details-marker-style-expected.png: Added.
- platform/qt/fast/html/details-marker-style-expected.txt: Added.
- platform/qt/fast/images/png-suite/test-expected.txt: Added.
- platform/qt/fast/text/international/text-spliced-font-expected.png: Added.
- platform/qt/fast/text/international/text-spliced-font-expected.txt: Added.
- platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
- platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
- platform/qt/svg/custom/path-zero-strokewidth-expected.png: Added.
- platform/qt/svg/custom/path-zero-strokewidth-expected.txt: Added.
- 4:13 AM Changeset in webkit [116514] by
-
- 1 edit1 add in trunk/LayoutTests
[Qt] Unreviewed gardening, add a platform specific expected file for a passing test.
- platform/qt-5.0-wk2/fast/repaint/focus-ring-expected.txt: Added.
- 4:10 AM Changeset in webkit [116513] by
-
- 4 edits2 adds in trunk
[Chromium][Forms] HTMLOptionsCollection doesn't have indexed properties on property enumeration
https://bugs.webkit.org/show_bug.cgi?id=85937
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-05-09
Reviewed by Kentaro Hara.
Source/WebCore:
This patch adds numeric indices to properties in enumeration to HTMLOptionsCollection V8 binding
to changes Objects.keys in ECMAScript5 and for-in statement behavior for compatibility with
Firefox 12, IE9, Opera 11, and Safari 5.
Test: fast/forms/select/options-indexed-properties.html
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementationIndexer): Set $hasEnumerator true for interface HTMLOptionsCollection
LayoutTests:
- fast/forms/select/options-indexed-properties-expected.txt: Added.
- fast/forms/select/options-indexed-properties.html: Added.
- platform/chromium/inspector/console/console-format-collections-expected.txt: Changed for HTMLOptionCollection printed output
- 4:02 AM Changeset in webkit [116512] by
-
- 2 edits in trunk/LayoutTests
[EFL] http/tests/loading/post-in-iframe-with-back-navigation.html fails
https://bugs.webkit.org/show_bug.cgi?id=85974
Unreviewed EFL gardening.
Move http/tests/loading/post-in-iframe-with-back-navigation.html to
test_expectations.txt. This test was added in r116473 but fails on all
the bots.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-09
- platform/efl/test_expectations.txt:
- 3:49 AM Changeset in webkit [116511] by
-
- 6 edits2 adds in trunk/LayoutTests
MediaStream API: Adding a test for constructed from JS MediaStreams
https://bugs.webkit.org/show_bug.cgi?id=85883
Reviewed by Kent Tamura.
Also moved shouldNotThrow to js-test-pre, and removed it from all mediastream tests.
- fast/js/resources/js-test-pre.js:
(shouldNotThrow):
- fast/mediastream/MediaStreamConstructor-expected.txt: Added.
- fast/mediastream/MediaStreamConstructor.html: Added.
- fast/mediastream/peerconnection-argument-types-expected.txt:
- fast/mediastream/peerconnection-iceoptions.html:
- fast/mediastream/script-tests/argument-types.js:
- fast/mediastream/script-tests/peerconnection-argument-types.js:
- 3:01 AM Changeset in webkit [116510] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update for media-stream tests
https://bugs.webkit.org/show_bug.cgi?id=85952
- platform/chromium/test_expectations.txt:
- 2:37 AM Changeset in webkit [116509] by
-
- 2 edits1 delete in trunk/LayoutTests
[Qt] Gardening. Skip a failing test, remove an unnecessary platform specific expected file.
https://bugs.webkit.org/show_bug.cgi?id=85969
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-09
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- platform/qt/fast/forms/form-collection-radio-node-list-expected.txt: Removed after r116491.
- 2:26 AM Changeset in webkit [116508] by
-
- 11 edits7 adds in trunk
Position should be able to have ShadowRoot as a container.
https://bugs.webkit.org/show_bug.cgi?id=82021
Reviewed by Ryosuke Niwa.
Source/WebCore:
Since Position could not take a shadow root as a container node, pointing the direct children
of a shadow root was difficult.
This patch makes it enabled, and fixes a lot of crashes caused by that limitation.
Also, we confirm that ShadowRoot is not exposed to JavaScript layer.
Currently this change is only enabled if shadow dom flag is enabled, since we cannot
prove this change does not destroy the existing behavior. However, this change is really required
to fix other editing bugs in Shadow DOM. A bunch of patches and tests will be added to
fix other editing bugs and they will check this patch does not break editing.
We will also add a fuzzer to check the stability of editing in Shadow DOM later, and it will
also help to confirm the patch will not break the editing.
Tests: editing/shadow/doubleclick-on-meter-in-shadow-crash.html
editing/shadow/rightclick-on-meter-in-shadow-crash.html
editing/shadow/shadow-selection-not-exported.html
- dom/Position.cpp:
(WebCore::Position::Position):
(WebCore::Position::containerNode):
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):
(WebCore::Position::findParent):
- dom/Position.h:
(WebCore):
(WebCore::positionInParentBeforeNode):
(WebCore::positionInParentAfterNode):
LayoutTests:
Skipped non-chromium port since SHADOW_DOM flag is not enabled in those platforms.
We will add bunch of tests for editing in Shadow DOM into editing/shadow later,
so I added the whole directory name to the skipped list.
- editing/shadow/doubleclick-on-meter-in-shadow-crash-expected.txt: Added.
- editing/shadow/doubleclick-on-meter-in-shadow-crash.html: Added.
- editing/shadow/rightclick-on-meter-in-shadow-crash-expected.txt: Added.
- editing/shadow/rightclick-on-meter-in-shadow-crash.html: Added.
- editing/shadow/shadow-selection-not-exported-expected.txt: Added.
- editing/shadow/shadow-selection-not-exported.html: Added.
- platform/efl/Skipped:
- platform/gtk/test_expectations.txt:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 2:07 AM Changeset in webkit [116507] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Build fix when using libpng version != 1.2
https://bugs.webkit.org/show_bug.cgi?id=85614
Reviewed by Eric Seidel.
Don't enforce the version of libpng when passing the option to the linker.
No new tests, no intended functionality change.
- WebCore.pri:
- 2:04 AM Changeset in webkit [116506] by
-
- 8 edits in trunk
[EFL][DRT] LayoutTestController addUserScript implementation
https://bugs.webkit.org/show_bug.cgi?id=84718
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-09
Reviewed by Antonio Gomes.
Source/WebKit/efl:
Added helper functions for adding/clearing of user scripts.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::addUserScript):
(DumpRenderTreeSupportEfl::clearUserScripts):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Added implementation of addUserScript() to LayoutTestController.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): clear added user scripts
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addUserScript): added implementation
LayoutTests:
Unskipped corresponding testcases.
- platform/efl/Skipped:
- 1:42 AM Changeset in webkit [116505] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Remove delayed loadDidSucceed() signaling and m_deferedUrlToLoad from QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=85906
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.
Deferred loading activies were introduced to work around the delayed Flickable construction
at onComponentComplete(). QQuickWebView inherits from QQuickFlickable now,
so no need for the workaround anymore.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebView::setUrl):
(QQuickWebView::componentComplete):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):
- 1:34 AM Changeset in webkit [116504] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update.
- platform/chromium/test_expectations.txt:
video-media-source-seek.html is also SLOW?
- 12:54 AM Changeset in webkit [116503] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Disable WebViewTest.TextInputType because the test is incomplete.
- tests/WebViewTest.cpp:
- 12:51 AM Changeset in webkit [116502] by
-
- 2 edits in trunk/LayoutTests
[EFL] http/tests/loading/pdf-commit-load-callbacks.html is failing
https://bugs.webkit.org/show_bug.cgi?id=85957
Unreviewed gardening.
Move http/tests/loading/pdf-commit-load-callbacks.html to
test_expectations.txt while Bug 85956 is fixed.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-09
- platform/efl/test_expectations.txt:
- 12:46 AM Changeset in webkit [116501] by
-
- 3 edits in trunk/Tools
Made build-webkit copy WebKitLibraries to the right location again after r116257
Reviewed by Mark Rowe.
- Scripts/build-webkit: Pass the built product directory to copy-webkitlibraries-to-product-directory.
- Scripts/copy-webkitlibraries-to-product-directory: Use the first argument, if present, as the
product directory.
- 12:42 AM Changeset in webkit [116500] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Some of *.runMultiThread tests intermittently crash.
Mark them flaky.
- tests/CCLayerTreeHostTest.cpp:
- 12:19 AM Changeset in webkit [116499] by
-
- 21 edits13 adds in trunk/Source
Source/WebCore: Add identifying methods for date/time input types.
This patch adds methods isDateField(), isDateTimeField(), isDateTimeLocalField(),
isMonthField(), isTimeField() and isWeekField() to InputType and the appropriate
HTMLInputElement classes, to allow date/time input types to be identified.
The new methods match the existing methods for types such as email, search and number.
https://bugs.webkit.org/show_bug.cgi?id=78746
Patch by Oli Lan <olilan@chromium.org> on 2012-05-09
Reviewed by Kent Tamura.
A new test WebViewTest.TextInputType has been added in WebKit/chromium/tests that calls
through to these methods via WebViewImpl.textInputType().
- html/DateInputType.cpp:
(WebCore::DateInputType::isDateField):
(WebCore):
- html/DateInputType.h:
(DateInputType):
- html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::isDateTimeField):
(WebCore):
- html/DateTimeInputType.h:
(DateTimeInputType):
- html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::isDateTimeLocalField):
(WebCore):
- html/DateTimeLocalInputType.h:
(DateTimeLocalInputType):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isDateField):
(WebCore):
(WebCore::HTMLInputElement::isDateTimeField):
(WebCore::HTMLInputElement::isDateTimeLocalField):
(WebCore::HTMLInputElement::isMonthField):
(WebCore::HTMLInputElement::isTimeField):
(WebCore::HTMLInputElement::isWeekField):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
(WebCore::InputType::isDateField):
(WebCore):
(WebCore::InputType::isDateTimeField):
(WebCore::InputType::isDateTimeLocalField):
(WebCore::InputType::isMonthField):
(WebCore::InputType::isTimeField):
(WebCore::InputType::isWeekField):
- html/InputType.h:
(InputType):
- html/MonthInputType.cpp:
(WebCore::MonthInputType::isMonthField):
(WebCore):
- html/MonthInputType.h:
(MonthInputType):
- html/TimeInputType.cpp:
(WebCore::TimeInputType::isTimeField):
(WebCore):
- html/TimeInputType.h:
(TimeInputType):
- html/WeekInputType.cpp:
(WebCore::WeekInputType::isWeekField):
(WebCore):
- html/WeekInputType.h:
(WeekInputType):
Source/WebKit/chromium: Adds date/time input types to WebTextInputType, and adds support for these
to WebViewImpl.textInputType().
Adds a new test WebViewTest.TextInputType to test WebViewImpl.textInputType(),
including the new types.
https://bugs.webkit.org/show_bug.cgi?id=78746
Patch by Oli Lan <olilan@chromium.org> on 2012-05-09
Reviewed by Kent Tamura.
- public/WebTextInputType.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputType):
- tests/WebViewTest.cpp:
(WebViewTest):
(WebKit::WebViewTest::testTextInputType):
(WebKit):
(WebKit::TEST_F):
- tests/data/input_field_date.html: Added.
- tests/data/input_field_datetime.html: Added.
- tests/data/input_field_default.html: Added.
- tests/data/input_field_email.html: Added.
- tests/data/input_field_number.html: Added.
- tests/data/input_field_search.html: Added.
- tests/data/input_field_time.html: Added.
- tests/data/input_field_week.html: Added.
- 12:17 AM Changeset in webkit [116498] by
-
- 8 edits4 adds in trunk
REGRESSION(r105057): Infinite loop inside SVGTextLayoutEngine::currentLogicalCharacterMetrics
https://bugs.webkit.org/show_bug.cgi?id=83405
Reviewed by Darin Adler.
Source/WebCore:
Dynamically adding tspans carrying position information in the x/y/dx/dy/rotate lists is broken.
To avoid mistakes like this in future, simplify the calling code in RenderSVGInlineText and centralize
the managment of all caches (text positioning element cache / metrics map / layout attributes) in
RenderSVGText. This avoids the hack in SVGRootInlineBox::computePerCharacterLayoutInformation() which
called textRoot->rebuildLayoutAttributes(), which was used to fix previous security issues with this code.
Instead correctly handle destruction of RenderSVGInlineText in RenderSVGText, keeping the m_layoutAttributes
synchronized with the current state of the render tree. Fixes highcharts problems.
Tests: svg/text/add-tspan-position-bug.html
svg/text/modify-tspan-position-bug.html
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::addChild):
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::willBeDestroyed):
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):
- rendering/svg/RenderSVGText.cpp:
(WebCore::recursiveUpdateMetrics):
(WebCore::RenderSVGText::subtreeChildAdded):
(WebCore::RenderSVGText::subtreeChildWillBeDestroyed):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::checkLayoutAttributesConsistency):
(WebCore::RenderSVGText::subtreeChildWasDestroyed):
(WebCore::RenderSVGText::subtreeStyleChanged):
(WebCore::RenderSVGText::subtreeTextChanged):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::RenderSVGText::rebuildAllLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):
- rendering/svg/RenderSVGText.h:
(WebCore::RenderSVGText::layoutAttributes):
- rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):
LayoutTests:
Add two new testcases covering the problem.
- svg/text/add-tspan-position-bug-expected.html: Added.
- svg/text/add-tspan-position-bug.html: Added.
- svg/text/modify-tspan-position-bug-expected.html: Added.
- svg/text/modify-tspan-position-bug.html: Added.
- 12:07 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
