⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 18, 2012:

11:51 PM WebKit Team edited by kseo@webkit.org
(diff)
11:42 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
10:55 PM Changeset in webkit [123074] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Another build fix after r123065. Don't list deleted file in gypi.

  • WebCore.gypi:
10:48 PM Changeset in webkit [123073] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium build fix attempt. Don't use anonymous namespace.

  • tests/TextureCopierTest.cpp:
10:30 PM Changeset in webkit [123072] by keishi@webkit.org
  • 23 edits
    12 adds in trunk

Implement painting slider tick marks
https://bugs.webkit.org/show_bug.cgi?id=87844

Reviewed by Kent Tamura.

Source/WebCore:

This implements painting slider tick marks for <datalist> support for input type=range.
This does not support automatic update when list target changes, and it will be fixed
in a follow up patch (Bug 89544).

Tests: fast/forms/datalist/input-appearance-range-with-datalist-rtl.html

fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html
fast/forms/datalist/input-appearance-range-with-datalist.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::sliderThumbElement):
(WebCore):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.h:

(WebCore::InputType::sliderThumbElement):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::typeMismatchFor): We need HTMLInputElement::isValidValue("foo") to return false.
(WebCore):
(WebCore::RangeInputType::sliderThumbElement):

  • html/RangeInputType.h:

(RangeInputType):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderContainer::layout): Slider height needs to be increased for the tick marks.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore):
(WebCore::RenderThemeEfl::sliderTickSize):
(WebCore::RenderThemeEfl::sliderTickOffsetFromTrackCenter):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::sliderTickSize):
(WebCore):
(WebCore::RenderThemeQt::sliderTickOffsetFromTrackCenter):

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

  • rendering/RenderTheme.cpp:

(WebCore):
(WebCore::RenderTheme::paintSliderTicks):

  • rendering/RenderTheme.h:

(RenderTheme):

  • rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsDataListUI):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore):
(WebCore::RenderThemeChromiumLinux::sliderTickSize): Tick size for horizontal slider. i.e. Width is length along the track.
(WebCore::RenderThemeChromiumLinux::sliderTickOffsetFromTrackCenter): Offset from
middle of draw rect to draw the ticks. Minus value means above the track.
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):

  • rendering/RenderThemeChromiumLinux.h:

(RenderThemeChromiumLinux):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::sliderTickSize):
(WebCore::RenderThemeChromiumWin::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::RenderThemeChromiumWin::paintSliderThumb):

  • rendering/RenderThemeChromiumWin.h:

(RenderThemeChromiumWin):

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore):
(WebCore::RenderThemeMac::sliderTickSize):
(WebCore::RenderThemeMac::sliderTickOffsetFromTrackCenter):

LayoutTests:

  • fast/forms/datalist/input-appearance-range-with-datalist-expected.txt: Added.
  • fast/forms/datalist/input-appearance-range-with-datalist-rtl-expected.html: Added.
  • fast/forms/datalist/input-appearance-range-with-datalist-rtl.html: Added. The ticks should go from right to left.
  • fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.txt: Added.
  • fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html: Added. The ticks should zoom properly.
  • fast/forms/datalist/input-appearance-range-with-datalist.html: Added.
  • platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
  • platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
  • platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
  • platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
  • platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
  • platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/datalist/input-list-expected.txt:
10:08 PM Changeset in webkit [123071] by shinyak@chromium.org
  • 4 edits in trunk/Source/WebCore

Element wants to have userAgentShadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=91564

Reviewed by Eric Carlson.

We introduce Element::userAgentShadowRoot() to return a UserAgentShadowRoot.
It returns the oldest shadow root if any, and checks the type of ShadowRoot in debug build.

Previously, we have used elementShadow()->oldestShadowRoot() to get UserAgentShadowRoot.
The class implementor will know the oldest shadow root is UserAgentShadowRoot, but it is not
clear for the other people. This method will make the code intention clearer.

We will introduce userAgentShadowRoot to the other elements (e.g. HTMLInputElement) after this patch.

No new tests, simple refactoring.

  • dom/Element.cpp:

(WebCore::Element::userAgentShadowRoot):
(WebCore):

  • dom/Element.h:

(Element):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::createShadowSubtree):
(WebCore::HTMLMediaElement::willAddAuthorShadowRoot):
(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):
(WebCore::HTMLMediaElement::createMediaControls):

10:05 PM Changeset in webkit [123070] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Shadow DOM drop event tests are very flaky.
https://bugs.webkit.org/show_bug.cgi?id=87364

Patch by Takashi Sakamoto <tasak@google.com> on 2012-07-18
Reviewed by Hajime Morita.

Modified these tests to run test functions in onload. Probably
executing event tests while parsing html document causes flakyness.

  • fast/dom/shadow/drop-event-for-input-in-shadow.html:
  • fast/dom/shadow/drop-event-in-shadow.html:
  • platform/chromium/TestExpectations:
9:47 PM Changeset in webkit [123069] by commit-queue@webkit.org
  • 4 edits in trunk

[CMake][EFL] Should try to find the same libsoup version pulled by jhbuild
https://bugs.webkit.org/show_bug.cgi?id=91626

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

.:

Bump required version of libsoup in CMake to 2.39.3. This is the first
tarball version to contain the API we need (soup_cookie_jar_get_cookies()
and soup_cookie_jar_set_cookie_with_first_party()).

  • Source/cmake/OptionsEfl.cmake:

Tools:

Update jhbuild to pull libsoup 2.39.3 tarball from Gnome FTP instead
of fetching a tag from Gnome GIT. We need to do this to map the version
of libsoup that is required by our CMake config.

  • efl/jhbuild.modules:
9:36 PM Changeset in webkit [123068] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

[CMAKE] Remove duplicated #ifdef guard in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=91575

Reviewed by Dirk Pranke.

CMake files have used ENABLE_XXX macro. However, almost source and idl files are already protected by #ifdef.
So, we don't need to guard them in CMake files again.

In SVG idl files case, blackberry port doesn't support it yet. So, SVG idl files are handled by WebCore_SVG_IDL_FILES macro.

No new tests. This patch isn't for functionality.

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake: Change SVG_IDL_FILES with WebCore_SVG_IDL_FILES.
7:51 PM Changeset in webkit [123067] by hbono@chromium.org
  • 6 edits
    5 adds in trunk

Move contents right when a vertical scrollbar is shown at the left side of an RTL element.
https://bugs.webkit.org/show_bug.cgi?id=85856

Reviewed by Hajime Morita.

Source/WebCore:

This change prevents the scrollWidth value from being cropped by the width of a
scrollbar when a vertical scrollbar is shown at the left side of an RTL element.
This change also increases the clientLeft value by this scrollbar width and move
contents right to improve compliance with CSSOM <http://www.w3.org/TR/cssom-view>.

Tests: scrollbars/rtl/div-horizontal.html

scrollbars/rtl/div-vertical.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject): Move contents to the right.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::topLeftLocationOffset): Move the top-left corner to the right to prevent WebKit from cropping scrollWidth.

  • rendering/RenderBox.h:

(WebCore::RenderBox::clientLeft): Increase clientLeft by the width of a scrollbar.

LayoutTests:

This changes adds a couple of tests that verify CSSOM properties of RTL elements
are compliant with <http://www.w3.org/TR/cssom-view> regardless of their
scrollbar positions.

  • platform/chromium/TestExpectations:
  • scrollbars/rtl: Added.
  • scrollbars/rtl/div-horizontal-expected.txt: Added.
  • scrollbars/rtl/div-horizontal.html: Added.
  • scrollbars/rtl/div-vertical-expected.txt: Added.
  • scrollbars/rtl/div-vertical.html: Added.
7:48 PM Changeset in webkit [123066] by tkent@chromium.org
  • 10 edits
    1 delete in trunk

Form state restore: Classify form control sates by owners in internal and serialized representations
https://bugs.webkit.org/show_bug.cgi?id=91594

Reviewed by Hajime Morita.

Source/WebCore:

Before this change, the internal representation of form control states
was a map like:

{name, type, formKey} -> [FormControlState, FormControlState, ...]

Also, the serialized representation was:

[name, type, formKey, FormControlState,

name, type, formKey, formControlState,
...]

This changes these represenations. The internal representation is

A map owned by FormController:

formKey -> SavedFormState

SavedFormState owns a map like:

{name, type} -> [FormControlState, FormControlState, ...]

The serialized representation is:

[formKey, count,

name, type, FormControlState,
name, type, FormControlState,
name, type, FormControlState,
....
formKey, count,
name, type, FormControlState,
name, type, FormControlState,
name, type, FormControlState,
....]

The serialized representation would be smaller in many cases because
each of items doesn't have formKey.

Tests: Covered by fast/forms/state-restore-broken-state.html,
state-restore-per-form.html, and state-restore-skip-stateless.html.

  • html/FormController.cpp:

(FormElementKey): Remove formKey argument and m_formKey.
(WebCore::FormElementKey::FormElementKey):
(WebCore::FormElementKey::operator=):
(WebCore::FormElementKey::ref):
(WebCore::FormElementKey::deref):
(WebCore::operator==):

(SavedFormState):

  • The role of SavedFromState was changed. It represented all of control states. Now it represent control states owned by a signle form.
  • Make this non-copyable and fast-allocated.
  • Add m_controlStateCount, a counter of FormControlState

(WebCore::SavedFormState::SavedFormState):

Initialize m_controlStateCount.

(WebCore::isNotFormControlTypeCharacter):
Moved from another place in this file.
(WebCore::SavedFormState::deserialize):
Added. Build a SavedFromState with the specified stateVector.
(WebCore::SavedFormState::serializeTo):
Added. m_controlStateCount is needed here.
(WebCore::SavedFormState::appendControlState):

  • Remove formKey arguement.
  • Update m_controlStateCount.

(WebCore::SavedFormState::takeControlState): ditto.

(WebCore::formStateSignature): Bump the version.
(WebCore::FormController::createSavedFormStateMap):
Added. Build a SavedFormStateMap from the form control list. This is a
helper for formElementsState, and classifies controls in the document.
(WebCore::FormController::formElementsState):
Build a SavedFormStateMap with createSavedFormStateMap(),
then serializes it.
(WebCore::FormController::setStateForNewFormElements):
Deserialize SavedFormState, and build SavedFormStateMap.
(WebCore::FormController::takeStateForFormElement):
Finds the corresponding SavedFormState with a formKey, and uses it.

  • html/FormController.h:

Declare createSavedFormStateMap(), and moved typedefs for it.

LayoutTests:

Because the state serialization order depends on iteration order of
HashMap, serialized state array is not stable. We should remove raw dump
of serialized state array.

  • fast/forms/state-restore-per-form.html: Remove the code to dump the

form state. It's useless because the test have enough assertions.

  • fast/forms/state-restore-per-form-expected.txt:
  • fast/forms/resources/state-restore-per-form-back.html: Removed.
  • fast/forms/resources/state-restore-skip-stateless-dump.html:

Instead of dumping form state, check existence of types with JavaScript code.

  • fast/forms/state-restore-skip-stateless-expected.txt:
  • fast/forms/state-restore-skip-stateless.html: Fix a typo.
  • fast/forms/state-restore-broken-state-expected.txt:

Update the expectation because of the serialization format change.

7:46 PM Changeset in webkit [123065] by piman@chromium.org
  • 73 edits
    1 copy
    3 adds
    3 deletes in trunk/Source

[chromium] Introduce CCResourceProvider, replacing TextureAllocator and hiding textures from clients to allow transport
https://bugs.webkit.org/show_bug.cgi?id=91044

Reviewed by Adrienne Walker.

This does several things:

  • Add a CCResourceProvider class, that hides textures and the 3D context

from layers (except those that need it). Instead layers manage
"resources". In the future, resources are expected to be transportable
to a "parent" CCResourceProvider to allow flattening of nested
compositors.

  • Replace texture ids by resource ids in DrawQuads (allowing them to be

serializable).

  • Replace TextureAllocator uses by the CCResourceProvider class.
  • Upload of data is done through the CCResourceProvider instead of

explicit GL calls.

  • External textures are wrapped into a resource at draw time (see

caveat/FIXME in CCTextureLayerImpl).

  • Rendering with the resources is done through an explicit

beginRenderFrom/endRenderFrom that exposes the texture only between that
pair.

  • Merge all the LayerTextureSubImage instances (one per layer), into a

single instance on the CCResourceProvider.

Added CCResourceProviderTest, the refactoring is covered by existing tests.

Source/Platform:

  • chromium/public/WebCompositorTextureQuad.h:

(WebCompositorTextureQuad):
(WebKit::WebCompositorTextureQuad::resourceId):

  • chromium/public/WebCompositorTileQuad.h:

(WebCompositorTileQuad):
(WebKit::WebCompositorTileQuad::resourceId):

Source/WebCore:

  • WebCore.gypi:
  • platform/chromium/support/WebCompositorTextureQuad.cpp:

(WebKit::WebCompositorTextureQuad::create):
(WebKit::WebCompositorTextureQuad::WebCompositorTextureQuad):

  • platform/chromium/support/WebCompositorTileQuad.cpp:

(WebKit::WebCompositorTileQuad::create):
(WebKit::WebCompositorTileQuad::WebCompositorTileQuad):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapCanvasLayerTextureUpdater::create):
(WebCore::BitmapCanvasLayerTextureUpdater::BitmapCanvasLayerTextureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(WebCore):
(Texture):
(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::create):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::BitmapSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(BitmapSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::createAcceleratedCanvas):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(FrameBufferSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::create):
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
(WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
(ImageLayerTextureUpdater):
(WebCore::ImageLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
(WebCore::applyFilters):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawIOSurfaceQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::useRenderPass):
(WebCore::LayerRendererChromium::useScopedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::finishCurrentFramebuffer):
(WebCore):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):
(WebCore::LayerRendererChromium::resourceProvider):

  • platform/graphics/chromium/LayerTextureSubImage.cpp:

(WebCore::LayerTextureSubImage::LayerTextureSubImage):
(WebCore::LayerTextureSubImage::upload):
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):

  • platform/graphics/chromium/LayerTextureSubImage.h:

(WebKit):
(LayerTextureSubImage):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore):
(Texture):

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::reserve):
(WebCore::ManagedTexture::allocate):
(WebCore::ManagedTexture::steal):
(WebCore::ManagedTexture::clear):

  • platform/graphics/chromium/ManagedTexture.h:

(WebCore::ManagedTexture::resourceId):
(ManagedTexture):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/TextureCopier.cpp:

(WebCore::AcceleratedTextureCopier::copyTexture):
(WebCore):
(WebCore::AcceleratedTextureCopier::flush):

  • platform/graphics/chromium/TextureCopier.h:

(TextureCopier):
(AcceleratedTextureCopier):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::TextureManager):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):

  • platform/graphics/chromium/TextureManager.h:

(WebCore):
(WebCore::TextureManager::create):
(TextureManager):
(TextureInfo):
(EvictionEntry):

  • platform/graphics/chromium/TextureUploader.h:

(TextureUploader):

  • platform/graphics/chromium/ThrottledTextureUploader.cpp:

(WebCore::ThrottledTextureUploader::uploadTexture):

  • platform/graphics/chromium/ThrottledTextureUploader.h:

(ThrottledTextureUploader):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/TrackingTextureAllocator.cpp: Removed.
  • platform/graphics/chromium/TrackingTextureAllocator.h: Removed.
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:

(WebCore::CCIOSurfaceLayerImpl::willDraw):

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.h:

(CCIOSurfaceLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::willDraw):
(WebCore::CCLayerImpl::didDraw):
(WebCore::CCLayerImpl::contentsResourceId):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnImplThread):
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(WebCore::CCLayerTreeHostImpl::resourceProvider):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCPrioritizedTexture.cpp:

(WebCore::CCPrioritizedTexture::acquireBackingTexture):
(WebCore::CCPrioritizedTexture::resourceId):
(WebCore::CCPrioritizedTexture::upload):
(WebCore::CCPrioritizedTexture::beginRenderTo):
(WebCore::CCPrioritizedTexture::endRenderTo):
(WebCore):

  • platform/graphics/chromium/cc/CCPrioritizedTexture.h:

(WebCore):
(CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::Backing::resourceId):
(WebCore::CCPrioritizedTexture::Backing::Backing):
(Backing):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::~CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
(WebCore::CCPrioritizedTextureManager::reduceMemory):
(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::allBackingTexturesWereDeleted):
(WebCore::CCPrioritizedTextureManager::createBacking):
(WebCore::CCPrioritizedTextureManager::destroyBacking):

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:

(WebCore::CCPrioritizedTextureManager::create):
(CCPrioritizedTextureManager):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::maskResourceId):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderer.h:

(WebCore):
(CCRenderer):

  • platform/graphics/chromium/cc/CCResourceProvider.cpp: Added.

(WebCore):
(WebCore::textureToStorageFormat):
(WebCore::isTextureFormatSupportedForStorage):
(WebCore::CCResourceProvider::create):
(WebCore::CCResourceProvider::~CCResourceProvider):
(WebCore::CCResourceProvider::graphicsContext3D):
(WebCore::CCResourceProvider::inUseByConsumer):
(WebCore::CCResourceProvider::createResource):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::deleteOwnedResources):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::beginRenderTo):
(WebCore::CCResourceProvider::endRenderTo):
(WebCore::CCResourceProvider::beginRenderFrom):
(WebCore::CCResourceProvider::endRenderFrom):
(WebCore::CCResourceProvider::CCResourceProvider):
(WebCore::CCResourceProvider::initialize):

  • platform/graphics/chromium/cc/CCResourceProvider.h: Added.

(WebKit):
(WebCore):
(CCResourceProvider):
(WebCore::CCResourceProvider::maxTextureSize):
(WebCore::CCResourceProvider::numResources):
(Resource):

  • platform/graphics/chromium/cc/CCScopedTexture.cpp:

(WebCore::CCScopedTexture::CCScopedTexture):
(WebCore::CCScopedTexture::allocate):
(WebCore::CCScopedTexture::free):

  • platform/graphics/chromium/cc/CCScopedTexture.h:

(WebCore::CCScopedTexture::create):
(CCScopedTexture):
(WebCore::CCScopedTexture::beginRenderTo):
(WebCore::CCScopedTexture::endRenderTo):
(WebCore::CCScopedTexture::beginRenderFrom):
(WebCore::CCScopedTexture::endRenderFrom):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore):
(WebCore::CCScrollbarLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(WebCore::CCScrollbarLayerImpl::setBackTrackResourceId):
(WebCore::CCScrollbarLayerImpl::setForeTrackResourceId):
(WebCore::CCScrollbarLayerImpl::setThumbResourceId):
(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::stop):

  • platform/graphics/chromium/cc/CCTexture.h:

(WebCore::CCTexture::id):
(WebCore::CCTexture::setId):
(CCTexture):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:

(WebCore::CCTextureLayerImpl::CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::willDraw):
(WebCore):
(WebCore::CCTextureLayerImpl::appendQuads):
(WebCore::CCTextureLayerImpl::didDraw):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.h:

(CCTextureLayerImpl):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::update):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(WebCore):
(CCTextureUpdater):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::DrawableTile::resourceId):
(WebCore::DrawableTile::setResourceId):
(WebCore::DrawableTile::DrawableTile):
(DrawableTile):
(WebCore::CCTiledLayerImpl::contentsResourceId):
(WebCore::CCTiledLayerImpl::hasTextureIdForTileAt):
(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::pushTileProperties):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):
(WebCore::CCVideoLayerImpl::FramePlane::allocateData):
(WebCore::CCVideoLayerImpl::FramePlane::freeData):
(WebCore::CCVideoLayerImpl::allocatePlaneData):
(WebCore::CCVideoLayerImpl::copyPlaneData):
(WebCore::CCVideoLayerImpl::freePlaneData):
(WebCore::CCVideoLayerImpl::freeUnusedPlaneData):
(WebCore::CCVideoLayerImpl::didLoseContext):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):
(FramePlane):
(WebCore::CCVideoLayerImpl::FramePlane::FramePlane):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCPrioritizedTextureTest.cpp:

(WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::createManager):
(WTF::CCPrioritizedTextureTest::validateTexture):
(WTF::CCPrioritizedTextureTest::resourceProvider):
(CCPrioritizedTextureTest):
(WTF::TEST_F):

  • tests/CCQuadCullerTest.cpp:
  • tests/CCResourceProviderTest.cpp: Added.

(WebKit):
(ResourceProviderContext):
(WebKit::ResourceProviderContext::create):
(WebKit::ResourceProviderContext::bindTexture):
(WebKit::ResourceProviderContext::createTexture):
(WebKit::ResourceProviderContext::deleteTexture):
(WebKit::ResourceProviderContext::texStorage2DEXT):
(WebKit::ResourceProviderContext::texImage2D):
(WebKit::ResourceProviderContext::texSubImage2D):
(WebKit::ResourceProviderContext::getPixels):
(WebKit::ResourceProviderContext::textureCount):
(WebKit::ResourceProviderContext::textureSize):
(WebKit::ResourceProviderContext::ResourceProviderContext):
(WebKit::ResourceProviderContext::Texture::Texture):
(Texture):
(WebKit::ResourceProviderContext::allocateTexture):
(WebKit::ResourceProviderContext::setPixels):
(CCResourceProviderTest):
(WebKit::CCResourceProviderTest::CCResourceProviderTest):
(WebKit::CCResourceProviderTest::context):
(WebKit::CCResourceProviderTest::getResourcePixels):
(WebKit::TEST_F):

  • tests/CCScopedTextureTest.cpp:

(WebKitTests::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::createLayer):
(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::Texture::updateRect):

  • tests/CCTiledLayerTestCommon.h:

(Texture):
(WebKitTests::FakeTextureCopier::copyTexture):
(WebKitTests::FakeTextureCopier::flush):
(WebKitTests::FakeTextureUploader::uploadTexture):

  • tests/ContentLayerChromiumTest.cpp:

(WebKit::TEST):

  • tests/FakeCCGraphicsContext.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTexture.h.

(WebKit):
(WebKit::createFakeCCGraphicsContext):

  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(LayerRendererChromiumTest::context):
(LayerRendererChromiumTest):
(TEST_F):
(TEST):

  • tests/TextureCopierTest.cpp:
  • tests/TextureManagerTest.cpp:

(WTF::TextureManagerTest::TextureManagerTest):
(WTF::TextureManagerTest::createTextureManager):
(WTF::TextureManagerTest::requestTexture):
(TextureManagerTest):

  • tests/TiledLayerChromiumTest.cpp:
7:39 PM Changeset in webkit [123064] by hayato@chromium.org
  • 6 edits in trunk

[Shadow] A 'selectstart' event fired on distributed nodes should not be stopped at shadow boundary of the parent shadow host.
https://bugs.webkit.org/show_bug.cgi?id=90508

Reviewed by Dimitri Glazkov.

Source/WebCore:

We should not stop some kinds of events at the shadow boundary of a shadow host if the
event is fired on distributed nodes.

See the spec for such kinds of events.
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events-that-are-always-stopped

Test: fast/dom/shadow/events-stopped-at-shadow-boundary.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::ensureEventAncestors):
(WebCore::inTheSameScope):
(WebCore):
(WebCore::EventDispatcher::determineDispatchBehavior):

  • dom/EventDispatcher.h:

(EventDispatcher):

LayoutTests:

  • fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
  • fast/dom/shadow/events-stopped-at-shadow-boundary.html:
7:29 PM Changeset in webkit [123063] by morrita@google.com
  • 4 edits
    4 adds in trunk

Add window resize benchmark
https://bugs.webkit.org/show_bug.cgi?id=91070

Reviewed by Ryosuke Niwa.

PerformanceTests:

Added window-resize.html which exercise html5.html. This test
resizes the window and forces re-layout repeatedly.

  • Interactive/resources/window-resize.js: Added.
  • Interactive/window-resize.html: Added.
  • Parser/resources/html5.html: Modified to inject driver scripts.

Tools:

Added some more output filters to take care of html5.html output.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):

7:24 PM Changeset in webkit [123062] by jchaffraix@webkit.org
  • 5 edits
    2 adds in trunk

Crash in RenderTableSection::addCell.
http://webkit.org/b/89496

Reviewed by Abhishek Arya.

Source/WebCore:

The issue comes from RenderBox::splitAnonymousBoxesAroundChild that would move sections
across tables but didn't force the table to do a synchronous section recalc. This opened
the way for race conditions where we would query the table column structure while it's dirty
(this is not uncommon but as usually the table's column representation is always bigger or
more split than a section's, it's usually harmless).

The fix is to force a synchronous section recalc.

Test: fast/table/split-table-no-section-update-crash.html

  • rendering/RenderBox.cpp:

(WebCore::markBoxForRelayoutAfterSplit):
Changed to call forceSectionsRecalc ie force a section recalc.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::recalcSections):
Added missing ASSERT for unneeded calls.

  • rendering/RenderTable.h:

(WebCore::RenderTable::forceSectionsRecalc):
Added this helper function.

LayoutTests:

The test is still pretty complex as it involves lots of generated content. It should
be possible to get a smaller test case based on the conditions for the crash. However
this test is a pretty good stress test so I decided against creating a more simple test
case.

  • fast/table/split-table-no-section-update-crash-expected.txt: Added.
  • fast/table/split-table-no-section-update-crash.html: Added.
6:52 PM Changeset in webkit [123061] by jchaffraix@webkit.org
  • 10 edits
    2 adds in trunk

Avoid calling GraphicsContext drawing primitives for 0px borders
https://bugs.webkit.org/show_bug.cgi?id=90039

Reviewed by Eric Seidel.

Source/WebCore:

The current code would happily call GraphicsContext to draw empty (0px) borders.
There is no good use case for going all the way to GraphicsContext in this case as
0px borders, regardless of the border-style, will not be painted. Thus this is a waste
of time on all platforms. On Chromium, this trigger some issues with pdf rendering as
Skia interprets 0px lines as very thin lines.

This change adds 0-checks in the border painting code as well as ASSERTs for
performance and to catch future bad use.

Test: fast/borders/0px-borders.html

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawRect):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawRect):

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:

(WebCore::GraphicsContext::drawRect):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawRect):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawRect):

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::drawRect):
Added an ASSERT on all platforms to catch incorrect use.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::BorderEdge::shouldRender):
Changed to not render 0px borders, which should avoid unneeded work
in the patining code (context saving / restoring or transparency layer
push).

(WebCore::RenderBoxModelObject::paintOneBorderSide):
Added an ASSERT here that the border side is not empty.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
Added an early return with a comment as to why it's not feasible to
ASSERT as would be best.

LayoutTests:

The ref-tests are pretty similar and the exact rendering doesn't matter. What matters
is that we try to exercise the border painting code with 0px borders. Note that the
test were passing before already as they are meant to trigger the newly added ASSERTs
if something changes.

  • fast/borders/0px-borders-expected.html: Added.
  • fast/borders/0px-borders.html: Added.
6:46 PM Changeset in webkit [123060] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r89900): Assertion failure on null view() when destroying the document
https://bugs.webkit.org/show_bug.cgi?id=91547

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-07-18
Reviewed by Abhishek Arya.

Source/WebCore:

Check for document destruction during insertion to avoid crash on null RenderView when trying
to count the number of RenderQuote and RenderCounter objects.

Test: fast/css-generated-content/bug91547.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

Test for crash caused by null RenderView in RenderQuote and RenderCounter.

  • fast/css-generated-content/bug91547-expected.txt: Added.
  • fast/css-generated-content/bug91547.html: Added.
6:31 PM Changeset in webkit [123059] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h
https://bugs.webkit.org/show_bug.cgi?id=91408

Reviewed by Adam Barth.

This is in support of the new upgradeneeded versioning api.
intVersion will eventually replace the WebString version member.

  • public/WebIDBMetadata.h:

(WebKit::WebIDBMetadata::WebIDBMetadata):
The spec uses unsigned long long for version numbers but we use signed
long long so that we can use -1 as a sentinel. It indicates that a
database still uses a string version.

6:21 PM Changeset in webkit [123058] by dpranke@chromium.org
  • 11 edits in trunk/Tools

nrwt: merge WebKitDriver into Driver
https://bugs.webkit.org/show_bug.cgi?id=91696

Reviewed by Adam Barth.

As part of merging WebKitPort into Port, we also should merge
WebKitDriver into Driver, since all of the non-test Drivers now
inherit from WebKitDriver.

There are no functional changes in this patch, and all the changes should
be covered by the existing tests.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._driver_class):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._check_file_exists):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._drt_cmd_line):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidDriverTest.test_read_prompt):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver):
(Driver.init):
(Driver.del):
(Driver.run_test):
(Driver.has_crashed):
(Driver.start):
(Driver._start):
(Driver.stop):
(Driver.cmd_line):
(Driver._check_for_driver_crash):
(Driver._command_from_driver_input):
(Driver._read_first_block):
(Driver._read_optional_image_block):
(Driver._read_header):
(Driver._process_stdout_line):
(Driver._strip_eof):
(Driver._read_block):
(ContentBlock):
(ContentBlock.init):
(ContentBlock.decode_content):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverTest.make_port):
(DriverTest._assert_wrapper):
(DriverTest.test_read_block):
(DriverTest):
(DriverTest.test_read_binary_block):
(DriverTest.test_read_base64_block):
(DriverTest.test_no_timeout):
(DriverTest.test_check_for_driver_crash):
(DriverTest.test_check_for_driver_crash.FakeServerProcess):
(DriverTest.test_check_for_driver_crash.FakeServerProcess.init):
(DriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
(DriverTest.test_check_for_driver_crash.FakeServerProcess.name):
(DriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
(DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
(DriverTest.test_check_for_driver_crash.assert_crash):
(DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
(DriverTest.test_stop_cleans_up_properly):
(DriverTest.test_two_starts_cleans_up_properly):
(MockServerProcess):
(MockServerProcess.init):
(MockServerProcess.has_crashed):
(MockServerProcess.read_stdout_line):
(MockServerProcess.read_stdout):
(MockServerProcess.read_either_stdout_or_stderr_line):
(MockServerProcess.start):
(MockServerProcess.stop):
(MockServerProcess.kill):

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._read_image_diff):
(WebKitPort.skipped_layout_tests):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_path_to_apache_config_file):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver):
(XvfbDriver.stop):

6:18 PM Changeset in webkit [123057] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebKit/mac

[Mac] Make WebDataSourcePrivate lighter
https://bugs.webkit.org/show_bug.cgi?id=91511

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-18
Reviewed by Anders Carlsson.

Make WebDataSourcePrivate a simple C++ class and use smart pointers for memory management.

Since the "loader" attribute is only set on initialization, all the assertions spread in
various function are removed in favor of assertions on initialization.

  • WebView/WebDataSource.h:
  • WebView/WebDataSource.mm:

(WebDataSourcePrivate):
(WebDataSourcePrivate::WebDataSourcePrivate):
(WebDataSourcePrivate::~WebDataSourcePrivate):
Use a class instead of a Objective-C object for WebDataSourcePrivate.
Use smart pointers instead of ref counting manually.

(-[WebDataSource _setRepresentation:]):
(-[WebDataSource _addSubframeArchives:]):
(-[WebDataSource _transferApplicationCache:]):
(-[WebDataSource _setDeferMainResourceDataLoad:]):
(-[WebDataSource _documentFragmentWithArchive:]):
(-[WebDataSource _initWithDocumentLoader:]):

(+[WebDataSource initialize]):
(-[WebDataSource dealloc]):
(-[WebDataSource finalize]):
WebDataSource takes the special initialization and destruction that was done in WebDataSourcePrivate.

(-[WebDataSource representation]):

6:08 PM Changeset in webkit [123056] by nduca@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Add histogram for tracking compositor-thread frame rate
https://bugs.webkit.org/show_bug.cgi?id=91692

Reviewed by Adrienne Walker.

This patch tracks the interval between compositor thread frames
and pushes it into a platform histogram. This allows us to track
compositor-thread frame rate in the wild.

  • platform/graphics/chromium/cc/CCFrameRateCounter.cpp:

(WebCore::CCFrameRateCounter::markBeginningOfFrame):

5:42 PM Changeset in webkit [123055] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy.common.system.executive_unittest.ExecutiveTest.test_kill_process is flaky
https://bugs.webkit.org/show_bug.cgi?id=91698

Unreviewed, build fix.

This is a workaround for the test failing (apparently mostly?)
when run in parallel with other tests. The underlying bug still
needs to be diagnosed as we shouldn't be getting ECHILD from
process.wait().

  • Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.test_kill_process):

5:35 PM Changeset in webkit [123054] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Disable running python unit tests in parallel on win32 for now.
https://bugs.webkit.org/show_bug.cgi?id=91697

Unreviewed, build fix.

  • Scripts/webkitpy/test/main.py:

(Tester._parse_args):

5:33 PM Changeset in webkit [123053] by jer.noble@apple.com
  • 3 edits in trunk/LayoutTests

[mac] Unreviewed gardening.

Rebaseline (by partially reverting) r122883.

  • platform/mac/fast/inline/002-expected.txt:
  • platform/mac/fast/table/table-display-types-strict-expected.txt:
5:30 PM Changeset in webkit [123052] by fpizlo@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

DFG should emit inline code for property storage (re)allocation
https://bugs.webkit.org/show_bug.cgi?id=91597

Reviewed by Oliver Hunt.

This adds two new ops to the DFG IR: AllocatePropertyStorage and
ReallocatePropertyStorage. It enables these to interact properly with
CSE so that a GetPropertyStorage on something for which we have
obviously done a (Re)AllocatePropertyStorage will result in the
GetPropertyStorage being eliminated. Other than that, the code
emitted for these ops is identical to the code we were emitting in
the corresponding PutById stub.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasStructureTransitionData):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(DFG):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/Structure.cpp:

(JSC::nextOutOfLineStorageCapacity):

  • runtime/Structure.h:

(JSC):

5:26 PM Changeset in webkit [123051] by jer.noble@apple.com
  • 4 edits in trunk/LayoutTests

[chromium] Drag image for image elements should be scaled with device scale factor.
https://bugs.webkit.org/show_bug.cgi?id=89688

Patch by Varun Jain <varunjain@chromium.org> on 2012-07-18
Reviewed by Adam Barth.

  • ManualTests/chromium/drag-image-accounts-for-device-scale.html:
5:19 PM Changeset in webkit [123050] by mitz@apple.com
  • 4 edits
    2 adds in trunk

Hit testing in the gap between pages returns incorrect results
https://bugs.webkit.org/show_bug.cgi?id=91695

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/multicol/hit-test-gap-between-pages.html

  • rendering/RenderBlock.h:

(RenderBlock): Promoted adjustPointToColumnContents from private to protected.

  • rendering/RenderView.cpp:

(WebCore::RenderView::updateHitTestResult): If we get here, and we make the document element
the inner node, adjust the local point for columns.

LayoutTests:

  • fast/multicol/hit-test-gap-between-pages-expected.txt: Added.
  • fast/multicol/hit-test-gap-between-pages.html: Added.
5:07 PM Changeset in webkit [123049] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Disable printing on chromium-android
https://bugs.webkit.org/show_bug.cgi?id=91550

Reviewed by Tony Chang.

We don't implement printing on Android.

  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::printPage):

4:57 PM Changeset in webkit [123048] by jsbell@chromium.org
  • 5 edits
    2 adds in trunk

IndexedDB: Direction parameter ignored by some openCursor() overloads
https://bugs.webkit.org/show_bug.cgi?id=91687

Reviewed by Tony Chang.

Source/WebCore:

A few of the openCursor() and openKeyCursor() overloads were not passing along the
direction parameter, resulting in the default direction being used. Trivial fixes.
Also, added a whitespace fix to a relevant console warning.

Test: storage/indexeddb/cursor-overloads.html

  • Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::openCursor):

LayoutTests:

Test the overloads to ensure cursor direction is set correctly.

  • storage/indexeddb/cursor-overloads-expected.txt: Added.
  • storage/indexeddb/cursor-overloads.html: Added.
  • storage/indexeddb/legacy-constants-expected.txt: Fix whitespace in console warnings.
4:54 PM Changeset in webkit [123047] by arv@chromium.org
  • 13 edits
    2 adds in trunk

[V8] Improve Replaceable extended attribute
https://bugs.webkit.org/show_bug.cgi?id=91668

Reviewed by Adam Barth.

Replaceable is working by chance in the V8 bindings because V8 does not correctly handle
read only properties on the prototype chain. With this change we generate a setter that
uses ForceSet to replace the existing property when set.

Source/WebCore:

Test: fast/dom/Window/replaceable.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateReplaceableAttrSetter):
(GenerateFunctionCallback):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::replaceableAttribute):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_get_replaceable_attribute):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjReplaceableAttribute):
(WebCore::setJSTestObjReplaceableAttribute):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj replaceableAttribute]):
(-[DOMTestObj setReplaceableAttribute:]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::replaceableAttributeAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::TestObjReplaceableAttrSetter):
(WebCore):

LayoutTests:

  • fast/dom/Window/replaceable-expected.txt: Added.
  • fast/dom/Window/replaceable.html: Added.
4:50 PM Changeset in webkit [123046] by jer.noble@apple.com
  • 12 edits in trunk/LayoutTests

Unreviewed gardening.

Correct a path error introduced by r122769 for the fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
test in many Skipped lists.

  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
4:44 PM Changeset in webkit [123045] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed TestExpectations update for WK90469.
Restore a test that was skipped to test a theory.
https://bugs.webkit.org/show_bug.cgi?id=90469

  • platform/chromium/TestExpectations:
4:39 PM Changeset in webkit [123044] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] Add heap profiling tests to Skipped list
https://bugs.webkit.org/show_bug.cgi?id=91684

Unreviewed gardening.

JSC doesn't support heap profiling.

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-18

  • platform/efl/Skipped:
4:38 PM Changeset in webkit [123043] by arv@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Remove temporary flag override for es52_globals
https://bugs.webkit.org/show_bug.cgi?id=91681

Reviewed by Adam Barth.

V8 has now changed their default value for the es52_globals so we no longer needs this override.

No new tests. No change in functionality.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initIsolate):

4:26 PM Changeset in webkit [123042] by oliver@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

dumpCallFrame is broken in ToT
https://bugs.webkit.org/show_bug.cgi?id=91444

Reviewed by Gavin Barraclough.

Various changes have been made to the SF calling convention, but
dumpCallFrame has not been updated to reflect these changes.
That resulted in both bogus information, as well as numerous
assertions of sadness.

This patch makes dumpCallFrame actually work again and adds the
wonderful feature of telling you the name of the variable that a
register reflects, or what value it contains.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::nameForRegister):

A really innefficient mechanism for finding the name of a local register.
This should only ever be used by debug code so this should be okay.

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

Debug builds no longer throw away a functions symbol table, this allows
us to actually perform a register# to name mapping

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

We weren't propogating the bytecode offset here leading to assertions
in debug builds when dumping bytecode of DFG compiled code.

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::dumpRegisters):

Rework to actually be correct.

(JSC::getCallerInfo):

Return the byteocde offset as well now, given we have to determine it
anyway.

(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):

  • interpreter/Interpreter.h:

(Interpreter):

  • jsc.cpp:

(GlobalObject::finishCreation):
(functionDumpCallFrame):

Give debug builds of JSC a method for calling dumpCallFrame so we can
inspect a callframe without requiring us to break in a debugger.

4:23 PM Changeset in webkit [123041] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[chromium] Add gl_tests to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=91680

Patch by Dave Tu <dtu@chromium.org> on 2012-07-18
Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/builders.js:

(loadBuildersList):

  • TestResultServer/static-dashboards/dashboard_base.js:

(currentBuilderGroupCategory):

4:21 PM Changeset in webkit [123040] by dpranke@chromium.org
  • 2 edits in trunk/Tools

fix python unit tests failing under cygwin
https://bugs.webkit.org/show_bug.cgi?id=91678

Reviewed by Adam Barth.

Fix a case where executive.kill_process was failing under cygwin
(apple win port) in an unexpected way.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.kill_process):

3:58 PM Changeset in webkit [123039] by jer.noble@apple.com
  • 5 edits in trunk/LayoutTests

REGRESSION (r122660-r122663): mathml/presentation/mo.xhtml, mathml/presentation/row.xhtml failing on Mountain Lion Production Tests
https://bugs.webkit.org/show_bug.cgi?id=91677

Reviewed by Eric Seidel.

Rebaseline after r122663.

  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/row-expected.png:
3:57 PM Changeset in webkit [123038] by commit-queue@webkit.org
  • 17 edits in trunk/Source

[chromium] Ubercomp: add id to SharedQuadState
https://bugs.webkit.org/show_bug.cgi?id=91670

Patch by Alexandre Elias <aelias@google.com> on 2012-07-18
Reviewed by Adrienne Walker.

This assigns an integer ID to SharedQuadState objects and a
corresponding ID to quads. This ID is unique only within a
RenderPass and currently is just set to the index in the shared quad
state list. This is redundant with the pointer and exists to
simplify serialization.

I found out that pointer rewriting within a pickler is blocked by
pointers to memory being const there, so the reassignment will have to
be performed in the application layer anyway. In that case, it's
simplest to add some ID integers.

Source/Platform:

  • chromium/public/WebCompositorQuad.h:

(WebKit::WebCompositorQuad::sharedQuadStateId):
(WebCompositorQuad):

  • chromium/public/WebCompositorSharedQuadState.h:

(WebCompositorSharedQuadState):

Source/WebCore:

No new tests (will introduce them when making use of the ID).

  • platform/chromium/support/WebCompositorQuad.cpp:

(WebKit::WebCompositorQuad::WebCompositorQuad):
(WebKit::WebCompositorQuad::setSharedQuadState):
(WebKit):

  • platform/chromium/support/WebCompositorSharedQuadState.cpp:

(WebKit::WebCompositorSharedQuadState::WebCompositorSharedQuadState):
(WebKit::WebCompositorSharedQuadState::create):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::createSharedQuadState):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
(WebCore::CCRenderPass::appendQuadsToFillScreen):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCQuadCullerTest.cpp:
  • tests/CCRenderSurfaceTest.cpp:
  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):

3:41 PM Changeset in webkit [123037] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Not reviewed. Build fix.

Add CR before bug number to avoid lint error.

  • platform/chromium/TestExpectations:
3:41 PM Changeset in webkit [123036] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Source/WebCore: [chromium] Ubercomp: clean up CCRenderer interface
https://bugs.webkit.org/show_bug.cgi?id=91555

Patch by Alexandre Elias <aelias@google.com> on 2012-07-18
Reviewed by Adrienne Walker.

I replaced the one-by-one RenderPass calls with a new drawFrame()
method that directly takes a CCRenderPassList, and moved a small
amount of code from CCLayerTreeHostImpl to implement it. In ubercomp
mode, we will produce a frame bundle rather than a command-stream, so
the full list is easier to work with.

Also, give empty default implementations for the methods that don't
need to do anything in a non-GL context, and make private
setScissorToRect.

No new tests (no-op refactoring).

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawFrame):
(WebCore):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCRenderer.h:

(WebCore::CCRenderer::viewportChanged):
(WebCore::CCRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):
(CCRenderer):
(WebCore::CCRenderer::finishDrawingFrame):
(WebCore::CCRenderer::doNoOp):
(WebCore::CCRenderer::isContextLost):

Source/WebKit/chromium: Add WebTextInputType enum values for text areas and
content-editable.
https://bugs.webkit.org/show_bug.cgi?id=91654

Patch by Nate Chapin <Nate Chapin> on 2012-07-18
Reviewed by Adam Barth.

No new tests, no behavior change without corresponding chromium.org changes.

  • public/WebTextInputType.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputType):

3:39 PM Changeset in webkit [123035] by dpranke@chromium.org
  • 2 edits in trunk/Tools

test-webkitpy: run tests in parallel by default
https://bugs.webkit.org/show_bug.cgi?id=91422

Reviewed by Adam Barth.

We use multiprocessing.cpu_count() for the default number of
jobs to run; memory overhead should be very low, so this should
be fine.

  • Scripts/webkitpy/test/main.py:

(Tester._parse_args):

3:36 PM Changeset in webkit [123034] by rniwa@webkit.org
  • 2 edits in trunk/Source/Platform

Another Chromium Windows build fix attempt after r123014.

  • chromium/public/Platform.h:
3:33 PM Changeset in webkit [123033] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Ubercomp: clean up CCRenderer interface
https://bugs.webkit.org/show_bug.cgi?id=91555

Patch by Alexandre Elias <aelias@google.com> on 2012-07-18
Reviewed by Adrienne Walker.

I replaced the one-by-one RenderPass calls with a new drawFrame()
method that directly takes a CCRenderPassList, and moved a small
amount of code from CCLayerTreeHostImpl to implement it. In ubercomp
mode, we will produce a frame bundle rather than a command-stream, so
the full list is easier to work with.

Also, give empty default implementations for the methods that don't
need to do anything in a non-GL context, and make private
setScissorToRect.

Source/WebCore:

No new tests (no-op refactoring).

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawFrame):
(WebCore):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCRenderer.h:

(WebCore::CCRenderer::viewportChanged):
(WebCore::CCRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):
(CCRenderer):
(WebCore::CCRenderer::finishDrawingFrame):
(WebCore::CCRenderer::doNoOp):
(WebCore::CCRenderer::isContextLost):

Source/WebKit/chromium:

  • tests/LayerRendererChromiumTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):
(FakeCCRendererClient::renderPasses):
(FakeCCRendererClient):
(TEST_F):
(TEST):

3:28 PM Changeset in webkit [123032] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[BlackBerry] Implement currentTime() and monotonicallyIncreasingTime() for OS(QNX)
https://bugs.webkit.org/show_bug.cgi?id=91659

Patch by Yong Li <yoli@rim.com> on 2012-07-18
Reviewed by Rob Buis.

Implement currentTime() and monotonicallyIncreasingTime() for OS(QNX) with clock_gettime().

  • wtf/CurrentTime.cpp:

(WTF):
(WTF::currentTime):
(WTF::monotonicallyIncreasingTime):

3:28 PM Changeset in webkit [123031] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Content size of child having percent height inside a fixed height container having overflow:auto is wrongly calculated
https://bugs.webkit.org/show_bug.cgi?id=11355

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-18
Reviewed by Julien Chaffraix.

Source/WebCore:

The content height of a child must be container height minus padding, border width and height of horizontal scrollbar(if any).

Tests: fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto.html

fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
Subtracting the height of the scrollbar from the client height when the client has percentage height.

LayoutTests:

  • fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt: Added.
  • fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto.html: Added.
  • fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt: Added.
  • fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto.html: Added.
3:22 PM Changeset in webkit [123030] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Add Pravin D to the list of contributors.

  • Scripts/webkitpy/common/config/committers.py:
3:20 PM Changeset in webkit [123029] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Ensure that the compositor code which is aware of flipped status of video-textures
per platform sets the flipped bit to false on Windows.
https://bugs.webkit.org/show_bug.cgi?id=91562

Patch by Anantanarayanan G Iyengar <ananta@chromium.org> on 2012-07-18
Reviewed by Adrienne Walker.

No new tests. (HW video decode is still only being tested manually for orientation)

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

3:17 PM Changeset in webkit [123028] by fpizlo@apple.com
  • 3 edits
    12 adds in trunk

DFG 32-bit PutById transition stub storage reallocation case copies the first pointer of each JSValue instead of the whole JSValue
https://bugs.webkit.org/show_bug.cgi?id=91599

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::emitPutTransitionStub):

LayoutTests:

Rubber stamped by Mark Hahnenberg.

It turns out we previously didn't have adequate coverage for this. Now we do.

  • fast/js/dfg-put-by-id-allocate-storage-expected.txt: Added.
  • fast/js/dfg-put-by-id-allocate-storage-polymorphic-expected.txt: Added.
  • fast/js/dfg-put-by-id-allocate-storage-polymorphic.html: Added.
  • fast/js/dfg-put-by-id-allocate-storage.html: Added.
  • fast/js/dfg-put-by-id-reallocate-storage-expected.txt: Added.
  • fast/js/dfg-put-by-id-reallocate-storage-polymorphic-expected.txt: Added.
  • fast/js/dfg-put-by-id-reallocate-storage-polymorphic.html: Added.
  • fast/js/dfg-put-by-id-reallocate-storage.html: Added.
  • fast/js/script-tests/dfg-put-by-id-allocate-storage-polymorphic.js: Added.

(foo):

  • fast/js/script-tests/dfg-put-by-id-allocate-storage.js: Added.

(foo):

  • fast/js/script-tests/dfg-put-by-id-reallocate-storage-polymorphic.js: Added.

(foo):

  • fast/js/script-tests/dfg-put-by-id-reallocate-storage.js: Added.

(foo):

3:16 PM Changeset in webkit [123027] by tsepez@chromium.org
  • 2 edits in trunk/Source/WTF

OOB read of stack buffer below DoubleToStringConverter::CreateExponentialRepresentation() in debug builds
https://bugs.webkit.org/show_bug.cgi?id=91642

Reviewed by Abhishek Arya.

  • wtf/dtoa/double-conversion.cc:

(DoubleToStringConverter::CreateExponentialRepresentation): NUL-terminate string buffer before passing it to StringBuilder::AddSubstring()

3:14 PM Changeset in webkit [123026] by hclam@chromium.org
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

[chromium] Unreviewed gardening.

Updated test expectation for compositing/masks/layer-mask-placement.html.
Updated bug number for fast/js/mozilla/strict/assign-to-callee-name.html after filing webkit bug 91676.

Updated bug number for fast/url/ipv6.html after filing crbug.com/137938.

  • platform/chromium-mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Removed.
  • platform/chromium-mac/compositing/masks/layer-mask-placement-expected.png: Added.
  • platform/chromium-win/compositing/masks/layer-mask-placement-expected.png: Added.
  • platform/chromium/TestExpectations:
3:06 PM Changeset in webkit [123025] by eae@chromium.org
  • 9 edits in trunk/Source/WebCore

Replace uses of RenderBox::x(), y() in rendering code with with point and size methods
https://bugs.webkit.org/show_bug.cgi?id=91549

Reviewed by Eric Seidel.

Replaces uses of RenderBox::x() and RenderBox::y() with
RenderBox::location(), RenderBox::locationOffset() and
RenderBox::frameRect().

No new tests, no change in functionality.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::positionNewFloats):
Use child->frameRect() and child->location() instead of constructing a
rect and size from the x, y, width and height values.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::repaintDuringLayoutIfMoved):
Compare and copy m_frameRect directly instead of comparing and copying
the individual values.

(WebCore::RenderBox::localCaretRect):
Use location() instead of x() and y().

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
Use pixelSnappedIntSize and RenderBox::size() instead of computing and
snapping the width and height separately.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::nodeAtPoint):
USe locationOffset() instead of creating a new LayoutSize object from the
x() and y() values.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateHitTestResult):
Move by Size instead of x and y value.

(WebCore::RenderInline::addFocusRingRects):
Move by Size instead of x and y value.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::offsetFromContainer):
Shrink offset by size instead of using x and y values.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::setLogicalPositionForCell):
Use child->frameRect() and child->location() instead of constructing a
rect and size from the x, y, width and height values.

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeRenderSVGTextBox):
Use location() instead of x() and y().

2:58 PM Changeset in webkit [123024] by kbr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations update. Added bug ID for fast/filesystem/file-writer-truncate-extend.html flakiness.

  • platform/chromium/TestExpectations:
2:51 PM Changeset in webkit [123023] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Unreviewed, try to fix the chromium-win build after r123014.

  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
2:38 PM Changeset in webkit [123022] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg flakily crashes on Chromium Win.

  • platform/chromium/TestExpectations:
2:36 PM Changeset in webkit [123021] by kbalazs@webkit.org
  • 3 edits in trunk/Tools

[Qt] feature detection in orwt/nrwt does not work with force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=91514

Reviewed by Dirk Pranke.

Analyzing libQtWebKit.so is not enough in the case of force_static_libs_as_shared.
We need to analyze all the shared library or at least the WebCore one.

  • Scripts/webkitdirs.pm:

(builtDylibPathForName):
In orwt it is hard coded to search for symbols in the WebCore library.
While in theory it is possible that symbols for a given feature are not
located in that, it doesn't happen in practice, so returning the path of
the WebCore library for a force_static_libs_as_shared build is enough to
fix the bug and it doesn't require a bigger refactoring. For a default
build we still return the path of the QtWebKit lib.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._modules_to_search_for_symbols):
Enumerate all dynamic libraries, not just the QtWebKit one.

2:33 PM Changeset in webkit [123020] by jsbell@chromium.org
  • 9 edits in trunk/Source

IndexedDB: Fix some coding style violations
https://bugs.webkit.org/show_bug.cgi?id=91565

Reviewed by Tony Chang.

Source/WebCore:

In declarations, put the * next to the type not the identifier.
Remove k as a prefix for various constants.

No new tests - no functional changes.

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::prefetchContinueInternal):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::computeFileIdentifier):

  • Modules/indexeddb/IDBKey.h:

(WebCore::IDBKey::IDBKey):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getDatabaseNames):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::getNewObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::getNewVersionNumber):
(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::getNewIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore):

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::maxIDBKey):
(WebCore::IDBLevelDBCoding::minIDBKey):
(WebCore::IDBLevelDBCoding::decodeVarInt):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
(WebCore::IDBLevelDBCoding::keyTypeByteToKeyType):
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
(WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::decodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::compare):
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
(WebCore::IDBLevelDBCoding::KeyPrefix::encode):
(WebCore::IDBLevelDBCoding::KeyPrefix::compare):
(WebCore::IDBLevelDBCoding::KeyPrefix::type):
(WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
(WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::decode):

  • Modules/indexeddb/IDBLevelDBCoding.h:

(IDBLevelDBCoding):
(ObjectStoreDataKey):
(ExistsEntryKey):

Source/WebKit/chromium:

  • tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):

2:31 PM Changeset in webkit [123019] by commit-queue@webkit.org
  • 6 edits
    4 adds
    3 deletes in trunk/Source/WebKit2

[EFL][WK2] EFL should use DownloadSoup instead of defining DownloadEfl
https://bugs.webkit.org/show_bug.cgi?id=91602

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

Reuse WebProcess/Downloads/soup/DownloadSoup.cpp in EFL port
instead of redefining our own DownloadEfl.cpp. The EFL port
is also using libsoup so it is best to avoid code duplication.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • WebProcess/Downloads/Download.h:

(WebKit):
(Download):

  • WebProcess/Downloads/efl/DownloadEfl.cpp: Removed.
  • WebProcess/Downloads/efl/DownloadSoupErrorsEfl.cpp: Added.

(WebKit):
(WebKit::platformDownloadNetworkError):
(WebKit::platformDownloadDestinationError):

  • WebProcess/Downloads/efl/FileDownloaderEfl.cpp: Removed.
  • WebProcess/Downloads/efl/FileDownloaderEfl.h: Removed.
  • WebProcess/Downloads/gtk/DownloadSoupErrorsGtk.cpp: Added.

(WebKit):
(WebKit::platformDownloadNetworkError):
(WebKit::platformDownloadDestinationError):

  • WebProcess/Downloads/soup/DownloadSoup.cpp: Make the code

compile for other ports than GTK.
(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFail):
(WebKit::Download::continueWithoutCredential):
(WebKit):
(WebKit::Download::useCredential):
(WebKit::Download::cancelAuthenticationChallenge):

  • WebProcess/Downloads/soup/DownloadSoupErrors.h: Added.

(WebKit):

2:28 PM Changeset in webkit [123018] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
http/tests/loading/307-after-303-after-post.html is flaky on win debug too.

  • platform/chromium/TestExpectations:
2:26 PM Changeset in webkit [123017] by tony@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed, fix some MSVC compile warnings.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
2:22 PM Changeset in webkit [123016] by commit-queue@webkit.org
  • 8 edits
    2 copies in trunk/Source/WebKit2

[WK2] Add C API for Network Information API
https://bugs.webkit.org/show_bug.cgi?id=90762

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

Add C API for WKNetworkInfo and WKNetworkInfoManager
so that they can be used by the client.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetNetworkInfoManager):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKNetworkInfo.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp.

(WKNetworkInfoGetTypeID):
(WKNetworkInfoCreate):

  • UIProcess/API/C/WKNetworkInfo.h: Copied from Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp.
  • UIProcess/API/C/WKNetworkInfoManager.cpp:

(WKNetworkInfoManagerSetProvider):
(WKNetworkInfoManagerProviderDidChangeNetworkInformation):

  • UIProcess/API/C/WKNetworkInfoManager.h:
2:13 PM Changeset in webkit [123015] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Update Chromium test expectations after filing the bug 91666.

  • platform/chromium/TestExpectations:
1:51 PM Changeset in webkit [123014] by pilgrim@chromium.org
  • 11 edits in trunk/Source

[Chromium] Call SQLiteFileSystem-related functions directly
https://bugs.webkit.org/show_bug.cgi?id=91631

Reviewed by Adam Barth.

Source/Platform:

Part of a refactoring series. See tracking bug 82948.

  • chromium/public/Platform.h:

(Platform):
(WebKit::Platform::databaseOpenFile):
(WebKit::Platform::databaseDeleteFile):
(WebKit::Platform::databaseGetFileAttributes):
(WebKit::Platform::databaseGetFileSize):
(WebKit::Platform::databaseGetSpaceAvailableForOrigin):

Source/WebCore:

Part of a refactoring series. See tracking bug 82948.

  • Modules/webdatabase/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/sql/chromium/SQLiteFileSystemChromium.cpp:

(WebCore::SQLiteFileSystem::deleteDatabaseFile):
(WebCore::SQLiteFileSystem::getDatabaseFileSize):

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

  • public/platform/WebKitPlatformSupport.h:

(WebKitPlatformSupport):

  • src/PlatformSupport.cpp:

(WebCore):

1:43 PM Changeset in webkit [123013] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

WebKit provides APIs that make it possible for JSC to attempt to initialise the heap without initialising threading
https://bugs.webkit.org/show_bug.cgi?id=91663

Reviewed by Filip Pizlo.

Initialising a JSGlobalData now requires us to have initialised JSC's threading
logic, as that also initialises the JSC VM runtime options. WebKit provides a
number of routines that make use of commonJSGlobalData() that can be used before
webcore has called the appropriate initialisation routine. This patch makes the
minimal change of ensuring that commonJSGlobalData initialises threading before
attempting to create the common heap.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonJSGlobalData):

1:40 PM Changeset in webkit [123012] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

Remove some test expectations with my name on it, they are currently passing.

  • platform/chromium/TestExpectations:
1:28 PM Changeset in webkit [123011] by msaboff@apple.com
  • 3 edits in trunk/Source/WebCore

Make TextCodecUTF8 handle 8 bit data without converting to UChar's
https://bugs.webkit.org/show_bug.cgi?id=90320

Reviewed by Oliver Hunt.

Change UTF8 Codec to produce 8-bit strings when data fits in 8-bit range.
First we try decoding the string as all 8-bit and then fall back to 16 bit
when we find the first character that doesn't fit in 8 bits. Then we take
the already decoded data and copy / convert it to a 16-bit buffer and then
continue process the rest of the stream as 16-bits.

No new tests, no change in functionality.

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::handleError):
(WebCore::TextCodecUTF8::decode):

  • platform/text/TextCodecUTF8.h:

(TextCodecUTF8):

1:27 PM Changeset in webkit [123010] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] ewk_cookie_manager_persistent_storage_set is not exported
https://bugs.webkit.org/show_bug.cgi?id=91647

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-18
Reviewed by Gustavo Noronha Silva.

Properly export ewk_cookie_manager_persistent_storage_set in
ewk_cookie_manager.h by using EAPI.

  • UIProcess/API/efl/ewk_cookie_manager.h:
1:25 PM Changeset in webkit [123009] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Chromium Mac: Add TEXTURE_RECTANGLE_ARB support to CCVideoLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=91169

Patch by Sailesh Agrawal <sail@chromium.org> on 2012-07-18
Reviewed by Adrienne Walker.

Source/Platform:

Added a "orientation" field to WebCompositorIOSurfaceQuad. This is used at draw time to flip the texture if necessary.

  • chromium/public/WebCompositorIOSurfaceQuad.h: Added orientation field to the constructor.

(WebKit::WebCompositorIOSurfaceQuad::orientation):
(WebCompositorIOSurfaceQuad): The new orientation field should be set to Flipped if the texture should be flipped when drawing.

Source/WebCore:

This extends CCVideoLayerImpl to support TEXTURE_RECTANGLE_ARB. This texture target is used by the Mac hardware accelerated video decoder.

No new tests (HW video decode on Mac is being tested manually.).

  • platform/chromium/support/WebCompositorIOSurfaceQuad.cpp:

(WebKit::WebCompositorIOSurfaceQuad::create): Added an orientation argument.
(WebKit::WebCompositorIOSurfaceQuad::WebCompositorIOSurfaceQuad): Added an orientation argument.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawIOSurfaceQuad): Added support for non-flipped IOSurface textures.

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium): Changed TextureIOSurfaceProgram to be non-flipped. To draw flipped textures drawIOSurfaceQuad sets a different value for texTransformLocation.

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:

(WebCore::CCIOSurfaceLayerImpl::appendQuads): Updated call to CCIOSurfaceDrawQuad constructor.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads): Added support for drawing TEXTURE_RECTANGLE_ARB textures.

1:22 PM Changeset in webkit [123008] by msaboff@apple.com
  • 6 edits in trunk/Source

Make TextCodecLatin1 handle 8 bit data without converting to UChar's
https://bugs.webkit.org/show_bug.cgi?id=90319

Reviewed by Oliver Hunt.

Source/WebCore:

Updated codec to create 8 bit strings where possible.
We assume that the incoming stream can all be decoded as 8-bit values.
If we find a 16-bit value, we take the already decoded data and
copy / convert it to a 16-bit buffer and then continue process the rest
of the stream as 16-bits.

No new tests, functionality covered with existing tests.

  • platform/text/TextCodecASCIIFastPath.h:

(WebCore::copyASCIIMachineWord):

  • platform/text/TextCodecLatin1.cpp:

(WebCore::TextCodecLatin1::decode):

Source/WTF:

  • wtf/text/StringImpl.h:

(StringImpl): Exported LChar variant of adopt().

  • wtf/text/WTFString.h:

(WTF::String::createUninitialized): Exported LChar variant.

1:21 PM Changeset in webkit [123007] by tony@chromium.org
  • 5 edits in trunk

[chromium] Unreviewed, more compile fixes on Chromium Win.

Source/WebKit/chromium:

  • tests/WebTransformationMatrixTest.cpp:

(WebKit::TEST):

Tools:

  • DumpRenderTree/chromium/TestShellWin.cpp:

(TestShell::waitTestFinished):

  • DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1:09 PM Changeset in webkit [123006] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

Fix up old name in RuleSet::addRulesFromSheet
https://bugs.webkit.org/show_bug.cgi?id=91646

Reviewed by Andreas Kling.

Simple parameter rename, no change in functionality.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Renamed styleSelector to resolver to reflect recent rename of the parameter type.

1:06 PM Changeset in webkit [123005] by scheib@chromium.org
  • 5 edits
    2 adds in trunk

Unify allowfullscreen logic in Document::webkitFullScreenEnabled and fullScreenIsAllowedForElement.
https://bugs.webkit.org/show_bug.cgi?id=91448

Reviewed by Adrienne Walker.

Unifies redundant traversal logic and static cast previously used
to determine if an element or document can be made fullscreen.
This clean up prepares for pointer lock, which will use the same logic.

Added a test to detect an edge case of an owning document with
fullscreen permision moving an iframe to fullscreen, while that iframe
does not have permision for its contents to be made fullscreen.

Source/WebCore:

Test: fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html

  • dom/Document.cpp:

(WebCore::isAttributeOnAllOwners):
(WebCore::Document::fullScreenIsAllowedForElement):
(WebCore::Document::webkitFullscreenEnabled):

LayoutTests:

  • fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent-expected.txt: Added.
  • fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html: Added.
1:01 PM Changeset in webkit [123004] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

[EFL] Add central error management to EFL port
https://bugs.webkit.org/show_bug.cgi?id=91598

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Define possible error types in ErrorsEfl so
that we can reuse the header in both WebKit1
and WebKit2. This is inspired from the GTK
port.

No new tests, no behavior change.

  • PlatformEfl.cmake:
  • platform/efl/ErrorsEfl.cpp: Added.

(WebCore):
(WebCore::cancelledError):
(WebCore::blockedError):
(WebCore::cannotShowURLError):
(WebCore::interruptedForPolicyChangeError):
(WebCore::cannotShowMIMETypeError):
(WebCore::fileDoesNotExistError):
(WebCore::pluginWillHandleLoadError):
(WebCore::downloadNetworkError):
(WebCore::downloadCancelledByUserError):
(WebCore::downloadDestinationError):
(WebCore::printError):
(WebCore::printerNotFoundError):
(WebCore::invalidPageRangeToPrint):

  • platform/efl/ErrorsEfl.h: Added.

(WebCore):

Source/WebKit/efl:

Make use of ErrorsEfl header from WebCore in
EFL's FrameLoaderClient now that we have
a central place for errors.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::cancelledError):
(WebCore::FrameLoaderClientEfl::blockedError):
(WebCore::FrameLoaderClientEfl::cannotShowURLError):
(WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
(WebCore::FrameLoaderClientEfl::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientEfl::fileDoesNotExistError):
(WebCore::FrameLoaderClientEfl::pluginWillHandleLoadError):
(WebCore::FrameLoaderClientEfl::shouldFallBack):

Source/WebKit2:

Make use of ErrorsEfl header from WebCore in
WebKit2, for Ewk_Web_Error and WebErrorsEfl.

  • UIProcess/API/efl/ewk_web_error.cpp:

(ewk_web_error_type_get):

  • UIProcess/API/efl/ewk_web_error.h:
  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:

(WebKit::cancelledError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::fileDoesNotExistError):
(WebKit::pluginWillHandleLoadError):

Tools:

Map WebKitNetworkError to NSURLErrorDomain when
printing in DumpRenderTree so that the output
matches the expected one.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(descriptionSuitableForTestResult):

12:59 PM Changeset in webkit [123003] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix compile on Windows.

148>tests\LayerChromiumTest.cpp(510): warning C4305: 'argument' : truncation from 'double' to 'float'

  • tests/LayerChromiumTest.cpp:
12:59 PM Changeset in webkit [123002] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: start merging port/webkit.py into port/base.py
https://bugs.webkit.org/show_bug.cgi?id=91559

Reviewed by Ojan Vafai.

Since all the non-test port implementations now derive from
WebKitPort, there's no real point in keeping WebKitPort distinct
from Port. This patch starts merging the two by moving nearly
all of the webkit implementations of routines with no default
behavior into base.py. The few that didn't move rely on
additional infrastructure that should be refactored differently
(like the image diffing, which should probably be its own
class) and deserve their own patches.

This patch should just be moving code around, and require no
additional tests; in fact, we can delete the tests that were
asserting virtual methods in the base class.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_search_path):
(Port.check_build):
(Port):
(Port._check_driver):
(Port._check_port_build):
(Port.check_image_diff):
(Port.driver_name):
(Port.default_results_directory):
(Port.to.setup_environ_for_server):
(Port._path_to_apache):
(Port._is_redhat_based):
(Port._is_debian_based):
(Port._apache_config_file_name_for_platform):
(Port._path_to_apache_config_file):
(Port._build_path):
(Port._path_to_driver):
(Port._path_to_webcore_library):
(Port._path_to_helper):
(Port._path_to_image_diff):
(Port._path_to_wdiff):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_httpd_returns_error_code):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort):
(WebKitPort._build_driver_flags):
(WebKitPort._read_image_diff):
(WebKitPort.skipped_layout_tests):

12:51 PM Changeset in webkit [123001] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix crash in DragImageTest caused by r122996
https://bugs.webkit.org/show_bug.cgi?id=91653

Patch by Varun Jain <varunjain@chromium.org> on 2012-07-18
Reviewed by Tony Chang.

Covered by existing DragImageTest.

  • platform/chromium/DragImageChromiumSkia.cpp:

(WebCore::deleteDragImage):

12:31 PM Changeset in webkit [123000] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL] Set a theme for EFL WebKit2 unit test fixture
https://bugs.webkit.org/show_bug.cgi?id=91618

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

The test fixture should load the theme generated by the build
instead of trying to load the system theme.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::SetUp):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::defaultTheme):
(EWK2UnitTest):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:

(EWK2UnitTestEnvironment):

12:26 PM Changeset in webkit [122999] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Implement putIndexKeys in WebIDBObjectStoreImpl
https://bugs.webkit.org/show_bug.cgi?id=91546

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-18
Reviewed by Darin Fisher.

Implement putIndexKeys in the chromium API, so it is callable
from chromium.

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
(WebKit):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

12:23 PM Changeset in webkit [122998] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed compile fix for Android.

More sqrt fixes.

  • tests/CCLayerTreeHostCommonTest.cpp:
11:55 AM Changeset in webkit [122997] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed compile fix for Android.

Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp: In member function 'virtual void<unnamed>::CCDamageTrackerTest_verifyDamageForTransformedLayer_Test::TestBody()':
Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:332: error: call of overloaded 'sqrt(int)' is ambiguous

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

11:43 AM Changeset in webkit [122996] by commit-queue@webkit.org
  • 14 edits in trunk

[chromium] Drag image for image elements should be scaled with device scale factor.
https://bugs.webkit.org/show_bug.cgi?id=89688

Patch by Varun Jain <varunjain@chromium.org> on 2012-07-18
Reviewed by Adam Barth.

.:

  • ManualTests/chromium/drag-image-accounts-for-device-scale.html:

Source/WebCore:

Modified ManualTest: ManualTests/chromium/drag-image-accounts-for-device-scale.html

  • page/Frame.cpp:

(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):

  • platform/chromium/DragImageChromiumSkia.cpp:

(WebCore::dragImageSize):
(WebCore::deleteDragImage):
(WebCore::scaleDragImage):
(WebCore::dissolveDragImageToFraction):
(WebCore::createDragImageFromImage):

  • platform/chromium/DragImageRef.h:

(DragImageChromium):
(WebCore):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(BitmapImageSingleFrameSkia):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
(WebCore::BitmapImageSingleFrameSkia::create):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::NativeImageSkia):

  • platform/graphics/skia/NativeImageSkia.h:

(NativeImageSkia):
(WebCore::NativeImageSkia::resolutionScale):

Source/WebKit/chromium:

  • src/DragClientImpl.cpp:

(WebKit::DragClientImpl::startDrag):

  • tests/DragImageTest.cpp:

(WebCore::TEST):

11:34 AM Changeset in webkit [122995] by tommyw@google.com
  • 4 edits
    2 copies in trunk/Tools

[chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platform class
https://bugs.webkit.org/show_bug.cgi?id=86215

Reviewed by Adam Barth.

Adding a shadow Platform object that is used to override some WebKit::Platform funtions to
instead create mock objects. No actual mock objects created yet.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Copied from Tools/DumpRenderTree/chromium/config.h.

(MockWebKitPlatformSupport::create):
(MockWebKitPlatformSupport::MockWebKitPlatformSupport):
(MockWebKitPlatformSupport::cryptographicallyRandomValues):
(MockWebKitPlatformSupport::createMediaStreamCenter):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Copied from Tools/DumpRenderTree/chromium/config.h.

(MockWebKitPlatformSupport):

  • DumpRenderTree/chromium/config.h:
11:32 AM Changeset in webkit [122994] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaseline 2 tests due to minor changes from r122980.

  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
11:25 AM Changeset in webkit [122993] by shawnsingh@chromium.org
  • 7 edits in trunk/Source/WebKit/chromium

[chromium] Fix style for numeric literals in chromium unit test code
https://bugs.webkit.org/show_bug.cgi?id=91635

Reviewed by Adrienne Walker.

Where possible, removed ".0" and "f" suffixes on numeric literals,
to be more consistent with WebKit style rules.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerQuadTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCQuadCullerTest.cpp:
  • tests/LayerChromiumTest.cpp:
  • tests/WebTransformationMatrixTest.cpp:

(WebKit::TEST):

11:25 AM Changeset in webkit [122992] by commit-queue@webkit.org
  • 9 edits
    2 moves in trunk/Source

[BlackBerry] Move about: URL handling out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91541

Patch by Yong Li <yoli@rim.com> on 2012-07-18
Reviewed by Rob Buis.

Source/WebCore:

Remove about URL handling from our NetworkJob.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::cancelJob):
(WebCore::NetworkJob::sendResponseIfNeeded):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

Source/WebKit:

AboutData.cpp is moved from WebCoreSupport to WebKitSupport.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Move about URL handling code to WebKit/blackberry. Now when WebPage is asked to load an about URL,
it directly calls loadString() with the generated source.

Also move AboutData.h/cpp from WebCoreSupport to WebKitSupport and change their namespace from WebCore
to BlackBerry::WebKit.

The change is very mechanical except "procss total memory usage" in about:memory now only accounts used
bytes and ignore free spaces in malloc.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::loadAbout):
(WebKit):
(BlackBerry::WebKit::WebPage::load):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/AboutData.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp.

(WebKit):
(BlackBerry::WebKit::writeFeatures):
(BlackBerry::WebKit::numberToHTMLTr):
(BlackBerry::WebKit::bool):
(BlackBerry::WebKit::configPage):
(BlackBerry::WebKit::cacheTypeStatisticToHTMLTr):
(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
(BlackBerry::WebKit::memoryPage):

  • WebKitSupport/AboutData.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/AboutData.h.

(WebKit):

11:21 AM Changeset in webkit [122991] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r122984.
http://trac.webkit.org/changeset/122984
https://bugs.webkit.org/show_bug.cgi?id=91171

Broken the shared build, need to export a SkData in skia

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setURLForRect):

11:09 AM Changeset in webkit [122990] by rwlbuis@webkit.org
  • 4 edits in trunk/Source

Source/WebCore: Alignment crash in MIMESniffer
https://bugs.webkit.org/show_bug.cgi?id=89787

Reviewed by Yong Li.

PR 169064

Prevent ASSERT on unaligned data. Special-case handling of unaligned data
to maskedCompareSlowCase.

No test, too hard to reproduce.

  • platform/network/MIMESniffing.cpp:

(std::maskedCompareSlowCase):
(std):
(std::maskedCompare):

Source/WTF: Alignment crash in MIMESniffer
https://bugs.webkit.org/show_bug.cgi?id=89787

Reviewed by Yong Li.

PR 169064

Change isPointerTypeAlignmentOkay so calling it does not require ifdefs.

  • wtf/StdLibExtras.h:

(isPointerTypeAlignmentOkay):

10:58 AM Changeset in webkit [122989] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Convert svg/css/scientific-numbers.html to a text only test
https://bugs.webkit.org/show_bug.cgi?id=91641

Reviewed by Dirk Schulze.

This is a JS test so we don't need the pixel dump.

  • svg/css/script-tests/scientific-numbers.js:
10:57 AM Changeset in webkit [122988] by commit-queue@webkit.org
  • 32 edits
    6 adds in trunk/LayoutTests

[Qt] platform/qt/http tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91119

Patch by Alex Bravo <alex.bravo@nokia.com> on 2012-07-18
Reviewed by Noam Rosenthal.

Rebased platform/qt/http tests and unskipped them from qt-5.0

  • platform/qt/http/tests/loading/simple-subframe-expected.png: Added.
  • platform/qt/http/tests/loading/simple-subframe-expected.txt:
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.png:
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/qt/http/tests/misc/acid2-expected.png:
  • platform/qt/http/tests/misc/acid2-expected.txt:
  • platform/qt/http/tests/misc/acid2-pixel-expected.png:
  • platform/qt/http/tests/misc/acid2-pixel-expected.txt:
  • platform/qt/http/tests/misc/error404-expected.png:
  • platform/qt/http/tests/misc/error404-expected.txt:
  • platform/qt/http/tests/misc/favicon-as-image-expected.png:
  • platform/qt/http/tests/misc/favicon-as-image-expected.txt:
  • platform/qt/http/tests/misc/frame-access-during-load-expected.png:
  • platform/qt/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.png:
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.txt:
  • platform/qt/http/tests/misc/iframe404-expected.png:
  • platform/qt/http/tests/misc/iframe404-expected.txt:
  • platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
  • platform/qt/http/tests/misc/slow-loading-mask-expected.png:
  • platform/qt/http/tests/misc/slow-loading-mask-expected.txt:
  • platform/qt/http/tests/navigation/error404-basic-expected.png: Added.
  • platform/qt/http/tests/navigation/error404-basic-expected.txt:
  • platform/qt/http/tests/navigation/error404-goback-expected.png: Added.
  • platform/qt/http/tests/navigation/error404-goback-expected.txt:
  • platform/qt/http/tests/navigation/error404-subframeload-expected.png: Added.
  • platform/qt/http/tests/navigation/error404-subframeload-expected.txt:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/qt/http/tests/navigation/postredirect-basic-expected.png: Added.
  • platform/qt/http/tests/navigation/postredirect-basic-expected.txt:
  • platform/qt/http/tests/navigation/postredirect-goback1-expected.png: Added.
  • platform/qt/http/tests/navigation/postredirect-goback1-expected.txt:
  • platform/qt/http/tests/uri/css-href-expected.png:
  • platform/qt/http/tests/uri/css-href-expected.txt:
10:43 AM Changeset in webkit [122987] by pierre.rossi@gmail.com
  • 2 edits in trunk/Source/WebKit2

[Qt] QQuickWebView shouldn't recieve mouse events while dialogs are active
https://bugs.webkit.org/show_bug.cgi?id=91634

Reviewed by Alexis Menard.

One side-effect of reimplementing childMouseEventFilter() in r122438 is that it can end up
bypassing the mouseArea mechanism used in QML dialogs and still forward some mouse events
over to the web process. We can rely on the same m_dialogActive mechanism already used for
touch events in there as well.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::childMouseEventFilter): ignore events and return early if a dialog is active.

10:37 AM Changeset in webkit [122986] by pierre.rossi@gmail.com
  • 5 edits in trunk/Source/WebKit2

[Qt] Build fix for ENABLE_TOUCH_EVENTS=0

Rubber-stamped by No'am Rosenthal.

Add the appropriate ENABLE(TOUCH_EVENTS) where they're needed.

  • UIProcess/API/qt/raw/qrawwebview.cpp:
  • UIProcess/API/qt/raw/qrawwebview_p.h: include Platform.h so we can use the ENABLE macro.
  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Also add the missing QFile include.
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::deactivateTapHighlight):

10:22 AM Changeset in webkit [122985] by commit-queue@webkit.org
  • 280 edits in trunk/LayoutTests

[Qt] fast/table tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91621

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-18
Reviewed by Alexis Menard.

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use
'monospace' font when directed, fast/table tests directory needs to be updated.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/fast/table/003-expected.png:
  • platform/qt-5.0/fast/table/003-expected.txt:
  • platform/qt-5.0/fast/table/border-collapsing/004-expected.txt:
  • platform/qt/fast/table/001-expected.png:
  • platform/qt/fast/table/001-expected.txt:
  • platform/qt/fast/table/002-expected.png:
  • platform/qt/fast/table/002-expected.txt:
  • platform/qt/fast/table/004-expected.png:
  • platform/qt/fast/table/004-expected.txt:
  • platform/qt/fast/table/005-expected.png:
  • platform/qt/fast/table/005-expected.txt:
  • platform/qt/fast/table/006-expected.png:
  • platform/qt/fast/table/006-expected.txt:
  • platform/qt/fast/table/007-expected.png:
  • platform/qt/fast/table/007-expected.txt:
  • platform/qt/fast/table/009-expected.png:
  • platform/qt/fast/table/009-expected.txt:
  • platform/qt/fast/table/010-expected.png:
  • platform/qt/fast/table/010-expected.txt:
  • platform/qt/fast/table/011-expected.png:
  • platform/qt/fast/table/011-expected.txt:
  • platform/qt/fast/table/012-expected.png:
  • platform/qt/fast/table/012-expected.txt:
  • platform/qt/fast/table/013-expected.png:
  • platform/qt/fast/table/013-expected.txt:
  • platform/qt/fast/table/014-expected.png:
  • platform/qt/fast/table/014-expected.txt:
  • platform/qt/fast/table/015-expected.png:
  • platform/qt/fast/table/015-expected.txt:
  • platform/qt/fast/table/016-expected.png:
  • platform/qt/fast/table/016-expected.txt:
  • platform/qt/fast/table/017-expected.png:
  • platform/qt/fast/table/017-expected.txt:
  • platform/qt/fast/table/018-expected.png:
  • platform/qt/fast/table/018-expected.txt:
  • platform/qt/fast/table/020-expected.png:
  • platform/qt/fast/table/020-expected.txt:
  • platform/qt/fast/table/021-expected.png:
  • platform/qt/fast/table/021-expected.txt:
  • platform/qt/fast/table/022-expected.png:
  • platform/qt/fast/table/022-expected.txt:
  • platform/qt/fast/table/023-expected.png:
  • platform/qt/fast/table/023-expected.txt:
  • platform/qt/fast/table/025-expected.png:
  • platform/qt/fast/table/025-expected.txt:
  • platform/qt/fast/table/026-expected.png:
  • platform/qt/fast/table/026-expected.txt:
  • platform/qt/fast/table/027-expected.png:
  • platform/qt/fast/table/027-expected.txt:
  • platform/qt/fast/table/027-vertical-expected.png:
  • platform/qt/fast/table/027-vertical-expected.txt:
  • platform/qt/fast/table/028-expected.png:
  • platform/qt/fast/table/028-expected.txt:
  • platform/qt/fast/table/028-vertical-expected.png:
  • platform/qt/fast/table/028-vertical-expected.txt:
  • platform/qt/fast/table/029-expected.png:
  • platform/qt/fast/table/029-expected.txt:
  • platform/qt/fast/table/030-expected.png:
  • platform/qt/fast/table/030-expected.txt:
  • platform/qt/fast/table/033-expected.png:
  • platform/qt/fast/table/033-expected.txt:
  • platform/qt/fast/table/034-expected.png:
  • platform/qt/fast/table/034-expected.txt:
  • platform/qt/fast/table/035-expected.png:
  • platform/qt/fast/table/035-expected.txt:
  • platform/qt/fast/table/035-vertical-expected.png:
  • platform/qt/fast/table/035-vertical-expected.txt:
  • platform/qt/fast/table/036-expected.png:
  • platform/qt/fast/table/036-expected.txt:
  • platform/qt/fast/table/037-expected.png:
  • platform/qt/fast/table/037-expected.txt:
  • platform/qt/fast/table/038-expected.png:
  • platform/qt/fast/table/038-expected.txt:
  • platform/qt/fast/table/038-vertical-expected.png:
  • platform/qt/fast/table/038-vertical-expected.txt:
  • platform/qt/fast/table/039-expected.png:
  • platform/qt/fast/table/039-expected.txt:
  • platform/qt/fast/table/040-expected.png:
  • platform/qt/fast/table/040-expected.txt:
  • platform/qt/fast/table/040-vertical-expected.png:
  • platform/qt/fast/table/040-vertical-expected.txt:
  • platform/qt/fast/table/041-expected.png:
  • platform/qt/fast/table/041-expected.txt:
  • platform/qt/fast/table/100-percent-cell-width-expected.png:
  • platform/qt/fast/table/100-percent-cell-width-expected.txt:
  • platform/qt/fast/table/absolute-table-at-bottom-expected.png:
  • platform/qt/fast/table/absolute-table-at-bottom-expected.txt:
  • platform/qt/fast/table/add-before-anonymous-child-expected.png:
  • platform/qt/fast/table/add-before-anonymous-child-expected.txt:
  • platform/qt/fast/table/align-right-within-left-aligned-div-expected.txt:
  • platform/qt/fast/table/append-cells-expected.png:
  • platform/qt/fast/table/append-cells-expected.txt:
  • platform/qt/fast/table/append-cells2-expected.png:
  • platform/qt/fast/table/append-cells2-expected.txt:
  • platform/qt/fast/table/auto-with-percent-height-expected.png:
  • platform/qt/fast/table/auto-with-percent-height-expected.txt:
  • platform/qt/fast/table/auto-with-percent-height-vertical-expected.png:
  • platform/qt/fast/table/auto-with-percent-height-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/001-expected.png:
  • platform/qt/fast/table/border-collapsing/001-expected.txt:
  • platform/qt/fast/table/border-collapsing/001-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/001-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/002-expected.png:
  • platform/qt/fast/table/border-collapsing/002-expected.txt:
  • platform/qt/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/002-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/003-expected.png:
  • platform/qt/fast/table/border-collapsing/003-expected.txt:
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt:
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-expected.png:
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
  • platform/qt/fast/table/cell-absolute-child-expected.png:
  • platform/qt/fast/table/cell-absolute-child-expected.txt:
  • platform/qt/fast/table/cell-coalescing-expected.png:
  • platform/qt/fast/table/cell-coalescing-expected.txt:
  • platform/qt/fast/table/cell-pref-width-invalidation-expected.png:
  • platform/qt/fast/table/cell-pref-width-invalidation-expected.txt:
  • platform/qt/fast/table/cell-width-auto-expected.png:
  • platform/qt/fast/table/cell-width-auto-expected.txt:
  • platform/qt/fast/table/cellindex-expected.png:
  • platform/qt/fast/table/cellindex-expected.txt:
  • platform/qt/fast/table/click-near-anonymous-table-expected.png:
  • platform/qt/fast/table/click-near-anonymous-table-expected.txt:
  • platform/qt/fast/table/colgroup-preceded-by-caption-expected.png:
  • platform/qt/fast/table/colgroup-preceded-by-caption-expected.txt:
  • platform/qt/fast/table/colgroup-spanning-groups-rules-expected.png:
  • platform/qt/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/qt/fast/table/colspanMinWidth-expected.png:
  • platform/qt/fast/table/colspanMinWidth-expected.txt:
  • platform/qt/fast/table/dynamic-caption-add-before-child-expected.png:
  • platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt:
  • platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.png:
  • platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.txt:
  • platform/qt/fast/table/dynamic-cellpadding-expected.png:
  • platform/qt/fast/table/dynamic-cellpadding-expected.txt:
  • platform/qt/fast/table/dynamic-descendant-percentage-height-expected.png:
  • platform/qt/fast/table/dynamic-descendant-percentage-height-expected.txt:
  • platform/qt/fast/table/early-table-layout-expected.png:
  • platform/qt/fast/table/early-table-layout-expected.txt:
  • platform/qt/fast/table/edge-offsets-expected.png:
  • platform/qt/fast/table/edge-offsets-expected.txt:
  • platform/qt/fast/table/empty-cells-expected.png:
  • platform/qt/fast/table/empty-cells-expected.txt:
  • platform/qt/fast/table/empty-row-crash-expected.png:
  • platform/qt/fast/table/empty-row-crash-expected.txt:
  • platform/qt/fast/table/empty-table-percent-height-expected.png:
  • platform/qt/fast/table/empty-table-percent-height-expected.txt:
  • platform/qt/fast/table/fixed-nested-expected.png:
  • platform/qt/fast/table/fixed-nested-expected.txt:
  • platform/qt/fast/table/fixed-table-non-cell-in-row-expected.png:
  • platform/qt/fast/table/fixed-table-non-cell-in-row-expected.txt:
  • platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt:
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt:
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.txt:
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt:
  • platform/qt/fast/table/fixed-table-with-small-percent-width-expected.txt:
  • platform/qt/fast/table/floating-th-expected.png:
  • platform/qt/fast/table/floating-th-expected.txt:
  • platform/qt/fast/table/floatingTablePaintBackground-expected.png:
  • platform/qt/fast/table/floatingTablePaintBackground-expected.txt:
  • platform/qt/fast/table/form-with-table-style-expected.png:
  • platform/qt/fast/table/form-with-table-style-expected.txt:
  • platform/qt/fast/table/frame-and-rules-expected.png:
  • platform/qt/fast/table/frame-and-rules-expected.txt:
  • platform/qt/fast/table/generated-caption-expected.png:
  • platform/qt/fast/table/generated-caption-expected.txt:
  • platform/qt/fast/table/giantRowspan2-expected.png:
  • platform/qt/fast/table/giantRowspan2-expected.txt:
  • platform/qt/fast/table/inline-form-assert-expected.png:
  • platform/qt/fast/table/inline-form-assert-expected.txt:
  • platform/qt/fast/table/insert-before-anonymous-ancestors-expected.png:
  • platform/qt/fast/table/insert-before-anonymous-ancestors-expected.txt:
  • platform/qt/fast/table/insert-cell-before-form-expected.png:
  • platform/qt/fast/table/insert-cell-before-form-expected.txt:
  • platform/qt/fast/table/insert-row-before-form-expected.png:
  • platform/qt/fast/table/insert-row-before-form-expected.txt:
  • platform/qt/fast/table/invisible-cell-background-expected.png:
  • platform/qt/fast/table/invisible-cell-background-expected.txt:
  • platform/qt/fast/table/large-width-expected.png:
  • platform/qt/fast/table/large-width-expected.txt:
  • platform/qt/fast/table/multiple-captions-display-expected.png:
  • platform/qt/fast/table/multiple-captions-display-expected.txt:
  • platform/qt/fast/table/multiple-percent-height-rows-expected.png:
  • platform/qt/fast/table/multiple-percent-height-rows-expected.txt:
  • platform/qt/fast/table/nested-percent-height-table-expected.png:
  • platform/qt/fast/table/nested-percent-height-table-expected.txt:
  • platform/qt/fast/table/nobr-expected.png:
  • platform/qt/fast/table/nobr-expected.txt:
  • platform/qt/fast/table/overflowHidden-expected.png:
  • platform/qt/fast/table/overflowHidden-expected.txt:
  • platform/qt/fast/table/percent-heights-expected.png:
  • platform/qt/fast/table/percent-heights-expected.txt:
  • platform/qt/fast/table/prepend-in-anonymous-table-expected.png:
  • platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/qt/fast/table/quote-text-around-iframe-expected.png:
  • platform/qt/fast/table/quote-text-around-iframe-expected.txt:
  • platform/qt/fast/table/relative-position-containment-expected.png:
  • platform/qt/fast/table/relative-position-containment-expected.txt:
  • platform/qt/fast/table/relative-position-offsets-expected.png:
  • platform/qt/fast/table/relative-position-offsets-expected.txt:
  • platform/qt/fast/table/relative-position-stacking-expected.png:
  • platform/qt/fast/table/relative-position-stacking-expected.txt:
  • platform/qt/fast/table/remove-td-display-none-expected.png:
  • platform/qt/fast/table/remove-td-display-none-expected.txt:
  • platform/qt/fast/table/replaced-percent-height-expected.png:
  • platform/qt/fast/table/replaced-percent-height-expected.txt:
  • platform/qt/fast/table/row-height-recalc-expected.png:
  • platform/qt/fast/table/row-height-recalc-expected.txt:
  • platform/qt/fast/table/rowindex-expected.png:
  • platform/qt/fast/table/rowindex-expected.txt:
  • platform/qt/fast/table/rowspan-paint-order-expected.png:
  • platform/qt/fast/table/rowspan-paint-order-expected.txt:
  • platform/qt/fast/table/rowspan-paint-order-vertical-expected.png:
  • platform/qt/fast/table/rowspan-paint-order-vertical-expected.txt:
  • platform/qt/fast/table/rtl-cell-display-none-assert-expected.png:
  • platform/qt/fast/table/rtl-cell-display-none-assert-expected.txt:
  • platform/qt/fast/table/rules-attr-dynchange1-expected.png:
  • platform/qt/fast/table/rules-attr-dynchange1-expected.txt:
  • platform/qt/fast/table/rules-attr-dynchange2-expected.png:
  • platform/qt/fast/table/rules-attr-dynchange2-expected.txt:
  • platform/qt/fast/table/spanOverlapRepaint-expected.png:
  • platform/qt/fast/table/spanOverlapRepaint-expected.txt:
  • platform/qt/fast/table/stale-grid-crash-expected.png:
  • platform/qt/fast/table/stale-grid-crash-expected.txt:
  • platform/qt/fast/table/table-after-child-in-table-expected.png:
  • platform/qt/fast/table/table-after-child-in-table-expected.txt:
  • platform/qt/fast/table/table-and-parts-outline-expected.png:
  • platform/qt/fast/table/table-and-parts-outline-expected.txt:
  • platform/qt/fast/table/table-before-child-in-table-expected.png:
  • platform/qt/fast/table/table-before-child-in-table-expected.txt:
  • platform/qt/fast/table/table-cell-after-child-in-block-expected.png:
  • platform/qt/fast/table/table-cell-after-child-in-block-expected.txt:
  • platform/qt/fast/table/table-cell-after-child-in-table-expected.png:
  • platform/qt/fast/table/table-cell-after-child-in-table-expected.txt:
  • platform/qt/fast/table/table-cell-before-child-in-block-expected.png:
  • platform/qt/fast/table/table-cell-before-child-in-block-expected.txt:
  • platform/qt/fast/table/table-cell-before-child-in-table-expected.png:
  • platform/qt/fast/table/table-cell-before-child-in-table-expected.txt:
  • platform/qt/fast/table/table-continuation-outline-paint-crash-expected.png:
  • platform/qt/fast/table/table-continuation-outline-paint-crash-expected.txt:
  • platform/qt/fast/table/table-display-types-expected.png:
  • platform/qt/fast/table/table-display-types-expected.txt:
  • platform/qt/fast/table/table-display-types-strict-expected.png:
  • platform/qt/fast/table/table-display-types-strict-expected.txt:
  • platform/qt/fast/table/table-display-types-vertical-expected.png:
  • platform/qt/fast/table/table-display-types-vertical-expected.txt:
  • platform/qt/fast/table/table-hspace-align-center-expected.png:
  • platform/qt/fast/table/table-hspace-align-center-expected.txt:
  • platform/qt/fast/table/table-row-after-child-in-block-expected.png:
  • platform/qt/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/qt/fast/table/table-row-after-child-in-table-expected.png:
  • platform/qt/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/qt/fast/table/table-row-before-child-in-block-expected.png:
  • platform/qt/fast/table/table-row-before-child-in-block-expected.txt:
  • platform/qt/fast/table/table-row-before-child-in-table-expected.png:
  • platform/qt/fast/table/table-row-before-child-in-table-expected.txt:
  • platform/qt/fast/table/tableInsideCaption-expected.png:
  • platform/qt/fast/table/tableInsideCaption-expected.txt:
  • platform/qt/fast/table/text-field-baseline-expected.png:
  • platform/qt/fast/table/text-field-baseline-expected.txt:
  • platform/qt/fast/table/unbreakable-images-quirk-expected.png:
  • platform/qt/fast/table/unbreakable-images-quirk-expected.txt:
  • platform/qt/fast/table/unused-percent-heights-expected.png:
  • platform/qt/fast/table/unused-percent-heights-expected.txt:
  • platform/qt/fast/table/vertical-align-baseline-expected.png:
  • platform/qt/fast/table/vertical-align-baseline-expected.txt:
10:10 AM Changeset in webkit [122984] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Chrome/Skia: PDF print output does not have clickable links.
https://bugs.webkit.org/show_bug.cgi?id=91171

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2012-07-18
Reviewed by Stephen White.

Connect GraphicsContext::setURLForRect to Skia's new API for annotations.

Printing is not generally testable.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setURLForRect):

9:51 AM Changeset in webkit [122983] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] 0.11 build broken
https://bugs.webkit.org/show_bug.cgi?id=91629

Patch by Philippe Normand <pnormand@igalia.com> on 2012-07-18
Reviewed by Alexis Menard.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkProposeAllocation): Pass null GstStructure to
gst_query_add_allocation_meta(). Our propose-allocation method
is simple enough to not need to set it.

9:46 AM Changeset in webkit [122982] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed TestExpectations update for WK90469.
Coalesce entries for windows flaky crashes related to 90469, and try
skipping a particularly impacted test to see if fails shift elsewhere.
https://bugs.webkit.org/show_bug.cgi?id=90469

  • platform/chromium/TestExpectations:
9:36 AM Changeset in webkit [122981] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: <input type="submit"> unlabelled.
https://bugs.webkit.org/show_bug.cgi?id=91563

Reviewed by Adele Peterson.

Source/WebCore:

Make sure the default value is returned if there is no other value specified.

Test: platform/mac/accessibility/submit-button-default-value.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::title):

LayoutTests:

  • platform/mac/accessibility/submit-button-default-value-expected.txt: Added.
  • platform/mac/accessibility/submit-button-default-value.html: Added.
9:34 AM Changeset in webkit [122980] by shawnsingh@chromium.org
  • 10 edits in trunk

[chromium] Remove awkward anchorPoint usage that implicity affects layer position
https://bugs.webkit.org/show_bug.cgi?id=91472

Reviewed by Adrienne Walker.

Source/WebCore:

Covered by existing layout tests and unit tests, several existing unit tests updated.

In GraphicsLayerChromium, anchorPoint() implicity affects
position(). Therefore, unit tests needed to remember to set
anchorPoint correctly when trying to position layers for
testing. However, it's easy to forget that initialization, and
probably shouldn't be necessary anyway since conceptually
anchorPoint does not affect layer position.

This patch removes the "actualPosition + anchorPoint" quirk in
GraphicsLayerChromium, so that this problem is avoided.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::updateLayerPosition): No longer computes position + anchorPoint. Instead this is done in calcDrawTransformsInternal.
(WebCore::GraphicsLayerChromium::updateLayerSize): No longer affects computation of position.
(WebCore::GraphicsLayerChromium::updateAnchorPoint): No longer affects computation of position
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D): Position is initialized to zero instead of relative to anchorPoint

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsInternal): explicitly use position + anchorPoint in this code, for both layer and replica.

Note that replicaLayer now uses its own anchorPoint, which seems to be more consistent with Safari behavior.

Source/WebKit/chromium:

Unit tests were updated to account for the fact that anchorPoint
and position are now separated.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

LayoutTests:

  • platform/chromium/TestExpectations: marked compositing/reflections/nested-reflection-anchor-point.html as needing

rebaselining. Its behavior should now be similar to Safari.

9:23 AM EFLWebKitTests edited by tmpsantos@gmail.com
(diff)
9:22 AM EFLWebKitTests edited by tmpsantos@gmail.com
(diff)
9:12 AM EFLWebKitTests edited by tmpsantos@gmail.com
(diff)
9:10 AM Changeset in webkit [122979] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [Regression] Save as file is missing in Network panel preview/response tabs.
https://bugs.webkit.org/show_bug.cgi?id=91625

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/HandlerRegistry.js:
  • inspector/front-end/NetworkPanel.js:
8:42 AM Changeset in webkit [122978] by krit@webkit.org
  • 5 edits
    3 adds in trunk

SVG CSS property types with <number> don't support exponents
https://bugs.webkit.org/show_bug.cgi?id=52542

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Parse numbers in SVG presentation attributes with SVG parser to support scientific notations.
The SVG parser is already well tested and has some extra checks for edge like protection from
overflow.

The patch is based upon a patch of Bear Travis.

Test: svg/css/scientific-numbers.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::lex): Use SVG parser to parse numbers of SVG attributes.

  • svg/SVGParserUtilities.cpp:

(WebCore::parseSVGNumber): Added accessor to call from CSSParser with double value.
(WebCore):

  • svg/SVGParserUtilities.h:

(WebCore):

LayoutTests:

Test scientific number values on SVG presentation attributes.

  • svg/css/scientific-numbers-expected.txt: Added.
  • svg/css/scientific-numbers.html: Added.
  • svg/css/script-tests/scientific-numbers.js: Added.
8:39 AM Changeset in webkit [122977] by pfeldman@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: beautify the paused in debugger message, make it configurable from the front-end.
https://bugs.webkit.org/show_bug.cgi?id=91628

Reviewed by Vsevolod Vlasov.

Made message smaller, using consistent font;
Made message configurable from the front-end.

  • English.lproj/localizedStrings.js:
  • inspector/DOMNodeHighlighter.cpp:

(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::setPausedInDebuggerMessage):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawPausedInDebugger):

  • inspector/DOMNodeHighlighter.h:

(InspectorOverlay):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setOverlayMessage):
(WebCore):
(WebCore::InspectorDebuggerAgent::clear):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::setOverlayMessage):

  • inspector/PageDebuggerAgent.h:

(PageDebuggerAgent):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype._setDebuggerPausedDetails):

8:15 AM Changeset in webkit [122976] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

WebCore::StylePropertySet::addParsedProperties - crash
https://bugs.webkit.org/show_bug.cgi?id=91153

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-18
Reviewed by Andreas Kling.

Source/WebCore:

WebKitCSSKeyframeRule::style exposed an immutable StylePropertySet.
Modified to create a mutable copy on demand.

Test: fast/css/css-keyframe-style-mutate-crash.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::mutableProperties): Added, creates a mutable copy of properties as required.
(WebCore::WebKitCSSKeyframeRule::style):

  • css/WebKitCSSKeyframeRule.h:

(WebCore::StyleKeyframe::properties): Made const, use mutableProperties to mutate.

LayoutTests:

  • fast/css/css-keyframe-style-mutate-crash-expected.txt: Added.
  • fast/css/css-keyframe-style-mutate-crash.html: Added.
8:13 AM Changeset in webkit [122975] by kseo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.
https://bugs.webkit.org/show_bug.cgi?id=91595

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-18
Reviewed by Noam Rosenthal.

Internal review by Kwang Yul Seo.

Currently, TextureMapperLayer creates an ImageBuffer as big as
m_state.needsDisplayRect if m_state.needsDispaly is false. The size of
m_state.needsDisplayRect can be bigger than the size of the layerRect, so we may
consume more memory than the size of the layerRect. It even can cause crash if
m_state.needsDisplayRect is too big.

No new tests, covered by existing tests.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore):

8:12 AM Changeset in webkit [122974] by kbalazs@webkit.org
  • 2 edits
    7 adds in trunk/LayoutTests

Unreviewed gardening.
More pixel rebaseline in compositing for qt-5.0-wk2.

Added baselines, mark failing tests.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/images/content-image-change-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
8:07 AM Changeset in webkit [122973] by commit-queue@webkit.org
  • 4 edits
    4 copies
    3 adds in trunk/Tools

[CMake][EFL] Build and run TestWebKitAPI unit tests
https://bugs.webkit.org/show_bug.cgi?id=90671

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Daniel Bates.

This patch enables almost for free a significant amount of test for the
WebKit C API, WTF and KURL. It makes easy for CMake based ports to
enable TestWebKitAPI since the missing bits to implement are
relatively simple.

  • CMakeLists.txt:
  • TestWebKitAPI/CMakeLists.txt: Added.
  • TestWebKitAPI/PlatformEfl.cmake: Added.
  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/config.h:
  • TestWebKitAPI/efl/InjectedBundleController.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::InjectedBundleController::platformInitialize):

  • TestWebKitAPI/efl/PlatformUtilities.cpp: Added.

(TestWebKitAPI):
(Util):
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::URLForNonExistentResource):

  • TestWebKitAPI/efl/PlatformWebView.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::initEcoreEvas):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):

  • TestWebKitAPI/efl/main.cpp: Added.

(checkForUseX11WindowArgument):
(main):

8:04 AM Changeset in webkit [122972] by jason.liu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] We should update the status in NetworkJob if there is a new one from libcurl.
https://bugs.webkit.org/show_bug.cgi?id=91475

Reviewed by Yong Li.

Libcurl sometimes sends multiple status messages, we need to keep the last
one in NetworkJob.
We originally had the m_statusReceived check, then we found out that libcurl
sometimes sent additional 401 codes and added the 401 exception to the check,
and now we're removing the whole check(so we don't need the exception either).

RIM PR# 163172
Reviewed internally by Joe Mason.

No new tests. This is caused by libcurl's multiple status messages.
So we don't need to write a test case for webkit.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyStatusReceived):

7:52 AM Changeset in webkit [122971] by commit-queue@webkit.org
  • 129 edits in trunk/LayoutTests

[Qt] fast/text tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91570

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-18
Reviewed by Simon Hausmann.

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use
'monospace' font when directed, fast/text tests directory needs to be updated.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.png:
  • platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.txt:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/qt-5.0/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/qt-5.0/fast/text/basic/003-expected.png:
  • platform/qt-5.0/fast/text/basic/003-expected.txt:
  • platform/qt-5.0/fast/text/fallback-traits-fixup-expected.txt:
  • platform/qt-5.0/fast/text/international/hindi-whitespace-expected.txt:
  • platform/qt-5.0/fast/text/international/text-spliced-font-expected.png:
  • platform/qt-5.0/fast/text/international/text-spliced-font-expected.txt:
  • platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/qt-5.0/fast/text/large-text-composed-char-expected.png:
  • platform/qt-5.0/fast/text/large-text-composed-char-expected.txt:
  • platform/qt-5.0/fast/text/letter-spacing-negative-opacity-expected.png:
  • platform/qt-5.0/fast/text/letter-spacing-negative-opacity-expected.txt:
  • platform/qt-5.0/fast/text/softHyphen-expected.txt:
  • platform/qt-5.0/fast/text/text-letter-spacing-expected.txt:
  • platform/qt/fast/text/atsui-kerning-and-ligatures-expected.txt:
  • platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png:
  • platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
  • platform/qt/fast/text/backslash-to-yen-sign-dynamic-expected.png:
  • platform/qt/fast/text/backslash-to-yen-sign-dynamic-expected.txt:
  • platform/qt/fast/text/basic/001-expected.png:
  • platform/qt/fast/text/basic/001-expected.txt:
  • platform/qt/fast/text/basic/002-expected.txt:
  • platform/qt/fast/text/basic/004-expected.txt:
  • platform/qt/fast/text/basic/005-expected.txt:
  • platform/qt/fast/text/basic/006-expected.txt:
  • platform/qt/fast/text/basic/007-expected.txt:
  • platform/qt/fast/text/basic/008-expected.txt:
  • platform/qt/fast/text/basic/009-expected.png:
  • platform/qt/fast/text/basic/009-expected.txt:
  • platform/qt/fast/text/basic/011-expected.txt:
  • platform/qt/fast/text/basic/012-expected.txt:
  • platform/qt/fast/text/basic/generic-family-changes-expected.png:
  • platform/qt/fast/text/basic/generic-family-changes-expected.txt:
  • platform/qt/fast/text/basic/generic-family-reset-expected.png:
  • platform/qt/fast/text/basic/generic-family-reset-expected.txt:
  • platform/qt/fast/text/break-word-expected.png:
  • platform/qt/fast/text/break-word-expected.txt:
  • platform/qt/fast/text/capitalize-empty-generated-string-expected.txt:
  • platform/qt/fast/text/capitalize-preserve-nbsp-expected.txt:
  • platform/qt/fast/text/cg-vs-atsui-expected.png:
  • platform/qt/fast/text/cg-vs-atsui-expected.txt:
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.png:
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.txt:
  • platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png:
  • platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt:
  • platform/qt/fast/text/delete-hard-break-character-expected.txt:
  • platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.png:
  • platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
  • platform/qt/fast/text/fake-italic-expected.txt:
  • platform/qt/fast/text/firstline/001-expected.txt:
  • platform/qt/fast/text/firstline/002-expected.txt:
  • platform/qt/fast/text/firstline/003-expected.txt:
  • platform/qt/fast/text/font-initial-expected.txt:
  • platform/qt/fast/text/hyphenate-limit-before-after-expected.png:
  • platform/qt/fast/text/hyphenate-limit-before-after-expected.txt:
  • platform/qt/fast/text/hyphenate-limit-lines-expected.png:
  • platform/qt/fast/text/hyphenate-limit-lines-expected.txt:
  • platform/qt/fast/text/justified-selection-at-edge-expected.txt:
  • platform/qt/fast/text/justified-selection-expected.txt:
  • platform/qt/fast/text/line-breaks-after-white-space-expected.png:
  • platform/qt/fast/text/line-breaks-after-white-space-expected.txt:
  • platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.txt:
  • platform/qt/fast/text/midword-break-hang-expected.txt:
  • platform/qt/fast/text/reset-emptyRun-expected.txt:
  • platform/qt/fast/text/selection-hard-linebreak-expected.png:
  • platform/qt/fast/text/selection-hard-linebreak-expected.txt:
  • platform/qt/fast/text/shadow-no-blur-expected.png:
  • platform/qt/fast/text/shadow-no-blur-expected.txt:
  • platform/qt/fast/text/shadow-translucent-fill-expected.txt:
  • platform/qt/fast/text/should-use-atsui-expected.txt:
  • platform/qt/fast/text/stroking-decorations-expected.txt:
  • platform/qt/fast/text/stroking-expected.txt:
  • platform/qt/fast/text/text-shadow-no-default-color-expected.txt:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.png:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/qt/fast/text/unicode-variation-selector-expected.png:
  • platform/qt/fast/text/unicode-variation-selector-expected.txt:
  • platform/qt/fast/text/updateNewFont-expected.txt:
  • platform/qt/fast/text/wbr-expected.txt:
  • platform/qt/fast/text/wbr-in-pre-crash-expected.txt:
  • platform/qt/fast/text/wbr-pre-expected.png:
  • platform/qt/fast/text/wbr-pre-expected.txt:
  • platform/qt/fast/text/wbr-styled-expected.png:
  • platform/qt/fast/text/wbr-styled-expected.txt:
  • platform/qt/fast/text/whitespace/002-expected.png:
  • platform/qt/fast/text/whitespace/002-expected.txt:
  • platform/qt/fast/text/whitespace/003-expected.png:
  • platform/qt/fast/text/whitespace/003-expected.txt:
  • platform/qt/fast/text/whitespace/006-expected.txt:
  • platform/qt/fast/text/whitespace/007-expected.txt:
  • platform/qt/fast/text/whitespace/008-expected.txt:
  • platform/qt/fast/text/whitespace/009-expected.txt:
  • platform/qt/fast/text/whitespace/012-expected.png:
  • platform/qt/fast/text/whitespace/012-expected.txt:
  • platform/qt/fast/text/whitespace/013-expected.txt:
  • platform/qt/fast/text/whitespace/014-expected.txt:
  • platform/qt/fast/text/whitespace/018-expected.txt:
  • platform/qt/fast/text/whitespace/019-expected.png:
  • platform/qt/fast/text/whitespace/019-expected.txt:
  • platform/qt/fast/text/whitespace/020-expected.txt:
  • platform/qt/fast/text/whitespace/021-expected.txt:
  • platform/qt/fast/text/whitespace/022-expected.png:
  • platform/qt/fast/text/whitespace/022-expected.txt:
  • platform/qt/fast/text/whitespace/023-expected.png:
  • platform/qt/fast/text/whitespace/023-expected.txt:
  • platform/qt/fast/text/whitespace/025-expected.txt:
  • platform/qt/fast/text/whitespace/026-expected.txt:
  • platform/qt/fast/text/whitespace/027-expected.txt:
  • platform/qt/fast/text/whitespace/029-expected.png:
  • platform/qt/fast/text/whitespace/029-expected.txt:
  • platform/qt/fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt:
  • platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/qt/fast/text/whitespace/nowrap-clear-float-expected.txt:
  • platform/qt/fast/text/whitespace/pre-break-word-expected.png:
  • platform/qt/fast/text/whitespace/pre-break-word-expected.txt:
  • platform/qt/fast/text/whitespace/pre-newline-box-test-expected.png:
  • platform/qt/fast/text/whitespace/pre-newline-box-test-expected.txt:
  • platform/qt/fast/text/whitespace/pre-wrap-last-char-expected.txt:
  • platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png:
  • platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.txt:
  • platform/qt/fast/text/whitespace/span-in-word-space-causes-overflow-expected.txt:
7:47 AM Changeset in webkit [122970] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

TOUCH_ADJUSTMENT is too aggressive when snapping to large elements.
https://bugs.webkit.org/show_bug.cgi?id=91262

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-18
Reviewed by Antonio Gomes.

Source/WebCore:

Constrains the extent to which the touch point can be adjusted when
generating synthetic mouse events when TOUCH_ADJUSTEMNT is enabled.
Previously, the target position snapped to the center of the target
element, which can be far removed from the touch position when tapping
on or near a large element. The refined strategy is to leave the
adjusted position unchanged if tapping within the element or to snap
to the center of the overlap region if the touch point lies outside the
bounds of the element, but the touch area and element bounds overlap.
For non-rectilineary bounds, a point lying outside the element boundary
is pulled towards the center of the element, by an amount limited by
the radius of the touch area.

Tests: touchadjustment/big-div.html

touchadjustment/rotated-node.html

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::contentsToWindow):
(TouchAdjustment):
(WebCore::TouchAdjustment::snapTo):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):

LayoutTests:

Adding a test case to ensure that the adjusted touch position is
within the bounds of the target element and the touch area.
Previously, the target position snapped to the center of the target
element, which can be far removed from the touch area.

The second test is for non-rectilinear elements, and verifies that
the touch area must overlap the true bounds of the element for an
adjustment to occur.

  • touchadjustment/big-div-expected.txt: Added.
  • touchadjustment/big-div.html: Added.
  • touchadjustment/rotated-node-expected.txt: Added.
  • touchadjustment/rotated-node.html: Added.
7:41 AM Changeset in webkit [122969] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk/Source/WebKit2

[EFL][WK2] Add Ewk class for cookie manager
https://bugs.webkit.org/show_bug.cgi?id=91053

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-18
Reviewed by Gustavo Noronha Silva.

Add new Ewk_Cookie_Manager class to allow the client
to set/get the cookie acceptance policy, support
persistent cookie storage and clear cookies.

The Ewk_Cookie_Manager instance can be retrieved
from the Ewk_Context API.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(_Ewk_Context::~_Ewk_Context):
(ewk_context_cookie_manager_get):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_cookie_manager.cpp: Added.

(_Ewk_Cookie_Manager):
(_Ewk_Cookie_Manager::_Ewk_Cookie_Manager):
(ewk_cookie_manager_persistent_storage_set):
(ewk_cookie_manager_accept_policy_set):
(Get_Policy_Async_Data):
(getAcceptPolicyCallback):
(ewk_cookie_manager_async_accept_policy_get):
(Get_Hostnames_Async_Data):
(getHostnamesWithCookiesCallback):
(ewk_cookie_manager_async_hostnames_with_cookies_get):
(ewk_cookie_manager_hostname_cookies_clear):
(ewk_cookie_manager_cookies_clear):
(ewk_cookie_manager_free):
(ewk_cookie_manager_new):

  • UIProcess/API/efl/ewk_cookie_manager.h: Added.
  • UIProcess/API/efl/ewk_cookie_manager_private.h: Added.
7:38 AM Changeset in webkit [122968] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, unskipped tests.

  • platform/chromium/TestExpectations:
7:06 AM Changeset in webkit [122967] by kbalazs@webkit.org
  • 25 edits
    3 adds in trunk/LayoutTests

[Qt] editing/input and editing/unsupported-content tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91400

Unreviewed rebaseline.

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-07-18

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
  • platform/qt/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
  • platform/qt/editing/input/emacs-ctrl-o-expected.png:
  • platform/qt/editing/input/emacs-ctrl-o-expected.txt:
  • platform/qt/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
  • platform/qt/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
  • platform/qt/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
  • platform/qt/editing/unsupported-content/list-delete-001-expected.png:
  • platform/qt/editing/unsupported-content/list-delete-001-expected.txt:
  • platform/qt/editing/unsupported-content/list-delete-003-expected.png:
  • platform/qt/editing/unsupported-content/list-delete-003-expected.txt:
  • platform/qt/editing/unsupported-content/list-type-after-expected.png:
  • platform/qt/editing/unsupported-content/list-type-after-expected.txt:
  • platform/qt/editing/unsupported-content/list-type-before-expected.png:
  • platform/qt/editing/unsupported-content/list-type-before-expected.txt:
  • platform/qt/editing/unsupported-content/table-delete-001-expected.png:
  • platform/qt/editing/unsupported-content/table-delete-001-expected.txt:
  • platform/qt/editing/unsupported-content/table-delete-002-expected.png:
  • platform/qt/editing/unsupported-content/table-delete-002-expected.txt:
  • platform/qt/editing/unsupported-content/table-delete-003-expected.png:
  • platform/qt/editing/unsupported-content/table-delete-003-expected.txt:
  • platform/qt/editing/unsupported-content/table-type-after-expected.png:
  • platform/qt/editing/unsupported-content/table-type-after-expected.txt:
  • platform/qt/editing/unsupported-content/table-type-before-expected.png:
  • platform/qt/editing/unsupported-content/table-type-before-expected.txt:
7:04 AM Changeset in webkit [122966] by caseq@chromium.org
  • 12 edits in trunk/Source/WebCore

Web Inspector: adding pause icon for JavaScript debugging
https://bugs.webkit.org/show_bug.cgi?id=90880

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-07-18
Reviewed by Pavel Feldman.

Refactored DOMNodeHighlighter into InspectorOverlay class and added a feature to show a "pause" screen when
the Javascript debugger is paused.

  • inspector/DOMNodeHighlighter.cpp:

(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::drawOutline):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::setPausedInDebugger):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore):
(WebCore::InspectorOverlay::highlightNode):
(WebCore::InspectorOverlay::setHighlightData):
(WebCore::InspectorOverlay::clearHighlightData):
(WebCore::InspectorOverlay::highlightedNode):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawHighlight):
(WebCore::InspectorOverlay::drawPausedInDebugger):

  • inspector/DOMNodeHighlighter.h:

(WebCore):
(InspectorOverlay):
(WebCore::InspectorOverlay::create):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::drawHighlight):
(WebCore::InspectorController::getHighlight):
(WebCore::InspectorController::highlightedNode):

  • inspector/InspectorController.h:

(WebCore):
(InspectorController):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::~InspectorDOMAgent):
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
(WebCore::InspectorDOMAgent::hideHighlight):

  • inspector/InspectorDOMAgent.h:

(WebCore):
(WebCore::InspectorDOMAgent::create):
(InspectorDOMAgent):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::didPaint):

  • inspector/InspectorPageAgent.h:

(WebCore):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::create):
(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::disable):
(WebCore):
(WebCore::PageDebuggerAgent::didPause):
(WebCore::PageDebuggerAgent::didContinue):

  • inspector/PageDebuggerAgent.h:

(WebCore):
(PageDebuggerAgent):

6:51 AM Changeset in webkit [122965] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, updated test expectations.

  • platform/chromium/TestExpectations:
6:46 AM Changeset in webkit [122964] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: intern strings when processing timeline records
https://bugs.webkit.org/show_bug.cgi?id=91531

Reviewed by Pavel Feldman.

  • added StringPool that is capable of interning strings;
  • used it in TimelineModel to process all incoming records;
  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype.reset):

  • inspector/front-end/utilities.js:
6:43 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Form client done! (diff)
6:42 AM Changeset in webkit [122963] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
https://bugs.webkit.org/show_bug.cgi?id=91548

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-18
Reviewed by Kentaro Hara.

Use cl.exe as preprocessor for IDL files rather than cygwin gcc. Cuts
two minute execution time on Windows by a bit better than 50%.

No new tests.

  • WebCore.gyp/WebCore.gyp:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

6:41 AM Changeset in webkit [122962] by pfeldman@chromium.org
  • 16 edits in trunk/Source/WebCore

Web Inspector: remove search replace from behind experiment, polish the behavior
https://bugs.webkit.org/show_bug.cgi?id=91519

Reviewed by Vsevolod Vlasov.

  • This change makes replace loop with no boundary, removes the loop parameter from jumpToNext/Previous;
  • Lays out replace as a second row
  • Fixes replace all with no search matches
  • Splits Search and Search and Replace
  • Introduces explicit Next / Previous buttons in the search mode
  • Introduces editRange on the TextEditor so that it was preserving the undo stack (we'll need to fix editor so that it does not require it).
  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.performSearch):
(WebInspector.ConsolePanel.prototype.jumpToNextSearchResult):
(WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel.prototype.performSearch):
(WebInspector.ExtensionPanel.prototype.jumpToNextSearchResult):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkPanel.prototype.jumpToNextSearchResult):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.performSearch):
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ProfilesPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ResourcesPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
(WebInspector.ScriptsPanel.prototype.replaceAllWith):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype.resetSearch):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._updateReplaceVisibility):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
(WebInspector.SearchController.prototype._updateReplaceDetailsVisibility):
(WebInspector.SearchController.prototype._replace):
(WebInspector.SearchController.prototype._replaceAll):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
(WebInspector.SourceFrame.prototype.replaceSearchMatchWith):
(WebInspector.SourceFrame.prototype.replaceAllWith):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.beforeTextChanged):

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.editRange):

  • inspector/front-end/inspector.css:

(.toolbar-search-replace .search-replace):
(.toolbar-search):
(.toolbar-search-replace):
(.toolbar-search-close-button):
(.toolbar-search-close-button:hover):
(.toolbar-search-close-button:active):
(.toolbar-search input[type="checkbox"]):
(.toolbar-search-replace .toolbar-replace-control):

6:39 AM Changeset in webkit [122961] by Carlos Garcia Campos
  • 9 edits
    5 adds in trunk/Source/WebKit2

[GTK] Add WebKitWebView::submit-form signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=91605

Reviewed by Gustavo Noronha Silva.

The signal is emitted when a form is about to submitted, with a
form submission request that can be used to get the text fields
and to continue the form submission wheh done.

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitFormClient.cpp: Added.

(willSubmitForm): Create a WebKitFormSubmissionRequest and call
webkitWebViewSubmitFormRequest() with the request.
(attachFormClientToView): Add impementation for willSubmitForm
callback.

  • UIProcess/API/gtk/WebKitFormClient.h: Added.
  • UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp: Added.

(webkit_form_submission_request_init):
(webkitFormSubmissionRequestFinalize):
(webkit_form_submission_request_class_init):
(webkitFormSubmissionRequestCreate): Create a new
WebKitFormSubmissionRequest for the given values dictionary and
submission listener.
(webkit_form_submission_request_get_text_fields): Create a
GHashTable with the text fields values and return it.
(webkit_form_submission_request_submit): Continue the form
submission.

  • UIProcess/API/gtk/WebKitFormSubmissionRequest.h: Added.
  • UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Attach web view to form client.
(webkit_web_view_class_init): Add WebKitWebView::submit-form
signal.
(webkitWebViewSubmitFormRequest): Emit WebKitWebView::submit-form
signal.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for

WebKitFormSubmissionRequest.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewSubmitForm):
(beforeAll):

  • UIProcess/API/gtk/webkit2.h: Include

WebKitFormSubmissionRequest.h.

6:27 AM Changeset in webkit [122960] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] No main resource in WebView when page has been loaded from history cache
https://bugs.webkit.org/show_bug.cgi?id=91478

Reviewed by Gustavo Noronha Silva.

We are assuming that a resource loaded for the main frame that is
provisionally loading is the main resource of the web view. However
that's not true for pages loaded from history cache, so when you
go back/forward webkit_web_view_get_main_resource() always returns
NULL. We can assume that the first resource loaded for the main
frame is the main resource of the web view when
pageIsProvisionallyLoading is false.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewResourceLoadStarted): Make sure we always have a
main resource for the web view.

  • UIProcess/API/gtk/tests/TestResources.cpp:

(testWebViewResourcesHistoryCache): Test we always have a main
resource even after going back/forward.
(beforeAll): Add new test case.

6:19 AM Changeset in webkit [122959] by kbalazs@webkit.org
  • 117 edits in trunk/LayoutTests

[Qt] editing/style and editing/undo tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91385

Unreviewed rebaseline.

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-07-18

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/editing/style/4916887-expected.png:
  • platform/qt/editing/style/4916887-expected.txt:
  • platform/qt/editing/style/5017613-1-expected.png:
  • platform/qt/editing/style/5017613-1-expected.txt:
  • platform/qt/editing/style/5017613-2-expected.png:
  • platform/qt/editing/style/5017613-2-expected.txt:
  • platform/qt/editing/style/5046875-1-expected.png:
  • platform/qt/editing/style/5046875-1-expected.txt:
  • platform/qt/editing/style/5046875-2-expected.png:
  • platform/qt/editing/style/5046875-2-expected.txt:
  • platform/qt/editing/style/5065910-expected.png:
  • platform/qt/editing/style/5065910-expected.txt:
  • platform/qt/editing/style/5084241-expected.png:
  • platform/qt/editing/style/5084241-expected.txt:
  • platform/qt/editing/style/5228141-expected.png:
  • platform/qt/editing/style/5228141-expected.txt:
  • platform/qt/editing/style/5279521-expected.png:
  • platform/qt/editing/style/5279521-expected.txt:
  • platform/qt/editing/style/apple-style-editable-mix-expected.png:
  • platform/qt/editing/style/apple-style-editable-mix-expected.txt:
  • platform/qt/editing/style/block-style-001-expected.png:
  • platform/qt/editing/style/block-style-001-expected.txt:
  • platform/qt/editing/style/block-style-002-expected.png:
  • platform/qt/editing/style/block-style-002-expected.txt:
  • platform/qt/editing/style/block-style-003-expected.png:
  • platform/qt/editing/style/block-style-003-expected.txt:
  • platform/qt/editing/style/block-styles-007-expected.png:
  • platform/qt/editing/style/block-styles-007-expected.txt:
  • platform/qt/editing/style/create-block-for-style-001-expected.png:
  • platform/qt/editing/style/create-block-for-style-001-expected.txt:
  • platform/qt/editing/style/create-block-for-style-002-expected.png:
  • platform/qt/editing/style/create-block-for-style-002-expected.txt:
  • platform/qt/editing/style/create-block-for-style-003-expected.png:
  • platform/qt/editing/style/create-block-for-style-003-expected.txt:
  • platform/qt/editing/style/create-block-for-style-004-expected.png:
  • platform/qt/editing/style/create-block-for-style-004-expected.txt:
  • platform/qt/editing/style/create-block-for-style-005-expected.png:
  • platform/qt/editing/style/create-block-for-style-005-expected.txt:
  • platform/qt/editing/style/create-block-for-style-006-expected.png:
  • platform/qt/editing/style/create-block-for-style-006-expected.txt:
  • platform/qt/editing/style/create-block-for-style-007-expected.png:
  • platform/qt/editing/style/create-block-for-style-007-expected.txt:
  • platform/qt/editing/style/create-block-for-style-008-expected.png:
  • platform/qt/editing/style/create-block-for-style-008-expected.txt:
  • platform/qt/editing/style/create-block-for-style-009-expected.png:
  • platform/qt/editing/style/create-block-for-style-009-expected.txt:
  • platform/qt/editing/style/create-block-for-style-010-expected.png:
  • platform/qt/editing/style/create-block-for-style-010-expected.txt:
  • platform/qt/editing/style/create-block-for-style-011-expected.png:
  • platform/qt/editing/style/create-block-for-style-011-expected.txt:
  • platform/qt/editing/style/create-block-for-style-012-expected.png:
  • platform/qt/editing/style/create-block-for-style-012-expected.txt:
  • platform/qt/editing/style/create-block-for-style-013-expected.png:
  • platform/qt/editing/style/create-block-for-style-013-expected.txt:
  • platform/qt/editing/style/designmode-expected.png:
  • platform/qt/editing/style/designmode-expected.txt:
  • platform/qt/editing/style/font-family-with-space-expected.png:
  • platform/qt/editing/style/font-family-with-space-expected.txt:
  • platform/qt/editing/style/highlight-expected.png:
  • platform/qt/editing/style/highlight-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-001-expected.png:
  • platform/qt/editing/style/relative-font-size-change-001-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-002-expected.png:
  • platform/qt/editing/style/relative-font-size-change-002-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-003-expected.png:
  • platform/qt/editing/style/relative-font-size-change-003-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-004-expected.png:
  • platform/qt/editing/style/relative-font-size-change-004-expected.txt:
  • platform/qt/editing/style/smoosh-styles-001-expected.png:
  • platform/qt/editing/style/smoosh-styles-001-expected.txt:
  • platform/qt/editing/style/smoosh-styles-003-expected.png:
  • platform/qt/editing/style/smoosh-styles-003-expected.txt:
  • platform/qt/editing/style/style-3681552-fix-001-expected.png:
  • platform/qt/editing/style/style-3681552-fix-001-expected.txt:
  • platform/qt/editing/style/style-3681552-fix-002-expected.png:
  • platform/qt/editing/style/style-3681552-fix-002-expected.txt:
  • platform/qt/editing/style/style-3998892-fix-expected.png:
  • platform/qt/editing/style/style-3998892-fix-expected.txt:
  • platform/qt/editing/style/style-boundary-001-expected.png:
  • platform/qt/editing/style/style-boundary-001-expected.txt:
  • platform/qt/editing/style/style-boundary-002-expected.png:
  • platform/qt/editing/style/style-boundary-002-expected.txt:
  • platform/qt/editing/style/style-boundary-003-expected.png:
  • platform/qt/editing/style/style-boundary-003-expected.txt:
  • platform/qt/editing/style/style-boundary-004-expected.png:
  • platform/qt/editing/style/style-boundary-004-expected.txt:
  • platform/qt/editing/style/style-boundary-005-expected.png:
  • platform/qt/editing/style/style-boundary-005-expected.txt:
  • platform/qt/editing/style/table-selection-expected.png:
  • platform/qt/editing/style/table-selection-expected.txt:
  • platform/qt/editing/style/typing-style-001-expected.png:
  • platform/qt/editing/style/typing-style-001-expected.txt:
  • platform/qt/editing/style/typing-style-002-expected.png:
  • platform/qt/editing/style/typing-style-002-expected.txt:
  • platform/qt/editing/style/unbold-in-bold-expected.png:
  • platform/qt/editing/style/unbold-in-bold-expected.txt:
  • platform/qt/editing/undo/4063751-expected.png:
  • platform/qt/editing/undo/4063751-expected.txt:
  • platform/qt/editing/undo/redo-typing-001-expected.png:
  • platform/qt/editing/undo/redo-typing-001-expected.txt:
  • platform/qt/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/qt/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/qt/editing/undo/undo-combined-delete-expected.png:
  • platform/qt/editing/undo/undo-combined-delete-expected.txt:
  • platform/qt/editing/undo/undo-delete-boundary-expected.png:
  • platform/qt/editing/undo/undo-delete-boundary-expected.txt:
  • platform/qt/editing/undo/undo-delete-expected.png:
  • platform/qt/editing/undo/undo-delete-expected.txt:
  • platform/qt/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/qt/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/qt/editing/undo/undo-forward-delete-expected.png:
  • platform/qt/editing/undo/undo-forward-delete-expected.txt:
  • platform/qt/editing/undo/undo-typing-001-expected.png:
  • platform/qt/editing/undo/undo-typing-001-expected.txt:
6:19 AM Changeset in webkit [122958] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[WK2][EFL] Divide ENABLE(WEBGL) into ENABLE(WEBGL) and USE(3D_GRAPHICS) in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=91584

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-18
Reviewed by Noam Rosenthal.

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
Modified CMakeLists.txt so that the basic 3D-graphics sources can be compiled even when WebGL is disabled.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::platformGraphicsContext3D):

6:11 AM Changeset in webkit [122957] by kbalazs@webkit.org
  • 2 edits
    10 adds in trunk/LayoutTests

Unreviewed rebaseline of compositing tests on Qt-WebKit2.

Mark pixel tests with wrong output as failing (IMAGE) Rebaseline some pixel
results where only scrollbar theme or antialiasing was the difference
between actual and expected.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/culling/clear-fixed-iframe-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png: Added.
5:59 AM Changeset in webkit [122956] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[CMake][EFL] Building jsc causes reconfiguration
https://bugs.webkit.org/show_bug.cgi?id=91387

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Daniel Bates.

We should remove CMakeCache only when running build-webkit script,
otherwise it will cause a reconfiguration every time someone calls
generateBuildSystemFromCMakeProject(). We were re-building "jsc" and
not running WebKit2 unit tests on the bots because the project was
reconfigured with default values by the scripts that run these tests.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(removeCMakeCache):
(generateBuildSystemFromCMakeProject):

5:59 AM Changeset in webkit [122955] by commit-queue@webkit.org
  • 2 edits
    1 move in trunk/Source/WebKit2

[EFL] Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=91585

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-18
Reviewed by Andreas Kling.

Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
since it implements the platform specific methods of WebInspectorProxy.

  • PlatformEfl.cmake:
  • UIProcess/efl/WebInspectorProxyEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp.

(WebKit):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformBringToFront):
(WebKit::WebInspectorProxy::platformIsFront):
(WebKit::WebInspectorProxy::platformInspectedURLChanged):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):

5:53 AM Changeset in webkit [122954] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, updated test expectations.

  • platform/chromium/TestExpectations:
5:50 AM Changeset in webkit [122953] by zoltan@webkit.org
  • 7 edits in trunk/Source

[Qt] Modify the using of the QImage::Format enum to the appropriate functions from NativeImageQt
https://bugs.webkit.org/show_bug.cgi?id=91600

Reviewed by Andreas Kling.

Use NativeImageQt::defaultFormatForAlphaEnabledImages() and NativeImageQt::defaultFormatForOpaqueImages()
instead of the direct imagetypes at the appropriate places.

Source/WebCore:

Covered by existing tests.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::paintToCanvas):

  • platform/graphics/qt/PathQt.cpp:

(WebCore::scratchContext):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawRepaintCounter):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::updateContents):

Source/WebKit2:

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createQImage):

5:50 AM Changeset in webkit [122952] by commit-queue@webkit.org
  • 11 edits in trunk

[EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=87935

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-18
Reviewed by Andreas Kling.

Source/WebKit/efl:

Add implementation of DumpRenderTreeSupportEfl::evaluateInWebInspector().
Some scripts for test should be evaluated in frontend.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateInWebInspector):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Web Inspector will be shown when path or url contains "inspector/".
Dumprendertree should wait util web inspector resources are loaded totally
and handle the signals for creating or removing a view of web inspector.
("inspector,view,create" and "inspector,view,close")

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(shouldOpenWebInspector):
(createLayoutTestController):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::createWebInspectorView):
(DumpRenderTreeChrome::removeWebInspectorView):
(DumpRenderTreeChrome::waitInspectorLoadFinished):
(DumpRenderTreeChrome::onInspectorViewCreate):
(DumpRenderTreeChrome::onInspectorViewClose):
(DumpRenderTreeChrome::onInspectorFrameLoadFinished):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onConsoleMessage):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::showWebInspector):
(LayoutTestController::closeWebInspector):
(LayoutTestController::evaluateInWebInspector):

LayoutTests:

Remove the following tests from Skipped list.
LayoutTests/inspector
LayoutTests/http/test/inspector
LayoutTests/http/test/inspector-enabled
LayoutTests/http/tests/inspector/network/ping.html

  • platform/efl/Skipped:
5:43 AM Changeset in webkit [122951] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, unskipped tests.

  • platform/chromium/TestExpectations:
5:38 AM Changeset in webkit [122950] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: create timeline detail records lazily
https://bugs.webkit.org/show_bug.cgi?id=91513

Reviewed by Pavel Feldman.

  • only create timeline record details when these are used;
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineRecordListRow.prototype.update):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
(WebInspector.TimelinePresentationModel.Record.prototype._refreshDetails):
(WebInspector.TimelinePresentationModel.Record.prototype.details):

5:16 AM Changeset in webkit [122949] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, unskipped tests.
https://bugs.webkit.org/show_bug.cgi?id=84764
https://bugs.webkit.org/show_bug.cgi?id=84767
https://bugs.webkit.org/show_bug.cgi?id=84768
https://bugs.webkit.org/show_bug.cgi?id=84769
https://bugs.webkit.org/show_bug.cgi?id=84775
https://bugs.webkit.org/show_bug.cgi?id=84776

  • platform/chromium/TestExpectations:
4:53 AM Changeset in webkit [122948] by zeno.albisser@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Caching of ShareableSurfaces breaks tiling.
https://bugs.webkit.org/show_bug.cgi?id=91609

A ShareableSurface should only be cached,
when it is GraphicsSurface based.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):

  • UIProcess/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

4:41 AM Changeset in webkit [122947] by Simon Hausmann
  • 5 edits in trunk

[ANGLE] On QT, use Bison and Flex during ANGLE build
https://bugs.webkit.org/show_bug.cgi?id=91108

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add derived source generators for the two angle bison parsers and flex based lexers.

  • DerivedSources.pri:
  • Target.pri:

Tools:

  • qmake/mkspecs/features/default_post.prf: Add support for variable_out to our generators, to allow

generating not only for SOURCES but also ANGLE_SOURCES (in this bug)

4:30 AM Changeset in webkit [122946] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][WK2] Too early assertion failure if default theme is not available
https://bugs.webkit.org/show_bug.cgi?id=91608

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

After bug 90107 we're setting a default theme path, which leads to a
themeChanged() call initializing edje in createEdje() - if that theme
path is not available we run into a premature assertion failure.
We need to give the embedder a chance to override the default theme path
before failing - so only the usages of m_edje should be guarded with assertions.

No new tests, no change in rendering behavior.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::themePartCacheEntryReset): Adding an assertion to ensure m_edje is present - so that all usages of m_edje are now guarded.
(WebCore::RenderThemeEfl::createEdje): Not hitting assertion if theme path doesn't contain the theme object file, allowing the embedder to override with a new path.

4:30 AM Changeset in webkit [122945] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix a crash due to an invalid assert
https://bugs.webkit.org/show_bug.cgi?id=91614

Reviewed by Xan Lopez.

In webkitWebViewBaseContainerAdd() there's
ASSERT(priv->inspectorView); that should be the opposite, since we
shoulnd't have an inspector view when the inspector view is added.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseContainerAdd):

4:25 AM Changeset in webkit [122944] by Simon Hausmann
  • 4 edits in trunk/Tools

[Qt] plugin tests should not be disabled for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=91604

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2012-07-18
Reviewed by Simon Hausmann.

Instead of not building TestNetscapePlugIn, we could programatically
disable actually loading it from WTR until https://bugs.webkit.org/show_bug.cgi?id=86620
has been solved, so we can still test plugins on WebKit1.

  • Tools.pro:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::initializeTestPluginDirectory):

4:15 AM Changeset in webkit [122943] by commit-queue@webkit.org
  • 6 edits in trunk

[CMake] Make gtest a shared library
https://bugs.webkit.org/show_bug.cgi?id=90973

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Daniel Bates.

.:

It's nicer to make it a shared library because it might improve
linking time and we don't need to force gtest users to link with gtest
dependencies like pthreads (which causes linking errors when it is not
available).

  • Source/cmake/gtest/CMakeLists.txt:

Source/WebKit:

No need to link with gtest dependencies now since it is a shared library.

  • PlatformEfl.cmake:

Source/WebKit2:

No need to link with gtest dependencies now since it is a shared library.

  • PlatformEfl.cmake:
3:54 AM Changeset in webkit [122942] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: IDBLevelDBBackingStore compilation fails because of unused variable.
https://bugs.webkit.org/show_bug.cgi?id=91612

Reviewed by Pavel Feldman.

Replaced ASSERT with ASSERT_UNUSED.

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getObjectStores):

3:31 AM Changeset in webkit [122941] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Add a common code using Color instead of QColor
https://bugs.webkit.org/show_bug.cgi?id=91580

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-18
Reviewed by Simon Hausmann.

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
drawBorder's argument is QColor. So add a common code using Color to be used by Efl.

  • UIProcess/texmap/LayerBackingStore.cpp:

(WebKit::LayerBackingStore::paintToTextureMapper):

3:20 AM Changeset in webkit [122940] by mario@webkit.org
  • 9 edits
    1 add in trunk

[WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK
https://bugs.webkit.org/show_bug.cgi?id=89223

Reviewed by Chris Fleizach.

Tools:

Implemented AccessibilityUIElement in WKTR for GTK, based in the
implementation present in DumpRenderTree.

Added new files in gtk/ and updated the cross-platform ones.

  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp: Added.

(WTR):
(WTR::attributeSetToString):
(WTR::checkElementState):
(WTR::indexRangeInTable):
(WTR::alterCurrentValue):
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::rowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::isActionSupported):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::hierarchicalLevel):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::ariaIsGrabbed):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild):
(WTR::AccessibilityUIElement::accessibilityValue):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::isVisible):
(WTR::AccessibilityUIElement::isOffScreen):
(WTR::AccessibilityUIElement::isCollapsed):
(WTR::AccessibilityUIElement::isIgnored):
(WTR::AccessibilityUIElement::hasPopup):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):

Add documentEncoding and documentURI to AccessibilityUIElement.idl.

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:

LayoutTests:

Removed lines skipping all the accessibility tests and replace
them with the specific ones that are still not passing, which
are just a few now, and will hopefully get fixed later on.

  • platform/gtk-wk2/Skipped: Reduce the list of skipped tests.

Updated two layout tests to consider nulls, something that didn't
happen with DumpRenderTree, but that we need to check now.

  • accessibility/table-cell-spans.html: Update test.
  • accessibility/table-cells.html: Update test.
2:57 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Add form client task (diff)
2:55 AM Changeset in webkit [122939] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, unskipped test.

  • platform/chromium/TestExpectations:
2:49 AM Changeset in webkit [122938] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, unskipped test.

  • platform/chromium/TestExpectations:
2:47 AM Changeset in webkit [122937] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r117738) [Forms] Default step base should be 0 (=1970-01) for input type month
https://bugs.webkit.org/show_bug.cgi?id=91603

Reviewed by Kent Tamura.

This patch restores default step base value to 0 (=1970-01) as before
r117738.

No new tests. Existing test(fast/forms/month/month-stepup-stepdown-from-renderer.html)
covers this case, although it is disabled.

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::createStepRange): Changed default value of
step base to defaultMonthStepBase instead of DateComponents::minimumMonth().

1:57 AM Changeset in webkit [122936] by alexis.menard@openbossa.org
  • 2 edits in trunk/Tools

[EFL] Build fix in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=91567

Reviewed by Kentaro Hara.

sleep() is defined in unistd.h, we need to include it.

  • WebKitTestRunner/efl/TestControllerEfl.cpp:
1:51 AM Changeset in webkit [122935] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, updated test expectations.

  • platform/chromium/TestExpectations:
1:37 AM Changeset in webkit [122934] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Cursor is not drawn when opengl_x11 backend is choosen.
https://bugs.webkit.org/show_bug.cgi?id=89142

Reviewed by Simon Hausmann.

If theme based cursor is not given, WebKit/Efl only uses Ecore_X based
cursor as a fallback after checked whether current engine is using EcoreX.
This patch adds opengl_x11 which is one of Ecore_X based engine in check
lists to draw fallback cursor.

  • platform/efl/EflScreenUtilities.cpp:

(WebCore::isUsingEcoreX):

1:28 AM Changeset in webkit [122933] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, unskipped test.

  • platform/chromium/TestExpectations:
1:20 AM Changeset in webkit [122932] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/Tools

[NRWT] Unreviewed gardening after r122913
https://bugs.webkit.org/show_bug.cgi?id=91601

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.process_kill_time):

1:19 AM Changeset in webkit [122931] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, unskipped test.

  • platform/chromium/TestExpectations:
1:16 AM Changeset in webkit [122930] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r122345): HTMLCollection::length() sometimes returns a wrong value
https://bugs.webkit.org/show_bug.cgi?id=91587

Reviewed by Benjamin Poulain.

Source/WebCore:

The bug was caused by my douchey code that set the length cache to be the *offset*
of the last item in a HTMLCollection. Clearly, the length of a collection that contains
the last item at offset n is n + 1. Fixed that.

Also removed the call to setLengthCache in HTMLCollection::length since it must have set
by previous calls to itemBeforeOrAfterCachedItem already. This will allow us to catch
regressions like this in ports that use JSC bindings as well.

Test: fast/dom/htmlcollection-length-after-item.html

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::itemBeforeOrAfterCachedItem):

LayoutTests:

Add a regression test. It only fails on Chromium port before the patch is applied because JSC binding code
has a bug (?) that it always checks index > length() to throw an exception before accessing an item in HTMLCollection.

  • fast/dom/htmlcollection-length-after-item-expected.txt: Added.
  • fast/dom/htmlcollection-length-after-item.html: Added.
1:14 AM Changeset in webkit [122929] by vsevik@chromium.org
  • 6 edits
    4 deletes in trunk/LayoutTests

Unreviewed chromium gardening, rebaselined tests.

  • platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Removed.
  • platform/chromium-win-xp/fast/inline-block/inline-block-vertical-align-expected.png: Removed.
  • platform/chromium-win-xp/fast/inline/002-expected.png: Removed.
  • platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.png:
  • platform/chromium-win/fast/inline/002-expected.png:
  • platform/chromium-win/fast/table/table-display-types-strict-expected.png:
1:09 AM Changeset in webkit [122928] by yosin@chromium.org
  • 4 edits in trunk/Source

Decimal::toString should not round integer value.
https://bugs.webkit.org/show_bug.cgi?id=91481

Reviewed by Kent Tamura.

Source/WebCore:

This patch makes Decimal::toString not to round an integer value
before converting string.

Tests: WebKit/chromium/tests/DecimalTest.cpp: DecimalTest.toString

  • platform/Decimal.cpp:

(WebCore::Decimal::toString): When the value is an integer, we don't
round coefficient to be DBL_DIG(15) digits because double can
represent an integer without rounding error.

Source/WebKit/chromium:

This patch adds a new test cases for Decimal::toString() for failed
value and maximum coefficient value with various exponent.

  • tests/DecimalTest.cpp:

(TEST_F): DecimalTest.toString: Add test cases for big coefficient values.

1:08 AM Changeset in webkit [122927] by hans@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

Add copy constructor to WebSpeechGrammar.h
https://bugs.webkit.org/show_bug.cgi?id=91484

Reviewed by Adam Barth.

Provide user-defined copy constructor (and assign function) for WebSpeechGrammar.
Without this, we were hitting the implicit copy constructor, which in
turn used the implicit copy constructor of WebPrivatePtr. This was bad,
because the implicit copy constructor wouldn't increace the reference
count on the wrapped object, causing us to crash.

Also add one for WebSpeechRecognitionResult; haven't seen any problems
here, but I noticed it was missing.

  • public/WebSpeechGrammar.h:

(WebKit::WebSpeechGrammar::WebSpeechGrammar):
(WebSpeechGrammar):

  • public/WebSpeechRecognitionResult.h:

(WebKit::WebSpeechRecognitionResult::WebSpeechRecognitionResult):
(WebSpeechRecognitionResult):

  • src/WebSpeechGrammar.cpp:

(WebKit::WebSpeechGrammar::assign):
(WebKit):

1:02 AM Changeset in webkit [122926] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(r122376): It made 68 tests flakey (TEXT PASS)
https://bugs.webkit.org/show_bug.cgi?id=91063

  • platform/qt-5.0-wk2/Skipped: Skip one more test.
  • platform/qt/Skipped: Move a skipped test to the proper Skipped list.
12:51 AM Changeset in webkit [122925] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/Source/ThirdParty/ANGLE

[Qt] Buildfix after r122870.
https://bugs.webkit.org/show_bug.cgi?id=89039

Reviewed by Csaba Osztrogonác

  • src/compiler/preprocessor/new/MacroExpander.cpp:

(pp::MacroExpander::ungetToken):

12:10 AM Changeset in webkit [122924] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the new failing tests.

  • platform/qt/Skipped:
12:09 AM Changeset in webkit [122923] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix null pointer dereference introduced by Changeset 121874.
https://bugs.webkit.org/show_bug.cgi?id=91578

Reviewed by Pavel Feldman.

In http://trac.webkit.org/changeset/121874/trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp I introduced code that
dereferences the return value of ownerDocument() without doing a null check. This was a bad idea.

No new tests. I don't have a repro case, but it is clear from reading the code for ownerDocument() that it can return null.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::ensureSourceData):

Jul 17, 2012:

11:50 PM Changeset in webkit [122922] by yosin@chromium.org
  • 4 edits in trunk/Source

Decimal constructor with 99999999999999999 loses last digit
https://bugs.webkit.org/show_bug.cgi?id=91579

Reviewed by Kent Tamura.

Source/WebCore:

This patch changes maximum coefficient value handling in Decimal::EncodedData
constructor not to lose the last digit. It was used ">=" operator for
comparison instead of ">" operator.

Tests: WebKit/chromium/tests/DecimalTest.cpp

  • platform/Decimal.cpp:

(WebCore::Decimal::EncodedData::EncodedData): Replace ">=" to ">" for
not getting rid of the last digit for maximum coefficient value.

Source/WebKit/chromium:

This patch adds test cases for Decimal::EncodedData constructors for
testing edge cases in addition to common cases which they aren't
covered by other test cases.

  • tests/DecimalTest.cpp:

(EXPECT_DECIMAL_ENCODED_DATA_EQ): Introduce a new macro for ease of
writing test cases for verifying components of Decimal::EncodedData.
(TEST_F): Added a new test entry DecimalTest.Constructor.

11:31 PM Changeset in webkit [122921] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed Web Inspector: followup fix for r122920.

Add collected Loaders size to InspectorMemoryBlock

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):

10:58 PM Changeset in webkit [122920] by loislo@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: show loaders memory consumption on the memory chart.
https://bugs.webkit.org/show_bug.cgi?id=90686

Reviewed by Pavel Feldman.

Size of FrameLoader, DocumentLoader, ResourceLoader and their resources should be shown on the memory pie chart.

It is covered by existing WebInspector performance tests infrastructure.

  • WebCore.exp.in:
  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addRawBuffer):
(WebCore::MemoryInstrumentation::addInstrumentedMemberImpl):
(WebCore):
(WebCore::MemoryClassInfo::addInstrumentedHashSet):
(WebCore::MemoryClassInfo::addRawBuffer):
(WebCore::MemoryInstrumentation::addInstrumentedHashSet):
(WebCore::MemoryInstrumentation::addVector):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):
(WebCore::domTreeInfo):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore):

  • loader/DocumentLoader.h:

(WebCore):
(DocumentLoader):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):
(WebCore):

  • loader/FrameLoader.h:

(WebCore):
(FrameLoader):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):
(WebCore):

  • loader/ResourceLoader.h:

(WebCore):
(ResourceLoader):

  • page/Frame.cpp:

(WebCore::Frame::reportMemoryUsage):
(WebCore):

  • page/Frame.h:

(WebCore):
(Frame):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::reportMemoryUsage):
(WebCore):

  • platform/SharedBuffer.h:

(WebCore):
(SharedBuffer):

9:42 PM Changeset in webkit [122919] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG 32-bit PutById transition stub passes the payload/tag arguments to a DFG operation in the wrong order
https://bugs.webkit.org/show_bug.cgi?id=91576

Reviewed by Gavin Barraclough.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::emitPutTransitionStub):

9:18 PM Changeset in webkit [122918] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Fix an assertion failure in CalendarPickerElement::hostInput().
https://bugs.webkit.org/show_bug.cgi?id=91568

Reviewed by Hajime Morita.

Source/WebCore:

Test: fast/forms/date/calendar-picker-type-change-onclick.html

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::defaultEventHandler):
It's possible that this function is called when the element is detached
from the document tree.

LayoutTests:

  • fast/forms/date/calendar-picker-type-change-onclick-expected.txt: Added.
  • fast/forms/date/calendar-picker-type-change-onclick.html: Added.
9:16 PM Changeset in webkit [122917] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Form state: Make a new class handling HashMap<FormElementKey, Deque<>>
https://bugs.webkit.org/show_bug.cgi?id=91480

Reviewed by Hajime Morita.

This is a preparation of Bug 91209, "Form state restore: Need to
identify a from by its content."

Make a new class which is responsible to handle "HashMap<FormElementKey,
Deque<FormControlState>, FormElementKeyHash, FormElementKeyHashTraits>."
Also, move the FormElementKey class declaration and related structs from
FormController.h to FormController.cpp because FormElementKey is used
only in FormController.cpp.

No new tests. Just a refactoring.

  • html/FormController.cpp:

(WebCore::FormElementKey): Moeved from FormController.h.
(WebCore::FormElementKey::FormElementKey):
Moved from the bottom of FormController.cpp
(WebCore::FormElementKey::~FormElementKey): ditto.
(WebCore::FormElementKey::operator=): ditto.
(WebCore::FormElementKey::ref): ditto.
(WebCore::FormElementKey::deref): ditto.
(WebCore::operator==): Moved from FormController.h
(FormElementKeyHash): ditto.
(WebCore::FormElementKeyHash::equal): ditto.
(WebCore::FormElementKeyHash::hash):
Moved from the bottom of FormController.cpp
(WebCore::FormElementKeyHashTraits::constructDeletedValue):
Moved from FormController.h
(WebCore::FormElementKeyHashTraits::isDeletedValue): ditto.

(WebCore::SavedFormState): Added.
(WebCore::SavedFormState::isEmpty):
(WebCore::SavedFormState::SavedFormState): Added. The constructor.
(WebCore::SavedFormState::create): Added. A factory function.
(WebCore::SavedFormState::appendControlState):
Moved some code from FormController::setStateForNewFormElements.
(WebCore::SavedFormState::takeControlState):
Moved some code from FormController::takeStateForFormElement.

(WebCore::FormController::setStateForNewFormElements):

  • Creates SavedFormState if needed.
  • Uses SavedFormState::appendControlState.

(WebCore::FormController::takeStateForFormElement):
Uses SavedFormState.

  • html/FormController.h:

(FormController):

9:09 PM Changeset in webkit [122916] by yosin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Test cases in DecimalTest should use EXPECT_STREQ for ease of debugging test case
https://bugs.webkit.org/show_bug.cgi?id=91572

Reviewed by Kent Tamura.

This patch introduces EXPECT_DECIMAL_STREQ macro to replace EXPECT_EQ
with String class for displaying text string rather than object dump
for ease of debugging test cases.

  • tests/DecimalTest.cpp:

(DecimalTest::stepDown): Changed to return Decimal instead of String
to use EXPECT_DECIMAL_STREQ.
(DecimalTest::stepUp): ditto.
(TEST_F): Replaced EXPECT_EQ + String class to EXPECT_DECIMAL_STREQ.

9:05 PM Changeset in webkit [122915] by morrita@google.com
  • 5 edits
    2 adds in trunk

[Shadow DOM] Some distribution invalidation can drop necessary reattachment.
https://bugs.webkit.org/show_bug.cgi?id=88843

Reviewed by Dimitri Glazkov.

Source/WebCore:

Following scenario caused this problem:

  • Inserting a Text node as a shadow child triggers invalidateDistribution(), which doen't reattach the shadow's host element.
  • Then inserting a <content> element after that triggers another invalidateDistribution(), which should reattach its host because <content> can affect not only distribution of new nodes, but also existing distribution.
  • Since the first invalidateDistribution() has marked the distribution as invalidated, the second invalidateDistribution() call returns early without any reattachment, even though it needs one.

This change adds InvalidationType parameter to invalidateDistribution(), which asks ElementShadow to
reattach the host regardless of its validity state. InsertionPoint::insertedInto() uses
this flag to ensure that its insertion always results a reattachment.

Test: fast/dom/shadow/content-after-style.html

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::addShadowRoot): Passes InvalidationType.
(WebCore::ElementShadow::removeAllShadowRoots): Passes InvalidationType.
(WebCore::ElementShadow::invalidateDistribution): Added a InvalidationType parameter.

  • dom/ElementShadow.h:
  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::insertedInto): Passes InvalidationType.

LayoutTests:

  • fast/dom/shadow/content-after-style-expected.html: Added.
  • fast/dom/shadow/content-after-style.html: Added.
7:45 PM Changeset in webkit [122914] by wangxianzhu@chromium.org
  • 6 edits in trunk/Tools

[Chromium-Android] Run ref tests together to avoid expensive driver restarts
https://bugs.webkit.org/show_bug.cgi?id=91533

Reviewed by Dirk Pranke.

Though DriverProxy maintains two drivers to support pixel tests and non-pixel tests,
chromium-android uses another way because it can't support multiple drivers.
It restarts the driver when pixel-test mode changes (e.g. when running a ref test after
a normal test in --no-pixel-tests mode). However restarting driver is expensive on
Android (several seconds each time). To reduce the cost, a command line option
'--shard-ref-tests' is added to group ref tests in dedicated shards.
The option is by default enabled on Android.

Will remove the option once DRT supports switching pixel test mode during one run.
(https://bugs.webkit.org/show_bug.cgi?id=91538, https://bugs.webkit.org/show_bug.cgi?id=91539)

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._shard_tests):
(Manager._shard_in_two):
(Manager._shard_by_directory):
(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker._update_test_input):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

6:26 PM Changeset in webkit [122913] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

NRWT The time before server_process kills DRT should be variable
https://bugs.webkit.org/show_bug.cgi?id=91542

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-07-17
Reviewed by Dirk Pranke.

Added the ability to configure the amount of time
server_process waits before killing the DRT process
during the call to stop.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.variable.process_kill_time):

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.stop):

6:16 PM Changeset in webkit [122912] by jonlee@apple.com
  • 7 edits in trunk/Source/WebCore

Teach CodeGenerator to support for static, readonly, attributes
https://bugs.webkit.org/show_bug.cgi?id=88920
<rdar://problem/11650330>

Reviewed by Oliver Hunt.

Update the parser to be able to accept the static keyword for attribute. We will treat static attributes
like custom static functions. They call the implementing class directly, and pass in the ExecState as a script context.

  • bindings/scripts/CodeGeneratorJS.pm:

(GetAttributeGetterName): Factor out the construction of the attribute getter function name.
(GetAttributeSetterName): Factor out the construction of the attribute setter function name.
(GenerateHeader): Determine that a class has read-write properties only if there is a read-write attribute that
is not static.
(GenerateAttributesHashTable): Skip static attributes in the object hash table. They will be added to the constructor
hash table.
(GenerateImplementation): Look for static attributes to add to the constructor hash table. Make a call to the static
function in the class.

  • bindings/scripts/IDLParser.pm:

(ParseInterface): Update the processing because of the regex change.

  • bindings/scripts/IDLStructure.pm: Update the attribute regex.
  • bindings/scripts/test/JS/JSTestObj.cpp: Update test results.
  • bindings/scripts/test/JS/JSTestObj.h: Update test results.
  • bindings/scripts/test/TestObj.idl: Add test cases.
6:12 PM Changeset in webkit [122911] by bashi@chromium.org
  • 8 edits
    4 moves in trunk/Source/WebCore

[Chromium] Rename HarfBuzzFace to HarfBuzzNGFace
https://bugs.webkit.org/show_bug.cgi?id=91458

Reviewed by Tony Chang.

There are HarfbuzzFace class (for old-harfbuzz) and HarfBuzzFace (for harfbuzz-ng) class. The difference is too subtle. Make them more distinct.

No new tests. No changes in behavior.

  • WebCore.gyp/WebCore.gyp: Rename HarfBuzzFace to HarfBuzzNGFace.
  • WebCore.gypi: Ditto.
  • platform/graphics/FontPlatformData.h: Ditto.

(FontPlatformData):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: Ditto.

(WebCore::FontPlatformData::harfbuzzFace):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Ditto.

(WebCore::FontPlatformData::harfbuzzFace):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Ditto.

(FontPlatformData):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCoreText.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp.

(WebCore):
(WebCore::floatToHarfBuzzPosition):
(WebCore::getGlyph):
(WebCore::getGlyphHorizontalAdvance):
(WebCore::getGlyphHorizontalOrigin):
(WebCore::getGlyphExtents):
(WebCore::harfbuzzCoreTextGetFontFuncs):
(WebCore::releaseTableData):
(WebCore::harfbuzzCoreTextGetTable):
(WebCore::HarfBuzzNGFace::createFace):
(WebCore::HarfBuzzNGFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceSkia.cpp.

(WebCore):
(WebCore::SkiaScalarToHarfbuzzPosition):
(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzSkiaGetFontFuncs):
(WebCore::harfbuzzSkiaGetTable):
(WebCore::destroyPaint):
(WebCore::HarfBuzzNGFace::createFace):
(WebCore::HarfBuzzNGFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp.

(WebCore):
(WebCore::harfbuzzFaceCache):
(WebCore::HarfBuzzNGFace::HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::~HarfBuzzNGFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFace.h.

(WebCore):
(HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::create):

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

6:08 PM Changeset in webkit [122910] by kinuko@chromium.org
  • 3 edits in trunk/Source/WebCore

Record metrics to measure the usage of Blob([ArrayBuffer]) to eventually deprecate it
https://bugs.webkit.org/show_bug.cgi?id=90534

Reviewed by Jian Li.

We are removing ArrayBuffer support in Blob constructor (in favor of
ArrayBufferView) but before doing that we should record its use relative to ArrayBufferView.
http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob

No new tests as this has no functional changes.

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::WebKitBlobBuilder::append):

6:07 PM Changeset in webkit [122909] by jsbell@chromium.org
  • 13 edits in trunk

IndexedDB: Key generator state not maintained across connections
https://bugs.webkit.org/show_bug.cgi?id=91456

Reviewed by Tony Chang.

Source/WebCore:

Explicitly store key generator state for each object store in the backing store,
rather than deriving it from the maximum key in the data (which violates the spec
if data is deleted).

This change eliminates a (fragile) per-store cache of the value to simplify the
code. A cache could be re-introduced, requiring an "onbeforecommit" hook for
object stores, but it seems cleaner to save that for a follow-up patch.

Test: storage/indexeddb/key-generator.html

  • Modules/indexeddb/IDBBackingStore.h: New APIs for getting/setting generator states.

(IDBBackingStore):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getObjectStores): Read generator state (but currently ignored).
(WebCore::IDBLevelDBBackingStore::createObjectStore): Write generator state.
(WebCore):
(WebCore::IDBLevelDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber): Update, optionally
checking to see if the new value is greater than the old. (If caller got the value via
getKeyGeneratorCurrentNumber it is safe to skip the check.)

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBLevelDBCoding.cpp:
  • Modules/indexeddb/IDBLevelDBCoding.h:
  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl): Ditch the cache.
(WebCore::IDBObjectStoreBackendImpl::put): No need for abort task.
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys): Ditto.
(WebCore::IDBObjectStoreBackendImpl::putInternal): Use the newfangled APIs below.
(WebCore::IDBObjectStoreBackendImpl::generateKey):
(WebCore::IDBObjectStoreBackendImpl::updateKeyGenerator):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

Source/WebKit/chromium:

Add stub method implementations to test class.

  • tests/IDBFakeBackingStore.h:

LayoutTests:

Added key generator test case that spans database connections.

  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/resources/key-generator.js:

(testAcrossConnections.request.onsuccess.request.onsuccess.request.onsuccess):
(testAcrossConnections.request.onsuccess.request.onsuccess):
(testAcrossConnections.request.onsuccess):
(testAcrossConnections.doFirstWrite.request.onsuccess):
(testAcrossConnections.doFirstWrite):
(testAcrossConnections.closeAndReopen.request.onsuccess):
(testAcrossConnections.closeAndReopen):
(testAcrossConnections.doSecondWrite.request.onsuccess):
(testAcrossConnections.doSecondWrite.trans.oncomplete):
(testAcrossConnections.doSecondWrite):

5:59 PM Changeset in webkit [122908] by tkent@chromium.org
  • 2 edits in branches/chromium/1132

Merge 122212 - RTL calendar picker for <input type=date> is too narrow and clipped
https://bugs.webkit.org/show_bug.cgi?id=90864

Reviewed by Kentaro Hara.

.:

  • ManualTests/forms/calendar-picker.html:
  • Add isRTL:true for the arabic setting
  • Reset the iframe size when the setting is changed.

Source/WebCore:

Tests: ManualTests/forms/calendar-picker.html

  • Resources/calendarPicker.js:

(fixWindowSize):
Checks the left edge of elemenets in RTL.
(layout): Add dir=ltr for the manual test, which re-uses the document.

TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10800003

5:58 PM Changeset in webkit [122907] by alexis.menard@openbossa.org
  • 2 edits in trunk/Tools

webkitdirs.pm should fallback to uname -m if arch is not present.
https://bugs.webkit.org/show_bug.cgi?id=91543

Reviewed by Martin Robinson.

It seems that coreutils is moving away from the 'arch' command. Archlinux
for example doesn't ship it anymore (coreutils 8.17). We can then fallback
to 'uname -m' to find out the architecture.

  • Scripts/webkitdirs.pm:

(determineArchitecture):

5:49 PM Changeset in webkit [122906] by eae@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed chromium windows rebaseline for r122883.

  • platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
  • platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Added.
  • platform/chromium-win-xp/fast/inline-block/inline-block-vertical-align-expected.png: Added.
  • platform/chromium-win-xp/fast/inline/002-expected.png:
5:35 PM Changeset in webkit [122905] by commit-queue@webkit.org
  • 7 edits in trunk

IndexedDB: createIndex should throw INVALID_ACCESS_ERR instead of NOT_SUPPORTED_ERR
https://bugs.webkit.org/show_bug.cgi?id=91553

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-17
Reviewed by Tony Chang.

Source/WebCore:

Update createIndex to throw an INVALID_ACCESS_ERR
as per the IndexedDB spec.

No new tests: existing tests have been updated

  • Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore):

  • Modules/indexeddb/IDBDatabaseException.h:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

LayoutTests:

Update to match IndexedDB spec.

  • storage/indexeddb/keypath-arrays-expected.txt:
  • storage/indexeddb/resources/keypath-arrays.js:

(openSuccess.request.onsuccess):
(openSuccess):

5:32 PM Changeset in webkit [122904] by dpranke@chromium.org
  • 5 edits in trunk/Tools

nrwt: rename printer.print_update to printer.write_update to match metered_stream
https://bugs.webkit.org/show_bug.cgi?id=91557

Reviewed by Ojan Vafai.

Now that all of the printing logic is in printer.py, I want the
public interface to printer to follow the meteredstream
interface where possible. renaming write_update() gets us close.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):
(Manager._set_up_run):
(Manager.start_servers_with_lock):
(Manager.stop_servers_with_lock):
(Manager._clobber_old_results):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.write_update):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.test_write_update):

5:30 PM Changeset in webkit [122903] by pdr@google.com
  • 6 edits in trunk/LayoutTests

Remove entries in TestExpectations for passing non-scaling-stroke-pattern.svg
https://bugs.webkit.org/show_bug.cgi?id=88230

Unreviewed update of test expecatations.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
5:26 PM Changeset in webkit [122902] by tony@chromium.org
  • 3 edits in trunk/Tools

Fix a bug where optimize-baselines would incorrectly fail to optimize
https://bugs.webkit.org/show_bug.cgi?id=91551

Reviewed by Adam Barth.

In some cases, optimize-baseline would correctly optimize the results, but because
we weren't filtering the virtual ports out of _results_by_port_name, we thought
that we had failed to optimize.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(BaselineOptimizer._find_optimal_result_placement): No virtual filtering here.
(BaselineOptimizer._filtered_results_by_port_name): New function that filters out virtual directories.
(BaselineOptimizer.optimize): Filter out virtual ports.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(TestBaselineOptimizer._move_baselines): Add a stub so we don't actual move results.
(BaselineOptimizerTest._assertOptimization): Call optimize and verify that the right files were moved.
(BaselineOptimizerTest._assertOptimizationFailed): Add a method for when optimization should fail.
(BaselineOptimizerTest.test_common_directory_includes_root): Update since this test should fail.
(BaselineOptimizerTest.test_virtual_ports_filtered): New test case that demonstrates the bug.

5:21 PM Changeset in webkit [122901] by wangxianzhu@chromium.org
  • 7 edits in trunk/Tools

[Chromium] Add --encode-binary command line option for DRT
https://bugs.webkit.org/show_bug.cgi?id=91532

Reviewed by Adam Barth.

When the option presents, DRT will encode binary output data in base64.
ChromiumAndroidPort will pass the option because 'adb shell' doesn't support
binary data output.

This change is a refactoring to replace the original hard-coded code for Android.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestEventPrinter.cpp:

(TestEventPrinter::TestEventPrinter):
(TestEventPrinter::handleAudio): New function replacing the original handleAudioHeader
(TestEventPrinter::handleImage):
(TestEventPrinter::handleBinary): Extracted common function for handleAudio and handleImage

  • DumpRenderTree/chromium/TestEventPrinter.h:

(TestEventPrinter):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::initialize):
(TestShell::dump):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):
(TestShell::setEncodeBinary):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py: Add --encode-binary to additional_drt_flags

(ChromiumAndroidPort.init):

5:16 PM Changeset in webkit [122900] by abarth@webkit.org
  • 3 edits
    1 delete in trunk/Source/WebCore

DragImageChromiumMac.cpp is never compiled and can be removed
https://bugs.webkit.org/show_bug.cgi?id=91545

Reviewed by Tony Chang.

This file would only be compiled on chromium-mac, but it's excluded
from that build. This is likely left over from the CG configuration.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/DragImageChromiumMac.cpp: Removed.
5:12 PM Changeset in webkit [122899] by eae@chromium.org
  • 10 edits in trunk/LayoutTests

Unreviewed chromium lion/snowleopard rebaseline for r122883.

  • platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac/fast/block/basic/014-expected.png:
  • platform/chromium-mac/fast/inline/002-expected.png:
  • platform/chromium-mac/fast/table/table-display-types-strict-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
5:03 PM Changeset in webkit [122898] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r122884.
http://trac.webkit.org/changeset/122884
https://bugs.webkit.org/show_bug.cgi?id=91408

Broke the chromium-win build.

  • public/WebIDBMetadata.h:

(WebIDBMetadata):
(WebKit::WebIDBMetadata::WebIDBMetadata):

4:39 PM Changeset in webkit [122897] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt: move per-test result output into printing.py
https://bugs.webkit.org/show_bug.cgi?id=91465

Reviewed by Ojan Vafai.

This moves the last substantive logging/printing code from the
manager into printing.py. Subsequent patches in this thread can
largely focus on cleaning up printing.py and will leave the rest
of the code alone.

This patch also removes manager.update() and
manager.update_summary(), two routines that were no longer being
used or needed (they have been dead for a long time but I didn't
notice them until now).

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.results_directory):
(Manager._look_for_new_crash_logs):
(Manager._update_summary_with_result):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_finished_test):

4:27 PM Changeset in webkit [122896] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Assertion failure/crash on Windows when using a font in an SVG
element with an unresaonbly large font size
https://bugs.webkit.org/show_bug.cgi?id=91273
Radar: <rdar://problem/8355401>

Source/WebCore:

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-17
Reviewed by Tim Horton.

When using a font in an SVG element with an unreasonably large
font size in Windows, WebKit crashes. The problem has to do with
font sizes overflowing into negative values in the Windows specific code.
The fix is to cap the font sizes to something reasonable when the font style is getting processed.
The fix will apply to both CSS and SVG so that behaviour is consistent.

Test: svg/text/font-size-too-large-crash.svg

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyFontSize::applyValue):
This is where the font size capping now occurs. Caps size to 1000000.
Both CSS and SVG reach the font size capping code here.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):
Capping here removed, moved to StyleBuilder.cpp.

LayoutTests:

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-17
Reviewed by Tim Horton.

Test to make sure that having an overly large font size won't crash on Windows.

  • svg/text/font-size-too-large-crash-expected.txt: Added.
  • svg/text/font-size-too-large-crash.svg: Added.
4:23 PM Changeset in webkit [122895] by commit-queue@webkit.org
  • 17 edits
    3 adds in trunk

Add parsing and style application for css3-images image-orientation
https://bugs.webkit.org/show_bug.cgi?id=89624

Patch by David Barr <davidbarr@chromium.org> on 2012-07-17
Reviewed by Tony Chang.

The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation

Source/WebCore:

Test: fast/css/image-orientation/image-orientation.html

  • css/CSSComputedStyleDeclaration.cpp: Add computed style for image-orientation.

(WebCore): Add CSSPropertyImageOrientation to computedProperties.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Map CSSPropertyImageOrientation using cast operator from PrimitiveValueMappings.

  • css/CSSParser.cpp: Add parsing rule for image-orientation.

(WebCore::CSSParser::parseValue): Parse the value of CSSPropertyImageOrientation as an angle.

  • css/CSSPrimitiveValueMappings.h: Add mappings between CSSPrimitiveValue and ImageOrientationEnum.

(WebCore): Add conditional include for ImageOrientation.h.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Map the natural orientations to angles.
(WebCore::CSSPrimitiveValue::operator ImageOrientationEnum): Round angles away from zero to quarter turns and map to the natural orientations.

  • css/CSSProperty.cpp: Add CSSPropertyImageOrientation.

(WebCore::CSSProperty::isInheritedProperty): Map CSSPropertyImageOrientation inherited.

  • css/CSSPropertyNames.in: Add image-orientation.
  • css/StyleBuilder.cpp: Add style application logic for CSSPropertyImageOrientation.

(WebCore::StyleBuilder::StyleBuilder): Map CSSPropertyImageOrientation to RenderStyle::imageOrientation with type ImageOrientationEnum.

  • css/StyleResolver.cpp: Handle CSSPropertyImageOrientation.

(WebCore::StyleResolver::applyProperty): Expect CSSPropertyImageOrientation to be handled by StyleBuilder.

  • rendering/style/RenderStyle.h: Add imageOrientation, setImageOrientation and initialImageOrientation.
  • rendering/style/StyleRareInheritedData.cpp: Add m_imageOrientation.

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Add m_imageOrientation to default and copy contructors.
(WebCore::StyleRareInheritedData::operator==): Include m_imageOrientation in comparison.

  • rendering/style/StyleRareInheritedData.h: Add m_imageOrientation.

(StyleRareInheritedData): Add 4-bit field m_imageOrientation, mapping to ImageOrientationEnum.

LayoutTests:

  • fast/css/image-orientation/image-orientation-expected.txt: Added.
  • fast/css/image-orientation/image-orientation.html: Added.
  • platform/chromium/TestExpectations: Skip tests until image-orientation implementation lands.
  • platform/efl/TestExpectations: Skip tests until image-orientation implementation lands.
  • platform/gtk/TestExpectations: Skip tests until image-orientation implementation lands.
  • platform/mac/TestExpectations: Skip tests until image-orientation implementation lands.
  • platform/qt/TestExpectations: Skip tests until image-orientation implementation lands.
4:20 PM Changeset in webkit [122894] by dpranke@chromium.org
  • 6 edits in trunk/Tools

nrwt: move config-specific logging to printing.py
https://bugs.webkit.org/show_bug.cgi?id=91450

Reviewed by Ojan Vafai.

More refactoring ... this moves the 'config' output to
printing.py.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._resize_shards):
(Manager._run_tests):
(Manager._upload_json_files):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.get_options):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_config):
(Printer.print_workers_and_shards):
(Printer._print_config):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.test_fallback_path_in_config):
(Testprinter.test_print_config):

4:20 PM Changeset in webkit [122893] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

Fix two mistakes I made when modifying TestExpectations.

Apparently the MAC modifier and the FAIL result don't do what I think they do.

  • platform/mac/TestExpectations: Remove MAC and replace FAIL with IMAGE.
4:18 PM Changeset in webkit [122892] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: clean up logging when we're only running one chunk of the tests
https://bugs.webkit.org/show_bug.cgi?id=91447

Reviewed by Ojan Vafai.

Apparently we were creating a 'tests_run.txt' in the results
directory if we were only running one chunk of the tests; after
3+ years of hacking on this code, that was news to me, so I'm
guessing no one uses this. I'm removing this, and changing the
_print_expected calls to debug messages to simplify the
layering.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._split_into_chunks_if_necessary):

4:15 PM Changeset in webkit [122891] by tony@chromium.org
  • 1 edit
    2 moves
    4 deletes in trunk/LayoutTests

Unreviewed, optimize baselines for fast/block/float/02[68].html .

  • fast/block/float/026-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/026-expected.txt.
  • fast/block/float/028-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/028-expected.txt.
  • platform/chromium-mac-snowleopard/fast/block/float/026-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/028-expected.txt: Removed.
  • platform/gtk/fast/block/float/026-expected.txt: Removed.
  • platform/gtk/fast/block/float/028-expected.txt: Removed.
4:13 PM Changeset in webkit [122890] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] REGRESSION (r122494): Running platform/mac/plugins/root-object-premature-delete-crash.html results in a crash
https://bugs.webkit.org/show_bug.cgi?id=91505

Skip this test so we don't see it in the results.

  • platform/mac/Skipped:
4:12 PM Changeset in webkit [122889] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix regression in style checker introduced in r122868.
https://bugs.webkit.org/show_bug.cgi?id=91470

Unreviewed, build fix.

  • Scripts/webkitpy/style/checkers/cpp.py:

(_FileState.init):

4:11 PM Changeset in webkit [122888] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] REGRESSION(r122768, r122771): They broke jquery/data.html and inspector/elements/edit-dom-actions.html
https://bugs.webkit.org/show_bug.cgi?id=91476

Reviewed by Mark Hahnenberg.

The 32-bit repatching code was not correctly adapted to the new world where there may not always
be an available scratch register. Fixed it by ensuring that the scratch register we select does
not overlap with the value tag.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):

4:08 PM Changeset in webkit [122887] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: move the bulk of the "expected" output to printing.py
https://bugs.webkit.org/show_bug.cgi?id=91442

Reviewed by Ojan Vafai.

More printing-related refactoring. This moves all of the code
that prints the results we expect to get, but doesn't move a few
dangling printfs (those'll get hit in a later patch).

No functional changes; covered by existing tests.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._split_into_chunks_if_necessary):
(Manager.prepare_lists_and_print_output):
(Manager.print_config):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_expected):
(Printer):
(Printer._print_expected_results_of_type):
(Printer._num_digits):
(Printer._print_expected):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.test_print_expected):

4:06 PM Changeset in webkit [122886] by enne@google.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r122215) - RenderObject::willRenderImage crashes on null view()
https://bugs.webkit.org/show_bug.cgi?id=91525

Reviewed by Julien Chaffraix.

Fix by doing an early out check. This is intended to fix the crash in
http://crbug.com/137161.

No new test, because unfortunately a layout test is ill-suited to
reproing this kind of Document creation/destruction bug.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willRenderImage):

4:05 PM Changeset in webkit [122885] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] REGRESSION (r122651): fast/text/descent-clip-in-scaled-page.html fails
https://bugs.webkit.org/show_bug.cgi?id=91552

  • platform/mac/TestExpectations: Mark the test as expected to fail.
4:04 PM Changeset in webkit [122884] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h
https://bugs.webkit.org/show_bug.cgi?id=91408

Reviewed by Adam Barth.

This is in support of the new upgradeneeded versioning api.
intVersion will eventually replace the WebString version member.

  • public/WebIDBMetadata.h:

(WebIDBMetadata): The spec uses unsigned long long for version
numbers but we use int64_t here so that we can use -1 as a sentinel.
It indicates that a database still uses a string version.

3:51 PM Changeset in webkit [122883] by eae@chromium.org
  • 36 edits
    2 adds in trunk

vertical-align: middle causes overflow with subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=91464

Reviewed by Eric Seidel.

Source/WebCore:

Using vertical-align: middle in combination with an overflow value other
than visible can cause the overflow height to be computed incorrectly.

Test: fast/sub-pixel/vertical-align-middle-overflow.html

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):
Round verticalPosition after calculation instead of flooring the result
of the xHeight calculation. By flooring it the resulting value is in
effect rounded up which can cause the height of the box to grow by one.
By rounding the resulting value thevertical position is more accurate and
the off by one error is avoided.

LayoutTests:

Add new test for vertical-align: middle and adjust existing results to
reflect the improved alignment calculation.

  • fast/sub-pixel/vertical-align-middle-overflow-expected.txt: Added.
  • fast/sub-pixel/vertical-align-middle-overflow.html: Added.
  • platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.png:
  • platform/chromium-linux/fast/inline/002-expected.png:
  • platform/chromium-linux/fast/table/table-display-types-strict-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/basic/014-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/002-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/table-display-types-strict-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.txt:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-mac/fast/block/basic/014-expected.txt:
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/css1/text_properties/vertical_align-expected.txt:
  • platform/chromium-win/fast/block/basic/014-expected.txt:
  • platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/chromium-win/fast/inline/002-expected.txt:
  • platform/chromium-win/fast/table/table-display-types-strict-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/fast/inline/002-expected.txt:
  • platform/mac/fast/replaced/008-expected.png:
  • platform/mac/fast/table/table-display-types-strict-expected.txt:
3:49 PM Changeset in webkit [122882] by cevans@google.com
  • 2 edits in branches/chromium/1180/Source/WebCore/svg

Merge 122278
BUG=136296
Review URL: https://chromiumcodereview.appspot.com/10778043

3:34 PM Changeset in webkit [122881] by cevans@google.com
  • 1 edit in branches/chromium/1180/Source/WebCore/dom/Element.cpp

Merge 122188
BUG=135698
Review URL: https://chromiumcodereview.appspot.com/10783039

3:22 PM Changeset in webkit [122880] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

A couple of UI nits about the flagging feature in results.html
https://bugs.webkit.org/show_bug.cgi?id=86798

Reviewed by Dirk Pranke.

-Clicking the flag unflags it now
-There's a flag all link for each test list
-Make the flag list always show up at the bottom of the viewport
when there are flagged tests. This makes it both less annoying
and easier to understand what's going on when you flag a test.
This required wrapping all the content in a div so that we could
make the body be a flexbox.

  • fast/harness/resources/results-test.js:

(runSingleRowTest):

  • fast/harness/results.html:
3:16 PM Changeset in webkit [122879] by commit-queue@webkit.org
  • 234 edits in trunk/LayoutTests

[Qt] fast/forms tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91504

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-17
Reviewed by Alexis Menard.

Updated expected Qt results for most fast/forms layout tests, after testfonts changes made by bug 85203.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/qt-5.0/fast/forms/box-shadow-override-expected.png:
  • platform/qt-5.0/fast/forms/box-shadow-override-expected.txt:
  • platform/qt-5.0/fast/forms/form-element-geometry-expected.png:
  • platform/qt-5.0/fast/forms/form-element-geometry-expected.txt:
  • platform/qt-5.0/fast/forms/input-disabled-color-expected.png:
  • platform/qt-5.0/fast/forms/input-disabled-color-expected.txt:
  • platform/qt-5.0/fast/forms/listbox-bidi-align-expected.txt:
  • platform/qt-5.0/fast/forms/menulist-separator-painting-expected.txt:
  • platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/qt-5.0/fast/forms/search-rtl-expected.png:
  • platform/qt-5.0/fast/forms/search-rtl-expected.txt:
  • platform/qt-5.0/fast/forms/select-background-none-expected.txt:
  • platform/qt-5.0/fast/forms/select-baseline-expected.png:
  • platform/qt-5.0/fast/forms/select-baseline-expected.txt:
  • platform/qt-5.0/fast/forms/selectlist-minsize-expected.txt:
  • platform/qt-5.0/fast/forms/textarea-align-expected.png:
  • platform/qt-5.0/fast/forms/textarea-align-expected.txt:
  • platform/qt-5.0/fast/forms/textarea-setinnerhtml-expected.png:
  • platform/qt-5.0/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/qt/fast/forms/003-expected.txt:
  • platform/qt/fast/forms/004-expected.txt:
  • platform/qt/fast/forms/006-expected.txt:
  • platform/qt/fast/forms/007-expected.txt:
  • platform/qt/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/qt/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/qt/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/qt/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/qt/fast/forms/HTMLOptionElement_label05-expected.txt:
  • platform/qt/fast/forms/basic-inputs-expected.png:
  • platform/qt/fast/forms/basic-inputs-expected.txt:
  • platform/qt/fast/forms/basic-selects-expected.png:
  • platform/qt/fast/forms/basic-selects-expected.txt:
  • platform/qt/fast/forms/basic-textareas-quirks-expected.png:
  • platform/qt/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/qt/fast/forms/blankbuttons-expected.png:
  • platform/qt/fast/forms/blankbuttons-expected.txt:
  • platform/qt/fast/forms/button-align-expected.png:
  • platform/qt/fast/forms/button-align-expected.txt:
  • platform/qt/fast/forms/button-cannot-be-nested-expected.png:
  • platform/qt/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/qt/fast/forms/button-default-title-expected.txt:
  • platform/qt/fast/forms/button-generated-content-expected.png:
  • platform/qt/fast/forms/button-generated-content-expected.txt:
  • platform/qt/fast/forms/button-inner-block-reuse-expected.png:
  • platform/qt/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/qt/fast/forms/button-positioned-expected.png:
  • platform/qt/fast/forms/button-positioned-expected.txt:
  • platform/qt/fast/forms/button-sizes-expected.png:
  • platform/qt/fast/forms/button-sizes-expected.txt:
  • platform/qt/fast/forms/button-style-color-expected.png:
  • platform/qt/fast/forms/button-style-color-expected.txt:
  • platform/qt/fast/forms/button-submit-expected.txt:
  • platform/qt/fast/forms/button-table-styles-expected.png:
  • platform/qt/fast/forms/button-table-styles-expected.txt:
  • platform/qt/fast/forms/button-text-transform-expected.png:
  • platform/qt/fast/forms/button-text-transform-expected.txt:
  • platform/qt/fast/forms/caret-rtl-expected.txt:
  • platform/qt/fast/forms/control-clip-expected.txt:
  • platform/qt/fast/forms/control-clip-overflow-expected.png:
  • platform/qt/fast/forms/control-clip-overflow-expected.txt:
  • platform/qt/fast/forms/control-restrict-line-height-expected.png:
  • platform/qt/fast/forms/control-restrict-line-height-expected.txt:
  • platform/qt/fast/forms/disabled-select-change-index-expected.png:
  • platform/qt/fast/forms/disabled-select-change-index-expected.txt:
  • platform/qt/fast/forms/encoding-test-expected.png:
  • platform/qt/fast/forms/encoding-test-expected.txt:
  • platform/qt/fast/forms/fieldset-align-expected.png:
  • platform/qt/fast/forms/fieldset-align-expected.txt:
  • platform/qt/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png:
  • platform/qt/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
  • platform/qt/fast/forms/fieldset-with-float-expected.txt:
  • platform/qt/fast/forms/file/file-input-direction-expected.png:
  • platform/qt/fast/forms/file/file-input-direction-expected.txt:
  • platform/qt/fast/forms/file/file-input-disabled-expected.png:
  • platform/qt/fast/forms/file/file-input-disabled-expected.txt:
  • platform/qt/fast/forms/float-before-fieldset-expected.png:
  • platform/qt/fast/forms/float-before-fieldset-expected.txt:
  • platform/qt/fast/forms/floating-textfield-relayout-expected.png:
  • platform/qt/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/qt/fast/forms/form-added-to-table-expected.txt:
  • platform/qt/fast/forms/form-hides-table-expected.png:
  • platform/qt/fast/forms/form-hides-table-expected.txt:
  • platform/qt/fast/forms/form-in-malformed-markup-expected.txt:
  • platform/qt/fast/forms/formmove-expected.txt:
  • platform/qt/fast/forms/formmove2-expected.txt:
  • platform/qt/fast/forms/formmove3-expected.png:
  • platform/qt/fast/forms/formmove3-expected.txt:
  • platform/qt/fast/forms/hidden-listbox-expected.txt:
  • platform/qt/fast/forms/image-border-expected.txt:
  • platform/qt/fast/forms/indeterminate-expected.txt:
  • platform/qt/fast/forms/input-align-expected.png:
  • platform/qt/fast/forms/input-align-expected.txt:
  • platform/qt/fast/forms/input-align-image-expected.txt:
  • platform/qt/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/qt/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/qt/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/qt/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/qt/fast/forms/input-appearance-disabled-expected.png:
  • platform/qt/fast/forms/input-appearance-disabled-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.png:
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/qt/fast/forms/input-appearance-readonly-expected.png:
  • platform/qt/fast/forms/input-appearance-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.png:
  • platform/qt/fast/forms/input-appearance-selection-expected.txt:
  • platform/qt/fast/forms/input-appearance-visibility-expected.png:
  • platform/qt/fast/forms/input-appearance-visibility-expected.txt:
  • platform/qt/fast/forms/input-baseline-expected.png:
  • platform/qt/fast/forms/input-baseline-expected.txt:
  • platform/qt/fast/forms/input-button-sizes-expected.png:
  • platform/qt/fast/forms/input-button-sizes-expected.txt:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/qt/fast/forms/input-field-text-truncated-expected.png:
  • platform/qt/fast/forms/input-field-text-truncated-expected.txt:
  • platform/qt/fast/forms/input-first-letter-expected.txt:
  • platform/qt/fast/forms/input-no-renderer-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/qt/fast/forms/input-readonly-dimmed-expected.png:
  • platform/qt/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/qt/fast/forms/input-readonly-empty-expected.png:
  • platform/qt/fast/forms/input-readonly-empty-expected.txt:
  • platform/qt/fast/forms/input-spaces-expected.png:
  • platform/qt/fast/forms/input-spaces-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.png:
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.png:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.png:
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/input-text-word-wrap-expected.png:
  • platform/qt/fast/forms/input-text-word-wrap-expected.txt:
  • platform/qt/fast/forms/input-width-expected.png:
  • platform/qt/fast/forms/input-width-expected.txt:
  • platform/qt/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/qt/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
  • platform/qt/fast/forms/menulist-clip-expected.png:
  • platform/qt/fast/forms/menulist-clip-expected.txt:
  • platform/qt/fast/forms/menulist-deselect-update-expected.txt:
  • platform/qt/fast/forms/menulist-no-overflow-expected.txt:
  • platform/qt/fast/forms/menulist-option-wrap-expected.png:
  • platform/qt/fast/forms/menulist-option-wrap-expected.txt:
  • platform/qt/fast/forms/menulist-style-color-expected.png:
  • platform/qt/fast/forms/menulist-style-color-expected.txt:
  • platform/qt/fast/forms/minWidthPercent-expected.png:
  • platform/qt/fast/forms/minWidthPercent-expected.txt:
  • platform/qt/fast/forms/negativeLineHeight-expected.png:
  • platform/qt/fast/forms/negativeLineHeight-expected.txt:
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/qt/fast/forms/option-index-expected.txt:
  • platform/qt/fast/forms/option-script-expected.txt:
  • platform/qt/fast/forms/option-strip-whitespace-expected.txt:
  • platform/qt/fast/forms/option-text-clip-expected.txt:
  • platform/qt/fast/forms/placeholder-position-expected.png:
  • platform/qt/fast/forms/placeholder-position-expected.txt:
  • platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/qt/fast/forms/range/input-appearance-range-expected.png:
  • platform/qt/fast/forms/range/input-appearance-range-expected.txt:
  • platform/qt/fast/forms/range/range-thumb-height-percentage-expected.png:
  • platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/qt/fast/forms/range/slider-padding-expected.png:
  • platform/qt/fast/forms/range/slider-padding-expected.txt:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.png:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.png:
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
  • platform/qt/fast/forms/select-align-expected.txt:
  • platform/qt/fast/forms/select-block-background-expected.txt:
  • platform/qt/fast/forms/select-change-listbox-size-expected.txt:
  • platform/qt/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/qt/fast/forms/select-change-popup-to-listbox-expected.txt:
  • platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/qt/fast/forms/select-disabled-appearance-expected.txt:
  • platform/qt/fast/forms/select-display-none-style-resolve-expected.txt:
  • platform/qt/fast/forms/select-empty-option-height-expected.txt:
  • platform/qt/fast/forms/select-initial-position-expected.txt:
  • platform/qt/fast/forms/select-item-background-clip-expected.txt:
  • platform/qt/fast/forms/select-list-box-with-height-expected.txt:
  • platform/qt/fast/forms/select-listbox-multiple-no-focusring-expected.png:
  • platform/qt/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
  • platform/qt/fast/forms/select-overflow-scroll-expected.png:
  • platform/qt/fast/forms/select-overflow-scroll-expected.txt:
  • platform/qt/fast/forms/select-overflow-scroll-inherited-expected.png:
  • platform/qt/fast/forms/select-overflow-scroll-inherited-expected.txt:
  • platform/qt/fast/forms/select-selected-expected.txt:
  • platform/qt/fast/forms/select-size-expected.txt:
  • platform/qt/fast/forms/select-style-expected.txt:
  • platform/qt/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/qt/fast/forms/targeted-frame-submission-expected.png:
  • platform/qt/fast/forms/targeted-frame-submission-expected.txt:
  • platform/qt/fast/forms/text-style-color-expected.png:
  • platform/qt/fast/forms/text-style-color-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/qt/fast/forms/textarea-scrollbar-expected.png:
  • platform/qt/fast/forms/textarea-scrollbar-expected.txt:
  • platform/qt/fast/forms/textarea-scrolled-type-expected.png:
  • platform/qt/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/qt/fast/forms/textfield-focus-ring-expected.png:
  • platform/qt/fast/forms/textfield-focus-ring-expected.txt:
  • platform/qt/fast/forms/textfield-outline-expected.png:
  • platform/qt/fast/forms/textfield-outline-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-by-value-update-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.png:
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
3:08 PM Changeset in webkit [122878] by commit-queue@webkit.org
  • 14 edits in trunk/LayoutTests

[Qt] svg/transforms tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91501

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-17
Reviewed by Alexis Menard.

Updated expected Qt results for most svg/transforms layout tests, after testfonts changes made by bug 85203.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.txt:
  • platform/qt/svg/transforms/svg-css-transforms-clip-path-expected.png:
  • platform/qt/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/qt/svg/transforms/svg-css-transforms-expected.png:
  • platform/qt/svg/transforms/svg-css-transforms-expected.txt:
3:05 PM Changeset in webkit [122877] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1180

Merge 122293
BUG=135071
Review URL: https://chromiumcodereview.appspot.com/10704255

2:47 PM Changeset in webkit [122876] by jpetsovits@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove unnecessary clearWindow() calls and the method itself
https://bugs.webkit.org/show_bug.cgi?id=91540
RIM PR 174365

Reviewed by Adam Treat.

If we resume the backingstore right afterwards with
RenderAndBlit then that'll fill the whole visible area
with content, making a clearWindow() call unnecessary.
This call is a remnant from ages ago, and is well suited
to disappear into nothingness.

(There is still a clearWindow() call, with rect argument,
which we continue using. This commit only removes the
rect-less version.)

  • Api/BackingStore.cpp:
  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):

2:43 PM Changeset in webkit [122875] by pdr@google.com
  • 5 edits in trunk/Source/WebCore

Move zero-length-subpaths from RenderSVGShape to RenderSVGPath
https://bugs.webkit.org/show_bug.cgi?id=90716

Reviewed by Nikolas Zimmermann.

Previously zero-length-subpath code was present in RenderSVGShape but it is
only needed in RenderSVGPath. This patch moves the zero-length-subpath code
to RenderSVGPath.

In this change, we gain:
1) Ellipses, Circles, and Rects will no longer carry an empty Vector nor

checks for zero-length subpaths which (per the spec) they cannot have.

2) RenderSVGShape, the superclass of all shape rendering, has been

drastically simplified by removing 70 lines of code that only applies
to Path rendering. This generally aids in code understandability.

The patch is primarily a straightforward code move but useStrokeStyleToFill
needs further explanation:
Zero-length-subpaths are drawn using rectangular and circular paths which
are filled.
Previously in RenderSVGShape::fillAndStrokePath, strokePath was called for
the main path with ApplyToStrokeMode and then strokePath was called for
each zero-length-subpath with ApplyToFillMode.
ApplyToFillMode had the effect of setting the context's stroke style to
the fill style so zero-length-subpaths were "filled" with the stroke style.
After this patch, the context is only setup once (which is faster!) using
ApplyToStrokeMode so we manually set the stroke style to the fill style
using useStrokeStyleToFill.

No new tests, just a refactoring.

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::updateShapeFromElement):
(WebCore):
(WebCore::RenderSVGPath::calculateUpdatedStrokeBoundingBox):
(WebCore::useStrokeStyleToFill):
(WebCore::RenderSVGPath::strokeShape):
(WebCore::RenderSVGPath::shapeDependentStrokeContains):
(WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGPath::zeroLengthLinecapPath):
(WebCore::RenderSVGPath::zeroLengthSubpathRect):
(WebCore::RenderSVGPath::updateZeroLengthSubpaths):

  • rendering/svg/RenderSVGPath.h:

(RenderSVGPath):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore::RenderSVGShape::strokeShape):
(WebCore::RenderSVGShape::strokeContains):
(WebCore):
(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::fillAndStrokeShape):
(WebCore::RenderSVGShape::paint):
(WebCore::RenderSVGShape::calculateStrokeBoundingBox):

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::hasPath):
(WebCore::RenderSVGShape::hasNonScalingStroke):
(RenderSVGShape):
(WebCore::RenderSVGShape::strokeBoundingBox):

2:33 PM Changeset in webkit [122874] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.
Mark media/media-continues-playing-after-replace-source.html as flaky.

  • platform/chromium/TestExpectations:
1:56 PM Changeset in webkit [122873] by rniwa@webkit.org
  • 6 edits
    2 adds in trunk

invalidateNodeListCachesInAncestors walks up ancestors even when an attribute that doesn't invalidate node lists changes
https://bugs.webkit.org/show_bug.cgi?id=91530

Reviewed by Ojan Vafai.

Source/WebCore:

The bug was caused by invalidateNodeListCachesInAncestors not calling Document::shouldInvalidateNodeListCaches with
attrName. Done that.

This chance revealed a bug in shouldInvalidateTypeOnAttributeChange that we weren't checking form attribute changes for
RadioNodeList and HTMLCollection, so fixed the bug.

Also renamed Document::clearNodeListCaches to invalidateNodeListCaches to match the name convention used elsewhere,
and added a new version of DynamicNodeListCacheBase::invalidateCache that takes attrName to reduce the code duplication.

Test: fast/forms/elements-invalidate-on-form-attribute-invalidation.html

  • dom/Document.cpp:

(WebCore::Document::invalidateNodeListCaches):

  • dom/Document.h:

(Document):

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange):

  • dom/Node.cpp:

(WebCore::Node::invalidateNodeListCachesInAncestors):
(WebCore::NodeListsNodeData::invalidateCaches):

LayoutTests:

Add a regression test for invalidating HTMLFormColletion on form attribute changes. This invalidation worked before
because we weren't properly exiting early in Node::invalidateNodeListCachesInAncestors and
Document::invalidateNodeListCaches invalidated all node lists regardless of the attribute type.

  • fast/forms/elements-invalidate-on-form-attribute-invalidation-expected.txt: Added.
  • fast/forms/elements-invalidate-on-form-attribute-invalidation.html: Added.
1:44 PM Changeset in webkit [122872] by fmalita@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

SVG getBBox does not update bound after path data change
https://bugs.webkit.org/show_bug.cgi?id=82629

Reviewed by Dirk Schulze.

The bug appears to have been fixed - adding a test for it.

  • svg/custom/path-bbox-update-expected.txt: Added.
  • svg/custom/path-bbox-update.html: Added.
1:24 PM Changeset in webkit [122871] by tony@chromium.org
  • 3 edits
    2 copies
    1 add in trunk/LayoutTests

[chromium] Unreviewed gardening. Add baselines after r122861.

  • platform/chromium-mac-snowleopard/fast/block/float/026-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/block/float/026-expected.txt.
  • platform/chromium-mac-snowleopard/fast/block/float/028-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/block/float/028-expected.txt.
  • platform/chromium-mac/fast/block/float/026-expected.txt:
  • platform/chromium-mac/fast/block/float/028-expected.txt:
  • platform/chromium-mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
1:18 PM Changeset in webkit [122870] by Alexandru Chiculita
  • 81 edits
    47 adds
    11 deletes in trunk/Source

Update ANGLE in WebKit
https://bugs.webkit.org/show_bug.cgi?id=89039

Reviewed by Dean Jackson and Mark Rowe.

Update ANGLE to r1170, with the following modifications:

(1) Use Bison 2.3 instead of Bison 2.4.2 to generate ExpressionParser.cpp and
glslang_tab.cpp. I had to modify ExpressionParser.y to make it compatible with Bison
2.3. The changes have been contributed back to ANGLE in r1224.

(2) Continue to recognize QNX as POSIX in ANGLE. This has been contributed back to ANGLE
in r1223.

(3) Rename ANGLE/src/compiler/preprocessor/new/Diagnostic.cpp to DiagnosticBase.cpp.
Rename ANGLE/src/compiler/preprocessor/new/DirectiveHandler.cpp to DirectiveHandlerBase.cpp.

With the introduction of ANGLE's new preprocessor, there were two files named Diagnostic.cpp
in ANGLE under different folders. This caused problems on the QT build when their object
files, both named Diagnostic.o, tried to go in the same folder. Renaming one of them to
DiagnosticBase.cpp avoids this conflict. The same situation occurred with
DirectiveHandler.cpp. I will work on contributing this change back to ANGLE for future
updates.

(4) Add the following lines to glslang.y and ExpressionParser.y:
#define YYENABLE_NLS 0
#define YYLTYPE_IS_TRIVIAL 1

Bison 2.3 doesn't first check that these macros are defined before reading their value,
which causes the QT build to fail.

We work around this issue in the same way in CSSGrammar.y.

I will work on contributing this change back to ANGLE.

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj/project.pbxproj:
  • include/GLES2/gl2ext.h:
  • include/GLSLANG/ShaderLang.h:
  • src/build_angle.xcodeproj/project.pbxproj:
  • src/common/angleutils.h:
  • src/common/debug.cpp:

(gl):
(gl::output):
(gl::trace):
(gl::perfActive):
(gl::ScopedPerfEventHelper::ScopedPerfEventHelper):
(gl::ScopedPerfEventHelper::~ScopedPerfEventHelper):

  • src/common/version.h:
  • src/compiler/BuiltInFunctionEmulator.cpp:

(BuiltInFunctionEmulator::IdentifyFunction):

  • src/compiler/BuiltInFunctionEmulator.h:
  • src/compiler/Compiler.cpp:

(isWebGLBasedSpec):
(TCompiler::compile):
(TCompiler::rewriteCSSShader):
(TCompiler::enforceTimingRestrictions):
(TCompiler::enforceFragmentShaderTimingRestrictions):
(TCompiler::enforceVertexShaderTimingRestrictions):

  • src/compiler/DetectDiscontinuity.cpp: Added.

(sh::DetectLoopDiscontinuity::traverse):
(sh):
(sh::DetectLoopDiscontinuity::visitBranch):
(sh::DetectLoopDiscontinuity::visitAggregate):
(sh::containsLoopDiscontinuity):
(sh::DetectGradientOperation::traverse):
(sh::DetectGradientOperation::visitUnary):
(sh::DetectGradientOperation::visitAggregate):
(sh::containsGradientOperation):

  • src/compiler/DetectDiscontinuity.h: Added.

(sh):
(DetectLoopDiscontinuity):
(DetectGradientOperation):

  • src/compiler/Diagnostics.cpp: Added.

(TDiagnostics::TDiagnostics):
(TDiagnostics::~TDiagnostics):
(TDiagnostics::writeInfo):
(TDiagnostics::writeDebug):
(TDiagnostics::print):

  • src/compiler/Diagnostics.h: Added.

(TDiagnostics):
(TDiagnostics::infoSink):

  • src/compiler/DirectiveHandler.cpp: Added.

(getBehavior):
(TDirectiveHandler::TDirectiveHandler):
(TDirectiveHandler::~TDirectiveHandler):
(TDirectiveHandler::handleError):
(TDirectiveHandler::handlePragma):
(TDirectiveHandler::handleExtension):
(TDirectiveHandler::handleVersion):

  • src/compiler/DirectiveHandler.h: Added.

(TDirectiveHandler):
(TDirectiveHandler::pragma):
(TDirectiveHandler::extensionBehavior):

  • src/compiler/ExtensionBehavior.h:

(getBehaviorString):

  • src/compiler/Initialize.cpp:

(BuiltInConstants):
(TBuiltIns::initialize):
(IdentifyBuiltIns):

  • src/compiler/InitializeParseContext.cpp: Added.

(InitializeParseContextIndex):
(FreeParseContextIndex):
(InitializeGlobalParseContext):
(FreeParseContext):
(GetGlobalParseContext):

  • src/compiler/InitializeParseContext.h:

(TThreadParseContextRec):

  • src/compiler/Intermediate.cpp:

(TIntermediate::addSelection):

  • src/compiler/MapLongVariableNames.cpp:
  • src/compiler/OutputHLSL.cpp:

(sh::str):
(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::~OutputHLSL):
(sh::OutputHLSL::output):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitBinary):
(sh::OutputHLSL::visitUnary):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::traverseStatements):
(sh):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::typeString):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::decorateField):

  • src/compiler/OutputHLSL.h:

(sh):
(OutputHLSL):

  • src/compiler/ParseHelper.cpp:

(TParseContext::parseVectorFields):
(TParseContext::parseMatrixFields):
(TParseContext::error):
(TParseContext::warning):
(TParseContext::trace):
(TParseContext::assignError):
(TParseContext::unaryOpError):
(TParseContext::binaryOpError):
(TParseContext::precisionErrorCheck):
(TParseContext::lValueErrorCheck):
(TParseContext::constErrorCheck):
(TParseContext::integerErrorCheck):
(TParseContext::globalErrorCheck):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::voidErrorCheck):
(TParseContext::boolErrorCheck):
(TParseContext::samplerErrorCheck):
(TParseContext::structQualifierErrorCheck):
(TParseContext::parameterSamplerErrorCheck):
(TParseContext::arraySizeErrorCheck):
(TParseContext::arrayQualifierErrorCheck):
(TParseContext::arrayTypeErrorCheck):
(TParseContext::arrayErrorCheck):
(TParseContext::arraySetMaxSize):
(TParseContext::nonInitConstErrorCheck):
(TParseContext::nonInitErrorCheck):
(TParseContext::paramErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::supportsExtension):
(TParseContext::handleExtensionDirective):
(TParseContext::handlePragmaDirective):
(TParseContext::findFunction):
(TParseContext::executeInitializer):
(TParseContext::constructBuiltIn):
(TParseContext::constructStruct):
(TParseContext::addConstVectorNode):
(TParseContext::addConstMatrixNode):
(TParseContext::addConstArrayNode):
(TParseContext::addConstStruct):
(TParseContext::enterStructDeclaration):
(TParseContext::structNestingErrorCheck):
(PaParseStrings):

  • src/compiler/ParseHelper.h:

(TParseContext::TParseContext):
(TParseContext):
(TParseContext::infoSink):
(TParseContext::extensionBehavior):
(TParseContext::pragma):

  • src/compiler/PoolAlloc.cpp:

(TAllocation::checkGuardBlock):

  • src/compiler/Pragma.h: Added.

(TPragma):
(TPragma::TPragma):

  • src/compiler/RenameFunction.h: Added.

(RenameFunction):
(RenameFunction::RenameFunction):
(RenameFunction::visitAggregate):

  • src/compiler/ShHandle.h:

(TCompiler):

  • src/compiler/ShaderLang.cpp:

(getVariableInfo):

  • src/compiler/SymbolTable.cpp:

(TType::buildMangledName):

  • src/compiler/TranslatorHLSL.cpp:
  • src/compiler/UnfoldSelect.cpp: Removed.
  • src/compiler/UnfoldSelect.h: Removed.
  • src/compiler/UnfoldShortCircuit.cpp: Added.

(sh::UnfoldShortCircuit::UnfoldShortCircuit):
(sh):
(sh::UnfoldShortCircuit::traverse):
(sh::UnfoldShortCircuit::visitBinary):
(sh::UnfoldShortCircuit::visitSelection):
(sh::UnfoldShortCircuit::visitLoop):
(sh::UnfoldShortCircuit::getNextTemporaryIndex):

  • src/compiler/UnfoldShortCircuit.h: Added.

(sh):
(UnfoldShortCircuit):

  • src/compiler/ValidateLimitations.cpp:
  • src/compiler/debug.cpp:
  • src/compiler/depgraph: Added.
  • src/compiler/depgraph/DependencyGraph.cpp: Added.

(TDependencyGraph::TDependencyGraph):
(TDependencyGraph::~TDependencyGraph):
(TDependencyGraph::createArgument):
(TDependencyGraph::createFunctionCall):
(TDependencyGraph::getOrCreateSymbol):
(TDependencyGraph::createSelection):
(TDependencyGraph::createLoop):
(TDependencyGraph::createLogicalOp):
(TGraphLogicalOp::getOpString):

  • src/compiler/depgraph/DependencyGraph.h: Added.

(TGraphNode):
(TGraphNode::TGraphNode):
(TGraphNode::~TGraphNode):
(TGraphParentNode):
(TGraphParentNode::TGraphParentNode):
(TGraphParentNode::~TGraphParentNode):
(TGraphParentNode::addDependentNode):
(TGraphArgument):
(TGraphArgument::TGraphArgument):
(TGraphArgument::~TGraphArgument):
(TGraphArgument::getIntermFunctionCall):
(TGraphArgument::getArgumentNumber):
(TGraphFunctionCall):
(TGraphFunctionCall::TGraphFunctionCall):
(TGraphFunctionCall::~TGraphFunctionCall):
(TGraphFunctionCall::getIntermFunctionCall):
(TGraphSymbol):
(TGraphSymbol::TGraphSymbol):
(TGraphSymbol::~TGraphSymbol):
(TGraphSymbol::getIntermSymbol):
(TGraphSelection):
(TGraphSelection::TGraphSelection):
(TGraphSelection::~TGraphSelection):
(TGraphSelection::getIntermSelection):
(TGraphLoop):
(TGraphLoop::TGraphLoop):
(TGraphLoop::~TGraphLoop):
(TGraphLoop::getIntermLoop):
(TGraphLogicalOp):
(TGraphLogicalOp::TGraphLogicalOp):
(TGraphLogicalOp::~TGraphLogicalOp):
(TGraphLogicalOp::getIntermLogicalOp):
(TDependencyGraph):
(TDependencyGraph::begin):
(TDependencyGraph::end):
(TDependencyGraph::beginSamplerSymbols):
(TDependencyGraph::endSamplerSymbols):
(TDependencyGraph::beginUserDefinedFunctionCalls):
(TDependencyGraph::endUserDefinedFunctionCalls):
(TDependencyGraphTraverser):
(TDependencyGraphTraverser::TDependencyGraphTraverser):
(TDependencyGraphTraverser::visitSymbol):
(TDependencyGraphTraverser::visitArgument):
(TDependencyGraphTraverser::visitFunctionCall):
(TDependencyGraphTraverser::visitSelection):
(TDependencyGraphTraverser::visitLoop):
(TDependencyGraphTraverser::visitLogicalOp):
(TDependencyGraphTraverser::getDepth):
(TDependencyGraphTraverser::incrementDepth):
(TDependencyGraphTraverser::decrementDepth):
(TDependencyGraphTraverser::clearVisited):
(TDependencyGraphTraverser::markVisited):
(TDependencyGraphTraverser::isVisited):

  • src/compiler/depgraph/DependencyGraphBuilder.cpp: Added.

(TDependencyGraphBuilder::build):
(TDependencyGraphBuilder::visitAggregate):
(TDependencyGraphBuilder::visitFunctionDefinition):
(TDependencyGraphBuilder::visitFunctionCall):
(TDependencyGraphBuilder::visitAggregateChildren):
(TDependencyGraphBuilder::visitSymbol):
(TDependencyGraphBuilder::visitBinary):
(TDependencyGraphBuilder::visitAssignment):
(TDependencyGraphBuilder::visitLogicalOp):
(TDependencyGraphBuilder::visitBinaryChildren):
(TDependencyGraphBuilder::visitSelection):
(TDependencyGraphBuilder::visitLoop):
(TDependencyGraphBuilder::connectMultipleNodesToSingleNode):

  • src/compiler/depgraph/DependencyGraphBuilder.h: Added.

(TDependencyGraphBuilder):
(TNodeSetStack):
(TDependencyGraphBuilder::TNodeSetStack::TNodeSetStack):
(TDependencyGraphBuilder::TNodeSetStack::~TNodeSetStack):
(TDependencyGraphBuilder::TNodeSetStack::getTopSet):
(TDependencyGraphBuilder::TNodeSetStack::pushSet):
(TDependencyGraphBuilder::TNodeSetStack::popSet):
(TDependencyGraphBuilder::TNodeSetStack::popSetIntoNext):
(TDependencyGraphBuilder::TNodeSetStack::insertIntoTopSet):
(TDependencyGraphBuilder::TNodeSetStack::clear):
(TNodeSetMaintainer):
(TDependencyGraphBuilder::TNodeSetMaintainer::TNodeSetMaintainer):
(TDependencyGraphBuilder::TNodeSetMaintainer::~TNodeSetMaintainer):
(TNodeSetPropagatingMaintainer):
(TDependencyGraphBuilder::TNodeSetPropagatingMaintainer::TNodeSetPropagatingMaintainer):
(TDependencyGraphBuilder::TNodeSetPropagatingMaintainer::~TNodeSetPropagatingMaintainer):
(TLeftmostSymbolMaintainer):
(TDependencyGraphBuilder::TLeftmostSymbolMaintainer::TLeftmostSymbolMaintainer):
(TDependencyGraphBuilder::TLeftmostSymbolMaintainer::~TLeftmostSymbolMaintainer):
(TDependencyGraphBuilder::TDependencyGraphBuilder):
(TDependencyGraphBuilder::build):

  • src/compiler/depgraph/DependencyGraphOutput.cpp: Added.

(TDependencyGraphOutput::outputIndentation):
(TDependencyGraphOutput::visitArgument):
(TDependencyGraphOutput::visitFunctionCall):
(TDependencyGraphOutput::visitSymbol):
(TDependencyGraphOutput::visitSelection):
(TDependencyGraphOutput::visitLoop):
(TDependencyGraphOutput::visitLogicalOp):
(TDependencyGraphOutput::outputAllSpanningTrees):

  • src/compiler/depgraph/DependencyGraphOutput.h: Added.

(TDependencyGraphOutput):
(TDependencyGraphOutput::TDependencyGraphOutput):

  • src/compiler/depgraph/DependencyGraphTraverse.cpp: Added.

(TGraphNode::traverse):
(TGraphParentNode::traverse):
(TGraphArgument::traverse):
(TGraphFunctionCall::traverse):
(TGraphSymbol::traverse):
(TGraphSelection::traverse):
(TGraphLoop::traverse):
(TGraphLogicalOp::traverse):

  • src/compiler/glslang.h:
  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp:

(yy_buffer_state):
(yyguts_t):
(yy_get_previous_state):
(yy_try_NUL_trans):
(input):
(yyensure_buffer_stack):
(yy_scan_bytes):
(yyget_leng):
(string_input):
(yyerror):
(glslang_finalize):
(glslang_scan):

  • src/compiler/glslang_tab.cpp:
  • src/compiler/intermediate.h:

(TIntermAggregate::TIntermAggregate):
(TIntermAggregate::~TIntermAggregate):
(TIntermAggregate::isUserDefined):
(TIntermAggregate):
(TIntermTraverser::~TIntermTraverser):

  • src/compiler/osinclude.h:
  • src/compiler/preprocessor/atom.c:

(FindHashLoc):
(PrintAtomTable):

  • src/compiler/preprocessor/cpp.c:

(CPPpragma):
(readCPPline):
(PredefineIntMacro):
(MacroExpand):

  • src/compiler/preprocessor/cpp.h:
  • src/compiler/preprocessor/memory.h:
  • src/compiler/preprocessor/new: Added properties allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs and allow-tabs.
  • src/compiler/preprocessor/new/Context.cpp: Removed.
  • src/compiler/preprocessor/new/Context.h: Removed.
  • src/compiler/preprocessor/new/Diagnostics.h: Added.

(pp):
(Diagnostics):

  • src/compiler/preprocessor/new/DiagnosticsBase.cpp: Added.

(pp):
(pp::Diagnostics::~Diagnostics):
(pp::Diagnostics::report):
(pp::Diagnostics::severity):

  • src/compiler/preprocessor/new/DirectiveHandler.h: Added.

(pp):
(DirectiveHandler):

  • src/compiler/preprocessor/new/DirectiveHandlerBase.cpp: Added.

(pp):
(pp::DirectiveHandler::~DirectiveHandler):

  • src/compiler/preprocessor/new/DirectiveParser.cpp: Added.

(getDirective):
(isConditionalDirective):
(isEOD):
(skipUntilEOD):
(isMacroNameReserved):
(isMacroPredefined):
(pp):
(DefinedParser):
(pp::DefinedParser::DefinedParser):
(pp::DefinedParser::lex):
(pp::DirectiveParser::DirectiveParser):
(pp::DirectiveParser::lex):
(pp::DirectiveParser::parseDirective):
(pp::DirectiveParser::parseDefine):
(pp::DirectiveParser::parseUndef):
(pp::DirectiveParser::parseIf):
(pp::DirectiveParser::parseIfdef):
(pp::DirectiveParser::parseIfndef):
(pp::DirectiveParser::parseElse):
(pp::DirectiveParser::parseElif):
(pp::DirectiveParser::parseEndif):
(pp::DirectiveParser::parseError):
(pp::DirectiveParser::parsePragma):
(pp::DirectiveParser::parseExtension):
(pp::DirectiveParser::parseVersion):
(pp::DirectiveParser::parseLine):
(pp::DirectiveParser::skipping):
(pp::DirectiveParser::parseConditionalIf):
(pp::DirectiveParser::parseExpressionIf):
(pp::DirectiveParser::parseExpressionIfdef):

  • src/compiler/preprocessor/new/DirectiveParser.h: Added.

(pp):
(DirectiveParser):
(ConditionalBlock):
(pp::DirectiveParser::ConditionalBlock::ConditionalBlock):

  • src/compiler/preprocessor/new/ExpressionParser.cpp: Added.

(yysyntax_error):
(yylex):
(yyerror):
(pp):
(pp::ExpressionParser::ExpressionParser):
(pp::ExpressionParser::parse):

  • src/compiler/preprocessor/new/ExpressionParser.h: Added.

(pp):
(ExpressionParser):

  • src/compiler/preprocessor/new/ExpressionParser.y: Added.
  • src/compiler/preprocessor/new/Input.cpp: Added property allow-tabs.

(pp::Input::Input):
(pp::Input::read):

  • src/compiler/preprocessor/new/Input.h: Added property allow-tabs.

(pp):
(Input):
(pp::Input::count):
(pp::Input::string):
(pp::Input::length):
(Location):
(pp::Input::Location::Location):
(pp::Input::readLoc):

  • src/compiler/preprocessor/new/Lexer.cpp: Added.

(pp):
(pp::Lexer::~Lexer):

  • src/compiler/preprocessor/new/Lexer.h: Added.

(pp):
(Lexer):

  • src/compiler/preprocessor/new/Macro.cpp: Added property allow-tabs.

(pp::Macro::equals):

  • src/compiler/preprocessor/new/Macro.h: Added property allow-tabs.

(pp):
(pp::Macro::Macro):
(Macro):

  • src/compiler/preprocessor/new/MacroExpander.cpp: Added.

(pp):
(TokenLexer):
(pp::TokenLexer::TokenLexer):
(pp::TokenLexer::lex):
(pp::MacroExpander::MacroExpander):
(pp::MacroExpander::~MacroExpander):
(pp::MacroExpander::lex):
(pp::MacroExpander::getToken):
(pp::MacroExpander::ungetToken):
(pp::MacroExpander::isNextTokenLeftParen):
(pp::MacroExpander::pushMacro):
(pp::MacroExpander::popMacro):
(pp::MacroExpander::expandMacro):
(pp::MacroExpander::collectMacroArgs):
(pp::MacroExpander::replaceMacroParams):

  • src/compiler/preprocessor/new/MacroExpander.h: Added.

(pp):
(MacroExpander):
(MacroContext):
(pp::MacroExpander::MacroContext::MacroContext):
(pp::MacroExpander::MacroContext::empty):
(pp::MacroExpander::MacroContext::get):
(pp::MacroExpander::MacroContext::unget):

  • src/compiler/preprocessor/new/Preprocessor.cpp: Added property allow-tabs.

(PreprocessorImpl):
(pp::PreprocessorImpl::PreprocessorImpl):
(pp):
(pp::Preprocessor::Preprocessor):
(pp::Preprocessor::~Preprocessor):
(pp::Preprocessor::init):
(pp::Preprocessor::predefineMacro):
(pp::Preprocessor::lex):

  • src/compiler/preprocessor/new/Preprocessor.h: Added property allow-tabs.

(pp):
(Preprocessor):

  • src/compiler/preprocessor/new/SourceLocation.h: Added.

(pp):
(pp::SourceLocation::SourceLocation):
(SourceLocation):
(pp::SourceLocation::equals):
(pp::operator==):
(pp::operator!=):

  • src/compiler/preprocessor/new/Token.cpp: Added property allow-tabs.

(pp::Token::reset):
(pp::Token::equals):
(pp::Token::setAtStartOfLine):
(pp::Token::setHasLeadingSpace):
(pp):
(pp::Token::setExpansionDisabled):
(pp::operator<<):

  • src/compiler/preprocessor/new/Token.h: Added property allow-tabs.

(pp::Token::Token):
(Token):
(pp::Token::atStartOfLine):
(pp::Token::hasLeadingSpace):
(pp::Token::expansionDisabled):
(pp::operator==):
(pp):
(pp::operator!=):

  • src/compiler/preprocessor/new/Tokenizer.cpp: Added.

(yy_buffer_state):
(yy_trans_info):
(yyguts_t):
(yy_get_previous_state):
(yy_try_NUL_trans):
(input):
(pprestart):
(pp_switch_to_buffer):
(pp_load_buffer_state):
(pp_create_buffer):
(pp_delete_buffer):
(pp_init_buffer):
(pp_flush_buffer):
(pppush_buffer_state):
(pppop_buffer_state):
(ppensure_buffer_stack):
(pp_scan_buffer):
(pp_scan_string):
(pp_scan_bytes):
(yy_fatal_error):
(ppget_extra):
(ppget_lineno):
(ppget_column):
(ppget_in):
(ppget_out):
(ppget_leng):
(ppget_text):
(ppset_extra):
(ppset_lineno):
(ppset_column):
(ppset_in):
(ppset_out):
(ppget_debug):
(ppset_debug):
(ppget_lval):
(ppset_lval):
(ppget_lloc):
(ppset_lloc):
(pplex_init):
(pplex_init_extra):
(yy_init_globals):
(pplex_destroy):
(yy_flex_strncpy):
(yy_flex_strlen):
(ppalloc):
(pprealloc):
(ppfree):
(pp):
(pp::Tokenizer::Tokenizer):
(pp::Tokenizer::~Tokenizer):
(pp::Tokenizer::init):
(pp::Tokenizer::setFileNumber):
(pp::Tokenizer::setLineNumber):
(pp::Tokenizer::lex):
(pp::Tokenizer::initScanner):
(pp::Tokenizer::destroyScanner):

  • src/compiler/preprocessor/new/Tokenizer.h: Added.

(pp):
(Tokenizer):
(Context):

  • src/compiler/preprocessor/new/Tokenizer.l: Added.
  • src/compiler/preprocessor/new/generate_parser.sh: Added property allow-tabs.
  • src/compiler/preprocessor/new/pp.l: Removed.
  • src/compiler/preprocessor/new/pp.y: Removed.
  • src/compiler/preprocessor/new/pp_lex.cpp: Removed.
  • src/compiler/preprocessor/new/pp_tab.cpp: Removed.
  • src/compiler/preprocessor/new/pp_tab.h: Removed.
  • src/compiler/preprocessor/new/pp_utils.h: Added.
  • src/compiler/preprocessor/new/preprocessor.vcproj: Added.
  • src/compiler/preprocessor/new/stl_utils.h: Removed.
  • src/compiler/preprocessor/new/token_type.h: Removed.
  • src/compiler/preprocessor/preprocess.h:
  • src/compiler/preprocessor/scanner.c:

(InitScannerInput):

  • src/compiler/preprocessor/scanner.h:
  • src/compiler/preprocessor/symbols.h:
  • src/compiler/preprocessor/tokens.c:

(ReadToken):
(DumpTokenStream):

  • src/compiler/preprocessor/tokens.h:
  • src/compiler/timing: Added.
  • src/compiler/timing/RestrictFragmentShaderTiming.cpp: Added.

(RestrictFragmentShaderTiming::RestrictFragmentShaderTiming):
(RestrictFragmentShaderTiming::enforceRestrictions):
(RestrictFragmentShaderTiming::validateUserDefinedFunctionCallUsage):
(RestrictFragmentShaderTiming::beginError):
(RestrictFragmentShaderTiming::isSamplingOp):
(RestrictFragmentShaderTiming::visitArgument):
(RestrictFragmentShaderTiming::visitSelection):
(RestrictFragmentShaderTiming::visitLoop):
(RestrictFragmentShaderTiming::visitLogicalOp):

  • src/compiler/timing/RestrictFragmentShaderTiming.h: Added.

(RestrictFragmentShaderTiming):
(RestrictFragmentShaderTiming::numErrors):

  • src/compiler/timing/RestrictVertexShaderTiming.cpp: Added.

(RestrictVertexShaderTiming::visitSymbol):

  • src/compiler/timing/RestrictVertexShaderTiming.h: Added.

(RestrictVertexShaderTiming):
(RestrictVertexShaderTiming::RestrictVertexShaderTiming):
(RestrictVertexShaderTiming::enforceRestrictions):
(RestrictVertexShaderTiming::numErrors):

  • src/libEGL/Display.cpp:

(egl):
(egl::Display::getDepthTextureSupport):
(egl::Display::getTexturePool):

  • src/libEGL/Display.h:

(Display):

  • src/libEGL/Surface.cpp:

(egl::Surface::Surface):
(egl::Surface::release):
(egl::Surface::resetSwapChain):
(egl::Surface::swapRect):
(egl):
(egl::Surface::swap):
(egl::Surface::postSubBuffer):

  • src/libEGL/Surface.h:

(Surface):

  • src/libEGL/libEGL.cpp:
  • src/libGLESv2/Context.cpp:

(gl::Context::makeCurrent):
(gl::Context::markDxUniformsDirty):
(gl):
(gl::Context::getIntegerv):
(gl::Context::getQueryParameterInfo):
(gl::Context::applyRenderTarget):
(gl::Context::applyState):
(gl::Context::applyShaders):
(gl::Context::applyTextures):
(gl::Context::readPixels):
(gl::Context::clear):
(gl::Context::drawArrays):
(gl::Context::drawElements):
(gl::Context::supportsDepthTextures):
(gl::Context::initExtensionString):
(gl::Context::blitFramebuffer):
(gl::VertexDeclarationCache::applyDeclaration):

  • src/libGLESv2/Context.h:

(Context):

  • src/libGLESv2/Framebuffer.cpp:

(gl::Framebuffer::~Framebuffer):
(gl):
(gl::Framebuffer::getNullColorbuffer):
(gl::Framebuffer::completeness):

  • src/libGLESv2/Framebuffer.h:

(Framebuffer):

  • src/libGLESv2/Program.cpp:

(gl):
(gl::AttributeBindings::AttributeBindings):
(gl::AttributeBindings::~AttributeBindings):
(gl::InfoLog::InfoLog):
(gl::InfoLog::~InfoLog):
(gl::InfoLog::getLength):
(gl::InfoLog::getLog):
(gl::InfoLog::appendSanitized):
(gl::InfoLog::append):
(gl::InfoLog::reset):
(gl::Program::Program):
(gl::Program::~Program):
(gl::Program::attachShader):
(gl::Program::detachShader):
(gl::Program::getAttachedShadersCount):
(gl::AttributeBindings::bindAttributeLocation):
(gl::Program::bindAttributeLocation):
(gl::Program::link):
(gl::AttributeBindings::getAttributeBinding):
(gl::Program::unlink):
(gl::Program::getProgramBinary):
(gl::Program::setProgramBinary):
(gl::Program::getInfoLogLength):
(gl::Program::getInfoLog):
(gl::Program::getActiveAttribute):
(gl::Program::getActiveAttributeCount):
(gl::Program::getActiveAttributeMaxLength):
(gl::Program::getActiveUniform):
(gl::Program::getActiveUniformCount):
(gl::Program::getActiveUniformMaxLength):
(gl::Program::validate):
(gl::Program::isValidated):

  • src/libGLESv2/Program.h:

(gl):
(AttributeBindings):
(InfoLog):
(Program):

  • src/libGLESv2/ProgramBinary.cpp: Added.

(gl::str):
(gl):
(gl::Uniform::Uniform):
(gl::Uniform::~Uniform):
(gl::Uniform::isArray):
(gl::UniformLocation::UniformLocation):
(gl::ProgramBinary::ProgramBinary):
(gl::ProgramBinary::~ProgramBinary):
(gl::ProgramBinary::getPixelShader):
(gl::ProgramBinary::getVertexShader):
(gl::ProgramBinary::getAttributeLocation):
(gl::ProgramBinary::getSemanticIndex):
(gl::ProgramBinary::getUsedSamplerRange):
(gl::ProgramBinary::getSamplerMapping):
(gl::ProgramBinary::getSamplerTextureType):
(gl::ProgramBinary::getUniformLocation):
(gl::ProgramBinary::setUniform1fv):
(gl::ProgramBinary::setUniform2fv):
(gl::ProgramBinary::setUniform3fv):
(gl::ProgramBinary::setUniform4fv):
(gl::transposeMatrix):
(gl::ProgramBinary::setUniformMatrix2fv):
(gl::ProgramBinary::setUniformMatrix3fv):
(gl::ProgramBinary::setUniformMatrix4fv):
(gl::ProgramBinary::setUniform1iv):
(gl::ProgramBinary::setUniform2iv):
(gl::ProgramBinary::setUniform3iv):
(gl::ProgramBinary::setUniform4iv):
(gl::ProgramBinary::getUniformfv):
(gl::ProgramBinary::getUniformiv):
(gl::ProgramBinary::dirtyAllUniforms):
(gl::ProgramBinary::applyUniforms):
(gl::ProgramBinary::compileToBinary):
(gl::ProgramBinary::packVaryings):
(gl::ProgramBinary::linkVaryings):
(gl::ProgramBinary::link):
(gl::ProgramBinary::linkAttributes):
(gl::ProgramBinary::linkUniforms):
(gl::ProgramBinary::defineUniform):
(gl::ProgramBinary::createUniform):
(gl::ProgramBinary::decorateAttribute):
(gl::ProgramBinary::undecorateUniform):
(gl::ProgramBinary::applyUniformnbv):
(gl::ProgramBinary::applyUniformnfv):
(gl::ProgramBinary::applyUniform1iv):
(gl::ProgramBinary::applyUniform2iv):
(gl::ProgramBinary::applyUniform3iv):
(gl::ProgramBinary::applyUniform4iv):
(gl::ProgramBinary::applyUniformniv):
(gl::ProgramBinary::isValidated):
(gl::ProgramBinary::getActiveAttribute):
(gl::ProgramBinary::getActiveAttributeCount):
(gl::ProgramBinary::getActiveAttributeMaxLength):
(gl::ProgramBinary::getActiveUniform):
(gl::ProgramBinary::getActiveUniformCount):
(gl::ProgramBinary::getActiveUniformMaxLength):
(gl::ProgramBinary::validate):
(gl::ProgramBinary::validateSamplers):
(gl::ProgramBinary::getDxDepthRangeLocation):
(gl::ProgramBinary::getDxDepthLocation):
(gl::ProgramBinary::getDxCoordLocation):
(gl::ProgramBinary::getDxHalfPixelSizeLocation):
(gl::ProgramBinary::getDxFrontCCWLocation):
(gl::ProgramBinary::getDxPointsOrLinesLocation):

  • src/libGLESv2/ProgramBinary.h: Added.

(gl):
(Uniform):
(gl::Uniform::RegisterInfo::RegisterInfo):
(RegisterInfo):
(gl::Uniform::RegisterInfo::set):
(UniformLocation):
(ProgramBinary):
(Sampler):

  • src/libGLESv2/Renderbuffer.cpp:

(gl):
(gl::RenderbufferTexture2D::RenderbufferTexture2D):
(gl::RenderbufferTexture2D::~RenderbufferTexture2D):
(gl::RenderbufferTexture2D::addProxyRef):
(gl::RenderbufferTexture2D::releaseProxy):
(gl::RenderbufferTexture2D::getRenderTarget):
(gl::RenderbufferTexture2D::getDepthStencil):
(gl::RenderbufferTexture2D::getWidth):
(gl::RenderbufferTexture2D::getHeight):
(gl::RenderbufferTexture2D::getInternalFormat):
(gl::RenderbufferTexture2D::getD3DFormat):
(gl::RenderbufferTexture2D::getSamples):
(gl::RenderbufferTexture2D::getSerial):
(gl::RenderbufferTextureCubeMap::RenderbufferTextureCubeMap):
(gl::RenderbufferTextureCubeMap::~RenderbufferTextureCubeMap):
(gl::RenderbufferTextureCubeMap::addProxyRef):
(gl::RenderbufferTextureCubeMap::releaseProxy):
(gl::RenderbufferTextureCubeMap::getRenderTarget):
(gl::RenderbufferTextureCubeMap::getDepthStencil):
(gl::RenderbufferTextureCubeMap::getWidth):
(gl::RenderbufferTextureCubeMap::getHeight):
(gl::RenderbufferTextureCubeMap::getInternalFormat):
(gl::RenderbufferTextureCubeMap::getD3DFormat):
(gl::RenderbufferTextureCubeMap::getSamples):
(gl::RenderbufferTextureCubeMap::getSerial):
(gl::DepthStencilbuffer::getDepthStencil):

  • src/libGLESv2/Renderbuffer.h:

(gl):
(RenderbufferTexture2D):
(RenderbufferTextureCubeMap):

  • src/libGLESv2/Shader.cpp:

(gl::Shader::getInfoLog):
(gl::Shader::getSourceImpl):

  • src/libGLESv2/Shader.h:

(Shader):
(VertexShader):

  • src/libGLESv2/Texture.cpp:

(gl::ConvertTextureFormatType):
(gl::IsTextureFormatRenderable):
(gl::GetTextureUsage):
(gl):
(gl::Image::createSurface):
(gl::Image::updateSurface):
(gl::Image::loadData):
(gl::Image::loadAlphaData):
(gl::Image::loadAlphaDataSSE2):
(gl::Image::loadAlphaFloatData):
(gl::Image::loadAlphaHalfFloatData):
(gl::Image::loadLuminanceData):
(gl::Image::loadLuminanceFloatData):
(gl::Image::loadLuminanceHalfFloatData):
(gl::Image::loadLuminanceAlphaData):
(gl::Image::loadLuminanceAlphaFloatData):
(gl::Image::loadLuminanceAlphaHalfFloatData):
(gl::Image::loadRGBUByteData):
(gl::Image::loadRGB565Data):
(gl::Image::loadRGBFloatData):
(gl::Image::loadRGBHalfFloatData):
(gl::Image::loadRGBAUByteDataSSE2):
(gl::Image::loadRGBAUByteData):
(gl::Image::loadRGBA4444Data):
(gl::Image::loadRGBA5551Data):
(gl::Image::loadRGBAFloatData):
(gl::Image::loadRGBAHalfFloatData):
(gl::Image::loadBGRAData):
(gl::Image::loadCompressedData):
(gl::Image::copy):
(gl::TextureStorage::TextureStorage):
(gl::TextureStorage::isRenderTarget):
(gl::TextureStorage::getUsage):
(gl::Texture::setImage):
(gl::Texture::setCompressedImage):
(gl::Texture::subImage):
(gl::Texture::subImageCompressed):
(gl::TextureStorage2D::TextureStorage2D):
(gl::Texture2D::getInternalFormat):
(gl::Texture2D::getD3DFormat):
(gl::Texture2D::copyImage):
(gl::Texture2D::copySubImage):
(gl::Texture2D::storage):
(gl::Texture2D::isSamplerComplete):
(gl::Texture2D::isCompressed):
(gl::Texture2D::isDepth):
(gl::Texture2D::createTexture):
(gl::Texture2D::convertToRenderTarget):
(gl::Texture2D::getRenderbuffer):
(gl::Texture2D::getRenderTarget):
(gl::Texture2D::getDepthStencil):
(gl::TextureStorageCubeMap::TextureStorageCubeMap):
(gl::TextureCubeMap::getWidth):
(gl::TextureCubeMap::getHeight):
(gl::TextureCubeMap::getInternalFormat):
(gl::TextureCubeMap::getD3DFormat):
(gl::TextureCubeMap::isSamplerComplete):
(gl::TextureCubeMap::isCompressed):
(gl::TextureCubeMap::createTexture):
(gl::TextureCubeMap::convertToRenderTarget):
(gl::TextureCubeMap::copyImage):
(gl::TextureCubeMap::copySubImage):
(gl::TextureCubeMap::storage):
(gl::TextureCubeMap::getRenderbuffer):

  • src/libGLESv2/Texture.h:

(Image):
(TextureStorage):
(Texture):
(TextureStorage2D):
(Texture2D):
(TextureStorageCubeMap):
(TextureCubeMap):

  • src/libGLESv2/VertexDataManager.cpp:

(gl::VertexDataManager::prepareVertexData):

  • src/libGLESv2/libGLESv2.cpp:

(checkTextureFormatType):
(validateSubImageParams2D):
(validateSubImageParamsCube):

  • src/libGLESv2/libGLESv2.vcproj:
  • src/libGLESv2/mathutil.h:

(gl):

  • src/libGLESv2/utilities.cpp:

(gl::IsDepthTexture):
(gl):
(gl::ComputePixelSize):
(gl::ExtractFormat):
(gl::ExtractType):
(es2dx::ConvertCubeFace):
(es2dx::ConvertRenderbufferFormat):
(dx2es::GetStencilSize):
(dx2es::GetDepthSize):
(dx2es::IsDepthTextureFormat):
(dx2es):
(dx2es::IsStencilTextureFormat):
(dx2es::ConvertDepthStencilFormat):

  • src/libGLESv2/utilities.h:

(gl):
(dx2es):

Source/WebCore:

No new tests. No change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
12:47 PM Changeset in webkit [122869] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

12:40 PM Changeset in webkit [122868] by commit-queue@webkit.org
  • 20 edits in trunk

[EFL] Replace 0 by NULL in public headers documentation
https://bugs.webkit.org/show_bug.cgi?id=91470

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-17
Reviewed by Dirk Pranke.

Source/WebKit/efl:

Use NULL instead of 0 for pointer types in public
C headers.

  • ewk/ewk_contextmenu.h:
  • ewk/ewk_cookies.h:
  • ewk/ewk_frame.h:
  • ewk/ewk_intent.h:
  • ewk/ewk_intent_request.h:
  • ewk/ewk_network.h:
  • ewk/ewk_security_origin.h:
  • ewk/ewk_settings.h:
  • ewk/ewk_view.h:
  • ewk/ewk_window_features.h:

Source/WebKit2:

Use NULL instead of 0 for pointer types in public
C headers.

  • UIProcess/API/efl/ewk_intent.h:
  • UIProcess/API/efl/ewk_intent_service.h:
  • UIProcess/API/efl/ewk_url_request.h:
  • UIProcess/API/efl/ewk_url_response.h:
  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_web_resource.h:

Tools:

Fix style checking to properly detect C headers as C
files. Without this change, the style script would
complain if we use NULL (instead of 0 / null) in C
headers.

  • Scripts/webkitpy/style/checkers/cpp.py:

(_FileState.init):
(_FileState.is_c):
(_FileState.is_c_or_objective_c):

12:17 PM Changeset in webkit [122867] by schenney@chromium.org
  • 2 edits in trunk/Source/WebCore

Crash in SVGStopElement::stopColorIncludingOpacity
https://bugs.webkit.org/show_bug.cgi?id=90814

Reviewed by Dirk Schulze.

No new tests as there should be no change in functionality.

  • svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::stopColorIncludingOpacity): Added a check for null
renderer and style. It is hard to see how this is happening because
the code is only invoked if the parent gradient has a renderer, and it seems
the stop element should always have a renderer when the parent has a renderer.
Still, it obviously can happen and does so frequently enough to generate multiple
Chromium crash reports per day. The fix is marked with a FIXME, as we expect to
remove this code entirely soon.

12:01 PM Changeset in webkit [122866] by wangxianzhu@chromium.org
  • 6 edits in trunk/Tools

[chromium] remove --test-shell support from DRT
https://bugs.webkit.org/show_bug.cgi?id=86927

Reviewed by Adam Barth.

Now no one use --test-shell. All of us use the standard DRT mode.

  • DumpRenderTree/chromium/DumpRenderTree.cpp: Removed support of --test-shell and --pixel-tests=filename options. (--pixel-tests without '=' is kept for DRT mode.)

(runTest):
(main):

  • DumpRenderTree/chromium/TestEventPrinter.cpp:

(TestEventPrinter::TestEventPrinter):
(TestEventPrinter::~TestEventPrinter):
(TestEventPrinter::handleTestHeader):
(TestEventPrinter::handleTimedOut):
(TestEventPrinter::handleTextHeader):
(TestEventPrinter::handleTextFooter):
(TestEventPrinter::handleAudioHeader):
(TestEventPrinter::handleAudioFooter):
(TestEventPrinter::handleImage): Removed the unused filename parameter.
(TestEventPrinter::handleTestFooter):

  • DumpRenderTree/chromium/TestEventPrinter.h:

(TestEventPrinter): Made it a concrete class because we have only one implementation.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::initialize):
(TestShell::dumpImage):

  • DumpRenderTree/chromium/TestShell.h:

(TestParams): Removed pixelFileName field.
(TestShell):

11:57 AM EFLWebKitCodingStyle edited by Christophe Dumez
(diff)
11:50 AM Changeset in webkit [122865] by danakj@chromium.org
  • 2 edits
    4 copies in branches/chromium/1180

Merge 122224 - Input type=range issue with events not being raised when value set in js
https://bugs.webkit.org/show_bug.cgi?id=84674

Source/WebCore:

Fix dispatching of change and click events for the input slider.
Prior to the fix, change events were not fired if the new value
matched the value at last change notification based on expected
behavior for text fields. Clicks were not fired if the thumb
element was repositioned under the cursor on mouse down.

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-10
Reviewed by Kent Tamura.

Tests: fast/events/click-range-slider.html

fast/events/onchange-range-slider.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

Ensure that click and change events are properly triggered for range
sliders. Prior to the fix, change events were not fired if the new
value matched the value at last change notification based on expected
behavior for text fields. Clicks were not fired if the thumb element
was positioned under the cursor on mouse down.

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-10
Reviewed by Kent Tamura.

  • fast/events/click-range-slider-expected.txt: Added.
  • fast/events/click-range-slider.html: Added.
  • fast/events/onchange-range-slider-expected.txt: Added.
  • fast/events/onchange-range-slider.html: Added.

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10783036

11:44 AM Changeset in webkit [122864] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

results.html should handle flaky tests differently
https://bugs.webkit.org/show_bug.cgi?id=90892

Reviewed by Dirk Pranke.

-Put tests that failed both runs into the main failures table.
-Put flaky passes below the list of timeout tests.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
11:42 AM Changeset in webkit [122863] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

results.html doesn't hide the right data when not showing expected failures
https://bugs.webkit.org/show_bug.cgi?id=90889

Reviewed by Dirk Pranke.

-Properly hide test lists that have no unexpected items.
-Show the correct counts of tests in each test list when only showing unexpected.
-Always show tests with stderr output.
-Put tests with expected crash/timeout in the crash/timeout lists.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
11:27 AM Changeset in webkit [122862] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, remove timeout lines for tests on snowleopard that no longer apply.

  • platform/chromium/TestExpectations:
11:22 AM Changeset in webkit [122861] by eae@chromium.org
  • 9 edits
    2 adds in trunk

Incorrect offset used for scrollWidth/Height calculation
https://bugs.webkit.org/show_bug.cgi?id=91461

Reviewed by Eric Seidel.

Source/WebCore:

Due to a different offset being used to calculate the scrollWidth/Height
and pixelSnappedClientWidth/Height the scroll value can be off by one in
same cases. This can causes scrollbars to appear even when there is no
overflow.

Test: fast/sub-pixel/block-with-margin-overflow.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
Change location offset passed to snapSizeToPixel to include x() to match
offset used by pixelSnappedClientWidth.

(WebCore::RenderBox::scrollHeight):
Change location offset passed to snapSizeToPixel to include y() to match
offset used by pixelSnappedClientHeight.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clampScrollOffset):
Change calculation to use pixelSnappedClientWidth/Height as it is
subtracted from the pixel snapped scrollWidth/Height values.

(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
Change RenderLayer versions of scrollWidth/Height to include x()/y() as
per the RenderBox versions.

LayoutTests:

Add new test ensuring that a block that shouldn't have overflow doesn't
have scrollbars.

  • fast/sub-pixel/block-with-margin-overflow-expected.html: Added.
  • fast/sub-pixel/block-with-margin-overflow.html: Added.
  • platform/chromium-win/fast/block/float/026-expected.txt:
  • platform/chromium-win/fast/block/float/028-expected.txt:
  • platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png:
  • platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:

Update test expectations that incorrectly had overflow.

11:15 AM Changeset in webkit [122860] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Remove duplicate lines added in r122857.

  • platform/chromium/TestExpectations:
11:11 AM Changeset in webkit [122859] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, stop marking all editing tests as slow.
The cause for the flakiness was determined to be hardware related.

  • platform/chromium/TestExpectations:
11:09 AM Changeset in webkit [122858] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] REGRESSION (r122494): Running platform/mac/plugins/root-object-premature-delete-crash.html results in a crash
https://bugs.webkit.org/show_bug.cgi?id=91505

Unreviewed.

  • platform/mac/TestExpectations: Mark the test as expected to crash.
11:07 AM Changeset in webkit [122857] by tony@chromium.org
  • 27 edits
    4 copies
    1 add
    4 deletes in trunk/LayoutTests

[chromium] Unreviewed gardening. These tests are in chromium's test_expectations.txt and can be rebaselined (skia change in r4600).

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/hixie/perf/001-expected.png: Removed.
  • platform/chromium-linux-x86/svg/hixie/perf/001-expected.txt:
  • platform/chromium-linux-x86/svg/hixie/perf/002-expected.png: Removed.
  • platform/chromium-linux-x86/svg/hixie/perf/002-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-linux/svg/hixie/perf/001-expected.png:
  • platform/chromium-linux/svg/hixie/perf/001-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/002-expected.png:
  • platform/chromium-linux/svg/hixie/perf/002-expected.txt:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/hixie/perf/001-expected.txt.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/hixie/perf/002-expected.txt.
  • platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-mac/svg/hixie/perf/001-expected.png:
  • platform/chromium-mac/svg/hixie/perf/001-expected.txt:
  • platform/chromium-mac/svg/hixie/perf/002-expected.png:
  • platform/chromium-mac/svg/hixie/perf/002-expected.txt:
  • platform/chromium-win-xp/svg/hixie/perf/001-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/hixie/perf/001-expected.txt.
  • platform/chromium-win-xp/svg/hixie/perf/002-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/hixie/perf/002-expected.txt.
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-win/svg/hixie/perf/001-expected.png:
  • platform/chromium-win/svg/hixie/perf/001-expected.txt:
  • platform/chromium-win/svg/hixie/perf/002-expected.png:
  • platform/chromium-win/svg/hixie/perf/002-expected.txt:
  • platform/chromium/TestExpectations:
11:01 AM Changeset in webkit [122856] by Lucas Forschler
  • 1 copy in tags/Safari-537.1

New Tag.

10:42 AM Changeset in webkit [122855] by wangxianzhu@chromium.org
  • 3 edits in trunk/Tools

remove ChromiumDriver from NRWT
https://bugs.webkit.org/show_bug.cgi?id=88478

Now WebKitDriver has replaced ChromiumDriver since test_shell mode is deperecated.

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py: Removed ChromiumDriver code.

(ChromiumPort._driver_class): Removed. WebKitPort._driver_class() will be used.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
10:40 AM Changeset in webkit [122854] by enne@google.com
  • 1 edit in branches/chromium/1180/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp

Merge 122791 - [chromium] Turn off ScrollbarLayerChromium for Windows due to bad alpha values
https://bugs.webkit.org/show_bug.cgi?id=91438

Reviewed by Kenneth Russell.

r120509 turned on blending for scrollbar thumbs. Unfortunately for
Windows XP scrollbar thumbs, their alpha channel is bogus and so the
thumb ends up being completely transparent. This should ultimately be
fixed in Chromium theme code, but in the meantime this patch turns
off the use of ScrollbarLayerChromium.

This change makes Windows scrollbars fall back to using normal
ContentLayerChromiums and being painted all in one layer on the main
thread rather than being painted separately and composited on the
compositor thread.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::createScrollbarLayer):

TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/10704248

10:35 AM Changeset in webkit [122853] by kareng@chromium.org
  • 4 edits in branches/chromium/1180

Merge 122552 - REGRESSION(r119948): [Forms] Spin button Up/Down actions make value to zero for input type "number" when step mismatched
https://bugs.webkit.org/show_bug.cgi?id=91197

Reviewed by Kent Tamura.

Source/WebCore:

This patch fixes implementation of Decimal::ceiling() and floor().
They return wrong value for small fractional numbers.

The bug is occurred when:

  • Step-able input type, e.g. number, date, datetime, and so on.
  • Current value is step mismatched
  • Current value is smaller than step
  • Step up/down by spin button

because spin button up/down actions are implemented in InputType::setpUpFromRenderer
which calls Decimal::ceiling() and floor() for step mismatched case.

Tests: fast/forms/number/number-stepup-stepdown-from-renderer.html: Added test cases

WebKit/chromium/tests/DecimalTest.cpp: Added test cases

  • platform/Decimal.cpp:

(WebCore::Decimal::ceiling): Changed to return 1 for positive small fractional number.
(WebCore::Decimal::floor): Changed to return -1 for negative small fractional number.

Source/WebKit/chromium:

This patch adds test cases for Decimal::ceiling() and floor() of
positive/negative small fractional numbers.

  • tests/DecimalTest.cpp:

(TEST_F):

LayoutTests:

This patch adds new test cases.

  • fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt: Updated for new test cases.
  • fast/forms/number/number-stepup-stepdown-from-renderer.html: Added new test cases.

TBR=yosin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10786036

10:32 AM Changeset in webkit [122852] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Tools

Unreviewed. Add QtGraphics, TextureMapper and OpenGL to watchlist.

  • Scripts/webkitpy/common/config/watchlist:
10:29 AM Changeset in webkit [122851] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
10:19 AM Changeset in webkit [122850] by vsevik@chromium.org
  • 5 edits in trunk/Tools

Unreviewed, rolling out r122828.
http://trac.webkit.org/changeset/122828
https://bugs.webkit.org/show_bug.cgi?id=91516

DumpRenderTree crashes after printing test results. (Requested
by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-17

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:

(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::accessibilityController):
(TestShell):

10:14 AM Changeset in webkit [122849] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Remove tests that have been passing consistently according to the flakiness dashboard.

  • platform/chromium/TestExpectations:
9:54 AM Changeset in webkit [122848] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Rename CSS Exclusions CSSWrapShape class properties to match Exclusion shape function parameters
https://bugs.webkit.org/show_bug.cgi?id=89669

Patch by Hans Muller <hmuller@adobe.com> on 2012-07-17
Reviewed by Dirk Schulze.

Renamed left,top properties in the exclusion shape types to better match the specification
http://dev.w3.org/csswg/css3-exclusions/#shapes-from-svg-syntax:

WrapShapeRectangle, CSSWrapShapeRectangle - left,top should be x, y
WrapShapeCircle, CSSWrapShapeCircle - left,top should be centerX, centerY
WrapShapeEllipse, CSSWrapShapeEllipse - left,top should be centerX, centerY

No new tests or tests revisions were needed, the existing tests cover these APIs.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseExclusionShapeRectangle):
(WebCore::CSSParser::parseExclusionShapeCircle):
(WebCore::CSSParser::parseExclusionShapeEllipse):

  • css/CSSWrapShapes.cpp:

(WebCore::CSSWrapShapeRectangle::cssText):
(WebCore::CSSWrapShapeCircle::cssText):
(WebCore::CSSWrapShapeEllipse::cssText):

  • css/CSSWrapShapes.h:

(WebCore::CSSWrapShapeRectangle::x):
(WebCore::CSSWrapShapeRectangle::y):
(WebCore::CSSWrapShapeRectangle::setX):
(WebCore::CSSWrapShapeRectangle::setY):
(CSSWrapShapeRectangle):
(WebCore::CSSWrapShapeCircle::centerX):
(WebCore::CSSWrapShapeCircle::centerY):
(WebCore::CSSWrapShapeCircle::setCenterX):
(WebCore::CSSWrapShapeCircle::setCenterY):
(CSSWrapShapeCircle):
(WebCore::CSSWrapShapeEllipse::centerX):
(WebCore::CSSWrapShapeEllipse::centerY):
(WebCore::CSSWrapShapeEllipse::setCenterX):
(WebCore::CSSWrapShapeEllipse::setCenterY):
(CSSWrapShapeEllipse):

  • css/WrapShapeFunctions.cpp:

(WebCore::valueForWrapShape):
(WebCore::wrapShapeForValue):

  • rendering/style/WrapShapes.h:

(WebCore::WrapShapeRectangle::x):
(WebCore::WrapShapeRectangle::y):
(WebCore::WrapShapeRectangle::setX):
(WebCore::WrapShapeRectangle::setY):
(WrapShapeRectangle):
(WebCore::WrapShapeCircle::centerX):
(WebCore::WrapShapeCircle::centerY):
(WebCore::WrapShapeCircle::setCenterX):
(WebCore::WrapShapeCircle::setCenterY):
(WrapShapeCircle):
(WebCore::WrapShapeEllipse::centerX):
(WebCore::WrapShapeEllipse::centerY):
(WebCore::WrapShapeEllipse::setCenterX):
(WebCore::WrapShapeEllipse::setCenterY):
(WrapShapeEllipse):

9:32 AM Changeset in webkit [122847] by pfeldman@chromium.org
  • 29 edits in trunk

Web Inspector: implement search / replace in source files (behind experiment flag)
https://bugs.webkit.org/show_bug.cgi?id=91394

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change adds "loop" parameter to the go to next / previous search + adds a UI component
for search / replace of text in the sources panel. New UI component is behind the experiment.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.performSearch):
(WebInspector.ConsolePanel.prototype.jumpToNextSearchResult):
(WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel.prototype.performSearch):
(WebInspector.ExtensionPanel.prototype.jumpToNextSearchResult):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkLogView.prototype._updateFilter):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkPanel.prototype.performSearch):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.performSearch):
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):
(WebInspector.Panel.prototype.canSearchAndReplace):
(WebInspector.Panel.prototype.replaceSelectionWith):
(WebInspector.Panel.prototype.replaceAllWith):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ProfilesPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ResourcesPanel.prototype.jumpToPreviousSearchResult):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ScriptsPanel.prototype.canSearchAndReplace):
(WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
(WebInspector.ScriptsPanel.prototype.replaceAllWith):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
(WebInspector.SearchController.prototype.activePanelChanged):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype.showSearchField):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onInput):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
(WebInspector.SearchController.prototype._toggleReplaceVisibility):
(WebInspector.SearchController.prototype._replace):
(WebInspector.SearchController.prototype._replaceAll):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.createSearchRegex):
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.replaceSearchMatchWith):
(WebInspector.SourceFrame.prototype.replaceAllWith):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.beforeTextChanged):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.commitEditing):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StyleSourceFrame.prototype.afterTextChanged):

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype._commitEditing):

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

  • inspector/front-end/inspector.css:

(.search-replace):
(.search-replace:focus):
(.toolbar-search-navigation-controls):
(.toolbar-search-navigation.enabled):
(.toolbar-search):
(.toolbar-search input[type="checkbox"]):
(.toolbar-search button):
(.toolbar-search button:active):
(.toolbar-search-control):
(.toolbar-replace-control):
(.toolbar-search-navigation.enabled:active):
(.toolbar-search-navigation.toolbar-search-navigation-prev):
(.toolbar-search-navigation.toolbar-search-navigation-prev.enabled:active):
(.toolbar-search-navigation.toolbar-search-navigation-next):
(.toolbar-search-navigation.toolbar-search-navigation-next.enabled:active):
(.drawer-header-close-button):
(.inspector-footer):

LayoutTests:

  • inspector/debugger/pause-in-inline-script.html:
  • inspector/debugger/script-formatter.html:
  • inspector/debugger/source-url-comment.html:
  • inspector/editor/indentation.html:
  • inspector/editor/text-editor-line-breaks.html:
  • inspector/editor/text-editor-model.html:
  • inspector/editor/text-editor-undo-redo.html:
8:25 AM Changeset in webkit [122846] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations fix.

  • platform/chromium/TestExpectations:
7:51 AM Changeset in webkit [122845] by commit-queue@webkit.org
  • 26 edits
    7 deletes in trunk

[Qt][V8] Remove the V8 related codepaths and configuration
https://bugs.webkit.org/show_bug.cgi?id=90863

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-07-17
Reviewed by Simon Hausmann.

.:

  • Source/api.pri:
  • WebKit.pro:

Source/WebCore:

No new tests because no new functionality.

  • DerivedSources.pri:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.pri:
  • bindings/v8/ScriptCachedFrameData.cpp:
  • bindings/v8/ScriptCachedFrameData.h:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/ScriptControllerQt.cpp: Removed.
  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::histogramEnumeration):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):

  • config.h:

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(setupScriptContext):
(QWebElement::evaluateJavaScript):
(convertWebElementVariantToJSValue):
(QtWebElementRuntime::initialize):

  • Api/qwebframe.cpp:

(QWebFramePrivate::didClearWindowObject):
(QWebFramePrivate::addQtSenderToGlobalObject):
(QWebFrame::addToJavaScriptWindowObject):
(QWebFrame::evaluateJavaScript):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(convertNodeVariantToJSValue):
(QtDRTNodeRuntime::initialize):
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
(DumpRenderTreeSupportQt::garbageCollectorCollect):
(DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createDocumentLoader):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

  • v8/ForwardingHeaders/v8-debug.h: Removed.
  • v8/ForwardingHeaders/v8-preparser.h: Removed.
  • v8/ForwardingHeaders/v8-profiler.h: Removed.
  • v8/ForwardingHeaders/v8-testing.h: Removed.
  • v8/ForwardingHeaders/v8.h: Removed.
  • v8/ForwardingHeaders/v8stdint.h: Removed.

Source/WTF:

  • WTF.pri:

Tools:

  • Scripts/build-webkit: Remove --v8 option.
7:45 AM Changeset in webkit [122844] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Don't use deprecated soup API in WebKit2APITests/TestResources
https://bugs.webkit.org/show_bug.cgi?id=91496

Reviewed by Martin Robinson.

soup_message_headers_get() is deprecated, use
soup_message_headers_get_one() instead.

  • UIProcess/API/gtk/tests/TestResources.cpp:

(serverCallback):

6:51 AM Changeset in webkit [122843] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=91479

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-17

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
6:46 AM Styling Form Controls edited by tkent@chromium.org
(diff)
6:45 AM Changeset in webkit [122842] by commit-queue@webkit.org
  • 25 edits in trunk/LayoutTests

[Qt] fast/box-{shadow,sizing} tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91397

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-17
Reviewed by Simon Hausmann.

Updated expected Qt results for most box-shadow/ and box-sizing layout tests,
after testfonts changes made by bug 85203.

  • platform/qt-5.0/Skipped:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
  • platform/qt/fast/box-shadow/basic-shadows-expected.txt:
  • platform/qt/fast/box-shadow/border-radius-big-expected.png:
  • platform/qt/fast/box-shadow/border-radius-big-expected.txt:
  • platform/qt/fast/box-shadow/box-shadow-radius-expected.txt:
  • platform/qt/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/qt/fast/box-shadow/box-shadow-transformed-expected.txt:
  • platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.png:
  • platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.txt:
  • platform/qt/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/qt/fast/box-shadow/inset-box-shadows-expected.txt:
  • platform/qt/fast/box-shadow/inset-expected.png:
  • platform/qt/fast/box-shadow/inset-expected.txt:
  • platform/qt/fast/box-shadow/scaled-box-shadow-expected.png:
  • platform/qt/fast/box-shadow/scaled-box-shadow-expected.txt:
  • platform/qt/fast/box-shadow/transform-fringing-expected.png:
  • platform/qt/fast/box-shadow/transform-fringing-expected.txt:
  • platform/qt/fast/box-sizing/box-sizing-expected.png:
  • platform/qt/fast/box-sizing/box-sizing-expected.txt:
  • platform/qt/fast/box-sizing/panels-one-expected.png:
  • platform/qt/fast/box-sizing/panels-one-expected.txt:
  • platform/qt/fast/box-sizing/panels-two-expected.png:
  • platform/qt/fast/box-sizing/panels-two-expected.txt:
6:23 AM Changeset in webkit [122841] by zoltan@webkit.org
  • 4 edits in trunk

[QT] REGRESSION (r122720): svg/filters/feSpecularLight-premultiplied.svg
https://bugs.webkit.org/show_bug.cgi?id=91390

Reviewed by Zoltan Herczeg.

Fix the regression by using the proper imagetype conversion in ImageBuffer::platformTransformColorSpace.

The test is unskipped.

Source/WebCore:

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::platformTransformColorSpace):

LayoutTests:

  • platform/qt/Skipped:
6:00 AM Drosera edited by wil@marrant.org
(diff)
5:30 AM Changeset in webkit [122840] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix a typo in WebKit2APITests/TestResources
https://bugs.webkit.org/show_bug.cgi?id=91495

Reviewed by Xan Lopez.

  • UIProcess/API/gtk/tests/TestResources.cpp:

(testWebResourceLoading):
(testWebResourceResponse):
(testWebResourceMimeType):
(testWebResourceActiveURI):

5:21 AM Changeset in webkit [122839] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r122824.

Patch by János Badics <János Badics> on 2012-07-17

  • platform/qt/Skipped:
5:11 AM Changeset in webkit [122838] by commit-queue@webkit.org
  • 43 edits in trunk/Source

Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.
https://bugs.webkit.org/show_bug.cgi?id=91196

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-17
Reviewed by Pavel Feldman.

Source/WebCore:

Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel. Also refactored
InspectorController::connectFrontend() to receive
InspectorFrontendChannel.

No new test as code refactoring done.

  • inspector/InspectorClient.h:

(WebCore):
(InspectorClient):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::show):
(WebCore::InspectorController::reconnectFrontend):

  • inspector/InspectorController.h:

(WebCore):
(InspectorController):

  • loader/EmptyClients.h:

(WebCore::EmptyInspectorClient::openInspectorFrontend):
(WebCore::EmptyInspectorClient::hideHighlight):

Source/WebKit/blackberry:

Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::enableWebInspector):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/InspectorClientBlackBerry.cpp:

(WebCore::InspectorClientBlackBerry::openInspectorFrontend):

  • WebCoreSupport/InspectorClientBlackBerry.h:

(InspectorClientBlackBerry):

Source/WebKit/chromium:

Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::openInspectorFrontend):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::reattach):
(WebKit::WebDevToolsAgentImpl::openInspectorFrontend):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

Source/WebKit/efl:

Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::openInspectorFrontend):

  • WebCoreSupport/InspectorClientEfl.h:

(InspectorClientEfl):

Source/WebKit/gtk:

Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::openInspectorFrontend):

  • WebCoreSupport/InspectorClientGtk.h:

(InspectorClient):

Source/WebKit/mac:

Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.

  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient):

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::openInspectorFrontend):

Source/WebKit/qt:

Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::openInspectorFrontend):
(WebCore::InspectorClientQt::attachAndReplaceRemoteFrontend):

  • WebCoreSupport/InspectorClientQt.h:

(InspectorClientQt):

Source/WebKit/win:

Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::openInspectorFrontend):

  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient):

Source/WebKit/wince:

Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.

  • WebCoreSupport/InspectorClientWinCE.cpp:

(WebKit::InspectorClientWinCE::openInspectorFrontend):

  • WebCoreSupport/InspectorClientWinCE.h:

(InspectorClientWinCE):

Source/WebKit/wx:

Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.

  • WebKitSupport/InspectorClientWx.cpp:

(WebCore::InspectorClientWx::openInspectorFrontend):

  • WebKitSupport/InspectorClientWx.h:

(InspectorClientWx):

Source/WebKit2:

Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient):

4:37 AM Changeset in webkit [122837] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r122768, r122771) - it made ~ 160 fails on WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91490

Unreviewed gardening.

Patch by János Badics <János Badics> on 2012-07-17

  • platform/qt-5.0-wk2/Skipped:
4:27 AM Changeset in webkit [122836] by kkristof@inf.u-szeged.hu
  • 25 edits
    1 copy
    6 adds in trunk

Unreviewed, rolling out r122834.
http://trac.webkit.org/changeset/122834
https://bugs.webkit.org/show_bug.cgi?id=91492

it broke the chromium (Requested by kkristof on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-17

.:

  • Source/api.pri:
  • WebKit.pro:

Source/WebCore:

  • DerivedSources.pri:
  • Target.pri:
  • WebCore.pri:
  • bindings/v8/ScriptCachedFrameData.cpp:

(WebCore):
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::domWindow):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):

  • bindings/v8/ScriptCachedFrameData.h:

(WebCore):
(ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/ScriptControllerQt.cpp: Copied from Source/WebCore/bindings/v8/ScriptCachedFrameData.cpp.

(WebCore):
(WebCore::ScriptController::qtScriptEngine):

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):

  • config.h:

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(setupScriptContext):
(QWebElement::evaluateJavaScript):
(QtWebElementRuntime::initialize):

  • Api/qwebframe.cpp:

(QWebFramePrivate::didClearWindowObject):
(QWebFrame::addToJavaScriptWindowObject):
(QWebFrame::evaluateJavaScript):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(QtDRTNodeRuntime::initialize):
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
(DumpRenderTreeSupportQt::garbageCollectorCollect):
(DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

(Bindings):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore):
(WebCore::FrameLoaderClientQt::didCreateScriptContext):
(WebCore::FrameLoaderClientQt::willReleaseScriptContext):
(WebCore::FrameLoaderClientQt::didCreateIsolatedScriptContext):
(WebCore::FrameLoaderClientQt::createDocumentLoader):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):
(WebCore::FrameLoaderClientQt::allowScriptExtension):

  • v8/ForwardingHeaders/v8-debug.h: Added.
  • v8/ForwardingHeaders/v8-preparser.h: Added.
  • v8/ForwardingHeaders/v8-profiler.h: Added.
  • v8/ForwardingHeaders/v8-testing.h: Added.
  • v8/ForwardingHeaders/v8.h: Added.
  • v8/ForwardingHeaders/v8stdint.h: Added.

Source/WTF:

  • WTF.pri:

Tools:

  • Scripts/build-webkit:
4:11 AM Changeset in webkit [122835] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Paste primary selection when middle clicking in X11 WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91411

Reviewed by Xan Lopez.

Handle middle click events to paste primary selection as expected
in any X11 application.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent): Call handleMousePressedEvent() for GTK+
platform.

  • WebProcess/WebPage/WebPage.h:

(WebPage): Add handleMousePressedEvent() for GTK+ platform.

  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::handleMousePressedEvent): Handle middle click
events to paste primary selection like we do in WebKit1.

3:58 AM Changeset in webkit [122834] by kkristof@inf.u-szeged.hu
  • 25 edits
    7 deletes in trunk

[Qt][V8] Remove the V8 related codepaths and configuration
https://bugs.webkit.org/show_bug.cgi?id=90863

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-07-17
Reviewed by Simon Hausmann.

.:

  • Source/api.pri:
  • WebKit.pro:

Source/WebCore:

No new tests, because there is no new functionality.

  • DerivedSources.pri:
  • Target.pri:
  • WebCore.pri:
  • bindings/v8/ScriptCachedFrameData.cpp:
  • bindings/v8/ScriptCachedFrameData.h:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/ScriptControllerQt.cpp: Removed.
  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::histogramEnumeration):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):

  • config.h:

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(setupScriptContext):
(QWebElement::evaluateJavaScript):
(convertWebElementVariantToJSValue):
(QtWebElementRuntime::initialize):

  • Api/qwebframe.cpp:

(QWebFramePrivate::didClearWindowObject):
(QWebFramePrivate::addQtSenderToGlobalObject):
(QWebFrame::addToJavaScriptWindowObject):
(QWebFrame::evaluateJavaScript):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(convertNodeVariantToJSValue):
(QtDRTNodeRuntime::initialize):
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
(DumpRenderTreeSupportQt::garbageCollectorCollect):
(DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createDocumentLoader):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

  • v8/ForwardingHeaders/v8-debug.h: Removed.
  • v8/ForwardingHeaders/v8-preparser.h: Removed.
  • v8/ForwardingHeaders/v8-profiler.h: Removed.
  • v8/ForwardingHeaders/v8-testing.h: Removed.
  • v8/ForwardingHeaders/v8.h: Removed.
  • v8/ForwardingHeaders/v8stdint.h: Removed.

Source/WTF:

  • WTF.pri:

Tools:

  • Scripts/build-webkit: Remove --v8 option.
3:36 AM Changeset in webkit [122833] by kbalazs@webkit.org
  • 3 edits in trunk/Tools

[Qt] Add --use-test-fonts option to Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=91402

Reviewed by Tor Arne Vestbø.

Same stuff that already exists for QtTestBrowser.

  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::handleUserOptions):

3:23 AM Changeset in webkit [122832] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Enable registerProtocolHandler for Blackberry
https://bugs.webkit.org/show_bug.cgi?id=90422

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-07-17
Reviewed by George Staikos.

Implements APIs were added in Custom Scheme Handler specification
which is at http://dev.w3.org/html5/spec/Overview.html#custom-handlers.

Test cases:
fast/dom/register-protocol-handler.html
fast/dom/unregister-protocol-handler.html

  • Api/WebPageClient.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
(WebCore::ChromeClientBlackBerry::unregisterProtocolHandler):
(WebCore::ChromeClientBlackBerry::registerProtocolHandler):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

2:59 AM Changeset in webkit [122831] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

"in body" insertion mode, "any other end tag" step 2.1 is updated
https://bugs.webkit.org/show_bug.cgi?id=91473

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-17
Reviewed by Eric Seidel.

The HTML5 spec is updated to change the 'end tag' processing to not imply
its own end tag, since that makes no sense. Step 2.1 now says
"Generate implied end tags, except for elements with the same tag name as the token."
Modified to follow the updated spec. Also removed the first FIXME because now
ElementRecord can't be deleted by the preceeding call.

This patch does not actually change the behavior because of the previous
check (aborts if generateImpliedEndTags has already popped the node for the token),
so no new tests.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):

2:45 AM Changeset in webkit [122830] by kbalazs@webkit.org
  • 137 edits
    12 copies
    55 adds in trunk/LayoutTests

[Qt] platfrom/qt/editing/inserting tests needs update after test font change.
https://bugs.webkit.org/show_bug.cgi?id=91378.

Unreviewed rebaseline.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-16

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.png: Removed.
  • platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.txt: Removed.
  • platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.png: Removed.
  • platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.txt: Removed.
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/editing/inserting/12882-expected.png: Added.
  • platform/qt/editing/inserting/12882-expected.txt:
  • platform/qt/editing/inserting/4278698-expected.png:
  • platform/qt/editing/inserting/4278698-expected.txt:
  • platform/qt/editing/inserting/4840662-expected.png: Added.
  • platform/qt/editing/inserting/4840662-expected.txt:
  • platform/qt/editing/inserting/4875189-1-expected.png: Added.
  • platform/qt/editing/inserting/4875189-1-expected.txt:
  • platform/qt/editing/inserting/4875189-2-expected.png: Added.
  • platform/qt/editing/inserting/4875189-2-expected.txt:
  • platform/qt/editing/inserting/4959067-expected.png: Added.
  • platform/qt/editing/inserting/4959067-expected.txt:
  • platform/qt/editing/inserting/4960120-1-expected.png:
  • platform/qt/editing/inserting/4960120-1-expected.txt:
  • platform/qt/editing/inserting/4960120-2-expected.png: Added.
  • platform/qt/editing/inserting/4960120-2-expected.txt:
  • platform/qt/editing/inserting/5002441-expected.png: Added.
  • platform/qt/editing/inserting/5002441-expected.txt:
  • platform/qt/editing/inserting/5058163-1-expected.png: Added.
  • platform/qt/editing/inserting/5058163-1-expected.txt:
  • platform/qt/editing/inserting/5058163-2-expected.png: Added.
  • platform/qt/editing/inserting/5058163-2-expected.txt:
  • platform/qt/editing/inserting/5156401-2-expected.png: Added.
  • platform/qt/editing/inserting/5156401-2-expected.txt:
  • platform/qt/editing/inserting/5418891-expected.png: Added.
  • platform/qt/editing/inserting/5418891-expected.txt:
  • platform/qt/editing/inserting/5510537-expected.png: Added.
  • platform/qt/editing/inserting/5510537-expected.txt:
  • platform/qt/editing/inserting/5549929-2-expected.png: Added.
  • platform/qt/editing/inserting/5549929-2-expected.txt:
  • platform/qt/editing/inserting/5549929-3-expected.png: Added.
  • platform/qt/editing/inserting/5549929-3-expected.txt:
  • platform/qt/editing/inserting/6703873-expected.png: Added.
  • platform/qt/editing/inserting/6703873-expected.txt:
  • platform/qt/editing/inserting/before-after-input-element-expected.png:
  • platform/qt/editing/inserting/before-after-input-element-expected.txt:
  • platform/qt/editing/inserting/break-blockquote-after-delete-expected.png: Added.
  • platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/qt/editing/inserting/editable-html-element-expected.png:
  • platform/qt/editing/inserting/editable-html-element-expected.txt:
  • platform/qt/editing/inserting/editable-inline-element-expected.png: Added.
  • platform/qt/editing/inserting/editable-inline-element-expected.txt:
  • platform/qt/editing/inserting/edited-whitespace-1-expected.png: Added.
  • platform/qt/editing/inserting/edited-whitespace-1-expected.txt:
  • platform/qt/editing/inserting/editing-empty-divs-expected.png:
  • platform/qt/editing/inserting/editing-empty-divs-expected.txt:
  • platform/qt/editing/inserting/insert-3654864-fix-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-3775316-fix-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
  • platform/qt/editing/inserting/insert-3775316-fix-expected.txt:
  • platform/qt/editing/inserting/insert-3778059-fix-expected.png: Added.
  • platform/qt/editing/inserting/insert-3778059-fix-expected.txt:
  • platform/qt/editing/inserting/insert-3800346-fix-expected.png: Added.
  • platform/qt/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/qt/editing/inserting/insert-3851164-fix-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-after-delete-001-expected.png:
  • platform/qt/editing/inserting/insert-after-delete-001-expected.txt:
  • platform/qt/editing/inserting/insert-at-end-01-expected.png: Added.
  • platform/qt/editing/inserting/insert-at-end-01-expected.txt:
  • platform/qt/editing/inserting/insert-at-end-02-expected.png: Added.
  • platform/qt/editing/inserting/insert-at-end-02-expected.txt:
  • platform/qt/editing/inserting/insert-br-001-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
  • platform/qt/editing/inserting/insert-br-001-expected.txt:
  • platform/qt/editing/inserting/insert-br-002-expected.png: Added.
  • platform/qt/editing/inserting/insert-br-002-expected.txt:
  • platform/qt/editing/inserting/insert-br-003-expected.png:
  • platform/qt/editing/inserting/insert-br-003-expected.txt:
  • platform/qt/editing/inserting/insert-br-004-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-3851164-fix-expected.png.
  • platform/qt/editing/inserting/insert-br-004-expected.txt:
  • platform/qt/editing/inserting/insert-br-005-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
  • platform/qt/editing/inserting/insert-br-005-expected.txt:
  • platform/qt/editing/inserting/insert-br-006-expected.png:
  • platform/qt/editing/inserting/insert-br-006-expected.txt:
  • platform/qt/editing/inserting/insert-br-007-expected.png:
  • platform/qt/editing/inserting/insert-br-007-expected.txt:
  • platform/qt/editing/inserting/insert-br-008-expected.png:
  • platform/qt/editing/inserting/insert-br-008-expected.txt:
  • platform/qt/editing/inserting/insert-br-009-expected.png:
  • platform/qt/editing/inserting/insert-br-009-expected.txt:
  • platform/qt/editing/inserting/insert-br-at-tabspan-001-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
  • platform/qt/editing/inserting/insert-br-at-tabspan-001-expected.txt:
  • platform/qt/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/qt/editing/inserting/insert-br-at-tabspan-002-expected.txt:
  • platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.txt:
  • platform/qt/editing/inserting/insert-br-quoted-001-expected.png: Added.
  • platform/qt/editing/inserting/insert-br-quoted-001-expected.txt:
  • platform/qt/editing/inserting/insert-br-quoted-002-expected.png: Added.
  • platform/qt/editing/inserting/insert-br-quoted-002-expected.txt:
  • platform/qt/editing/inserting/insert-br-quoted-003-expected.png: Added.
  • platform/qt/editing/inserting/insert-br-quoted-003-expected.txt:
  • platform/qt/editing/inserting/insert-br-quoted-004-expected.png: Added.
  • platform/qt/editing/inserting/insert-br-quoted-004-expected.txt:
  • platform/qt/editing/inserting/insert-br-quoted-005-expected.png: Added.
  • platform/qt/editing/inserting/insert-br-quoted-005-expected.txt:
  • platform/qt/editing/inserting/insert-br-quoted-006-expected.png: Added.
  • platform/qt/editing/inserting/insert-br-quoted-006-expected.txt:
  • platform/qt/editing/inserting/insert-div-001-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
  • platform/qt/editing/inserting/insert-div-001-expected.txt:
  • platform/qt/editing/inserting/insert-div-002-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
  • platform/qt/editing/inserting/insert-div-002-expected.txt:
  • platform/qt/editing/inserting/insert-div-003-expected.png:
  • platform/qt/editing/inserting/insert-div-003-expected.txt:
  • platform/qt/editing/inserting/insert-div-004-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-after-delete-001-expected.png.
  • platform/qt/editing/inserting/insert-div-004-expected.txt:
  • platform/qt/editing/inserting/insert-div-005-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-005-expected.txt:
  • platform/qt/editing/inserting/insert-div-006-expected.png:
  • platform/qt/editing/inserting/insert-div-006-expected.txt:
  • platform/qt/editing/inserting/insert-div-007-expected.png:
  • platform/qt/editing/inserting/insert-div-007-expected.txt:
  • platform/qt/editing/inserting/insert-div-008-expected.png:
  • platform/qt/editing/inserting/insert-div-008-expected.txt:
  • platform/qt/editing/inserting/insert-div-009-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-div-010-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-div-011-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-011-expected.txt:
  • platform/qt/editing/inserting/insert-div-012-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-012-expected.txt:
  • platform/qt/editing/inserting/insert-div-013-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-013-expected.txt:
  • platform/qt/editing/inserting/insert-div-014-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-014-expected.txt:
  • platform/qt/editing/inserting/insert-div-015-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-015-expected.txt:
  • platform/qt/editing/inserting/insert-div-016-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-016-expected.txt:
  • platform/qt/editing/inserting/insert-div-017-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-017-expected.txt:
  • platform/qt/editing/inserting/insert-div-018-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-018-expected.txt:
  • platform/qt/editing/inserting/insert-div-019-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-019-expected.txt:
  • platform/qt/editing/inserting/insert-div-020-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-020-expected.txt:
  • platform/qt/editing/inserting/insert-div-022-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-022-expected.txt:
  • platform/qt/editing/inserting/insert-div-023-expected.png:
  • platform/qt/editing/inserting/insert-div-023-expected.txt:
  • platform/qt/editing/inserting/insert-div-024-expected.png:
  • platform/qt/editing/inserting/insert-div-024-expected.txt:
  • platform/qt/editing/inserting/insert-div-025-expected.png:
  • platform/qt/editing/inserting/insert-div-025-expected.txt:
  • platform/qt/editing/inserting/insert-div-026-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-026-expected.txt:
  • platform/qt/editing/inserting/insert-div-027-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-027-expected.txt:
  • platform/qt/editing/inserting/insert-paragraph-01-expected.png: Added.
  • platform/qt/editing/inserting/insert-paragraph-01-expected.txt:
  • platform/qt/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/qt/editing/inserting/insert-paragraph-02-expected.txt:
  • platform/qt/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/qt/editing/inserting/insert-paragraph-03-expected.txt:
  • platform/qt/editing/inserting/insert-paragraph-04-expected.png: Added.
  • platform/qt/editing/inserting/insert-paragraph-04-expected.txt:
  • platform/qt/editing/inserting/insert-paragraph-05-expected.png: Added.
  • platform/qt/editing/inserting/insert-paragraph-05-expected.txt:
  • platform/qt/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/qt/editing/inserting/insert-space-in-empty-doc-expected.txt:
  • platform/qt/editing/inserting/insert-tab-001-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-after-delete-001-expected.png.
  • platform/qt/editing/inserting/insert-tab-001-expected.txt:
  • platform/qt/editing/inserting/insert-tab-002-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-after-delete-001-expected.png.
  • platform/qt/editing/inserting/insert-tab-002-expected.txt:
  • platform/qt/editing/inserting/insert-tab-004-expected.png: Renamed from LayoutTests/platform/qt/editing/inserting/insert-3851164-fix-expected.png.
  • platform/qt/editing/inserting/insert-tab-004-expected.txt:
  • platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.txt:
  • platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.txt:
  • platform/qt/editing/inserting/insert-text-at-tabspan-003-expected.png: Renamed from LayoutTests/platform/qt/editing/inserting/insert-3654864-fix-expected.png.
  • platform/qt/editing/inserting/insert-text-at-tabspan-003-expected.txt:
  • platform/qt/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/qt/editing/inserting/insert-text-with-newlines-expected.txt:
  • platform/qt/editing/inserting/line-break-expected.png: Added.
  • platform/qt/editing/inserting/line-break-expected.txt:
  • platform/qt/editing/inserting/multiple-lines-selected-expected.png:
  • platform/qt/editing/inserting/multiple-lines-selected-expected.txt:
  • platform/qt/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/qt/editing/inserting/paragraph-separator-01-expected.txt:
  • platform/qt/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/qt/editing/inserting/paragraph-separator-02-expected.txt:
  • platform/qt/editing/inserting/paragraph-separator-03-expected.png:
  • platform/qt/editing/inserting/paragraph-separator-03-expected.txt:
  • platform/qt/editing/inserting/paragraph-separator-in-table-1-expected.png: Added.
  • platform/qt/editing/inserting/paragraph-separator-in-table-1-expected.txt:
  • platform/qt/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
  • platform/qt/editing/inserting/paragraph-separator-in-table-2-expected.txt:
  • platform/qt/editing/inserting/redo-expected.png:
  • platform/qt/editing/inserting/redo-expected.txt:
  • platform/qt/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/qt/editing/inserting/return-key-with-selection-001-expected.txt:
  • platform/qt/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/qt/editing/inserting/return-key-with-selection-002-expected.txt:
  • platform/qt/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/qt/editing/inserting/return-key-with-selection-003-expected.txt:
  • platform/qt/editing/inserting/typing-001-expected.png:
  • platform/qt/editing/inserting/typing-001-expected.txt:
  • platform/qt/editing/inserting/typing-002-expected.png:
  • platform/qt/editing/inserting/typing-002-expected.txt:
  • platform/qt/editing/inserting/typing-003-expected.png:
  • platform/qt/editing/inserting/typing-003-expected.txt:
  • platform/qt/editing/inserting/typing-around-br-001-expected.png:
  • platform/qt/editing/inserting/typing-around-br-001-expected.txt:
  • platform/qt/editing/inserting/typing-around-image-001-expected.png:
  • platform/qt/editing/inserting/typing-around-image-001-expected.txt:
2:20 AM Changeset in webkit [122829] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, skipped failing test.
https://bugs.webkit.org/show_bug.cgi?id=91477

  • platform/chromium/TestExpectations:
2:09 AM Changeset in webkit [122828] by abarth@webkit.org
  • 5 edits in trunk/Tools

[Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
https://bugs.webkit.org/show_bug.cgi?id=91459

Reviewed by Ryosuke Niwa.

Rather than having TestShell own and bind each of these JavaScript APIs
individually, TestShell should delegate that work to TestInterfaces.
This patch moves AccessibilityController and TextInputController to be
the responsibility of TestInterfaces.

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:

(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::setWebView):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.h:

(WebKit):
(TestInterfaces):
(TestInterfaces::accessibilityController):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::accessibilityController):
(TestShell):

2:05 AM Changeset in webkit [122827] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r122768 or r122771.
https://bugs.webkit.org/show_bug.cgi?id=91476

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-07-17

  • platform/qt/Skipped:
1:45 AM Changeset in webkit [122826] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after 122816. Skipped fast/dom/shadow/shadowdom-for-media.html
because ENABLE(SHADOW_DOM) is disabled on Qt.

Patch by János Badics <János Badics> on 2012-07-17

  • platform/qt/Skipped:
1:37 AM Changeset in webkit [122825] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

[Regression] Infinite loop in document.elementFromPoint
https://bugs.webkit.org/show_bug.cgi?id=90820

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Node::shadowAncestorNode returns the caller node itself for SVGElement. However,
since we have already implemented event retargeting algorithm in Shadow DOM, we don't have to
take a special care of SVGElement for Node.shadowAncestorNode() now.

This patch will removes the special care code and fixes infinite loop in document.elementFromPoint().

Test: svg/hittest/svg-use-element-from-point.html

  • dom/Node.cpp:

(WebCore::Node::shadowAncestorNode):

LayoutTests:

  • svg/hittest/svg-use-element-from-point-expected.txt: Added.
  • svg/hittest/svg-use-element-from-point.html: Added.
1:27 AM Changeset in webkit [122824] by shinyak@chromium.org
  • 26 edits
    25 adds in trunk

Shadow DOM for img element
https://bugs.webkit.org/show_bug.cgi?id=90532

Reviewed by Hajime Morita.

Source/WebCore:

This patch adds Shadow DOM support for img element.

According to the Shadow DOM spec, img element should behave like having a user agent Shadow DOM.
However, if we add Shadow DOM to img by default, it will cause performance regression and memory bloat.

So, we would like to postpone adding a Shadow DOM to img until when we really need it. In other words,
we add our User Agent Shadow DOM to img just before a user adds Author Shadow DOM.

The User Agent Shadow DOM for img has only one element, which displays an image. If img has
a Shadow DOM, img will behave like <span style="display: inline-block"> by default. The display style can
be chagned using CSS though.

This patch also adds ImageLoaderClient. The element we render an image and the element we take an argument
from were the same, however not they might be different. We would like to encapsulate the fact into
ImageLoaderClient.

Tests: fast/dom/shadow/shadowdom-for-image-alt-update.html

fast/dom/shadow/shadowdom-for-image-alt.html
fast/dom/shadow/shadowdom-for-image-content.html
fast/dom/shadow/shadowdom-for-image-dynamic.html
fast/dom/shadow/shadowdom-for-image-event-click.html
fast/dom/shadow/shadowdom-for-image-in-shadowdom.html
fast/dom/shadow/shadowdom-for-image-map.html
fast/dom/shadow/shadowdom-for-image-style.html
fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html
fast/dom/shadow/shadowdom-for-image-with-width-and-height.html
fast/dom/shadow/shadowdom-for-image.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/html.css:

(img):

  • html/HTMLImageElement.cpp:

(WebCore::ImageElement::setImageIfNecessary):
(WebCore):
(WebCore::ImageElement::createRendererForImage):
(WebCore::HTMLImageElement::willAddAuthorShadowRoot): When we don't have a user agent Shadow DOM yet
we add it.
(WebCore::HTMLImageElement::createShadowSubtree):
(WebCore::HTMLImageElement::imageElement):
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::createRenderer): If a user agent Shadow DOM is attached, we create
Renderer from style, instead of creating RenderImage.
(WebCore::HTMLImageElement::attach):
(WebCore::HTMLImageElement::innerElement):

  • html/HTMLImageElement.h:

(WebCore):
(ImageElement):
(HTMLImageElement):
(WebCore::HTMLImageElement::sourceElement):
(WebCore::HTMLImageElement::refSourceElement):
(WebCore::HTMLImageElement::derefSourceElement):
(WebCore::HTMLImageElement::imageRenderer):
(WebCore::HTMLImageElement::imageLoader):
(WebCore::isHTMLImageElement):
(WebCore::toHTMLImageElement):

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::HTMLImageLoader):
(WebCore::HTMLImageLoader::dispatchLoadEvent):
(WebCore::HTMLImageLoader::sourceURI):
(WebCore::HTMLImageLoader::notifyFinished):

  • html/HTMLImageLoader.h:

(HTMLImageLoader):

  • html/HTMLInputElement.h:
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.h:
  • html/HTMLTagNames.in:
  • html/HTMLVideoElement.h:
  • html/shadow/ImageInnerElement.cpp: Added.

(WebCore):
(WebCore::ImageInnerElement::ImageInnerElement):
(WebCore::ImageInnerElement::hostImage):
(WebCore::ImageInnerElement::imageLoader):
(WebCore::ImageInnerElement::attach):
(WebCore::ImageInnerElement::createRenderer):

  • html/shadow/ImageInnerElement.h: Added.

(WebCore):
(ImageInnerElement):
(WebCore::ImageInnerElement::imageRenderer):
(WebCore::ImageInnerElement::create):
(WebCore::isImageInnerElement):
(WebCore::toImageInnerElement):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore):
(WebCore::ImageLoader::document):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::renderImageResource):
(WebCore::ImageLoader::updatedHasPendingLoadEvent):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvent):

  • loader/ImageLoader.h:

(WebCore):
(ImageLoader):
(WebCore::ImageLoader::client):

  • loader/ImageLoaderClient.h: Added.

(WebCore):
(ImageLoaderClient): Provides the necessary interfaces to ImageLoader.
(WebCore::ImageLoaderClient::~ImageLoaderClient):
(ImageLoaderClientBase):
(WebCore::ImageLoaderClientBase::sourceElement):
(WebCore::ImageLoaderClientBase::imageElement):
(WebCore::ImageLoaderClientBase::refSourceElement):
(WebCore::ImageLoaderClientBase::derefSourceElement):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):
(WebCore::RenderImage::hostImageElement):
(WebCore):

  • rendering/RenderImage.h:

(WebCore):
(RenderImage):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

  • svg/SVGImageElement.h:

(SVGImageElement):

  • svg/SVGImageLoader.cpp:

(WebCore::SVGImageLoader::SVGImageLoader):
(WebCore::SVGImageLoader::dispatchLoadEvent):
(WebCore::SVGImageLoader::sourceURI):

  • svg/SVGImageLoader.h:

(SVGImageLoader):

LayoutTests:

Contains the following test cases.
(1) ShadowDOM is attached to an img element and use a shadow element
(2) ShadowDOM is attached to an img element and use a content element
(3) width and height are specified
(4) src attribute is dynamically changed
(5) multiple ShadowDOMs are attached to an img element
(6) ShadowDOM is attached to an img element in Shadow DOM
(7) event retargetting
(8) img with display: none, display: inline, display: block
(9) image map
(10) alt text
(11) alt text with dynamic update

  • fast/dom/shadow/shadowdom-for-image-alt-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-image-alt-update-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-image-alt-update.html: Added.
  • fast/dom/shadow/shadowdom-for-image-alt.html: Added.
  • fast/dom/shadow/shadowdom-for-image-content-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-image-content.html: Added.
  • fast/dom/shadow/shadowdom-for-image-dynamic-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-image-dynamic.html: Added.
  • fast/dom/shadow/shadowdom-for-image-event-click-expected.txt: Added.
  • fast/dom/shadow/shadowdom-for-image-event-click.html: Added.
  • fast/dom/shadow/shadowdom-for-image-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-image-in-shadowdom-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-image-in-shadowdom.html: Added.
  • fast/dom/shadow/shadowdom-for-image-map-expected.txt: Added.
  • fast/dom/shadow/shadowdom-for-image-map.html: Added.
  • fast/dom/shadow/shadowdom-for-image-style-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-image-style.html: Added.
  • fast/dom/shadow/shadowdom-for-image-with-multiple-shadow-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html: Added.
  • fast/dom/shadow/shadowdom-for-image-with-width-and-height-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-image-with-width-and-height.html: Added.
  • fast/dom/shadow/shadowdom-for-image.html: Added.
1:22 AM Changeset in webkit [122823] by tkent@chromium.org
  • 10 edits in trunk/Source/WebCore

Internals: Remove injectPagePopupController()
https://bugs.webkit.org/show_bug.cgi?id=91471

Reviewed by Hajime Morita.

r122558 introduced injectPagePopupController(), however we'd like to
avoid adding such JavaScript binding code. We can avoid it by exposing a
PagePopupController for a mock and injecting the following code to the
popup document:

<script>window.pagePopupController = window.internals.pagePopupController</script>

No new tests. This is a kind of refactoring.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::pagePopupController):
Added. Accessor for PagePopupControler owned by the MockPagePopupDriver.

  • testing/InternalSettings.h:

(InternalSettings): Declare pagePopupController() for Internals::pagePopupController().

  • testing/Internals.cpp:

(WebCore::Internals::pagePopupController):
Added. This uses InternalSettings::pagePopupController().

  • testing/Internals.h:

(Internals): Declare pagePopupController() for Internals.idl.

  • testing/Internals.idl: Declare pagePopupController.
  • testing/MockPagePopupDriver.cpp:

Moved m_pagePopupController from MockPagePopup to MockPagePopupDriver.
(WebCore::MockPagePopup::MockPagePopup):
Added a script element to prepare window.pagePopupController.
Removed a callsite of injectPagePopupController().
(WebCore::MockPagePopupDriver::openPagePopup):
(WebCore::MockPagePopupDriver::closePagePopup):

  • testing/MockPagePopupDriver.h:

(WebCore::MockPagePopupDriver::pagePopupController):
Accessor for a PagePopupController object.
(MockPagePopupDriver): Add RefPtr<PagePopupController> data member.

  • testing/v8/WebCoreTestSupport.cpp: Remove injectPagePopupController().
  • testing/v8/WebCoreTestSupport.h: ditto.
1:11 AM Changeset in webkit [122822] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

[Chromium] Move TextInputController into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=91457

Reviewed by Ryosuke Niwa.

This patch is purely moving code. TextInputController is one of the
objects exposed to JavaScript and so should be in the TestRunner
library.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/TextInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/TextInputController.cpp.
  • DumpRenderTree/chromium/TestRunner/TextInputController.h: Renamed from Tools/DumpRenderTree/chromium/TextInputController.h.
1:10 AM Changeset in webkit [122821] by abarth@webkit.org
  • 4 edits in trunk/Tools

[Chromium] TextInputController shouldn't know about TestShell
https://bugs.webkit.org/show_bug.cgi?id=91455

Reviewed by Kent Tamura.

This patch uses the same pattern we used for the
AccessibilityController to remove the dependency on TestShell.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):

  • DumpRenderTree/chromium/TextInputController.cpp:

(TextInputController::TextInputController):
(TextInputController::insertText):
(TextInputController::doCommand):
(TextInputController::setMarkedText):
(TextInputController::unmarkText):
(TextInputController::hasMarkedText):
(TextInputController::markedRange):
(TextInputController::selectedRange):
(TextInputController::firstRectForCharacterRange):
(TextInputController::validAttributesForMarkedText):
(TextInputController::setComposition):

  • DumpRenderTree/chromium/TextInputController.h:

(WebKit):
(TextInputController):
(TextInputController::setWebView):

1:02 AM Changeset in webkit [122820] by vsevik@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed chromium tests rebaselines after r122791.

  • platform/chromium-win/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
1:00 AM Changeset in webkit [122819] by vsevik@chromium.org
  • 29 edits
    2 copies
    7 adds in trunk/LayoutTests

Unreviewed chromium tests rebaselines after r122785.

  • platform/chromium-linux-x86/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • platform/chromium-linux-x86/fast/reflections/reflection-with-zoom-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png.
  • platform/chromium-linux/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-linux/fast/css/transformed-mask-expected.png:
  • platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/css3-linear-right-angle-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.png:
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.png:
  • platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/transformed-mask-expected.png:
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-mac/fast/css/transformed-mask-expected.png:
  • platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
  • platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/css3-linear-right-angle-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/css3-radial-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/css3-repeating-radial-gradients-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-win-xp/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • platform/chromium-win-xp/fast/reflections/reflection-with-zoom-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png.
  • platform/chromium-win/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-win/fast/css/transformed-mask-expected.png:
  • platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
  • platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png:
  • platform/chromium-win/fast/gradients/css3-linear-right-angle-gradients-expected.png:
  • platform/chromium-win/fast/gradients/css3-radial-gradients-expected.png:
  • platform/chromium-win/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-win/fast/reflections/reflection-with-zoom-expected.png:
12:59 AM Changeset in webkit [122818] by rgabor@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed buildfix from Zoltan Herczeg after 122768.

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

12:52 AM Changeset in webkit [122817] by ryuan.choi@samsung.com
  • 14 edits in trunk/Source

[EFL] Move codes related to theme setting from Widget to RenderTheme
https://bugs.webkit.org/show_bug.cgi?id=89842

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

WebKit/Efl uses custom theme for Scrollbar, RenderTheme and Cursor.
However, theme information itself is in WidgetEfl so it is accessed by
calling recursive function.
Because theme is managed by each page, this patch moves codes related to
theme from WidgetEfl to RenderThemeEfl which is contained by page.

  • platform/Widget.h: Removed functions related to theme.
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::setThemePath): Added to set theme path.
(WebCore::RenderThemeEfl::createEdje): Updated method to use RenderThemeEfl's theme.
(WebCore::RenderThemeEfl::RenderThemeEfl):

  • platform/efl/RenderThemeEfl.h:

(WebCore::RenderThemeEfl::themePath): Added to get theme path

  • platform/efl/ScrollbarEfl.cpp: Updated method to use RenderThemeEfl's theme.

(ScrollbarEfl::setParent):

  • platform/efl/WidgetEfl.cpp: Removed codes related theme.

(WidgetPrivate):

Source/WebKit:

  • CMakeLists.txt: Added html/shadow to WebKit_INCLUDE_DIRECTORIES.

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_view_create_for_view): Removed codes which set theme in FrameView.

  • ewk/ewk_view.cpp:

(ewk_view_theme_set): Called RenderThemeEfl::setThemePath instead of setting theme in FrameView.

Source/WebKit2:

  • CMakeLists.txt: Added html/shadow to WebKit_INCLUDE_DIRECTORIES.
  • WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::WebPage::setThemePath): Called RenderThemeEfl::setThemePath instead of setting theme in FrameView.

12:26 AM Changeset in webkit [122816] by shinyak@chromium.org
  • 7 edits
    2 adds in trunk

HTMLMediaElement should not use Element::ensureShadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=77936

Reviewed by Hajime Morita.

Source/WebCore:

a video element and an audio element add UserAgentShadowRoot dynamically, and they assume that it's the oldest ShadowRoot.
However an AuthorShadowRoot could be added by a user before a video element and an audio element add UserAgentShadowRoot.
It breaks the assumption that the UserAgentShadowRoot is the oldest.

If the UserAgentShadowRoot is not the oldest, the AuthorShadowRoot a page author added might be ignored.
Since the timing to add UserAgentShadowRoot is not known by a user, the fact that UserAgentShadorRoot is
not the oldest will cause inconsistent behavior.

Adding AuthorShadowRoot to a video element and an audio element is allowed by this patch.

Test: fast/dom/shadow/shadowdom-for-media.html

  • dom/ShadowRoot.cpp:

(WebCore::allowsAuthorShadowRoot):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::createShadowSubtree):
(WebCore):
(WebCore::HTMLMediaElement::willAddAuthorShadowRoot):
(WebCore::HTMLMediaElement::createMediaControls):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

LayoutTests:

Adding Shadow DOM to a video element and an audio element is allowed now.

  • fast/dom/shadow/shadow-disable-expected.txt:
  • fast/dom/shadow/shadow-disable.html:
  • fast/dom/shadow/shadowdom-for-media-expected.txt: Added.
  • fast/dom/shadow/shadowdom-for-media.html: Added.
12:24 AM Styling Form Controls edited by tkent@chromium.org
(diff)
12:23 AM Changeset in webkit [122815] by yosin@chromium.org
  • 7 edits in trunk/LayoutTests

[Forms] Test expectations of datetime/datetime-local/time should not contain milliseconds when they aren't expected
https://bugs.webkit.org/show_bug.cgi?id=91469

Reviewed by Kent Tamura.

This patch gets rid of unexpected millisecond strings from both test
cases and expected text.

This is adaptation of behavior change caused by r119948, introducing
decimal arithmetic, which corrected the expression step mod 1000 used
in BaseDateAndTimeInputType::serialize for checking adding milliseconds
or not, which converts internal date time representation into string.

Before r119948, we used fmod(step, 1000) for this. However, it doesn't
return mathematically correct value when quotient is very large, e.g.
fmod(3.40282346e+38, 1000) returns 616 on x86 linux, although we
expect that it is 0.

  • fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Get rid of millig seconds for big step value tests.
  • fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html: ditto.
  • fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: ditto.
  • fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html: ditto.
  • fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Get rid of millig seconds for a big step value test and expected value's fractinal second is zero.
  • fast/forms/time/time-stepup-stepdown-from-renderer.html: ditto.
12:19 AM Changeset in webkit [122814] by kkristof@inf.u-szeged.hu
  • 2 edits
    3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped:
  • platform/qt/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Added.
12:18 AM Styling Form Controls edited by tkent@chromium.org
Add a section for <input type=date> (diff)
12:11 AM Changeset in webkit [122813] by commit-queue@webkit.org
  • 12 edits in trunk

Introduce ENABLE_CSS_IMAGE_ORIENTATION compile flag
https://bugs.webkit.org/show_bug.cgi?id=89055

Patch by David Barr <davidbarr@chromium.org> on 2012-07-17
Reviewed by Kent Tamura.

The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation

Add a configuration option for CSS image-orientation support, disabling it by default.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:
12:08 AM Changeset in webkit [122812] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the Chromium Mac build after <http://trac.webkit.org/changeset/122802>
(https://bugs.webkit.org/show_bug.cgi?id=91451)

Remove unused private instance variable AbsoluteQuadsGeneratorContext::m_wasFixed.
This instance variable has remained unused since it was added in
<http://trac.webkit.org/changeset/116718> (https://bugs.webkit.org/show_bug.cgi?id=85725).

I'm unclear as to why the Chromium Mac build began to complain about this
unused instance variable following <http://trac.webkit.org/changeset/122802>, since this
code has been in the tree for a while and we previously instantiated AbsoluteQuadsGeneratorContext
with wasFixed (even though it wasn't used). Regardless, we should remove the unused
instance variable AbsoluteQuadsGeneratorContext::m_wasFixed.

  • rendering/RenderInline.cpp:

(WebCore): Remove AbsoluteQuadsGeneratorContext::m_wasFixed.
(WebCore::RenderInline::absoluteQuads):

Note: See TracTimeline for information about the timeline view.