Timeline
Aug 6, 2012:
- 11:54 PM Changeset in webkit [124858] by
-
- 4 edits in trunk/Source/WebCore
IndexedDB: Make leveldb store integer versions and migrate old schemas
https://bugs.webkit.org/show_bug.cgi?id=92883
Reviewed by Tony Chang.
Our first schema change. If an existing DB doesn't have integer
versions, this will add one to all object stores in the origin.
No new tests - chrome test for the migration forthcoming. Will involve
starting with a leveldb directory from an old build of chrome, opening
it up with the migration code in place, and checking the new database.
http://codereview.chromium.org/10826159/
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::putVarInt):
(WebCore):
(WebCore::setUpMetadata):
Uses the ASSERT-but-still-handle-corruption pattern recently discussed
in https://bugs.webkit.org/show_bug.cgi?id=92725#c13.
(WebCore::IDBLevelDBBackingStore::open):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
Because we can't store negative numbers, store 0 instead of -1.
(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
- Modules/indexeddb/IDBLevelDBCoding.h:
- Modules/indexeddb/IDBMetadata.h:
- 11:40 PM Changeset in webkit [124857] by
-
- 20 edits5 deletes in trunk/Source/WebCore
Unreviewed, rolling out r124780.
http://trac.webkit.org/changeset/124780
https://bugs.webkit.org/show_bug.cgi?id=93340
We don't want an incomplete feature set for the chromium
branch cut. (Requested by annacc on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Modules/mediasource/MediaSource.cpp: Removed.
- Modules/mediasource/MediaSource.h: Removed.
- Modules/mediasource/MediaSource.idl: Removed.
- Modules/mediasource/MediaSourceRegistry.cpp: Removed.
- Modules/mediasource/MediaSourceRegistry.h: Removed.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::buffered):
(WebCore::SourceBuffer::append):
(WebCore::SourceBuffer::abort):
- Modules/mediasource/SourceBuffer.h:
(WebCore::SourceBuffer::create):
(WebCore::SourceBuffer::clear):
(SourceBuffer):
- Modules/mediasource/SourceBufferList.cpp:
- Modules/mediasource/SourceBufferList.h:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/EventTarget.h:
(WebCore):
- dom/EventTargetFactory.in:
- html/DOMURL.cpp:
- html/DOMURL.h:
(WebCore):
(DOMURL):
- html/DOMURL.idl:
- page/DOMWindow.idl:
- 11:37 PM Changeset in webkit [124856] by
-
- 6 edits in trunk
[EFL] Enable link prefetch
https://bugs.webkit.org/show_bug.cgi?id=93281
Reviewed by Kentaro Hara.
.:
- Source/cmake/OptionsEfl.cmake: Enable LINK_PREFETCH by default.
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable LINK_PREFETCH feature.
LayoutTests:
Unskip test cases related to link prefetch feature except for fast/dom/HTMLLinkElement/subresource.html.
- platform/efl/TestExpectations:
- 11:34 PM Changeset in webkit [124855] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, rebaseline again for chromium-linux-x86.
See, also r124850.
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06
- platform/chromium-linux-x86/fast/forms/formmethod-attribute-button-html-expected.txt: Removed.
- 11:07 PM Changeset in webkit [124854] by
-
- 14 edits in trunk/Tools
Unreviewed, rolling out r124801.
http://trac.webkit.org/changeset/124801
https://bugs.webkit.org/show_bug.cgi?id=93338
It broke NRWT (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):
(SingleTestRunner._compare_output_with_reference):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
(TestResultWriterTest):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.diff_image):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.diff_image):
- Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_diff_image):
- Scripts/webkitpy/layout_tests/port/image_diff.py:
(ImageDiffer.diff_image):
(ImageDiffer._read):
- Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
(TestImageDiffer.test_diff_image):
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.test_diff_image):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_diff_image):
- Scripts/webkitpy/layout_tests/port/server_process_mock.py:
(MockServerProcess.init):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.diff_image):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_tolerance.ImageDiffTestPort.diff_image):
- 10:58 PM Changeset in webkit [124853] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r124798.
http://trac.webkit.org/changeset/124798
https://bugs.webkit.org/show_bug.cgi?id=93337
We don't want an incomplete feature set for the chromium
branch cut. (Requested by annacc on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06
- html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
- html/PublicURLManager.h:
(WebCore::PublicURLManager::contextDestroyed):
(PublicURLManager):
- 10:54 PM Changeset in webkit [124852] by
-
- 18 edits1 move1 add1 delete in trunk
Unreviewed, rolling out r124848.
http://trac.webkit.org/changeset/124848
https://bugs.webkit.org/show_bug.cgi?id=93336
Caused 3 tests to crash on chromium Linux32/Mac10.6/Linux
(Requested by toyoshim on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::noneSupported):
(WebCore::HTMLMediaElement::mediaEngineError):
(WebCore::HTMLMediaElement::mediaPlayerSourceOpened):
(WebCore::HTMLMediaElement::isValidSourceId):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::webkitSourceAddId):
(WebCore::HTMLMediaElement::webkitSourceRemoveId):
(WebCore::HTMLMediaElement::webkitSourceBuffered):
(WebCore::HTMLMediaElement::webkitSourceAppend):
(WebCore::HTMLMediaElement::webkitSourceAbort):
(WebCore::HTMLMediaElement::webkitSourceEndOfStream):
(WebCore::HTMLMediaElement::webkitSourceState):
(WebCore::HTMLMediaElement::setSourceState):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::createMediaPlayer):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- html/HTMLMediaElement.idl:
LayoutTests:
- http/tests/media/media-source/media-source.js:
(MediaSourceTest.SegmentHelper):
(MediaSourceTest.SegmentHelper.prototype.addSourceId):
(MediaSourceTest.SegmentHelper.prototype.appendInitSegment):
(MediaSourceTest.SegmentHelper.prototype.appendMediaSegment):
(MediaSourceTest.SegmentHelper.prototype.appendUntilEndOfStream):
(MediaSourceTest.setSrcToMediaSourceTestURL):
(MediaSourceTest.defaultOnErrorChecks):
(MediaSourceTest.runOnSourceOpen.eventHandlerFunction):
(MediaSourceTest.runOnSourceOpen):
(MediaSourceTest.logSourceState):
(MediaSourceTest.expectSourceState):
(MediaSourceTest.getSourceStateName):
- http/tests/media/media-source/video-media-source-abort-expected.txt:
- http/tests/media/media-source/video-media-source-abort.html:
- http/tests/media/media-source/video-media-source-add-and-remove-buffers.html: Removed.
- http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt: Renamed from LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt.
- http/tests/media/media-source/video-media-source-add-and-remove-ids.html: Added.
- http/tests/media/media-source/video-media-source-errors-expected.txt:
- http/tests/media/media-source/video-media-source-errors.html:
- http/tests/media/media-source/video-media-source-event-attributes-expected.txt:
- http/tests/media/media-source/video-media-source-event-attributes.html:
- http/tests/media/media-source/video-media-source-play-expected.txt:
- http/tests/media/media-source/video-media-source-play.html:
- http/tests/media/media-source/video-media-source-seek-expected.txt:
- http/tests/media/media-source/video-media-source-seek.html:
- http/tests/media/media-source/video-media-source-state-changes-expected.txt:
- http/tests/media/media-source/video-media-source-state-changes.html:
- 10:47 PM Changeset in webkit [124851] by
-
- 5 edits in trunk/Tools
[Chromium]duplicated command line options in Android LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=93233
Patch by Wei James <james.wei@intel.com> on 2012-08-06
Reviewed by Tony Chang.
Duplicated options found in Android layout test command line:
--encode-binary and --enable-hardware-gpu.
If there are multiple ChromiumAndroidPort instances,
these two options will be appended for multiple times.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.additional_drt_flag):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.init):
(ChromiumAndroidPort.additional_drt_flag):
- Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidTwoPortsTest):
(ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.cmd_line):
- 10:47 PM Changeset in webkit [124850] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed, rebaseline for chromium-linux-x86.
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06
- platform/chromium-linux-x86/fast/forms/formmethod-attribute-button-html-expected.png: Added.
- platform/chromium-linux-x86/fast/forms/formmethod-attribute-button-html-expected.txt: Added.
- 9:48 PM Changeset in webkit [124849] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaseline for r124836.
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
- 9:41 PM Changeset in webkit [124848] by
-
- 18 edits1 move1 add1 delete in trunk
Update HTMLMediaElement to the new OO MediaSource API.
https://bugs.webkit.org/show_bug.cgi?id=91775
Reviewed by Eric Carlson.
This patch rips out the old-style MediaSource API and allows a
MediaSource object to be attached to HTMLMediaElement.
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html
Source/WebCore:
Test: http/tests/media/media-source/video-media-source-add-and-remove-buffers.html
Tests: updates to http/tests/media/media-source/*
- html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::HTMLMediaElement::HTMLMediaElement): Remove old style API resources.
(WebCore::HTMLMediaElement::parseAttribute): Remove old style event attributes.
(WebCore::HTMLMediaElement::prepareForLoad): Set source state to "closed".
(WebCore::HTMLMediaElement::loadResource): Get MediaSource object from blob registry
look up and, if found, set it's MediaPlayer pointer to the current MediaPlayer.
(WebCore::HTMLMediaElement::noneSupported): Set source state to "closed".
(WebCore::HTMLMediaElement::mediaEngineError): Set source state to "closed".
(WebCore::HTMLMediaElement::mediaPlayerSourceOpened): Set source state to "open".
(WebCore::HTMLMediaElement::mediaPlayerSourceURL): Change to new blob URL.
(WebCore::HTMLMediaElement::seek): Check if source state is "closed".
(WebCore::HTMLMediaElement::setSourceState): Helper function so that we don't have to
keep checking for m_mediaSource.
(WebCore::HTMLMediaElement::userCancelledLoad): Set source state to "closed".
(WebCore::HTMLMediaElement::createMediaPlayer): If the current MediaPlayer is re-
created, notify the MediaSource and reset its MediaPlayer.
- html/HTMLMediaElement.h: Remove old style API code and add a MediaSource object.
(HTMLMediaElement):
- html/HTMLMediaElement.idl: Remove old style API.
LayoutTests:
- http/tests/media/media-source/media-source.js:
(MediaSourceTest.SegmentHelper):
(MediaSourceTest.SegmentHelper.prototype.addSourceBuffer):
(MediaSourceTest.SegmentHelper.prototype.appendInitSegment):
(MediaSourceTest.SegmentHelper.prototype.appendMediaSegment):
(MediaSourceTest.SegmentHelper.prototype.appendUntilEndOfStream):
(MediaSourceTest.setSrcToMediaSourceTestURL):
(MediaSourceTest.defaultOnErrorChecks):
(MediaSourceTest.runOnSourceOpen.eventHandlerFunction):
(MediaSourceTest.runOnSourceOpen):
(MediaSourceTest.logSourceState):
(MediaSourceTest.expectSourceState):
- http/tests/media/media-source/video-media-source-abort-expected.txt:
- http/tests/media/media-source/video-media-source-abort.html:
- http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt: Renamed from LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt.
- http/tests/media/media-source/video-media-source-add-and-remove-buffers.html: Added.
- http/tests/media/media-source/video-media-source-add-and-remove-ids.html: Removed.
- http/tests/media/media-source/video-media-source-errors-expected.txt:
- http/tests/media/media-source/video-media-source-errors.html:
- http/tests/media/media-source/video-media-source-event-attributes-expected.txt:
- http/tests/media/media-source/video-media-source-event-attributes.html:
- http/tests/media/media-source/video-media-source-play-expected.txt:
- http/tests/media/media-source/video-media-source-play.html:
- http/tests/media/media-source/video-media-source-seek-expected.txt:
- http/tests/media/media-source/video-media-source-seek.html:
- http/tests/media/media-source/video-media-source-state-changes-expected.txt:
- http/tests/media/media-source/video-media-source-state-changes.html:
- 9:08 PM Changeset in webkit [124847] by
-
- 10 edits in trunk/Source/WebCore
BindingSecurity::shouldAllowAccessToFrame shouldn't use a raw boolean parameter
https://bugs.webkit.org/show_bug.cgi?id=93323
Reviewed by Eric Seidel.
As requested by Eric. This patch also renames the function to match its
counterpart in the JavaScriptCore bindings.
- bindings/generic/BindingSecurity.cpp:
(WebCore::canAccessDocument):
(WebCore::BindingSecurity::shouldAllowAccessToFrame):
(WebCore::BindingSecurity::shouldAllowAccessToNode):
(WebCore::BindingSecurity::allowSettingFrameSrcToJavascriptUrl):
- bindings/generic/BindingSecurity.h:
(BindingSecurity):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateReplaceableAttrSetter):
(GenerateFunctionCallback):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::canAccessFromCurrentOrigin):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
(WebCore::V8DOMWindow::eventAccessorGetter):
(WebCore::V8DOMWindow::eventAccessorSetter):
(WebCore::V8DOMWindow::openerAccessorSetter):
(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):
(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::indexedSecurityCheck):
(WebCore::V8History::namedSecurityCheck):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):
(WebCore::V8Location::toStringCallback):
(WebCore::V8Location::indexedSecurityCheck):
(WebCore::V8Location::namedSecurityCheck):
- 9:06 PM Changeset in webkit [124846] by
-
- 14 edits5 adds in trunk
WebSocket.send() should accept ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=90877
Reviewed by Kent Tamura.
Source/WebCore:
Accept ArrayBufferView as an argument of WebSocket.send() to comply with recent change
in specification: <http://html5.org/tools/web-apps-tracker?from=7084&to=7085>.
Once WebSocket.send(ArrayBuffer) was removed from the specification, but added back
in <http://html5.org/tools/web-apps-tracker?from=7202&to=7203>. Thus the functionality
of send(ArrayBuffer) is kept as-is.
Tests: http/tests/websocket/tests/hybi/send-arraybufferview.html
http/tests/websocket/tests/hybi/workers/send-arraybufferview.html
- Modules/websockets/ThreadableWebSocketChannel.h:
Change the signature of send() to receive offset and length so the clients can send
subrange of an ArrayBuffer.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
WebSocket.send(ArrayBufferView) is added, which puts the sub region of the given
ArrayBuffer into the outgoing frame queue.
- Modules/websockets/WebSocket.h:
- Modules/websockets/WebSocket.idl:
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
- Modules/websockets/WebSocketChannel.h:
(WebSocketChannel):
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
Send only necessary part of data to the main thread.
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel):
(Bridge):
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::send): Accept ArrayBufferView in send().
- bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback): Ditto.
Source/WebKit/chromium:
- src/WebSocketImpl.cpp:
(WebKit::WebSocketImpl::sendArrayBuffer):
Apply change in function signature of WebSocketChannel::send().
LayoutTests:
Two tests are added to check whether WebSocket.send(ArrayBufferView) works in the
main thread and in a worker.
- http/tests/websocket/tests/hybi/send-arraybufferview-expected.txt: Added.
- http/tests/websocket/tests/hybi/send-arraybufferview.html: Added.
- http/tests/websocket/tests/hybi/workers/resources/send-arraybufferview.js: Added.
- http/tests/websocket/tests/hybi/workers/send-arraybufferview-expected.txt: Added.
- http/tests/websocket/tests/hybi/workers/send-arraybufferview.html: Added.
- 8:59 PM Changeset in webkit [124845] by
-
- 4 edits in trunk/Source
[chromium] Add gyp variable to control which compositor target is depended on
https://bugs.webkit.org/show_bug.cgi?id=93165
Patch by James Robinson <jamesr@chromium.org> on 2012-08-06
Reviewed by Adam Barth.
This adds a use_libcc_for_compositor gyp variable to control whether webcore_platform links in the compositor
code from the webcore_chromium_compositor target or from cc from the chromium repo.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 8:59 PM Changeset in webkit [124844] by
-
- 2 edits in trunk/LayoutTests
LayoutTest: fast/forms/input-set-composition-scroll.html is failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=93320
Patch by Roger Fong <roger_fong@apple.com> on 2012-08-06
Reviewed by Tim Horton.
fast/forms/input-set-composition-scroll.html is failing after r120145
because TestInputController::setComposition() method has not been implemented.
It was added to skip list on Mac, see https://bugs.webkit.org/show_bug.cgi?id=89845 but not on Windows.
- platform/win/Skipped:
Adding test to skip list.
- 8:43 PM Changeset in webkit [124843] by
-
- 3 edits2 adds in trunk
Crash in GenericEventQueue::timerFired since the owner of GenericEventQueue is deleted during dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=92946
Reviewed by Eric Carlson.
Source/WebCore:
In GenericEventQueue::timerFired(), the owner of GenericEventQueue might be deleted.
We have to protect the owner of GenericEventQueue during dispatching events.
Test: media/event-queue-crash.html
- dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::timerFired): Added a protection.
LayoutTests:
- media/event-queue-crash-expected.txt: Added.
- media/event-queue-crash.html: Added.
- 8:40 PM Changeset in webkit [124842] by
-
- 4 edits in trunk/Source/WebCore
IndexedDB: Remove IDBRequest::finishCursor() and plumbing
https://bugs.webkit.org/show_bug.cgi?id=93274
Reviewed by Tony Chang.
Delete an unused flag and code for setting it, rendered obsolete in r123275.
No new tests - no functional changes.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::close):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
- 8:37 PM Changeset in webkit [124841] by
-
- 7 edits in trunk/Source
[chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp
https://bugs.webkit.org/show_bug.cgi?id=93319
Patch by James Robinson <jamesr@chromium.org> on 2012-08-06
Reviewed by Adrienne Walker.
Source/Platform:
Adds a few more entry points to WebLayer that are being used by GraphicsLayerChromium.
- chromium/public/WebLayer.h:
(WebLayer):
Source/WebCore:
Gets rid of all (but one) of the remaining unwrap<LayerChromium>() calls in GraphicsLayer chromium to avoid
punching through the WebLayer API. Covered by many layout tests, mostly in compositing/
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::setName):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
Source/WebKit/chromium:
- src/WebLayer.cpp:
(WebKit::WebLayer::setChildren):
(WebKit):
(WebKit::WebLayer::setReplicaLayer):
(WebKit::WebLayer::setDebugName):
(WebKit::WebLayer::clearRenderSurface):
- 8:18 PM Changeset in webkit [124840] by
-
- 2 edits in trunk/Source/Platform
[chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=93313
Reviewed by James Robinson.
Sync points already landed chromium-side, mailbos at https://chromiumcodereview.appspot.com/10829209/
- chromium/public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::insertSyncPoint):
(WebKit::WebGraphicsContext3D::waitSyncPoint):
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::genMailboxCHROMIUM):
(WebKit::WebGraphicsContext3D::produceTextureCHROMIUM):
(WebKit::WebGraphicsContext3D::consumeTextureCHROMIUM):
- 8:00 PM Changeset in webkit [124839] by
-
- 16 edits1 copy1 move1 add in trunk/Source
[chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface
https://bugs.webkit.org/show_bug.cgi?id=93308
Reviewed by James Robinson.
Source/Platform:
Convert WebScrollbarThemeGeometry to be an interface. Update
WebScrollbarLayer to take a pointer to this interface.
- chromium/public/WebScrollbarLayer.h:
(WebScrollbarLayer):
- chromium/public/WebScrollbarThemeGeometry.h:
(WebScrollbarThemeGeometry):
Source/WebCore:
Convert WebScrollbarThemeGeometry to be an interface. Create a new
WebScrollbarThemeGeometryNative implementation to wrap a native theme
pointer.
Update ScrollbarLayerChromium/CCScrollbarLayerImpl to use a pointer to
this interface rather than a concrete member variable. Because both
layer types need to access the theme during painting or compositing
and either layer could go away at any time, the theme is cloned during
commit rather than dealing with refcounting across threads or having
one layer type be the sole owner.
- WebCore.gypi:
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
- platform/chromium/support/WebScrollbarThemeGeometryNative.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarThemeGeometry.cpp.
(WebKit):
(WebKit::WebScrollbarThemeGeometryNative::create):
(WebKit::WebScrollbarThemeGeometryNative::WebScrollbarThemeGeometryNative):
(WebKit::WebScrollbarThemeGeometryNative::clone):
(WebKit::WebScrollbarThemeGeometryNative::thumbPosition):
(WebKit::WebScrollbarThemeGeometryNative::thumbLength):
(WebKit::WebScrollbarThemeGeometryNative::trackPosition):
(WebKit::WebScrollbarThemeGeometryNative::trackLength):
(WebKit::WebScrollbarThemeGeometryNative::hasButtons):
(WebKit::WebScrollbarThemeGeometryNative::hasThumb):
(WebKit::WebScrollbarThemeGeometryNative::trackRect):
(WebKit::WebScrollbarThemeGeometryNative::thumbRect):
(WebKit::WebScrollbarThemeGeometryNative::minimumThumbLength):
(WebKit::WebScrollbarThemeGeometryNative::scrollbarThickness):
(WebKit::WebScrollbarThemeGeometryNative::backButtonStartRect):
(WebKit::WebScrollbarThemeGeometryNative::backButtonEndRect):
(WebKit::WebScrollbarThemeGeometryNative::forwardButtonStartRect):
(WebKit::WebScrollbarThemeGeometryNative::forwardButtonEndRect):
(WebKit::WebScrollbarThemeGeometryNative::constrainTrackRectToTrackPieces):
(WebKit::WebScrollbarThemeGeometryNative::splitTrack):
- platform/chromium/support/WebScrollbarThemeGeometryNative.h: Added.
(WebKit):
(WebScrollbarThemeGeometryNative):
- platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::create):
(WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(WebCore::ScrollbarBackgroundPainter::create):
(WebCore::ScrollbarBackgroundPainter::ScrollbarBackgroundPainter):
(ScrollbarBackgroundPainter):
(WebCore::ScrollbarThumbPainter::create):
(WebCore::ScrollbarThumbPainter::ScrollbarThumbPainter):
(ScrollbarThumbPainter):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
(WebCore::ScrollbarLayerChromium::setTexturePriorities):
(WebCore::ScrollbarLayerChromium::update):
- platform/graphics/chromium/ScrollbarLayerChromium.h:
(ScrollbarLayerChromium):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::setScrollbarGeometry):
(WebCore::CCScrollbarLayerImpl::setScrollbarData):
(WebCore::CCScrollbarLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(WebCore::CCScrollbarLayerImpl::scrollbarGeometry):
(CCScrollbarLayerImpl):
Source/WebKit/chromium:
Now that WebScrollbarThemeGeometry can have different implementations,
create a FakeWebScrollbarThemeGeometry for testing purposes rather
than just overriding a geometry-related virtual.
- WebKit.gyp:
- WebKit.gypi:
- src/WebScrollbarLayer.cpp:
(WebKit::WebScrollbarLayer::create):
- tests/CCLayerTreeHostImplTest.cpp:
- tests/FakeWebScrollbarThemeGeometry.h: Added.
(WebKit):
(FakeWebScrollbarThemeGeometry):
(WebKit::FakeWebScrollbarThemeGeometry::create):
- tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::TEST):
- 7:49 PM Changeset in webkit [124838] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] About: shows PAGE_CACHE not enabled.
https://bugs.webkit.org/show_bug.cgi?id=93216
Reviewed by Antonio Gomes.
Page cache is a feature that can be enabled/disabled at runtime, there's no
MACRO named PAGE_CACHE to control the feature.
- WebCoreSupport/AboutDataEnableFeatures.in:
- 7:44 PM Changeset in webkit [124837] by
-
- 1 edit3 adds in trunk/LayoutTests
IndexedDB: Throw proper exceptions
https://bugs.webkit.org/show_bug.cgi?id=85513
Reviewed by Tony Chang.
Test all of the exception throwing clauses in the spec, unless they are
well covered elsewhere (indicated by a comment in the script).
- storage/indexeddb/exceptions-expected.txt: Added.
- storage/indexeddb/exceptions.html: Added.
- storage/indexeddb/resources/exceptions.js: Added.
(test.request.onsuccess.request.onsuccess.request.onsuccess):
(test.request.onsuccess.request.onsuccess):
(test.request.onsuccess):
(test):
(testDatabase.request.onsuccess.trans.oncomplete):
(testDatabase.request.onsuccess):
(testDatabase):
(prepareStoreAndIndex.request.onsuccess):
(prepareStoreAndIndex):
(testObjectStore.request.onsuccess.trans.oncomplete):
(testObjectStore.request.onsuccess):
(testObjectStore):
(testIndex):
(testCursor.makeCursor.request.onsuccess):
(testCursor.makeCursor):
(testCursor.makeKeyCursor.request.onsuccess):
(testCursor.makeKeyCursor):
(testCursor.makeReverseCursor.request.onsuccess):
(testCursor.makeReverseCursor):
(testCursor.makeInlineCursor.request.onsuccess):
(testCursor.makeInlineCursor):
(testCursor.testCursorAdvance):
(testCursor.testCursorContinue):
(testCursor.testCursorDelete):
(testCursor.testCursorUpdate):
(testCursor.makeReadOnlyCursor.request.onsuccess):
(testCursor.makeReadOnlyCursor):
(testCursor.doReadOnlyCursorTests):
(testCursor):
(testTransaction):
- 7:18 PM Changeset in webkit [124836] by
-
- 6 edits6 adds2 deletes in trunk/LayoutTests
[Chromium] Rebaseline test color-suggestion-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=92444
Unreviewed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
- platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png: Added.
- platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
- platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png: Added.
- platform/chromium/TestExpectations:
- 7:04 PM Changeset in webkit [124835] by
-
- 17 edits2 adds in trunk/Source/WebCore
JSC should use BindingState to determine the activeDOMWindow
https://bugs.webkit.org/show_bug.cgi?id=93307
Reviewed by Eric Seidel.
This patch moves activeDOMWindow from JSDOMBindings.cpp to
BindingState.cpp. This is a first step towards sharing the core
security logic in the bindings between JavaScriptCore and V8. Once the
logic is shared, we will be able to refactor the logic to avoid the
need for DOMWindow::m_securityOrigin.
This patch doesn't actually share any code (yet). It just sets the
stage by creating BindingState as a typedef of ExecState and adding the
appropriate files to the build systems.
This patch also renames activeWindow and firstWindow in the V8 bindings
to activeDOMWindow and firstDOMWindow to match the names in the
JavaScriptCore bindings.
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/BindingSecurity.cpp:
(WebCore::canAccessDocument):
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMBinding.cpp:
(WebCore):
- bindings/js/JSDOMBinding.h:
(WebCore):
- bindings/v8/BindingState.cpp:
(WebCore::activeDOMWindow):
(WebCore::firstDOMWindow):
- bindings/v8/BindingState.h:
(WebCore):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::locationAccessorSetter):
(WebCore::handlePostMessageCallback):
(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):
- bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorSetter):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::hashAccessorSetter):
(WebCore::V8Location::hostAccessorSetter):
(WebCore::V8Location::hostnameAccessorSetter):
(WebCore::V8Location::hrefAccessorSetter):
(WebCore::V8Location::pathnameAccessorSetter):
(WebCore::V8Location::portAccessorSetter):
(WebCore::V8Location::protocolAccessorSetter):
(WebCore::V8Location::searchAccessorSetter):
(WebCore::V8Location::reloadCallback):
(WebCore::V8Location::replaceCallback):
(WebCore::V8Location::assignCallback):
- 7:01 PM Changeset in webkit [124834] by
-
- 2 edits in trunk/Source/WebCore
[Chromium-Mac] Use the default locale only if the browser locale matches to it
https://bugs.webkit.org/show_bug.cgi?id=93227
Reviewed by Hajime Morita.
For a calendar picker, we have used month names and day-of-week names
obtained from the OS default locale. However, the year-month format and
[Today] [Clear] labels are decided with the browser locale. It made
calendar pickers with mixed languages.
To make calendar pickers with a single language, we use the OS default
locale only if the browser locale matches to it.
No new tests. Behavior for locale setting is not testable in WebKit.
- platform/text/mac/LocaleMac.mm:
(WebCore::languageFromLocale):
A helper for determineLocale. This returns the language part of the
specified locale identifier.
(WebCore::determineLocale):
If the browser language matches to the language of the current NSLocale,
returns the current NSLocale. Otherwise, returns a NSLocale with the
browser language.
Note that [NSLolca localeIdentifier] returns a string in
<language>_<country> format though defaultLanguage() in Chromium returns
a string in <language>-<country> format.
(WebCore::LocaleMac::currentLocale):
Use determineLocale.
- 6:57 PM Changeset in webkit [124833] by
-
- 3 edits2 adds in trunk
Handle variables in CSSParser::parseValidPrimitive(), preventing null return value.
https://bugs.webkit.org/show_bug.cgi?id=93235
Reviewed by Tony Chang.
Source/WebCore:
By returning null here (and failing to handle the variable) the current code would cause null pointer dereferences in StyleResolver at several points.
Instead we create a primitive value for the variable reference and return it.
Test: fast/css/variables/invalid-font-reference.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValidPrimitive):
LayoutTests:
Exercises the code path where variables are parsed in CSSParser::parseValidPrimitive().
- fast/css/variables/invalid-font-reference-expected.txt: Added.
- fast/css/variables/invalid-font-reference.html: Added.
- 6:52 PM WebKitGTK edited by
- (diff)
- 6:50 PM LayoutUnit edited by
- (diff)
- 6:49 PM LayoutTestDashboards edited by
- (diff)
- 6:46 PM Changeset in webkit [124832] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Update chromium DEPS r150037 -> r150169
https://bugs.webkit.org/show_bug.cgi?id=93309
As the title says. Unreviewed.
Patch by James Robinson <jamesr@chromium.org> on 2012-08-06
- DEPS:
- 6:45 PM Changeset in webkit [124831] by
-
- 2 edits in trunk/LayoutTests
LayoutTest: fast/forms/validation-message-user-modify.html fails.
https://bugs.webkit.org/show_bug.cgi?id=93207
Patch by Roger Fong <roger_fong@apple.com> on 2012-08-06
Reviewed by Tim Horton.
This test uses the "required" form element property which currently does not work on Safari,
see <rdar://problem/119655018>.
This test should not be run.
- platform/win/Skipped:
Adding test to skip list.
- 6:41 PM Changeset in webkit [124830] by
-
- 32 edits2 moves in trunk/Source
[Chromium] Rename CCTextureUpdater to CCTextureUpdateQueue.
https://bugs.webkit.org/show_bug.cgi?id=93293
Patch by David Reveman <reveman@chromium.org> on 2012-08-06
Reviewed by Adrienne Walker.
Source/WebCore:
No new tests.
- WebCore.gypi:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::update):
- platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
- platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp:
(WebCore::HeadsUpDisplayLayerChromium::update):
- platform/graphics/chromium/HeadsUpDisplayLayerChromium.h:
(HeadsUpDisplayLayerChromium):
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::update):
- platform/graphics/chromium/ImageLayerChromium.h:
(ImageLayerChromium):
- platform/graphics/chromium/LayerChromium.h:
(WebCore):
(WebCore::LayerChromium::update):
- platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::updatePart):
(WebCore::ScrollbarLayerChromium::update):
- platform/graphics/chromium/ScrollbarLayerChromium.h:
(WebCore):
(ScrollbarLayerChromium):
- platform/graphics/chromium/TextureLayerChromium.cpp:
(WebCore::TextureLayerChromium::update):
- platform/graphics/chromium/TextureLayerChromium.h:
(TextureLayerChromiumClient):
(TextureLayerChromium):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::updateContentRect):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitAndComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCTextureUpdateController.cpp:
(WebCore::CCTextureUpdateController::updateTextures):
(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::hasMoreUpdates):
(WebCore::CCTextureUpdateController::updateMoreTextures):
- platform/graphics/chromium/cc/CCTextureUpdateController.h:
(WebCore::CCTextureUpdateController::create):
(CCTextureUpdateController):
- platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.cpp.
(WebCore):
(WebCore::CCTextureUpdateQueue::CCTextureUpdateQueue):
(WebCore::CCTextureUpdateQueue::~CCTextureUpdateQueue):
(WebCore::CCTextureUpdateQueue::appendFullUpload):
(WebCore::CCTextureUpdateQueue::appendPartialUpload):
(WebCore::CCTextureUpdateQueue::appendCopy):
(WebCore::CCTextureUpdateQueue::takeFirstFullUpload):
(WebCore::CCTextureUpdateQueue::takeFirstPartialUpload):
(WebCore::CCTextureUpdateQueue::takeFirstCopy):
(WebCore::CCTextureUpdateQueue::hasMoreUpdates):
- platform/graphics/chromium/cc/CCTextureUpdateQueue.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.
(WebCore):
(CCTextureUpdateQueue):
(WebCore::CCTextureUpdateQueue::fullUploadSize):
(WebCore::CCTextureUpdateQueue::partialUploadSize):
(WebCore::CCTextureUpdateQueue::copySize):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(WebCore):
(CCThreadProxy):
Source/WebKit/chromium:
- src/WebExternalTextureLayer.cpp:
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
- tests/CCTextureUpdateControllerTest.cpp:
- tests/CCThreadedTest.cpp:
- tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeTiledLayerChromium::update):
- tests/CCTiledLayerTestCommon.h:
(FakeTiledLayerChromium):
- tests/Canvas2DLayerBridgeTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
- 6:34 PM Changeset in webkit [124829] by
-
- 2 edits in trunk/Source/WebCore
Clear out the TileCache backpointer for all tile layers when the tile cache is destroyed
https://bugs.webkit.org/show_bug.cgi?id=93317
<rdar://problem/11566543>
Reviewed by Dean Jackson.
It seems that in some rare cases, the tile cache layer can be destroyed in the same transaction as tile layers
are being asked to paint. Make sure to null out the TileCache back pointer for all layers in the TileCache destructor.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::~TileCache):
- 6:19 PM Changeset in webkit [124828] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebCore
Merged r121803. <rdar://problem/11968346>
- 6:14 PM Changeset in webkit [124827] by
-
- 3 edits2 copies in branches/safari-536.26-branch
Merged r120845. <rdar://problem/12035599>
- 6:07 PM Changeset in webkit [124826] by
-
- 2 edits in trunk
[GTK] Cleanup configure.ac build options output
https://bugs.webkit.org/show_bug.cgi?id=93245
Patch by Xan Lopez <xlopez@igalia.com> on 2012-08-06
Reviewed by Laszlo Gombos.
Remove duplicated elements, sort alphabetically.
- configure.ac: ditto.
- 5:50 PM Changeset in webkit [124825] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r124816.
http://trac.webkit.org/changeset/124816
https://bugs.webkit.org/show_bug.cgi?id=93311
made some tests crash (Requested by noamr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06
Source/WebCore:
- platform/graphics/GraphicsLayerAnimation.cpp:
(WebCore::GraphicsLayerAnimation::GraphicsLayerAnimation):
(WebCore::GraphicsLayerAnimations::hasActiveAnimationsOfType):
(WebCore::GraphicsLayerAnimations::hasRunningAnimations):
(WebCore::GraphicsLayerAnimations::add):
(WebCore::GraphicsLayerAnimations::pause):
(WebCore::GraphicsLayerAnimations::apply):
- platform/graphics/GraphicsLayerAnimation.h:
(GraphicsLayerAnimation):
(GraphicsLayerAnimations):
(WebCore::GraphicsLayerAnimations::remove):
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::addAnimation):
- 5:47 PM Changeset in webkit [124824] by
-
- 3 edits in trunk/Source/WebKit/chromium
[CSS Exclusions] Add a command-line flag to enable / disable exclusions
https://bugs.webkit.org/show_bug.cgi?id=91420
Patch by Bear Travis <betravis@adobe.com> on 2012-08-06
Reviewed by Dimitri Glazkov.
Adding the interface code to expose the css exclusions runtime flag to
Chromium.
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures): Adding getters/setters for cssExclusions
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableCSSExclusions):
(WebKit):
(WebKit::WebRuntimeFeatures::isCSSExclusionsEnabled):
- 5:29 PM Changeset in webkit [124823] by
-
- 6 edits in trunk/Source
[WIN] Remove dependency on pthread from MachineStackMarker
https://bugs.webkit.org/show_bug.cgi?id=68429
Reviewed by Geoffrey Garen.
Windows has no support for calling a destructor for thread specific data.
Since we need more control over creating and deleting thread specific keys
we can not simply extend WTF::ThreadSpecific with this functionality.
All thread specific keys created via the new API get stored in a list.
After a thread function finished we iterate over this list and call
the registered destructor for every item if needed.
Source/JavaScriptCore:
- heap/MachineStackMarker.cpp: Use the new functions instead of pthread directly.
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::makeUsableFromMultipleThreads):
(JSC::MachineThreads::addCurrentThread):
- heap/MachineStackMarker.h:
(MachineThreads):
Source/WTF:
- wtf/ThreadSpecific.h:
(WTF):
(WTF::threadSpecificKeyCreate): Added wrapper around pthread_key_create.
(WTF::threadSpecificKeyDelete): Added wrapper around pthread_key_delete.
(WTF::threadSpecificSet): Added wrapper around pthread_setspecific.
(WTF::threadSpecificGet): Added wrapper around pthread_getspecific.
- wtf/ThreadSpecificWin.cpp:
- 5:17 PM Changeset in webkit [124822] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebCore
Rollout r116203. <rdar://problem/11932288>
- 5:14 PM Changeset in webkit [124821] by
-
- 2 edits in branches/safari-536.26-branch/Source/JavaScriptCore
Merge <rdar://problem/11781190>
- 5:00 PM Changeset in webkit [124820] by
-
- 28 edits2 adds2 deletes in trunk
[CSS Shaders] Parse mix function
https://bugs.webkit.org/show_bug.cgi?id=90101
Patch by Max Vujovic <mvujovic@adobe.com> on 2012-08-06
Reviewed by Dirk Schulze.
Source/WebCore:
Parse the mix function syntax for CSS Shaders as defined in the Filter Effects spec:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#FilterFunction
The fragment shader argument of the custom filter function can now be a mix function with
the following syntax:
mix(<uri> [ <blend-mode> <alpha-compositing> ]?) For example:
-webkit-filter: custom(url(shader.vert) mix(url(shader.frag multiply source-over))
The Filter Effects spec references the Compositing and Blending spec, which defines the
supported blend modes and alpha compositing modes.
Blend modes:
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blend-mode
This patch adds all of the blend modes in the spec.
Alpha compositing modes:
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#alpha-compositing
This patch does not add any new CSS values for alpha compositing. Currently, we parse the
values that are the same between the spec and the -webkit-background-composite property,
including:
clear
copy
source-over
source-in
source-out
source-atop
destination-over
destination-in
destination-out
destination-atop
xor
In the future, we may need to add the following CSS values for alpha compositing:
lighter
destination
This is currently under discussion on the www-style mailing list:
http://lists.w3.org/Archives/Public/www-style/2012Aug/0123.html
No new test files. Add test cases in:
css3/filters/script-tests/custom-filter-property-computed-style.js:
css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
css3/filters/script-tests/custom-filter-property-parsing.js:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
- css/CSSParser.cpp:
(WebCore::CSSParser::isBlendMode):
(WebCore):
(WebCore::CSSParser::isCompositeOperator):
(WebCore::CSSParser::parseMixFunction):
(WebCore::CSSParser::parseCustomFilter):
- css/CSSParser.h:
(WebCore):
- css/CSSParserValues.h:
(WebCore::CSSParserValueList::currentIndex):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator BlendMode):
- css/CSSValue.cpp:
(WebCore::CSSValue::reportMemoryUsage):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
- css/CSSValue.h:
(WebCore::CSSValue::isWebKitCSSMixFunctionValue):
(CSSValue):
- css/CSSValueKeywords.in:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/WebKitCSSMixFunctionValue.cpp: Added.
(WebCore):
(WebCore::WebKitCSSMixFunctionValue::WebKitCSSMixFunctionValue):
(WebCore::WebKitCSSMixFunctionValue::customCssText):
(WebCore::WebKitCSSMixFunctionValue::cloneForCSSOM):
(WebCore::WebKitCSSMixFunctionValue::reportDescendantMemoryUsage):
- css/WebKitCSSMixFunctionValue.h: Added.
(WebCore):
(WebKitCSSMixFunctionValue):
(WebCore::WebKitCSSMixFunctionValue::create):
- platform/graphics/GraphicsTypes.h:
- platform/graphics/filters/CustomFilterProgram.cpp:
(WebCore::CustomFilterProgram::CustomFilterProgram):
- platform/graphics/filters/CustomFilterProgram.h:
(WebCore::CustomFilterProgramMixSettings::CustomFilterProgramMixSettings):
(CustomFilterProgramMixSettings):
(WebCore):
- rendering/style/StyleCustomFilterProgram.h:
(WebCore::StyleCustomFilterProgram::create):
(WebCore::StyleCustomFilterProgram::StyleCustomFilterProgram):
LayoutTests:
Add tests for custom filter mix function parsing as defined in the Filter Effects spec:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#FilterFunction
Remove some mac-wk2 and chromium expectations because they are the same as the general
expectations.
- css3/filters/custom/custom-filter-property-computed-style-expected.txt:
- css3/filters/custom/custom-filter-property-parsing-expected.txt:
- css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
- css3/filters/script-tests/custom-filter-property-computed-style.js:
- css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
- css3/filters/script-tests/custom-filter-property-parsing.js:
- platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
- platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:
- platform/chromium/css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt: Removed.
- platform/mac-wk2/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Removed.
- 4:58 PM Changeset in webkit [124819] by
-
- 4 edits in branches/safari-536.26-branch/Source/WebCore
Merged r123780. <rdar://problem/11979232>
- 4:54 PM Rebaseline edited by
- (diff)
- 4:51 PM Changeset in webkit [124818] by
-
- 18 edits4 copies in branches/safari-536.26-branch/Source
Merged r123778. <rdar://problem/11979232>
- 4:46 PM Changeset in webkit [124817] by
-
- 5 edits in trunk/Source/JavaScriptCore
Unify JSC date and time formating functions
https://bugs.webkit.org/show_bug.cgi?id=92282
Reviewed by Geoffrey Garen.
Replace the existing functions for formating GregorianDateTime
with one single function. This removes some code duplications
in DatePrototype and is a preperation to fix encoding issues,
since we can add UChar* values to the resulting string now.
- runtime/DateConstructor.cpp:
(JSC::callDate):
- runtime/DateConversion.cpp:
(JSC::formatDateTime):
- runtime/DateConversion.h:
(JSC):
- runtime/DatePrototype.cpp:
(JSC::formateDateInstance):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToGMTString):
- 4:43 PM Changeset in webkit [124816] by
-
- 6 edits in trunk/Source
GraphicsLayerAnimation shouldn't use HashMap<String>
https://bugs.webkit.org/show_bug.cgi?id=93284
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Use a vector containing all the animations instead of a map of String to Vector.
The HashMap contains very few elements, which makes it inefficient relatively to a vector.
This has been shown to be a bottleneck in valgrind.
Covered by existing animation tests.
- platform/graphics/GraphicsLayerAnimation.cpp:
(WebCore::GraphicsLayerAnimation::GraphicsLayerAnimation):
(WebCore::GraphicsLayerAnimations::hasActiveAnimationsOfType):
(WebCore::GraphicsLayerAnimations::hasRunningAnimations):
(WebCore::GraphicsLayerAnimations::add):
(WebCore::GraphicsLayerAnimations::pause):
(WebCore::GraphicsLayerAnimations::remove):
(WebCore::GraphicsLayerAnimations::apply):
- platform/graphics/GraphicsLayerAnimation.h:
(GraphicsLayerAnimation):
(WebCore::GraphicsLayerAnimation::name):
(GraphicsLayerAnimations):
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):
Source/WebKit2:
Apply the changes to GraphicsLayerAnimation API.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::addAnimation):
- 4:42 PM Changeset in webkit [124815] by
-
- 32 edits1 copy7 adds in trunk
Out-of-process plug-ins should support asynchronous initialization
<rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919
Reviewed by Anders Carlsson.
Source/WebKit2:
If a plug-in has been deemed capable of asynchronous initialization when run out of process...
...then do that!
Add flags to communicate that this plugin create is meant to create a plug-in already requested asynchronously and
to include whether or not the initialize call should include an artificial delay (for testing):
- PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::PluginCreationParameters):
(WebKit::PluginCreationParameters::encode):
(WebKit::PluginCreationParameters::decode):
- PluginProcess/PluginCreationParameters.h:
(PluginCreationParameters):
Add a flag for the UI Process to tell the PluginProcess that it supports asynchronous initialization:
- Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::PluginProcessCreationParameters):
(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):
- Shared/Plugins/PluginProcessCreationParameters.h:
(PluginProcessCreationParameters):
Allow the UI Process to pass along whether the plug-on supports asynchronous initialization:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
- UIProcess/Plugins/PluginProcessProxy.h:
(PluginProcessProxy):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
- UIProcess/WebProcessProxy.messages.in:
Allow the Plugin Process to pass whether or not it supports asynchronous initialization, originally determined
in the UI Process, along to the WebProcess:
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::PluginProcess):
(WebKit::PluginProcess::initializePluginProcess):
(WebKit::PluginProcess::createWebProcessConnection):
- PluginProcess/PluginProcess.h:
(PluginProcess):
- UIProcess/Plugins/PluginProcessProxy.messages.in:
Add a flag so PluginProcessConnections remember whether or not they support asynchronous initialization:
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::PluginProcessConnection):
(WebKit::PluginProcessConnection::setSupportsAsynchronousPluginInitialization):
(WebKit):
- WebProcess/Plugins/PluginProcessConnection.h:
(WebKit::PluginProcessConnection::create):
(WebKit::PluginProcessConnection::supportsAsynchronousPluginInitialization):
(PluginProcessConnection):
Create PluginProcessConnections with the flag passed down from the PluginProcess about whether or not they
support asynchronous initialization:
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Responding to messages from the WebProcess, most of the heavy decision making in asynchronous initialization is here:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::asynchronousInstanceIDsToIgnore): A set of instance IDs to *not* create asynchronously later because we know
we no longer need to.
(WebKit):
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::destroyPlugin): If the plug-in doesn't exist but is awaiting asynchronous creation, flag
this instance ID in the "asynchronous ignore set".
(WebKit::WebProcessConnection::createPluginInternal): Renamed from createPlugin, actually does the plug-in creation.
(WebKit::WebProcessConnection::createPlugin): Adds the instance ID to the "asynchronous ignore set" then calls createPluginInternal.
(WebKit::WebProcessConnection::createPluginAsynchronously): If the instance ID is in the "asynchronous ignore set", remove it from the
set and do nothing else. Otherwise, perform the initialization and then send the asynchronous result back to the WebProcess.
- PluginProcess/WebProcessConnection.h:
(WebProcessConnection):
- PluginProcess/WebProcessConnection.messages.in:
Add helpers for asynchronous initialization that all plug-in types must implement:
- WebProcess/Plugins/Plugin.h:
(Plugin):
Add helpers for asynchronous initialization that plug-in controllers can override:
- WebProcess/Plugins/PluginController.h:
(PluginController):
(WebKit::PluginController::asynchronousPluginInitializationEnabled):
(WebKit::PluginController::asynchronousPluginInitializationEnabledForAllPlugins):
(WebKit::PluginController::artificialPluginInitializationDelayEnabled):
Give PluginProxys the ability to initialize either asynchronously or synchronously, and also the ability to synchronously
wait for previously asynchronous initialization (in case their PluginScriptObject is required):
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::PluginProxy):
(WebKit::PluginProxy::initialize): Store the plugin creation parameters as a member, and decide whether to try synchronous
or asynchronous initialization.
(WebKit):
(WebKit::PluginProxy::canInitializeAsynchronously): Answer based on preferences and what the PluginProcessConnection says
that it supports.
(WebKit::PluginProxy::waitForAsynchronousInitialization): Synchronously wait on initialization when asynchronous initialization
was previously requested.
(WebKit::PluginProxy::initializeSynchronously):
(WebKit::PluginProxy::didCreatePlugin): Double-check that we're still expecting asynchronous initialization, then call
through to didCreatePluginInternal.
(WebKit::PluginProxy::didCreatePluginInternal): Handle completion of initialization (both synchronously and asynchronously)
(WebKit::PluginProxy::didFailToCreatePlugin): Double-check that we're still expecting asynchronous initialization, then call
through to didFailToCreatePluginInternal.
(WebKit::PluginProxy::didFailToCreatePluginInternal): Handle failure to initialize (both synchronously and asynchronously)
(WebKit::PluginProxy::destroy):
- WebProcess/Plugins/PluginProxy.h:
(WebKit):
(WebKit::PluginProxy::isInitializingAsynchronously):
(PluginProxy):
- WebProcess/Plugins/PluginProxy.messages.in:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
(WebKit::PluginView::~PluginView): Always destroy the plug-in even if it hasn't been initialized yet, as it might be initializing
right now.
(WebKit::PluginView::initializePlugin): Don't handle the result of initialization immediately. Break that out in to two
methods that will be called later.
(WebKit):
(WebKit::PluginView::didFailToInitializePlugin):
(WebKit::PluginView::didInitializePlugin):
(WebKit::PluginView::scriptObject): If we truly need the script object, then wait for a synchronous initialization of the plug-in.
(WebKit::PluginView::asynchronousPluginInitializationEnabled):
(WebKit::PluginView::asynchronousPluginInitializationEnabledForAllPlugins):
(WebKit::PluginView::artificialPluginInitializationDelayEnabled):
- WebProcess/Plugins/PluginView.h:
(PluginView):
These methods shouldn't be called in the PluginProcess, only in the WebProcess:
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::didInitializePlugin):
(WebKit):
(WebKit::PluginControllerProxy::didFailToInitializePlugin):
- PluginProcess/PluginControllerProxy.h:
(PluginControllerProxy):
NetscapePlugin is for in-process plug-ins:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
(NetscapePlugin):
(WebKit::NetscapePlugin::waitForAsynchronousInitialization):
(WebKit::NetscapePlugin::isInitializingAsynchronously):
Built-in PDFView is currently only in-process:
- WebProcess/Plugins/PDF/BuiltInPDFView.h:
(BuiltInPDFView):
(WebKit::BuiltInPDFView::waitForAsynchronousInitialization):
(WebKit::BuiltInPDFView::isInitializingAsynchronously):
Tools:
Add a plug-in with an NPP_New that takes 550ms (a reasonable trade-off between a solid test and a slow running test)
for testing asynchronous plug-in initialization.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp: Copied from Source/WebKit2/Shared/Plugins/PluginProcessCreationParameters.h.
(SlowNPPNew):
(SlowNPPNew::SlowNPPNew):
(SlowNPPNew::NPP_New):
LayoutTests:
Add tests to make sure a plug-in with a long running NPP_New does not block the web thread.
- platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization-expected.txt: Added.
- platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization-multiple-expected.txt: Added.
- platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization-multiple.html: Added.
- platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization.html: Added.
- platform/mac-wk2/plugins/slow/resources/asynchronous-plugin-initialization-multiple-finish.html: Added.
- 4:35 PM Changeset in webkit [124814] by
-
- 13 edits in branches/safari-536.26-branch/Source
Merged r123775. <rdar://problem/11979232>
- 4:33 PM Changeset in webkit [124813] by
-
- 5 edits1 move in trunk/Source
[Chromium] WebTouchCandidatesInfo should be part of the Client API
https://bugs.webkit.org/show_bug.cgi?id=93088
Reviewed by Eric Seidel.
Source/Platform:
All the input related interfaces are part of the client (rather than
the platform) part of the API. This patch moves WebTouchCandidatesInfo
to the client part of the API.
- Platform.gypi:
- chromium/public/WebTouchCandidatesInfo.h: Removed.
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebTouchCandidatesInfo.h: Copied from Source/Platform/chromium/public/WebTouchCandidatesInfo.h.
- src/WebViewImpl.cpp:
- 4:29 PM Changeset in webkit [124812] by
-
- 11 edits in branches/safari-536.26-branch/Source/WebCore
Merged r123747. <rdar://problem/11979232>
- 4:23 PM Changeset in webkit [124811] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=93199
REGRESSION (r124489): Crash in FrameView::scrollContentsFastPath when
scrolling Facebook and Google image search
-and corresponding-
<rdar://problem/12035066>
Reviewed by Anders Carlsson.
As the comment in setShouldUpdateScrollLayerPositionOnMainThread()
indicates, the goal of adding a call to
updateMainFrameScrollPositionAndScrollLayerPosition() within that
function was just to make sure the layer position was up-to-date
since that is what is not kept up to date when scrolling is happening
on the scrolling thread. So I'm fixing this crash by having that code
ONLY update the layer position instead of also updating the scroll
position, since it was updating the scroll position that led to this
crash.
New function updateMainFrameScrollLayerPosition() will update JUST
the layer position.
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollLayerPosition):
Update just the layer position here instead of the layer position and
the scroll position.
(WebCore)::
- 4:22 PM Changeset in webkit [124810] by
-
- 2 edits in trunk/Tools
[Chromium-Android] Virtual test suites fail
https://bugs.webkit.org/show_bug.cgi?id=92515
Reviewed by Dirk Pranke.
The failure is because our bypassing of DriverProxy.
Repeat the logic of virtual tests in DriverProxy in ChromiumAndroidDriver
and restart DRT when the command line changes.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver.cmd_line): Added comments about why we override this and have _drt_cmd_line().
(ChromiumAndroidDriver.run_test): Repeat the logic of virtual tests in DriverProxy.
(ChromiumAndroidDriver.start): Restart DRT when the command line changes.
(ChromiumAndroidDriver._start_once):
- 4:19 PM Changeset in webkit [124809] by
-
- 6 edits in trunk/Tools
Remove NRWT --shard-ref-tests
https://bugs.webkit.org/show_bug.cgi?id=91539
This is basically a revert of "[Chromium-Android] Run ref tests together to avoid expensive driver restarts"
(https://bugs.webkit.org/show_bug.cgi?id=91533, http://trac.webkit.org/changeset/122914),
with some conflicts resolved (because of refactory of Manager/LayoutTestRunner/Sharder classes).
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.run_tests):
(Sharder.shard_tests):
(Sharder._shard_in_two):
(Sharder._shard_by_directory):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(SharderTests):
(SharderTests.get_test_input):
(SharderTests.get_shards):
(SharderTests.test_shard_by_dir):
(SharderTests.test_shard_in_two):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._test_input_for_file):
(Manager._test_is_slow):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.init):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 4:05 PM Changeset in webkit [124808] by
-
- 5 edits in trunk
[Qt] Default sizes for input-text and text-area are different when running DRT/WTR
https://bugs.webkit.org/show_bug.cgi?id=91990
Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-08-06
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
WTR wasn't using the proper font types provided by testfonts directory.
The same approach as DRT was applied and now it takes info from QFont to
update the store variable.
- UIProcess/qt/WebPreferencesQt.cpp:
(WebKit::setStringValueIfInUserDefaults):
(WebKit):
(WebKit::WebPreferences::platformInitializeStore):
Tools:
Initializing TestFonts information into WTR binary. Doing it
later leads to wrong font names usage (Dejavu Serif instead
of Liberation Serif).
- WebKitTestRunner/Target.pri:
- WebKitTestRunner/qt/main.cpp:
(main):
- 4:03 PM Changeset in webkit [124807] by
-
- 2 edits in trunk/Tools
Add twiz@{chromium|google}.org to the set of non-committer contributors.
https://bugs.webkit.org/show_bug.cgi?id=93288
Patch by Jeff Timanus <twiz@chromium.org> on 2012-08-06
Reviewed by Adam Barth.
- Scripts/webkitpy/common/config/committers.py:
- 4:01 PM Changeset in webkit [124806] by
-
- 3 edits in trunk/LayoutTests
Testcase LayoutTests/editing/input/editable-container-with-word-wrap-normal.html failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=93287
Patch by Pravin D <pravind.2k4@gmai.com> on 2012-08-06
Reviewed by Ryosuke Niwa.
The testcase uses 'End' keypress event emulation to scroll the caret to the end of the line. As the behavior of 'End' keypress
is platform dependent, replacing it platform independent code.
- editing/input/editable-container-with-word-wrap-normal-expected.txt:
- editing/input/editable-container-with-word-wrap-normal.html: Replaced 'End' keypress event with testRunner's execCommand() to make testcase behavior independent of platform.
- 4:01 PM Changeset in webkit [124805] by
-
- 10 edits in trunk/Source/WebKit2
[Qt] Use GraphicsLayerAnimation in LayerTreeCoordinator
https://bugs.webkit.org/show_bug.cgi?id=93147
Reviewed by Kenneth Rohde Christiansen
Allow controlling animations outside of WebCore. This is an intermediate step before moving
to threaded animations.
CoordinatedGraphicsLayer maintains the GraphicsLayerAnimation structures, and applies the
animation interpolation at the right time, before syncing the rest of the layer info and
the visible contents rect.
This also allows sending shorter IPC messages for animated opacity/transform changes,
without the rest of the layer info.
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::setLayerAnimatedOpacity):
(WebKit):
(WebKit::LayerTreeCoordinatorProxy::setLayerAnimatedTransform):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::setAnimatedOpacity):
(WebKit):
(WebKit::LayerTreeRenderer::setAnimatedTransform):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::didChangeAnimatedProperties):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::syncAnimatedProperties):
(WebCore::CoordinatedGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
account for the animated transform in the visible rect.
(WebCore::CoordinatedGraphicsLayer::addAnimation):
(WebCore::CoordinatedGraphicsLayer::pauseAnimation):
(WebCore::CoordinatedGraphicsLayer::removeAnimation):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
(WebCore::CoordinatedGraphicsLayer::setAnimatedTransform):
(WebCore::CoordinatedGraphicsLayer::setAnimatedOpacity):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit):
(WebKit::LayerTreeCoordinator::setLayerAnimatedOpacity):
(WebKit::LayerTreeCoordinator::setLayerAnimatedTransform):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- 3:30 PM Changeset in webkit [124804] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] REGRESSION(r124714): webkit_unit_tests asserts in Debug
https://bugs.webkit.org/show_bug.cgi?id=93297
Patch by Adrienne Walker <enne@google.com> on 2012-08-06
Reviewed by James Robinson.
This is a quick fix to get debug unit tests working again by
implementing a virtual function that has ASSERT_NOT_REACHED in the
base class version.
- tests/ScrollAnimatorNoneTest.cpp:
(MockScrollableArea::scrollPosition):
- 3:24 PM Changeset in webkit [124803] by
-
- 3 edits in trunk/Tools
REGRESSION(124789): EWS errors out because --print option is missing
https://bugs.webkit.org/show_bug.cgi?id=93299
Unreviewed.
The --print option doesn't exist anymore. Let's try --quiet instead.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
- 2:59 PM Changeset in webkit [124802] by
-
- 5 edits in trunk
run-webkit-tests should have ability to add description to its JSON output
https://bugs.webkit.org/show_bug.cgi?id=93296
Reviewed by Dirk Pranke.
PerformanceTests:
Parse description and show it with the WebKit revision on the results page. Also use bar graphs
instead of line graphs since we're not depicting the time series here per arv's suggestion.
Finally, add the ability to adjust y-axis between the adjusted value and 0 (plot even doesn't adjust
y-axis automatically now) by a mouse click.
- resources/results-template.html:
Tools:
Add --description option.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._generate_and_show_results):
(PerfTestsRunner._generate_results_dict):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_with_description):
- 2:00 PM Changeset in webkit [124801] by
-
- 14 edits in trunk/Tools
nrwt: handle errors from image diff better
https://bugs.webkit.org/show_bug.cgi?id=92934
Reviewed by Ojan Vafai.
Currently if ImageDiff crashes, returns a weird exit code, or
produces any stderr output, it's basically swallowed. This
change ensures that we log errors to stderr, and also appends
the error to the stderr for the test (so it'll show up in
results.html).
Most importantly, it'll cause diff_image() to fail and we'll
report ImageHashMismatch ... this may be kinda untrue, but I
think it's better than ignoring the error.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):
(SingleTestRunner._compare_output_with_reference):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
(TestResultWriterTest):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.diff_image):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.diff_image):
- Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_diff_image_crashed):
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
- Scripts/webkitpy/layout_tests/port/image_diff.py:
(ImageDiffer.diff_image):
(ImageDiffer._read):
- Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
(TestImageDiffer.test_diff_image):
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.test_diff_image_crashed):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_diff_image):
(PortTestCase):
(PortTestCase.test_diff_image_crashed):
(PortTestCase.test_diff_image_crashed.make_proc):
- Scripts/webkitpy/layout_tests/port/server_process_mock.py:
(MockServerProcess.init):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.diff_image):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_tolerance.ImageDiffTestPort.diff_image):
- 1:46 PM Changeset in webkit [124800] by
-
- 6 edits in trunk/Tools
nrwt: clean up printing.py
https://bugs.webkit.org/show_bug.cgi?id=93026
Reviewed by Dirk Pranke.
This patch cleans up the implementation of printing.py now
that we're not using all the original complexity.
There should be no changes in functionality and everything
should be covered by the existing tests.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.run_tests):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.init):
(Printer.del):
(Printer.print_config):
(Printer.print_found):
(Printer.print_expected):
(Printer.print_workers_and_shards):
(Printer):
(Printer._print_expected_results_of_type):
(Printer.print_results):
(Printer._print_timing_statistics):
(Printer._print_aggregate_test_statistics):
(Printer._print_individual_test_times):
(Printer._print_test_list_timing):
(Printer._print_directory_timings):
(Printer._print_statistics_for_test_timings):
(Printer._print_result_summary):
(Printer._print_result_summary_entry):
(Printer._print_one_line_summary):
(Printer.print_finished_test):
(Printer._print_test_result):
(Printer._print_test_trace):
(Printer._print_baseline):
(Printer._print_unexpected_test_result):
(Printer._print_progress):
(Printer._print_unexpected_results):
(Printer._print_unexpected_results.add_result):
(Printer._print_quiet):
(Printer._print_default):
(Printer._print_debug):
(Printer._print_for_bot):
(Printer.write_update):
(Printer.writeln):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_printer):
(Testprinter.test_print_config):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_unexpected_results):
(test_details):
- 1:42 PM Changeset in webkit [124799] by
-
- 9 edits in trunk
If the Apple Java plug-in is blocked and no runtime is installed, don't load it
https://bugs.webkit.org/show_bug.cgi?id=93289
<rdar://problem/11730092>
Reviewed by Dan Bernstein.
Source/WebKit2:
If the Apple Java plug-in is blocked, but there's no Java runtime installed (or the Java plug-in is disabled),
don't even include it in the plug-in info store.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::shouldBlockPlugin):
Since this is static now, it shouldn't be const.
- UIProcess/Plugins/PluginInfoStore.h:
(PluginInfoStore):
shouldBlockPlugin can be static.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
Return false if the Apple Java plug-in is blocked but Java isn't installed or enabled.
(WebKit::PluginInfoStore::shouldBlockPlugin):
Since this is static now, it shouldn't be const.
WebKitLibraries:
Add WKJLIsRuntimeAndWebComponentsInstalled().
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 1:41 PM Changeset in webkit [124798] by
-
- 3 edits in trunk/Source/WebCore
MediaSource should use it's own list of source URLs
https://bugs.webkit.org/show_bug.cgi?id=93285
Reviewed by Eric Carlson.
r124780 added MediaSource objects to PublicURLManager's streamURLs list,
piggy-backing on MEDIA_STREAM. This patch creates a sourceURLs list so
that MediaSource can stand on its own.
Test: builds on Andriod even when MEDIA_STREAM is disabled.
- html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
- html/PublicURLManager.h:
(WebCore::PublicURLManager::contextDestroyed):
(PublicURLManager):
(WebCore::PublicURLManager::sourceURLs):
- 1:31 PM Changeset in webkit [124797] by
-
- 2 edits in trunk/Source/WebCore
[chromium/mac] Unbreak debug builds with the 10.7 SDK
https://bugs.webkit.org/show_bug.cgi?id=93202
Reviewed by James Robinson.
FMGetATSFontRefFromFont() is not available with the 10.7 SDK
when targetting 10.6. Don't delete this code completely yet,
it's still used with the 10.6 SDK when targetting 10.6 (which
chromium's build bots use).
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore):
- 1:31 PM Changeset in webkit [124796] by
-
- 25 edits in branches/safari-536.26-branch/Source
Merged r122676. <rdar://problem/11932587>
- 1:22 PM Changeset in webkit [124795] by
-
- 2 edits in trunk/Tools
change bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=93043
Reviewed by Ryosuke Niwa.
in preparation for the cleanup of the logging flags in new-run-webkit-tests.
- Scripts/run-webkit-tests:
- 12:56 PM Changeset in webkit [124794] by
-
- 1 edit2 adds in trunk/LayoutTests
Layout Test: Windows specific tests needed for fast/css/getComputedStyle/computed-style.html & computed-style-without-renderer.html
https://bugs.webkit.org/show_bug.cgi?id=93033
Patch by Roger Fong <roger_fong@apple.com> on 2012-08-06
Reviewed by Tim Horton.
Windows specific computed-style and computed-style-without-renderer tests are needed since CSS3 Flexbox is disabled on windows,
see https://bugs.webkit.org/show_bug.cgi?id=92047, new CSS3 Flexbox properties no longer used.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Added.
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
- 12:17 PM Changeset in webkit [124793] by
-
- 4 edits2 adds in trunk
need tests to ensure flexboxes play nicely with box-sizing
https://bugs.webkit.org/show_bug.cgi?id=70771
Reviewed by Tony Chang.
Source/WebCore:
Anytime we grab the width/height off of the RenderStyle, we need to adjust
it for box-sizing. Fortunately, we only do this two places in RenderFlexibleBox.
Also, delete crossAxisLength since it's unused.
Test: css3/flexbox/box-sizing.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
- rendering/RenderFlexibleBox.h:
LayoutTests:
- css3/flexbox/box-sizing-expected.txt: Added.
- css3/flexbox/box-sizing.html: Added.
- 12:04 PM Changeset in webkit [124792] by
-
- 5 edits in trunk
Web Inspector: WebInspector.linkifyStringAsFragment gives wrong typeof lineNumber
https://bugs.webkit.org/show_bug.cgi?id=93019
Patch by John J. Barton <johnjbarton@chromium.org> on 2012-08-06
Reviewed by Pavel Feldman.
Source/WebCore:
Add test for WebInspector.linkifyStringAsFragment()
- inspector/front-end/ResourceUtils.js:
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
LayoutTests:
parseInt the RegExp match for lineNumber
New test case added to linkify.html
- inspector/debugger/linkifier-expected.txt:
- inspector/debugger/linkifier.html:
- 11:46 AM Changeset in webkit [124791] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Not reviewed, linting TestExpectations.
- platform/chromium/TestExpectations:
- 11:42 AM Changeset in webkit [124790] by
-
- 11 edits in trunk/Source/WebKit/chromium
Adding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=93127
Patch by Nasko Oskov <nasko@chromium.org> on 2012-08-06
Reviewed by Adam Barth.
Add support in the API to monitor and create frame hierarchy to allow replicating it
across different instances of WebKit.
- public/WebDocument.h:
(WebDocument): Added createElement.
- public/WebFrame.h: Added assignedName.
- public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::didCreateFrame): Added to allow embedders to know when frames are created.
(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent): Added the target frame as a parameter.
- public/WebNode.h:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent):
- src/WebDocument.cpp:
(WebKit::WebDocument::createElement): Added to allow for creating frame elements.
(WebKit):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::uniqueName): Added to migrate callers to the matching WebCore API.
(WebKit):
(WebKit::WebFrameImpl::assignedName): Returns the name given to a frame, as opposed
to the unique name, generated by WebKit.
(WebKit::WebFrameImpl::createChildFrame): Added call to the frame client's didCreateFrame.
- src/WebFrameImpl.h:
(WebFrameImpl):
- src/WebNode.cpp:
(WebKit::WebNode::appendChild): Added to allow for adding elements to the DOM.
(WebKit):
- tests/WebFrameTest.cpp:
- 11:31 AM Changeset in webkit [124789] by
-
- 5 edits in trunk/Tools
nrwt: clean up logging, part 1
https://bugs.webkit.org/show_bug.cgi?id=93018
Reviewed by Ojan Vafai.
remove --print, --help-printing from nrwt, add three new options:
--quiet, which just logs warnings,errors, and unexpected results
--debug-rwt-logging, a new name for --verbose
--details, to get the old --print trace-everything behavior
This patch does not implement the new "one line per test"
--verbose behavior specified in bug 88702, and there's a bunch
of internal cleanup I can do in printing.py that I'll defer to
a later patch to make things easier to review.
This patch deletes a lot of unit tests that are no longer
necessary since there aren't so many logging combinations.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(parse_args):
(passing_run):
(StreamTestingMixin.assertContains):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_full_results_html):
(MainTest.test_no_tests_found):
(MainTest.test_no_tests_found_2):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_additional_platform_directory):
(RebaselineTest.assertBaselines):
- Scripts/webkitpy/layout_tests/views/printing.py:
(print_options):
(Printer.init):
(Printer.enabled):
(Printer.print_unexpected_results):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(TestUtilityFunctions.test_print_options):
(Testprinter.get_result_summary):
(Testprinter.test_configure_and_cleanup):
(Testprinter.test_print_config):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_unexpected_results):
(test_details):
(test_default):
(test_quiet):
(test_verbose):
- 11:29 AM Changeset in webkit [124788] by
-
- 4 edits in trunk/Tools
[Chromium-Android] Store test executable, data and fonts in /data/local/tmp
https://bugs.webkit.org/show_bug.cgi?id=91910
/data/local/tmp is a directory with permission 0777 by default.
Place DumpRenderTree resources here so that both the native test app and
the NRWT script can access them even if adb shell isn't running as root.
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestShellAndroid.cpp:
(createFIFO): Set fifo mode to 0666 to allow unrooted adb shell to access.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.driver_cmd_line):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._push_executable):
- Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.make_port):
(ChromiumAndroidPortTest.test_expectations_files):
(ChromiumAndroidDriverTest.test_drt_cmd_line):
- 11:19 AM Changeset in webkit [124787] by
-
- 4 edits in tags/Safari-537.3.1/Source
Versioning
- 11:15 AM Changeset in webkit [124786] by
-
- 1 copy in tags/Safari-537.3.1
New Tag.
- 11:15 AM Changeset in webkit [124785] by
-
- 2 edits in trunk/Tools
[Chromium] Re-expose layoutTestController as various fuzzers depend on it
https://bugs.webkit.org/show_bug.cgi?id=93282
Reviewed by Ryosuke Niwa.
Unfortunately, various fuzzers used in the Chromium project still depends on
window.layoutTestController. Re-expose the object while they're making the transition.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::bindJSObjectsToWindow):
- 10:59 AM Changeset in webkit [124784] by
-
- 21 edits1 copy1 move1 add in trunk/Source
[Chromium] Refactor CCTextureUpdater into CCTextureUpdater and CCTextureUpdateController.
https://bugs.webkit.org/show_bug.cgi?id=92596
Patch by David Reveman <reveman@chromium.org> on 2012-08-06
Reviewed by Adrienne Walker.
Source/WebCore:
The CCTextureUpdater interface is used by the main thread to queue
texture updates. The CCTextureUpdateController constructor takes a
CCTextureUpdater and contains the logic required to perform texture
uploads and texture copies. This class is only used by the impl thread.
No new tests.
- WebCore.gypi:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::updatePart):
- platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::copyTexture):
- platform/graphics/chromium/TextureCopier.h:
(Parameters):
(TextureCopier):
(AcceleratedTextureCopier):
- platform/graphics/chromium/TextureUploader.h:
(Parameters):
(TextureUploader):
- platform/graphics/chromium/ThrottledTextureUploader.cpp:
(WebCore::ThrottledTextureUploader::uploadTexture):
- platform/graphics/chromium/ThrottledTextureUploader.h:
(ThrottledTextureUploader):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
- platform/graphics/chromium/cc/CCTextureUpdateController.cpp: Added.
(WebCore):
(WebCore::CCTextureUpdateController::maxPartialTextureUpdates):
(WebCore::CCTextureUpdateController::updateTextures):
(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::~CCTextureUpdateController):
(WebCore::CCTextureUpdateController::hasMoreUpdates):
(WebCore::CCTextureUpdateController::updateMoreTextures):
(WebCore::CCTextureUpdateController::updateMoreTexturesSize):
- platform/graphics/chromium/cc/CCTextureUpdateController.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.
(WebCore):
(CCTextureUpdateController):
(WebCore::CCTextureUpdateController::create):
- platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::appendFullUpload):
(WebCore::CCTextureUpdater::appendPartialUpload):
(WebCore::CCTextureUpdater::appendCopy):
(WebCore::CCTextureUpdater::takeFirstFullUpload):
(WebCore::CCTextureUpdater::takeFirstPartialUpload):
(WebCore::CCTextureUpdater::takeFirstCopy):
(WebCore::CCTextureUpdater::hasMoreUpdates):
- platform/graphics/chromium/cc/CCTextureUpdater.h:
(CCTextureUpdater):
(WebCore::CCTextureUpdater::fullUploadSize):
(WebCore::CCTextureUpdater::partialUploadSize):
(WebCore::CCTextureUpdater::copySize):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::hasMoreResourceUpdates):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::scheduledActionCommit):
(WebCore::CCThreadProxy::maxPartialTextureUpdates):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(WebCore):
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):
(CCThreadProxy):
Source/WebKit/chromium:
- WebKit.gypi:
- src/WebExternalTextureLayer.cpp:
- tests/CCTextureUpdateControllerTest.cpp: Renamed from Source/WebKit/chromium/tests/CCTextureUpdaterTest.cpp.
- tests/CCTiledLayerTestCommon.h:
(WebKitTests::FakeTextureCopier::copyTexture):
(WebKitTests::FakeTextureUploader::uploadTexture):
- tests/TextureCopierTest.cpp:
(TEST):
- tests/TiledLayerChromiumTest.cpp:
- 10:46 AM Changeset in webkit [124783] by
-
- 8 edits2 adds in trunk
Crash in WebCore::RenderListItem::updateMarkerLocation
https://bugs.webkit.org/show_bug.cgi?id=90476
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-08-06
Reviewed by Abhishek Arya.
Source/WebCore:
In some cases an anonymous block is destroyed when its last child is
removed. RenderListItem did not expect this and has it's own logic for
cleaning up such blocks when the list marker is removed. Detect this
case in RenderBlock::removeChild to defer to the logic in RenderListItem::updateListMarker.
Test: fast/lists/list-marker-remove-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
LayoutTests:
- fast/lists/list-marker-remove-crash-expected.txt: Added.
- fast/lists/list-marker-remove-crash.html: Added.
- 10:43 AM Changeset in webkit [124782] by
-
- 6 edits in trunk/Source
[chromium] Non-preserves-3d requires explicit flattening of screen-space transform.
https://bugs.webkit.org/show_bug.cgi?id=85808
Reviewed by Adrienne Walker.
Source/WebCore:
When computing the screen-space transforms, z values were not
being flattened when they should be. This caused incorrect
clipping due to occlusion tracking that relied on the screen-space
transform. The fix is to flatten the screen-space transform just
like the "sublayerMatrix" is flattened, when the layer does not
preserve-3d.
In addition to making the simple fix, it was convenient to make a
helper function for the flattening code.
Additional unit test added to exercise that flattening code:
CCLayerTreeHostCommonTest.verifyTransformsForFlatteningLayer
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):
- platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::CCMathUtil::flattenTransformTo2d):
(WebCore):
- platform/graphics/chromium/cc/CCMathUtil.h:
(CCMathUtil):
Source/WebKit/chromium:
- tests/CCLayerTreeHostCommonTest.cpp:
- 10:37 AM Changeset in webkit [124781] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable and make it return error
https://bugs.webkit.org/show_bug.cgi?id=92545
Unreviewed trivial test fix after r124765.
- http/tests/inspector-enabled/dedicated-workers-list.html:
- 10:28 AM Changeset in webkit [124780] by
-
- 20 edits4 copies1 add in trunk/Source/WebCore
Create a MediaSource object.
https://bugs.webkit.org/show_bug.cgi?id=91773
Reviewed by Eric Carlson.
MediaSource object is needed in order to implement the new
object-oriented MediaSource API:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html
No new tests - will be able to test after landing:
https://bugs.webkit.org/show_bug.cgi?id=91775
Adding new files to build files:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
New MediaSource object:
- Modules/mediasource/MediaSource.cpp: Added.
- Modules/mediasource/MediaSource.h: Added.
- Modules/mediasource/MediaSource.idl: Added.
Create a registry for the blob storage and lookup:
- Modules/mediasource/MediaSourceRegistry.cpp: Added.
- Modules/mediasource/MediaSourceRegistry.h: Added.
Connect SourceBuffer to MediaSource:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::buffered): Forward call to MediaSource.
(WebCore::SourceBuffer::append): Ditto.
(WebCore::SourceBuffer::abort): Ditto.
- Modules/mediasource/SourceBuffer.h:
(WebCore::SourceBuffer::create): Add a MediaSource to the constructor.
(WebCore::SourceBuffer::clear): Clear the MediaSource.
(SourceBuffer):
- Modules/mediasource/SourceBufferList.cpp: include SourceBuffer.h
- Modules/mediasource/SourceBufferList.h:
Make MediaSource an EventTarget:
- dom/EventTarget.h:
(WebCore):
- dom/EventTargetFactory.in:
Enable creation of MediaSource object URL from JavaScript:
- html/DOMURL.cpp:
(WebCore):
(WebCore::DOMURL::createObjectURL):
- html/DOMURL.h:
(WebCore):
(DOMURL):
- html/DOMURL.idl:
New MediaSource constructor:
- page/DOMWindow.idl:
- 10:04 AM Changeset in webkit [124779] by
-
- 7 edits in trunk/Source/WebCore
Simplify CSSOM style declaration's grabbing at internals.
<http://webkit.org/b/93261>
Reviewed by Antti Koivisto.
It was already the case that StylePropertySets exposed in CSSOM were guaranteed mutable,
so remove the mechanism to convert immutable backing objects to mutable ones.
Made ensureCSSStyleDeclaration() non-const to prevent callers that may have an
immutable StylePropertySet from wrapping a CSSOM object around it.
- css/PropertySetCSSStyleDeclaration.h:
(PropertySetCSSStyleDeclaration):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):
Remove indirection and access StylePropertySet member directly.
- css/StylePropertySet.h:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):
Made these two non-const. CSSOM wrappers should only ever be constructed around
mutable StylePropertySets.
Also added ASSERT(isMutable()).
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
Cast away the constness of StyledElement::attributeStyle(). It's not pretty,
but these objects are guaranteed mutable, and there's an assertion to protect
us in ensureCSSStyleDeclaration() if something changes in the future.
- 9:39 AM Changeset in webkit [124778] by
-
- 11 edits in trunk
Web Inspector: Protocol: Add "namedFlowCreated" and "namedFlowRemoved" events
https://bugs.webkit.org/show_bug.cgi?id=92739
Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-08-06
Reviewed by Pavel Feldman.
Source/WebCore:
Implemented "namedFlowCreated" and "namedFlowRemoved" events.
Modified test: inspector/styles/protocol-css-regions-commands.html.
- dom/WebKitNamedFlowCollection.cpp:
(WebCore::WebKitNamedFlowCollection::ensureFlowWithName):
(WebCore::WebKitNamedFlowCollection::discardNamedFlow):
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.styleSheetChanged):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
LayoutTests:
Modified test so that it validates the implemented events.
- inspector/styles/protocol-css-regions-commands-expected.txt:
- inspector/styles/protocol-css-regions-commands.html:
- 9:38 AM Changeset in webkit [124777] by
-
- 1 copy in releases/WebKitGTK/webkit-1.9.6
Tagging the WebKitGTK+ 1.9.6 release
- 9:30 AM Changeset in webkit [124776] by
-
- 2 edits in trunk/Source/WebCore
Crash in FrameLoader::stopAllLoaders.
https://bugs.webkit.org/show_bug.cgi?id=90805
Reviewed by Nate Chapin.
Calling m_provisionalDocumentLoader->stopLoading() can blow away the frame
from underneath. Protect it with a RefPtr.
No new tests. We don't have a reliable testcase to reproduce this. However,
the crash and free stack from ClusterFuzz point clearly at the bug.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopAllLoaders):
- 9:07 AM Changeset in webkit [124775] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed GTK gardening, rebaselining a few HTMLProgressElement tests
after changes in r124754.
- platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
- platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
- platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
- 8:53 AM Changeset in webkit [124774] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r124692): webarchive/loading/javascript-url-iframe-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=93190
Reviewed by Adam Barth.
Apparently we can't just edit the markup in a webarchive file. Re-generated webarchive file
from a locally copied markup.
- webarchive/loading/resources/javascript-url-iframe-crash.webarchive:
- 8:29 AM Changeset in webkit [124773] by
-
- 6 edits in trunk
Source/WebCore: Rolling out my r123067 and r123572
https://bugs.webkit.org/show_bug.cgi?id=93234
Reviewed by Ryosuke Niwa.
This change manually rolls out my r123067 and r123572 (except layout tests)
because it renders RTL text to a wrong place when an RTL element shows a
vertical scrollbar at its left side.
No new tests because this change rolls out my changes.
- dom/Element.cpp:
(WebCore::Element::clientLeft):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromPositionedObjects):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::paintObject):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::topLeftLocationOffset):
LayoutTests: Rolling out for r123067 and r123572
https://bugs.webkit.org/show_bug.cgi?id=93234
Reviewed by Ryosuke Niwa.
This change marks tests that fail when rolling out my r123067 and r123572.
- platform/chromium/TestExpectations:
- 8:24 AM Changeset in webkit [124772] by
-
- 5 edits2 adds in trunk
[CSS Regions] Add the NamedFlow.getRegions() API
https://bugs.webkit.org/show_bug.cgi?id=93240
Patch by Andrei Bucur <abucur@adobe.com> on 2012-08-06
Reviewed by Andreas Kling.
Source/WebCore:
This patch adds the NamedFlow.getRegions() API call as specified by http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-named-flow .
For now, WebKit supports only one type of regions, Element. The Region interface will be introduced when other interfaces will be capable
of becoming regions.
New test: fast/regions/webkit-named-flow-get-regions.html
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::getRegionsByContent): Add a check not to include the pseudo-elements that are regions; those don't have a node attached.
(WebCore::WebKitNamedFlow::getRegions):
(WebCore):
- dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
- dom/WebKitNamedFlow.idl:
LayoutTests:
Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-named-flow
The test also verifies the regions are returned in document order.
- fast/regions/webkit-named-flow-get-regions-expected.txt: Added.
- fast/regions/webkit-named-flow-get-regions.html: Added.
- 8:21 AM Changeset in webkit [124771] by
-
- 9 edits2 moves2 adds2 deletes in trunk
[CSS Regions] Rename regionOverflow to regionOverset
https://bugs.webkit.org/show_bug.cgi?id=93256
Patch by Andrei Bucur <abucur@adobe.com> on 2012-08-06
Reviewed by Andreas Kling.
Source/WebCore:
Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-region-regionoverset
The regionOverflow property has been renamed to regionOverset in the latest working draft. This patch applies the change both externally and
internally in the code.
Tests: No new tests because this is not a functional change.
- dom/Element.cpp:
(WebCore::Element::renderRegion): Convenience method to access the renderer for a region element.
(WebCore):
(WebCore::Element::webkitRegionOverset):
- dom/Element.h:
(WebCore):
- dom/Element.idl:
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintIntoRegion):
(WebCore::RenderFlowThread::hitTestRegion):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOversetRect):
- rendering/RenderRegion.h:
(RenderRegion):
LayoutTests:
Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-region-regionoverset
The tests have been adapted to use webkitRegionOverset rather than webkitRegionOverflow.
- fast/regions/element-region-overflow-state-expected.txt: Removed.
- fast/regions/element-region-overflow-state-vertical-rl-expected.txt: Removed.
- fast/regions/element-region-overset-state-expected.txt: Added.
- fast/regions/element-region-overset-state-vertical-rl-expected.txt: Added.
- fast/regions/element-region-overset-state-vertical-rl.html: Renamed from LayoutTests/fast/regions/element-region-overflow-state-vertical-rl.html.
- fast/regions/element-region-overset-state.html: Renamed from LayoutTests/fast/regions/element-region-overflow-state.html.
- fast/regions/webkit-named-flow-first-empty-region-index.html:
- 7:54 AM Changeset in webkit [124770] by
-
- 2 edits in trunk/Tools
WTR should be able to load external resources
https://bugs.webkit.org/show_bug.cgi?id=89382
Reviewed by Ryosuke Niwa.
Allow to load an external resource as the main frame
and allow all subsequent external loads for such a main
frame. This behavior is necessary for being able to run
performance tests (https://bugs.webkit.org/show_bug.cgi?id=84008).
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::isLocalHost):
(WTR):
(WTR::isHTTPOrHTTPSScheme):
(WTR::InjectedBundlePage::willSendRequestForFrame):
- 7:39 AM EFLWebKitTests edited by
- (diff)
- 7:14 AM Changeset in webkit [124769] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: a tiny refactoring of Highlighter in InspectorDOMAgent
https://bugs.webkit.org/show_bug.cgi?id=93257
Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-08-06
Reviewed by Pavel Feldman.
Moving error string setting inside highlightConfigFromInspectorObject.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::highlightNode):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- 7:09 AM Changeset in webkit [124768] by
-
- 71 edits in trunk/Source/WebCore
Web Inspector: add memory instrumentation for CSSValue and its descendants
https://bugs.webkit.org/show_bug.cgi?id=93130
Reviewed by Pavel Feldman.
Added memory footprint reporting routine to CSSValue and its descendants.
Memory reporing for CSSValue is organized in a following way:
- CSSValue implements reportMemoryUsage method that switches by the value type and calls reportDescendantMemoryUsage on the concrete type
- There may be some intermediate classes in the inheritance chain between CSSValue and the leaf class implementing reportDescendantMemoryUsage. Those intermediate classes implement reportBaseClassMemoryUsage method that can be called from a descendant to collect memory information for the base class members. Having reportDescendantMemoryUsage only on the leaf classes prevents us from accidentally adding the intermediate classes to the switch block in the CSSValue::reportMemoryUsage.
- css/CSSAspectRatioValue.cpp:
(WebCore::CSSAspectRatioValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSAspectRatioValue.h:
(CSSAspectRatioValue):
- css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSBorderImageSliceValue.h:
(CSSBorderImageSliceValue):
- css/CSSCalculationValue.cpp:
(WebCore):
(WebCore::CSSCalcValue::reportDescendantMemoryUsage):
(CSSCalcPrimitiveValue):
- css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(CSSCalcValue):
- css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSCanvasValue.h:
(CSSCanvasValue):
- css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSCrossfadeValue.h:
(CSSCrossfadeValue):
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSCursorImageValue.h:
(CSSCursorImageValue):
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSFontFaceSrcValue.h:
(CSSFontFaceSrcValue):
- css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSFunctionValue.h:
(CSSFunctionValue):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):
- css/CSSGradientValue.h:
(CSSGradientColorStop):
(CSSGradientValue):
(CSSLinearGradientValue):
(CSSRadialGradientValue):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
(WebCore):
- css/CSSImageGeneratorValue.h:
(CSSImageGeneratorValue):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
- css/CSSImageSetValue.h:
(ImageWithScale):
(CSSImageSetValue):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSImageValue.h:
(CSSImageValue):
- css/CSSInheritedValue.cpp:
(WebCore::CSSInheritedValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSInheritedValue.h:
(CSSInheritedValue):
- css/CSSInitialValue.cpp:
(WebCore::CSSInitialValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSInitialValue.h:
(CSSInitialValue):
- css/CSSLineBoxContainValue.cpp:
(WebCore::CSSLineBoxContainValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSLineBoxContainValue.h:
(CSSLineBoxContainValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
- css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSReflectValue.h:
(CSSReflectValue):
- css/CSSTimingFunctionValue.cpp:
(WebCore::CSSLinearTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore):
(WebCore::CSSCubicBezierTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSStepsTimingFunctionValue::reportDescendantMemoryUsage):
- css/CSSTimingFunctionValue.h:
(CSSLinearTimingFunctionValue):
(CSSCubicBezierTimingFunctionValue):
(CSSStepsTimingFunctionValue):
- css/CSSUnicodeRangeValue.cpp:
(WebCore::CSSUnicodeRangeValue::reportDescendantMemoryUsage):
(WebCore):
- css/CSSUnicodeRangeValue.h:
(CSSUnicodeRangeValue):
- css/CSSValue.cpp:
(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
(TextCloneCSSValue):
(WebCore::CSSValue::reportMemoryUsage):
(WebCore):
- css/CSSValue.h:
(WebCore):
(CSSValue):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::reportDescendantMemoryUsage):
(WebCore):
- css/CSSValueList.h:
(CSSValueList):
- css/CSSVariableValue.h:
(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
(CSSVariableValue):
- css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
(WebCore):
- css/FontFeatureValue.h:
(FontFeatureValue):
- css/FontValue.cpp:
(WebCore::FontValue::reportDescendantMemoryUsage):
(WebCore):
- css/FontValue.h:
(FontValue):
- css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
- css/ShadowValue.cpp:
(WebCore::ShadowValue::reportDescendantMemoryUsage):
(WebCore):
- css/ShadowValue.h:
(ShadowValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::reportDescendantMemoryUsage):
(WebCore):
- css/WebKitCSSFilterValue.h:
(WebKitCSSFilterValue):
- css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
(WebCore):
- css/WebKitCSSSVGDocumentValue.h:
(WebKitCSSSVGDocumentValue):
- css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
(WebCore):
- css/WebKitCSSShaderValue.h:
(WebKitCSSShaderValue):
- css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::reportDescendantMemoryUsage):
(WebCore):
- css/WebKitCSSTransformValue.h:
(WebKitCSSTransformValue):
- dom/MemoryInstrumentation.cpp:
(WebCore::MemoryInstrumentation::addString):
(WebCore):
- dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore::MemoryClassInfo::addHashCountedSet):
(WebCore::MemoryClassInfo::addMember):
- svg/SVGColor.cpp:
(WebCore::SVGColor::reportDescendantMemoryUsage):
(WebCore):
- svg/SVGColor.h:
(SVGColor):
- svg/SVGPaint.cpp:
(WebCore::SVGPaint::reportDescendantMemoryUsage):
(WebCore):
- svg/SVGPaint.h:
(SVGPaint):
- 7:09 AM Changeset in webkit [124767] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaseline for Mac10.6 against r124752
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06
- platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
- 7:05 AM Changeset in webkit [124766] by
-
- 4 edits3 adds7 deletes in trunk/LayoutTests
Unreviewed, rebaseline for r124754.
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06
- fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
- fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
- fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
- platform/chromium-mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
- platform/chromium-mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
- platform/chromium-mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt:
- platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Removed.
- platform/efl/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Removed.
- platform/efl/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
- platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
- 6:51 AM Changeset in webkit [124765] by
-
- 16 edits in trunk/Source
Web Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable and make it return error
https://bugs.webkit.org/show_bug.cgi?id=92545
Reviewed by Pavel Feldman.
Source/WebCore:
- Replaced WorkerAgent.setWorkerInspectionEnabled with WorkerAgent.enable/disable
- Replaced Preferences.exposeWorkersInspection with InspectorFrontendHost.canInspectWorkers() that tells if inspector front-end on the given platform can launch dedicated worker front-end.
- inspector/Inspector.json:
- inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
- inspector/InspectorFrontendClientLocal.h:
(WebCore::InspectorFrontendClientLocal::canInspectWorkers):
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::canInspectWorkers):
(WebCore):
- inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
- inspector/InspectorFrontendHost.idl:
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::enable):
(WebCore):
(WebCore::InspectorWorkerAgent::disable):
- inspector/InspectorWorkerAgent.h:
(InspectorWorkerAgent):
- inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.setZoomFactor):
(.WebInspector.InspectorFrontendHostStub.prototype.canInspectWorkers):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/Settings.js:
Source/WebKit/chromium:
Replaced Preferences.exposeWorkersInspection with InspectorFrontendHost.canInspectWorkers()
that tells if inspector front-end on the given platform can launch dedicated worker
front-end.
- src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::canInspectWorkers):
(WebKit):
- src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):
- src/js/DevTools.js:
- 6:45 AM Changeset in webkit [124764] by
-
- 4 edits in trunk
Unreviewed. Update NEWS and configure.ac for 1.9.6 release
.:
- configure.ac: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 1.9.6.
- 6:43 AM Changeset in webkit [124763] by
-
- 8 edits in trunk/Source
[WK2][GTK] Improvements for the new spell-checking API
https://bugs.webkit.org/show_bug.cgi?id=93262
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Provide a way to ask TextCheckerEnchant helper class for the list
of languages currently available for the spell checking feature.
- platform/text/gtk/TextCheckerEnchant.cpp:
(enchantDictDescribeCallback): Renamed from
getAvailableDictionariesCallback, for consistency.
(TextCheckerEnchant::updateSpellCheckingLanguages): Updated usage
of getAvailableDictionariesCallback to enchantDictDescribeCallback.
(TextCheckerEnchant::getSpellCheckingLanguages): New. Will build
and return a String with a comma-separated list of languages
currently in use by the spell checking feature.
- platform/text/gtk/TextCheckerEnchant.h:
(TextCheckerEnchant): Added new function getSpellCheckingLanguages.
Source/WebKit2:
Improve the way the new spell-checking API is implemented, by
using better internal representations for data, documenting better
the new functions and using better unit tests.
- UIProcess/API/gtk/WebKitTextChecker.cpp:
(WebKitTextChecker::getSpellCheckingLanguages): Just return the
value previously cached when calling to the setter function.
(WebKitTextChecker::setSpellCheckingLanguages): Update the text
checker in WebCore and cache the value returned from it.
- UIProcess/API/gtk/WebKitTextChecker.h:
(WebKitTextChecker): Use a CString instead of an String to cache
the list of spell checking languages. Update getter and setter.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate): No need to cache the spell checking
languages here anymore.
(webkit_web_context_get_spell_checking_languages): Improve
both implementation and documentation to be more consistent.
(webkit_web_context_set_spell_checking_languages): Make
'languages' a mandatory (non-NULL) parameter. Update documentation.
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextSpellChecker): Test even more situations.
- 6:35 AM Changeset in webkit [124762] by
-
- 3 edits in trunk/Tools
[WK2] REGRESSION(124596) lot of web process unresponsiveness appears on Apple bots
https://bugs.webkit.org/show_bug.cgi?id=93120
Reviewed by Csaba Osztrogonác.
Set the short timeout back to 15 seconds and add more time to WebKitTestRunner
so it will be able to detect an unresponsive web process.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_timeout_ms):
- WebKitTestRunner/TestController.cpp:
(WTR):
- 6:30 AM Changeset in webkit [124761] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-06
- 6:14 AM Changeset in webkit [124760] by
-
- 14 edits in trunk/Source/WebCore
Pass presentational attribute StylePropertySets by const pointer where possible.
<http://webkit.org/b/93187>
Reviewed by Antti Koivisto.
Minor cleanup to enforce (at compile time) the fact that no methods that have the
side-effect of incurring immutable-to-mutable-StylePropertySet conversion.
This was already covered by assertions, we're just making it stricter and adding
some documentational flavor.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::addElementStyleProperties):
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleResolver.h:
(StyleResolver):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::attributeStyle):
- dom/StyledElement.h:
(WebCore::StyledElement::additionalAttributeStyle):
(StyledElement):
(WebCore::StyledElement::attributeStyle):
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyle):
- html/HTMLTableCellElement.h:
(HTMLTableCellElement):
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyle):
- html/HTMLTableColElement.h:
(HTMLTableColElement):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):
- html/HTMLTableElement.h:
(HTMLTableElement):
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyle):
- html/HTMLTableSectionElement.h:
(HTMLTableSectionElement):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
- 6:04 AM Changeset in webkit [124759] by
-
- 12 edits11 adds in trunk
Add DeviceProximityEvent interface
https://bugs.webkit.org/show_bug.cgi?id=92942
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-06
Reviewed by Kentaro Hara.
Source/WebCore:
Spec : http://www.w3.org/TR/proximity/#idl-def-DeviceProximityEvent
Add DeviceProximityEvent interface of Proximity Events.
And add onwebkitdeviceproximity event handler to the DOMWindow.
Tests: fast/dom/Proximity/check-event-deviceproximity.html
fast/dom/Proximity/create-event-deviceproximity.html
fast/events/constructors/device-proximity-event-constructor.html
- CMakeLists.txt:
- Modules/proximity/DeviceProximityEvent.cpp: Added.
(WebCore):
(WebCore::DeviceProximityEvent::DeviceProximityEvent):
- Modules/proximity/DeviceProximityEvent.h: Added.
(WebCore):
(WebCore::DeviceProximityEventInit::DeviceProximityEventInit):
(DeviceProximityEventInit):
(DeviceProximityEvent):
(WebCore::DeviceProximityEvent::~DeviceProximityEvent):
(WebCore::DeviceProximityEvent::create):
(WebCore::DeviceProximityEvent::value):
(WebCore::DeviceProximityEvent::min):
(WebCore::DeviceProximityEvent::max):
(WebCore::DeviceProximityEvent::interfaceName):
- Modules/proximity/DeviceProximityEvent.idl: Added.
- dom/EventNames.h:
(WebCore):
- dom/EventNames.in:
- page/DOMWindow.h:
(DOMWindow):
- page/DOMWindow.idl:
LayoutTests:
Add tests for creating and handling the DeviceProximityEvent.
- fast/dom/Proximity/check-event-deviceproximity-expected.txt: Added.
- fast/dom/Proximity/check-event-deviceproximity.html: Added.
- fast/dom/Proximity/create-event-deviceproximity-expected.txt: Added.
- fast/dom/Proximity/create-event-deviceproximity.html: Added.
- fast/events/constructors/device-proximity-event-constructor-expected.txt: Added.
- fast/events/constructors/device-proximity-event-constructor.html: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/Skipped:
- platform/qt/Skipped:
- 6:03 AM Changeset in webkit [124758] by
-
- 6 edits in trunk/Source/WebKit2
[Qt][WK2] Remove workarounds from input event handling
https://bugs.webkit.org/show_bug.cgi?id=93125
Reviewed by Jocelyn Turcotte.
Since input event propagation in Qt5 has been fixed we can remove
the workarounds introduced to prevent the QML WebView from receiving
input events targeting a child dialog.
To do this the childMouseEventFilter function has to be changed to
force touch and mouse events through the default propagation path.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewLegacyPrivate::initialize):
(QQuickWebView::childMouseEventFilter):
(QQuickWebView::touchEvent):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
(QQuickWebViewLegacyPrivate):
- UIProcess/qt/QtDialogRunner.cpp:
(WebKit::QtDialogRunner::run):
- UIProcess/qt/WebColorChooserProxyQt.cpp:
(WebKit::WebColorChooserProxyQt::createItem):
(WebKit::WebColorChooserProxyQt::endChooser):
- UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
(WebKit::WebPopupMenuProxyQt::hidePopupMenu):
- 5:35 AM Changeset in webkit [124757] by
-
- 6 edits in trunk
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing header file.
Source/WebCore:
- GNUmakefile.list.am: Remove unexistent header file.
Tools:
- GNUmakefile.am: Add jhbuildutils.py to EXTRA_DIST.
- 5:27 AM Changeset in webkit [124756] by
-
- 4 edits in trunk
[EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
https://bugs.webkit.org/show_bug.cgi?id=82724
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-06
Reviewed by Csaba Osztrogonác.
Tools:
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::removeAllVisitedLinks):
LayoutTests:
- platform/efl/Skipped:
- 5:02 AM Changeset in webkit [124755] by
-
- 17 edits in trunk/Source/WebCore
[JSC] Remove custom JSBindings for constructArrayBufferView()
https://bugs.webkit.org/show_bug.cgi?id=93097
Patch by Vineet Chaudhary <Vineet> on 2012-08-06
Reviewed by Kentaro Hara.
Currently TypedArray files have the custom implementation of constructArrayBufferView().
We can can remove these modifying CodeGeneratorJS.pm
Tests: TestTypedArray.idl
- bindings/js/JSFloat32ArrayCustom.cpp: Removed custom call constructArrayBufferView().
- bindings/js/JSFloat64ArrayCustom.cpp: Ditto.
- bindings/js/JSInt16ArrayCustom.cpp: Ditto.
- bindings/js/JSInt32ArrayCustom.cpp: Ditto.
- bindings/js/JSUint16ArrayCustom.cpp: Ditto.
- bindings/js/JSUint32ArrayCustom.cpp: Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Modified Generator code to generate bindings for
constructArrayBufferView()
(GenerateConstructorDefinition):
- bindings/scripts/IDLAttributes.txt: Added [TypedArray] attribute.
- bindings/scripts/test/JS/JSFloat64Array.cpp: Tests result.
(WebCore::JSFloat64ArrayConstructor::getConstructData):
(WebCore::JSFloat64ArrayConstructor::constructJSFloat64Array):
- bindings/scripts/test/TestTypedArray.idl: Test.
- html/canvas/Float32Array.idl: Using [TypedArray].
- html/canvas/Float64Array.idl: Ditto.
- html/canvas/Int16Array.idl: Ditto.
- html/canvas/Int32Array.idl: Ditto.
- html/canvas/Uint16Array.idl: Ditto.
- html/canvas/Uint32Array.idl: Ditto.
- 5:00 AM Changeset in webkit [124754] by
-
- 16 edits13 adds in trunk
AuthorShadowDOM for progress element
https://bugs.webkit.org/show_bug.cgi?id=91969
Reviewed by Hajime Morita.
Source/WebCore:
We add support for AuthorShadowDOM for progress element.
According to the Shadow DOM spec, a progress element should behave like having a UserAgentShadowRoot and
an element in UserAgentShadowRoot draws a real 'progress' bar. In this patch, we change the inner structure
of a progress element so that we can distribute an element having RenderProgress to AuthorShadowDOM.
Before this patch, a progress element has the following inner structure.
<progress>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot
|
+-- ProgressBarElement
|
+-- ProgressValueElement
After this patch, a progress element will have the following inner structure.
<progress>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot
|
+-- ProgressInnerElement
|
+-- ProgressBarElement
|
+-- ProgressValueElement
Tests: fast/dom/shadow/shadowdom-for-progress-dynamic.html
fast/dom/shadow/shadowdom-for-progress-multiple.html
fast/dom/shadow/shadowdom-for-progress-with-style.html
fast/dom/shadow/shadowdom-for-progress-without-appearance.html
fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html
fast/dom/shadow/shadowdom-for-progress.html
- css/html.css:
(progress::-webkit-progress-inner-element):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::HTMLProgressElement):
(WebCore::HTMLProgressElement::createRenderer):
(WebCore::HTMLProgressElement::renderProgress): Returns RenderProgress gotten from UserAgentShadowDOM.
(WebCore):
(WebCore::HTMLProgressElement::willAddAuthorShadowRoot):
(WebCore::HTMLProgressElement::didElementStateChange):
(WebCore::HTMLProgressElement::createShadowSubtree): Creates a new Shadow DOM structure.
- html/HTMLProgressElement.h:
(WebCore):
(WebCore::HTMLProgressElement::hasAuthorShadowRoot):
(HTMLProgressElement):
(WebCore::isHTMLProgressElement):
(WebCore::toHTMLProgressElement):
- html/shadow/ProgressShadowElement.cpp:
(WebCore::ProgressShadowElement::ProgressShadowElement):
(WebCore::ProgressShadowElement::progressElement):
(WebCore::ProgressInnerElement::ProgressInnerElement): We introduce a new element having RenderProgress
so that we can distribute an element having RenderProgress to AuthorShadowDOM.
(WebCore):
(WebCore::ProgressInnerElement::create):
(WebCore::ProgressInnerElement::shadowPseudoId):
(WebCore::ProgressInnerElement::createRenderer):
(WebCore::ProgressInnerElement::rendererIsNeeded):
- html/shadow/ProgressShadowElement.h:
(ProgressShadowElement):
(WebCore):
(ProgressInnerElement):
- rendering/RenderProgress.cpp:
(WebCore::RenderProgress::RenderProgress):
(WebCore::RenderProgress::progressElement):
- rendering/RenderProgress.h:
(RenderProgress):
LayoutTests:
Contains the following tests:
(1) progress element with AuthorShadowDOM
(2) progress element with multiple AuthorShadowDOM with a shadow element
(3) progress element with multiple AuthorShadowDOM without a shadow element
(4) progress element with AuthorShadowDOM with dynamic value update
(5) progress element with AuthorShadowDOM with style
(6) progress element with AuthorShadowDOM with -webkit-appearance: none
- fast/dom/HTMLProgressElement/progress-clone-expected.txt:
- fast/dom/HTMLProgressElement/progress-clone.html:
- fast/dom/HTMLProgressElement/progress-element-markup-expected.txt:
- fast/dom/shadow/resources/replaced-element-styles.css: Added.
(.progress-like):
(.progress-inner-element-like):
- fast/dom/shadow/shadowdom-for-progress-dynamic-expected.html: Added.
- fast/dom/shadow/shadowdom-for-progress-dynamic.html: Added.
- fast/dom/shadow/shadowdom-for-progress-expected.html: Added.
- fast/dom/shadow/shadowdom-for-progress-multiple-expected.html: Added.
- fast/dom/shadow/shadowdom-for-progress-multiple.html: Added.
- fast/dom/shadow/shadowdom-for-progress-with-style-expected.html: Added.
- fast/dom/shadow/shadowdom-for-progress-with-style.html: Added.
- fast/dom/shadow/shadowdom-for-progress-without-appearance-expected.html: Added.
- fast/dom/shadow/shadowdom-for-progress-without-appearance.html: Added.
- fast/dom/shadow/shadowdom-for-progress-without-shadow-element-expected.html: Added.
- fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html: Added.
- fast/dom/shadow/shadowdom-for-progress.html: Added.
- platform/chromium-win/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt:
- platform/mac/TestExpectations:
- 4:37 AM Changeset in webkit [124753] by
-
- 12 edits in trunk
Remove minimum window size for PagePopup
https://bugs.webkit.org/show_bug.cgi?id=93100
Reviewed by Kent Tamura.
Source/WebCore:
DOMWindow had a minimum size of 100x100 pixels. We need to remove that limit for PagePopup window.
No new tests. Covered in platform/chromium/fast/forms/color/color-suggestion-picker-{one,two}-row-appearance.html.
- Resources/colorSuggestionPicker.css:
(.color-swatch-container):
- page/ChromeClient.h:
(WebCore::ChromeClient::minimumWindowSize):
(ChromeClient):
- page/DOMWindow.cpp:
(WebCore):
(WebCore::DOMWindow::adjustWindowRect): Asks Chrome::minimumWindowSize for minimum window size.
- page/DOMWindow.h:
(DOMWindow):
Source/WebKit/chromium:
- src/WebPagePopupImpl.cpp: Returns 0x0 so the page popup can be smaller than 100x100.
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
- platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html: Added background color so we can check that we don't have extra white area.
- platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html: Ditto.
- 4:06 AM Changeset in webkit [124752] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, rebaseline for r124745.
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06
- platform/chromium-mac/fast/block/float/032-expected.txt:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
- 3:30 AM Changeset in webkit [124751] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, skip new asserting tests to paint the bots green.
- platform/qt/Skipped:
- 3:29 AM Changeset in webkit [124750] by
-
- 4 edits2 adds in trunk
Microdata: document.getItems() must treat no token as no parameter.
https://bugs.webkit.org/show_bug.cgi?id=93071
Reviewed by Ryosuke Niwa.
Source/WebCore:
document.getItems() must return all top-level microdata items in the
document when no tokens specified in the argument.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html#dom-document-getitems
Test: fast/dom/MicroData/getitems-empty-string-as-arg.html
- dom/Document.cpp:
(WebCore::Document::getItems): Create an empty string identifier when typeNames is null string
to map such request in the cache.
- dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::undefinedItemType): Changed undefinedItemType() to empty string.
(WebCore::MicroDataItemList::nodeMatches): Return true if m_typeNames contains no token.
LayoutTests:
Added test to verify that document.getItems() returns all top-level
microdata items in the document when no tokens specified in the argement.
- fast/dom/MicroData/getitems-empty-string-as-arg-expected.txt: Added.
- fast/dom/MicroData/getitems-empty-string-as-arg.html: Added.
- 3:19 AM Changeset in webkit [124749] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: extracting HighlightInfo from HighlightData in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=91632
Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-08-06
Reviewed by Pavel Feldman.
Extracted struct HighlightInfo from struct HighlightData in DOMNodeHighlighter.
Now InspectorOverlay receives node or rect to highlight together with highlightInfo.
- inspector/DOMNodeHighlighter.cpp:
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore::InspectorOverlay::highlightNode):
(WebCore::InspectorOverlay::highlightRect):
(WebCore::InspectorOverlay::highlightedNode):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore):
(WebCore::InspectorOverlay::drawRectHighlight):
(WebCore::InspectorOverlay::drawPausedInDebugger):
- inspector/DOMNodeHighlighter.h:
(HighlightConfig):
(WebCore::Highlight::setColors):
(Highlight):
(InspectorOverlay):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::inspect):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
- inspector/InspectorDOMAgent.h:
(WebCore):
(InspectorDOMAgent):
- 3:17 AM Changeset in webkit [124748] by
-
- 1 edit18 deletes in trunk/LayoutTests
Remove unused png files from platform/chromium-linux/fast/css/variables.
https://bugs.webkit.org/show_bug.cgi?id=93232
Reviewed by Tony Chang.
- platform/chromium-linux/fast/css/variables/block-cycle-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/colors-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/declaration-block-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/font-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/image-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/import-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/inline-style-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/invalid-variable-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/margin-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/misplaced-import-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/misplaced-variables-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/multiple-blocks-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/multiple-term-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/override-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/print-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/remove-variable-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/set-variable-test-expected.png: Removed.
- platform/chromium-linux/fast/css/variables/shorthand-test-expected.png: Removed.
- 2:57 AM Changeset in webkit [124747] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed: Web Inspector: single line test fix for r124744.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):
- 2:44 AM Changeset in webkit [124746] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r124739.
http://trac.webkit.org/changeset/124739
https://bugs.webkit.org/show_bug.cgi?id=93241
newly added test crash on chromium linux debug (Requested by
toyoshim on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
LayoutTests:
- fast/lists/list-marker-remove-crash-expected.txt: Removed.
- fast/lists/list-marker-remove-crash.html: Removed.
- 2:38 AM Changeset in webkit [124745] by
-
- 7 edits in trunk
Fix layoutMod in fractional layout units.
https://bugs.webkit.org/show_bug.cgi?id=92374
Reviewed by Levi Weintraub.
Source/WebCore:
The modulo operation is upgraded from only being performed in integer to
being performed in fractionalLayoutUnits, so that it returns an accurate
remainder for fractionalLayoutUnit division.
An alternative modulo operation is added and used to find the remainder
after division with natural integer results, for instance, the remainding
height after pagination.
No new functionality. No new tests.
- platform/FractionalLayoutUnit.h:
(WebCore::intMod):
(WebCore::operator%):
- rendering/LayoutTypes.h:
(WebCore::layoutMod):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
LayoutTests:
Mark minor pixel changes in the baseline as expected failures.
- platform/chromium/TestExpectations:
- 2:12 AM Changeset in webkit [124744] by
-
- 29 edits in trunk/Source/WebCore
Web Inspector: native memory instrumentation: cover MemoryCache with MemoryInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=91734
Reviewed by Yury Semikhatsky.
Old version of native memory instrumentation doesn't mark the memory cache objects as visited.
As a result MI could count the same objects multiple times.
The new version just traverses through MemoryCache the same way as through DOM.
Also not all the cached resource types were counted.
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/MemoryInstrumentation.h:
- inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
(WebCore::collectDomTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
(WebCore):
- loader/cache/CachedCSSStyleSheet.h:
(WebCore):
(CachedCSSStyleSheet):
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::reportMemoryUsage):
(WebCore):
- loader/cache/CachedFont.h:
(CachedFont):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
(WebCore):
- loader/cache/CachedImage.h:
(CachedImage):
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::reportMemoryUsage):
(WebCore):
- loader/cache/CachedRawResource.h:
(WebCore):
(CachedRawResource):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
(WebCore):
- loader/cache/CachedResource.h:
(WebCore):
(CachedResource):
- loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::reportMemoryUsage):
(WebCore):
- loader/cache/CachedResourceHandle.h:
(WebCore):
(CachedResourceHandleBase):
- loader/cache/CachedResourceLoader.cpp:
(WebCore):
(WebCore::CachedResourceLoader::reportMemoryUsage):
- loader/cache/CachedResourceLoader.h:
(WebCore):
(CachedResourceLoader):
- loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::reportMemoryUsage):
(WebCore):
- loader/cache/CachedSVGDocument.h:
(CachedSVGDocument):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::reportMemoryUsage):
(WebCore):
- loader/cache/CachedScript.h:
(WebCore):
(CachedScript):
- loader/cache/CachedShader.cpp:
(WebCore::CachedShader::reportMemoryUsage):
(WebCore):
- loader/cache/CachedShader.h:
(WebCore):
(CachedShader):
- loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
(WebCore):
- loader/cache/CachedXSLStyleSheet.h:
(WebCore):
(CachedXSLStyleSheet):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
(WebCore):
- loader/cache/MemoryCache.h:
(WebCore):
(MemoryCache):
- platform/PurgeableBuffer.h:
(WebCore):
(PurgeableBuffer):
- 1:55 AM FeatureFlags edited by
- (diff)
- 1:46 AM FeatureFlags edited by
- (diff)
- 1:27 AM Changeset in webkit [124743] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] fast/forms/range/slider-mouse-events.html and fast/forms/range/slider-onchange-event.html fail after r124625
https://bugs.webkit.org/show_bug.cgi?id=93231
Unreviewed gardening.
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-08-06
- platform/qt-5.0-wk2/Skipped:
- 1:02 AM Changeset in webkit [124742] by
-
- 9 edits in trunk/Source/WebKit
[EFL] [GTK] Register Protocol Handler Client is never deleted
https://bugs.webkit.org/show_bug.cgi?id=92745
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-06
Reviewed by Gustavo Noronha Silva.
Added usage of OwnPtr to manage register protocol handler client pointer.
Source/WebKit/efl:
- WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp:
(WebCore::RegisterProtocolHandlerClientEfl::create): Factory function returning smart pointer.
(WebCore):
- WebCoreSupport/RegisterProtocolHandlerClientEfl.h:
(RegisterProtocolHandlerClientEfl):
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
Source/WebKit/gtk:
- WebCoreSupport/RegisterProtocolHandlerClientGtk.cpp:
(WebKit::RegisterProtocolHandlerClient::create): Factory function returning smart pointer.
(WebKit):
- WebCoreSupport/RegisterProtocolHandlerClientGtk.h:
(RegisterProtocolHandlerClient):
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
- webkit/webkitwebviewprivate.h:
- 1:00 AM Changeset in webkit [124741] by
-
- 10 edits2 adds in trunk
[WK2][GTK] Implement a new spell checker API for WebKit2GTK+
https://bugs.webkit.org/show_bug.cgi?id=90268
Reviewed by Martin Robinson.
Source/WebKit2:
Add a simple spell checking API to WK2, allowing to enable/disable
this feature and to define a list of languages associated to it.
- GNUmakefile.am: Add flags to handle the SPELLCHECK feature.
- GNUmakefile.list.am: Added new files
Added new internal class that will act both as the implementation
of TextCheckerClient and as the object WebKitWebContext will
depend on to implement the newly added API.
- UIProcess/API/gtk/WebKitTextChecker.cpp: Added.
(toTextChecker):
(continuousSpellCheckingEnabledCallback):
(setContinuousSpellCheckingEnabledCallback):
(checkSpellingOfStringCallback):
(guessesForWordCallback):
(learnWordCallback):
(ignoreWordCallback):
(WebKitTextChecker::~WebKitTextChecker):
(WebKitTextChecker::create):
(WebKitTextChecker::WebKitTextChecker):
(WebKitTextChecker::checkSpellingOfString):
(WebKitTextChecker::getGuessesForWord):
(WebKitTextChecker::learnWord):
(WebKitTextChecker::ignoreWord):
(WebKitTextChecker::setSpellCheckingEnabled):
(WebKitTextChecker::setSpellCheckingLanguages):
- UIProcess/API/gtk/WebKitTextChecker.h: Added.
(WebKitTextChecker):
(WebKitTextChecker::isSpellCheckingEnabled):
(WebKitTextChecker::getSpellCheckingLanguages):
Added WKTextChecker to WebKitPrivate.h, needed in WebKitTextChecker.
- UIProcess/API/gtk/WebKitPrivate.h:
Add new API to WebKitWebContext to allow enabling/disabling this
spell checking feature, and to set/get the list of languages used
to decide which dictionaries will be consulted.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate):
(createDefaultWebContext):
(webkit_web_context_get_spell_checking_enabled): New API.
(webkit_web_context_set_spell_checking_enabled): Ditto.
(webkit_web_context_get_spell_checking_languages): Ditto.
(webkit_web_context_set_spell_checking_languages): Ditto.
- UIProcess/API/gtk/WebKitWebContext.h:
New tests for checking the new API added to WebKitWebContext.
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextSpellChecker):
(beforeAll):
Update documentation with new sections and symbols.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
Tools:
Ignore WebKitTextChecker.* private files for gtk-doc.
- gtk/generate-gtkdoc:
(get_webkit2_options):
- 12:57 AM Changeset in webkit [124740] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, rebaseline for chromium gardening.
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06
- platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png:
- platform/chromium-mac/fast/css/text-overflow-input-expected.png:
- 12:50 AM Changeset in webkit [124739] by
-
- 3 edits2 adds in trunk
Crash in WebCore::RenderListItem::updateMarkerLocation
https://bugs.webkit.org/show_bug.cgi?id=90476
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-08-06
Reviewed by Abhishek Arya.
Source/WebCore:
In some cases an anonymous block is destroyed when its last child is
removed. RenderListItem did not expect this and has it's own logic for
cleaning up such blocks when the list marker is removed. Detect this
case in RenderBlock::removeChild to defer to the logic in RenderListItem::updateListMarker.
Test: fast/lists/list-marker-remove-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
LayoutTests:
- fast/lists/list-marker-remove-crash-expected.txt: Added.
- fast/lists/list-marker-remove-crash.html: Added.
- 12:33 AM Changeset in webkit [124738] by
-
- 2 edits in trunk/Tools
Unreviewed. Roll out r124728 because of build bot test fail.
- Scripts/webkitpy/common/config/watchlist:
- 12:27 AM Changeset in webkit [124737] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip the failing tests.
- platform/qt/Skipped:
- 12:13 AM Changeset in webkit [124736] by
-
- 20 edits in trunk/Source/WebCore
Web Inspector: NMI: replace addString with addMember overload function.
https://bugs.webkit.org/show_bug.cgi?id=93201
Reviewed by Yury Semikhatsky.
It is impossible to implement nice instrumentation for template containers
content when we have different function names for different types.
Drive by: fix the most annoing warning in Element.h detected by our clang plugin.
- css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportDescendantMemoryUsage):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
- css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
- css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
- css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::reportDescendantMemoryUsage):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::reportMemoryUsage):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
- dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/Element.h:
(WebCore::Element::reportMemoryUsage):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/MemoryInstrumentation.cpp:
(WebCore::MemoryInstrumentation::addObject):
- dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore::MemoryClassInfo::addMember):
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
Aug 5, 2012:
- 11:39 PM Changeset in webkit [124735] by
-
- 8 edits1 add in trunk/Source
[Chromium-win] Use system locale for number representation
https://bugs.webkit.org/show_bug.cgi?id=93085
Reviewed by Hajime Morita.
Source/WebCore:
We have used LocaleICU for number localization (presentation of <input
type=number>) even on Windows. This patch introduces number localization
feature with Windows API to LocaleWin, and we stop using LocaleICU on
Windows.
Tests: Add new test cases to WebKit/chromium/tests/LocaleWinTest.cpp.
- WebCore.gyp/WebCore.gyp:
- Stop using LocaleICU.{cpp,h} and LocalizedNumberICU.cpp.
- Add LocalizedNumberWin.cpp.
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::LocaleWin):
- Initialize m_didInitializeNumberData.
- Use getLocaleInfo() to obtain LOCALE_IFIRSTDAYOFWEEK.
(WebCore::LocaleWin::getLocaleInfo):
Added. A helper to obtain integer locale value.
(WebCore::LocaleWin::initializeNumberLocalizerData):
Added. Prepare data for number localization, and pass it to NumberLocalizer.
- platform/text/LocaleWin.h:
(LocaleWin): Inherit NumberLocalizer, and declare some new members.
- platform/text/win/LocalizedNumberWin.cpp: Added.
(WebCore::convertToLocalizedNumber):
Forward to the corresponding function of LocaleWin.
(WebCore::convertFromLocalizedNumber): ditto.
(WebCore::localizedDecimalSeparator): ditto.
Source/WebKit/chromium:
- WebKit.gypi:
Don't include Localized*ICUTest.cpp in Windows and OSX. They are unnecessary.
- tests/LocaleWinTest.cpp:
(LocaleWinTest): Add some LCID symbols.
(LocaleWinTest::decimalSeparator):
A helper for LocaleWinTest.decimalSeparator.
(TEST_F(LocaleWinTest, decimalSeparator)):
A test for LocaleWin::localizedDecimalSeparator(). This is a copy of the
corresponding test in LocalizedNumberICUTest.cpp.
(testNumberIsReversible):
A test helper LocaleWinTest.localizedNumberRoundTrip. This is a copy of
the corresponding test in LocalizedNumberICUTest.cpp.
(testNumbers): ditto.
(TEST_F(LocaleWinTest, localizedNumberRoundTrip)):
Tests for LocaleWin changes. This is a copy of the corresponding tests
in LocalizedNumberICUTest.cpp.
- 11:35 PM Changeset in webkit [124734] by
-
- 2 edits in trunk/LayoutTests
[chromium] form tests are flaky, mostly on Linux
https://bugs.webkit.org/show_bug.cgi?id=78620
Unreviewed. Update test expecations for
fast/forms/formaction-attribute.html
fast/forms/formmethod-attribute-button-html.html
fast/forms/formmethod-attribute-input-html.html
based on the latest dashboard.
- platform/chromium/TestExpectations:
- 11:31 PM Changeset in webkit [124733] by
-
- 4 edits2 adds in trunk
Fix assertion during detach of SVG wrappers without baseVal
https://bugs.webkit.org/show_bug.cgi?id=93063
Reviewed by Nikolas Zimmermann.
Source/WebCore:
r131583 introduced a change where SVGAnimatedListPropertyTearOff required
a baseVal to be set before detaching wrappers. This caused an assertion
to be hit if no baseVal was set.
This patch changes this behavior so that wrappers are detached even if
no baseVal is set.
Test: svg/animations/dynamic-modify-transform-without-baseval.html
- svg/properties/SVGAnimatedListPropertyTearOff.h:
(WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers):
- svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::detachListWrappersAndResize): Extracted this static method for detaching wrappers without needing an SVGListProperty.
(SVGListProperty):
(WebCore::SVGListProperty::detachListWrappers):
LayoutTests:
- svg/animations/dynamic-modify-transform-without-baseval-expected.txt: Added.
- svg/animations/dynamic-modify-transform-without-baseval.html: Added.
- 11:09 PM Changeset in webkit [124732] by
-
- 2 edits in trunk/Source/WebCore
Remove DeviceMotionEvent.h and DeviceOrientationEvent.h from Document.cpp
https://bugs.webkit.org/show_bug.cgi?id=93224
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-05
Reviewed by Kentaro Hara.
Need to remove DeviceMotionEvent.h and DeviceOrientationEvent.h from Document.cpp.
They are not used anymore in that file.
No new tests. No change in behavior.
- dom/Document.cpp:
- 10:10 PM Changeset in webkit [124731] by
-
- 2 edits1 add in trunk/LayoutTests
[chromium] fast/forms/focus2.html fails
https://bugs.webkit.org/show_bug.cgi?id=45061
Unreviewed. Chromium DRT sets tabsToLink to false. So, Chrimium DRT doesn't set focus to anchor.
- platform/chromium/TestExpectations: Removed fast/forms/focus2.html
- platform/chromium/fast/forms/focus2-expected.txt: Added.
- 8:27 PM Changeset in webkit [124730] by
-
- 2 edits in trunk/Source/WebCore
[CMAKE] Move media source files from #ifdef ENABLE(MEDIA_SOURCE) to existing file list
https://bugs.webkit.org/show_bug.cgi?id=93219
Reviewed by Hajime Morita.
r122688 removed duplicating #ifdef guards from CMakeLists.txt. But, ENABLE_MEDIA_SOURCE is added to
CMakeList using duplicating #ifdef again.
No new tests. No change in behavior.
- CMakeLists.txt:
- 8:16 PM Changeset in webkit [124729] by
-
- 31 edits in trunk/Source
Web Inspector: [JSC] implement setting breakpoints by line:column
https://bugs.webkit.org/show_bug.cgi?id=53003
Source/JavaScriptCore:
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-05
Reviewed by Geoffrey Garen.
Add a counter to Lexer to record the column info of each Token. Add a column parameter to
op_debug, cti_op_debug, and _llint_op_debug byte-code command.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::emitDebugHook):
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
- debugger/Debugger.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::debug):
(JSC::Interpreter::privateExecute):
- interpreter/Interpreter.h:
(Interpreter):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_debug):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_debug):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- parser/ASTBuilder.h:
(ASTBuilder):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::appendBinaryOperation):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
- parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):
- parser/Lexer.h:
(Lexer):
(JSC::Lexer::currentColumnNumber):
(JSC::::lexExpectIdentifier):
- parser/NodeConstructors.h:
(JSC::Node::Node):
(JSC::ExpressionNode::ExpressionNode):
(JSC::StatementNode::StatementNode):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::RegExpNode::RegExpNode):
(JSC::ThisNode::ThisNode):
(JSC::ResolveNode::ResolveNode):
(JSC::ArrayNode::ArrayNode):
(JSC::PropertyListNode::PropertyListNode):
(JSC::ObjectLiteralNode::ObjectLiteralNode):
(JSC::BracketAccessorNode::BracketAccessorNode):
(JSC::DotAccessorNode::DotAccessorNode):
(JSC::ArgumentListNode::ArgumentListNode):
(JSC::NewExprNode::NewExprNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PrePostResolveNode::PrePostResolveNode):
(JSC::PostfixResolveNode::PostfixResolveNode):
(JSC::PostfixBracketNode::PostfixBracketNode):
(JSC::PostfixDotNode::PostfixDotNode):
(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::DeleteValueNode::DeleteValueNode):
(JSC::VoidNode::VoidNode):
(JSC::TypeOfResolveNode::TypeOfResolveNode):
(JSC::TypeOfValueNode::TypeOfValueNode):
(JSC::PrefixResolveNode::PrefixResolveNode):
(JSC::PrefixBracketNode::PrefixBracketNode):
(JSC::PrefixDotNode::PrefixDotNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::UnaryOpNode::UnaryOpNode):
(JSC::UnaryPlusNode::UnaryPlusNode):
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::LogicalNotNode::LogicalNotNode):
(JSC::BinaryOpNode::BinaryOpNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::AddNode::AddNode):
(JSC::SubNode::SubNode):
(JSC::LeftShiftNode::LeftShiftNode):
(JSC::RightShiftNode::RightShiftNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
(JSC::LessNode::LessNode):
(JSC::GreaterNode::GreaterNode):
(JSC::LessEqNode::LessEqNode):
(JSC::GreaterEqNode::GreaterEqNode):
(JSC::ThrowableBinaryOpNode::ThrowableBinaryOpNode):
(JSC::InstanceOfNode::InstanceOfNode):
(JSC::InNode::InNode):
(JSC::EqualNode::EqualNode):
(JSC::NotEqualNode::NotEqualNode):
(JSC::StrictEqualNode::StrictEqualNode):
(JSC::NotStrictEqualNode::NotStrictEqualNode):
(JSC::BitAndNode::BitAndNode):
(JSC::BitOrNode::BitOrNode):
(JSC::BitXOrNode::BitXOrNode):
(JSC::LogicalOpNode::LogicalOpNode):
(JSC::ConditionalNode::ConditionalNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::CommaNode::CommaNode):
(JSC::ConstStatementNode::ConstStatementNode):
(JSC::EmptyStatementNode::EmptyStatementNode):
(JSC::DebuggerStatementNode::DebuggerStatementNode):
(JSC::ExprStatementNode::ExprStatementNode):
(JSC::VarStatementNode::VarStatementNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):
(JSC::DoWhileNode::DoWhileNode):
(JSC::WhileNode::WhileNode):
(JSC::ForNode::ForNode):
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ReturnNode::ReturnNode):
(JSC::WithNode::WithNode):
(JSC::LabelNode::LabelNode):
(JSC::ThrowNode::ThrowNode):
(JSC::TryNode::TryNode):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
(JSC::SwitchNode::SwitchNode):
(JSC::ConstDeclNode::ConstDeclNode):
(JSC::BlockNode::BlockNode):
(JSC::ForInNode::ForInNode):
- parser/Nodes.cpp:
(JSC::StatementNode::setLoc):
(JSC):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
- parser/Nodes.h:
(Node):
(JSC::Node::columnNo):
(ExpressionNode):
(StatementNode):
(JSC::StatementNode::column):
(NullNode):
(BooleanNode):
(NumberNode):
(StringNode):
(RegExpNode):
(ThisNode):
(ResolveNode):
(ArrayNode):
(PropertyListNode):
(ObjectLiteralNode):
(BracketAccessorNode):
(DotAccessorNode):
(ArgumentListNode):
(NewExprNode):
(EvalFunctionCallNode):
(FunctionCallValueNode):
(FunctionCallResolveNode):
(FunctionCallBracketNode):
(FunctionCallDotNode):
(CallFunctionCallDotNode):
(ApplyFunctionCallDotNode):
(PrePostResolveNode):
(PostfixResolveNode):
(PostfixBracketNode):
(PostfixDotNode):
(PostfixErrorNode):
(DeleteResolveNode):
(DeleteBracketNode):
(DeleteDotNode):
(DeleteValueNode):
(VoidNode):
(TypeOfResolveNode):
(TypeOfValueNode):
(PrefixResolveNode):
(PrefixBracketNode):
(PrefixDotNode):
(PrefixErrorNode):
(UnaryOpNode):
(UnaryPlusNode):
(NegateNode):
(BitwiseNotNode):
(LogicalNotNode):
(BinaryOpNode):
(MultNode):
(DivNode):
(ModNode):
(AddNode):
(SubNode):
(LeftShiftNode):
(RightShiftNode):
(UnsignedRightShiftNode):
(LessNode):
(GreaterNode):
(LessEqNode):
(GreaterEqNode):
(ThrowableBinaryOpNode):
(InstanceOfNode):
(InNode):
(EqualNode):
(NotEqualNode):
(StrictEqualNode):
(NotStrictEqualNode):
(BitAndNode):
(BitOrNode):
(BitXOrNode):
(LogicalOpNode):
(ConditionalNode):
(ReadModifyResolveNode):
(AssignResolveNode):
(ReadModifyBracketNode):
(AssignBracketNode):
(AssignDotNode):
(ReadModifyDotNode):
(AssignErrorNode):
(CommaNode):
(ConstDeclNode):
(ConstStatementNode):
(BlockNode):
(EmptyStatementNode):
(DebuggerStatementNode):
(ExprStatementNode):
(VarStatementNode):
(IfNode):
(IfElseNode):
(DoWhileNode):
(WhileNode):
(ForNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ReturnNode):
(WithNode):
(LabelNode):
(ThrowNode):
(TryNode):
(ScopeNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
(FuncExprNode):
(FuncDeclNode):
(SwitchNode):
- parser/Parser.cpp:
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):
- parser/Parser.h:
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenEnd):
(JSC::Parser::tokenLocation):
(Parser):
(JSC::Parser::getTokenName):
(JSC::::parse):
- parser/ParserTokens.h:
(JSC::JSTokenLocation::JSTokenLocation):
(JSTokenLocation):
(JSToken):
- parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::closeBraceToken):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::createCommaExpr):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeTypeOfNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::makeNegateNode):
(JSC::SyntaxChecker::makeBitwiseNotNode):
(JSC::SyntaxChecker::createLogicalNot):
(JSC::SyntaxChecker::createUnaryPlus):
(JSC::SyntaxChecker::createVoid):
(JSC::SyntaxChecker::thisExpr):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createObjectLiteral):
(JSC::SyntaxChecker::createArray):
(JSC::SyntaxChecker::createNumberExpr):
(JSC::SyntaxChecker::createString):
(JSC::SyntaxChecker::createBoolean):
(JSC::SyntaxChecker::createNull):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createConditionalExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):
Source/WebCore:
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-05
Reviewed by Geoffrey Garen.
Since JSC can provide column info now, ScriptDebugServer can use it to support "Pretty Print"
debug mode. The related interfaces derived from JSC::Debugger was added a parameter.
No new tests for this patch.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore):
(WebCore::ScriptDebugServer::updateCurrentStatementPosition):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):
- bindings/js/ScriptDebugServer.h:
(ScriptDebugServer):
Source/WebKit/mac:
Unreviewed, just changed the interface according the changes of base class JSC::Debugger.
No JSC can provide the column info of current JS statement, mac porting can use it to support
"Pretty Print" debug mode.
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-05
- WebView/WebScriptDebugger.h:
(WebScriptDebugger):
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::callEvent):
(WebScriptDebugger::atStatement):
(WebScriptDebugger::returnEvent):
(WebScriptDebugger::exception):
(WebScriptDebugger::willExecuteProgram):
(WebScriptDebugger::didExecuteProgram):
(WebScriptDebugger::didReachBreakpoint):
- 7:45 PM Changeset in webkit [124728] by
-
- 2 edits in trunk/Tools
Unreviewed. Change my email address for watch list.
- Scripts/webkitpy/common/config/watchlist:
- 7:40 PM Changeset in webkit [124727] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectation updates.
- platform/chromium/TestExpectations: assign bug for fast/text/international/bold-bengali.html
- 7:35 PM Changeset in webkit [124726] by
-
- 2 edits in trunk/LayoutTests
Enable fast/css/variables tests by default for chromium.
https://bugs.webkit.org/show_bug.cgi?id=92610
Reviewed by Tony Chang.
Since variables are now compiled in by default on chromium there is no reason not to run these tests.
- platform/chromium/TestExpectations:
- 6:50 PM Changeset in webkit [124725] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Marked the following test cases as known failures
tracked by the bug 93213, 93214, 92956, 93212.
fast/text/international/text-spliced-font.html
http/tests/loading/307-after-303-after-post.html
http/tests/security/contentSecurityPolicy/object-src-url-blocked.html
http/tests/incremental/slow-utf8-text.pl
- platform/efl/TestExpectations:
- 6:36 PM Changeset in webkit [124724] by
-
- 4 edits4 adds in trunk
Assert in checkValidity() in hashtable.h from WebGeolocationManager::didFailToDeterminePosition() when fetching http://html5demos.com/geo
https://bugs.webkit.org/show_bug.cgi?id=80386
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-05
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
WebKit2's WebGeolocationManager was delivering events without accounting that each event
can modify the list of page that need delivery.
Any page can remove itself by invoking clearWatch() from the callback function. A page can also cause another
page to be removed.
This patch solves the issue by taking a copy of the list of page before delivery. Each page is
referenced as it can be deleted during the delivery.
Unfortunately, this cannot be tested due to missing features of WebKitTestRunner.
- WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):
LayoutTests:
Add tests for clearing the Geolocation as a listener from a callback originated from the GeolocationController.
- fast/dom/Geolocation/error-clear-watch-expected.txt: Added.
- fast/dom/Geolocation/error-clear-watch.html: Added.
- fast/dom/Geolocation/success-clear-watch-expected.txt: Added.
- fast/dom/Geolocation/success-clear-watch.html: Added.
- platform/wk2/Skipped:
- 6:22 PM Changeset in webkit [124723] by
-
- 3 edits2 adds in trunk
Fix null pointer dereference when CSSParser::sinkFloatingValueList() returns null and is passed to storeVariableDeclaration().
https://bugs.webkit.org/show_bug.cgi?id=92461
Reviewed by Eric Seidel.
Source/WebCore:
Invalid variable lists could cause CSSGrammar.y to pass null as value to storeVariableDeclaration, so we now check for null.
Test: fast/css/variables/invalid-value-list-crash.html
- css/CSSParser.cpp:
(WebCore::CSSParser::storeVariableDeclaration):
LayoutTests:
Test case that causes CSSParser::storeVariableDeclaration to be passed a null value.
- fast/css/variables/invalid-value-list-crash-expected.txt: Added.
- fast/css/variables/invalid-value-list-crash.html: Added.
- 6:19 PM Changeset in webkit [124722] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Updte text expectation.
Remove an entry for media/media-fragments/TC0010-TC0019.html.
It doesn't exist any more.
- platform/chromium/TestExpectations:
- 6:12 PM Changeset in webkit [124721] by
-
- 2 edits in trunk/Source/WebCore
[Chromium-win] Use the default locale only if the browser locale matches to it
https://bugs.webkit.org/show_bug.cgi?id=93083
Reviewed by Hajime Morita.
For a calendar picker, we have used month names and day-of-week names
obtained from the OS default locale. However, the year-month format and
[Today] [Clear] labels are decided with the browser locale. It made
calendar pickers with mixed languages.
To make calendar pickers with a single language, we use the OS default
locale only if the browser locale matches to it.
This patch changes the behavior for Windows Vista or later. No change
for Windows XP because of API support limitation.
No new tests. Behavior for locale setting is not testable in WebKit.
- platform/text/LocaleWin.cpp:
(determineCurrentLCID):
Added. If the system has no LocaleNameToLCID API, just returns
LOCALE_USER_DEFAULT. Otherwise, if the system locale matches to the
browser locale, it returns LOCALE_USER_DEFAULT, otherwise it returns the
LCID for the browser locale.
(WebCore::LocaleWin::currentLocale): Uses determineCurrentLCID().
- 6:09 PM FeatureFlags edited by
- ANIMATION_API (diff)
- 2:03 PM Changeset in webkit [124720] by
-
- 19 edits in trunk/Source/WebCore
Don't reuse cached stylesheet with failed or canceled resource loads
https://bugs.webkit.org/show_bug.cgi?id=93203
Reviewed by Simon Fraser.
1) Go to apple.com
2) Reload repeatedly
Eventually you can get into state where some images don't load.
The problem is that a cached stylesheet may end up pointing to image resources that have been canceled (by the reload).
If this happens they stay in the canceled state even when the stylesheet is applied to a new document.
Fix by checking if all loads are complete (or pending) when restoring a cached stylesheet. The sheet is only used
if there are no failed or canceled loads. There are potential more sophisticated fixes but this is simple and safe.
Walking the sheet is fast and since it is only done on cache restore the cost is minimal.
No regression test yet though the new code does get exercised by the existing tests.
- css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::hasFailedOrCanceledSubresources):
(WebCore):
- css/CSSCrossfadeValue.h:
(CSSCrossfadeValue):
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::hasFailedOrCanceledSubresources):
(WebCore):
- css/CSSFontFaceSrcValue.h:
(CSSFontFaceSrcValue):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::hasFailedOrCanceledSubresources):
(WebCore):
- css/CSSImageSetValue.h:
(CSSImageSetValue):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::hasFailedOrCanceledSubresources):
(WebCore):
- css/CSSImageValue.h:
(CSSImageValue):
- css/CSSValue.cpp:
(WebCore::CSSValue::hasFailedOrCanceledSubresources):
(WebCore):
- css/CSSValue.h:
(CSSValue):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::hasFailedOrCanceledSubresources):
(WebCore):
- css/CSSValueList.h:
(CSSValueList):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::hasFailedOrCanceledSubresources):
(WebCore):
- css/StylePropertySet.h:
(StylePropertySet):
- css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):
(WebCore):
(WebCore::StyleSheetContents::hasFailedOrCanceledSubresources):
- css/StyleSheetContents.h:
(StyleSheetContents):
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::loadFailedOrCanceled):
- 1:55 PM Changeset in webkit [124719] by
-
- 3 edits in trunk/Source/WebKit/win
[WIN] Use sizeof() for cbWndExtra values
https://bugs.webkit.org/show_bug.cgi?id=93179
Reviewed by Eric Carlson.
Using sizof() instead of hardcoding the pointer size of
the 32bit platform allows us to use the code on 64bit too.
- FullscreenVideoController.cpp:
(FullscreenVideoController::registerHUDWindowClass):
- WebView.cpp:
(WebView::registerWebViewWindowClass):
- 11:40 AM Changeset in webkit [124718] by
-
- 5 edits in trunk/Source/WebCore
[V8] Move V8Proxy methods that set DOM attributes/callbacks to V8Binding
https://bugs.webkit.org/show_bug.cgi?id=93103
Reviewed by Adam Barth.
To remove V8Proxy, we can move V8Proxy methods that set DOM
attributes/callbacks to V8Binding.
No tests. No change in behavior.
- bindings/v8/V8Binding.cpp:
(WebCore::batchConfigureAttributes):
(WebCore):
(WebCore::batchConfigureCallbacks):
(WebCore::batchConfigureConstants):
- bindings/v8/V8Binding.h:
(BatchedAttribute):
(WebCore):
(WebCore::configureAttribute):
(BatchedConstant):
(BatchedCallback):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(WebCore):
- 9:28 AM Changeset in webkit [124717] by
-
- 5 edits in trunk/LayoutTests
media/video-poster-blocked-by-willsendrequest.html isn't blocking poster on willsendrequest
https://bugs.webkit.org/show_bug.cgi?id=92824
Reviewed by Ryosuke Niwa.
Chromium/Mac/GTK DRTs appear not to clear the cache between tests so append a unique query-string param to avoid a cache hit in this test.
Filed 93195 for the chromium port, Mac has 82976, and GTK has 79760.
- media/video-poster-blocked-by-willsendrequest.html:
- platform/chromium/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/Skipped:
- 8:39 AM Changeset in webkit [124716] by
-
- 3 edits in trunk/Source/WebCore
[V8] Remove V8Proxy::registerExtensionWithV8()
https://bugs.webkit.org/show_bug.cgi?id=93115
Reviewed by Adam Barth.
V8Proxy::registerExtensionWithV8() is used by V8Proxy::registerExtension()
only. We can remove the redundant method.
In a follow-up patch, I will implement V8Proxy::registerExtentionIfNeeded()
and remove registerExtensionWithV8() and registerExtension().
No tests. No change in behavior.
- bindings/v8/V8Proxy.cpp:
(WebCore::staticExtensionsList): Just moved to near related methods.
(WebCore):
(WebCore::V8Proxy::extensions):
(WebCore::V8Proxy::registerExtension):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 8:37 AM CoordinatedGraphicsSystem edited by
- (diff)
- 8:37 AM Changeset in webkit [124715] by
-
- 3 edits in trunk/Source/WebCore
[V8] Remove unused enum and typedefs in V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93105
Reviewed by Adam Barth.
In preparation for removing V8Proxy, we can remove unused enum
and typedefs in V8Proxy.
No tests. No change in behavior.
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(WebCore::throwError):
