Context Navigation

← Previous Period
Next Period →

Timeline

Aug 23, 2012:

11:43 PM Changeset in webkit [126548] by commit-queue@webkit.org

5 edits in trunk/Source

Unreviewed, rolling out r126542.
http://trac.webkit.org/changeset/126542
https://bugs.webkit.org/show_bug.cgi?id=94907

Broke WK2 build on OS X (Requested by tronical_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-23

Source/WebCore:

inspector/CodeGeneratorInspector.py:

(EnumConstants.get_enum_constant_code):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(Generator.go):
(Generator.process_event):
(Generator.process_command):

Source/WebKit2:

Scripts/webkit2/messages.py:
Scripts/webkit2/parser.py:

11:41 PM Changeset in webkit [126547] by haraken@chromium.org

3 edits in trunk/Source/WebCore

[V8] StringCache should not return already disposed strings
https://bugs.webkit.org/show_bug.cgi?id=94899

Reviewed by Adam Barth.

See this Chromium bug (http://code.google.com/p/chromium/issues/detail?id=143937)
for details.

I investigated the crash and found that v8ExternalString() can return
already disposed strings:

class StringCache {

v8::Local<v8::String> v8ExternalString(StringImpl* stringImpl, ...)
{

if (m_lastStringImpl.get() == stringImpl) {

ASSERT(!m_lastV8String.IsNearDeath());
ASSERT(!m_lastV8String.IsEmpty());
return v8::Local<v8::String>::New(m_lastV8String); m_lastV8String might be already disposed.

}
return v8ExternalStringSlow(stringImpl, ...);

}

}

I couldn't find why m_lastV8String can be prematurely disposed, but the
following fix solves the crash:

class StringCache {

v8::Local<v8::String> v8ExternalString(StringImpl* stringImpl, ...)
{

if (m_lastStringImpl.get() == stringImpl && m_lastV8String.IsWeak())

return v8::Local<v8::String>::New(m_lastV8String);

return v8ExternalStringSlow(stringImpl, ...);

}

}

Although the ideal fix might be to fix the root cause of the premature disposal,
I think that the proposed fix is reasonable for safety. In fact, we've so far
encountered crashes caused by premature disposals (e.g. r123500). The proposed fix
will prevent future crashes caused by premature disposals.

No tests. The crash depends on GC behavior and I couldn't write a test that
reproduces the crash. Open http://lore.com/testdrive/Navigating-the-Universe
and confirm that Chromium doesn't crash.

bindings/v8/V8ValueCache.cpp:

(WebCore::StringCache::v8ExternalStringSlow):

bindings/v8/V8ValueCache.h:

(WebCore::StringCache::v8ExternalString):

11:26 PM Changeset in webkit [126546] by pfeldman@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: move ResourceViews to "components" module - it is used from the Resources as well.
https://bugs.webkit.org/show_bug.cgi?id=94904

Reviewed by Vsevolod Vlasov.

WebCore.gypi:
inspector/compile-front-end.py:
inspector/front-end/NetworkPanel.js:
inspector/front-end/inspector.html:

11:10 PM Changeset in webkit [126545] by yosin@chromium.org

2 edits in trunk/LayoutTests

[Chromium] REGRESSION(r126534) time-multiple-fields-appearance-pseudo-elements.html failing on Win7
https://bugs.webkit.org/show_bug.cgi?id=94898

This patch changes parameters to test expectation generator to make
actual result and test expectation to be matched.

Root cause of this regression is the test expectation generator for
Chromium-Win generates second field with value "56" instead of "00".

On Chromium-Linux and Chromium-Mac, the test expectation generator
doesn't generate second field.

fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Changes parameters to have hour and minute only.

10:59 PM Changeset in webkit [126544] by abarth@webkit.org

4 edits in trunk/Source/WebCore

[V8] V8DOMWindowShell should use ScopedPersistent
https://bugs.webkit.org/show_bug.cgi?id=94882

Reviewed by Kentaro Hara.

This patch updates V8DOMWindowShell to use ScopedPersistent rather than
manually managing v8::Persistent handles. I've also fixed some style
issues in code I needed to edit for this patch. This class could use
more touchup, but I'm going to hold off until the next patch.

bindings/v8/ScopedPersistent.h:

(WebCore::ScopedPersistent::adopt):
(ScopedPersistent):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::initializeV8IfNeeded):
(WebCore):
(WebCore::V8DOMWindowShell::isContextInitialized):
(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::destroyGlobal):
(WebCore::V8DOMWindowShell::clearForClose):
(WebCore::V8DOMWindowShell::clearForNavigation):
(WebCore::V8DOMWindowShell::initContextIfNeeded):
(WebCore::V8DOMWindowShell::setContext):
(WebCore::V8DOMWindowShell::updateDocumentWrapper):
(WebCore::V8DOMWindowShell::clearDocumentWrapper):
(WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
(WebCore::V8DOMWindowShell::clearDocumentWrapperCache):
(WebCore::V8DOMWindowShell::setSecurityToken):
(WebCore::V8DOMWindowShell::updateDocument):
(WebCore::getter):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):
(WebCore::V8DOMWindowShell::updateSecurityOrigin):

bindings/v8/V8DOMWindowShell.h:

(WebCore::V8DOMWindowShell::context):
(V8DOMWindowShell):

10:49 PM Changeset in webkit [126543] by commit-queue@webkit.org

11 edits
2 deletes in trunk

Unreviewed, rolling out r126496.
http://trac.webkit.org/changeset/126496
https://bugs.webkit.org/show_bug.cgi?id=94895

Broke TestNotificationActiveDescendantChanged (Requested by
dominicc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-23

Source/WebCore:

accessibility/AccessibilityNodeObject.cpp:
accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

accessibility/AccessibilityObject.cpp:
accessibility/AccessibilityObject.h:

(AccessibilityObject):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isDescendantOfElementType):

accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

LayoutTests:

accessibility/editable-webarea-context-menu-point.html:
accessibility/focusable-div-expected.txt: Removed.
accessibility/focusable-div.html: Removed.
accessibility/table-detection.html:
platform/mac/accessibility/listbox-hit-test.html:

10:28 PM Changeset in webkit [126542] by Simon Hausmann

5 edits in trunk/Source

Make it possible to build WebKit with Python 3 (and 2)
https://bugs.webkit.org/show_bug.cgi?id=94814

Source/WebCore:

Exceptions need a hack to work with both.
string.join was already deprecated in Python 2.
Relative imports are no longer supported, use package name instead.

Patch by Frederik Gladhorn <gladhorn@kde.org> on 2012-08-23
Reviewed by Ryosuke Niwa.

inspector/CodeGeneratorInspector.py:

Source/WebKit2:

Patch by Frederik Gladhorn <gladhorn@kde.org> on 2012-08-23
Reviewed by Ryosuke Niwa.

Exceptions need a hack to work with both.
string.join was already deprecated in Python 2.
Relative imports are no longer supported, use package name instead.

Scripts/webkit2/messages.py:
Scripts/webkit2/parser.py:

10:28 PM Changeset in webkit [126541] by commit-queue@webkit.org

2 edits
20 deletes in trunk/LayoutTests

[EFL] Skip the tests which have wrong pixel expectations in fast/forms/
https://bugs.webkit.org/show_bug.cgi?id=94798

Unreviewed. Some tests in fast/forms seem to fail. Removed wrong expectations
and marked the tests MISSING.

fast/forms/listbox-hit-test-zoomed.html
Test 2 in this test seems to fail.

fast/forms/menulist-restrict-line-height.html
The text in the popup button is clipped.

fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-rtl.html
Cancel mark in search field is not displayed.

fast/forms/menulist-narrow-width.html
fast/forms/select-baseline.html
fast/forms/menulist-style-color.html
fast/forms/select-style.html
These tests seem to have style error.

fast/forms/textarea-scroll-height.html
fast/forms/textarea-scrolled-type.html
Scroll bar isn't being fully rendered.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-23

platform/efl/TestExpectations:
platform/efl/fast/forms/listbox-hit-test-zoomed-expected.png: Removed.
platform/efl/fast/forms/listbox-hit-test-zoomed-expected.txt: Removed.
platform/efl/fast/forms/menulist-narrow-width-expected.png: Removed.
platform/efl/fast/forms/menulist-narrow-width-expected.txt: Removed.
platform/efl/fast/forms/menulist-restrict-line-height-expected.png: Removed.
platform/efl/fast/forms/menulist-restrict-line-height-expected.txt: Removed.
platform/efl/fast/forms/menulist-style-color-expected.png: Removed.
platform/efl/fast/forms/menulist-style-color-expected.txt: Removed.
platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png: Removed.
platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt: Removed.
platform/efl/fast/forms/search-rtl-expected.png: Removed.
platform/efl/fast/forms/search-rtl-expected.txt: Removed.
platform/efl/fast/forms/select-baseline-expected.png: Removed.
platform/efl/fast/forms/select-baseline-expected.txt: Removed.
platform/efl/fast/forms/select-style-expected.png: Removed.
platform/efl/fast/forms/select-style-expected.txt: Removed.
platform/efl/fast/forms/textarea-scroll-height-expected.png: Removed.
platform/efl/fast/forms/textarea-scroll-height-expected.txt: Removed.
platform/efl/fast/forms/textarea-scrolled-type-expected.png: Removed.
platform/efl/fast/forms/textarea-scrolled-type-expected.txt: Removed.

10:00 PM Changeset in webkit [126540] by piman@chromium.org

5 edits in trunk/Source

[chromium] Fix lost context when textures are evicted
https://bugs.webkit.org/show_bug.cgi?id=94892

Reviewed by James Robinson.

After eviction, the CCPrioritizedTextureManager is in a limbo state
where all its resources are invalid. If we try to release them we will
double-destroy them.

New test: CCLayerTreeHostTestLostContextAfterEvictTextures.

Source/WebCore:

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTestLostContextAfterEvictTextures):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::CCLayerTreeHostTestLostContextAfterEvictTextures):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::beginTest):
(EvictTexturesAndLoseContextTask):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::EvictTexturesAndLoseContextTask):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::~EvictTexturesAndLoseContextTask):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::run):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::postEvictTexturesAndLoseContext):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didRecreateOutputSurface):
(WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::afterTest):
(WTF):
(WTF::TEST_F):

9:55 PM Changeset in webkit [126539] by keishi@webkit.org

5 edits in trunk

REGRESSION(r126132): thumb doesn't match click position for rtl input type=range
https://bugs.webkit.org/show_bug.cgi?id=94890

Reviewed by Kent Tamura.

Source/WebCore:

r126132 broke rtl input type=range so the thumb doesn't match click position.

Added new tests to range-hit-test-with-padding.html.

html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

LayoutTests:

fast/forms/range/range-hit-test-with-padding-expected.txt:
fast/forms/range/range-hit-test-with-padding.html:

9:50 PM Changeset in webkit [126538] by dominicc@chromium.org

3 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaseline meter element tests on Mac. These grew a DIV in
r125659.
https://bugs.webkit.org/show_bug.cgi?id=94666

platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

9:46 PM Changeset in webkit [126537] by piman@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Add OVERRIDEs in test code
https://bugs.webkit.org/show_bug.cgi?id=94894

Reviewed by James Robinson.

tests/CCLayerTreeHostTest.cpp:

9:38 PM Changeset in webkit [126536] by dominicc@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Revert a few test expectations tightened in r126529 to green
builders.

These differ by whether zero width blocks appear in the dumped
render tree.

platform/chromium/TestExpectations:

9:31 PM Changeset in webkit [126535] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Add OVERRIDE and deinline virtual getters on *PlatformGestureCurve
https://bugs.webkit.org/show_bug.cgi?id=94887

Patch by James Robinson <jamesr@chromium.org> on 2012-08-23
Reviewed by Dirk Pranke.

This makes clang happy. Clang makes me happy. By induction, this makes me happy.

platform/TouchpadFlingPlatformGestureCurve.cpp:

(WebCore::TouchpadFlingPlatformGestureCurve::debugName):
(WebCore):

platform/TouchpadFlingPlatformGestureCurve.h:

(TouchpadFlingPlatformGestureCurve):

platform/WheelFlingPlatformGestureCurve.cpp:

(WebCore::WheelFlingPlatformGestureCurve::debugName):
(WebCore):

platform/WheelFlingPlatformGestureCurve.h:

(WheelFlingPlatformGestureCurve):

9:23 PM Changeset in webkit [126534] by yosin@chromium.org

15 edits
2 adds in trunk

[Forms] Step mismatched value should be editable in multiple field time UI.
https://bugs.webkit.org/show_bug.cgi?id=94664

Reviewed by Kent Tamura.

Source/WebCore:

This patch changes layout method of multiple field time input UI to
check value of the "input" element in addition to step and range to
allow users to change step mismatched value from UI.

Tests: fast/forms/time-multiple-fields/time-multiple-fields-change-layout-by-value.html: for changing layout by value change.
This patch also adds new test case into fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html.

html/TimeInputType.cpp:

(WebCore::TimeInputType::createShadowSubtree): Changed for DateTimeEditElement::create signature change.
(WebCore::TimeInputType::minOrMaxAttributeChanged): Changed to call updateInnerTextValue instead of removed updateEditElementLayout()
(WebCore::TimeInputType::stepAttributeChanged): ditto.
(WebCore::TimeInputType::updateInnerTextValue): Changed for DateTimeEditElement::setValueAsDate() and setEmptyValue() signature change.

html/TimeInputType.h:

(TimeInputType): Removed updateEditElementLayout() declaration.

html/shadow/DateTimeEditElement.cpp:

(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Added a new parameter date value to constructor to use it for layout decision.
(WebCore::DateTimeEditBuilder::needMillisecondField): Changed to check date value too.
(WebCore::DateTimeEditBuilder::needMinuteField): ditto
(WebCore::DateTimeEditBuilder::needSecondField): ditto
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldReadOnly): ditto
(WebCore::DateTimeEditBuilder::shouldMinuteFieldReadOnly): ditto
(WebCore::DateTimeEditBuilder::shouldSecondFieldReadOnly): ditto
(WebCore::DateTimeEditElement::create): Changed for removing stepRange parameter.
(WebCore::DateTimeEditElement::layout): Changed to keep focus field for new layout.
(WebCore::DateTimeEditElement::setValueAsDate): Changed to call layout() with StepRange and date value.
(WebCore::DateTimeEditElement::setEmptyValue): ditto

html/shadow/DateTimeEditElement.h:

(DateTimeEditElement):

LayoutTests:

This patch adds new test case for step mismatched value case and
updates test cases to avoid step mismatched value, and a test file
for dynamic layout change casued by input element's value change.

Note: We need to do rebaseline for Chromium-Mac and Chromium-Win.

fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.html: Updated for new test case and behavior change.
fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: ditto
fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Updated for behavior change.
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: ditto
fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: ditto
fast/forms/time-multiple-fields/time-multiple-fields-change-layout-by-value-expected.txt: Added.
fast/forms/time-multiple-fields/time-multiple-fields-change-layout-by-value.html: Added for dynamic layout change from value change.
platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: ditto
platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: ditto
platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: ditto
platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: ditto

9:03 PM Changeset in webkit [126533] by dpranke@chromium.org

3 edits in trunk/Tools

leak detection broken after r126247 on mac
https://bugs.webkit.org/show_bug.cgi?id=94893

Unreviewed, build fix.

Adds is_snowleopard(), is_lion back() in for the mac port. We'll
probably need an is_mountainlion() or equivalent at some point,
I'm guessing (but I've deleted the leopard code).

Scripts/webkitpy/layout_tests/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):

Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort):
(MacPort.is_snowleopard):
(MacPort.is_lion):

8:40 PM Changeset in webkit [126532] by mrowe@apple.com

4 edits in trunk/Source

Versioning.

8:37 PM Changeset in webkit [126531] by mrowe@apple.com

1 copy in tags/Safari-537.7

New tag.

8:03 PM Changeset in webkit [126530] by jchaffraix@webkit.org

4 edits in trunk

[Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
https://bugs.webkit.org/show_bug.cgi?id=94871

Reviewed by Benjamin Poulain.

Source/WTF:

wtf/PassRefPtr.h:

We need to include Assertions.h due to the COMPILE_ASSERT added in r89283.
This matches other files in WTF though I am not sure why Chromium is the only
platform complaining about that.

Tools:

TestWebKitAPI/TestWebKitAPI.gypi:

Added the missing files to Chromium's build system.

8:01 PM Changeset in webkit [126529] by kbr@google.com

2 edits in trunk/LayoutTests

[Chromium] LayoutTests: css3/selector3/xml tests are flaky / have wrong expectations on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=82122

Unreviewed Chromium gardening. Tightened majority of test
expectations to only expect failures on debug bots.

platform/chromium/TestExpectations:

7:59 PM Changeset in webkit [126528] by rakuco@webkit.org

2 edits in trunk/Tools

[watchlist] Unreviewed, subscribe to WebKit2-EFL bugs.

Scripts/webkitpy/common/config/watchlist:

7:45 PM Changeset in webkit [126527] by ryuan.choi@samsung.com

3 edits in trunk/Source/WebKit/efl

[EFL] Remove ewk_tile_matrix_tile_update.
https://bugs.webkit.org/show_bug.cgi?id=63437

Reviewed by Gyuyoung Kim.

ewk/ewk_tiled_matrix.cpp:

Removed ewk_tile_matrix_tile_update and ewk_tile_matrix_tile_update_full
which are dead code.

ewk/ewk_tiled_matrix_private.h: Ditto.

7:28 PM Changeset in webkit [126526] by ggaren@apple.com

4 edits
5 deletes in trunk/Source/JavaScriptCore

Unreviewed, rolling out r126505.
http://trac.webkit.org/changeset/126505
https://bugs.webkit.org/show_bug.cgi?id=94840

Caused testapi to crash on launch

DerivedSources.make:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

bytecode/OpcodeDefinitions.h: Removed.
bytecode/opcodes: Removed.
opcode_definition_generator.py: Removed.
opcode_generator.py: Removed.
opcode_parser.py: Removed.

6:53 PM Changeset in webkit [126525] by shinyak@chromium.org

9 edits in trunk/LayoutTests

Needs update tests of Shadow DOM for keygen
https://bugs.webkit.org/show_bug.cgi?id=94765

Reviewed by Dimitri Glazkov.

Now that the HTMLKeygenElement was AuthroShadowDOM-ready, it's time to update the previous
failing tests for AuthroShadowDOM for keygen elements.

I've updated the failing tests to follow the current implementation and updated the test expectations.

fast/dom/shadow/shadowdom-for-keygen-complex-shadow-expected.html:
fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html:
fast/dom/shadow/shadowdom-for-keygen-only-shadow-expected.html:
fast/dom/shadow/shadowdom-for-keygen-only-shadow.html:
fast/dom/shadow/shadowdom-for-keygen-without-shadow-expected.html:
fast/dom/shadow/shadowdom-for-keygen-without-shadow.html:
platform/chromium/TestExpectations:
platform/efl/TestExpectations:

6:25 PM Changeset in webkit [126524] by kling@webkit.org

4 edits in trunk/Source/WebCore

Use immutable StylePropertySets for element inline style declarations.
<http://webkit.org/b/94714>

Reviewed by Antti Koivisto.

Construct the inline styles as immutable StylePropertySets initially (until they are
modified through CSSOM APIs), reducing their memory footprint and enabling us to do
sharing optimizations in the future.

css/CSSParser.cpp:

(WebCore::CSSParser::parseInlineStyleDeclaration):
(WebCore::CSSParser::parseDeclaration):

css/CSSParser.h:
dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):

6:19 PM Changeset in webkit [126523] by jhoneycutt@apple.com

3 edits
1 add in trunk/LayoutTests

Update Skipped list and TestExpectations in preparation for making
Mountain Lion the default Mac builder.

Rubber-stamped by Jessie Berlin.

platform/mac-lion/TestExpectations: Added.

Moved/added test expectations from platform/mac/TestExpectations to
here.

platform/mac/Skipped:

Added some known failures from internal testers.

platform/mac/TestExpectations:

Ditto.

6:08 PM Changeset in webkit [126522] by mrowe@apple.com

4 edits in trunk/Source

Versioning.

6:02 PM Changeset in webkit [126521] by abarth@webkit.org

3 edits in trunk/Source/WebCore

[V8] V8AbstractEventListener re-implements ScopedPersistent by hand
https://bugs.webkit.org/show_bug.cgi?id=94873

Reviewed by Eric Seidel.

Rather than calling New/Dispose manually, this patch changes
V8AbstractEventListener to use ScopedPersistent.

bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::weakEventListenerCallback):
(WebCore::V8AbstractEventListener::~V8AbstractEventListener):
(WebCore::V8AbstractEventListener::setListenerObject):
(WebCore::V8AbstractEventListener::getReceiverObject):

bindings/v8/V8AbstractEventListener.h:

(WebCore::V8AbstractEventListener::getListenerObject):
(WebCore::V8AbstractEventListener::getExistingListenerObject):
(WebCore::V8AbstractEventListener::existingListenerObjectPersistentHandle):
(WebCore::V8AbstractEventListener::hasExistingListenerObject):
(V8AbstractEventListener):

5:52 PM Changeset in webkit [126520] by Simon Fraser

18 edits in trunk/Source/WebCore

Prep work for: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Dave Hyatt.

Do some method renaming in preparation for adding a new kind
of in-flow positioning: sticky positioning.

Rename RenderStyle::isOutOfFlowPositioned() to hasOutOfFlowPosition().
Add RenderStyle::hasInFlowPosition().

Use RenderObject::isInFlowPositioned() in places where it will apply
for both relative and sticky positioning.

Add RenderBoxModelObject::offsetForInFlowPosition(), which currently
applies just to relative positioning, but will also apply to sticky.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::getPositionOffsetValue):

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

editing/TextIterator.cpp:

(WebCore::ignoresContainerClip):

rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::positionForPointRespectingEditingBoundaries):

rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::updateBoxModelInfoFromStyle):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

rendering/RenderBox.h:
rendering/RenderBoxModelObject.cpp:

(WebCore::accumulateInFlowPositionOffsets):
(WebCore::RenderBoxModelObject::relativePositionOffset):
(WebCore::RenderBoxModelObject::offsetForInFlowPosition):
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):
(WebCore::RenderBoxModelObject::stickyPositionLogicalOffset):
(WebCore::RenderBoxModelObject::requiresLayer):

rendering/RenderInline.cpp:

(WebCore::inFlowPositionedInlineAncestor): We need to actually return
the ancestor, since we will need to copy its position type once there
is more than one kind of in-flow position.
(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::mapLocalToContainer):
(WebCore::RenderInline::offsetForInFlowPositionedInline):

rendering/RenderInline.h:

(WebCore::RenderInline::requiresLayer):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):
(WebCore::isPositionedContainer):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):

rendering/RenderLayer.h:

(WebCore::RenderLayer::offsetForInFlowPosition):

rendering/RenderObject.cpp:

(WebCore::RenderObject::markContainingBlocksForLayout):
(WebCore::RenderObject::setPreferredLogicalWidthsDirty):
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):
(WebCore::RenderObject::containingBlock):

rendering/RenderObject.h:

(WebCore::RenderObject::isRelPositioned):

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

rendering/style/RenderStyle.h:

5:52 PM Changeset in webkit [126519] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

EFL build fix attempt after r126494. Try touching the IDL file.

Modules/battery/BatteryManager.idl:

5:50 PM Changeset in webkit [126518] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Remove FIXMEs from css3/flexbox/flexitem.html
https://bugs.webkit.org/show_bug.cgi?id=94872

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-08-23
Reviewed by Ojan Vafai.

Remove FIXMEs that were fixed in bug 94604.

css3/flexbox/flexitem.html:

5:42 PM Changeset in webkit [126517] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed attempt to fix build failure in Debug.

bindings/v8/ScriptValue.h:

5:41 PM Changeset in webkit [126516] by jsbell@chromium.org

17 edits in trunk/Source

IndexedDB: Expose mechanism for database to force a connection to close
https://bugs.webkit.org/show_bug.cgi?id=91010

Reviewed by Tony Chang.

Source/WebCore:

In response to user action (e.g. "delete my browsing data") a connection may
need to be forcibly terminated. This allows an event to be sent to a connection
from the back end via IDBDatabaseCallbacks to initiate closing the connection.

Test: [chromium] webkit_unit_test --gtest_filter='IDBDatabaseBackendTest.ForcedClose'

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::forceClose): Abort all transactions and close.
(WebCore):

Modules/indexeddb/IDBDatabase.h:

(IDBDatabase): Entry point.

Modules/indexeddb/IDBDatabaseCallbacks.h:

(IDBDatabaseCallbacks): Event plumbing from back end.

Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:

(WebCore::IDBDatabaseCallbacksImpl::onForcedClose): Ditto.
(WebCore):

Modules/indexeddb/IDBDatabaseCallbacksImpl.h:

(IDBDatabaseCallbacksImpl): Ditto.

inspector/InspectorIndexedDBAgent.cpp:

(WebCore): Method stub.

Source/WebKit/chromium:

In Chromium, the browsing data deleter has a WebIDBDatabase handle which
it can use to terminate a connection. This handles forcefully closing
the front end connections and the back end, to unblock disk cleanup.

public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::forceClose): Entry point.

public/WebIDBDatabaseCallbacks.h:

(WebKit::WebIDBDatabaseCallbacks::onForcedClose): Plumbing back to front.

src/IDBDatabaseCallbacksProxy.cpp:

(WebKit::IDBDatabaseCallbacksProxy::onForcedClose): Plumbing back to front.
(WebKit):

src/IDBDatabaseCallbacksProxy.h:

(IDBDatabaseCallbacksProxy): Plumbing.

src/WebIDBDatabaseCallbacksImpl.cpp:

(WebKit::WebIDBDatabaseCallbacksImpl::onForcedClose): Plumbing back to front.
(WebKit):

src/WebIDBDatabaseCallbacksImpl.h:

(WebIDBDatabaseCallbacksImpl): Plumbing back to front.

src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::close): Tidy up dropping the callback reference.
(WebKit):
(WebKit::WebIDBDatabaseImpl::forceClose): Terminate the connection by notifying
the back end and the front end, while avoid re-entrant badness.

src/WebIDBDatabaseImpl.h: Header tweak for unit test.

(WebIDBDatabaseImpl):

tests/IDBDatabaseBackendTest.cpp: Added unit test to exercise connections.

5:40 PM Changeset in webkit [126515] by mrowe@apple.com

2 edits in trunk/Source/WTF

Build fix for old, old versions of Clang.

wtf/FastMalloc.cpp:

(WTF): Rejigger things so that they parse correctly if has_warning isn't defined.

5:39 PM Changeset in webkit [126514] by tonikitoo@webkit.org

6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Obsolete the in-region scroll codepath prior to BB10's
https://bugs.webkit.org/show_bug.cgi?id=94839
PR #197775

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

This codepath is not needed anymore, so lets let it RIP.

The only code addition is due to some code I've moved from WebPagePrivate::scrollNodeRecursively
and WebPagePrivate::scrollBy to InRegionScrollerPrivate::setLayerScrollPosition.
Rest is code removal ...

Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):

Api/InRegionScroller_p.h:

(InRegionScrollerPrivate):

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::scrollBy):
(BlackBerry::WebKit::WebPage::scrollBy):

Api/WebPage.h:
Api/WebPage_p.h:

(WebPagePrivate):

5:36 PM Changeset in webkit [126513] by jamesr@google.com

16 edits
2 copies
2 moves in trunk/Source

[chromium] Convert WebAnimationCurve subtypes into pure virtual
https://bugs.webkit.org/show_bug.cgi?id=94068

Reviewed by Adrienne Walker.

Source/Platform:

This makes the Web*AnimationCurve interfaces pure virtual to provide better insulation from the implementation
details of the classes.

chromium/public/WebAnimation.h:

(WebKit::WebAnimation::WebAnimation):
(WebAnimation):

chromium/public/WebAnimationCurve.h:
chromium/public/WebFloatAnimationCurve.h:

(WebFloatAnimationCurve):
(WebKit::WebFloatAnimationCurve::~WebFloatAnimationCurve):

chromium/public/WebTransformAnimationCurve.h:

(WebTransformAnimationCurve):
(WebKit::WebTransformAnimationCurve::~WebTransformAnimationCurve):

Source/WebCore:

Updates users of the Web*AnimationCurve interface for its new pointery goodness.

platform/graphics/chromium/AnimationTranslationUtil.cpp:

(WebCore::appendKeyframeWithStandardTimingFunction):
(WebCore::appendKeyframeWithCustomBezierTimingFunction):
(WebCore::WebTransformAnimationCurve):
(WebCore::createWebAnimation):

Source/WebKit/chromium:

Updates the implementations, some callers and tests of Web*AnimationCurve to its new interface.

WebKit.gyp:
src/WebAnimation.cpp:

(WebKit::WebAnimation::initialize):

src/WebFloatAnimationCurveImpl.cpp: Renamed from Source/WebKit/chromium/src/WebFloatAnimationCurve.cpp.

(WebKit):
(WebKit::WebFloatAnimationCurve::create):
(WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
(WebKit::WebFloatAnimationCurveImpl::~WebFloatAnimationCurveImpl):
(WebKit::WebFloatAnimationCurveImpl::type):
(WebKit::WebFloatAnimationCurveImpl::add):
(WebKit::WebFloatAnimationCurveImpl::getValue):
(WebKit::WebFloatAnimationCurveImpl::cloneToCCAnimationCurve):

src/WebTransformAnimationCurve.cpp: Removed.
tests/WebAnimationTest.cpp:

(WebKit::TEST):

tests/WebFloatAnimationCurveTest.cpp:

(WebKit::TEST):

tests/WebTransformAnimationCurveTest.cpp:

(WebKit::TEST):

5:31 PM Changeset in webkit [126512] by rniwa@webkit.org

3 edits in trunk/Tools

Replay tests take forever to load
https://bugs.webkit.org/show_bug.cgi?id=94764

Reviewed by Adam Barth.

Don't load about:blank at the beginning. This appears to clog the DRT.

Scripts/webkitpy/performance_tests/perftest.py:

(ReplayPerfTest.run_single):

Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestReplayPerfTest.test_run_single):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error):

5:22 PM Changeset in webkit [126511] by mrowe@apple.com

2 edits in trunk/Source/WTF

Roll back in the part of r126475 that I had rolled out.

wtf/FastMalloc.cpp:

(WTF): Disable the -Wunused-private-field warning around the declaration of
TCMalloc_Central_FreeListPadded since the padding is intentionally unused.
Only disable the warning if we detect it is enabled, since the warning may not
be supported by the version of Clang that is being used.

5:17 PM Changeset in webkit [126510] by kbr@google.com

2 edits in trunk/Tools

Unreviewed, rolling out r126497.
http://trac.webkit.org/changeset/126497
https://bugs.webkit.org/show_bug.cgi?id=94764

Caused webkitpy-test step to start failing.

Scripts/webkitpy/performance_tests/perftest.py:

(ReplayPerfTest.run_single):

5:14 PM Changeset in webkit [126509] by eae@chromium.org

16 edits
2 adds in trunk

Add saturation arithmetic support to FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=94364

Reviewed by Benjamin Poulain.

Source/WebCore:

Add experimental saturation arithmetic support to FractionalLayoutUnit,
guarded by a flag.
The idea here is to saturate (or clamp) rather than overflow when
computing positions and sizes.

No new tests for WebCore, not enabled by default.

platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::intMinForLayoutUnit):
Use INT_MIN instead of -INT_MAX to compute minimum value as the two are
not the same.

(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::fromFloatCeil):
(WebCore::FractionalLayoutUnit::fromFloatFloor):
(WebCore::FractionalLayoutUnit::fromFloatRound):
(WebCore::FractionalLayoutUnit::setValue):
Add range checks.

(WebCore::operator*):
(WebCore::operator+):
(WebCore::operator-):
(WebCore::operator+=):
(WebCore::operator-=):
Use the saturatedAddition and saturatedSubtraction functions, which have
been optimized to reduce branching, instead of range checks for the most
common operators.

Source/WTF:

Add support functions for saturated addition and subtraction.

Test: TestWebKitAPI/Tests/WTF/SaturatedArithmeticOperations.cpp

GNUmakefile.list.am:
WTF.gypi:
WTF.pro:
WTF.vcproj/WTF.vcproj:
WTF.xcodeproj/project.pbxproj:
WTF/wtf/CMakeLists.txt:

Add SaturatedArithmetic.h to build files.

wtf/SaturatedArithmetic.h: Added.

(saturatedAddition):
(saturatedSubtraction):
Support functions for saturated addition/subtraction. Compares the signed
bit of the values instead of using range checks to reduce branching.

wtf/Platform.h:

Add ENABLE_SATURATED_LAYOUT_ARITHMETIC flag.

Tools:

Add test for new saturatedArithmetic functions.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/GNUmakefile.am:
TestWebKitAPI/TestWebKitAPI.gypi:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/SaturatedArithmeticOperations.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

TestWebKitAPI/win/TestWebKitAPI.vcproj:

5:11 PM Changeset in webkit [126508] by haraken@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed. Just added comments I forgot to add in r126506.

bindings/v8/ScriptController.h:

(WebCore):
(ScriptController):

5:09 PM Changeset in webkit [126507] by kbr@google.com

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r126483.
http://trac.webkit.org/changeset/126483
https://bugs.webkit.org/show_bug.cgi?id=92272

Caused two Chromium browser_tests to time out 100% reliably.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::detachFromParent):

loader/FrameLoader.h:

(FrameLoader):

4:59 PM Changeset in webkit [126506] by haraken@chromium.org

33 edits
2 deletes in trunk/Source

[V8] Remove V8Proxy.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=94794

Reviewed by Dimitri Glazkov.

Now V8Proxy is no longer used. We can completely remove V8Proxy from the codebase.

No tests. No change in behavior.

Source/WebCore:

UseV8.cmake:
WebCore.gypi:
bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):
(GenerateCallbackImplementation):

bindings/scripts/test/V8/V8Float64Array.cpp:
bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
bindings/scripts/test/V8/V8TestCallback.cpp:
bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
bindings/scripts/test/V8/V8TestEventConstructor.cpp:
bindings/scripts/test/V8/V8TestEventTarget.cpp:
bindings/scripts/test/V8/V8TestException.cpp:
bindings/scripts/test/V8/V8TestInterface.cpp:
bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
bindings/scripts/test/V8/V8TestNode.cpp:
bindings/scripts/test/V8/V8TestObj.cpp:
bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::callFunction):
(WebCore::ScriptController::clearWindowShell):

bindings/v8/ScriptController.h:

(WebCore):
(ScriptController):

bindings/v8/V8AbstractEventListener.h:

(WebCore):

bindings/v8/V8Binding.cpp:
bindings/v8/V8DOMWindowShell.cpp:

(WebCore::reportFatalErrorInV8):

bindings/v8/V8DOMWrapper.h:

(WebCore):

bindings/v8/V8ObjectConstructor.cpp:

(WebCore::V8ObjectConstructor::newInstanceInDocument):

bindings/v8/V8Proxy.cpp: Removed.
bindings/v8/V8Proxy.h: Removed.
bindings/v8/V8RecursionScope.h:

(WebCore):

bindings/v8/V8Utilities.cpp:
bindings/v8/custom/V8CustomXPathNSResolver.h:

Source/WebKit/chromium:

src/ChromeClientImpl.cpp:
src/WebBindings.cpp:
src/WebDOMMessageEvent.cpp:
src/WebDevToolsAgentImpl.cpp:
src/WebMediaPlayerClientImpl.cpp:

4:49 PM Changeset in webkit [126505] by oliver@apple.com

4 edits
5 adds in trunk/Source/JavaScriptCore

Autogenerate Opcode definitions
https://bugs.webkit.org/show_bug.cgi?id=94840

Reviewed by Gavin Barraclough.

Start the process of autogenerating the code emission for the bytecode.
We'll just start with automatic generation of the list of Opcodes as that
requires the actual definition of the opcodes, and the logic for parsing
them.

Due to some rather annoying dependency cycles, this initial version has
the OpcodeDefinitions.h file checked into the tree, although with some
work I hope to be able to fix that.

DerivedSources.make:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/Opcode.h: Include OpcodeDefinitions.h as our definitive source of info about the opcodes.
bytecode/OpcodeDefinitions.h: Added. Autogenerated file
bytecode/opcodes: Added. The new opcode definition file
opcode_definition_generator.py: Added.

(generateOpcodeDefinition):
(generate):

Module that generates the content for OpcodeDefinitions.h

opcode_generator.py: Added.

(printUsage):
(main):

Driver script

opcode_parser.py: Added. Simple parser for the opcode definitions.

4:48 PM Changeset in webkit [126504] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Add a check to filter out cookies that tries to set the domain to a top level domain
https://bugs.webkit.org/show_bug.cgi?id=94722

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-08-23
Reviewed by Rob Buis.

Changing the topleveldomain method name for better readability.

Also renaming the TopLevelDomain.h in platform to DomainTools
because there exists other tests that should belong in the same file.

Only changing method names and include file names.

platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):

4:41 PM Changeset in webkit [126503] by commit-queue@webkit.org

7 edits in trunk

Fix cross-direction stretch for replaced elements in column flexbox
https://bugs.webkit.org/show_bug.cgi?id=94604

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-08-23
Reviewed by Ojan Vafai.

Source/WebCore:

Moved the logic that constrains logical width by MinSize and MaxSize to
a new helper function called constrainLogicalWidthInRegionByMinMax.
This helper function is used from both computeLogicalWidthInRegion and
RenderFlexibleBox::applyStretchAlignmentToChild.

RenderFlexibleBox no longer checks for isMultiline when stretching
elements in a column flexbox. Instead, we now constrain the available
width by the child's min-width and max-width, and set the override
width only if that constrained width is different from the child's
current logicalWidth.

No new tests. The existing css3/flexbox/flexitem.html test was extended
to exercise the new code.

rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax): New helper
method to constrain logical width by min-width and max-width.
(WebCore):
(WebCore::RenderBox::computeLogicalWidthInRegion): Changed to use the
new constrainLogicalWidthInRegionByMinMax helper method.

rendering/RenderBox.h:

(RenderBox):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Changed to
use constrainLogicalWidthInRegionByMinMax to determine the override
width for the child.

LayoutTests:

Fixed failing test cases. Add tests for min/max width/height.

css3/flexbox/flexitem-expected.txt:
css3/flexbox/flexitem.html:

4:30 PM Changeset in webkit [126502] by abarth@webkit.org

5 edits in trunk/Source/WebCore

[V8] ScriptState is using stone knifes and bear skins
https://bugs.webkit.org/show_bug.cgi?id=94846

Reviewed by Eric Seidel.

This patch just modernizes ScriptState to use some of the newer tools
available in the V8 bindings. There shouldn't be any behavior changes.

bindings/v8/ScriptState.cpp:

(WebCore::ScriptState::ScriptState):
(WebCore::ScriptState::~ScriptState):
(WebCore::ScriptState::domWindow):
(WebCore::ScriptState::scriptExecutionContext):
(WebCore::ScriptState::forContext):
(WebCore::ScriptState::current):

bindings/v8/ScriptState.h:

(WebCore):
(WebCore::ScriptState::context):
(ScriptState):
(WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr):
(ScriptStateProtectedPtr):

bindings/v8/V8Binding.cpp:

(WebCore::toScriptExecutionContext):
(WebCore):

bindings/v8/V8Binding.h:

(WebCore):

4:23 PM Changeset in webkit [126501] by danakj@chromium.org

7 edits in trunk/Source

[chromium] Don't require a RenderSurface* in order to create a RenderPass
https://bugs.webkit.org/show_bug.cgi?id=94862

Reviewed by Adrienne Walker.

Source/WebCore:

If a test wants to create a RenderPass, they are required to create a
Layer, and a RenderSurface. This is not ideal, we should let tests
create RenderPasses more simply by giving the information that it needs.

This also helps us recreate the RenderPasses after receiving a copy
via IPC.

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):

platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:
tests/CCRendererGLTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):

4:21 PM Changeset in webkit [126500] by abarth@webkit.org

3 edits in trunk/Source/WebCore

[V8] ScriptValue should use ScopedPresistent rather than calling New/Dispose directly
https://bugs.webkit.org/show_bug.cgi?id=94864

Reviewed by Eric Seidel.

ScriptValue was created before ScopedPersistent existed and therefore
calls New/Dispose manually. Instead, it should use the less error-prone
approach of having ScopedPersistent balance those calls.

bindings/v8/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):

bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(WebCore::ScriptValue::v8Value):
(ScriptValue):

4:17 PM Changeset in webkit [126499] by kbr@google.com

2 edits in trunk/LayoutTests

Unreviewed Chromium gardening. Generalized a few Snow Leopard-only
expectations to Mac in order to get the new Lion bot green.

platform/chromium/TestExpectations:

4:14 PM Changeset in webkit [126498] by jamesr@google.com

7 edits in trunk/Source

[chromium] Remove WebLayer::setChildren API
https://bugs.webkit.org/show_bug.cgi?id=94749

Reviewed by Adrienne Walker.

Source/Platform:

This is redundant with removeAllChildren() / addChild() and less efficient.

chromium/public/WebLayer.h:

(WebLayer):

Source/WebCore:

Sets up the child list directly instead of building an intermediate buffer. Covered by compositing/*

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::updateChildList):

Source/WebKit/chromium:

src/WebLayer.cpp:

4:12 PM Changeset in webkit [126497] by rniwa@webkit.org

2 edits in trunk/Tools

Replay tests take forever to load
https://bugs.webkit.org/show_bug.cgi?id=94764

Reviewed by Adam Barth.

Don't load about:blank at the beginning. This appears to clog the DRT.

Scripts/webkitpy/performance_tests/perftest.py:

(ReplayPerfTest.run_single):

4:05 PM Changeset in webkit [126496] by dmazzoni@google.com

11 edits
2 adds in trunk

AX: Focusable elements without a role should not be ignored
https://bugs.webkit.org/show_bug.cgi?id=94302

Reviewed by Chris Fleizach.

Source/WebCore:

Changes the accessibility logic so that a generic element that's focusable is
not ignored for accessibility, and returns its inner text as its title. That way
if you Tab to the element, a reasonable accessibility notification is generated.

One exception is the body element, because focusing the body is equivalent to
blurring the current focused element and does not result in a "focus" accessibility
notification.

Also fixes logic that determined if an element was contentEditable by making
sure it catches the case with no attribute value (e.g. <div contentEditable>),
which also implies contentEditable=true according to the spec.

Test: accessibility/focusable-div.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::nodeHasContentEditableAttributeSet):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests:

Adds a new test to make sure that a generic focusable element (like a div with tabindex=0)
can get focus and return an appropriate title, just like a form control or element with
an ARIA role.

Modifies three existing tests that were previously assuming that a focusable node
with no role would be ignored for accessibility ("accessibilityIsIgnored").

accessibility/editable-webarea-context-menu-point.html:
accessibility/focusable-div-expected.txt: Added.
accessibility/focusable-div.html: Added.
accessibility/table-detection.html:
platform/mac/accessibility/listbox-hit-test.html:

4:02 PM Changeset in webkit [126495] by jchaffraix@webkit.org

7 edits in trunk/Source/WebCore

Remove RenderTable::removeChild
https://bugs.webkit.org/show_bug.cgi?id=94842

Reviewed by Abhishek Arya.

This change removed removeChild, replaced by willBeRemovedFromTree calls. The upside is that
the invalidations are now guaranteed to run if we split a table (which is not guaranteed when
using removeChild). This change also shows that our code may be doing too much work in some
of the child's removal, in which case the code was marked as needed.

Covered by existing tests.

rendering/RenderTable.cpp:

(WebCore::RenderTable::removeCaption):
Helper function used to remove the caption from our Vector. The invalidation are very likely
unneeded so added a comment about that.

rendering/RenderTable.h:
rendering/RenderTableCaption.cpp:

(WebCore::RenderTableCaption::willBeRemovedFromTree):
(WebCore::RenderTableCaption::table):

rendering/RenderTableCaption.h:
rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::willBeRemovedFromTree):

rendering/RenderTableCol.h:

Added the following functions to do the invalidation.

4:00 PM Changeset in webkit [126494] by mhahnenberg@apple.com

60 edits
3 adds in trunk

Change behavior of MasqueradesAsUndefined to better accommodate DFG changes
https://bugs.webkit.org/show_bug.cgi?id=93884

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

With some upcoming changes to the DFG to remove uses of ClassInfo, we will be changing the behavior of
MasqueradesAsUndefined. In order to make this change consistent across all of our execution engines,
we will make this change to MasqueradesAsUndefined as a separate patch. After this patch, MasqueradesAsUndefined
objects will only masquerade as undefined in their original context (i.e. their original JSGlobalObject).
For example, if an object that masquerades as undefined in frame A is passed to frame B, it will not
masquerade as undefined within frame B, but it will continue to masquerade in frame A.

There are two primary changes that are taking place here. One is to thread the ExecState* through
JSValue::toBoolean and JSCell::toBoolean so that JSCell::toBoolean can check the object's
JSGlobalObject to compare it to the lexical JSGlobalObject of the currently running code. If the two
are distinct, then the object cannot MasqueradeAsUndefined.

The other change is to perform this comparison of JSGlobalObjects everywhere where the MasqueradesAsUndefined
flag in the Structure is checked. For C++ code, this check has been factored into its own function in
Structure::masqueradesAsUndefined. We only perform this check in the DFG if the current JSGlobalObject has
had a MasqueradesAsUndefined object allocated within its context. This conditional compilation is managed
through the use of a WatchpointSet in each JSGlobalObject and alternate create() functions for JS DOM wrappers
that are MasqueradesAsUndefined.

API/JSValueRef.cpp:

(JSValueToBoolean):

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
bytecode/Watchpoint.h:

(WatchpointSet):

debugger/DebuggerCallFrame.h:

(JSC::DebuggerCallFrame::callFrame):

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncSome):

runtime/BooleanConstructor.cpp:

(JSC::constructBoolean):
(JSC::callBooleanConstructor):

runtime/JSCell.h:

(JSCell):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):

runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::masqueradesAsUndefinedWatchpoint):

runtime/JSString.h:

(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

runtime/JSValue.h:
runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):

runtime/Operations.h:

(JSC):
(JSC::JSValue::equalSlowCaseInline):

runtime/RegExpConstructor.cpp:

(JSC::setRegExpConstructorMultiline):

runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

runtime/Structure.h:

(Structure):
(JSC::Structure::globalObjectOffset):
(JSC::Structure::masqueradesAsUndefined):
(JSC):

Source/WebCore:

Test: fast/js/document-all-between-frames.html

All of the changes in WebCore are simply passing the additional ExecState argument to JSValue::toBoolean.

bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems):

bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::dataFunctionMatrix):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

bindings/js/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::exec):
(WebCore):

bindings/js/JavaScriptCallFrame.h:

(JavaScriptCallFrame):

bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):

bindings/scripts/CodeGeneratorJS.pm: Also add the custom create function for MasqueradesAsUndefined JS DOM wrappers.

(GenerateEventListenerCall):
(GenerateHeader):
(JSValueToNative):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):

bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::create):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):

bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertValueToJObject):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

Source/WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray): Passing ExecState to toBoolean call.

Source/WebKit2:

WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant): Passing ExecState to toBoolean call.

LayoutTests:

Added a test that uses a variety of ways of checking whether something is correctly
masquerading as undefined (or not) in a subframe.

fast/js/document-all-between-frames-expected.txt: Added.
fast/js/document-all-between-frames.html: Added.
fast/js/resources/document-all-between-frames-subframe.html: Added.
platform/chromium/TestExpectations: Chromium treats document.all differently, so skip our new test.

3:53 PM Changeset in webkit [126493] by mrowe@apple.com

4 edits in branches/safari-536.26-branch/Source

Versioning.

3:53 PM Changeset in webkit [126492] by mrowe@apple.com

1 copy in tags/Safari-536.26.9

New tag.

3:52 PM Changeset in webkit [126491] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

CSSParser: Move enumeration to a common place (StylePropertyShorthand)
https://bugs.webkit.org/show_bug.cgi?id=93210

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-08-23
Reviewed by Dean Jackson.

CSSParser::parseAnimationShorthand() uses an enumeration with the same
elements as another enumeration present in StylePropertyShorthand, but
with different ordering of values. This patch puts both enums in the same place.

No new tests. No change in behavior.

css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationShorthand):

css/StylePropertyShorthand.cpp:

(WebCore::webkitAnimationShorthandForParsing):
(WebCore):

css/StylePropertyShorthand.h:

(WebCore):

3:50 PM Changeset in webkit [126490] by beidson@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (r124815): PDF in frame does not display any more
<rdar://problem/12063306> and https://bugs.webkit.org/show_bug.cgi?id=94869

Reviewed by Alexey Proskuryakov.

WebProcess/Plugins/PDF/BuiltInPDFView.mm:

(WebKit::BuiltInPDFView::initialize): Tell the controller that initialization was successful.

3:50 PM Changeset in webkit [126489] by commit-queue@webkit.org

2 edits
1 add in trunk/LayoutTests

Adjust test expectations for fast/js/toString-overrides.html and fast/js/eval-cross-window.html
https://bugs.webkit.org/show_bug.cgi?id=94824

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-08-23
Reviewed by Kentaro Hara.

Add a bug number for tracking failing cases in fast/js/toString-overrides.html.
Upload Chromium specific test expectations for fast/js/eval-cross-window.html.

Failing tests in eval-cross-window swap the eval() function in the main window and the frame.
This behaviour is not specified in ECMA-262 and is probably implementation dependent.
Both Firefox and Chromium produce the same result for this test.

platform/chromium/TestExpectations:
platform/chromium/fast/js/eval-cross-window-expected.txt: Added.

3:48 PM Changeset in webkit [126488] by commit-queue@webkit.org

5 edits in trunk

Trailing spaces in CSP source lists should not generate console warnings.
https://bugs.webkit.org/show_bug.cgi?id=94847

Patch by Mike West <mkwst@chromium.org> on 2012-08-23
Reviewed by Adam Barth.

Trailing space after a valid source in a Content Security Policy source
list was accidentally generating console warnings about an invalid
(empty) source. This patch silently ignores trailing whitespace instead.

Source/WebCore:

A test-case has been added to 'source-list-parsing-02.html' to cover
this case.

page/ContentSecurityPolicy.cpp:

(WebCore::CSPSourceList::parse):

Return early if we reach the end of the source list after skipping
leading whitespace.

LayoutTests:

http/tests/security/contentSecurityPolicy/source-list-parsing-02-expected.txt:
http/tests/security/contentSecurityPolicy/source-list-parsing-02.html:

3:37 PM Changeset in webkit [126487] by kbr@google.com

2 edits in trunk/LayoutTests

[Chromium] LayoutTests: css3/selector3/xml tests are flaky / have wrong expectations on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=82122

Unreviewed Chromium gardening. Expanded expectations from Snow Leopard to Mac.

platform/chromium/TestExpectations:

3:17 PM Changeset in webkit [126486] by mrowe@apple.com

2 edits in trunk/Source/WebCore

Remove some unneeded cruft from WebCore.xcodeproj.

WebCore.xcodeproj/project.pbxproj:

2:53 PM Changeset in webkit [126485] by commit-queue@webkit.org

7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Replace the three different rendering mechanisms for clearing the render queue
https://bugs.webkit.org/show_bug.cgi?id=94837

Patch by Adam Treat <atreat@rim.com> on 2012-08-23
Reviewed by George Staikos.

PR 197738

Currently, we have three different mechanisms for clearing the render queue.
The first mechanism is render on idle. Whenever the webkit thread becomes idle
(read: no more events in its queue) we render the next job in the render queue.

This is the primary means we use for clearing the render queue. However, this

mechanism has a flaw, it is such a low priority mechanism that sometimes the
queue grows so fast due to higher priority events adding rects to the queue
that this mechanism can't possibly keep up. That is what leads to the second
mechanism: rendering right before a timer is fired when we discover that the
render queue is under pressure and rendering on idle can't keep up. However,
there are still degenerate cases where even this mechanism does not allow us to
keep up. That brings us to the third mechanism: rendering based on a timer
that is a catch-all.

The second and third mechanisms lead to very large render jobs as they try and
clear the queue faster when it comes under pressure. These very large render
jobs end up keeping the webkit thread busy with a message that can take large
fractions of a second to resolve.

These three mechanisms were put in place when the backingstore had a different
overall design that was not truly asynchronous. This patch replaces these
three mechanisms with a single one that uses the platform messaging classes to
full purpose - a uniquely coalescing message that has a higher priority level
than timers making sure the render queue can never come under pressure.

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(WebKit):
(RenderJobMessage):
(BlackBerry::WebKit::RenderJobMessage::RenderJobMessage):
(BlackBerry::WebKit::BackingStorePrivate::dispatchRenderJob):
(BlackBerry::WebKit::BackingStorePrivate::renderJob):
(BlackBerry::WebKit::BackingStore::blitContents):

Api/BackingStore.h:
Api/BackingStore_p.h:

(BackingStorePrivate):

Api/WebPage.cpp:
Api/WebPage.h:
WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::reset):
(BlackBerry::WebKit::RenderQueue::addToRegularQueue):
(BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
(BlackBerry::WebKit::RenderQueue::clear):
(BlackBerry::WebKit::RenderQueue::clearVisibleZoom):
(BlackBerry::WebKit::RenderQueue::render):

2:45 PM Changeset in webkit [126484] by abarth@webkit.org

8 edits
1 move in trunk/Source/WebCore

[V8] OwnHandle is a bit of a misnomer
https://bugs.webkit.org/show_bug.cgi?id=94841

Reviewed by Eric Seidel.

You don't really own the handle in the same way that you own a pointer
with OwnPtr. This class is more correctly called ScopedPersistent
because it just forces you to balance New() and Dispose() calls.

WebCore.gypi:
bindings/v8/JavaScriptCallFrame.h:

(JavaScriptCallFrame):

bindings/v8/OwnHandle.h: Removed.
bindings/v8/ScheduledAction.h:

(ScheduledAction):

bindings/v8/ScopedPersistent.h: Copied from Source/WebCore/bindings/v8/OwnHandle.h.

(ScopedPersistent):
(WebCore::ScopedPersistent::ScopedPersistent):
(WebCore::ScopedPersistent::~ScopedPersistent):

bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::compileScript):
(WebCore::ScriptDebugServer::runScript):

bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

bindings/v8/ScriptInstance.h:

(V8ScriptInstance):

bindings/v8/V8PerContextData.h:

(V8PerContextData):

2:26 PM Changeset in webkit [126483] by Nate Chapin

3 edits in trunk/Source/WebCore

ProgressTracker never completes if iframe detached during parsing
https://bugs.webkit.org/show_bug.cgi?id=92272

Reviewed by Adam Barth.

Add a simple helper class to FrameLoader to ensure progressStarted/progressCompleted calls are matched,
and balance the calls when the Frame is detached.

No new tests, as this behavior has only been producing reliably by setting a breakpoint in a specific place.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):
(WebCore::FrameLoader::FrameProgressTracker::progressStarted):
(WebCore::FrameLoader::FrameProgressTracker::progressCompleted):
(WebCore::FrameLoader::FrameProgressTracker::~FrameProgressTracker):
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::detachFromParent):

loader/FrameLoader.h:

(FrameProgressTracker):
(WebCore::FrameLoader::FrameProgressTracker::create):
(WebCore::FrameLoader::FrameProgressTracker::FrameProgressTracker):

2:01 PM Changeset in webkit [126482] by danakj@chromium.org

35 edits in trunk/Source

[chromium] Create sharedQuadState at same time as creating quads and give them to the quadSink
https://bugs.webkit.org/show_bug.cgi?id=94752

Reviewed by Adrienne Walker.

Source/WebCore:

Previously, CCRenderPass would create a sharedQuadState for a layer,
and pass it in to the layer. Then the layer would point all its quads
at the sharedQuadState.

After this change, the layer creates its own sharedQuadState, gives it
to the RenderPass (via CCQuadSink), and points its quads at it.

This approach allows a layer to generate more than one sharedQuadState
with different quads pointing to different shared states. Also, this
will allow the layer representing a delegating renderer (via ubercomp)
to copy sharedQuadStates from the delegating renderer in order to
merge its quads into the RenderPass for the current renderer.

Covered by existing tests, no change in behaviour.

platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:

(WebCore::CCHeadsUpDisplayLayerImpl::appendQuads):

platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:

(CCHeadsUpDisplayLayerImpl):

platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:

(WebCore::CCIOSurfaceLayerImpl::appendQuads):

platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.h:

(CCIOSurfaceLayerImpl):

platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::createSharedQuadState):

platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::appendQuads):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):
(WebCore::CCQuadCuller::useSharedQuadState):
(WebCore):

platform/graphics/chromium/cc/CCQuadCuller.h:

(WebCore):
(CCQuadCuller):

platform/graphics/chromium/cc/CCQuadSink.h:

(WebCore):
(CCQuadSink):

platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
(WebCore::CCRenderPass::appendQuadsToFillScreen):

platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCRenderPass):

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendQuads):

platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::appendQuads):

platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

platform/graphics/chromium/cc/CCSharedQuadState.cpp:

(WebCore::CCSharedQuadState::create):
(WebCore::CCSharedQuadState::CCSharedQuadState):

platform/graphics/chromium/cc/CCSharedQuadState.h:

(CCSharedQuadState):

platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:

(WebCore::CCSolidColorLayerImpl::appendQuads):

platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:

(WebCore::CCTextureLayerImpl::appendQuads):

platform/graphics/chromium/cc/CCTextureLayerImpl.h:

(CCTextureLayerImpl):

platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:
tests/CCLayerTreeHostTest.cpp:

(WTF::EvictionTestLayerImpl::appendQuads):

tests/CCQuadCullerTest.cpp:
tests/CCRenderSurfaceTest.cpp:
tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
(CCLayerTestCommon::coverageVisibleRectOnTileBoundaries):
(CCLayerTestCommon::coverageVisibleRectIntersectsTiles):
(CCLayerTestCommon::coverageVisibleRectIntersectsBounds):

tests/MockCCQuadCuller.h:

(WebCore::MockCCQuadCuller::MockCCQuadCuller):
(MockCCQuadCuller):
(WebCore::MockCCQuadCuller::quadList):
(WebCore::MockCCQuadCuller::sharedQuadStateList):

1:57 PM Changeset in webkit [126481] by mrowe@apple.com

2 edits in trunk/Source/WTF

Roll out part of r126475 that breaks the build with older versions of Clang.

wtf/FastMalloc.cpp:

1:56 PM Changeset in webkit [126480] by pfeldman@chromium.org

2 edits in trunk/Source/WebKit/chromium

Not reviewed - fixing input list for timeline inspector module.
https://bugs.webkit.org/show_bug.cgi?id=94829

WebKit.gyp:

1:50 PM Changeset in webkit [126479] by mrowe@apple.com

2 edits in trunk/Source/ThirdParty

Make gtest build with the latest version of clang.

Reviewed by Dan Bernstein.

gtest/src/gtest-internal-inl.h:

(GTestFlagSaver): Remove an unused member.

1:50 PM Changeset in webkit [126478] by mrowe@apple.com

2 edits in trunk/Source/WebKit2

Make WebKit2 build with the latest version of clang.

Reviewed by Dan Bernstein.

Configurations/Base.xcconfig: Ensure that operator new isn't exported as a weak external symbol.

1:50 PM Changeset in webkit [126477] by mrowe@apple.com

8 edits in trunk/Source/WebCore

Make WebCore build with the latest version of clang.

Reviewed by Dan Bernstein.

html/shadow/MediaControlRootElement.h: Remove m_textTrackDisplay as it is unused.
platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::AudioFileReader): Remove m_filePath as it is unused.

platform/audio/mac/AudioFileReaderMac.h:

(AudioFileReader): Ditto.

platform/graphics/ImageSource.h:

(ImageSource): Guard m_alphaOption and m_gammaAndColorProfileOption with !USE(CG)
as they're unused on platforms using CG.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(MediaPlayerPrivateAVFoundationObjC): Remove m_player as it is unused.

platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::ImageSource): Don't initialize the m_alphaOption and
m_gammaAndColorProfileOption members since we never use them.

platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate): Remove m_graphicsContext3D
as it is unused.

1:50 PM Changeset in webkit [126476] by mrowe@apple.com

4 edits in trunk/Source/JavaScriptCore

Make JavaScriptCore build with the latest version of clang.

Reviewed by Dan Bernstein.

heap/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThreads): The m_heap member is only used within
assertions, so guard its initialization with !ASSERT_DISABLED.

heap/MachineStackMarker.h:

(MachineThreads): Ditto for its declaration.

jit/JITStubCall.h:

(JSC::JITStubCall::JITStubCall): The m_returnType member is only used within
assertions or if we're using JSVALUE32_64, so guard its uses with the appropriate
(JITStubCall): Ditto.

1:50 PM Changeset in webkit [126475] by mrowe@apple.com

2 edits in trunk/Source/WTF

Make WTF build with the latest version of clang.

Reviewed by Dan Bernstein.

wtf/FastMalloc.cpp:

(WTF): Disable the -Wunused-private-field warning around the declaration of
TCMalloc_Central_FreeListPadded since the padding is intentionally unused.
(WTF::AdminRegionRecorder): Remove the unused m_reader member.
(WTF::FastMallocZone::enumerate): Don't pass in the RemoteMemoryReader since
it is no longer needed.

1:39 PM Changeset in webkit [126474] by tonikitoo@webkit.org

6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Unify slow and fast in-region scrolling code paths
https://bugs.webkit.org/show_bug.cgi?id=94834
PR #197662

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Arvid Nilsson.

In order to be able to remove a bunch of obsolete code from
InRegionScroller.cpp, we need to unify the codepaths for slow
and fast in-region scrolling.

This patch caches the root scrollable node of each scrollable block
in InRegionScrollableArea also for the non-composited-scrolling case now too
(analogly to the way we cache LayerWebKitThread for the composited scrolling case).

Now the client (libwebview) can dispatch an in-region scrolling with one single code path,
making use of a boolean (argh!) to inform if the scroll of the given
layer supports compositing or not. Later on, this boolean is used to casting the proper element.

Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):

Api/InRegionScroller.h:
Api/InRegionScroller_p.h:

(InRegionScrollerPrivate):

WebKitSupport/InRegionScrollableArea.cpp:

(WebKit):
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
(BlackBerry::WebKit::enclosingLayerNode):

WebKitSupport/InRegionScrollableArea.h:

(WebCore):
(InRegionScrollableArea):

1:31 PM Changeset in webkit [126473] by aelias@chromium.org

38 edits
3 moves in trunk/Source

[chromium] Rename LayerRendererChromium to GL-specific name
https://bugs.webkit.org/show_bug.cgi?id=94835

Reviewed by James Robinson.

Over time, LayerRendererChromium has evolved to be a GL-specific
subclass of CCRenderer that has no awareness of layers (as it operates
only with drawQuads).

This patch renames LayerRendererChromium to CCRendererGL, replaces all
instances of "layerRenderer" with just "renderer", and removes a
few unnecessary includes of LayerRendererChromium.h.

Source/WebCore:

No new tests (no-op refactoring).

WebCore.gypi:
platform/graphics/chromium/Canvas2DLayerBridge.cpp:
platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

platform/graphics/chromium/GeometryBinding.cpp:
platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp:

(WebCore::HeadsUpDisplayLayerChromium::update):

platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::createTextureUpdaterIfNeeded):

platform/graphics/chromium/LayerTextureSubImage.cpp:
platform/graphics/chromium/ProgramBinding.cpp:
platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore):

platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):

platform/graphics/chromium/TextureCopier.cpp:
platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):

platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::sortLayers):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeRenderer):
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnImplThread):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::rendererCapabilities):
(WebCore::CCLayerTreeHost::initializeRendererIfNeeded):
(WebCore::CCLayerTreeHost::updateLayers):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::RendererCapabilities::RendererCapabilities):
(CCLayerTreeHost):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::finishAllRendering):
(WebCore::CCLayerTreeHostImpl::isContextLost):
(WebCore::CCLayerTreeHostImpl::rendererCapabilities):
(WebCore::CCLayerTreeHostImpl::swapBuffers):
(WebCore::CCLayerTreeHostImpl::readback):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeRenderer):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(WebCore::CCLayerTreeHostImpl::renderer):
(CCLayerTreeHostImpl):

platform/graphics/chromium/cc/CCPrioritizedTexture.cpp:
platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:
platform/graphics/chromium/cc/CCPriorityCalculator.cpp:
platform/graphics/chromium/cc/CCProxy.h:

(WebCore):
(CCProxy):

platform/graphics/chromium/cc/CCRenderSurface.cpp:
platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):

platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

platform/graphics/chromium/cc/CCRendererGL.cpp: Renamed from Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp.

(WebCore::CCRendererGL::create):
(WebCore):
(WebCore::CCRendererGL::CCRendererGL):
(WebCore::CCRendererGL::initialize):
(WebCore::CCRendererGL::~CCRendererGL):
(WebCore::CCRendererGL::context):
(WebCore::CCRendererGL::debugGLCall):
(WebCore::CCRendererGL::setVisible):
(WebCore::CCRendererGL::releaseRenderPassTextures):
(WebCore::CCRendererGL::viewportChanged):
(WebCore::CCRendererGL::clearFramebuffer):
(WebCore::CCRendererGL::beginDrawingFrame):
(WebCore::CCRendererGL::doNoOp):
(WebCore::CCRendererGL::drawQuad):
(WebCore::CCRendererGL::drawCheckerboardQuad):
(WebCore::CCRendererGL::drawDebugBorderQuad):
(WebCore::applyFilters):
(WebCore::CCRendererGL::drawBackgroundFilters):
(WebCore::CCRendererGL::drawRenderPassQuad):
(WebCore::CCRendererGL::drawSolidColorQuad):
(TileProgramUniforms):
(WebCore::tileUniformLocation):
(WebCore::CCRendererGL::drawTileQuad):
(WebCore::CCRendererGL::drawYUVVideoQuad):
(WebCore::CCRendererGL::drawStreamVideoQuad):
(WebCore::TextureProgramBinding::set):
(TextureProgramBinding):
(WebCore::TexTransformTextureProgramBinding::set):
(TexTransformTextureProgramBinding):
(WebCore::CCRendererGL::drawTextureQuad):
(WebCore::CCRendererGL::drawIOSurfaceQuad):
(WebCore::CCRendererGL::finishDrawingFrame):
(WebCore::CCRendererGL::toGLMatrix):
(WebCore::CCRendererGL::setShaderFloatQuad):
(WebCore::CCRendererGL::setShaderOpacity):
(WebCore::CCRendererGL::drawQuadGeometry):
(WebCore::CCRendererGL::copyTextureToFramebuffer):
(WebCore::CCRendererGL::finish):
(WebCore::CCRendererGL::swapBuffers):
(WebCore::CCRendererGL::onSwapBuffersComplete):
(WebCore::CCRendererGL::onMemoryAllocationChanged):
(WebCore::CCRendererGL::onMemoryAllocationChangedOnImplThread):
(WebCore::CCRendererGL::discardFramebuffer):
(WebCore::CCRendererGL::ensureFramebuffer):
(WebCore::CCRendererGL::onContextLost):
(WebCore::CCRendererGL::getFramebufferPixels):
(WebCore::CCRendererGL::getFramebufferTexture):
(WebCore::CCRendererGL::useScopedTexture):
(WebCore::CCRendererGL::bindFramebufferToOutputSurface):
(WebCore::CCRendererGL::bindFramebufferToTexture):
(WebCore::CCRendererGL::enableScissorTestRect):
(WebCore::CCRendererGL::disableScissorTest):
(WebCore::CCRendererGL::setDrawViewportSize):
(WebCore::CCRendererGL::makeContextCurrent):
(WebCore::CCRendererGL::initializeSharedObjects):
(WebCore::CCRendererGL::tileCheckerboardProgram):
(WebCore::CCRendererGL::solidColorProgram):
(WebCore::CCRendererGL::renderPassProgram):
(WebCore::CCRendererGL::renderPassProgramAA):
(WebCore::CCRendererGL::renderPassMaskProgram):
(WebCore::CCRendererGL::renderPassMaskProgramAA):
(WebCore::CCRendererGL::tileProgram):
(WebCore::CCRendererGL::tileProgramOpaque):
(WebCore::CCRendererGL::tileProgramAA):
(WebCore::CCRendererGL::tileProgramSwizzle):
(WebCore::CCRendererGL::tileProgramSwizzleOpaque):
(WebCore::CCRendererGL::tileProgramSwizzleAA):
(WebCore::CCRendererGL::textureProgram):
(WebCore::CCRendererGL::textureProgramFlip):
(WebCore::CCRendererGL::textureIOSurfaceProgram):
(WebCore::CCRendererGL::videoYUVProgram):
(WebCore::CCRendererGL::videoStreamTextureProgram):
(WebCore::CCRendererGL::cleanupSharedObjects):
(WebCore::CCRendererGL::isContextLost):

platform/graphics/chromium/cc/CCRendererGL.h: Renamed from Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h.

(WebKit):
(WebCore):
(CCRendererGL):
(WebCore::CCRendererGL::sharedGeometryQuad):
(WebCore::CCRendererGL::sharedGeometry):
(WebCore::CCRendererGL::isFramebufferDiscarded):

platform/graphics/chromium/cc/CCResourceProvider.cpp:
platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::initializeRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore::CCSingleThreadProxy::rendererCapabilities):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::forceSerializeOnSwapBuffers):
(WebCore::CCSingleThreadProxy::commitAndComposite):

platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::initializeRenderer):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::rendererCapabilities):
(WebCore::CCThreadProxy::forceSerializeOnSwapBuffersOnImplThread):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore::CCThreadProxy::initializeRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

WebKit.gypi:
tests/CCLayerTreeHostImplTest.cpp:
tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::drawLayersOnCCThread):

tests/CCRendererGLTest.cpp: Renamed from Source/WebKit/chromium/tests/LayerRendererChromiumTest.cpp.

(FrameCountingMemoryAllocationSettingContext):
(FrameCountingMemoryAllocationSettingContext::FrameCountingMemoryAllocationSettingContext):
(FrameCountingMemoryAllocationSettingContext::prepareTexture):
(FrameCountingMemoryAllocationSettingContext::setMemoryAllocationChangedCallbackCHROMIUM):
(FrameCountingMemoryAllocationSettingContext::getString):
(FrameCountingMemoryAllocationSettingContext::frameCount):
(FrameCountingMemoryAllocationSettingContext::setMemoryAllocation):
(FakeCCRendererClient):
(FakeCCRendererClient::FakeCCRendererClient):
(FakeCCRendererClient::setFullRootLayerDamageCount):
(FakeCCRendererClient::rootRenderPass):
(FakeCCRendererClient::renderPassesInDrawOrder):
(FakeCCRendererClient::renderPasses):
(FakeCCRendererClient::memoryAllocationLimitBytes):
(FakeCCRendererGL):
(FakeCCRendererGL::FakeCCRendererGL):
(CCRendererGLTest):
(CCRendererGLTest::CCRendererGLTest):
(CCRendererGLTest::SetUp):
(CCRendererGLTest::TearDown):
(CCRendererGLTest::swapBuffers):
(CCRendererGLTest::context):
(TEST_F):
(ForbidSynchronousCallContext):
(ForbidSynchronousCallContext::ForbidSynchronousCallContext):
(ForbidSynchronousCallContext::getActiveAttrib):
(ForbidSynchronousCallContext::getActiveUniform):
(ForbidSynchronousCallContext::getAttachedShaders):
(ForbidSynchronousCallContext::getAttribLocation):
(ForbidSynchronousCallContext::getBooleanv):
(ForbidSynchronousCallContext::getBufferParameteriv):
(ForbidSynchronousCallContext::getContextAttributes):
(ForbidSynchronousCallContext::getError):
(ForbidSynchronousCallContext::getFloatv):
(ForbidSynchronousCallContext::getFramebufferAttachmentParameteriv):
(ForbidSynchronousCallContext::getIntegerv):
(ForbidSynchronousCallContext::getProgramiv):
(ForbidSynchronousCallContext::getShaderiv):
(ForbidSynchronousCallContext::getString):
(ForbidSynchronousCallContext::getProgramInfoLog):
(ForbidSynchronousCallContext::getRenderbufferParameteriv):
(ForbidSynchronousCallContext::getShaderInfoLog):
(ForbidSynchronousCallContext::getShaderPrecisionFormat):
(ForbidSynchronousCallContext::getShaderSource):
(ForbidSynchronousCallContext::getTexParameterfv):
(ForbidSynchronousCallContext::getTexParameteriv):
(ForbidSynchronousCallContext::getUniformfv):
(ForbidSynchronousCallContext::getUniformiv):
(ForbidSynchronousCallContext::getUniformLocation):
(ForbidSynchronousCallContext::getVertexAttribfv):
(ForbidSynchronousCallContext::getVertexAttribiv):
(ForbidSynchronousCallContext::getVertexAttribOffset):
(TEST):
(LoseContextOnFirstGetContext):
(LoseContextOnFirstGetContext::LoseContextOnFirstGetContext):
(ContextThatDoesNotSupportMemoryManagmentExtensions):
(ContextThatDoesNotSupportMemoryManagmentExtensions::ContextThatDoesNotSupportMemoryManagmentExtensions):
(ContextThatDoesNotSupportMemoryManagmentExtensions::prepareTexture):
(ContextThatDoesNotSupportMemoryManagmentExtensions::setMemoryAllocationChangedCallbackCHROMIUM):
(ContextThatDoesNotSupportMemoryManagmentExtensions::getString):
(ClearCountingContext):
(ClearCountingContext::ClearCountingContext):
(ClearCountingContext::clear):
(ClearCountingContext::clearCount):

tests/TiledLayerChromiumTest.cpp:

1:31 PM Changeset in webkit [126472] by Beth Dakin

2 edits in branches/safari-536.26-branch/LayoutTests

Updated the expected results for this test after r125463.

platform/mac/fast/table/multiple-captions-display-expected.txt:

1:29 PM Changeset in webkit [126471] by annacc@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Removing media/track/track-mode.html - resolved.
[Chromium] Removing media/track/track-cues-cuechange.html - appears to be no longer failing.

Unreviewed gardening.

platform/chromium/TestExpectations:

1:27 PM Changeset in webkit [126470] by zhajiang@rim.com

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Web pages are zoomed out to much on initial load
https://bugs.webkit.org/show_bug.cgi?id=94830

Reviewed by Adam Treat.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 193943
Browser continuously adds paddings to the left and right sides of the
main contents which makes the main contents even smaller.
The issue can be reproduced on the desktop websites such as
huffingtonpost.ca, bloomberg.com, online.wsj.com, nytimes.com,
yahoo.com, thestar.com, sina.com.cn, sohu.com and so on.
The root cause is that we layout those contents at the width of 1280
although the fixed width of the main contents of those websites is
less than 1000, which results in adding the paddings.
To fix this, we need to get back to the default max layout size
1024 * 768, which will make the main contents of those popular websites
take full advantage of the screen real estate and look much better.

Internally reviewed by Adam Treat.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

Api/WebPage_p.h:

(WebPagePrivate):

WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::splittingFactor):

1:22 PM Changeset in webkit [126469] by senorblanco@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

12:46 PM Changeset in webkit [126468] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Flexbox doesn't need to compute logical height for stretched items in row flow
https://bugs.webkit.org/show_bug.cgi?id=94807

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-08-23
Reviewed by Tony Chang.

Change logicalHeightConstrainedByMinMax to
constrainLogicalHeightByMinMax. The new method doesn't compute the
MainOrPreferred logical height (that computation has been moved back to
computeLogicalHeight). RenderFlexibleBox now just constrains the
stretchedLogicalHeight by min/max.

No new tests. This is a cleanup of bug 94237.

rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalHeightByMinMax): Instead of
computing the MainOrPreferred logical height, just constrain the given
logical height by MinSize and MaxSize.
(WebCore::RenderBox::computeLogicalHeight): Compute the MainOrPreferred
logical height before constraining by min/max.

rendering/RenderBox.h:

(RenderBox):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Use
constrainLogicalHeightByMinMax to constrain the stretchedLogicalHeight.

12:43 PM Changeset in webkit [126467] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-1.10

Unreviewed. Update NEWS and configure.ac for 1.9.90 release

12:20 PM Changeset in webkit [126466] by commit-queue@webkit.org

91 edits in trunk/LayoutTests

[EFL] Update pixel test expectations for layout test fast/forms/
https://bugs.webkit.org/show_bug.cgi?id=94687

Unreviewed, rebaseline.

Some tests have wrong pixel test expectations. They should be replaced.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-23

platform/efl/fast/forms/003-expected.png:
platform/efl/fast/forms/006-expected.png:
platform/efl/fast/forms/007-expected.png:
platform/efl/fast/forms/HTMLOptionElement_label01-expected.png:
platform/efl/fast/forms/HTMLOptionElement_label02-expected.png:
platform/efl/fast/forms/HTMLOptionElement_label03-expected.png:
platform/efl/fast/forms/HTMLOptionElement_label04-expected.png:
platform/efl/fast/forms/HTMLOptionElement_label05-expected.png:
platform/efl/fast/forms/basic-buttons-expected.png:
platform/efl/fast/forms/basic-inputs-expected.png:
platform/efl/fast/forms/button-align-expected.png:
platform/efl/fast/forms/button-cannot-be-nested-expected.png:
platform/efl/fast/forms/button-default-title-expected.png:
platform/efl/fast/forms/button-generated-content-expected.png:
platform/efl/fast/forms/button-inner-block-reuse-expected.png:
platform/efl/fast/forms/button-sizes-expected.png:
platform/efl/fast/forms/button-style-color-expected.png:
platform/efl/fast/forms/button-table-styles-expected.png:
platform/efl/fast/forms/button-text-transform-expected.png:
platform/efl/fast/forms/button-white-space-expected.png:
platform/efl/fast/forms/control-clip-expected.png:
platform/efl/fast/forms/control-clip-overflow-expected.png:
platform/efl/fast/forms/control-restrict-line-height-expected.png:
platform/efl/fast/forms/disabled-select-change-index-expected.png:
platform/efl/fast/forms/encoding-test-expected.png:
platform/efl/fast/forms/fieldset-align-expected.png:
platform/efl/fast/forms/file/file-input-direction-expected.png:
platform/efl/fast/forms/file/file-input-disabled-expected.png:
platform/efl/fast/forms/floating-textfield-relayout-expected.png:
platform/efl/fast/forms/form-hides-table-expected.png:
platform/efl/fast/forms/image-border-expected.png:
platform/efl/fast/forms/input-appearance-bkcolor-expected.png:
platform/efl/fast/forms/input-appearance-default-bkcolor-expected.png:
platform/efl/fast/forms/input-appearance-focus-expected.png:
platform/efl/fast/forms/input-appearance-preventDefault-expected.png:
platform/efl/fast/forms/input-appearance-selection-expected.png:
platform/efl/fast/forms/input-appearance-visibility-expected.png:
platform/efl/fast/forms/input-appearance-width-expected.png:
platform/efl/fast/forms/input-button-sizes-expected.png:
platform/efl/fast/forms/input-disabled-color-expected.png:
platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.png:
platform/efl/fast/forms/input-field-text-truncated-expected.png:
platform/efl/fast/forms/input-readonly-dimmed-expected.png:
platform/efl/fast/forms/input-readonly-empty-expected.png:
platform/efl/fast/forms/input-spaces-expected.png:
platform/efl/fast/forms/input-table-expected.png:
platform/efl/fast/forms/input-text-click-inside-expected.png:
platform/efl/fast/forms/input-text-option-delete-expected.png:
platform/efl/fast/forms/input-text-self-emptying-click-expected.png:
platform/efl/fast/forms/input-text-word-wrap-expected.png:
platform/efl/fast/forms/input-type-text-min-width-expected.png:
platform/efl/fast/forms/input-value-expected.png:
platform/efl/fast/forms/input-width-expected.png:
platform/efl/fast/forms/listbox-bidi-align-expected.png:
platform/efl/fast/forms/listbox-scrollbar-incremental-load-expected.png:
platform/efl/fast/forms/listbox-width-change-expected.png:
platform/efl/fast/forms/menulist-clip-expected.png:
platform/efl/fast/forms/menulist-option-wrap-expected.png:
platform/efl/fast/forms/menulist-width-change-expected.png:
platform/efl/fast/forms/minWidthPercent-expected.png:
platform/efl/fast/forms/negativeLineHeight-expected.png:
platform/efl/fast/forms/option-index-expected.png:
platform/efl/fast/forms/option-script-expected.png:
platform/efl/fast/forms/option-strip-whitespace-expected.png:
platform/efl/fast/forms/option-text-clip-expected.png:
platform/efl/fast/forms/search-display-none-cancel-button-expected.png:
platform/efl/fast/forms/search-vertical-alignment-expected.png:
platform/efl/fast/forms/searchfield-heights-expected.png:
platform/efl/fast/forms/select-align-expected.png:
platform/efl/fast/forms/select-block-background-expected.png:
platform/efl/fast/forms/select-change-listbox-size-expected.png:
platform/efl/fast/forms/select-change-listbox-to-popup-expected.png:
platform/efl/fast/forms/select-change-popup-to-listbox-expected.png:
platform/efl/fast/forms/select-dirty-parent-pref-widths-expected.png:
platform/efl/fast/forms/select-display-none-style-resolve-expected.png:
platform/efl/fast/forms/select-initial-position-expected.png:
platform/efl/fast/forms/select-item-background-clip-expected.png:
platform/efl/fast/forms/select-list-box-with-height-expected.png:
platform/efl/fast/forms/select-size-expected.png:
platform/efl/fast/forms/select-visual-hebrew-expected.png:
platform/efl/fast/forms/select/optgroup-rendering-expected.png:
platform/efl/fast/forms/tabbing-input-iframe-expected.png:
platform/efl/fast/forms/targeted-frame-submission-expected.png:
platform/efl/fast/forms/text-style-color-expected.png:
platform/efl/fast/forms/textAreaLineHeight-expected.png:
platform/efl/fast/forms/textarea-align-expected.png:
platform/efl/fast/forms/textarea-width-expected.png:
platform/efl/fast/forms/textfield-focus-ring-expected.png:
platform/efl/fast/forms/textfield-outline-expected.png:
platform/efl/fast/forms/visual-hebrew-text-field-expected.png:

12:16 PM Changeset in webkit [126465] by abarth@webkit.org

4 edits in trunk/Source/WebCore

[V8] V8ScriptInstance is much more complicated than necessary
https://bugs.webkit.org/show_bug.cgi?id=94785

Reviewed by Kentaro Hara.

V8ScriptInstance just needs to be a one-line wrapper around OwnHandle.

bindings/v8/OwnHandle.h:

(WebCore::OwnHandle::get):

bindings/v8/ScriptInstance.cpp:

(WebCore::V8ScriptInstance::V8ScriptInstance):
(WebCore::V8ScriptInstance::~V8ScriptInstance):
(WebCore::V8ScriptInstance::instance):

bindings/v8/ScriptInstance.h:

(WebCore::V8ScriptInstance::create):
(V8ScriptInstance):

12:08 PM Changeset in webkit [126464] by commit-queue@webkit.org

11 edits in trunk

Serialization of JavaScript values does not appear to respect new HTML5 Structured Clone semantics
https://bugs.webkit.org/show_bug.cgi?id=65292

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-23
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Add function to construct a StringObject from a JSValue.
Similar functions already exist for NumberObject and
BooleanObject for example.

Export several symbols so address linking errors in
WebCore.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/BooleanObject.h:

(BooleanObject):

runtime/NumberObject.h:

(NumberObject):
(JSC):

runtime/StringObject.cpp:

(JSC::constructString):
(JSC):

runtime/StringObject.h:

(JSC):

Source/WebCore:

JSC now correctly serialize Boolean, Number and String objects as per
the structured clone algorithm specification. This patch reduces the
delta with the V8 implementation of SerializedScriptValue.

No new tests, already tested by fast/dom/Window/window-postmessage-clone.html

bindings/js/SerializedScriptValue.cpp:

(WebCore):
(WebCore::CloneSerializer::dumpStringObject):
(CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::readTerminal):

LayoutTests:

Update expected results for fast/dom/Window/window-postmessage-clone.html
now that String, Boolean and Number object are correctly serialized with
JSC.

fast/dom/Window/window-postmessage-clone-expected.txt:
platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt:

12:01 PM Changeset in webkit [126463] by commit-queue@webkit.org

6 edits in trunk

create different WebKit::WebMediaPlayer based on URL
https://bugs.webkit.org/show_bug.cgi?id=91301

Patch by Wei Jia <wjia@chromium.org> on 2012-08-23
Reviewed by Adam Barth.

Source/WebKit/chromium:

Pass URL to WebFrameClient::createMediaPlayer(). This allows creation
of different WebMediaPlayer implementations based on the URL.

public/WebFrameClient.h:

(WebKit::WebFrameClient::createMediaPlayer): add URL as additional argument.

src/WebMediaPlayerClientImpl.cpp:

(WebKit::createWebMediaPlayer): add URL as additional argument.
(WebKit::WebMediaPlayerClientImpl::loadInternal):

Tools:

Pass URL to createMediaPlayer. This corresponds to change in base
class WebKit::WebFrameClient.

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createMediaPlayer): add URL as additional argument.

DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

12:00 PM Changeset in webkit [126462] by mitz@apple.com

2 edits in branches/safari-536.26-branch/LayoutTests

Updated the expected results for this test after r125463.

platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:

11:56 AM Changeset in webkit [126461] by jsbell@chromium.org

8 edits in trunk/Source

IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
https://bugs.webkit.org/show_bug.cgi?id=94757

Reviewed by Tony Chang.

Source/WebCore:

Move the implementation of IDBCallbacks::onSuccess(IDBDatabaseBackendInterface)
from IDBRequest to the new IDBOpenDBRequest, which is the only request type that
should be receiving that callback.

No new tests - no functional changes.

Modules/indexeddb/IDBCallbacks.h:

(IDBCallbacks):
(WebCore::IDBCallbacks::onSuccess):

Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::onSuccess):
(WebCore):

Modules/indexeddb/IDBOpenDBRequest.h:

(IDBOpenDBRequest):

Modules/indexeddb/IDBRequest.cpp:
Modules/indexeddb/IDBRequest.h:

Source/WebKit/chromium:

Drop onSuccess(IDBDatabaseBackendImpl) overload from test, as it is no longer
implemented by IDBRequest.

tests/IDBRequestTest.cpp:

(WebCore::TEST):

11:47 AM Changeset in webkit [126460] by kbr@google.com

2 edits in trunk/LayoutTests

Web Inspector: three layout tests crashing with assertion failure
https://bugs.webkit.org/show_bug.cgi?id=94829

Unreviewed. Expanded suppressions.

platform/chromium/TestExpectations:

11:45 AM Changeset in webkit [126459] by commit-queue@webkit.org

6 edits
2 adds in trunk

[CSSRegions]Crash when moving anonymous block children inside a named flow
https://bugs.webkit.org/show_bug.cgi?id=90865

Patch by Andrei Onea <onea@adobe.com> on 2012-08-23
Reviewed by Abhishek Arya.

Source/WebCore:

When an anonymous block's children are detached in RenderBlock::collapseAnonymousBoxChild, the reference
to their enclosingRenderFlowThread is lost and causes a crash in RenderObject::willBeRemovedFromTree.
Because of this, we now maintain the enclosingRenderFlowThread during the whole lifetime of the
RenderBlock::collapseAnonymousBoxChild function, using a CurrentRenderFlowThreadMaintainer local.

Test: fast/regions/move-anonymous-block-inside-named-flow-crash.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseAnonymousBoxChild):

rendering/RenderFlowThread.cpp:

(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
Moved CurrentRenderFlowThreadMaintaner declaration from .cpp to .h, so that we can access it from
RenderBlock::collapseAnonymousBoxChild.

rendering/RenderFlowThread.h:

(CurrentRenderFlowThreadMaintainer):
(WebCore):

rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeRemovedFromTree):

LayoutTests:

Added test for crash which happens when the children of an anonymous block
inside a flow thread are moved.

fast/regions/move-anonymous-block-inside-named-flow-crash-expected.txt:
fast/regions/move-anonymous-block-inside-named-flow-crash.html:

11:43 AM Changeset in webkit [126458] by commit-queue@webkit.org

1 edit
3 adds in trunk/LayoutTests

Add test for decodeAudioData
https://bugs.webkit.org/show_bug.cgi?id=92620

Patch by Li Yin <li.yin@intel.com> on 2012-08-23
Reviewed by Chris Rogers.

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioContext-section
This test checks if successCallback or errorCallback can be invoked correctly when
there is a correct or error decoding.

webaudio/decode-audio-data-basic-expected.txt: Added.
webaudio/decode-audio-data-basic.html: Added.
webaudio/resources/media/invalid-audio-file.txt: Added.

11:41 AM Changeset in webkit [126457] by kevino@webkit.org

2 edits in trunk

[wx] Unreviewed build fix. Disable compilation of WebDOM file for now,
add the opentype directory, and remove old ATSUI files no longer in the tree.

11:37 AM Changeset in webkit [126456] by kevino@webkit.org

2 edits in trunk/Source/WebCore

[wx] Unreviewed build fix. Add wx to the list of platforms that use CoreText
APIs on Mac.

11:36 AM Changeset in webkit [126455] by kbr@google.com

2 edits in trunk/Source/WebKit/chromium

Convert ScrollableArea ASSERT_NOT_REACHED virtuals into pure virtuals
https://bugs.webkit.org/show_bug.cgi?id=93306

Unreviewed build fix.

src/ScrollbarGroup.h:

11:35 AM Changeset in webkit [126454] by kevino@webkit.org

2 edits in trunk/Source/WebCore

[wx] Unreviewed build fix. Don't rely on implicit casts, explicitly use the
Cursor constructor that takes a platform cursor for creating native cursors.

11:28 AM Changeset in webkit [126453] by jesus@webkit.org

5 edits in trunk

[EFL] Use WTF_USE_SOUP instead BUILDING_SOUP
https://bugs.webkit.org/show_bug.cgi?id=94744

Reviewed by Gustavo Noronha Silva.

There is no need to define BUILDING_SOUP if only WTF_USE_SOUP
is used.

GNUmakefile.am:
Source/cmake/OptionsEfl.cmake:

Source/WebKit2:

Use #if defined(WTF_USE_SOUP) instead of #if defined(BUILDING_SOUP)
since the former is used everywhere.

Shared/API/c/WKBase.h:

11:28 AM Changeset in webkit [126452] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Remove redundant check for negative values when using WebCore::Color::alpha()
https://bugs.webkit.org/show_bug.cgi?id=94811

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-23
Reviewed by Eric Seidel.

Though alpha() returns a signed value (int), its value is stored on an unsigned
typedef (RGBA32) and is safeguarded by alphaChannel() that its value never goes
beyond 255, so no integer overflow, thus we can safely remove redundant check
for negative values while using it.

This change does not affect behavior, so no new tests needed.

platform/graphics/Image.cpp:

(WebCore::Image::fillWithSolidColor):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground): Using hasAlpha() for readibility.

rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

rendering/style/RenderStyle.h:

11:20 AM Changeset in webkit [126451] by kbr@google.com

2 edits in trunk/LayoutTests

Web Inspector: three layout tests crashing with assertion failure
https://bugs.webkit.org/show_bug.cgi?id=94829

Unreviewed Chromium gardening. Suppressed failing tests.

platform/chromium/TestExpectations:

11:20 AM Changeset in webkit [126450] by zandobersek@gmail.com

4 edits
1 add in trunk

[Gtk] Move feature defines processing into a GNUmakefile that's simple to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=87127

Reviewed by Martin Robinson.

Add 'feature_defines_defaults' and 'feature_defines_overrides' variables
and define them, along with 'feature_defines' (changed from the all-caps version),
before webcore_cppflags.

GNUmakefile.am:

Source/WebCore:

List all the feature defines with their default value in
GNUmakefile.features.am and append them to the 'feature_defines_defaults'.
variable.

In GNUmakefile.am, include the GNUmakefile.features.am. When checking the
AM conditionals for feature-enabling, append the appropriate define to
'feature_defines_overrides'.

After all such overrides are performed, append the proper define (of which
value was possibly overridden) for each feature to the 'feature_defines'
variable. Finally, append all these defines to webcore_cppflags in the form
of macros for preprocessing.

No new tests - no new functionality.

GNUmakefile.am:
GNUmakefile.features.am: Added.

11:12 AM Changeset in webkit [126449] by mitz@apple.com

2 edits in branches/safari-536.26-branch/LayoutTests

Updated the expected results for this test after r125463.

fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:

11:02 AM Changeset in webkit [126448] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2] Free ewk context data on program exit.
https://bugs.webkit.org/show_bug.cgi?id=94808

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

Make sure the default Ewk_Context gets freed
on program exit.

The patch also fixes leaking of WKContextRef
inside Ewk_Context which should have been
adopted.

UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context::_Ewk_Context):
(ewk_context_default_get):

10:55 AM Changeset in webkit [126447] by ggaren@apple.com

2 edits in trunk/Source/WTF

Fixed a fastMallocForbid/Allow compile error for some compilers
https://bugs.webkit.org/show_bug.cgi?id=94775

Reviewed by Gavin Barraclough.

wtf/FastMalloc.h:

(WTF::fastMallocForbid()):
(WTF::fastMallocAllow()): Export, since these are called by JavaScriptCore.

10:51 AM Changeset in webkit [126446] by abarth@webkit.org

4 edits in trunk/Source/WebCore

[V8] ScheduledAction is ugly and needs a cleanup
https://bugs.webkit.org/show_bug.cgi?id=94784

Reviewed by Eric Seidel.

This patch updates ScheduledAction to use modern WebKit machinery, like
OwnHandle and Vector.

bindings/v8/OwnHandle.h:

(OwnHandle):

bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::~ScheduledAction):
(WebCore::ScheduledAction::execute):

bindings/v8/ScheduledAction.h:

(WebCore):
(ScheduledAction):
(WebCore::ScheduledAction::ScheduledAction):

10:45 AM Changeset in webkit [126445] by caseq@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: dblclick on Timeline overview no longer selects entire timeline range
https://bugs.webkit.org/show_bug.cgi?id=94826

Reviewed by Vsevolod Vlasov.

Only install a glass pane for drag-n-drop upon first mouseout event -- otherwise, glass pane
will interfere with double clicks.

inspector/front-end/UIUtils.js:

(WebInspector._elementDragStart.onMouseOut):
(WebInspector._elementDragStart):
(WebInspector._elementDragEnd):

10:41 AM Changeset in webkit [126444] by enne@google.com

22 edits in trunk/Source

Convert ScrollableArea ASSERT_NOT_REACHED virtuals
https://bugs.webkit.org/show_bug.cgi?id=93306

Reviewed by Darin Adler.

Source/WebCore:

ASSERT_NOT_REACHED is a bad way to make sure that a virtual function
gets an override, because it only fails at run-time in debug builds.

To fix this, convert the virtuals in ScrollableArea that have
ASSERT_NOT_REACHED to be either pure virtual or implemented directly
in ScrollableArea. Add implementations where necessary to make derived
classes concrete.

Additionally, consistently add OVERRIDE for virtual functions in
derived classes that override ScrollableArea methods.

WebCore.exp.in:
page/FrameView.h:

(FrameView):

platform/ScrollView.h:

(ScrollView):

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPosition):
(WebCore):
(WebCore::ScrollableArea::minimumScrollPosition):
(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore::ScrollableArea::visibleContentRect):

platform/ScrollableArea.h:

(ScrollableArea):
(WebCore::ScrollableArea::overhangAmount):

platform/chromium/FramelessScrollView.cpp:

(WebCore::FramelessScrollView::isOnActivePage):
(WebCore):
(WebCore::FramelessScrollView::scrollableAreaBoundingBox):

platform/chromium/FramelessScrollView.h:

(FramelessScrollView):

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::visibleHeight):
(WebCore):
(WebCore::PopupMenuWin::visibleWidth):
(WebCore::PopupMenuWin::contentsSize):
(WebCore::PopupMenuWin::isOnActivePage):
(WebCore::PopupMenuWin::scrollableAreaBoundingBox):

platform/win/PopupMenuWin.h:

(PopupMenuWin):

rendering/RenderListBox.cpp:
rendering/RenderListBox.h:

(RenderListBox):

Source/WebKit/chromium:

Add implementations where necessary to make derived classes concrete.
Add OVERRIDE for ScrollableArea functions.

src/ScrollbarGroup.h:

(ScrollbarGroup):
(WebKit::ScrollbarGroup::scrollCornerRect):

tests/ScrollAnimatorNoneTest.cpp:

(MockScrollableArea):

Source/WebKit/win:

Add implementations where necessary to make derived classes concrete.
Add OVERRIDE for ScrollableArea functions.

WebScrollBar.cpp:

(WebScrollBar::visibleHeight):
(WebScrollBar::visibleWidth):
(WebScrollBar::contentsSize):
(WebScrollBar::isOnActivePage):
(WebScrollBar::scrollableAreaBoundingBox):

WebScrollBar.h:

(WebScrollBar):

Source/WebKit2:

Add implementations where necessary to make derived classes concrete.
Add OVERRIDE for ScrollableArea functions.

UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::visibleHeight):
(WebKit):
(WebKit::WebPopupMenuProxyWin::visibleWidth):
(WebKit::WebPopupMenuProxyWin::contentsSize):
(WebKit::WebPopupMenuProxyWin::scrollableAreaBoundingBox):

UIProcess/win/WebPopupMenuProxyWin.h:

(WebPopupMenuProxyWin):

WebProcess/Plugins/PDF/BuiltInPDFView.h:

10:23 AM Changeset in webkit [126443] by commit-queue@webkit.org

7 edits in trunk

getComputedStyle returns wrong value for CSS3 2D transformations
https://bugs.webkit.org/show_bug.cgi?id=94211

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-08-23
Reviewed by Simon Fraser.

Source/WebCore:

When computed style is calculated for CSS3 2D transformation, content
box size is used. According to W3C specification, object's bounding
box should be used. This patch fixes transformation matrix calculation.

Layout tests getComputedStyle-transform.html and computed-style-origin.html
were modified to test changes.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::pixelSnappedSizingBox): Removed unused method

LayoutTests:

This change fixes getComputedStyle-transform.html test.
Before this change, the test doesn't do anything.
When new transformation value is set, it immediately read
back as an old value, thus computed style is equal to
an old style. Moreover, expected result is never checked.
Added new test case to computed-style-origin.html layout test.

fast/css/getComputedStyle/getComputedStyle-transform-expected.txt:
fast/css/getComputedStyle/getComputedStyle-transform.html:
transforms/2d/computed-style-origin-expected.txt:
transforms/2d/computed-style-origin.html:

10:08 AM Changeset in webkit [126442] by commit-queue@webkit.org

6 edits
2 adds in trunk

Distributed nodes should not share styles.
https://bugs.webkit.org/show_bug.cgi?id=90661

Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-23
Reviewed by Hajime Morita.

Source/WebCore:

styleForElement tries to use previous sibling's style for distributed
nodes. However distributed nodes are children of a shadow host, but
the nodes are not siblings as the result of distribution.
The spec is:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-dom-subtrees
So sharing previous sibling's style should be disabled for distrbuted
nodes.

Test: fast/dom/shadow/style-of-distributed-node.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
Initialized m_distributedToInsertionPoint. Its initial value is false.
(WebCore::StyleResolver::initForStyleResolve):
After invoking NodeRenderingContext, if the context returns any
insertion point, set m_distributedToInsertionPoint to be true.
Otherwise, false. The value is used in styleForElement.
(WebCore::StyleResolver::styleForElement):
If m_distributedToInsertionPoint is true, disable local sibling style
cache.

css/StyleResolver.h:

(StyleResolver):
Added a new member variable, m_distributedToInsertionPoint.
The variable keeps whether the m_element is distributed to an
insertion point.

LayoutTests:

fast/dom/shadow/style-of-distributed-node-expected.txt: Added.
fast/dom/shadow/style-of-distributed-node.html: Added.
fast/dom/shadow/user-modify-inheritance-expected.txt:

As this patch also change the user-modify-inheritance's test result,
updated the expected result.

fast/dom/shadow/user-modify-inheritance.html:

Added FIXME comment.

9:52 AM Changeset in webkit [126441] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Replace access ot HTMLMediaElement from MediaPlayerPrivateBlackBerry with methods in MediaPlayerClient - updated with notes from initial reviews. https://bugs.webkit.org/show_bug.cgi?id=84291

Reviewed by Eric Carlson.

Code standard compliance - no functional change, so no new tests required.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerExitFullscreen): (WebCore): (WebCore::HTMLMediaElement::mediaPlayerIsVideo): (WebCore::HTMLMediaElement::mediaPlayerContentBoxRect): (WebCore::HTMLMediaElement::mediaPlayerSetSize): (WebCore::HTMLMediaElement::mediaPlayerPause): (WebCore::HTMLMediaElement::mediaPlayerPlay): (WebCore::HTMLMediaElement::mediaPlayerIsPaused): (WebCore::HTMLMediaElement::mediaPlayerHostWindow): (WebCore::HTMLMediaElement::mediaPlayerWindowClipRect):
html/HTMLMediaElement.h: (HTMLMediaElement):
platform/graphics/MediaPlayer.h: (WebCore): (WebCore::MediaPlayerClient::mediaPlayerExitFullscreen): (WebCore::MediaPlayerClient::mediaPlayerIsVideo): (WebCore::MediaPlayerClient::mediaPlayerContentBoxRect): (WebCore::MediaPlayerClient::mediaPlayerSetSize): (WebCore::MediaPlayerClient::mediaPlayerPause): (WebCore::MediaPlayerClient::mediaPlayerPlay): (WebCore::MediaPlayerClient::mediaPlayerIsPaused): (WebCore::MediaPlayerClient::mediaPlayerHostWindow): (WebCore::MediaPlayerClient::mediaPlayerWindowClipRect):
platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp: (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::resizeSourceDimensions): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::onPauseStateChanged): (WebCore::MediaPlayerPrivate::onPlayNotified): (WebCore::MediaPlayerPrivate::onPauseNotified): (WebCore::MediaPlayerPrivate::onAuthenticationNeeded): (WebCore::MediaPlayerPrivate::showErrorDialog): (WebCore::MediaPlayerPrivate::platformWindow): (WebCore::MediaPlayerPrivate::isElementPaused): (WebCore::MediaPlayerPrivate::isTabVisible):
platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h: (MediaPlayerPrivate):

Patch by John Griggs <jgriggs@rim.com> on 2012-08-23

9:33 AM Changeset in webkit [126440] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.10/Source/WTF

[GTK] Disable the parallel garbage collector for the 1.10 stable release
https://bugs.webkit.org/show_bug.cgi?id=94823

Reviewed by Carlos Garcia Campos.

The parallel garbage collector is still causing some flaky crashes, so we should
probably disable it for the stable release.

wtf/Platform.h:

9:26 AM Changeset in webkit [126439] by commit-queue@webkit.org

2 edits in trunk

[GTK] The tarball should be called webkitgtk-x.x.x.tar.xz
https://bugs.webkit.org/show_bug.cgi?id=94572

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-08-23
Reviewed by Carlos Garcia Campos.

Change the name of the tarball to match the name of the library
and to disambiguate it from other WebKit ports.

configure.ac: Update the tarball name.

9:24 AM Changeset in webkit [126438] by commit-queue@webkit.org

5 edits
2 adds in trunk

Text Autosizing: Multiply large fonts less, as they are already more legible.
https://bugs.webkit.org/show_bug.cgi?id=94227

Patch by John Mellor <johnme@chromium.org> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Rather than uniformly multiplying font sizes by the multiplier (derived
from the width of the block), we should multiply fonts that are already
large less, since they are already more legible hence there is less need
for them to grow.

However it is still important to maintain differentiation between text
that the author specified to be of different sizes.

This algorithm multiplies text by the multiplier up until a predefined
"pleasant" font size; beyond that the computedSize goes up with
specifiedSize but at a gradient of less than 1 in order to gradually
fade out the size increase; finally for very large specifiedSizes the
computedSize will be the same as the specifiedSize.

For further details, including a graph, please see the bug report.

Test: fast/text-autosizing/various-font-sizes.html

rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::computeAutosizedFontSize):

Implements the custom multiplication. See comment for details.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::lineHeight):

Use computeAutosizedFontSize instead of directly multiplying.

(WebCore::RenderStyle::setFontSize):

Use computeAutosizedFontSize instead of directly multiplying.

LayoutTests:

Added test demonstrating how various font sizes are affected.

fast/text-autosizing/various-font-sizes-expected.html: Added.
fast/text-autosizing/various-font-sizes.html: Added.

9:21 AM Changeset in webkit [126437] by eae@chromium.org

17 edits
1 add in trunk/Source/WebCore

Remove dependency on RenderStyle from FractionalLayoutBoxExtent and LayoutBox
https://bugs.webkit.org/show_bug.cgi?id=94146

Reviewed by Eric Seidel.

FractionalLayoutBoxExtent and LayoutBox currently have a dependency on
RenderStyle to resolve writing mode and text direction.
This is undesirable and breaks encapsulation.

Change FractionalLayoutBoxExtent and LengthBox to take a writing mode
parameter, and text direction as needed, instead of a pointer to a
RenderStyle object.

No new tests, no change in functionality.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Add new WritingMode.h file.

css/CSSPrimitiveValueMappings.h:
css/CSSProperty.h:
css/CSSToStyleMap.h:

Change includes as needed.

platform/LengthBox.h:
platform/LengthBox.cpp:

(WebCore::LengthBox::logicalLeft):
(WebCore::LengthBox::logicalRight):
(WebCore::LengthBox::before):
(WebCore::LengthBox::after):
Change methods to take a WirtingMode parameter instead of a RenderStyle pointer.

(WebCore::LengthBox::start):
(WebCore::LengthBox::end):
Change methods to take WritingMode and TextDirection parameters instead of a RenderStyle pointer.

platform/graphics/FractionalLayoutBoxExtent.h:
platform/graphics/FractionalLayoutBoxExtent.cpp:

(WebCore::FractionalLayoutBoxExtent::logicalTop):
(WebCore::FractionalLayoutBoxExtent::logicalBottom):
(WebCore::FractionalLayoutBoxExtent::logicalLeft):
(WebCore::FractionalLayoutBoxExtent::logicalRight):
(WebCore::FractionalLayoutBoxExtent::before):
(WebCore::FractionalLayoutBoxExtent::after):
(WebCore::FractionalLayoutBoxExtent::setBefore):
(WebCore::FractionalLayoutBoxExtent::setAfter):
(WebCore::FractionalLayoutBoxExtent::mutableLogicalLeft):
(WebCore::FractionalLayoutBoxExtent::mutableLogicalRight):
(WebCore::FractionalLayoutBoxExtent::mutableBefore):
(WebCore::FractionalLayoutBoxExtent::mutableAfter):
Change methods to take a WritingMode parameter instead of a RenderStyle pointer.

(WebCore::FractionalLayoutBoxExtent::start):
(WebCore::FractionalLayoutBoxExtent::end):
(WebCore::FractionalLayoutBoxExtent::setStart):
(WebCore::FractionalLayoutBoxExtent::setEnd):
Change methods to take WritingMode and TextDirection parameters instead of a RenderStyle pointer.

platform/text/TextDirection.h:

(WebCore::isLeftToRightDirection):
Add convenience method.

platform/text/WritingMode.h: Added.

Move WritingMode enum from RenderStyleConstants to new file.

(WebCore::isHorizontalWritingMode):
(WebCore::isFlippedLinesWritingMode):
(WebCore::isFlippedBlocksWritingMode):
Add convenience methods for working with writing modes.

rendering/InlineFlowBox.cpp:
rendering/RenderBox.cpp:
rendering/RenderBox.h:
rendering/style/RenderStyle.h:

Update calls to FractionalLayoutBoxExtent/LengthBox to pass WritingMode/
TextDirection as needed.

rendering/style/RenderStyleConstants.h:

Remove WritingMode enum as it is now in a dedicated file.

9:11 AM WebKit Team edited by gyuyoung.kim@samsung.com

Move myself from committer to reviewer list (diff)

9:01 AM Changeset in webkit [126436] by gyuyoung.kim@samsung.com

2 edits in trunk/Tools

Unreviewed, upgrade gyuyoung to reviewer.
http://lists.webkit.org/pipermail/webkit-dev/2012-August/022004.html

Scripts/webkitpy/common/config/committers.py:

8:59 AM Changeset in webkit [126435] by pfeldman@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: introduce canFilter on panel (otherwise we check for function existence).
https://bugs.webkit.org/show_bug.cgi?id=94820

Reviewed by Alexander Pavlov.

Drive-by: fix for network panel sorting null pointer access.

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype.performSearch):
(WebInspector.NetworkPanel.prototype.canFilter):

inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.replaceAllWith):
(WebInspector.Panel.prototype.canFilter):
(WebInspector.Panel.prototype.performFilter):

inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype._updateFilterVisibility):
(WebInspector.SearchController.prototype._performFilter):

8:58 AM Changeset in webkit [126434] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2] ewk_intent_request API test does not free Eina_List
https://bugs.webkit.org/show_bug.cgi?id=94809

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

The used Eina_List should be freed due to ewk_intent_suggestions_get() documentation.

UIProcess/API/efl/tests/test_ewk2_intents.cpp:

(onIntentReceived):

8:48 AM Changeset in webkit [126433] by Carlos Garcia Campos

2 edits in trunk

Unreviewed. Bump WebKitGTK+ version number.

configure.ac: Bump version number to 1.11.0 now that we branched

for 1.10.

8:46 AM Changeset in webkit [126432] by pfeldman@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: introduce TimelineGrid.Calculator interface.
https://bugs.webkit.org/show_bug.cgi?id=94819

Reviewed by Alexander Pavlov.

This way we can compile TimelineGrid properly.

inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._calculateVisibleIndexes):

inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):
(WebInspector.TimelineGrid.Calculator):
(WebInspector.TimelineGrid.Calculator.prototype.computePosition):
(WebInspector.TimelineGrid.Calculator.prototype.formatTime):
(WebInspector.TimelineGrid.Calculator.prototype.minimumBoundary):
(WebInspector.TimelineGrid.Calculator.prototype.maximumBoundary):
(WebInspector.TimelineGrid.Calculator.prototype.boundarySpan):

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewCalculator.prototype.computePosition):
(WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineOverviewCalculator.prototype.setWindow):
(WebInspector.TimelineOverviewCalculator.prototype.formatTime):
(WebInspector.TimelineOverviewCalculator.prototype.maximumBoundary):
(WebInspector.TimelineOverviewCalculator.prototype.minimumBoundary):
(WebInspector.TimelineOverviewCalculator.prototype.boundarySpan):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._shouldShowFrames):
(WebInspector.TimelineCalculator.prototype.computePosition):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineCalculator.prototype.setWindow):
(WebInspector.TimelineCalculator.prototype.formatTime):
(WebInspector.TimelineCalculator.prototype.maximumBoundary):
(WebInspector.TimelineCalculator.prototype.minimumBoundary):
(WebInspector.TimelineCalculator.prototype.boundarySpan):

8:42 AM Changeset in webkit [126431] by commit-queue@webkit.org

9 edits in trunk/Source

[Chromium] Unnecessary delay when starting to update resources with an inactive vsync timer.
https://bugs.webkit.org/show_bug.cgi?id=94719

Patch by David Reveman <reveman@chromium.org> on 2012-08-23
Reviewed by James Robinson.

Source/WebCore:

Replace nextTickTime() with nextTickTimeIfActivated() and return
appropriate value when timer is inactive.

No new tests.

platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:

(WebCore::CCDelayBasedTimeSource::nextTickTimeIfActivated):
(WebCore::CCDelayBasedTimeSource::nextTickTarget):
(WebCore):
(WebCore::CCDelayBasedTimeSource::postNextTickTask):

platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::nextTickTimeIfActivated):

platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateController):

platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::processScheduledActions):

platform/graphics/chromium/cc/CCTimeSource.h:

(CCTimeSource):

Source/WebKit/chromium:

tests/CCSchedulerTestCommon.h:

8:36 AM Changeset in webkit [126430] by pfeldman@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: make treeoutline.js compiler-friendly
https://bugs.webkit.org/show_bug.cgi?id=94818

Reviewed by Alexander Pavlov.

This change declares base methods on TreeElement so that we did not need to check for their existence.

inspector/front-end/AdvancedSearchController.js:

(WebInspector.FileBasedSearchResultsPane.prototype._appendShowMoreMatchesElement):
(WebInspector.FileBasedSearchResultsPane.prototype._addFileTreeElement):

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.onselect):

inspector/front-end/SidebarPane.js:

(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.onexpand):
(WebInspector.SidebarPane.prototype.collapse):

inspector/front-end/treeoutline.js:

(TreeOutline.prototype._treeKeyDown):
(TreeOutline.prototype._searchInputKeyDown):
(TreeElement.prototype._fireDidChange):
(TreeElement.prototype._attach):
(TreeElement.treeElementDoubleClicked):
(TreeElement.prototype.collapse):
(TreeElement.prototype.expand):
(TreeElement.prototype.reveal):
(TreeElement.prototype.select):
(TreeElement.prototype.deselect):
(TreeElement.prototype.onpopulate):
(TreeElement.prototype.onenter):
(TreeElement.prototype.ondelete):
(TreeElement.prototype.onspace):
(TreeElement.prototype.onattach):
(TreeElement.prototype.onexpand):
(TreeElement.prototype.oncollapse):
(TreeElement.prototype.ondblclick):
(TreeElement.prototype.onreveal):
(TreeElement.prototype.onselect):

8:34 AM Changeset in webkit [126429] by yurys@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: use temporary directory for modules generated by compile-front-end.py
https://bugs.webkit.org/show_bug.cgi?id=94804

Reviewed by Pavel Feldman.

Create temporary directory for generated js modules and remove the directory
after the compilation.

inspector/compile-front-end.py:

8:11 AM Changeset in webkit [126428] by abecsi@webkit.org

3 edits in trunk/Source/WebKit2

[Qt][WK2] Helper functions used by the raw webview tests should not be guarded by HAVE_QTQUICK

Reviewed by Simon Hausmann.

This fixes the build if the QtQuick module is not present.

UIProcess/API/qt/tests/util.cpp:

(messageHandler):
(suppressDebugOutput):

UIProcess/API/qt/tests/util.h:

8:09 AM Changeset in webkit [126427] by Simon Hausmann

2 edits in trunk/Source/WebCore

[Qt] Fix make install on Windows
https://bugs.webkit.org/show_bug.cgi?id=94816

Reviewed by Laszlo Gombos.

This old left-over rule for Windows to add dlltarget to INSTALLS caused
various bugs: WebCore's Makefile had an actual install target that
tried to install the WebCore static library and it also screwed up
api.pri's install rule by overriding what is usually set up for qt
modules, i.e. the install path was missing INSTALL_ROOT. We don't need
these rules at all, the default qmake features take care of setting up
target install rules accordingly.

WebCore.pri:

8:08 AM Changeset in webkit [126426] by pfeldman@chromium.org

11 edits
1 add in trunk

Web Inspector: extract ParsedURL into a separate file.
https://bugs.webkit.org/show_bug.cgi?id=94817

Reviewed by Alexander Pavlov.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):

inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._rewriteHref):

inspector/front-end/ParsedURL.js: Added.

(WebInspector.ParsedURL):
(WebInspector.ParsedURL.completeURL):
(WebInspector.ParsedURL.prototype.get displayName):
(String.prototype.asParsedURL):

inspector/front-end/ResourceUtils.js:

(WebInspector.resourceURLForRelatedNode):

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):

inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

8:05 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos

(diff)

7:59 AM Changeset in webkit [126425] by pfeldman@chromium.org

12 edits
2 adds in trunk/Source/WebCore

Web Inspector: register context menu providers for lazily loaded panels.
https://bugs.webkit.org/show_bug.cgi?id=94812

Reviewed by Alexander Pavlov.

Panel descriptors now register providers that lazily load panels on demand.
Removed custom profiles context provider infrastructure in favor of generic one.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel):

inspector/front-end/NetworkPanelDescriptor.js: Added.

(WebInspector.NetworkPanelDescriptor):
(WebInspector.NetworkPanelDescriptor.prototype.appendApplicableItems):

inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection.prototype._contextMenuEventFired):

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilesPanel.prototype.appendApplicableItems.didReceiveHeapObjectId):
(WebInspector.ProfilesPanel.prototype.appendApplicableItems):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

inspector/front-end/ScriptsPanelDescriptor.js: Added.

(WebInspector.ScriptsPanelDescriptor):
(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):

inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:
inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):

7:55 AM Changeset in webkit [126424] by peter@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

6:42 AM WebKitGTK/1.10.x created by Carlos Garcia Campos

Add page for stable 1.10.x releases

6:33 AM Changeset in webkit [126423] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-1.10

Branching for the WebKitGTK+ 1.10 stable release

6:24 AM Changeset in webkit [126422] by Carlos Garcia Campos

3 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

GNUmakefile.am: Add idl files in Modules/quota to EXTRA_DIST.
GNUmakefile.list.am: Add missing files to compilation.

6:21 AM Changeset in webkit [126421] by commit-queue@webkit.org

11 edits in trunk

REGRESSION(r126306): it broke the plugin process
https://bugs.webkit.org/show_bug.cgi?id=94797

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2012-08-23
Reviewed by Xan Lopez.

GNUmakefile.am:

Source/WebCore:

GNUmakefile.am:
GNUmakefile.list.am:

Source/WebKit/gtk:

GNUmakefile.am:

Source/WebKit2:

GNUmakefile.am:

Tools:

GNUmakefile.am:

6:11 AM Changeset in webkit [126420] by Simon Hausmann

2 edits in trunk/Source/WebCore

Unreviewed trivial build fix for Qt/Mac on OS X 10.6: Avoid using an
enum value that clashes with an existing class name that's used in the
same file.

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):

6:04 AM Changeset in webkit [126419] by ryuan.choi@samsung.com

6 edits
5 adds in trunk/Tools

[EFL] Add url bar to EWebLauncher and MiniBrowser/Efl.
https://bugs.webkit.org/show_bug.cgi?id=63966

Reviewed by Kenneth Rohde Christiansen.

EWebLauncher and MiniBrowser/Efl did not have functionality that users
navigates the site which they want.
This patch adds the urlbar and functionality to load url which users want.

CMakeLists.txt:

Added to share urlbar theme for both EWebLauncher and MiniBrowser/Efl.

EWebLauncher/CMakeLists.txt:

Added urlbar.c and dependency of urlbar theme.
In addition, changed macro name to THEME_DIR to share the code easily.

EWebLauncher/ControlTheme/CMakeLists.txt: Added for urlbar theme.
EWebLauncher/ControlTheme/entry.edc: Implemented urlbar theme.
EWebLauncher/main.c:

Implemented to use the urlbar.
In addition, remove unnecessary border of webview to control webview and urlbar easily.
(_ELauncher):
(on_url_changed):
(browserCreate):
(closeWindow):
(findThemePath):

EWebLauncher/url_bar.c: Implemented functionality of the urlbar.

(_url_bar_url_get_with_protocol):
(on_urlbar_key_down):
(on_urlbar_mouse_down):
(on_urlbar_focus_out):
(url_bar_add):
(url_bar_del):
(url_bar_url_set):

EWebLauncher/url_bar.h: Added.
MiniBrowser/efl/CMakeLists.txt:
MiniBrowser/efl/main.c: Implemented to use the urlbar.

(_MiniBrowser):
(on_url_changed):
(browserCreate):

4:50 AM Changeset in webkit [126418] by kbalazs@webkit.org

5 edits in trunk/Tools

[nrwt, WTR] Remove workaround for timeout handing from r126062
https://bugs.webkit.org/show_bug.cgi?id=94609

Reviewed by Dirk Pranke.

Don't try to reset state if a timeout occured but inform
the harness that the web process is no longer reliable.

Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test): Remove the workaround. Furthermore, handle the case when
the pid is unknown.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::run):

WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dumpWebProcessUnresponsiveness):

WebKitTestRunner/TestInvocation.h:

(TestInvocation):

4:34 AM Changeset in webkit [126417] by zandobersek@gmail.com

1 edit
13 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Adding platform-specific baselines required after r126343 and r126372.

platform/gtk/fast/overflow/paged-x-div-expected.png: Added.
platform/gtk/fast/overflow/paged-x-div-expected.txt: Added.
platform/gtk/fast/overflow/paged-x-on-root-expected.png: Added.
platform/gtk/fast/overflow/paged-x-on-root-expected.txt: Added.
platform/gtk/fast/overflow/paged-y-div-expected.png: Added.
platform/gtk/fast/overflow/paged-y-div-expected.txt: Added.
platform/gtk/fast/overflow/paged-y-on-root-expected.png: Added.
platform/gtk/fast/overflow/paged-y-on-root-expected.txt: Added.
platform/gtk/media/track: Added.
platform/gtk/media/track/track-cue-rendering-horizontal-expected.png: Added.
platform/gtk/media/track/track-cue-rendering-horizontal-expected.txt: Added.
platform/gtk/media/track/track-cue-rendering-vertical-expected.png: Added.
platform/gtk/media/track/track-cue-rendering-vertical-expected.txt: Added.

4:30 AM Changeset in webkit [126416] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Build fix for WinCE after r126359.

rendering/RenderThemeWinCE.cpp:

3:49 AM WebKit Team edited by dominik.rottsches@intel.com

Adding myself as committer (diff)

3:46 AM Changeset in webkit [126415] by loislo@chromium.org

2 edits in trunk/PerformanceTests

WebInspector: unreviewed single line test fix.

The test has to open profiles panel explicitly because it is creating lazily.

inspector/heap-snapshot-performance-test.js:

3:31 AM Changeset in webkit [126414] by dominicc@chromium.org

11 edits
2 deletes in trunk

Unreviewed, rolling out r126391.
http://trac.webkit.org/changeset/126391
https://bugs.webkit.org/show_bug.cgi?id=94302

Breaks Chromium browser_tests AccessibilityFooter,
AccessibilityListMarkers, AccessibilityUI

Source/WebCore:

accessibility/AccessibilityNodeObject.cpp:
accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

accessibility/AccessibilityObject.cpp:
accessibility/AccessibilityObject.h:

(AccessibilityObject):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isDescendantOfElementType):

accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

LayoutTests:

accessibility/editable-webarea-context-menu-point.html:
accessibility/focusable-div-expected.txt: Removed.
accessibility/focusable-div.html: Removed.
accessibility/table-detection.html:
platform/mac/accessibility/listbox-hit-test.html:

3:08 AM Changeset in webkit [126413] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Allow collecting calls for Resource objects affecting their states
https://bugs.webkit.org/show_bug.cgi?id=94686

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-23
Reviewed by Pavel Feldman.

Allow collecting calls for WebGL Resource objects affecting their states.
Clone Call's mutable arguments before pushing it to the log.

inspector/InjectedScriptWebGLModuleSource.js:

(.):

2:52 AM Changeset in webkit [126412] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[BlackBerry] draw <video> on <canvas> does not work
https://bugs.webkit.org/show_bug.cgi?id=94791
PR #195866

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-08-23
Reviewed by George Staikos.

Re-implement MediaPlayerPrivate::paintCurrentFrameInContext() in the
blackberry port. This method is mainly called from <canvas>, and it
is supposed to paint video frames using software rendering path.

On the other hand, MediaPlayerPrivate::paint() will choose accelerated
rendering if possible.

media/video-canvas-alpha.html covers this.

platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::paint):
(WebCore):
(WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):

platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

2:42 AM Changeset in webkit [126411] by morrita@google.com

2 edits in trunk/LayoutTests

Unreviewed Chromium gardeing.

platform/chromium/TestExpectations:

2:24 AM Changeset in webkit [126410] by dominicc@chromium.org

2 edits in trunk/LayoutTests

2012-08-23 Dominic Cooney <dominicc@chromium.org>

[Chromium] Unreviewed gardening.

notifications-event-listener-crash.html test has non-deterministic
output on Chromium XP debug.

platform/chromium/TestExpectations:

2:04 AM Changeset in webkit [126409] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Gardening after r126350
https://bugs.webkit.org/show_bug.cgi?id=94787

Unreviewed gardening.

Gardening of media/track/track-cue-rendering-snap-to-lines-not-set.html.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-23

platform/efl/TestExpectations:

2:02 AM Changeset in webkit [126408] by morrita@google.com

1 edit
2 adds in trunk/LayoutTests

Unreviewed Chromium gardeing.

platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.txt: Added.
platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.txt: Added.

1:50 AM Changeset in webkit [126407] by haraken@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed. Build fix for r126399.

bindings/v8/ScriptInstance.cpp:

1:47 AM Changeset in webkit [126406] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[WK2] Refactoring: WebBackForwardList getters should be const
https://bugs.webkit.org/show_bug.cgi?id=94711

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

Before the change were not consistent with each other
(WebBackForwardList::entries() was const but WebBackForwardList::currentIndex() was not).
Besides having not const getters is not a good practice in C++. (Please read
Scott Meyers. Effective C++ (3rd edition). ISBN: 0-321-33487-6.
Item 3: 'Use const whenever possible').

UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):

UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::currentIndex):
(WebBackForwardList):

1:32 AM Changeset in webkit [126405] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: treat 0 cookies as "no cookies" and render it accordingly in the UI
https://bugs.webkit.org/show_bug.cgi?id=94732

Reviewed by Yury Semikhatsky.

inspector/front-end/RequestCookiesView.js:

(WebInspector.RequestCookiesView.prototype.get _gotCookies):

1:26 AM Changeset in webkit [126404] by zandobersek@gmail.com

4 edits in trunk/LayoutTests

Unreviewed gardening.

A follow-up to r126400, updating various baselines for fast/js/constructor-length.html
so they are correct.

platform/gtk/fast/js/constructor-length-expected.txt:
platform/mac/fast/js/constructor-length-expected.txt:
platform/qt/fast/js/constructor-length-expected.txt:

1:10 AM Changeset in webkit [126403] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Added missing SKIP keyword to platform/efl/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=94781

Unreviewed. Some layout tests which are expected missing should not make
expected result files during layout test.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-23

platform/efl/TestExpectations:

1:08 AM Changeset in webkit [126402] by kadam@inf.u-szeged.hu

2 edits in trunk/Tools

Unreviewed. Adding myself to committers list.

Scripts/webkitpy/common/config/committers.py:

12:54 AM Changeset in webkit [126401] by commit-queue@webkit.org

15 edits
2 adds in trunk

[EFL] Use vertical slider theme when the slider is vertical
https://bugs.webkit.org/show_bug.cgi?id=93838

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Applied vertical slider theme to the vertical sliders. The height
of the vertical slider is wrong when it's applied horizontal
slider theme.

And do not resize slider when its size is not specified. It's natural
to use the default value of renderer.

No new tests. It's covered by existing range and datalist tests.

platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustSliderTrackStyle):

LayoutTests:

Updated expected result because theme of the slider is changed.

The size of the renderSlider is changed to 129x12 from 129x11
because it has the slider thumb 12x12 and it is not resized when
the size is not specified.

platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
platform/efl/fast/forms/box-shadow-override-expected.png:
platform/efl/fast/forms/box-shadow-override-expected.txt:
platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
platform/efl/fast/forms/input-appearance-height-expected.png:
platform/efl/fast/forms/input-appearance-height-expected.txt:
platform/efl/fast/forms/range/input-appearance-range-expected.png:
platform/efl/fast/forms/range/input-appearance-range-expected.txt:
platform/efl/fast/forms/range/slider-padding-expected.png:
platform/efl/fast/forms/range/slider-padding-expected.txt:
platform/efl/fast/forms/range/slider-thumb-shared-style-expected.png:
platform/efl/fast/forms/range/slider-thumb-shared-style-expected.txt:
platform/efl/fast/repaint/slider-thumb-drag-release-expected.txt:

12:37 AM Changeset in webkit [126400] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed gardening.

After the TextTrackCue constructor was updated in r126350 the
expected constructor length is 3. Updating fast/js/constructor-length.html
to reflect that.

fast/js/constructor-length.html:

12:35 AM Changeset in webkit [126399] by haraken@chromium.org

94 edits in trunk/Source/WebCore

[V8] Remove almost all #include "V8Proxy.h"
https://bugs.webkit.org/show_bug.cgi?id=94777

Reviewed by Adam Barth.

No tests. No change in behavior.

bindings/v8/NPV8Object.cpp:
bindings/v8/PageScriptDebugServer.cpp:
bindings/v8/ScheduledAction.cpp:
bindings/v8/ScriptController.cpp:
bindings/v8/ScriptInstance.cpp:
bindings/v8/ScriptObject.cpp:
bindings/v8/ScriptRunner.cpp:
bindings/v8/SerializedScriptValue.cpp:
bindings/v8/V8AbstractEventListener.cpp:
bindings/v8/V8Binding.h:

(WebCore):

bindings/v8/V8BindingMacros.h:

(WebCore):

bindings/v8/V8Collection.h:
bindings/v8/V8DOMWindowShell.cpp:
bindings/v8/V8DOMWrapper.cpp:
bindings/v8/V8EventListener.cpp:
bindings/v8/V8GCController.cpp:
bindings/v8/V8LazyEventListener.cpp:
bindings/v8/V8NPObject.cpp:
bindings/v8/V8NPUtils.cpp:
bindings/v8/V8Proxy.h:

(WebCore):

bindings/v8/V8Utilities.cpp:
bindings/v8/WorkerContextExecutionProxy.cpp:
bindings/v8/WorkerScriptController.cpp:
bindings/v8/custom/V8ArrayBufferCustom.cpp:
bindings/v8/custom/V8ArrayBufferViewCustom.h:
bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
bindings/v8/custom/V8AudioContextCustom.cpp:
bindings/v8/custom/V8BlobCustom.cpp:
bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
bindings/v8/custom/V8ClipboardCustom.cpp:
bindings/v8/custom/V8ConsoleCustom.cpp:
bindings/v8/custom/V8CoordinatesCustom.cpp:
bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
bindings/v8/custom/V8DOMFormDataCustom.cpp:
bindings/v8/custom/V8DataViewCustom.cpp:
bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
bindings/v8/custom/V8DocumentCustom.cpp:
bindings/v8/custom/V8DocumentLocationCustom.cpp:
bindings/v8/custom/V8EntryCustom.cpp:
bindings/v8/custom/V8EntrySyncCustom.cpp:
bindings/v8/custom/V8EventCustom.cpp:
bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
bindings/v8/custom/V8HTMLCollectionCustom.cpp:
bindings/v8/custom/V8HTMLFormElementCustom.cpp:
bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
bindings/v8/custom/V8HTMLInputElementCustom.cpp:
bindings/v8/custom/V8HTMLLinkElementCustom.cpp:
bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
bindings/v8/custom/V8HTMLOutputElementCustom.cpp:
bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
bindings/v8/custom/V8HistoryCustom.cpp:
bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
bindings/v8/custom/V8IntentConstructor.cpp:
bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
bindings/v8/custom/V8LocationCustom.cpp:
bindings/v8/custom/V8MessageChannelConstructor.cpp:
bindings/v8/custom/V8MessageEventCustom.cpp:
bindings/v8/custom/V8MessagePortCustom.cpp:
bindings/v8/custom/V8MutationCallbackCustom.cpp:
bindings/v8/custom/V8MutationObserverCustom.cpp:
bindings/v8/custom/V8NamedNodeMapCustom.cpp:
bindings/v8/custom/V8NodeCustom.cpp:
bindings/v8/custom/V8NodeListCustom.cpp:
bindings/v8/custom/V8NotificationCenterCustom.cpp:
bindings/v8/custom/V8NotificationCustom.cpp:
bindings/v8/custom/V8PopStateEventCustom.cpp:
bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
bindings/v8/custom/V8SQLTransactionCustom.cpp:
bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
bindings/v8/custom/V8SVGDocumentCustom.cpp:
bindings/v8/custom/V8ScriptProfileCustom.cpp:
bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
bindings/v8/custom/V8StorageCustom.cpp:
bindings/v8/custom/V8StyleSheetListCustom.cpp:
bindings/v8/custom/V8TrackEventCustom.cpp:
bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
bindings/v8/custom/V8WebKitAnimationCustom.cpp:
bindings/v8/custom/V8WebKitPointConstructor.cpp:
bindings/v8/custom/V8WebSocketCustom.cpp:
bindings/v8/custom/V8WorkerContextCustom.cpp:
bindings/v8/custom/V8WorkerCustom.cpp:
bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
bindings/v8/custom/V8XSLTProcessorCustom.cpp:

12:34 AM Changeset in webkit [126398] by morrita@google.com

1 edit
6 deletes in trunk/LayoutTests

Unreviewed Chromium gardeing.

platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.txt: Removed.
platform/chromium-win-xp/media/track/track-cue-rendering-horizontal-expected.png: Removed.
platform/chromium-win-xp/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.txt: Removed.

Aug 22, 2012:

11:54 PM Changeset in webkit [126397] by haraken@chromium.org

10 edits in trunk/Source/WebCore

Unreviewed, rolling out r126348.
http://trac.webkit.org/changeset/126348
https://bugs.webkit.org/show_bug.cgi?id=94588

We should use v8::String::NewSymbol() for symbols. See
https://bugs.webkit.org/show_bug.cgi?id=94574#c10 for more
details

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateNamedConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):

bindings/v8/V8Binding.h:

(WebCore):

11:52 PM Changeset in webkit [126396] by mrowe@apple.com

2 edits in branches/safari-536.26-branch/LayoutTests

Fix another test.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-22

platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.txt:

11:29 PM Changeset in webkit [126395] by Philippe Normand

5 edits in trunk/LayoutTests

[GTK] media/video-duration-known-after-eos.html and media/media-element-play-after-eos.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=83790

Reviewed by Eric Seidel.

Refactor the tests to wait the loadedmetadata event before
starting playback and attempting any access to the duration
attribute. This is an attempt to eliminate flakyness of the tests.

media/media-element-play-after-eos-expected.txt:
media/media-element-play-after-eos.html:
media/video-duration-known-after-eos.html:
platform/gtk/TestExpectations:

11:10 PM Changeset in webkit [126394] by morrita@google.com

1 edit
21 adds in trunk/LayoutTests

Unreviewed Chromium gardeing.

platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png: Added.
platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.txt: Added.
platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png: Added.
platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.txt: Added.
platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png: Added.
platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt: Added.
platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png: Added.
platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt: Added.
platform/chromium-win-xp/media/track/track-cue-rendering-horizontal-expected.png: Added.
platform/chromium-win-xp/media/track/track-cue-rendering-horizontal-expected.txt: Added.
platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png: Added.
platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.txt: Added.
platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png: Added.
platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt: Added.
platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png: Added.
platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt: Added.

10:59 PM Changeset in webkit [126393] by haraken@chromium.org

14 edits in trunk/Source/WebCore

[V8] Remove V8Proxy from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=94773

Reviewed by Adam Barth.

To kill V8Proxy, we can remove V8Proxy uses from CodeGeneratorV8.pm.

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::wrapSlow):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

10:58 PM Changeset in webkit [126392] by commit-queue@webkit.org

9 edits
2 adds in trunk

Implement UndoManager's item() method
https://bugs.webkit.org/show_bug.cgi?id=94671

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-22
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch implements UndoManager's item() method and its V8 custom binding.
We need to use custom binding here because we need to return user objects
that are stored in a hidden property of DOMTransaction wrappers, not returning
the wrappers themselves.

Test: editing/undomanager/undomanager-item.html

bindings/js/JSUndoManagerCustom.cpp:

(WebCore::JSUndoManager::item):
(WebCore):

bindings/v8/DOMTransaction.cpp:

(WebCore::DOMTransaction::data):
(WebCore):
(WebCore::DOMTransaction::setData):
(WebCore::DOMTransaction::getFunction):

bindings/v8/DOMTransaction.h:
bindings/v8/custom/V8UndoManagerCustom.cpp:

(WebCore::V8UndoManager::transactCallback):
(WebCore::V8UndoManager::itemCallback):
(WebCore):

editing/UndoManager.cpp:

(WebCore::UndoManager::item):
(WebCore):

editing/UndoManager.h:

(UndoManager):

editing/UndoManager.idl:

LayoutTests:

editing/undomanager/undomanager-item-expected.txt: Added.
editing/undomanager/undomanager-item.html: Added.

10:54 PM Changeset in webkit [126391] by dmazzoni@google.com

11 edits
2 adds in trunk

AX: Focusable elements without a role should not be ignored
https://bugs.webkit.org/show_bug.cgi?id=94302

Reviewed by Chris Fleizach.

Source/WebCore:

One exception is the body element, because focusing the body is equivalent to
blurring the current focused element and does not result in a "focus" accessibility
notification.

Test: accessibility/focusable-div.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::nodeHasContentEditableAttributeSet):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests:

Adds a new test to make sure that a generic focusable element (like a div with tabindex=0)
can get focus and return an appropriate title, just like a form control or element with
an ARIA role.

Modifies three existing tests that were previously assuming that a focusable node
with no role would be ignored for accessibility ("accessibilityIsIgnored").

accessibility/editable-webarea-context-menu-point.html:
accessibility/focusable-div-expected.txt: Added.
accessibility/focusable-div.html: Added.
accessibility/table-detection.html:
platform/mac/accessibility/listbox-hit-test.html:

10:08 PM FeatureFlags edited by rniwa@webkit.org

Add UNDO_MANAGER (diff)

9:49 PM Changeset in webkit [126390] by haraken@chromium.org

22 edits in trunk/Source/WebCore

Unreviewed, rolling out r126383.
http://trac.webkit.org/changeset/126383
https://bugs.webkit.org/show_bug.cgi?id=82888

Chromium win build crash

bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):

bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):

dom/Clipboard.h:

(Clipboard):

platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::types):

platform/blackberry/ClipboardBlackBerry.h:

(ClipboardBlackBerry):

platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):

platform/chromium/ChromiumDataObject.h:

(ChromiumDataObject):

platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::types):

platform/chromium/ClipboardChromium.h:

(ClipboardChromium):

platform/efl/ClipboardEfl.cpp:

(WebCore::ClipboardEfl::types):

platform/efl/ClipboardEfl.h:

(ClipboardEfl):

platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::types):

platform/gtk/ClipboardGtk.h:

(ClipboardGtk):

platform/mac/ClipboardMac.h:

(ClipboardMac):

platform/mac/ClipboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::types):

platform/qt/ClipboardQt.h:

(ClipboardQt):

platform/win/ClipboardWin.cpp:

(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):

platform/win/ClipboardWin.h:

(ClipboardWin):

platform/wx/ClipboardWx.cpp:

(WebCore::ClipboardWx::types):

platform/wx/ClipboardWx.h:

(ClipboardWx):

8:46 PM Changeset in webkit [126389] by haraken@chromium.org

4 edits in trunk/Source/WebCore

[V8] Move m_isolatedWorlds and m_isolatedWorldSecurityOrigins from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94770

Reviewed by Adam Barth.

Now m_isolatedWorlds and m_isolatedWorldSecurityOrigins of V8Proxy
are used by ScriptController only. We can move them to ScriptController.

No tests. No change in behavior.

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
(WebCore::ScriptController::collectIsolatedContexts):

bindings/v8/ScriptController.h:

(ScriptController):

bindings/v8/V8Proxy.h:

(V8Proxy):

8:42 PM Changeset in webkit [126388] by haraken@chromium.org

7 edits in trunk/Source/WebCore

[V8] Move evaluate() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94768

Reviewed by Adam Barth.

To kill V8Proxy, we can move evaluate() from V8Proxy to ScriptController.

Renamed evaluate() to compileAndRunScript() to avoid name conflict

with existing ScriptController::evaluate().

Removed toV8Proxy() from NPV8Object, as it is no longer used.

No tests. No change in behavior.

bindings/v8/NPV8Object.cpp:

(_NPN_EvaluateHelper):

bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::compileAndRunScript):
(WebCore):
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::evaluateInIsolatedWorld):

bindings/v8/ScriptController.h:

(ScriptController):

bindings/v8/V8Proxy.cpp:
bindings/v8/V8Proxy.h:

8:38 PM Changeset in webkit [126387] by fpizlo@apple.com

20 edits
2 adds in trunk/Source/JavaScriptCore

Array accesses should remember what kind of array they are predicted to access
https://bugs.webkit.org/show_bug.cgi?id=94448

Reviewed by Gavin Barraclough.

Introduced the notion of DFG::Array::Mode, stored in node.arrayMode(), which allows nodes
to remember how they decided to access arrays. This permits the bytecode parser to "lock in"
the mode of access if it has profiling at its disposal, and it also allows the prediction
propagator to do a fixup of the array mode later in the optimization fixpoint.

This patch adds a healthy amount of new capability (specifically the ability of the parser
to lock in an array mode regardless of type predictions) and it also blows away a lot of
messy code.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

dfg/DFGArrayMode.cpp: Added.

(DFG):
(JSC::DFG::fromObserved):
(JSC::DFG::refineArrayMode):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):

dfg/DFGArrayMode.h: Added.

(DFG):
(JSC::DFG::canCSEStorage):
(JSC::DFG::modeForPut):
(JSC::DFG::modesCompatibleForStorageLoad):
(JSC::DFG::modeSupportsLength):

dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayModeWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGGraph.h:

(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):

dfg/DFGNode.h:

(JSC::DFG::Node::hasArrayMode):
(Node):
(JSC::DFG::Node::arrayMode):
(JSC::DFG::Node::setArrayMode):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::typedArrayDescriptor):
(DFG):
(JSC::DFG::SpeculativeJIT::speculateArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):

dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

8:09 PM Changeset in webkit [126386] by alexis@webkit.org

3 edits in trunk/Tools

Unreviewed update of my email.

Scripts/webkitpy/common/config/committers.py:
Scripts/webkitpy/common/config/watchlist:

7:51 PM Changeset in webkit [126385] by mrowe@apple.com

7 edits in branches/safari-536.26-branch/LayoutTests

Fix some more tests.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-22

http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt:
http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt:
http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt:
http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt:
http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt:
http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt:

7:33 PM Changeset in webkit [126384] by mrowe@apple.com

11 edits
1 add in branches/safari-536.26-branch/LayoutTests

Fix some tests on safari-536.26-branch.
https://bugs.webkit.org/show_bug.cgi?id=94759

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-22
Reviewed by Mark Rowe.

animations/animation-shorthand-name-order.html:
compositing/repaint/newly-composited-on-scroll.html:
editing/execCommand/crash-extend-selection-forward.html:
fast/events/drag-display-none-element.html:
fast/forms/autocomplete-off-with-default-value-does-not-clear.html:
fast/forms/hidden/change-type-to-hidden-after-updating-value.html:
fast/table/auto-table-layout-colgroup-removal-crash.html:
fast/text/title-crash-expected.txt: Added.
http/tests/security/video-poster-cross-origin-crash.html:
platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
plugins/npruntime/overrides-all-properties.html:

6:56 PM Changeset in webkit [126383] by commit-queue@webkit.org

22 edits in trunk/Source/WebCore

Consider replacing return type of Clipboard::types() from HashSet<String> to Vector<String>.
https://bugs.webkit.org/show_bug.cgi?id=82888

Patch by Vineet Chaudhary <Vineet> on 2012-08-22
Reviewed by Kentaro Hara.

As part of removing custom bindings of types Array Clipboard::types() needs to return
Vector<String> than HashSet<String>

No new tests. Exixting test should pass with this change as no behavoural changes.

bindings/js/JSClipboardCustom.cpp: Replace data type from HashSet<> to Vector<>.

(WebCore::JSClipboard::types):

bindings/v8/custom/V8ClipboardCustom.cpp: Ditto.

(WebCore::V8Clipboard::typesAccessorGetter):

dom/Clipboard.h: Ditto.

(Clipboard):

platform/blackberry/ClipboardBlackBerry.cpp: Ditto.

(WebCore::ClipboardBlackBerry::types):

platform/blackberry/ClipboardBlackBerry.h: Ditto.

(ClipboardBlackBerry):

platform/chromium/ChromiumDataObject.cpp: Ditto.

(WebCore::ChromiumDataObject::types):

platform/chromium/ChromiumDataObject.h: Ditto.

(ChromiumDataObject):

platform/chromium/ClipboardChromium.cpp: Ditto.

(WebCore::ClipboardChromium::types):

platform/chromium/ClipboardChromium.h: Ditto.

(ClipboardChromium):

platform/efl/ClipboardEfl.cpp: Ditto.

(WebCore::ClipboardEfl::types):

platform/efl/ClipboardEfl.h: Ditto.

(ClipboardEfl):

platform/gtk/ClipboardGtk.cpp: Ditto.

(WebCore::ClipboardGtk::types):

platform/gtk/ClipboardGtk.h: Ditto.

(ClipboardGtk):

platform/mac/ClipboardMac.h: Ditto.

(ClipboardMac):

platform/mac/ClipboardMac.mm: Ditto.

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

platform/qt/ClipboardQt.cpp: Ditto.

(WebCore::ClipboardQt::types):

platform/qt/ClipboardQt.h: Ditto.

(ClipboardQt):

platform/win/ClipboardWin.cpp: Ditto.

(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):

platform/win/ClipboardWin.h: Ditto.

(ClipboardWin):

platform/wx/ClipboardWx.cpp: Ditto.

(WebCore::ClipboardWx::types):

platform/wx/ClipboardWx.h: Ditto.

(ClipboardWx):

6:54 PM Changeset in webkit [126382] by kbr@google.com

1 edit
4 moves
20 deletes in trunk/LayoutTests

Unreviewed Chromium gardening. Optimized baselines from yesterday
with dpranke's new algorithm in webkit-patch optimize-baselines
from r126374 and r126380.

platform/chromium-linux/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
platform/chromium-linux/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
platform/chromium-linux/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
platform/chromium-linux/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
platform/chromium-mac/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
platform/chromium-mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
platform/chromium-mac/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
platform/chromium-mac/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
platform/chromium-win-xp/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
platform/chromium-win-xp/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
platform/chromium-win-xp/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
platform/chromium-win-xp/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
platform/chromium-win/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
platform/chromium-win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
platform/chromium-win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
platform/chromium-win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
platform/chromium/fast/canvas/canvas-scale-shadowBlur-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/canvas/canvas-scale-shadowBlur-expected.txt.
platform/chromium/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/canvas/canvas-scale-strokePath-shadow-expected.txt.
platform/chromium/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt.
platform/chromium/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt.

6:49 PM Changeset in webkit [126381] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

IndexedDB: tests for injection/extraction of idb keys
https://bugs.webkit.org/show_bug.cgi?id=94653

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-22
Reviewed by Tony Chang.

Added unit tests for key injection/extraction using
SerializedScriptValue. These were moved from chromium, now
that all uses of the API are through WebKit.

tests/IDBKeyPathTest.cpp:

(WebCore):
(WebCore::TEST):

6:34 PM Changeset in webkit [126380] by dpranke@chromium.org

2 edits in trunk/Tools

Fix typos in r126374
https://bugs.webkit.org/show_bug.cgi?id=94665
Unreviewed, build fix.

Fix two issues that snuck in, one that caused a crash if there
were no baselines to optimize and one that occurred as a result
of failing to rename a variable when I changed the recursion to
a loop in the previous patch.

Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(BaselineOptimizer._optimize_by_pushing_results_up):

6:33 PM Changeset in webkit [126379] by ggaren@apple.com

6 edits in trunk/Source

ThreadRestrictionVerifier should be opt-in, not opt-out
https://bugs.webkit.org/show_bug.cgi?id=94761

Reviewed by Mark Hahnenberg.

../JavaScriptCore:

Removed explicit calls to disable the verifier, since it's off by default now.

parser/SourceProvider.h:

(JSC::SourceProvider::SourceProvider):
(SourceProvider):

runtime/SymbolTable.h:

(JSC::SharedSymbolTable::SharedSymbolTable):

../WTF:

WebKit's JavaScript engine supports use on multiple threads, so default-on
is not appropriate for most of our objects, and it causes lots of suprious
assertions.

wtf/MetaAllocator.cpp:

(WTF::MetaAllocatorHandle::MetaAllocatorHandle): No need to turn off
explicitly, since it's off by default now.

wtf/ThreadRestrictionVerifier.h:

(WTF::ThreadRestrictionVerifier::ThreadRestrictionVerifier): Turn off by default.

(WTF::ThreadRestrictionVerifier::setMutexMode):
(WTF::ThreadRestrictionVerifier::setDispatchQueueMode):
(WTF::ThreadRestrictionVerifier::turnOffVerification): These assertions
about state transitions were inconsistent with each other, and impossible
to maintain with default off, so I removed them.

6:28 PM Changeset in webkit [126378] by jamesr@google.com

41 edits
4 copies
6 moves
4 deletes in trunk/Source

[chromium] Change WebLayer from a concrete type to a pure virtual interface
https://bugs.webkit.org/show_bug.cgi?id=94174

Reviewed by Adrienne Walker.

Source/Platform:

This changes WebLayer from a value type to a pure virtual interface and changes Web*Layers from subtypes to
standalone types that have a WebLayer. This better isolates the implementation from the interface and, since
it's not possible to re-wrap an existing layer, makes cleanup explicit instead of requiring the caller to
invoke special cleanup methods before shutdown.

chromium/public/WebContentLayer.h:

(WebContentLayer):

chromium/public/WebExternalTextureLayer.h:

(WebExternalTextureLayer):

chromium/public/WebIOSurfaceLayer.h:

(WebIOSurfaceLayer):

chromium/public/WebImageLayer.h:

(WebImageLayer):

chromium/public/WebLayer.h:

(WebKit):
(WebLayer):
(WebKit::WebLayer::~WebLayer):

chromium/public/WebScrollableLayer.h: Removed.
chromium/public/WebScrollbarLayer.h:

(WebScrollbarLayer):

chromium/public/WebSolidColorLayer.h:

(WebKit):
(WebSolidColorLayer):
(WebKit::WebSolidColorLayer::~WebSolidColorLayer):

chromium/public/WebVideoLayer.h:

(WebVideoLayer):

Source/WebCore:

This updates WebCore code for the WebLayer interface changes. Classes that have ownership of specific layer
types (such as DrawingBufferChromium, Canvas2DLayerBridge and ScrollingCoordinatorChromium) hold ownership
of a specific type and a pointer to the WebLayer to GraphicsLayerChromium to be included in the final layer
tree. GraphicsLayerChromium holds a WebContentLayer and (optionally) a WebImageLayer and WebLayer (for
m_transformLayer) and assembles the final layer tree.

page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(WebCore::scrollableLayerForGraphicsLayer):
(WebCore):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):

platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):

platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):

platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::setContentsTo):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(WebCore::GraphicsLayerChromium::contentLayer):
(WebCore::GraphicsLayerChromium::contentsLayer):

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::rootLayer):

platform/graphics/chromium/LayerChromium.h:

Source/WebKit/chromium:

This updates the implementation of the Web*Layer family to the new design and updates callers in WebViewImpl /
NonCompositedContentHost / LinkHighlight.

WebKit.gypi:
src/LinkHighlight.cpp:

(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::contentLayer):
(WebKit::LinkHighlight::clipLayer):
(WebKit::LinkHighlight::releaseResources):
(WebKit::LinkHighlight::computeHighlightLayerPathAndPosition):
(WebKit::LinkHighlight::startHighlightAnimation):
(WebKit::LinkHighlight::updateGeometry):

src/LinkHighlight.h:

(LinkHighlight):

src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):

src/NonCompositedContentHost.h:
src/WebContentLayer.cpp: Removed.
src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayer::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::layer):
(WebKit):
(WebKit::WebContentLayerImpl::setDoubleSided):
(WebKit::WebContentLayerImpl::setContentsScale):
(WebKit::WebContentLayerImpl::setUseLCDText):
(WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
(WebKit::WebContentLayerImpl::paintContents):

src/WebContentLayerImpl.h:

(WebContentLayerImpl):

src/WebExternalTextureLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp.

(WebKit):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::layer):
(WebKit::WebExternalTextureLayerImpl::setTextureId):
(WebKit::WebExternalTextureLayerImpl::setFlipped):
(WebKit::WebExternalTextureLayerImpl::setUVRect):
(WebKit::WebExternalTextureLayerImpl::setOpaque):
(WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha):
(WebKit::WebExternalTextureLayerImpl::willModifyTexture):
(WebKit::WebExternalTextureLayerImpl::setRateLimitContext):
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebKit::WebExternalTextureLayerImpl::prepareTexture):
(WebKit::WebExternalTextureLayerImpl::context):

src/WebExternalTextureLayerImpl.h: Copied from Source/Platform/chromium/public/WebVideoLayer.h.

(WebKit):
(WebExternalTextureLayerImpl):

src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp.

(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayerImpl::layer):

src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h.

(WebCore):
(WebKit):
(WebIOSurfaceLayerImpl):

src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp.

(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayerImpl::WebImageLayerImpl):
(WebKit::WebImageLayerImpl::~WebImageLayerImpl):
(WebKit::WebImageLayerImpl::layer):
(WebKit::WebImageLayerImpl::setBitmap):

src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp.

(WebCore):
(WebKit):
(WebImageLayerImpl):

src/WebLayer.cpp: Removed.
src/WebLayerImpl.cpp:

(WebKit::WebLayer::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit):
(WebKit::WebLayerImpl::id):
(WebKit::WebLayerImpl::invalidateRect):
(WebKit::WebLayerImpl::invalidate):
(WebKit::WebLayerImpl::addChild):
(WebKit::WebLayerImpl::insertChild):
(WebKit::WebLayerImpl::replaceChild):
(WebKit::WebLayerImpl::setChildren):
(WebKit::WebLayerImpl::removeFromParent):
(WebKit::WebLayerImpl::removeAllChildren):
(WebKit::WebLayerImpl::setAnchorPoint):
(WebKit::WebLayerImpl::anchorPoint):
(WebKit::WebLayerImpl::setAnchorPointZ):
(WebKit::WebLayerImpl::anchorPointZ):
(WebKit::WebLayerImpl::setBounds):
(WebKit::WebLayerImpl::bounds):
(WebKit::WebLayerImpl::setMasksToBounds):
(WebKit::WebLayerImpl::masksToBounds):
(WebKit::WebLayerImpl::setMaskLayer):
(WebKit::WebLayerImpl::setReplicaLayer):
(WebKit::WebLayerImpl::setOpacity):
(WebKit::WebLayerImpl::opacity):
(WebKit::WebLayerImpl::setOpaque):
(WebKit::WebLayerImpl::opaque):
(WebKit::WebLayerImpl::setPosition):
(WebKit::WebLayerImpl::position):
(WebKit::WebLayerImpl::setSublayerTransform):
(WebKit::WebLayerImpl::sublayerTransform):
(WebKit::WebLayerImpl::setTransform):
(WebKit::WebLayerImpl::transform):
(WebKit::WebLayerImpl::setDrawsContent):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::setPreserves3D):
(WebKit::WebLayerImpl::setUseParentBackfaceVisibility):
(WebKit::WebLayerImpl::setBackgroundColor):
(WebKit::WebLayerImpl::setFilters):
(WebKit::WebLayerImpl::setBackgroundFilters):
(WebKit::WebLayerImpl::setDebugBorderColor):
(WebKit::WebLayerImpl::setDebugBorderWidth):
(WebKit::WebLayerImpl::setDebugName):
(WebKit::WebLayerImpl::setAnimationDelegate):
(WebKit::WebLayerImpl::addAnimation):
(WebKit::WebLayerImpl::removeAnimation):
(WebKit::WebLayerImpl::pauseAnimation):
(WebKit::WebLayerImpl::suspendAnimations):
(WebKit::WebLayerImpl::resumeAnimations):
(WebKit::WebLayerImpl::hasActiveAnimation):
(WebKit::WebLayerImpl::transferAnimationsTo):
(WebKit::WebLayerImpl::setForceRenderSurface):
(WebKit::WebLayerImpl::setScrollPosition):
(WebKit::WebLayerImpl::setScrollable):
(WebKit::WebLayerImpl::setHaveWheelEventHandlers):
(WebKit::WebLayerImpl::setShouldScrollOnMainThread):
(WebKit::WebLayerImpl::setNonFastScrollableRegion):
(WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers):
(WebKit::WebLayerImpl::setFixedToContainerLayer):
(WebKit::WebLayerImpl::layer):

src/WebLayerImpl.h:

(WebCore):
(WebLayerImpl):

src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setRootLayer):

src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::create):

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):

src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):

src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

src/WebScrollableLayer.cpp: Removed.
src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp.

(WebKit):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::layer):
(WebKit::WebScrollbarLayerImpl::setScrollLayer):

src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h.

(WebCore):
(WebKit):
(WebScrollbarLayerImpl):

src/WebSolidColorLayerImpl.cpp:

(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
(WebKit::WebSolidColorLayerImpl::layer):
(WebKit):
(WebKit::WebSolidColorLayerImpl::setBackgroundColor):

src/WebSolidColorLayerImpl.h:

(WebCore):
(WebKit):
(WebSolidColorLayerImpl):

src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp.

(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::~WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::layer):
(WebKit::WebVideoLayerImpl::active):

src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp.

(WebCore):
(WebKit):
(WebVideoLayerImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

src/WebViewImpl.h:
tests/ImageLayerChromiumTest.cpp:

(WebCore::TEST):

tests/WebLayerTest.cpp:
tests/WebLayerTreeViewTest.cpp:

6:27 PM Changeset in webkit [126377] by haraken@chromium.org

8 edits
2 adds in trunk/Source/WebCore

[V8] Move runScript() from V8Proxy to ScriptRunner
https://bugs.webkit.org/show_bug.cgi?id=94706

Reviewed by Adam Barth.

To kill V8Proxy, we can move runScript() from V8Proxy to ScriptRunner.

ScriptRunner::runScript() should be a static method.

It should receive ScriptExecutionContext on which the script is evaluated.

After this patch is landed, I'll remove WorkerContextExecutionContext::runScript()

and ScriptDebugServer::runScript().

No tests. No change in behavior.

UseV8.cmake:
WebCore.gypi:
bindings/v8/ScriptController.cpp:
bindings/v8/ScriptRunner.cpp: Added.

(WebCore):
(WebCore::ScriptRunner::runScript):

bindings/v8/ScriptRunner.h: Added.

(WebCore):
(ScriptRunner):

bindings/v8/V8Binding.cpp:

(WebCore::handleMaxRecursionDepthExceeded):
(WebCore):

bindings/v8/V8Binding.h:

(WebCore):

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluate):

bindings/v8/V8Proxy.h:

(V8Proxy):

6:23 PM Changeset in webkit [126376] by abarth@webkit.org

2 edits in trunk/Source/WebCore

[V8] OwnHandle doesn't need to support weak handles
https://bugs.webkit.org/show_bug.cgi?id=94760

Reviewed by Kentaro Hara.

No code uses makeWeak(). We can drop support for it and simplify this
class.

bindings/v8/OwnHandle.h:

(WebCore):
(OwnHandle):
(WebCore::OwnHandle::OwnHandle):
(WebCore::OwnHandle::~OwnHandle):
(WebCore::OwnHandle::get):
(WebCore::OwnHandle::set):
(WebCore::OwnHandle::clear):

6:12 PM Changeset in webkit [126375] by haraken@chromium.org

7 edits in trunk/Source/WebCore

[V8] Remove V8Proxy from getXPathNSResolver()
https://bugs.webkit.org/show_bug.cgi?id=94715

Reviewed by Adam Barth.

The V8Proxy* argument of getXPathNSResolver(..., V8Proxy* = 0) is not used. We can remove it.

We can rename getXPathNSResolver() to toXPathNSResolver().

We can move toXPathNSResolver() from V8DOMWrapper to V8Binding, since other toXXX() methods are written in V8Binding.

Change the return value of toXPathNSResolver() from RefPtr to PassRefPtr.

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(JSValueToNative):

bindings/v8/V8Binding.cpp:

(WebCore::toXPathNSResolver):
(WebCore):

bindings/v8/V8Binding.h:

(WebCore):

bindings/v8/V8DOMWrapper.cpp:
bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

6:08 PM Changeset in webkit [126374] by dpranke@chromium.org

3 edits in trunk/Tools

Baseline optimizer should try to optimize per-port if global optimization fails
https://bugs.webkit.org/show_bug.cgi?id=94665

Reviewed by Adam Barth.

Add a fallback strategy for optimizing baselines if the default
one fails; this one simply attempts to shift baselines up in the
tree and consolidates them if a parent and child in the fallback
path have the same result. This strategy is somewhat flawed in
that we will always put something in a parent dir even if we
"shouldn't"; for example, if chromium-mac produces a different
result from chromium-win and chromium-linux, then the new
algorithm will move the mac result into platform/chromium,
leaving chromium-mac empty. This result is still correct, but
perhaps confusing.

I haven't done much testing of this algorithm yet, so it's not
clear how many cases where this does a better job than the
default algorithm and how many it'll do a worse job.

Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(BaselineOptimizer._find_optimal_result_placement):
(BaselineOptimizer._optimize_by_most_specific_common_directory):
(BaselineOptimizer):
(BaselineOptimizer._optimize_by_pushing_results_up):
(BaselineOptimizer._find_in_fallbackpath):

Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_platform_mac_different):

6:07 PM Changeset in webkit [126373] by kbr@google.com

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r126325.
http://trac.webkit.org/changeset/126325
https://bugs.webkit.org/show_bug.cgi?id=94644

Caused subtle but reproducible failure to call onload handler
properly in an SVG layout test in Chromium Mac Debug builds,
indicating potentially larger problem

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadTimerFired):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::decrementRequestCount):

6:00 PM Changeset in webkit [126372] by victor@rosedu.org

17 edits
13 adds in trunk

Display a TextTrackCue when snap-to-lines flag is set
https://bugs.webkit.org/show_bug.cgi?id=79751

Reviewed by Tony Chang.

Source/WebCore:

This patch implements rendering functionality for a given text track,
following closer the exact WebVTT specification. There are two new classes
which have been added in order to succesfully cover rendering when of a text
track cue.

RenderTextTrackCue handles the specific rendering algorithm required,
by checking for overlaps with other boxes that are in the same
container (these can be any other boxes, not necessarily other cues,
the video controls, for example).

TextTrackCueBox extends HTMLDivElement and is an intermediate layer
between the renderer class and the actual cue object. Its purpose is
to instantiate the particular renderer and cover all the default CSS
styling that needs to be applied to the cue.

The layout is done in two steps:

Step 1: Layout the TextTrackCue with default CSS properties set (this is

the TextTrackCueBox decorated with the respective CSS elements)

Step 2: RenderTextTrackCue adjusts the box position depending on the

parameters of the TextTrackCue object and the overlaps that may occur with
previously positioned cues.

Tests: media/track/track-cue-rendering-horizontal.html

media/track/track-cue-rendering-vertical.html

CMakeLists.txt: Updated to include RenderTextTrackCue.
GNUmakefile.list.am: Updated to include RenderTextTrackCue.
Target.pri: Updated to include RenderTextTrackCue.
WebCore.gypi: Updated to include RenderTextTrackCue.
WebCore.vcproj/WebCore.vcproj: Updated to include RenderTextTrackCue.
WebCore.xcodeproj/project.pbxproj: Updated to include RenderTextTrackCue.
css/mediaControls.css: Removed unreliable CSS.

(video::-webkit-media-text-track-display): Removed properties.

html/shadow/MediaControlElements.cpp: Updated to not use the new class.

(RenderTextTrackContainerElement):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Simplified
the function by moving the check if track is rendered in TextTrack and used
the TextTrackCueBox for cues.

html/track/TextTrack.cpp: Added a new method.

(WebCore::TextTrack::isRendered): Method that returns whether the track should
be rendered or not.
(WebCore):

html/track/TextTrack.h: Added the isRendered method.

(TextTrack):

html/track/TextTrackCue.cpp: Added several helper methods and

the TextTrackCueBox.
(WebCore):
(WebCore::TextTrackCueBox::TextTrackCueBox): The TextTrackCueBox extends
the HTMLDivElement and represents a bridge class between RenderTextTrackCue
and TextTrackCue. This is required as the layout is done in two steps, as
explained on top of the ChangeLog entry.
(WebCore::TextTrackCueBox::getCue): Returns the associated TextTrackCue object.
(WebCore::TextTrackCueBox::applyCSSProperties): Applies a part of the default CSS
properties, as defined by section 3.5.1 of the WebVTT specification.
(WebCore::TextTrackCueBox::shadowPseudoId): Moved the shadow pseudo id.
(WebCore::TextTrackCueBox::createRenderer): Creates the particular renderer.
(WebCore::TextTrackCue::TextTrackCue): Corrected the internal writing mode map.
(WebCore::TextTrackCue::calculateComputedLinePosition): Updated the compute line
position algorithm. This requires, however, a method to consider only rendered
tracks (and therefore will be addressed completely in subsequent changeset).
(WebCore::TextTrackCue::calculateDisplayParameters): Updated and corrected the
computed display parameters to match the current specification.
(WebCore::TextTrackCue::getDisplayTree): Update to use the TextTrackCueBox class
and moved CSS application to the respective class.
(WebCore::TextTrackCue::getPositionCoordinates): Added comment to specify in which
situation this method is used and change visibility to private.
(WebCore::TextTrackCue::getCSSWritingMode): Returns the CSS writing mode corresponding
to the cue writing mode.
(WebCore::TextTrackCue::getCSSSize): Returns the cue width / height (depending on the
writing direction.
(WebCore::TextTrackCue::getCSSPosition): Returns the default display position, that is
used in the first layout step.

html/track/TextTrackCue.h:

(WebCore):
(TextTrackCueBox):
(WebCore::TextTrackCueBox::create): Initialization method.
(TextTrackCue):
(WebCore::TextTrackCue::getWritingDirection): Helper method to return the internal
values used to represent the writing direction.

rendering/RenderTextTrackCue.cpp: Added.

(WebCore):
(WebCore::RenderTextTrackCue::RenderTextTrackCue):
(WebCore::RenderTextTrackCue::layout): The rendering steps, as mentioned in
the WebVTT rendering rules. Currently, this treats only the snap-to-lines set
case. It is implemented following closely the spec, and might be subject to
change as discussions on various bugs evolve.
(WebCore::RenderTextTrackCue::initializeLayoutParameters): Steps 1 - 7.
(WebCore::RenderTextTrackCue::placeBoxInDefaultPosition): Steps 8 - 10.
(WebCore::RenderTextTrackCue::isOutside): Inline method to check if the cue is outside.
(WebCore::RenderTextTrackCue::isOverlapping): Inline method to check if the cue overlaps other boxes.
(WebCore::RenderTextTrackCue::shouldSwitchDirection): Step 12.
(WebCore::RenderTextTrackCue::moveBoxesByStep): Step 13.
(WebCore::RenderTextTrackCue::switchDirection): Steps 15 - 18.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Cue repositioning
for text track cue when the snap to lines flag is set.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesNotSet): Cue repositioning
for text track cue when the snap to lines flag is not set. Not implemented yet.

rendering/RenderTextTrackCue.h: Added.

(WebCore):
(RenderTextTrackCue): Rendering class, handling the display of cues.

LayoutTests:

Test cases covering snap-to-lines horizontal and vertical positioning of cues.

media/track/captions-webvtt/captions-snap-to-lines-set.vtt: Added.
media/track/track-cue-rendering-horizontal.html: Added.
media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Updated.
media/track/track-cue-rendering-vertical.html: Added.
media/video-test.js: Updated to support pixel test dumps.
platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png: Added.
platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Added.
platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png: Added.
platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Added.
platform/chromium/TestExpectations: Marking these temporarily as IMAGE fail, as they will

anyway require new baselines.

platform/mac/media/track/track-cue-rendering-horizontal-expected.png: Added.
platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Added.
platform/mac/media/track/track-cue-rendering-vertical-expected.png: Added.
platform/mac/media/track/track-cue-rendering-vertical-expected.txt: Added.

5:59 PM Changeset in webkit [126371] by dpranke@chromium.org

7 edits in trunk/Tools

add debug info, another test to webkit-patch optimize-baselines
https://bugs.webkit.org/show_bug.cgi?id=94762

Reviewed by Adam Barth.

This patch adds more debug logging for optimize-baselines so
that you can tell the before and after states and figure out
what the command is actually deciding to do.

Also, this command adds a (disabled) test for the problem in bug

It's disabled because we don't have the fix yet (that

will be posted in a patch to that bug).

There should be no functional changes in this patch apart from
the additional logging.

Note that adding the debug logging exposed a bug in
filesystem_mock.relpath() (that would return None if the path
wasn't a subpath of the start); the real relpath computes a
relpath with parent dirs. Fixing this revealed a bad check in
the style checker's change_directory() call which was checking
for None.

Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(BaselineOptimizer._find_optimal_result_placement):
(BaselineOptimizer):
(BaselineOptimizer._optimize_by_most_specific_common_directory):
(BaselineOptimizer._move_baselines):
(BaselineOptimizer.optimize):

Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.disabled_test_platform_mac_different):

Scripts/webkitpy/common/system/filesystem.py:

(FileSystem):

Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem):
(MockFileSystem.init):
(MockFileSystem.relpath):

Scripts/webkitpy/common/system/filesystem_unittest.py:

(RealFileSystemTest.test_sep):

Scripts/webkitpy/style/main.py:

(change_directory):

5:38 PM Changeset in webkit [126370] by haraken@chromium.org

8 edits in trunk/Source/WebCore

[V8] Move matchesCurrentContext() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94596

Reviewed by Adam Barth.

To kill V8Proxy:

We can move matchesCurrentContext() from V8Proxy to ScriptController.
We can remove V8Proxy::isolatedWorldContext() since it is not used by anybody.
We can remove V8Proxy::finishedWithEvent() since it is empty.

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::finishedWithEvent):
(WebCore::ScriptController::matchesCurrentContext):
(WebCore):

bindings/v8/ScriptController.h:

(ScriptController):

bindings/v8/V8Proxy.cpp:
bindings/v8/V8Proxy.h:

(V8Proxy):

5:36 PM Changeset in webkit [126369] by commit-queue@webkit.org

13 edits
2 adds in trunk

Source/WebCore: [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
https://bugs.webkit.org/show_bug.cgi?id=73819

Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
Reviewed by Chris Fleizach.

Added a new role, Toggle Button, based on whether aria-pressed is present.
http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed

Test: platform/gtk/accessibility/aria-toggle-button-role.html

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole): using buttonRoleType
to classify a button-related role.
(WebCore::AccessibilityNodeObject::determineAriaRoleAttribute): using buttonRoleType
to classify a button-related role.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::ariaPressedIsPresent): checks if aria-pressed
attribute is present.
(WebCore::AccessibilityObject::buttonRoleType): returns a specific button-related
role if the object is a button-related role.

accessibility/AccessibilityObject.h:

(AccessibilityObject): added new role ToggleButtonRole.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole): using buttonRoleType
to classify a button-related role.

accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(atkRole): added a mapping between ToggleButtonRole and
ATK_ROLE_TOGGLE_BUTTON.

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(createAccessibilityRoleMap): added a mapping between
ToggleButtonRole and NSAccessibilityButtonRole

Source/WebKit/chromium: Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
https://bugs.webkit.org/show_bug.cgi?id=73819

Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
Reviewed by Chris Fleizach.

Added a new role, Toggle Button, based on whether aria-pressed is present.
http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed

public/WebAccessibilityRole.h: added WebAccessibilityRoleToggleButton that

matchs with WebCore ToggleButtonRole

src/AssertMatchingEnums.cpp: added the assert matching rule for

WebAccessibilityRoleToggleButton and ToggleButtonRole

Tools: Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
https://bugs.webkit.org/show_bug.cgi?id=73819

Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
Reviewed by Chris Fleizach.

Added a new role, Toggle Button, based on whether aria-pressed is present.
http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed

DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(roleToString): added "ToggleButton" string for WebAccessibilityRoleToggleButton

LayoutTests: [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
https://bugs.webkit.org/show_bug.cgi?id=73819

Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
Reviewed by Chris Fleizach.

Added a test to verify that when aria-pressed is present, buttons
will have the appropiate role.

platform/gtk/accessibility/aria-toggle-button-role-expected.txt: Added.
platform/gtk/accessibility/aria-toggle-button-role.html: Added.

5:13 PM Changeset in webkit [126368] by victor@rosedu.org

2 edits in trunk/Tools

2012-08-23 Victor Carbune <victor@rosedu.org>

Add myself to the committer list
https://bugs.webkit.org/show_bug.cgi?id=94659

Reviewed by James Robinson.

Added my email and IRC handle.

Scripts/webkitpy/common/config/committers.py:

5:08 PM Changeset in webkit [126367] by kbr@google.com

2 edits
20 adds in trunk/LayoutTests

[Chromium] Need baselines for new paged-x and paged-y tests in fast/overflow after r126343
https://bugs.webkit.org/show_bug.cgi?id=94748

Unreviewed Chromium gardening. Added baselines via garden-o-matic.

platform/chromium-linux/fast/overflow/paged-x-div-expected.png: Added.
platform/chromium-linux/fast/overflow/paged-x-on-root-expected.png: Added.
platform/chromium-linux/fast/overflow/paged-y-div-expected.png: Added.
platform/chromium-linux/fast/overflow/paged-y-on-root-expected.png: Added.
platform/chromium-mac-snowleopard/fast/overflow/paged-x-div-expected.png: Added.
platform/chromium-mac-snowleopard/fast/overflow/paged-x-on-root-expected.png: Added.
platform/chromium-mac-snowleopard/fast/overflow/paged-y-div-expected.png: Added.
platform/chromium-mac-snowleopard/fast/overflow/paged-y-on-root-expected.png: Added.
platform/chromium-mac/fast/overflow/paged-x-div-expected.png: Added.
platform/chromium-mac/fast/overflow/paged-x-on-root-expected.png: Added.
platform/chromium-mac/fast/overflow/paged-y-div-expected.png: Added.
platform/chromium-mac/fast/overflow/paged-y-on-root-expected.png: Added.
platform/chromium-win/fast/overflow/paged-x-div-expected.png: Added.
platform/chromium-win/fast/overflow/paged-x-div-expected.txt: Added.
platform/chromium-win/fast/overflow/paged-x-on-root-expected.png: Added.
platform/chromium-win/fast/overflow/paged-x-on-root-expected.txt: Added.
platform/chromium-win/fast/overflow/paged-y-div-expected.png: Added.
platform/chromium-win/fast/overflow/paged-y-div-expected.txt: Added.
platform/chromium-win/fast/overflow/paged-y-on-root-expected.png: Added.
platform/chromium-win/fast/overflow/paged-y-on-root-expected.txt: Added.
platform/chromium/TestExpectations:

Removed expected failures.

4:23 PM Changeset in webkit [126366] by dgrogan@chromium.org

5 edits
3 adds in trunk

IndexedDB: revert int version when version change transaction aborts
https://bugs.webkit.org/show_bug.cgi?id=94662

Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/intversion-revert-on-abort.html

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::resetIntVersion):
One-liner modeled after resetVersion.

(WebCore):

Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

LayoutTests:

This is tested in some other layout tests but it should have its own,
so add intversion-revert-on-abort.html.

storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt:

FAIL event.target.result.version should be 0 will be resolved at least
when we figure out if we can make the default version an integer
during the transition period.

storage/indexeddb/intversion-revert-on-abort-expected.txt: Added.
storage/indexeddb/intversion-revert-on-abort.html: Added.
storage/indexeddb/resources/intversion-revert-on-abort.js: Added.

(test):
(deleteSuccess):
(firstUpgradeNeededCallback):
(openSuccess):
(secondUpgradeNeededCallback):
(errorAfterAbortCallback):
(finalSuccessCallback):

4:08 PM WebKit Team edited by alexis@webkit.org

(diff)

3:58 PM Changeset in webkit [126365] by jpfau@apple.com

20 edits
7 adds in trunk

Allow blocking of Web SQL databases in third-party web workers
https://bugs.webkit.org/show_bug.cgi?id=94170

Reviewed by Adam Barth.

Source/WebCore:

Web workers did not previously know anything about the document that
spawned them. This is undefined for shared workers, but for dedicated
workers, we now pipe the information through.

Tests: http/tests/security/cross-origin-worker-websql-allowed.html

http/tests/security/cross-origin-worker-websql.html

Modules/webdatabase/WorkerContextWebDatabase.cpp: Pass information about the top origin to canAccessDatabase

(WebCore::WorkerContextWebDatabase::openDatabase):
(WebCore::WorkerContextWebDatabase::openDatabaseSync):

WebCore.exp.in: Make SecurityOrigin::isolatedCopy const
page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::isolatedCopy):
(WebCore::SecurityOrigin::canAccessStorage):

page/SecurityOrigin.h:
workers/DedicatedWorkerContext.cpp: Pass topOrigin

(WebCore::DedicatedWorkerContext::create):
(WebCore::DedicatedWorkerContext::DedicatedWorkerContext):

workers/DedicatedWorkerContext.h:

(DedicatedWorkerContext):

workers/DedicatedWorkerThread.cpp: Pass topOrigin

(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerContext):

workers/DedicatedWorkerThread.h:

(DedicatedWorkerThread):

workers/SharedWorkerContext.cpp: Pass topOrigin

(WebCore::SharedWorkerContext::SharedWorkerContext):

workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::SharedWorkerThread):
(WebCore::SharedWorkerThread::createWorkerContext):

workers/SharedWorkerThread.h:

(SharedWorkerThread): Pass topOrigin

workers/WorkerContext.cpp:

(WebCore::WorkerContext::WorkerContext):

workers/WorkerContext.h:

(WebCore::WorkerContext::topOrigin):
(WorkerContext):

workers/WorkerMessagingProxy.cpp: Pass topOrigin

(WebCore::WorkerMessagingProxy::startWorkerContext):

workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::create):
(WorkerThreadStartupData):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):

workers/WorkerThread.h:

(WorkerThread):

Source/WebKit/chromium:

Web workers did not previously know anything about the document that
spawned them. This is undefined for shared workers, but for dedicated
workers, we now pipe the information through.

src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext): Pass top document's origin

LayoutTests:

Created tests for accessing openDatabase from a third party and first party dedicated workers when third-party blocking is on and off.

http/tests/security/cross-origin-worker-websql-allowed-expected.txt: Added.
http/tests/security/cross-origin-worker-websql-allowed.html: Added.
http/tests/security/cross-origin-worker-websql-expected.txt: Added.
http/tests/security/cross-origin-worker-websql.html: Added.
http/tests/security/resources/cross-origin-iframe-for-worker-websql.html: Added.
http/tests/security/resources/document-for-cross-origin-worker-websql.html: Added.
http/tests/security/resources/worker-for-websql.js: Added.

(self.onmessage):

3:55 PM Changeset in webkit [126364] by annacc@chromium.org

3 edits in trunk/LayoutTests

[Chromium/GTK/EFL] Flaky media/track/track-mode test.
https://bugs.webkit.org/show_bug.cgi?id=83878

Reviewed by Eric Seidel.

This test should only care that cuechange events are fired when the TextTrack
mode is set to HIDDEN or SHOWING. Because the events are asynchronous, we
shouldn't test the order of them, just that they occur.

media/track/track-mode-expected.txt:
media/track/track-mode.html:

3:52 PM Changeset in webkit [126363] by haraken@chromium.org

14 edits in trunk/Source

[V8] Move context() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94593

Reviewed by Adam Barth.

Source/WebCore:

This patch removes V8Proxy::context(Frame*).
This patch moves V8Proxy::context() to ScriptController::context().
This patch renames ScriptController::context() to ScriptController::currentWorldContext(),

for naming consistency with ScriptController::maintWorldContext().

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::context):
(WebCore):

bindings/v8/ScriptController.h:

(ScriptController):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setNamedHiddenWindowReference):

bindings/v8/V8Proxy.cpp:
bindings/v8/V8Proxy.h:

(V8Proxy):

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):
(WebCore::V8DOMWindow::eventAccessorGetter):
(WebCore::V8DOMWindow::eventAccessorSetter):
(WebCore::DialogHandler::dialogCreated):
(WebCore::toV8):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::openCallback):

Source/WebKit/chromium:

To kill V8Proxy, we can move context() from V8Proxy to ScriptController.

No tests. No change in behavior.

src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::windowObjectCleared):

src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

3:44 PM Changeset in webkit [126362] by haraken@chromium.org

16 edits in trunk/Source/WebCore

[V8] Remove V8Proxy from V8DOMWrapper::instantiateV8Object()
https://bugs.webkit.org/show_bug.cgi?id=94713

Reviewed by Adam Barth.

To kill V8Proxy, V8DOMWrapper::instantiateV8Object() should receive Frame*
instead of V8Proxy*.

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::wrapSlow):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/v8/V8DOMWrapper.cpp:

(WebCore):
(WebCore::V8DOMWrapper::instantiateV8Object):

bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

3:28 PM Changeset in webkit [126361] by jsbell@chromium.org

2 edits in trunk/Source/WebCore

IndexedDB: IDBRequest can be destructed during abort
https://bugs.webkit.org/show_bug.cgi?id=94618

Reviewed by Tony Chang.

If there are no script references, an IDBRequest could be kept alive
only by enqueued events. On document destruction, the parent transaction
is aborted, which aborts the request. During the abort, the enqueued events
are deleted, releasing the last reference to the IDBRequest which then
destructs in mid-method call and an "unfinished" state, hitting an assert.

This patch keeps the IDBRequest alive through the completion of the abort()
method, which will enqueue another event. In the document destruction case,
this will end up with the IDBRequest having stop() called on it which will
send the IDBRequest into EarlyDeath state, satisfying the destructor assert.

Addresses existing layout tests that behave flakily in Chromium port.

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::abort):

3:27 PM Changeset in webkit [126360] by haraken@chromium.org

5 edits in trunk/Source/WebCore

[V8] Move precompileScript() from V8Proxy to ScriptSourceCode
https://bugs.webkit.org/show_bug.cgi?id=94701

Reviewed by Adam Barth.

To kill V8Proxy, we can move precompileScript() from V8Proxy
to ScriptSourceCode.

No tests. No change in behavior.

bindings/v8/ScriptSourceCode.cpp:

(WebCore::ScriptSourceCode::precompileScript):
(WebCore):

bindings/v8/ScriptSourceCode.h:

(ScriptSourceCode):

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluate):

bindings/v8/V8Proxy.h:

(V8Proxy):

3:25 PM Changeset in webkit [126359] by commit-queue@webkit.org

69 edits in trunk/Source

Reduce Font.h includes across project -- improves RenderObject.h compile time
https://bugs.webkit.org/show_bug.cgi?id=93629

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-22
Reviewed by Eric Seidel.

Source/WebCore:

RenderStyle.h no longer depends on Font.h. The files that transitively
need to be updated with proper includes are fixed.

No new tests. Functionality should remain the same.

accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
accessibility/mac/WebAccessibilityObjectWrapper.mm:
bindings/objc/DOM.mm:
css/CSSComputedStyleDeclaration.cpp:
css/CSSPrimitiveValue.cpp:
css/StyleResolver.h:
dom/CharacterData.cpp:
dom/ElementRareData.h:
dom/NodeRenderingContext.cpp:
dom/Text.cpp:
editing/TextIterator.cpp:
editing/mac/EditorMac.mm:
html/HTMLTitleElement.cpp:
html/shadow/TextControlInnerElements.cpp:
inspector/InspectorOverlay.cpp:
page/ContextMenuController.cpp:
page/PrintContext.cpp:
platform/efl/RenderThemeEfl.cpp:
platform/graphics/FontMetrics.h:
platform/gtk/RenderThemeGtk.cpp:
platform/gtk/RenderThemeGtk2.cpp:
platform/mac/HTMLConverter.mm:
rendering/EllipsisBox.cpp:
rendering/FlowThreadController.cpp:
rendering/InlineBox.cpp:
rendering/InlineFlowBox.cpp:
rendering/InlineFlowBox.h:

(WebCore):

rendering/RenderButton.cpp:
rendering/RenderCombineText.cpp:
rendering/RenderCombineText.h:
rendering/RenderDeprecatedFlexibleBox.cpp:
rendering/RenderEmbeddedObject.h:

(WebCore):

rendering/RenderFileUploadControl.cpp:
rendering/RenderFullScreen.h:
rendering/RenderImage.cpp:
rendering/RenderInline.cpp:
rendering/RenderListItem.cpp:
rendering/RenderListMarker.cpp:
rendering/RenderMultiColumnBlock.cpp:
rendering/RenderRegion.h:
rendering/RenderRuby.cpp:
rendering/RenderRubyRun.cpp:
rendering/RenderScrollbar.cpp:
rendering/RenderTable.cpp:
rendering/RenderTableCell.cpp:
rendering/RenderTableRow.cpp:
rendering/RenderTableSection.cpp:
rendering/RenderTextControl.cpp:
rendering/RenderTextControlMultiLine.cpp:
rendering/RenderThemeChromiumSkia.cpp:
rendering/RenderView.cpp:
rendering/TextAutosizer.cpp:
rendering/mathml/RenderMathMLBlock.h:
rendering/style/KeyframeList.h:
rendering/style/RenderStyle.cpp:
rendering/style/RenderStyle.h:

(WebCore):

rendering/style/StyleInheritedData.cpp:
rendering/svg/RenderSVGBlock.cpp:
rendering/svg/RenderSVGInlineText.h:
svg/SVGLengthContext.cpp:
svg/SVGTRefElement.cpp:

Source/WebKit/chromium:

Adds includes due to change in RenderStyle.h

src/WebFrameImpl.cpp:
src/mac/WebSubstringUtil.mm:

Source/WebKit/win:

Adds includes due to change in RenderStyle.h

DOMCoreClasses.cpp:

Source/WebKit2:

Adds includes due to change in RenderStyle.h

WebProcess/WebPage/mac/WebPageMac.mm:

3:23 PM Changeset in webkit [126358] by commit-queue@webkit.org

17 edits in trunk/LayoutTests

Test cases under fast/filesystem/workers are flaky when using JSC
https://bugs.webkit.org/show_bug.cgi?id=94747

Patch by Leo Yang <leoyang@rim.com> on 2012-08-22
Reviewed by Yong Li.

These test cases sometimes can't complete because the worker object
created by startWorker() has been gc'ed before the worker thread complete.
We should reference the object to avoid it being gc'ed.

fast/filesystem/workers/async-operations.html:
fast/filesystem/workers/file-entry-to-uri-sync.html:
fast/filesystem/workers/file-from-file-entry-sync.html:
fast/filesystem/workers/file-from-file-entry.html:
fast/filesystem/workers/file-writer-empty-blob.html:
fast/filesystem/workers/file-writer-events.html:
fast/filesystem/workers/file-writer-gc-blob.html:
fast/filesystem/workers/file-writer-sync-truncate-extend.html:
fast/filesystem/workers/file-writer-sync-write-overlapped.html:
fast/filesystem/workers/file-writer-truncate-extend.html:
fast/filesystem/workers/file-writer-write-overlapped.html:
fast/filesystem/workers/simple-persistent-sync.html:
fast/filesystem/workers/simple-persistent.html:
fast/filesystem/workers/simple-temporary-sync.html:
fast/filesystem/workers/simple-temporary.html:
fast/filesystem/workers/sync-operations.html:

3:01 PM Changeset in webkit [126357] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

win64 compile error fix for BinaryPropertyList.cpp
https://bugs.webkit.org/show_bug.cgi?id=94122

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-08-22
Reviewed by Eric Seidel.

Fixed compile errors for MSVC x64 without changing performance

platform/cf/BinaryPropertyList.cpp:

(WebCore::BinaryPropertyListSerializer::appendStringObject):

2:55 PM Changeset in webkit [126356] by commit-queue@webkit.org

2 edits in trunk/Tools

Don't unconditionally define NOMINMAX on Windows
https://bugs.webkit.org/show_bug.cgi?id=94742

Patch by Scott Graham <scottmg@chromium.org> on 2012-08-22
Reviewed by Adrienne Walker.

Avoids a warning when building on Windows when NOMINMAX is defined
elsewhere or on the command line.

TestWebKitAPI/config.h:

2:55 PM Changeset in webkit [126355] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

HTMLTreeBuilder::furthestBlockForFormattingElement should belong to HTMLElementStack
https://bugs.webkit.org/show_bug.cgi?id=93857

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-22
Reviewed by Eric Seidel.

HTMLTreeBuilder::furthestBlockForFormattingElement should belong to
HTMLElementStack because it traverses the element stack and finds the
furthest block for the given formatting element.

Currently, it belongs to HTMLTreeBuilder just because
isSpecialNode(const HTMLStackItem*) function used by
furthestBlockForFormattingElement is internal to HTMLTreeBuilder.

Moved isSpecialNode to HTMLStackItem and changed
furthestBlockForFormattingElement to be a method of HTMLElementStack.

No behavior change. Just a refactoring.

html/parser/HTMLElementStack.cpp:

(WebCore):
(WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
(WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
(WebCore::HTMLElementStack::furthestBlockForFormattingElement):

html/parser/HTMLElementStack.h:

(HTMLElementStack):

html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::isInHTMLNamespace):
(HTMLStackItem):
(WebCore::HTMLStackItem::isNumberedHeaderElement):
(WebCore::HTMLStackItem::isTableBodyContextElement):
(WebCore::HTMLStackItem::isSpecialNode):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

html/parser/HTMLTreeBuilder.h:

2:49 PM Changeset in webkit [126354] by mhahnenberg@apple.com

11 edits
3 adds in trunk/Source/JavaScriptCore

Separate MarkStackThreadSharedData from MarkStack
https://bugs.webkit.org/show_bug.cgi?id=94294

Reviewed by Filip Pizlo.

MarkStackThreadSharedData is soon going to have data to allow for a parallel copying
mode too, so to separate our concerns we should split it out into its own set of files
and rename it to GCThreadSharedData. For now this is purely a cosmetic refactoring.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
heap/GCThreadSharedData.cpp: Added.

(JSC):
(JSC::GCThreadSharedData::resetChildren):
(JSC::GCThreadSharedData::childVisitCount):
(JSC::GCThreadSharedData::markingThreadMain):
(JSC::GCThreadSharedData::markingThreadStartFunc):
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::~GCThreadSharedData):
(JSC::GCThreadSharedData::reset):

heap/GCThreadSharedData.h: Added.

(JSC):
(GCThreadSharedData):

heap/Heap.h:

(Heap):

heap/ListableHandler.h:

(ListableHandler):

heap/MarkStack.cpp:

(JSC::MarkStack::MarkStack):
(JSC::MarkStack::~MarkStack):

heap/MarkStack.h:

(JSC):
(MarkStack):
(JSC::MarkStack::sharedData):

heap/MarkStackInlineMethods.h: Added.

(JSC):
(JSC::MarkStack::append):
(JSC::MarkStack::appendUnbarrieredPointer):
(JSC::MarkStack::appendUnbarrieredValue):
(JSC::MarkStack::internalAppend):
(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::addUnconditionalFinalizer):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):

heap/SlotVisitor.h:

(JSC):
(SlotVisitor):
(JSC::SlotVisitor::SlotVisitor):

2:42 PM Changeset in webkit [126353] by zandobersek@gmail.com

2 edits in trunk/Tools

REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
https://bugs.webkit.org/show_bug.cgi?id=94704

Reviewed by Dirk Pranke.

Use tolerance=0 when acquiring diff image of reftest output.

Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._compare_output_with_reference):

2:29 PM Changeset in webkit [126352] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

Speed up compilation of tests involving WebTransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=94639

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-22
Reviewed by James Robinson.

EXPECT_TRANSFORMATION_MATRIX_EQ was changed to become mainly a function.
As a macro that expanded into 16 other macros, it caused an unneeded
slow down of close to 45s in the compile time of CCLayerTreeHostCommonTest
Bugs have been filed to clang and gcc noting the errant behavior:
http://llvm.org/bugs/show_bug.cgi?id=13651 and http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54337

tests/CCLayerTreeHostCommonTest.cpp:
tests/CCLayerTreeTestCommon.h:

(WebKitTests):
(WebKitTests::ExpectTransformationMatrixEq):

tests/WebTransformOperationsTest.cpp:

(TEST):
(checkProgress):

tests/WebTransformationMatrixTest.cpp:

(WebKit::TEST):

2:26 PM Changeset in webkit [126351] by commit-queue@webkit.org

8 edits in trunk/Source

[chromium] Add software bitmap resources to CCResourceProvider
https://bugs.webkit.org/show_bug.cgi?id=93677

Patch by Alexandre Elias <aelias@google.com> on 2012-08-22
Reviewed by Adrienne Walker.

Second commit after revert.

This adds the ability to CCResourceProvider to use software bitmaps.
They are allocated as plain-old-memory, and exposed as Skia objects.

We want the ResourceProvider to be able to handle different resource
types at the same time. In practice, a default resource type is
desired for most uses within a single compositor instance, which is
specified by the default resource type. Default resource types are
expected to be mostly 1-to-1 with CCRenderer types.

New tests added by parametrizing existing CCResourceProvider tests.

Source/WebCore:

platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::applyFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):

platform/graphics/chromium/LayerRendererChromium.h:

(DrawingFrame):

platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::createResource):
(WebCore):
(WebCore::CCResourceProvider::createGLTexture):
(WebCore::CCResourceProvider::createBitmap):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::flush):
(WebCore::CCResourceProvider::shallowFlushIfSupported):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::ScopedReadLockGL::ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedReadLockGL::~ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::ScopedWriteLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::~ScopedWriteLockGL):
(WebCore::CCResourceProvider::populateSkBitmapWithResource):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::~ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::~ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::CCResourceProvider):

platform/graphics/chromium/cc/CCResourceProvider.h:

(WebCore):
(WebCore::CCResourceProvider::setCreationPolicy):
(WebCore::CCResourceProvider::creationPolicy):
(CCResourceProvider):
(ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedReadLockGL::textureId):
(ScopedWriteLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::textureId):
(ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::skBitmap):
(ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::skCanvas):
(Resource):

Source/WebKit/chromium:

tests/CCResourceProviderTest.cpp:

(WebKit::CCResourceProviderTest::getResourcePixels):

2:24 PM Changeset in webkit [126350] by annacc@chromium.org

9 edits in trunk

Update the TextTrackCue Constructor
https://bugs.webkit.org/show_bug.cgi?id=88583

Reviewed by Eric Carlson.

The TextTrackCue constructor has been changed to:
[Constructor(double startTime, double endTime, DOMString text)]
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#texttrackcue

Source/WebCore:

No new tests. Update to media/track/track-add-remove-cue.html

html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::TextTrackCue):

html/track/TextTrackCue.h:

(WebCore::TextTrackCue::create):
(TextTrackCue):

html/track/TextTrackCue.idl:
html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::createNewCue):

LayoutTests:

media/track/track-add-remove-cue-expected.txt:
media/track/track-add-remove-cue.html:

2:19 PM Changeset in webkit [126349] by arv@chromium.org

8 edits
2 adds in trunk

Changing class attribute is not reflected in the classList property
https://bugs.webkit.org/show_bug.cgi?id=93665

Reviewed by Ojan Vafai.

Before this change classAttributeChanged was only called for StyledElement. With this refactoring
it gets called for all Elements when the class attribute changes.

Source/WebCore:

Test: fast/dom/Element/class-list-update.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRules): To match the old behavior we only include StyledElements.

dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::nodeMatches): Ditto.

dom/Element.cpp:

(WebCore::Element::attributeChanged): Moved the call to parseAttribute here, from StyledElement::attributeChanged.
(WebCore::Element::parseAttribute): Moved from StyledElement.
(WebCore):
(WebCore::Element::classAttributeChanged): Ditto.

dom/Element.h:

(Element):
(WebCore::Element::classNames): Ditto.
(WebCore):

dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged): Let Element::attributeChanged call parseAttribtue instead.
(WebCore::StyledElement::parseAttribute): Move the class attribute handling to Element::parseAttribute.

dom/StyledElement.h:

(StyledElement):

LayoutTests:

fast/dom/Element/class-list-update-expected.txt: Added.
fast/dom/Element/class-list-update.html: Added.

2:14 PM Changeset in webkit [126348] by haraken@chromium.org

10 edits in trunk/Source/WebCore

[V8] Replace v8::String::NewSymbol() in CodeGeneratorV8.pm with v8String()
https://bugs.webkit.org/show_bug.cgi?id=94588

Reviewed by Eric Seidel.

v8String() is faster than String::NewSymbol().
This patch implements v8String(char*, Isolate*) and
replaces String::NewSymbol(char*) in CodeGeneratorV8.pm
with v8String(char*, Isolate*).

Performance result:

272 nano sec
static v8::Handle<v8::Value> attr3AttrGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{

v8::Handle<v8::Value> v1 = v8String(String("foo"));
v8::Handle<v8::Value> v2 = v8String(String("bar"));
if (!v1.IsEmpty() && !v2.IsEmpty())

return v8Undefined();

return v8::Null(); Never reach.

}

377 nano sec
static v8::Handle<v8::Value> attr4AttrGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{

v8::Handle<v8::Value> v1 = v8::String::NewSymbol("foo");
v8::Handle<v8::Value> v2 = v8::String::NewSymbol("bar");
if (!v1.IsEmpty() && !v2.IsEmpty())

return v8Undefined();

return v8::Null(); Never reach.

}

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateNamedConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

bindings/v8/V8Binding.h:

(WebCore):
(WebCore::v8String):

html/HTMLDivElement.idl:

2:05 PM Changeset in webkit [126347] by kbr@google.com

2 edits in trunk/LayoutTests

[Chromium] Need baselines for new paged-x and paged-y tests in fast/overflow after r126343
https://bugs.webkit.org/show_bug.cgi?id=94748

Unreviewed gardening; suppressing new failures until baselines are generated.

platform/chromium/TestExpectations:

1:57 PM Changeset in webkit [126346] by psolanki@apple.com

2 edits in trunk/Source/WebCore

Setting WebKitEnableHTTPPipelining doesn't work if default is true
https://bugs.webkit.org/show_bug.cgi?id=94537

Reviewed by David Kilzer.

platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::initializeMaximumHTTPConnectionCountPerHost): Read in the HTTP pipelining pref and
allow it to override the default pipelining behavior if it was actually set.

1:47 PM Changeset in webkit [126345] by wjmaclean@chromium.org

11 edits
1 move
108 adds
1 delete in trunk

[chromium] Add touch link highlight animation layers.
https://bugs.webkit.org/show_bug.cgi?id=84487

Reviewed by James Robinson.

Adds support for creating composited touch link highlights in renderer thread. Clipping not yet
implemented for non-composited frames/overflow divs, but scrolling and layout changes are supported.
Transform support currently limited to translation.

Source/WebCore:

Unit tests for LinkHighlight revised.

Tests: platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html

platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scroll-clip.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple.html

WebCore.gypi:
platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed): Adds notification to LinkHighlight when layer goes away.
(WebCore::GraphicsLayerChromium::updateNames): Now sets debug name for LinkHighlight layer.
(WebCore::GraphicsLayerChromium::setSize): Invalidates LinkHighlight if present.
(WebCore::GraphicsLayerChromium::setNeedsDisplay): Invalidates LinkHighlight if present.
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect): Invalidates LinkHighlight if present.
(WebCore::GraphicsLayerChromium::setLinkHighlight): Registers LinkHighlightClient* with GraphicsLayerChromium.
(WebCore::GraphicsLayerChromium::updateChildList): Now adds LinkHighlight WebLayer if highlight active.
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable): Invalidates LinkHighlight if present.

platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore):
(LinkHighlightClient): Abstract interface seen by GraphicsLayerChromium.
(WebCore::LinkHighlightClient::~LinkHighlightClient):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::linkHighlight):

platform/graphics/chromium/LinkHighlight.cpp: Removed.

Source/WebKit/chromium:

Unit tests for LinkHighlight revised.

WebKit.gyp:
src/LinkHighlight.cpp: Added.

(WebKit):
(WebKit::LinkHighlight::create):
(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::~LinkHighlight):
(WebKit::LinkHighlight::contentLayer): Accessor for layer containing highlight.
(WebKit::LinkHighlight::clipLayer): Accessor for layer that provides clipping for highlight.
(WebKit::LinkHighlight::releaseResources): Releases Node* for highlight target, clears client/delegate pointers.
(WebKit::LinkHighlight::computeEnclosingCompositingLayer): Determines which GraphicsLayerChromium to attach highlight to.
(WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Determines coordinates of highlight in owning GraphicsLayerChromium's coordinates.
(WebKit::LinkHighlight::paintContents): If highlight active, paints highlight.
(WebKit::LinkHighlight::startHighlightAnimation): Called to start highlight animation.
(WebKit::LinkHighlight::clearGraphicsLayerLinkHighlightPointer): Removes this LinkHighlight's pointer from owning GraphicsLayerChromium.
(WebKit::LinkHighlight::notifyAnimationStarted): Implements WebAnimationDelegate.
(WebKit::LinkHighlight::notifyAnimationFinished): Implements WebAnimationDelegate, releases resources when animation completes.
(WebKit::LinkHighlight::updateGeometry): Invokes computation of which GraphicsLayerChromium to attach to, and highlight shape & position.

Computations proceed only if preceded by call to invalidate().

(WebKit::LinkHighlight::clearCurrentGraphicsLayer): Handles notification that current GraphicsLayerChromium* is no longer valid.
(WebKit::LinkHighlight::invalidate): Sets flag to allow geometry update on next call from WebViewImpl::layout().
(WebKit::LinkHighlight::layer): Exports WebLayer* for use in GraphicsLayerChromium.

src/LinkHighlight.h: Renamed from Source/WebCore/platform/graphics/chromium/LinkHighlight.h.

(WebCore):
(WebKit):
(LinkHighlight):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit):
(WebKit::highlightConditions):
(WebKit::WebViewImpl::bestTouchLinkNode): Find highlight target node for touch event location.
(WebKit::WebViewImpl::enableTouchHighlight): Invokes highlight for node at current touch event location.
(WebKit::WebViewImpl::layout): Adds call to LinkHighlight::updateGeometry().

src/WebViewImpl.h:

(WebKit):
(WebViewImpl):
(WebKit::WebViewImpl::linkHighlight):

tests/LinkHighlightTest.cpp:

(WebCore):
(WebCore::TEST):

tests/data/test_touch_link_highlight.html: Added.

LayoutTests:

platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple.html: Added.
platform/chromium-linux/compositing/gestures/resources/1-frame-composited.html: Added.
platform/chromium-linux/compositing/gestures/resources/1-frame-noncomposited.html: Added.
platform/chromium-linux/compositing/gestures/resources/1-nested-frame-composited.html: Added.
platform/chromium-linux/compositing/gestures/resources/1-nested-frame-noncomposited.html: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.txt: Added.
platform/chromium/TestExpectations:

1:24 PM Changeset in webkit [126344] by abarth@webkit.org

8 edits in trunk/Source/WebKit/chromium

WebWidget should be able to paint into a zoomed canvas without aliasing
https://bugs.webkit.org/show_bug.cgi?id=92043

Reviewed by James Robinson.

If accelerated compositing is enabled, WebWidget::paint reads back from
the compositor rather than re-painting the widget. That approach works
well if the canvas we're rendering into is at a similar resolution to
the pixels in the compositor, but if the canvas has been scaled (e.g.,
to help the user disambiguate links), then reading back from the
compositor will cause aliasing artifacts.

This patch adds an option to paint to let the embedder request a
software re-rendering of the widget to avoid these aliasing artifacts.

public/WebWidget.h:

(WebKit::WebWidget::paint):

src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::paint):

src/WebPagePopupImpl.h:

(WebPagePopupImpl):

src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::paint):

src/WebPopupMenuImpl.h:
src/WebViewImpl.cpp:

(WebKit::canvasBackgroundForTransparencey):
(WebKit):
(WebKit::WebViewImpl::paint):

src/WebViewImpl.h:

(WebViewImpl):

1:20 PM Changeset in webkit [126343] by Beth Dakin

35 edits
13 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=94401
Add support for making a web site become paginated using overflow:
paged-x | paged-y
-and corresponding-
<rdar://problem/11831783>

Reviewed by Dave Hyatt.

Source/autotools/symbols.filter:

Source/WebCore:

This patch adds two new possible values for overflow-y. They are -
webkit-paged-x and -webkit-paged-y. When you set these as overflow-y
values on the html or body element, they make the RenderView
paginated, much like the API on Page.

-webkit-paged-x and -webkit-paged-y are only valid values for
overflow-y, NOT overflow-x. overflow-x defaults to a value of auto
(for now) unless it has been set to something else.

css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):

Two new CSS value keywords.

css/CSSValueKeywords.in:

EOverflow has two new values for pagination.

rendering/style/RenderStyleConstants.h:
css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EOverflow):

A bunch of existing code from StyleResolver::styleForDocument() is
moved into a helper function so that it can be called from two
places.

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

Even though this pagination is very similar to Page::pagination(), it
is different in one critical way. Page::pagination() will apply to
all FrameViews, even those in the page cache. For this reason,
FrameView needs to keep its own Pagination value that just applies to
this FrameView.

page/FrameView.cpp:
page/FrameView.h:

(WebCore):
(FrameView):

Map RenderStyle values to a Pagination::Mode.
(WebCore::paginationModeForRenderStyle):
(WebCore):

Account for paged-x and paged-y here.
(WebCore::FrameView::applyOverflowToViewport):

As is explained in the header, FrameView::pagination() will return
m_pagination if it has been set. Otherwise, it will return
Page::pagination() since currently there are no callers that need to
distinguish between the two.
(WebCore::FrameView::pagination):
(WebCore::FrameView::setPagination):

Generally this means that everywhere in WebCore should ask FrameView
for the pagination(), not Page. These call sites all look to
FrameView now.
(WebCore::FrameView::paintContents):

rendering/RenderView.cpp:

(WebCore::RenderView::requiresColumns):
(WebCore::RenderView::calcColumnWidth):
(WebCore::RenderView::paginationUnit):
(WebCore::RenderView::viewLogicalHeight):

Since we need to define Pagination in Page.h AND FrameView.h, it is
now in its own header, Pagination.h. And therefore it is no longer
WebCore::Page::Pagination, but rather it is just WebCore::Pagination.

page/Page.h:

(Page):

rendering/Pagination.h: Added.

(WebCore):
(WebCore::Pagination::Pagination):
(Pagination):
(WebCore::Pagination::operator==):
(WebCore::Pagination::operator!=):

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:

Certain ColumnInfo values are set based on the RenderStyle. So if
those RenderStyle values change, the ColumnInfo needs to be updated.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateColumnInfoFromStyle):
(WebCore):

rendering/RenderBlock.h:

(RenderBlock):

Factor in paged-x and paged-y when determining if a RenderBlock
requires columns.
(WebCore::RenderBlock::requiresColumns):

RenderStyle::specifiesColumns() is an odd and probably broken
function. At the very least, it should be re-named, if not removed
entirely. It does not accurately assess if columns have been
specified. I had to add this code here because specifiesColumns()
returns false for paged-x and true for paged-y. We were hitting a
number of crashes with paged-y because of this, so I chose for the
time being to limit this check to non-root layers.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly):

It's just Pagination now, not Page::Pagination.

testing/InternalSettings.cpp:

(WebCore::InternalSettings::reset):
(WebCore::InternalSettings::setPagination):

Source/WebKit/mac:

WebCore::Page::Pagination is now just WebCore::Pagination.

WebView/WebView.mm:

(-[WebView _setPaginationMode:]):
(-[WebView _paginationMode]):
(-[WebView _setPaginationBehavesLikeColumns:]):
(-[WebView _setPageLength:]):
(-[WebView _setGapBetweenPages:]):

Source/WebKit2:

WebCore::Page::Pagination is now just WebCore::Pagination.

Shared/WebPageCreationParameters.h:

(WebPageCreationParameters):

UIProcess/API/C/WKPage.cpp:

(WKPageSetPaginationMode):
(WKPageGetPaginationMode):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setPaginationMode):

UIProcess/WebPageProxy.h:

(WebPageProxy):
(WebKit::WebPageProxy::paginationMode):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setPaginationMode):
(WebKit::WebPage::setPaginationBehavesLikeColumns):
(WebKit::WebPage::setPageLength):
(WebKit::WebPage::setGapBetweenPages):

WebProcess/WebPage/WebPage.h:

(WebPage):

LayoutTests:

Test the parsing of the two new values.

fast/css/overflow-property-expected.txt:
fast/css/overflow-property.html:

New tests.

fast/overflow/paged-x-div.html: Added.
fast/overflow/paged-x-on-root.html: Added.
fast/overflow/paged-y-div.html: Added.
fast/overflow/paged-y-on-root.html: Added.
platform/mac/fast/overflow/paged-x-div-expected.png: Added.
platform/mac/fast/overflow/paged-x-div-expected.txt: Added.
platform/mac/fast/overflow/paged-x-on-root-expected.png: Added.
platform/mac/fast/overflow/paged-x-on-root-expected.txt: Added.
platform/mac/fast/overflow/paged-y-div-expected.png: Added.
platform/mac/fast/overflow/paged-y-div-expected.txt: Added.
platform/mac/fast/overflow/paged-y-on-root-expected.png: Added.
platform/mac/fast/overflow/paged-y-on-root-expected.txt: Added.

1:14 PM Changeset in webkit [126342] by dino@apple.com

4 edits in trunk/Source/WebCore

[WebGL] Mac/ATI/AMD systems need to translate built-in GLSL functions
https://bugs.webkit.org/show_bug.cgi?id=94030

Reviewed by Tim Horton.

ATI/AMD GPUs on Apple platforms do not give correct values for some of
the built-in GLSL functions. Add a compile flag that is passed to ANGLE
so that, with this configuration, it will rewrite the shader to emulate
the function in code.

This is exposing some design weaknesses in the way we call ANGLE. We'll
soon need to add more compiler flags; Future bugs will likely clean
this code up. But this approach is satisfactory for the moment.

This change is tested by the Khronos WebGL conformance test suite, in particular:
conformance/glsl/functions/glsl-function-distance.html
conformance/glsl/functions/glsl-function-dot.html
conformance/glsl/functions/glsl-function-length.html

platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::ANGLEWebKitBridge::validateShaderSource): Test for ATI cards
on the Mac platform, and pass in an extra flag to the translation step.

platform/graphics/ANGLEWebKitBridge.h:

(ANGLEWebKitBridge): Add a new parameter to getTranslatedShaderSourceANGLE
that accepts some extra options to pass to ANGLE.

platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Pass
the extra options into ANGLE's compile function.

12:55 PM Changeset in webkit [126341] by tommyw@google.com

8 edits
2 copies in trunk

[chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=93091

Reviewed by Adam Barth.

Source/WebCore:

Fixing a FIXME that the patch obsoletes.

Covered by existing tests.

platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::initialize):

Tools:

Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
to complete the infrastructure for RTCPeerConnection.

DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::createRTCPeerConnectionHandler):

DumpRenderTree/chromium/MockWebKitPlatformSupport.h:

(MockWebKitPlatformSupport):

DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.

(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::initialize):

DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.

(WebKit):
(MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):

12:50 PM Changeset in webkit [126340] by commit-queue@webkit.org

9 edits in trunk/Source

[chromium] Simplify updateContentRect, removing rect parameter, refactor unit tests.
https://bugs.webkit.org/show_bug.cgi?id=94165

Patch by Eric Penner <epenner@google.com> on 2012-08-22
Reviewed by Adrienne Walker.

Source/WebCore:

Remove visible rect parameter from TiledLayerChromium functions. Passing a
rect that is not the visible rect wouldn't make sense, and soon we might
need further visibility information.

In refactoring the unit tests, I removed texture manager from all tests
and put it in the test class. I also made some utility functions to
simulate the commit flow and remove tons of boilerplate code. I refactored
about half the unit tests to use the utility functions.

Refactored tests.

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::update):
(WebCore::ContentLayerChromium::needMoreUpdates):

platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::update):

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore):
(WebCore::TiledLayerChromium::setTexturePriorities):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::update):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

Source/WebKit/chromium:

Refactored tests to remove lots of boilerplate code.

tests/CCTiledLayerTestCommon.cpp:
tests/CCTiledLayerTestCommon.h:

(FakeTiledLayerChromium):

tests/TiledLayerChromiumTest.cpp:

12:40 PM Changeset in webkit [126339] by inferno@chromium.org

1 edit
2 copies in branches/chromium/1180

Merge 124282 - REGRESSION(r120979): Node list returned by getElementsByTagNameNS isn't invalidated when children changes
https://bugs.webkit.org/show_bug.cgi?id=92705
BUG=139646
Review URL: https://chromiumcodereview.appspot.com/10871021

12:38 PM Changeset in webkit [126338] by commit-queue@webkit.org

7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make all pickers non-zoomable
https://bugs.webkit.org/show_bug.cgi?id=94729

Patch by Crystal Zhang <haizhang@rim.com> on 2012-08-22
Reviewed by Antonio Gomes.

Move HTML header initialization to PagePopupBlackBerry as that part are all the same, and make all pickers non-zoomable.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::screenSize):
(WebKit):

Api/WebPage_p.h:

(WebPagePrivate):

WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::generateHTML):
(WebCore::DatePickerClient::writeDocument):

WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::PagePopupBlackBerry::init):
(WebCore::PagePopupBlackBerry::generateHTML):
(WebCore):

WebCoreSupport/PagePopupBlackBerry.h:

(PagePopupBlackBerry):

WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::generateHTML):
(WebCore::SelectPopupClient::writeDocument):

12:37 PM Changeset in webkit [126337] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Skipping css3/flexbox/flexitem.html.
https://bugs.webkit.org/show_bug.cgi?id=94723.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-22
Reviewed by Simon Fraser.

platform/mac/Skipped:

12:36 PM Changeset in webkit [126336] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Add a check to filter out cookies that tries to set the
domain to a top level domain
https://bugs.webkit.org/show_bug.cgi?id=94722

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-08-22
Reviewed by Rob Buis.

Adding conditions to check whether a cookie domain is a top level domain.
If it is, throw it out when parsing.

Manual Testing by trying to insert a cookie with an invalid domain
using web-inspector. (ex: when on news.yahoo.com.hk, try to document.
cookie="test1=seeifthiscookieexist; domain=.com.hk")

PR121622

platform/blackberry/CookieParser.cpp:

WebCore::CookieParser::parseOneCookie):

12:34 PM Changeset in webkit [126335] by rwlbuis@webkit.org

3 edits in trunk/Source/WebCore

Remove RenderBlock::paintEllipsisBoxes
https://bugs.webkit.org/show_bug.cgi?id=94709

Reviewed by Eric Seidel.

Remove unused method.

No change in functionality, no new tests.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintFloats):

rendering/RenderBlock.h:

(RenderBlock):

12:32 PM Changeset in webkit [126334] by rniwa@webkit.org

7 edits in trunk/Tools

Merge TestExpectationSerializer into TestExpectationLine
https://bugs.webkit.org/show_bug.cgi?id=94638

Reviewed by Dimitri Glazkov.

Moved all methods except, list_to_string which was moved to TestExpectations
from TestExpectationSerializer to TestExpectationLine and removed TestExpectationSerializer.

Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:

(TestExpectationEditorTests.assert_remove_roundtrip):
(TestExpectationEditorTests.assert_update_roundtrip):

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(ParseError.repr):
(TestExpectationLine):
(TestExpectationLine.create_passing_expectation):
(TestExpectationLine.to_string): Moved from TestExpectationSerializer.
(TestExpectationLine.to_csv): Ditto.
(TestExpectationLine._serialize_parsed_expectations): Ditto.
(TestExpectationLine._serialize_parsed_modifiers): Ditto.
(TestExpectationLine._format_line):
(TestExpectations.remove_configuration_from_test):
(TestExpectations.remove_rebaselined_tests):
(TestExpectations.add_skipped_tests):
(TestExpectations):
(TestExpectations.list_to_string): Moved from TestExpectationSerializer.
(TestExpectations.list_to_string.serialize):
(TestExpectations.list_to_string.nones_out):

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(TestExpectationSerializationTests): Renamed from TestExpectationSerializerTests.
(TestExpectationSerializationTests.init):
(TestExpectationSerializationTests.assert_round_trip):
(TestExpectationSerializationTests.assert_list_round_trip):
(TestExpectationSerializationTests.test_unparsed_to_string):
(TestExpectationSerializationTests.test_unparsed_list_to_string):
(TestExpectationSerializationTests.test_parsed_to_string):
(TestExpectationSerializationTests.test_serialize_parsed_expectations):
(TestExpectationSerializationTests.test_serialize_parsed_modifier_string):
(TestExpectationSerializationTests.test_format_line):
(TestExpectationSerializationTests.test_reconstitute_only_these):

Scripts/webkitpy/tool/commands/expectations.py:

(OptimizeExpectations.execute):

Scripts/webkitpy/tool/commands/queries.py:

(PrintExpectations.execute):
(PrintExpectations._format_lines):

Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningExpectationsUpdater.update_expectations):

12:30 PM Changeset in webkit [126333] by tommyw@google.com

6 edits
7 adds in trunk

MediaStream API: Introduce RTCSessionDescription
https://bugs.webkit.org/show_bug.cgi?id=93119

Reviewed by Adam Barth.

Source/WebCore:

This patch introduces RTCSessionDescription together with its
corresponding WebCore/platform representation.

Test: fast/mediastream/RTCSessionDescription.html

CMakeLists.txt:
GNUmakefile.list.am:
Modules/mediastream/DOMWindowMediaStream.idl:
Modules/mediastream/RTCSessionDescription.cpp: Added.

(WebCore):
(WebCore::RTCSessionDescription::create):
(WebCore::RTCSessionDescription::RTCSessionDescription):
(WebCore::RTCSessionDescription::~RTCSessionDescription):
(WebCore::RTCSessionDescription::type):
(WebCore::RTCSessionDescription::setType):
(WebCore::RTCSessionDescription::sdp):
(WebCore::RTCSessionDescription::setSdp):
(WebCore::RTCSessionDescription::descriptor):

Modules/mediastream/RTCSessionDescription.h: Added.

(WebCore):
(RTCSessionDescription):

Modules/mediastream/RTCSessionDescription.idl: Added.
WebCore.gypi:
platform/mediastream/RTCSessionDescriptionDescriptor.cpp: Added.

(WebCore):
(WebCore::RTCSessionDescriptionDescriptor::create):
(WebCore::RTCSessionDescriptionDescriptor::RTCSessionDescriptionDescriptor):
(WebCore::RTCSessionDescriptionDescriptor::~RTCSessionDescriptionDescriptor):

platform/mediastream/RTCSessionDescriptionDescriptor.h: Added.

(WebCore):
(RTCSessionDescriptionDescriptor):
(WebCore::RTCSessionDescriptionDescriptor::type):
(WebCore::RTCSessionDescriptionDescriptor::setType):
(WebCore::RTCSessionDescriptionDescriptor::sdp):
(WebCore::RTCSessionDescriptionDescriptor::setSdp):

LayoutTests:

fast/mediastream/RTCSessionDescription-expected.txt: Added.
fast/mediastream/RTCSessionDescription.html: Added.

12:27 PM Changeset in webkit [126332] by aelias@chromium.org

2 edits in trunk/Tools

Unreviewed, add aelias@chromium.org to committers

I (aelias@chromium.org) have been approved for commit access and Apple
has confirmed receipt of my committer agreement.

Scripts/webkitpy/common/config/committers.py:

12:27 PM Changeset in webkit [126331] by victor@rosedu.org

3 edits
2 adds in trunk

DOM manipulation crashes the browser

Creating a DOM track element by script and changing the mode crashes
results in a browser crash.
https://bugs.webkit.org/show_bug.cgi?id=94628

Reviewed by Eric Carlson.

Source/WebCore:

Simple fix that creates the text track cue list in case of mode change.

Test: media/track/track-element-dom-change-crash.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackModeChanged):

LayoutTests:

media/track/track-element-dom-change-crash-expected.txt: Added.
media/track/track-element-dom-change-crash.html: Added.

12:24 PM Changeset in webkit [126330] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Microdata build fix.

html/HTMLPropertiesCollection.h:

(WebCore::HTMLPropertiesCollection::updatePropertyCache):

12:21 PM Changeset in webkit [126329] by zandobersek@gmail.com

2 edits
2 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Adding platform-specific baseline for css3/flexbox/flexitem.html that's
required after r126257.

Removing failure expectation for fast/forms/range/range-hit-test-with-padding.html
after the test was refactored in r126252 and is now passing.

Skipping two more failing tests that take too long to fail.

platform/gtk/TestExpectations:
platform/gtk/css3/flexbox: Added.
platform/gtk/css3/flexbox/flexitem-expected.txt: Added.

12:18 PM Changeset in webkit [126328] by tommyw@google.com

6 edits
7 adds in trunk

MediaStream API: Introduce RTCIceCandidate
https://bugs.webkit.org/show_bug.cgi?id=93117

Reviewed by Adam Barth.

Source/WebCore:

This patch introduces RTCIceCandidate together with its corresponding
WebCore/platform representation.

Test: fast/mediastream/RTCIceCandidate.html

CMakeLists.txt:
GNUmakefile.list.am:
Modules/mediastream/DOMWindowMediaStream.idl:
Modules/mediastream/RTCIceCandidate.cpp: Added.

(WebCore):
(WebCore::RTCIceCandidate::create):
(WebCore::RTCIceCandidate::RTCIceCandidate):
(WebCore::RTCIceCandidate::~RTCIceCandidate):
(WebCore::RTCIceCandidate::candidate):
(WebCore::RTCIceCandidate::sdpMid):
(WebCore::RTCIceCandidate::sdpMLineIndex):
(WebCore::RTCIceCandidate::descriptor):

Modules/mediastream/RTCIceCandidate.h: Added.

(WebCore):
(RTCIceCandidate):

Modules/mediastream/RTCIceCandidate.idl: Added.
WebCore.gypi:
platform/mediastream/RTCIceCandidateDescriptor.cpp: Added.

(WebCore):
(WebCore::RTCIceCandidateDescriptor::create):
(WebCore::RTCIceCandidateDescriptor::RTCIceCandidateDescriptor):
(WebCore::RTCIceCandidateDescriptor::~RTCIceCandidateDescriptor):

platform/mediastream/RTCIceCandidateDescriptor.h: Added.

(WebCore):
(RTCIceCandidateDescriptor):
(WebCore::RTCIceCandidateDescriptor::candidate):
(WebCore::RTCIceCandidateDescriptor::sdpMid):
(WebCore::RTCIceCandidateDescriptor::sdpMLineIndex):

LayoutTests:

fast/mediastream/RTCIceCandidate-expected.txt: Added.
fast/mediastream/RTCIceCandidate.html: Added.

12:09 PM Changeset in webkit [126327] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

[chromium] Remove WebFrame::setSelectionToRange
https://bugs.webkit.org/show_bug.cgi?id=94685

Patch by Iain Merrick <husky@chromium.org> on 2012-08-22
Reviewed by Adam Barth.

It has basically the same functionality as WebFrame::selectRange.
The calling code was removed in Chromium patch 152608.

public/WebFrame.h:

(WebFrame):

src/WebFrameImpl.cpp:
src/WebFrameImpl.h:

(WebFrameImpl):

12:00 PM Changeset in webkit [126326] by mrowe@apple.com

2 edits in trunk/Source/WebCore

<http://webkit.org/b/94679> WebCore scrolling thread leaks objects due to them being autoreleased without any autorelease pool in place

Reviewed by Dan Bernstein.

page/scrolling/mac/ScrollingThreadMac.mm:

(WebCore::ScrollingThread::threadRunLoopSourceCallback): Ensure that an autorelease pool is in place when
dispatching functions on the scrolling thread.

11:44 AM Changeset in webkit [126325] by psolanki@apple.com

3 edits in trunk/Source/WebCore

Failure to dispatch delegate callbacks if resource load fails synchronously
https://bugs.webkit.org/show_bug.cgi?id=94644

Reviewed by Antti Koivisto.

Resource loads can be triggered by layout after document load is
complete but before we have dispatched didFinishLoadForFrame callback.
In such cases, if the load fails synchronously due to the client
returning 0 from willSendRequest callback, we would fail to call
didFinishLoading. this was fixed for Font resources in r122446 for bug

This fixes it in the general case by having CachedResourceLoader

call FrameLoader::checkLoadComplete() when it is done loading all
resources.

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadTimerFired):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::decrementRequestCount):

11:33 AM Changeset in webkit [126324] by kbr@google.com

2 edits in trunk/LayoutTests

Layout test fast/text/emphasis-overlap.html started failing differently after r126312
https://bugs.webkit.org/show_bug.cgi?id=94735

Unreviewed gardening. Suppressed failure.

platform/chromium/TestExpectations:

11:17 AM Changeset in webkit [126323] by kbr@google.com

10 edits
1 move
1 add
108 deletes in trunk

Unreviewed, rolling out r126319.
http://trac.webkit.org/changeset/126319
https://bugs.webkit.org/show_bug.cgi?id=84487

Broke Chromium Mac build

Source/WebCore:

WebCore.gypi:
platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):

platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore):
(GraphicsLayerChromium):

platform/graphics/chromium/LinkHighlight.cpp: Added.

(WebCore):
(WebCore::LinkHighlight::create):
(WebCore::LinkHighlight::LinkHighlight):
(WebCore::LinkHighlight::~LinkHighlight):
(WebCore::LinkHighlight::contentLayer):
(WebCore::LinkHighlight::paintContents):
(WebCore::LinkHighlight::notifyAnimationStarted):
(WebCore::LinkHighlight::notifyAnimationFinished):

platform/graphics/chromium/LinkHighlight.h: Renamed from Source/WebKit/chromium/src/LinkHighlight.h.

(WebCore):
(LinkHighlight):

Source/WebKit/chromium:

WebKit.gyp:
src/LinkHighlight.cpp: Removed.
src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::layout):

src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

tests/LinkHighlightTest.cpp:
tests/data/test_touch_link_highlight.html: Removed.

LayoutTests:

platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html: Removed.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple.html: Removed.
platform/chromium-linux/compositing/gestures/resources/1-frame-composited.html: Removed.
platform/chromium-linux/compositing/gestures/resources/1-frame-noncomposited.html: Removed.
platform/chromium-linux/compositing/gestures/resources/1-nested-frame-composited.html: Removed.
platform/chromium-linux/compositing/gestures/resources/1-nested-frame-noncomposited.html: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.txt: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.png: Removed.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.txt: Removed.

11:14 AM Changeset in webkit [126322] by kbr@google.com

2 edits in trunk/LayoutTests

Layout Test fast/repaint/japanese-rl-selection-repaint-in-regions.html is failing after r126304
https://bugs.webkit.org/show_bug.cgi?id=94730

Unreviewed; suppressed failure for the moment.

platform/chromium/TestExpectations:

10:59 AM Changeset in webkit [126321] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Respect system setting for rubber-banding in ScrollAnimatorMac.
https://bugs.webkit.org/show_bug.cgi?id=94356

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-08-22
Reviewed by James Robinson.

Respects user defaults setting of NSScrollViewRubberbanding,
which controls rubber-banding in other Mac OS X applications.

If NSScrollViewRubberbanding is not set, defaults to enabling
rubber banding. Otherwise, rubber banding is disabled if the
value is 0 and enabled otherwise.

No new tests since the behavior depends on system settings.

platform/mac/ScrollAnimatorMac.mm:

(WebCore):
(WebCore::rubberBandingEnabledForSystem):
(WebCore::ScrollAnimatorMac::handleWheelEvent):

10:56 AM Changeset in webkit [126320] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[chromium/mac] Remove unnecessary checks for OS version <= 10.5. We don't support those
https://bugs.webkit.org/show_bug.cgi?id=94658

Patch by James Robinson <jamesr@chromium.org> on 2012-08-22
Reviewed by Tony Chang.

The chromium mac port hasn't supported Leopard for a while now, so remove chromium-specific code that checks
for OS X version <= Leopard.

platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore::FontPlatformData::loadFont):

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::canSetCascadeListForCustomFont):

10:51 AM Changeset in webkit [126319] by wjmaclean@chromium.org

10 edits
1 move
112 adds
1 delete in trunk

[chromium] Add touch link highlight animation layers.
https://bugs.webkit.org/show_bug.cgi?id=84487

Reviewed by James Robinson.

Source/WebCore:

Unit tests for LinkHighlight revised.

Tests: platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html

platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scroll-clip.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple.html

WebCore.gypi:
platform/graphics/chromium/GraphicsLayerChromium.cpp:

platform/graphics/chromium/GraphicsLayerChromium.h:

platform/graphics/chromium/LinkHighlight.cpp: Removed.

Source/WebKit/chromium:

Unit tests for LinkHighlight revised.

WebKit.gyp:
src/LinkHighlight.cpp: Added.

Computations proceed only if preceded by call to invalidate().

src/LinkHighlight.h: Renamed from Source/WebCore/platform/graphics/chromium/LinkHighlight.h.

(WebCore):
(WebKit):
(LinkHighlight):

src/WebViewImpl.cpp:

src/WebViewImpl.h:

(WebKit):
(WebViewImpl):
(WebKit::WebViewImpl::linkHighlight):

tests/LinkHighlightTest.cpp:

(WebCore):
(WebCore::TEST):

tests/data/test_touch_link_highlight.html: Added.

LayoutTests:

platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html: Added.
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple.html: Added.
platform/chromium-linux/compositing/gestures/resources/1-frame-composited.html: Added.
platform/chromium-linux/compositing/gestures/resources/1-frame-noncomposited.html: Added.
platform/chromium-linux/compositing/gestures/resources/1-nested-frame-composited.html: Added.
platform/chromium-linux/compositing/gestures/resources/1-nested-frame-noncomposited.html: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.txt: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.png: Added.
platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.txt: Added.

10:50 AM Changeset in webkit [126318] by jer.noble@apple.com

2 edits in trunk/Source/WebKit2

Browser menu visible when calling webkitRequestFullscreen after user manually enters full screen mode
https://bugs.webkit.org/show_bug.cgi?id=93892

Reviewed by Eric Carlson.

Allow the full screen window to "Join All Spaces", so that once it's original full screen space is destroyed,
it can join the new one.

UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):

10:41 AM Changeset in webkit [126317] by kbr@google.com

1 edit
5 adds in trunk/LayoutTests

Unreviewed Chromium gardening. Copy old Mac test expectations
(ignored anyway) for this Mac-specific test after r126219.

platform/chromium/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Added.
platform/chromium/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Added.

10:33 AM Changeset in webkit [126316] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unskip http/tests/inspector/console-resource-errors.html.
https://bugs.webkit.org/show_bug.cgi?id=94640.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-22
Reviewed by Jessie Berlin.

The test has been rebaseline'd in r126281 and no longer fails.

platform/mac/Skipped:

10:19 AM Changeset in webkit [126315] by kov@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed build fix. Missing PANGO_CFLAGS.

GNUmakefile.am:

10:10 AM Changeset in webkit [126314] by pfeldman@chromium.org

35 edits
1 add in trunk

Web Inspector: make "sdk" component compile independently from the rest of the front-end.
https://bugs.webkit.org/show_bug.cgi?id=94705

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change refactors the way we compile. Running "compile-front-end.py sdk" will compile sdk only.
It also introduces DOMStorageModel and DatabaseModel that are used to split model / UI layers.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/InjectedScriptExterns.js:

(InjectedScriptHost.prototype.evaluate):

inspector/Inspector.json:
inspector/compile-front-end.py:

(dump_module):

inspector/front-end/CompilerScriptMapping.js:
inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype.clone):
(WebInspector.ConsoleMessage.prototype.location):

inspector/front-end/DOMAgent.js:
inspector/front-end/DOMStorage.js:

(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._addDOMStorage):
(WebInspector.DOMStorageModel.prototype._domStorageUpdated):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):
(WebInspector.DOMStorageDispatcher):
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
(WebInspector.DOMStorageDispatcher.prototype.domStorageUpdated):

inspector/front-end/Database.js:

(WebInspector.Database):
(WebInspector.Database.prototype.executeSql):
(WebInspector.DatabaseModel):
(WebInspector.DatabaseModel.prototype.databases):
(WebInspector.DatabaseModel.prototype.databaseForId):
(WebInspector.DatabaseModel.prototype._addDatabase):
(WebInspector.DatabaseModel.prototype._sqlTransactionSucceeded):
(WebInspector.DatabaseModel.prototype._sqlTransactionFailed):
(WebInspector.DatabaseDispatcher):
(WebInspector.DatabaseDispatcher.prototype.addDatabase):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):

inspector/front-end/DebuggerModel.js:
inspector/front-end/FileUtils.js:

(WebInspector.OutputStreamDelegate.prototype.onTransferStarted):
(WebInspector.OutputStreamDelegate.prototype.onChunkTransferred):
(WebInspector.OutputStreamDelegate.prototype.onTransferFinished):
(WebInspector.OutputStreamDelegate.prototype.onError):
(WebInspector.OutputStream):
(WebInspector.OutputStream.prototype.startTransfer):
(WebInspector.OutputStream.prototype.transferChunk):
(WebInspector.OutputStream.prototype.finishTransfer):
(WebInspector.OutputStream.prototype.dispose):

inspector/front-end/HandlerRegistry.js:
inspector/front-end/HeapSnapshotView.js:
inspector/front-end/InspectorFrontendHostStub.js:
inspector/front-end/PresentationConsoleMessageHelper.js:

(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):

inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._reset):
(WebInspector.ResourcesPanel.prototype._databaseAdded):
(WebInspector.ResourcesPanel.prototype._addDatabase):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._addDOMStorage):
(WebInspector.ResourcesPanel.prototype._showDatabase.get if):
(WebInspector.ResourcesPanel.prototype._showDatabase.else.get if):
(WebInspector.ResourcesPanel.prototype._showDatabase):
(WebInspector.ResourcesPanel.prototype._showDOMStorage.get if):
(WebInspector.ResourcesPanel.prototype._showDOMStorage):
(WebInspector.ResourcesPanel.prototype._updateDatabaseTables.get if):
(WebInspector.ResourcesPanel.prototype._updateDatabaseTables.tableNamesCallback):
(WebInspector.DatabaseTreeElement.prototype.onselect):
(WebInspector.DatabaseTableTreeElement.prototype.onselect):
(WebInspector.DOMStorageTreeElement.prototype.onselect):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.showFunctionDefinition):

inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):

inspector/front-end/Settings.js:
inspector/front-end/Spectrum.js:
inspector/front-end/TextEditorModel.js:
inspector/front-end/UIString.js: Added.

(WebInspector.UIString):

inspector/front-end/UIUtils.js:
inspector/front-end/WebKit.qrc:
inspector/front-end/externs.js:

(InspectorFrontendHostAPI.prototype.platform):
(InspectorFrontendHostAPI.prototype.port):
(InspectorFrontendHostAPI.prototype.bringToFront):
(InspectorFrontendHostAPI.prototype.closeWindow):
(InspectorFrontendHostAPI.prototype.requestAttachWindow):
(InspectorFrontendHostAPI.prototype.requestDetachWindow):
(InspectorFrontendHostAPI.prototype.requestSetDockSide):
(InspectorFrontendHostAPI.prototype.setAttachedWindowHeight):
(InspectorFrontendHostAPI.prototype.moveWindowBy):
(InspectorFrontendHostAPI.prototype.setInjectedScriptForOrigin):
(InspectorFrontendHostAPI.prototype.loaded):
(InspectorFrontendHostAPI.prototype.localizedStringsURL):
(InspectorFrontendHostAPI.prototype.hiddenPanels):
(InspectorFrontendHostAPI.prototype.inspectedURLChanged):
(InspectorFrontendHostAPI.prototype.documentCopy):
(InspectorFrontendHostAPI.prototype.copyText):
(InspectorFrontendHostAPI.prototype.openInNewTab):
(InspectorFrontendHostAPI.prototype.canSave):
(InspectorFrontendHostAPI.prototype.save):
(InspectorFrontendHostAPI.prototype.canAppend):
(InspectorFrontendHostAPI.prototype.append):
(InspectorFrontendHostAPI.prototype.sendMessageToBackend):
(InspectorFrontendHostAPI.prototype.recordActionTaken):
(InspectorFrontendHostAPI.prototype.recordPanelShown):
(InspectorFrontendHostAPI.prototype.recordSettingChanged):
(InspectorFrontendHostAPI.prototype.loadResourceSynchronously):
(InspectorFrontendHostAPI.prototype.setZoomFactor):
(InspectorFrontendHostAPI.prototype.canInspectWorkers):
(SourceMapV3):
(SourceMapV3.Section):
(SourceMapV3.Offset):

inspector/front-end/inspector.html:
inspector/front-end/inspector.js:

(WebInspector.inspect):

LayoutTests:

http/tests/inspector-enabled/database-open.html:
http/tests/inspector-enabled/dom-storage-open.html:

10:05 AM Changeset in webkit [126313] by kov@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed build fix. libWebCore needs include paths
for some bits of WebCoreGtk.

GNUmakefile.am:

9:53 AM Changeset in webkit [126312] by commit-queue@webkit.org

9 edits
1 add in trunk

FontMetrics.unitsPerEm(), FontPlatformData.orientation(), SimpleFontData::platformBoundsForGlyph are not implemented on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=83512

Patch by Koji Ishii <Koji Ishii> on 2012-08-22
Reviewed by Tony Chang.

Source/WebCore:

Chromium Windows does not implement following 3 functions that are required for bug 51450.

FontMetrics.unitsPerEm() always returns the default value (gDefaultUnitsPerEm = 1000).
FontPlatformData.orientation() always returns Horizontal.
SimpleFontData::platformBoundsForGlyph() always returns FloatRect().

Tony suggested in bug 51450 review to split code that is not behind
#if ENABLE(OPENTYPE_VERTICAL) to a separate patch.

Test: Following 3 existing but skipped tests are now enabled and pass.

fast/text/emphasis-overlap.html
fast/text/emphasis-avoid-ruby.html
fast/repaint/text-emphasis-v.html

platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::FontCache::createFontPlatformData): Add orientation.

platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

(WebCore::FontPlatformData::FontPlatformData): Add orientation.
(WebCore::FontPlatformData::operator=): Add orientation.

platform/graphics/chromium/FontPlatformDataChromiumWin.h:

(FontPlatformData):
(WebCore::FontPlatformData::orientation): Add orientation.
(WebCore::FontPlatformData::setOrientation): Add orientation.
(WebCore::FontPlatformData::operator==): Add orientation.

platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformInit): Set FontMetrics.unitsPerEm.
(WebCore::SimpleFontData::createScaledFontData): Add orientation.
(WebCore::SimpleFontData::platformBoundsForGlyph): Implemented.

platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Add orientation.

LayoutTests:

Chromium Windows does not implement following 3 functions that are required for bug 51450.

FontMetrics.unitsPerEm() always returns the default value (gDefaultUnitsPerEm = 1000). This change requires rebaseline of fast/repaint/stacked-diacritics and fast/text/emphasis-overlap.
FontPlatformData.orientation() always returns Horizontal. This has no effect as of this patch.
SimpleFontData::platformBoundsForGlyph() always returns FloatRect(). This change improves rendering of text-emphasis and 3 existing tests pass now.

Tony suggested in bug 51450 review to split code that is not behind
#if ENABLE(OPENTYPE_VERTICAL) to a separate patch.

platform/chromium-win/fast/repaint/stacked-diacritics-expected.png:
platform/chromium-win/fast/text/emphasis-overlap-expected.txt: Added due to metrics change.
platform/chromium/TestExpectations: Enabled 3 tests for Chromium Win.

9:36 AM Changeset in webkit [126311] by ap@apple.com

22 edits in trunk

[WK2] Support posting injected bundle messages to a page
https://bugs.webkit.org/show_bug.cgi?id=94630

Reviewed by Sam Weinig.

Shared/APIClientTraits.cpp:
Shared/APIClientTraits.h:
Shared/CoreIPCSupport/InjectedBundleMessageKinds.h:
UIProcess/API/C/WKPage.cpp: (WKPagePostMessageToInjectedBundle):
UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::postMessageToInjectedBundle):
UIProcess/WebPageProxy.h:
WebProcess/InjectedBundle/API/c/WKBundle.h:
WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::didReceiveMessageToPage): (WebKit::InjectedBundle::didReceiveMessage):
WebProcess/InjectedBundle/InjectedBundle.h:
WebProcess/InjectedBundle/InjectedBundleClient.cpp: (WebKit::InjectedBundleClient::didReceiveMessageToPage):
WebProcess/InjectedBundle/InjectedBundleClient.h: (InjectedBundleClient): Added a PostMessageToPage injected bundle message type, with all associated machinery. API is WKPagePostMessageToInjectedBundle(), and an associated didReceiveMessageToPage() injected bundle client function.

WebProcess/qt/QtBuiltinBundle.cpp: (WebKit::QtBuiltinBundle::initialize): Updated for new client API.

UIProcess/WebContext.cpp: (WebKit::WebContext::postMessageToInjectedBundle): Implemented multiple process model case.

9:07 AM Changeset in webkit [126310] by robert@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION(r125578): fast/regex/unicodeCaseInsensitive.html crash on Linux Debug Chromium
https://bugs.webkit.org/show_bug.cgi?id=94010

Reviewed by Tony Chang.

r125578 inspected the raw text run for word-end but the index it used to do so was for a normalized
version of the run that could be longer than the raw text run. So to allow proper detection of word-end
in complex text (i) do not normalize tabs to plain white-space and (ii) go back to using the normalized version
of the run for detecting word-end. There is a risk that some fonts may create glyphs for the '\t' character
but this does not turn up in any of our regression tests and the more common risk appears to be the new-line.

Test: fast/regex/unicodeCaseInsensitive.html

platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::normalizeSpacesAndMirrorChars):

9:01 AM Changeset in webkit [126309] by dmazzoni@google.com

4 edits in trunk

REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
https://bugs.webkit.org/show_bug.cgi?id=94200

Reviewed by Chris Fleizach.

Tools:

Adds reference counting for AtkObjects referenced by
AccessibilityUIElementGtk. This prevents bogus results and
assertion failures on AccessibilityUIElements whose underlying
object has been deleted (as opposed to just made defunct).

This fixes two tests that were previously failing because of this bug.

DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):

LayoutTests:

This patch fixes two tests and removes them from gtk expectations.

platform/gtk/TestExpectations:

8:54 AM Changeset in webkit [126308] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Support the communication protocol from the injected script
https://bugs.webkit.org/show_bug.cgi?id=94689

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-22
Reviewed by Pavel Feldman.

Support the WebGL communication protocol from the injected script module.

inspector/InjectedScriptWebGLModuleSource.js:

(.):

8:53 AM Changeset in webkit [126307] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit/gtk

[GTK] Crash when finalizing WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=94699

Reviewed by Martin Robinson.

Create the offscreen window the first time accelerated compositing
is enabled, so that if it's never enabled the window won't be
created.

WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::initialize):
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer):

8:47 AM Changeset in webkit [126306] by kov@webkit.org

11 edits in trunk

[GTK] Split WebCore/platform into a separate library
https://bugs.webkit.org/show_bug.cgi?id=94435

Reviewed by Martin Robinson.

More people have been reporting problems when linking WebCore because
the command line limit is being exceeded. Splitting WebCore a bit more
is in order.

GNUmakefile.am: add variable that will hold the list of source files

for libWebCorePlatform .

Source/WebCore:

GNUmakefile.am: add new libWebCorePlatform convenience library.
GNUmakefile.list.am: move list of platform/* files to its own variable.

Source/WebKit/gtk:

GNUmakefile.am: link libWebCorePlatform into libwebkitgtk

Source/WebKit2:

GNUmakefile.am: link libWebCorePlatform into libwebkit2gtk

Tools:

GNUmakefile.am: link libWebCorePlatform into DRT

8:46 AM Changeset in webkit [126305] by rakuco@webkit.org

2 edits in trunk/Source/WebCore

[EFL] Build failures with harfbuzz outside standard locations
https://bugs.webkit.org/show_bug.cgi?id=93030

Reviewed by Rob Buis.

Add ${HARFBUZZ_INCLUDE_DIRS} to the list of included paths: so far
it was being implicitly pulled from evas's pkg-config file, and
used to work when WebKit-EFL's dependencies were built with
jhbuild -- in this case, harfbuzz is built before evas, which is
then built with harfbuzz support and adds the required paths to
its .pc file.

We need to include things directly to account for the case of
people not using jhbuild and thus not necessarily having harfbuzz
as an evas dependency.

PlatformEfl.cmake:

8:34 AM Changeset in webkit [126304] by commit-queue@webkit.org

13 edits
4 adds in trunk

Crash in WebCore::RenderBlock::removeChild
https://bugs.webkit.org/show_bug.cgi?id=93879

Patch by Raul Hudea <rhudea@adobe.com> on 2012-08-22
Reviewed by Abhishek Arya.

Source/WebCore:

By adding the lifetime state to the RenderNamedFlowThread (r122556), it become possible for the a RenderRegion object to delete its sibling,
the RenderNamedFlowThread. This is unexpected in the rendering world and cause problems in RenderBlock::removeChild where we retain previous
and next sibling pointers.
So, all the RenderNamedFlowThread are created under a RenderFlowThreadContainer object insted of the RenderView. The new object is created only
when the first named flow is created.

Test: fast/regions/remove-flow-thread-crash.html

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::FlowThreadController): Added initialization for the new RenderFlowThreadContainer member
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName): Added the creation of the RenderFlowThreadContainer object and use it as a parent for all RenderNamedFlowThreads
(WebCore::FlowThreadController::styleDidChange): Inform all the RenderNamedFlowThreads that the style changed in regions (initially this code was in RenderView, but now all RenderNamedFlowThreads are children of RenderFlowThreadContainer)
(WebCore):

rendering/FlowThreadController.h:

(WebCore):
(FlowThreadController):

rendering/RenderFlowThreadContainer.cpp: Added.

(WebCore):
(WebCore::RenderFlowThreadContainer::RenderFlowThreadContainer):
(WebCore::RenderFlowThreadContainer::layout):

rendering/RenderFlowThreadContainer.h: Added.
rendering/RenderObject.cpp:

(WebCore::RenderObject::markContainingBlocksForLayout): Skip to RenderView if the current object is an RenderFlowThreadContainer.

rendering/RenderObject.h:

(WebCore::RenderObject::isRenderFlowThreadContainer):

rendering/RenderView.cpp:

(WebCore::RenderView::styleDidChange): Moved the code associated to RenderNamedFlowThreads to FlowThreadController:styleDidChange and call it instead.

LayoutTests:

Test the region-flow_thread sibling case

fast/regions/remove-flow-thread-crash-expected.txt: Added.
fast/regions/remove-flow-thread-crash.html: Added.

8:28 AM Changeset in webkit [126303] by rwlbuis@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Add RSS content handling support
https://bugs.webkit.org/show_bug.cgi?id=93496

Reviewed by Yong Li.

Cleanup some more.

platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore):
(WebCore::createParser):
(WebCore::defaultEncodingForLanguage):
(WebCore::isTranscodingNeeded):

7:51 AM Changeset in webkit [126302] by caio.oliveira@openbossa.org

5 edits in trunk/Source/WebCore

Remove unused TextDrawingMode flags from GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=21898

Reviewed by Benjamin Poulain.

Remove TextModeClip and TextModeInvisible. These are not used by any port, and
according to https://bugs.webkit.org/show_bug.cgi?id=42110#c2 these were added
just to map CG existing flags, but are not used.

platform/graphics/GraphicsContext.h:
platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setPlatformTextDrawingMode):

platform/graphics/openvg/PainterOpenVG.cpp:

(WebCore::PainterOpenVG::drawText):

platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::setTextDrawingMode):

7:13 AM Changeset in webkit [126301] by Csaba Osztrogonác

9 edits in trunk

Unreviewed, rolling out r126287.
http://trac.webkit.org/changeset/126287
https://bugs.webkit.org/show_bug.cgi?id=94708

It made WK1 layout testing 3.7x slower (>1hours) (Requested by
ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-22

Source/WebCore:

bridge/qt/qt_instance.cpp:

(JSC::Bindings::unusedWeakObjectMapCallback):
(Bindings):
(JSC::Bindings::WeakMapImpl::WeakMapImpl):
(JSC::Bindings::WeakMapImpl::~WeakMapImpl):
(JSC::Bindings::WeakMap::~WeakMap):
(JSC::Bindings::WeakMap::set):
(JSC::Bindings::WeakMap::get):
(JSC::Bindings::WeakMap::remove):

bridge/qt/qt_instance.h:

(QtInstance):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):

bridge/qt/qt_runtime.h:

(QtRuntimeMethod):

Source/WebKit/qt:

tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::objectDeleted):
(tst_QObjectBridge::introspectQtMethods_data):
(tst_QObjectBridge::introspectQtMethods):

LayoutTests:

platform/qt/Skipped:

7:11 AM Changeset in webkit [126300] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Not reviewed: follow up to r126297, fixing WebCore.gypi.

WebCore.gypi:

7:00 AM Changeset in webkit [126299] by allan.jensen@nokia.com

2 edits in trunk/Tools

Unreviewed buildfix for Qt-minimal after r126291

Disable smooth scrolling when request-animation-frame has been disabled either
explicitly or as part of --minimal.

qmake/mkspecs/features/features.prf:

6:34 AM Changeset in webkit [126298] by Carlos Garcia Campos

11 edits in trunk/Source

[GTK] Preferred languages and spellchecker APIs are not consistent in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=94683

Reviewed by Alejandro G. Castro.

Source/WebCore:

Use a Vector<String> instead of a comma-separated string to
get/set languages.

platform/text/gtk/TextCheckerEnchant.cpp:

(TextCheckerEnchant::updateSpellCheckingLanguages):
(TextCheckerEnchant::getSpellCheckingLanguages):

platform/text/gtk/TextCheckerEnchant.h:

(TextCheckerEnchant):

Source/WebKit/gtk:

webkit/webkitspellcheckerenchant.cpp:

(updateSpellCheckingLanguages): Split the languages string to pass a
Vector to updateSpellCheckingLanguages().

Source/WebKit2:

Change spell-checker and preferred languages API to use a GStrv
instead of a comma-separated string and GList. This makes the API
more consistent and convenient to use.

UIProcess/API/gtk/WebKitTextChecker.cpp:

(WebKitTextChecker::getSpellCheckingLanguages): Return a
Vector<String> instead of a String.
(WebKitTextChecker::setSpellCheckingLanguages): Receive a
Vector<String> instead of a String.

UIProcess/API/gtk/WebKitTextChecker.h:

(WebKitTextChecker): Use a GPtrArray to cache languages.

UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_get_spell_checking_languages):
(webkit_web_context_set_spell_checking_languages):
(webkit_web_context_set_preferred_languages):

UIProcess/API/gtk/WebKitWebContext.h:
UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(testWebContextSpellChecker):
(testWebContextLanguages):

6:22 AM Changeset in webkit [126297] by pfeldman@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: move NavigatorView and NavigatorOverlayController to ScriptsPanel module
https://bugs.webkit.org/show_bug.cgi?id=94693

Reviewed by Vsevolod Vlasov.

Loading them via importScript now.

inspector/compile-front-end.py:
inspector/front-end/ScriptsPanel.js:
inspector/front-end/inspector.html:

6:21 AM Changeset in webkit [126296] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

[Qt][WK2] Enable runtime enabled features: DeviceMotion and DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=94692

Reviewed by Kenneth Rohde Christiansen.

WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

6:12 AM Changeset in webkit [126295] by allan.jensen@nokia.com

2 edits in trunk/Source/WebKit2

Wrong default for new ScrollAnimatorEnabled preference.

Reviewed by Simon Hausmann.

ScrollAnimatorEnabled introduced in r126291, should default to 'true'
to preserve existing behaviour on WK2 platforms that already enabled
SMOOTH_SCROLLING unconditionally.

Shared/WebPreferencesStore.h:

(WebKit):

6:12 AM Changeset in webkit [126294] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Fix JSC build when DFG-JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=94694

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-08-22
Reviewed by Csaba Osztrogonác.

Adding an appropriate guard for fixing the build.

bytecode/ResolveGlobalStatus.cpp:

(JSC):

5:56 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

Move pending tasks to the new cycle (diff)

5:50 AM Changeset in webkit [126293] by allan.jensen@nokia.com

2 edits in trunk/Source/WebKit2

Unreviewed, build fixup for r126291.

Shared/WebPreferencesStore.h:

(WebKit):

5:48 AM Changeset in webkit [126292] by commit-queue@webkit.org

5 edits in trunk

[EFL] Support slider tick mark snapping
https://bugs.webkit.org/show_bug.cgi?id=94560

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-22
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Increased the threshold for the EFL port. The value is snapped
when it clicked near tick mark.

No new tests. Covered by fast/forms/datalist/range-snap-to-datalist.html.

platform/efl/RenderThemeEfl.cpp:

(WebCore):
(WebCore::RenderThemeEfl::sliderTickSnappingThreshold):

platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

LayoutTests:

The expected result of fast/forms/datalist/range-snap-to-datalist.html
is updated because slider tick mark snapping threshold is changed.

platform/efl/fast/forms/datalist/range-snap-to-datalist-expected.txt:

5:46 AM Changeset in webkit [126291] by allan.jensen@nokia.com

16 edits in trunk

[Qt] Optionally support smooth-scrolling on all platforms
https://bugs.webkit.org/show_bug.cgi?id=74926

Reviewed by Simon Hausmann.

Source/WebCore:

Make GestureAnimations depend on the GESTURE_ANIMATION feature flag,
since GestureAnimations are unused on some platforms.

Target.pri:
platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::fireUpAnAnimation):
(WebCore::ScrollAnimatorNone::cancelAnimations):
(WebCore::ScrollAnimatorNone::animationTimerFired):

platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

Source/WebKit/qt:

Expose the enable scroll animator setting.

Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):

Api/qwebsettings.h:

Source/WebKit2:

Expose scroll-animator preference, but ensure animated smooth scrolling
on the web process side is disabled when scrolling has been delegated
to the UI process.

Shared/WebPreferencesStore.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
(WebKit::WebPage::updatePreferences):

Source/WTF:

Initialize GESTURE_ANIMATION feature flag.

wtf/Platform.h:

Tools:

Enabled SMOOTH_SCROLLING on Qt, and expose the enable scroll animator
setting in QtTestBrowser so it can be tested.

QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::createChrome):
(LauncherWindow::toggleScrollAnimator):

QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):
(WindowOptions):
(LauncherWindow):

qmake/mkspecs/features/features.pri:

5:26 AM Changeset in webkit [126290] by Simon Hausmann

4 edits in trunk/Source/WebCore

[Qt] Port convertQVariantToValue to use the JSC C API
https://bugs.webkit.org/show_bug.cgi?id=93889

Reviewed by Kenneth Rohde Christiansen.

Based on patch by Noam Rosenthal.

This patch is another step towards reducing the use of internal JSC API
in the Qt bridge. Most of the conversion from QVariant to JS values is
straight-forward. The biggest behavioural change is that QVariant lists
are converted on-the-spot instead of lazily. Bug #94691 tracks fixing
that.

bridge/qt/qt_instance.cpp:

(Bindings):
(JSC::Bindings::QtField::valueFromInstance):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::::valueAt):

bridge/qt/qt_runtime.h:

(Bindings):

4:21 AM Changeset in webkit [126289] by dominik.rottsches@intel.com

2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Gardening after r126025 & r126275.

platform/efl/TestExpectations: Unskipping one, skipping another.

3:59 AM Changeset in webkit [126288] by shinyak@chromium.org

9 edits in trunk/LayoutTests

Test and test expectation of Shadow DOM for button should be fixed.
https://bugs.webkit.org/show_bug.cgi?id=94674

Reviewed by Hajime Morita.

Now that the HTMLButtonElement was AuthroShadowDOM-ready, it's time to update the previous
failing tests for AuthroShadowDOM for button elements.

I've updated the failing tests to follow the current implementation and updated the test expectations.

fast/dom/shadow/shadowdom-for-button-complex-shadow-expected.html:
fast/dom/shadow/shadowdom-for-button-complex-shadow.html:
fast/dom/shadow/shadowdom-for-button-only-shadow-expected.html:
fast/dom/shadow/shadowdom-for-button-only-shadow.html:
fast/dom/shadow/shadowdom-for-button-without-shadow-expected.html:
fast/dom/shadow/shadowdom-for-button-without-shadow.html:
platform/chromium/TestExpectations:
platform/efl/TestExpectations:

3:42 AM Changeset in webkit [126287] by Simon Hausmann

9 edits in trunk

[Qt] REGRESSION(r125428): fast/profiler/nested-start-and-stop-profiler.html fails
https://bugs.webkit.org/show_bug.cgi?id=93897

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Before r125428 run-time methods (wrapped signals, slots or invokable
functions) were subclasses of JSInternalFunction and therefore real
function objects in the JavaScript sense. r125428 changed them to be
just callable objects, but they did not have Function.prototype as
prototype anymore for example nor was their name correct (resulting in
a layout test failure).

This patch changes run-time methods back to being real function objects
that have a correct name and have Function.prototype in their prototype
change

The objects returned by JSObjectMakeFunctionWithCallbackInjected are
light-weight internal function objects that do not support
JSObject{Set/Get}Private. Therefore we inject our own prototype right
before the Function.prototype prototype, which uses private data to
store a pointer to our C++ QtRuntimeMethod object. This complicates
the retrieval of the pointer to that instance slightly, which is why
this patch introduces the toRuntimeMethod convenience function that
looks up our prototype first and does a check for type-safety.

At the same time the patch removes the length properties from the
run-time method itself as well as connect/disconnect. The length
property on a function signifies the number of arguments, but in all
three cases that number is actually variable, because of overloading.
That is why we choose not to expose it in the first place.

In QtInstance we cache the JS wrapper objects for QtRuntimeMethod in a
JSWeakObjectMap. JSWeakObjectMap requires the stored objects to be
either the result of JSObjectMake or the global object of a context ref
(AFAICS), which is ensured using an ASSERT. Objects created via
JSObjectMakeFunctionWithCalllback do not fall into the required
category, cause a failing assertion and can therefore not be stored in
the weak object map.

Consequently this patch removes the use of JSWeakObjectMap again and
goes back to the old way of using the internal Weak<> API, for the time
being. In a future patch the storage will be simplified to not require
the use of a weak object map cache for the run-time methods anymore.

bridge/qt/qt_instance.cpp: Remove unused WeakMap code.
bridge/qt/qt_instance.h: Remove method cache.

(QtInstance):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::toRuntimeMethod):
(Bindings):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):

bridge/qt/qt_runtime.h:

(QtRuntimeMethod): Remove unused member variables.

Source/WebKit/qt:

Fixed some test expectations.

tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::objectDeleted): Since runtime methods are real function objects again, we
can go back to testing Function.prototype.call, as it was done before r125428.
(tst_QObjectBridge::introspectQtMethods_data): Removed tests for the length property.
(tst_QObjectBridge::introspectQtMethods): Changed test expectation of the properties of
run-time methods back to being non-configurable, as before r125428.

LayoutTests:

platform/qt/Skipped: Unskip test that is now passing.

3:37 AM Changeset in webkit [126286] by commit-queue@webkit.org

12 edits in trunk

window.postMessage() / MessagePort.postMessage() throw wrong exception for invalid ports argument
https://bugs.webkit.org/show_bug.cgi?id=94581

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-22
Reviewed by Kentaro Hara.

Source/WebCore:

Update JSC and V8 implementations of window.postMessage() and
MessagePort.postMessage() in order to throw an
INVALID_STATE_ERR instead of a DATA_CLONE_ERR when values
in the "ports" argument are invalid. Additionally, we now
check for duplicate ports and throw an exception for this
case as well.

This change was made to comply with the latest HTML5
specification at:
http://www.w3.org/TR/html5/comms.html

No new tests, already tested by:
fast/events/constructors/message-event-constructor.html
fast/events/message-port-clone.html
fast/events/message-port-multi.html
fast/workers/worker-context-multi-port.html
fast/workers/worker-multi-port.html

bindings/js/JSMessagePortCustom.cpp:

(WebCore::fillMessagePortArray):

bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage):

LayoutTests:

Update several tests and their expected results now that an
INVALID_STATE_ERR is thrown instead of a DATA_CLONE_ERROR
when window.postMessage() / MessagePort.postMessage() are
called with invalid values in their 'ports' argument.

fast/events/constructors/message-event-constructor-expected.txt:
fast/events/constructors/message-event-constructor.html: Stop using duplicate

ports in the test since it throws an exception now.

fast/events/message-port-clone-expected.txt:
fast/events/message-port-multi-expected.txt:
fast/events/resources/message-port-multi.js: Add check for duplicate port case.
fast/workers/worker-context-multi-port-expected.txt:
fast/workers/worker-multi-port-expected.txt:

3:30 AM Changeset in webkit [126285] by commit-queue@webkit.org

2 edits
1 delete in trunk/LayoutTests

Remove chromium/fast/js/array-functions-non-arrays-expected.txt and add WebKit bug id to chromium/TestExpectation.
https://bugs.webkit.org/show_bug.cgi?id=94682

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-08-22
Reviewed by Kentaro Hara.

Only one failing test case remains in array-functions-non-arrays and it is being tracked by Bug 94681.

platform/chromium/TestExpectations:
platform/chromium/fast/js/array-functions-non-arrays-expected.txt: Removed.

3:23 AM Changeset in webkit [126284] by allan.jensen@nokia.com

5 edits
2 adds in trunk

[TouchAdjustment] Adjust to word or selection
https://bugs.webkit.org/show_bug.cgi?id=94449

Reviewed by Antonio Gomes.

Source/WebCore:

Makes each separate word a separate subtarget when context menu triggers
selections, and only the selected part of a partial selected node a
target when selections are not overridden.

Fix of reverted commit r126026, fix misplaced ASSERT.

Test: touchadjustment/context-menu-text-subtargets.html

page/TouchAdjustment.cpp:

(TouchAdjustment):
(WebCore::TouchAdjustment::providesContextMenuItems):
(WebCore::TouchAdjustment::appendQuadsToSubtargetList):
(WebCore::TouchAdjustment::appendBasicSubtargetsForNode):
(WebCore::TouchAdjustment::appendContextSubtargetsForNode):
(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::findBestClickableCandidate):
(WebCore::findBestContextMenuCandidate):

LayoutTests:

Tests that touch-adjustment can adjust to the right subtargets within text-nodes.

touchadjustment/context-menu-select-text.html:
touchadjustment/context-menu-text-subtargets-expected.txt: Added.
touchadjustment/context-menu-text-subtargets.html: Added.
touchadjustment/resources/touchadjustment.js:

(pointToString):
(shouldBeWithin):

2:19 AM Changeset in webkit [126283] by caseq@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Generic framework draft for tracking WebGL resources
https://bugs.webkit.org/show_bug.cgi?id=90597

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-22
Reviewed by Pavel Feldman.

Wrap WebGL rendering context methods and collect a trace log if we are in capturing mode.
Stubbed code for collecting calls contributing to a WebGL resource state so that we could replay them later.

Typical scenario:

we wrap a GL context with InjectedScript.wrapWebGLContext() and return a proxy to the inspected page
the proxy saves all calls necessary to do a replay later - only those that modify a resource's state
when we turn on capturing mode (InjectedScript.captureFrame), we save all WebGL calls to a trace log

inspector/InjectedScriptSource.js:

(.):

inspector/InjectedScriptWebGLModuleSource.js:

(.):

2:10 AM Changeset in webkit [126282] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][GTK] REGRESSION(r126194): http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html fails
https://bugs.webkit.org/show_bug.cgi?id=94677

Unreviewed gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-08-22

platform/qt/Skipped:

2:09 AM Changeset in webkit [126281] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-22

http/tests/inspector/console-resource-errors-expected.txt: Rebaseline after r126168.
platform/qt/Skipped: Skip tests using disabled SHADOW_DOM feature.

1:50 AM Changeset in webkit [126280] by caseq@chromium.org

8 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Add minimum transport protocol from backend to frontend
https://bugs.webkit.org/show_bug.cgi?id=88973

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-22
Reviewed by Pavel Feldman.

Added the following protocol methods to communicate with the WebGL injected
module: captureFrame, getTraceLog, dropTraceLog, replayTraceLog.

inspector/CodeGeneratorInspector.py:
inspector/InjectedScriptWebGLModule.cpp:

(WebCore::InjectedScriptWebGLModule::captureFrame):
(WebCore):
(WebCore::InjectedScriptWebGLModule::dropTraceLog):
(WebCore::InjectedScriptWebGLModule::getTraceLog):
(WebCore::InjectedScriptWebGLModule::replayTraceLog):

inspector/InjectedScriptWebGLModule.h:

(InjectedScriptWebGLModule):

inspector/Inspector.json:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/InspectorWebGLAgent.cpp:

(WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::dropTraceLog):
(WebCore):
(WebCore::InspectorWebGLAgent::captureFrame):
(WebCore::InspectorWebGLAgent::getTraceLog):
(WebCore::InspectorWebGLAgent::replayTraceLog):

inspector/InspectorWebGLAgent.h:

(WebCore):
(WebCore::InspectorWebGLAgent::create):
(InspectorWebGLAgent):

1:47 AM Changeset in webkit [126279] by hans@chromium.org

2 edits in trunk/Source/WebCore

Remove unused field DeleteEntryRequest::m_type
https://bugs.webkit.org/show_bug.cgi?id=94680

Unreviewed build fix.

Remove this unused field. Clang warns about it and it breaks the
Chromium build.

No change in functionality, no new tests.

inspector/InspectorFileSystemAgent.cpp:

(WebCore):

1:45 AM Changeset in webkit [126278] by dominicc@chromium.org

1 edit
4 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaseline tests after http://trac.webkit.org/changeset/126219 .

These are the same results as platform/mac-lion, which until
r126219 were the results of platform/mac. So this is "reverting"
r126219 in terms of Chromium expectations.

platform/chromium/fast/text/hyphenate-locale-expected.png: Added.
platform/chromium/fast/text/hyphenate-locale-expected.txt: Added.
platform/chromium/fast/text/justify-ideograph-vertical-expected.png: Added.
platform/chromium/fast/text/justify-ideograph-vertical-expected.txt: Added.

1:44 AM Changeset in webkit [126277] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[Qt] Avoid using WebKit macros in qrawwebview_p.h
https://bugs.webkit.org/show_bug.cgi?id=94648

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-08-22
Reviewed by Noam Rosenthal.

ENABLE(FEATURE) should not be used in qrawwebview_p.h because it is an API header file.

UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebView::sendTouchEvent):

UIProcess/API/qt/raw/qrawwebview_p.h:

1:42 AM Changeset in webkit [126276] by caseq@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: console.time() should use performance.now()
https://bugs.webkit.org/show_bug.cgi?id=94263

Reviewed by Pavel Feldman.

use monotonicallyIncreasingTime() instead of currentTime() for measuring time intervals

with console.time()/console.timeEnd()

adjust precision to 3 digits after decimal point (i.e. microseconds) when formatting intervals;

inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::stopTiming):

1:20 AM Changeset in webkit [126275] by commit-queue@webkit.org

7 edits
2 adds in trunk

Dynamically styling ShadowDom content on a node distributed to another shadow insertion point fails.
https://bugs.webkit.org/show_bug.cgi?id=92899

Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-22
Reviewed by Hajime Morita.

Source/WebCore:

Since childNeedsStyleRecalc is not cleared when parent nodes are
attached, setNeedsStyleRecalc flag is not reached Document. So,
document() doesn't run re-layout.

Test: fast/dom/shadow/shadowdom-dynamic-styling.html

dom/ContainerNode.h:

(ContainerNode):
(WebCore::ContainerNode::detachAsNode):
Removed detachAsNode, because the below change made the method
not-used.

dom/Element.cpp:

(WebCore::Element::detach):
Modify to invoke ContainerNode::detach when any shadow subtree is
attached. ContainerNode::detach takes care of childNeedsStyleRecalc
flag.

dom/ElementShadow.cpp:

(WebCore::ElementShadow::invalidateDistribution):
Use SetAttached for lazyAttach instead of DoNotSetAttached, because
it is reuired to invoke ContainerNode::detach. If not, attached() is
false and reattach() invokes only attach(). This causes to leave
shadow host's childNeedsStyleRecalc flag true after
Element::recalcStyle.

LayoutTests:

fast/dom/shadow/shadowdom-dynamic-styling-expected.txt: Added.
fast/dom/shadow/shadowdom-dynamic-styling.html: Added.
editing/shadow/delete-characters-in-distributed-node-crash.html:

Made the layout test robust. This patch causes commit-queue- and the
failed test is delete-characters-in-distributed-node-crash.html.
However the layout test passes when locally running run_webkit_test
i.e. no difference between actual and expected texts. And looking at
the commit-queue's report, the actual text has "PASS" message (no
crash messages).

1:11 AM Changeset in webkit [126274] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-22

DEPS:

12:50 AM Changeset in webkit [126273] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Web Inspector: Add deleteEntry command and deletionCompleted event to FileSystemAgent
https://bugs.webkit.org/show_bug.cgi?id=91831

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-22
Reviewed by Vsevolod Vlasov.

InspectorAgent-side implementation of deleteEntry command.

Test will be added after JS-side implementation landed.

inspector/Inspector.json:
inspector/InspectorFileSystemAgent.cpp:

(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
(WebCore::InspectorFileSystemAgent::requestFileContent):
(WebCore::InspectorFileSystemAgent::deleteEntry):
(WebCore::InspectorFileSystemAgent::assertFrontend):

inspector/InspectorFileSystemAgent.h:

(InspectorFileSystemAgent):

inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemDispatcher.prototype.fileContentReceived):
(WebInspector.FileSystemDispatcher.prototype.deletionCompleted):

12:49 AM Changeset in webkit [126272] by dominik.rottsches@intel.com

2 edits in trunk/Tools

Unreviewed, adding myself to committers.py.

Scripts/webkitpy/common/config/committers.py:

12:42 AM Changeset in webkit [126271] by dominicc@chromium.org

3 edits
4 adds
1 delete in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaseline tests after http://trac.webkit.org/changeset/126187 .
These are the same results as platform/mac-lion, which until
r126187 were the results of platform/mac. So this is "reverting"
r126187 in terms of Chromium expectations.
https://bugs.webkit.org/show_bug.cgi?id=94665 was filed
to track optimization of these baselines.

platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/writing-mode/vertical-align-table-baseline-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/writing-mode/vertical-align-table-baseline-expected.txt: Added.
platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.txt: Added.
platform/chromium-mac/fast/writing-mode/vertical-align-table-baseline-expected.png:
platform/chromium-mac/fast/writing-mode/vertical-align-table-baseline-expected.txt: Added.
platform/chromium/TestExpectations:

12:31 AM Changeset in webkit [126270] by dominicc@chromium.org

3 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Update image expectations for these tests. The 'x' to clear out a
text field is slightly brighter on chromium-mac; this is not
material to the intent of the tests.

platform/chromium-mac/fast/css/text-overflow-input-expected.png:
platform/chromium-mac/fast/forms/box-shadow-override-expected.png:

12:24 AM Changeset in webkit [126269] by dominicc@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Add failure expectations for a regression in r126257. See
https://bugs.webkit.org/show_bug.cgi?id=94675

platform/chromium/TestExpectations:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed