Timeline
Oct 27, 2012:
- 11:47 PM Changeset in webkit [132747] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix for breakage to minimal bot caused by r132742.
Patch by Noam Rosenthal <noam.rosenthal@nokia.com> on 2012-10-27
- WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
Added appropriate ENABLE(REQUEST_ANIMATION_FRAME) flag.
- 11:27 PM Changeset in webkit [132746] by
-
- 3 edits1 add in trunk/Source/WebKit/chromium
[Chromium] Find-in-page reports matches in hidden iframes
https://bugs.webkit.org/show_bug.cgi?id=100604
Reviewed by Eric Seidel.
This is actually a regression caused by
http://trac.webkit.org/changeset/128784. This patch adds back some code
removed in WebFrameImpl::shouldScopeMatches in r128784.
This patch also introduces a test so that we don't make this mistake
again.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::shouldScopeMatches):
- tests/WebFrameTest.cpp:
- tests/data/find_in_hidden_frame.html: Added.
- 11:13 PM Changeset in webkit [132745] by
-
- 16 edits in trunk/Source/JavaScriptCore
DFG::Array::Mode needs to be cleaned up
https://bugs.webkit.org/show_bug.cgi?id=100599
Reviewed by Oliver Hunt.
Turn the previous massive Array::Mode enum into a class that contains four
fields, the type, whether it's a JSArray, the level of speculation, and the
kind of conversion to perform.
No performance or behavioral change.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::refine):
(JSC::DFG::ArrayMode::alreadyChecked):
(JSC::DFG::arrayTypeToString):
(JSC::DFG::arrayClassToString):
(DFG):
(JSC::DFG::arraySpeculationToString):
(JSC::DFG::arrayConversionToString):
(JSC::DFG::ArrayMode::toString):
- dfg/DFGArrayMode.h:
(DFG):
(ArrayMode):
(JSC::DFG::ArrayMode::ArrayMode):
(JSC::DFG::ArrayMode::type):
(JSC::DFG::ArrayMode::arrayClass):
(JSC::DFG::ArrayMode::speculation):
(JSC::DFG::ArrayMode::conversion):
(JSC::DFG::ArrayMode::asWord):
(JSC::DFG::ArrayMode::fromWord):
(JSC::DFG::ArrayMode::withSpeculation):
(JSC::DFG::ArrayMode::usesButterfly):
(JSC::DFG::ArrayMode::isJSArray):
(JSC::DFG::ArrayMode::isInBounds):
(JSC::DFG::ArrayMode::mayStoreToHole):
(JSC::DFG::ArrayMode::isOutOfBounds):
(JSC::DFG::ArrayMode::isSlowPut):
(JSC::DFG::ArrayMode::canCSEStorage):
(JSC::DFG::ArrayMode::lengthNeedsStorage):
(JSC::DFG::ArrayMode::modeForPut):
(JSC::DFG::ArrayMode::isSpecific):
(JSC::DFG::ArrayMode::supportsLength):
(JSC::DFG::ArrayMode::benefitsFromStructureCheck):
(JSC::DFG::ArrayMode::doesConversion):
(JSC::DFG::ArrayMode::arrayModesThatPassFiltering):
(JSC::DFG::ArrayMode::operator==):
(JSC::DFG::ArrayMode::operator!=):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShape):
(JSC::DFG::canCSEStorage):
(JSC::DFG::lengthNeedsStorage):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::byValIsPure):
- dfg/DFGNode.h:
(JSC::DFG::Node::arrayMode):
(JSC::DFG::Node::setArrayMode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::typedArrayDescriptor):
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
(JSC::DFG::SpeculativeJIT::temporaryRegisterForPutByVal):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::putByValWillNeedExtraRegister):
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 11:10 PM Changeset in webkit [132744] by
-
- 4 edits in trunk/Source
All tests crash in WebKit1 mode
https://bugs.webkit.org/show_bug.cgi?id=100602
Reviewed by Sam Weinig.
- WebView/WebView.mm: (+[WebView _setLoadResourcesSerially:]): Resource load scheduler is created via a strategy, so strategies need to be initialized before using it.
- 10:49 PM Changeset in webkit [132743] by
-
- 12 edits in trunk/Source/WebKit2
Unreviewed, rolling out r132740.
http://trac.webkit.org/changeset/132740
https://bugs.webkit.org/show_bug.cgi?id=100603
"Causing many crashes" (Requested by weinig on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-27
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::DownloadProxy):
(WebKit::DownloadProxy::invalidate):
(WebKit):
- UIProcess/Downloads/DownloadProxy.h:
(DownloadProxy):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createDownloadProxy):
(WebKit::WebContext::downloadFinished):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h:
(WebKit):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
- UIProcess/WebPageProxy.h:
(CoreIPC):
(WebPageProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::~WebPageGroupProxy):
(WebKit):
(WebKit::WebPageGroupProxy::didReceiveMessage):
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
- WebProcess/WebPage/WebPageGroupProxy.h:
(CoreIPC):
(WebPageGroupProxy):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::didReceiveMessage):
- 6:32 PM Changeset in webkit [132742] by
-
- 10 edits3 adds in trunk
Coordinated Graphics: Animation jerkiness when rAF is enabled
https://bugs.webkit.org/show_bug.cgi?id=100536
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
The jerkiness comes from the fact that we schedule animations excessively; That's because
the previous patch broke requestAnimationFrame behavior during CSS animations, since the
frame returns right away instead of waiting till the previous frame is actually rendered.
This patch makes sure that when animations are scheduled, they're only serviced after the
UI process has actually painted the previous frame. We do so by sending a
RequestAnimationFrame message to the UI process, which responds with AnimationFrameReady
after the UI process paints.
New test: fast/animations/request-animation-frame-too-rapid.html
Tests that we don't receive an unreasonably high number of callbacks from
requestAnimationFrame (> 1000FPS).
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit):
(WebKit::LayerTreeCoordinatorProxy::requestAnimationFrame):
(WebKit::LayerTreeCoordinatorProxy::animationFrameReady):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::paintToCurrentGLContext):
(WebKit):
(WebKit::LayerTreeRenderer::animationFrameReady):
(WebKit::LayerTreeRenderer::requestAnimationFrame):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit):
(WebKit::LayerTreeCoordinator::scheduleAnimation):
(WebKit::LayerTreeCoordinator::animationFrameReady):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.messages.in:
LayoutTests:
Added a test to make sure we don't respond too eagerly to requestAnimationFrame.
- fast/animation/request-animation-frame-too-rapid-expected.txt: Added.
- fast/animation/request-animation-frame-too-rapid.html: Added.
- fast/animation/script-tests/request-animation-frame-too-rapid.js: Added.
- 6:31 PM Changeset in webkit [132741] by
-
- 2 edits in trunk/Source/WebCore
Fix AVFoundation build.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::addKey):
- 1:48 PM Changeset in webkit [132740] by
-
- 12 edits in trunk/Source/WebKit2
Yet more MessageReceivering
https://bugs.webkit.org/show_bug.cgi?id=100325
Reviewed by Anders Carlsson.
Make DownloadProxy, WebPageProxy, and WebPageGroupProxy MessageReceivers.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::DownloadProxy):
(WebKit::DownloadProxy::invalidate):
(WebKit::DownloadProxy::didReceiveMessage):
(WebKit::DownloadProxy::didReceiveSyncMessage):
- UIProcess/Downloads/DownloadProxy.h:
(DownloadProxy):
Make a MessageReceiver.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::addMessageReceiver):
(WebKit::WebContext::removeMessageReceiver):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h:
Add additional MessageReceiverMap forwards, and stop dealing with DownloadProxy explicitly.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
- UIProcess/WebPageProxy.h:
Make a MessageReceiver, but keep sub objects using didReceiveMessage for now (like WebPage).
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addMessageReceiver):
(WebKit::WebProcessProxy::removeMessageReceiver):
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
Give WebProcessProxy a MessageReceiverMap and all the appropriate forwarding methods.
- WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
(WebKit::WebPageGroupProxy::~WebPageGroupProxy):
(WebKit::WebPageGroupProxy::didReceiveMessage):
- WebProcess/WebPage/WebPageGroupProxy.h:
(WebKit::WebPageGroupProxy::isVisibleToHistoryClient):
(WebPageGroupProxy):
Make a MessageReceiver and register/unregister with the WebProcess.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
Remove extraneous return statement.
(WebKit::WebProcess::didReceiveMessage):
Stop handling WebPageGroupProxy special.
- 1:33 PM Changeset in webkit [132739] by
-
- 4 edits in trunk/Source/WTF
Try to create AtomicString as 8 bit where possible
https://bugs.webkit.org/show_bug.cgi?id=100575
Reviewed by Oliver Hunt.
Added StringImpl::create8BitIfPossible() that first tries to create an 8 bit string. If it finds a 16 bit character
during processing, it calls the standard create() method. The assumption is that this will be used on mostly 8 bit
strings and ones that are shorter (in the tens of characters). Changed AtomicString to use the new creation method
for UChar based construction.
- wtf/text/AtomicString.cpp:
(WTF::UCharBufferTranslator::translate):
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::create8BitIfPossible):
- wtf/text/StringImpl.h:
(WTF::StringImpl::create8BitIfPossible):
- 1:31 PM Changeset in webkit [132738] by
-
- 8 edits in trunk/Source/WebKit2
Completely roll out https://bugs.webkit.org/show_bug.cgi?id=99251 (r131686)
It has caused too many crashes.
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/mac/WKView.mm:
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/API/mac/WKViewPrivate.h:
- UIProcess/mac/CorrectionPanel.mm:
- UIProcess/mac/WKFullScreenWindowController.mm:
- UIProcess/mac/WebFullScreenManagerProxyMac.mm:
- 11:27 AM Changeset in webkit [132737] by
-
- 2 edits in trunk/Source/WebCore
ASSERTION FAILED: m_next in LayoutState.cpp
https://bugs.webkit.org/show_bug.cgi?id=99796
Reviewed by Eric Seidel.
Before RenderMathMLBlock::computeChildrenPreferredLogicalHeights calls child->layoutIfNeeded(),
it must ensure a layoutState exists. We disable it in any case, since we are just calculating
metrics here, and the final layout may well happen again.
No new tests. I don't know how to create an automated test for this. The crashes users are
seeing are flaky.
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
- 11:25 AM Changeset in webkit [132736] by
-
- 2 edits in trunk/Source/WTF
String::fromUTF8() should take advantage of the ASCII check in convertUTF8ToUTF16()
https://bugs.webkit.org/show_bug.cgi?id=100577
Reviewed by Oliver Hunt.
Passed is ASCII flag to convertUTF8ToUTF16() and if try, create an 8 bit string from the original arguments.
- wtf/text/WTFString.cpp:
(WTF::String::fromUTF8):
- 11:18 AM Changeset in webkit [132735] by
-
- 5 edits2 adds in trunk
[MathML] Improve some addChild methods
https://bugs.webkit.org/show_bug.cgi?id=98791
Reviewed by Eric Seidel.
Source/WebCore:
MathML addChild methods need to handle any anonymous renderers correctly. Actually, most MathML elements have a fixed
number of children, so conformant javascript won't be doing arbitrary addChild and removeChild calls. However, we don't
want any assertions to fail, and we do want addChild to work correctly when beforeChild == 0, to build up the original
renderer, and then replaceChild at least should work correctly after that. We therefore clean up these routines before
giving them to the chromium fuzzers.
It's best to build the anonymous wrappers just once initially if possible, so empty wrappers aren't left in the render
tree after later removeChild calls.
Test: mathml/presentation/dynamic.html added for mfrac and msqrt. There are already tests for dynamically changing
msub/sup elements, in mathml/presentation/m*-changed.xhtml.
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::addChild):
- The two wrappers are built initially. Also, the old RenderMathMLBlock::addChild(row, beforeChild); doesn't really work because beforeChild is buried inside a wrapper. This new routine allows the numerator and denominator to be added initially, and then later replaced with replaceChild. It's not clear whether e.g. a plain removeChild of a numerator should move the remaining child from the denominator to the numerator or not, so we ignore that for now.
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::addChild):
- A bit of bullet-proofing for the fuzzers.
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::addChild):
- Like RenderMathMLFraction::addChild, we create the wrappers once initially, and then fill them dynamically.
LayoutTests:
- mathml/presentation/dynamic-expected.html: Added.
- mathml/presentation/dynamic.html: Added.
- 11:17 AM Changeset in webkit [132734] by
-
- 2 edits in trunk/Source/WebKit2
buildHTTPHeaders() should use a StringBuilder instead of a Vector<UChar>
https://bugs.webkit.org/show_bug.cgi?id=100580
Reviewed by Oliver Hunt.
Replaced Vector<UChar> with StringBuilder in the HTTP header construction function buildHTTPHeaders.
This eliminates 8 -> 16 bit up conversion of the strings involved.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::buildHTTPHeaders):
- 11:16 AM Changeset in webkit [132733] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed gardening.
Removing my garbage, now from svn.
- platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png: Removed.
- 10:22 AM Changeset in webkit [132732] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed gardening.
Added one more png to a wrong path in my previous commit, removing it and hoping that
the directory will not stay in svn.
- platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Removed.
- 10:18 AM Changeset in webkit [132731] by
-
- 3 edits2 adds in trunk
Background images can incorrectly repeat with sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=94622
Reviewed by Emil A Eklund.
Source/WebCore:
Attempting to better match author expectations when painting tiled background images. When under
the effects of zoom with sub-pixel layout enabled, the drawn size of a rendered element can
differ depending on its location. This change looks at the size of the scaled tiled background
image size, and either ceils or floors that value depending on if tiling that value will
result in us being one pixel or less short of covering the background size. This is a heuristic,
as sub-pixel/zooming isn't specced.
Test: fast/sub-pixel/scaled-background-image.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::applySubPixelHeuristicForTileSize):
(WebCore):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
LayoutTests:
- fast/sub-pixel/scaled-background-image-expected.html: Added.
- fast/sub-pixel/scaled-background-image.html: Added.
- 10:15 AM Changeset in webkit [132730] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r132725.
http://trac.webkit.org/changeset/132725
https://bugs.webkit.org/show_bug.cgi?id=100596
it broke linking on chromium debug bots (Requested by loislo
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-27
- inspector/InspectorMemoryAgent.cpp:
(WebCore::addPlatformComponentsInfo):
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
- platform/MemoryUsageSupport.h:
(ComponentInfo):
(WebCore::MemoryUsageSupport::ComponentInfo::ComponentInfo):
(MemoryUsageSupport):
- platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
- platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryTypes):
- platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
- platform/qt/MemoryUsageSupportQt.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
- 9:14 AM Changeset in webkit [132729] by
-
- 49 edits in trunk
REAL_PLATFORM_NAME build setting is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=100587
Reviewed by Mark Rowe.
Removed the definition of REAL_PLATFORM_NAME and replaced references to it with references
to PLATFORM_NAME.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/JSC.xcconfig:
- Configurations/JavaScriptCore.xcconfig:
- Configurations/ToolExecutable.xcconfig:
Source/ThirdParty:
- gtest/xcode/Config/CompilerVersion.xcconfig:
- gtest/xcode/Config/General.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKit.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- Configurations/BaseTarget.xcconfig:
- Configurations/CompilerVersion.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/WebKit2.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/CompilerVersion.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- 9:07 AM Changeset in webkit [132728] by
-
- 1 edit27 adds in trunk/LayoutTests
Pixel tests need rebaseline https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed gardening.
Reland Qt-WebKit2 new expectations part 2 with fixed paths.
- platform/qt-5.0-wk2/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/full-screen-stacking-context-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/full-screen-zIndex-after-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/full-screen-zIndex-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-getItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGNumberList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPointList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGTransformList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
- platform/qt-5.0-wk2/svg/repaint/image-href-change-expected.png: Added.
- platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png: Added.
- 9:05 AM Changeset in webkit [132727] by
-
- 1 edit75 adds in trunk/LayoutTests
Pixel tests need rebaseline https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed gardening.
Reland Qt-WebKit2 new expectations part 1 with fixed paths.
- platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Added.
- platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png: Added.
- platform/qt-5.0-wk2/css3/flexbox/repaint-expected.png: Added.
- platform/qt-5.0-wk2/css3/flexbox/repaint-rtl-column-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/border-shadow-large-radius-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/outline-alpha-block-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/outline-alpha-inline-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-composite-transformclip-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-empty-image-pattern-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-resize-reset-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-transforms-during-path-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/image-pattern-rotate-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/toDataURL-alpha-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/border-radius-non-negative-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/linear-gradient-currentcolor-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/file/file-input-pressed-state-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-color-stops-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients2-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients3-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/gradient-after-transparent-border-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/jpeg-with-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/paint-subrect-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/paint-subrect-grid-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/png-with-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/absolute-position-changed-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-show-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-inside-table-cell-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/replaced/outline-replaced-elements-expected.png: Added.
- platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/table-row-focus-ring-paint-expected.png: Added.
- 8:13 AM Changeset in webkit [132726] by
-
- 12 edits in trunk
Remove internals shouldDisplayTrackKind methods; these are also on internals.settings
https://bugs.webkit.org/show_bug.cgi?id=100564
Reviewed by Adam Barth.
Source/WebCore:
Remove duplicate methods from internals that was just forwarding on the call to internals.settings.
Also fix a bug where we didn't reset these settings properly.
No new tests, this is covered by existing media/track tests.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Properly save display track settings.
(WebCore::InternalSettings::Backup::restoreTo): Restore display track settings.
- testing/InternalSettings.h:
- testing/InternalSettings.idl: Use [Conditional=VIDEO_TRACK].
- testing/Internals.cpp: Remove code.
- testing/Internals.h: Remove code.
- testing/Internals.idl: Remove code.
LayoutTests:
Update tests to use the internals.settings method.
- media/track/track-language-preference-expected.txt:
- media/track/track-language-preference.html:
- media/track/track-prefer-captions-expected.txt:
- media/track/track-prefer-captions.html:
- 8:11 AM Changeset in webkit [132725] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: instrument chromium GlyphCache. It keeps ~2mb.
https://bugs.webkit.org/show_bug.cgi?id=100515
Reviewed by Yury Semikhatsky.
I replaced old version with an abstract number with new one which precisely reports allocated SkGlyphCache objects and their sizes.
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::reportMemoryUsage):
- platform/MemoryUsageSupport.h:
(MemoryUsageSupport):
- platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
- platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryTypes):
- platform/chromium/MemoryUsageSupportChromium.cpp:
(reportMemoryUsage):
(WebCore::reportGlyphCache):
(WebCore):
(WebCore::MemoryUsageSupport::reportMemoryUsage):
- platform/qt/MemoryUsageSupportQt.cpp:
(WebCore::MemoryUsageSupport::reportMemoryUsage):
- 12:01 AM Changeset in webkit [132724] by
-
- 5 edits2 adds in trunk
Prevent NaN offset values in ElementTimeControl.
https://bugs.webkit.org/show_bug.cgi?id=100322
Reviewed by Abhishek Arya.
Source/WebCore:
NaN values can cause ElementTimeControl to go back in time!
If a value of NaN is passed to ElementTimeControl::beginElementAt(offset),
subsequent sorting will cause an assert in SVGSMILElement::findInstanceTime
because NaN values are not properly sorted. NaN SMILTime values
should not be allowed at all, so this patch adds a check for them in
ElementTimeControl's setters.
This patch also adds preventative asserts to catch if SMILTime is ever
initialized with NaN, or if addEndTime/addBeginTime are ever called
with NaN values.
Test: svg/custom/elementTimeControl-nan-crash.html
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):
- svg/animation/SMILTime.h:
(WebCore::SMILTime::SMILTime):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::addBeginTime):
(WebCore::SVGSMILElement::addEndTime):
LayoutTests:
- svg/custom/elementTimeControl-nan-crash-expected.txt: Added.
- svg/custom/elementTimeControl-nan-crash.html: Added.
Oct 26, 2012:
- 11:55 PM Changeset in webkit [132723] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip new failing tests.
- platform/qt/TestExpectations:
- 11:00 PM Changeset in webkit [132722] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Browser prematurely sends wrong credentials
https://bugs.webkit.org/show_bug.cgi?id=100585
Reviewed by Yong Li.
Manually revert the patch for bug 96362, which causes regressions and the right patch has been
submitted with patch for bug 100448. Since the auto-revert fails, we use this patch to manually
revert.
No new tests. The test is coverted by patch for 100448.
- platform/network/blackberry/CredentialBackingStore.cpp:
- platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- 10:59 PM Changeset in webkit [132721] by
-
- 24 edits4 copies4 adds in trunk/Source
Have NetworkProcess manage resource load scheduling.
https://bugs.webkit.org/show_bug.cgi?id=100479
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Down in WebCore we need to virtualize a handful of ResourceLoadScheduler methods
to be overridden by WebKit's implementation.
No new tests (No change in Core behavior).
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- loader/ResourceLoadScheduler.cpp:
(WebCore::resourceLoadScheduler): Gracefully handle LoaderStrategies wanting to return the default scheduler.
(WebCore::ResourceLoadScheduler::scheduleLoad): Call notifyDidScheduleResourceRequest.
(WebCore::ResourceLoadScheduler::notifyDidScheduleResourceRequest): Moved InspectorInstrumentation call
here so derived classes can do it indirectly.
(WebCore::ResourceLoadScheduler::startResourceLoader): To allow derived classes the ability to call
ResourceLoader::start() which only ResourceLoadScheduler can do.
- loader/ResourceLoadScheduler.h:
(ResourceLoadScheduler): Virtualize some core public methods so they can be overridden.
(WebCore::ResourceLoadScheduler::setSerialLoadingEnabled): Make virtual.
(WebCore::ResourceLoadScheduler::isSuspendingPendingRequests): Make private as it's internal only.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::setIdentifier): Add this setter so outside clients can manually change the identifier.
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::identifier): Change identifier to explicitly be uint64_t.
(WebCore::ResourceLoader::request): Make public.
(ResourceLoader):
Source/WebKit2:
Implement a ResourceLoadScheduler that models the same behavior as WebCore::ResourceLoadScheduler.
The WebProcess scheduler acts as a marshall to the NetworkProcess scheduler via CoreIPC messaging.
Besides MainResourceLoads which are started directly in the WebProcess, all other loads are now
started only when the NetworkProcess tells them to start.
Build-system and messaging related stuff:
- DerivedSources.make:
- Platform/CoreIPC/MessageID.h:
- WebKit2.xcodeproj/project.pbxproj:
Add a new Network logging channel.
- Platform/Logging.cpp:
(WebKit::getChannelFromName):
- Platform/Logging.h:
Modeled after ResourceLoadScheduler::HostInformation but more specifically geared towards what NetworkProcess needs to track:
- NetworkProcess/HostRecord.cpp: Added.
(WebKit::HostRecord::HostRecord):
(WebKit::HostRecord::~HostRecord):
(WebKit::HostRecord::schedule):
(WebKit::HostRecord::addLoadInProgress):
(WebKit::HostRecord::remove):
(WebKit::HostRecord::hasRequests):
(WebKit::HostRecord::limitRequests):
- NetworkProcess/HostRecord.h:
(WebKit::HostRecord::name):
(WebKit::HostRecord::requestsPending):
Gateway messaging from the WebResourceLoadScheduler to the NetworkResourceLoadScheduler:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::registerObserver):
(WebKit::NetworkConnectionToWebProcess::unregisterObserver):
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::scheduleNetworkRequest):
(WebKit::NetworkConnectionToWebProcess::addLoadInProgress):
(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier):
(WebKit::NetworkConnectionToWebProcess::crossOriginRedirectReceived):
(WebKit::NetworkConnectionToWebProcess::servePendingRequests):
(WebKit::NetworkConnectionToWebProcess::suspendPendingRequests):
(WebKit::NetworkConnectionToWebProcess::resumePendingRequests):
(WebKit::NetworkConnectionToWebProcess::setSerialLoadingEnabled):
- NetworkProcess/NetworkConnectionToWebProcess.h:
(NetworkConnectionToWebProcessObserver): Add an observer interface so arbitrary objects can be notified if
a Network->WebProcess connection closes.
(WebKit::NetworkConnectionToWebProcessObserver::~NetworkConnectionToWebProcessObserver):
(WebKit::NetworkConnectionToWebProcess::isSerialLoadingEnabled):
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
Represents a request, ResourceLoadIdentifier, and connection that all correspond to the same pending NetworkLoad:
- NetworkProcess/NetworkRequest.cpp:
(WebKit::NetworkRequest::NetworkRequest):
(WebKit::NetworkRequest::~NetworkRequest):
(WebKit::NetworkRequest::connectionToWebProcessDidClose): Using the NetworkConnectionToWebProcessObserver interface,
if the connection closes then clear out the connection pointer for this request that is now irrelevant.
- NetworkProcess/NetworkRequest.h:
(WebKit::NetworkRequest::create):
(WebKit::NetworkRequest::identifier):
(WebKit::NetworkRequest::connectionToWebProcess):
Manages connection-per-host scheduling with the same structure as WebCore::ResourceLoadScheduling but also with IPC:
- NetworkProcess/NetworkResourceLoadScheduler.cpp: Added.
(WebKit::NetworkResourceLoadScheduler::NetworkResourceLoadScheduler):
(WebKit::NetworkResourceLoadScheduler::scheduleServePendingRequests):
(WebKit::NetworkResourceLoadScheduler::requestTimerFired):
(WebKit::NetworkResourceLoadScheduler::scheduleNetworkRequest):
(WebKit::NetworkResourceLoadScheduler::addLoadInProgress):
(WebKit::NetworkResourceLoadScheduler::hostForURL):
(WebKit::NetworkResourceLoadScheduler::removeLoadIdentifier):
(WebKit::NetworkResourceLoadScheduler::crossOriginRedirectReceived):
(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
(WebKit::NetworkResourceLoadScheduler::servePendingRequestsForHost): Serve as many requests for the host as we should,
skipping the NetworkRequests who have lost their connection to their WebProcess.
(WebKit::NetworkResourceLoadScheduler::suspendPendingRequests):
(WebKit::NetworkResourceLoadScheduler::resumePendingRequests):
- NetworkProcess/NetworkResourceLoadScheduler.h: Added.
- NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm: Added.
(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost):
- NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::networkResourceLoadScheduler): Add a scheduler global to the NetworkProcess.
A thin derivation of WebCore::ResourceLoadScheduler, most of what WebResourceLoadScheduler does is handle IPC to the NetworkProcess:
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::WebResourceLoadScheduler):
(WebKit::WebResourceLoadScheduler::scheduleSubresourceLoad):
(WebKit::WebResourceLoadScheduler::schedulePluginStreamLoad):
(WebKit::WebResourceLoadScheduler::scheduleLoad):
(WebKit::WebResourceLoadScheduler::addMainResourceLoad):
(WebKit::WebResourceLoadScheduler::remove):
(WebKit::WebResourceLoadScheduler::crossOriginRedirectReceived):
(WebKit::WebResourceLoadScheduler::servePendingRequests):
(WebKit::WebResourceLoadScheduler::suspendPendingRequests):
(WebKit::WebResourceLoadScheduler::resumePendingRequests):
(WebKit::WebResourceLoadScheduler::setSerialLoadingEnabled):
(WebKit::WebResourceLoadScheduler::startResourceLoad):
- WebProcess/Network/WebResourceLoadScheduler.h:
Add the ability for the NetworkProcess to message back to the WebProcess telling it to start a resource load:
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
(WebKit::NetworkProcessConnection::startResourceLoad):
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Network/NetworkProcessConnection.messages.in:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::resourceLoadScheduler): Only return the WebResourceLoadScheduler if NetworkProcess is enabled.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureNetworkProcessConnection): Actually keep the NetworkProcessConnection around in a member variable.
(WebKit::WebProcess::networkConnection):
- WebProcess/WebProcess.h:
(WebKit::WebProcess::usesNetworkProcess): Expose this for platform strategies sake.
- 7:10 PM Changeset in webkit [132720] by
-
- 5 edits4 adds in trunk
Implement AudioBufferSourceNode .loopStart and .loopEnd attributes
https://bugs.webkit.org/show_bug.cgi?id=100170
Reviewed by Kenneth Russell.
Source/WebCore:
AudioBufferSourceNode currently only supports looping of an entire AudioBuffer.
Sample-based synthesis is a very common technique which requires "internal" loop-points.
For example, the first part of the sample data might represent the attack portion of
a synthesized instrument, which then enters a loop portion.
Tests: webaudio/audiobuffersource-loop-comprehensive.html
webaudio/audiobuffersource-loop-points.html
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):
- Modules/webaudio/AudioBufferSourceNode.h:
(AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::loopStart):
(WebCore::AudioBufferSourceNode::loopEnd):
(WebCore::AudioBufferSourceNode::setLoopStart):
(WebCore::AudioBufferSourceNode::setLoopEnd):
- Modules/webaudio/AudioBufferSourceNode.idl:
LayoutTests:
- webaudio/audiobuffersource-loop-comprehensive-expected.txt: Added.
- webaudio/audiobuffersource-loop-comprehensive.html: Added.
- webaudio/audiobuffersource-loop-points-expected.wav: Added.
- webaudio/audiobuffersource-loop-points.html: Added.
- 7:07 PM Changeset in webkit [132719] by
-
- 8 edits in trunk/LayoutTests
[Chromium] Test expectation update.
Rebaseline for recent forms changes.
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium/TestExpectations:
- 6:53 PM Changeset in webkit [132718] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Convert Chromium template string to an LDML date format
https://bugs.webkit.org/show_bug.cgi?id=100128
Reviewed by Tony Chang.
- src/LocalizedStrings.cpp:
(WebCore): Include WebCore/platform/text/DateTimeFormat.h.
(WebCore::weekFormatInLDML):
Replace $1 with yyyy, $2 with ww, and quote other parts.
- 6:37 PM Changeset in webkit [132717] by
-
- 1 edit1 add in trunk/PerformanceTests
Add a microbenchmark for Hindi (complex-text) line-layout
https://bugs.webkit.org/show_bug.cgi?id=100024
Reviewed by Ryosuke Niwa.
I wrote this to make sure that we don't regress line-breaking performance
for the complex-text codepath. This test has shown me that TOT is
already 5% slower than Safari 6.0.1 here. :(
- Layout/hindi-line-layout.html: Added.
- 6:31 PM Changeset in webkit [132716] by
-
- 7 edits2 adds in trunk
dragover's default action should prevent drop for file drags
https://bugs.webkit.org/show_bug.cgi?id=79173
Reviewed by Tony Chang.
Source/WebCore:
During a file drag, we need to keep track of whether or not the document has cancelled the
dragover action. We should only send a drop event if the dragover event was cancelled; this
matches the behavior of the spec, as well as IE, Gecko, and Opera. The relevant sections
from the spec are the sections pertaining to dragover and drop events at:
http://www.whatwg.org/specs/web-apps/current-work/#drag-and-drop-processing-model
Test: fast/events/only-valid-drop-targets-receive-file-drop.html
- page/DragController.cpp:
(WebCore::DragController::performDrag):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::tryDocumentDrag):
- page/DragController.h:
(DragController): Cleanup to repurpose a variable that doesn't need to be a member anymore
and remove the corresponding getter/setter.
LayoutTests:
- fast/dom/shadow/drop-event-in-shadow.html:
Added dragover handler as required by the HTML specification.
- fast/events/input-element-display-none-in-dragleave-crash.html:
Added dragover handler as required by the HTML specification.
- fast/events/only-valid-drop-targets-receive-file-drop-expected.txt: Added.
- fast/events/only-valid-drop-targets-receive-file-drop.html: Added.
- http/tests/security/clipboard/clipboard-file-access.html:
Added dragover handler as required by the HTML specification.
- 6:20 PM Changeset in webkit [132715] by
-
- 2 edits in trunk/Source/WebCore
Fix a operator ordering bug in SVGSMILElement::calculateAnimationPercentAndRepeat
https://bugs.webkit.org/show_bug.cgi?id=94756
Reviewed by Dirk Schulze.
The function has an early exit for !simpleDuration.value(), so
!simpleDuration.value() always is 0 when passed as second parameter to
fmod(), which means fmod() always returns NaN, which always evaluates
to true. Simplify the code by removing that explicit check.
No observable behavior change.
Covered by existing svg tests.
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
- 6:01 PM Changeset in webkit [132714] by
-
- 2 edits in trunk/Source/WebKit2
Crash in WebProces at WebCore::ResourceLoadScheduler::crossOriginRedirectReceived + 78
https://bugs.webkit.org/show_bug.cgi?id=100554
Reviewed by Alexey Proskuryakov.
For now, just have WebPlatformStrategies return the same default resourceLoadScheduler that
WebCore knows about.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::resourceLoadScheduler):
- 5:17 PM Changeset in webkit [132713] by
-
- 12 edits3 adds in trunk
Source/WebKit2: Crash when making NPRuntime calls with a null NPP pointer
https://bugs.webkit.org/show_bug.cgi?id=100569
<rdar://problem/11726426>
<rdar://problem/12352836>
Reviewed by Darin Adler.
Finally bite the bullet and remove the assertion from NetscapePlugin::fromNPP. The WebKit1 equivalent of this
function used to return the plug-in currently being initialized in NPP_New, but we've never done that in WebKit2
and it has never been necessary. The crashes fixed here are not from calls underneath NPP_New so fixing it wouldn't
do us any good anyway.
Also, make the PluginDestructionProtector handle a null plug-in gracefully.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::PluginDestructionProtector::PluginDestructionProtector):
(PluginDestructionProtector):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::fromNPP):
Tools: Crash when making NPRuntime calls with a null NPP pointer
https://bugs.webkit.org/show_bug.cgi?id=100569
Reviewed by Darin Adler.
Add new NPRuntimeCallsWithNullNPP plug-in test.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPN_ReleaseVariantValue):
(PluginTest::netscapeFuncs):
- DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
(PluginTest):
- DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp: Added.
(NPRuntimeCallsWithNullNPP):
(NPRuntimeCallsWithNullNPP::NPRuntimeCallsWithNullNPP):
(NPRuntimeCallsWithNullNPP::NPP_New):
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- GNUmakefile.am:
LayoutTests: Crash when making NPRuntime calls with a null NPP pointer
https://bugs.webkit.org/show_bug.cgi?id=100569
Reviewed by Darin Adler.
Add new tests.
- plugins/npruntime/npruntime-calls-with-null-npp-expected.txt: Added.
- plugins/npruntime/npruntime-calls-with-null-npp.html: Added.
- 4:55 PM Changeset in webkit [132712] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r132695.
http://trac.webkit.org/changeset/132695
https://bugs.webkit.org/show_bug.cgi?id=100581
caused 20+ test crashes on bots (Requested by estes on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::suspendPostAttachCallbacks):
(WebCore::ContainerNode::resumePostAttachCallbacks):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::loadNow):
- loader/ResourceLoadScheduler.cpp:
(WebCore::resourceLoadScheduler):
- loader/ResourceLoadScheduler.h:
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::willSendRequest):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::performPostLoadActions):
- 4:36 PM Changeset in webkit [132711] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r132689.
http://trac.webkit.org/changeset/132689
https://bugs.webkit.org/show_bug.cgi?id=100574
Broke HashMaps containing RetainPtrs (Requested by andersca on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- wtf/RetainPtr.h:
- 4:28 PM Changeset in webkit [132710] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r132702.
http://trac.webkit.org/changeset/132702
https://bugs.webkit.org/show_bug.cgi?id=100322
Compile error on Chromium Linux dbg builder (and others)
Source/WebCore:
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):
- svg/animation/SMILTime.h:
(WebCore::SMILTime::SMILTime):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::addBeginTime):
(WebCore::SVGSMILElement::addEndTime):
LayoutTests:
- svg/custom/elementTimeControl-nan-crash-expected.txt: Removed.
- svg/custom/elementTimeControl-nan-crash.html: Removed.
- 4:21 PM Changeset in webkit [132709] by
-
- 3 edits in trunk/Source/WebKit2
Add pids to WebMemorySampleFiles.
https://bugs.webkit.org/show_bug.cgi?id=100449.
Reviewed by Tim Horton.
Make it easier to associate WebMemorySamples with a process. Add the pid to the filename and header.
- Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::initializeTimers): Update notification.
(WebKit::WebMemorySampler::stop): Update notification.
(WebKit::WebMemorySampler::writeHeaders): dump pid in the header.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::processDidFinishLaunching): append pid to filename.
- 4:03 PM Changeset in webkit [132708] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Allow embedder to enter/leave force compositing mode
https://bugs.webkit.org/show_bug.cgi?id=100458
Patch by James Robinson <jamesr@chromium.org> on 2012-10-26
Reviewed by Adrienne Walker.
This adds API for the embedder to decide when to enter and leave force compositing mode since it's
more efficient to only toggle this setting when the embedder is about to produce a frame.
- public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::enterForceCompositingMode):
- src/WebFrameImpl.cpp:
(WebKit::WebViewImpl::enterForceCompositingMode):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
- 3:59 PM Changeset in webkit [132707] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, remove one more test that consistently passes according to the flakiness dashboard.
- platform/chromium/TestExpectations:
- 3:45 PM Changeset in webkit [132706] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2][AC] Build fix after r132647.
https://bugs.webkit.org/show_bug.cgi?id=100540
Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
AC enabled build is broken after the latest refactoring of EFL WK2.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::informLoadCommitted):
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::exitAcceleratedCompositingMode):
(EwkViewImpl::informContentsSizeChange):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
(EwkViewImpl::pageViewportControllerClient):
(EwkViewImpl::pageViewportController):
(EwkViewImpl::evasGl):
(EwkViewImpl::evasGlContext):
(EwkViewImpl::evasGlSurface):
(EwkViewImpl::resetEvasGlSurface):
- UIProcess/API/efl/ewk_view.cpp:
(mapToWebContent):
(_ewk_view_smart_calculate):
- 3:42 PM Changeset in webkit [132705] by
-
- 3 edits in trunk/LayoutTests
[chromium] Unreviewed, remove tests that consistently pass.
- platform/chromium-mac-mountainlion/TestExpectations: Some tests still need 10.8 baselines. Add them to this file.
- platform/chromium/TestExpectations:
- 3:36 PM Changeset in webkit [132704] by
-
- 8 edits in tags/Safari-537.16/Source/JavaScriptCore
Merged r132701.
- 3:31 PM Changeset in webkit [132703] by
-
- 8 edits in tags/Safari-537.16/Source/JavaScriptCore
Rollout r132674.
- 3:29 PM Changeset in webkit [132702] by
-
- 5 edits2 adds in trunk
Prevent NaN offset values in ElementTimeControl.
https://bugs.webkit.org/show_bug.cgi?id=100322
Reviewed by Abhishek Arya.
Source/WebCore:
NaN values can cause ElementTimeControl to go back in time!
If a value of NaN is passed to ElementTimeControl::beginElementAt(offset),
subsequent sorting will cause an assert in SVGSMILElement::findInstanceTime
because NaN values are not properly sorted. NaN SMILTime values
should not be allowed at all, so this patch adds a check for them in
ElementTimeControl's setters.
This patch also adds preventative asserts to catch if SMILTime is ever
initialized with NaN, or if addEndTime/addBeginTime are ever called
with NaN values.
Test: svg/custom/elementTimeControl-nan-crash.html
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):
- svg/animation/SMILTime.h:
(WebCore::SMILTime::SMILTime):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::addBeginTime):
(WebCore::SVGSMILElement::addEndTime):
LayoutTests:
- svg/custom/elementTimeControl-nan-crash-expected.txt: Added.
- svg/custom/elementTimeControl-nan-crash.html: Added.
- 3:18 PM Changeset in webkit [132701] by
-
- 8 edits in trunk/Source/JavaScriptCore
Forward OSR calculation is wrong in the presence of multiple SetLocals, or a mix of SetLocals and Phantoms
https://bugs.webkit.org/show_bug.cgi?id=100461
Reviewed by Oliver Hunt and Gavin Barraclough.
This does a couple of things. First, it removes the part of the change in r131822 that made the forward
OSR exit calculator capable of handling multiple SetLocals. That change was wrong, because it would
blindly assume that all SetLocals had the same ValueRecovery, and would ignore the possibility that if
there is no value recovery then a ForwardCheckStructure on the first SetLocal would not know how to
recover the state associated with the second SetLocal. Then, it introduces the invariant that any bytecode
op that decomposes into multiple SetLocals must first emit dead SetLocals as hints and then emit a second
set of SetLocals to actually do the setting of the locals. This means that if a ForwardCheckStructure (or
any other hoisted forward speculation) is inserted, it will always be inserted on the second set of
SetLocals (since hoisting only touches the live ones), at which point OSR will already know about the
mov hints implied by the first set of (dead) SetLocals. This gives us the behavior we wanted, namely, that
a ForwardCheckStructure applied to a variant set by a resolve_with_base-like operation can correctly do a
forward exit while also ensuring that prior to exiting we set the appropriate locals.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExit.h:
(OSRExit):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
- 2:59 PM Changeset in webkit [132700] by
-
- 57 edits in trunk
Move non-Settings Inspector methods from internals.settings to internals
https://bugs.webkit.org/show_bug.cgi?id=100392
Reviewed by Adam Barth.
Source/WebCore:
These methods don't have to do with the WebCore Settings object, so move them up to internals.
I moved the reset code from InternalSettings to Internals.
No new tests, this is just a rename. Existing tests should pass.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Remove inspector methods.
(WebCore::InternalSettings::Backup::restoreTo): Remove inspector methods.
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): New method for resetting page state. Named after similar
methods in WTR.
(WebCore::Internals::setInspectorResourcesDataSizeLimits): Moved from InspectorSettings.
(WebCore::Internals::setJavaScriptProfilingEnabled): Moved from InspectorSettings.
- testing/Internals.h:
- testing/Internals.idl:
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): Reset state in Internals.
- testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): Reset state in Internals.
LayoutTests:
Update tests to use internals.setJavaScriptProfilingEnabled instead of internals.settings.setJavaScriptProfilingEnabled.
Update tests to use internals.setInspectorResourcesDataSizeLimits instead of internals.settings.setInspectorResourcesDataSizeLimits.
- fast/profiler/anonymous-event-handler.html:
- fast/profiler/anonymous-function-called-from-different-contexts.html:
- fast/profiler/anonymous-function-calls-built-in-functions.html:
- fast/profiler/anonymous-function-calls-eval.html:
- fast/profiler/anonymous-functions-with-display-names.html:
- fast/profiler/apply.html:
- fast/profiler/built-in-function-calls-anonymous.html:
- fast/profiler/built-in-function-calls-user-defined-function.html:
- fast/profiler/call-register-leak.html:
- fast/profiler/call.html:
- fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
- fast/profiler/compare-multiple-profiles.html:
- fast/profiler/constructor.html:
- fast/profiler/dead-time.html:
- fast/profiler/document-dot-write.html:
- fast/profiler/event-handler.html:
- fast/profiler/execution-context-and-eval-on-same-line.html:
- fast/profiler/inline-event-handler.html:
- fast/profiler/many-calls-in-the-same-scope.html:
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
- fast/profiler/multiple-and-different-scoped-function-calls.html:
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html:
- fast/profiler/multiple-frames.html:
- fast/profiler/named-functions-with-display-names.html:
- fast/profiler/nested-anonymous-functon.html:
- fast/profiler/nested-start-and-stop-profiler.html:
- fast/profiler/no-execution-context.html:
- fast/profiler/one-execution-context.html:
- fast/profiler/profile-calls-in-included-file.html:
- fast/profiler/profile-with-no-title.html:
- fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
- fast/profiler/profiling-from-a-nested-location.html:
- fast/profiler/simple-event-call.html:
- fast/profiler/simple-no-level-change.html:
- fast/profiler/start-and-stop-profiler-multiple-times.html:
- fast/profiler/start-and-stop-profiling-in-the-same-function.html:
- fast/profiler/start-but-dont-stop-profiling.html:
- fast/profiler/stop-profiling-after-setTimeout.html:
- fast/profiler/stop-then-function-call.html:
- fast/profiler/two-execution-contexts.html:
- fast/profiler/user-defined-function-calls-built-in-functions.html:
- fast/profiler/window-dot-eval.html:
- http/tests/inspector/network-test.js:
(resetInspectorResourcesData):
- http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html:
- http/tests/inspector/network/network-content-replacement-embed.html:
- http/tests/inspector/network/network-content-replacement-xhr.html:
- inspector/profiler/cpu-profiler-profiling-without-inspector.html:
- 2:57 PM Changeset in webkit [132699] by
-
- 27 edits6 adds in trunk
AX: Notification should be sent when accessibilityIsIgnored changes
https://bugs.webkit.org/show_bug.cgi?id=99547
Reviewed by Chris Fleizach.
Source/WebCore:
Adds a new flag in AccessibilityObject that keeps track of the most recent
value of accessibilityIsIgnored(). After certain events such as an ARIA
attribute change or content change, checks the new value of
accessibilityIsIgnored() and posts a "children changed" notification on the
parent node if it changed, making sure the parent recomputes its vector of
(unignored) children.
Also moves handling of attribute changes to AXObjectCache, and sends
notifications for some attribute changes that were previously silent. On
Chromium, all changes to an accessibility object's attributes should
result in some notification.
Some tests would have broken because an AccessibilityScrollView was created
and holding a reference to a ScrollView for an iframe after it was deleted,
so this change switches AccessibilityScrollView to hold a weak reference
to ScrollView instead.
Tests: platform/chromium/accessibility/is-ignored-change-sends-notification.html
platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html
platform/chromium/accessibility/text-change-notification.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::textChanged):
(WebCore):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
(WebCore::AXObjectCache::recomputeIsIgnored):
- accessibility/AXObjectCache.h:
(AXObjectCache):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::textChanged):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::recomputeIsIgnored):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::insertChild):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::cachedIsIgnoredValue):
(WebCore):
(WebCore::AccessibilityObject::setCachedIsIgnoredValue):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::textChanged):
(AccessibilityObject):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
(WebCore::AccessibilityRenderObject::textChanged):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::addChildren):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::~AccessibilityScrollView):
(WebCore):
(WebCore::AccessibilityScrollView::detach):
(WebCore::AccessibilityScrollView::isAttachment):
(WebCore::AccessibilityScrollView::widgetForAttachmentView):
(WebCore::AccessibilityScrollView::updateScrollbars):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::elementRect):
(WebCore::AccessibilityScrollView::documentFrameView):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):
(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable):
(WebCore::AccessibilityScrollView::scrollTo):
- accessibility/AccessibilityScrollView.h:
(WebCore::AccessibilityScrollView::scrollView):
(AccessibilityScrollView):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
- accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createAndAppendRootInlineBox):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
- rendering/RenderText.cpp:
(WebCore::RenderText::setText):
Source/WebKit/chromium:
Adds new accessibility notifications.
- public/WebAccessibilityNotification.h:
- src/AssertMatchingEnums.cpp:
Tools:
Add additional accessibility notifications.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::postAccessibilityNotification):
LayoutTests:
Adds 3 new test to ensure:
- A "children changed" notification is fired on the parent object when an object that was previously ignored becomes unignored.
- A notification is sent when an element's text (incl. title or label) changes.
- A notification is sent when another ARIA attribute changes.
Modifies add-to-menu-list-crashes because it was too brittle; it was
referencing a stale object rather than retrieving its latest handle.
Modifies aria-checkbox-sends-notification to listen on the correct
object on all platforms.
Simplifies notification-listeners so it doesn't generate additional
notifications that are inconsistent between platforms now.
- accessibility/aria-checkbox-sends-notification.html:
- accessibility/notification-listeners.html:
- platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt:
- platform/chromium/accessibility/add-to-menu-list-crashes.html:
- platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt: Added.
- platform/chromium/accessibility/is-ignored-change-sends-notification.html: Added.
- platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt: Added.
- platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html: Added.
- platform/chromium/accessibility/text-change-notification-expected.txt: Added.
- platform/chromium/accessibility/text-change-notification.html: Added.
- 2:55 PM Changeset in webkit [132698] by
-
- 9 edits in trunk/Source/WebCore
[WebKitIDL] Optional dictionary types should have default values of empty dictionary
https://bugs.webkit.org/show_bug.cgi?id=100547
Reviewed by Adam Barth.
Per WebIDL, "Optional dictionary type arguments are always considered to have a default
value of an empty dictionary." WebKitIDL already supported this via the extended attribute
[Optional=DefaultIsUndefined] but make this the default for Dictionary.
Binding test expectations updated.
- Modules/filesystem/DirectoryEntry.h: Remove default parameters.
(DirectoryEntry):
- Modules/indexeddb/IDBDatabase.h: Remove overloads.
(IDBDatabase):
- Modules/indexeddb/IDBObjectStore.h: Remove overloads.
(IDBObjectStore):
- Modules/mediastream/RTCPeerConnection.idl: Remove DefaultIsUndefined annotations.
- bindings/scripts/CodeGeneratorJS.pm: Special case for Optional Dictionary.
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOptionsObject): Updated expectation - no early call.
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::optionsObjectCallback): Ditto.
- 2:41 PM Changeset in webkit [132697] by
-
- 8 edits in tags/Safari-537.16/Source/WebCore
Merged r132695. <rdar://problem/12575514>
- 2:36 PM Changeset in webkit [132696] by
-
- 12 edits6 adds21 deletes in trunk
Generated should not be supported for things with a shadow
https://bugs.webkit.org/show_bug.cgi?id=98836
Unreviewed rollout of rollout of http://trac.webkit.org/changeset/132269.
Initial rollout was speculative and was shown not to be related to crashes.
Change author: Elliott Sprehn <esprehn@chromium.org>
Source/WebCore:
As far as CSS is concerned inputs and things with shadow content inside
shouldn't support pseudo elements like :before, :after or :first-letter.
Neither Gecko or Presto supports it, and we only accidentally supported
it.
Until the spec tells us what to do we should disable support. This is
also neccesary because the new generated content implementation doesn't
support shadows.
Test: fast/forms/pseudo-elements.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderListBox.h:
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
LayoutTests:
Change all pseudos on <input> tests to be ref tests and clean up the tests.
They now make sure we don't support generated content on things with a shadow.
Also added another test for the other form control types to ensure they don't
support pseudos either.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.html: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.html: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html:
- fast/forms/pseudo-elements-expected.html: Added.
- fast/forms/pseudo-elements.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html:
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.html: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html:
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- 2:30 PM Changeset in webkit [132695] by
-
- 8 edits in trunk/Source/WebCore
Crash in WebProces at WebCore::ResourceLoadScheduler::crossOriginRedirectReceived + 78
<rdar://problem/12575514> and https://bugs.webkit.org/show_bug.cgi?id=100554
Reviewed by Alexey Proskuryakov.
This was fallout from http://trac.webkit.org/changeset/132501 where I missed some of the
spots that call resourceLoadScheduler().
As a result we were creating more than one ResourceLoadScheduler, allowing the host records
to get out of sync.
The fix that also results in less #ifdefs scattered throughout the code is to use a single
choke point for all ResourceLoadScheduler access.
No new tests
(No change of behavior for the default config, not testable at this time in the repro config)
Add a single choke point for accessing the correct ResourceLoadScheduler:
- loader/ResourceLoadScheduler.cpp:
(WebCore::defaultResourceLoadScheduler): New private function that keeps the singleton default ResourceLoadScheduler.
(WebCore::resourceLoadScheduler): Refactor this function to either ask the LoaderStrategy or call through to
Revert back to using that single choke point everywhere:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::suspendPostAttachCallbacks):
(WebCore::ContainerNode::resumePostAttachCallbacks):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::loadNow):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::willSendRequest):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::performPostLoadActions):
- 2:25 PM Changeset in webkit [132694] by
-
- 2 edits1 delete in trunk/LayoutTests
Remove Chromium specific expectations for video-media-source-add-and-remove-buffers.html
https://bugs.webkit.org/show_bug.cgi?id=100160
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-10-26
Reviewed by Adam Barth.
The common expectations just reflected a bug in Chromium. The bug has been fixed and the common expectations
have been updated to reflect the correct behavior.
- http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt:
- platform/chromium/http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt: Removed.
- 2:20 PM Changeset in webkit [132693] by
-
- 2 edits3 moves3 adds in trunk/PerformanceTests
Turn PageLoad tests into simple performancetests, commit #6
https://bugs.webkit.org/show_bug.cgi?id=99899
Reviewed by Ryosuke Niwa.
We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.
This is the #6 commit of the whole patch.
- PageLoad/svg/files/gearflowers.svg: Removed.
- PageLoad/svg/files/hereGear4.svg: Removed.
- PageLoad/svg/files/worldcup.svg: Removed.
- SVG/GearFlowers.html: Added.
- SVG/HereGear.html: Added.
- SVG/Worldcup.html: Added.
- SVG/resources/GearFlowers.svg: Copied from PerformanceTests/PageLoad/svg/files/gearflowers.svg.
- SVG/resources/HereGear.svg: Copied from PerformanceTests/PageLoad/svg/files/hereGear4.svg.
- SVG/resources/Worldcup.svg: Copied from PerformanceTests/PageLoad/svg/files/worldcup.svg.
- Skipped: Rename the files on the skipped list also.
- 2:16 PM Changeset in webkit [132692] by
-
- 4 edits in trunk/Source/WebCore
Try to fix the windows build
https://bugs.webkit.org/show_bug.cgi?id=100556
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-26
Reviewed by Eric Seidel.
Touch files by adding whitespace to try and make the windows
build bot regenerate files.
No new tests, just kick the bot.
- dom/DOMAllInOne.cpp:
- html/HTMLElementsAllInOne.cpp:
- html/shadow/TextControlInnerElements.cpp:
- 1:59 PM Changeset in webkit [132691] by
-
- 1 edit3 copies in branches/chromium/1271
Merge 132371 - Crash when trying to write exception message to null console
https://bugs.webkit.org/show_bug.cgi?id=99658
Patch by Toni Barzic <tbarzic@chromium.org> on 2012-10-24
Reviewed by Adam Barth.
Source/WebCore:
DOMWindow::console may return NULL, so we should do a NULL check before adding message to it.
This may happen e.g. if a worker throws an exception just as the document is being replaced in the view.
The exception task could be processes after current window in the frame changes, and console in the document window is nulled.
Test: fast/workers/worker-exception-during-navigation.html
- dom/Document.cpp:
(WebCore::Document::addMessage):
LayoutTests:
The test creates bunch of workers that throw an exception as soon as they are loaded and then tries to change the current document.
The test passes if there is no crash.
Unfortuantely, the test is inherently flaky and may produce some false positive results (but should never fail if there is no bug).
- fast/workers/resources/worker-exception.js: Added.
- fast/workers/worker-exception-during-navigation-expected.txt: Added.
- fast/workers/worker-exception-during-navigation.html: Added.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11320014
- 1:41 PM Changeset in webkit [132690] by
-
- 2 edits in trunk/Tools
Get rid of (<X%) failing output for old-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=100447
Reviewed by Jessie Berlin.
Not a particularly useful piece of information. It's pretty much never above 1%.
new-run-webkit-tests does not output this either.
- Scripts/old-run-webkit-tests:
(printResults):
- 1:36 PM Changeset in webkit [132689] by
-
- 2 edits in trunk/Source/WTF
Add an operator& to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=100549
Reviewed by Dan Bernstein.
This is useful for APIs that return references using out parameters.
- wtf/RetainPtr.h:
(WTF::RetainPtr::operator&):
- 1:12 PM Changeset in webkit [132688] by
-
- 4 edits in trunk
[BlackBerry] Platform Abstraction for WebKit Resource/Image Loading
https://bugs.webkit.org/show_bug.cgi?id=100518
PR 231732
Reviewed by Yong Li.
.:
Remove RESOURCE_PATH from webkit, this is now abstracted in our platform layer.
- Source/cmake/OptionsBlackBerry.cmake:
Source/WebCore:
Use the new resource/image loading abstraction ResourceStore.
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::Image::loadPlatformResource):
- 1:02 PM Changeset in webkit [132687] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry][FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
https://bugs.webkit.org/show_bug.cgi?id=100421
Reviewed by Yong Li.
Patch by Jacky Jiang <zhajiang@rim.com>.
PR: 231173
When leaving fullscreen, we need to suspend screen and backing store
updates before setting scroll position and changing transformation and
resume after they are done. In which way, we can get rid of a noticeable
glitch during the transition.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- 12:58 PM Changeset in webkit [132686] by
-
- 3 edits1 copy in trunk/Source/Platform
[chromium] Add additional memory management fields to WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=99703
Patch by Christopher Cameron <ccameron@chromium.org> on 2012-10-26
Reviewed by James Robinson.
Add new fields to WebGraphicsMemoryAllocation to allow for specifying
limits for when visible and not, and to allow for specifying priority
cutoffs (e.g, to allow specifying that backgrounded tabs should
retain only their visible textures).
Add sendManagedMemoryStatsCHROMIUM to WebGraphicsContext3D, and
add WebGraphicsManagedMemoryStats structure, to allow the GPU memory
manager to make more informed choices.
- chromium/public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::sendManagedMemoryStatsCHROMIUM):
- chromium/public/WebGraphicsMemoryAllocation.h:
(WebGraphicsMemoryAllocation):
(WebKit::WebGraphicsMemoryAllocation::WebGraphicsMemoryAllocation):
(WebKit):
(WebGraphicsManagedMemoryStats):
(WebKit::WebGraphicsManagedMemoryStats::WebGraphicsManagedMemoryStats):
- 12:57 PM Changeset in webkit [132685] by
-
- 3 edits3 adds in trunk
[CSS Exclusions] Block children have incorrect offset when shape-inside element lays out below other elements
https://bugs.webkit.org/show_bug.cgi?id=98189
Patch by Bear Travis <betravis@adobe.com> on 2012-10-26
Reviewed by Dirk Schulze.
Source/WebCore:
The initial code assumed that each block created a new layout state, such that
LayoutState::layoutOffset would be specific to each block child of a shape-inside.
Typically, however, block children of a shape-inside do not create a new layout state,
and therefore we use the current element's offset instead.
Test: fast/exclusions/shape-inside/shape-inside-subsequent-blocks.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Modified to use only logicalTop
rather than LayoutState::layoutOffset::width/height and logicalTop.
LayoutTests:
Test that block content in subsequent shape-insides lays out correctly. Introducing a script
that can eventually be used to simplify the rectangle cases.
- fast/exclusions/resources/simple-rectangle.js: Added.
(createRectangleTest): Generate a shape-inside rectangle test using the given parameters.
(createRectangleTestResult): Generate a shape-inside rectangle expected result using
the given parameters.
- fast/exclusions/shape-inside/shape-inside-subsequent-blocks-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-subsequent-blocks.html: Added.
- 12:28 PM Changeset in webkit [132684] by
-
- 9 edits in trunk/Source/WebCore
Remove setRenderStyle in favor of callbacks on HTMLOptionElement and HTMLOptGroupElement
https://bugs.webkit.org/show_bug.cgi?id=100397
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-26
Reviewed by Ojan Vafai.
Use Node custom callbacks to support the non-renderer style caching for option
and optgroup eliminating the need for setRenderStyle.
setRenderStyle only existed to support HTMLOptionElement and HTMLOptGroupElement
so they could store their RenderStyle even though they have no renderer. This
means all style setting went through the virtual call to setRenderStyle, and it
also hid the if statement protecting against null renderers meaning we end up
checking if the renderer is null repeatedly in recalcStyle. This refactor cleans
up recalcStyle to be more clear about what's going on.
No new tests needed, this is just a refactor.
- dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid):
(WebCore::Element::recalcStyle):
- dom/Node.cpp:
(WebCore::Node::createRenderer):
(WebCore::Node::setRenderStyle):
Removed this method because it was only here to support HTMLOptionElement
and HTMLOptGroupElement. Instead we can use node custom callbacks.
- dom/Node.h:
(WebCore::Node::nonRendererStyle): Renamed from nonRendererRenderStyle to match other style methods.
- dom/NodeRenderStyle.h:
(WebCore::Node::renderStyle):
- html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
(WebCore::HTMLOptGroupElement::attach): Reorder the logic to avoid calling styleForRenderer twice.
(WebCore::HTMLOptGroupElement::updateNonRenderStyle): Updates the cached non-renderer style.
(WebCore::HTMLOptGroupElement::nonRendererStyle):
(WebCore::HTMLOptGroupElement::customStyleForRenderer):
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement):
(WebCore::HTMLOptionElement::attach): Reorder the logic to avoid calling styleForRenderer twice.
(WebCore::HTMLOptionElement::updateNonRenderStyle): Updates the cached non-renderer style.
(WebCore::HTMLOptionElement::nonRendererStyle):
(WebCore::HTMLOptionElement::customStyleForRenderer):
(WebCore::HTMLOptionElement::didRecalcStyle): Requests the repaint of the select like setRenderStyle used to.
- html/HTMLOptionElement.h:
- 12:15 PM Changeset in webkit [132683] by
-
- 2 edits in trunk/Source/Platform
[chromium] Add implicit conversions between WebFloatPoint and gfx::PointF
https://bugs.webkit.org/show_bug.cgi?id=100435
Reviewed by James Robinson.
This is similar to other Web geometry types, but the WebFloatPoint is
missing it.
- chromium/public/WebFloatPoint.h:
(WebFloatPoint):
(WebKit::WebFloatPoint::WebFloatPoint):
(WebKit::WebFloatPoint::operator=):
(WebKit::WebFloatPoint::operator gfx::PointF):
- 12:06 PM Changeset in webkit [132682] by
-
- 3 edits2 adds in trunk
-webkit-clip-path property should just reference clipPath
https://bugs.webkit.org/show_bug.cgi?id=100531
Reviewed by Eric Seidel.
Source/WebCore:
The -webkit-clip-path property should just reference clipPath. Added a check for that.
Test: css3/masking/clip-path-reference-of-fake-clipPath.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
LayoutTests:
Check that anther SVG resource like mask can not be referenced as clipPath.
- css3/masking/clip-path-reference-of-fake-clipPath-expected.txt: Added.
- css3/masking/clip-path-reference-of-fake-clipPath.html: Added.
- 11:51 AM Changeset in webkit [132681] by
-
- 4 edits in trunk/Source/WebCore
Remove the circular reference between TextTrack and TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=100300
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-10-26
Reviewed by Eric Carlson.
Changed TextTrackCue.m_track to a normal pointer to break the circular
reference that was keeping both objects from ever getting deleted.
No new tests. This simply fixes a memory leak.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::~TextTrack):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::~TextTrackCue):
(WebCore::TextTrackCue::track):
(WebCore::TextTrackCue::setTrack):
- html/track/TextTrackCue.h:
(TextTrackCue):
- 11:47 AM Changeset in webkit [132680] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Breakpoints are not managed correctly when editing uiSourceCode that was bound to ScriptFile after JavaScriptSourceFrame creation.
https://bugs.webkit.org/show_bug.cgi?id=100535
Reviewed by Pavel Feldman.
Added SourceMappingChanged event to UISourceCode and made
JavaScriptSourceFrame update ScriptFile events listeners on it.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onSourceMappingChanged):
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.setSourceMapping):
- 11:44 AM Changeset in webkit [132679] by
-
- 3 edits in trunk/Tools
Build bot gives incorrect link to EWS build failure
https://bugs.webkit.org/show_bug.cgi?id=100436
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(MockCommitQueue.init):
(MockCommitQueue.command_failed): Return incremental failure_status_id
(CommitQueueTaskTest.test_red_tree_patch_rejection): Check failure_status_id
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._test_patch): Use the failure_status_id of test with patch when test without patch fails and test with patch has unexpected failures.
- 11:41 AM Changeset in webkit [132678] by
-
- 10 edits in trunk
webkitpy: Pass the `Listen' Apache directive from webkitpy, not the httpd.conf files.
https://bugs.webkit.org/show_bug.cgi?id=98602
Reviewed by Dirk Pranke.
Tools:
Unify all the different `Listen' directives present in the several
httpd.conf files we have in LayoutTests/http/conf. For one, we
were already passing `Listen 127.0.0.1:8000' via webkitpy before,
and opening the other ports from the conf files.
The configuration files differed mostly in the way they handled
IPV6 ports. Some of them did not listen to IPV6 ports because the
systems which used them sometimes did not have IPV6 support. The
`http_server_supports_ipv6' method has been added to Port to
address that. cygwin, on its turn, still seems to use Apache 1.3,
which does not support IPV6 at all; the newly-added method has a
special case for that. Plus, perform a socket.getaddrinfo() call
the same way Apache itself does so we are sure we only enable IPV6
when setting that up in the httpd server is not going to fail.
- Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.is_cygwin):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.baseline_version_dir):
(Port.to.start_websocket_server):
(Port.to):
(Port.to.http_server_supports_ipv6):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_http_server_supports_ipv6):
(PortTest.test_build_path):
- Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd):
(LayoutTestApacheHttpd.init):
LayoutTests:
- http/conf/apache2-debian-httpd.conf: Remove the `Listen'
directive and related comments, it is passed to httpd by webkitpy
now.
- http/conf/apache2-httpd.conf: Ditto.
- http/conf/cygwin-httpd.conf: Ditto.
- http/conf/fedora-httpd.conf: Ditto.
- 11:18 AM Changeset in webkit [132677] by
-
- 2 edits in trunk/Tools
Unreviewed. Update my IRC nickname to a registered one.
- Scripts/webkitpy/common/config/committers.py:
- 10:52 AM Changeset in webkit [132676] by
-
- 1 edit2 copies in branches/chromium/1271
Merge 131315 - Calling WebCore::SharedBuffer::append(data, 0) on a shared buffer when
its current position is at a segment boundary (4096) ends up adding an
unitialized segment (with uninitialized memory) to the SharedBuffer.
https://bugs.webkit.org/show_bug.cgi?id=99000
Reviewed by Adam Barth.
Source/WebCore:
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):
LayoutTests:
- mhtml/shared_buffer_bug-expected.txt: Added.
- mhtml/shared_buffer_bug.mht: Added.
TBR=jcivelli@chromium.org
Review URL: https://codereview.chromium.org/11316005
- 10:49 AM WebKit Team edited by
- (diff)
- 10:49 AM Changeset in webkit [132675] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r132644.
http://trac.webkit.org/changeset/132644
https://bugs.webkit.org/show_bug.cgi?id=100497
Causes webkit_unit_tests
MemoryInstrumentationTest.ImageObserver to fail.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):
- platform/network/ResourceRequestBase.h:
(ResourceRequestBase):
- platform/network/chromium/ResourceRequest.cpp:
- platform/network/chromium/ResourceRequest.h:
- 10:30 AM Changeset in webkit [132674] by
-
- 8 edits in tags/Safari-537.16/Source/JavaScriptCore
Merge fix for <rdar://problem/12551946>
- 10:30 AM Changeset in webkit [132673] by
-
- 12 edits8 copies2 moves2 adds2 deletes in trunk/LayoutTests
compositing/tiling/huge-layer* flakey
https://bugs.webkit.org/show_bug.cgi?id=48454
Reviewed by Dan Bernstein.
In r131009 I fixed layerTreeAsText() to not be flakey with tiled layers, by ensuring that
we flush layer state before dumping the layer tree. That makes these tests non-flakey. I was
also able to remove all the setTimeouts() from these tests.
The 'usingTiledLayer' property is only dumped on Mac, so made cross-platform results without
this flag, and added Mac-specific results with it.
Unskipped some tests on non-Mac platforms that should now pass.
- compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- compositing/tiling/huge-layer-add-remove-child-expected.txt:
- compositing/tiling/huge-layer-add-remove-child.html: Added.
- compositing/tiling/huge-layer-add-remove-child.html-disabled: Removed.
- compositing/tiling/huge-layer-expected.txt:
- compositing/tiling/huge-layer-img-expected.txt:
- compositing/tiling/huge-layer-img.html: Renamed from LayoutTests/compositing/tiling/huge-layer-img.html-disabled.
- compositing/tiling/huge-layer-resize-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-resize.html: Added.
- compositing/tiling/huge-layer-with-layer-children-resize.html-disabled: Removed.
- compositing/tiling/huge-layer-with-layer-children.html: Renamed from LayoutTests/compositing/tiling/huge-layer-with-layer-children.html-disabled.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt: Copied from LayoutTests/compositing/tiling/backface-preserve-3d-tiled-expected.txt.
- platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Copied from LayoutTests/compositing/tiling/crash-reparent-tiled-layer-expected.txt.
- platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-add-remove-child-expected.txt.
- platform/mac/compositing/tiling/huge-layer-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-expected.txt.
- platform/mac/compositing/tiling/huge-layer-img-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-img-expected.txt.
- platform/mac/compositing/tiling/huge-layer-resize-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-resize-expected.txt.
- platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children-expected.txt.
- platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt.
- platform/qt-5.0-wk2/TestExpectations:
- 10:30 AM Changeset in webkit [132672] by
-
- 2 edits in trunk/LayoutTests
[chromium] Enable fast/images/exif-orientation.html
https://bugs.webkit.org/show_bug.cgi?id=100534
Unreviewed, TestExpecations change.
The baselines for this test landed yesterday.
- platform/chromium/TestExpectations:
- 10:19 AM Changeset in webkit [132671] by
-
- 2 edits in trunk/Source/WebCore
[Qt] MiniBrowser segfaults on exit after using WebGL.
https://bugs.webkit.org/show_bug.cgi?id=100523
The display connection must not be closed before
destroying the offscreen window.
Therefore opening the connection is moved to the
getXWindow() function. And closing the connection
is being moved to the destructor of the offscreen window.
Reviewed by Kenneth Rohde Christiansen.
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(WebCore::OffScreenRootWindow::getXWindow):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::display):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
- 9:31 AM Changeset in webkit [132670] by
-
- 2 edits4 moves3 adds in trunk/PerformanceTests
Turn PageLoad tests into simple performancetests, commit #5
https://bugs.webkit.org/show_bug.cgi?id=99899
Reviewed by Ryosuke Niwa.
We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.
This is the #5 commit of the whole patch.
- PageLoad/svg/files/Harvey_Rayner.svg: Removed.
- PageLoad/svg/files/Sierpinski_carpet_6.svg: Removed.
- PageLoad/svg/files/mtsthelens.svg: Removed.
- PageLoad/svg/files/mtsthelens0.jpg: Removed.
- SVG/HarveyRayner.html: Added.
- SVG/MtSaintHelens.html: Added.
- SVG/SierpinskiCarpet.html: Added.
- SVG/resources/HarveyRayner.svg: Copied from PerformanceTests/PageLoad/svg/files/Harvey_Rayner.svg.
- SVG/resources/MtSaintHelens.svg: Copied from PerformanceTests/PageLoad/svg/files/mtsthelens.svg.
- SVG/resources/SierpinskiCarpet.svg: Copied from PerformanceTests/PageLoad/svg/files/Sierpinski_carpet_6.svg.
- SVG/resources/mtsthelens0.jpg: Copied from PerformanceTests/PageLoad/svg/files/mtsthelens0.jpg.
- Skipped: Rename the files on the skipped list also.
- 9:25 AM Changeset in webkit [132669] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Extending existing ThreadUnsafe singletons in webkit to
Generic ThreadUnsafe Singleton
https://bugs.webkit.org/show_bug.cgi?id=100529
Patch by Parth Patel <parpatel@rim.com> on 2012-10-26
Reviewed by Yong Li.
No new tests added as there was no behavioural change.
- platform/network/blackberry/NetworkManager.cpp:
(WebCore):
- platform/network/blackberry/NetworkManager.h:
(NetworkManager):
- 9:12 AM Changeset in webkit [132668] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Fix log-type icon alignment.
https://bugs.webkit.org/show_bug.cgi?id=100520
Reviewed by Yury Semikhatsky.
The icons are just a pixel or two off, and it's driving me nuts.
- inspector/front-end/inspector.css:
(.console-message::before, .console-user-command::before, #console-prompt::before, .console-group-title::before):
(.console-warning-level::before):
- 9:09 AM Changeset in webkit [132667] by
-
- 11 edits in trunk/Source/WebCore
Replaceable attributes should also have readonly
https://bugs.webkit.org/show_bug.cgi?id=91768
Reviewed by Adam Barth.
This updates the code generators for JSC and V8 to handle this case correctly.
- Modules/intents/DOMWindowIntents.idl:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
- 8:58 AM Changeset in webkit [132666] by
-
- 2 edits in trunk/Source/WebCore
Clear m_orientation in FrameData::clear() for skia
https://bugs.webkit.org/show_bug.cgi?id=100456
Reviewed by Stephen White.
clear() is only called by the FrameData destructor and for multi-image
images in BitmapImage::destroyDecodedData(). Multi-frame images don't
have exif data, so this patch should have no effect in practice. It
makes the skia code match the CG code in BitmapImageCG.cpp though.
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::FrameData::clear):
- 8:57 AM Changeset in webkit [132665] by
-
- 3 edits2 adds in trunk
Crash on loading SVG filter resource on HTML element
https://bugs.webkit.org/show_bug.cgi?id=100491
Reviewed by Dirk Schulze.
Source/WebCore:
Skip non-filter elements referenced via -webkit-filter.
Test: svg/filters/filter-reference-crash.html
- rendering/RenderLayerFilterInfo.cpp:
(WebCore::RenderLayerFilterInfo::updateReferenceFilterClients):
LayoutTests:
- svg/filters/filter-reference-crash-expected.txt: Added.
- svg/filters/filter-reference-crash.html: Added.
- 8:49 AM Changeset in webkit [132664] by
-
- 3 edits in trunk/Source/WebCore
Lots of time spent under DNSResolveQueue::platformProxyIsEnabledInSystemPreferences
https://bugs.webkit.org/show_bug.cgi?id=100514
Reviewed by Anders Carlsson.
DNSResolveQueue::platformProxyIsEnabledInSystemPreferences gets called for every link in
the document. The function is relatively slow.
This patch caches the result of the last check for 5 seconds. Based on code comments
prefetching is disabled with proxies due to regressing performance with some configurations.
Proxy status changes rarely and a slight reaction delay shoudn't cause practical problems.
- platform/network/DNSResolveQueue.cpp:
(WebCore::DNSResolveQueue::DNSResolveQueue):
Add constructor. Also fixes a bug, m_requestsInFlight was not initialized.
(WebCore):
(WebCore::DNSResolveQueue::isUsingProxy):
(WebCore::DNSResolveQueue::add):
(WebCore::DNSResolveQueue::fired):
- platform/network/DNSResolveQueue.h:
(DNSResolveQueue):
- 8:42 AM Changeset in webkit [132663] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r132662.
http://trac.webkit.org/changeset/132662
https://bugs.webkit.org/show_bug.cgi?id=100528
It is not necessary any more. (Requested by loislo on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- platform/qt/MemoryUsageSupportQt.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
(WebCore):
- 8:36 AM Changeset in webkit [132662] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for Qt builders.
- platform/qt/MemoryUsageSupportQt.cpp:
- 8:33 AM Changeset in webkit [132661] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r132658.
http://trac.webkit.org/changeset/132658
https://bugs.webkit.org/show_bug.cgi?id=100515
It broke the Qt build
- inspector/InspectorMemoryAgent.cpp:
(WebCore::addPlatformComponentsInfo):
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
- platform/MemoryUsageSupport.h:
(ComponentInfo):
(WebCore::MemoryUsageSupport::ComponentInfo::ComponentInfo):
(MemoryUsageSupport):
- platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
- platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryTypes):
- platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
- 8:21 AM Changeset in webkit [132660] by
-
- 37 deletes in trunk/LayoutTests/platform/qt-5.0-wk2
Unreviewed. Remove empty buggy directories.
- 8:13 AM Changeset in webkit [132659] by
-
- 27 edits in trunk/Source/WebCore
Web Inspector: Some context menu items are duplicated on Resources and Sources panels.
https://bugs.webkit.org/show_bug.cgi?id=100522
Reviewed by Pavel Feldman.
Method appendApplicableItems now receives event as a parameter.
HandlerRegistry now makes sure that it is not called more than once for certain context menu event.
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._emptyElementContextMenu):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._emptyElementContextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):
- inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.Placard.prototype._placardContextMenu):
- inspector/front-end/ConsoleView.js:
- inspector/front-end/ContextMenu.js:
(WebInspector.ContextMenu):
(WebInspector.ContextMenu.prototype.show):
(WebInspector.ContextMenu.prototype.appendApplicableItems):
(WebInspector.ContextMenu.Provider.prototype.appendApplicableItems):
- inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._contextMenu):
- inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._contextMenu):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._contextMenuEventFired.set get var):
- inspector/front-end/ElementsPanelDescriptor.js:
(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
- inspector/front-end/HandlerRegistry.js:
(WebInspector.HandlerRegistry.prototype.appendApplicableItems):
- inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._contextMenu):
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype.handleContextMenu):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._contextMenu):
- inspector/front-end/NetworkPanelDescriptor.js:
(WebInspector.NetworkPanelDescriptor.prototype.appendApplicableItems):
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype._contextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuFired):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IndexedDBTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FileSystemListTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IDBDatabaseTreeElement.prototype._handleContextMenuEvent):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.appendApplicableItems):
- inspector/front-end/ScriptsPanelDescriptor.js:
(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._contextMenu):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._emptyElementContextMenu):
(WebInspector.WatchExpressionTreeElement.prototype._contextMenu):
- 8:07 AM Changeset in webkit [132658] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: instrument chromium GlyphCache. It keeps ~2mb data on gmail.
https://bugs.webkit.org/show_bug.cgi?id=100515
Reviewed by Yury Semikhatsky.
I replaced old version with an abstract number with new one which precisely reports allocated SkGlyphCache objects and their sizes.
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::reportMemoryUsage):
- platform/MemoryUsageSupport.h:
(MemoryUsageSupport):
- platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
- platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryTypes):
- platform/chromium/MemoryUsageSupportChromium.cpp:
(reportMemoryUsage):
(WebCore::reportGlyphCache):
(WebCore):
(WebCore::MemoryUsageSupport::reportMemoryUsage):
- 7:58 AM Changeset in webkit [132657] by
-
- 6 edits2 deletes in trunk/Source/WebKit2
[EFL][WK2] Get rid of C'ism in text checker API
https://bugs.webkit.org/show_bug.cgi?id=100513
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
Make Ewk_Text_Checker a C++ class and move the
WebKitTextChecker code to this new class. This
gets rid of the C'ism in the text checker code
and make it consistent with other Ewk classes.
- PlatformEfl.cmake:
- UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::Ewk_Context):
- UIProcess/API/efl/ewk_settings.cpp:
(spellCheckingLanguagesSetUpdate):
(ewk_settings_continuous_spell_checking_enabled_set):
(ewk_settings_spell_checking_available_languages_get):
(ewk_settings_spell_checking_languages_get):
- UIProcess/API/efl/ewk_text_checker.cpp:
(ClientCallbacks):
(textCheckerEnchant):
(clientCallbacks):
(isContinuousSpellCheckingEnabled):
(setContinuousSpellCheckingEnabled):
(uniqueSpellDocumentTag):
(closeSpellDocumentWithTag):
(checkSpellingOfString):
(guessesForWord):
(learnWord):
(ignoreWord):
(Ewk_Text_Checker):
(Ewk_Text_Checker::availableSpellCheckingLanguages):
(Ewk_Text_Checker::updateSpellCheckingLanguages):
(Ewk_Text_Checker::loadedSpellCheckingLanguages):
(Ewk_Text_Checker::initialize):
- UIProcess/API/efl/ewk_text_checker_private.h:
(Ewk_Text_Checker):
- UIProcess/efl/WebKitTextChecker.cpp: Removed.
- UIProcess/efl/WebKitTextChecker.h: Removed.
- 7:58 AM Changeset in webkit [132656] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Build fix for r132650.
https://bugs.webkit.org/show_bug.cgi?id=100482
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::timeFormat):
- 7:49 AM Changeset in webkit [132655] by
-
- 2 edits in trunk/Source/WebCore
[v8] Memory instrumentation: don't count memory of WrapperTypeInfo
https://bugs.webkit.org/show_bug.cgi?id=100517
Reviewed by Alexander Pavlov.
- bindings/v8/V8PerIsolateData.cpp: when estimating bindings memory size skip
pointers to WrapperTypeInfo objects as they are static fields and belong to
the data segment.
(WTF):
- 7:43 AM Changeset in webkit [132654] by
-
- 6 edits in trunk/LayoutTests
[WK2] should enable two postredirect tests
https://bugs.webkit.org/show_bug.cgi?id=100508
Unreviewed gardening.
The EFL results for these tests seem to have been wrong from the beginning.
Update expected results, enable tests for WK2 (based on comment in
TestExpectations these were skipped because efl failed).
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-26
- platform/efl/http/tests/navigation/postredirect-basic-expected.png:
- platform/efl/http/tests/navigation/postredirect-basic-expected.txt:
- platform/efl/http/tests/navigation/postredirect-goback1-expected.png:
- platform/efl/http/tests/navigation/postredirect-goback1-expected.txt:
- platform/wk2/TestExpectations:
- 7:30 AM Changeset in webkit [132653] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] ASSERT currentThreadIsHoldingLock() failed in MarkedAllocator::allocateSlowCase()
https://bugs.webkit.org/show_bug.cgi?id=100504
Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-10-26
Reviewed by Yong Li.
PR #232038 The similar PR # 200724.
Reviewed internally by Petter Wang.
This issue is same as bug 95492, and this patch is same as its patch.
Hold the JSLock for the current thread before we call toRef to avoid
the ASSERT failure.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
- 7:26 AM Changeset in webkit [132652] by
-
- 1 copy in tags/Safari-537.16
New Tag.
- 7:25 AM Changeset in webkit [132651] by
-
- 1 delete in tags/Safari-537.16
Remove Tag.
- 7:22 AM Changeset in webkit [132650] by
-
- 10 edits in trunk/Source/WebCore
Refactor Localizer-related classes.
https://bugs.webkit.org/show_bug.cgi?id=100482
Reviewed by Kentaro Hara.
- Localizer has unused code Localizer should have function implementations only if they are used in multiple subclasses.
- Some Localizer subclasses hide Localizer data members
- Should use String::isNull to check initialization-or-not
No new tests. This should not change any behavior.
- platform/text/Localizer.h:
(Localizer):
- timeFormat, shortTimeFormat, and timeAMPMLabels should be pure virtual.
- Remove m_localizedDateFormatText, m_localizedShortTimeFormatText, and m_timeAMPMLabels
- platform/text/Localizer.cpp:
Remove implementations of timeFormat, shortTimeFormat, and timeAMPMLabels.
- platform/text/LocaleICU.h:
(LocaleICU): Introduce m_timeFormatWithSeconds and m_timeFormatWithoutSeconds.
- platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeDateTimeFormat):
Use new data members instead of Localizer data members.
(WebCore::LocaleICU::dateFormat): Use isNull.
- platform/text/LocaleNone.cpp:
(LocaleNone): Add timeFormat, shortTimeFormat, timeAMPMLabels
implementations, and m_timeAMPMLabels.
(WebCore::LocaleNone::timeFormat): Returns the HTML time format.
(WebCore::LocaleNone::shortTimeFormat): Returns the HTML time format.
(WebCore::LocaleNone::timeAMPMLabels): Returns "AM" and "PM".
- platform/text/LocaleWin.h:
(LocaleWin): Add m_timeFormatWithSeconds.
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::dateFormat): Use isNull.
(WebCore::LocaleWin::timeFormat): Use m_timeFormatWithSeconds.
- platform/text/mac/LocaleMac.h:
(LocaleMac): Rename m_localized*TimeFormatText to m_timeFormatWith*Seconds.
- platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::timeFormat): Follow the renaming.
(WebCore::LocaleMac::shortTimeFormat): Ditto.
- 7:19 AM Changeset in webkit [132649] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip a few tests which produce wrong pixel expectations.
- platform/efl/TestExpectations:
- 7:07 AM Changeset in webkit [132648] by
-
- 4 edits in trunk/Source/WebCore
Crash in PagePopupController by events after WebPagePopupImpl::closePopup
https://bugs.webkit.org/show_bug.cgi?id=100454
Reviewed by Hajime Morita.
No new tests. The bug is timing-dependent.
- page/DOMWindowPagePopup.cpp:
(WebCore::DOMWindowPagePopup::~DOMWindowPagePopup):
Calls clearPagePopupClient for the associalated PagePopupController object.
- page/PagePopupController.cpp:
(WebCore::PagePopupController::setValueAndClosePopup):
Do nothing if m_popupClient is 0.
(WebCore::PagePopupController::localizeNumberString): Ditto.
(WebCore::PagePopupController::clearPagePopupClient): Added.
- page/PagePopupController.h:
(PagePopupController): Declare clearPagePopupClient.
- 6:43 AM Changeset in webkit [132647] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Clean up construction/destruction code in Ewk_view
https://bugs.webkit.org/show_bug.cgi?id=100232
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
Simplified a lot of initialization and destruction code of Ewk_view and EwkViewImpl
put all the impl stuff to its constructor and destructor, also made EwkViewImpl member
variables private.
- UIProcess/API/efl/EwkViewImpl.cpp:
(pageViewMap):
(EwkViewImpl::addToPageViewMap):
(EwkViewImpl::removeFromPageViewMap):
(EwkViewImpl::viewFromPageViewMap):
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::~EwkViewImpl):
(EwkViewImpl::wkPage):
(EwkViewImpl::title):
(EwkViewImpl::setThemePath):
(EwkViewImpl::customTextEncodingName):
(EwkViewImpl::setCustomTextEncodingName):
(EwkViewImpl::informIconChange):
(EwkViewImpl::informWebProcessCrashed):
(EwkViewImpl::updateTextInputState):
(EwkViewImpl::informURLChange):
(EwkViewImpl::onFaviconChanged):
- UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
(EwkViewImpl::view):
(EwkViewImpl::page):
(EwkViewImpl::ewkContext):
(EwkViewImpl::backForwardList):
- UIProcess/API/efl/ewk_settings.cpp:
(Ewk_Settings::preferences):
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_on_show):
(_ewk_view_on_hide):
(_ewk_view_smart_add):
(_ewk_view_smart_del):
(_ewk_view_smart_calculate):
(_ewk_view_smart_color_set):
(createEwkViewSmartClass):
(createEwkView):
(ewk_view_base_add):
(ewk_view_smart_add):
(ewk_view_add_with_context):
(ewk_view_url_set):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_load_progress_get):
(ewk_view_scale_set):
(ewk_view_scale_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_back_forward_list_get):
(ewk_view_html_string_load):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
(ewk_view_text_matches_count):
(ewk_view_feed_touch_event):
(ewk_view_inspector_show):
(ewk_view_inspector_close):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):
- 6:32 AM Changeset in webkit [132646] by
-
- 1 edit1 add in trunk/LayoutTests
[EFL] Add custom expectation for test added in r131557.
- platform/efl/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
- 6:27 AM Changeset in webkit [132645] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Bring device geolocation and orientation emulation from behind the experiment
https://bugs.webkit.org/show_bug.cgi?id=100220
Reviewed by Yury Semikhatsky.
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SettingsScreen.js:
(WebInspector.UserAgentSettingsTab):
- 6:20 AM Changeset in webkit [132644] by
-
- 5 edits in trunk/Source/WebCore
Memory instrumentation: report memory occupied by ResourceRequest instead of its base ResourceRequestBase
https://bugs.webkit.org/show_bug.cgi?id=100497
Reviewed by Alexander Pavlov.
Added memory reporting method to Chromium implementation of ResourceRequest.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsageBase): Renamed reportMemoryUsage
on ResourceRequestBase to reportMemoryUsageBase and made it protected. I'd
rather make ResourceRequestBase::reportMemoryUsage virtual and override it
in the descendant but ResourceRequestBase doesn't have any virtual methods
and shouldn't be used directly (ResourceRequest should be used instead).
- platform/network/ResourceRequestBase.h:
(ResourceRequestBase):
- platform/network/chromium/ResourceRequest.cpp:
(WebCore::ResourceRequest::reportMemoryUsage):
(WebCore):
- platform/network/chromium/ResourceRequest.h:
(ResourceRequest):
- 6:17 AM Changeset in webkit [132643] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Initialize Ewk_Context class members in initialization list
https://bugs.webkit.org/show_bug.cgi?id=100503
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
Move Ewk_Context class members initialization from the
constructor body to the initialization list for
efficiency.
- UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::Ewk_Context):
- 6:14 AM Changeset in webkit [132642] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove the on-hover highlighting of console messages
https://bugs.webkit.org/show_bug.cgi?id=100511
Reviewed by Pavel Feldman.
This clashes with the hovered element highlight in console messages.
- inspector/front-end/inspector.css:
(ol.watch-expressions > li.hovered):
- 6:13 AM Changeset in webkit [132641] by
-
- 7 edits4 deletes in trunk
Unreviewed, rolling out r132612.
http://trac.webkit.org/changeset/132612
https://bugs.webkit.org/show_bug.cgi?id=100512
Crashes fast/events/tabindex-focus-blur-all.html in debug mode
(Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
Source/WebCore:
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
(WebCore::RenderTableCol::computePreferredLogicalWidths):
- rendering/RenderTableCol.h:
(RenderTableCol):
LayoutTests:
- fast/table/col-span-change-relayout-expected.txt: Removed.
- fast/table/col-span-change-relayout.html: Removed.
- fast/table/simplified-layout-table-expected.html: Removed.
- fast/table/simplified-layout-table.html: Removed.
- 5:55 AM Changeset in webkit [132640] by
-
- 4 edits in trunk/Source/WebKit2
LayerTreeCoordinator: Make sure that dependent layers are deleted before their directly composited image
https://bugs.webkit.org/show_bug.cgi?id=100495
Reviewed by Kenneth Rohde Christiansen.
Since r128980 layers removals are delayed until we flush the layer tree.
This causes a crash if such a layer had a directly composited image since
the image is now deleted while the layer is still active in the UI process
and tries to access a deleted backing store.
Fix it by delaying the directly composited image removal as well.
Fixes a crash in tst_QQuickWebView::basicRenderingSanity since showWebView is
called first and loads direct-image-compositing.html.
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer): Remove unused variable.
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- 5:55 AM Changeset in webkit [132639] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fast return upon setting the same dock side.
https://bugs.webkit.org/show_bug.cgi?id=100510
Reviewed by Vsevolod Vlasov.
Added fast return.
- inspector/front-end/DockController.js:
- 5:54 AM Changeset in webkit [132638] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Apple Win gardening.
- platform/win/TestExpectations: Skipping XHR timeout tests.
- 5:48 AM Changeset in webkit [132637] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
German de.po translation needs update
https://bugs.webkit.org/show_bug.cgi?id=91349
Patch by Christian Kirbach <Christian.Kirbach@gmail.com> on 2012-10-26
Rubber-stamped by Gustavo Noronha.
- de.po: updated with proof-read version.
- 5:48 AM Changeset in webkit [132636] by
-
- 8 edits in trunk
[Qt] Fix the LLInt build on Windows
https://bugs.webkit.org/show_bug.cgi?id=97648
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-26
Reviewed by Tor Arne Vestbø.
Source/JavaScriptCore:
The main change for the port on Windows is changing the way offsets are extracted
and the LLIntAssembly.h is generated to accomodate release and debug configurations.
Firstly the LLIntOffsetsExtractor binary is now built as-is (no DESTDIR set) and
placed into debug\LLIntOffsetsExtractor.exe and release\LLIntOffsetsExtractor.exe
on Windows debug_and_release builds. On other patforms it remainds in the regular
out directory.
Secondly the LLIntAssembly.h files must be different for different build types,
so the LLIntAssembly.h generator in DerivedSources.pri operates no on the extractor
binary files as input. Using a simple exists() check we verify the presence of either
a regular, a debug\LLIntOffsetsExtractor and a release\LLIntOffsetsExtractor binary
and process all of them. The resulting assembly files consequently end up in
generated\debug\LLIntAssembly.h and generated\release\LLIntAssembly.h.
In Target.pri we have to also make sure that those directories are in the include
path according to the release or debug configuration.
Lastly a small tweak - swapping WTF.pri and JSC.pri inclusions - in the
LLIntOffsetsExtractor build was needed to make sure that we include
JavaScriptCore/config.h instead of WTF/config.h, required to fix the
build issues originally pasted in bug #97648.
- DerivedSources.pri:
- JavaScriptCore.pro:
- LLIntOffsetsExtractor.pro:
- Target.pri:
Tools:
Added BIN_EXTENSION variable - similar to automake - that expands to .exe as suffix for
executable programs on Windows. Empty otherwise. Also added support for force_build_all
to allow overriding us disabling build_all for TEMPLATE = app.
- qmake/mkspecs/features/default_pre.prf:
- 5:40 AM Changeset in webkit [132635] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Removing bogus '#EOF\n' data in the listed PNG file that's
positioned after the IEND PNG chunk.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
- 5:38 AM Changeset in webkit [132634] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed trivial build fix: It's glXGetCurrentContext not glxGetCurrentContext :)
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
- 5:27 AM Changeset in webkit [132633] by
-
- 3 edits2 adds in trunk
Printing should use use high resolution images when available
https://bugs.webkit.org/show_bug.cgi?id=100488
Reviewed by Antti Koivisto.
The images loaded using -webkit-device-pixel-ratio depends on
the display type (deviceScaleFactor) and thus affects which
images are being used for printing. Printing should always
use the higher resolution images (aka 'retina' images).
Source/WebCore:
Test: fast/media/mq-pixel-ratio-print.html
- css/MediaQueryEvaluator.cpp:
(WebCore::device_pixel_ratioMediaFeatureEval):
LayoutTests:
Added a test testing -webkit-device-pixel-ratio media query
in conjuntion with 'print' media type.
- fast/media/mq-pixel-ratio-print-expected.txt: Added.
- fast/media/mq-pixel-ratio-print.html: Added.
- 5:25 AM Changeset in webkit [132632] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: NMI instrument InspectorResourceAgent. it caches resources for the front-end.
https://bugs.webkit.org/show_bug.cgi?id=100496
Reviewed by Yury Semikhatsky.
It is plain instrumentation for InspectorResourceAgent and NetworkResourceData which is used by the agent.
- dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
- dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryTypes):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::reportMemoryUsage):
(WebCore):
- inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
- inspector/NetworkResourcesData.cpp:
(WebCore::XHRReplayData::reportMemoryUsage):
(WebCore):
(WebCore::NetworkResourcesData::ResourceData::reportMemoryUsage):
(WebCore::NetworkResourcesData::reportMemoryUsage):
- inspector/NetworkResourcesData.h:
(XHRReplayData):
(ResourceData):
(NetworkResourcesData):
- 5:25 AM Changeset in webkit [132631] by
-
- 2 edits in trunk/LayoutTests
[EFL] ... And another pixel rebaseline after r131941 and r131991.
- platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.png:
- 5:24 AM Changeset in webkit [132630] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r132493.
http://trac.webkit.org/changeset/132493
https://bugs.webkit.org/show_bug.cgi?id=100509
It didn't fix the tests on the bot as we had hoped. (Requested
by drott on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError):
- 5:19 AM Changeset in webkit [132629] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Temporarily disable use of QXcbNativeInterface in GraphicsSurfaceGLX.
https://bugs.webkit.org/show_bug.cgi?id=100493
Once QXcbNativeInterface::nativeResourceForContext() can provide the
GLXContext for an existing QOpenGLContext, this patch shall be reverted.
Patch by Zeno Albisser <zeno@webkit.org> on 2012-10-26
Reviewed by Simon Hausmann.
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
- 5:19 AM Changeset in webkit [132628] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Remove QOpenGL specific code from GraphicsSurfaceGLX.
https://bugs.webkit.org/show_bug.cgi?id=100492
This patch removes most of the QOpenGLContext related code
from GraphicsSurfaceGLX. This allows sharing almost all
GraphicsSurfaceGLX code with EFL, by relying on pure GLX.
Patch by Zeno Albisser <zeno@webkit.org> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(GraphicsSurfacePrivate):
(WebCore::resolveGLMethods):
- 5:18 AM Changeset in webkit [132627] by
-
- 13 edits in trunk
[EFL][WK2] Enable WebGL
https://bugs.webkit.org/show_bug.cgi?id=97652
Patch by Regina Chung <heejin.r.chung@samsung.com> on 2012-10-26
Reviewed by Gyuyoung Kim.
.:
Use Graphics Surface to enable WebGL for WebKit2 EFL.
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
Implemented GraphicsSurface for EFL to enable WebGL for WebKit2.
Depends on GLX since Evas doesn't provide the necessary functionality.
No new tests. Covered by existing tests.
- PlatformEfl.cmake:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::createGraphicsSurfaces):
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::reshape):
- platform/graphics/surfaces/efl: Added.
- platform/graphics/surfaces/efl/GraphicsSurfaceEfl.cpp: Added.
(WebCore):
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.h: Added.
(WebCore):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::glxPixmap):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::glContext):
(WebCore::resolveGLMethods):
- platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore):
(WebCore::OffScreenRootWindow::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
Source/WebKit2:
Set WebGLEnabled to true when WebGL is enabled.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_initialize):
- 5:16 AM Changeset in webkit [132626] by
-
- 3 edits1 add in trunk/LayoutTests
Not reviewed: chromium baselines for selection-after-remove updated.
- platform/chromium-mac-lion/fast/repaint/selection-after-remove-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/selection-after-remove-expected.png:
- platform/chromium-win/fast/repaint/selection-after-remove-expected.png:
- 5:05 AM Changeset in webkit [132625] by
-
- 1 edit27 deletes in trunk/LayoutTests
Unreviewed, rolling out r132607.
http://trac.webkit.org/changeset/132607
https://bugs.webkit.org/show_bug.cgi?id=100502
"SOS! More wrong paths." (Requested by kbalazs on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-iframe-zIndex-expected.png: Removed.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-remove-ancestor-after-expected.png: Removed.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-stacking-context-expected.png: Removed.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-after-expected.png: Removed.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png/SVGLengthList-appendItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-basics-expected.png/SVGLengthList-basics-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-getItem-expected.png/SVGLengthList-getItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png/SVGLengthList-initialize-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png/SVGLengthList-insertItemBefore-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png/SVGLengthList-removeItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png/SVGLengthList-replaceItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png/SVGLengthList-xml-dom-modifications-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLocatable-getCTM-svg-root-expected.png/SVGLocatable-getCTM-svg-root-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGNumberList-basics-expected.png/SVGNumberList-basics-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png/SVGPathSegList-appendItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png/SVGPathSegList-clear-and-initialize-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png/SVGPathSegList-insertItemBefore-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png/SVGPathSegList-removeItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png/SVGPathSegList-replaceItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png/SVGPathSegList-xml-dom-synchronization-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPointList-basics-expected.png/SVGPointList-basics-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png/SVGStringList-basics-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGTransformList-basics-expected.png/SVGTransformList-basics-expected.png: Removed.
- platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png/feImage-animated-transform-on-target-rect-expected.png: Removed.
- platform/qt-5.0-wk2/svg/repaint/image-href-change-expected.png/image-href-change-expected.png: Removed.
- platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png/image-with-clip-path-expected.png: Removed.
- 4:58 AM Changeset in webkit [132624] by
-
- 1 edit74 deletes in trunk/LayoutTests
Unreviewed, rolling out r132604.
http://trac.webkit.org/changeset/132604
https://bugs.webkit.org/show_bug.cgi?id=100501
"SOS! Wrong paths." (Requested by kbalazs on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Removed.
- platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png: Removed.
- platform/qt-5.0-wk2/css3/flexbox/repaint-expected.png: Removed.
- platform/qt-5.0-wk2/css3/flexbox/repaint-rtl-column-expected.png: Removed.
- platform/qt-5.0-wk2/fast/borders/border-shadow-large-radius-expected.png: Removed.
- platform/qt-5.0-wk2/fast/borders/outline-alpha-block-expected.png: Removed.
- platform/qt-5.0-wk2/fast/borders/outline-alpha-inline-expected.png: Removed.
- platform/qt-5.0-wk2/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
- platform/qt-5.0-wk2/fast/box-shadow/no-blur-multiple-offsets-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-resize-reset-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/image-pattern-rotate-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/toDataURL-alpha-expected.png: Removed.
- platform/qt-5.0-wk2/fast/css/border-radius-non-negative-expected.png: Removed.
- platform/qt-5.0-wk2/fast/css/linear-gradient-currentcolor-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/file/file-input-pressed-state-expected.png/file-input-pressed-state-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png/css3-color-stop-units-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-color-stops-expected.png/css3-color-stops-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-linear-angle-gradients-expected.png/css3-linear-angle-gradients-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-linear-right-angle-gradients-expected.png/css3-linear-right-angle-gradients-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients-expected.png/css3-radial-gradients-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients2-expected.png/css3-radial-gradients2-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients3-expected.png/css3-radial-gradients3-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients-expected.png/css3-repeating-linear-gradients-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients2-expected.png/css3-repeating-linear-gradients2-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-radial-gradients-expected.png/css3-repeating-radial-gradients-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/gradient-after-transparent-border-expected.png/gradient-after-transparent-border-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/jpeg-with-color-profile-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/paint-subrect-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/paint-subrect-grid-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/png-with-color-profile-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Removed.
- platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png/scroll-with-transform-composited-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png/scroll-with-transform-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/absolute-position-changed-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-inner-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-outer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/overflow-show-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-clipped-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-transformed-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-inside-table-cell-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/replaced/outline-replaced-elements-expected.png: Removed.
- platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Removed.
- platform/qt-5.0-wk2/fast/table/table-row-focus-ring-paint-expected.png: Removed.
- 4:55 AM Changeset in webkit [132623] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: [Overrides] Do not persist the User Agent "master switch"
https://bugs.webkit.org/show_bug.cgi?id=100484
Reviewed by Yury Semikhatsky.
The User Agent override state is managed in the front-end, just like for other override-able parameters.
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::disable):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
- inspector/front-end/SettingsScreen.js:
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.set checkboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement):
- inspector/front-end/UserAgentSupport.js:
(WebInspector.UserAgentSupport):
(WebInspector.UserAgentSupport.prototype.toggleUserAgentOverride):
(WebInspector.UserAgentSupport.prototype._userAgentChanged):
- 4:53 AM Changeset in webkit [132622] by
-
- 11 edits1 add in trunk/LayoutTests
[EFL] More pixel rebaselines after r131941 and r131991.
- platform/efl/fast/backgrounds/solid-color-context-restore-expected.png:
- platform/efl/fast/dynamic/containing-block-change-expected.png:
- platform/efl/fast/forms/listbox-clip-expected.png:
- platform/efl/fast/frames/inline-object-inside-frameset-expected.png:
- platform/efl/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
- platform/efl/fast/layers/inline-dirty-z-order-lists-expected.png:
- platform/efl/fast/layers/layer-content-visibility-change-expected.png:
- platform/efl/fast/layers/remove-layer-with-nested-stacking-expected.png:
- platform/efl/fast/reflections/inline-crash-expected.png:
- platform/efl/fast/replaced/width100percent-textarea-expected.png:
- platform/efl/fast/text/font-initial-expected.png:
- 4:42 AM Changeset in webkit [132621] by
-
- 8 edits2 adds in trunk
[Shadow]: removing styles in shadow dom subtree causes crash.
https://bugs.webkit.org/show_bug.cgi?id=100455
Reviewed by Hajime Morita.
Source/WebCore:
To quickly check whether shadow roots or elements have any scoped
styles or not, elements have hasStyleScoped flag. If elements have
any scoped styles, the styles are direct children of the element.
The original code just sees how many chilren are scoped style or not.
However styles in shadow dom subtree are registered with the shadow
root but are not always direct children of shadow roots. So to check
whether shadow roots have any scoped styles, modified to count
number of styles registered with the shadow root.
Test: fast/dom/shadow/remove-styles-in-shadow-crash.html
- dom/Node.cpp:
(WebCore::Node::registerScopedHTMLStyleChild):
(WebCore::Node::unregisterScopedHTMLStyleChild):
Made the above two method virtual. class ShadowRoot overrides these
methods.
(WebCore::Node::numberOfScopedHTMLStyleChildren):
Moved HTMLStyleElement.cpp to Node.cpp, because the above two methods
are moved into Node.cpp.
- dom/Node.h:
(Node):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::registerScopedHTMLStyleChild):
(WebCore::ShadowRoot::unregisterScopedHTMLStyleChild):
Modify to count how many styles are registered with the shadow root.
The "counting" is done when styles are registered and unregistered
with the shadow root, i.e. style element is inserted into document or
removed from document. When unregister some style, there are no more
styles registered with the shadow root. Set style scoped flag false.
- dom/ShadowRoot.h:
(ShadowRoot):
- html/HTMLStyleElement.cpp:
- html/HTMLStyleElement.h:
(WebCore::HTMLStyleElement::isRegisteredAsScoped):
Now isRegisteredAsScoped is used in Node.cpp, so removed inline and
moved .cpp to .h.
LayoutTests:
- fast/dom/shadow/remove-styles-in-shadow-crash-expected.txt: Added.
- fast/dom/shadow/remove-styles-in-shadow-crash.html: Added.
- 4:40 AM Changeset in webkit [132620] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r132589.
http://trac.webkit.org/changeset/132589
https://bugs.webkit.org/show_bug.cgi?id=100498
Breaks font-face layout tests (Requested by pfeldman on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- 4:39 AM Changeset in webkit [132619] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=100481
Unreviewed EFL gardening.
Skip failing test and also unskip tests that are
consistently passing.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-26
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 4:33 AM Changeset in webkit [132618] by
-
- 15 edits2 adds in trunk
[Shadow DOM] Needs @host rule for ShadowDOM styling
https://bugs.webkit.org/show_bug.cgi?id=88606
Reviewed by Hajime Morita.
Source/WebCore:
Implemented @host-@rules according to the shadow dom spec:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#host-at-rule
The design doc is:
https://docs.google.com/document/d/1P2yorchF8lci2sccr-mVSRf2dtvjKeiuyQWzCB2bEA8/edit
Test: fast/dom/shadow/athost-atrules.html
- css/CSSGrammar.y.in:
Added rules for parsing @host @-rules.
- css/CSSParser.cpp:
(WebCore::CSSParser::detectAtToken):
Added a new token "@host".
(WebCore::CSSParser::createHostRule):
Added a new method to create an @host @-rule, which is invoked from
(WebCore):
- css/CSSParser.h:
Added a declaration of the above new method: createHostRule.
- css/CSSPropertySourceData.h:
Added HOST_RULE to enum Type.
- css/RuleSet.cpp:
(WebCore::RuleData::RuleData):
Modified multiple bool arguments into one argument. Now it
uses combinations of values from enum AddRuleFlags.
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addStyleRule):
Updated according to the RuleData's change.
Modified to Invoke increaseSpecificity if the given rule is @host
@-rule.
(WebCore::RuleSet::addRulesFromSheet):
Invoked addHostRule if the given rule is @host @-rule.
- css/RuleSet.h:
(RuleData):
(WebCore::RuleData::increaseSpecificity):
Added a new method to increase selector's specificity. This method is
used to make @host @-rules' specificity larger than normal author
rules' specificity.
(RuleSet):
- css/StyleResolver.cpp:
(WebCore::makeRuleSet):
(WebCore::StyleResolver::addHostRule):
A wrapper method to invoke StyleScopeResolver::addHostRule. The method
is used to make only StyleResolver know an implementation detail about
class StyleScopeResolver.
(WebCore::StyleResolver::appendAuthorStylesheets):
Updated according to the RuleData's change.
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
A new method to find matched host rules when an element is given.
This method invokes
StyleScopeResolver::styleSharingCandidateMatchesHostRules to find
matched host rules.
(WebCore):
(WebCore::StyleResolver::matchHostRules):
A new method to find matched host rules when an element is given.
This method invokes StyleScopeResolver::matchHostRules to find
matched host rules.
(WebCore::StyleResolver::matchScopedAuthorRules):
Modified to invoke matchHostRules.
(WebCore::StyleResolver::locateSharedStyle):
Disable sibling style cache if the given element is a shadow host and
any @host @-rules are applied to the element.
- css/StyleResolver.h:
(WebCore::StyleResolver::ensureScopeResolver):
If no scopeResolver is created, create and return the instance.
If created, just return the instance.
(StyleResolver):
- css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleHost::StyleRuleHost):
Implemented class StyleRuleHost. The class is almost the same as
StyleRuleBlock except type.
(WebCore):
- css/StyleRule.h:
(WebCore::StyleRuleBase::isHostRule):
(StyleRuleHost):
(WebCore::StyleRuleHost::create):
(WebCore::StyleRuleHost::copy):
(WebCore):
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::ensureAtHostRuleSetFor):
A new method to create a new RuleSet for the given shadow root.
(WebCore):
(WebCore::StyleScopeResolver::atHostRuleSetFor):
A new private inline method to obtain @host @-rules declared in
the given shadow root.
(WebCore::StyleScopeResolver::addHostRule):
Added a new method to register @host @-rules with shadow roots.
(WebCore::StyleScopeResolver::styleSharingCandidateMatchesHostRules):
A new method to find whether any @host @-rules are applied to
the given host element.
(WebCore::StyleScopeResolver::matchHostRules):
A new method to find matched rules for the given host element.
(WebCore::StyleScopeResolver::reportMemoryUsage):
- css/StyleScopeResolver.h:
(WebCore):
(StyleScopeResolver):
- css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):
LayoutTests:
- fast/dom/shadow/athost-atrules-expected.txt: Added.
- fast/dom/shadow/athost-atrules.html: Added.
- 4:32 AM Changeset in webkit [132617] by
-
- 9 edits4 adds in trunk/Source/WebKit2
[EFL][WK2] Add Ewk_Color_Picker API
https://bugs.webkit.org/show_bug.cgi?id=100472
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
Move the color picker code out of EwkViewImpl and into
a new Ewk_Color_Picker class to avoid cluttering the
view code.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::requestColorPicker):
(EwkViewImpl::dismissColorPicker):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
- UIProcess/API/efl/ewk_color_picker.cpp: Added.
(Ewk_Color_Picker::Ewk_Color_Picker):
(Ewk_Color_Picker::setColor):
(Ewk_Color_Picker::color):
(ewk_color_picker_color_set):
(ewk_color_picker_color_get):
- UIProcess/API/efl/ewk_color_picker.h: Added.
- UIProcess/API/efl/ewk_color_picker_private.h: Added.
(Ewk_Color_Picker):
(Ewk_Color_Picker::create):
- UIProcess/API/efl/ewk_view.cpp:
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_color_picker.cpp: Added.
(onColorPickerDone):
(setColorPickerColor):
(showColorPicker):
(hideColorPicker):
(hideColorPickerByRemovingElement):
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::showColorPicker):
- 4:26 AM Changeset in webkit [132616] by
-
- 2 edits in trunk/LayoutTests
[EFL] Fix test pixel expectation.
- platform/efl/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
- 4:21 AM Changeset in webkit [132615] by
-
- 4 edits in trunk/Source/WebKit/efl
[Texmap][EFL] Implementation of AC related functions in ChromeClientEfl and ewkView.
https://bugs.webkit.org/show_bug.cgi?id=82315
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
This patch implements accelerated-compositing-related functions
to enter accelerated-compositing mode and sync layers
in ChromeClientEfl and ewkView.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::attachRootGraphicsLayer):
(WebCore::ChromeClientEfl::setNeedsOneShotDrawingSynchronization):
(WebCore::ChromeClientEfl::scheduleCompositingLayerFlush):
(WebCore::ChromeClientEfl::allowedCompositingTriggers):
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(_ewk_view_accelerated_compositing_cb):
Sync and render layers.
(_ewk_view_accelerated_compositing_context_create_if_needed):
Create a new AcceleratedCompositingContext.
(ewk_view_accelerated_compositing_object_create):
Create a new evas_image_object act as render target surface.
(ewk_view_accelerated_compositing_context_get):
Return the GraphicsContext3D for accelerated compositing.
(ewk_view_root_graphics_layer_set):
Set the root layer to AcceleratedCompositingContext.
(ewk_view_mark_for_sync):
Mark the evas_image_object for accelerated compositing as dirty to make it update.
- ewk/ewk_view_private.h:
(WebCore):
- 4:21 AM Changeset in webkit [132614] by
-
- 1 edit80 adds in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed pixel gardening.
Added a bunch of pixel expectations for Qt-WebKit2 - part 5 (svg/dynamic-updates).
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png: Added.
- 4:17 AM Changeset in webkit [132613] by
-
- 2 edits in trunk/Source/WebCore
[CMAKE] Add TextAutosizer.cpp in WebCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=100476
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-26
Reviewed by Kentaro Hara.
ENABLE_TEXT_AUTOSIZING option is added in CMAKE,
but the source file for that feature is omitted.
No new tests. Covered by existing tests.
- CMakeLists.txt:
- 4:13 AM Changeset in webkit [132612] by
-
- 7 edits4 adds in trunk
RenderTableCol::computePreferredLogicalWidths and RenderTableCol::layout should never be called
https://bugs.webkit.org/show_bug.cgi?id=99861
Reviewed by Ojan Vafai.
Source/WebCore:
RenderTableCol's computePreferredLogicalWidths and layout's only purpose were to clear the preferred logical
widths dirty / layout flag so that we would properly propagate the information to our containing table. This
led to clunky code where the table layout code had to forcefully call RenderTableCol::computePreferredLogicalWidths
or else we would ignore the next layout hint on the <col> or <colgroup>.
Tests: fast/table/col-span-change-relayout.html
fast/table/simplified-layout-table.html
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
Simplified the code now that we only need to iterate over the sections.
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
Removed call to computePreferredLogicalWidths.
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
Forward a layout hint to the table so that we properly recompute the cell's logical withs.
(WebCore::RenderTableCol::computePreferredLogicalWidths):
(WebCore::RenderTableCol::layout):
Change our implementations of those 2 methods to be no-ops, while enforcing that they are
never called when it was possible.
(WebCore::RenderTableCol::propagateLayoutCueToTable):
New helper function that forward any layout cue to the containing table, this works around
us not clearing the flags which confuses RenderObject markContainingBlocksForLayout and
invalidateContainerPreferredLogicalWidths.
- rendering/RenderTableCol.h:
Made the function that we are not expected to be called private.
LayoutTests:
Added 2 tests:
- 1 to cover the code in RenderTableCol::updateFromElement.
- 1 to cover simplified layout on a table.
- fast/table/col-span-change-relayout-expected.txt: Added.
- fast/table/col-span-change-relayout.html: Added.
- fast/table/simplified-layout-table-expected.html: Added.
- fast/table/simplified-layout-table.html: Added.
- 4:08 AM Changeset in webkit [132611] by
-
- 1 edit100 adds in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed pixel gardening.
Added a bunch of pixel expectations for Qt-WebKit2 - part 4 (svg/dynamic-updates).
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.
- 4:07 AM Changeset in webkit [132610] by
-
- 1 edit2 adds in trunk/Tools
[BlackBerry] Support pixel tests for BlackBerry DRT
https://bugs.webkit.org/show_bug.cgi?id=100210
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-10-26
Reviewed by Rob Buis.
(The following 2 files are missed in previous patch(r132582), adding them
again.)
- DumpRenderTree/blackberry/build: Added.
- DumpRenderTree/blackberry/src.pro: Added.
Adds 2 files for building ImageDiff, by Christopher Wells.
- 4:01 AM FeatureFlags edited by
- (diff)
- 4:00 AM Changeset in webkit [132609] by
-
- 1 edit101 adds in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed pixel gardening.
Added a bunch of pixel expectations for Qt-WebKit2 - part 3 (svg/dynamic-updates).
- platform/qt-5.0-wk2/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png: Added.
- 4:00 AM AddingFeatures edited by
- (diff)
- 3:52 AM Changeset in webkit [132608] by
-
- 14 edits in trunk
Unreviewed, rolling out r132601.
http://trac.webkit.org/changeset/132601
https://bugs.webkit.org/show_bug.cgi?id=100494
It broke the Qt build (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
.:
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
- PlatformEfl.cmake:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::createGraphicsSurfaces):
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::reshape):
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(GraphicsSurfacePrivate):
(WebCore::resolveGLMethods):
Source/WebKit:
- PlatformEfl.cmake:
Source/WebKit2:
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_initialize):
- 3:51 AM Changeset in webkit [132607] by
-
- 1 edit53 adds in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed pixel gardening.
Added a bunch of pixel expectations for Qt-WebKit2 - part 1.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-stacking-context-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-after-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png/SVGLengthList-appendItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-basics-expected.png/SVGLengthList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-getItem-expected.png/SVGLengthList-getItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png/SVGLengthList-initialize-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png/SVGLengthList-insertItemBefore-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png/SVGLengthList-removeItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png/SVGLengthList-replaceItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png/SVGLengthList-xml-dom-modifications-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLocatable-getCTM-svg-root-expected.png/SVGLocatable-getCTM-svg-root-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGNumberList-basics-expected.png/SVGNumberList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png/SVGPathSegList-appendItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png/SVGPathSegList-clear-and-initialize-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png/SVGPathSegList-insertItemBefore-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png/SVGPathSegList-removeItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png/SVGPathSegList-replaceItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPointList-basics-expected.png/SVGPointList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png/SVGStringList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGTransformList-basics-expected.png/SVGTransformList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png/feImage-animated-transform-on-target-rect-expected.png: Added.
- platform/qt-5.0-wk2/svg/repaint/image-href-change-expected.png/image-href-change-expected.png: Added.
- platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png/image-with-clip-path-expected.png: Added.
- 3:50 AM Changeset in webkit [132606] by
-
- 6 edits in trunk/Source
[Qt] Enable JSC's disassembler on x86, x86_64 Linux
https://bugs.webkit.org/show_bug.cgi?id=100386
Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-10-26
Reviewed by Simon Hausmann.
It works fine on Linux x86, x86_64 just needs to be enabled in the
QtWebKit build system.
Source/JavaScriptCore:
- DerivedSources.pri:
- JavaScriptCore.pri:
- Target.pri:
Source/WTF:
- wtf/Platform.h:
- 3:50 AM Changeset in webkit [132605] by
-
- 2 edits in trunk/Source/WebCore
Memory instrumentation: do not report memory occupied by v8::String
https://bugs.webkit.org/show_bug.cgi?id=100487
Reviewed by Alexander Pavlov.
Pointers to v8::String are skipped when reporting memory usage of V8 bindings'
string cache.
- bindings/v8/V8Binding.cpp:
(WTF):
- 3:45 AM Changeset in webkit [132604] by
-
- 1 edit94 adds in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed pixel gardening.
Added a bunch of pixel expectations for Qt-WebKit2 - part 1.
- platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Added.
- platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png: Added.
- platform/qt-5.0-wk2/css3/flexbox/repaint-expected.png: Added.
- platform/qt-5.0-wk2/css3/flexbox/repaint-rtl-column-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/border-shadow-large-radius-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/outline-alpha-block-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/outline-alpha-inline-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-composite-transformclip-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-empty-image-pattern-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-resize-reset-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-transforms-during-path-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/image-pattern-rotate-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/toDataURL-alpha-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/border-radius-non-negative-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/linear-gradient-currentcolor-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/file/file-input-pressed-state-expected.png/file-input-pressed-state-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png/css3-color-stop-units-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-color-stops-expected.png/css3-color-stops-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-linear-angle-gradients-expected.png/css3-linear-angle-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-linear-right-angle-gradients-expected.png/css3-linear-right-angle-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients-expected.png/css3-radial-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients2-expected.png/css3-radial-gradients2-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients3-expected.png/css3-radial-gradients3-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients-expected.png/css3-repeating-linear-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients2-expected.png/css3-repeating-linear-gradients2-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-radial-gradients-expected.png/css3-repeating-radial-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/gradient-after-transparent-border-expected.png/gradient-after-transparent-border-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/jpeg-with-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/paint-subrect-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/paint-subrect-grid-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/png-with-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png/scroll-with-transform-composited-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png/scroll-with-transform-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/absolute-position-changed-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-show-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-inside-table-cell-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/replaced/outline-replaced-elements-expected.png: Added.
- platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/table-row-focus-ring-paint-expected.png: Added.
- 3:40 AM Changeset in webkit [132603] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening, skip a new failing test.
- platform/qt-5.0-wk2/TestExpectations:
- 3:31 AM Changeset in webkit [132602] by
-
- 6 edits36 adds in trunk
[CSSRegions] Add support for auto-height regions with region-breaks
https://bugs.webkit.org/show_bug.cgi?id=99952
Reviewed by David Hyatt.
Source/WebCore:
This patch takes region breaks into account when computing the height for auto logical height regions.
When a region break is encountered before/after an element from within a flow thread and we are in the layout
phase in which we lay out the flow threads in regions unconstrained, we use the region break to
compute the region override logical content height if the region break fits inside an auto logical height region.
A region break inside an auto logical height region determines the region override logical content height, taking
min/max height into account.
Tests: fast/regions/autoheight-allregions-nobreaks.html
fast/regions/autoheight-allregions.html
fast/regions/autoheight-breakafteralways-maxheight.html
fast/regions/autoheight-breakbeforealways.html
fast/regions/autoheight-firstregion-breakalways.html
fast/regions/autoheight-lastregion-overflowauto-breaksignored.html
fast/regions/autoheight-lastregion-overflowauto.html
fast/regions/autoheight-middleregion.html
fast/regions/autoheight-secondregion-breakoutside.html
fast/regions/autoheight-secondregion.html
fast/regions/autoheight-singleregion-breakafteralways-maxheight.html
fast/regions/autoheight-singleregion-breakafteralways.html
fast/regions/autoheight-singleregion-breakaftermargin.html
fast/regions/autoheight-singleregion-breakbeforealways-minheight.html
fast/regions/autoheight-singleregion-breakbeforealways.html
fast/regions/autoheight-singleregion-multiplebreaks.html
fast/regions/autoheight-singleregion-overflowauto-breaksignored.html
fast/regions/autoheight-singleregion-overflowauto.html
- rendering/RenderBlock.cpp: When encounter a region break before/after an element inside a flow thread,
try to use it to determine the override logical content height for auto logical height regions.
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
Simulate a region break at the end of the flow thread content.
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::clearOverrideLogicalContentHeightInRegions):
Helper method used to clear the overrideLogicalContentHeight for auto logical height regions.
(WebCore::RenderFlowThread::addForcedRegionBreak):
Extend the method to process region breaks. The method returns true if at least one auto logical height region
has its override logical content height computed.
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp: Make these methods work with auto logical height regions.
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
LayoutTests:
Add tests for auto logical height regions with content having region breaks.
- fast/regions/autoheight-allregions-expected.html: Added.
- fast/regions/autoheight-allregions-nobreaks-expected.html: Added.
- fast/regions/autoheight-allregions-nobreaks.html: Added.
- fast/regions/autoheight-allregions.html: Added.
- fast/regions/autoheight-breakafteralways-maxheight-expected.html: Added.
- fast/regions/autoheight-breakafteralways-maxheight.html: Added.
- fast/regions/autoheight-breakbeforealways-expected.html: Added.
- fast/regions/autoheight-breakbeforealways.html: Added.
- fast/regions/autoheight-firstregion-breakalways-expected.html: Added.
- fast/regions/autoheight-firstregion-breakalways.html: Added.
- fast/regions/autoheight-lastregion-overflowauto-breaksignored-expected.html: Added.
- fast/regions/autoheight-lastregion-overflowauto-breaksignored.html: Added.
- fast/regions/autoheight-lastregion-overflowauto-expected.html: Added.
- fast/regions/autoheight-lastregion-overflowauto.html: Added.
- fast/regions/autoheight-middleregion-expected.html: Added.
- fast/regions/autoheight-middleregion.html: Added.
- fast/regions/autoheight-secondregion-breakoutside-expected.html: Added.
- fast/regions/autoheight-secondregion-breakoutside.html: Added.
- fast/regions/autoheight-secondregion-expected.html: Added.
- fast/regions/autoheight-secondregion.html: Added.
- fast/regions/autoheight-singleregion-breakafteralways-expected.html: Added.
- fast/regions/autoheight-singleregion-breakafteralways-maxheight-expected.html: Added.
- fast/regions/autoheight-singleregion-breakafteralways-maxheight.html: Added.
- fast/regions/autoheight-singleregion-breakafteralways.html: Added.
- fast/regions/autoheight-singleregion-breakaftermargin-expected.html: Added.
- fast/regions/autoheight-singleregion-breakaftermargin.html: Added.
- fast/regions/autoheight-singleregion-breakbeforealways-expected.html: Added.
- fast/regions/autoheight-singleregion-breakbeforealways-minheight-expected.html: Added.
- fast/regions/autoheight-singleregion-breakbeforealways-minheight.html: Added.
- fast/regions/autoheight-singleregion-breakbeforealways.html: Added.
- fast/regions/autoheight-singleregion-multiplebreaks-expected.html: Added.
- fast/regions/autoheight-singleregion-multiplebreaks.html: Added.
- fast/regions/autoheight-singleregion-overflowauto-breaksignored-expected.html: Added.
- fast/regions/autoheight-singleregion-overflowauto-breaksignored.html: Added.
- fast/regions/autoheight-singleregion-overflowauto-expected.html: Added.
- fast/regions/autoheight-singleregion-overflowauto.html: Added.
- 3:22 AM Changeset in webkit [132601] by
-
- 13 edits in trunk
[EFL][WK2] Enable WebGL
https://bugs.webkit.org/show_bug.cgi?id=97652
Patch by Regina Chung <heejin.r.chung@samsung.com> on 2012-10-26
Reviewed by Gyuyoung Kim.
.:
Use Graphics Surface to enable WebGL for WebKit2 EFL.
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
Implemented GraphicsSurface for EFL to enable WebGL for WebKit2.
Depends on GLX since Evas doesn't provide the necessary functionality.
No new tests. Covered by existing tests.
- PlatformEfl.cmake:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::createGraphicsSurfaces):
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::reshape):
- platform/graphics/surfaces/efl: Added.
- platform/graphics/surfaces/efl/GraphicsSurfaceEfl.cpp: Added.
(WebCore):
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.h: Added.
(WebCore):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::glxPixmap):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::glContext):
(WebCore::resolveGLMethods):
- platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore):
(WebCore::OffScreenRootWindow::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
Source/WebKit2:
Set WebGLEnabled to true when WebGL is enabled.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_initialize):
- 3:20 AM Changeset in webkit [132600] by
-
- 18 edits in trunk
Add feature flags for CSS Device Adaptation
https://bugs.webkit.org/show_bug.cgi?id=95960
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- GNUmakefile.features.am:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 3:18 AM Changeset in webkit [132599] by
-
- 9 edits2 adds in trunk
fast/forms/file/input-file-write-files.html should cover correct setting value
https://bugs.webkit.org/show_bug.cgi?id=100085
Patch by Li Yin <li.yin@intel.com> on 2012-10-26
Reviewed by Kentaro Hara.
Source/WebCore:
From Spec: http://dev.w3.org/html5/spec/single-page.html#dom-input-value-filename
On setting, if the new value is the empty string, it must empty the list of selected
files; otherwise, it must throw an InvalidStateError exception.
Test: fast/forms/file/input-file-value.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue):
(WebCore):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLInputElement.idl:
LayoutTests:
The test input-file-value.html is split from input-file-write-test.html.
And add correct setting value for files attribute, verify the files attribute
is writable or not.
- fast/forms/file/input-file-value-expected.txt: Added.
- fast/forms/file/input-file-value.html: Added.
- fast/forms/file/input-file-write-files-expected.txt:
- fast/forms/file/input-file-write-files.html:
- 3:09 AM Changeset in webkit [132598] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening after bug 99824
https://bugs.webkit.org/show_bug.cgi?id=100469
Unreviewed, EFL gardening.
Unskip following 3 test cases after bug 99824 is resolved.
- fast/lists/w3-css3-list-styles-alphabetic.html
- fast/lists/w3-css3-list-styles-fallback-style.html
- fast/lists/w3-list-styles.html
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-26
- platform/efl-wk1/TestExpectations:
- 3:00 AM Changeset in webkit [132597] by
-
- 12 edits2 deletes in trunk/Tools
Unreviewed, rolling out r132552.
http://trac.webkit.org/changeset/132552
https://bugs.webkit.org/show_bug.cgi?id=100486
Makes typeahead tests crash in debug. (Requested by pfeldman
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/DRTTestRunner.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::doDragDrop):
(WebTestRunner::EventSender::updateClickCountForButton):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::handleMouseWheel):
(WebTestRunner::EventSender::gestureEvent):
(WebTestRunner::EventSender::gestureFlingCancel):
(WebTestRunner::EventSender::gestureFlingStart):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
(TestDelegate):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebKit):
(webkit_support):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestInterfaces::Internal):
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 2:56 AM Changeset in webkit [132596] by
-
- 2 edits in trunk/Source/WebCore
Refactor calendar picker to remove _x/_y from DaysTable
https://bugs.webkit.org/show_bug.cgi?id=100460
Reviewed by Kent Tamura.
_x/_y properties keep the coordinates for the selection but when we add
week and month picking capabilities, the selection can't be expressed as
a set of coordinates. This change will remove it.
No new tests. Covered by calendar-picker-*.html tests.
- Resources/pagepopups/calendarPicker.js:
(DaysTable): Removed _x/_y properties.
(DaysTable.prototype._hasSelection): Changed to refer to the DOM to see if we have a selection.
(DaysTable.prototype.navigateToMonthAndKeepSelectionPosition): Lookup the selection position.
(DaysTable.prototype.selectDate): Deselect first so we don't have two selections.
(DaysTable.prototype._selectRangeContainingNode): Selects date/week/month containing the given day node.
(DaysTable.prototype._selectRangeAtPosition): Selects date/week/month at the given position.
(DaysTable.prototype._firstNodeInSelectedRange): Returns first selected day node.
(DaysTable.prototype._deselect): Deselects all selections.
(DaysTable.prototype._handleMouseOver): Use _selectRangeContainingNode so we don't have many places handling the selection.
(DaysTable.prototype._handleMouseOut): Use _deselect.
(DaysTable.prototype._handleKey): Lookup the selection position.
(DaysTable.prototype.updateSelection): Use _selectRangeAtPosition.
- 2:40 AM Changeset in webkit [132595] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip svg/foreignObject/viewport-foreignobject-crash.html
https://bugs.webkit.org/show_bug.cgi?id=100467
Unreviewed, EFL gardening.
Removing a test failure expectations, the test was fixed in r132548.
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-26
- platform/efl-wk2/TestExpectations:
- 2:40 AM Changeset in webkit [132594] by
-
- 6 edits2 adds in trunk/Source/WebKit2
[EFL][WK2] Move input method code out of EwkViewImpl
https://bugs.webkit.org/show_bug.cgi?id=100468
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
Move input method code out of EwkViewImpl and into
a new InputMethodContextEfl class to avoid cluttering
the view code.
- PlatformEfl.cmake:
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::inputMethodContext):
- UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_key_down):
- UIProcess/efl/InputMethodContextEfl.cpp: Added.
(WebKit):
(WebKit::InputMethodContextEfl::InputMethodContextEfl):
(WebKit::InputMethodContextEfl::~InputMethodContextEfl):
(WebKit::InputMethodContextEfl::onIMFInputSequenceComplete):
(WebKit::InputMethodContextEfl::onIMFPreeditSequenceChanged):
(WebKit::InputMethodContextEfl::createIMFContext):
(WebKit::InputMethodContextEfl::handleMouseUpEvent):
(WebKit::InputMethodContextEfl::handleKeyDownEvent):
(WebKit::InputMethodContextEfl::updateTextInputState):
- UIProcess/efl/InputMethodContextEfl.h: Added.
(WebKit):
(InputMethodContextEfl):
(WebKit::InputMethodContextEfl::create):
- UIProcess/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::updateTextInputState):
- 2:39 AM Changeset in webkit [132593] by
-
- 3 edits in trunk/LayoutTests
[Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html fails every 3 days
https://bugs.webkit.org/show_bug.cgi?id=100480
Reviewed by Pavel Feldman.
Because the date field in the test has step=3, the availability of
[Today] button depends on the current date. We make the test stable by
specifying max attribute.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:
- 2:37 AM Changeset in webkit [132592] by
-
- 2 edits in trunk/Source/WebCore
FileReader abort case causes Chromium renderer crash
https://bugs.webkit.org/show_bug.cgi?id=99142
Patch by Ningxin Hu <ningxin.hu@intel.com> on 2012-10-26
Reviewed by Kentaro Hara.
Before dispatching load event, FileReader should check if it is
in aborting.
Test: manually launch fast/files/file-reader-abort.html in Chromium
browser and compare the result with
fast/files/file-reader-abort-expected.txt.
- fileapi/FileReader.cpp:
(WebCore::FileReader::didFinishLoading):
- 2:34 AM Changeset in webkit [132591] by
-
- 5 edits in trunk
Generate less repaint calls during subtree detaching
https://bugs.webkit.org/show_bug.cgi?id=99741
Reviewed by Eric Seidel.
Source/WebCore:
Following bug 98336, detach is now a subtree top-down operation. Because we
track visual overflow from our children during layout for most cases, we can
generate a repaint only on the subtree root.
On http://dglazkov.github.com/performance-tests/redraw.html, this ups the FPS to
26 fps from 22 fps on my MBP (+ 15%). On PerformanceTests/layout/subtree-detach.html,
it decreases the time by 35%. This is due to being the best case and we now generate
only one repaint per detach phase.
Covered by existing pixels tests (including but not limited to repaint ones).
- rendering/RenderObject.cpp:
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
Changed the function not to be recursive anymore to generate one painting for
our root only. Added a FIXME about using our RenderLayer for repainting to avoid
the cost of computing our absolute repaint rectangle.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
Removed the logic for repainting in the general case. However we still force a repaint
if we have a RenderLayer as we don't track their overflow in some cases (e.g. positioned
objects). This check is conservative and could be narrowed down (e.g overflow RenderLayers
are properly accounted for in our clipppedOverflowRectForRepaint).
LayoutTests:
- platform/chromium-linux/fast/repaint/selection-after-remove-expected.png:
Rebaselined this test after the change. It is progressing as we still properly repaint
the selection, but repaint less (ie don't repaint the top border which didn't change).
- 2:33 AM Changeset in webkit [132590] by
-
- 2 edits in trunk/Source/JavaScriptCore
[WIN] Make LLInt offsets extractor work on Windows
https://bugs.webkit.org/show_bug.cgi?id=100369
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
Open the input file explicitly in binary mode to prevent ruby/Windows from thinking that
it's a text mode file that needs even new line conversions. The binary mode parameter is
ignored on other platforms.
- offlineasm/offsets.rb:
- 2:09 AM Changeset in webkit [132589] by
-
- 2 edits in trunk/Source/WebCore
local(Helvetica) in src descriptor prevent fallback
https://bugs.webkit.org/show_bug.cgi?id=100446
Reviewed by Dan Bernstein.
FontCache::getCachedFontData() has a mechanism that aliases a few pairs
of font family names, so that if the family name specified in the font-family
property is not available on the system, but the its alias is available,
it will be used instead. This is appropriate for the font-family property,
but not for font family names specified in the local() function of the src
descriptor in a @font-face rule.
This patch disables the mechanism while checking src descriptor of @font-face.
No new tests. It's difficult to test the change because 'Helvetica' can
be mapped any other font. For example, chromium DRT uses FontConfig to
map Helvetica to Times New Roman. Other ports may map Helvetica to other
fonts. We can't define the expected result.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
Call fontCache()->getCachedFontData() with checkingAlternateName = true.
This disables aliasing font family names in FontCache.
- 2:06 AM Changeset in webkit [132588] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: Doctype Audits panel code
https://bugs.webkit.org/show_bug.cgi?id=100371
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-26
Reviewed by Alexander Pavlov.
This is a preparation step for ongoing refactoring.
It is much easier to read doctyped code.
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
Replaced "undefined" with "null"
- inspector/front-end/AuditsPanel.js:
(WebInspector.AuditCategory.prototype.callbackWrapper):
Removed callback parameter indirection.
(WebInspector.AuditRuleResult.prototype.addFormatted):
Converted private instance function to scoped function.
- 2:01 AM Changeset in webkit [132587] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update.
https://bugs.webkit.org/show_bug.cgi?id=100471
- platform/chromium/TestExpectations:
We should do rebaseline for time-suggestion-picker-*.html too.
- 1:39 AM Changeset in webkit [132586] by
-
- 4 edits in trunk
Disable ENABLE_INPUT_TYPE_WEEK on Chromium/Android
https://bugs.webkit.org/show_bug.cgi?id=100457
Reviewed by Kentaro Hara.
Source/WebKit/chromium:
It was enabled accidentally. Week input is not implemented in
Android.
- features.gypi: Remove ENABLE_INPUT_TYPE_WEEK=1 in the common block,
add ENABLE_INPUT_TYPE_WEEK=0 in Android block, and add
ENABLE_INPUT_TYPE_WEEK=1 in non-Android block.
LayoutTests:
- platform/chromium/TestExpectations:
Tests in fast/forms/week/ may fail on Android.
- 1:25 AM Changeset in webkit [132585] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: chromiuim expectations updated.
- platform/chromium/TestExpectations:
- 1:24 AM Changeset in webkit [132584] by
-
- 4 edits301 adds in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed pixel rebaseline.
Adding new expectations, mark failures.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/bgCompositeCopy-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize01-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize02-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize04-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize05-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize06-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize07-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize12-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize13-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize14-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize17-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize18-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize19-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize20-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize21-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize22-expected.png: Added.
- platform/qt-5.0-wk2/svg/css/arrow-with-shadow-expected.png: Added.
- platform/qt/TestExpectations:
- platform/qt/animations/state-at-end-event-expected.png: Added.
- platform/qt/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.png: Added.
- platform/qt/compositing/overflow/nested-scrolling-expected.png: Added.
- platform/qt/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor-expected.png: Added.
- platform/qt/compositing/overflow/remove-overflow-crash2-expected.png: Added.
- platform/qt/css2.1/t1004-c43-rpl-ibx-00-d-ag-expected.png: Added.
- platform/qt/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
- platform/qt/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
- platform/qt/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
- platform/qt/css2.1/t1202-counters-04-b-expected.png: Added.
- platform/qt/css2.1/t140201-c534-bgreps-00-c-ag-expected.png: Added.
- platform/qt/css2.1/t140201-c534-bgreps-01-c-ag-expected.png: Added.
- platform/qt/css2.1/t140201-c534-bgreps-02-c-ag-expected.png: Added.
- platform/qt/css2.1/t140201-c534-bgreps-03-c-ag-expected.png: Added.
- platform/qt/css2.1/t140201-c534-bgreps-04-c-ag-expected.png: Added.
- platform/qt/css2.1/t140201-c534-bgreps-05-c-ag-expected.png: Added.
- platform/qt/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
- platform/qt/css2.1/t1602-c43-center-00-d-ag-expected.png: Added.
- platform/qt/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
- platform/qt/css2.1/t1604-c542-letter-sp-01-b-a-expected.png: Added.
- platform/qt/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
- platform/qt/css3/flexbox/flexbox-baseline-expected.png: Added.
- platform/qt/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
- platform/qt/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
- platform/qt/fast/backgrounds/bgCompositeCopy-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize01-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize02-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize03-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize04-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize05-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize06-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize07-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize08-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize09-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize10-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize11-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize12-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize13-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize14-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize17-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize18-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize19-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize20-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize21-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize22-expected.png: Added.
- platform/qt/fast/block/float/009-expected.png: Added.
- platform/qt/fast/block/float/034-expected.png: Added.
- platform/qt/fast/block/float/4145535Crash-expected.png: Added.
- platform/qt/fast/block/float/negative-margin-clear-expected.png: Added.
- platform/qt/fast/block/float/nowrap-clear-min-width-expected.png: Added.
- platform/qt/fast/borders/border-image-scaled-gradient-expected.png: Added.
- platform/qt/fast/borders/border-radius-circle-expected.png: Added.
- platform/qt/fast/borders/border-radius-groove-01-expected.png: Added.
- platform/qt/fast/borders/border-radius-groove-02-expected.png: Added.
- platform/qt/fast/borders/border-radius-groove-03-expected.png: Added.
- platform/qt/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
- platform/qt/fast/borders/border-radius-wide-border-01-expected.png: Added.
- platform/qt/fast/borders/border-radius-wide-border-02-expected.png: Added.
- platform/qt/fast/borders/border-radius-wide-border-03-expected.png: Added.
- platform/qt/fast/borders/border-radius-wide-border-04-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDashed04-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDashed05-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDashed06-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDotted04-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDotted05-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDotted06-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDouble04-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDouble05-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDouble06-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDouble07-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDouble08-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDouble09-expected.png: Added.
- platform/qt/fast/borders/outline-offset-min-assert-expected.png: Added.
- platform/qt/fast/css/006-expected.png: Added.
- platform/qt/fast/css/background-clip-values-expected.png: Added.
- platform/qt/fast/css/bogus-color-span-expected.png: Added.
- platform/qt/fast/css/box-shadow-and-border-radius-expected.png:
- platform/qt/fast/css/content-dynamic-expected.png: Added.
- platform/qt/fast/css/contentDiv-expected.png: Added.
- platform/qt/fast/css/contentDivWithChildren-expected.png: Added.
- platform/qt/fast/css/contentImage-expected.png: Added.
- platform/qt/fast/css/pseudo-first-line-border-width-expected.png: Added.
- platform/qt/fast/css/replaced-element-implicit-size-expected.png: Added.
- platform/qt/fast/dom/attr_dead_doc-expected.png: Added.
- platform/qt/fast/dom/css-cached-import-rule-expected.png: Added.
- platform/qt/fast/dom/css-insert-import-rule-expected.png: Added.
- platform/qt/fast/dynamic/001-expected.png: Added.
- platform/qt/fast/dynamic/005-expected.png: Added.
- platform/qt/fast/dynamic/anonymous-block-layer-lost-expected.png: Added.
- platform/qt/fast/dynamic/staticY-expected.png: Added.
- platform/qt/fast/forms/002-expected.png: Added.
- platform/qt/fast/forms/003-expected.png: Added.
- platform/qt/fast/forms/004-expected.png: Added.
- platform/qt/fast/forms/005-expected.png: Added.
- platform/qt/fast/forms/006-expected.png: Added.
- platform/qt/fast/forms/007-expected.png: Added.
- platform/qt/fast/forms/HTMLOptionElement_label01-expected.png: Added.
- platform/qt/fast/forms/HTMLOptionElement_label02-expected.png: Added.
- platform/qt/fast/forms/HTMLOptionElement_label03-expected.png: Added.
- platform/qt/fast/forms/HTMLOptionElement_label04-expected.png: Added.
- platform/qt/fast/forms/button-submit-expected.png: Added.
- platform/qt/fast/forms/caret-rtl-expected.png: Added.
- platform/qt/fast/forms/control-clip-expected.png: Added.
- platform/qt/fast/forms/fieldset-with-float-expected.png: Added.
- platform/qt/fast/forms/form-added-to-table-expected.png: Added.
- platform/qt/fast/forms/form-in-malformed-markup-expected.png: Added.
- platform/qt/fast/forms/formmove-expected.png: Added.
- platform/qt/fast/forms/formmove2-expected.png: Added.
- platform/qt/fast/forms/image-border-expected.png: Added.
- platform/qt/fast/forms/indeterminate-expected.png: Added.
- platform/qt/fast/forms/input-align-image-expected.png: Added.
- platform/qt/fast/forms/input-first-letter-expected.png: Added.
- platform/qt/fast/forms/input-no-renderer-expected.png: Added.
- platform/qt/fast/forms/linebox-overflow-in-textarea-padding-expected.png: Added.
- platform/qt/fast/forms/menulist-deselect-update-expected.png: Added.
- platform/qt/fast/forms/menulist-no-overflow-expected.png: Added.
- platform/qt/fast/forms/option-index-expected.png: Added.
- platform/qt/fast/forms/option-script-expected.png: Added.
- platform/qt/fast/forms/option-text-clip-expected.png: Added.
- platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
- platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.png: Added.
- platform/qt/fast/forms/select-align-expected.png: Added.
- platform/qt/fast/forms/select-change-listbox-to-popup-expected.png: Added.
- platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.png: Added.
- platform/qt/fast/forms/select-disabled-appearance-expected.png: Added.
- platform/qt/fast/forms/select-display-none-style-resolve-expected.png: Added.
- platform/qt/fast/forms/select-empty-option-height-expected.png: Added.
- platform/qt/fast/forms/select-selected-expected.png: Added.
- platform/qt/fast/forms/select-size-expected.png: Added.
- platform/qt/fast/forms/select-style-expected.png: Added.
- platform/qt/fast/forms/stuff-on-my-optgroup-expected.png: Added.
- platform/qt/fast/forms/textfield-overflow-by-value-update-expected.png: Added.
- platform/qt/fast/frames/002-expected.png: Added.
- platform/qt/fast/frames/calculate-round-expected.png: Added.
- platform/qt/fast/frames/content-opacity-1-expected.png: Added.
- platform/qt/fast/frames/content-opacity-2-expected.png: Added.
- platform/qt/fast/frames/empty-cols-attribute-expected.png: Added.
- platform/qt/fast/frames/empty-frame-src-expected.png: Added.
- platform/qt/fast/frames/frame-length-fractional-expected.png: Added.
- platform/qt/fast/frames/frame-set-whitespace-attributes-expected.png: Added.
- platform/qt/fast/frames/iframe-text-contents-expected.png: Added.
- platform/qt/fast/frames/no-frame-borders-expected.png: Added.
- platform/qt/fast/gradients/border-image-gradient-expected.png: Added.
- platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
- platform/qt/fast/images/embed-image-expected.png: Added.
- platform/qt/fast/images/favicon-as-image-expected.png: Added.
- platform/qt/fast/images/image-css3-content-data-expected.png: Added.
- platform/qt/fast/images/object-image-expected.png: Added.
- platform/qt/fast/images/pdf-as-image-expected.png: Added.
- platform/qt/fast/inline-block/004-expected.png: Added.
- platform/qt/fast/inline-block/005-expected.png: Added.
- platform/qt/fast/invalid/015-expected.png: Added.
- platform/qt/fast/invalid/table-residual-style-crash-expected.png: Added.
- platform/qt/fast/js/exception-linenums-in-html-3-expected.png: Added.
- platform/qt/fast/js/missing-style-end-tag-js-expected.png: Added.
- platform/qt/fast/js/missing-title-end-tag-js-expected.png: Added.
- platform/qt/fast/layers/opacity-stacking-expected.png: Added.
- platform/qt/fast/layers/positioned-inside-root-with-margins-expected.png: Added.
- platform/qt/fast/layers/zindex-ridonkulous-expected.png: Added.
- platform/qt/fast/media/implicit-media-all-expected.png: Added.
- platform/qt/fast/media/media-query-invalid-value-expected.png: Added.
- platform/qt/fast/media/monochrome-expected.png: Added.
- platform/qt/fast/media/mq-min-pixel-ratio-expected.png: Added.
- platform/qt/fast/overflow/position-relative-expected.png: Added.
- platform/qt/fast/overflow/unreachable-content-test-expected.png: Added.
- platform/qt/fast/parser/comment-in-script-expected.png: Added.
- platform/qt/fast/parser/style-script-head-test-expected.png: Added.
- platform/qt/fast/reflections/table-cell-expected.png: Added.
- platform/qt/fast/repaint/background-generated-expected.png: Added.
- platform/qt/fast/repaint/background-misaligned-expected.png: Added.
- platform/qt/fast/repaint/canvas-putImageData-expected.png: Added.
- platform/qt/fast/repaint/erase-overflow-expected.png: Added.
- platform/qt/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
- platform/qt/fast/repaint/float-new-in-block-expected.png: Added.
- platform/qt/fast/repaint/inline-block-resize-expected.png: Added.
- platform/qt/fast/repaint/intermediate-layout-position-clip-expected.png: Added.
- platform/qt/fast/repaint/intermediate-layout-position-expected.png: Added.
- platform/qt/fast/repaint/layer-full-repaint-expected.png: Added.
- platform/qt/fast/repaint/table-col-background-expected.png: Added.
- platform/qt/fast/repaint/table-outer-border-expected.png: Added.
- platform/qt/fast/repaint/table-row-expected.png: Added.
- platform/qt/fast/repaint/table-section-overflow-expected.png: Added.
- platform/qt/fast/replaced/008-expected.png: Added.
- platform/qt/fast/replaced/image-tag-expected.png: Added.
- platform/qt/fast/replaced/selection-rect-expected.png: Added.
- platform/qt/fast/table/008-expected.png: Added.
- platform/qt/fast/table/024-expected.png: Added.
- platform/qt/fast/table/031-expected.png: Added.
- platform/qt/fast/table/caption-relayout-expected.png: Added.
- platform/qt/fast/table/colspanMinWidth-vertical-expected.png: Added.
- platform/qt/fast/table/div-as-col-span-expected.png: Added.
- platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.png: Added.
- platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png: Added.
- platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.png: Added.
- platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.png: Added.
- platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.png: Added.
- platform/qt/fast/table/fixed-table-with-small-percent-width-expected.png: Added.
- platform/qt/fast/table/giantRowspan-expected.png: Added.
- platform/qt/fast/table/growCellForImageQuirk-expected.png: Added.
- platform/qt/fast/table/percent-widths-stretch-expected.png: Added.
- platform/qt/fast/table/vertical-align-baseline-readjust-expected.png: Added.
- platform/qt/fast/text/align-center-rtl-spill-expected.png: Added.
- platform/qt/fast/text/basic/013-expected.png: Added.
- platform/qt/fast/text/basic/015-expected.png: Added.
- platform/qt/fast/text/line-breaks-expected.png: Added.
- platform/qt/fast/text/soft-hyphen-3-expected.png: Added.
- platform/qt/fast/text/stripNullFromText-expected.png: Added.
- platform/qt/fast/text/whitespace/017-expected.png: Added.
- platform/qt/fast/tokenizer/missing-style-end-tag-1-expected.png: Added.
- platform/qt/fast/tokenizer/missing-style-end-tag-2-expected.png: Added.
- platform/qt/fast/tokenizer/script-after-frameset-expected.png: Added.
- platform/qt/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Added.
- platform/qt/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
- platform/qt/svg/as-background-image/svg-as-background-1-expected.png: Added.
- platform/qt/svg/as-background-image/svg-as-background-2-expected.png: Added.
- platform/qt/svg/as-background-image/svg-as-background-3-expected.png: Added.
- platform/qt/svg/as-background-image/svg-as-background-6-expected.png: Added.
- platform/qt/svg/as-background-image/svg-as-background-expected.png: Added.
- platform/qt/svg/as-background-image/svg-as-tiled-background-expected.png: Added.
- platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.png: Added.
- platform/qt/svg/as-image/svg-as-image-expected.png: Added.
- platform/qt/svg/as-image/svg-as-relative-image-expected.png: Added.
- platform/qt/svg/css/arrow-with-shadow-expected.png: Added.
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.png: Added.
- platform/qt/svg/css/path-with-shadow-expected.png: Added.
- platform/qt/svg/css/shadow-and-opacity-expected.png: Added.
- platform/qt/svg/css/shadow-with-large-radius-expected.png: Added.
- platform/qt/svg/css/shadow-with-negative-offset-expected.png: Added.
- platform/qt/svg/custom/animation-currentColor-expected.png: Added.
- platform/qt/svg/custom/clip-path-id-changes-expected.png: Added.
- platform/qt/svg/custom/createImageElement-expected.png: Added.
- platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
- platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
- platform/qt/svg/custom/js-update-image-and-display-expected.png: Added.
- platform/qt/svg/custom/js-update-image-and-display2-expected.png: Added.
- platform/qt/svg/custom/js-update-image-and-display3-expected.png: Added.
- platform/qt/svg/custom/marker-opacity-expected.png: Added.
- platform/qt/svg/custom/marker-referencePoint-expected.png: Added.
- platform/qt/svg/custom/marker-strokeWidth-changes-expected.png: Added.
- platform/qt/svg/custom/mask-on-multiple-objects-expected.png: Added.
- platform/qt/svg/custom/mask-with-default-value-expected.png: Added.
- platform/qt/svg/custom/outer-svg-unknown-feature-expected.png: Added.
- platform/qt/svg/custom/pan-direction-expected.png: Added.
- platform/qt/svg/custom/pattern-excessive-malloc-expected.png: Added.
- platform/qt/svg/custom/repaint-shadow-expected.png: Added.
- platform/qt/svg/custom/transformedMaskFails-expected.png: Added.
- platform/qt/svg/custom/use-inherit-style-expected.png: Added.
- platform/qt/svg/custom/xhtml-no-svg-renderer-expected.png: Added.
- platform/qt/svg/filters/feGaussianBlur-expected.png: Added.
- platform/qt/svg/filters/feLighting-crash-expected.png: Added.
- platform/qt/svg/filters/feMerge-expected.png: Added.
- platform/qt/svg/filters/feMerge-wrong-input-expected.png: Added.
- platform/qt/svg/filters/feOffset-expected.png: Added.
- platform/qt/svg/filters/feTile-expected.png: Added.
- platform/qt/svg/filters/filter-clip-expected.png: Added.
- platform/qt/svg/filters/filter-rounding-issues-expected.png: Added.
- platform/qt/svg/filters/shadow-on-filter-expected.png: Added.
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/qt/svg/filters/subRegion-in-userSpace-expected.png: Added.
- platform/qt/svg/hixie/error/006-expected.png: Added.
- platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug120107-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug1271-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug12908-2-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug12910-2-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug131020-2-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug13169-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug137388-3-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug1818-3-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug1818-6-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug196870-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug222336-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug222467-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug269566-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug277062-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug28933-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug2954-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug50695-2-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug56201-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug8032-2-expected.png: Added.
- platform/qt/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Added.
- platform/qt/transitions/opacity-transition-zindex-expected.png: Added.
- platform/qt/transitions/transition-end-event-rendering-expected.png: Added.
- 1:24 AM Changeset in webkit [132583] by
-
- 2 edits in trunk/Source/WebCore
[Qt]REGRESSION(r131428): cookies.db created on wrong place
https://bugs.webkit.org/show_bug.cgi?id=99445
Patch by János Badics <János Badics> on 2012-10-26
Reviewed by Simon Hausmann.
Added a slash to the path of cookies.db in CookieJarQt.cpp.
- platform/qt/CookieJarQt.cpp:
(WebCore::SharedCookieJarQt::SharedCookieJarQt):
- 1:11 AM Changeset in webkit [132582] by
-
- 9 edits in trunk
[BlackBerry] Support pixel tests for BlackBerry DRT
https://bugs.webkit.org/show_bug.cgi?id=100210
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-10-26
Reviewed by Rob Buis.
Source/WebKit:
Adds a step to build ImageDiff from Qt for DRT. Most of the works are
accomplished by Christopher Wells.
- PlatformBlackBerry.cmake:
Tools:
The implementation is based on the patch from Christopher Wells.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
(BlackBerry::WebKit::DumpRenderTree::runTest):
(BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::DumpRenderTree::runTests):
(BlackBerry::WebKit::DumpRenderTree::dump):
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(DumpRenderTree):
- DumpRenderTree/blackberry/PNGImageEncoder.cpp:
(BGRAtoRGBA):
(encodeBitmapToPNG):
- DumpRenderTree/blackberry/PNGImageEncoder.h:
The changes to PNGImageEncoder files are from master_40, patched by Tyler
Abbott and Rob Buis.
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
(createBitmapContextFromWebView):
(computeMD5HashStringForBitmapContext):
(printPNG):
(dumpBitmap):
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
(BitmapContext::createByAdoptingData):
(BitmapContext::~BitmapContext):
(BitmapContext):
(BitmapContext::BitmapContext):
- DumpRenderTree/blackberry/build: Added.
- DumpRenderTree/blackberry/src.pro: Added.
Adds 2 files for building ImageDiff, by Christopher Wells.
- 1:10 AM Changeset in webkit [132581] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. This ASSERT is no longer correct (and fires on many tests.)
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
- 12:51 AM Changeset in webkit [132580] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: chromiuim expectations updated.
- platform/chromium/TestExpectations:
- 12:43 AM Changeset in webkit [132579] by
-
- 12 edits in trunk
[Chromium-Win] Support shortTimeFormat
https://bugs.webkit.org/show_bug.cgi?id=100471
Reviewed by Kentaro Hara.
Source/WebCore:
No new tests. Covered by fast/forms/time-multiple-fields/ and
WebKit/chromium/tests/LocaleWinTest.
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::shortTimeFormat):
Gets a format by LOCALE_SSHORTTIME. If it fails, remove "<delimiter>ss"
from the format by LOCALE_STIMEFORMAT.
- platform/text/LocaleWin.h:
(LocaleWin): Declare m_timeFormatWithoutSeconds.
Source/WebKit/chromium:
- tests/LocaleWinTest.cpp:
(TEST_F): Update test expectations for the behavior change.
LayoutTests:
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
- platform/chromium/TestExpectations:
- 12:35 AM Changeset in webkit [132578] by
-
- 2 edits in trunk/Source/WebKit2
Implement {get,set}FloatValueForKey
https://bugs.webkit.org/show_bug.cgi?id=100452
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-26
Reviewed by Anders Carlsson.
Implement missing functions in WebPreferencesStore.
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::setFloatValueForKey):
(WebKit):
(WebKit::WebPreferencesStore::getFloatValueForKey):
- 12:32 AM Changeset in webkit [132577] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Skip a new failing test introduced in r132554 that fails on 32 bit platforms.
Remove another one that does not exists already.
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-26
- platform/qt/TestExpectations:
- 12:15 AM Changeset in webkit [132576] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed. Update run-bindings-tests results after recent active DOM
object changes.
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::constructorCallback):
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::wrap):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::wrap):
- 12:07 AM Changeset in webkit [132575] by
-
- 2 edits in trunk/Source/WebCore
[V8] REGRESSION(132540) Assertion failure on V8DOMWrapper::setJSWrapperForDOMNode()
https://bugs.webkit.org/show_bug.cgi?id=100462
Patch by MORITA Hajime <morrita@google.com> on 2012-10-26
Reviewed by Adam Barth.
Removed the no longer correct assertion statement.
No new tests. Covered by breaking tests.
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
